Janne Hyvärinen [Wed, 24 Apr 2013 22:58:08 +0000 (08:58 +1000)]
Metaflac UTF-8 fixes (Windows)
Metaflac can now print all console supported characters from tags on the
screen. It also fixes metaflac to be able to import its own exports back
without non-ascii characters getting mutilated. And --no-utf8-convert
now works properly with import and export commands.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Martijn van Beurden [Sun, 21 Apr 2013 21:12:16 +0000 (23:12 +0200)]
Reduce valgrind num-callers to 50
My Valgrind doesn't run, saying it doesn't support showing more
than 50 entries of a stack trace
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Martijn van Beurden [Sun, 21 Apr 2013 20:05:26 +0000 (22:05 +0200)]
Fixes setting test level and valgrind testing
This should enable using the disable-thorough-tests,
enable-exhaustive-tests and enable-valgrind-testing
configure switches, because setting these didn't do
anything
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Janne Hyvärinen [Sun, 21 Apr 2013 11:02:48 +0000 (14:02 +0300)]
Fix status print staying on the wrong line with certain filename length.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Erik de Castro Lopo [Sun, 21 Apr 2013 09:51:47 +0000 (19:51 +1000)]
Fix compile when compiling with FLAC__INTEGER_ONLY_LIBRARY.
Problem reported by Martijn van Beurden <mvanb1@gmail.com>.
Erik de Castro Lopo [Sun, 21 Apr 2013 09:31:54 +0000 (19:31 +1000)]
Fix -Wshadow warnings when compiling with mingw-gcc.
Erik de Castro Lopo [Sun, 21 Apr 2013 08:05:21 +0000 (18:05 +1000)]
Metaflac hex dump UTF-8 and locale fix.
Change metaflac hexdump function so utf-8 decoding is only used for
filename printing and changed hex output printing to not rely only
on isprint. That function seems to return true for tabulator
control character under Windows when application isn't using C-locale.
Patch (with one minor tweak) from Janne Hyvärinen <cse@sci.fi>.
Janne Hyvärinen [Sat, 20 Apr 2013 09:42:24 +0000 (12:42 +0300)]
Windows utf8 utime fix.
UTF-8 version of utime was completely broken and file timestamps were
not preserved.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Erik de Castro Lopo [Sun, 21 Apr 2013 07:53:02 +0000 (17:53 +1000)]
Win utf8 treatment for CreateFile.
Patch from Janne Hyvärinen <cse@sci.fi>.
Cristian Rodríguez [Thu, 18 Apr 2013 17:13:48 +0000 (14:13 -0300)]
Ensure AM_LDFLAGS is used consistently
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Erik de Castro Lopo [Sun, 21 Apr 2013 07:19:37 +0000 (17:19 +1000)]
Fix compiler warnings related to win utf8 stuff.
Erik de Castro Lopo [Sun, 21 Apr 2013 06:16:44 +0000 (16:16 +1000)]
A set of windows utf8 patches fromJanne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Sun, 7 Apr 2013 10:21:24 +0000 (20:21 +1000)]
src/libFLAC/include/private/macros.h : Add default MIN/MAX macros.
Erik de Castro Lopo [Sun, 7 Apr 2013 10:15:09 +0000 (20:15 +1000)]
src/libFLAC/include/private/macros.h : Check GNUC version for MIN macro.
Erik de Castro Lopo [Sun, 7 Apr 2013 08:41:14 +0000 (18:41 +1000)]
include/share/compat.h : Include cleanup.
Patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Sun, 7 Apr 2013 08:40:34 +0000 (18:40 +1000)]
doc/html/changelog.html : Updates.
Erik de Castro Lopo [Sun, 7 Apr 2013 08:12:30 +0000 (18:12 +1000)]
Fix Windows SIZE_T_MAX definition.
Problem reported by Ulrich Klauer <ulrich@chirlu.de>.
Patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Sun, 7 Apr 2013 07:48:06 +0000 (17:48 +1000)]
src/share/Makefile.am : Rejig building of win_utf8_io/libwin_utf8_io.la.
This should avoid a build error on Mac OSX where it the Mac build
tools refused to build an empty library. Problem reported by
Michael Guntsche <michael.guntsche@it-loops.com>.
Erik de Castro Lopo [Sun, 7 Apr 2013 03:44:33 +0000 (13:44 +1000)]
Fix a bunch of compiler warnings (mainly MinGW).
Erik de Castro Lopo [Sun, 7 Apr 2013 03:11:19 +0000 (13:11 +1000)]
For windows, make UTF-8 mode into a runtime choice.
The smaller patch makes the utf-8 library use ANSI codepage by
default. When frontends call the "get_utf8_argv" function it
changes Unicode conversion codepage from ANSI to UTF-8.
Patch from Janne Hyvärinen <cse@sci.fi>.
Ulrich Klauer [Sat, 6 Apr 2013 19:28:25 +0000 (21:28 +0200)]
Only link against libogg (and libm) if needed
Most of the programs don't use libogg or libm directly and should not
link to them (overlinking).
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Ulrich Klauer [Sat, 6 Apr 2013 18:41:12 +0000 (20:41 +0200)]
Fix pkg-config files to avoid overlinking
Libraries that are used internally by libFLAC(++) but are not part of
their API should be listed in pkg-config "private" clauses. Otherwise
executables that are linked dynamically against libFLAC(++) will have
unneeded direct dependencies (overlinking).
Based on a patch by Brad Smith from
https://sourceforge.net/p/flac/bugs/397/
that I updated to only include ogg if libFLAC is actually built with
ogg support.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Erik de Castro Lopo [Sat, 6 Apr 2013 09:18:03 +0000 (20:18 +1100)]
m4/ogg.m4 : Grab latest version from libogg-1.3.0.
Erik de Castro Lopo [Fri, 5 Apr 2013 09:21:22 +0000 (20:21 +1100)]
Rename all parameters and locals from 'index' to 'indx'.
Erik de Castro Lopo [Tue, 2 Apr 2013 09:45:54 +0000 (20:45 +1100)]
flac*.pc : Add -logg if configured with Ogg support.
Erik de Castro Lopo [Tue, 2 Apr 2013 09:30:55 +0000 (20:30 +1100)]
flactimer patches from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Tue, 2 Apr 2013 09:24:37 +0000 (20:24 +1100)]
flac_mac safe string patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Tue, 2 Apr 2013 09:22:15 +0000 (20:22 +1100)]
metaflac typo patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Tue, 2 Apr 2013 06:53:12 +0000 (17:53 +1100)]
autogen.sh : Test for required programs.
Erik de Castro Lopo [Mon, 1 Apr 2013 19:37:08 +0000 (06:37 +1100)]
flac_mac patches from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Mon, 1 Apr 2013 19:35:35 +0000 (06:35 +1100)]
Another windows utf8 I/O patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Mon, 1 Apr 2013 19:33:09 +0000 (06:33 +1100)]
MSVC version patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Mon, 1 Apr 2013 19:27:07 +0000 (06:27 +1100)]
Two small patches for utf8 I/O.
Thanks to LRN <lrn1986@gmail.com>.
Erik de Castro Lopo [Mon, 1 Apr 2013 19:05:47 +0000 (06:05 +1100)]
include/share/Makefile.am : Add win_utf8_io.h.
Erik de Castro Lopo [Mon, 1 Apr 2013 11:00:59 +0000 (22:00 +1100)]
Purge more strcpy/strcat usage.
Erik de Castro Lopo [Mon, 1 Apr 2013 09:49:41 +0000 (20:49 +1100)]
configure.ac : Version 1.3.0pre3.
Erik de Castro Lopo [Mon, 1 Apr 2013 09:01:37 +0000 (20:01 +1100)]
Purge FLAC__STRINGS_IN_UTF8 from VC project files.
Erik de Castro Lopo [Mon, 1 Apr 2013 08:57:13 +0000 (19:57 +1100)]
Enable utf8 I/O stuff when compiling with MinGW.
Erik de Castro Lopo [Mon, 1 Apr 2013 06:44:42 +0000 (17:44 +1100)]
Use recursive automake in src/share/ part of tree.
This will make it easier to incorporate the win_utf8_io stuff.
Erik de Castro Lopo [Sat, 23 Mar 2013 11:24:47 +0000 (22:24 +1100)]
Add CLEANFILES to relevant Makefile.am to force removal of Windows EXEs.
This ensures they are removed even we've cross-compiled from Linux
to Windows and then configured for Linux. We don't want the Windows
EXEs to be run after configuring for Linux.
Erik de Castro Lopo [Sat, 23 Mar 2013 11:13:47 +0000 (22:13 +1100)]
include/share/compat.h : Cleanup.
Erik de Castro Lopo [Fri, 22 Mar 2013 07:22:57 +0000 (18:22 +1100)]
Rename _flac_stat to flac_stat_s.
Erik de Castro Lopo [Fri, 22 Mar 2013 07:18:14 +0000 (18:18 +1100)]
Rename all 'utf8_io' -> 'win_utf8_io'.
Erik de Castro Lopo [Thu, 21 Mar 2013 08:18:49 +0000 (19:18 +1100)]
Huge Windows utf8 I/O patch.
Patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Fri, 29 Mar 2013 09:54:34 +0000 (20:54 +1100)]
src/test_libFLAC/decoders.c : Minor improvement.
Miroslav Lichvar [Wed, 27 Mar 2013 16:49:19 +0000 (17:49 +0100)]
Fix option names in documentation and help messages.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Erik de Castro Lopo [Sat, 23 Mar 2013 11:02:56 +0000 (22:02 +1100)]
include/share/compat.h : Simplify.
Erik de Castro Lopo [Thu, 21 Mar 2013 06:28:23 +0000 (17:28 +1100)]
Replace a couple of safe_strncpy/cat with snprintf.
Erik de Castro Lopo [Tue, 19 Mar 2013 09:23:44 +0000 (20:23 +1100)]
Replace broken str* functions with safe versions.
Erik de Castro Lopo [Tue, 19 Mar 2013 09:14:26 +0000 (20:14 +1100)]
Add new file include/share/safe_str.h.
New functions safe_strncat() and safe_strncpy() which always return
a NUL terminated string and do not overflow the destination buffer.
Erik de Castro Lopo [Mon, 18 Mar 2013 08:35:30 +0000 (19:35 +1100)]
autogen.sh : OpenBSD tweaks.
Erik de Castro Lopo [Sun, 17 Mar 2013 19:22:51 +0000 (06:22 +1100)]
More Microsoft Visual Studio project file updates.
Patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Sun, 17 Mar 2013 11:05:58 +0000 (22:05 +1100)]
Windows flac_snprintf tweaks.
Patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Sun, 17 Mar 2013 11:04:34 +0000 (22:04 +1100)]
include/share/private.h : Add FLAC_API to private functions.
Patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Sun, 17 Mar 2013 09:56:41 +0000 (20:56 +1100)]
Use new function flac_snprintf() where ever appropriate.
This replaces un-safe usage of sprintf() and Micorsoft's _snprintf()
with something sane.
Erik de Castro Lopo [Sun, 17 Mar 2013 09:51:52 +0000 (20:51 +1100)]
Add file src/share/grabbag/snprintf.c to grabbag library.
Define function flac_snprintf() which has ISO C99 snprintf() behavior
even when compiling with Microsoft Visual Studio, by wrapping the
MSVS snprintf_s() function.
Erik de Castro Lopo [Sun, 17 Mar 2013 08:39:05 +0000 (19:39 +1100)]
FLAC.sln : Remove obsolete in_flac project.
Patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Sun, 17 Mar 2013 07:31:46 +0000 (18:31 +1100)]
changelog.html : Updates.
Erik de Castro Lopo [Sun, 17 Mar 2013 07:28:53 +0000 (18:28 +1100)]
Wave64 patch from Janne Hyvrinen <cse@sci.fi>.
GUID had one word incorrectly in little endian order.
Erik de Castro Lopo [Thu, 14 Mar 2013 19:37:59 +0000 (06:37 +1100)]
Restore code dropped in commit
f25b2602dc.
Erik de Castro Lopo [Thu, 14 Mar 2013 07:22:29 +0000 (18:22 +1100)]
Fix a couple of Windows 2Gig file size issues.
Patch submitted by Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Wed, 13 Mar 2013 10:54:15 +0000 (21:54 +1100)]
configure.ac : Detect the size of off_t.
Erik de Castro Lopo [Wed, 13 Mar 2013 07:58:16 +0000 (18:58 +1100)]
Add configure option to enable GNU GCC stack smash protection.
This option is disabled by default because it is known not to work
on FreeBSD 9.1 and for Linux -> Windows cross compiling using the
Debian MinGW-w64 tool chain.
It is known to work for native compiles in Debian testing and
OpenBSD 5.2.
Erik de Castro Lopo [Tue, 12 Mar 2013 08:14:51 +0000 (19:14 +1100)]
MS VS : Add alloc.c to the grabbag static build.
Patch from Janne Hyvärinen <cse@sci.fi>.
Erik de Castro Lopo [Tue, 12 Mar 2013 06:08:29 +0000 (17:08 +1100)]
MS VS inline/extern fix from Ben Alison plus comments.
Add explicit extern to functions that are locally declared inline
but which also have non-inline public prototypes.
It seems MS VS does not quite meet the C99 spec (section 6.7.4).
Erik de Castro Lopo [Sun, 10 Mar 2013 11:34:18 +0000 (22:34 +1100)]
configure.ac : When compiling with GCC use some extra warning flags.
Erik de Castro Lopo [Sun, 10 Mar 2013 11:03:47 +0000 (22:03 +1100)]
Fix -Wshadow warnings.
Erik de Castro Lopo [Sun, 10 Mar 2013 11:02:07 +0000 (22:02 +1100)]
src/libFLAC/include/private/macros.h : Fix flac_min.
The existing flac_min macro was generating -Wshadow compiler warnings
when nested.
Erik de Castro Lopo [Sun, 10 Mar 2013 09:39:03 +0000 (20:39 +1100)]
Fix -Wstrict-prototypes -Wmissing-prototypes warnings.
The files src/flac/encode.c and src/libFLAC/stream_encoder.c use
functions in libFLAC that are marked as 'unpublished debug routines'.
This patch moves these functions to new file include/share/private.h
and marks them as 'unpublished debug routines'.
Erik de Castro Lopo [Sun, 10 Mar 2013 07:38:03 +0000 (18:38 +1100)]
include/share/compat.h : feeko and ftello fixes for MinGW.
Patch from LRN <lrn1986@gmail.com>.
Erik de Castro Lopo [Sun, 10 Mar 2013 01:30:49 +0000 (12:30 +1100)]
gcc_version.m4 : Use cut instead of sed.
Add this and other macros to Makefile.am.
Erik de Castro Lopo [Sun, 10 Mar 2013 00:01:20 +0000 (11:01 +1100)]
Purge old un-maintained MSVC 6 project files.
Erik de Castro Lopo [Sat, 9 Mar 2013 23:58:57 +0000 (10:58 +1100)]
doc/html/changelog.html : Prepare for 1.3.0 release.
Erik de Castro Lopo [Sat, 9 Mar 2013 12:56:19 +0000 (23:56 +1100)]
doc/html/documentation_tools_flac.html : Tweaks.
Erik de Castro Lopo [Sat, 9 Mar 2013 11:06:12 +0000 (22:06 +1100)]
Version 1.3.0pre2.
Erik de Castro Lopo [Sat, 9 Mar 2013 09:50:27 +0000 (20:50 +1100)]
Update .gitignore.
Erik de Castro Lopo [Sat, 9 Mar 2013 09:07:31 +0000 (20:07 +1100)]
m4/gcc_version.m4 : Fix XIPH_GCC_VERSION macro.
Macro was misbehaving with OpenBSD's sed.
Erik de Castro Lopo [Sat, 9 Mar 2013 08:42:26 +0000 (19:42 +1100)]
configure.ac : If gcc is version 4.2, use -fgnu89-inline.
Using -gnu-inline avoids a rather ugly warning message that only
seems to be present with gcc-4.2.
Erik de Castro Lopo [Sat, 9 Mar 2013 08:35:42 +0000 (19:35 +1100)]
test/test_compression.sh : Replace seq with numbers.
Apparently seq is a GNU program that isn't installed by default
on OpenBSD.
Erik de Castro Lopo [Sat, 9 Mar 2013 07:42:59 +0000 (18:42 +1100)]
configure.ac : Disable stack protector on FreeBSD.
Erik de Castro Lopo [Fri, 8 Mar 2013 23:25:39 +0000 (10:25 +1100)]
FLAC/ordinals.h : Add <stdint.h> definitions for MSVC < 2010.
Erik de Castro Lopo [Fri, 8 Mar 2013 21:55:37 +0000 (08:55 +1100)]
configure.ac : Don't enable stack protector for mingw* host_os.
Erik de Castro Lopo [Fri, 8 Mar 2013 10:13:13 +0000 (21:13 +1100)]
FLAC/ordinals.h : Provide links for <stdint.h> replacements.
Erik de Castro Lopo [Fri, 8 Mar 2013 10:06:37 +0000 (21:06 +1100)]
Fix version number in Visual Studio project files.
Patch from Ben Allison <benski@winamp.com> and tweaked to change
version from 1.3.0 (which hasn't been released yet) to 1.3.0pre1.
Erik de Castro Lopo [Fri, 8 Mar 2013 09:47:31 +0000 (20:47 +1100)]
Another MSVC patch from Ben Alison.
Erik de Castro Lopo [Wed, 6 Mar 2013 11:17:46 +0000 (22:17 +1100)]
Large patch from Ben Allison fixing the MSVC build.
Patch tweaked a little to fix Linux build and clean up minor problems.
Erik de Castro Lopo [Tue, 5 Mar 2013 11:19:27 +0000 (22:19 +1100)]
Fix compiler warnings from new compiler flags.
Erik de Castro Lopo [Tue, 5 Mar 2013 10:53:18 +0000 (21:53 +1100)]
configure.ac : Add hardening compile options.
Extra compile options are detected at configure time with new
XIPH_ADD_*FLAGS m4 macros.
Options enabled include -Wextra, -D_FORTIFY_SOURCE=2 and stack
protection.
Erik de Castro Lopo [Tue, 5 Mar 2013 07:11:36 +0000 (18:11 +1100)]
Fix a bunch of WDG validation warnings in HTML docs.
Erik de Castro Lopo [Tue, 5 Mar 2013 06:46:04 +0000 (17:46 +1100)]
documentation_tools_flac.html : Document --ignore-chunk-sizes command line option.
Erik de Castro Lopo [Tue, 5 Mar 2013 06:40:45 +0000 (17:40 +1100)]
documentation_tools_flac.html : Fix WDG HTML validator warnings.
Erik de Castro Lopo [Tue, 5 Mar 2013 06:35:16 +0000 (17:35 +1100)]
src/flac/main.c : Mention --ignore-chunk-sizes in help output.
Also mention --no-ignore-chunk-sizes option.
Erik de Castro Lopo [Mon, 4 Mar 2013 10:24:51 +0000 (21:24 +1100)]
test/test_compression.sh : Use wc instead of stat to get file size.
The stat program has different command line parameters depend on
whether its the GNU or BSD version. Sitch to 'wc -c' instead which
seems more portable.
Plus other minor improvements.
Erik de Castro Lopo [Sat, 2 Mar 2013 08:06:56 +0000 (19:06 +1100)]
configure.ac : Version 1.3.0pre1.
Erik de Castro Lopo [Sat, 2 Mar 2013 08:06:20 +0000 (19:06 +1100)]
src/flac/decode.c : Remove repeated code block.
Erik de Castro Lopo [Sat, 2 Mar 2013 03:09:46 +0000 (14:09 +1100)]
Add appropriate WAV channel masks for 7 and 8 channel files.
This commit accepts the new default channel masks for 6.1 and 7.1
surround input WAV files, and writes the corresponding masks when
decoding to WAV without a channel mask from the metadata block.
The local copy of the format spec is also updated with the new text
from the flac-website repository.
Patch from Ralph Giles <giles@mozilla.com>
Timothy B. Terriberry [Thu, 7 Feb 2013 20:33:03 +0000 (12:33 -0800)]
Robustify autogen.sh
This allows the script to be run from somewhere other than the
top-level build directory.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Timothy B. Terriberry [Thu, 7 Feb 2013 20:28:39 +0000 (12:28 -0800)]
xmms - Fix inline linking problems with old glib
f0296255 switched to --std=c99 by default, but old glib relies on
the pre-C99 extern inline rules.
Override G_INLINE_FUNC for it to avoid multiple definition linker
errors.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Timothy B. Terriberry [Thu, 7 Feb 2013 20:27:09 +0000 (12:27 -0800)]
xmms - #include <inttypes.h> for PRIu64
Not sure where this was coming from before, but it's not getting
included elsewhere on my system, so include it explicitly.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Timothy B. Terriberry [Thu, 7 Feb 2013 20:23:24 +0000 (12:23 -0800)]
xmms - Fix libtool usage.
9b7cb22f removed the extra libtool-disable-static script in favor
of always building with disable-static, but plugin_xmms still
referenced libtool-disable-static explicitly.
Signed-off-by: Erik de Castro Lopo <erikd@mega-nerd.com>