philn@webkit.org [Wed, 15 Feb 2012 08:53:02 +0000 (08:53 +0000)]
Unreviewed, GTK rebaseline after r107785 and r107762. Also
skipping a new SVG failure.
* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-zoom-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 15 Feb 2012 08:45:57 +0000 (08:45 +0000)]
[Qt] Unreviewed morning gardening.
* platform/qt/fast/dom/Range/surround-contents-font-face-crash-expected.txt: Added after r107749.
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r107785.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Wed, 15 Feb 2012 08:43:48 +0000 (08:43 +0000)]
WebSocket: MessageEvent fired during send() on workers
https://bugs.webkit.org/show_bug.cgi?id=76521
Reviewed by David Levin.
Source/WebCore:
WebSocket's message event should not be invoked while a synchronous operation
(send() and bufferedAmount) is in progress.
Test: http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
Added #if ENABLE(WORKERS) because ThreadableWebSocketChannelClientWrapper is not used
if Web Workers is not available.
Changed access label because private members were declared as protected with no good reason.
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
Receive ScriptExecutionContext so we can post a task that should be executed later.
(WebCore::ThreadableWebSocketChannelClientWrapper::create):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasksCallback):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
* websockets/ThreadableWebSocketChannelClientWrapper.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
LayoutTests:
* http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html: Added.
* http/tests/websocket/tests/hybi/workers/resources/no-onmessage-in-sync-op.js:
Added. The server sends messages immediately after the connection is established, but
these messages should not be delivered until the script exits the current cycle of
the event loop. The script calls a few synchronous operations to make sure we don't
fire MessageEvents while we are waiting for these operations to finish.
* http/tests/websocket/tests/hybi/workers/resources/no-onmessage-in-sync-op_wsh.py: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Wed, 15 Feb 2012 08:26:30 +0000 (08:26 +0000)]
[Texmap] Divide TextureMapperNode.cpp to 3 files.
https://bugs.webkit.org/show_bug.cgi?id=76660
Source/WebCore:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
No new tests.
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::notifyChange):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setParent):
(WebCore::GraphicsLayerTextureMapper::setChildren):
(WebCore::GraphicsLayerTextureMapper::addChild):
(WebCore::GraphicsLayerTextureMapper::addChildAtIndex):
(WebCore::GraphicsLayerTextureMapper::addChildAbove):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore::GraphicsLayerTextureMapper::replaceChild):
(WebCore::GraphicsLayerTextureMapper::removeFromParent):
(WebCore::GraphicsLayerTextureMapper::setMaskLayer):
(WebCore::GraphicsLayerTextureMapper::setReplicatedByLayer):
(WebCore::GraphicsLayerTextureMapper::setPosition):
(WebCore::GraphicsLayerTextureMapper::setAnchorPoint):
(WebCore::GraphicsLayerTextureMapper::setSize):
(WebCore::GraphicsLayerTextureMapper::setTransform):
(WebCore::GraphicsLayerTextureMapper::setChildrenTransform):
(WebCore::GraphicsLayerTextureMapper::setPreserves3D):
(WebCore::GraphicsLayerTextureMapper::setMasksToBounds):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
(WebCore::GraphicsLayerTextureMapper::setContentsOpaque):
(WebCore::GraphicsLayerTextureMapper::setBackfaceVisibility):
(WebCore::GraphicsLayerTextureMapper::setOpacity):
(WebCore::GraphicsLayerTextureMapper::setContentsRect):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
(WebCore::GraphicsLayerTextureMapper::syncCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::syncCompositingState):
(WebCore::GraphicsLayerTextureMapper::addAnimation):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore):
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::layer):
* platform/graphics/texmap/TextureMapperLayer.cpp: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp.
(WebCore):
(WebCore::toTextureMapperLayer):
(WebCore::TextureMapperLayer::rootLayer):
(WebCore::TextureMapperLayer::setTransform):
(WebCore::TextureMapperLayer::clearBackingStoresRecursive):
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::updateBackingStore):
(WebCore::TextureMapperLayer::paint):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::compareGraphicsLayersZValue):
(WebCore::TextureMapperLayer::sortByZOrder):
(WebCore::TextureMapperLayer::paintSelfAndChildren):
(WebCore::TextureMapperLayer::intermediateSurfaceRect):
(WebCore::TextureMapperLayer::shouldPaintToIntermediateSurface):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintRecursive):
(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::syncCompositingState):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
(WebCore::TextureMapperLayer::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperLayer::syncAnimations):
(WebCore::TextureMapperLayer::syncAnimationsRecursively):
* platform/graphics/texmap/TextureMapperLayer.h: Renamed from Source/WebCore/platform/graphics/texmap/TextureMapperNode.h.
(WebCore):
(TextureMapperPaintOptions):
(WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::TextureMapperLayer):
(WebCore::TextureMapperLayer::size):
(WebCore::TextureMapperLayer::setOpacity):
(WebCore::TextureMapperLayer::setTextureMapper):
(WebCore::TextureMapperLayer::setShouldUpdateBackingStoreFromLayer):
(WebCore::TextureMapperLayer::setBackingStore):
(WebCore::TextureMapperLayer::backingStore):
(WebCore::TextureMapperLayer::texture):
(WebCore::TextureMapperLayer::layerRect):
(State):
(WebCore::TextureMapperLayer::State::State):
Source/WebKit/gtk:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
* WebCoreSupport/AcceleratedCompositingContext.h:
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext):
(WebKit::AcceleratedCompositingContext::enabled):
(WebKit::AcceleratedCompositingContext::renderLayersToWindow):
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer):
(WebKit::AcceleratedCompositingContext::syncLayersTimeout):
Source/WebKit/qt:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
* Api/qwebframe.cpp:
(QWebFramePrivate::renderCompositedLayers):
* Api/qwebframe.h:
(WebCore):
* Api/qwebframe_p.h:
(WebCore):
(QWebFramePrivate::QWebFramePrivate):
(QWebFramePrivate):
* WebCoreSupport/PageClientQt.cpp:
(WebCore::TextureMapperLayerClientQt::TextureMapperLayerClientQt):
(WebCore::TextureMapperLayerClientQt::setTextureMapper):
(WebCore::TextureMapperLayerClientQt::~TextureMapperLayerClientQt):
(WebCore::TextureMapperLayerClientQt::syncRootLayer):
(WebCore::TextureMapperLayerClientQt::rootLayer):
(WebCore::PageClientQWidget::setRootGraphicsLayer):
(WebCore::PageClientQWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
* WebCoreSupport/PageClientQt.h:
(TextureMapperLayerClientQt):
(PageClientQWidget):
(PageClientQGraphicsWidget):
Source/WebKit2:
Rename TextureMapperNode to TextureMapperLayer.
Reviewed by Kenneth Rohde Christiansen.
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::createLayer):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::paintToGraphicsContext):
(WebKit::LayerTreeHostProxy::getBackingStore):
(WebKit::LayerTreeHostProxy::ensureRootLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Wed, 15 Feb 2012 08:21:29 +0000 (08:21 +0000)]
ShadowRoot: Remove a public static factory function which doesn't have any callers.
https://bugs.webkit.org/show_bug.cgi?id=78668
Reviewed by Kent Tamura.
No tests. No change in behavior.
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* dom/ShadowRoot.h:
(ShadowRoot):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 15 Feb 2012 08:04:44 +0000 (08:04 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #11 of N.
* platform/chromium-linux/svg/custom/image-rescale-clip-expected.png:
* platform/chromium-linux/svg/custom/image-rescale-clip-expected.txt: Removed.
* platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png:
* platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/custom/image-rescale-clip-expected.png:
* platform/chromium-mac-leopard/svg/custom/image-rescale-scroll-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/image-rescale-clip-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/image-rescale-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/image-rescale-scroll-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-rescale-scroll-expected.png.
* platform/chromium-mac/svg/custom/image-rescale-clip-expected.png: Removed.
* platform/chromium-mac/svg/custom/image-rescale-expected.png: Removed.
* platform/chromium-win/svg/custom/image-rescale-clip-expected.png:
* platform/chromium-win/svg/custom/image-rescale-expected.png:
* platform/chromium-win/svg/custom/image-rescale-scroll-expected.png:
* platform/chromium/test_expectations.txt:
* platform/mac/svg/custom/image-rescale-expected.txt: Removed.
* platform/qt/svg/custom/image-rescale-expected.txt: Removed.
* svg/custom/image-rescale-expected.txt: Renamed from LayoutTests/platform/gtk/svg/custom/image-rescale-expected.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 15 Feb 2012 07:03:43 +0000 (07:03 +0000)]
Cleanup pending transaction queue in Database.
https://bugs.webkit.org/show_bug.cgi?id=75048
Patch by Hao Zheng <zhenghao@chromium.org> on 2012-02-14
Reviewed by David Levin.
Source/WebCore:
Each SQLTransaction has 3 SQLCallbackWrappers, and each of them
holds a ref to WorkerContext. As a result, if the worker thread is
stopped before all SQLTransactions are finished, the ASSERT of
m_workerContext->hasOneRef() in WorkerThread::workerThread() would fail.
No new tests.
REGRESSION(r103429) fast/workers/storage/use-same-database-in-page-and-workers.html asserts
* storage/Database.cpp:
(WebCore::Database::close): Cleanup pending transaction queue in close().
* storage/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
(SafeReleaseTask): Make SafeReleaseTask a cleanup task, which is
necessary because at the time of SafeReleaseTask is performed,
WorkerRunLoop has been terminated and only runs cleanup tasks.
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):
LayoutTests:
As crash is fixed, trun BUGWK75048 into BUGWK75111, so that we can
close 75048 and fix the timeout in 75111 for both DEBUG and RELEASE.
REGRESSION(r103429) fast/workers/storage/use-same-database-in-page-and-workers.html asserts
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 15 Feb 2012 06:58:59 +0000 (06:58 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=78662
CSSStyleSelector should not rely on parent rule pointer in StylePropertySet
Reviewed by Andreas Kling.
Pass the rule pointer down to the style applying so we don't need to rely on
StylePropertySet having one.
To make this easier the patch also refactors the matched properties vector to
be part of MatchResult object instead of a member of CSSStyleSelector.
Rename Declaration -> Properties.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::sweepMatchedPropertiesCache):
(WebCore::CSSStyleSelector::addMatchedProperties):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::matchAuthorRules):
(WebCore::CSSStyleSelector::matchUserRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore):
(WebCore::CSSStyleSelector::initForStyleResolve):
(WebCore::CSSStyleSelector::matchesRuleSet):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyProperties):
(WebCore::CSSStyleSelector::applyMatchedProperties):
(WebCore::CSSStyleSelector::computeMatchedPropertiesHash):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CSSStyleSelector::findFromMatchedPropertiesCache):
(WebCore::CSSStyleSelector::addToMatchedPropertiesCache):
(WebCore::CSSStyleSelector::invalidateMatchedPropertiesCache):
(WebCore::isCacheableInMatchedPropertiesCache):
(WebCore::CSSStyleSelector::matchPageRules):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedRule):
(WebCore::CSSStyleSelector::MatchedProperties::MatchedProperties):
(MatchedProperties):
(MatchResult):
(MatchedPropertiesCacheItem):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
toyoshim@chromium.org [Wed, 15 Feb 2012 06:56:24 +0000 (06:56 +0000)]
Provide SocketStreamHandleInternal::toWebSocketStreamHandle(SocketStreamHandle*).
https://bugs.webkit.org/show_bug.cgi?id=78581
Reviewed by Kent Tamura.
Now, there is no way to convert SocketStreamHandle to
WebSocketStreamHandle. In subsequent changes, I'll use this function
in FrameLoaderClientImpl.
* src/SocketStreamHandle.cpp: Remove SocketStreamHandleInternal class declaration.
* src/SocketStreamHandleInternal.h: Move SocketStreamHandleInternal class declaration from SocketStreamHandle.cpp to expose, and add conversion function to WebSocketStreamHandle from SocketStreamHandle.
(WebKit):
(WebCore):
(SocketStreamHandleInternal):
(WebCore::SocketStreamHandleInternal::create):
(WebCore::SocketStreamHandleInternal::toWebSocketStreamHandle):
* WebKit.gyp: Add SocketStreamHandleInternal.h entry.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 15 Feb 2012 06:56:00 +0000 (06:56 +0000)]
Stop using script-tests in LayoutTests/fast/forms
https://bugs.webkit.org/show_bug.cgi?id=78667
Reviewed by Kentaro Hara.
* fast/forms/ValidityState-patternMismatch-unsupported.html:
* fast/forms/ValidityState-rangeOverflow.html:
* fast/forms/ValidityState-rangeUnderflow.html:
* fast/forms/ValidityState-stepMismatch.html:
* fast/forms/ValidityState-tooLong-input.html:
* fast/forms/ValidityState-tooLong-textarea.html:
* fast/forms/ValidityState-typeMismatch-date-expected.txt: Removed.
* fast/forms/ValidityState-typeMismatch-url.html:
* fast/forms/ValidityState-valueMissing-radio.html:
* fast/forms/checkValidity-cancel.html:
* fast/forms/checkValidity-handler-updates-dom.html:
* fast/forms/form-attribute-elements-order.html:
* fast/forms/form-attribute-elements-order2.html:
* fast/forms/form-attribute-elements.html:
* fast/forms/form-attribute.html:
* fast/forms/form-collection-elements-order.html:
* fast/forms/form-collection-elements.html:
* fast/forms/formnovalidate-attribute.html:
* fast/forms/incremental-dom-property.html:
* fast/forms/input-maxlength-ime-completed.html:
* fast/forms/input-maxlength-ime-preedit.html:
* fast/forms/input-maxlength-unsupported.html:
* fast/forms/input-minmax.html:
* fast/forms/input-pattern.html:
* fast/forms/input-step.html:
* fast/forms/input-stepup-stepdown.html:
* fast/forms/input-type-change3.html:
* fast/forms/input-valueasnumber-unsupported.html:
* fast/forms/labels-add-htmlFor-label.html:
* fast/forms/labels-add-parent-label.html:
* fast/forms/labels-change-htmlFor-attribute.html:
* fast/forms/labels-item-index.html:
* fast/forms/labels-remove-htmlFor-attribute.html:
* fast/forms/labels-remove-htmlFor-label.html:
* fast/forms/labels-remove-parent-label.html:
* fast/forms/labels-set-htmlFor-attribute.html:
* fast/forms/listbox-deselect-scroll.html:
* fast/forms/listbox-selection-2.html:
* fast/forms/listbox-selection.html:
* fast/forms/menulist-disabled-selected-option.html:
* fast/forms/menulist-submit-without-selection.html:
* fast/forms/novalidate-attribute.html:
* fast/forms/output-reset-assertion-failed.html:
* fast/forms/placeholder-dom-property.html:
* fast/forms/script-tests/TEMPLATE.html: Removed.
* fast/forms/script-tests/ValidityState-patternMismatch-unsupported.js: Removed.
* fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed.
* fast/forms/script-tests/ValidityState-rangeUnderflow.js: Removed.
* fast/forms/script-tests/ValidityState-stepMismatch.js: Removed.
* fast/forms/script-tests/ValidityState-tooLong-input.js: Removed.
* fast/forms/script-tests/ValidityState-tooLong-textarea.js: Removed.
* fast/forms/script-tests/ValidityState-typeMismatch-date.js: Removed.
* fast/forms/script-tests/ValidityState-typeMismatch-url.js: Removed.
* fast/forms/script-tests/ValidityState-valueMissing-radio.js: Removed.
* fast/forms/script-tests/checkValidity-cancel.js: Removed.
* fast/forms/script-tests/checkValidity-handler-updates-dom.js: Removed.
* fast/forms/script-tests/form-attribute-elements-order.js: Removed.
* fast/forms/script-tests/form-attribute-elements-order2.js: Removed.
* fast/forms/script-tests/form-attribute-elements.js: Removed.
* fast/forms/script-tests/form-attribute.js: Removed.
* fast/forms/script-tests/form-collection-elements-order.js: Removed.
* fast/forms/script-tests/form-collection-elements.js: Removed.
* fast/forms/script-tests/formnovalidate-attribute.js: Removed.
* fast/forms/script-tests/incremental-dom-property.js: Removed.
* fast/forms/script-tests/input-maxlength-ime-completed.js: Removed.
* fast/forms/script-tests/input-maxlength-ime-preedit.js: Removed.
* fast/forms/script-tests/input-maxlength-unsupported.js: Removed.
* fast/forms/script-tests/input-minmax.js: Removed.
* fast/forms/script-tests/input-pattern.js: Removed.
* fast/forms/script-tests/input-step.js: Removed.
* fast/forms/script-tests/input-stepup-stepdown.js: Removed.
* fast/forms/script-tests/input-type-change3.js: Removed.
* fast/forms/script-tests/input-valueasnumber-unsupported.js: Removed.
* fast/forms/script-tests/labels-add-htmlFor-label.js: Removed.
* fast/forms/script-tests/labels-add-parent-label.js: Removed.
* fast/forms/script-tests/labels-change-htmlFor-attribute.js: Removed.
* fast/forms/script-tests/labels-item-index.js: Removed.
* fast/forms/script-tests/labels-remove-htmlFor-attribute.js: Removed.
* fast/forms/script-tests/labels-remove-htmlFor-label.js: Removed.
* fast/forms/script-tests/labels-remove-parent-label.js: Removed.
* fast/forms/script-tests/labels-set-htmlFor-attribute.js: Removed.
* fast/forms/script-tests/listbox-deselect-scroll.js: Removed.
* fast/forms/script-tests/listbox-selection-2.js: Removed.
* fast/forms/script-tests/listbox-selection.js: Removed.
* fast/forms/script-tests/menulist-disabled-selected-option.js: Removed.
* fast/forms/script-tests/menulist-submit-without-selection.js: Removed.
* fast/forms/script-tests/novalidate-attribute.js: Removed.
* fast/forms/script-tests/output-reset-assertion-failed.js: Removed.
* fast/forms/script-tests/placeholder-dom-property.js: Removed.
* fast/forms/script-tests/search-cancel-button-events.js: Removed.
* fast/forms/script-tests/select-set-length-optgroup.js: Removed.
* fast/forms/script-tests/select-set-length-with-mutation-remove.js: Removed.
* fast/forms/script-tests/select-set-length-with-mutation-reorder.js: Removed.
* fast/forms/script-tests/select-set-length-with-mutation-reparent.js: Removed.
* fast/forms/script-tests/select-set-length-with-mutation.js: Removed.
* fast/forms/script-tests/select-set-length.js: Removed.
* fast/forms/script-tests/setCustomValidity-existence.js: Removed.
* fast/forms/script-tests/shadow-tree-exposure.js: Removed.
* fast/forms/script-tests/submit-form-attributes.js: Removed.
* fast/forms/script-tests/text-control-intrinsic-widths.js: Removed.
* fast/forms/script-tests/textarea-maxlength.js: Removed.
* fast/forms/script-tests/textarea-metrics.js: Removed.
* fast/forms/script-tests/textarea-placeholder-dom-property.js: Removed.
* fast/forms/script-tests/textarea-rows-cols.js: Removed.
* fast/forms/script-tests/textarea-textlength.js: Removed.
* fast/forms/script-tests/validationMessage.js: Removed.
* fast/forms/script-tests/willvalidate.js: Removed.
* fast/forms/search-cancel-button-events.html:
* fast/forms/select-set-length-optgroup.html:
* fast/forms/select-set-length-with-mutation-remove.html:
* fast/forms/select-set-length-with-mutation-reorder.html:
* fast/forms/select-set-length-with-mutation-reparent.html:
* fast/forms/select-set-length-with-mutation.html:
* fast/forms/select-set-length.html:
* fast/forms/setCustomValidity-existence.html:
* fast/forms/shadow-tree-exposure.html:
* fast/forms/submit-form-attributes.html:
* fast/forms/text-control-intrinsic-widths.html:
* fast/forms/textarea-maxlength.html:
* fast/forms/textarea-metrics.html:
* fast/forms/textarea-placeholder-dom-property.html:
* fast/forms/textarea-rows-cols.html:
* fast/forms/textarea-textlength.html:
* fast/forms/validationMessage.html:
* fast/forms/willvalidate.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
toyoshim@chromium.org [Wed, 15 Feb 2012 06:39:35 +0000 (06:39 +0000)]
WebSocketChannel minor refactoring for code manageability
https://bugs.webkit.org/show_bug.cgi?id=78576
Reviewed by Kent Tamura.
Change the first argument type of WebSocketChannel
from ScriptExecutionContext to Document.
WebSocketChannel always assume this ScriptExecutionContext must
inherit Document. Then, it results in many static cast.
It isn't readable and dangerous against future code changes.
* websockets/ThreadableWebSocketChannel.cpp: Pass the first argument for WebSocketChannel as Document.
(WebCore::ThreadableWebSocketChannel::create):
* websockets/WebSocketChannel.cpp: Replace all ScriptExecutionContext* m_context descriptions to Document* m_document.
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
* websockets/WebSocketChannel.h: Change the first argument for construction to Document and hold it as Document m_document.
(WebCore):
(WebCore::WebSocketChannel::create):
(WebSocketChannel):
* websockets/WorkerThreadableWebSocketChannel.cpp: Pass the first argument for WebSocketChannel as Document.
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 15 Feb 2012 06:00:36 +0000 (06:00 +0000)]
Unreviewed, rolling out r107774.
http://trac.webkit.org/changeset/107774
https://bugs.webkit.org/show_bug.cgi?id=78661
Broke Chromium build
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/ScrollAnimator.cpp:
(WebCore):
(WebCore::ScrollAnimator::handleGestureEvent):
* platform/ScrollAnimator.h:
(ScrollAnimator):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(ScrollView):
* platform/ScrollableArea.cpp:
(WebCore):
(WebCore::ScrollableArea::handleGestureEvent):
* platform/ScrollableArea.h:
(ScrollableArea):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Wed, 15 Feb 2012 05:19:16 +0000 (05:19 +0000)]
Unreviewed, rolling out r107766.
http://trac.webkit.org/changeset/107766
https://bugs.webkit.org/show_bug.cgi?id=78665
Breaks Chromium Win build (Requested by bashi1 on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-14
Source/WebCore:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* websockets/WebSocketDeflater.cpp: Removed.
* websockets/WebSocketDeflater.h: Removed.
Source/WebKit/chromium:
* WebKit.gypi:
* tests/WebSocketDeflaterTest.cpp: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 15 Feb 2012 05:10:16 +0000 (05:10 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #10 of N.
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 15 Feb 2012 04:13:40 +0000 (04:13 +0000)]
Add #include of unistd.h on the mac for getcwd.
Reviewed by Anders Carlsson.
This is necessary when building with libc++.
* WebKitTestRunner/TestInvocation.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 15 Feb 2012 04:10:26 +0000 (04:10 +0000)]
In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
https://bugs.webkit.org/show_bug.cgi?id=78663
Reviewed by Anders Carlsson.
* DumpRenderTree/DumpRenderTreePrefix.h:
* DumpRenderTree/cg/ImageDiffCG.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 15 Feb 2012 03:56:22 +0000 (03:56 +0000)]
Remove ScrollableArea::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=78661
Reviewed by Sam Weinig.
ScrollableArea::handleGestureEvent ends up being a no-op so remove it and the related code.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/ScrollAnimator.cpp:
* platform/ScrollAnimator.h:
(ScrollAnimator):
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(ScrollView):
* platform/ScrollableArea.cpp:
* platform/ScrollableArea.h:
(ScrollableArea):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 15 Feb 2012 03:22:14 +0000 (03:22 +0000)]
[JSC] Cache the number of non-custom constructor arguments
https://bugs.webkit.org/show_bug.cgi?id=78195
Reviewed by Darin Adler.
Source/WebCore:
If [ConstructorParameters=] is specified, JSC caches the number of constructor
arguments for performance. However, at present, [ConstructorParameters=] is specified
on a small part of constructors (It appears that people have forgotten to
add [ConstructorParameters=]). Thus, for non-custom constructors, this patch modifies
CodeGeneratorJS.pm so that it caches the number of constructor arguments automatically
without [ConstructorParameters=] (CodeGeneratorJS.pm can know the number of arguments
by the [Constructor=...] signature).
Test: fast/js/constructor-length.html
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
LayoutTests:
The added tests check the length property of constructors.
The test fails for "flag-disabled" constructors.
* fast/js/constructor-length.html: Added.
* platform/mac/fast/js/constructor-length-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 15 Feb 2012 03:04:48 +0000 (03:04 +0000)]
<webkit.org/b/78658> platformUserPreferredLanguages is leaking all of the language codes
Reviewed by Darin Adler.
* platform/mac/Language.mm:
(WebCore::httpStyleLanguageCode): Switch to using RetainPtr's for temporaries to make the ownership
more explicit. Switch to returning a WTF::String so that the caller doesn't have to worry about
ownership at all. Change the name to reflect the lack of transfer of ownership.
(WebCore::platformUserPreferredLanguages):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 15 Feb 2012 02:20:19 +0000 (02:20 +0000)]
[Mac] PasteboardMac.mm build fails
https://bugs.webkit.org/show_bug.cgi?id=78655
Reviewed by Hajime Morita.
Although the bots have been working fine, PasteboardMac.mm build fails
in our local Mac environments due to an uninitialized variable:
/Users/haraken/WebKit/Source/WebCore/platform/mac/PasteboardMac.mm:322: warning: 'string' may be used uninitialized in this function
This patch initializes the 'string' to nil to fix the build failure.
No tests. No change in behavior.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::plainText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Wed, 15 Feb 2012 02:11:46 +0000 (02:11 +0000)]
[WebSocket] Add extension attribute support
https://bugs.webkit.org/show_bug.cgi?id=78557
Source/WebCore:
Implement WebSocket "extensions" attribute that holds a list of
extension the server accepted. No change in behavior at this time
because we don't send any extension on handshake.
Reviewed by Kent Tamura.
No new tests. http/tests/websocket/tests/hybi/extensions.html checks the value of this attribute.
* websockets/ThreadableWebSocketChannel.h: Add extensions().
(ThreadableWebSocketChannel):
* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::extensions): Added.
(WebCore):
(WebCore::ThreadableWebSocketChannelClientWrapper::setExtensions): Added.
* websockets/ThreadableWebSocketChannelClientWrapper.h:
(ThreadableWebSocketChannelClientWrapper):
* websockets/WebSocket.cpp: Added m_extensions member variable.
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::extensions): Returns m_extensions.
* websockets/WebSocket.h:
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::extensions): Added.
(WebCore):
* websockets/WebSocketChannel.h:
(WebSocketChannel):
* websockets/WebSocketExtensionDispatcher.cpp:
(WebCore::WebSocketExtensionDispatcher::fail): Added.
(WebCore::WebSocketExtensionDispatcher::processHeaderValue): Stores accepted extensions.
(WebCore::WebSocketExtensionDispatcher::acceptedExtensions): Added.
(WebCore):
(WebCore::WebSocketExtensionDispatcher::acceptedExtensions): Added.
* websockets/WebSocketExtensionDispatcher.h:
(WebSocketExtensionDispatcher):
* websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::acceptedExtensions): Added.
(WebCore):
* websockets/WebSocketHandshake.h:
* websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::extensions): Added.
(WebCore):
(WebCore::workerContextDidConnect): Calls ThreadableWebSocketChannelClientWrapper::setExtensions().
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect): Passes extensions as an argument.
* websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):
Source/WebKit/chromium:
Add WebSocketExtensionDispatcher::acceptedExtensions() checks.
Reviewed by Kent Tamura.
* tests/WebSocketExtensionDispatcherTest.cpp:
(WebCore::TEST_F):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 15 Feb 2012 02:05:13 +0000 (02:05 +0000)]
Rename [JSGenerateToJS] to [JSGenerateToJSObject]
https://bugs.webkit.org/show_bug.cgi?id=78490
Reviewed by Adam Barth.
This patch renames [JSGenerateToJS] to [JSGenerateToJSObject],
for naming consistency with [CustomToJSObject], [JSCustomToJSObject] and [V8CustomToJSObject].
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* dom/WebKitNamedFlow.idl:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.idl:
* fileapi/File.idl:
* fileapi/FileEntry.idl:
* fileapi/FileEntrySync.idl:
* html/DOMFormData.idl:
* html/DOMSettableTokenList.idl:
* html/DOMURL.idl:
* html/MediaController.idl:
* mediastream/LocalMediaStream.idl:
* webaudio/AudioBufferCallback.idl:
* webaudio/AudioBufferSourceNode.idl:
* webaudio/AudioDestinationNode.idl:
* webaudio/AudioGain.idl:
* webaudio/AudioGainNode.idl:
* webaudio/AudioPannerNode.idl:
* webaudio/AudioProcessingEvent.idl:
* webaudio/BiquadFilterNode.idl:
* webaudio/ConvolverNode.idl:
* webaudio/DelayNode.idl:
* webaudio/DynamicsCompressorNode.idl:
* webaudio/HighPass2FilterNode.idl:
* webaudio/JavaScriptAudioNode.idl:
* webaudio/LowPass2FilterNode.idl:
* webaudio/MediaElementAudioSourceNode.idl:
* webaudio/OfflineAudioCompletionEvent.idl:
* webaudio/RealtimeAnalyserNode.idl:
* webaudio/WaveShaperNode.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 15 Feb 2012 02:04:53 +0000 (02:04 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #9 of N.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Renamed from LayoutTests/platform/chromium/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Wed, 15 Feb 2012 02:02:53 +0000 (02:02 +0000)]
Source/WebCore: [WebSocket] Add deflater/inflater classes
https://bugs.webkit.org/show_bug.cgi?id=78449
Add WebSocketDeflater/WebSocketInflater classes which wrap zlib
functions. These classes are not used yet, but will be used for
supporting WebSocket deflate-frame extension.
Reviewed by Kent Tamura.
No new tests except for chromium port. Behavior is unchanged.
* GNUmakefile.list.am: Added.WebSocketDeflater.(cpp|h).
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* websockets/WebSocketDeflater.cpp: Added.
(WebCore):
(WebCore::WebSocketDeflater::create):
(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::create):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):
(WebCore::WebSocketInflater::reset):
* websockets/WebSocketDeflater.h: Added.
(WebCore):
(WebSocketDeflater):
(WebCore::WebSocketDeflater::data):
(WebCore::WebSocketDeflater::size):
(WebSocketInflater):
(WebCore::WebSocketInflater::data):
(WebCore::WebSocketInflater::size):
Source/WebKit/chromium: [WebSocket] Add deflater/inflater classes.
https://bugs.webkit.org/show_bug.cgi?id=78449
Add tests which ensure WebSocketDeflater/WebSocketInflater can
compress/decompress data correctly.
Reviewed by Kent Tamura.
* WebKit.gypi:
* tests/WebSocketDeflaterTest.cpp: Added.
(WebCore):
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 15 Feb 2012 01:47:57 +0000 (01:47 +0000)]
[BlackBerry] Upstreaming WebSettings code
https://bugs.webkit.org/show_bug.cgi?id=78633
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-14
Reviewed by Rob Buis.
Initial upstreaming, no new tests.
* blackberry/Api/WebSettings.cpp: Added.
* blackberry/Api/WebSettings.h: Added.
* blackberry/Api/WebSettings_p.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 15 Feb 2012 01:34:36 +0000 (01:34 +0000)]
[chromium] Compare filters on impl thread when setting them, and test setting in unit tests
https://bugs.webkit.org/show_bug.cgi?id=78643
Patch by Dana Jansens <danakj@chromium.org> on 2012-02-14
Reviewed by James Robinson.
Source/WebCore:
Add setFilters() coverage to CCLayerImplTest.cpp
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setFilters):
Source/WebKit/chromium:
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Wed, 15 Feb 2012 01:34:14 +0000 (01:34 +0000)]
Convert a couple of media layouttests to mock scrollbars & rebaseline
https://bugs.webkit.org/show_bug.cgi?id=78634
Unreviewed layouttest rebaselining.
* platform/chromium-gpu-linux/media/video-controls-rendering-expected.png:
* platform/chromium-gpu-linux/media/video-zoom-expected.png:
* platform/chromium-gpu-mac/media/video-controls-rendering-expected.png:
* platform/chromium-gpu-mac/media/video-zoom-expected.png:
* platform/chromium-gpu-win/media/video-controls-rendering-expected.png:
* platform/chromium-gpu-win/media/video-zoom-expected.png:
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-linux/media/video-zoom-expected.png:
* platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
* platform/chromium-mac-leopard/media/video-zoom-expected.png:
* platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
* platform/chromium-mac-snowleopard/media/video-zoom-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-zoom-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 15 Feb 2012 01:23:49 +0000 (01:23 +0000)]
Crash in deleteInsignificantText
https://bugs.webkit.org/show_bug.cgi?id=78567
Reviewed by Eric Seidel.
Source/WebCore:
Fix the crash. Also update layout at the beginning of each call to deleteInsignificantText
since the previous call may have mutated the DOM.
Test: editing/inserting/delete-insignificant-text-crash.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::deleteInsignificantText):
LayoutTests:
Add a regression test.
* editing/inserting/delete-insignificant-text-crash.html: Added.
* editing/inserting/delete-insignificant-text-crash.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Wed, 15 Feb 2012 01:20:32 +0000 (01:20 +0000)]
Prepare RenderLayerBacking and RenderLayerCompositor for subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78630
Reviewed by Simon Fraser.
In our transition to subpixel layout in the render tree, we continue to pass RenderLayerBacking
and RenderLayerCompositor integer (pixel) sizes and positions. This patch moves nearly all
methods and members on these two classes back to integers, and applies pixel snapping logic to
LayoutUnits pulled in.
No new tests. No change in behavior.
* rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedLayoutOverflowRect): Convenience function for getting pixel
snapped overflow bounds.
* rendering/RenderLayerBacking.cpp:
(WebCore):
(WebCore::RenderLayerBacking::updateCompositedBounds): Switch to integers and pixel snapping the
clipping bounds.
(WebCore::clipBox): Returns a pixel snapped rect.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Using pixelSnappedLayerCoords. Removing
pixelSnappedIntRect calls to clipBox since this is now an IntRect.
(WebCore::RenderLayerBacking::computeTransformOrigin): Switching to operate on a pixel snapped rect.
(WebCore::RenderLayerBacking::computePerspectiveOrigin): Ditto.
(WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): Returns a size based on m_compositingBounds,
which is now an IntSize.
(WebCore::RenderLayerBacking::contentsBox): Switching to use pixel snapped values from the render tree.
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): This now takes in and outputs integers.
(WebCore::RenderLayerBacking::paintIntoLayer): Uses a pixel snapped rect for the dirty rect.
(WebCore::paintScrollbar): Scrollbars are Widgets & painted natively, so they should use integers.
(WebCore::RenderLayerBacking::paintContents): We now properly take in an integer clip rect, as it's
used for the scrollbars.
(WebCore::RenderLayerBacking::startAnimation): Using pixel snapped values for animations and transitions.
(WebCore::RenderLayerBacking::startTransition): Ditto.
(WebCore::RenderLayerBacking::compositedBounds): Composited bounds are now properly stored as integers.
(WebCore::RenderLayerBacking::setCompositedBounds): Ditto.
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds): Composited bounds are pixel snapped, but
we use LayoutUnits up until we snap and return.
(WebCore::RenderLayerCompositor::addToOverlapMap): Overlap mapping uses our integer positions. Switching
it back to operating on them.
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive): Ditto.
(WebCore::RenderLayerCompositor::overlapsCompositedLayers): Ditto.
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Using integers.
(WebCore::RenderLayerCompositor::frameViewDidChangeLocation): FrameViews are on integer bounds. We now
properly use these as integers.
(WebCore::RenderLayerCompositor::frameViewDidScroll): Ditto.
(WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): Switching to use integers and
pixelSnappedLayerCoords.
(WebCore::RenderLayerCompositor::repaintCompositedLayersAbsoluteRect): Ditto.
(WebCore::RenderLayerCompositor::updateRootLayerPosition): Using integer positions, which are what
the apis used already returned.
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin): Using pixel snapped values.
(WebCore::RenderLayerCompositor::requiresCompositingForFrame): Ditto.
(WebCore::paintScrollbar): Scrollbars should always use integers.
(WebCore::RenderLayerCompositor::paintContents): Switching to use an integer clip rect.
(WebCore::RenderLayerCompositor::ensureRootLayer): Using values from new pixelSnappedLayoutOverflowRect
method on RenderBox to ensure we're using values that are pixel snapped to the proper location.
(WebCore::RenderLayerCompositor::destroyRootLayer): Properly calling scrollbar invalidation methods
with integers.
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Wed, 15 Feb 2012 01:16:53 +0000 (01:16 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #8 of N.
* platform/chromium-mac-snowleopard/fast/writing-mode/background-horizontal-bt-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/writing-mode/background-vertical-lr-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/writing-mode/background-vertical-rl-expected.png: Added.
* platform/chromium-mac/fast/writing-mode/background-horizontal-bt-expected.png: Removed.
* platform/chromium-mac/fast/writing-mode/background-vertical-lr-expected.png: Removed.
* platform/chromium-mac/fast/writing-mode/background-vertical-rl-expected.png: Removed.
* platform/chromium-win/fast/writing-mode/background-horizontal-bt-expected.png:
* platform/chromium-win/fast/writing-mode/background-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/background-vertical-rl-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 15 Feb 2012 01:08:25 +0000 (01:08 +0000)]
Swipe gestures don't work if main frame has a horizontal scrollbar
https://bugs.webkit.org/show_bug.cgi?id=78650
<rdar://problem/
10864993>
Reviewed by Sam Weinig.
Source/WebCore:
Change ScrollingTree::tryToHandleWheelEvent so we can indicate that an event was
processed by the scrolling tree but that we should indicate back to WebKit that it wasn't handled.
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Initialize new member variables.
(WebCore::ScrollingTree::tryToHandleWheelEvent):
If the wheel event will start a swipe gesture, return DidNotHandleEvent.
(WebCore::ScrollingTree::updateBackForwardState):
This can now be called from any thread, so use a mutex.
(WebCore::ScrollingTree::setMainFramePinState):
New function that will set the current main frame pin state.
(WebCore::ScrollingTree::canGoBack):
(WebCore::ScrollingTree::canGoForward):
Put locks around these.
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
Helper function that returns whether the given wheel event will start a swipe gesture
because the main frame is pinned to the left/right and we can go back/forward.
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
Call updateMainFramePinState if the frame geometry changes.
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
Call updateMainFramePinState.
(WebCore::ScrollingTreeNodeMac::updateMainFramePinState):
Compute the main frame pin state and set it on the scrolling tree.
Source/WebKit2:
* WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
ScrollingTree::tryToHandleWheelEvent now returns a tri-state enum so handle the extra case.
(WebKit::EventDispatcher::sendDidReceiveEvent):
Rename this now that it takes a parameter indicating whether the event was handled or not.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 15 Feb 2012 01:05:58 +0000 (01:05 +0000)]
Source/WebCore: Web Inspector: Add the ability to show the resources panel on launch
https://bugs.webkit.org/show_bug.cgi?id=78641
Reviewed by Timothy Hatcher.
* WebCore.exp.in: Add a new function to be exported.
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::showResources): Call showResources on load.
* inspector/InspectorFrontendClientLocal.h:
(InspectorFrontendClientLocal):
* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.showResources): Show the resources panel.
Source/WebKit2: Web Inspector: Add the ability to show the resources panel on launch
https://bugs.webkit.org/show_bug.cgi?id=78641
Add WebKit2 API for the ability to show the resources panel. This calls down
from the WK API all the way to InspectorFrontendClientLocal::showResources.
Reviewed by Timothy Hatcher.
* UIProcess/API/C/WKInspector.cpp:
(WKInspectorShowResources): Call WebInspectorProxy::showResources.
* UIProcess/API/C/WKInspector.h:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::showResources): Send a message to the web process.
* UIProcess/WebInspectorProxy.h:
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::showResources): Call InspectorFrontendClientLocal::showResources.
* WebProcess/WebPage/WebInspector.h:
* WebProcess/WebPage/WebInspector.messages.in: Add a ShowResources message.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 15 Feb 2012 01:00:46 +0000 (01:00 +0000)]
Implement an adb-based driver for the ChromiumAndroidPort
https://bugs.webkit.org/show_bug.cgi?id=78627
Reviewed by Eric Seidel.
This driver mostly just wires up the ChromiumDriver through adb. In
some cases, it translates protocol elements, such as URIs, so that the
rest of webkitpy is insulated from the "remoteness" of the target device.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._driver_class):
(ChromiumAndroidPort._update_version):
(ChromiumAndroidPort._get_stderr):
(ChromiumAndroidPort):
(ChromiumAndroidPort._get_last_stacktrace):
(ChromiumAndroidPort._teardown_performance):
(ChromiumAndroidDriver):
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver.run_test):
(ChromiumAndroidDriver.stop):
(ChromiumAndroidDriver._test_shell_command):
(ChromiumAndroidDriver._write_command_and_read_line):
(ChromiumAndroidDriver._output_image):
(ChromiumAndroidDriver._has_crash_hint):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 15 Feb 2012 00:57:07 +0000 (00:57 +0000)]
webkitpy: the real_name() method in the Port class is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=78651
Reviewed by Eric Seidel.
The change in bug 78565 / r107718 made it no longer necessary
(we can use options.platform instead).
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.name):
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRTPort.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 15 Feb 2012 00:36:03 +0000 (00:36 +0000)]
webkitpy: clean up options, port handling in manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=78568
Reviewed by Tony Chang.
manager_worker_broker no longer needs options or port objects
directly, so we make them only be passed in start_worker().
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get):
(_ManagerConnection.__init__):
(_ManagerConnection.start_worker):
(_InlineManager.__init__):
(_InlineManager.start_worker):
(_InlineManager.run_message_loop):
(_MultiProcessManager.__init__):
(_MultiProcessManager):
(_MultiProcessManager.start_worker):
(_InlineWorkerConnection.__init__):
(_InlineWorkerConnection.run):
(_Process.__init__):
(_MultiProcessWorkerConnection.__init__):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(make_broker):
(_TestWorker.run):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
(_TestsMixin.test_unknown_message):
(MultiProcessBrokerTests.setUp):
(InterfaceTest.test_managerconnection_is_abstract):
* Scripts/webkitpy/layout_tests/controllers/message_broker.py:
(Broker.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Wed, 15 Feb 2012 00:35:51 +0000 (00:35 +0000)]
REGRESSION (r107568-r107627): Crash when copying in WebCore::SharedBuffer::hasPlatformData().
https://bugs.webkit.org/show_bug.cgi?id=78577
Reviewed by Dan Bernstein.
* platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::setBufferForType): Missing null check when
setting data to the NSPasteboard.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 15 Feb 2012 00:26:34 +0000 (00:26 +0000)]
Fix Interpreter.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 15 Feb 2012 00:11:59 +0000 (00:11 +0000)]
nrwt: add a unit test for regression introduced in bug 78565
https://bugs.webkit.org/show_bug.cgi?id=78646
Reviewed by Tony Chang.
* Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
(FakeConnection):
(FakeConnection.run_message_loop):
(FakeConnection.post_message):
(WorkerTest):
(WorkerTest.test_default_platform_in_worker):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Wed, 15 Feb 2012 00:11:57 +0000 (00:11 +0000)]
[BlackBerry] Upstream remaining classes in Api
https://bugs.webkit.org/show_bug.cgi?id=78644
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
* blackberry/Api/BlackBerryContext.h: Added.
* blackberry/Api/BlackBerryGlobal.cpp: Added.
* blackberry/Api/BlackBerryGlobal.h: Added.
* blackberry/Api/Version.cpp: Added.
* blackberry/Api/Version.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 14 Feb 2012 23:54:40 +0000 (23:54 +0000)]
Crash in WebCore::SVGElement::removedFromDocument
https://bugs.webkit.org/show_bug.cgi?id=77270
Reviewed by Adam Barth.
Source/WebCore:
Add a protector before calling NodeRemovalDispatcher::dispatch since
NodeRemovalDispatcher::dispatch may remove the last RefPtr to this node.
Test: fast/dom/Range/surround-contents-font-face-crash.svg
* dom/ContainerNodeAlgorithms.h:
(WebCore::Private::addChildNodesToDeletionQueue):
LayoutTests:
Add a regression test for the crash.
* fast/dom/Range/surround-contents-font-face-crash-expected.txt: Added.
* fast/dom/Range/surround-contents-font-face-crash.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mlilek@apple.com [Tue, 14 Feb 2012 23:40:29 +0000 (23:40 +0000)]
Don't ENABLE_DASHBOARD_SUPPORT unconditionally on all Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=78629
Reviewed by David Kilzer.
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kubo@profusion.mobi [Tue, 14 Feb 2012 23:26:09 +0000 (23:26 +0000)]
[CMake] Merge WebKitEfl.cmake into FindEFL.cmake.
https://bugs.webkit.org/show_bug.cgi?id=78566
Reviewed by Daniel Bates.
.:
* Source/cmake/FindEFL.cmake: Move the code to find edje_cc here from
WebKitEfl.cmake.
* Source/cmake/WebKitEfl.cmake: Removed.
Source/WebKit/efl:
* CMakeListsEfl.txt: Do not include WebKitEfl.cmake.
Source/WebKit2:
* PlatformEfl.cmake: Do not include WebKitEfl.cmake.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 14 Feb 2012 23:20:10 +0000 (23:20 +0000)]
NRWT is broken for the default port
https://bugs.webkit.org/show_bug.cgi?id=78640
Reviewed by Tony Chang.
The change in r107718 (bug 78565) broke NRWT if you didn't
specify any sort of --platform flag or equivalent. I didn't
catch this because it's a full integration test (which we don't
have an automated test for) and I missed this command line
variant when testing interactively.
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.run):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 23:16:53 +0000 (23:16 +0000)]
Avoid full style recalc when presentation attributes change.
<http://webkit.org/b/78636>
Patch by Andreas Kling <awesomekling@apple.com> on 2012-02-14
Reviewed by Antti Koivisto.
Use setNeedsStyleRecalc(InlineStyleChange) when a presentation attribute changes
to reduce the amount of work done in recalcStyle().
* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 14 Feb 2012 23:11:33 +0000 (23:11 +0000)]
Unreviewed, build fix for non-DFG platforms.
* assembler/MacroAssembler.h:
(MacroAssembler):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 22:58:34 +0000 (22:58 +0000)]
[BlackBerry] Upstreaming DOMSupport files
https://bugs.webkit.org/show_bug.cgi?id=78607
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-02-14
Reviewed by Rob Buis.
Initial upstreaming, no new tests.
* blackberry/WebKitSupport/DOMSupport.cpp: Added.
* blackberry/WebKitSupport/DOMSupport.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 14 Feb 2012 22:56:19 +0000 (22:56 +0000)]
Unreviewed, fix build and configuration goof.
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::invert):
* dfg/DFGCommon.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 14 Feb 2012 22:50:08 +0000 (22:50 +0000)]
DFG should be able to emit code on control flow edges
https://bugs.webkit.org/show_bug.cgi?id=78515
Reviewed by Gavin Barraclough.
This gets us a few steps closer to being able to perform global register allocation,
by allowing us to have landing pads on control flow edges. This will let us reshuffle
registers if it happens to be necessary due to different reg alloc decisions in
differen blocks.
This also introduces the notion of a landing pad for OSR entry, which will allow us
to emit code that places data into registers when we're entering into the DFG from
the old JIT.
Finally, this patch introduces a verification mode that checks that the landing pads
are actually emitted and do actually work as advertised. When verification is disabled,
this has no effect on behavior.
* assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::invert):
(JSC::MacroAssembler::isInvertible):
* dfg/DFGCommon.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(DFG):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::branchDouble):
(JSC::DFG::SpeculativeJIT::branchDoubleNonZero):
(JSC::DFG::SpeculativeJIT::branch32):
(JSC::DFG::SpeculativeJIT::branchTest32):
(JSC::DFG::SpeculativeJIT::branchPtr):
(JSC::DFG::SpeculativeJIT::branchTestPtr):
(JSC::DFG::SpeculativeJIT::branchTest8):
(JSC::DFG::SpeculativeJIT::jump):
(JSC::DFG::SpeculativeJIT::haveEdgeCodeToEmit):
(JSC::DFG::SpeculativeJIT::emitEdgeCode):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Tue, 14 Feb 2012 22:47:10 +0000 (22:47 +0000)]
Convert a couple of media layouttests to mock scrollbars & rebaseline
https://bugs.webkit.org/show_bug.cgi?id=78634
Unreviewed test maintenance.
* media/video-controls-rendering.html:
* media/video-zoom.html:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 22:35:32 +0000 (22:35 +0000)]
Last character display for passwords in Android.
https://bugs.webkit.org/show_bug.cgi?id=78532
Patch by Ramya Chandrasekaran <cramya@google.com> on 2012-02-14
Reviewed by Adam Barth.
Source/WebCore:
* page/Settings.cpp:
(WebCore::Settings::Settings):
Source/WebKit/chromium:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setPasswordEchoEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPasswordEchoDurationInSeconds):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
Tools:
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Tue, 14 Feb 2012 22:31:26 +0000 (22:31 +0000)]
IndexedDB: Invalid dates should not be valid keys
https://bugs.webkit.org/show_bug.cgi?id=78622
Reviewed by Tony Chang.
Source/WebCore:
Tests: storage/indexeddb/invalid-keys.html
storage/indexeddb/factory-cmp.html
* bindings/v8/IDBBindingUtilities.cpp: Special case for NaN Dates.
(WebCore::createIDBKeyFromValue):
LayoutTests:
* storage/indexeddb/factory-cmp-expected.txt:
* storage/indexeddb/factory-cmp.html:
* storage/indexeddb/invalid-keys-expected.txt:
* storage/indexeddb/invalid-keys.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 22:30:52 +0000 (22:30 +0000)]
[BlackBerry] Remove OpenVG references
https://bugs.webkit.org/show_bug.cgi?id=78623
Patch by Jeff Rogers <jrogers@rim.com> on 2012-02-14
Reviewed by Rob Buis.
Removed references to USE(OPENVG) and the related code.
* blackberry/Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::createSurface):
* blackberry/Api/BackingStore_p.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 22:18:20 +0000 (22:18 +0000)]
Initial upstreaming for find-in-page for BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=78615
Create a new class InPageSearchManager for find-in-page and
remove the functions in SelectionHandler
Patch by Andy Chen <andchen@rim.com> on 2012-02-14
Reviewed by Rob Buis.
* blackberry/CMakeListsBlackBerry.txt:
* blackberry/WebKitSupport/InPageSearchManager.cpp: Added.
(BlackBerry::WebKit::InPageSearchManager::InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::~InPageSearchManager):
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
(BlackBerry::WebKit::InPageSearchManager::setMarkerActive):
* blackberry/WebKitSupport/InPageSearchManager.h: Added.
* blackberry/WebKitSupport/SelectionHandler.cpp:
* blackberry/WebKitSupport/SelectionHandler.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 22:09:21 +0000 (22:09 +0000)]
[BlackBerry] Upstream BlackBerry WebCoreSupport FrameLoaderClientBlackBerry class
https://bugs.webkit.org/show_bug.cgi?id=78275
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-02-14
Reviewed by Rob Buis.
Initial upstream, no new tests.
* blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 22:02:05 +0000 (22:02 +0000)]
Crash from line break iterators in counter content
https://bugs.webkit.org/show_bug.cgi?id=72977
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-02-14
Reviewed by David Hyatt.
Source/WebCore:
Calculating the width of counter text can sometimes cause the
underlying text buffer to change. This patch causes the iterator
to reset appropriately when this happens.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
LayoutTests:
Test that causes asterisk counters to change during layout
and potentially confuse iterators.
* fast/css/counters/asterisk-counter-update-after-layout-crash-expected.txt: Added
* fast/css/counters/asterisk-counter-update-after-layout-crash.html: Added
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 14 Feb 2012 21:26:26 +0000 (21:26 +0000)]
Assertion failure under JSC::DFG::AbstractState::execute loading economist.com
https://bugs.webkit.org/show_bug.cgi?id=78153
<rdar://problem/
10861712> <rdar://problem/
10861947>
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
LayoutTests:
* fast/js/dfg-add-not-number-expected.txt: Added.
* fast/js/dfg-add-not-number.html: Added.
* fast/js/script-tests/dfg-add-not-number.js: Added.
(foo):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Tue, 14 Feb 2012 21:17:27 +0000 (21:17 +0000)]
Update usage of LayoutUnits in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=78511
Reviewed by Simon Fraser.
Updating RenderLayer to properly use LayoutUnits. See descriptions below for the rationale behind all
the changes. Also adding a roundedIntSize method that takes a LayoutSize.
No new tests. No change in behavior.
* rendering/LayoutTypes.h:
(WebCore::roundedIntSize): Inline method that currently does nothing, but will round a LayoutSize
to an IntSize.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions): Switching repaint and outline boxes to LayoutRects, as
it's important to keep the precision of these rects until handing off to the embedder (in FrameView).
(WebCore::RenderLayer::computeRepaintRects): Repaint rects should be preserved in subpixel units until
being passed to the embedding layer. This prevents needless repaints.
(WebCore::RenderLayer::convertToPixelSnappedLayerCoords): Convenience function to return pixel snapped rects
(WebCore):
(WebCore::RenderLayer::convertToLayerCoords): Fixing a style flaw.
(WebCore::RenderLayer::scrollRectToVisible): Pixel snapping the rect when handing off to the embedder.
(WebCore::RenderLayer::maximumScrollPosition): Scroll offsets are rounded.
(WebCore::RenderLayer::scrollCornerRect): Scrollbars are drawn natively and should be positioned on pixel
boundaries.
(WebCore::RenderLayer::scrollCornerAndResizerRect): Resize corner doesn't influence the size/position of
render objects. It is only painted and hit tested. Therefor it should use integers.
(WebCore::RenderLayer::offsetFromResizeCorner): Ditto.
(WebCore::RenderLayer::positionOverflowControls): Overflow controls are drawn natively and should be
positioned on integer boundaries.
(WebCore::RenderLayer::paintOverflowControls): Ditto.
(WebCore::RenderLayer::paintScrollCorner): Ditto.
(WebCore::RenderLayer::drawPlatformResizerImage): Ditto.
(WebCore::RenderLayer::paintResizer): Ditto.
(WebCore::RenderLayer::hitTestOverflowControls): Hit testing & overflow controls both use integers.
(WebCore::RenderLayer::clipToRect): Clipping to actual painted (pixel snapped) layer bounds in the
graphics context.
(WebCore::RenderLayer::paintLayerContents): Calling paintOverflowControls at pixel bounds.
(WebCore::RenderLayer::hitTest): Intersecting the hit test area with pixel snapped boundaries.
(WebCore::RenderLayer::setBackingNeedsRepaintInRect): Sending pixelSnapped rects to the backing
store, which only cares about pixels, and hence integers.
* rendering/RenderLayer.h:
(WebCore::RenderLayer::scrolledContentOffset): RenderLayer's scroll offsets are used in platform
code, so we need to return them as integers. Rounding the scroll overflow before adding it to the
scroll offset, which was already stored in integers.
(RenderLayer):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 21:16:52 +0000 (21:16 +0000)]
Separate mimetype and file extension mapping API from WebKit/blackberry/Api/WebKitTextCodec and complete it.
https://bugs.webkit.org/show_bug.cgi?id=78605
Patch by Lianghui Chen <liachen@rim.com> on 2012-02-14
Reviewed by Rob Buis.
Now the MIME type and file extension mapping API are in WebKitMIMETypeConverter.
* blackberry/Api/WebKitMIMETypeConverter.cpp: Added.
(WebKit):
(BlackBerry::WebKit::getExtensionForMimeType):
(BlackBerry::WebKit::getMimeTypeForExtension):
* blackberry/Api/WebKitMIMETypeConverter.h: Added.
(WebKit):
* blackberry/Api/WebKitTextCodec.cpp:
* blackberry/Api/WebKitTextCodec.h:
* blackberry/CMakeListsBlackBerry.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 14 Feb 2012 21:02:36 +0000 (21:02 +0000)]
Crash in NavigationScheduler::schedule.
https://bugs.webkit.org/show_bug.cgi?id=78297
Reviewed by Adam Barth.
Source/WebCore:
Protect frame pointer and navigation scheduler when we stop the
load (when redirect is scheduled during a load). Also, dont fire
the navigation scheduler timer when we know that frameloader is
going away.
Test: http/tests/navigation/navigation-redirect-schedule-crash.html
* loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::schedule):
LayoutTests:
* http/tests/navigation/navigation-redirect-schedule-crash-expected.txt: Added.
* http/tests/navigation/navigation-redirect-schedule-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Tue, 14 Feb 2012 21:00:24 +0000 (21:00 +0000)]
font shorthand with inherit keyword incorrectly parsed and rendered
https://bugs.webkit.org/show_bug.cgi?id=20181
Reviewed by Tony Chang.
Source/WebCore:
As stated in http://www.w3.org/TR/CSS21/changes.html#q142
if the inherit (and also by extension initial) is encountered in the
middle of the shorthand then the property becomes invalid.
Test: fast/css/font-shorthand-mix-inherit.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
LayoutTests:
* fast/css/font-shorthand-mix-inherit-expected.txt: Added.
* fast/css/font-shorthand-mix-inherit.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Tue, 14 Feb 2012 20:45:20 +0000 (20:45 +0000)]
Crash due to incorrect firing of mutation event during class attribute parsing.
https://bugs.webkit.org/show_bug.cgi?id=78537
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/dom/class-attr-change-double-mutation-fire.html
* dom/StyledElement.cpp:
(WebCore::StyledElement::classAttributeChanged):
LayoutTests:
* fast/dom/class-attr-change-double-mutation-fire-expected.txt: Added.
* fast/dom/class-attr-change-double-mutation-fire.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 14 Feb 2012 20:29:14 +0000 (20:29 +0000)]
Finish implementing start_helper for ChromiumAndroidPort
https://bugs.webkit.org/show_bug.cgi?id=78582
Reviewed by Eric Seidel.
This patch contains the remaining odds and ends for the start_helper function.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.start_helper):
(ChromiumAndroidPort._synchronize_datetime):
(ChromiumAndroidPort):
(ChromiumAndroidPort._check_version):
(ChromiumAndroidPort._run_adb_command):
(ChromiumAndroidPort._copy_device_file):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikelawther@chromium.org [Tue, 14 Feb 2012 20:22:03 +0000 (20:22 +0000)]
CSS3 calc: add isZero implementations to catch divide by zero
https://bugs.webkit.org/show_bug.cgi?id=78603
Reviewed by Ojan Vafai.
Source/WebCore:
* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcPrimitiveValue::isZero):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcBinaryOperation::isZero):
(CSSCalcBinaryOperation):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
LayoutTests:
* css3/calc/calc-errors-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 14 Feb 2012 20:15:43 +0000 (20:15 +0000)]
[chromium] Unreviewed, marking a perf test as slow in debug and two
gpu tests as failing in debug (different scrollbar rendering).
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 20:13:14 +0000 (20:13 +0000)]
[Chromium] Expose perTilePainting setting through WebLayerTreeView::Settings interface.
https://bugs.webkit.org/show_bug.cgi?id=76937
Patch by David Reveman <reveman@chromium.org> on 2012-02-14
Reviewed by James Robinson.
Add perTilePainting to WebLayerTreeView::Settings.
* public/platform/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Tue, 14 Feb 2012 20:11:52 +0000 (20:11 +0000)]
[chromium] Layout Test media/media-document-audio-repaint.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=76580
Reviewed by James Robinson.
Make sure to call layoutTestController.display() at a stable point
(namely when the media element is paused) so that any subsequent GPU
disabling doesn't cause a complete redraw (and the test to be
flaky).
* media/media-document-audio-repaint.html:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 14 Feb 2012 19:42:05 +0000 (19:42 +0000)]
Remove inspector/protocol/page-agent.html since it is inherently flaky.
Filed https://webkit.org/b/78621 about devising a non-flaky test.
Unreviewed.
* inspector/protocol/page-agent-expected.txt: Removed.
* inspector/protocol/page-agent.html: Removed.
* inspector/protocol/resources/dummy-iframe.html: Removed.
* inspector/protocol/resources/empty.png: Removed.
* inspector/protocol/resources/font1.ttf: Removed.
* inspector/protocol/resources/font2.ttf: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 19:39:58 +0000 (19:39 +0000)]
[BlackBerry] Dragging a selection handle outside of the content bounding box does not update the selection range correctly
https://bugs.webkit.org/show_bug.cgi?id=78608
Ensure that when selection handles leave the content bounding box that
the handle not being dragged remains fixed. Do not applying padding to
a direction that would cause the selection to shrink when performing
the handle direction detection.
Patch by Ed Baker <edbaker@rim.com> on 2012-02-14
Reviewed by Rob Buis.
* blackberry/WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::clipPointToFocusNode):
(BlackBerry::WebKit::SelectionHandler::setSelection):
* blackberry/WebKitSupport/SelectionHandler.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 14 Feb 2012 19:25:31 +0000 (19:25 +0000)]
webkitpy: create ports in Workers, not in manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=78565
Reviewed by Tony Chang.
We will now create the Port object (if necessary) in the Worker
directly, so that the manager_worker_broker module doesn't need
all of this layout_test-specific logic. Part of the fixes for
bug 78171.
These changes are all well-tested by the existing tests in
run_webkit_tests_integrationtest.py.
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_Process.run):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.__init__):
(Worker.safe_init):
(Worker.run):
(Worker.cleanup):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(main): Fix a minor bug where running the 'mock-test' port didn't work right.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 14 Feb 2012 19:18:59 +0000 (19:18 +0000)]
[chromium] Unreviewed, mark some form tests as flaky.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Tue, 14 Feb 2012 19:13:44 +0000 (19:13 +0000)]
[BlackBerry] Upstream backing store related classes
https://bugs.webkit.org/show_bug.cgi?id=78517
Reviewed by Antonio Gomes.
Initial upstream, no new tests.
* blackberry/WebKitSupport/BackingStoreClient.cpp: Added.
* blackberry/WebKitSupport/BackingStoreClient.h: Added.
* blackberry/WebKitSupport/BackingStoreCompositingSurface.cpp: Added.
* blackberry/WebKitSupport/BackingStoreCompositingSurface.h: Added.
* blackberry/WebKitSupport/BackingStoreTile.cpp: Added.
* blackberry/WebKitSupport/BackingStoreTile.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 14 Feb 2012 18:44:58 +0000 (18:44 +0000)]
Source/WebCore: Don't include CachedResources that haven't downloaded when populating the Web Inspector on load.
https://webkit.org/b/78447
rdar://problem/
10843542
Reviewed by Brian Weinstein.
Test: inspector/protocol/page-agent.html
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourcesForFrame): Skip CachedFonts and CachedImages that
return true for stillNeedsLoad.
* loader/cache/CachedFont.h:
(WebCore::CachedFont::stillNeedsLoad): Added.
LayoutTests: Updated test results to exclude CachedResources that haven't downloaded.
https://webkit.org/b/78447
rdar://problem/
10843542
Reviewed by Brian Weinstein.
* inspector/protocol/page-agent-expected.txt: Updated. There is now only one font list
in the resources, when there was incorrectly two being listed. Only the font being used
is the one that downloaded and is listed now.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Tue, 14 Feb 2012 18:44:47 +0000 (18:44 +0000)]
Source/WebCore: Web Inspector: include failed and canceled in FrameResourceTree.
https://webkit.org/b/78445
Reviewed by Pavel Feldman.
Test: inspector/protocol/page-agent.html
* WebCore.xcodeproj/project.pbxproj: Added Inspector.json, Inspector-0.1.json and Inspector-1.0.json
for quick access and easy editing.
* inspector/Inspector.json: Added failed and canceled as optional properties to the object for resources in FrameResourceTree.
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrameTree): Set those properties.
LayoutTests: Test for Web Inspector: include failed and canceled in FrameResourceTree.
https://webkit.org/b/78445
Reviewed by Pavel Feldman.
* inspector/protocol/page-agent-expected.txt: Added.
* inspector/protocol/page-agent.html: Added.
* inspector/protocol/resources/dummy-iframe.html: Added.
* inspector/protocol/resources/empty.png: Added.
* inspector/protocol/resources/font1.ttf: Added.
* inspector/protocol/resources/font2.ttf: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 17:39:58 +0000 (17:39 +0000)]
[GTK] fast/forms/implicit-submission.html fails
https://bugs.webkit.org/show_bug.cgi?id=76632
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-02-14
Reviewed by Martin Robinson.
[Gtk] Rebaseline implicit-submission test expectations after r105253.
* platform/gtk/Skipped:
* platform/gtk/fast/forms/implicit-submission-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 14 Feb 2012 16:12:24 +0000 (16:12 +0000)]
Unreviewed, GTK rebaseline after r107688 and skipping some new
test failures.
* platform/gtk/Skipped:
* platform/gtk/css3/calc/getComputedStyle-margin-percentage-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 14 Feb 2012 14:28:41 +0000 (14:28 +0000)]
Typo fix after r107707.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::updateBackingStore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Tue, 14 Feb 2012 14:24:59 +0000 (14:24 +0000)]
Web Inspector: [refactoring] extract TimelineOverviewWindow from TimelineOverviewPanel
https://bugs.webkit.org/show_bug.cgi?id=78599
Reviewed by Pavel Feldman.
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype.scrollWindow):
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype.reset):
(WebInspector.TimelineOverviewWindow.prototype.scrollWindow):
(WebInspector.TimelineOverviewWindow.prototype._windowResizeDragging):
(WebInspector.TimelineOverviewWindow.prototype._dragWindow):
(WebInspector.TimelineOverviewWindow.prototype._windowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._windowDragging):
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowRight):
(WebInspector.TimelineOverviewWindow.prototype._resizeWindowMaximum):
(WebInspector.TimelineOverviewWindow.prototype._setWindowPosition):
(WebInspector.TimelineOverviewWindow.prototype._endWindowDragging):
(WebInspector.TimelinePanel.WindowSelector):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Tue, 14 Feb 2012 12:55:56 +0000 (12:55 +0000)]
Web Inspector: Make ScriptsNavigator default file selector.
https://bugs.webkit.org/show_bug.cgi?id=78349
Reviewed by Pavel Feldman.
Source/WebCore:
Moved ScriptsNavigator out of experiments.
Introduced new setting "useScriptsNavigator" with true as default value.
Updated scripts panel tests related to file selector.
Tests: inspector/debugger/scripts-combobox-file-selector-history.html
inspector/debugger/scripts-file-selector.html
* English.lproj/localizedStrings.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype._showScriptFoldersSettingChanged):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
Source/WebKit/chromium:
* src/js/Tests.js:
(.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
(.TestSuite.prototype.uiSourceCodesToString_):
(.TestSuite.prototype.nonAnonymousUISourceCodes_):
(.TestSuite.prototype._scriptsAreParsed):
(.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
(.TestSuite.prototype._waitUntilScriptsAreParsed):
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
(initialize_DebuggerTest.):
* inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Added.
* inspector/debugger/scripts-combobox-file-selector-history.html: Added.
* inspector/debugger/scripts-file-selector-expected.txt: Copied from LayoutTests/inspector/debugger/scripts-panel-expected.txt.
* inspector/debugger/scripts-file-selector.html: Added.
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:
* inspector/debugger/source-frame-count.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Tue, 14 Feb 2012 12:53:30 +0000 (12:53 +0000)]
[Qt][Texmap] Refactor backing-store code in TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=78305
Source/WebCore:
Instead of dealing with tiling inside of TextureMapperNode, we now deal with that in a new
TextureMapperBackingStore class. Since the class is abstract, WebKit2 can overload it to
support remotely-managed tiles.
The backing-store for directly composited images is handled separately, in a new class
TextureMapperCompositedImage. The TextureMapper implementation decides the dimension of
the tiles, for example 2000 in the case of OpenGL.
Also, directly composited content is now handled correctly, by painting it after the regular
content and not as part of the same texture.
To make this work, the functions in TextureMapperPlatformLayers had to become non-const,
thus the changes to that file and GraphicsContext3DQt.
Reviewed by Kenneth Rohde Christiansen.
No new functionality, no new tests.
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/graphics/opengl/TextureMapperGL.h:
(WebCore::TextureMapperGL::maxTextureDimension):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::didSynchronize):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::addChildBelow):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::getContentsLayer):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::setContentsToMedia):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::platformLayer):
(WebCore::GraphicsLayerTextureMapper::needsDisplay):
(WebCore::GraphicsLayerTextureMapper::needsDisplayRect):
* platform/graphics/texmap/TextureMapper.cpp:
* platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::maxTextureDimension):
(TextureMapper):
* platform/graphics/texmap/TextureMapperBackingStore.cpp: Added.
* platform/graphics/texmap/TextureMapperBackingStore.h: Added.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::backingStore):
(WebCore::TextureMapperNode::updateBackingStore):
(WebCore::TextureMapperNode::paint):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::intermediateSurfaceRect):
(WebCore::TextureMapperNode::paintRecursive):
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::syncCompositingState):
* platform/graphics/texmap/TextureMapperNode.h:
(TextureMapperPaintOptions):
(WebCore::TextureMapperPaintOptions::TextureMapperPaintOptions):
(WebCore::TextureMapperNode::TextureMapperNode):
(TextureMapperNode):
(WebCore::TextureMapperNode::setBackingStore):
(WebCore::TextureMapperNode::texture):
(WebCore::TextureMapperNode::layerRect):
(WebCore::TextureMapperNode::createBackingStore):
(State):
(WebCore::TextureMapperNode::State::State):
* platform/graphics/texmap/TextureMapperPlatformLayer.h:
(TextureMapperPlatformLayer):
(WebCore::TextureMapperPlatformLayer::swapBuffers):
Source/WebKit2:
Move the backing-store code to LayerTreeBackingStore, implementing the virtual functions
in TextureMapperBackingStore.
We save the double-buffered tile in the backing-store, and then convert them to regular
tiles in updateContents, based on the order of painting.
Use TextureMapperCompositedImage for images instead of saving our own composited image
registry.
Reviewed by Kenneth Rohde Christiansen.
* Target.pri:
* UIProcess/LayerTreeHostProxy.h:
(WebKit):
(LayerTreeHostProxy):
* UIProcess/qt/LayerBackingStore.cpp: Added.
* UIProcess/qt/LayerBackingStore.h: Added.
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::createLayer):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
(WebKit::LayerTreeHostProxy::getBackingStore):
(WebKit::LayerTreeHostProxy::createTile):
(WebKit::LayerTreeHostProxy::removeTile):
(WebKit::LayerTreeHostProxy::updateTile):
(WebKit::LayerTreeHostProxy::createImage):
(WebKit::LayerTreeHostProxy::assignImageToLayer):
(WebKit::LayerTreeHostProxy::purgeGLResources):
* WebProcess.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 12:48:24 +0000 (12:48 +0000)]
Use youngestShadowRoot and oldestShadowRoot instead of Element::shadowRoot().
https://bugs.webkit.org/show_bug.cgi?id=78455
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-02-14
Reviewed by Hajime Morita.
.:
Exports necessary symbols.
* Source/autotools/symbols.filter:
Source/WebCore:
Element::shadowRoot() was used for these 3 purposes.
1. checks a shadow root exists.
2. gets author shadow root.
3. gets user agent shadow root.
We have to distinguish them when implementing multiple shadow subtrees.
Calling for (1), (2), and (3) are convered to hasShadowRoot(),
ShadowRootList()->youngestShadowRoot(), and ShadowRootList()->oldestShadowRoot() respectively.
No new tests, no change in behavior.
* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
* dom/Element.cpp:
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::insertedIntoTree):
(WebCore::Element::removedFromTree):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::ensureShadowRoot):
(WebCore::Element::childrenChanged):
(WebCore::Element::focus):
* dom/Element.h:
(Element):
* dom/EventDispatcher.cpp:
(WebCore::isShadowHost):
* dom/Node.cpp:
(WebCore::shadowRoot):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::insertedIntoDocument):
(WebCore):
(WebCore::ShadowRootList::removedFromDocument):
(WebCore::ShadowRootList::insertedIntoTree):
(WebCore::ShadowRootList::removedFromTree):
(WebCore::ShadowRootList::hostChildrenChanged):
(WebCore::ShadowRootList::attach):
(WebCore::ShadowRootList::detach):
* dom/ShadowRootList.h:
(ShadowRootList):
* dom/TreeScopeAdopter.cpp:
(WebCore::shadowRootFor):
* html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
(WebCore::FileInputType::multipleAttributeChanged):
* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
(WebCore::HTMLDetailsElement::findMainSummary):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
(WebCore::HTMLKeygenElement::shadowSelect):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaControls):
(WebCore::HTMLMediaElement::hasMediaControls):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):
(WebCore::HTMLTextAreaElement::innerTextElement):
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
* html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent):
(WebCore::RangeInputType::createShadowSubtree):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::deleteBubbleTree):
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderContainer::layout):
(WebCore::trackLimiterElementOf):
* page/FocusController.cpp:
(WebCore::shadowRoot):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::uploadButton):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText):
* testing/Internals.cpp:
(WebCore::Internals::ensureShadowRoot):
(WebCore::Internals::shadowRoot):
(WebCore):
(WebCore::Internals::youngestShadowRoot):
(WebCore::Internals::oldestShadowRoot):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit2:
Exports necesarry symbols.
* win/WebKit2.def:
* win/WebKit2CFLite.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Tue, 14 Feb 2012 12:45:59 +0000 (12:45 +0000)]
Elements panel needs to be able to preview images
https://bugs.webkit.org/show_bug.cgi?id=21570
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.willHide):
(WebInspector.ElementsPanel.prototype._getPopoverAnchor):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode.resolvedNode.dimensions):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode.resolvedNode):
(WebInspector.ElementsPanel.prototype._loadDimensionsForNode):
(WebInspector.ElementsPanel.prototype._showPopover.dimensionsCallback):
(WebInspector.ElementsPanel.prototype._showPopover.showPopover):
(WebInspector.ElementsPanel.prototype._showPopover.buildPopoverContents):
(WebInspector.ElementsPanel.prototype._showPopover):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._onmousemove):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.get g):
(WebInspector.StylePropertyTreeElement.prototype.updateTitle):
* inspector/front-end/elementsPanel.css:
(.image-preview-container):
(.image-preview-container img):
LayoutTests:
* inspector/elements/elements-img-tooltip-expected.txt:
* inspector/elements/elements-img-tooltip.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Tue, 14 Feb 2012 12:36:08 +0000 (12:36 +0000)]
[chromium] check that we're not running multiple modal dialogs at the same time
https://bugs.webkit.org/show_bug.cgi?id=78486
Reviewed by Kent Tamura.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setIsDisplayingModalDialog):
(TestShell::isDisplayingModalDialog):
(TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::runModal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 14 Feb 2012 12:01:14 +0000 (12:01 +0000)]
Web Inspector: List expansion arrows is pointing down even
when the list of eventListeners are hidden in the Elements tab
https://bugs.webkit.org/show_bug.cgi?id=78360
Reviewed by Timothy Hatcher.
* inspector/front-end/elementsPanel.css:
(.section .event-bar .header):
(.section .event-bars .event-bar .header .title):
(.section .event-bar .header .subtitle):
(.section .event-bar .header::before):
(.section .event-bar.expanded .header::before):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 14 Feb 2012 11:42:06 +0000 (11:42 +0000)]
[Qt] Unreviewed gardening.
* platform/qt/Skipped: Typo fix, skip a new failing test.
* platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Updated after r107688.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Tue, 14 Feb 2012 11:37:49 +0000 (11:37 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
Unreviewed. Rebaseline #7 of N.
* platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
* platform/chromium-mac-leopard/fast/replaced/width100percent-image-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/img-layer-grow-expected.png: Added.
* platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Removed.
* platform/chromium-win/fast/replaced/width100percent-image-expected.png:
* platform/chromium-win/platform/chromium/compositing/img-layer-grow-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Tue, 14 Feb 2012 11:32:12 +0000 (11:32 +0000)]
Make ShadowRoot.nodeType return DOCUMENT_FRAGMENT_NODE.
https://bugs.webkit.org/show_bug.cgi?id=77514
Reviewed by Dimitri Glazkov.
NodeType.SHADOW_ROOT_NODE type is finally gone.
Source/WebCore:
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/objc/DOM.mm:
(kitClass):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* dom/ContainerNode.cpp:
(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):
* dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):
* dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):
* dom/Node.h:
* dom/Range.cpp:
(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):
* dom/ShadowRoot.cpp:
* dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::toShadowRoot):
* editing/FrameSelection.cpp:
(WebCore::nodeIsDetachedFromDocument):
(WebCore):
(WebCore::FrameSelection::textWillBeReplaced):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):
* html/parser/HTMLElementStack.h:
(WebCore::isInHTMLNamespace):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* xml/XPathUtil.cpp:
(WebCore::XPath::isValidContextNode):
Source/WebKit/chromium:
* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::buildContentForNode):
LayoutTests:
* fast/dom/shadow/nodetype-expected.txt:
* fast/dom/shadow/nodetype.html:
* resources/dump-as-markup.js:
(Markup._get):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Tue, 14 Feb 2012 11:01:30 +0000 (11:01 +0000)]
StylePropertySet: Try to find a CSSValuePool for identifier values.
<http://webkit.org/b/78590>
Reviewed by Antti Koivisto.
For StylePropertySets with a parent element (inline and attribute style),
grab at the parentElement()->document() to locate a CSSValuePool.
This code will change soon in the CSSOM refactoring and moreso once we
figure out how to have a global CSSValuePool, but I'm hoping it will buy
us some perf back in the meantime.
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setProperty):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 14 Feb 2012 10:54:15 +0000 (10:54 +0000)]
svg/hixie/perf has different repaint region in debug vs release
https://bugs.webkit.org/show_bug.cgi?id=78516
Reviewed by Hajime Morita.
Based on patch by Tony Chang <tony@chromium.org>.
The problem is the progress text in the lower right. It says,
"Test in progress... X of 10". Depending on how fast the test runs,
this text is never painted and the repaint region changes. Disable
painting of the intermediate text and only include the final text.
Extended Tonys original patch to cover all svg/hixie/perf tests that
suffered from this issue - also avoid using setTimeout between the
individual steps, as we're only interessted in the final repaint
region, not the intermediate ones.
* platform/mac/svg/hixie/perf/001-expected.png:
* platform/mac/svg/hixie/perf/002-expected.png:
* platform/mac/svg/hixie/perf/003-expected.png:
* svg/hixie/perf/001.xml:
* svg/hixie/perf/002.xml:
* svg/hixie/perf/003.xml:
* svg/hixie/perf/004.xml:
* svg/hixie/perf/005.xml:
* svg/hixie/perf/006.xml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 14 Feb 2012 10:41:03 +0000 (10:41 +0000)]
Enable the GPU codepath in the chromium-android port
https://bugs.webkit.org/show_bug.cgi?id=78580
Reviewed by James Robinson.
Suprise! There is no ChromiumGpuAndroidPort! Instead, Chromium
Android always uses the GPU codepath, so we set the GPU flags on the
main chromium-android port instead.
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 14 Feb 2012 10:38:54 +0000 (10:38 +0000)]
NRWT should expose --adb-args flag for Android
https://bugs.webkit.org/show_bug.cgi?id=78579
Reviewed by Eric Seidel.
This flag is already wired up to the ChromiumAndroidPort.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 10:35:58 +0000 (10:35 +0000)]
[Chromium] Inconsistent initialization of CCSettings in WebLayerTreeView.
https://bugs.webkit.org/show_bug.cgi?id=76927
Patch by David Reveman <reveman@chromium.org> on 2012-02-14
Reviewed by James Robinson.
Remove unnecessary initialization and include maxPartialTextureUpdates
in FIXME comment.
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 14 Feb 2012 10:21:20 +0000 (10:21 +0000)]
2012-02-14 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add mixing Lion pixel test result for a svg/carto.net test.
* platform/mac/svg/carto.net/scrollbar-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 14 Feb 2012 10:19:08 +0000 (10:19 +0000)]
Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422
Reviewed by Hajime Morita.
Fix last-minute typo in clearTimesWithDynamicOrigins, leading to assertions browsing the W3C SVG animation tests.
Covered by existing tests in svg/animations.
* svg/SVGAnimationElement.cpp: Remove unused endedActiveInterval.
* svg/SVGAnimationElement.h: Ditto.
* svg/animation/SVGSMILElement.cpp:
(WebCore::clearTimesWithDynamicOrigins): Fix order of walking the times list.
(WebCore::SVGSMILElement::reset): Move calls to clearTimesWithDynamicOrigins into endedActiveInterval.
(WebCore::SVGSMILElement::endedActiveInterval):
* svg/animation/SVGSMILElement.h:
(SVGSMILElement): Devirtualize endedActiveInterval.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 14 Feb 2012 10:04:12 +0000 (10:04 +0000)]
[Qt] Unreviewed gardening, skip new failing tests.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 14 Feb 2012 09:55:28 +0000 (09:55 +0000)]
Unreviewed, rolling out r107661.
http://trac.webkit.org/changeset/107661
https://bugs.webkit.org/show_bug.cgi?id=78591
crash on lion/qt bots (Requested by hayato on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-02-14
Source/WebCore:
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/objc/DOM.mm:
(kitClass):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* dom/ContainerNode.cpp:
(WebCore::collectTargetNodes):
(WebCore::ContainerNode::replaceChild):
* dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::childTypeAllowed):
(WebCore::Document::canReplaceChild):
* dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupPrefix):
(WebCore::Node::lookupNamespaceURI):
(WebCore::appendTextContent):
(WebCore::Node::setTextContent):
* dom/Node.h:
* dom/Range.cpp:
(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::insertNode):
(WebCore::Range::checkNodeWOffset):
(WebCore::Range::checkNodeBA):
(WebCore::Range::selectNode):
(WebCore::Range::selectNodeContents):
(WebCore::Range::surroundContents):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::nodeType):
(WebCore):
* dom/ShadowRoot.h:
(ShadowRoot):
(WebCore::toShadowRoot):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::textWillBeReplaced):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::pushRootNode):
* html/parser/HTMLElementStack.h:
(WebCore::isInHTMLNamespace):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* xml/XPathUtil.cpp:
(WebCore::XPath::isValidContextNode):
Source/WebKit/chromium:
* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::buildContentForNode):
LayoutTests:
* fast/dom/shadow/nodetype-expected.txt:
* fast/dom/shadow/nodetype.html:
* resources/dump-as-markup.js:
(Markup._get):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Tue, 14 Feb 2012 09:52:47 +0000 (09:52 +0000)]
Fix typo. HTMLContentSeleciton -> HTMLContentSelection.
https://bugs.webkit.org/show_bug.cgi?id=78571
Reviewed by Hajime Morita.
No tests. No change in behavior.
* dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::insertionPointFor):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::attach):
* html/shadow/HTMLContentSelector.cpp:
(WebCore::HTMLContentSelection::append):
(WebCore::HTMLContentSelection::unlink):
(WebCore::HTMLContentSelectionList::find):
(WebCore::HTMLContentSelectionList::append):
(WebCore::HTMLContentSelector::select):
(WebCore::HTMLContentSelector::unselect):
(WebCore::HTMLContentSelector::findFor):
* html/shadow/HTMLContentSelector.h:
(HTMLContentSelection):
(WebCore::HTMLContentSelection::next):
(WebCore::HTMLContentSelection::previous):
(WebCore::HTMLContentSelection::HTMLContentSelection):
(WebCore::HTMLContentSelection::create):
(WebCore::HTMLContentSelectionList::first):
(WebCore::HTMLContentSelectionList::last):
(HTMLContentSelectionList):
(WebCore::HTMLContentSelectionSet::add):
(WebCore::HTMLContentSelectionSet::remove):
(HTMLContentSelectionSet):
(WebCore::HTMLContentSelectionSet::Translator::equal):
(WebCore::HTMLContentSelectionSet::Hash::hash):
(WebCore::HTMLContentSelectionSet::Hash::equal):
(WebCore::HTMLContentSelectionSet::find):
(HTMLContentSelector):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 14 Feb 2012 09:50:41 +0000 (09:50 +0000)]
[Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
https://bugs.webkit.org/show_bug.cgi?id=78541
<rdar://problem/
10036695>
Reviewed by Kent Tamura.
Source/WebKit/mac:
* WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed default value of the
preference.
Source/WebKit/win:
* WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default value of
the preference
Source/WebKit2:
* Shared/WebPreferencesStore.h: (WebKit): Changed default value of the preference.
Tools:
* DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
After each test, reset to using new protocol.
LayoutTests:
* http/tests/websocket/tests/hixie76/alert-in-event-handler.html:
* http/tests/websocket/tests/hixie76/bad-handshake-crash.html:
* http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars.html:
* http/tests/websocket/tests/hixie76/bad-sub-protocol-empty.html:
* http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii.html:
* http/tests/websocket/tests/hixie76/bufferedAmount-after-close.html:
* http/tests/websocket/tests/hixie76/client-close.html:
* http/tests/websocket/tests/hixie76/close-before-open.html:
* http/tests/websocket/tests/hixie76/close-event.html:
* http/tests/websocket/tests/hixie76/close-on-navigate-new-location.html:
* http/tests/websocket/tests/hixie76/close-on-unload-and-force-gc.html:
* http/tests/websocket/tests/hixie76/close-on-unload-reference-in-parent.html:
* http/tests/websocket/tests/hixie76/close-on-unload.html:
* http/tests/websocket/tests/hixie76/close-unref-websocket.html:
* http/tests/websocket/tests/hixie76/cross-origin.html:
* http/tests/websocket/tests/hixie76/error-detect.html:
* http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer.html:
* http/tests/websocket/tests/hixie76/frame-length-overflow.html:
* http/tests/websocket/tests/hixie76/frame-length-skip.html:
* http/tests/websocket/tests/hixie76/frame-lengths.html:
* http/tests/websocket/tests/hixie76/handshake-challenge-randomness.html:
* http/tests/websocket/tests/hixie76/handshake-error.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-cross-origin.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null.html:
* http/tests/websocket/tests/hixie76/handshake-fail-by-sub-protocol-mismatch.html:
* http/tests/websocket/tests/hixie76/long-invalid-header.html:
* http/tests/websocket/tests/hixie76/multiple-connections.html:
* http/tests/websocket/tests/hixie76/null-character.html:
* http/tests/websocket/tests/hixie76/reload-crash.html:
* http/tests/websocket/tests/hixie76/send-after-close-on-unload.html:
* http/tests/websocket/tests/hixie76/send-empty.html:
* http/tests/websocket/tests/hixie76/send-object.html:
* http/tests/websocket/tests/hixie76/send-throw.html:
* http/tests/websocket/tests/hixie76/send.html:
* http/tests/websocket/tests/hixie76/server-close.html:
* http/tests/websocket/tests/hixie76/simple-stress.html:
* http/tests/websocket/tests/hixie76/simple.html:
* http/tests/websocket/tests/hixie76/split-binary-frame-header.html:
* http/tests/websocket/tests/hixie76/sub-protocol-with-space.html:
* http/tests/websocket/tests/hixie76/sub-protocol.html:
* http/tests/websocket/tests/hixie76/undefined-attributes.html:
* http/tests/websocket/tests/hixie76/unicode.html:
* http/tests/websocket/tests/hixie76/url-attribute.html:
* http/tests/websocket/tests/hixie76/url-no-trailing-slash.html:
* http/tests/websocket/tests/hixie76/url-parsing.html:
* http/tests/websocket/tests/hixie76/url-with-credential.html:
* http/tests/websocket/tests/hixie76/url-with-empty-query.html:
* http/tests/websocket/tests/hixie76/url-with-query-for-no-query.html:
* http/tests/websocket/tests/hixie76/url-with-query.html:
* http/tests/websocket/tests/hixie76/websocket-event-target.html:
* http/tests/websocket/tests/hixie76/websocket-pending-activity.html:
* http/tests/websocket/tests/hixie76/websocket-protocol-ignored.html:
* http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html:
* http/tests/websocket/tests/hixie76/workers/close-in-shared-worker.html:
* http/tests/websocket/tests/hixie76/workers/close-in-worker.html:
* http/tests/websocket/tests/hixie76/workers/shared-worker-simple.html:
* http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html:
* http/tests/websocket/tests/hixie76/workers/worker-simple.html:
Added overridePreference calls, so that the tests don't depend on platform or DRT default.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikelawther@chromium.org [Tue, 14 Feb 2012 09:46:48 +0000 (09:46 +0000)]
CSS3 calc: embed calc expressions in CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=78446
Source/WebCore:
Reviewed by Ojan Vafai.
Adds calc expressions to CSSPrimitiveValue. This enables simple (ie no mixing of
percents with numbers/lengths) expressions to be evaluated on most properties.
Tests: css3/calc/block-mask-overlay-image-outset-expected.html
css3/calc/css3-radial-gradients-expected.html
css3/calc/gradient-color-stops-expected.html
* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(CSSCalcValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::init):
(WebCore):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::getDoubleValue):
(WebCore::CSSPrimitiveValue::getDoubleValueInternal):
(WebCore::CSSPrimitiveValue::customCssText):
* css/CSSPrimitiveValue.h:
(WebCore):
(WebCore::CSSPrimitiveValue::isLength):
(WebCore::CSSPrimitiveValue::isNumber):
(WebCore::CSSPrimitiveValue::isPercentage):
(WebCore::CSSPrimitiveValue::isPx):
(WebCore::CSSPrimitiveValue::isCalculated):
(WebCore::CSSPrimitiveValue::isCalculatedPercentageNumber):
(WebCore::CSSPrimitiveValue::isCalculatedPercentageLength):
(CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::getValue):
(WebCore::CSSPrimitiveValue::cssCalcValue):
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyBorderRadius::applyValue):
LayoutTests:
Reviewed by Ojan Vafai.
* css3/calc/block-mask-overlay-image-outset-expected.html: Renamed from LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html.
* css3/calc/border-expected.txt:
* css3/calc/calc-errors-expected.txt:
* css3/calc/css3-radial-gradients-expected.html: Renamed from LayoutTests/css3/calc/css3-radial-gradients-expected-mismatch.html.
* css3/calc/font-expected.txt:
* css3/calc/font-monospace-expected.txt:
* css3/calc/font-size-expected.txt:
* css3/calc/font-size-fractional-expected.txt:
* css3/calc/getComputedStyle-margin-percentage-expected.txt:
* css3/calc/gradient-color-stops-expected.html: Renamed from LayoutTests/css3/calc/gradient-color-stops-expected-mismatch.html.
* css3/calc/line-height-expected.txt:
* css3/calc/margin-expected.txt:
* css3/calc/padding-expected.txt:
* css3/calc/simple-calcs-expected.txt:
* css3/calc/table-border-spacing-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Tue, 14 Feb 2012 09:24:30 +0000 (09:24 +0000)]
Not reviewed: follow up to r107683: protect inspector sidebar from updating
while inserting new rule.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 14 Feb 2012 09:22:14 +0000 (09:22 +0000)]
Unreviewed, GTK rebaseline after r107662.
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc