platform/upstream/libHarfBuzzSharp.git
5 years ago[serialize] Implement for ClassDef
Behdad Esfahbod [Thu, 13 Dec 2018 21:01:45 +0000 (16:01 -0500)]
[serialize] Implement for ClassDef

5 years ago[serialize] Implement for ClassDefFormat2
Behdad Esfahbod [Thu, 13 Dec 2018 20:57:12 +0000 (15:57 -0500)]
[serialize] Implement for ClassDefFormat2

5 years ago[serialize] Implement for ClassDefFormat1
Behdad Esfahbod [Thu, 13 Dec 2018 20:50:13 +0000 (15:50 -0500)]
[serialize] Implement for ClassDefFormat1

5 years ago[subset] Minor
Behdad Esfahbod [Thu, 13 Dec 2018 02:21:26 +0000 (21:21 -0500)]
[subset] Minor

5 years ago[CFF] bad offset in Index (#1476)
Michiharu Ariza [Thu, 13 Dec 2018 02:08:15 +0000 (18:08 -0800)]
[CFF] bad offset in Index (#1476)

* Update hb-ot-cff-common.hh

* fix bug

* bummer fix wasn't hit. refix

* additional sanity check

* Added test cases for oss-fuzz issues 11805, 11806

5 years ago[CFF] check out of range FD index (#1477)
Michiharu Ariza [Thu, 13 Dec 2018 01:36:01 +0000 (17:36 -0800)]
[CFF] check out of range FD index (#1477)

* add fd index checks to subr subsetter

also added oss-fuzz test case

* undid SubrSubsetParam::is_valid

because already validated by SubrClosures.valid

5 years ago[util/hb-subset] Add --layout to keep GDEF/GSUB/GPOS
Behdad Esfahbod [Wed, 12 Dec 2018 16:32:57 +0000 (11:32 -0500)]
[util/hb-subset] Add --layout to keep GDEF/GSUB/GPOS

Will become default and option removed in the future.

5 years ago[dispatch] Minor
Behdad Esfahbod [Wed, 12 Dec 2018 15:07:38 +0000 (10:07 -0500)]
[dispatch] Minor

5 years ago[sanitize] Fix sanitizing sublookup array
Behdad Esfahbod [Wed, 12 Dec 2018 14:56:47 +0000 (09:56 -0500)]
[sanitize] Fix sanitizing sublookup array

5 years ago[dispatch] Minor
Behdad Esfahbod [Wed, 12 Dec 2018 14:50:18 +0000 (09:50 -0500)]
[dispatch] Minor

5 years agoRevert "Minor fix re sanitize of Lookup subtables"
Behdad Esfahbod [Wed, 12 Dec 2018 14:44:30 +0000 (09:44 -0500)]
Revert "Minor fix re sanitize of Lookup subtables"

This reverts commit 7146718bef81492e13aede0a2801cda1da41ce35.

Fixing differently.

5 years agominor style fix, use void in methods on no argument
Ebrahim Byagowi [Wed, 12 Dec 2018 11:44:37 +0000 (15:14 +0330)]
minor style fix, use void in methods on no argument

5 years agoMerge pull request #1474 from fanc999/master.msvc
Ebrahim Byagowi [Wed, 12 Dec 2018 09:14:06 +0000 (12:44 +0330)]
Merge pull request #1474 from fanc999/master.msvc

Few fixes for Visual Studio builds

5 years agoMinor fix re sanitize of Lookup subtables
Behdad Esfahbod [Wed, 12 Dec 2018 04:44:29 +0000 (23:44 -0500)]
Minor fix re sanitize of Lookup subtables

We were dereferencing Null pointers and trying to sanitize them,
which is not necessary...

5 years agoMinor
Behdad Esfahbod [Wed, 12 Dec 2018 04:07:48 +0000 (23:07 -0500)]
Minor

5 years ago[subset] Map glyphs during SingleSubst subsetting
Behdad Esfahbod [Wed, 12 Dec 2018 03:53:58 +0000 (22:53 -0500)]
[subset] Map glyphs during SingleSubst subsetting

Ha!

5 years ago[subset] Minor
Behdad Esfahbod [Wed, 12 Dec 2018 03:48:27 +0000 (22:48 -0500)]
[subset] Minor

5 years ago[serialize] Break down assert
Behdad Esfahbod [Wed, 12 Dec 2018 02:18:47 +0000 (21:18 -0500)]
[serialize] Break down assert

5 years agoMinor
Behdad Esfahbod [Tue, 11 Dec 2018 22:28:04 +0000 (17:28 -0500)]
Minor

5 years ago[CFF] oss-fuzz issue 11690 ASSERT: substr.offset >= opStart (#1461)
Michiharu Ariza [Tue, 11 Dec 2018 20:21:24 +0000 (12:21 -0800)]
[CFF] oss-fuzz issue 11690 ASSERT: substr.offset >= opStart (#1461)

* fix oss-fuzz 11690: substr.offset >= opStart

detect recursive subroutine call & handle as error

* fix build failure

* add minimized test case for oss-fuzz 11690

* removed asserts

5 years agominimize use of assert: removed or changed to error handling (#1467)
Michiharu Ariza [Tue, 11 Dec 2018 20:20:20 +0000 (12:20 -0800)]
minimize use of assert: removed or changed to error handling (#1467)

5 years ago[ci] Fix Travis macOS bot ICU issue (#1472)
Ebrahim Byagowi [Tue, 11 Dec 2018 19:32:52 +0000 (23:02 +0330)]
[ci] Fix Travis macOS bot ICU issue (#1472)

5 years ago[ucdn] Fix header
👻 [Tue, 11 Dec 2018 18:38:05 +0000 (13:38 -0500)]
[ucdn] Fix header

Fixes https://github.com/harfbuzz/harfbuzz/issues/1470

5 years agoCorrect REPLACEMENT CHARACTER's code point to FFFD (#1471)
David Corbett [Tue, 11 Dec 2018 18:19:17 +0000 (13:19 -0500)]
Correct REPLACEMENT CHARACTER's code point to FFFD (#1471)

5 years agotest/api: Fix building on pre-C99 compilers
Chun-wei Fan [Tue, 11 Dec 2018 17:32:01 +0000 (01:32 +0800)]
test/api: Fix building on pre-C99 compilers

Ensure variables are declared at the top of the block.

5 years agoCMake: Fix Introspection builds
Chun-wei Fan [Tue, 11 Dec 2018 17:23:53 +0000 (01:23 +0800)]
CMake: Fix Introspection builds

We need to add -DHB_AAT_H and -DHB_AAT_H_IN to the flags that are passed
to g-ir-scanner, so that introspection builds can proceed normally.

5 years ago[glyf] minor
Ebrahim Byagowi [Sat, 8 Dec 2018 10:27:39 +0000 (13:57 +0330)]
[glyf] minor

5 years ago[os2] Move typometrics detection logic to the table (#1465)
Ebrahim Byagowi [Sat, 8 Dec 2018 10:10:44 +0000 (13:40 +0330)]
[os2] Move typometrics detection logic to the table (#1465)

5 years agoApply non-controversial parts of ot-style (#1464)
Ebrahim Byagowi [Sat, 8 Dec 2018 06:50:25 +0000 (10:20 +0330)]
Apply non-controversial parts of ot-style (#1464)

Things to be used in https://github.com/harfbuzz/harfbuzz/pull/1459

5 years agofix for issue #1447 (#1462)
Michiharu Ariza [Sat, 8 Dec 2018 04:49:39 +0000 (20:49 -0800)]
fix for issue #1447 (#1462)

Added case for OpCode_BaseFontName. This opcode in spec but practically unused.
Added a comment for default case which can't be hit

5 years ago[fdsc] minor
Ebrahim Byagowi [Fri, 7 Dec 2018 19:04:12 +0000 (22:34 +0330)]
[fdsc] minor

5 years ago[CFF] Refix oss-fuzz 11714: set_blends (PR #1458) (#1460)
Michiharu Ariza [Thu, 6 Dec 2018 21:36:26 +0000 (13:36 -0800)]
[CFF] Refix oss-fuzz 11714: set_blends (PR #1458) (#1460)

* pass subarray of stack to set_blends

* get_subarray to return a value, not ref

* restored error check (with tweak)

5 years agoFix likely check
Behdad Esfahbod [Thu, 6 Dec 2018 18:27:37 +0000 (10:27 -0800)]
Fix likely check

Ouch!

5 years agoAdd default value to first argument of sub_array()
Behdad Esfahbod [Thu, 6 Dec 2018 18:26:32 +0000 (10:26 -0800)]
Add default value to first argument of sub_array()

5 years agoAdd sub_array to hb_vector_t
Behdad Esfahbod [Thu, 6 Dec 2018 18:21:06 +0000 (10:21 -0800)]
Add sub_array to hb_vector_t

5 years agoAdd default-value for second arg of sub_array()
Behdad Esfahbod [Thu, 6 Dec 2018 18:19:03 +0000 (10:19 -0800)]
Add default-value for second arg of sub_array()

5 years agoMerge pull request #1458 from harfbuzz/cff-check-blends
Ebrahim Byagowi [Thu, 6 Dec 2018 06:51:00 +0000 (10:21 +0330)]
Merge pull request #1458 from harfbuzz/cff-check-blends

[CFF] oss-fuzz issue 11714: set_blends

5 years agoadd minimized test case for oss-fuzz issue 11714
Michiharu Ariza [Thu, 6 Dec 2018 05:47:34 +0000 (21:47 -0800)]
add minimized test case for oss-fuzz issue 11714

5 years agoMerge branch 'master' into cff-check-blends
Michiharu Ariza [Thu, 6 Dec 2018 05:37:38 +0000 (21:37 -0800)]
Merge branch 'master' into cff-check-blends

5 years agocheck number of blends against args on stack
Michiharu Ariza [Thu, 6 Dec 2018 05:33:29 +0000 (21:33 -0800)]
check number of blends against args on stack

5 years agoMerge pull request #1457 from harfbuzz/cff-varstore-sanitize
Ebrahim Byagowi [Thu, 6 Dec 2018 05:03:44 +0000 (08:33 +0330)]
Merge pull request #1457 from harfbuzz/cff-varstore-sanitize

[CFF] oss-fuzz issue 11713 (CFF2VariationStore::serialize)

5 years agoMerge pull request #1456 from harfbuzz/cff-subr-sanitize
Behdad Esfahbod [Thu, 6 Dec 2018 01:37:21 +0000 (17:37 -0800)]
Merge pull request #1456 from harfbuzz/cff-subr-sanitize

[CFF] fix oss-fuzz issue 11691 (BlendArg::set_blends)

5 years agoadd minimized test case for oss-fuzz issue 11713
Michiharu Ariza [Thu, 6 Dec 2018 01:14:51 +0000 (17:14 -0800)]
add minimized test case for oss-fuzz issue 11713

5 years agosanitize variationStore in CFF2 against its size
Michiharu Ariza [Thu, 6 Dec 2018 01:04:55 +0000 (17:04 -0800)]
sanitize variationStore in CFF2 against its size

5 years agoMerge branch 'master' into cff-subr-sanitize
Michiharu Ariza [Wed, 5 Dec 2018 23:50:05 +0000 (15:50 -0800)]
Merge branch 'master' into cff-subr-sanitize

5 years agoadd minimized test case for oss-fuzz issue 11691
Michiharu Ariza [Wed, 5 Dec 2018 23:49:11 +0000 (15:49 -0800)]
add minimized test case for oss-fuzz issue 11691

5 years agoMerge pull request #1454 from harfbuzz/cff-fixbcd
Behdad Esfahbod [Wed, 5 Dec 2018 23:39:34 +0000 (15:39 -0800)]
Merge pull request #1454 from harfbuzz/cff-fixbcd

[CFF] fix oss-fuzz issue 11674: parse_bcd

5 years agoMerge pull request #1455 from harfbuzz/cff-strinc_assert
Behdad Esfahbod [Wed, 5 Dec 2018 23:37:15 +0000 (15:37 -0800)]
Merge pull request #1455 from harfbuzz/cff-strinc_assert

[CFF] fix oss-fuzz issue 11675 (ASSERT: count <= str.len)

5 years agosanitize CFF1 & CFF2 global subrs
Michiharu Ariza [Wed, 5 Dec 2018 23:07:46 +0000 (15:07 -0800)]
sanitize CFF1 & CFF2 global subrs

5 years agofix oss-fuzz issue 11675 (ASSERT: count <= str.len)
Michiharu Ariza [Wed, 5 Dec 2018 20:51:18 +0000 (12:51 -0800)]
fix oss-fuzz issue 11675 (ASSERT: count <= str.len)

Also added an additional error check to avail ()

5 years agominimized test case for oss-fuzz issue 11674
Michiharu Ariza [Wed, 5 Dec 2018 20:23:58 +0000 (12:23 -0800)]
minimized test case for oss-fuzz issue 11674

5 years agoMerge branch 'master' into cff-fixbcd
Michiharu Ariza [Wed, 5 Dec 2018 19:25:29 +0000 (11:25 -0800)]
Merge branch 'master' into cff-fixbcd

5 years agofixed a bug with fractional part in a negative value
Michiharu Ariza [Wed, 5 Dec 2018 19:18:16 +0000 (11:18 -0800)]
fixed a bug with fractional part in a negative value

5 years ago[os2] Make newer table fields accessible (#1452)
Ebrahim Byagowi [Wed, 5 Dec 2018 11:53:41 +0000 (15:23 +0330)]
[os2] Make newer table fields accessible (#1452)

5 years ago[fdsc] Implement the table parsing
Ebrahim Byagowi [Wed, 5 Dec 2018 10:47:37 +0000 (14:17 +0330)]
[fdsc] Implement the table parsing

Related to https://github.com/harfbuzz/harfbuzz/issues/1337

May used in addition to an API related to STAT.

Lots of Apple fonts have it.

5 years ago[gasp] Implement the table parsing
Ebrahim Byagowi [Wed, 5 Dec 2018 10:21:14 +0000 (13:51 +0330)]
[gasp] Implement the table parsing

May or may not be used in https://github.com/harfbuzz/harfbuzz/pull/1432

5 years agoMerge pull request #1449 from harfbuzz/cff-fixcharset
Ebrahim Byagowi [Wed, 5 Dec 2018 09:55:18 +0000 (13:25 +0330)]
Merge pull request #1449 from harfbuzz/cff-fixcharset

[CFF] fix for oss-fuzz 11657: Charset overrun

5 years agoMerge pull request #1448 from harfbuzz/cff-leak
Ebrahim Byagowi [Wed, 5 Dec 2018 09:53:23 +0000 (13:23 +0330)]
Merge pull request #1448 from harfbuzz/cff-leak

[CFF] fix leak: oss-fuzz 11662

5 years agofix unsigned long const
Michiharu Ariza [Wed, 5 Dec 2018 08:36:11 +0000 (00:36 -0800)]
fix unsigned long const

5 years agofix signed/unsigned comparison
Michiharu Ariza [Wed, 5 Dec 2018 08:26:03 +0000 (00:26 -0800)]
fix signed/unsigned comparison

5 years agouse sized int types in parse_bcd
Michiharu Ariza [Wed, 5 Dec 2018 07:58:26 +0000 (23:58 -0800)]
use sized int types in parse_bcd

5 years agorefix
Michiharu Ariza [Wed, 5 Dec 2018 07:23:23 +0000 (23:23 -0800)]
refix

5 years agofix bug
Michiharu Ariza [Wed, 5 Dec 2018 07:18:28 +0000 (23:18 -0800)]
fix bug

5 years agofix typo
Michiharu Ariza [Wed, 5 Dec 2018 06:40:07 +0000 (22:40 -0800)]
fix typo

5 years agoinclude float.h
Michiharu Ariza [Wed, 5 Dec 2018 06:30:33 +0000 (22:30 -0800)]
include float.h

5 years agocheck overflow & clamp
Michiharu Ariza [Wed, 5 Dec 2018 06:24:38 +0000 (22:24 -0800)]
check overflow & clamp

5 years ago[CFF] fix oss-fuzz issue 11670: NULL dereference (#1450)
Michiharu Ariza [Wed, 5 Dec 2018 05:32:34 +0000 (21:32 -0800)]
[CFF] fix oss-fuzz issue 11670: NULL dereference (#1450)

* guard against no subr access

* code tweak

* add minimized testcase for oss-fuzz 11670 (Null deference)

5 years agoadded minimized testcase for oss-fuzz issue 11657
Michiharu Ariza [Tue, 4 Dec 2018 22:17:03 +0000 (14:17 -0800)]
added minimized testcase for oss-fuzz issue 11657

5 years agofix oss-fuzz 11657: buffer overrun
Michiharu Ariza [Tue, 4 Dec 2018 21:51:26 +0000 (13:51 -0800)]
fix oss-fuzz 11657: buffer overrun

Check overrun in Charset1_2::get_glyph

5 years agoReuse hb_aat_layout_has_* logic in coretext-aat detection logic (#1442)
Ebrahim Byagowi [Tue, 4 Dec 2018 20:12:13 +0000 (23:42 +0330)]
Reuse hb_aat_layout_has_* logic in coretext-aat detection logic (#1442)

5 years agoMerge branch 'master' into cff-leak
Michiharu Ariza [Tue, 4 Dec 2018 19:01:26 +0000 (11:01 -0800)]
Merge branch 'master' into cff-leak

5 years agoadd unlikely to error handling
Michiharu Ariza [Tue, 4 Dec 2018 18:39:17 +0000 (10:39 -0800)]
add unlikely to error handling

5 years agoadded minimized test case for oss-fuzz issue 11662
Michiharu Ariza [Tue, 4 Dec 2018 18:30:35 +0000 (10:30 -0800)]
added minimized test case for oss-fuzz issue 11662

5 years agomore leak fixes
Michiharu Ariza [Tue, 4 Dec 2018 18:22:35 +0000 (10:22 -0800)]
more leak fixes

5 years agoMerge pull request #1444 from harfbuzz/cff-assert
Ebrahim Byagowi [Tue, 4 Dec 2018 18:00:07 +0000 (21:30 +0330)]
Merge pull request #1444 from harfbuzz/cff-assert

removed assert, fixes https://github.com/harfbuzz/harfbuzz/issues/1443

5 years agofix attempt for oss-fuzz 11662 leak
Michiharu Ariza [Tue, 4 Dec 2018 17:58:48 +0000 (09:58 -0800)]
fix attempt for oss-fuzz 11662 leak

5 years agoremoved assert
Michiharu Ariza [Tue, 4 Dec 2018 17:24:07 +0000 (09:24 -0800)]
removed assert

5 years agoMerge pull request #1441 from harfbuzz/cff-doublenum
Behdad Esfahbod [Tue, 4 Dec 2018 09:14:13 +0000 (04:14 -0500)]
Merge pull request #1441 from harfbuzz/cff-doublenum

use double as CFF Number implementation

5 years agomore double changes
Michiharu Ariza [Tue, 4 Dec 2018 00:59:41 +0000 (16:59 -0800)]
more double changes

5 years agoadded minimized test cases
Michiharu Ariza [Tue, 4 Dec 2018 00:18:10 +0000 (16:18 -0800)]
added minimized test cases

5 years agoadditional precision made a difference in extents test
Michiharu Ariza [Tue, 4 Dec 2018 00:06:58 +0000 (16:06 -0800)]
additional precision made a difference in extents test

5 years agomore double changes
Michiharu Ariza [Mon, 3 Dec 2018 23:32:42 +0000 (15:32 -0800)]
more double changes

5 years agoNumber to use double for all types
Michiharu Ariza [Mon, 3 Dec 2018 22:48:46 +0000 (14:48 -0800)]
Number to use double for all types

5 years agoMerge pull request #1439 from ebraminio/tracking
Behdad Esfahbod [Mon, 3 Dec 2018 19:30:51 +0000 (14:30 -0500)]
Merge pull request #1439 from ebraminio/tracking

[aat] Expose hb_aat_layout_has_tracking API

5 years ago[aat] Expose hb_aat_layout_has_tracking API
Ebrahim Byagowi [Mon, 3 Dec 2018 18:34:48 +0000 (22:04 +0330)]
[aat] Expose hb_aat_layout_has_tracking API

5 years ago[aat] Expose a couple APIs
Behdad Esfahbod [Mon, 3 Dec 2018 15:41:37 +0000 (10:41 -0500)]
[aat] Expose a couple APIs

New API:
+hb_aat_layout_has_substitution()
+hb_aat_layout_has_positioning()

5 years ago[aat] Fix division sign fallout
Behdad Esfahbod [Sun, 2 Dec 2018 17:38:53 +0000 (12:38 -0500)]
[aat] Fix division sign fallout

Happened after 11d2f49af8f53340134c844173f4d8655b00dea3
since now nClasses is unsigned int...

5 years agoAdd casts to hb_array_t<>
Behdad Esfahbod [Sun, 2 Dec 2018 01:04:45 +0000 (20:04 -0500)]
Add casts to hb_array_t<>

5 years agoSimplify build source list
Behdad Esfahbod [Sun, 2 Dec 2018 00:34:18 +0000 (19:34 -0500)]
Simplify build source list

5 years agoMinor
Behdad Esfahbod [Sun, 2 Dec 2018 00:28:17 +0000 (19:28 -0500)]
Minor

5 years agoNew approach to change BigEndian casts to be int-sized
Behdad Esfahbod [Sat, 1 Dec 2018 18:12:21 +0000 (13:12 -0500)]
New approach to change BigEndian casts to be int-sized

Fixes spurious warnings like:
Fixes https://github.com/harfbuzz/harfbuzz/issues/1436

5 years agoChange hb_assert_unsigned_t<> to hb_is_signed<>
Behdad Esfahbod [Sat, 1 Dec 2018 18:03:52 +0000 (13:03 -0500)]
Change hb_assert_unsigned_t<> to hb_is_signed<>

5 years agoRevert "Change BigEndian casts to be int-sized"
Behdad Esfahbod [Sat, 1 Dec 2018 05:14:48 +0000 (00:14 -0500)]
Revert "Change BigEndian casts to be int-sized"

This reverts commit eb5ddd32bf4e458ca0af8d5784f8fd46485ad225.

Broke tests, badly.  To be investigated and reenabled.

5 years agoMinor
Behdad Esfahbod [Sat, 1 Dec 2018 05:04:29 +0000 (00:04 -0500)]
Minor

5 years agoChange BigEndian casts to be int-sized
Behdad Esfahbod [Sat, 1 Dec 2018 05:03:01 +0000 (00:03 -0500)]
Change BigEndian casts to be int-sized

Fixes spurious warnings like:
Fixes https://github.com/harfbuzz/harfbuzz/issues/1436

5 years agoFix more warning
Behdad Esfahbod [Sat, 1 Dec 2018 04:38:24 +0000 (23:38 -0500)]
Fix more warning

5 years agoFix warning
Behdad Esfahbod [Sat, 1 Dec 2018 04:20:50 +0000 (23:20 -0500)]
Fix warning

5 years ago[CFF] Change spaces to tabs
Behdad Esfahbod [Sat, 1 Dec 2018 04:04:59 +0000 (23:04 -0500)]
[CFF] Change spaces to tabs

5 years ago[CFF] Whitespace
Behdad Esfahbod [Sat, 1 Dec 2018 03:54:57 +0000 (22:54 -0500)]
[CFF] Whitespace

5 years agoMinor
Behdad Esfahbod [Sat, 1 Dec 2018 03:54:20 +0000 (22:54 -0500)]
Minor