Nick Zitzmann [Sun, 24 Feb 2013 22:39:15 +0000 (15:39 -0700)]
darwinssl: fix undefined $ssllib warning in runtests.pl
I also added --with-darwinssl to the list of SSL options in configure.
Steve Holme [Sun, 24 Feb 2013 19:23:33 +0000 (19:23 +0000)]
imap: Added check for new internal imap response code
Steve Holme [Sun, 24 Feb 2013 16:14:16 +0000 (16:14 +0000)]
imap: Changed the order of the response types in imap_endofresp()
From a maintenance point of view the code reads better to view tagged
responses, then untagged followed by continuation responses.
Additionally, this matches the order of responses in POP3.
Jiri Hruska [Sun, 24 Feb 2013 13:54:25 +0000 (14:54 +0100)]
imap: Added stricter parsing of continuation responses
Enhanced the parsing to only allow continuation responses in some
states.
Steve Holme [Sun, 24 Feb 2013 12:45:04 +0000 (12:45 +0000)]
imap: Simplified memcmp() in tagged response parsing
Jiri Hruska [Sun, 24 Feb 2013 12:27:49 +0000 (13:27 +0100)]
imap: Reworked the logic of untagged command responses
Steve Holme [Sun, 24 Feb 2013 12:05:15 +0000 (12:05 +0000)]
imap: Corrected spacing of trailing brace
Jiri Hruska [Sun, 24 Feb 2013 11:48:43 +0000 (12:48 +0100)]
imap: Added stricter parsing of tagged command responses
Enhanced the parsing of tagged responses which must start with "OK",
"NO" or "BAD"
Jiri Hruska [Sun, 24 Feb 2013 11:23:06 +0000 (12:23 +0100)]
imap: Simplified command response test in imap_endofresp()
Jiri Hruska [Sun, 24 Feb 2013 11:21:53 +0000 (12:21 +0100)]
imap: Corrected comment in imap_endofresp()
Steve Holme [Sun, 24 Feb 2013 00:47:38 +0000 (00:47 +0000)]
DOCS: Corrected layout of POP3 and IMAP URL examples
Corrected layout issues with the POP3 and IMAP URL examples introduced
in commit
cb3ae6894fb2.
Steve Holme [Sat, 23 Feb 2013 23:14:12 +0000 (23:14 +0000)]
DOCS: Updated CURLOPT_URL section following recent POP3 and IMAP changes
Updated the POP3 sub-section to refer to message ID rather than mailbox.
Added an IMAP sub-section with example URLs depicting the specification
of mailbox, uid and section.
Steve Holme [Sat, 23 Feb 2013 21:43:59 +0000 (21:43 +0000)]
pop3: Refactored the mailbox variable as it didn't reflect it's purpose
Updated the mailbox variable to correctly reflect it's purpose. The
name mailbox was a leftover from when IMAP and POP3 support was
initially added to curl.
Steve Holme [Sat, 23 Feb 2013 21:15:06 +0000 (21:15 +0000)]
FEATURES: Updated following recent IMAP changes
Jiri Hruska [Sat, 23 Feb 2013 21:05:19 +0000 (22:05 +0100)]
imap: Added the ability to FETCH a specific UID and SECTION
Updated the FETCH command to send the UID and SECTION parsed from the
URL. By default the BODY specifier doesn't include a section, BODY[] is
now sent whereas BODY[TEXT] was previously sent. In my opinion
retrieving just the message text is rarely useful when dealing with
emails, as the headers are required for example, so that functionality
is not retained. In can however be simulated by adding SECTION=TEXT to
the URL.
Also updated test801 and test1321 due to the BODY change.
Steve Holme [Sat, 23 Feb 2013 20:02:05 +0000 (20:02 +0000)]
email: Additional tidy up of comments following recent changes
Steve Holme [Sat, 23 Feb 2013 19:46:21 +0000 (19:46 +0000)]
smtp: Removed some FTP heritage leftovers
Removed user and passwd from the SMTP struct as these cannot be set on
a per-request basis and are leftover from legacy FTP code.
Changed some comments still using FTP terminology.
Steve Holme [Sat, 23 Feb 2013 19:39:22 +0000 (19:39 +0000)]
smtp: Moved the per-request variables to the per-request data structure
Moved the rcpt variable from the per-connection struct smtp_conn to the
new per-request struct and fixed references accordingly.
Steve Holme [Sat, 23 Feb 2013 19:31:59 +0000 (19:31 +0000)]
pop3: Introduced a custom SMTP structure for per-request data
Created a new SMTP structure and changed the type of the smtp proto
variable in connectdata from FTP* to SMTP*.
Steve Holme [Sat, 23 Feb 2013 18:57:18 +0000 (18:57 +0000)]
imap: Minor correction of comments for max line length
Daniel Stenberg [Sat, 23 Feb 2013 18:51:05 +0000 (19:51 +0100)]
strcasestr: remove check for this unused function
Daniel Stenberg [Sat, 23 Feb 2013 18:44:00 +0000 (19:44 +0100)]
pop3: fix compiler warning
error: declaration of 'pop3' shadows a previous local
Jiri Hruska [Sat, 23 Feb 2013 18:35:48 +0000 (19:35 +0100)]
imap: Added URL parsing of new variables
Updated the imap_parse_url_path() function to parse uidvalidity, uid and
section parameters based on RFC-5092.
Jiri Hruska [Sat, 23 Feb 2013 18:07:41 +0000 (19:07 +0100)]
imap: Introduced imap_is_bchar() function
Added imap_is_bchar() for testing if a given character is a valid bchar
or not.
Jiri Hruska [Sat, 23 Feb 2013 17:24:53 +0000 (18:24 +0100)]
imap: Introduced new per-request veriables
Added uidvalidity, uid and section variables to the per-request IMAP
structure in preparation for upcoming URL parsing.
Steve Holme [Sat, 23 Feb 2013 17:09:24 +0000 (17:09 +0000)]
pingpong: Renamed curl_ftptransfer to curl_pp_transfer
Steve Holme [Sat, 23 Feb 2013 16:27:17 +0000 (16:27 +0000)]
pop3: Removed some FTP heritage leftovers
Removed user and passwd from the POP3 struct as these cannot be set on
a per-request basis and are leftover from legacy FTP code.
Changed some comments still using FTP terminology.
Steve Holme [Sat, 23 Feb 2013 16:15:38 +0000 (16:15 +0000)]
pop3: Moved the per-request variables to the per-request data structure
Moved the mailbox and custom request variables from the per-connection
struct pop3_conn to the new per-request struct and fixed references
accordingly.
Steve Holme [Sat, 23 Feb 2013 16:06:54 +0000 (16:06 +0000)]
pop3: Introduced a custom POP3 structure for per-request data
Created a new POP3 structure and changed the type of the pop3 proto
variable in connectdata from FTP* to POP*.
Jiri Hruska [Tue, 12 Feb 2013 13:47:37 +0000 (14:47 +0100)]
imap: Fixed escaping of mailbox names
Used imap_atom() to escape mailbox names in imap_select().
Steve Holme [Sat, 23 Feb 2013 15:26:26 +0000 (15:26 +0000)]
pingpong: Moved curl_ftptransfer definition to pingpong.h
Moved the ftp transfer structure into pingpong.h so other protocols that
require it don't have to include ftp.h.
Steve Holme [Sat, 23 Feb 2013 12:31:12 +0000 (12:31 +0000)]
urldata.h: Fixed comment for opt_no_body variable
Corrected comment for opt_no_body variable to CURLOPT_NOBODY.
Steve Holme [Sat, 23 Feb 2013 11:34:52 +0000 (11:34 +0000)]
email: Minor tidy up following IMAP changes
Jiri Hruska [Sat, 23 Feb 2013 09:48:52 +0000 (10:48 +0100)]
imap: Removed more FTP leftovers
Changed some variables and comments still using FTP terminology.
Jiri Hruska [Sat, 23 Feb 2013 09:41:47 +0000 (10:41 +0100)]
imap: Removed some FTP heritage leftovers
Removed user and passwd from the IMAP struct as these cannot be set on
a per-request basis and are leftover from legacy FTP code.
Jiri Hruska [Sat, 23 Feb 2013 09:29:40 +0000 (10:29 +0100)]
imap: Introduced a custom IMAP structure for per-request data
Created a new IMAP structure and changed the type of the imap proto
variable in connectdata from FTP* to the new IMAP*.
Moved the mailbox variable from the per-connection struct imap_conn to
the new per-request struct and fixed references accordingly.
Steve Holme [Fri, 22 Feb 2013 23:31:13 +0000 (23:31 +0000)]
pop3: Updated do phrase clean-up comment
Following commit
65644b833532 for the IMAP module updated the clean-up
comment in POP3.
Steve Holme [Fri, 22 Feb 2013 23:29:33 +0000 (23:29 +0000)]
imap: Fixed memory leak when performing multiple selects
Moved the clean-up of the mailbox variable from imap_disconnect() to
imap_done() as this variable is allocated in the do phase, yet would
have only been freed only once if multiple selects where preformed
on a single connection.
Alexander Klauer [Fri, 22 Feb 2013 12:06:56 +0000 (13:06 +0100)]
Documentation: Typo in docs/CONTRIBUTE
Fixes a typo get → git in docs/CONTRIBUTE.
Alexander Klauer [Fri, 22 Feb 2013 12:06:55 +0000 (13:06 +0100)]
repository: ignore patch files generated by git
Ignores the patch files generated by the 'git format-patch' command.
Alexander Klauer [Fri, 22 Feb 2013 12:06:54 +0000 (13:06 +0100)]
libcurl documentation: clarifications and typos
* Elaborates on default values of some curl_easy_setopt() options.
* Reminds the user to cast variadic arguments to curl_easy_setopt() to
'void *' where curl internally interprets them as such.
* Clarifies the working of the CURLOPT_SEEKFUNCTION option for
curl_easy_setopt().
* Fixes typo 'forth' → 'fourth'.
* Elaborates on CURL_SOCKET_TIMEOUT.
* Adds some missing periods.
* Notes that the return value of curl_version() must not be passed to
free().
Alexander Klauer [Fri, 22 Feb 2013 12:06:53 +0000 (13:06 +0100)]
lib/url.c: Generic read/write data pointers
Always interprets the pointer passed with the CURLOPT_WRITEDATA or
CURLOPT_READDATA options of curl_easy_setopt() as a void pointer in
order to avoid problems in environments where FILE and void pointers
have non-trivial conversion.
Alexander Klauer [Fri, 22 Feb 2013 12:06:52 +0000 (13:06 +0100)]
libcurl documentation: updates HTML index
* Adds several links to documentation of library functions which were
missing.
* Marks documentation of deprecated library functions "(deprecated)".
* Removes spurious .html suffixes.
Daniel Stenberg [Fri, 22 Feb 2013 21:54:31 +0000 (22:54 +0100)]
ossl_seed: avoid recursive seeding!
Jiri Hruska [Fri, 15 Feb 2013 15:42:49 +0000 (16:42 +0100)]
Fixed checking the socket if there is data waiting in the cache
Use Curl_pp_moredata() in Curl_pp_multi_statemach() to check if there is
more data to be received, rather than the socket state, as a task could
hang waiting for more data from the socket itself.
Steve Holme [Fri, 22 Feb 2013 19:58:42 +0000 (19:58 +0000)]
imap.c: Fixed an incorrect variable reference
Fixed an incorrect variable reference which was introduced in commit
a1701eea289f as a result of a copy and paste from SMTP/POP3.
Jiri Hruska [Thu, 14 Feb 2013 18:36:43 +0000 (19:36 +0100)]
pingpong: Introduce Curl_pp_moredata()
A simple function to test whether the PP is not sending and there are
still more data in its receiver cache. This will be later utilized to:
1) Change Curl_pp_multi_statemach() and Curl_pp_easy_statemach() to
not test socket state and just call user's statemach_act() function
when there are more data to process, because otherwise the task would
just hang, waiting for more data from the socket.
2) Allow PP users to read multiple responses by looping as long as there
are more data available and current phase is not finished.
(Currently needed for correct processing of IMAP SELECT responses.)
Nick Zitzmann [Wed, 20 Feb 2013 02:15:32 +0000 (19:15 -0700)]
FEATURES: why yes, we do support metalink
I just noticed Metalink support wasn't listed as a feature of the tool.
Nick Zitzmann [Wed, 20 Feb 2013 02:03:39 +0000 (19:03 -0700)]
metalink: fix improbable crash parsing metalink filename
The this_url pointer wasn't being initialized, so if strdup() would return
null when copying the filename in a metalink file, then hilarity would
ensue during the cleanup phase. This change was brought to you by clang,
which noticed this and raised a warning.
Yang Tse [Tue, 19 Feb 2013 15:53:13 +0000 (16:53 +0100)]
smtp.c: fix enumerated type mixed with another type
Yang Tse [Tue, 19 Feb 2013 12:11:55 +0000 (13:11 +0100)]
polarssl threadlock cleanup
Nick Zitzmann [Mon, 18 Feb 2013 23:27:30 +0000 (16:27 -0700)]
docs: schannel and darwinssl documentation improvements
Schannel and darwinssl use the certificates built into the
OS to do vert verification instead of bundles. darwinssl
is thread-safe. Corrected typos in the NSS docs.
Daniel Stenberg [Mon, 18 Feb 2013 21:52:58 +0000 (22:52 +0100)]
resolver_error: remove wrong error message output
The attempt to use gai_strerror() or alternative function didn't work as
the 'sock_error' field didn't contain the proper error code. But since
this hasn't been reported and thus isn't really a big deal I decided to
just scrap the whole attempt to output the detailed resolver error and
instead remain with just stating that the resolving of the name failed.
Kim Vandry [Mon, 18 Feb 2013 20:36:34 +0000 (21:36 +0100)]
Curl_resolver_is_resolved: show proper host name on failed resolve
Daniel Stenberg [Mon, 18 Feb 2013 12:40:13 +0000 (13:40 +0100)]
Curl_resolver_is_resolved: fix compiler warning
conversion to 'int' from 'long int' may alter its value
Daniel Stenberg [Mon, 18 Feb 2013 11:56:03 +0000 (12:56 +0100)]
compiler warning fix
follow-up to commit
ed7174c6f66, rename 'wait' to 'block'
Daniel Stenberg [Sun, 17 Feb 2013 23:14:35 +0000 (00:14 +0100)]
compiler warning fix: declaration of 'wait' shadows a global declaration
It seems older gcc installations (at least) will cause warnings if we
name a variable 'wait'. Now changed to 'block' instead.
Reported by: Jiří Hruška
Bug: http://curl.haxx.se/mail/lib-2013-02/0247.html
Nick Zitzmann [Sun, 17 Feb 2013 21:30:38 +0000 (14:30 -0700)]
MacOSX-Framework: Make script work in Xcode 4.0 and later
Apple made a number of changes to Xcode 4. The SDKs were moved, the entire
Developer folder was moved, and PowerPC support was removed. The script
will now adapt to those changes and should be future-proofed against
additional changes in case Apple moves the Developer folder ever again.
Also, the minimum OS X version compiler option was removed, so that the
framework can be built against the latest SDK but still run in older cats.
Daniel Stenberg [Sat, 16 Feb 2013 13:40:54 +0000 (14:40 +0100)]
docs: refer to CURLOPT_ACCEPT_ENCODING instead of the old name
Steve Holme [Sat, 16 Feb 2013 23:37:50 +0000 (23:37 +0000)]
email: Tidied up result code variables
Tidied up result variables to be consistent in name, declaration order
and default values.
Nick Zitzmann [Sat, 16 Feb 2013 21:21:09 +0000 (14:21 -0700)]
ntlm_core: fix compiler warning when building with clang
Fixed a 64-to-32 compiler warning raised when building with
clang and the --with-darwinssl option.
Daniel Stenberg [Sat, 16 Feb 2013 13:26:28 +0000 (14:26 +0100)]
Guile-curl: a new libcurl binding
Daniel Stenberg [Sat, 16 Feb 2013 12:56:08 +0000 (13:56 +0100)]
polarsslthreadlock: #include the proper memory and debug includes
Pointed out by Steve Holme
Steve Holme [Sat, 16 Feb 2013 10:28:32 +0000 (10:28 +0000)]
email: Removed unnecessary forward declaration
Due to the reordering of functions in commit
586f5d361474 the forward
declaration to state_upgrade_tls() are no longer required.
Steve Holme [Sat, 16 Feb 2013 10:18:01 +0000 (10:18 +0000)]
pop3.c: Added reference to RFC-5034
Willem Sparreboom [Wed, 13 Feb 2013 10:26:16 +0000 (11:26 +0100)]
PolarSSL: Change to cURL coding style
Repaired all curl/lib/checksrc.pl warnings in the previous four patches
Willem Sparreboom [Mon, 28 Jan 2013 17:55:52 +0000 (18:55 +0100)]
PolarSSL: WIN32 threading support for entropy
Added WIN32 threading support for PolarSSL entropy if
--enable-threaded-resolver config flag is set and process.h can be found.
Willem Sparreboom [Mon, 28 Jan 2013 17:31:22 +0000 (18:31 +0100)]
PolarSSL: pthread support for entropy
Added pthread support for polarssl entropy if --enable-threaded-resolver
config flag is set and pthread.h can be found.
Willem Sparreboom [Mon, 28 Jan 2013 15:03:40 +0000 (16:03 +0100)]
PolarSSL: changes to entropy/ctr_drbg/HAVEGE_RANDOM
Add non-threaded entropy and ctr_drbg and removed HAVEGE_RANDOM define
Willem Sparreboom [Mon, 28 Jan 2013 14:46:07 +0000 (15:46 +0100)]
PolarSSL: added human readable error strings
Print out human readable error strings for PolarSSL related errors
Steve Holme [Fri, 15 Feb 2013 18:33:28 +0000 (18:33 +0000)]
pop3: Removed unnecessary state changes on failure
Steve Holme [Fri, 15 Feb 2013 18:33:10 +0000 (18:33 +0000)]
imap: Removed unnecessary state change on failure
Daniel Stenberg [Fri, 15 Feb 2013 12:45:28 +0000 (13:45 +0100)]
metalink_cleanup: yet another follow-up fix
Daniel Stenberg [Fri, 15 Feb 2013 10:19:59 +0000 (11:19 +0100)]
metalink_cleanup: define it without argument
Since the function takes no argument, the macro shouldn't take one as
some compilers will error out on that.
Daniel Stenberg [Fri, 15 Feb 2013 10:03:42 +0000 (11:03 +0100)]
rename "easy" statemachines: call them block instead
... since they're not used by the easy interface really, I wanted to
remove the association. Also, I unified the pingpong statemachine driver
into a single function with a 'wait' argument: Curl_pp_statemach.
Gisle Vanem [Fri, 15 Feb 2013 01:11:57 +0000 (02:11 +0100)]
curl_setup_once.h: definition of HAVE_CLOSE_S defines sclose() to close_s()
Gisle Vanem [Fri, 15 Feb 2013 01:11:18 +0000 (02:11 +0100)]
config-dos.h: define HAVE_CLOSE_S for MSDOS/Watt-32
Gisle Vanem [Fri, 15 Feb 2013 00:51:19 +0000 (01:51 +0100)]
config-dos.h: define strerror() to strerror_s_() for High-C
Gisle Vanem [Fri, 15 Feb 2013 00:38:39 +0000 (01:38 +0100)]
config-dos.h: define HAVE_TERMIOS_H only for djgpp
Steve Holme [Thu, 14 Feb 2013 20:06:03 +0000 (20:06 +0000)]
smtp.c: Fixed a trailing whitespace
Remove tailing whitespace introduced in commit
7ed689d24a4e.
Steve Holme [Thu, 14 Feb 2013 18:20:52 +0000 (18:20 +0000)]
pop3: Fixed blocking SSL connect when connecting via POP3S
A call to Curl_ssl_connect() was accidentally left in when the SSL/TLS
connection layer was reworked in 7.29. Not only would this cause the
connection to block but had the additional overhead of calling the
non-blocking connect a little bit later.
Steve Holme [Thu, 14 Feb 2013 18:15:07 +0000 (18:15 +0000)]
smtp: Refactored the smtp_state_auth_resp() function
Renamed smtp_state_auth_resp() function to match the implementations in
IMAP and POP3.
Daniel Stenberg [Thu, 14 Feb 2013 10:41:57 +0000 (11:41 +0100)]
remove ifdefs
Clarify the code by reducing ifdefs
Daniel Stenberg [Wed, 13 Feb 2013 12:18:43 +0000 (13:18 +0100)]
strlcat: remove function
This function was only used twice, both in places where performance
isn't crucial (socks + if2ip). Removing the use of this function removes
the need to have our private version for systems without it == reduced
amount of code.
Also, in the SOCKS case it is clearly better to fail gracefully rather
than to truncate the results.
This work was triggered by a bug report on the strcal prototype in
strequal.h.
strlcat was added in commit
db70cd28 in February 2001!
Bug: http://curl.haxx.se/bug/view.cgi?id=1192
Reported by: Jeremy Huddleston
Daniel Stenberg [Thu, 14 Feb 2013 09:32:04 +0000 (10:32 +0100)]
Curl_FormBoundary: made static
As Curl_FormBoundary() is no longer used outside of this file (since
commit
ad7291c1a9d), it is now renamed to formboundary() and is made
static.
Daniel Stenberg [Wed, 13 Feb 2013 23:06:19 +0000 (00:06 +0100)]
ossl_seed: fix the last resort PRNG seeding
Instead of just abusing the pseudo-randomizer from Curl_FormBoundary(),
this now uses Curl_ossl_random() to get entropy.
Steve Holme [Wed, 13 Feb 2013 20:12:21 +0000 (20:12 +0000)]
email: Tidy up before additional IMAP work
Replaced two explicit comparisons of CURLE_OK with boolean alternatives.
General tidy up of comments.
Steve Holme [Wed, 13 Feb 2013 18:22:20 +0000 (18:22 +0000)]
smtp: Removed duplicate pingpong structure initialisation
The smtp_connect() function was setting the member variables of the
pingpong structure twice, once before calling Curl_pp_init() and once
after!
Yang Tse [Wed, 13 Feb 2013 16:02:38 +0000 (17:02 +0100)]
move msvc IDE related files to 'vs' directory tree
Use 'vs' directory tree given that 'vc' intended one clashes
with an already existing build target in file Makefile.dist.
Daniel Stenberg [Wed, 13 Feb 2013 14:41:59 +0000 (15:41 +0100)]
install-sh: updated to support multiple source files as arguments
Version 7.29.0 uses Makefiles generated with a newer version of the
autotools than the previous 7.28.1. These Makefiles try to install
e.g. header files by calling install-sh with multiple source files as
arguments. The bundled install-sh is to old and does not support this.
The problem only occurs, if install-sh is actually being used, ie. the
platform install executable is to old or not usable. Example: Solaris
10.
The files install-sh and mkinstalldirs are now updated with the automake
1.11.3 versions. A better fix might be to completely remove them from
git and force the files to be added/created during buildconf.
Bug: http://curl.haxx.se/bug/view.cgi?id=1195
Reported by: Rainer Jung
Yang Tse [Mon, 11 Feb 2013 18:11:14 +0000 (19:11 +0100)]
move msvc IDE related files to 'vc' directory tree
Yang Tse [Mon, 11 Feb 2013 18:00:38 +0000 (19:00 +0100)]
msvc IDE 'vc' directory tree preparation
Steve Holme [Tue, 12 Feb 2013 23:05:14 +0000 (23:05 +0000)]
imap: Corrected a whitespace issue from previous commit
Fixed a small whitespace issue that crept in there in commit
508cdf4da4d7.
Steve Holme [Tue, 12 Feb 2013 23:00:34 +0000 (23:00 +0000)]
email: Another post optimisation of endofresp() tidy up
Steve Holme [Tue, 12 Feb 2013 22:20:44 +0000 (22:20 +0000)]
sasl: Fixed null pointer reference when decoding empty digest challenge
Fixed a null pointer reference when an empty challenge is passed to the
Curl_sasl_create_digest_md5_message() function.
Bug: http://sourceforge.net/p/curl/bugs/1193/
Reported by: Saran Neti
Steve Holme [Tue, 12 Feb 2013 21:01:50 +0000 (21:01 +0000)]
email: Post optimisation of endofresp() tidy up
Removed unnecessary end of line check and return.
Nick Zitzmann [Tue, 12 Feb 2013 20:02:36 +0000 (13:02 -0700)]
darwinssl: Fix send glitchiness with data > 32 or so KB
An ambiguity in the SSLWrite() documentation lead to a bad inference in the
code where we assumed SSLWrite() returned the amount of bytes written to
the socket, when that is not actually true; it returns the amount of data
that is buffered for writing to the socket if it returns errSSLWouldBlock.
Now darwinssl_send() returns CURLE_AGAIN if data is buffered but not written.
Reference URL: http://curl.haxx.se/mail/lib-2013-02/0145.html
Steve Holme [Tue, 12 Feb 2013 19:28:23 +0000 (19:28 +0000)]
pingpong.h: Fixed line length over 78 characters from
b56c9eb48e3c
Steve Holme [Tue, 12 Feb 2013 18:08:48 +0000 (18:08 +0000)]
pingpong: Optimised the endofresp() function
Reworked the pp->endofresp() function so that the conndata, line and
line length are passed down to it just as with Curl_client_write()
rather than each implementation of the function having to query
these values.
Additionally changed the int return type to bool as this is more
representative of the function's usage.
Steve Holme [Mon, 11 Feb 2013 23:13:50 +0000 (23:13 +0000)]
email: Post STARTLS capability code tidy up (Part Three)
Corrected the order of the upgrade_tls() functions and moved the handler
upgrade and getsock() functions out from the middle of the state related
functions.