platform/core/csapi/xsf.git
5 years agoAddresses issue #5854 (#5855)
Muzib [Mon, 29 Apr 2019 21:39:45 +0000 (03:39 +0600)]
Addresses issue #5854 (#5855)

fixes #5854

5 years agoFixes _child.Element null reference exception (#5756)
Carbaholic [Mon, 29 Apr 2019 21:37:41 +0000 (15:37 -0600)]
Fixes _child.Element null reference exception (#5756)

* Fixes _child.Element null reference exception

* Update ListViewRenderer.cs

fixes #5700

5 years agomerge tweaks
ShaneN [Mon, 29 Apr 2019 20:14:45 +0000 (14:14 -0600)]
merge tweaks

5 years agomerge 4.0.0 in master
ShaneN [Mon, 29 Apr 2019 20:14:19 +0000 (14:14 -0600)]
merge 4.0.0 in master

5 years agoadditional proguard rules for shell (#6032)
Shane Neuville [Sat, 27 Apr 2019 19:21:30 +0000 (13:21 -0600)]
additional proguard rules for shell (#6032)

* additional proguard rules for shell

* add property to disable file

fixes #5799

5 years agoadd check for null track drawable (#6029)
Shane Neuville [Sat, 27 Apr 2019 19:18:33 +0000 (13:18 -0600)]
add check for null track drawable (#6029)

fixes #5970

5 years ago[Android] set dialog to null when dismissed (#6031)
Shane Neuville [Sat, 27 Apr 2019 19:18:08 +0000 (13:18 -0600)]
[Android] set dialog to null when dismissed (#6031)

fixes #5945

5 years ago[Android] Use Fast Renderers by Default (#5926)
Samantha Houts [Sat, 27 Apr 2019 19:15:39 +0000 (12:15 -0700)]
[Android] Use Fast Renderers by Default (#5926)

* [Android] Unseal FastRenderers

* [Android] Flip experimental flag to legacy flag

* Flip flag for testing both renderers & set up custom renderers for testing

* Undo build arg change

This reverts commit 8447fec03b4dff16d8ca96544ec83159670b80d7.

* Fix whitespace

* restore workaround for #2520

* Only use workaround for fast renderers (crashes legacy)

fixes #5724

5 years agofix tizen obsolete errors (#6030)
Shane Neuville [Sat, 27 Apr 2019 17:48:26 +0000 (11:48 -0600)]
fix tizen obsolete errors (#6030)

5 years ago[iOS] remove SetPaddingInsets api and just have it pad content and flyout by default...
Shane Neuville [Sat, 27 Apr 2019 03:29:42 +0000 (21:29 -0600)]
[iOS] remove SetPaddingInsets api and just have it pad content and flyout by default (#5990)

* remove content setting api and just set by default

* - address comments and centralize window insets check

* add check if height < 0

5 years ago`WpfHelper.FindChildren`: Pass `forceUsingTheVisualTreeHelper` to recursive calls...
Johannes Egger [Fri, 26 Apr 2019 23:00:59 +0000 (01:00 +0200)]
`WpfHelper.FindChildren`: Pass `forceUsingTheVisualTreeHelper` to recursive calls. (#5922)

fixes #5921

5 years ago[WIP] Unify the image handling (#4915)
Matthew Leibowitz [Fri, 26 Apr 2019 20:46:13 +0000 (00:46 +0400)]
[WIP] Unify the image handling (#4915)

* Initial code to get unifiied image handling
 - not yet tested
 - still using FileImageSource in some areas

* Updated the button renderers and added tests for Android

* Updated a few more of the Android renderers
 - also added an `IsEmpty` property to the ImageSource to indicate if this source actually contains data that can be used to try and load an image
 - added a few more "tests"
 - includes the changes for #4916

* A few more changes

* Keep the default page for the sample app

* Changing everything to ImageSource and going from there
 - Android, iOS, UWP and WPF are compiling
 - GTK, Mac and Tizen are not yet finished
 - Added a new interface for UWP to return an IconElement in addition to ImageSource (for app bar buttons)
 - not tested yet, nor are there any tests

* Renamed the property to be more useful

* All of Android is now async
 - still only minimal tests
 - also removed the bits that are in https://github.com/xamarin/Xamarin.Forms/pull/4948

* Update Xamarin.Forms.Platform.cs

* A few fixes to whitespace and nameof()

* Updated iOS and UWP wirth async image sources

* A few fixes and WPF support

* A few fixes for Android after the big merge

* Updated a few more loaders:
 - ios
 - macos
 - tizen
 - gtk

* Fix a few things after the merge

* - cast type to FileImageSource

* fix setting of title content if icon doesn't load

* fix IButtonLayoutManager to return correct control

* remove cast and add pack api

* - fix timing issues with layout/invalidation

* - remove aggresive element invalidations for now

* first set of api changes

* obsolete old apis and create new ones for ImageSource

* obsolete messages and static ordering fix

* add tests

* switch default on windows to show images on tabs

* - XStatic obsolete fix

* fix NPC test and bring back alert check on uwp

Fixes #3207
Fixes #4689

5 years agoAdd null check in iOS ShadowEffect OnDetached (#5952)
Matt Soucoup [Fri, 26 Apr 2019 16:15:04 +0000 (18:15 +0200)]
Add null check in iOS ShadowEffect OnDetached (#5952)

Added a null check in iOS ShadowEffect OnDetached
fixes #5951

5 years ago[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual (#5453)
Kangho Hur [Mon, 15 Apr 2019 16:55:56 +0000 (01:55 +0900)]
[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual (#5453)

* [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual

* Update Tizen.NET.MaterialComponent for applying color scheme

* Don't build XF.Material.Tzien on iPhone and iPhoneSimulator

* Fix MCanvas build issue

* Update build-windows.yml for XF.Material.Tizen

5 years agoAdd the ShellRenderer for Tizen (#5818)
yourina [Mon, 8 Apr 2019 16:54:41 +0000 (01:54 +0900)]
Add the ShellRenderer for Tizen (#5818)

5 years agoShell hamburger (#5961)
Shane Neuville [Thu, 25 Apr 2019 00:36:19 +0000 (18:36 -0600)]
Shell hamburger (#5961)

* Draw the hamburger if the user hasn't supplied an icon

* move variable

* remove excess code

* remove public

5 years agofix infinite loops and remove public apis (#5954)
Shane Neuville [Wed, 24 Apr 2019 22:25:12 +0000 (16:25 -0600)]
fix infinite loops and remove public apis (#5954)

* fix infinite loops and remove public apis

* - remove comments, fix location to not have implicit

* force uri to be relative on ios when no scheme specified

* address PR comments

* add error message

* reformat absolute uris

* additional suggestions

* Update Xamarin.Forms.Core/Shell/ShellNavigationState.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
5 years agoAllow CollectionView items to resize with their content (#5905)
E.Z. Hart [Wed, 24 Apr 2019 18:30:02 +0000 (12:30 -0600)]
Allow CollectionView items to resize with their content (#5905)

* Add gallery for reproing expanding DataTemplate content;
Allow ItemContentView on Android to expand with content;
Allow ItemContentView on iOS to expand with content;
Fixes #5647

* Improve instructions
Fixes #5721
Fixes #5521

* Apply suggestions from code review

Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Clear binding contexts before recycling cells/viewholders.

5 years ago[Shell, iOS, Android] added tab order on Shell flyout menu items (#5930)
Pavel Yakovlev [Wed, 24 Apr 2019 02:33:09 +0000 (05:33 +0300)]
[Shell, iOS, Android] added tab order on Shell flyout menu items (#5930)

* [Shell, Android] added tab order on Shell flyout menu items

* [iOS mac] fix build

* support iOS

5 years agoRefactoring Map.ItemsSource to use NotifyCollectionChangedEventArgsExtensions (#5689)
Andrei Nitescu [Wed, 24 Apr 2019 01:00:49 +0000 (04:00 +0300)]
Refactoring Map.ItemsSource to use NotifyCollectionChangedEventArgsExtensions (#5689)

5 years ago[GTK] Fix Padding/Margin properties of Frame element (#5533) (#5764)
Stanislav [Wed, 24 Apr 2019 00:58:11 +0000 (03:58 +0300)]
[GTK] Fix Padding/Margin properties of Frame element (#5533) (#5764)

Frame's content wrapped into a Gtk.Fixed container since Gtk.Frame itself can't position it's content.
fixes #5533

5 years ago[Maps] Add MapClicked event (#5317)
jcmanke [Wed, 24 Apr 2019 00:57:22 +0000 (19:57 -0500)]
[Maps] Add MapClicked event (#5317)

* Add MapClicked event to Map

* Android MapClicked implementation

* iOS MapClicked implementation

* UWP implementation of MapClicked

* Null check before sending MapClicked event from renderers

* Rewrote MapGallery page in XAML

5 years agoRemove Xamarin.Android.Support.v7.MediaRouter (#5941)
Jonathan Peppers [Tue, 23 Apr 2019 19:21:21 +0000 (14:21 -0500)]
Remove Xamarin.Android.Support.v7.MediaRouter (#5941)

Context: https://github.com/xamarin/xamarin-android/issues/2982

The Blank Xamarin.Forms app template in VS 2019 takes longer to build
than in VS 2017. A little research is showing that this is due to use
of the 28.x support libraries... For example, the build includes ~20
*more* jar files in the template from 2019 than 2017. The
`_CompileDex` step alone goes from ~15.2s to ~18.2s.

This lead me down the road of investigating if we can remove any
support libraries by default in Xamarin.Forms apps. I am also seeing
if there is more we can do in Xamarin.Android for this problem, in
general.

It looks like we can remove:

* Xamarin.Android.Support.v7.MediaRouter
* Xamarin.Android.Support.Media.Compat

Neither of these appear to be used, but have been listed as
dependencies of Xamarin.Forms for a long time.

~~ Results ~~

I made these changes, then did a `Debug` build of
`Xamarin.Forms.ControlGallery.Android.csproj` for comparison.

Comparing dex file sizes (in bytes):

    Before:
    3428092 classes.dex
    3265616 classes2.dex
    6693708 total
    After:
    4938000 classes.dex
    1098772 classes2.dex
    6036772 total

This looks like it could potentially save ~600KB of compiled dex code
on every Xamarin.Forms app.

Comparing methods:

    Before:
    classes.dex  11,492 methods
    classes2.dex 19,451 methods
    total        30,943 methods
    After:
    classes.dex  22,171 methods
    classes2.dex  7,635 methods
    total        29,806 methods

~1,137 methods removed, which should help with the dex limit.

Comparing APK sizes (in bytes):

    Before:
    26442597 AndroidControlGallery.AndroidControlGallery-Signed.apk
    After:
    25741701 AndroidControlGallery.AndroidControlGallery-Signed.apk

~700KB smaller APK, due to less .NET assemblies & dex code.

Comparing build time (this was using dx):

    Before:
    19785 ms  CompileToDalvik                            1 calls
    After:
    18532 ms  CompileToDalvik                            1 calls

Looks like it saved over a second of build time for this project.

Seems like an "easy win", let's do this!

5 years agoAvoid LINQ exception (#5933)
Morten Nielsen [Tue, 23 Apr 2019 17:18:19 +0000 (10:18 -0700)]
Avoid LINQ exception (#5933)

* Avoid LINQ exception

If the back button in UWP is pressed, but there's nothing in the backstack, the `Last()` LINQ query will throw `System.InvalidOperationException: 'Sequence contains no elements`
This change avoids that, and just returns false that Forms didn't handle the event.

* Change to use LastOrDefault

5 years agoadd delay to 2951 (#5972)
Shane Neuville [Tue, 23 Apr 2019 17:13:20 +0000 (11:13 -0600)]
add delay to 2951 (#5972)

5 years ago[UWP] Allow embedding Forms page in secondary window (#5658)
E.Z. Hart [Mon, 22 Apr 2019 22:44:12 +0000 (16:44 -0600)]
[UWP] Allow embedding Forms page in secondary window (#5658)

* Make secondary window work in UWP (fixes #2229)

* Update Xamarin.Forms.Core/Internals/Ticker.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
5 years agoAdd UITest for issue 1763 (#5907)
puppetSpace [Mon, 22 Apr 2019 21:05:54 +0000 (23:05 +0200)]
Add UITest for issue 1763 (#5907)

* Add UITest for issue 1763

* Removed restriction for Windows Only. Also added the PreserveAttribute on the classes the test used.

5 years agoTesting a theory about an unreliable memory leak test (#5964)
E.Z. Hart [Mon, 22 Apr 2019 00:41:10 +0000 (18:41 -0600)]
Testing a theory about an unreliable memory leak test (#5964)

5 years agoMerge branch '4.0.0'
Rui Marinho [Thu, 18 Apr 2019 15:27:58 +0000 (16:27 +0100)]
Merge branch '4.0.0'

5 years ago[Android] move runtime registration of renderers to its own method (#5946)
Shane Neuville [Thu, 18 Apr 2019 15:25:58 +0000 (09:25 -0600)]
[Android] move runtime registration of renderers to its own method (#5946)

* move renderer registration to its own method

* - move to static

5 years ago[Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934)...
Shane Neuville [Thu, 18 Apr 2019 15:25:31 +0000 (09:25 -0600)]
[Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934) fixes #5650 fixes #5501

* propagate bindingcontext

* - add exception message and fix poorly named xaml file

* add ui test automation

* - fix unit test to represent new code

* - changed from ui test to unit test

* - propagate visual, parent, bc to titleview

* - style fixes

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Thu, 18 Apr 2019 15:15:48 +0000 (16:15 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Fixes to yaml public build (#5948)
Rui Marinho [Thu, 18 Apr 2019 15:14:47 +0000 (16:14 +0100)]
[Build] Fixes to yaml public build (#5948)

* [Build] Don't sign on public builds

* [Build] Use vmImages

* [Build] Fix pool specification

* [Build] Revert back to pool name

* [Build] add osx demands

* [Build] Fix indentation

* [Build] Add more demands

* [Build] Try using certs

* [Build] Try use name

* cert password

* [Build] Add endpoint back

* [Build] Add VSTS feed as variable

* [Build] Add signing stuff

* Fix

* [Build] Try simplify Windows build

* [Build] Publish android apps

* [Build] Add signVmImage

5 years agomacOs: fixes NRE in during entryRenderer disposing (#5914)
Andrei [Thu, 18 Apr 2019 01:11:31 +0000 (04:11 +0300)]
macOs: fixes NRE in during entryRenderer disposing (#5914)

fixes https://github.com/xamarin/Xamarin.Forms/issues/5881

5 years agoMove IElementConfiguration to an internal structure on Cell (#5850)
Shane Neuville [Wed, 17 Apr 2019 17:59:16 +0000 (11:59 -0600)]
Move IElementConfiguration to an internal structure on Cell (#5850)

* Move IElementConfiguration to an internal structure on Cell

* set custom ElementConfiguration to private

* fix comments

5 years agoRemove need for PressEnter on test 5535 because it crashes iOS 12 tests
E.Z. Hart [Wed, 17 Apr 2019 16:13:10 +0000 (10:13 -0600)]
Remove need for PressEnter on test 5535 because it crashes iOS 12 tests

5 years agos/SearchBoxVisiblity/SearchBoxVisibility/ from base 4.0.0 (#5931)
Larry O'Brien [Tue, 16 Apr 2019 22:04:55 +0000 (12:04 -1000)]
s/SearchBoxVisiblity/SearchBoxVisibility/ from base 4.0.0 (#5931)

* s/SearchBoxVisiblty/SearchBoxVisibility/

Fix typo in type name.

* s/Collapsable/Collapsible/

* Changed capitalization in comment

5 years agoremove used Group Header Template (#5906)
Shane Neuville [Tue, 16 Apr 2019 16:38:17 +0000 (10:38 -0600)]
remove used Group Header Template (#5906)

5 years agoMerge branch '4.0.0'
Samantha Houts [Mon, 15 Apr 2019 21:54:48 +0000 (14:54 -0700)]
Merge branch '4.0.0'

5 years ago[iOS] Fix usage of iOS11 api (#5893)
Rui Marinho [Mon, 15 Apr 2019 21:24:50 +0000 (22:24 +0100)]
[iOS] Fix usage of iOS11 api (#5893)

* [iOS] Fix usage of iOS11 api

* [iOS] Fix remaining calls to HomeIndicatorHidden feature

5 years ago[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual (#5453)
Kangho Hur [Mon, 15 Apr 2019 16:55:56 +0000 (01:55 +0900)]
[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual (#5453)

* [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual

* Update Tizen.NET.MaterialComponent for applying color scheme

* Don't build XF.Material.Tzien on iPhone and iPhoneSimulator

* Fix MCanvas build issue

* Update build-windows.yml for XF.Material.Tizen

5 years ago[Shell] Hide Shell types from being browsable (#5915)
Shane Neuville [Mon, 15 Apr 2019 16:22:47 +0000 (10:22 -0600)]
[Shell] Hide Shell types from being browsable (#5915)

* set shell things to EditorBrowsable false

* - EditorBrowsable always

* delete tab content

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 13 Apr 2019 01:28:49 +0000 (18:28 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago- add explicit references back into nuspec (#5902)
Shane Neuville [Fri, 12 Apr 2019 23:25:54 +0000 (17:25 -0600)]
- add explicit references back into nuspec (#5902)

5 years ago[Android, shell] fixes visibility of tabs after their changes (#5896)
Pavel Yakovlev [Fri, 12 Apr 2019 16:33:33 +0000 (19:33 +0300)]
[Android, shell] fixes visibility of tabs after their changes (#5896)

5 years agoMerge branch '4.0.0'
Samantha Houts [Thu, 11 Apr 2019 05:03:02 +0000 (22:03 -0700)]
Merge branch '4.0.0'

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 11 Apr 2019 04:59:38 +0000 (21:59 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[iOS] Add Platform Specific features for PrefersHomeIndicatorAutoHidden (#5717)
piotrkonowalski [Thu, 11 Apr 2019 04:58:34 +0000 (06:58 +0200)]
[iOS] Add Platform Specific features for PrefersHomeIndicatorAutoHidden (#5717)

fixes #5310

5 years ago[Shell] refactor of processing uris (#5852)
Shane Neuville [Thu, 11 Apr 2019 04:54:50 +0000 (22:54 -0600)]
[Shell] refactor of processing uris (#5852)

fixes #5790

5 years ago[Android/iOS] TabIndex sets focus order for TalkBack traversal (#3989)
Samantha Houts [Thu, 11 Apr 2019 04:53:37 +0000 (21:53 -0700)]
[Android/iOS] TabIndex sets focus order for TalkBack traversal (#3989)

fixes #2789

5 years agoPorting fix from 4794 to handle clip bounds on sub-API-19 Android; fixes #4790 (...
E.Z. Hart [Thu, 11 Apr 2019 04:28:11 +0000 (22:28 -0600)]
Porting fix from 4794 to handle clip bounds on sub-API-19 Android; fixes #4790 (#5863)

fixes #4790

5 years ago[Android] Null check on Switch TrackDrawable (#5851)
Samantha Houts [Thu, 11 Apr 2019 00:25:45 +0000 (17:25 -0700)]
[Android] Null check on Switch TrackDrawable (#5851)

* [Android] Null check on Switch TrackDrawable

fixes #5553

* Add a few more checks, dispose Drawable, fix copy/paste error

* Couple more for safety's sake

5 years ago[X] update Cecil (#5878)
Stephane Delcroix [Wed, 10 Apr 2019 23:10:54 +0000 (01:10 +0200)]
[X] update Cecil (#5878)

- fixes #5875

5 years ago[Android] Fix ObjectDisposedException on MasterDetailPageRenderer update (#4955)
Kevin Petit [Mon, 18 Feb 2019 11:24:26 +0000 (12:24 +0100)]
[Android] Fix ObjectDisposedException on MasterDetailPageRenderer update (#4955)

* Android - MasterDetailPageRenderer - Fix ObjectDisposedException on update.

* Fix update call to master.

* Move checks inside update methods.
Add HandleMasterPropertyChanged handler unsubscribing.

5 years agoCreate UITest for issue B44476 (#5859)
puppetSpace [Wed, 10 Apr 2019 16:43:10 +0000 (18:43 +0200)]
Create UITest for issue B44476 (#5859)

fixes #2381

5 years ago[Android] add another gc.collect for Android to ensure all is collected (#5847)
Shane Neuville [Wed, 10 Apr 2019 00:40:28 +0000 (18:40 -0600)]
[Android] add another gc.collect for Android to ensure all is collected (#5847)

* add another gc.collect for Android

* move all gc collects to a helper

5 years agoAdd automated test for Bugzilla41205 (#5826)
Shane Neuville [Wed, 10 Apr 2019 00:36:53 +0000 (18:36 -0600)]
Add automated test for Bugzilla41205 (#5826)

fixes #2353

5 years agoImplemented ImageButtonRenderer for WPF (#5668)
Sunner [Tue, 9 Apr 2019 18:16:39 +0000 (20:16 +0200)]
Implemented ImageButtonRenderer for WPF (#5668)

* Added ImageButton renderer for WPF

* Removed private modifiers
fixes #4991

5 years agoUpdate issue templates
Samantha Houts [Tue, 9 Apr 2019 17:31:33 +0000 (10:31 -0700)]
Update issue templates

5 years agomerge 4.0.0 into master
ShaneN [Mon, 8 Apr 2019 19:17:37 +0000 (13:17 -0600)]
merge 4.0.0 into master

5 years agoMerge branch '3.6.0' into 4.0.0
Stephane Delcroix [Mon, 8 Apr 2019 19:09:04 +0000 (21:09 +0200)]
Merge branch '3.6.0' into 4.0.0

5 years ago[iOS] Fix when we render the font icon image as original (#5753)
Rui Marinho [Mon, 8 Apr 2019 17:15:53 +0000 (18:15 +0100)]
[iOS] Fix when we render the font icon image as original (#5753)

fixes #5071

5 years ago[C] allow inheriting from Behavior (#5559)
Stephane Delcroix [Mon, 8 Apr 2019 17:15:14 +0000 (19:15 +0200)]
[C] allow inheriting from Behavior (#5559)

- fixes #5520

5 years agoAdd the ShellRenderer for Tizen (#5818)
yourina [Mon, 8 Apr 2019 16:54:41 +0000 (01:54 +0900)]
Add the ShellRenderer for Tizen (#5818)

5 years agoupdate build script for mac and readme based on vs mac 2019 (#5827)
Shane Neuville [Mon, 8 Apr 2019 16:48:23 +0000 (10:48 -0600)]
update build script for mac and readme based on vs mac 2019 (#5827)

5 years agoCreate UITest for Bugzilla41619 (#5829)
Pedro Jesus [Mon, 8 Apr 2019 15:17:49 +0000 (12:17 -0300)]
Create UITest for Bugzilla41619 (#5829)

* - create UITest for Bugzilla41619

* - remove the hard code

5 years ago[Android] fixes material placeholder (#5823)
Pavel Yakovlev [Sat, 6 Apr 2019 03:42:41 +0000 (06:42 +0300)]
[Android] fixes material placeholder (#5823)

5 years agoIncrease API level check for setting Android ripple effect on selection (#5760) fixes...
E.Z. Hart [Fri, 5 Apr 2019 12:02:29 +0000 (06:02 -0600)]
Increase API level check for setting Android ripple effect on selection (#5760) fixes #5693

Fixes #5693

5 years agoXamlLoader should not ignore x:TypeArguments on root node (#5804)
Tim Barham [Fri, 5 Apr 2019 05:31:28 +0000 (15:31 +1000)]
XamlLoader should not ignore x:TypeArguments on root node (#5804)

5 years agoRevert "Man init (#5587) closes #5248" (#5814)
kingces95 [Thu, 4 Apr 2019 20:38:27 +0000 (10:38 -1000)]
Revert "Man init (#5587) closes #5248" (#5814)

This reverts commit 0b69ead5a034dbc6535ed9768e5b79998b1939a3.

5 years agoMan init (#5587) closes #5248
kingces95 [Thu, 4 Apr 2019 18:50:39 +0000 (08:50 -1000)]
Man init (#5587) closes #5248

* man init

* man init w/o profile

* Update Xamarin.Forms.Platform.Android/Forms.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>
5 years ago[Core] Add some Device.InvokeOnMainThread helpers (#5028)
Andres G. Aragoneses [Thu, 4 Apr 2019 11:23:45 +0000 (19:23 +0800)]
[Core] Add some Device.InvokeOnMainThread helpers (#5028)

* [Core] Add some Device.InvokeOnMainThread helpers

These helpers keep popping up on forums/stackoverflow[1][2],
would be nice to include them out of the box.

[1] https://forums.xamarin.com/discussion/51720/wait-for-device-begininvokeonmainthread
[2] https://stackoverflow.com/a/47941859

* [Core] Add a helper to get the mainthread's SynchronizationContext

It might be handy to expose it, so that F# devs can use it when
employing the Async.SwitchToContext API.

5 years agoMerge branch '4.0.0'
Stephane Delcroix [Thu, 4 Apr 2019 06:55:24 +0000 (08:55 +0200)]
Merge branch '4.0.0'

5 years ago[macOS] Fixes #5257 (#5262)
Andrei [Wed, 3 Apr 2019 17:00:48 +0000 (20:00 +0300)]
[macOS] Fixes #5257 (#5262)

5 years agoAllow EmptyView swapping in Android CollectionView (#5720) fixes #5535
E.Z. Hart [Wed, 3 Apr 2019 16:49:05 +0000 (10:49 -0600)]
Allow EmptyView swapping in Android CollectionView (#5720) fixes #5535

* Automated test for issue

* Fix empty view swapping for Android (fixes #5535)

* Remove private modifier

* Account for null Flags when setting flags for test

* Fix rebase issue

5 years ago[X] check for null on the parent property (#5796)
Stephane Delcroix [Wed, 3 Apr 2019 13:19:48 +0000 (15:19 +0200)]
[X] check for null on the parent property (#5796)

In case of value types in Compiled Binding Paths, we weren't checking
for null property on the right part of the path

before
```csharp
bindingExtension.TypedBinding = new TypedBinding<Gh5770, Color>(delegate(Gh5770 gh)
{
if (gh == null)
{
return new ValueTuple<Color, bool>(default(Color), false);
}
Gh5770VM expr_24 = gh.MyContentViewModel;
return new ValueTuple<Color, bool>(expr_24.TextColor, true);
}, ..., ...);
```

after
```csharp
bindingExtension.TypedBinding = new TypedBinding<Gh5770, Color>(delegate(Gh5770 gh)
{
if (gh == null)
{
return new ValueTuple<Color, bool>(default(Color), false);
}
Gh5770VM expr_24 = gh.MyContentViewModel;
if (expr_24 == null)
{
return new ValueTuple<Color, bool>(default(Color), false);
}
return new ValueTuple<Color, bool>(expr_24.TextColor, true);
}, ..., ...);
```

- fixes #5770

5 years ago[X] resolve generic indexer types (#5794)
Stephane Delcroix [Wed, 3 Apr 2019 13:19:33 +0000 (15:19 +0200)]
[X] resolve generic indexer types (#5794)

- fixes #5510

5 years ago[C] SearchHandler.SelectedItem (#5775)
Stephane Delcroix [Wed, 3 Apr 2019 07:27:13 +0000 (09:27 +0200)]
[C] SearchHandler.SelectedItem (#5775)

- fixes #5712

5 years agotry to avoid merge conflicts in GitInfo.txt (#5715)
Stephane Delcroix [Wed, 3 Apr 2019 06:49:40 +0000 (08:49 +0200)]
try to avoid merge conflicts in GitInfo.txt (#5715)

5 years ago[Shell] propagate BindingContext to SearchHandler (#5730)
Stephane Delcroix [Wed, 3 Apr 2019 06:49:01 +0000 (08:49 +0200)]
[Shell] propagate BindingContext to SearchHandler (#5730)

- fixes #5705

5 years agofix reference to local folder (#5792)
Shane Neuville [Wed, 3 Apr 2019 02:13:35 +0000 (20:13 -0600)]
fix reference to local folder (#5792)

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Tue, 2 Apr 2019 17:28:23 +0000 (18:28 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Shell] propagate BC to BackButtonBehavior (#5743) fixes #5734
Stephane Delcroix [Tue, 2 Apr 2019 16:52:48 +0000 (18:52 +0200)]
[Shell] propagate BC to BackButtonBehavior (#5743) fixes #5734

- fixes #5734

no test, as it's straightforward, and mimics #5730

5 years ago[nuspec] Start using the 28.x versions of Android support (#5512)
Matthew Leibowitz [Tue, 2 Apr 2019 15:06:59 +0000 (17:06 +0200)]
[nuspec] Start using the 28.x versions of Android support (#5512)

5 years ago[C] change searchHandler bindingMode (#5776)
Stephane Delcroix [Tue, 2 Apr 2019 08:02:44 +0000 (10:02 +0200)]
[C] change searchHandler bindingMode (#5776)

Change the default BindingMode for some properties

- fixes #5706

5 years ago[UItest] Added dynamic view gallery (#5402)
Pavel Yakovlev [Tue, 2 Apr 2019 02:45:41 +0000 (05:45 +0300)]
[UItest] Added dynamic view gallery (#5402)

5 years agoFix UI test 4600 for Android/iOS; fixes #4943 (#5726)
E.Z. Hart [Tue, 2 Apr 2019 02:34:36 +0000 (20:34 -0600)]
Fix UI test 4600 for Android/iOS; fixes #4943 (#5726)

5 years agoExtend Control Gallery to allow for Shell UI Tests (#5740)
Shane Neuville [Mon, 1 Apr 2019 20:25:01 +0000 (14:25 -0600)]
Extend Control Gallery to allow for Shell UI Tests (#5740)

* enable UI tests for shell

* - fix test for ios shell

* - add scrollview so success is visible on ios

* - add instructions

* - add shell category

5 years agoAdd covariance back to IElementConfiguration (#5771)
Shane Neuville [Mon, 1 Apr 2019 20:07:59 +0000 (14:07 -0600)]
Add covariance back to IElementConfiguration (#5771)

* add covariance back

* - remove confusing comment

5 years agoMap with ItemTemplateSelector (#5226)
Andrei Nitescu [Mon, 1 Apr 2019 18:12:40 +0000 (21:12 +0300)]
Map with ItemTemplateSelector (#5226)

* Map with ItemTemplateSelector

* Fixed Map test

5 years agoCheck if Element parent is null before getting the padding insets (#5757)
Shane Neuville [Mon, 1 Apr 2019 08:53:53 +0000 (02:53 -0600)]
Check if Element parent is null before getting the padding insets (#5757)

* Check if Element parent is null before getting the padding insets

* - move if up earlier

5 years agoShell.CurrentShell is too many Shells (#5761)
Shane Neuville [Mon, 1 Apr 2019 08:52:18 +0000 (02:52 -0600)]
Shell.CurrentShell is too many Shells (#5761)

5 years agoMerge branch '4.0.0'
Samantha Houts [Thu, 28 Mar 2019 00:14:57 +0000 (17:14 -0700)]
Merge branch '4.0.0'

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Thu, 28 Mar 2019 00:13:02 +0000 (17:13 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years ago[iOS] Don't crash if no Thumbnail specified for AppLink (#5684)
Samantha Houts [Wed, 27 Mar 2019 23:41:38 +0000 (16:41 -0700)]
[iOS] Don't crash if no Thumbnail specified for AppLink (#5684)

* Add test for #5470

* [iOS] Don't crash if no Thumbnail specified for AppLink

fixes #5470

* Add braces

* fix test on Android

5 years agoRemoved dependency on modernhttpclient (#5390)
Andrei Nitescu [Wed, 27 Mar 2019 23:38:45 +0000 (01:38 +0200)]
Removed dependency on modernhttpclient (#5390)

fixes #1886

5 years ago[UWP] Fixes the casting crash of the FontImageSource (#5678)
Pavel Yakovlev [Wed, 27 Mar 2019 23:26:05 +0000 (02:26 +0300)]
[UWP] Fixes the casting crash of the FontImageSource (#5678)

5 years ago[visual] Add extra parameter to android visual constructors (#5289)
Shane Neuville [Wed, 27 Mar 2019 23:10:21 +0000 (17:10 -0600)]
[visual] Add extra parameter to android visual constructors (#5289)

* [visual] Add extra parameter to android visual constructors

* - add null check and constructor to Material Button Renderer to prove scenario

5 years agoHandle DataTemplateSelector on iOS/Android CollectionView (#5429)
E.Z. Hart [Wed, 27 Mar 2019 23:03:35 +0000 (17:03 -0600)]
Handle DataTemplateSelector on iOS/Android CollectionView (#5429)

* DataTemplateSelector working on Android for ItemTemplate and EmptyTemplate

* Demonstrate DataTemplateSelector working with EmptyViewTemplate

* Handle DataTemplateSelector on iOS CollectionView

* Add UI test
Fixes #4826

* Temporarily patching EditorRenderer to get tests running

* Add test for binding errors;
Fix binding errors on Android;

* Fix binding errors for iOS

* Add flag setting to allow UI test to run

* Fix rebase errors

5 years ago[C] alias shell names (#5624)
Stephane Delcroix [Wed, 27 Mar 2019 18:52:12 +0000 (19:52 +0100)]
[C] alias shell names (#5624)

* [C] alias shell names

* - change from ShellTab to Tab