sdk/ide/eclipse-platform-swt.git
8 years agoBug465054 - [GTK3] [GTK3.14] Mixed fonts for labels produces visual garbage on scrolling
Snjezana Peco [Wed, 13 Jan 2016 18:41:38 +0000 (19:41 +0100)]
Bug465054 -  [GTK3] [GTK3.14] Mixed fonts for labels produces visual garbage on scrolling

Change-Id: Iea3918715b5425e17aa9dd4974c61de9ac3d356c
Signed-off-by: Snjezana Peco <snjeza.peco@gmail.com>
8 years agov4529
Arun Thondapu [Wed, 13 Jan 2016 13:11:46 +0000 (18:41 +0530)]
v4529

8 years agov4529
Arun Thondapu [Wed, 13 Jan 2016 13:07:20 +0000 (18:37 +0530)]
v4529

8 years agoBug 479998: [GTK3] Form/wizard Composites have incorrect background
Eric Williams [Thu, 10 Dec 2015 14:37:02 +0000 (09:37 -0500)]
Bug 479998: [GTK3] Form/wizard Composites have incorrect background
colors

UPDATED: This patch also contains fixes to bug 484729.

As of GTK3.16 gtk_widget_override_background_color() is deprecated.
Unfortunately in GTK3.18 it has started to break the background colors
of SwtFixed containers. This is most notably visible in the workspace
selection and commit dialogs, where some background containers had the
default gray background color when they should have been white.

This fix overrides the draw signal in Composite, which allows for CSS
rendering of the background color using gtk_render_background(), which
is the recommended fix as per the GTK team's changes. This ensures that
every composite is drawn with the correct background color if it is set.

The only additional side effect is that ToolBar background colors need
to be set with CSS also, since some SwtFixed containers that were
previously being overridden by ToolBar background colors now are
correctly displaying their own background. This means that ToolBars need
to be rendered with CSS as well. This can be accomplished very easily by
overriding the setBackgroundColor() method in ToolBar.java.

This change will only affect SWT using GTK3.16 and upward. Anything
below 3.16 still uses the old function (which works reliably on those
versions).

Change-Id: I215871be8b6b652d4e77017118415425ae650386
Signed-off-by: Eric Williams <ericwill@redhat.com>
8 years agoBug 481611 - Table/tree column header events have incorrect coordinates
Lakshmi Shanmugam [Mon, 11 Jan 2016 11:57:50 +0000 (17:27 +0530)]
Bug 481611 - Table/tree column header events have incorrect coordinates
in OS X 10.11 El Capitan

In OSX 10.11, the origin of the tree is the header, not the top-left of
the rows. Adjust the co-ordinates accordingly.
Fixed getClientArea, getTopItem, setTopItem, setTopIndex & getTopIndex()
for 10.11. The behavior on older OSX versions remains unchanged.

8 years agoBug 434393 - [10.11] OS X: NPE in Control.internal_new_GC
Lakshmi Shanmugam [Tue, 1 Dec 2015 12:08:30 +0000 (17:38 +0530)]
Bug 434393 - [10.11] OS X: NPE in Control.internal_new_GC

NSGraphicsContext currentContext() returns null on OSX 10.11 when called
from a
non-drawing method, for eg, Table.cellSize(). The fix to is to check if
the context returned is valid, if not we create a new context using
NSGraphicsContext.graphicsContextWithWindow.

8 years agov4528
Arun Thondapu [Wed, 6 Jan 2016 14:52:50 +0000 (20:22 +0530)]
v4528

8 years agoRevert "Bug 479998: [GTK3] Form/wizard Composites have incorrect background colors "
Arun Thondapu [Wed, 6 Jan 2016 14:44:39 +0000 (09:44 -0500)]
Revert "Bug 479998: [GTK3] Form/wizard Composites have incorrect background colors "

This reverts commit a6809d2829e8dba637cdcebd3962e699b1a152b4.

Change-Id: I93f512e8058f88ce5045b0b5af39200e4da01d89

8 years agoBug 479998: [GTK3] Form/wizard Composites have incorrect background
Eric Williams [Thu, 10 Dec 2015 14:37:02 +0000 (09:37 -0500)]
Bug 479998: [GTK3] Form/wizard Composites have incorrect background
colors

As of GTK3.16 gtk_widget_override_background_color() is deprecated.
Unfortunately in GTK3.18 it has started to break the background colors
of SwtFixed containers. This is most notably visible in the workspace
selection and commit dialogs, where some background containers had the
default gray background color when they should have been white.

This fix overrides the draw signal in Composite, which allows for CSS
rendering of the background color using gtk_render_background(), which
is the recommended fix as per the GTK team's changes. This ensures that
every composite is drawn with the correct background color if it is set.

The only additional side effect is that ToolBar background colors need
to be set with CSS also, since some SwtFixed containers that were
previously being overridden by ToolBar background colors now are
correctly displaying their own background. This means that ToolBars need
to be rendered with CSS as well. This can be accomplished very easily by
overriding the setBackgroundColor() method in ToolBar.java.

This change will only affect SWT using GTK3.16 and upward. Anything
below 3.16 still uses the old function (which works reliably on those
versions).

Change-Id: I7b7de3faa53d2ad82b5b546b0e0e607299f123b0
Signed-off-by: Eric Williams <ericwill@redhat.com>
8 years agoBug 480794: [GTK3] TabFolder cannot be traversed with Tab key;
Arun Thondapu [Wed, 6 Jan 2016 13:49:34 +0000 (19:19 +0530)]
Bug 480794: [GTK3] TabFolder cannot be traversed with Tab key;
TabFolder#getChildren() is empty

Fix missing import for ArrayList in
Test_org_eclipse_swt_widgets_TabFolder

Change-Id: I9692bff76b7ef35bda1647c58ac4613bb218572b
Signed-off-by: Arun Thondapu <arunkumar.thondapu@in.ibm.com>
8 years agoBug 480794: [GTK3] TabFolder cannot be traversed with Tab key; TabFolder#getChildren...
Markus Keller [Thu, 5 Nov 2015 20:13:46 +0000 (21:13 +0100)]
Bug 480794: [GTK3] TabFolder cannot be traversed with Tab key; TabFolder#getChildren() is empty

Change-Id: Ib9559713fcf327a535b32be3b12de08467eb9c15

8 years agov4528
Arun Thondapu [Wed, 23 Dec 2015 14:29:38 +0000 (19:59 +0530)]
v4528

8 years agoBug 465644 - [GTK3] Investigate a GTK+ specific fix outside CTabFolder
Niraj Modi [Tue, 6 Oct 2015 06:03:14 +0000 (11:33 +0530)]
Bug 465644 - [GTK3] Investigate a GTK+ specific fix outside CTabFolder
for rendering issues with GTK3

Change-Id: Iaafdf409ec383f2d1d4f94b3f3cf528df37add01
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
8 years agoBug 477798 - [Win32][Cocoa]CTabFolder has wrong initial size
Niraj Modi [Thu, 24 Sep 2015 17:54:30 +0000 (23:24 +0530)]
Bug 477798 - [Win32][Cocoa]CTabFolder has wrong initial size

Change-Id: I0d17531b4875f65a7dc3889cc9bf05f897cf481c
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agov4528
Arun Thondapu [Wed, 14 Oct 2015 11:35:00 +0000 (17:05 +0530)]
v4528

9 years agoBug 478688 - Update parent pom to 4.5.2
Arun Thondapu [Thu, 1 Oct 2015 08:17:32 +0000 (13:47 +0530)]
Bug 478688 - Update parent pom to 4.5.2

Change-Id: Ifc91556fbbf6dbdfa4f9bd477b734e926470c445
Signed-off-by: Arun Thondapu <arunkumar.thondapu@in.ibm.com>
9 years agov4528
Arun Thondapu [Tue, 25 Aug 2015 11:43:22 +0000 (17:13 +0530)]
v4528

9 years agoBug 467852 - [Win32][bidi] Control#setTextDirection(int) on Composite
Lina Kemmel [Tue, 18 Aug 2015 20:54:28 +0000 (02:24 +0530)]
Bug 467852 - [Win32][bidi] Control#setTextDirection(int) on Composite
doesn't memorize AUTO state on Button and Group children

Change-Id: Ifd04c2268de593c7065d4328a2acb58dcda3d5d8
Signed-off-by: Arun Thondapu <arunkumar.thondapu@in.ibm.com>
9 years agoBug 471835 - Build succeeds, even when "old" parent pom is referred to
Markus Keller [Fri, 21 Aug 2015 13:23:20 +0000 (15:23 +0200)]
Bug 471835 - Build succeeds, even when "old" parent pom is referred to

9 years agov4528
Arun Thondapu [Wed, 12 Aug 2015 12:39:15 +0000 (18:09 +0530)]
v4528

9 years agov4528
Arun Thondapu [Wed, 12 Aug 2015 12:29:39 +0000 (17:59 +0530)]
v4528

9 years agoBug 466499 - [GTK3] Path text not drawn in column of commit dialog
Snjezana Peco [Thu, 21 May 2015 08:41:39 +0000 (10:41 +0200)]
Bug 466499 - [GTK3] Path text not drawn in column of commit dialog
window

Change-Id: I508432a354314ca11839e03fbac7b5adc44fff3c
Signed-off-by: Snjezana Peco <snjeza.peco@gmail.com>
9 years agoBug 468208 - [GTK3] Background not painted correctly when using
Sravan Kumar Lakkimsetti [Wed, 27 May 2015 06:25:37 +0000 (11:55 +0530)]
Bug 468208 - [GTK3] Background not painted correctly when using
SWT.EraseItem

Change-Id: Iea209de4f7386ed096a9988c6013a06292726697

Change-Id: I1bbee7468ba50f59d22ff75bf11239d33622a35c
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
9 years agoBug 312568 (part 3) - [GTK] Editor does not get focus after double click
Leo Ufimtsev [Tue, 7 Jul 2015 18:16:01 +0000 (14:16 -0400)]
Bug 312568 (part 3) - [GTK] Editor does not get focus after double click
from Project/Package Explorer.

Refactoring code to better match swt style.
Tested, works as before.

Change-Id: I87990a451a9cda562f1af07fc57be11965fe2ad2
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
9 years agoBug 312568 (Part 2) [GTK] Editor does not get focus after double click
Leo Ufimtsev [Thu, 11 Jun 2015 17:50:29 +0000 (13:50 -0400)]
Bug 312568 (Part 2) [GTK] Editor does not get focus after double click
from Project/Package Explorer.

Moving DefaultSelection event to be sent *after* MouseDoubleClick.

Removing row-activation handler from Tree/Table/List. Instead sending
DefaultSelection event manually in situations described here:
https://developer.gnome.org/gtk3/stable/GtkTreeView.html#GtkTreeView-row-activated
- Double click.
- Space (no modifiers).
- Shift+Space (no other modifiers).
- Return (no modifiers).

This fixes the focus issue in package explorer and also in all widgets
that rely on doubleClick to shift focus, e.g doubleclicking a breakpoint
now shifts focus to the actual breakpoint in the code.

Tests:
 (Eclipse + ControlExample + (other snippets) + (SWT Junit tests))
  * (Gtk2 + Gtk3)

Change-Id: I1a3d6432d68d29a479fcfe6a64f3f4d54e6127d6
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
9 years agoBug 312568 (Part 1) - [GTK] Editor does not get focus after double click
Leo Ufimtsev [Thu, 11 Jun 2015 15:23:42 +0000 (11:23 -0400)]
Bug 312568 (Part 1) - [GTK] Editor does not get focus after double click
from Project/Package Explorer

This is part 1 of the fix to prevent package explorer from stealing
focus.

Here I remove a workaround introduced 11 years ago. See:
git show 300ace8e3eaec6136b4861feec65efae8fe149fc

Originally not-returning focus caused a seg-fault in GtkTree.
But this is no longer the case with current Gtk.

TESTS PERFORMED after removal:
- 64 bit machine
- (SWT Tree+List+Table) * (Gtk2.24 + Gtk3.14)
-> No crashes observed.

I Used snippet in my Repo for testing:
https://github.com/LeoUfimtsev/LeoSwtTests/blob/master/src/standaloneTests/LTEST_465984_TreeDoubleClick.java
But any Tree/Table/List snippet will do.

Noticible changes in the behaviour of the snippet:
 - GTK2 : No changes can be observed with/without patch.
 - GKT3 : Focus now stays in the text field after double-clicking on
          SWT Tree/List/Table.

Part 2 of the fix is on it's way.

Change-Id: Ie27503caac60a97459b3cb86dc9e024f2e879cd0
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
9 years agoBug 457476 - [GTK3] DND issue with overlapping widgets w/ absolute
Leo Ufimtsev [Wed, 20 May 2015 20:09:43 +0000 (16:09 -0400)]
Bug 457476 - [GTK3] DND issue with overlapping widgets w/ absolute
positioning.

Fixed *_forall(..) traversal of child widgets in swtFixed. Incorrect
direction of the traversal caused things like DnD Drop & DnD Motion to
find the incorrect widget as destination in the case of overlapping
widgets with absolute positioning (bottom of stack instead of
top).
This fix has a wide reach. If you notice issues with overlapping
widgets, this may affect it's behaviour.
This may also affect layout of internals of a widget, if you observe
odd behaviour (e.g layout is in inverse of what you expect), please
re-open this bug.

Tests carried out: (Gtk2/Gtk3.14):
- DnD with overlapping widgets.
- SWT Juint tests.
- running an Eclipse, fast-view and the application as a whole.
- LayoutExample, (Row/Column/Fill/Grid/FormAttach/Stack).
- Control Example.

I did a code inspection of code that can be affected. All seems good.

Change-Id: Ide88c6b80f69aadd87f0dc0cb68f65317b9587cb
Signed-off-by: Leo Ufimtsev <lufimtse@redhat.com>
9 years agov4527
Arun Thondapu [Wed, 5 Aug 2015 12:02:08 +0000 (17:32 +0530)]
v4527

9 years agoBug 471431 - Problems with Table/Tree with header on OSX 10.10.3.
Lakshmi Shanmugam [Thu, 2 Jul 2015 10:22:54 +0000 (15:52 +0530)]
Bug 471431 - Problems with Table/Tree with header on OSX 10.10.3.

Revert "Bug 446534 - [10.10] Table/tree with column headers visible has
issues on OS X 10.10 Yosemite"

This reverts the following commits:
5c5a1960ed4fe39af5c026e122d7c1e5145e25fa.
adf7f16f5cf34e63f05f2da0e0bae04f43495e01.
f05b4fbf416f2b0b093907de82f9762b4ada1375.
e36ad026bcc2ea955980a2ee3df2c148939b95c0.

9 years agoBug 474305 (Part 2) - SWT should increase bundle version in Mars SR1 to
Niraj Modi [Wed, 5 Aug 2015 11:16:25 +0000 (16:46 +0530)]
Bug 474305 (Part 2) - SWT should increase bundle version in Mars SR1 to
3.104.1 qualifier

Change-Id: I6c8194771586649167ada0766689071cdeb8d73d
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agoBug 474305 - SWT should increase bundle version in Mars SR1 to 3.104.1
Niraj Modi [Wed, 5 Aug 2015 10:15:34 +0000 (15:45 +0530)]
Bug 474305 - SWT should increase bundle version in Mars SR1 to 3.104.1
qualifier

Change-Id: I5ec147619d25124592f6bd726afe0f6073b64e48
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agoBug 472956 - [Regression][XULRunner] XULRunner crashes when profile path
Niraj Modi [Tue, 4 Aug 2015 14:41:51 +0000 (20:11 +0530)]
Bug 472956 - [Regression][XULRunner] XULRunner crashes when profile path
does not exist

Change-Id: I48a6cc7236c8000fbfbf3f8698d5741d95845740
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agoBug 334234 - [Viewers] TableViewer scrolls the leftmost column into view
Niraj Modi [Thu, 16 Jul 2015 07:49:55 +0000 (13:19 +0530)]
Bug 334234 - [Viewers] TableViewer scrolls the leftmost column into view
unexpectedly

Change-Id: Ic2e90e1349270c5aed9b6e9816b23febd900e109
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agoBug 469765 - Prep for 4.6 (Neon) and 4.5 (Mars) maintenance builds
Arun Thondapu [Tue, 7 Jul 2015 14:04:44 +0000 (19:34 +0530)]
Bug 469765 - Prep for 4.6 (Neon) and 4.5 (Mars) maintenance builds

Update pom files to use 4.5.1 for parent pom

Change-Id: Iaf85f7c70a80cae531ff499140674ed590208de8

9 years agov4527
Arun Thondapu [Thu, 28 May 2015 06:11:10 +0000 (11:41 +0530)]
v4527

9 years agoBug 468439 - Do the annual javadoc bash for 4.5
Lakshmi Shanmugam [Wed, 27 May 2015 07:18:39 +0000 (12:48 +0530)]
Bug 468439 - Do the annual javadoc bash for 4.5
- javadoc changes.

Change-Id: I7407abcffd09e1e2e5f65aff39fdd4d6e4448ad6
Signed-off-by: Lakshmi Shanmugam <lshanmug@in.ibm.com>
9 years agov4527
Arun Thondapu [Sun, 24 May 2015 23:01:17 +0000 (04:31 +0530)]
v4527

9 years agov4527
Arun Thondapu [Sat, 23 May 2015 23:01:17 +0000 (04:31 +0530)]
v4527

9 years agov4527
Arun Thondapu [Fri, 22 May 2015 23:01:16 +0000 (04:31 +0530)]
v4527

9 years agov4527
Arun Thondapu [Thu, 21 May 2015 23:01:17 +0000 (04:31 +0530)]
v4527

9 years agov4527
Arun Thondapu [Thu, 21 May 2015 12:25:57 +0000 (17:55 +0530)]
v4527

9 years agoBug 467601 - [Win32][bidi] Control#setTextDirection(int) doesn't
Lina Kemmel [Thu, 21 May 2015 12:17:00 +0000 (17:47 +0530)]
Bug 467601 - [Win32][bidi] Control#setTextDirection(int) doesn't
propagate AUTO to children of Composite

Change-Id: I13de91b4d8024132f26f037869a1ff5b9fd75354
Signed-off-by: Lina Kemmel <lkemmel@il.ibm.com>
9 years agoBug 467687 - SWT: Invalid thread access in GC.drawImage
Sravan Kumar Lakkimsetti [Wed, 20 May 2015 17:27:04 +0000 (22:57 +0530)]
Bug 467687 - SWT: Invalid thread access in GC.drawImage

On Windows created a new method getActualDPI() that works in non ui
threads as well and using this to get the dpi

On linux modified the getActualdpi() method to not use getbounds call
which is actually not required as we need on only x and y of the
display. these are always 0, 0 in all cases of getBounds.

Updated with review comments

Change-Id: I7154ca7a2493fc21d1e38388a2f19c885ce9e4bf
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
9 years agov4527
Arun Thondapu [Wed, 20 May 2015 23:01:17 +0000 (04:31 +0530)]
v4527

9 years agov4527
Arun Thondapu [Wed, 20 May 2015 12:09:13 +0000 (17:39 +0530)]
v4527

9 years agov4527
Arun Thondapu [Wed, 20 May 2015 12:05:02 +0000 (17:35 +0530)]
v4527

9 years agoBug 467656 - CCombo dropdown popup doesn't close automatically
Niraj Modi [Wed, 20 May 2015 11:57:40 +0000 (17:27 +0530)]
Bug 467656 - CCombo dropdown popup doesn't close automatically

Change-Id: Icedbaaf8bb692861225511711b7adf257cf66bf3
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agoBug 467664 - [GTK3][ppc64le] Add support for GTK3 in SWT for
Sravan Kumar Lakkimsetti [Wed, 20 May 2015 11:11:17 +0000 (16:41 +0530)]
Bug 467664 - [GTK3][ppc64le] Add support for GTK3 in SWT for
Power8/ppc64le platform

Change-Id: I057b853d75651f6fd8f4ef81719077030c50ff3d
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
9 years agoBug 433817 - Shell#setText with newlines (\n) causes the shell title to
Niraj Modi [Wed, 20 May 2015 10:22:27 +0000 (15:52 +0530)]
Bug 433817 - Shell#setText with newlines (\n) causes the shell title to
disappear

Change-Id: I56cac9c5799d3009b3a480a81604944c8251e23b
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agov4526
Arun Thondapu [Tue, 19 May 2015 23:01:16 +0000 (04:31 +0530)]
v4526

9 years agoBug 433817 - Shell#setText with newlines (\n) causes the shell title to
Niraj Modi [Tue, 19 May 2015 12:22:17 +0000 (17:52 +0530)]
Bug 433817 - Shell#setText with newlines (\n) causes the shell title to
disappear
- fixed JavaDoc changes to use the term "escape sequences"

Change-Id: I141c0dd13fb97fee5c6d7b5edb5d9cf739822b0c
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agov4526
Arun Thondapu [Mon, 18 May 2015 23:01:16 +0000 (04:31 +0530)]
v4526

9 years agoBug 438505 - [GTK3] Problem with table/tree editing
Snjezana Peco [Thu, 14 May 2015 08:16:41 +0000 (10:16 +0200)]
Bug 438505 - [GTK3] Problem with table/tree editing

Change-Id: I0038080544c6cbfae7fa8abee54b7660dea2dc3b
Signed-off-by: Snjezana Peco <snjeza.peco@gmail.com>
9 years agov4526
Arun Thondapu [Sun, 17 May 2015 23:01:17 +0000 (04:31 +0530)]
v4526

9 years agov4526
Arun Thondapu [Sat, 16 May 2015 23:01:16 +0000 (04:31 +0530)]
v4526

9 years agov4526
Arun Thondapu [Fri, 15 May 2015 23:01:18 +0000 (04:31 +0530)]
v4526

9 years agoBug 433817 - Shell#setText with newlines (\n) causes the shell title to
Niraj Modi [Fri, 15 May 2015 13:25:07 +0000 (18:55 +0530)]
Bug 433817 - Shell#setText with newlines (\n) causes the shell title to
disappear
- Fixed JavaDocs for CCombo#add() methods.

Change-Id: I79b3b142f0f6cd2cd2d4b55ad3d350dea0062681
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agov4526
Arun Thondapu [Thu, 14 May 2015 23:01:18 +0000 (04:31 +0530)]
v4526

9 years agoBug 433817 - Shell#setText with newlines (\n) causes the shell title to
Niraj Modi [Thu, 14 May 2015 10:03:25 +0000 (15:33 +0530)]
Bug 433817 - Shell#setText with newlines (\n) causes the shell title to
disappear

Change-Id: Ic2ac18c47274c40c6eda3d1bb309077d0b84908b
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agoBug 433817 - Shell#setText with newlines (\n) causes the shell title to
Niraj Modi [Thu, 14 May 2015 08:50:53 +0000 (14:20 +0530)]
Bug 433817 - Shell#setText with newlines (\n) causes the shell title to
disappear

Change-Id: I701985afc2cd779035b14cb1287513d42bf086c7
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agov4526
Arun Thondapu [Wed, 13 May 2015 23:01:17 +0000 (04:31 +0530)]
v4526

9 years agov4526
Arun Thondapu [Wed, 13 May 2015 20:02:20 +0000 (01:32 +0530)]
v4526

9 years agov4526
Arun Thondapu [Wed, 13 May 2015 19:59:06 +0000 (01:29 +0530)]
v4526

9 years agoBug 465757 - [Browser][Xulrunner] When browser is using XULRunner, the
Lakshmi Shanmugam [Wed, 13 May 2015 19:07:28 +0000 (00:37 +0530)]
Bug 465757 - [Browser][Xulrunner] When browser is using XULRunner, the
browser.evaluate function is always returning null
Patch to put back the code required for BrowserFunction to work on
versions < 24. This code was removed as part of fix for 429739.
The new approach in that fix is used for XULR versions >= 24. For XULR versions < 24, we still need the old code.

9 years agoBug 465757 - When browser is using XULRunner, the browser.evaluate
Lakshmi Shanmugam [Wed, 13 May 2015 17:27:36 +0000 (22:57 +0530)]
Bug 465757 - When browser is using XULRunner, the browser.evaluate
function is always returning null.
-Modified evaluate(script) to use evaluate(script, false) so that
evaluate executes in the context of the current document.
-Modified javadoc of evaluate(script,trusted)
-fixed a typo on nsIHelperAppLauncher_1_8.java

9 years ago[Bug 430012] [BiDi] Implement contextual base text direction for
Lina Kemmel [Wed, 13 May 2015 18:55:18 +0000 (21:55 +0300)]
[Bug 430012] [BiDi] Implement contextual base text direction for
Widgets:
GTK and Cocoa constants / stubs

9 years agoRevert "Misc changes"
Arun Thondapu [Wed, 13 May 2015 18:00:57 +0000 (23:30 +0530)]
Revert "Misc changes"

This reverts commit 28eae5a124e699ec7aa8293ac7fa643d7d4191ce.

9 years agoMisc changes
Lina Kemmel [Wed, 13 May 2015 16:26:24 +0000 (19:26 +0300)]
Misc changes

9 years agoSupport AUTO (contextual) text direction for Controls
Lina Kemmel [Wed, 13 May 2015 16:24:04 +0000 (19:24 +0300)]
Support AUTO (contextual) text direction for Controls

9 years agoBug 465309 - [GTK3] No icon showing in open type dialog
Sravan Kumar Lakkimsetti [Wed, 13 May 2015 09:52:27 +0000 (15:22 +0530)]
Bug 465309 - [GTK3] No icon showing in open type dialog

Adjusted the clip rectangle to consider the icon size as well

Change-Id: I326a3f84068ec804d6c2c0cac166cd8fbebb6c7e
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
9 years agov4525
Arun Thondapu [Tue, 12 May 2015 23:01:15 +0000 (04:31 +0530)]
v4525

9 years agov4525
Arun Thondapu [Tue, 12 May 2015 17:55:50 +0000 (23:25 +0530)]
v4525

9 years agoBug 438505 - [GTK3] Problem with table editing
Snjezana Peco [Sun, 10 May 2015 22:17:05 +0000 (00:17 +0200)]
Bug 438505 -  [GTK3] Problem with table editing

Change-Id: I30c9caaa1b71547eb4c762f4f074b0dadf719e26
Signed-off-by: Snjezana Peco <snjeza.peco@gmail.com>
9 years agoBug 466943 - Bogus UI freeze logged on Mac when opening a view menu
Sergey Prigogin [Tue, 12 May 2015 13:38:44 +0000 (06:38 -0700)]
Bug 466943 - Bogus UI freeze logged on Mac when opening a view menu

Change-Id: I045207e49db6d897cb40eb78ef9ae4f922a13a28
Signed-off-by: Sergey Prigogin <eclipse.sprigogin@gmail.com>
9 years agoBug 466202 - XULRunner 24 : memory leak when calling SWT BrowserFunction
Niraj Modi [Tue, 12 May 2015 14:00:05 +0000 (19:30 +0530)]
Bug 466202 - XULRunner 24 : memory leak when calling SWT BrowserFunction

Change-Id: Ic5a649f9f99d8396fbcedc2b924c80acfbfed7f5
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agov4525
Arun Thondapu [Tue, 12 May 2015 13:57:24 +0000 (19:27 +0530)]
v4525

9 years agoBug 466975 - XULRunner browser crashes when any file is downloaded.
Lakshmi Shanmugam [Mon, 11 May 2015 18:14:19 +0000 (23:44 +0530)]
Bug 466975 - XULRunner browser crashes when any file is downloaded.
Fixed the code to return correct method indexes for
nsIHelperAppLauncher_1_8.saveToDisk() and nsICancelable.cancel().
Modified getMethodIndex() to throw error if something fails instead of
returning -1 and causing a crash eventually.

9 years agov4525
Arun Thondapu [Mon, 11 May 2015 17:36:27 +0000 (23:06 +0530)]
v4525

9 years agov4525
Arun Thondapu [Mon, 11 May 2015 17:29:51 +0000 (22:59 +0530)]
v4525

9 years agoBug 466112 - Fix for Control.getMonitor(), which was returning
Stefan Xenos [Thu, 7 May 2015 21:04:57 +0000 (14:04 -0700)]
Bug 466112 - Fix for Control.getMonitor(), which was returning
wildly incorrect monitor boundaries.

Change-Id: I8c3b284c7fd591e1a5448b5d516328f1f83c47a2
Signed-off-by: Stefan Xenos <sxenos@google.com>
9 years agoBug 466112 - Use the correct GDK calls to
Stefan Xenos [Thu, 7 May 2015 21:03:20 +0000 (14:03 -0700)]
Bug 466112 - Use the correct GDK calls to
compute the client area for the monitors

Change-Id: I4d94860d40d2726e98c2416a50c8bc72fa9d9286
Signed-off-by: Stefan Xenos <sxenos@google.com>
9 years agoBug 411719 - [Win32] UnsatisfiedLinkError: GREVersionRange_sizeof() on
Niraj Modi [Mon, 11 May 2015 07:06:37 +0000 (12:36 +0530)]
Bug 411719 - [Win32] UnsatisfiedLinkError: GREVersionRange_sizeof() on
Windows 64 while creating new Browser(MOZILLA)
- Added comments in Mozilla class for this bug fix.

Change-Id: I74ef8a41552134ba8560aa7aaa2293784cb6b950
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agov4524
Arun Thondapu [Sun, 10 May 2015 23:01:16 +0000 (04:31 +0530)]
v4524

9 years agov4524
Arun Thondapu [Sat, 9 May 2015 23:01:17 +0000 (04:31 +0530)]
v4524

9 years agov4524
Arun Thondapu [Fri, 8 May 2015 23:01:16 +0000 (04:31 +0530)]
v4524

9 years agoBug 411719 - [Win32] UnsatisfiedLinkError: GREVersionRange_sizeof() on
Niraj Modi [Fri, 8 May 2015 11:42:52 +0000 (17:12 +0530)]
Bug 411719 - [Win32] UnsatisfiedLinkError: GREVersionRange_sizeof() on
Windows 64 while creating new Browser(MOZILLA)

Change-Id: I2cbeccb3254d32dfd892c96189cc8dcb3baac5d1
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
9 years agov4524
Arun Thondapu [Thu, 7 May 2015 23:01:18 +0000 (04:31 +0530)]
v4524

9 years agov4524
Arun Thondapu [Thu, 7 May 2015 19:34:47 +0000 (01:04 +0530)]
v4524

9 years agoBug 464816 - [Gtk3] Adding SWT.EraseItem listener and drawing background
Niraj Modi [Wed, 29 Apr 2015 05:54:10 +0000 (11:24 +0530)]
Bug 464816 - [Gtk3] Adding SWT.EraseItem listener and drawing background
makes the TreeItem/TableItem text dissapear
- Updated Code for Table as well

The code change is related to setting the correct clipping during the EraseItem event.

This has been tested on Fedora 19 with GTK+ 3.8.8 and Ubuntu 14.04 with GTK+ 3.10.

Testing is done using the snippet provided and modified snippet for table as well. Ran the SWT junit test suite.

For regression testing, used a self hosted eclipse and tested on multiple views like Call hierarchy, Type hierarchy, etc. Verified that they are working fine.

Change-Id: I8bdb7f219ccbfec467b85c88a1e72c5fdc3dcf3e
Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
9 years agov4524
Arun Thondapu [Wed, 6 May 2015 23:01:18 +0000 (04:31 +0530)]
v4524

9 years agov4524
Arun Thondapu [Tue, 5 May 2015 23:01:16 +0000 (04:31 +0530)]
v4524

9 years agov4524
Arun Thondapu [Mon, 4 May 2015 23:01:17 +0000 (04:31 +0530)]
v4524

9 years agoBug 465721: SWT Browser Tests fail with I-build I20150427-0800 & later
Markus Keller [Mon, 4 May 2015 10:15:53 +0000 (12:15 +0200)]
Bug 465721: SWT Browser Tests fail with I-build I20150427-0800 & later

9 years agodocument usage of internal method OS.setDarkThemePreferred(boolean)
Markus Keller [Mon, 4 May 2015 09:47:35 +0000 (11:47 +0200)]
document usage of internal method OS.setDarkThemePreferred(boolean)

9 years agov4524
Arun Thondapu [Sun, 3 May 2015 23:01:17 +0000 (04:31 +0530)]
v4524

9 years agov4524
Arun Thondapu [Sat, 2 May 2015 23:01:18 +0000 (04:31 +0530)]
v4524

9 years agov4524
Arun Thondapu [Fri, 1 May 2015 23:01:16 +0000 (04:31 +0530)]
v4524

9 years agov4524
Arun Thondapu [Thu, 30 Apr 2015 23:01:16 +0000 (04:31 +0530)]
v4524

9 years agov4524
Arun Thondapu [Thu, 30 Apr 2015 16:53:32 +0000 (22:23 +0530)]
v4524

9 years agoBug 465868 - A UI freeze in context assist is not caught by UI
Sergey Prigogin [Thu, 30 Apr 2015 03:10:21 +0000 (20:10 -0700)]
Bug 465868 - A UI freeze in context assist is not caught by UI
Responsiveness Monitoring

Change-Id: If4cc13aabc8733c1c0ae6177cd2e82bbcb1a513c
Signed-off-by: Sergey Prigogin <eclipse.sprigogin@gmail.com>