platform/upstream/libSkiaSharp.git
11 years agoProvide an option to bench drawing individual tiles in bench_pictures.
scroggo@google.com [Thu, 13 Dec 2012 22:09:28 +0000 (22:09 +0000)]
Provide an option to bench drawing individual tiles in bench_pictures.

Provides output like the following:
running bench [1236 12045] androidpolice.skp
  tile_256x256: tile [0,0] out of [5,48]: msecs =   1.00
  tile_256x256: tile [1,0] out of [5,48]: msecs =   1.50
  tile_256x256: tile [2,0] out of [5,48]: msecs =   1.00
  tile_256x256: tile [3,0] out of [5,48]: msecs =   1.50
  tile_256x256: tile [4,0] out of [5,48]: msecs =   2.50
  tile_256x256: tile [0,1] out of [5,48]: msecs =   2.00
  tile_256x256: tile [1,1] out of [5,48]: msecs =   3.50
  tile_256x256: tile [2,1] out of [5,48]: msecs =   3.50
  tile_256x256: tile [3,1] out of [5,48]: msecs =   6.00
  tile_256x256: tile [4,1] out of [5,48]: msecs =   2.50
  tile_256x256: tile [0,2] out of [5,48]: msecs =   2.00

BUG=https://code.google.com/p/skia/issues/detail?id=1016

Review URL: https://codereview.appspot.com/6937047

git-svn-id: http://skia.googlecode.com/svn/trunk@6805 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIn the config name, report the viewport, if one is provided.
scroggo@google.com [Thu, 13 Dec 2012 22:07:08 +0000 (22:07 +0000)]
In the config name, report the viewport, if one is provided.

Review URL: https://codereview.appspot.com/6942048

git-svn-id: http://skia.googlecode.com/svn/trunk@6804 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert 6798 (assert in GM)
reed@google.com [Thu, 13 Dec 2012 21:53:41 +0000 (21:53 +0000)]
revert 6798 (assert in GM)

git-svn-id: http://skia.googlecode.com/svn/trunk@6802 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd debugging flag SK_IGNORE_PIXELREF_SETPRELOCKED for pixelref locks (disabled)
reed@google.com [Thu, 13 Dec 2012 21:41:00 +0000 (21:41 +0000)]
add debugging flag SK_IGNORE_PIXELREF_SETPRELOCKED for pixelref locks (disabled)

git-svn-id: http://skia.googlecode.com/svn/trunk@6800 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow bench_pictures to have its viewport set on the command line.
scroggo@google.com [Thu, 13 Dec 2012 21:40:48 +0000 (21:40 +0000)]
Allow bench_pictures to have its viewport set on the command line.

Instead of drawing the entire (potentially very large) picture, only
draw one viewport's worth.

example:

bench_pictures <skp directory> --viewport 640 480

BUG=https://code.google.com/p/skia/issues/detail?id=1007

Review URL: https://codereview.appspot.com/6943052

git-svn-id: http://skia.googlecode.com/svn/trunk@6799 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGoal: ensure we always balance lock/unlock pixels calls.
reed@google.com [Thu, 13 Dec 2012 21:39:56 +0000 (21:39 +0000)]
Goal: ensure we always balance lock/unlock pixels calls.

A big caller of lockPixels is setContext in the bitmapshader.

This change replaces beginSession/endSession with adding endContext(), and
adds debugging code to ensure that
1. setContext calls are never nested
2. endContext is always called after each setContext call.
Review URL: https://codereview.appspot.com/6937046

git-svn-id: http://skia.googlecode.com/svn/trunk@6798 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix oversights in r6793.
bsalomon@google.com [Thu, 13 Dec 2012 20:43:56 +0000 (20:43 +0000)]
Fix oversights in r6793.

git-svn-id: http://skia.googlecode.com/svn/trunk@6794 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse GrDrawTarget::AutoClipRestore to set temporary irect clips.
bsalomon@google.com [Thu, 13 Dec 2012 20:38:14 +0000 (20:38 +0000)]
Use GrDrawTarget::AutoClipRestore to set temporary irect clips.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6937048

git-svn-id: http://skia.googlecode.com/svn/trunk@6793 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix Android SampleApp
djsollen@google.com [Thu, 13 Dec 2012 20:07:21 +0000 (20:07 +0000)]
Fix Android SampleApp

Review URL: https://codereview.appspot.com/6949046

git-svn-id: http://skia.googlecode.com/svn/trunk@6792 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a state bit to GrDrawState that forces coverage to be blended.
bsalomon@google.com [Thu, 13 Dec 2012 19:59:23 +0000 (19:59 +0000)]
Add a state bit to GrDrawState that forces coverage to be blended.

Use this mode in GrClipMaskManager.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6945048

git-svn-id: http://skia.googlecode.com/svn/trunk@6790 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd the original path renderer files and some support files from Android.
jvanverth@google.com [Thu, 13 Dec 2012 19:53:18 +0000 (19:53 +0000)]
Add the original path renderer files and some support files from Android.
Renamed PathRenderer.{cpp,h} to AndroidPathRenderer.{cpp,h} to avoid name
collisions.

http://codereview.appspot.com/6938050/

git-svn-id: http://skia.googlecode.com/svn/trunk@6789 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Thu, 13 Dec 2012 19:47:53 +0000 (19:47 +0000)]
shape ops work in progress

things work pretty well up to this point
it's time to apply recent deletion of binary code
algorithms to the unary code path

git-svn-id: http://skia.googlecode.com/svn/trunk@6788 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange to BDS license (as we did with all the other files that were Apache)
reed@google.com [Thu, 13 Dec 2012 19:24:05 +0000 (19:24 +0000)]
Change to BDS license (as we did with all the other files that were Apache)
Review URL: https://codereview.appspot.com/6948045

git-svn-id: http://skia.googlecode.com/svn/trunk@6787 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix android build by removing references to the old sampleApp
djsollen@google.com [Thu, 13 Dec 2012 18:27:44 +0000 (18:27 +0000)]
Fix android build by removing references to the old sampleApp

Review URL: https://codereview.appspot.com/6949045

git-svn-id: http://skia.googlecode.com/svn/trunk@6786 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoModifying SkTileGrid to support arbitrary query rectangles.
junov@chromium.org [Thu, 13 Dec 2012 16:39:53 +0000 (16:39 +0000)]
Modifying SkTileGrid to support arbitrary query rectangles.
Exposing SkTileGrid functionality in the public API through SkTileGridPicture.
This patch also makes TileGrid and Rtree testable in gm, which revealed errors.

TEST=gm with '--tileGrid'
BUG=http://code.google.com/p/chromium/issues/detail?id=164636
Review URL: https://codereview.appspot.com/6933044

git-svn-id: http://skia.googlecode.com/svn/trunk@6783 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agokill unused SkFlipPixelRef
reed@google.com [Thu, 13 Dec 2012 16:35:37 +0000 (16:35 +0000)]
kill unused SkFlipPixelRef
Review URL: https://codereview.appspot.com/6949043

git-svn-id: http://skia.googlecode.com/svn/trunk@6781 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing clip region test in deferred canvas, used to determine whether a draw operatio...
junov@chromium.org [Thu, 13 Dec 2012 16:30:39 +0000 (16:30 +0000)]
Fixing clip region test in deferred canvas, used to determine whether a draw operation occludes the entire canvas.

BUG=http://code.google.com/p/chromium/issues/detail?id=164580
TEST=unit test DeferredCanvas/TestDeferredCanvasFreshFrame
Review URL: https://codereview.appspot.com/6934045

git-svn-id: http://skia.googlecode.com/svn/trunk@6780 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMatrix inversion optimizations and benchmark; originally by whunt@google.com.
tomhudson@google.com [Thu, 13 Dec 2012 09:55:42 +0000 (09:55 +0000)]
Matrix inversion optimizations and benchmark; originally by whunt@google.com.

https://codereview.appspot.com/6901046/

git-svn-id: http://skia.googlecode.com/svn/trunk@6775 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 13 Dec 2012 02:01:33 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6774 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse double precision when iterating in SkDashPathEffect::filterPath()
fmalita@google.com [Wed, 12 Dec 2012 22:13:58 +0000 (22:13 +0000)]
Use double precision when iterating in SkDashPathEffect::filterPath()

Extremely large path_length/dash_length ratios may cause us to loop
indefinitely otherwise.

R=reed@google.com

BUG=

Review URL: https://codereview.appspot.com/6926051

git-svn-id: http://skia.googlecode.com/svn/trunk@6773 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSet git to ignore .android_config
scroggo@google.com [Wed, 12 Dec 2012 21:21:29 +0000 (21:21 +0000)]
Set git to ignore .android_config

Review URL: https://codereview.appspot.com/6863056

git-svn-id: http://skia.googlecode.com/svn/trunk@6772 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert 6766, thereby re-landing 6762-6763 now that the bots are ready
reed@google.com [Wed, 12 Dec 2012 20:48:18 +0000 (20:48 +0000)]
revert 6766, thereby re-landing 6762-6763 now that the bots are ready

git-svn-id: http://skia.googlecode.com/svn/trunk@6770 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd bench_pictures config
borenet@google.com [Wed, 12 Dec 2012 20:13:26 +0000 (20:13 +0000)]
Add bench_pictures config
Review URL: https://codereview.appspot.com/6873073

git-svn-id: http://skia.googlecode.com/svn/trunk@6768 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert 6762-6763, since those require new skps to be generated, and we can't
reed@google.com [Wed, 12 Dec 2012 19:15:31 +0000 (19:15 +0000)]
revert 6762-6763, since those require new skps to be generated, and we can't
do that immediately right now... will re-submit when we can.

git-svn-id: http://skia.googlecode.com/svn/trunk@6766 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopart of prev CL for rrect
reed@google.com [Wed, 12 Dec 2012 19:03:29 +0000 (19:03 +0000)]
part of prev CL for rrect

git-svn-id: http://skia.googlecode.com/svn/trunk@6763 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomake RRect and Oval first-class drawing primitives in SkCanvas.
reed@google.com [Wed, 12 Dec 2012 19:02:53 +0000 (19:02 +0000)]
make RRect and Oval first-class drawing primitives in SkCanvas.
add RRect as a first-class clip primitive.
Review URL: https://codereview.appspot.com/6923058

git-svn-id: http://skia.googlecode.com/svn/trunk@6762 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding quickContains API method to SkClipStack
junov@chromium.org [Wed, 12 Dec 2012 17:58:15 +0000 (17:58 +0000)]
Adding quickContains API method to SkClipStack

BUG=http://code.google.com/p/chromium/issues/detail?id=164580
TEST=unit test ClipStack/quickContains
Review URL: https://codereview.appspot.com/6919044

git-svn-id: http://skia.googlecode.com/svn/trunk@6760 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCreate SkBitmapChecksummer and associated SkBitmapTransformer
epoger@google.com [Wed, 12 Dec 2012 17:22:23 +0000 (17:22 +0000)]
Create SkBitmapChecksummer and associated SkBitmapTransformer

As needed to start capturing gm image checksums.
Review URL: https://codereview.appspot.com/6920050

git-svn-id: http://skia.googlecode.com/svn/trunk@6759 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMinor cleanup
robertphillips@google.com [Wed, 12 Dec 2012 15:58:25 +0000 (15:58 +0000)]
Minor cleanup

https://codereview.appspot.com/6927054/

git-svn-id: http://skia.googlecode.com/svn/trunk@6756 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix generation of random two point gradients for program unit test.
bsalomon@google.com [Tue, 11 Dec 2012 15:32:04 +0000 (15:32 +0000)]
Fix generation of random two point gradients for program unit test.

git-svn-id: http://skia.googlecode.com/svn/trunk@6751 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 11 Dec 2012 02:01:20 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6746 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing logic error in deferred canvas unittest.
junov@chromium.org [Mon, 10 Dec 2012 21:24:38 +0000 (21:24 +0000)]
Fixing logic error in deferred canvas unittest.

Fixing an inverted test condition.  The tested feature is not broken, but the test was passing the inverted test because code just above was missing a restore call, which was affecting the test.
Review URL: https://codereview.appspot.com/6921044

git-svn-id: http://skia.googlecode.com/svn/trunk@6745 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse new enum-constructors
reed@google.com [Mon, 10 Dec 2012 21:21:27 +0000 (21:21 +0000)]
use new enum-constructors

git-svn-id: http://skia.googlecode.com/svn/trunk@6744 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for Mac-specific OpenGL == complaint in GrGLProgram.cpp
robertphillips@google.com [Mon, 10 Dec 2012 21:05:19 +0000 (21:05 +0000)]
Fix for Mac-specific OpenGL == complaint in GrGLProgram.cpp

Unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@6743 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkMatrix44 constructor that allows user to control the initialization
vollick@chromium.org [Mon, 10 Dec 2012 20:16:10 +0000 (20:16 +0000)]
Add SkMatrix44 constructor that allows user to control the initialization
method.  Preliminary results using Chromium's cc_perftests
show that we can avoid almost half of the default constructors from
redundantly/unnecessarily initializing the matrix to identity.

Review URL: https://codereview.appspot.com/6872056

git-svn-id: http://skia.googlecode.com/svn/trunk@6742 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoModifications to GrPatherRenderer(Chain) interfaces to support clip mask manager.
bsalomon@google.com [Mon, 10 Dec 2012 19:10:17 +0000 (19:10 +0000)]
Modifications to GrPatherRenderer(Chain) interfaces to support clip mask manager.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6904069

git-svn-id: http://skia.googlecode.com/svn/trunk@6741 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhen cloning picture, use a bitmap heap to avoid flattening bitmaps.
scroggo@google.com [Mon, 10 Dec 2012 18:20:23 +0000 (18:20 +0000)]
When cloning picture, use a bitmap heap to avoid flattening bitmaps.

When cloning a picture, the paints are reflattened. Use a bitmap
heap so the bitmaps do not get unnecessarily get flattened as well.

For br.337, this speeds up bench_pictures timing the clone
operation (not yet checked in, but currently timing making five
clones) from around 180 ms to around 24ms.

Review URL: https://codereview.appspot.com/6903063

git-svn-id: http://skia.googlecode.com/svn/trunk@6740 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agooptimize for paints that don't require deep copy during clone
reed@google.com [Mon, 10 Dec 2012 17:39:36 +0000 (17:39 +0000)]
optimize for paints that don't require deep copy during clone
Review URL: https://codereview.appspot.com/6903062

git-svn-id: http://skia.googlecode.com/svn/trunk@6739 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDisable failing test on android.
bsalomon@google.com [Mon, 10 Dec 2012 17:32:07 +0000 (17:32 +0000)]
Disable failing test on android.
Review URL: https://codereview.appspot.com/6899059

git-svn-id: http://skia.googlecode.com/svn/trunk@6738 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomark our unflattened bitmap as immutable (just as picture deserialization does)
reed@google.com [Mon, 10 Dec 2012 16:10:33 +0000 (16:10 +0000)]
mark our unflattened bitmap as immutable (just as picture deserialization does)

git-svn-id: http://skia.googlecode.com/svn/trunk@6736 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd '--mode clone' option to bench_pictures
reed@google.com [Mon, 10 Dec 2012 16:05:09 +0000 (16:05 +0000)]
add '--mode clone' option to bench_pictures

git-svn-id: http://skia.googlecode.com/svn/trunk@6735 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodon't convert clipPath -> clipRect if the path is inverse-filled
reed@google.com [Mon, 10 Dec 2012 15:50:37 +0000 (15:50 +0000)]
don't convert clipPath -> clipRect if the path is inverse-filled

git-svn-id: http://skia.googlecode.com/svn/trunk@6734 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIn SKP serialization, use existing encoded data.
scroggo@google.com [Mon, 10 Dec 2012 15:40:55 +0000 (15:40 +0000)]
In SKP serialization, use existing encoded data.

If an SkBitmap has encoded data, write that during serialization
rather than reencoding it.

Add a test to ensure that this does not modify the output stream,
so the reader need not know the difference.

Review URL: https://codereview.appspot.com/6884054

git-svn-id: http://skia.googlecode.com/svn/trunk@6732 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing SkClipStack::clipDevPath so that it will not convert rectangular paths to...
junov@chromium.org [Mon, 10 Dec 2012 14:57:54 +0000 (14:57 +0000)]
Fixing SkClipStack::clipDevPath so that it will not convert rectangular paths to rectangle clips if inverse fill.

BUG=http://code.google.com/p/chromium/issues/detail?id=164580
TEST=unit test ClipStackTest/test_rect_inverse_fill
Review URL: https://codereview.appspot.com/6880044

git-svn-id: http://skia.googlecode.com/svn/trunk@6731 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 10 Dec 2012 14:50:04 +0000 (14:50 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@6730 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReapply (r6718) with fix for compiler error on linux.
djsollen@google.com [Mon, 10 Dec 2012 14:12:55 +0000 (14:12 +0000)]
Reapply (r6718) with fix for compiler error on linux.

git-svn-id: http://skia.googlecode.com/svn/trunk@6729 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert Reapply r5364 (Update ARM and NEON optimizations for S32A_Opaque_BlitRow32)
djsollen@google.com [Mon, 10 Dec 2012 14:10:20 +0000 (14:10 +0000)]
revert Reapply r5364 (Update ARM and NEON optimizations for S32A_Opaque_BlitRow32)

git-svn-id: http://skia.googlecode.com/svn/trunk@6728 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReapply r5364 (Update ARM and NEON optimizations for S32A_Opaque_BlitRow32)
djsollen@google.com [Mon, 10 Dec 2012 13:55:02 +0000 (13:55 +0000)]
Reapply r5364 (Update ARM and NEON optimizations for S32A_Opaque_BlitRow32)

This reverts r5378.

Review URL: https://codereview.appspot.com/6815056

git-svn-id: http://skia.googlecode.com/svn/trunk@6727 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 10 Dec 2012 12:50:53 +0000 (12:50 +0000)]
shape ops work in progress

rewrite binary edge inclusion lookup
fix warnings

git-svn-id: http://skia.googlecode.com/svn/trunk@6726 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd helpers for isTranslate and isScaleTranslate
mike@reedtribe.org [Mon, 10 Dec 2012 03:27:47 +0000 (03:27 +0000)]
add helpers for isTranslate and isScaleTranslate
special-case determinant for isScaleTranslate

git-svn-id: http://skia.googlecode.com/svn/trunk@6725 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 8 Dec 2012 02:01:38 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6721 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Added the following 3 features to sample app."
djsollen@google.com [Fri, 7 Dec 2012 22:10:39 +0000 (22:10 +0000)]
Revert "Added the following 3 features to sample app."

Review URL: https://codereview.appspot.com/6906054

git-svn-id: http://skia.googlecode.com/svn/trunk@6719 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded the following 3 features to sample app.
djsollen@google.com [Fri, 7 Dec 2012 21:52:34 +0000 (21:52 +0000)]
Added the following 3 features to sample app.

1) Imported SKP files can now be run using the bbox playback ('b' key)
2) Imported SKP files are displayed using their basename
3) FPS counter has been updated to print time to draw all tiles

Review URL: https://codereview.appspot.com/6904057

git-svn-id: http://skia.googlecode.com/svn/trunk@6718 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate filter tool to write out paths to .cpp file
robertphillips@google.com [Fri, 7 Dec 2012 20:56:13 +0000 (20:56 +0000)]
Update filter tool to write out paths to .cpp file

https://codereview.appspot.com/6843125/

git-svn-id: http://skia.googlecode.com/svn/trunk@6714 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake debugger profiling honor deleted commands
robertphillips@google.com [Fri, 7 Dec 2012 20:48:56 +0000 (20:48 +0000)]
Make debugger profiling honor deleted commands

https://codereview.appspot.com/6906043/

git-svn-id: http://skia.googlecode.com/svn/trunk@6713 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImprove handling of inverse clip paths in GrClipMaskManager.
bsalomon@google.com [Fri, 7 Dec 2012 20:43:52 +0000 (20:43 +0000)]
Improve handling of inverse clip paths in GrClipMaskManager.

Will require rebaselining of complexclip_aa and complexclip_aa_layer on GPU.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6907052

git-svn-id: http://skia.googlecode.com/svn/trunk@6712 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix some extract subset bugs.
scroggo@google.com [Fri, 7 Dec 2012 19:14:45 +0000 (19:14 +0000)]
Fix some extract subset bugs.

In SkBitmap::extractSubset, perform a deepCopy, if the pixelRef supports it.

Fixes a bug in the 'extractbitmap' gm, which attempts to draw a subset of a texture backed bitmap (if the canvas is really an SkGpuCanvas).

Also fix some bugs that happen when there is a pixel offset. These fixes get bypassed by the deepCopy, but a user can still set a pixel offset manually.

When copying GPU backed bitmap with a pixel offset, copy the offset.

If the new config is the same as the old, copy fRowBytes as well.

Add a function to SkBitmap.cpp (getUpperLeftFromOffset) to find the x,y coordinate to use when copying to a new config.

Fix a bug where readPixels copied to the correct desired config and we were setting the generation ID to match even though the desired config was not the same as the original config (caught by my new tests!).

Add some tests to verify the correct behavior.

Review URL: https://codereview.appspot.com/6839043

git-svn-id: http://skia.googlecode.com/svn/trunk@6710 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoutils.gyp: add SkCityHash.h, delete SkConsistentChecksum.h
epoger@google.com [Fri, 7 Dec 2012 19:06:11 +0000 (19:06 +0000)]
utils.gyp: add SkCityHash.h, delete SkConsistentChecksum.h
Review URL: https://codereview.appspot.com/6906050

git-svn-id: http://skia.googlecode.com/svn/trunk@6709 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agospeedup peek32() when the offset is in the last block (fTail)
reed@google.com [Fri, 7 Dec 2012 17:48:04 +0000 (17:48 +0000)]
speedup peek32() when the offset is in the last block (fTail)
Review URL: https://codereview.appspot.com/6906047

git-svn-id: http://skia.googlecode.com/svn/trunk@6708 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline script: check for .git and .svn in the current directory as well. Add...
senorblanco@chromium.org [Fri, 7 Dec 2012 17:19:07 +0000 (17:19 +0000)]
Rebaseline script:  check for .git and .svn in the current directory as well.  Add mesa to list of configs to update.

R=bsalomon@google.com

Review URL: https://codereview.appspot.com/6908050

git-svn-id: http://skia.googlecode.com/svn/trunk@6707 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocache fontmetrics in picture-record
reed@google.com [Fri, 7 Dec 2012 17:14:40 +0000 (17:14 +0000)]
cache fontmetrics in picture-record
Review URL: https://codereview.appspot.com/6908049

git-svn-id: http://skia.googlecode.com/svn/trunk@6706 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd cityhash to SVN dependencies, not just DEPS file
epoger@google.com [Fri, 7 Dec 2012 16:30:31 +0000 (16:30 +0000)]
add cityhash to SVN dependencies, not just DEPS file

git-svn-id: http://skia.googlecode.com/svn/trunk@6705 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMark 64-bit constants as ULL to fix broken 32-bit Mac 10.6 build
epoger@google.com [Fri, 7 Dec 2012 15:54:01 +0000 (15:54 +0000)]
Mark 64-bit constants as ULL to fix broken 32-bit Mac 10.6 build
TBR=bungeman
Review URL: https://codereview.appspot.com/6867079

git-svn-id: http://skia.googlecode.com/svn/trunk@6704 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomark bitmaps as immutable as we deserialize them into picture-playback
reed@google.com [Fri, 7 Dec 2012 15:53:49 +0000 (15:53 +0000)]
mark bitmaps as immutable as we deserialize them into picture-playback
Review URL: https://codereview.appspot.com/6900045

git-svn-id: http://skia.googlecode.com/svn/trunk@6703 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocomment-only fix
epoger@google.com [Fri, 7 Dec 2012 15:27:27 +0000 (15:27 +0000)]
comment-only fix

git-svn-id: http://skia.googlecode.com/svn/trunk@6702 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace SkConsistentChecksum with SkCityHash (now including CityHash via DEPS)
epoger@google.com [Fri, 7 Dec 2012 15:12:01 +0000 (15:12 +0000)]
Replace SkConsistentChecksum with SkCityHash (now including CityHash via DEPS)

Alternative to https://codereview.appspot.com/6847087/ ('Change SkConsistentChecksum to use SuperFastHash')
Review URL: https://codereview.appspot.com/6867060

git-svn-id: http://skia.googlecode.com/svn/trunk@6701 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 7 Dec 2012 02:01:25 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6699 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDefining new color constat for transparent color
junov@google.com [Thu, 6 Dec 2012 21:47:40 +0000 (21:47 +0000)]
Defining new color constat for transparent color
Review URL: https://codereview.appspot.com/6901044

git-svn-id: http://skia.googlecode.com/svn/trunk@6696 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Thu, 6 Dec 2012 21:47:48 +0000 (21:47 +0000)]
shape ops work in progress

overhaul coincident handling

git-svn-id: http://skia.googlecode.com/svn/trunk@6695 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse ReduceClipStack in ClipMaskManager.
bsalomon@google.com [Thu, 6 Dec 2012 20:58:57 +0000 (20:58 +0000)]
Use ReduceClipStack in ClipMaskManager.

R=robertphillips@google.com

This will require some gpu rebaselining (complexclip_rect_aa, complexclip_aa, aaclip, simpleaaclip, complexclip_aa_layer)xy
Review URL: https://codereview.appspot.com/6884051

git-svn-id: http://skia.googlecode.com/svn/trunk@6694 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAs part of preliminary groundwork for a chromium fix, this changelist is deprecating...
sugoi@google.com [Thu, 6 Dec 2012 20:13:11 +0000 (20:13 +0000)]
As part of preliminary groundwork for a chromium fix, this changelist is deprecating GrPathFill so that SkPath::FillType is used everywhere in order to remove some code duplication between Skia and Ganesh.

BUG=chromium:135111
TEST=Try path rendering tests from the gm
Review URL: https://codereview.appspot.com/6875058

git-svn-id: http://skia.googlecode.com/svn/trunk@6693 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNo longer generating 4444, remove from rebaseline tool.
bungeman@google.com [Thu, 6 Dec 2012 19:16:36 +0000 (19:16 +0000)]
No longer generating 4444, remove from rebaseline tool.
https://codereview.appspot.com/6886048/

git-svn-id: http://skia.googlecode.com/svn/trunk@6692 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd query to pixelref for its encoded data (if it has any)
reed@google.com [Thu, 6 Dec 2012 14:26:02 +0000 (14:26 +0000)]
add query to pixelref for its encoded data (if it has any)
Review URL: https://codereview.appspot.com/6891047

git-svn-id: http://skia.googlecode.com/svn/trunk@6689 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake the clip reducer operate on int rects. Remove redundant Gr from func
bsalomon@google.com [Thu, 6 Dec 2012 14:23:20 +0000 (14:23 +0000)]
Make the clip reducer operate on int rects. Remove redundant Gr from func
name.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6890045

git-svn-id: http://skia.googlecode.com/svn/trunk@6688 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 6 Dec 2012 02:01:25 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6687 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove GrReducedClip to its own files.
bsalomon@google.com [Wed, 5 Dec 2012 22:26:11 +0000 (22:26 +0000)]
Move GrReducedClip to its own files.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6891045

git-svn-id: http://skia.googlecode.com/svn/trunk@6686 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agooptimize translate and scale
reed@google.com [Wed, 5 Dec 2012 22:13:59 +0000 (22:13 +0000)]
optimize translate and scale
add map2() to optimize for mapping an array of 2D points into homogeneous 4-vector
Review URL: https://codereview.appspot.com/6874064

git-svn-id: http://skia.googlecode.com/svn/trunk@6685 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd newline at end of tools/skdiff_html.h to happify the housekeeping bot
epoger@google.com [Wed, 5 Dec 2012 20:30:00 +0000 (20:30 +0000)]
Add newline at end of tools/skdiff_html.h to happify the housekeeping bot
TBR=bungeman
Review URL: https://codereview.appspot.com/6893043

git-svn-id: http://skia.googlecode.com/svn/trunk@6684 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd script to help rebaseline gm self-tests, and run it right now
epoger@google.com [Wed, 5 Dec 2012 20:21:35 +0000 (20:21 +0000)]
Add script to help rebaseline gm self-tests, and run it right now
BUG=https://code.google.com/p/skia/issues/detail?id=995
TBR=rmistry
Review URL: https://codereview.appspot.com/6887046

git-svn-id: http://skia.googlecode.com/svn/trunk@6683 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDelete no-longer-expected 4444 output images from gm self-test
epoger@google.com [Wed, 5 Dec 2012 20:13:26 +0000 (20:13 +0000)]
Delete no-longer-expected 4444 output images from gm self-test

git-svn-id: http://skia.googlecode.com/svn/trunk@6682 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate skdiff.
bungeman@google.com [Wed, 5 Dec 2012 20:13:12 +0000 (20:13 +0000)]
Update skdiff.
https://codereview.appspot.com/6850115/

git-svn-id: http://skia.googlecode.com/svn/trunk@6681 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDelete no-longer-used 4444 gm-selftest input images
epoger@google.com [Wed, 5 Dec 2012 20:11:43 +0000 (20:11 +0000)]
Delete no-longer-used 4444 gm-selftest input images

git-svn-id: http://skia.googlecode.com/svn/trunk@6680 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd display of a path's filltype to debugger
robertphillips@google.com [Wed, 5 Dec 2012 19:34:33 +0000 (19:34 +0000)]
Add display of a path's filltype to debugger

https://codereview.appspot.com/6887044/

git-svn-id: http://skia.googlecode.com/svn/trunk@6679 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd drawPoints dash bench
robertphillips@google.com [Wed, 5 Dec 2012 19:07:21 +0000 (19:07 +0000)]
Add drawPoints dash bench

https://codereview.appspot.com/6866053/

git-svn-id: http://skia.googlecode.com/svn/trunk@6678 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoClean up SkFontHost_mac_coretext.
bungeman@google.com [Wed, 5 Dec 2012 15:32:35 +0000 (15:32 +0000)]
Clean up SkFontHost_mac_coretext.
https://codereview.appspot.com/6843087/

git-svn-id: http://skia.googlecode.com/svn/trunk@6676 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThe goal is to make the ClangCompile buildstep in the Housekeeping bot turn red if...
rmistry@google.com [Wed, 5 Dec 2012 14:56:08 +0000 (14:56 +0000)]
The goal is to make the ClangCompile buildstep in the Housekeeping bot turn red if there is a warning.
Review URL: https://codereview.appspot.com/6868055

git-svn-id: http://skia.googlecode.com/svn/trunk@6674 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd operator delete to match operator new for SkTLList.
bsalomon@google.com [Wed, 5 Dec 2012 14:51:39 +0000 (14:51 +0000)]
Add operator delete to match operator new for SkTLList.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6871061

git-svn-id: http://skia.googlecode.com/svn/trunk@6673 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd missing SK_API definition at request of Chromium callers
djsollen@google.com [Wed, 5 Dec 2012 06:15:42 +0000 (06:15 +0000)]
Add missing SK_API definition at request of Chromium callers

Review URL: https://codereview.appspot.com/6878050

git-svn-id: http://skia.googlecode.com/svn/trunk@6671 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd test for adding outer contour first and second
reed@google.com [Wed, 5 Dec 2012 05:34:51 +0000 (05:34 +0000)]
add test for adding outer contour first and second

git-svn-id: http://skia.googlecode.com/svn/trunk@6670 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 5 Dec 2012 02:01:21 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6669 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd gm/pathinterior.cpp in advance of cary's path api
reed@google.com [Tue, 4 Dec 2012 22:52:28 +0000 (22:52 +0000)]
add gm/pathinterior.cpp in advance of cary's path api

git-svn-id: http://skia.googlecode.com/svn/trunk@6668 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExpand dashing3 GM to include additional dashing cases
robertphillips@google.com [Tue, 4 Dec 2012 20:34:11 +0000 (20:34 +0000)]
Expand dashing3 GM to include additional dashing cases

https://codereview.appspot.com/6870056/

git-svn-id: http://skia.googlecode.com/svn/trunk@6667 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GrReduceClipStack use a caller provided query rect rather than return a
bsalomon@google.com [Tue, 4 Dec 2012 15:22:12 +0000 (15:22 +0000)]
Make GrReduceClipStack use a caller provided query rect rather than return a
bounds.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6865059

git-svn-id: http://skia.googlecode.com/svn/trunk@6665 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoHandle recording a bitmap if copy fails.
scroggo@google.com [Tue, 4 Dec 2012 15:08:56 +0000 (15:08 +0000)]
Handle recording a bitmap if copy fails.

If SkBitmapHeap::insert() returns INVALID_SLOT, assert at picture
record time so we can debug, but allow it to continue in release
mode, so that we can still capture a picture. At playback time,
print a message so we know that there was an error.

Review URL: https://codereview.appspot.com/6873050

git-svn-id: http://skia.googlecode.com/svn/trunk@6664 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix stale iterators in LList test. Add newline to end of SkTLList.h
bsalomon@google.com [Tue, 4 Dec 2012 14:48:57 +0000 (14:48 +0000)]
Fix stale iterators in LList test. Add newline to end of SkTLList.h

git-svn-id: http://skia.googlecode.com/svn/trunk@6663 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPull SkMergeImageFilter out into its own file.
senorblanco@chromium.org [Tue, 4 Dec 2012 14:18:50 +0000 (14:18 +0000)]
Pull SkMergeImageFilter out into its own file.

Review URL: https://codereview.appspot.com/6873052

git-svn-id: http://skia.googlecode.com/svn/trunk@6662 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake SkClipStack::Iter use SkClipStack::Element.
bsalomon@google.com [Tue, 4 Dec 2012 14:06:06 +0000 (14:06 +0000)]
Make SkClipStack::Iter use SkClipStack::Element.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/6871051

git-svn-id: http://skia.googlecode.com/svn/trunk@6661 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 4 Dec 2012 02:01:25 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@6660 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix compiler error in SkTInternalList.h
robertphillips@google.com [Mon, 3 Dec 2012 23:34:32 +0000 (23:34 +0000)]
Fix compiler error in SkTInternalList.h

git-svn-id: http://skia.googlecode.com/svn/trunk@6659 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoProvide default guess at font type in Mac CoreText font host, since CT's detection...
bungeman@google.com [Mon, 3 Dec 2012 22:52:30 +0000 (22:52 +0000)]
Provide default guess at font type in Mac CoreText font host, since CT's detection is unreliable.

git-svn-id: http://skia.googlecode.com/svn/trunk@6658 2bbb7eff-a529-9590-31e7-b0007b416f81