Jim Meyering [Mon, 29 Oct 2007 09:01:25 +0000 (10:01 +0100)]
Remove spurious semicolon after "else".
* build-aux/check.mk (am__tty_colors): Fix syntax error.
Jim Meyering [Mon, 29 Oct 2007 08:49:50 +0000 (09:49 +0100)]
Attribute suggestion for last change.
Jim Meyering [Mon, 29 Oct 2007 08:47:52 +0000 (09:47 +0100)]
If $TERM is empty, don't use colors. This helps the buildbot,
since it produces its result in an environment with a tty, but
we don't want color codes in that case.
* build-aux/check.mk (am__tty_colors): Test for nonempty $TERM.
Jim Meyering [Mon, 29 Oct 2007 07:41:08 +0000 (08:41 +0100)]
Always initialize terminal colorization string variables.
* build-aux/check.mk (am__tty_colors): Always initialize red, grn, etc.,
In case they're defined in the environment.
Jim Meyering [Mon, 29 Oct 2007 06:47:21 +0000 (07:47 +0100)]
Avoid test failure in non-srcdir build vs. the git tree.
* tests/check.mk (vc_exe_in_TESTS): Run this test only in a
srcdir build directory. Reported by Andreas Schwab.
Jim Meyering [Sun, 28 Oct 2007 18:04:59 +0000 (19:04 +0100)]
Define ENOTSUP, not ENOSYS. Needed on OpenBSD 3.9.
* gl/lib/se-context.in.h (ENOTSUP): Define if missing.
* gl/lib/se-selinux.in.h: Likewise.
Jim Meyering [Sun, 28 Oct 2007 17:16:54 +0000 (18:16 +0100)]
Define ENODATA, for FreeBSD 5.0 and 6.1.
* src/system.h (ENODATA): Define, if missing.
Jim Meyering [Sun, 28 Oct 2007 14:53:59 +0000 (15:53 +0100)]
Run autoreconf, not just autoconf, to avoid warnings.
* GNUmakefile (dummy): Otherwise, we'd sometimes get a warning
about autoconf version mismatch between what was used to generate
aclocal.m4 and the currently-running autoconf.
Jim Meyering [Sun, 28 Oct 2007 14:38:17 +0000 (15:38 +0100)]
Require gnulib's printf-posix module, to support Interix.
* bootstrap.conf (gnulib_modules): Add printf-posix.
Jim Meyering [Sun, 28 Oct 2007 14:37:56 +0000 (15:37 +0100)]
Help xgettext recognize more printf-style format strings.
* bootstrap.conf (XGETTEXT_OPTIONS): Add directives for
error, error_at_line, xasprintf, xfprintf and xprintf.
Jim Meyering [Sat, 27 Oct 2007 07:42:27 +0000 (09:42 +0200)]
Adjust format string so msgfmt doesn't object.
* src/df.c (main): Use "%s%s" (not %smsg) to print "msg" with or
without a "Warning: " prefix. Reported by Clytie Siddall.
Jim Meyering [Sat, 27 Oct 2007 07:06:11 +0000 (09:06 +0200)]
Clean up tests/Makefile.am.
* tests/Makefile.am (EXTRA_DIST): Remove $(TESTS). No longer defined.
(TESTS_ENVIRONMENT): Remove definition.
Jim Meyering [Sat, 27 Oct 2007 07:04:47 +0000 (09:04 +0200)]
* build-aux/check.mk: Merge with latest from Akim.
Jim Meyering [Fri, 26 Oct 2007 21:59:43 +0000 (23:59 +0200)]
Add a test for the printf fix of 2007-10-21.
* tests/misc/printf-surprise: New file. Test for 2007-10-21's fix.
* tests/misc/Makefile.am (TESTS): Add printf-surprise.
Jim Meyering [Thu, 25 Oct 2007 07:20:44 +0000 (09:20 +0200)]
Add attribution for the expr.c-vs-xgettext report.
Jim Meyering [Thu, 25 Oct 2007 07:06:29 +0000 (09:06 +0200)]
Remove vestiges of cvs-gnulib-checkout process. Now we use git.
* bootstrap: Remove support for now-unnecessary option, --cvs-user,
and envvars CVS_USER, CVS_RSH.
2007-10-24 Micah Cowan <micah@cowan.name>
Micah Cowan [Thu, 25 Oct 2007 06:59:30 +0000 (08:59 +0200)]
Tell xgettext that "ARG1 % ARG2" is not a C format string.
* src/expr.c (usage): Add a comment to override xgettext's default
behavior, which would classify "ARG1 % ARG2" as a fprintf-style
format string.
Jim Meyering [Wed, 24 Oct 2007 20:31:35 +0000 (22:31 +0200)]
Avoid diagnostics from sha1sum when there is no cached checksum.
* bootstrap (update_po_files): Skip the sha1sum check if the po.s1
file hasn't been created yet.
Jim Meyering [Wed, 24 Oct 2007 20:09:57 +0000 (22:09 +0200)]
Get gnulib from the git repository, not from an obsolete cvs one.
* bootstrap: Suggestion from Micah Cowan.
Jim Meyering [Wed, 24 Oct 2007 07:13:59 +0000 (09:13 +0200)]
Doc improvements.
* README-hacking: Prefer the no-hyphen variant of git commands,
e.g., use "git pull" not "git-pull".
Don't presume that the only way to read this document is via a
prior git clone: provide instructions for cloning coreutils, too.
* README-hacking: Add "cd automake" in build instructions.
From Bob Proulx.
Jim Meyering [Wed, 24 Oct 2007 06:50:09 +0000 (08:50 +0200)]
Don't fail part 2 of tests/rm/unreadable when run as root.
* tests/rm/unreadable: With UID == 0, expect different results.
Reported by Mike Frysinger.
Jim Meyering [Tue, 23 Oct 2007 13:44:58 +0000 (15:44 +0200)]
* README-hacking: Refer to LZMA Utils <tukaani.org/lzma/>.
Paul Eggert [Mon, 22 Oct 2007 21:29:40 +0000 (23:29 +0200)]
* README-hacking: Describe how to build with LZMA.
Jim Meyering [Mon, 22 Oct 2007 19:43:12 +0000 (21:43 +0200)]
Remove git-version-gen's first parameter.
* build-aux/git-version-gen: Add comments.
Remove first command-line parameter.
* configure.ac: Remove corresponding first argument.
* GNUmakefile (_curr-ver): Likewise.
Jim Meyering [Sun, 21 Oct 2007 16:19:54 +0000 (18:19 +0200)]
Attribute the printf bug report.
Jim Meyering [Sun, 21 Oct 2007 16:17:30 +0000 (18:17 +0200)]
* NEWS: Mention the printf fix.
Jim Meyering [Sun, 21 Oct 2007 10:44:32 +0000 (12:44 +0200)]
Reorder tests to run more basic ones earlier.
* tests/misc/Makefile.am (TESTS): Reorder.
* tests/Makefile.am (SUBDIRS): Reorder.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Jim Meyering [Sun, 21 Oct 2007 10:38:33 +0000 (12:38 +0200)]
tr: do not reject an unmatched [:lower:] or [:upper:] in SET1.
* NEWS: Mention this.
* src/tr.c (get_next) [RE_CHAR_CLASS]: Don't skip the loop when
processing [:lower:] and [:upper:].
(main): Require [:lower:] or [:upper:] in SET1 only when
when one of those is specified in SET2.
* tests/tr/Test.pm: Add tests for this fix.
Reported by Per Starbäck.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Jim Meyering [Sat, 20 Oct 2007 19:50:43 +0000 (21:50 +0200)]
* tests/misc/help-version: Add a comment.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Jim Meyering [Sat, 20 Oct 2007 12:48:29 +0000 (14:48 +0200)]
Detect printf(3) failure due to ENOMEM.
* src/printf.c: Include "xprintf.h"
(print_direc): Use xprintf, rather than printf.
* bootstrap.conf (gnulib_modules): Add xprintf.
* po/POTFILES.in: Add lib/xprintf.c.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Jim Meyering [Sat, 20 Oct 2007 12:41:50 +0000 (14:41 +0200)]
Put always-failing programs first in PATH, so tests cannot mistakenly run installed versions.
* Makefile.maint (my-distcheck): Set up a bogus bin/ dir, to be used
for "make check".
Signed-off-by: Jim Meyering <meyering@redhat.com>
Jim Meyering [Sat, 20 Oct 2007 11:53:45 +0000 (13:53 +0200)]
* doc/coreutils.texi: Add a cross-reference to bashref's Process Substitution node.
Jim Meyering [Sat, 20 Oct 2007 10:00:54 +0000 (12:00 +0200)]
* doc/coreutils.texi (tee invocation): Fix typo. Add a little.
Jim Meyering [Sat, 20 Oct 2007 08:07:12 +0000 (10:07 +0200)]
Adjust tests to pass, now that Test.pm ones use check.mk.
* tests/check.mk (vc_exe_in_TESTS): Adjust regexp not to match the
"TESTS = $x-tests" line in each Test.pm-derived Makefile.am file.
* tests/sort/main: Remove this unused file.
Jim Meyering [Sat, 20 Oct 2007 07:06:39 +0000 (09:06 +0200)]
Ensure that Test.pm-derived tests use the right $PATH.
* tests/Makefile.am.in: Include $(top_srcdir)/tests/check.mk.
Bob Proulx [Sat, 20 Oct 2007 06:26:57 +0000 (08:26 +0200)]
Prevent "make check" from leaving mktemp /tmp/tmp.* files behind.
* tests/misc/help-version (mktemp_args): Tell mktemp to create
its temporary file in the current directory.
Jim Meyering [Tue, 9 Oct 2007 10:24:14 +0000 (12:24 +0200)]
Show how to make tee redirect to multiple processes.
Jim Meyering [Sun, 14 Oct 2007 19:47:08 +0000 (21:47 +0200)]
Pull all TESTS_ENVIRONMENT settings "up" into tests/check.mk.
* tests/Makefile.am.in (TESTS_ENVIRONMENT): Remove definition.
* tests/chgrp/Makefile.am: Likewise.
* tests/chmod/Makefile.am: Likewise.
* tests/chown/Makefile.am: Likewise.
* tests/cp/Makefile.am: Likewise.
* tests/dd/Makefile.am: Likewise.
* tests/du/Makefile.am: Likewise.
* tests/install/Makefile.am: Likewise.
* tests/ln/Makefile.am: Likewise.
* tests/ls/Makefile.am: Likewise.
* tests/misc/Makefile.am: Likewise.
* tests/mkdir/Makefile.am: Likewise.
* tests/mv/Makefile.am: Likewise.
* tests/readlink/Makefile.am: Likewise.
* tests/rm/Makefile.am: Likewise.
* tests/rmdir/Makefile.am: Likewise.
* tests/tail-2/Makefile.am: Likewise.
* tests/touch/Makefile.am: Likewise.
* tests/check.mk (TESTS_ENVIRONMENT) [EXEEXT, EGREP, MAKE, PERL]:
[CONFIG_HEADER, build_programs, host_os, host_triplet, PATH]:
[REPLACE_GETCWD, CU_TEST_NAME]: Add definitions here.
* tests/misc/pwd-long: Use $abs_top_builddir/src, not $BUILD_SRC_DIR.
* tests/dd/skip-seek: Don't use $ENV{PROG}.
* tests/rm/empty-name: Likewise.
* tests/rm/unreadable: Likewise.
* tests/mv/i-1: Likewise.
Jim Meyering [Sun, 14 Oct 2007 11:35:34 +0000 (13:35 +0200)]
Fix a minor typo.
* configure.ac (AC_INIT): Fix a typo (s/9.6/6.9/) that makes a
difference only when running "make dist" without a .git/ subdir.
Jim Meyering [Tue, 9 Oct 2007 15:12:45 +0000 (17:12 +0200)]
Move the help-version test into misc/.
* tests/help-version: Move to...
* tests/misc/help-version: ...here.
Source test-lib.sh, as usual.
Use $abs_top_builddir, rather than ".." and "../..".
Jim Meyering [Tue, 9 Oct 2007 13:48:51 +0000 (15:48 +0200)]
Make the runcon-no-reorder test slightly more general.
* tests/misc/runcon-no-reorder: Don't hard-code "unconstrained_t".
Use slightly more general "runcon $(id -Z)".
Suggestion from Stephen Smalley.
Jim Meyering [Tue, 9 Oct 2007 07:58:27 +0000 (09:58 +0200)]
Skip the chcon test on a system with no SELinux support.
* tests/test-lib.sh (require_selinux_): New function.
* tests/misc/chcon: Use it.
* tests/misc/selinux: Use it here, too.
* tests/cp/cp-a-selinux: and here.
* tests/selinux: Remove file.
* tests/Makefile.am (EXTRA_DIST): Remove selinux.
Reported by Mike Frysinger and Bauke Jan Douma.
Jim Meyering [Tue, 9 Oct 2007 07:39:13 +0000 (09:39 +0200)]
* src/dircolors.hin: Recognize .lzma as a compressed-file suffix.
Jim Meyering [Tue, 9 Oct 2007 07:37:43 +0000 (09:37 +0200)]
* configure.ac (AM_INIT_AUTOMAKE): Use dist-lzma, rather than dist-bzip2.
Jim Meyering [Tue, 9 Oct 2007 07:33:48 +0000 (09:33 +0200)]
Now that we don't install su, don't make misleading suggestions.
* src/Makefile.am (install-exec-local) [$(INSTALL_SU) != yes]:
Don't suggest running "make install-root".
(uninstall-local) [$(INSTALL_SU) != yes]: Don't even check
the installed binary.
Jim Meyering [Mon, 8 Oct 2007 08:34:04 +0000 (10:34 +0200)]
When forming a truncated name, use the "[...]" prefix even for
an extremely long name in the current directory.
* src/remove.c (full_filename_): Rename a local variable.
Use two separate "truncated" variables, in case the second
call to right_justify does not indicate any truncation -- which
would happen only if the single component FILENAME were longer
than 511 bytes and DIR_NAME were empty.
Jim Meyering [Sun, 7 Oct 2007 20:58:29 +0000 (22:58 +0200)]
rm could malfunction under unusual circumstances:
When operating on a relative name longer than 511 bytes,
and (when either processing a directory that is neither writable
nor readable (but still searchable) or when determining whether
to prompt), and encountering an ENOMEM error while forming the
file name, rm would operate on a truncated-to-511-byte name
starting with "[...]" rather than the intended one.
* NEWS: Describe the bugs.
* src/remove.c: Correct two misuses of full_filename:
(full_filename0, xfull_filename): New functions.
(full_filename_): Rewrite to use full_filename0.
(AD_pop_and_chdir): Use xfull_filename, not full_filename.
(write_protected_non_symlink): Likewise.
Jim Meyering [Sun, 7 Oct 2007 19:55:42 +0000 (21:55 +0200)]
Don't let a helper function modify errno.
* src/remove.c (full_filename_): Save and restore errno.
Spotted by Bruno Haible.
Jim Meyering [Sun, 7 Oct 2007 19:04:14 +0000 (21:04 +0200)]
Reflect 2->3 GPL copyright version update in gnulib.
* gl/lib/tempname.h: Update copyright from gnulib.
* gl/lib/tempname.c: Likewise.
* .x-sc_GPL_version: Don't make an exception for those two files.
Jim Meyering [Sun, 7 Oct 2007 18:33:57 +0000 (20:33 +0200)]
* configure.ac (AM_INIT_AUTOMAKE): Don't use dist-lzma just yet.
Jim Meyering [Sat, 2 Jun 2007 21:04:10 +0000 (23:04 +0200)]
New program: mktemp.
* NEWS: Mention this.
* README: Add mktemp to the list.
* AUTHORS: Add this: mktemp: Jim Meyering
* src/mktemp.c: New file.
* src/Makefile.am (bin_PROGRAMS): Add mktemp.
(mktemp_LDADD): Add $(LIB_GETHRXTIME).
* man/mktemp.x: New file.
* man/Makefile.am (dist_man_MANS): Add mktemp.1.
(mktemp.1): New dependency.
* man/.cvsignore: Add mktemp.1.
* man/.gitignore: New file.
* src/.cvsignore, src/.gitignore: Add mktemp.
* tests/misc/mktemp: New file.
* tests/misc/Makefile.am (TESTS): Add mktemp.
* tests/Coreutils.pm (run_tests): Give the POST-test function
access to stdout and stderr contents, so it can verify that
the named-on-stdout file/dir does indeed exist and has proper
permissions, etc.
[po/ChangeLog]
* POTFILES.in: Add src/mktemp.c.
Jim Meyering [Sat, 1 Sep 2007 08:33:33 +0000 (10:33 +0200)]
Make tempname more random, via the randint module.
* gl/modules/tempname (Depends-on): Add randint and stdbool.
* gl/lib/tempname.c: Include randint.h and stdbool.h.
(uint64_t): Remove definition. Not needed.
[_LIBC] (RANDOM_BITS): Remove this block, now that we have proper random bits.
(check_x_suffix): New function.
(gen_tempname_len): Rename from __gen_tempname.
Add a parameter, x_suffix_len, telling how many X's there must be at
the end of the template.
Use pseudo-random numbers all the way, rather than adding 7777
from one iteration to the next.
(__gen_tempname): New function, to call gen_tempname_len, requiring a
suffix length of 6.
* gl/lib/tempname.h: Add prototype for gen_tempname_len.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Jim Meyering [Sat, 1 Sep 2007 07:54:45 +0000 (09:54 +0200)]
Convert coreutils' rand*.{c,h,m4} into modules.
First step: move these files to gl/lib:
* lib/rand-isaac.c, lib/rand-isaac.h
* lib/randint.c, lib/randint.h
* lib/randperm.c, lib/randperm.h
* lib/randread.c, lib/randread.h
Step 2: add modules/rand* and remove now-unneeded .m4 files.
* gl/modules/randint: New file.
* gl/modules/randperm: New file.
* gl/modules/randread: New file.
* m4/randint.m4: Remove file.
* m4/randperm.m4: Remove file.
* m4/randread.m4: Remove file.
Step 3: use the new modules
* bootstrap.conf (gnulib_modules): Add randint and randperm.
* m4/prereq.m4 (gl_RANDINT, gl_RANDREAD, gl_RANDPERM): Don't require;
These have been removed.
(gl_ROOT_DEV_INO): Don't require; already handled via bootstrap.conf.
Jim Meyering [Sat, 1 Sep 2007 09:33:00 +0000 (11:33 +0200)]
Copy from gnulib the parts of tempname that we'll modify.
* gl/lib/tempname.c: Copy from gnulib.
* gl/lib/tempname.h: Likewise.
* gl/modules/tempname: Likewise.
Allow GPLv2 on temporarily(?)-imported file from gnulib/libc.
* .x-sc_GPL_version: New file.
* Makefile.am (EXTRA_DIST): Add .x-sc_GPL_version
Jim Meyering [Sun, 7 Oct 2007 16:41:33 +0000 (18:41 +0200)]
Avoid a pseudo-leak in sort.
* src/sort.c (main) [lint]: Avoid a nominal leak.
Jim Meyering [Sun, 7 Oct 2007 16:16:00 +0000 (18:16 +0200)]
Use puts, rather than printf ("%s\n". Slightly cleaner.
* src/tsort.c (tsort): ...and more efficient.
Jim Meyering [Sun, 7 Oct 2007 14:15:49 +0000 (16:15 +0200)]
Avoid seq malfunction on non-POSIX systems: mingw, BeOS, Interix.
* bootstrap.conf (gnulib_modules): Add vasprintf-posix.
Suggestion from Bruno Haible.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Jim Meyering [Sun, 7 Oct 2007 14:06:59 +0000 (16:06 +0200)]
Avoid a used-uninitialized error.
* src/copy.c (copy_internal): Don't overload "use_stat".
Jim Meyering [Fri, 5 Oct 2007 08:55:26 +0000 (10:55 +0200)]
Make a failing cross-partition mv give a sensible diagnostic.
A cross-partition move of a file in a sticky tmpdir and owned by
another user would evoke an invalid diagnostic after copying it:
mv: cannot remove `x': Operation not permitted
Either of the following (mv.c, remove.c) changes would fix the bug by
itself. I think it's slightly better to use both; the added cost is
minimal: mv: an extra lstat-per-mv-cmdline-arg-that-goes-cross-partition,
rm: an extra lstat-per-unlink-that-fails-w/EPERM.
* src/remove.c (remove_entry): Also lstat the file upon EPERM.
* src/mv.c (rm_option_init): Initialize root_dev_ino just as is done
in rm, so that a cross-partition invoked remove.c:rm call works the
same way as one invoked from the command-line use of "rm". That
setting of root_dev_ino makes rm() do the equivalent of an additional
lstat for each argument, which in turn gives rm enough information to
issue the right diagnostic.
* tests/mv/sticky-to-xpart (version): New file. Test for the above.
* tests/mv/Makefile.am (TESTS): Add sticky-to-xpart.
Arrange for "make check-root" to run the new root-only test.
* tests/Makefile.am (tb): New target, to run the new root-only test.
(all_t): Add tb.
* src/c99-to-c89.diff: Adjust offsets.
Jim Meyering [Fri, 5 Oct 2007 10:14:16 +0000 (12:14 +0200)]
Add PACKAGE_VERSION to TESTS_ENVIRONMENT via check.mk.
* tests/check.mk (TESTS_ENVIRONMENT): Add PACKAGE_VERSION here,
rather than in every Makefile.am that needs it.
* tests/rm/Makefile.am (TESTS_ENVIRONMENT): Remove PACKAGE_VERSION.
* tests/misc/Makefile.am (TESTS_ENVIRONMENT): Likewise.
Jim Meyering [Fri, 5 Oct 2007 06:58:22 +0000 (08:58 +0200)]
List two systems on which chroot works when run by non-root.
Jim Meyering [Thu, 4 Oct 2007 10:26:38 +0000 (12:26 +0200)]
Adapt to new gnulib naming scheme.
* gl/lib/se-context.in.h: Rename from gl/lib/se-context_.h.
* gl/lib/se-selinux.in.h: Rename from gl/lib/se-selinux_.h.
* gl/m4/selinux-context-h.m4: Remove use of AC_LIBSOURCES.
* gl/m4/selinux-selinux-h.m4: Likewise.
* gl/modules/selinux-h (Files, Makefile.am): Reflect renaming.
(Makefile.am) [lib_SOURCES]: Add se-context.in.h and se-selinux.in.h.
Jim Meyering [Thu, 4 Oct 2007 10:20:27 +0000 (12:20 +0200)]
lib/search_.h: Remove unused file.
Jim Meyering [Thu, 4 Oct 2007 09:55:31 +0000 (11:55 +0200)]
* bootstrap (update_po_files): Work also when there are no .po files in po/.
Jim Meyering [Thu, 4 Oct 2007 09:41:48 +0000 (11:41 +0200)]
* bootstrap (slurp): Adapt to _.h -> .in.h name change.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Jim Meyering [Thu, 4 Oct 2007 08:26:05 +0000 (10:26 +0200)]
Remove test program: lib/t-fpending.c.
* lib/t-fpending.c: Remove file. Now, this test is in gnulib.
* lib/Makefile.am: Remove associated rules.
* .gitignore: Remove lib/t-fpending.
Jim Meyering [Wed, 3 Oct 2007 10:56:32 +0000 (12:56 +0200)]
* tests/misc/selinux: Skip this test if the initial chcon fails.
Jim Meyering [Tue, 2 Oct 2007 09:10:22 +0000 (11:10 +0200)]
Never copy through a symlink that cp has just created.
* src/copy.c (copy_internal): When same-file detection requires
'stat'ing the destination file, also 'lstat' it and ensure that
it wasn't the destination of a preceding copy operation.
This bug was introduced on 2007-06-18.
* tests/cp/abuse: New test for the above.
* tests/cp/Makefile.am (TESTS): Add abuse.
Jim Meyering [Sun, 30 Sep 2007 07:05:10 +0000 (09:05 +0200)]
cp: do not abbreviate in --help output.
* src/cp.c (usage): Don't abbreviate: s/=link/=links/.
Reported by Géraud Meyer in <http://bugs.debian.org/444137>.
Signed-off-by: Jim Meyering <jim@meyering.net>
Eric Blake [Sat, 29 Sep 2007 14:56:50 +0000 (08:56 -0600)]
Fix testsuite on cygwin.
* check.mk (%.log): Also allow suffix-less tests, on platforms
where $(EXEEXT) is not empty.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Sat, 29 Sep 2007 14:49:20 +0000 (08:49 -0600)]
Test previous patch.
* tests/misc/groups-dash: New test.
* tests/misc/Makefile.am (TESTS): Add it.
Signed-off-by: Eric Blake <ebb9@byu.net>
Eric Blake [Fri, 28 Sep 2007 23:09:30 +0000 (23:09 +0000)]
* src/groups.sh: Don't ignore first argument if later argument is --.
Signed-off-by: Eric Blake <ebb9@byu.net>
Jim Meyering [Thu, 27 Sep 2007 20:37:23 +0000 (22:37 +0200)]
Avoid spurious test failure when SELinux stats "selinux/class".
* tests/ls/stat-free-symlinks: Grep for more precise /^stat("x"/.
Jim Meyering [Tue, 25 Sep 2007 20:24:21 +0000 (22:24 +0200)]
Move file-set and hash-triple modules to gnulib.
* bootstrap.conf (gnulib_modules): Remove file-set, now that
it's in gnulib, and the canonicalize module requires it there.
* gl/lib/file-set.c, gl/lib/file-set.h, gl/modules/hash-triple: Remove.
* gl/lib/hash-triple.c, gl/lib/hash-triple.h, gl/modules/file-set: Remove.
Jim Meyering [Mon, 24 Sep 2007 07:53:57 +0000 (09:53 +0200)]
Add a test to exercise a readlink bug.
* tests/misc/readlink-fp-loop: New file. Test for the readlink bug
fixed through today's change to Gnulib's canonicalize module.
* tests/misc/Makefile.am (TESTS): Add readlink-fp-loop.
Bug report and a test case from mpb.mail@gmail.com.
Pádraig Brady [Tue, 25 Sep 2007 17:00:04 +0000 (18:00 +0100)]
Make "Date input formats" easier to find in info file
* doc/coreutils.texi (date invocation):
`man date` gives all options for the date command except
the description of the date input formats. Therefore it
should be easy to browse to this info using `info date`.
Signed-off-by: Pádraig Brady <P@draigBrady.com>
Jim Meyering [Tue, 25 Sep 2007 19:27:14 +0000 (21:27 +0200)]
Use XOR, not OR to combine bits.
* gl/lib/hash-triple.c (triple_hash): Use XOR (^), not OR (|), to
combine the bits from hashing the name and those of the inode number.
Add a few comments and remove out-of-context ones.
Jim Meyering [Mon, 24 Sep 2007 14:33:35 +0000 (16:33 +0200)]
* NEWS: The recent rm-diagnostic fix also affects cross-partition "mv".
Jim Meyering [Mon, 24 Sep 2007 13:09:17 +0000 (15:09 +0200)]
copy.c: Remove definitions of factored-out functions.
* src/copy.c: Include "file-set.h".
(seen_file, record_file): Remove functions that I factored
out on 2007-08-23.
Jim Meyering [Sat, 22 Sep 2007 21:26:37 +0000 (23:26 +0200)]
Don't print the commands of a 10-line script that's run in each subdir.
* tests/check.mk (vc_exe_in_TESTS): Add a leading "@", to reduce noise.
Jim Meyering [Sat, 22 Sep 2007 08:02:09 +0000 (10:02 +0200)]
rm: give a sensible diagnostic when failing to remove a symlink
On some systems (those with openat et al), when rm would fail to
remove a symlink, it would fail with the misleading diagnostic,
"Too many levels of symbolic links".
* NEWS: Mention the bug fix.
* src/remove.c (is_nondir_lstat): New function.
(remove_entry): Use it to catch failed-to-remove symlink (and any
other non-dir) here so that we don't fall through and try to treat
it as directory, which -- with a symlink -- would provoke the bogus
ELOOP failure.
* tests/rm/fail-eacces: Add a test for the above.
* src/c99-to-c89.diff: Adjust offsets.
Jim Meyering [Sat, 22 Sep 2007 06:40:47 +0000 (08:40 +0200)]
rm: fix a tiny, nearly inconsequential bug.
Don't perform a "."-relative lstat, when the file in question
may well not be in ".". Although this is a bug, a few attempts
to exercise it on a linux-2.6.22 system failed. You probably need
a pre-openat system to trigger the failure. The consequence of this
bug would be a lower-quality diagnostic upon failed dir removal.
* src/remove.c (is_dir_lstat): Add a parameter, fd_cwd.
Use it instead of hard-coding AT_FDCWD.
(remove_entry): Call is_dir_lstat with fd_cwd.
Signed-off-by: Jim Meyering <jim@meyering.net>
Karl Berry [Sat, 22 Sep 2007 06:28:21 +0000 (08:28 +0200)]
TODO: It'd be nice to add renice.
Signed-off-by: Jim Meyering <jim@meyering.net>
Jim Meyering [Fri, 21 Sep 2007 06:30:26 +0000 (08:30 +0200)]
Avoid a test failure due to now-parallelized tests.
* tests/du/two-args: Run "du .." from a sub-directory one level deeper.
Jim Meyering [Wed, 19 Sep 2007 09:13:46 +0000 (11:13 +0200)]
Fix typo in previous change.
Spotted by Andreas Schwab.
Jim Meyering [Wed, 19 Sep 2007 08:25:40 +0000 (10:25 +0200)]
* coreutils.texi (expr invocation): Correct description of relative
operator precedence. Reported by hanpingtian@gmail.com.
Jim Meyering [Sun, 16 Sep 2007 09:26:24 +0000 (11:26 +0200)]
tests/misc/tac-continue: Arrange to remove a temporary file.
Signed-off-by: Jim Meyering <jim@meyering.net>
Jim Meyering [Sun, 16 Sep 2007 09:20:55 +0000 (11:20 +0200)]
tests/check.mk (vc_exe_in_TESTS): Don't rely on the value of $(TESTS),
so that "make check TESTS=test-name" works once again.
Signed-off-by: Jim Meyering <jim@meyering.net>
Jim Meyering [Sun, 16 Sep 2007 09:07:59 +0000 (11:07 +0200)]
tests/CuTmpdir.pm: Use File::Find + chmod syscall, not chmod -R.
Signed-off-by: Jim Meyering <jim@meyering.net>
Jim Meyering [Sat, 15 Sep 2007 23:24:37 +0000 (01:24 +0200)]
Revamp most test scripts.
Add a ChangeLog entry summarizing the preceding 30+ change sets.
Jim Meyering [Sat, 15 Sep 2007 23:06:16 +0000 (01:06 +0200)]
* tests/rm/v-slash: Avoid test failure with non-C locale.
Reported by Michael Stone.
Jim Meyering [Thu, 13 Sep 2007 10:13:35 +0000 (12:13 +0200)]
Enable some previously omitted test scripts. Add a test cross-check.
* tests/rm/Makefile.am (TESTS): Add empty-name and unreadable.
* tests/rm/empty-name: Likewise.
* tests/rm/unreadable: Reenable this test. Adjust for new rm.
* tests/mkdir/Makefile.am: Add writable-under-readonly.
* tests/mkdir/writable-under-readonly: Add some comments.
This test is always skipped, for now.
* tests/Makefile.am (ta): Hook up the new root-only script.
* tests/tail-2/infloop-1: Make this test pass.
* tests/tail-2/Makefile.am (TESTS): Add infloop-1.
* tests/tail-2/fflush: Remove unused file.
* tests/check.mk (vc_executable_is_in_TESTS): More portable.
* tests/check.mk (check): Depend on the above.
* build-aux/check.mk: Remove comment mentioning AUTHORS file.
Jim Meyering [Thu, 13 Sep 2007 08:04:35 +0000 (10:04 +0200)]
Factor out definitions in TESTS_ENVIRONMENT of srcdir, top_srcdir, etc.
tests/check.mk (top_srcdir): Define.
tests/*/Makefile.am: Remove definitions of $(srcdir), $(top_srcdir),
$(abs_top_srcdir), and $(abs_top_builddir), since they're
defined via the included tests/check.mk.
Jim Meyering [Thu, 13 Sep 2007 07:22:39 +0000 (09:22 +0200)]
tests/general: Remove from VC, this long-unused directory and contents.
Jim Meyering [Thu, 13 Sep 2007 06:44:26 +0000 (08:44 +0200)]
Adapt tests/tail-2/ to use test-lib.sh.
Jim Meyering [Wed, 12 Sep 2007 16:14:36 +0000 (18:14 +0200)]
Adapt tests/readlink/ to use test-lib.sh.
Jim Meyering [Wed, 12 Sep 2007 13:55:54 +0000 (15:55 +0200)]
Move the sole test in tests/ls-2/ to tests/misc/.
* tests/ls-2/basic-1: Move this file to ...
* tests/misc/ls-misc: ...here. Don't rely on $PROG in env.
* tests/misc/Makefile.am (TESTS): Add ls-misc.
* tests/Makefile.am (SUBDIRS): Remove ls-2.
* tests/ls-2: Remove the directory.
* configure.ac (AC_CONFIG_FILES): Remove tests/ls-2/Makefile.
Jim Meyering [Wed, 12 Sep 2007 12:52:26 +0000 (14:52 +0200)]
More misc, test-related changes. (some to allow running tests as root)
Jim Meyering [Tue, 11 Sep 2007 21:30:49 +0000 (23:30 +0200)]
Move all tests from test/{od,sha1sum,shred,stty} to tests/misc/.
Reflect these renamings:
od/od-N misc/od-N
od/x8 misc/od-x8
sha1sum/basic-1 misc/sha1sum
sha1sum/sample-vec misc/sha1sum-vec
shred/exact misc/shred-exact
shred/remove misc/shred-remove
stty/basic-1 misc/stty
stty/invalid misc/stty-invalid
stty/row-col-1 misc/stty-row-col
* tests/misc/Makefile.am (TESTS): Add the new files.
* tests/Makefile.am (SUBDIRS): Remove the dir names.
* tests/od, tests/sha1sum, tests/shred, tests/stty: Remove the directories.
* configure.ac (AC_CONFIG_FILES): Remove the corresponding Makefile names.
Jim Meyering [Tue, 11 Sep 2007 21:30:09 +0000 (23:30 +0200)]
Move the two tests in tests/tee to tests/misc/.
* tests/tee/basic: Move this file to ...
* tests/misc/tee: ...here. Don't rely on $PROG in env.
* tests/tee/dash: Move this file to ...
* tests/misc/tee-dash: ...here. Don't rely on $PROG in env.
* tests/misc/Makefile.am (TESTS): Add tee.
* tests/Makefile.am (SUBDIRS): Remove tee.
* tests/tee: Remove the directory.
* configure.ac (AC_CONFIG_FILES): Remove tests/tee/Makefile