commit-bot@chromium.org [Fri, 28 Mar 2014 17:55:51 +0000 (17:55 +0000)]
Adds bench expectations to expectations/bench; fixes bench alert test's dependency on script line number.
BUG=skia:2307
NOTRY=true
R=borenet@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
214913005
git-svn-id: http://skia.googlecode.com/svn/trunk@13979
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 28 Mar 2014 17:11:13 +0000 (17:11 +0000)]
New Win7 baselines for resize image filters.
New Win7 baselines for imageresizetiled, imagefiltersclipped,
imagefiltersscaled GM. Likely affected by
https://code.google.com/p/skia/source/detail?r=13941.
TBR=borenet@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
217003004
git-svn-id: http://skia.googlecode.com/svn/trunk@13978
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Mar 2014 16:08:18 +0000 (16:08 +0000)]
Lazy image decoding to reduce bench_record overhead.
We want bench_record to time recording only, and are willing to accept
some time spent playing back the source pictures only out of necessity.
This lets us skip the JPEG and PNG decoding, which are a pretty fair
chunk of time. Should mean better record numbers at the same --loops.
BUG=skia:
R=tomhudson@chromium.org, halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
212563009
git-svn-id: http://skia.googlecode.com/svn/trunk@13977
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Mar 2014 16:08:05 +0000 (16:08 +0000)]
Add discard API to SkCanvas, plumb it to glDiscardFramebuffer()
BUG=skia:2349
R=robertphillips@google.com, reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
211683002
git-svn-id: http://skia.googlecode.com/svn/trunk@13976
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Mar 2014 15:59:04 +0000 (15:59 +0000)]
Updates to Android.mk generation.
Generate SkUserConfig.
Include arm64 as another build flavor.
Add tests.
gyp/common_conditions.gypi:
Add conditions for Android framework. These will get written into the generated SkUserConfig.
include/core/SkUserConfig.h:
Generated version that will ultimately be checked into Android (but not here).
platform_tools/android/bin/gyp_to_android.py:
Generate SkUserConfig.
Add arm64 (note that arm64 is not currently respected by our gyp files, so it results in use _none.cpp for the various opts).
Reset the common defines, which are now passed to the generated SkUserConfig.
platform_tools/android/gyp_gen/generate_user_config.py:
New script to generate SkUserConfig.h.
platform_tools/android/gyp_gen/gypd_parser.py:
Fix a lint error (unused import).
platform_tools/android/gyp_gen/makefile_writer.py:
Append any remaining DEFINES to LOCAL_CFLAGS (previously this was done during parsing).
Add a warning for arm64 (corresponds to downstream Android.mk).
platform_tools/android/gyp_gen/vars_dict_lib.py:
Add OrderedSet.reset().
Add DEFINES to VarsDict.
platform_tools/android/tests/expectations/:
Add and update expectations files.
platform_tools/android/tests/generate_user_config_tests.py:
New test for generate_user_config.py
platform_tools/android/tests/inputs/SkUserConfig.h:
Input to the new test, so we don't have to update the expectations each time the real SkUserConfig.h changes.
platform_tools/android/tests/makefile_writer_tests.py:
Add a way to rebaseline test_write_local_vars, which has changed.
Refactor EXPECTATIONS_DIR and compare_files into a separate file for sharing with generate_user_config_tests.py.
platform_tools/android/tests/utils.py:
Common code for tests.
platform_tools/android/tests/var_dict_tests.py:
Use a for loop to test the new key (DEFINES) and future proof this test to test any new keys in the future.
BUG=skia:1975
R=djsollen@google.com, halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
198063002
git-svn-id: http://skia.googlecode.com/svn/trunk@13975
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Mar 2014 15:58:31 +0000 (15:58 +0000)]
Add clip effect for circles
BUG=skia:2181
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
214153002
git-svn-id: http://skia.googlecode.com/svn/trunk@13974
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Mar 2014 15:52:18 +0000 (15:52 +0000)]
Increase GrGpuGL's program cache size
BUG=skia:2274
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
214823009
git-svn-id: http://skia.googlecode.com/svn/trunk@13973
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Mar 2014 14:29:23 +0000 (14:29 +0000)]
Please Valgrind by calling preConcat.
Valgrind's whining about m.setConcat(m, I). That special cases into m =
m, which compiles into memcpy(&m, &m, sizeof(m)), and then Valgrind
decides that's not kosher because &m and &m overlap. (memmove would
have been fine, but this is compiler generated code; not much we can do.)
preConcat gets us the same thing with an early can-we-noop check for I,
sidestepping the whole problem.
BUG=skia:
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
214823003
git-svn-id: http://skia.googlecode.com/svn/trunk@13972
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Mar 2014 14:28:04 +0000 (14:28 +0000)]
rebaseline_server: add option to read actuals from local disk
(SkipBuildbotRuns)
BUG=skia:1908
NOTREECHECKS=True
NOTRY=True
R=halcanary@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
212673013
git-svn-id: http://skia.googlecode.com/svn/trunk@13971
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Mar 2014 14:22:16 +0000 (14:22 +0000)]
Mark megalooper_0x0_gpu and complexclip2_rrect_aa_gpu flaky on Win7 perspective
NOTRY=true
BUG=skia:2359,skia:2332
R=epoger@google.com, bsalomon@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
216793005
git-svn-id: http://skia.googlecode.com/svn/trunk@13970
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 28 Mar 2014 14:20:35 +0000 (14:20 +0000)]
Add GM expectations for Test-Linux-Bare-NoGPU-Arm8_64-Debug
NOTRY=true
R=djsollen@google.com, borenet@google.com, epoger@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
214713006
git-svn-id: http://skia.googlecode.com/svn/trunk@13969
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Mar 2014 20:24:18 +0000 (20:24 +0000)]
Whitespace change to trigger builds after master crash
NOTRY=true
NOTREECHECKS=true
BUG=skia:2356
R=rmistry@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
215323002
git-svn-id: http://skia.googlecode.com/svn/trunk@13968
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Mar 2014 17:51:11 +0000 (17:51 +0000)]
Mark some msaa GMs flaky on Ubuntu12-GTX660
NOTREECHECKS=true
NOTRY=true
BUG=skia:2354
R=bsalomon@google.com, epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
215013002
git-svn-id: http://skia.googlecode.com/svn/trunk@13967
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 27 Mar 2014 16:21:31 +0000 (16:21 +0000)]
Add a default-default font for DirectWrite.
BUG=357067
R=reed@google.com
Review URL: https://codereview.chromium.org/
214843002
git-svn-id: http://skia.googlecode.com/svn/trunk@13966
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Mar 2014 15:48:52 +0000 (15:48 +0000)]
Making SkDeferredCanvas::silentFlush trigger a skippedPendingDrawCommands callback
The bug was preventing Canvas2DLayerBridge from properly tracking changes
in memory consumption that were triggered by calls to silentFlush.
BUG=344666
TEST=DeferredCanvas unit test
R=senorblanco@google.com, senorblanco@chromium.org
Author: junov@chromium.org
Review URL: https://codereview.chromium.org/
214803002
git-svn-id: http://skia.googlecode.com/svn/trunk@13965
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Mar 2014 15:30:35 +0000 (15:30 +0000)]
fix SkBitmap::erase to handle RGBA and BGRA
BUG=skia:2352
R=mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
212643014
git-svn-id: http://skia.googlecode.com/svn/trunk@13964
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Mar 2014 14:19:17 +0000 (14:19 +0000)]
Revert of Implement text rendering with NVPR (https://codereview.chromium.org/
196133014/)
Reason for revert:
This probably caused Win8 test bot fail during gm run:
http://108.170.217.252:10117/builders/Test-Win8-ShuttleA-GTX660-x86-Debug/builds/574
I can not identify any errors from the logs, so maybe it hung or something?
Original issue's description:
> Implement text rendering with NVPR
>
> Use path rendering to render the text from outlines if supported by the
> GPU. Implement this in GrStencilAndCoverTextContext by copying large
> chunks of code from GrBitmapTextContext (drawText) and
> GrDistanceFieldTextContext (drawPosText).
>
> The drawing is implemented with "instanced" path drawing
> functions.
>
> Moves the creation of the "main" text context from SkGpuDevice to the
> GrContext::createTextContext. This is done because the decision of which
> text renderer is optimal can be made only with the internal
> implementation-specific information of the context.
>
> Committed: http://code.google.com/p/skia/source/detail?r=13962
R=jvanverth@google.com, bsalomon@google.com, mtklein@google.com
TBR=bsalomon@google.com, jvanverth@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
213123014
git-svn-id: http://skia.googlecode.com/svn/trunk@13963
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 27 Mar 2014 11:26:10 +0000 (11:26 +0000)]
Implement text rendering with NVPR
Use path rendering to render the text from outlines if supported by the
GPU. Implement this in GrStencilAndCoverTextContext by copying large
chunks of code from GrBitmapTextContext (drawText) and
GrDistanceFieldTextContext (drawPosText).
The drawing is implemented with "instanced" path drawing
functions.
Moves the creation of the "main" text context from SkGpuDevice to the
GrContext::createTextContext. This is done because the decision of which
text renderer is optimal can be made only with the internal
implementation-specific information of the context.
R=jvanverth@google.com, bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
196133014
git-svn-id: http://skia.googlecode.com/svn/trunk@13962
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 27 Mar 2014 03:02:48 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13961
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Mar 2014 21:26:15 +0000 (21:26 +0000)]
Let DM work without a GPU.
Testing:
/m/s/skia (dm) $ d dm; and env GYP_DEFINES=skia_gpu=0 d dm
ninja: Entering directory `out/Debug'
ninja: no work to do.
(294 GMs, 620 benches) x 4 configs, 245 tests
4507 tasks leftUnsupported vertex-color/texture xfer mode.
Unsupported vertex-color/texture xfer mode.
0 tasks left
416.53user 9.86system 0:47.43elapsed 898%CPU (0avgtext+0avgdata
13353376maxresident)k
0inputs+0outputs (0major+3579906minor)pagefaults 0swaps
ninja: Entering directory `out/Debug'
[909/909] LINK dm
(287 GMs, 612 benches) x 4 configs, 227 tests
0 tasks left
365.24user 7.71system 0:14.55elapsed 2562%CPU (0avgtext+0avgdata
14718912maxresident)k
0inputs+0outputs (0major+3328269minor)pagefaults 0swaps
BUG=skia:
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
213093004
git-svn-id: http://skia.googlecode.com/svn/trunk@13960
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Mar 2014 21:21:40 +0000 (21:21 +0000)]
Remove static bmp from shadertext3
R=mtklein@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
212843004
git-svn-id: http://skia.googlecode.com/svn/trunk@13959
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Mar 2014 19:49:03 +0000 (19:49 +0000)]
Distance field fixes for Android
- Expand glyph size by 2 on each side to compensate for bilerp lookup
- Correct for Adreno tendency to drop entire tile if any pixel has divide-by-0
- Fix blurriness on Adreno by using uv coords to compute gradient instead
of st coords
- Add faster version for uniform scale
BUG=skia:2173
Committed: http://code.google.com/p/skia/source/detail?r=13955
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
205343008
git-svn-id: http://skia.googlecode.com/svn/trunk@13958
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Mar 2014 19:46:51 +0000 (19:46 +0000)]
Add tests for makefile_writer.py.
Many of the tests performed are comparison tests, where we call the
functions using dummy values and then compare to expectations (also
newly added).
Add a way to rebaseline the test for write_android_mk, which is likely
to change in the future.
BUG=skia:1975
R=epoger@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
205383006
git-svn-id: http://skia.googlecode.com/svn/trunk@13957
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Mar 2014 18:21:55 +0000 (18:21 +0000)]
Revert of Distance field fixes for Android (https://codereview.chromium.org/
205343008/)
Reason for revert:
compile error at line 110 in GrDistanceFieldTextureEffect.cpp
Original issue's description:
> Distance field fixes for Android
> - Expand glyph size by 2 on each side to compensate for bilerp lookup
> - Correct for Adreno tendency to drop entire tile if any pixel has divide-by-0
> - Fix blurriness on Adreno by using uv coords to compute gradient instead
> of st coords
> - Add faster version for uniform scale
>
> BUG=skia:2173
>
> Committed: http://code.google.com/p/skia/source/detail?r=13955
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2173
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
212953008
git-svn-id: http://skia.googlecode.com/svn/trunk@13956
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Mar 2014 18:03:05 +0000 (18:03 +0000)]
Distance field fixes for Android
- Expand glyph size by 2 on each side to compensate for bilerp lookup
- Correct for Adreno tendency to drop entire tile if any pixel has divide-by-0
- Fix blurriness on Adreno by using uv coords to compute gradient instead
of st coords
- Add faster version for uniform scale
BUG=skia:2173
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
205343008
git-svn-id: http://skia.googlecode.com/svn/trunk@13955
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Mar 2014 15:55:50 +0000 (15:55 +0000)]
remove SK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG
NOTRY=True
TBR=bsalomon
Author: reed@google.com
Review URL: https://codereview.chromium.org/
212623003
git-svn-id: http://skia.googlecode.com/svn/trunk@13954
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Mar 2014 15:32:23 +0000 (15:32 +0000)]
Updated baselines for Ubuntu12-GTX660
I think I may have committed incorrect baselines (left over from ATI5770) in
https://codereview.chromium.org/
204983016/ due to https://code.google.com/p/skia/issues/detail?id=2247
BUG=skia:2325
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
211493004
git-svn-id: http://skia.googlecode.com/svn/trunk@13953
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 26 Mar 2014 13:44:58 +0000 (13:44 +0000)]
remove all references to legacy Config8888
BUG=skia:
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
211043002
git-svn-id: http://skia.googlecode.com/svn/trunk@13952
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 26 Mar 2014 13:38:29 +0000 (13:38 +0000)]
rebaseline_server: delete invalid image files from local disk cache
BUG=skia:2247
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
211733004
git-svn-id: http://skia.googlecode.com/svn/trunk@13951
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 23:31:33 +0000 (23:31 +0000)]
Debugger improvements
This CL:
improves the 'SaveAs' functionality
allows switching between # and offset indexing in the command list
minor nit cleanup
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
211383003
git-svn-id: http://skia.googlecode.com/svn/trunk@13950
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 23:29:53 +0000 (23:29 +0000)]
Minor cleanup (moved out of main CL)
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
211173005
git-svn-id: http://skia.googlecode.com/svn/trunk@13949
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 22:07:24 +0000 (22:07 +0000)]
Remove forceRenderTargetFlush (unused)
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
210253004
git-svn-id: http://skia.googlecode.com/svn/trunk@13948
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 25 Mar 2014 21:12:18 +0000 (21:12 +0000)]
Speculative Mac 10.6 fix: disable medium & high filter quality tests.
BUG=skia:
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/
211693003
git-svn-id: http://skia.googlecode.com/svn/trunk@13947
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 21:01:13 +0000 (21:01 +0000)]
Fix bug on android with GL_EXT_debug_marker
A device was finding the extension string, but was returning NULL
when getting the proc addresses
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
211633002
git-svn-id: http://skia.googlecode.com/svn/trunk@13946
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 21:00:02 +0000 (21:00 +0000)]
Add a minimal --undefok to SkCommandLineFlags.
Similar in spirit to gflags' undefok, I'd like to be able to ignore
specific unknown flags. This lets me run the same command line on, say,
a branch that's got a new flag and on a clean branch tracking
origin/master. This is handy for performance comparison, etc.
It's not essential, and if you hate this I can find another way.
As an example, I want to compare the runtime of SKP recording with my new code. I've added a flag --skr to bench_record to help this. So I want to compare
origin/master: out/Release/bench_record
my patch: out/Release/bench_record --skr
This lets me run both as out/Release/bench_record --undefok skr --skr, which is handy for scripts and things.
BUG=skia:
R=scroggo@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
209393015
git-svn-id: http://skia.googlecode.com/svn/trunk@13945
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 25 Mar 2014 20:47:29 +0000 (20:47 +0000)]
Speculative Mac 10.6 fix: remove useless code from matriximagefilter GM.
TBR=mtklein@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
211703002
git-svn-id: http://skia.googlecode.com/svn/trunk@13944
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Tue, 25 Mar 2014 19:36:20 +0000 (19:36 +0000)]
Suppress failing GMs for rebaseline.
https://codereview.chromium.org/
203203004 caused a couple of minor GM
diffs:
fontscaler
bleed
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/
204983023
git-svn-id: http://skia.googlecode.com/svn/trunk@13943
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 18:02:17 +0000 (18:02 +0000)]
Further tweak compare_codereview.py.
- only show details for bots where at least one side failed
- dedup identical failures
BUG=skia:
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
202113008
git-svn-id: http://skia.googlecode.com/svn/trunk@13942
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 25 Mar 2014 17:35:10 +0000 (17:35 +0000)]
Implement a generic matrix transform image filter.
This will be used in Blink to accommodate matrices that contain
rotation or shearing. This is a generalization of SkResizeImageFilter,
so I've replaced all uses of SkResizeImageFilter in Skia. (It might be
easier to review by diffing it with SkResizeImageFilter, too.)
R=reed@google.com
Review URL: https://codereview.chromium.org/
211103006
git-svn-id: http://skia.googlecode.com/svn/trunk@13941
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 17:32:26 +0000 (17:32 +0000)]
Consolidate SkCanvas matrix virtuals.
Remove didTranslate, didScale, didRotate & didSkew, and rely on
didConcat instead. Subclasses can sniff the matrix type if they want to
differentiate.
(work in progress)
R=reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
203203004
git-svn-id: http://skia.googlecode.com/svn/trunk@13940
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 25 Mar 2014 16:20:24 +0000 (16:20 +0000)]
Revert "Revert of implement readPixels and writePixels natively, w/o using the (deprecated) (https://codereview.chromium.org/
199733016/)"
This reverts commit
9a90bd16dc6756395c422adf0f24560d033ed9ea.
BUG=skia:
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
211293002
git-svn-id: http://skia.googlecode.com/svn/trunk@13939
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 15:49:59 +0000 (15:49 +0000)]
Fix for int to bool in GrInOrderDrawBuffer
NOTREECHECK=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
207553006
git-svn-id: http://skia.googlecode.com/svn/trunk@13938
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 15:37:36 +0000 (15:37 +0000)]
platform_tools/barelinux/bin/arm64_make script
Motivation: an upcoming CL will change the Gyp variables.
That CL can change this script and the deps roll bot will
pick up those changes.
NOTRY=true
R=borenet@google.com, djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
211133002
git-svn-id: http://skia.googlecode.com/svn/trunk@13937
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 15:17:32 +0000 (15:17 +0000)]
Add Gpu Tracing to Ganesh
BUG=skia:2316
R=bsalomon@google.com, tomhudson@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
184443003
git-svn-id: http://skia.googlecode.com/svn/trunk@13936
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 15:16:27 +0000 (15:16 +0000)]
Tweak compare_codereview.py.
- summary at end so I don't have to scroll back up
- tweak the diff markers a bit
- strip the test runtimes
BUG=skia:
R=halcanary@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
211233002
git-svn-id: http://skia.googlecode.com/svn/trunk@13935
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 15:14:18 +0000 (15:14 +0000)]
Remove more flags not needed by android framework.
R=djsollen@google.com, reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
184753003
git-svn-id: http://skia.googlecode.com/svn/trunk@13934
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 15:13:18 +0000 (15:13 +0000)]
Add GM that tests GrTextureDomain and fix bug where kDecal_Mode gets incorrectly ignored.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
208313017
git-svn-id: http://skia.googlecode.com/svn/trunk@13933
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 13:38:44 +0000 (13:38 +0000)]
Revert of implement readPixels and writePixels natively, w/o using the (deprecated) (https://codereview.chromium.org/
199733016/)
Reason for revert:
Android bots segfaulting in tests.
Original issue's description:
> implement readPixels and writePixels natively, w/o using the (deprecated)
> SkCanvas::Config8888 enum.
>
> Revert "Revert "hide Config8888 entirely". Broke a bunch of builds."
>
> This reverts commit
763277ba157fef0f651004bb98a189e9f1ac730b.
>
> Needs chrome to remove the READPIXELS guard from skia's .gyp
>
> Committed: https://code.google.com/p/skia/source/detail?r=13931
R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
209233004
git-svn-id: http://skia.googlecode.com/svn/trunk@13932
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 25 Mar 2014 12:00:30 +0000 (12:00 +0000)]
implement readPixels and writePixels natively, w/o using the (deprecated)
SkCanvas::Config8888 enum.
Revert "Revert "hide Config8888 entirely". Broke a bunch of builds."
This reverts commit
763277ba157fef0f651004bb98a189e9f1ac730b.
Needs chrome to remove the READPIXELS guard from skia's .gyp
Review URL: https://codereview.chromium.org/
199733016
git-svn-id: http://skia.googlecode.com/svn/trunk@13931
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 11:59:40 +0000 (11:59 +0000)]
Make it possible to draw multiple paths at once to a draw target
Add interface to draw multiple paths in a single "command" to a draw
target. Implement this interface in GrGpuGL with NVPR "instanced"
calls.
The instanced calls accept list of paths and list of transformations as
their parameters. The transformations are at this moment expected to be
2d affine transformations, as the functions are called only for text
rendering.
This will be used when drawing fonts. Later it can be maybe be used in
GrInOrderDrawBuffer to aggregate many draw calls into one instanced draw
call, similar to drawing rects.
R=jvanverth@google.com, bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
209413006
git-svn-id: http://skia.googlecode.com/svn/trunk@13930
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 25 Mar 2014 11:45:49 +0000 (11:45 +0000)]
Whitespace change to trigger builds for new GCE compile bots
NOTREECHECKS=true
BUG=skia:2323
TBR=
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
210923003
git-svn-id: http://skia.googlecode.com/svn/trunk@13929
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 25 Mar 2014 03:02:32 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13928
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 23:03:11 +0000 (23:03 +0000)]
SkPaint: eliminate some dead bytes in 64-bit build.
+ memcpy-based copy constructor was hiding this gap -> manual copy constructor.
+ Split tests for finer-grained failures.
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=13856
Committed: http://code.google.com/p/skia/source/detail?r=13887
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
203203003
git-svn-id: http://skia.googlecode.com/svn/trunk@13927
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 21:42:01 +0000 (21:42 +0000)]
SkFontHost_linux - dup stream instead of ref
R=bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
210383002
git-svn-id: http://skia.googlecode.com/svn/trunk@13926
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 24 Mar 2014 21:32:28 +0000 (21:32 +0000)]
Fix Mac Debug clang build.
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
210443002
git-svn-id: http://skia.googlecode.com/svn/trunk@13925
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 20:58:21 +0000 (20:58 +0000)]
Mark dashing_gpu and complexclip2_rect_aa_gpu as ignore-failure on Win7 perspective
BUG=skia:2245
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
208323012
git-svn-id: http://skia.googlecode.com/svn/trunk@13924
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 24 Mar 2014 20:50:59 +0000 (20:50 +0000)]
Fix for crash on large image blur sigma values.
This was crashing on the GPU path, due to a failed texture allocation.
The belt-and-suspenders fix is to:
1) Limit the GPU path to only allocate up to maxTextureSize.
2) Limit both the raster and GPU paths to reasonable blur sizes (box blur
kernel size of 1000, resulting in a sigma limit of 532).
R=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
209353014
git-svn-id: http://skia.googlecode.com/svn/trunk@13923
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 20:07:44 +0000 (20:07 +0000)]
gather GM tests which are disabled on Android
BUG=skia:2326
R=borenet@google.com, djsollen@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
208313014
git-svn-id: http://skia.googlecode.com/svn/trunk@13922
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 19:51:57 +0000 (19:51 +0000)]
fix compare_to_expectations command line launch
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
210093003
git-svn-id: http://skia.googlecode.com/svn/trunk@13921
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 19:43:02 +0000 (19:43 +0000)]
Add SkASSERT's to gl/Interface validate
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
209433006
git-svn-id: http://skia.googlecode.com/svn/trunk@13920
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 19:40:49 +0000 (19:40 +0000)]
Add new experimental API to SkPicture to get "id" of current op
When gathering information about a picture (in the new SkDevice::EXPERIMENTAL_optimize entry point) it is necessary to be able to correlate the gathered information with the command in the SkPicture (so the information can later be combined with the similarly indexed information from the BBH). This entry point exposes that information to friend classes.
R=reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
206853003
git-svn-id: http://skia.googlecode.com/svn/trunk@13919
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 19:24:59 +0000 (19:24 +0000)]
When clipping treat rrect corners where either the x or y radius is < 0.5 as square.
BUG=skia:2181
R=robertphillips@google.com, jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
200723011
git-svn-id: http://skia.googlecode.com/svn/trunk@13918
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 24 Mar 2014 18:38:25 +0000 (18:38 +0000)]
Clean up SkOnce usage in SkFontMgr_Indirect.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
210283002
git-svn-id: http://skia.googlecode.com/svn/trunk@13917
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 18:34:04 +0000 (18:34 +0000)]
More distance field improvements:
- Make sure we only use the 0,0 subpixel glyph
- Copy image data into outsized buffer to ensure we capture outer edges
- Change edge dump to blend better with original glyph
- Edges are detected across >128 and <128 boundaries, or when
there are two non-zero <128 pixels next to each other
BUG=skia:
R=robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
208893003
git-svn-id: http://skia.googlecode.com/svn/trunk@13916
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 18:26:36 +0000 (18:26 +0000)]
Add tools to generated Android.mk
Include the skia tools (bench, gm, tests) in the generated Android
make file for the framework. They are commented out, so that a tester
can include them if desired.
BUG=skia:1975
R=halcanary@google.com, djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
210173002
git-svn-id: http://skia.googlecode.com/svn/trunk@13915
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 24 Mar 2014 18:07:24 +0000 (18:07 +0000)]
remove SK_SUPPORT_LEGACY_READPIXELSCONFIG
BUG=skia:
Review URL: https://codereview.chromium.org/
209333011
git-svn-id: http://skia.googlecode.com/svn/trunk@13914
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 17:52:28 +0000 (17:52 +0000)]
rebaseline Nexus10 results obscured by skia:2313
BUG=skia:2313
NOTREECHECKS=True
NOTRY=True
R=bsalomon@google.com
TBR=bsalomon
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
209353012
git-svn-id: http://skia.googlecode.com/svn/trunk@13913
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 17:44:00 +0000 (17:44 +0000)]
Add skimage expectations for Arm8_64
NOTRY=true
R=djsollen@google.com, scroggo@google.com, borenet@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
200123005
git-svn-id: http://skia.googlecode.com/svn/trunk@13912
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 17:30:48 +0000 (17:30 +0000)]
Remove unnecessary isrect code in clip mask manager
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
205213002
git-svn-id: http://skia.googlecode.com/svn/trunk@13911
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 16:59:09 +0000 (16:59 +0000)]
Update expectations for Ubuntu12-GTX660
Move ATI5770 expectations to GTX660
BUG=skia:2325
NOTRY=true
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
204983016
git-svn-id: http://skia.googlecode.com/svn/trunk@13910
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 24 Mar 2014 15:55:01 +0000 (15:55 +0000)]
Have SkTArray state that it default-initializes.
The current comments in SkTArray lead one to believe that it is default
constructing all types. However, it is not calling the default
constructor for primitive types, it is actually default-initializing.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
208393006
git-svn-id: http://skia.googlecode.com/svn/trunk@13909
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 15:52:33 +0000 (15:52 +0000)]
Manual memset to work around bogus compiler warning bug.
BUG=skia:2215
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
210013003
git-svn-id: http://skia.googlecode.com/svn/trunk@13908
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 15:40:42 +0000 (15:40 +0000)]
Add skimage baselines for Ubuntu12-GTX660 bots
BUG=skia:2325
R=scroggo@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
200843005
git-svn-id: http://skia.googlecode.com/svn/trunk@13907
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 14:54:04 +0000 (14:54 +0000)]
Fix 10.6 build: double -> float.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
209893004
git-svn-id: http://skia.googlecode.com/svn/trunk@13906
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 14:53:09 +0000 (14:53 +0000)]
Add test cases for small radii to rrect GMs.
BUG=skia:2181
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
203963010
git-svn-id: http://skia.googlecode.com/svn/trunk@13905
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 24 Mar 2014 02:49:48 +0000 (02:49 +0000)]
update bitmapshader to avoid potential rendering error for kA8_Config
A local matrix is set to the shader, which will show the potential error for SkCanvas::drawBitmap when the bitmap is kA8_Config, as well as the potential error for drawing a geometry with a bitmapshader who's bitmap is kA8_Config.
A simple case is also added for SkCanvas::drawBitmap when the bitmap is kA8_Config, but there is not shader. Then the drawing area will be colorized by the solid color set in SkPaint.
BUG=skia:2278
BUG=skia:2293
R=reed@google.com, bsalomon@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
204143004
git-svn-id: http://skia.googlecode.com/svn/trunk@13904
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 23 Mar 2014 23:08:18 +0000 (23:08 +0000)]
disable imagefilterscropexpand GM test on Android
BUG=skia:2313
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com, senorblanco@google.com, senorblanco@chromium.org
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
208813004
git-svn-id: http://skia.googlecode.com/svn/trunk@13903
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 22 Mar 2014 03:02:27 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13902
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Sat, 22 Mar 2014 00:25:34 +0000 (00:25 +0000)]
Fix r13897.
git-svn-id: http://skia.googlecode.com/svn/trunk@13901
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 21 Mar 2014 23:19:10 +0000 (23:19 +0000)]
Fix r13897.
git-svn-id: http://skia.googlecode.com/svn/trunk@13900
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 21 Mar 2014 23:07:24 +0000 (23:07 +0000)]
Fix r13897.
git-svn-id: http://skia.googlecode.com/svn/trunk@13899
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 21 Mar 2014 23:00:41 +0000 (23:00 +0000)]
Fix r13897.
git-svn-id: http://skia.googlecode.com/svn/trunk@13898
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 21 Mar 2014 22:48:32 +0000 (22:48 +0000)]
A remotable font management interface and DirectWrite implementation.
The introduced SkRemotableFontMgr is a font management interface designed for simple and fast proxy support. SkFontMgr_Indirect bridges a SkRemotableFontMgr and a local SkFontMgr to present a SkFontMgr interface.
This change is to be followed by https://codereview.chromium.org/
132113015/ and https://codereview.chromium.org/
206693003 .
R=reed@google.com
Review URL: https://codereview.chromium.org/
206683002
git-svn-id: http://skia.googlecode.com/svn/trunk@13897
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 21 Mar 2014 20:14:05 +0000 (20:14 +0000)]
Fix incorrect assert in r13895.
git-svn-id: http://skia.googlecode.com/svn/trunk@13896
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Fri, 21 Mar 2014 19:39:02 +0000 (19:39 +0000)]
Add removeShuffle to SkTArray and add SkTArray tests.
R=reed@google.com
Review URL: https://codereview.chromium.org/
208153008
git-svn-id: http://skia.googlecode.com/svn/trunk@13895
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Mar 2014 17:54:14 +0000 (17:54 +0000)]
rebaseline_server: rename results.py to compare_to_expectations.py
BUG=skia:1919
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
208243003
git-svn-id: http://skia.googlecode.com/svn/trunk@13894
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Mar 2014 17:30:12 +0000 (17:30 +0000)]
rebaseline_server: fix --editable mode
complete revert of https://skia.googlesource.com/skia/+/
736be3527214ddbd3dd7e42a89a374c62d98f370
partial revert of https://skia.googlesource.com/skia/+/
579942387bed9259b03419c593503022e1399931
and glue made necessary by the above.
(SkipBuildbotRuns)
BUG=skia:2319
NOTREECHECKS=True
NOTRY=True
R=senorblanco@google.com, senorblanco@chromium.org
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
208473004
git-svn-id: http://skia.googlecode.com/svn/trunk@13893
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Mar 2014 16:19:28 +0000 (16:19 +0000)]
Fixed double offset in resize filter
The fix is trivial, simply remove the extra offset
I added another case to the resizeimagefilter gm and made it so that it looks exactly like the one next to it, so that failure is easy to detect visually.
BUG=skia:
R=senorblanco@google.com, senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
208303002
git-svn-id: http://skia.googlecode.com/svn/trunk@13892
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 21 Mar 2014 15:04:12 +0000 (15:04 +0000)]
Some stragglerbot rebaselines for lighting, imagefiltersscaled GMs.
TBR=jcgregorio@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
208353002
git-svn-id: http://skia.googlecode.com/svn/trunk@13891
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 21 Mar 2014 13:13:22 +0000 (13:13 +0000)]
Fix broken Android builds due to missing includes for NEON defines
Review URL: https://codereview.chromium.org/
208173002
git-svn-id: http://skia.googlecode.com/svn/trunk@13890
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 21 Mar 2014 03:02:42 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@13889
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 21 Mar 2014 01:40:07 +0000 (01:40 +0000)]
Revert of SkPaint: eliminate some dead bytes in 64-bit build. (https://codereview.chromium.org/
203203003/)
Reason for revert:
Huh, some Android tests are still failing despite the fix. IntelRhB, Xoom... that's weird.
Original issue's description:
> SkPaint: eliminate some dead bytes in 64-bit build.
>
> + memcpy-based copy constructor was hiding this gap -> manual copy constructor.
> + Split tests for finer-grained failures.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13856
>
> Committed: http://code.google.com/p/skia/source/detail?r=13887
R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
206623005
git-svn-id: http://skia.googlecode.com/svn/trunk@13888
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Mar 2014 23:02:35 +0000 (23:02 +0000)]
SkPaint: eliminate some dead bytes in 64-bit build.
+ memcpy-based copy constructor was hiding this gap -> manual copy constructor.
+ Split tests for finer-grained failures.
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=13856
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
203203003
git-svn-id: http://skia.googlecode.com/svn/trunk@13887
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Mar 2014 21:39:03 +0000 (21:39 +0000)]
Remove the now-unnecessary enum in the elliptical clipping effect.
BUG=skia:2181
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
204463007
git-svn-id: http://skia.googlecode.com/svn/trunk@13886
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Mar 2014 20:25:14 +0000 (20:25 +0000)]
Fix cull nesting assertion.
Cull rects are in local coordinates and cannot be compared directly.
No wonder it was so hard enforcing this in Blink :o
This moves the validation logic into SkCanvas, using a device-space
cull stack (debug build only).
There are still some Blink bugs causing violations, so for now I'd like
to keep this as an error message only.
R=reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
200923008
git-svn-id: http://skia.googlecode.com/svn/trunk@13885
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Mar 2014 20:00:24 +0000 (20:00 +0000)]
replace old SK_TRACE_EVENT macros with new TRACE_EVENT ones, and then remove them entirely!
BUG=skia:353
R=tomhudson@google.com, epoger@google.com, reed@google.com, egdaniel@google.com, bsalomon@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
196133033
git-svn-id: http://skia.googlecode.com/svn/trunk@13884
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Mar 2014 19:59:09 +0000 (19:59 +0000)]
gyp_skia: make default GYP_GENERATORS for each platform explicit
BUG=skia:2317
R=bungeman@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
199873003
git-svn-id: http://skia.googlecode.com/svn/trunk@13883
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Mar 2014 19:56:55 +0000 (19:56 +0000)]
fix error in linux makefile for some shells
R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
196823007
git-svn-id: http://skia.googlecode.com/svn/trunk@13882
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Mar 2014 19:48:16 +0000 (19:48 +0000)]
android_run_skia: fix error check
(SkipBuildbotRuns)
BUG=skia:2313
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
204713003
git-svn-id: http://skia.googlecode.com/svn/trunk@13881
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 20 Mar 2014 18:37:06 +0000 (18:37 +0000)]
Don't use __ARM_HAVE_NEON to detect NEON's presence in SkBlitter_RGB16
Replace __ARM_HAVE_NEON by SK_ARM_NEON_IS_ALWAYS. It was the only
use of __ARM_HAVE_NEON apart from defining SK_ARM_NEON_IS_ALWAYS.
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com, halcanary@google.com, reed@google.com
Author: kevin.petit@arm.com
Review URL: https://codereview.chromium.org/
206543002
git-svn-id: http://skia.googlecode.com/svn/trunk@13880
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log