platform/upstream/libSkiaSharp.git
11 years agore-land r8535, now that src.chromium.org is back up
epoger@google.com [Thu, 4 Apr 2013 19:23:11 +0000 (19:23 +0000)]
re-land r8535, now that src.chromium.org is back up
Review URL: https://codereview.chromium.org/13662002

git-svn-id: http://skia.googlecode.com/svn/trunk@8538 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to see if svn.chromium.org is back
rmistry@google.com [Thu, 4 Apr 2013 19:13:40 +0000 (19:13 +0000)]
Whitespace change to see if svn.chromium.org is back

git-svn-id: http://skia.googlecode.com/svn/trunk@8537 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r8535
epoger@google.com [Thu, 4 Apr 2013 18:21:48 +0000 (18:21 +0000)]
Revert r8535

git-svn-id: http://skia.googlecode.com/svn/trunk@8536 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm: report ExpectationsMismatch and RenderModeMismatch results separately
epoger@google.com [Thu, 4 Apr 2013 18:11:31 +0000 (18:11 +0000)]
gm: report ExpectationsMismatch and RenderModeMismatch results separately
Review URL: https://codereview.chromium.org/13650002

git-svn-id: http://skia.googlecode.com/svn/trunk@8535 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change - Verify that checkouts are fixed
borenet@google.com [Thu, 4 Apr 2013 14:12:22 +0000 (14:12 +0000)]
Whitespace change - Verify that checkouts are fixed

Unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@8533 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to verify successful builds after master restart
borenet@google.com [Thu, 4 Apr 2013 13:00:01 +0000 (13:00 +0000)]
Whitespace change to verify successful builds after master restart

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@8532 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test commit queue compile bots
commit-bot@chromium.org [Thu, 4 Apr 2013 11:59:55 +0000 (11:59 +0000)]
Whitespace change to test commit queue compile bots

(SkipBuildbotRuns)

Author: rmistry@google.com

Reviewed By: borenet@google.com

Review URL: https://chromiumcodereview.appspot.com/13631002

git-svn-id: http://skia.googlecode.com/svn/trunk@8530 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 4 Apr 2013 07:01:12 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8529 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert 8525,8526 pending investigation of bench_pictures crashes.
bsalomon@google.com [Wed, 3 Apr 2013 21:06:42 +0000 (21:06 +0000)]
Revert 8525,8526 pending investigation of bench_pictures crashes.

git-svn-id: http://skia.googlecode.com/svn/trunk@8527 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCommit file accidentally left out of glc change for r8525
bsalomon@google.com [Wed, 3 Apr 2013 19:55:19 +0000 (19:55 +0000)]
Commit file accidentally left out of glc change for r8525

git-svn-id: http://skia.googlecode.com/svn/trunk@8526 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GrTexture::releaseRenderTarget() and add GrSurface::isSameAs().
bsalomon@google.com [Wed, 3 Apr 2013 19:49:13 +0000 (19:49 +0000)]
Remove GrTexture::releaseRenderTarget() and add GrSurface::isSameAs().
Review URL: https://codereview.chromium.org/13414006

git-svn-id: http://skia.googlecode.com/svn/trunk@8525 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd list of Skia trybots to run CLs against, along with existing lists of Chrome...
epoger@google.com [Wed, 3 Apr 2013 18:48:18 +0000 (18:48 +0000)]
Add list of Skia trybots to run CLs against, along with existing lists of Chrome trybots
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13545002

git-svn-id: http://skia.googlecode.com/svn/trunk@8522 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake submit_try accept space- or comma-separated list
epoger@google.com [Wed, 3 Apr 2013 18:35:35 +0000 (18:35 +0000)]
Make submit_try accept space- or comma-separated list
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13535005

git-svn-id: http://skia.googlecode.com/svn/trunk@8521 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test the commit queue compile bots
commit-bot@chromium.org [Wed, 3 Apr 2013 18:30:26 +0000 (18:30 +0000)]
Whitespace change to test the commit queue compile bots

(SkipBuildbotRuns)

Author: rmistry@google.com

Reviewed By: borenet@google.com

Review URL: https://chromiumcodereview.appspot.com/13561002

git-svn-id: http://skia.googlecode.com/svn/trunk@8520 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agore-land r8514 without breaking 32-bit Mac compilers
epoger@google.com [Wed, 3 Apr 2013 18:00:39 +0000 (18:00 +0000)]
re-land r8514 without breaking 32-bit Mac compilers
Review URL: https://codereview.chromium.org/13427004

git-svn-id: http://skia.googlecode.com/svn/trunk@8518 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline Ubuntu performance trigger
robertphillips@google.com [Wed, 3 Apr 2013 17:31:22 +0000 (17:31 +0000)]
Rebaseline Ubuntu performance trigger

git-svn-id: http://skia.googlecode.com/svn/trunk@8516 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoroll out r8514
epoger@google.com [Wed, 3 Apr 2013 17:12:42 +0000 (17:12 +0000)]
roll out r8514
Review URL: https://codereview.chromium.org/13503003

git-svn-id: http://skia.googlecode.com/svn/trunk@8515 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm: display summary of all results by ErrorType
epoger@google.com [Wed, 3 Apr 2013 17:02:53 +0000 (17:02 +0000)]
gm: display summary of all results by ErrorType
as discussed in https://codereview.chromium.org/12825005/#msg14
Review URL: https://codereview.chromium.org/12851022

git-svn-id: http://skia.googlecode.com/svn/trunk@8514 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix for Surface Test on non-gpu builds
junov@chromium.org [Wed, 3 Apr 2013 15:25:46 +0000 (15:25 +0000)]
Build fix for Surface Test on non-gpu builds

git-svn-id: http://skia.googlecode.com/svn/trunk@8513 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixed bug with SkImage leaving canvas backing store in an immutable state after destroy.
junov@chromium.org [Wed, 3 Apr 2013 15:03:26 +0000 (15:03 +0000)]
Fixed bug with SkImage leaving canvas backing store in an immutable state after destroy.
Added unit test that verifies that surface backing is writable after creating and destroying an image.
Review URL: https://codereview.chromium.org/13226002

git-svn-id: http://skia.googlecode.com/svn/trunk@8512 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GrDrawTarget::copySurface.
bsalomon@google.com [Wed, 3 Apr 2013 14:56:40 +0000 (14:56 +0000)]
Add GrDrawTarget::copySurface.
Review URL: https://codereview.chromium.org/13428004

git-svn-id: http://skia.googlecode.com/svn/trunk@8510 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplacing 'new' with 'SkNEW_ARGS' in SkImage_Gpu
junov@chromium.org [Wed, 3 Apr 2013 13:58:32 +0000 (13:58 +0000)]
Replacing 'new' with 'SkNEW_ARGS' in SkImage_Gpu
Review URL: https://codereview.chromium.org/13535004

git-svn-id: http://skia.googlecode.com/svn/trunk@8509 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix build error when building Android in Release mode with -O2.
djsollen@google.com [Wed, 3 Apr 2013 12:34:16 +0000 (12:34 +0000)]
Fix build error when building Android in Release mode with -O2.

This fixes the folowing error...

../../../src/pdf/SkPDFShader.cpp: In function 'void gradientFunctionCode(const SkShader::GradientInfo&, SkString*)':
../../../src/pdf/SkPDFShader.cpp:69:19: error: array subscript is above array bounds [-Werror=array-bounds]

Review URL: https://codereview.chromium.org/13471011

git-svn-id: http://skia.googlecode.com/svn/trunk@8506 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkDraw.h #include cleanup
tomhudson@google.com [Wed, 3 Apr 2013 10:18:17 +0000 (10:18 +0000)]
SkDraw.h #include cleanup

Removal of SkAutoKern header was already done in r8495; this just
lands the replacement of #includes with forward declarations for
incremental compile speed.

https://codereview.appspot.com/8109043/

git-svn-id: http://skia.googlecode.com/svn/trunk@8504 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 3 Apr 2013 07:01:14 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8503 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake drawRect preserve vertex attrib state and push/pop the geom sources.
bsalomon@google.com [Tue, 2 Apr 2013 21:00:15 +0000 (21:00 +0000)]
Make drawRect preserve vertex attrib state and push/pop the geom sources.

Also, add some balancing calls for setIndexSource*()
Review URL: https://codereview.chromium.org/13468004

git-svn-id: http://skia.googlecode.com/svn/trunk@8499 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for effect cache key.
commit-bot@chromium.org [Tue, 2 Apr 2013 20:48:38 +0000 (20:48 +0000)]
Fix for effect cache key.

Adds the additional shift needed to incorporate the attribKeyBits.  Also simplifies the creation of the static globals for the edge effects.

Author: jvanverth@google.com

Reviewed By: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/13465019

git-svn-id: http://skia.googlecode.com/svn/trunk@8498 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove unused header declaration.
commit-bot@chromium.org [Tue, 2 Apr 2013 18:41:32 +0000 (18:41 +0000)]
Remove unused header declaration.

BUG=1179

Author: djsollen@google.com

Reviewed By: reed@google.com,tomhudson@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13097005

git-svn-id: http://skia.googlecode.com/svn/trunk@8495 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert Skia to use -02.
djsollen@google.com [Tue, 2 Apr 2013 18:14:21 +0000 (18:14 +0000)]
Revert Skia to use -02.

There was no clear speed improvement and the
increase in binary size was substantial.

Committed: http://code.google.com/p/skia/source/detail?r=8492

Review URL: https://codereview.chromium.org/13468010

git-svn-id: http://skia.googlecode.com/svn/trunk@8494 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove edge GrEffects to locally defined classes.
commit-bot@chromium.org [Tue, 2 Apr 2013 17:57:21 +0000 (17:57 +0000)]
Move edge GrEffects to locally defined classes.

This removes the general GrEdgeEffect and the specialized oval GrEffects and declares them within the renderer files that use them. It also splits GrEdgeEffect into three different GrEffects.

Author: jvanverth@google.com

Reviewed By: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/13344002

git-svn-id: http://skia.googlecode.com/svn/trunk@8493 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert Skia to use -02.
commit-bot@chromium.org [Tue, 2 Apr 2013 17:36:30 +0000 (17:36 +0000)]
Revert Skia to use -02.

There was no clear speed improvement and the
increase in binary size was substantial.

Author: djsollen@google.com

Reviewed By: borenet@google.com

Review URL: https://chromiumcodereview.appspot.com/13468010

git-svn-id: http://skia.googlecode.com/svn/trunk@8492 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIncreases batch size for sending bench data to appengine to 66.
bensong@google.com [Tue, 2 Apr 2013 16:41:55 +0000 (16:41 +0000)]
Increases batch size for sending bench data to appengine to 66.
This is part of the attempt to avoid bench step timeout errors (10-20min).
Review URL: https://codereview.chromium.org/13430011

git-svn-id: http://skia.googlecode.com/svn/trunk@8491 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoresubmit https://code.google.com/p/skia/source/detail?r=7883 (in the meantime we
edisonn@google.com [Tue, 2 Apr 2013 15:33:08 +0000 (15:33 +0000)]
resubmit https://code.google.com/p/skia/source/detail?r=7883 (in the meantime we
added capability to collect minidump and callstack if buildbot fails with heap
coruption in windows, and a NPE bug was fixed in SkPDFDocument, when document was destroyed without ever beeing used and a field was NULL + a few minor conflicts have been resolved)

git-svn-id: http://skia.googlecode.com/svn/trunk@8487 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExpand filter 0 to handle transparent drawBitmapRect paints
robertphillips@google.com [Tue, 2 Apr 2013 15:30:03 +0000 (15:30 +0000)]
Expand filter 0 to handle transparent drawBitmapRect paints

https://codereview.chromium.org/13394014/

git-svn-id: http://skia.googlecode.com/svn/trunk@8486 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd tile rendering to GM
robertphillips@google.com [Tue, 2 Apr 2013 15:18:41 +0000 (15:18 +0000)]
Add tile rendering to GM

https://codereview.chromium.org/13165011/

git-svn-id: http://skia.googlecode.com/svn/trunk@8485 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRe-enabling Mac 10.8 performance triggers removed in r8472
robertphillips@google.com [Tue, 2 Apr 2013 15:05:55 +0000 (15:05 +0000)]
Re-enabling Mac 10.8 performance triggers removed in r8472

git-svn-id: http://skia.googlecode.com/svn/trunk@8484 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix clang warning as error from 8480.
bungeman@google.com [Tue, 2 Apr 2013 14:40:44 +0000 (14:40 +0000)]
Fix clang warning as error from 8480.

git-svn-id: http://skia.googlecode.com/svn/trunk@8482 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline Nexus7 performance triggers
robertphillips@google.com [Tue, 2 Apr 2013 14:36:10 +0000 (14:36 +0000)]
Rebaseline Nexus7 performance triggers

git-svn-id: http://skia.googlecode.com/svn/trunk@8481 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoName table iterator.
bungeman@google.com [Tue, 2 Apr 2013 14:12:38 +0000 (14:12 +0000)]
Name table iterator.
https://codereview.appspot.com/8180043/

git-svn-id: http://skia.googlecode.com/svn/trunk@8480 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReland 8459 with fix for #extension after default precision in FS.
bsalomon@google.com [Tue, 2 Apr 2013 12:50:49 +0000 (12:50 +0000)]
Reland 8459 with fix for #extension after default precision in FS.

git-svn-id: http://skia.googlecode.com/svn/trunk@8479 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 2 Apr 2013 07:01:34 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8477 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix another clang warning/error
robertphillips@google.com [Mon, 1 Apr 2013 23:30:26 +0000 (23:30 +0000)]
Fix another clang warning/error

git-svn-id: http://skia.googlecode.com/svn/trunk@8476 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix clang compiler warning/error
robertphillips@google.com [Mon, 1 Apr 2013 23:24:15 +0000 (23:24 +0000)]
Fix clang compiler warning/error

git-svn-id: http://skia.googlecode.com/svn/trunk@8475 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r8459 due to shader error on Nexus 10
robertphillips@google.com [Mon, 1 Apr 2013 22:20:59 +0000 (22:20 +0000)]
Reverting r8459 due to shader error on Nexus 10

git-svn-id: http://skia.googlecode.com/svn/trunk@8474 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove MacMini_10_8 performance triggers
robertphillips@google.com [Mon, 1 Apr 2013 21:38:37 +0000 (21:38 +0000)]
Remove MacMini_10_8 performance triggers

git-svn-id: http://skia.googlecode.com/svn/trunk@8472 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTaken together with the filter tool's new looping capabilities, these two optimizatio...
commit-bot@chromium.org [Mon, 1 Apr 2013 21:00:27 +0000 (21:00 +0000)]
Taken together with the filter tool's new looping capabilities, these two optimizations can replace check_7 and apply_7.

Author: robertphillips@google.com

Reviewed By: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/13261019

git-svn-id: http://skia.googlecode.com/svn/trunk@8471 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOne more fix for r8468. Replace use of int with size_t. Unreviewed.
jvanverth@google.com [Mon, 1 Apr 2013 20:28:08 +0000 (20:28 +0000)]
One more fix for r8468. Replace use of int with size_t. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@8470 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPatches for r8468 build errors. Unreviewed.
jvanverth@google.com [Mon, 1 Apr 2013 20:14:02 +0000 (20:14 +0000)]
Patches for r8468 build errors. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@8469 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTake two for r8466:
jvanverth@google.com [Mon, 1 Apr 2013 20:06:51 +0000 (20:06 +0000)]
Take two for r8466:

Replace the old attribute binding and index interface with one where we include the binding as part of the attribute array. Also removed the fixed attribute indices for constant color and coverage attributes, and replaced with dynamic ones based on current attribute set. Removed binding of color and coverage attributes unless they're actually set.

Original author: bsalomon@google.com

Author: jvanverth@google.com

Reviewed By: bsalomon@google.com,robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/13296005

git-svn-id: http://skia.googlecode.com/svn/trunk@8468 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRolling back r8466.
jvanverth@google.com [Mon, 1 Apr 2013 19:29:32 +0000 (19:29 +0000)]
Rolling back r8466.

Not reviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@8467 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevise attribute binding interface.
commit-bot@chromium.org [Mon, 1 Apr 2013 19:12:42 +0000 (19:12 +0000)]
Revise attribute binding interface.

Replace the old attribute binding and index interface with one where we include the binding as part of the attribute array. Also removed the fixed attribute indices for constant color and coverage attributes, and replaced with dynamic ones based on current attribute set. Removed binding of color and coverage attributes unless they're actually set.

Original author: bsalomon@google.com

Author: jvanverth@google.com

Reviewed By: bsalomon@google.com,robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/13296005

git-svn-id: http://skia.googlecode.com/svn/trunk@8466 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd looping over optimizations to filter tool
robertphillips@google.com [Mon, 1 Apr 2013 19:10:21 +0000 (19:10 +0000)]
Add looping over optimizations to filter tool

https://codereview.chromium.org/13261018/

git-svn-id: http://skia.googlecode.com/svn/trunk@8465 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSimplify the circle outset code and add comment relating it to the shader code.
bsalomon@google.com [Mon, 1 Apr 2013 19:01:20 +0000 (19:01 +0000)]
Simplify the circle outset code and add comment relating it to the shader code.
Review URL: https://codereview.chromium.org/13165012

git-svn-id: http://skia.googlecode.com/svn/trunk@8463 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd getDrawCommandAt and setDrawCommandAt to SkDebugCanvas
robertphillips@google.com [Mon, 1 Apr 2013 18:18:49 +0000 (18:18 +0000)]
Add getDrawCommandAt and setDrawCommandAt to SkDebugCanvas

https://codereview.chromium.org/13393005/

git-svn-id: http://skia.googlecode.com/svn/trunk@8462 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GM mixed_xfermodes. This is a work in progress and will be used to test fixes...
bsalomon@google.com [Mon, 1 Apr 2013 18:02:55 +0000 (18:02 +0000)]
Add GM mixed_xfermodes. This is a work in progress and will be used to test fixes for GPU Xfermodes effects.
Review URL: https://codereview.chromium.org/13365005

git-svn-id: http://skia.googlecode.com/svn/trunk@8461 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd short option for --bot in submit_try
borenet@google.com [Mon, 1 Apr 2013 17:59:16 +0000 (17:59 +0000)]
Add short option for --bot in submit_try

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13133011

git-svn-id: http://skia.googlecode.com/svn/trunk@8460 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GrGLShaderBuilder responsible for enabling GLSL extensions
bsalomon@google.com [Mon, 1 Apr 2013 17:48:33 +0000 (17:48 +0000)]
Make GrGLShaderBuilder responsible for enabling GLSL extensions
Review URL: https://codereview.chromium.org/12668019

git-svn-id: http://skia.googlecode.com/svn/trunk@8459 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd Xfermode bench. Also clear before rendering in bench (rather than after).
commit-bot@chromium.org [Mon, 1 Apr 2013 12:51:34 +0000 (12:51 +0000)]
Add Xfermode bench. Also clear before rendering in bench (rather than after).

Author: bsalomon@google.com

Reviewed By: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/13334011

git-svn-id: http://skia.googlecode.com/svn/trunk@8454 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTrim the copy of the dst made for dst-reading effects using the clip and dev-bounds...
commit-bot@chromium.org [Mon, 1 Apr 2013 12:49:31 +0000 (12:49 +0000)]
Trim the copy of the dst made for dst-reading effects using the clip and dev-bounds of draw.

Adds dev bounds to circles and rects drawn by GrDrawTarget base class (GrIODB already provides rect bounds).

Author: bsalomon@google.com

Reviewed By: robertphilips@google.com,jvanverth@google.com,robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/13222004

git-svn-id: http://skia.googlecode.com/svn/trunk@8453 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 30 Mar 2013 07:01:27 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8452 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix GLPrograms test.
bsalomon@google.com [Fri, 29 Mar 2013 20:30:50 +0000 (20:30 +0000)]
Fix GLPrograms test.
Review URL: https://codereview.chromium.org/13327008

git-svn-id: http://skia.googlecode.com/svn/trunk@8450 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support for reading the dst pixel value in an effect. Use in a new effect for...
bsalomon@google.com [Fri, 29 Mar 2013 19:22:36 +0000 (19:22 +0000)]
Add support for reading the dst pixel value in an effect. Use in a new effect for the kDarken xfer mode.

The current implementation is to always make a copy of the entire dst before the draw.
It will only succeed if the RT is also a texture.
Obviously, there is lots of room for improvement.
Review URL: https://codereview.chromium.org/13314002

git-svn-id: http://skia.googlecode.com/svn/trunk@8449 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test Commit Queue
commit-bot@chromium.org [Fri, 29 Mar 2013 17:34:33 +0000 (17:34 +0000)]
Whitespace change to test Commit Queue

TBR=borenet

(SkipBuildbotRuns)

Author: rmistry@google.com

Reviewed By:

Review URL: https://chromiumcodereview.appspot.com/13326003

git-svn-id: http://skia.googlecode.com/svn/trunk@8447 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDisplay prompt for caution only if it is an interactive shell.
rmistry@google.com [Fri, 29 Mar 2013 17:26:00 +0000 (17:26 +0000)]
Display prompt for caution only if it is an interactive shell.

Created to fix https://code.google.com/p/skia/issues/detail?id=1197 : Skia Commit Queue quits if the tree is in Caution.

(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13325002

git-svn-id: http://skia.googlecode.com/svn/trunk@8446 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix more clang tautological-constant-out-of-range-compare errors.
tfarina@chromium.org [Fri, 29 Mar 2013 16:53:30 +0000 (16:53 +0000)]
Fix more clang tautological-constant-out-of-range-compare errors.

And one of unused-private-field:
samplecode/SampleStrokeText.cpp:109:10: error: private field 'fAA' is not used [-Werror,-Wunused-private-field]
    bool fAA;

R=bsalomon@google.com,reed@google.com

Review URL: https://codereview.chromium.org/12906016

git-svn-id: http://skia.googlecode.com/svn/trunk@8445 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd matcher to fontstyleset
reed@google.com [Fri, 29 Mar 2013 14:57:22 +0000 (14:57 +0000)]
add matcher to fontstyleset
Review URL: https://codereview.chromium.org/13312002

git-svn-id: http://skia.googlecode.com/svn/trunk@8444 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SkTCast
reed@google.com [Fri, 29 Mar 2013 14:23:56 +0000 (14:23 +0000)]
use SkTCast

git-svn-id: http://skia.googlecode.com/svn/trunk@8443 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix minor cppcheck-found issues
robertphillips@google.com [Fri, 29 Mar 2013 12:11:10 +0000 (12:11 +0000)]
Fix minor cppcheck-found issues

https://codereview.chromium.org/13146005/

git-svn-id: http://skia.googlecode.com/svn/trunk@8440 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 29 Mar 2013 07:01:22 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8439 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GM render to render targets that are also textures.
bsalomon@google.com [Thu, 28 Mar 2013 19:18:12 +0000 (19:18 +0000)]
Make GM render to render targets that are also textures.
Review URL: https://codereview.chromium.org/13211002

git-svn-id: http://skia.googlecode.com/svn/trunk@8438 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger builders to make sure codesite issue is resolved.
rmistry@google.com [Thu, 28 Mar 2013 18:08:05 +0000 (18:08 +0000)]
Whitespace change to trigger builders to make sure codesite issue is resolved.

git-svn-id: http://skia.googlecode.com/svn/trunk@8437 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix iOS compiler error/warning
robertphillips@google.com [Thu, 28 Mar 2013 18:03:27 +0000 (18:03 +0000)]
Fix iOS compiler error/warning

git-svn-id: http://skia.googlecode.com/svn/trunk@8436 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger builders to make sure codesite issue is resolved.
rmistry@google.com [Thu, 28 Mar 2013 17:54:20 +0000 (17:54 +0000)]
Whitespace change to trigger builders to make sure codesite issue is resolved.

git-svn-id: http://skia.googlecode.com/svn/trunk@8435 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAttempt to silence signed/unsigned warnings in android build.
bsalomon@google.com [Thu, 28 Mar 2013 15:11:14 +0000 (15:11 +0000)]
Attempt to silence signed/unsigned warnings in android build.
Review URL: https://codereview.chromium.org/13168003

git-svn-id: http://skia.googlecode.com/svn/trunk@8434 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodisable tests that exercise serialization of fonts here, since we are experimentally
reed@google.com [Thu, 28 Mar 2013 15:03:22 +0000 (15:03 +0000)]
disable tests that exercise serialization of fonts here, since we are experimentally
creating typeface styles that don't know how to serialize yet.

git-svn-id: http://skia.googlecode.com/svn/trunk@8433 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTriggering rebuilds after master restart
rmistry@google.com [Thu, 28 Mar 2013 14:22:58 +0000 (14:22 +0000)]
Triggering rebuilds after master restart

git-svn-id: http://skia.googlecode.com/svn/trunk@8432 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTriggering rebuilds after master restart.
rmistry@google.com [Thu, 28 Mar 2013 14:15:37 +0000 (14:15 +0000)]
Triggering rebuilds after master restart.

git-svn-id: http://skia.googlecode.com/svn/trunk@8431 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd caching to fontmgr for mac
reed@google.com [Thu, 28 Mar 2013 14:12:10 +0000 (14:12 +0000)]
add caching to fontmgr for mac
Review URL: https://codereview.chromium.org/13161002

git-svn-id: http://skia.googlecode.com/svn/trunk@8430 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding unit test for verifying copy on write in SkSurface + bug fix in SkCanvas:...
junov@chromium.org [Thu, 28 Mar 2013 13:49:22 +0000 (13:49 +0000)]
Adding unit test for verifying copy on write in SkSurface + bug fix in SkCanvas::clear
Review URL: https://codereview.chromium.org/13116018

git-svn-id: http://skia.googlecode.com/svn/trunk@8429 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GrGLShaderBuilder::TextureSampler extract only required info from GrTextureAccess.
bsalomon@google.com [Thu, 28 Mar 2013 13:46:42 +0000 (13:46 +0000)]
Make GrGLShaderBuilder::TextureSampler extract only required info from GrTextureAccess.

This will make it possible to init a TextureSampler without a texture or a specific config.

Also unify two separate bitfields of color components in GPU code.
Review URL: https://codereview.chromium.org/13121002

git-svn-id: http://skia.googlecode.com/svn/trunk@8428 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoConvert #warning to comment to get iOS compiling
robertphillips@google.com [Thu, 28 Mar 2013 13:43:16 +0000 (13:43 +0000)]
Convert #warning to comment to get iOS compiling

https://codereview.chromium.org/13157002/

git-svn-id: http://skia.googlecode.com/svn/trunk@8427 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd gm for experimental fontmgr api
reed@google.com [Thu, 28 Mar 2013 13:39:35 +0000 (13:39 +0000)]
add gm for experimental fontmgr api

git-svn-id: http://skia.googlecode.com/svn/trunk@8426 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GrPaint stage for xfermodes.
bsalomon@google.com [Thu, 28 Mar 2013 13:23:29 +0000 (13:23 +0000)]
Add GrPaint stage for xfermodes.
Review URL: https://codereview.chromium.org/12918032

git-svn-id: http://skia.googlecode.com/svn/trunk@8425 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNew filter targeted at desk_googlespreadsheet overdraw issues
robertphillips@google.com [Thu, 28 Mar 2013 12:25:25 +0000 (12:25 +0000)]
New filter targeted at desk_googlespreadsheet overdraw issues

https://codereview.chromium.org/12918029/

git-svn-id: http://skia.googlecode.com/svn/trunk@8424 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTrigger rebuilds on Mac 10.6 compile bots.
rmistry@google.com [Thu, 28 Mar 2013 12:14:12 +0000 (12:14 +0000)]
Trigger rebuilds on Mac 10.6 compile bots.
(RunBuilders:Skia_Mac_Float_Compile_Release_64)

git-svn-id: http://skia.googlecode.com/svn/trunk@8423 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTrigger rebuilds on Mac compile bots.
rmistry@google.com [Thu, 28 Mar 2013 12:06:46 +0000 (12:06 +0000)]
Trigger rebuilds on Mac compile bots.
(RunBuilders:Skia_Mac_Float_Compile_Release_32)

git-svn-id: http://skia.googlecode.com/svn/trunk@8422 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 28 Mar 2013 07:01:15 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8420 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix minor memory leaks
robertphillips@google.com [Wed, 27 Mar 2013 21:31:21 +0000 (21:31 +0000)]
Fix minor memory leaks

https://codereview.chromium.org/12703044/

git-svn-id: http://skia.googlecode.com/svn/trunk@8419 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove dubious assertion.
tfarina@chromium.org [Wed, 27 Mar 2013 21:24:20 +0000 (21:24 +0000)]
Remove dubious assertion.

Clang error report:

../../src/animator/SkDrawBitmap.cpp:89:21: error: comparison of constant 4294967295
with expression of type 'int' is always true [-Werror,-Wtautological-constant-out-of-range-compare]
    SkASSERT(format != (SkBitmap::Config) -1);
                 ~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~

R=bsalomon@google.com,reed@google.com

Review URL: https://codereview.chromium.org/12770023

git-svn-id: http://skia.googlecode.com/svn/trunk@8418 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove typeface cache limit from 128 to 1024 (128 is a joke, not sure what a
reed@google.com [Wed, 27 Mar 2013 20:29:18 +0000 (20:29 +0000)]
move typeface cache limit from 128 to 1024 (128 is a joke, not sure what a
real upper limit should be)

git-svn-id: http://skia.googlecode.com/svn/trunk@8417 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoalways call SkFontMgr::Factory() (now that everyone has impl'd it)
reed@google.com [Wed, 27 Mar 2013 20:12:59 +0000 (20:12 +0000)]
always call SkFontMgr::Factory() (now that everyone has impl'd it)

git-svn-id: http://skia.googlecode.com/svn/trunk@8416 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd dummpy SkFontMgr::Factory() impl to font backends, so we can start testing it
reed@google.com [Wed, 27 Mar 2013 20:01:49 +0000 (20:01 +0000)]
add dummpy SkFontMgr::Factory() impl to font backends, so we can start testing it
Review URL: https://codereview.chromium.org/13119021

git-svn-id: http://skia.googlecode.com/svn/trunk@8415 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove GrGLProgramDesc::Build to new cpp file.
bsalomon@google.com [Wed, 27 Mar 2013 19:50:27 +0000 (19:50 +0000)]
Move GrGLProgramDesc::Build to new cpp file.
Review URL: https://codereview.chromium.org/13097007

git-svn-id: http://skia.googlecode.com/svn/trunk@8414 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix assertion failure in SkGpuDevice from 8412.
bsalomon@google.com [Wed, 27 Mar 2013 18:46:16 +0000 (18:46 +0000)]
Fix assertion failure in SkGpuDevice from 8412.

git-svn-id: http://skia.googlecode.com/svn/trunk@8413 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd interface to SkXfermode to return a GrEffect and blend coeffs.
bsalomon@google.com [Wed, 27 Mar 2013 18:31:15 +0000 (18:31 +0000)]
Add interface to SkXfermode to return a GrEffect and blend coeffs.
Review URL: https://codereview.chromium.org/13097006

git-svn-id: http://skia.googlecode.com/svn/trunk@8412 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove GrGLProgram::Desc out of GrGLProgram.
bsalomon@google.com [Wed, 27 Mar 2013 18:14:57 +0000 (18:14 +0000)]
Move GrGLProgram::Desc out of GrGLProgram.
Review URL: https://codereview.chromium.org/12942014

git-svn-id: http://skia.googlecode.com/svn/trunk@8411 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds
rmistry@google.com [Wed, 27 Mar 2013 17:03:52 +0000 (17:03 +0000)]
Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@8410 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix mask error for BW text, where I forgot to look at just the low-8 bits
reed@google.com [Wed, 27 Mar 2013 15:08:23 +0000 (15:08 +0000)]
fix mask error for BW text, where I forgot to look at just the low-8 bits
of the right mask when computing the number of "full" runs.

possibly related to crbug.com/178796
Review URL: https://codereview.chromium.org/13044012

git-svn-id: http://skia.googlecode.com/svn/trunk@8408 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCTFontManagerCopyAvailableFontFamilyNames is not always available (on iOS)
reed@google.com [Wed, 27 Mar 2013 13:56:34 +0000 (13:56 +0000)]
CTFontManagerCopyAvailableFontFamilyNames is not always available (on iOS)
so write a wrapper for it.

fixes iOS build

git-svn-id: http://skia.googlecode.com/svn/trunk@8406 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 27 Mar 2013 07:01:04 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@8404 2bbb7eff-a529-9590-31e7-b0007b416f81