Alyssa Rosenzweig [Tue, 1 Aug 2023 16:17:17 +0000 (12:17 -0400)]
nir: Drop trivial reg handling
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:13:17 +0000 (12:13 -0400)]
treewide: Drop some is_ssa if's
Via Coccinelle patch:
@@
expression x;
@@
-if (!x.is_ssa) {
-...
-}
and likewise with x->is_ssa, with invalid hunks manually filtered out.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:10:24 +0000 (12:10 -0400)]
pan/mdg: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:07:25 +0000 (12:07 -0400)]
treewide: sed out more is_ssa
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:55:12 +0000 (11:55 -0400)]
nir: Drop nir_alu_src::{negate,abs}
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:51:55 +0000 (11:51 -0400)]
nir/print: Drop legacy NIR
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:46:42 +0000 (11:46 -0400)]
nir: Remove stale todo
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:45:49 +0000 (11:45 -0400)]
nir: Remove reg-only dest manipulation
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:36:45 +0000 (11:36 -0400)]
treewide: Remove more is_ssa asserts
Stuff Coccinelle missed.
sed -i -e '/assert(.*\.is_ssa)/d' $(git grep -l is_ssa)
sed -i -e '/ASSERT.*\.is_ssa)/d' $(git grep -l is_ssa)
+ a manual fixup to restore the assert for parallel copy lowering.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:29:43 +0000 (11:29 -0400)]
nir: Collapse some SSA checks
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:17:24 +0000 (11:17 -0400)]
treewide: Drop is_ssa asserts
We only see SSA now.
Via Coccinelle patch:
@@
expression x;
@@
-assert(x.is_ssa);
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:05:53 +0000 (11:05 -0400)]
nir: Remove nir_alu_dest::saturate
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:03:10 +0000 (11:03 -0400)]
nir: Remove impl->{registers,reg_alloc}
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:02:13 +0000 (11:02 -0400)]
nir/validate: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 15:00:23 +0000 (11:00 -0400)]
nir/serialize: Drop legacy NIR
Assume SSA, no modifiers.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:55:28 +0000 (10:55 -0400)]
nir/clone: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:53:43 +0000 (10:53 -0400)]
nir/print: Assume SSA
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:52:04 +0000 (10:52 -0400)]
ntt: Drop nir_register reference
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:51:04 +0000 (10:51 -0400)]
nir: remove nir_{src,dest}_for_reg
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:49:48 +0000 (10:49 -0400)]
nir: Remove nir_foreach_register
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:49:23 +0000 (10:49 -0400)]
nir/schedule: Drop more nir_register handling
No-op.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:48:27 +0000 (10:48 -0400)]
nir: Remove nir_index_local_regs and callers
With no registers seen, it is now a no-op.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:46:53 +0000 (10:46 -0400)]
nir: Drop NIR reg create/destroy
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:38:47 +0000 (10:38 -0400)]
nir/schedule: Drop nir_schedule_dest_pressure
Unused.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 14:36:56 +0000 (10:36 -0400)]
nir/from_ssa: Drop legacy reg support
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Alyssa Rosenzweig [Tue, 1 Aug 2023 19:00:41 +0000 (15:00 -0400)]
nir: Add {...} before case
Will prevent a clang regression.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24432>
Yonggang Luo [Wed, 2 Aug 2023 11:24:14 +0000 (19:24 +0800)]
intel/compiler,intel/blorp,intel/vulkan: decouple vulkan driver and compiler from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
Yonggang Luo [Wed, 2 Aug 2023 11:41:53 +0000 (19:41 +0800)]
crocus: #include "program/prog_instruction.h" for SWIZZLE_*
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
Yonggang Luo [Wed, 2 Aug 2023 11:36:27 +0000 (19:36 +0800)]
intel/brw: Define and use BRW_SWIZZLE_* instead of SWIZZLE_*
This is for avoid #include "program/prog_instrunction.h" in intel/brw code
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
Yonggang Luo [Wed, 2 Aug 2023 11:12:12 +0000 (19:12 +0800)]
intel/blorp: brw_sampler_prog_key_data::swizzles is only and should only accessed in crocus
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
Yonggang Luo [Wed, 2 Aug 2023 11:10:49 +0000 (19:10 +0800)]
intel/blorp: Use float directly to avoid #include "mesa/main/format_utils.h"
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
Yonggang Luo [Wed, 2 Aug 2023 07:08:33 +0000 (15:08 +0800)]
compiler: Move WRITEMASK_* from prog_instruction.h into shader_enums.h
Because both compiler/glsl/* and intel/compiler accessed it, so do the move
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24438>
David Heidelberg [Thu, 3 Aug 2023 05:11:07 +0000 (08:11 +0300)]
bin/ci: handle errors more gracefully in update_traces_checksum script
UnicodeDecodeError is present very often, since GitLab logs are scary.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24444>
Faith Ekstrand [Wed, 2 Aug 2023 16:58:38 +0000 (11:58 -0500)]
nir/builder: Don't assume we have compiler options
We use nir_builder a variety of places where we may not yet have
back-end compiler options such as for building meta shaders. Don't
assume we always have an options struct.
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24459>
xurui [Fri, 28 Jul 2023 07:57:10 +0000 (15:57 +0800)]
glx: There is no need to psc++
Signed-off-by: xurui <xurui@kylinos.cn>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24360>
Felix DeGrood [Fri, 7 Jul 2023 17:15:01 +0000 (17:15 +0000)]
anv: debug messaging for sparse texture usage
Enable sparse debug messages with INTEL_DEBUG=sparse
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24046>
Felix DeGrood [Fri, 7 Jul 2023 17:48:00 +0000 (17:48 +0000)]
anv: enable fake sparse for Elden Ring
Elden Ring requires sparse support to be advertised but does not
use the feature. Enable fake sparse support for Elden Ring through
dri-conf.
This change fixes Elden Ring on Intel graphics.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24046>
Felix DeGrood [Fri, 7 Jul 2023 20:21:01 +0000 (20:21 +0000)]
anv: add fake sparse support
Some DX12 games require sparse resource support but don't
actually use sparse resources. Add a way to make these games work
while we still don't have sparse resources fully working on every
KMD backend.
When fake_sparse=true, anv advertises sparse resource support
despite lacking full support.
Based-on-patch-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24046>
Yonggang Luo [Sun, 4 Jun 2023 20:46:32 +0000 (04:46 +0800)]
asahi: decouple layout from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24465>
Yonggang Luo [Sun, 4 Jun 2023 20:46:07 +0000 (04:46 +0800)]
etnaviv: decouple drm from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24465>
Eric Engestrom [Thu, 3 Aug 2023 14:54:27 +0000 (15:54 +0100)]
docs/ci: expand the description of test suites
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24472>
Eric Engestrom [Thu, 3 Aug 2023 13:13:02 +0000 (14:13 +0100)]
docs/ci: drop mention of build systems variants in the CI
We managed to get rid of all the other ones, so let's forget about them
now :P
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24472>
Eric Engestrom [Thu, 3 Aug 2023 13:13:02 +0000 (14:13 +0100)]
docs/ci: in paragraph about the CI being overwhelmed, mention our tool to help with that
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24472>
Eric Engestrom [Thu, 3 Aug 2023 13:13:02 +0000 (14:13 +0100)]
docs/ci: stop trying to enumerate drivers that are tested using VK-GL-CTS
Most of our drivers are tested by now.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24472>
Eric Engestrom [Wed, 2 Aug 2023 15:48:53 +0000 (16:48 +0100)]
ci: include some timing information in the git cache download script
In https://gitlab.freedesktop.org/zmike/mesa/-/jobs/
46476087 it is unclear
whether this script is where 30+ minutes were lost, or if this ran fine and
the `git clone` afterwards is where the issue was.
Printing these timestamps will help next time something like this happens.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24452>
David Heidelberg [Tue, 1 Aug 2023 20:40:39 +0000 (23:40 +0300)]
docs/ci: remove default nginx config, which we don't need for proxy
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24445>
David Heidelberg [Tue, 1 Aug 2023 20:39:37 +0000 (23:39 +0300)]
docs/ci: update to systemd and used version of the trace for testing
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24445>
David Heidelberg [Tue, 1 Aug 2023 20:37:46 +0000 (23:37 +0300)]
docs/ci: default to port 80 for the caching proxy
Also use `caching-proxy` as a name which is automatically
generated from `NFS_SERVER_IP`.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24445>
David Heidelberg [Thu, 3 Aug 2023 12:22:53 +0000 (15:22 +0300)]
ci/amd: fix timeouting radeonsi-raven-va-full job
LAVA needs to know that job will run more than default 30 minutes.
Fixes:
ae9c67d773a7 ("ci/amd: add radeonsi-raven-va-full job to cover all VA-API tests")
Reviewed-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24469>
David Rosca [Sun, 30 Jul 2023 10:55:16 +0000 (12:55 +0200)]
radeonsi: Enable PIPE_VIDEO_CAP_SUPPORTS_CONTIGUOUS_PLANES_MAP
This is needed for vaDeriveImage to map multi-plane surfaces.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7947
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24389>
David Rosca [Sun, 30 Jul 2023 10:39:15 +0000 (12:39 +0200)]
radeonsi: Copy all planes with multi-plane staging textures
Multi-plane format textures are allocated as a single buffer
for all planes, so when mapping first plane it will map
all planes.
However, when staging texture is used, only the first
plane will be available.
When asked to map first plane of multi-plane texture,
create a staging texture with matching multi-plane format
and copy all planes on map/unmap.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24389>
Alyssa Rosenzweig [Tue, 1 Aug 2023 16:22:39 +0000 (12:22 -0400)]
zink: Collapse is_ssa check
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24471>
Alyssa Rosenzweig [Tue, 1 Aug 2023 18:14:13 +0000 (14:14 -0400)]
vc4,broadcom/compiler: Drop write_mask handling
There's no legacy register support so we ncessarily write a contiguous vector.
In other words, the write_mask is of the form `(1 << x) - 1`. Meanwhile this
code asserts the write mask is of the form (1 << x)`. Putting it together the
write mask is necessarily always 0x1, writing out a single scalar.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24471>
Alyssa Rosenzweig [Tue, 1 Aug 2023 18:40:58 +0000 (14:40 -0400)]
nouveau/codegen: Drop writemask check
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: M Henning <drawoc@darkrefraction.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24471>
Alyssa Rosenzweig [Tue, 1 Aug 2023 18:34:58 +0000 (14:34 -0400)]
r600/sfn: Ignore instruction write masks
It's all SSA so this is redundant.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24471>
Alyssa Rosenzweig [Tue, 1 Aug 2023 18:05:43 +0000 (14:05 -0400)]
r600/sfn: Stop referencing legacy functionality
It's unused now, just need the references to it dropped so we'll still build
when it's all removed.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24471>
David Rosca [Sat, 29 Jul 2023 11:38:17 +0000 (13:38 +0200)]
frontends/va: Init view_resources array in vlVaPut/GetImage
Fixes crash when VA format num_planes > surface num_planes.
Fixes:
975a8ecc881 ("frontends/va: use resources instead of views")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9377
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24381>
David Rosca [Wed, 2 Aug 2023 07:58:51 +0000 (09:58 +0200)]
frontends/va: Don't allow multi-plane derive without driver support
Mapping multi-plane surfaces won't work correctly without driver
supporting PIPE_VIDEO_CAP_SUPPORTS_CONTIGUOUS_PLANES_MAP.
Remove the check for ffmpeg process and instead check for
multi-plane format and driver support only.
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24381>
Mike Blumenkrantz [Fri, 24 Feb 2023 19:13:24 +0000 (14:13 -0500)]
lavapipe: VK_EXT_host_image_copy
Acked-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24278>
Mike Blumenkrantz [Fri, 24 Feb 2023 18:56:10 +0000 (13:56 -0500)]
lavapipe: be slightly more permissive for bad apps (and cts) with dynrender
this is stupid, but it makes the default color output "write the output"
instead of zero, which is still wrong, but at least maybe it's wrong
in a way that's useful instead of just being confusing
Acked-by: Konstantin Seurer <konstantin.seurer@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24278>
Yonggang Luo [Sun, 4 Jun 2023 20:45:34 +0000 (04:45 +0800)]
ac/radv: decouple radv vulkan driver and compiler from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24464>
Yonggang Luo [Sun, 4 Jun 2023 20:23:38 +0000 (04:23 +0800)]
nouveau/drm-shim: Decouple from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24463>
Jordan Justen [Wed, 2 Aug 2023 16:44:25 +0000 (09:44 -0700)]
intel/tools: Use 'env bash' to find bash executable
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24453>
Yonggang Luo [Thu, 3 Aug 2023 06:42:37 +0000 (14:42 +0800)]
meson: Remove arm_neon_workaround
Suddenly found this workaround doesn't need anymore
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24461>
Yonggang Luo [Sun, 4 Jun 2023 20:59:16 +0000 (04:59 +0800)]
glx: decouple from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23438>
Yonggang Luo [Sun, 4 Jun 2023 20:44:55 +0000 (04:44 +0800)]
freedreno: decouple compiler and vulkan driver from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23438>
Yonggang Luo [Sun, 4 Jun 2023 20:43:53 +0000 (04:43 +0800)]
pvr: decouple vulkan driver and compiler from gallium
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-By: Matt Coster <matt.coster@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23438>
Iago Toral Quiroga [Mon, 31 Jul 2023 08:32:43 +0000 (10:32 +0200)]
broadcom/compiler: drop execution environment from the shader key
We are no longer using this for anything.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Mon, 31 Jul 2023 08:26:55 +0000 (10:26 +0200)]
broadcom/compiler: always clamp results from logic ops
We have also been clamping our integer RTs in GL for a while now.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Mon, 31 Jul 2023 08:29:51 +0000 (10:29 +0200)]
v3dv: don't set lower_wpos_pntc for Vulkan
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Mon, 31 Jul 2023 07:48:00 +0000 (09:48 +0200)]
broadcom/compiler: move vulkan's point coord lowering to the driver
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Mon, 31 Jul 2023 07:21:52 +0000 (09:21 +0200)]
broadcom/compiler: move uniform offset lowering from compiler to GL driver
We only need this in GL so move it there.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Thu, 27 Jul 2023 07:59:48 +0000 (09:59 +0200)]
broadcom/compiler: use NIR's lowering for dispatch base
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Thu, 27 Jul 2023 04:56:48 +0000 (06:56 +0200)]
broadcom/compiler: stop asserting on Vulkan environment
The idea is to eventually get rid of key->environment.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Tue, 1 Aug 2023 09:43:15 +0000 (11:43 +0200)]
v3dv: fix incorrect key setup
We had this incorrectly included inside the body of loop over
the subpass attachments so when all attachments are unused we
would not set this correctly.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Thu, 27 Jul 2023 08:48:05 +0000 (10:48 +0200)]
nir/lower_robustness: drop skip_ubo_0 option
v3dv was the only user and it no longer requires this.
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Iago Toral Quiroga [Thu, 27 Jul 2023 04:53:44 +0000 (06:53 +0200)]
v3dv: stop incrementing UBO indices by one
This matches what we do for OpenGL, allowing us to
have the same compiler behavior for both worlds.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24396>
Samuel Pitoiset [Wed, 26 Jul 2023 11:01:42 +0000 (13:01 +0200)]
radv: add radv_graphics_shaders_compile() to compile graphics shaders
Similar to radv_compile_cs() but for all graphics stages.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24423>
Samuel Pitoiset [Tue, 1 Aug 2023 08:04:25 +0000 (10:04 +0200)]
radv: add a struct for the retained shaders and GPL
This will be used to remove the pipeline dependency completely when
compiling graphics shaders.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24423>
Samuel Pitoiset [Wed, 26 Jul 2023 10:47:27 +0000 (12:47 +0200)]
radv: inline radv_pipeline_get_nir() in radv_graphics_pipeline_compile()
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24423>
Samuel Pitoiset [Tue, 25 Jul 2023 11:25:16 +0000 (13:25 +0200)]
radv: stop passing a graphics pipeline to radv_pipeline_nir_to_asm()
Also rename the function.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24423>
Samuel Pitoiset [Tue, 25 Jul 2023 11:14:26 +0000 (13:14 +0200)]
radv: remove unnecessary check in radv_pipeline_nir_to_asm()
If a NIR stage is present, there shouldn't be any compiled binaries
in the same stage slot.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24423>
Jordan Justen [Wed, 29 Jun 2022 06:22:28 +0000 (23:22 -0700)]
intel/dev: Support xe2 device init (for intel_device_info_test)
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24419>
Jordan Justen [Tue, 28 Jun 2022 18:54:41 +0000 (11:54 -0700)]
intel/dev: Add LNL platform enum
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24421>
Dave Airlie [Wed, 2 Aug 2023 02:17:27 +0000 (12:17 +1000)]
llvmpipe: fix fragdata/lastfragdata heuristic a bit more.
This heuristic broke when zmike lowered fragcolor using NIR,
This fixes a regression in:
dEQP-GLES31.functional.shaders.framebuffer_fetch.basic.last_frag_data
Fixes:
db1371cce1d4 ("llvmpipe: fix handling of unused color attachments")
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24435>
Eric Engestrom [Wed, 2 Aug 2023 19:39:53 +0000 (20:39 +0100)]
docs: update calendar for 23.1.5
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24455>
Eric Engestrom [Wed, 2 Aug 2023 19:39:39 +0000 (20:39 +0100)]
docs: add sha256sum for 23.1.5
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24455>
Eric Engestrom [Wed, 2 Aug 2023 19:34:12 +0000 (20:34 +0100)]
docs: add release notes for 23.1.5
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24455>
Gert Wollny [Tue, 1 Aug 2023 08:33:55 +0000 (10:33 +0200)]
r600/sfn: AR loads should depend on all previous non ALU instructions
These instructions could be re-ordered, so depending just on the last one
is not sufficient.
Fixes:
d21054b4bc92a1a9240841dca719f81a142fd5cc
r600/sfn: Add pass to split address and index register loads
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24454>
Gert Wollny [Tue, 1 Aug 2023 08:29:34 +0000 (10:29 +0200)]
r600/sfn: Only switch to other CF if no AR uses are pending
Otherwise we end up with an incorrect array load (or an assertion failure).
Fixes:
d617052db6b2f359d7242875013603ec63b069fc
r600/sfn: take address loads into account when scheduling
Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24454>
Eric Engestrom [Wed, 2 Aug 2023 14:12:24 +0000 (15:12 +0100)]
ci: drop rule for non-existent src/include/
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24449>
Eric Engestrom [Wed, 2 Aug 2023 14:06:35 +0000 (15:06 +0100)]
ci: add .core-rules to .gallium-core-rules
All the users of the latter were already getting the former through
other rules so there's no functional change, but it's more correct.
Signed-off-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24449>
Samuel Pitoiset [Mon, 31 Jul 2023 14:19:52 +0000 (16:19 +0200)]
radv: add support for emitting TCS epilogs in cmdbuf
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Mon, 31 Jul 2023 13:49:25 +0000 (15:49 +0200)]
radv: add support for a TCS epilogs cache in the device
Similar to VS prologs and PS epilogs.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Wed, 2 Aug 2023 13:17:08 +0000 (15:17 +0200)]
radv: add infra for creating TCS epilogs
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Mon, 31 Jul 2023 13:54:27 +0000 (15:54 +0200)]
radv: add radv_tcs_epilog_key
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Mon, 31 Jul 2023 14:15:27 +0000 (16:15 +0200)]
radv: declare new argument for the TCS epilog PC
To jump to the TCS epilog.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Mon, 31 Jul 2023 16:12:01 +0000 (18:12 +0200)]
radv: track if TES reads tess factors differently
This information will be passed through the TCS epilog key.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Mon, 31 Jul 2023 14:24:08 +0000 (16:24 +0200)]
radv: do not write tess factors in main TCS when it has an epilog
Tess factors will be written by TCS epilogs.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>
Samuel Pitoiset [Wed, 2 Aug 2023 06:54:43 +0000 (08:54 +0200)]
radv: assume a TCS needs an epilog unless it's linked with a TES
For shader object.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24404>