platform/upstream/glibc.git
4 years agohtl: Only check pthread_self coherency when DEBUG is set
Samuel Thibault [Sat, 15 Feb 2020 14:31:50 +0000 (14:31 +0000)]
htl: Only check pthread_self coherency when DEBUG is set

htl has been widely tested for a long time now with this coherency
checked successfully.

4 years agohurd: Add THREAD_GET/SETMEM/_NC
Samuel Thibault [Sat, 15 Feb 2020 13:04:02 +0000 (05:04 -0800)]
hurd: Add THREAD_GET/SETMEM/_NC

Store them in the TCB, and use them for accessing _hurd_sigstate.

4 years agohurd tls: update comment about fields at the end of tcbhead
Samuel Thibault [Sat, 15 Feb 2020 12:56:44 +0000 (04:56 -0800)]
hurd tls: update comment about fields at the end of tcbhead

4 years agold.so: Do not export free/calloc/malloc/realloc functions [BZ #25486]
Florian Weimer [Sat, 8 Feb 2020 18:58:43 +0000 (19:58 +0100)]
ld.so: Do not export free/calloc/malloc/realloc functions [BZ #25486]

Exporting functions and relying on symbol interposition from libc.so
makes the choice of implementation dependent on DT_NEEDED order, which
is not what some compiler drivers expect.

This commit replaces one magic mechanism (symbol interposition) with
another one (preprocessor-/compiler-based redirection).  This makes
the hand-over from the minimal malloc to the full malloc more
explicit.

Removing the ABI symbols is backwards-compatible because libc.so is
always in scope, and the dynamic loader will find the malloc-related
symbols there since commit f0b2132b35248c1f4a80f62a2c38cddcc802aa8c
("ld.so: Support moving versioned symbols between sonames
[BZ #24741]").

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
4 years agoRemove weak declaration of free from <inline-hashtab.h>
Florian Weimer [Sat, 8 Feb 2020 15:15:09 +0000 (16:15 +0100)]
Remove weak declaration of free from <inline-hashtab.h>

elf/dl-minimal.c provides a definition of free, so the function
pointer is always non-null, even before the final relocation
of the loader.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
4 years agoelf: Extract _dl_sym_post, _dl_sym_find_caller_map from elf/dl-sym.c
Florian Weimer [Sat, 8 Feb 2020 14:00:28 +0000 (15:00 +0100)]
elf: Extract _dl_sym_post, _dl_sym_find_caller_map from elf/dl-sym.c

The definitions are moved into a new file, elf/dl-sym-post.h, so that
this code can be used by the dynamic loader as well.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
4 years agoelf: Introduce the rtld-stubbed-symbols makefile variable
Florian Weimer [Fri, 7 Feb 2020 19:06:32 +0000 (20:06 +0100)]
elf: Introduce the rtld-stubbed-symbols makefile variable

This generalizes a mechanism used for stack-protector support, so
that it can be applied to other symbols if required.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
4 years agoarm: fix use of INTERNAL_SYSCALL_CALL
Andreas Schwab [Sat, 15 Feb 2020 09:21:20 +0000 (10:21 +0100)]
arm: fix use of INTERNAL_SYSCALL_CALL

Remove extra argument from INTERNAL_SYSCALL_CALL macro call.  Fixes
commit bc2eb9321e ("linux: Remove INTERNAL_SYSCALL_DECL").

4 years agolinux: Remove INTERNAL_SYSCALL_DECL
Adhemerval Zanella [Wed, 29 Jan 2020 20:38:36 +0000 (20:38 +0000)]
linux: Remove INTERNAL_SYSCALL_DECL

With all Linux ABIs using the expected Linux kABI to indicate
syscalls errors, the INTERNAL_SYSCALL_DECL is an empty declaration
on all ports.

This patch removes the 'err' argument on INTERNAL_SYSCALL* macro
and remove the INTERNAL_SYSCALL_DECL usage.

Checked with a build against all affected ABIs.

4 years agonptl: Remove ununsed pthread-errnos.h rule
Adhemerval Zanella [Mon, 10 Feb 2020 18:16:28 +0000 (18:16 +0000)]
nptl: Remove ununsed pthread-errnos.h rule

4 years agolinux: Consolidate INLINE_SYSCALL
Adhemerval Zanella [Wed, 29 Jan 2020 17:36:58 +0000 (17:36 +0000)]
linux: Consolidate INLINE_SYSCALL

With all Linux ABIs using the expected Linux kABI to indicate
syscalls errors, there is no need to replicate the INLINE_SYSCALL.

The generic Linux sysdep.h includes errno.h even for !__ASSEMBLER__,
which is ok now and it allows cleanup some archaic code that assume
otherwise.

Checked with a build against all affected ABIs.

4 years agos390: Consolidate Linux syscall definition
Adhemerval Zanella [Mon, 10 Feb 2020 14:32:40 +0000 (11:32 -0300)]
s390: Consolidate Linux syscall definition

The {INTERNAL,INLINE}_SYSCALL are defined only on s390 sysdep.h.

Checked on s390x-linux-gnu and s390-linux-gnu.

4 years agoriscv: Avoid clobbering register parameters in syscall
Adhemerval Zanella [Mon, 10 Feb 2020 13:32:14 +0000 (10:32 -0300)]
riscv: Avoid clobbering register parameters in syscall

The riscv INTERNAL_SYSCALL macro might clobber the register
parameter if the argument itself might clobber any register (a function
call for instance).

This patch fixes it by using temporary variables for the expressions
between the register assignments (as indicated by GCC documentation,
6.47.5.2 Specifying Registers for Local Variables).

It is similar to the fix done for MIPS (bug 25523).

Checked with riscv64-linux-gnu-rv64imafdc-lp64d build.

4 years agomicroblaze: Avoid clobbering register parameters in syscall
Adhemerval Zanella [Mon, 10 Feb 2020 13:19:29 +0000 (10:19 -0300)]
microblaze: Avoid clobbering register parameters in syscall

The microblaze INTERNAL_SYSCALL macro might clobber the register
parameter if the argument itself might clobber any register (a function
call for instance).

This patch fixes it by using temporary variables for the expressions
between the register assignments (as indicated by GCC documentation,
6.47.5.2 Specifying Registers for Local Variables).

It is similar to the fix done for MIPS (bug 25523).

Checked with microblaze-linux-gnu and microblazeel-linux-gnu build.

4 years agonios2: Use Linux kABI for syscall return
Adhemerval Zanella [Mon, 3 Feb 2020 15:00:19 +0000 (12:00 -0300)]
nios2: Use Linux kABI for syscall return

It changes the nios INTERNAL_SYSCALL_RAW macro to return a negative
value instead of the 'r2' register value on the 'err' macro argument.

The macro INTERNAL_SYSCALL_DECL is no longer required, and the
INTERNAL_SYSCALL_ERROR_P macro follows the other Linux kABIs.

Checked with a build against nios2-linux-gnu.

4 years agomips: Use Linux kABI for syscall return
Adhemerval Zanella [Mon, 3 Feb 2020 14:52:43 +0000 (11:52 -0300)]
mips: Use Linux kABI for syscall return

It changes the mips INTERNAL_SYSCALL* and internal_syscall*  macros
to return a negative value instead of the 'a3' register value on then
'err' macro argument.

The macro INTERNAL_SYSCALL_DECL is no longer required, and the
INTERNAL_SYSCALL_ERROR_P macro follows the other Linux kABIs.
The redefinition of INTERNAL_VSYSCALL_CALL is also no longer
required.

Checked on mips64-linux-gnu, mips64n32-linux-gnu, and mips-linux-gnu.

4 years agomips64: Consolidate Linux sysdep.h
Adhemerval Zanella [Mon, 3 Feb 2020 14:13:18 +0000 (11:13 -0300)]
mips64: Consolidate Linux sysdep.h

The mips64 Linux syscall macros only differs argument type and
the requirement of sign-extending values on n32.  The headers
are consolidate by parameterizing the arguments with a new type,
__syscall_arg_t, and by defining the ARGIFY for n64.

Also, the generic unix mips64 sysdep is essentially the same,
only the load instruction need to be adjusted depending of the
ABI.

Checked on mips64-linux-gnu and mips64n32-linux-gnu.

4 years agoia64: Use Linux kABI for syscall return
Adhemerval Zanella [Mon, 3 Feb 2020 00:03:28 +0000 (21:03 -0300)]
ia64: Use Linux kABI for syscall return

It changes the ia64 INTERNAL_SYSCALL_NCS macro to return a negative
value instead of the 'r10' register value on the 'err' macro argument.

The macro INTERNAL_SYSCALL_DECL is no longer required, and the
INTERNAL_SYSCALL_ERROR_P macro follows the other Linux kABIs.

Checked on ia64-linux-gnu.

4 years agoalpha: Refactor syscall and Use Linux kABI for syscall return
Adhemerval Zanella [Fri, 31 Jan 2020 19:41:25 +0000 (19:41 +0000)]
alpha: Refactor syscall and Use Linux kABI for syscall return

It highly unlikely that alpha will be ported to anything else than
Linux, so this patch moves the generic unix syscall definition to
Linux and adapt it to Linux kernel ABI.

It changes the internal_syscall* macros to return a negative value
instead of the '$19' register value on the 'err' macro argument.

The macro INTERNAL_SYSCALL_DECL is no longer required, and the
INTERNAL_SYSCALL_ERROR_P macro follows the other Linux kABIs.

Checked on alpha-linux-gnu.

4 years agosparc: Avoid clobbering register parameters in syscall
Adhemerval Zanella [Mon, 10 Feb 2020 15:57:28 +0000 (12:57 -0300)]
sparc: Avoid clobbering register parameters in syscall

The sparc INTERNAL_SYSCALL macro might clobber the register
parameter if the argument itself might clobber any register (a function
call for instance).

This patch fixes it by using temporary variables for the expressions
between the register assignments (as indicated by GCC documentation,
6.47.5.2 Specifying Registers for Local Variables).

It is similar to the fix done for MIPS (bug 25523).

Checked on sparc64-linux-gnu and sparcv9-linux-gnu.

4 years agosparc: Use Linux kABI for syscall return
Adhemerval Zanella [Tue, 28 Jan 2020 22:33:01 +0000 (19:33 -0300)]
sparc: Use Linux kABI for syscall return

It changes the sparc internal_syscall* macros to return a negative
value instead of the 'g1' register value in the 'err' macro argument.
The __SYSCALL_STRING macro is also changed to no set the 'g1'
value, since 'o1' already holds all the required information
to check if syscall has failed.

The macro INTERNAL_SYSCALL_DECL is no longer required, and the
INTERNAL_SYSCALL_ERROR_P macro follows the other Linux kABIs.
The redefinition of INTERNAL_VSYSCALL_CALL is also no longer
required.

Checked on sparc64-linux-gnu and sparcv9-linux-gnu. It fixes
the sporadic issues on sparc32 where clock_nanosleep does not
act as cancellation entrypoint.

4 years agopowerpc: Use Linux kABI for syscall return
Adhemerval Zanella [Sun, 2 Feb 2020 23:45:58 +0000 (20:45 -0300)]
powerpc: Use Linux kABI for syscall return

It changes the powerpc INTERNAL_VSYSCALL_CALL and INTERNAL_SYSCALL_NCS
to return a negative value instead of the returning the CR value in
the 'err' macro argument.

The macro INTERNAL_SYSCALL_DECL is no longer required, and the
INTERNAL_SYSCALL_ERROR_P macro follows the other Linux kABIs.

Checked on powerpc64-linux-gnu, powerpc64le-linux-gnu, and
powerpc-linux-gnu-power4.

4 years agopowerpc: Consolidate Linux syscall definition
Adhemerval Zanella [Thu, 30 Jan 2020 19:13:31 +0000 (19:13 +0000)]
powerpc: Consolidate Linux syscall definition

The diferences between powerpc64{le} and powerpc32 Linux sysdep.h
are:

  1. On both vDSO and syscall macros the volatile registers r9, r10,
     r11, and r12 are used as input operands on powerpc32 and as
     clobber registers on powerpc64.  However the outcome is essentially
     the same, it advertise the register might be clobbered by the
     kernel (although Linux won't leak register information to userland
     in such case).

  2. The LOADARGS* macros uses a different size to check for invalid
     types.

  3. The pointer mangling support guard pointer loading uses ABI
     specific instruction and register.

This patch consolidates on only one sysdep by using the the powerpc64
version as default and add the adjustments required for powerpc32.

Checked on powerpc64-linux-gnu, powerpc64le-linux-gnu, and
powerpc-linux-gnu-power4.

4 years agoi386: Enable CET support in ucontext functions
H.J. Lu [Fri, 14 Feb 2020 22:45:34 +0000 (14:45 -0800)]
i386: Enable CET support in ucontext functions

1. getcontext and swapcontext are updated to save the caller's shadow
stack pointer and return address.
2. setcontext and swapcontext are updated to restore shadow stack and
jump to new context directly.
3. makecontext is updated to allocate a new shadow stack and set the
caller's return address to the helper code, L(exitcode).
4. Since we no longer save and restore EAX, ECX and EDX in getcontext,
setcontext and swapcontext, we can use them as scratch register slots
to enable CET in ucontext functions.

Since makecontext allocates a new shadow stack when making a new
context and kernel allocates a new shadow stack for clone/fork/vfork
syscalls, we track the current shadow stack base.  In setcontext and
swapcontext, if the target shadow stack base is the same as the current
shadow stack base, we unwind the shadow stack.  Otherwise it is a stack
switch and we look for a restore token.

We enable shadow stack at run-time only if program and all used shared
objects, including dlopened ones, are shadow stack enabled, which means
that they must be compiled with GCC 8 or above and glibc 2.28 or above.
We need to save and restore shadow stack only if shadow stack is enabled.
When caller of getcontext, setcontext, swapcontext and makecontext is
compiled with smaller ucontext_t, shadow stack won't be enabled at
run-time.  We check if shadow stack is enabled before accessing the
extended field in ucontext_t.

Tested on i386 CET/non-CET machines.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
4 years agotst-clone3: Use __NR_futex_time64 if we don't have __NR_futex
Alistair Francis [Mon, 11 Nov 2019 23:07:19 +0000 (15:07 -0800)]
tst-clone3: Use __NR_futex_time64 if we don't have __NR_futex

We can't include sysdep.h in the test case (it introduces lots of
strange failures) so __NR_futex isn't redifined to __NR_futex_time64 by
64-bit time_t 32-bit archs (y2038 safe).

To allow the test to pass let's just do the __NR_futex_time64 syscall if
we don't have __NR_futex defined.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
4 years agopowerpc64: Add memory protection key support [BZ #23202]
Florian Weimer [Fri, 14 Feb 2020 19:55:39 +0000 (20:55 +0100)]
powerpc64: Add memory protection key support [BZ #23202]

The 32-bit protection key behavior is somewhat unclear on 32-bit powerpc,
so this change is restricted to the 64-bit variants.

Flag translation is needed because of hardware differences between the
POWER implementation (read and write flags) and the Intel implementation
(write and read+write flags).

4 years agoldbl-128ibm-compat: Provide a scalb implementation
Tulio Magno Quites Machado Filho [Mon, 18 Jun 2018 22:02:08 +0000 (19:02 -0300)]
ldbl-128ibm-compat: Provide a scalb implementation

Reuse the template in order to provide the redirect for
scalbl to __scalbieee128, but avoid any extra aliasing
as this is intended to support long double redirects only.

4 years agoAdd a generic scalb implementation
Tulio Magno Quites Machado Filho [Tue, 29 May 2018 20:52:24 +0000 (17:52 -0300)]
Add a generic scalb implementation

This is a preparatory patch to enable building a _Float128
variant to ease reuse when building a _Float128 variant to
alias this long double only symbol.

Notably, stubs are added where missing to the native _Float128
sysdep dir to prevent building these newly templated variants
created inside the build directories.

Also noteworthy are the changes around LIBM_SVID_COMPAT.  These
changes are not intuitive.  The templated version is only
enabled when !LIBM_SVID_COMPAT, and the compat version is
predicated entirely on LIBM_SVID_COMPAT.  Thus, exactly one is
stubbed out entirely when building.  The nldbl scalb compat
files are updated to account for this.

Likewise, fixup the reuse of m68k's e_scalb{f,l}.c to include
it's override of e_scalb.c.  Otherwise, the search path finds
the templated copy in the build directory.  This could be
futher simplified by providing an overridden template, but I
lack the hardware to verify.

4 years agoAdjust thresholds in Bessel function implementations (bug 14469).
Joseph Myers [Fri, 14 Feb 2020 14:16:25 +0000 (14:16 +0000)]
Adjust thresholds in Bessel function implementations (bug 14469).

A recent discussion in bug 14469 notes that a threshold in float
Bessel function implementations, used to determine when to use a
simpler implementation approach, results in substantially inaccurate
results.

As I discussed in
<https://sourceware.org/ml/libc-alpha/2013-03/msg00345.html>, a
heuristic argument suggests 2^(S+P) as the right order of magnitude
for a suitable threshold, where S is the number of significand bits in
the floating-point type and P is the number of significant bits in the
representation of the floating-point type, and the float and ldbl-96
implementations use thresholds that are too small.  Some threshold
does need using, there or elsewhere in the implementation, to avoid
spurious underflow and overflow for large arguments.

This patch sets the thresholds in the affected implementations to more
heuristically justifiable values.  Results will still be inaccurate
close to zeroes of the functions (thus this patch does *not* fix any
of the bugs for Bessel function inaccuracy); fixing that would require
a different implementation approach, likely along the lines described
in <http://www.cl.cam.ac.uk/~jrh13/papers/bessel.ps.gz>.

So the justification for a change such as this would be statistical
rather than based on particular tests that had excessive errors and no
longer do so (no doubt such tests could be found, but would probably
be too fragile to add to the testsuite, as liable to give large errors
again from very small implementation changes or even from compiler
changes).  See
<https://sourceware.org/ml/libc-alpha/2020-02/msg00638.html> for such
statistics of the resulting improvements for float functions.

Tested (glibc testsuite) for x86_64.

4 years agoresolv: Fix ABA race in /etc/resolv.conf change detection [BZ #25420]
Florian Weimer [Tue, 21 Jan 2020 16:38:15 +0000 (17:38 +0100)]
resolv: Fix ABA race in /etc/resolv.conf change detection [BZ #25420]

__resolv_conf_get_current should only record the initial file
change data if after verifying that file just read matches the
original measurement.  Fixes commit aef16cc8a4c670036d45590877
("resolv: Automatically reload a changed /etc/resolv.conf file
[BZ #984]").

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
4 years agoresolv: Enhance __resolv_conf_load to capture file change data
Florian Weimer [Tue, 21 Jan 2020 16:25:39 +0000 (17:25 +0100)]
resolv: Enhance __resolv_conf_load to capture file change data

The data is captured after reading the file.  This allows callers
to check the change data against an earlier measurement.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
4 years agoresolv: Fix file handle leak in __resolv_conf_load [BZ #25429]
Florian Weimer [Tue, 21 Jan 2020 16:11:01 +0000 (17:11 +0100)]
resolv: Fix file handle leak in __resolv_conf_load [BZ #25429]

res_vinit_1 did not close the stream on errors, only on success.
This change moves closing the stream to __resolv_conf_load, for both
the success and error cases.

Fixes commit 89f187a40fc0ad4e22838526bfe34d73f758b776 ("resolv: Use
getline for configuration file reading in res_vinit_1") and commit
3f853f22c87f0b671c0366eb290919719fa56c0e ("resolv: Lift domain search
list limits [BZ #19569] [BZ #21475]"), where memory allocation was
introduced into res_vinit_1.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
4 years agoresolv: Use <file_change_detection.h> in __resolv_conf_get_current
Florian Weimer [Tue, 21 Jan 2020 15:52:33 +0000 (16:52 +0100)]
resolv: Use <file_change_detection.h> in __resolv_conf_get_current

Only minor functional changes (i.e., regarding the handling of
directories, which are now treated as empty files).

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
4 years agoAdd STATX_ATTR_VERITY from Linux 5.5 to bits/statx-generic.h.
Joseph Myers [Thu, 13 Feb 2020 21:59:59 +0000 (21:59 +0000)]
Add STATX_ATTR_VERITY from Linux 5.5 to bits/statx-generic.h.

This patch adds the new STATX_ATTR_VERITY macro from Linux 5.5 to
glibc's bits/statx-generic.h.  (This only does anything if glibc is
being used with old kernel headers.)

Tested for x86_64.

4 years agoUse gcc -finput-charset=ascii for check-installed-headers.
Stefan Liebler [Thu, 13 Feb 2020 16:32:00 +0000 (17:32 +0100)]
Use gcc -finput-charset=ascii for check-installed-headers.

A non-ascii character in the installed headers leads now to:
error: failure to convert ascii to UTF-8

Such a finding in s390 specific fenv.h leads to fails in GCC testsuite.
See glibc commit 08aea89ef67c5780ae734073494df0a451bce20f.

Adding this gcc option also to our tests was proposed by Florian Weimer.

This change also found a hit in resource.h where now "microseconds" is used.
I've adjusted all the resource.h files.

I've used the following command to check for further hits in headers.
LC_ALL=C find -name "*.h" -exec grep -PHn "[\x80-\xFF]" {} \;

Tested on s390x and x86_64.

Reviewed-by: Zack Weinberg <zackw@panix.com>
4 years agomath/test-sinl-pseudo: Use stack protector only if available
Florian Weimer [Thu, 13 Feb 2020 16:01:15 +0000 (17:01 +0100)]
math/test-sinl-pseudo: Use stack protector only if available

This fixes commit 9333498794cde1d5cca518bad ("Avoid ldbl-96 stack
corruption from range reduction of pseudo-zero (bug 25487).").

4 years agoalpha: Fix static gettimeofday symbol
Adhemerval Zanella [Thu, 13 Feb 2020 11:27:27 +0000 (08:27 -0300)]
alpha: Fix static gettimeofday symbol

By undef strong_alias on alpha implementation, the
default_symbol_version macro becomes an empty macro on static build.
It fixes the issue introduced at c953219420.

Checked on alpha-linux-gnu with a 'make check run-built-tests=no'.

4 years agonss_nisplus: Use NSS_DECLARE_MODULE_FUNCTIONS
Florian Weimer [Wed, 12 Feb 2020 14:36:03 +0000 (15:36 +0100)]
nss_nisplus: Use NSS_DECLARE_MODULE_FUNCTIONS

Reviewed-by: DJ Delorie <dj@redhat.com>
4 years agonss_dns: Use NSS_DECLARE_MODULE_FUNCTIONS
Florian Weimer [Wed, 12 Feb 2020 10:47:49 +0000 (11:47 +0100)]
nss_dns: Use NSS_DECLARE_MODULE_FUNCTIONS

Reviewed-by: DJ Delorie <dj@redhat.com>
4 years agonss_files: Use NSS_DECLARE_MODULE_FUNCTIONS
Florian Weimer [Wed, 12 Feb 2020 10:47:40 +0000 (11:47 +0100)]
nss_files: Use NSS_DECLARE_MODULE_FUNCTIONS

Reviewed-by: DJ Delorie <dj@redhat.com>
4 years agonss_db: Use NSS_DECLARE_MODULE_FUNCTIONS
Florian Weimer [Wed, 12 Feb 2020 10:47:26 +0000 (11:47 +0100)]
nss_db: Use NSS_DECLARE_MODULE_FUNCTIONS

Reviewed-by: DJ Delorie <dj@redhat.com>
4 years agonss_compat: Use NSS_DECLARE_MODULE_FUNCTIONS
Florian Weimer [Wed, 12 Feb 2020 10:47:13 +0000 (11:47 +0100)]
nss_compat: Use NSS_DECLARE_MODULE_FUNCTIONS

Reviewed-by: DJ Delorie <dj@redhat.com>
4 years agonss_hesiod: Use NSS_DECLARE_MODULE_FUNCTIONS
Florian Weimer [Wed, 12 Feb 2020 10:46:59 +0000 (11:46 +0100)]
nss_hesiod: Use NSS_DECLARE_MODULE_FUNCTIONS

Reviewed-by: DJ Delorie <dj@redhat.com>
4 years agonss: Add function types and NSS_DECLARE_MODULE_FUNCTIONS macro to <nss.h>
Florian Weimer [Wed, 12 Feb 2020 14:27:37 +0000 (15:27 +0100)]
nss: Add function types and NSS_DECLARE_MODULE_FUNCTIONS macro to <nss.h>

This macro allows to add type safety to the implementation of NSS
service modules.

Reviewed-by: DJ Delorie <dj@redhat.com>
4 years agonss_compat: Do not use nss_* names for function pointers
Florian Weimer [Wed, 12 Feb 2020 10:30:06 +0000 (11:30 +0100)]
nss_compat: Do not use nss_* names for function pointers

A future commit will use these names for types of functions
in NSS service modules.

Reviewed-by: DJ Delorie <dj@redhat.com>
4 years agoAvoid ldbl-96 stack corruption from range reduction of pseudo-zero (bug 25487).
Joseph Myers [Wed, 12 Feb 2020 23:31:56 +0000 (23:31 +0000)]
Avoid ldbl-96 stack corruption from range reduction of pseudo-zero (bug 25487).

Bug 25487 reports stack corruption in ldbl-96 sinl on a pseudo-zero
argument (an representation where all the significand bits, including
the explicit high bit, are zero, but the exponent is not zero, which
is not a valid representation for the long double type).

Although this is not a valid long double representation, existing
practice in this area (see bug 4586, originally marked invalid but
subsequently fixed) is that we still seek to avoid invalid memory
accesses as a result, in case of programs that treat arbitrary binary
data as long double representations, although the invalid
representations of the ldbl-96 format do not need to be consistently
handled the same as any particular valid representation.

This patch makes the range reduction detect pseudo-zero and unnormal
representations that would otherwise go to __kernel_rem_pio2, and
returns a NaN for them instead of continuing with the range reduction
process.  (Pseudo-zero and unnormal representations whose unbiased
exponent is less than -1 have already been safely returned from the
function before this point without going through the rest of range
reduction.)  Pseudo-zero representations would previously result in
the value passed to __kernel_rem_pio2 being all-zero, which is
definitely unsafe; unnormal representations would previously result in
a value passed whose high bit is zero, which might well be unsafe
since that is not a form of input expected by __kernel_rem_pio2.

Tested for x86_64.

4 years agomips: Fix argument passing for inlined syscalls on Linux [BZ #25523]
WANG Xuerui [Wed, 12 Feb 2020 16:57:03 +0000 (00:57 +0800)]
mips: Fix argument passing for inlined syscalls on Linux [BZ #25523]

According to [gcc documentation][1], temporary variables must be used for
the desired content to not be call-clobbered.

Fix the Linux inline syscall templates by adding temporary variables,
much like what x86 did before
(commit 381a0c26d73e0f074c962e0ab53b99a6c327066d).

Tested with gcc 9.2.0, both cross-compiled and natively on Loongson
3A4000.

[1]: https://gcc.gnu.org/onlinedocs/gcc/Local-Register-Variables.html

4 years agomips: Use 'long int' and 'long long int' in linux syscall code
WANG Xuerui [Wed, 12 Feb 2020 16:57:02 +0000 (00:57 +0800)]
mips: Use 'long int' and 'long long int' in linux syscall code

Style fixes only, no functional change.

4 years agoalpha: Use generic gettimeofday implementation
Adhemerval Zanella [Mon, 10 Feb 2020 20:59:57 +0000 (17:59 -0300)]
alpha: Use generic gettimeofday implementation

It makes alpha no longer reports information about a system-wide
time zone and moves the version logic on the alpha implementation.

Checked on a build and check-abi for alpha-linux-gnu.

Reviewed-by: Lukasz Majewski <lukma@denx.de>
4 years agosunrpc: Properly clean up if tst-udp-timeout fails
Matheus Castanho [Wed, 12 Feb 2020 16:07:32 +0000 (13:07 -0300)]
sunrpc: Properly clean up if tst-udp-timeout fails

The macro TEST_VERIFY_EXIT is used several times on
sunrpc/tst-udp-timeout to exit the test if a condition evaluates to
false. The side effect is that the code to terminate the RPC server
process is not executed when the program calls exit, so that
sub-process stays alive.

This commit registers a clean up function with atexit to kill the
server process before exiting the main program.

Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
4 years agoelf: avoid stack allocation in dl_open_worker
David Kilroy [Wed, 12 Feb 2020 17:31:17 +0000 (14:31 -0300)]
elf: avoid stack allocation in dl_open_worker

As the sort was removed, there's no need to keep a separate map of
links. Instead, when relocating objects iterate over l_initfini
directly.

This allows us to remove the loop copying l_initfini elements into
map. We still need a loop to identify the first and last elements that
need relocation.

Tested by running the testsuite on x86_64.

4 years agoelf: avoid redundant sort in dlopen
David Kilroy [Wed, 12 Feb 2020 17:30:31 +0000 (14:30 -0300)]
elf: avoid redundant sort in dlopen

l_initfini is already sorted by dependency in _dl_map_object_deps(),
so avoid sorting again in dl_open_worker().

Tested by running the testsuite on x86_64.

4 years agoelf: Allow dlopen of filter object to work [BZ #16272]
David Kilroy [Wed, 12 Feb 2020 17:28:15 +0000 (14:28 -0300)]
elf: Allow dlopen of filter object to work [BZ #16272]

There are two fixes that are needed to be able to dlopen filter
objects. First _dl_map_object_deps cannot assume that map will be at
the beginning of l_searchlist.r_list[], as filtees are inserted before
map. Secondly dl_open_worker needs to ensure that filtees get
relocated.

In _dl_map_object_deps:

* avoiding removing relocation dependencies of map by setting
  l_reserved to 0 and otherwise processing the rest of the search
  list.

* ensure that map remains at the beginning of l_initfini - the list
  of things that need initialisation (and destruction). Do this by
  splitting the copy up. This may not be required, but matches the
  initialization order without dlopen.

Modify dl_open_worker to relocate the objects in new->l_inifini.
new->l_initfini is constructed in _dl_map_object_deps, and lists the
objects that need initialization and destruction. Originally the list
of objects in new->l_next are relocated. All of these objects should
also be included in new->l_initfini (both lists are populated with
dependencies in _dl_map_object_deps). We can't use new->l_prev to pick
up filtees, as during a recursive dlopen from an interposed malloc
call, l->prev can contain objects that are not ready for relocation.

Add tests to verify that symbols resolve to the filtee implementation
when auxiliary and filter objects are used, both as a normal link and
when dlopen'd.

Tested by running the testsuite on x86_64.

4 years agoUpdate translations
Siddhesh Poyarekar [Wed, 12 Feb 2020 14:43:57 +0000 (20:13 +0530)]
Update translations

Pull in translation update from translation.org.

4 years agoRename RWF_WRITE_LIFE_NOT_SET to RWH_WRITE_LIFE_NOT_SET following Linux 5.5.
Joseph Myers [Wed, 12 Feb 2020 13:37:16 +0000 (13:37 +0000)]
Rename RWF_WRITE_LIFE_NOT_SET to RWH_WRITE_LIFE_NOT_SET following Linux 5.5.

Linux 5.5 renames RWF_WRITE_LIFE_NOT_SET to RWH_WRITE_LIFE_NOT_SET,
with the old name kept as an alias.  This patch makes the
corresponding change in glibc.

Tested for x86_64.

4 years agoS390: Fix non-ascii character in fenv.h.
Stefan Liebler [Wed, 12 Feb 2020 08:10:56 +0000 (09:10 +0100)]
S390: Fix non-ascii character in fenv.h.

The comment "isn't" contained a non-ascii character which leads to
an error if compiled with -finput-charset=ascii:
error: failure to convert ascii to UTF-8

This is observable in GCC testsuite:
FAIL: 17_intro/headers/c++1998/charset.cc (test for excess errors)
FAIL: 17_intro/headers/c++2011/charset.cc (test for excess errors)
FAIL: 17_intro/headers/c++2014/charset.cc (test for excess errors)
FAIL: 17_intro/headers/c++2017/charset.cc (test for excess errors)
FAIL: 17_intro/headers/c++2020/charset.cc (test for excess errors)

Also rewrite the comment above.

Reported-by: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
4 years agoio: Add io/tst-lchmod covering lchmod and fchmodat
Florian Weimer [Tue, 11 Feb 2020 15:22:19 +0000 (16:22 +0100)]
io: Add io/tst-lchmod covering lchmod and fchmodat

4 years agoLinux: Emulate fchmodat with AT_SYMLINK_NOFOLLOW using O_PATH [BZ #14578]
Florian Weimer [Wed, 22 Jan 2020 18:01:20 +0000 (19:01 +0100)]
Linux: Emulate fchmodat with AT_SYMLINK_NOFOLLOW using O_PATH [BZ #14578]

/proc/self/fd files are special and chmod on O_PATH descriptors
in that directory operates on the symbolic link itself (like lchmod).

4 years agoio: Implement lchmod using fchmodat [BZ #14578]
Florian Weimer [Wed, 22 Jan 2020 17:56:04 +0000 (18:56 +0100)]
io: Implement lchmod using fchmodat [BZ #14578]

4 years agoAdd internal <file_change_detection.h> header file
Florian Weimer [Tue, 11 Feb 2020 12:52:06 +0000 (13:52 +0100)]
Add internal <file_change_detection.h> header file

The code started out with bits form resolv/resolv_conf.c, but it
was enhanced to deal with directories and FIFOs in a more predictable
manner.  A test case is included as well.

This will be used to implement the /etc/resolv.conf change detection.

This currently lives in a header file only.  Once there are multiple
users, the implementations should be moved into C files.

4 years agoelf.h: Add R_RISCV_IRELATIVE
Fangrui Song [Wed, 12 Feb 2020 06:10:19 +0000 (01:10 -0500)]
elf.h: Add R_RISCV_IRELATIVE

The number has been officially assigned by
https://github.com/riscv/riscv-elf-psabi-doc/pull/131
https://github.com/riscv/riscv-elf-psabi-doc/commit/d21ca40a7f56812a15e97450b7bc1599c0d35b82

4 years agoFix typo in the name for Wednesday in Kurdish [BZ #9809]
Mike FABIAN [Tue, 11 Feb 2020 09:17:12 +0000 (10:17 +0100)]
Fix typo in the name for Wednesday in Kurdish [BZ #9809]

4 years agodebug: Add missing locale dependencies of fortify tests
Florian Weimer [Mon, 10 Feb 2020 13:37:10 +0000 (14:37 +0100)]
debug: Add missing locale dependencies of fortify tests

The missing dependencies result in failures like this if make check
is invoked with sufficient parallelism for the debug subdirectory:

FAIL: debug/tst-chk2
FAIL: debug/tst-chk3
FAIL: debug/tst-chk4
FAIL: debug/tst-chk5
FAIL: debug/tst-chk6
FAIL: debug/tst-lfschk1
FAIL: debug/tst-lfschk2
FAIL: debug/tst-lfschk3
FAIL: debug/tst-lfschk4
FAIL: debug/tst-lfschk5
FAIL: debug/tst-lfschk6

4 years agohtl C11 threads: Avoid pthread_ symbols visibility in static library
Samuel Thibault [Mon, 10 Feb 2020 23:45:23 +0000 (23:45 +0000)]
htl C11 threads: Avoid pthread_ symbols visibility in static library

4 years agohurd: Add __pthread_spin_wait and use it
Samuel Thibault [Mon, 10 Feb 2020 22:06:33 +0000 (23:06 +0100)]
hurd: Add __pthread_spin_wait and use it

900778283ac3 ("htl: make pthread_spin_lock really spin") made
pthread_spin_lock really spin and not block, but the current users of
__pthread_spin_lock were assuming that it blocks, i.e. they use it as a
lightweight mutex fitting in just one int.

__pthread_spin_wait provides that support back.

4 years agoldbl-128ibm-compat: set PRINTF_CHK flag in {,v}sprintf_chk
Paul E. Murphy [Tue, 4 Feb 2020 15:21:19 +0000 (09:21 -0600)]
ldbl-128ibm-compat: set PRINTF_CHK flag in {,v}sprintf_chk

This should be unconditionally set to match the common implementation,
and fixes multiple test failures related to sprintf.

Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
4 years agoUse --disable-gdbserver in build-many-glibcs.py.
Joseph Myers [Mon, 10 Feb 2020 22:17:59 +0000 (22:17 +0000)]
Use --disable-gdbserver in build-many-glibcs.py.

Now that binutils-gdb has gdbserver at top level, an extra
--disable-gdbserver configure option is needed when configuring
binutils from a git checkout to avoid it also building gdbserver
unnecessarily (although fairly harmlessly).  This patch updates the
options used in build-many-glibcs.py accordingly (although this might
end up not being needed depending on what happens regarding whether
gdbserver gets built for host != target).

Tested with a build-many-glibcs.py compilers build for
aarch64-linux-gnu using binutils-gdb master.

4 years agoImprove random memcpy benchmark
Wilco Dijkstra [Mon, 10 Feb 2020 16:08:40 +0000 (16:08 +0000)]
Improve random memcpy benchmark

Improve the random memcpy benchmark.  Double the number of copies and
increase the memory sizes tested to 512KB.  Add a more detailed
distribution of memcpy alignment and sizes up to 4096 based on SPEC2017
traces.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
4 years agonptl: update default pthread-offsets.h
Andreas Schwab [Wed, 5 Feb 2020 16:33:30 +0000 (17:33 +0100)]
nptl: update default pthread-offsets.h

Remove unused definitions, and correct __PTHREAD_RWLOCK_FLAGS_OFFSET for
__WORDSIZE == 64.

4 years agonptl: add missing pthread-offsets.h
Andreas Schwab [Wed, 5 Feb 2020 17:09:04 +0000 (18:09 +0100)]
nptl: add missing pthread-offsets.h

All architectures using their own definition of struct
__pthread_rwlock_arch_t need to provide their own pthread-offsets.h.

4 years agohtl: Avoid a local plt for pthread_self
Samuel Thibault [Mon, 10 Feb 2020 12:22:31 +0000 (13:22 +0100)]
htl: Avoid a local plt for pthread_self

4 years agopthread: Move some join tests from nptl to sysdeps/pthread
Samuel Thibault [Mon, 10 Feb 2020 01:21:46 +0000 (01:21 +0000)]
pthread: Move some join tests from nptl to sysdeps/pthread

So they can be checked with htl too.

4 years agohtl: Make joining self return EDEADLK
Samuel Thibault [Mon, 10 Feb 2020 01:19:00 +0000 (01:19 +0000)]
htl: Make joining self return EDEADLK

4 years agopthread: Move most barrier tests from nptl to sysdeps/pthread
Samuel Thibault [Sun, 9 Feb 2020 23:14:35 +0000 (23:14 +0000)]
pthread: Move most barrier tests from nptl to sysdeps/pthread

So they can be checked with htl too.

4 years agohtl: Fix barrier_wait with one thread
Samuel Thibault [Sun, 9 Feb 2020 23:02:13 +0000 (23:02 +0000)]
htl: Fix barrier_wait with one thread

4 years agopthread: Move most sem tests from nptl to sysdeps/pthread
Samuel Thibault [Sun, 9 Feb 2020 22:55:12 +0000 (22:55 +0000)]
pthread: Move most sem tests from nptl to sysdeps/pthread

So they can be checked with htl too.

4 years agohtl: Make sem_wait/sem_timedwait interruptible
Samuel Thibault [Mon, 10 Feb 2020 00:52:50 +0000 (00:52 +0000)]
htl: Make sem_wait/sem_timedwait interruptible

4 years agohtl: Make sem_open return ENOSYS
Samuel Thibault [Sun, 9 Feb 2020 22:52:32 +0000 (22:52 +0000)]
htl: Make sem_open return ENOSYS

instead of EOPNOTSUPP, which is for sockets.

4 years agohtl: Add support for semaphore maximum value
Samuel Thibault [Sun, 9 Feb 2020 22:44:08 +0000 (22:44 +0000)]
htl: Add support for semaphore maximum value

4 years agopthread: Move key tests from nptl to sysdeps/pthread
Samuel Thibault [Sun, 9 Feb 2020 22:27:09 +0000 (22:27 +0000)]
pthread: Move key tests from nptl to sysdeps/pthread

So they can be checked with htl too.

4 years agohurd: Make nanosleep a cancellation point
Samuel Thibault [Sun, 9 Feb 2020 22:27:56 +0000 (22:27 +0000)]
hurd: Make nanosleep a cancellation point

4 years agohtl: Add support for libc cancellation points
Samuel Thibault [Sun, 9 Feb 2020 22:23:52 +0000 (22:23 +0000)]
htl: Add support for libc cancellation points

4 years agohtl: clean __pthread_get_cleanup_stack hidden proto
Samuel Thibault [Sun, 9 Feb 2020 23:13:24 +0000 (23:13 +0000)]
htl: clean __pthread_get_cleanup_stack hidden proto

4 years agohtl: XFAIL rwlock tests which need pshared support
Samuel Thibault [Sun, 9 Feb 2020 22:27:38 +0000 (22:27 +0000)]
htl: XFAIL rwlock tests which need pshared support

4 years agopthread: Move some rwlock tests from nptl to sysdeps/pthread
Samuel Thibault [Sun, 9 Feb 2020 20:07:51 +0000 (20:07 +0000)]
pthread: Move some rwlock tests from nptl to sysdeps/pthread

So they can be checked with htl too.

4 years agopthread: Move most once tests from nptl to sysdeps/pthread
Samuel Thibault [Sun, 9 Feb 2020 19:50:21 +0000 (19:50 +0000)]
pthread: Move most once tests from nptl to sysdeps/pthread

So they can be checked with htl too.

4 years agohtl: support cancellation during pthread_once
Samuel Thibault [Sun, 9 Feb 2020 19:43:43 +0000 (19:43 +0000)]
htl: support cancellation during pthread_once

4 years agopthread: Move most cond tests from nptl to sysdeps/pthread
Samuel Thibault [Sun, 9 Feb 2020 19:17:51 +0000 (19:17 +0000)]
pthread: Move most cond tests from nptl to sysdeps/pthread

So they can be checked with htl too.

4 years agohtl: make pthread_cond_destroy return EBUSY on waiters
Samuel Thibault [Sun, 9 Feb 2020 19:19:25 +0000 (19:19 +0000)]
htl: make pthread_cond_destroy return EBUSY on waiters

4 years agohtl: Report missing mutex lock on pthread_cond_*wait
Samuel Thibault [Sun, 9 Feb 2020 18:12:39 +0000 (18:12 +0000)]
htl: Report missing mutex lock on pthread_cond_*wait

4 years agohtl: Fix linking static testcases
Samuel Thibault [Sun, 9 Feb 2020 17:57:27 +0000 (17:57 +0000)]
htl: Fix linking static testcases

They need libpthread.a

4 years agohtl: Move __register_atfork from forward to own file
Samuel Thibault [Sun, 9 Feb 2020 17:55:37 +0000 (17:55 +0000)]
htl: Move __register_atfork from forward to own file

Since we need it also in the static linking case.

4 years agopthread: Move some attr tests from nptl to sysdeps/pthread
Samuel Thibault [Sun, 9 Feb 2020 17:30:30 +0000 (17:30 +0000)]
pthread: Move some attr tests from nptl to sysdeps/pthread

So they can be checked with htl too.

4 years agohtl: Fix default guard size
Samuel Thibault [Sun, 9 Feb 2020 17:27:38 +0000 (17:27 +0000)]
htl: Fix default guard size

When it is not hardcoded by the architecture with PAGESIZE, we need to
use the dynamic values from __vm_page_size.

4 years agopthread: Move most mutex tests from nptl to sysdeps/pthread
Samuel Thibault [Sun, 9 Feb 2020 17:15:47 +0000 (17:15 +0000)]
pthread: Move most mutex tests from nptl to sysdeps/pthread

So they can be checked with htl too.

XFAIL tst-mutex4, for which support is still missing in htl.

4 years agopthread: Move spin tests from nptl to sysdeps/pthread
Samuel Thibault [Sun, 9 Feb 2020 17:00:39 +0000 (17:00 +0000)]
pthread: Move spin tests from nptl to sysdeps/pthread

So they can be checked with htl too.

4 years agohtl: make pthread_spin_lock really spin
Samuel Thibault [Sun, 9 Feb 2020 16:54:58 +0000 (16:54 +0000)]
htl: make pthread_spin_lock really spin

__spin_lock would actually use gsync_wait to block, which is not what
pthread_spin_lock is about.

4 years agohtl: Avoid check-installed-headers looking at inlines
Samuel Thibault [Sun, 9 Feb 2020 16:41:24 +0000 (16:41 +0000)]
htl: Avoid check-installed-headers looking at inlines

4 years agohtl: Do not put spin_lock inlines in public headers
Samuel Thibault [Sun, 9 Feb 2020 16:34:26 +0000 (16:34 +0000)]
htl: Do not put spin_lock inlines in public headers

They were not getting used anyway.
Also do not make libsupport use them, it would make tests using it have
to be made to link against libmachuser for gsync_wait.

4 years agopthread: Move basic tests from nptl to sysdeps/pthread
Samuel Thibault [Sun, 9 Feb 2020 16:12:35 +0000 (16:12 +0000)]
pthread: Move basic tests from nptl to sysdeps/pthread

So they can be checked with htl too.