Stephen Toub [Wed, 9 Mar 2022 11:49:16 +0000 (06:49 -0500)]
Fix cancellation race condition in PipeStream cancellation callback (#65909)
* Fix cancellation race condition in PipeStream cancellation callback
The public PipeStream.SafePipeHandle property throws an exception if the handle has already been closed. This code should have been using the internal InternalHandle property, which just gets the SafePipeHandle object if it exists.
* Update src/libraries/System.IO.Pipes/src/System/IO/Pipes/PipeStream.ValueTaskSource.cs
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
brianmed [Wed, 9 Mar 2022 10:56:44 +0000 (05:56 -0500)]
First try at implementing newly suggested ctor for providing tighter control over charset (#63231)
* First try at implementing newly suggested ctor for providing tighter control over charset
* Update reference assembly so mediaType is accurate
* Update per github code review
Jakob Botsch Nielsen [Wed, 9 Mar 2022 10:22:25 +0000 (11:22 +0100)]
Do not mark implicit byrefs with GTF_GLOB_REF (#66266)
Koundinya Veluri [Wed, 9 Mar 2022 02:35:55 +0000 (18:35 -0800)]
Fix some exception messages for BindHandle-like cases (#66326)
* Fix some exception messages for BindHandle-like cases
- Updated `ThrowHelper.ThrowApplicationException` to get and include an error message
- Enabled the disabled tests, disabled a `BindHandle` test on Unixes where it now throws `PNSE` before `ArgumentNullException`
Fixes https://github.com/dotnet/runtime/issues/66273
Fixes https://github.com/dotnet/runtime/issues/66274
SingleAccretion [Wed, 9 Mar 2022 02:18:54 +0000 (05:18 +0300)]
Do not propagate RHS flags in block morphing (#66291)
It is not necessary to copy flags from the source node to the field nodes
when doing a field-by-field copy in block morphing. In fact, it can be a
pessimization in cases where the source node had NO_CSE set, which would
block constant propagation.
Aaron Robinson [Wed, 9 Mar 2022 00:57:12 +0000 (19:57 -0500)]
Remove compiler warning suppression (#66234)
* Remove 4996
* Remove 4701
* Remove 4611
* Remove 4610
* Remove 4510
* Remove 4267
* Remove 4267 - libunwind
Parker Bibus [Tue, 8 Mar 2022 23:57:38 +0000 (17:57 -0600)]
Partial revert of Maui Install Fix #65904 (#66221)
* Prep for test build run.
* Replace the rollback file in the install call as the emscription line has been added to the downloaded json.
* Revert "Prep for test build run."
This reverts commit
2d7cca803e1cb6b79f83583b4dfa9846be3cf95e.
* Fix comment detailing Install Maui Workload setup.
Olli Saarikivi [Tue, 8 Mar 2022 21:30:46 +0000 (13:30 -0800)]
Fix NonBacktracking quadratic behavior with deep loops (#66038)
Derivative construction now accumulates a list of concatenands and
builds concatenations making up a part of a derivative just once.
Repeated concatenation to the right side in an interaction of the
derivation rule for concatenations and loops was causing quadratic
rebuilding of concatenations.
To implement this fix TransitionRegex is no longer used and instead both
normal and effectful derivative variants use a monolithic base function
that implements the rules for regex derivatives. This also gets rid of
the additional inefficiency of allocating TransitionRegex trees.
Both kinds of derivatives now support simulating backtracking behavior
and always use OrderedOr nodes to maintain transition ordering. The
second reverse phase of matching, however, needs to not use backtracking
simulation. A new DisableBacktrackingSimulation is used to signal this.
Other notable fixes:
The eager concept in derivatives is renamed to simulateBacktracking.
Put TransitionRegex and SymbolicNFA behind DEBUG.
Fix ApplyEffects calls to not create closures.
Fix OrderedOr to always deduplicate: when the new element was on the
left deduplication was skipped.
Improve CaptureStart/End ToString to not look like parentheses and
include the group number.
dotnet-maestro[bot] [Tue, 8 Mar 2022 19:34:24 +0000 (20:34 +0100)]
[main] Update dependencies from dotnet/linker (#66331)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Stephen Toub [Tue, 8 Mar 2022 19:24:48 +0000 (14:24 -0500)]
Fix code coverage gaps in RegexGenerator and fix RegexCompiler bug (#66321)
Noticed some easily-fillable gaps in code coverage for RegexGenerator. In adding those tests, found and fixed a bug in RegexCompiler where we were incorrectly using `Call(s_spanIndexOfSpan)` instead of `Call(s_spanIndexOfAnySpan)`.
Jakob Botsch Nielsen [Tue, 8 Mar 2022 18:41:32 +0000 (19:41 +0100)]
Fix instruction hex display for arm/arm64 when W^X is on (#66328)
Fix #65638
Radek Zikmund [Tue, 8 Mar 2022 17:44:17 +0000 (18:44 +0100)]
Mark EncryptionPolicy.NoEncryption and EncryptionPolicy.AllowNoEncryption as obsolete (#66292)
Fixes #65545
Elinor Fung [Tue, 8 Mar 2022 17:14:43 +0000 (09:14 -0800)]
Add tests for `ijwhost` (#66308)
Badre BSAILA [Tue, 8 Mar 2022 16:15:18 +0000 (17:15 +0100)]
use the name of the header when throwing exception for invalid chars (#66250)
* use the name of the header when throwing exception for invalid chars
* delete VS code cleanups
* delete VS code cleanups 2
* add suggested changes 1
* delete VS code cleanups 3
* delete VS code cleanups 4
* delete VS code cleanups 5
Fan Yang [Tue, 8 Mar 2022 15:20:59 +0000 (10:20 -0500)]
[Mono] Enable generating SIMD intrinsics for System.Numerics.Vector on Arm64 (#65486)
* Enable SIMD intrinsics for System.Numerics.Vector on Arm64
* Minor adjustment
* Use the correct op code for BitwiseAnd, BitwiseOr and Xor
* Check if vector element type is a primitive type or not
* Remove dead code and fix constant formet
* Add type checks for each method and refactor
* Remove extra condition check
* Loose the type check for vector creation methods
* Remove type checks for Create* functions
* Remove some of the type checks
Zoltan Varga [Tue, 8 Mar 2022 15:18:15 +0000 (10:18 -0500)]
[mono][jit] Remove OP_FCONV_TO_I/OP_RCONV_TO_I from the back ends, convert them to TO_I4/TO_I8 in the front end. (#66268)
Zoltan Varga [Tue, 8 Mar 2022 15:17:55 +0000 (10:17 -0500)]
[mono][jit] Disable deopt in gsharedvt methods. (#66322)
The deopt code can't handle the gsharedvt return value convention.
Fixes https://github.com/dotnet/runtime/issues/66319.
Aleksey Kliger (λgeek) [Tue, 8 Mar 2022 14:08:40 +0000 (09:08 -0500)]
[mono] Put WeakAttribute support under an ifdef (#66213)
This code has been effectively dead in .NET 6 on all platforms since
System.WeakAttribute is not in CoreLib.
Not everything is removed:
- MonoClass:has_weak_fields bit is still present (and always 0).
- the AOT compiler still emits a (size 0) weak_field_indexes symbol (but the
AOT runtime reader code is under an ifdef). Likewise the AOT table
definitions, etc are still there. It seemed unnecessary to perturb the AOT
format.
Michal Strehovský [Tue, 8 Mar 2022 05:51:58 +0000 (06:51 +0100)]
Add MultiModule test to issues.targets (#66289)
Hitting https://github.com/dotnet/runtime/issues/66191 in the CI.
Bruce Forstall [Tue, 8 Mar 2022 01:43:56 +0000 (17:43 -0800)]
Disable failing bindhandleinvalid tests (#66303)
* Disable failing bindhandleinvalid tests
Tracking: https://github.com/dotnet/runtime/issues/66273
* Also disable bindhandlenull
Tracking: #66274
Jose Perez Rodriguez [Tue, 8 Mar 2022 01:39:21 +0000 (17:39 -0800)]
Adding Count(ReadOnlySpan<char>) Overloads (#66026)
* Adding Count(ReadOnlySpan<char>) Overloads
* Address PR Feedback
Tomáš Rylek [Tue, 8 Mar 2022 01:22:08 +0000 (02:22 +0100)]
Fix ConditionalFactAttribute instances in ILPROJ tests (#66312)
I have found out that the change I originally made by changing
reference assembly for System.Type from System.Runtime to mscorlib
was incorrect - the Roslyn XUnit wrapper source generator started
failing with a nullref. I have experimentally identified that I can
fix this problem by explicitly specifying public key tokens of
the System.Runtime and Microsoft.DotNet.XUnitExtensions assembly
references and by adding a reference to the TestLibrary.
As I had to update System.Runtime references in all affected modules,
I also put back the System.Runtime assembly as the home for
System.Type as was the original state I copied from a C# compilation
disassembly, I changed them to mscorlib because I didn't know
I would need to specify the System.Runtime reference.
Thanks
Tomas
Jeremy Koritzinsky [Tue, 8 Mar 2022 01:14:30 +0000 (17:14 -0800)]
Add partial to the enclosing types when running the ConvertToGeneratedDllImport fixer (#65452)
Bruce Forstall [Tue, 8 Mar 2022 00:33:13 +0000 (16:33 -0800)]
Try additional nuget retries (#66306)
After adding NUGET_EXPERIMENTAL_CHAIN_BUILD_RETRY_POLICY, we still see
some benchmarks SPMI collection runs fail with the same nuget errors.
In case this is actually a potential workaround, try increasing the
number of retries and delay between them.
Also, print out the environment used so we can verify it, and see if
there are any other relevant variables set.
Egor Bogatov [Mon, 7 Mar 2022 23:22:14 +0000 (02:22 +0300)]
JIT: Optimize movzx after setcc (#66245)
Maryam Ariyan [Mon, 7 Mar 2022 22:45:01 +0000 (17:45 -0500)]
Revisiting nullable annotations on caching (#66215)
* Revisiting nullable annotations on caching
* Fix up more nullablity mismatches
Ankit Jain [Mon, 7 Mar 2022 22:33:42 +0000 (17:33 -0500)]
[wasm] Rename `$(EmccInitialMemory)` to `$(EmccInitialHeapSize)` (#66233)
.. to better represent what it is.
Ankit Jain [Mon, 7 Mar 2022 22:08:49 +0000 (17:08 -0500)]
[wasm][aot] Disable `System.Text.RegularExpressions.Unit.Tests` (#66311)
Issue: https://github.com/dotnet/runtime/issues/66118
Filip Navara [Mon, 7 Mar 2022 22:00:02 +0000 (23:00 +0100)]
Fix compatibility with NTLM authentication to McAfee Web Gateway (#66305)
Stephen Toub [Mon, 7 Mar 2022 21:53:12 +0000 (16:53 -0500)]
Fix missing StringSyntax attribute in Regex ref assembly (#66309)
Stephen Toub [Mon, 7 Mar 2022 21:52:38 +0000 (16:52 -0500)]
Enable RegexOptions.RightToLeft and lookbehinds in compiler / source generator (#66280)
* Enable RegexOptions.RightToLeft and lookbehinds in compiler / source generator
For .NET 7 we rewrote RegexCompiler as we were writing the source generator, and in doing so we left out support for RegexOptions.RightToLeft as well as lookbehinds (which are implemented via RightToLeft). This adds support for both. I initially started incrementally adding in support for various constructs in lookbehinds, but from a testing perspective it made more sense to just add it all, as then all of the RightToLeft tests are used to validate the constructs that are also in lookbehinds.
* Address PR feedback
AraHaan [Mon, 7 Mar 2022 21:45:42 +0000 (16:45 -0500)]
Use runtime and targeting pack version of System.Diagnostics.DiagnosticSource in Microsoft.Extensions.Logging. (#66284)
* Use runtime and targeting pack version of System.Diagnostics.DiagnosticSource.
This removes the copy of System.Diagnostics.DiagnosticSource when using the Microsoft.Extensions.Logging package on .NET Core.
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Stephen A. Imhoff [Mon, 7 Mar 2022 21:04:10 +0000 (13:04 -0800)]
Use RegexGenerator in applicable tests (#66179)
Fan Yang [Mon, 7 Mar 2022 20:12:57 +0000 (15:12 -0500)]
[Mono] Intrinsify Convert* for Vector{64, 128} on ARM64 (#65946)
* Intrinsify Convert*
* Test - comment out my change
* Enable ConvertToDouble
* Enable ConvertToInt32 and ConvertToUInt32
* Enable ConvertToInt64 and ConvertToUInt64
* Disable ConvertToInt64 and ConvertToUInt64, but enable ConvertToSingle
* Remove the support for ConvertToInt64, ConvertToUInt64 and ConvertToSingle
Eirik Tsarpalis [Mon, 7 Mar 2022 19:44:14 +0000 (19:44 +0000)]
Fix issues related to JsonSerializerOptions mutation and caching. (#66248)
* Fix issues related to JsonSerializerOptions mutation and caching. (#65863)
* Fix issues related to JsonSerializerOptions mutation and caching.
* fix test style
* fix linker warning
* disable failing tests in netfx
dotnet-maestro[bot] [Mon, 7 Mar 2022 19:10:18 +0000 (19:10 +0000)]
[main] Update dependencies from 9 repositories (#65843)
[main] Update dependencies from 9 repositories
- Merge branch 'main' into darc-main-
69c88284-a4b6-425e-834c-
f89f194a9041
- Merge branch 'main' into darc-main-
69c88284-a4b6-425e-834c-
f89f194a9041
- Merge branch 'main' into darc-main-
69c88284-a4b6-425e-834c-
f89f194a9041
SingleAccretion [Mon, 7 Mar 2022 18:10:39 +0000 (21:10 +0300)]
Fix a couple issues with GTF_GLOB_REF setting (#66247)
Add it to INDs and BLKs off of exposed ADDRs in addition to OBJs.
Remove code from args morphing which was re-deriving the side effects
flags for an OBJ argument, it was:
a) Unnecessary, as morph has already done all the work.
b) Incorrect, as it lost GTF_GLOB_REF for OBJ(ADDR(LCL (AX)))-like trees.
Adam Sitnik [Mon, 7 Mar 2022 17:39:04 +0000 (18:39 +0100)]
remove invalid System.IO.FileSystem.Watcher tests (#66296)
Genevieve Warren [Mon, 7 Mar 2022 17:33:11 +0000 (09:33 -0800)]
Backport docs fixes for Cbor (#66180)
Lakshan Fernando [Mon, 7 Mar 2022 17:02:19 +0000 (09:02 -0800)]
Annotating Native CoreLib library to be AOT friendly (#66112)
* Annotating Native CoreLib to be AOT friendly
* change array attribute msg
* FB
* Update src/libraries/System.Private.CoreLib/src/Internal/Runtime/InteropServices/ComponentActivator.cs
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Michal Strehovský [Mon, 7 Mar 2022 16:49:50 +0000 (17:49 +0100)]
Fix clash between tentative method optimizations (#66145)
When we were in the situation of the newly added test, we would try to generate method body on the abstract class. Such method body is not actually reachable.
Michal Strehovský [Mon, 7 Mar 2022 15:58:30 +0000 (16:58 +0100)]
Fix workaround for static virtual methods (#66290)
The workaround for reflection invoking static virtual methods wasn't working around well enough. Fixes #66028.
The repro case also hit a scanning failure due to scanner not scanning a throw helper. Those are more of asserts, so add them to the collection of throw helpers to ignore.
Meri Khamoyan [Mon, 7 Mar 2022 15:35:12 +0000 (19:35 +0400)]
Merikhamoyan vector intrinsics operators (#66002)
* Added addition and subtraction operator intrinsics
Peter Sollich [Mon, 7 Mar 2022 13:02:48 +0000 (14:02 +0100)]
Decommit region tails (#66008)
I observed that with gen 1 regions, we often get into the situation that gen 1 is much smaller per heap than a region. So it makes sense to decommit the tail end of the last region in an ephemeral generation guided by the budget for that generation.
To implement this, I reactivated decommit_target for regions and have decommit_step call decommit_ephemeral_segment_pages_step which in the regions case needs to synchronize with the allocator. This is done by taking the more space lock.
Note that with default settings, this decommitting logic will usually only apply to gen 1 because normally gen 0 is larger than a region. It can still happen for gen 0 though if gen 0 has pins and thus already has enough space to satisfy the budget. Then we will decommit the tail end of the last region in gen 0.
SingleAccretion [Mon, 7 Mar 2022 10:58:04 +0000 (13:58 +0300)]
Count `OBJ/BLK` as memory uses (#66135)
* Fix memory liveness for OBJ/BLK
We need to count OBJ/BLK as uses, otherwise SSA can
fail to insert a memory PHI where one is needed.
* Add a test
SingleAccretion [Mon, 7 Mar 2022 09:54:35 +0000 (12:54 +0300)]
Do not create small constants while morphing cascading addition (#66270)
* Do not create small constants
* Add a test
Egor Bogatov [Mon, 7 Mar 2022 08:53:34 +0000 (11:53 +0300)]
Fix address exposure + fsub (#66253)
Radek Zikmund [Mon, 7 Mar 2022 08:16:45 +0000 (09:16 +0100)]
Fix performance regression in SSL handshake (#66077)
dotnet-maestro[bot] [Mon, 7 Mar 2022 00:49:56 +0000 (01:49 +0100)]
[main] Update dependencies from dotnet/linker (#66081)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Stephen Toub [Mon, 7 Mar 2022 00:13:14 +0000 (19:13 -0500)]
Add missing regex position check after BOL optimization (#66216)
* Add missing regex position check after BOL optimization
* Address PR feedback
Dennis Yemelyanov [Sun, 6 Mar 2022 22:40:24 +0000 (14:40 -0800)]
Try to remove "-" and "'" from HighCharTable (#66200)
Sergey Andreenko [Sun, 6 Mar 2022 21:32:10 +0000 (16:32 -0500)]
[crossgen2] Promote single byref aot. (#65682)
* Rename `CORINFO_FLG_DONT_PROMOTE` to `CORINFO_FLG_DONT_DIG_FIELDS`.
* Support promotion of `struct{ 1 gcref; }` outside of version bubble.
Andy Ayers [Sun, 6 Mar 2022 16:27:35 +0000 (08:27 -0800)]
JIT: fix scalability issue in redundant branch optimizer (#66259)
In methods with long skinny dominator trees and lots of redundant branches
the jit can spend too much time trying to optimize the branches.
Place a limit on the number of redundant branches with matching VNs that
the jit will consider for a given branch.
Fixes #66067.
Andy Ayers [Sun, 6 Mar 2022 16:26:43 +0000 (08:26 -0800)]
JIT: add OSR patchpoint strategy, inhibit tail duplication (#66208)
Two changes for OSR:
* add new strategies for placing patchpoints -- either at
backedge sources (instead of targets) or adaptive. depending
on number of backedges. Change default to adaptive, since this
works better with the flow we see from C# `for` loops.
* inhibit tail duplication for OSR as it may end up interfering
with loop recognition.
We may not be able to place patchpoints at sources, for various reasons;
if so we fall back to placing them at targets.
We also can't place patchpoints unless block entries are also stack empty
ponts. This means forgoing patchpoints in some IL cases..
dotnet bot [Sun, 6 Mar 2022 13:47:20 +0000 (05:47 -0800)]
Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1647296 (#66130)
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1642379
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1642486
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1642664
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1643161
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1643830
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1644178
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1644565
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1644845
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1645065
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1645441
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1645652
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1645888
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1646089
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1646301
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1646622
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1646734
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1646905
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1647056
* Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 1647296
Alexander Köplinger [Sun, 6 Mar 2022 13:44:33 +0000 (14:44 +0100)]
[mono] Remove SkipVerification support from the runtime (#66211)
CAS support was removed in .NET Core. This allows us removing a bunch of code that is unused, e.g. the dependency on libiconv.
Sajad Samiizadeh [Sun, 6 Mar 2022 00:59:26 +0000 (04:29 +0330)]
Remove unnecessary return (#66252)
Zoltan Varga [Sat, 5 Mar 2022 16:59:51 +0000 (11:59 -0500)]
[mono][llvm] Fix crashes when methods fail LLVM compilation. (#65391)
Calling LLVMDeleteBasicBlock () seems to cause crashes, so
call LLVMRemoveBasicBlockFromParent () instead.
Jan Kotas [Sat, 5 Mar 2022 14:08:07 +0000 (06:08 -0800)]
Revert "Fix issues related to JsonSerializerOptions mutation and caching. (#65863)" (#66235)
This reverts commit
11b79618faf1023ba4ea26b4037f495f81070d79.
Jan Kotas [Sat, 5 Mar 2022 06:21:59 +0000 (22:21 -0800)]
Replace TargetFrameworks with TargetFramework where possible (#66198)
Jeff Handley [Sat, 5 Mar 2022 05:05:01 +0000 (21:05 -0800)]
Address feedback on fabricbot config for area pods (#66137)
Automatically remove the `untriaged` label when a triage action is performed. When an issue/PR is moved to another area, consider it done on the original board instead of removing it.
Kevin Jones [Sat, 5 Mar 2022 03:49:08 +0000 (22:49 -0500)]
Replace CngCommon hash with OneShotHashHelpers.
Elinor Fung [Sat, 5 Mar 2022 03:42:33 +0000 (19:42 -0800)]
Rename classes in p/invoke generator to be `LibraryImport` (#66217)
Aaron Robinson [Sat, 5 Mar 2022 03:40:27 +0000 (19:40 -0800)]
Use CMakeProjectReference instead of ProjectReference (#66202)
* Use CMakeProjectReference instead of ProjectReference
Changing this permits usage of "\runtime\dotnet.cmd build" as opposed
to forcing users to use "\runtime\dotnet.cmd msbuild".
Ankit Jain [Sat, 5 Mar 2022 02:38:26 +0000 (21:38 -0500)]
[wasm] Add support for symbolicating native traces from JS, using a symbols file (#66042)
* [wasm] Fix run command lines for samples
* [wasm] Export FS_readFile
* [wasm] Add support for symbolicating traces in console errors, or
.. warnings. The regex patterns are hardcoded in `debug.ts`. And the
symbols are loaded from `dotnet.js.symbols`.
We try to symbolicate wherever possible.
* [wasm] Enable symbolicating for non-aot test builds by default
* [wasm] Enable symbol map for debugger tests
* Address feedback from @pavelsavara
* [wasm] Add a `mono_wasm_symbolicate_string` function
.. and use that to symbolicate traces marshaled as C# exceptions (thanks
to @pavelsavara for the suggestion).
Stephen Halter [Sat, 5 Mar 2022 01:15:17 +0000 (17:15 -0800)]
Add HostApplicationBuilder (#65109)
SingleAccretion [Fri, 4 Mar 2022 22:59:19 +0000 (01:59 +0300)]
Delete compUnsafeCastUsed (#66204)
SingleAccretion [Fri, 4 Mar 2022 22:06:37 +0000 (01:06 +0300)]
Slightly more aggressive ASG reversal (#65920)
Allows us to reverse "ASG(IND(const), ...)".
SingleAccretion [Fri, 4 Mar 2022 21:38:48 +0000 (00:38 +0300)]
Keep the volatility of CLS_VARs in rationalize (#65919)
Stephen Toub [Fri, 4 Mar 2022 20:45:33 +0000 (15:45 -0500)]
Fix source generated regex compilation failure due to mismatched notion of atomic (#66195)
During and post-parsing, we apply various optimizations to the regex node tree, in particular trying to annotate as much as possible as atomic in order to eliminate unnecessary backtracking. Then later when RegexCompiler and the source generator view the final tree, they also compute for every node whether a child may backtrack, as doing so enables avoiding unnecessary backtracking-related code generation if the child is known to not backtrack (e.g. because it's now marked as atomic). However, things can go awry if the compiler / source generator's view of what's atomic differs from what's actually generated. Because of how optimizations are applied to the node tree, it's possible for a late optimization to make a transformation that then would enable a node to be made atomic, but we don't run that phase of the optimizer again, and thus the node is left non-atomic. Then the source generator comes along, does its analysis, and sees that the node should be treated as atomic. That leads to problems, because the node itself will have unnecessary backtracking code generated but the parent will rightly assume there wasn't anyway and won't generate the code necessary to compensate for it, or alternatively will generate code that causes problems (e.g. the source generator uses this information to determine whether it can output scopes).
Our outer loop tests that source gen our full regex corpus caught a case where this was happening. A couple fixes, either of which on their own is sufficient to address this particular case, but each of which also brings other benefits:
1. When rendering a single-char loop, it consults the computed atomicity table to determine whether the rest of the source generation views it as atomic. If it does, it instead does an atomic rendering.
2. When we do our ending backtracking elimination pass (i.e. walking down the right-hand side of atomic nodes to make anything that ends them also be atomic), we should also recur into lookarounds.
This also removes some duplicated code for reducing lookarounds, and renames some stale method names.
Stephen Toub [Fri, 4 Mar 2022 20:33:55 +0000 (15:33 -0500)]
Clean up stale use of runtextbeg/end in RegexInterpreter (#66178)
Radek Doulik [Fri, 4 Mar 2022 19:36:48 +0000 (20:36 +0100)]
[wasm] Use INITIAL_MEMORY instead of TOTAL_MEMORY (#65790)
* [wasm] Use INITIAL_MEMORY instead of TOTAL_MEMORY
It was renamed in emscripten 1.39.9:
- Rename `TOTAL_MEMORY` to `INITIAL_MEMORY` and `WASM_MEM_MAX` to `MAXIMUM_MEMORY`,
which are more accurate and match wasm conventions. The old names are still
supported as aliases.
* Add EmccInitialMemory property
Jan Kotas [Fri, 4 Mar 2022 19:13:54 +0000 (11:13 -0800)]
Fix catching of generic exception in crossgened shared generic code (#66162)
* Add regression test
Fixes #66005
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Koundinya Veluri [Fri, 4 Mar 2022 18:47:48 +0000 (10:47 -0800)]
Add support for Windows IO completions to the portable thread pool (#64834)
* Add support for Windows IO completions to the portable thread pool
- Added an implementation for BindHandle
- Polling for IO completions is done in batches on separate threads similarly to what is done on Unixes
- Added a high-priority work item queue to have IO completion work items run at higher priority
- Removed the time-sensitive work item queue, used the high-priority queue instead
Andrew Au [Fri, 4 Mar 2022 18:07:01 +0000 (10:07 -0800)]
Make sure that StressLogAnalyzer works with filtering 64 bit addresses (#64594)
Sam Patel [Fri, 4 Mar 2022 17:15:58 +0000 (12:15 -0500)]
Update files to remove imhameed (#66160)
* Update Codeowners to remove imhameed
* Update area-owners.md to remove imhameed
* Update fabricbot.json file to remove imhameed
* update codeowners file to remove alexrp
* update codeowners to remove Egor from Mono files
* remove merp related entries from CODEOWNERS
Co-authored-by: Aleksey Kliger (λgeek) <alklig@microsoft.com>
Co-authored-by: Aleksey Kliger (λgeek) <alklig@microsoft.com>
Eirik Tsarpalis [Fri, 4 Mar 2022 16:48:09 +0000 (16:48 +0000)]
Make ReadStack.JsonTypeInfo derivation logic consistent with WriteStack's (#66169)
* Make ReadStack.JsonTypeInfo derivation consistent with WriteStack
* remove duplicated assignment
Eirik Tsarpalis [Fri, 4 Mar 2022 16:17:01 +0000 (16:17 +0000)]
Fix issues related to JsonSerializerOptions mutation and caching. (#65863)
* Fix issues related to JsonSerializerOptions mutation and caching.
* fix test style
* fix linker warning
Eirik Tsarpalis [Fri, 4 Mar 2022 16:14:36 +0000 (16:14 +0000)]
Fix DebuggerDisplay for serializer types (#65971)
* Fix DebuggerDisplay for serializer types
* Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/WriteStack.cs
Stephen Toub [Fri, 4 Mar 2022 15:52:45 +0000 (10:52 -0500)]
Some more clean up for RegexOptions.NonBacktracking (#66018)
* Remove some dead code
* Remove Algebras folder
* Delete more dead code
* Clean up BV
* Change GenerateMinterms to accept a HashSet rather than IEnumerable
* Remove more unnecessary enumerable iteration
* Delete more dead code
* A little more BitVector cleanup
* Address PR feedback
Alexander Köplinger [Fri, 4 Mar 2022 15:32:56 +0000 (16:32 +0100)]
[mono] Remove support for nint/nuint/nfloat from mini-native-types.c (#65967)
The Xamarin.iOS types were replaced by the BCL versions.
Adam Sitnik [Fri, 4 Mar 2022 15:07:03 +0000 (16:07 +0100)]
delete the test file with custom security settings when it's being closed (#66192)
Aaron Robinson [Fri, 4 Mar 2022 14:50:07 +0000 (06:50 -0800)]
Rename unixinterface.cpp -> exports.cpp (#66190)
Andy Gocke [Fri, 4 Mar 2022 14:49:12 +0000 (06:49 -0800)]
Remove the multitarget from ILCompiler.Reflection.R2r (#66175)
Aleksey Kliger (λgeek) [Fri, 4 Mar 2022 13:46:02 +0000 (08:46 -0500)]
[tests] Add MonoApi runtime tests (#65221)
Contributes to https://github.com/dotnet/runtime/issues/64456
Create a new directory src/tests/Interop/MonoAPI for tests that use the mono embedding API.
Move the mono libtest.c native library along with managed tests: InstallEHCallback.cs, PInvokeDetach.cs and Thunks.cs to src/tests/Interop/MonoAPI/...
The native library (now called mono-embedding-api-test.c) builds on all platforms where we build native support libraries for the runtime tests.
The managed tests only run on desktop mono configurations for now.
* copy libtest.c from mono to src/tests and add cmake builds
* Make it build with the monoapi project
* remove mono-compiler.h dependency
* Remove dependency on gmodule.h
Had to copy the w32_find_symbol code that searches for a symbol in every module.
* Remove test library eglib dependency
Delete some unrunnable tests.
Copy some basic eglib utilities into the test.
* Move native embedding API test lib to Interop/MonoAPI/Native
* Move install_eh_callback test to src/tests/Interop/MonoAPI/MonoMono
* add issues.targets excludes for MonoAPI tests
Not expected to run on coreclr or mono on wasm or mobile, for now.
* Add PInvokeDetach MonoAPI test
* Return exit code 100 on success
* Change test class names to be unique
* fix win32 and gcc builds
* simplify managed code
* put all the MonoMono tests in a single directory
* Use the new MONO_API_FUNCTION monoapi headers
* compile the native library as C, not C++, same as libtest.c in the past
* delete many unused test functions
* delete unused utilities
* Add Thunks.cs tests
* Use a common setup method to probe for symbols
* simplify the native test library
* Make the PInvokeDetach native code sleep less
* add MIT banner
* skip Thunks test on AOT
In the mono/mono repo that test was not expected to work with AOT
Stephen Toub [Fri, 4 Mar 2022 11:33:07 +0000 (06:33 -0500)]
Use RegexGenerator in System.Private.Xml (#66142)
Viktor Hofer [Fri, 4 Mar 2022 10:53:13 +0000 (11:53 +0100)]
Update Traversal msbuild SDK (#66165)
Fixes https://github.com/dotnet/runtime/issues/66122
Tomáš Rylek [Fri, 4 Mar 2022 10:51:57 +0000 (11:51 +0100)]
Only register composite R2R native image code range once (#65623)
As David Wrighton noticed during an independent investigation,
today CoreCLR runtime logic ends up registering composite image
code range with the execution manager the number of times equal
to the number of component modules of the composite image
accessed at runtime, i.e. ultimately up to over 200 times in case
of the composite framework. This change fixes that by slightly
shuffling the initialization housekeeping chores.
Thanks
Tomas
Fixes: https://github.com/dotnet/runtime/issues/65481
Tomáš Rylek [Fri, 4 Mar 2022 10:50:50 +0000 (11:50 +0100)]
Don't add TestLibrary as a reference to all runtime tests (#66157)
When I was tagging several architecture-dependent runtime tests
with the ConditionalFact attribute, I added CoreCLRTestLibrary
as a general reference. This started causing timeouts in Mono AOT
tests because the library needs to be compiled many times.
As there's only a small number of architecture-dependent tests,
I have modified the change so that the test library is only added
explicitly to architecture-dependent tests.
Fixes: #66083
Thanks
Tomas
Dan Moseley [Fri, 4 Mar 2022 10:28:00 +0000 (03:28 -0700)]
Improve ICU missing msg for Alpine (#66150)
Jay Harris [Fri, 4 Mar 2022 10:03:18 +0000 (02:03 -0800)]
docs(jsonPropertyOrder): correct ctor xmldocs (#66173)
Change the ctor XML docs on JsonPropertyOrderAttribute to property self-reference the JsonPropertyOrderAttribute type.
Kunal Pathak [Fri, 4 Mar 2022 07:00:20 +0000 (23:00 -0800)]
Skip Upper vector save/restore for blocks that THROW (#66109)
* Skip upper vector save/restore if the call doesn't return or the block is a THROW block
* Revert "Disable SuperPMI replay jobs until #65332 is fixed (#66062)"
This reverts commit
eb2fea80c6a4ff8117930b4003391d737f05c686.
* Just skip restore for BBJ_THROW
* Use skipSaveRestore to avoid extra save/restores
* jit format
Elinor Fung [Fri, 4 Mar 2022 06:17:23 +0000 (22:17 -0800)]
Rename `DllImportGenerator` project to `LibraryImportGenerator` (#66029)
madelson [Fri, 4 Mar 2022 04:19:52 +0000 (23:19 -0500)]
Avoid Attribute.GetCustomAttributes() returning null for open generic type (#65237)
* Avoid Attribute.GetCustomAttributes() returning null for open generic type.
Fix #64335
Tomas Weinfurt [Fri, 4 Mar 2022 04:15:52 +0000 (20:15 -0800)]
retire DummyTcpServer from SslStream tests (#65876)
* retire DummyTcpServer from SslStream test
* fix build
* feedback from review
Jose Perez Rodriguez [Fri, 4 Mar 2022 03:56:22 +0000 (19:56 -0800)]
Fix System.IO.Ports native package not getting published any longer after the oob + sfx split (#66176)
Aaron Robinson [Fri, 4 Mar 2022 01:10:06 +0000 (17:10 -0800)]
Update the StubManager for better debugger stepping. (#65947)
* Update various comments and logging
* The StubManager is now aware of InstantiatingMethods in IL Stub
and StubLink scenarios
Created the concept of a "StepThroughStub". This handles cases where
the stub should be treated like as an implementation details and
simply forward to the appropriate target.
Updates to various logging mechanisms.
* Reorganize the ILStubType logic between DynamicMethodDesc and ILStubResolver.
Matthias Kruk [Fri, 4 Mar 2022 00:09:12 +0000 (09:09 +0900)]
Add RIDs for MIRACLE LINUX 8 and 9 (#61304)
Whenever we build dotnet RPMs for MIRACLE LINUX 8 (formerly Asianux Server 8) we have to
apply patches that add RIDs for MIRACLE LINUX. To streamline the build process, we would
like to add our RIDs to the upstream sources, in the same way CentOS and other RHEL-
derivatives do.
This commit adds the following runtime IDs:
- "miraclelinux"
- "miraclelinux-x64"
- "miraclelinux.8"
- "miraclelinux.8-x64"
- "miraclelinux.9"
- "miraclelinux.9-x64"
SingleAccretion [Thu, 3 Mar 2022 22:59:13 +0000 (01:59 +0300)]
Fix copy propagation (#66070)
Now that we don't push defs for shadowed parameters, we don't want to pop them as well.
Miha Zupan [Thu, 3 Mar 2022 22:57:56 +0000 (14:57 -0800)]
Use a unique EventId for Verbose in NetEventSource.Common (#66158)