Kay Sievers [Sun, 20 Oct 2013 22:38:19 +0000 (00:38 +0200)]
bus: remove static introspection file export
Kay Sievers [Sun, 20 Oct 2013 22:18:00 +0000 (00:18 +0200)]
bus: allow to specify NULL as an empty string to add
Colin Walters [Sun, 20 Oct 2013 20:02:26 +0000 (16:02 -0400)]
log: Fix previous commit to use correct level
Kay Sievers [Sun, 20 Oct 2013 19:17:55 +0000 (21:17 +0200)]
log: avoid calling the logging functions for log levels above the current maximum
Messages with log levels above the current maximum log level will be dropped
inside log_meta(). But to be able to call the function, all parameters for
the function need to be provided. This can easily get expensive, if values
need to be calculated or functions are used in parameters.
Avoid all useless work by checking inside the macro, before we look
at any parameters passed to the logging functions.
Kay Sievers [Sun, 20 Oct 2013 14:58:04 +0000 (16:58 +0200)]
build-sys: unify foo_CFLAGS = usage and add explaining comments
Always add the default AM_CFLAGS first.
If variables are used in conditionals, the default assignment
of AM variables is disabled, even when the conditional is not
in use; foo_CFLAGS = $(AM_CFLAGS) is needed, even when it looks
like a no-op.
Colin Walters [Sun, 20 Oct 2013 13:53:05 +0000 (09:53 -0400)]
Revert "build-sys: move journalctl CFLAGS= to one line"
This reverts commit
e5d5aa1d0f4e143f12f5e00ca072547369d37e53; it
breaks if !HAVE_QRENCODE since then we aren't using $(AM_CFLAGS) for
journalctl.
Kay Sievers [Sun, 20 Oct 2013 02:27:30 +0000 (04:27 +0200)]
vimrc: disable -fdiagnostics-color output
David Strauss [Sun, 20 Oct 2013 00:11:36 +0000 (17:11 -0700)]
socket-proxyd: Remove datagram research TODO. This proxy will not work with them.
David Strauss [Sun, 20 Oct 2013 00:05:42 +0000 (17:05 -0700)]
socket-proxyd: Comment and log text cleanup.
* Standardize on "nonblocking" spelling, per Linux man pages.
* Clarify that the nonblocking sockets are never in a "blocking"
or "unblocked" state, just a "would block" or "ready" state.
Kay Sievers [Sat, 19 Oct 2013 23:16:32 +0000 (01:16 +0200)]
man: systemd-fstab-generator - remove <term>
Element term in namespace '' encountered in para, but no template matches.
Kay Sievers [Sat, 19 Oct 2013 23:12:29 +0000 (01:12 +0200)]
hwdb: update
Kay Sievers [Sat, 19 Oct 2013 23:10:49 +0000 (01:10 +0200)]
socket-proxyd: initialize variable used in error code path
Kay Sievers [Sat, 19 Oct 2013 22:59:53 +0000 (00:59 +0200)]
build-sys: move journalctl CFLAGS= to one line
Tom Gundersen [Sat, 19 Oct 2013 17:28:21 +0000 (19:28 +0200)]
trivial: rfkill - don't include util.h twice
Colin Walters [Sat, 19 Oct 2013 13:02:01 +0000 (09:02 -0400)]
trivial: rfkill: It's util.h, not utils.h
How about we actually run make locally before pushing, eh?
Tom Gundersen [Sat, 19 Oct 2013 10:33:47 +0000 (12:33 +0200)]
man: fix typos in backlight/rfkill page
/me must learn to also test manpage changes
Tom Gundersen [Sat, 19 Oct 2013 10:23:41 +0000 (12:23 +0200)]
TODO: update
Tom Gundersen [Sat, 19 Oct 2013 10:13:25 +0000 (12:13 +0200)]
udev-builtin: uaccess - inherit logging form udev
Not that it makes a difference in this builtin, but otherwise /etc/udev/udev.conf is not respected.
Tom Gundersen [Sat, 19 Oct 2013 09:38:42 +0000 (11:38 +0200)]
fsck-root: only run when requested in fstab
fsck-root is redundant in case an initrd is used, or in case the rootfs
is never remounted 'rw', so the new default is the correct behavior for
most users. For the rest, they should enable it in fstab.
Tom Gundersen [Sat, 5 Oct 2013 15:32:21 +0000 (17:32 +0200)]
efi-boot-generator: hookup to fsck
Tom Gundersen [Sat, 5 Oct 2013 15:28:09 +0000 (17:28 +0200)]
mount/service: drop FsckPassNo support
We now treat passno as boleans in the generators, and don't need this any more. fsck itself
is able to sequentialize checks on the same local media, so in the common case the ordering
is redundant.
It is still possible to force an order by using .d fragments, in case that is desired.
Thomas Bächler [Sun, 29 Sep 2013 23:34:46 +0000 (01:34 +0200)]
Remove FsckPassNo from systemd-fsck-root.service
Thomas Bächler [Sun, 29 Sep 2013 23:34:45 +0000 (01:34 +0200)]
gpt-auto-generator: Generate explicit dependencies on systemd-fsck@.service instead of using FsckPassNo
[tomegun: check for OOM]
Thomas Bächler [Sun, 29 Sep 2013 23:34:44 +0000 (01:34 +0200)]
fstab-generator: Generate explicit dependencies on systemd-fsck@.service instead of using FsckPassNo
[tomegun:
* order all fsck instances after fsck-root
* check for OOM
* added notes in the manpages]
Thomas Bächler [Sun, 29 Sep 2013 22:32:33 +0000 (00:32 +0200)]
fstab-generator: When parsing the root= cmdline option, set FsckPassNo to 1
[tomegun: without this we would never fsck the rootfs if it was directly
mounted 'rw' from the initrd. We now risk fsck'ing it twice in the case it
is mounted 'ro', so that should be addressed in a separate patch.]
Tom Gundersen [Fri, 18 Oct 2013 22:46:07 +0000 (00:46 +0200)]
kerne-command-line: introduce option 'systemd.restore_state'
When set to 0 this will stop tools like the backlight and rfkill tools to
restore state from previous boot. This is useful in case the stored state
is bogus to the extent that it is preventing you from resetting it (e.g.,
the backlight settings cause the screen to be off on boot on a system where
the backlight can not be adjusted directly from the keyboard).
Tom Gundersen [Fri, 18 Oct 2013 19:17:50 +0000 (21:17 +0200)]
TODO: add some fsck items
Colin Walters [Fri, 18 Oct 2013 14:13:52 +0000 (10:13 -0400)]
build-sys: Honor CFLAGS for journalctl again
Regression from
e905a456814eadfb904c49241e3841c1e4a1d119.
Lennart Poettering [Fri, 18 Oct 2013 12:21:36 +0000 (14:21 +0200)]
build-sys: fix += vs = in Makefile
Lennart Poettering [Fri, 18 Oct 2013 12:06:56 +0000 (14:06 +0200)]
bus: if we hit the end of an array container return 0 as EOF indicator when reading it
Tom Gundersen [Mon, 12 Aug 2013 00:51:56 +0000 (02:51 +0200)]
update-utmp: port to sd-bus
Change from GetUnit to LoadUnit to make sure we can detect the current legacy
runlevel, even if nothing loaded the legacy target files yet.
Lennart Poettering [Fri, 18 Oct 2013 00:40:26 +0000 (02:40 +0200)]
socket-proxyd: rename from saproxy
The thing is a daemon, hence needs a "d" prefix. Also, we tend to not
abbreviate names of background components unnecessarily, since they are
not primary commands people type. Then, the fact that this thing does
socket actviation is mostly in implementationd detail for the proxy.
Also, do some minor indenting clean-ups and other code updates.
Lennart Poettering [Fri, 18 Oct 2013 00:37:38 +0000 (02:37 +0200)]
build-sys: drop a number CFLAGS assignments in Makefile that are pointless
Lennart Poettering [Thu, 17 Oct 2013 23:43:11 +0000 (01:43 +0200)]
bus: automatically flush bus queue when we exit the event loop
This way, we do not have to call it manually
Tom Gundersen [Sun, 11 Aug 2013 23:50:03 +0000 (01:50 +0200)]
initctl: port to sd-bus
Tom Gundersen [Sun, 11 Aug 2013 22:57:16 +0000 (00:57 +0200)]
cgroup-agent: port to sd-bus
Tom Gundersen [Sun, 11 Aug 2013 22:35:49 +0000 (00:35 +0200)]
fsck: port to sd-bus
Lennart Poettering [Thu, 17 Oct 2013 22:48:00 +0000 (00:48 +0200)]
timedated: disable debug logging
Lennart Poettering [Thu, 17 Oct 2013 22:47:41 +0000 (00:47 +0200)]
hostnamed: port over from libdbus to libsystemd-bus
Dave Reisner [Thu, 17 Oct 2013 00:24:11 +0000 (20:24 -0400)]
sd-event: initialize return value
src/libsystemd-bus/sd-event.c:1597:13: warning: 'r' may be used
uninitialized in this function [-Wmaybe-uninitialized]
David Strauss [Thu, 17 Oct 2013 20:19:29 +0000 (13:19 -0700)]
Fix kmod error message to have correct version requirement
Tom Gundersen [Thu, 17 Oct 2013 17:49:19 +0000 (19:49 +0200)]
static-nodes: don't call mkdir
This is no longer necessary with kmod-15. Bump the requirement.
Kay Sievers [Thu, 17 Oct 2013 01:20:46 +0000 (03:20 +0200)]
tmpfiles: log unaccessible FUSE mount points only as debug message
Lennart Poettering [Wed, 16 Oct 2013 23:03:39 +0000 (01:03 +0200)]
timedated: expose time and NTP sync flag via the bus
This way, timedatectl can be run over the network and determine all
properties correctly from the server rather than the client.
Lennart Poettering [Wed, 16 Oct 2013 15:00:13 +0000 (17:00 +0200)]
api: unify some common bits used by public systemd APIs
Lennart Poettering [Wed, 16 Oct 2013 14:57:49 +0000 (16:57 +0200)]
timedate: expose RTC time
Since access to the RTC is privileged expose the current RTC time as bus
property so that unprivileged clients can read it.
Lennart Poettering [Wed, 16 Oct 2013 14:55:01 +0000 (16:55 +0200)]
bus: fix default exit on idle timeout
David Strauss [Wed, 16 Oct 2013 12:12:16 +0000 (05:12 -0700)]
sabridge: Makefile should be a symlink
David Strauss [Wed, 16 Oct 2013 11:04:43 +0000 (04:04 -0700)]
saproxy: man page formatting and terminology fixes
Lennart Poettering [Wed, 16 Oct 2013 04:10:04 +0000 (06:10 +0200)]
timedated: use libsystemd-bus instead of libdbus for bus communication
Among other things this also adds a few things necessary for the change:
- Considerably more powerful error returning APIs in libsystemd-bus
- Adapter for connecting an sd_bus to an sd_event
- As I reworked the PolicyKit logic to the new library I also made it
asynchronous, so that PolicyKit requests of one user cannot block out
another user anymore.
- We always use the macro names for common bus error. That way it is
harder to mistype them since the compiler will notice
Lennart Poettering [Wed, 16 Oct 2013 04:04:20 +0000 (06:04 +0200)]
bus: return 1 on all calls that send messages
This way they are nicer to use from method dispatch callbacks as last
call, since method dispatch callbacks expect > 0 return if the message
got handled.
Lennart Poettering [Wed, 16 Oct 2013 04:01:46 +0000 (06:01 +0200)]
bus: make sure sd_bus_get_timeout() returns a 0 timeout of there are already read but not dispatched messages
Lennart Poettering [Wed, 16 Oct 2013 03:59:21 +0000 (05:59 +0200)]
bus: fix generate introspection XML
Lennart Poettering [Wed, 16 Oct 2013 03:58:28 +0000 (05:58 +0200)]
bus: extend bus protocol definitions a bit
Lennart Poettering [Wed, 16 Oct 2013 03:57:41 +0000 (05:57 +0200)]
event: handle arbitrary signals received during epoll gracefully
Lennart Poettering [Wed, 16 Oct 2013 03:57:05 +0000 (05:57 +0200)]
event: properly disarm timers when we don't need them anymore
Lennart Poettering [Wed, 16 Oct 2013 03:56:37 +0000 (05:56 +0200)]
event: fix sd_event_source_set_io_events()
Lennart Poettering [Wed, 16 Oct 2013 01:17:09 +0000 (03:17 +0200)]
macro: clean up usage of gcc attributes
Always use our own macros, and name all our own macros the same style.
Lennart Poettering [Wed, 16 Oct 2013 00:51:24 +0000 (02:51 +0200)]
rules: don't limit some of the rules to the "add" action
Devices should show up in systemd regardless whether the user invoked
"udevadm trigger" or not. Before this change some devices might have
suddenly disappeared due issuing that command.
Lennart Poettering [Wed, 16 Oct 2013 00:49:54 +0000 (02:49 +0200)]
rules: expose loop block devices to systemd
Since the kernel no longer exposes a large number of "dead" loop devices
it is OK to expose them now in systemd, so let's do that. This has the
benefit that mount dependencies on loop devices start to work.
David Strauss [Wed, 16 Oct 2013 01:55:25 +0000 (18:55 -0700)]
saproxy: Fix for systemd's event library not deduping fds.
David Strauss [Wed, 16 Oct 2013 00:29:51 +0000 (17:29 -0700)]
Bump up the saproxy buffer to 16kB.
David Strauss [Wed, 16 Oct 2013 00:00:18 +0000 (17:00 -0700)]
Rename sabridge to saproxy to be less cryptic
David Strauss [Tue, 15 Oct 2013 23:25:45 +0000 (16:25 -0700)]
Update TODOs with follow-up sabridge work.
David Strauss [Mon, 14 Oct 2013 23:41:47 +0000 (16:41 -0700)]
Add sabridge for socket activation of traditional daemons
David Herrmann [Tue, 15 Oct 2013 19:13:39 +0000 (21:13 +0200)]
logind: allow unprivileged session-device access
The session-device/control API was introduced for unprivileged device
access from within a session. Add the required dbus policy to the default
logind policies.
Note: logind validates that only root and the user of a session can
use the API. Furthermore, only a single API user gets access at a time.
Jan Engelhardt [Tue, 15 Oct 2013 06:58:50 +0000 (08:58 +0200)]
man: document the -b special boot option
Igor Zhbanov [Tue, 15 Oct 2013 10:35:13 +0000 (14:35 +0400)]
Fix for SIGSEGV in systemd-bootchart on short-living processes
The function svg_ps_bars() dereferencess NULL pointer in the line
endtime = ps->last->sampledata->sampletime;
because of partially initialized ps_struct (ps->last == NULL).
If some process terminates between scaning /proc directory in the log_sample()
function and reading additional information from /proc/PID/... files,
the files couldn't be read, the loop will be continued and partially
initialized structure returned.
Jan Engelhardt [Tue, 15 Oct 2013 06:58:51 +0000 (08:58 +0200)]
man: wording and grammar updates
This is a recurring submission and includes corrections to various
issue spotted. I guess I can just skip over reporting ubiquitous comma
placement fixes…
Anatol Pomozov [Mon, 14 Oct 2013 23:12:29 +0000 (16:12 -0700)]
Fix misspellings with codespell tool
Kay Sievers [Tue, 15 Oct 2013 00:26:37 +0000 (02:26 +0200)]
build-sys: libsystemd-id128 - get rid of the needless selinux linking (again)
$ ldd libsystemd-id128.so
linux-vdso.so.1 => (0x00007fffce377000)
libselinux.so.1 => /lib64/libselinux.so.1 (0x00007f4de1fc1000)
librt.so.1 => /lib64/librt.so.1 (0x00007f4de1db9000)
libdl.so.2 => /lib64/libdl.so.2 (0x00007f4de1bb4000)
libc.so.6 => /lib64/libc.so.6 (0x00007f4de17f5000)
/lib64/ld-linux-x86-64.so.2 (0x00007f4de2406000)
libpcre.so.1 => /lib64/libpcre.so.1 (0x00007f4de158f000)
libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f4de1371000)
$ ldd libsystemd-id128.so
linux-vdso.so.1 => (0x00007fff25187000)
libdl.so.2 => /lib64/libdl.so.2 (0x00007f41a3964000)
libc.so.6 => /lib64/libc.so.6 (0x00007f41a35a5000)
/lib64/ld-linux-x86-64.so.2 (0x00007f41a3d89000)
Kay Sievers [Tue, 15 Oct 2013 00:11:56 +0000 (02:11 +0200)]
build-sys: libudev - get rid of the needless selinux linking (again)
Zbigniew Jędrzejewski-Szmek [Mon, 14 Oct 2013 23:15:24 +0000 (19:15 -0400)]
Fix bad assert in show_pid_array
This function should get the same treatment as other qsort uses
did in 7ff7394 "Never call qsort on potentially NULL arrays".
Reported-by: Oleksii Shevchuk <alxchk@gmail.com>
Lennart Poettering [Mon, 14 Oct 2013 19:58:06 +0000 (21:58 +0200)]
bus: properly handle if new objects are installed in the node tree while we are dispatching to one
Lennart Poettering [Mon, 14 Oct 2013 17:53:56 +0000 (19:53 +0200)]
bus: make sure that we always keep a ref to the bus when we dispatch callbacks
Otherwise the callback might unref the bus we are processing and destroy
the object while we are processing it.
Lennart Poettering [Mon, 14 Oct 2013 17:40:37 +0000 (19:40 +0200)]
bus: use assert_return() for more API calls
Lennart Poettering [Mon, 14 Oct 2013 17:02:11 +0000 (19:02 +0200)]
git: add test-ellipsize to files to ignore by git
Lennart Poettering [Mon, 14 Oct 2013 17:01:09 +0000 (19:01 +0200)]
backlight: include ID_PATH in file names for backlight settings
Much like for rfkill devices we should provide some stability regarding
enumeration order, hence include the stable bits of the device path in
the file name we store settings under.
Lennart Poettering [Mon, 14 Oct 2013 16:52:07 +0000 (18:52 +0200)]
rfkill: use ID_PATH as identifier for rfkill state files
Let's include the stable device path for the rfkill devices in the name
of the file we store the rfkill state in, so that we have some stability
regarding enumeration order.
Bastien Nocera [Mon, 14 Oct 2013 06:15:51 +0000 (08:15 +0200)]
shared/util: Fix glob_extend() argument
glob_extend() would completely fail to work, or return incorrect
data if it wasn't being passed the current getopt "optarg" variable
as it used the global variable, instead of the passed parameters.
Lennart Poettering [Mon, 14 Oct 2013 04:10:14 +0000 (06:10 +0200)]
list: make our list macros a bit easier to use by not requring type spec on each invocation
We can determine the list entry type via the typeof() gcc construct, and
so we should to make the macros much shorter to use.
Lennart Poettering [Mon, 14 Oct 2013 02:59:26 +0000 (04:59 +0200)]
util: allow trailing semicolons on define_trivial_cleanup_func lines
Emacs C indenting really gets confused by these lines if they carry no
trailing semicolon, hence let's make this nicer for good old emacs. The
other macros which define functions already do this too, so let's copy
the scheme here.
Also, let's use an uppercase name for the macro. So far our rough rule
was that macros that are totally not function-like (like this ones,
which define a function) are uppercase. (Well, admittedly it is a rough
rule only, for example function and variable decorators are all
lower-case SINCE THE CONSTANT YELLING IN THE SOURCES WOULD SUCK, and
also they at least got underscore prefixes.) Also, the macros that
define functions that we already have are all uppercase, so let's do the
same here...
Lennart Poettering [Mon, 14 Oct 2013 02:52:51 +0000 (04:52 +0200)]
update TODO
Mantas Mikulėnas [Wed, 9 Oct 2013 11:57:12 +0000 (14:57 +0300)]
manager: connect to private bus even if $DBUS_SESSION_BUS_ADDRESS is not set
Because that's exactly the kind of situation where the private bus is
necessary.
Lennart Poettering [Mon, 14 Oct 2013 02:31:49 +0000 (04:31 +0200)]
rfkill: add new rfkill tool to save/restore rfkill state across reboots
This works analogous to the existing backlight and random seed services
Lennart Poettering [Mon, 14 Oct 2013 00:12:52 +0000 (02:12 +0200)]
backlight: always prefer "firmware"/"platform" backlights over "raw" backlights if we have both for the same device
Zbigniew Jędrzejewski-Szmek [Sun, 13 Oct 2013 23:43:19 +0000 (19:43 -0400)]
man: add more markup to udevadm(8)
Zbigniew Jędrzejewski-Szmek [Sun, 13 Oct 2013 21:41:24 +0000 (17:41 -0400)]
event: avoid derefencing null pointer
Zbigniew Jędrzejewski-Szmek [Sun, 13 Oct 2013 21:40:34 +0000 (17:40 -0400)]
bus: make sure we don't try to malloc 0 bytes
Zbigniew Jędrzejewski-Szmek [Sun, 13 Oct 2013 00:28:21 +0000 (20:28 -0400)]
Introduce udev object cleanup functions
Zbigniew Jędrzejewski-Szmek [Sat, 12 Oct 2013 23:50:54 +0000 (19:50 -0400)]
gitignore: ignore clang --analyze output
Zbigniew Jędrzejewski-Szmek [Sat, 12 Oct 2013 17:43:07 +0000 (13:43 -0400)]
Make sure that we don't dereference NULL
The code was actually safe, because b should
never be null, because if rvalue is empty, a different
branch is taken. But we *do* check for NULL in the
loop above, so it's better to also check here for symmetry.
Zbigniew Jędrzejewski-Szmek [Fri, 11 Oct 2013 23:34:21 +0000 (19:34 -0400)]
udev: use initialization instead of zeroing in one place
Zbigniew Jędrzejewski-Szmek [Fri, 11 Oct 2013 23:34:17 +0000 (19:34 -0400)]
Fix write-only use of a few variables
Since the invention of read-only memory, write-only memory has been
considered deprecated. Where appropriate, either make use of the
value, or avoid writing it, to make it clear that it is not used.
Zbigniew Jędrzejewski-Szmek [Fri, 11 Oct 2013 23:33:48 +0000 (19:33 -0400)]
Introduce _cleanup_fdset_free_
Zbigniew Jędrzejewski-Szmek [Fri, 11 Oct 2013 23:33:43 +0000 (19:33 -0400)]
bus: fix access to unitialized variable in error path
src/machine/machined-dbus.c:237:13: warning: Branch condition evaluates to a garbage value
if (m)
^
Zbigniew Jędrzejewski-Szmek [Fri, 11 Oct 2013 23:33:36 +0000 (19:33 -0400)]
drop-ins: check return value
If the function failed, nothing serious would happen
because unlink would probably return EFAULT, but this
would obscure the real error and is a bit sloppy.
Zbigniew Jędrzejewski-Szmek [Fri, 11 Oct 2013 23:33:30 +0000 (19:33 -0400)]
journald: use greedy_realloc in one place
Zbigniew Jędrzejewski-Szmek [Fri, 11 Oct 2013 23:33:20 +0000 (19:33 -0400)]
dbus-common: avoid leak in error path
src/shared/dbus-common.c:968:33: warning: Potential leak of memory pointed to by 'l'
return -EINVAL;
^~~~~~
Zbigniew Jędrzejewski-Szmek [Sat, 12 Oct 2013 16:15:49 +0000 (12:15 -0400)]
Modernization
Fixes minor leak in error path in device.c.