Stephen Toub [Fri, 20 Mar 2020 13:58:40 +0000 (09:58 -0400)]
Annotate System.Runtime.WindowsRuntime for nullable reference types (#33692)
Tomas Weinfurt [Fri, 20 Mar 2020 13:31:49 +0000 (06:31 -0700)]
rework locking in SslStream to support TLS1.3 (#32925)
* initial locking
* feedback from review
* update _handshakeWaiter
* feedback from review
* feedback from review
* feedback from review
monojenkins [Fri, 20 Mar 2020 12:21:41 +0000 (08:21 -0400)]
Updating the Copyright line display when running 'mono --version' (#32910)
Removes the copyright year.
```
$ mono --version
Mono JIT compiler version 6.6.0.166 (2019-08/
d9001b5ae70 Wed Feb 12 19:20:16 EST 2020)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
TLS:
SIGSEGV: altstack
Notification: kqueue
Architecture: amd64
Disabled: none
Misc: softdebug
Interpreter: yes
LLVM: yes(610)
Suspend: hybrid
GC: sgen (concurrent by default)
```
Co-authored-by: ivancitin <ivancitin@users.noreply.github.com>
monojenkins [Fri, 20 Mar 2020 12:21:27 +0000 (08:21 -0400)]
[debugger] Fix NOT_IMPLEMENTED while debugging. (#33702)
- Changed the behavior on debugger-agent, if we can't parse the new behavior is to return invalid_argument and not assert and stop debugging
- Changed the mono_domain_set_fast before return from assembly_commands.
- Add error message when return INVALID_ARGUMENT
Fixes mono/mono#19146
Co-authored-by: thaystg <thaystg@users.noreply.github.com>
monojenkins [Fri, 20 Mar 2020 12:08:15 +0000 (08:08 -0400)]
Remove dead code from bug-10127.cs. (#31976)
Co-authored-by: jaykrell <jaykrell@users.noreply.github.com>
monojenkins [Fri, 20 Mar 2020 12:01:18 +0000 (08:01 -0400)]
[FreeBSD] Fix for libinotify support and compile (#33607)
Resolves mono/mono#18528 in for both detection and compiling. This should backport cleanly to next release.
Tested on 12.1-RELEASE with libinotify; configure detects features correctly, compiles successfully, resolves some observed issues during run.
```
#define HAVE_SYS_INOTIFY_H 1
#define HAVE_LIBINOTIFY 1
#define HAVE_INOTIFY_INIT 1
#define HAVE_INOTIFY_ADD_WATCH 1
#define HAVE_INOTIFY_RM_WATCH 1
#define HAVE_INOTIFY 1
```
Co-authored-by: rootwyrm <rootwyrm@users.noreply.github.com>
Jan Vorlicek [Fri, 20 Mar 2020 08:43:51 +0000 (09:43 +0100)]
Fix R2RDump generic signature parsing (#33825)
The signature parsing wasn't handling module overrides correctly. For
generic type parameters, the current module needs to be reset to the
outer module.
Jeremy Koritzinsky [Fri, 20 Mar 2020 05:37:06 +0000 (22:37 -0700)]
Don't pass the managed array object down when clearing a native array field. (#33830)
* Don't pass the managed array object down when clearing a native array field.
* Add test.
Kevin Jones [Fri, 20 Mar 2020 02:35:42 +0000 (22:35 -0400)]
Use ReadOnlySpan<byte> for defaultDerInit (#33828)
* Use ReadOnlySpan for defaultDerInit.
This removes an array allocation for each type initializer.
* Regenerate files.
Layomi Akinrinade [Fri, 20 Mar 2020 02:10:28 +0000 (19:10 -0700)]
Reactivate JsonSerializer polymorphic tests (#33815)
dotnet-maestro[bot] [Fri, 20 Mar 2020 01:04:47 +0000 (21:04 -0400)]
[master] Update dependencies from dotnet/arcade mono/linker Microsoft/vstest (#33750)
* Update dependencies from https://github.com/dotnet/arcade build
20200318.2
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20168.2
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20168.2
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20168.2
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20168.2
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20168.2
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20168.2
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20168.2
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20168.2
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20168.2
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20168.2
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20168.2
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20168.2
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20168.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20168.2
* Update dependencies from https://github.com/mono/linker build
20200319.1
- ILLink.Tasks - 0.1.6-prerelease.20169.1
* Update dependencies from https://github.com/microsoft/vstest build
20200318-01
- Microsoft.NET.Test.Sdk - 16.6.0-preview-
20200318-01
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Tomáš Rylek [Fri, 20 Mar 2020 00:24:17 +0000 (01:24 +0100)]
New attempt at enabling Windows ARM32 runs (#32819)
Omair Majid [Fri, 20 Mar 2020 00:23:36 +0000 (20:23 -0400)]
Fix src/libraries to build on clang 10 (#33734)
Clang 10 enable new warnings, some of which is affecting the
src/libraries code.
Clang 10 has added `-Walloca` to warn about uses of `alloca`. This
commit replaces the only non-compliant use of that with a single fixed
stack-allocated buffer.
Clang 10 has also added `-Wimplicit-int-float-conversion`. This commit
uses explicit casts to double to avoid the warnings.
Fixes #33681
Also contains a small fix for slist.h that was somehow missed in #33096.
After this commit, I can build all of runtime with Clang 10.
Aleksey Kliger (λgeek) [Thu, 19 Mar 2020 23:00:09 +0000 (19:00 -0400)]
[mono] Enter GC Unsafe mode in some string allocation functions (#33754)
All these functions are MONO_RT_EXTERNAL_ONLY and they all allocate managed
objects.
Fixes a coop state machine assertion if an embedder calls the function and it needs to take the GC
lock to do a collection.
Egor Bogatov [Thu, 19 Mar 2020 22:29:59 +0000 (01:29 +0300)]
Don't crash with SO for AdvSimd.IsSupported (#33761)
Jo Shields [Thu, 19 Mar 2020 20:39:37 +0000 (16:39 -0400)]
Make "iOS" not part of "all" to avoid some outerloop assumptions (#33811)
Julien Couvreur [Thu, 19 Mar 2020 18:31:17 +0000 (11:31 -0700)]
Add MemberNotNull/When attributes (#33567)
* Add MemberNotNull/When attributes
* Apply [CLSCompliant(false)]
* Fix typos and indent
* Move [CLSCompliant(false)] and remove AllowMultiple
* Declare attributes in ref file
* Store parameters into readonly properties
* Don't use deconstruction
* Qualify, move properties, remove this
David Wrighton [Thu, 19 Mar 2020 16:29:19 +0000 (09:29 -0700)]
Unify instruction set definition (#33730)
* Unify instruction set definition
- Build simple DSL to describe the instruction set support of the compiler/jit/etc
- Parse DSL and produce data structures useable throughout our compilation environment
- This is in support of adding more granular instruction set support to crossgen2, but this change is pulled out into its own PR to ease reviewing cost
- Make it hard to mess up 64bit instruction set variants by adding helper function to fill them in.
- Add 64 bit variant names to 32bit instruction set enum to remove the need to add a large number of #ifdefs to the jit
Alexander Nikolaev [Thu, 19 Mar 2020 14:37:00 +0000 (15:37 +0100)]
Enable HTTP/2 client cert authentication in WinHttpHandler (#33158)
Pre-release WinHTTP's version supports client cert authentication over HTTP/2, but the feature must be explicitly opted-in. PR sets WINHTTP_OPTION_ENABLE_HTTP2_PLUS_CLIENT_CERT to TRUE before invoking WinHttpConnect if the request's protocol is HTTP/2 and scheme is HTTPS.
This PR also enables all HTTP 1.1 tests for WinHttpHandler on .Net Core and Framework and the most of HTTP/2 tests on .Net Core.
Matt Mitchell [Thu, 19 Mar 2020 14:30:25 +0000 (07:30 -0700)]
Exclude packages from checksum generation (#33722)
- Remove PreparedArtifacts upload
- Alter the ItemGroup for artifacts that have checksums generated to not include nuget or symbol packages
Egor Bogatov [Thu, 19 Mar 2020 11:00:23 +0000 (14:00 +0300)]
Bump global.json dotnet version (#33735)
monojenkins [Thu, 19 Mar 2020 10:38:35 +0000 (06:38 -0400)]
[runtime] Fix the mapping of 'int' in jit icall signatures, it should be int32 not native int. (#33711)
Co-authored-by: vargaz <vargaz@users.noreply.github.com>
Egor Bogatov [Thu, 19 Mar 2020 10:29:15 +0000 (13:29 +0300)]
Make iOS sample simulator friendly (#33740)
Johan Lorensson [Thu, 19 Mar 2020 10:01:53 +0000 (11:01 +0100)]
Ignore register unwinder callback for empty patch_info data table on Windows. (#33726)
Running System.Runtime.Serialization.Xml test suite triggers calls to
mono_code_manager_reserve with 0 size code block. On Windows, allocating
code regions from code manager will also add callback for code region
into unwinder function table, but since region could be 0 length,
it will be causing a crash in RtlInstallFunctionTableCallback OS call.
Fix hardens code to not try to register callbacks for code regions
of size 0, since that is considered a critical error by Windows OS API.
Jeremy Barton [Thu, 19 Mar 2020 09:47:05 +0000 (02:47 -0700)]
Remove bad calls to ReferenceEquals (#33739)
All of these calls to ReferenceEquals pass a value type, which gets boxed, and
ReferenceEquals returns false.
Further, all of the calls originated in .NET Framework, so the moderately
expensive way of saying "false" has been there for a while.
* Inline the expression to `false`
* Further inline and remove dead blocks or unnecessary ifs.
* Delete any comments explaining the code, since they're not relevant.
monojenkins [Thu, 19 Mar 2020 08:37:37 +0000 (04:37 -0400)]
[interp] Optimize out intptr ctor (#33720)
Co-authored-by: BrzVlad <BrzVlad@users.noreply.github.com>
Johan Lorensson [Thu, 19 Mar 2020 03:31:29 +0000 (04:31 +0100)]
Mono DISABLE_SIMD define still emits OP codes depending on SIMD support. (#33717)
Fix makes sure runtime checks also report that SIMD has been disabled.
Returning FALSE from is_simd_supported will turn of MONO_OPT_SIMD and
disable all SSE/AVX cpu features will prevent code checking cpu
capabilities to emit SIMD instructions.
Johan Lorensson [Thu, 19 Mar 2020 03:29:17 +0000 (04:29 +0100)]
Fix warning building Mono using -Wint-conversion. (#33723)
Sergey Andreenko [Thu, 19 Mar 2020 01:57:51 +0000 (18:57 -0700)]
Fix SIMD case on arm64 linux with zapDisabled. (#33712)
Egor Chesakov [Thu, 19 Mar 2020 01:31:08 +0000 (18:31 -0700)]
[Arm64] Implement Store Hardware Intrinsic (#33535)
Maryam Ariyan [Thu, 19 Mar 2020 01:25:26 +0000 (18:25 -0700)]
Merge pull request #33678 from maryamariyan/fromoldmaster-di-spec
Brings over history on DI.Specification.Tests from Extensions
Frederik Carlier [Thu, 19 Mar 2020 00:44:56 +0000 (01:44 +0100)]
Update System.Drawing to reflect GDI+ changes (#32873)
* Update System.Drawing to reflect GDI+ changes
- Add support ValueTypePointer encoder parameters
- Support ColorSpace, ImageItems and SaveAsCmyk encoders
* Skip test on NetFx
* Add XML documentation
Andy Ayers [Thu, 19 Mar 2020 00:33:32 +0000 (17:33 -0700)]
Add pipeline setup for jit experimental feature testing (#33709)
Create a pipeline to test functionality in the jit that is not (yet) enabled by default:
* object stack allocation
* eh write through
* on stack replacement (+ osr stress)
* guarded devirtualization
Currently just x64, pri1 tests.
Tomáš Rylek [Wed, 18 Mar 2020 23:59:40 +0000 (00:59 +0100)]
Add support for previously missing helper Check_FieldOffset (#33729)
This failure crashes Crossgen2 build of several framework assemblies
without the large version bubble. I discovered this during my work
on composite build against shared framework where we newly introduce
the notion of two separate large bubbles (app vs. framework).
Thanks
Tomas
Maryam Ariyan [Wed, 18 Mar 2020 22:03:24 +0000 (15:03 -0700)]
Remove DI.Specification csproj
dotnet-maestro[bot] [Wed, 18 Mar 2020 21:47:59 +0000 (17:47 -0400)]
[master] Update dependencies from dotnet/arcade mono/linker Microsoft/vstest (#33718)
* Update dependencies from https://github.com/dotnet/arcade build
20200318.1
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20168.1
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20168.1
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20168.1
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20168.1
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20168.1
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20168.1
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20168.1
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20168.1
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20168.1
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20168.1
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20168.1
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20168.1
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20168.1
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20168.1
* Update dependencies from https://github.com/mono/linker build
20200318.1
- ILLink.Tasks - 0.1.6-prerelease.20168.1
* Update dependencies from https://github.com/microsoft/vstest build
20200317-02
- Microsoft.NET.Test.Sdk - 16.6.0-preview-
20200317-02
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
monojenkins [Wed, 18 Mar 2020 21:47:27 +0000 (17:47 -0400)]
[interp] Inline also constructors of valuetypes (#33632)
Speeds up by 3.5x some span operations. We will likely get even more performance improvement there by adding special handling in interpreter for IntPtr.
Co-authored-by: BrzVlad <BrzVlad@users.noreply.github.com>
monojenkins [Wed, 18 Mar 2020 21:11:54 +0000 (17:11 -0400)]
[interp] Do cfold for a few more unary operators (#33516)
That are accessing the stack value at level -2.
Co-authored-by: BrzVlad <BrzVlad@users.noreply.github.com>
Carlos Sanchez Lopez [Wed, 18 Mar 2020 21:09:31 +0000 (14:09 -0700)]
Fix unexpected exception when enumerating a completely empty drive root (#33684)
* Fix unexpected exception when enumerating a completely empty drive root.
* Address PR suggestions:
- Add NTStatus for file not found.
- Use it in the switch case. Since it's a rare case, add it right above 'default'.
* Remove hidden character causing build failure. It showed up after the file's encoding was changed to UTF8.
Egor Bogatov [Wed, 18 Mar 2020 20:51:47 +0000 (23:51 +0300)]
[mono] Add iOS sample (AOT, arm64) (#33633)
* Add iOS sample
Maryam Ariyan [Wed, 18 Mar 2020 20:51:09 +0000 (13:51 -0700)]
Update src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.Specification.Tests/Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj
Co-Authored-By: Eric StJohn <ericstj@microsoft.com>
Stephen Toub [Wed, 18 Mar 2020 20:49:18 +0000 (16:49 -0400)]
Annotate System.Runtime.WindowsRuntime.UI.Xaml for nullable reference types (#33725)
Andy Ayers [Wed, 18 Mar 2020 20:32:07 +0000 (13:32 -0700)]
JIT: propagate block flags during guarded devirt transform (#33724)
This transform duplicates code that might contain constructs we track via
block flags, so update the block flags.
Fadi Hanna [Wed, 18 Mar 2020 18:03:46 +0000 (11:03 -0700)]
Fix for issue 32731 (#33534)
* Couple of crossgen2 fixes:
1) Fix an issue hitting an assert in the TypeSystem's virtual function resolution
2) Port some inlining rules from crossgen1 - One of them fixes an issue where we would incorrectly inline a virtual method that has a MethodImpl associated with it (test = self_override5)
3) Remove an assert from R2RDump related to the composite work (assert needs to be after loading _readyToRunHeaderRVA, and is actually already at the right place a few lines below)
Johan Lorensson [Wed, 18 Mar 2020 17:34:43 +0000 (18:34 +0100)]
Change Mono runtime to use static linked c-runtime in debug builds. (#33715)
Tomáš Rylek [Wed, 18 Mar 2020 17:13:21 +0000 (18:13 +0100)]
One more fix for running / debugging Crossgen2 under dogfooding VS (#33698)
Juan Hoyos [Wed, 18 Mar 2020 16:08:20 +0000 (09:08 -0700)]
Only add the llvm elf headers on Windows for dbgutil (#33706)
Krzysztof Wicher [Wed, 18 Mar 2020 15:19:25 +0000 (08:19 -0700)]
Support Rfc3279 signature format for DSA and EcDSA (#1612)
This change adds overloads for SignData and SignHash/ComputeSignature on the DSA and ECDsa classes to make it easier for callers that need to use RFC3279's signature format to work with the classes in .NET.
It also moves more temporary work from temporary buffers to stackallocs.
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Johan Lorensson [Wed, 18 Mar 2020 13:35:08 +0000 (14:35 +0100)]
Correct subsetCategory parameter passed to build.cmd on Windows. (#33713)
monojenkins [Wed, 18 Mar 2020 12:50:46 +0000 (08:50 -0400)]
Fix additional constants embedded in instruction stream on AMD64. (#33682)
A couple of more op codes embedded constant values in instruction stream. When using MONO_ARCH_CODE_EXEC_ONLY these needs to be moved into GOT slots.
Thanks @buggeststar for bring the issues to our attention.
Co-authored-by: lateralusX <lateralusX@users.noreply.github.com>
monojenkins [Wed, 18 Mar 2020 09:20:07 +0000 (05:20 -0400)]
Remove useless ip += from MINT_JMP, it is assigned later. (#33548)
Co-authored-by: jaykrell <jaykrell@users.noreply.github.com>
Vladimir Sadov [Wed, 18 Mar 2020 05:00:41 +0000 (22:00 -0700)]
Adding public API for Pinned Object Heap allocations (#33526)
* Adding API for POH allocations and propagating flags all the way to Alloc.
* make `AllocateUninitializedArray` and `AllocateArray` public
* Added NYI implementations to Mono
* moved tests to libraries
* Actually use POH and more tests.
* Disable tests for the new API on mono
* mop up remaining TODOs
* Fix build breaking whitespace.
* Mono tabs and mark heavier tests as [Outerloop]
* Mono space before openning parens and braces
* Refactored AllocateArray
* PR feedback
* XML Doc comments
Jan Kotas [Wed, 18 Mar 2020 03:22:39 +0000 (20:22 -0700)]
Avoid unnecessary use of Linq (#33700)
Aaron Robinson [Wed, 18 Mar 2020 01:48:32 +0000 (18:48 -0700)]
Reverse P/Invoke methods do not support tailcalls. (#33677)
* Disable tailcalls in all scenarios involving a Reverse P/Invoke
dotnet-maestro[bot] [Wed, 18 Mar 2020 01:30:43 +0000 (18:30 -0700)]
[master] Update dependencies from mono/linker dotnet/arcade (#33646)
* Update dependencies from https://github.com/dotnet/arcade build
20200316.1
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20166.1
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20166.1
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20166.1
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20166.1
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20166.1
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20166.1
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20166.1
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20166.1
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20166.1
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20166.1
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20166.1
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20166.1
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20166.1
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20166.1
* Update dependencies from https://github.com/dotnet/arcade build
20200316.3
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20166.3
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20166.3
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20166.3
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20166.3
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20166.3
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20166.3
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20166.3
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20166.3
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20166.3
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20166.3
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20166.3
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20166.3
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20166.3
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20166.3
* Fix nullability warnings due to new compiler
* Update dependencies from https://github.com/mono/linker build
20200316.4
- ILLink.Tasks - 0.1.6-prerelease.20166.4
* PR Feedback
* Update dependencies from https://github.com/dotnet/arcade build
20200317.1
- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.20167.1
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.20167.1
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.20167.1
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20167.1
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.20167.1
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.20167.1
- Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk - 5.0.0-beta.20167.1
- Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk - 5.0.0-beta.20167.1
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.20167.1
- Microsoft.DotNet.GenAPI - 5.0.0-beta.20167.1
- Microsoft.DotNet.GenFacades - 5.0.0-beta.20167.1
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.20167.1
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.20167.1
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.20167.1
* Fix nullability warnings in System.Net.Http
* Use ! instead of pragma warning where we can and fix warning in tests build
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
Jan Kotas [Wed, 18 Mar 2020 00:16:59 +0000 (17:16 -0700)]
Disable warnings-as-errors for release branches (#33664)
Fixes #33627
Matt Galbraith [Tue, 17 Mar 2020 23:48:41 +0000 (16:48 -0700)]
Try UsePythonVersion to work around py2 removal (#33695)
* Try UsePythonVersion to work around py2 removal; Additionally, use hosted pools for windows to deal with lack of python on path
* PR feedback (typos)
Stephen Toub [Tue, 17 Mar 2020 23:37:48 +0000 (19:37 -0400)]
Annotate System.Threading.Tasks.Dataflow for nullable reference types (#33644)
Jo Shields [Tue, 17 Mar 2020 23:19:56 +0000 (19:19 -0400)]
Add AzDO builds for iOS (#33424)
This is based on #33292
Adeel Mujahid [Tue, 17 Mar 2020 23:03:37 +0000 (01:03 +0200)]
Fix native components build for Android (#32800)
* Fix native components build for Android
* Add cmake introspection for pthread_setcancelstate
* Address CR feedback
* Use calculated eth speed for Android
* Use #ifdef FEATURE_EVENT_TRACE
Maryam Ariyan [Tue, 17 Mar 2020 23:01:42 +0000 (16:01 -0700)]
Update src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.Specification.Tests/Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj
Co-Authored-By: Eric StJohn <ericstj@microsoft.com>
Stephen Toub [Tue, 17 Mar 2020 22:54:08 +0000 (18:54 -0400)]
Address follow-up feedback on System.Net.Requests annotations (#33691)
Maryam Ariyan [Tue, 17 Mar 2020 22:15:20 +0000 (15:15 -0700)]
Merge branch 'fromoldmaster-di-spec' of Extensions repo into fromoldmaster-di-spec
Maryam Ariyan [Tue, 17 Mar 2020 21:29:26 +0000 (14:29 -0700)]
Extensions: Incremental additions (#33563)
ref/src/pkg (have no test projects)
Microsoft.Extensions.Caching.Abstractions
Microsoft.Extensions.Configuration.Abstractions
Microsoft.Extensions.DependencyInjection.Abstractions
Microsoft.Extensions.Hosting.Abstractions
Microsoft.Extensions.Logging.Abstractions
ref/src/test/pkg
Microsoft.Extensions.Configuration
Microsoft.Extensions.Configuration.Binder
Microsoft.Extensions.Configuration.CommandLine
Microsoft.Extensions.Configuration.EnvironmentVariables
Microsoft.Extensions.Options.ConfigurationExtensions
Microsoft.Extensions.Options.DataAnnotations
Anirudh Agnihotry [Tue, 17 Mar 2020 19:48:23 +0000 (12:48 -0700)]
Adding missing test project config to .sln file (#33679)
Stephen Toub [Tue, 17 Mar 2020 19:47:58 +0000 (15:47 -0400)]
Annotate System.Net.WebClient for nullable reference types (#33670)
Stephen Toub [Tue, 17 Mar 2020 19:45:17 +0000 (15:45 -0400)]
Annotate System.Net.Requests for nullable reference types (#33630)
Tarek Mahmoud Sayed [Tue, 17 Mar 2020 16:18:35 +0000 (09:18 -0700)]
Fix Reading the Currency Formats (#33599)
* Fix Reading the Currency Formats
* Fix the managed format arrays
* Support formats missing #'s
Vitek Karas [Tue, 17 Mar 2020 12:41:55 +0000 (05:41 -0700)]
Merge pull request #33602 from vitek-karas/AppHostVersionAlways
Include apphost_version parameter in download URLs for both GUI and CLI apps
Stephen Toub [Tue, 17 Mar 2020 10:33:10 +0000 (06:33 -0400)]
Annotate System.Net.WebSockets.Client for nullable reference types (#33625)
Alexis Christoforides [Tue, 17 Mar 2020 10:26:52 +0000 (06:26 -0400)]
Revert "Disable System.Reflection.Emit.Tests in mono (#32201)" (#33641)
This reverts commit
11dcd00c1a77c8da0fe06404609a9c4af9e5da4f.
Anton Lapounov [Tue, 17 Mar 2020 09:28:24 +0000 (02:28 -0700)]
Enable crossgen2smoke test for ARM64 (#33530)
* Enable crossgen2smoke test for ARM64.
* Re-enable NullableWithExplicitLayoutTest sub-test.
* Restore setting the image base removed by #31663.
Aaron Robinson [Tue, 17 Mar 2020 05:35:14 +0000 (22:35 -0700)]
GC coverage can now occur in scenarios where a thread doesn't exist. (#33615)
* GC coverage can now occur in scenarios where a thread doesn't exist.
Properly handle this case and assert some invariant.
* Update gccover.cpp
Misspelled function referenced in comment.
* Remove MethodDesc from GC coverage.
* Code review and fix some asserts when running the Debug version of tests.
* Limit JIT flag manipulation to FEATURE_TIERED_COMPILATION
Santiago Fernandez Madero [Tue, 17 Mar 2020 05:34:50 +0000 (22:34 -0700)]
Use compilerName and compilerArg in pipeline configs (#33605)
Jan Vorlicek [Tue, 17 Mar 2020 05:34:35 +0000 (06:34 +0100)]
Fix Win64 exception propagation in NativeCallable methods (#33653)
A recent change has removed the UMThunkStub usage for native callable
methods. That has broken handling of exceptions propagated from the
managed native callable method into the native caller in case there were
explicit frames below the native frame, like during the GC stress 3.
This change fixes it by unwinding the explicit frames upto the native
frame during the 2nd pass of exception handling when exception unwinding
passes through the frame of a native callable method and isn't handled
there.
Pent Ploompuu [Tue, 17 Mar 2020 05:13:07 +0000 (07:13 +0200)]
Simplify Convert (#33659)
* Simplify Convert
* Optimize Number.UInt32ToDecStr
monojenkins [Tue, 17 Mar 2020 04:51:25 +0000 (00:51 -0400)]
Fix usage of JIT_FLAG_CODE_EXEC_ONLY flag. (#33623)
#19219 didn't convert the JIT flags into options on cfg meaning that code currently checked JIT_FLAG_CODE_EXEC_ONLY never executed. Fix handles the new JIT flag in same way as other JIT flags, converted into bit field on cfg.
With this fix, the following C# method:
```
static double Test()
{
return 1.0f;
}
```
will now generate the following assembly on amd64, when using MONO_ARCH_CODE_EXEC_ONLY:
```
sub rsp,8
mov r11,qword ptr [180003318h]
movsd xmm0,mmword ptr [r11]
add rsp,8
ret
```
Co-authored-by: lateralusX <lateralusX@users.noreply.github.com>
Jan Kotas [Tue, 17 Mar 2020 04:30:03 +0000 (21:30 -0700)]
Delete IExecutionEngine (#33640)
* Delete IExecutionEngine
* Delete InitUtilcode
* Delete cvtres invocation
* Delete cached m_pClrDebugState and fix contract violations
Jan Kotas [Tue, 17 Mar 2020 04:01:45 +0000 (21:01 -0700)]
Delete unused and redundant msbuild properties in coreclr build (#33645)
Aaron Robinson [Tue, 17 Mar 2020 03:22:17 +0000 (20:22 -0700)]
Limit JIT flag manipulation to FEATURE_TIERED_COMPILATION
monojenkins [Tue, 17 Mar 2020 02:23:38 +0000 (22:23 -0400)]
[merp] Add breadcrumb for StackHash (#33635)
Contributes to https://github.com/mono/mono/issues/18715
<!--
Thank you for your Pull Request!
If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.
Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
Co-authored-by: alexischr <alexischr@users.noreply.github.com>
buyaa-n [Tue, 17 Mar 2020 01:06:01 +0000 (18:06 -0700)]
Annotate System.Net.Http for nullable (#33268)
* Annotate System.Net.Http for nullable
monojenkins [Tue, 17 Mar 2020 01:02:22 +0000 (21:02 -0400)]
[jit] Transition the SIMD code to use the MONO_CPU_... set of flags instead of the SIMD_VERSION_... flags. (#33267)
Co-authored-by: vargaz <vargaz@users.noreply.github.com>
Davis Goodin [Tue, 17 Mar 2020 00:33:31 +0000 (18:33 -0600)]
Update area owners: Setup, Infra-installer (#33650)
Andy Ayers [Tue, 17 Mar 2020 00:29:55 +0000 (17:29 -0700)]
Implement simple version of On Stack Replacement (OSR) (#32969)
Add support to runtime and jit to allow switching from unoptimized to
optimized code for a method while the method has active stack frames.
Details in the included document.
Elinor Fung [Tue, 17 Mar 2020 00:02:38 +0000 (17:02 -0700)]
Fix COM + dynamic tests (#33642)
David Mason [Tue, 17 Mar 2020 00:01:08 +0000 (17:01 -0700)]
Revert "Add example profiler that does stack sampling with ICorProfilerInfo10::SuspendRuntime (#32988)" (#33656)
This reverts commit
7a362a03f6e829828b5276ab2bf3f1d3073cc166.
Aaron Robinson [Mon, 16 Mar 2020 23:34:28 +0000 (16:34 -0700)]
Code review and fix some asserts when running the Debug version of tests.
Thomas Gassmann [Mon, 16 Mar 2020 22:18:55 +0000 (23:18 +0100)]
Fix timespan wrap-around when multiplying back by inverse scale
When creating a `TimeSpan` by either dividing, multiplying or using one of
the `From...` methods, the ticks are multiplied by an inverse scale.
When converting the double-precision value back to a long, this
currently causes incorrect values.
This change makes MaxValue work and to allow it to roundtrip.
Ganbarukamo41 [Mon, 16 Mar 2020 22:10:27 +0000 (07:10 +0900)]
Implement Vector.Ceiling / Vector.Floor (#31993)
* Add Ceil/Floor to S.P.CoreLib and expose publicly
* Make Ceil/Floor JIT intrinsic
* Add missing identifier for closing endif
* Add JIT test for Ceil/Floor
* Add test for Ceil/Floor in S.Numerics.Vectors
* Also fix the old path for the new structure
* Apply jit-format
* Do not attempt to treat Ceil/Floor if SSE4.1 isn't available
* Mark Vector<T>.Ceiling/Floor as Intrinsic
* Add missing underscore
* Revert "Add missing idenfitier for closing endif"
* Oops
* Add missing breaks
* Oops, again
* Simplify switch case
* Per review suggestion
Co-Authored-By: Egor Chesakov <egor.chesakov@microsoft.com>
Co-authored-by: Egor Chesakov <egor.chesakov@microsoft.com>
Eirik Tsarpalis [Mon, 16 Mar 2020 22:00:12 +0000 (22:00 +0000)]
[CBOR] Implement Map support for CborReader and CborWriter (#33500)
* Implement map support for CborReader and CborWriter
* fix test naming
* move helper functions to nested type
* check for arithmetic overflow in CborReader.ReadStartMap
* throw FormatExceptions on data items whose definite length exceeds remaining buffer size
Nathan Ricci [Mon, 16 Mar 2020 21:07:31 +0000 (17:07 -0400)]
Changed RuntimeName to the existing RuntimeFlavor property. (#33559)
Change RuntimeName to the exiting RuntimeFlavor property.
Jan Kotas [Mon, 16 Mar 2020 20:13:09 +0000 (13:13 -0700)]
Delete redundant LangVersion properties (#33637)
vitek-karas [Mon, 16 Mar 2020 19:44:45 +0000 (12:44 -0700)]
Update the docs with the change
Jan Kotas [Mon, 16 Mar 2020 18:36:36 +0000 (11:36 -0700)]
Delete unnecessary ReferenceSystemPrivateCoreLib from CoreCLR tests (#33629)
Jan Kotas [Mon, 16 Mar 2020 17:54:49 +0000 (10:54 -0700)]
Replace manually managed TLS slots with regular thread_local statics (#33597)
* Delete TlsIdx_XXX
* Delete EnableTerminationOnHeapCorruption
* Delete redundant cant stop tracking
* Workaround compiler bug
monojenkins [Mon, 16 Mar 2020 15:51:56 +0000 (11:51 -0400)]
[Loader] Change mono_trace level from info to debug (#33104)
Fixes mono/mono#18795
**Testing:**
Created HelloWorld script
Set environment variable `export MONO_LOG_LEVEL=info`
Compiled and executed script before and after these changes were applied
```
mdhwang:~/Desktop$ ls -al csc_*txt mono_*txt
-rw-r--r--@ 1 mdhwang staff 4270 Mar 3 10:12 csc_after.txt
-rw-r--r--@ 1 mdhwang staff 56698 Mar 3 10:14 csc_before.txt
-rw-r--r--@ 1 mdhwang staff 176 Mar 3 10:12 mono_after.txt
-rw-r--r--@ 1 mdhwang staff 3617 Mar 3 10:14 mono_before.txt
```
There is a noticeable difference in log output sizes, and the logs created after the changes were applied mainly contain `Loading reference 0 of _ asmctx _` as desired in the issue.
Co-authored-by: mdh1418 <mdh1418@users.noreply.github.com>
dotnet-maestro[bot] [Mon, 16 Mar 2020 15:37:59 +0000 (16:37 +0100)]
[master] Update dependencies from 3 repositories (#33588)
* Update dependencies from https://github.com/mono/linker build
20200313.2
- ILLink.Tasks - 0.1.6-prerelease.20163.2
* Update dependencies from https://github.com/microsoft/vstest build
20200313-06
- Microsoft.NET.Test.Sdk - 16.6.0-preview-
20200313-06
* Update dependencies from https://github.com/mono/linker build
20200316.1
- ILLink.Tasks - 0.1.6-prerelease.20166.1
* Update dependencies from https://github.com/microsoft/vstest build
20200316-01
- Microsoft.NET.Test.Sdk - 16.6.0-preview-
20200316-01
* Update dependencies from https://github.com/dotnet/llvm-project build
20200316.1
- runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools - 6.0.1-alpha.1.20166.1
- runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk - 6.0.1-alpha.1.20166.1
- runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools - 6.0.1-alpha.1.20166.1
- runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk - 6.0.1-alpha.1.20166.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Roman Marusyk [Mon, 16 Mar 2020 14:39:37 +0000 (16:39 +0200)]
Remove calls to empty RuntimeHelpers.PrepareConstrainedRegions() (#33191)
Fixes #33179
handlespeed [Mon, 16 Mar 2020 11:27:25 +0000 (19:27 +0800)]
Remove unused variable for System.Net.Requests, as part of #30457 (#33619)
src/libraries/System.Net.Requests/src/System/Net/FtpControlStream.cs, remove unused variable 'request' in L414.
Partially Fix #30457