commit-bot@chromium.org [Tue, 6 May 2014 04:49:13 +0000 (04:49 +0000)]
Relaxes bench range upper bound by a bit.
BUG=skia:
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
263373002
git-svn-id: http://skia.googlecode.com/svn/trunk@14585
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 6 May 2014 03:06:53 +0000 (03:06 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14584
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 5 May 2014 22:33:45 +0000 (22:33 +0000)]
Initialize the SkFontConfigInterface singleton with SkOnce.
BUG=chromium:369257
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
269143002
git-svn-id: http://skia.googlecode.com/svn/trunk@14583
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 21:59:52 +0000 (21:59 +0000)]
Add pattern matchers for SkRecord
This is a mid-level library for finding patterns of commands in an SkRecord. At the API level, it's a bit regex inspired. Some examples:
- Pattern1<Is<DrawRect>> matches a single DrawRect
- Pattern1<Star<Is<DrawRect>>> matches 0 or more DrawRects
- Pattern2<Is<ClipRect>, Is<DrawRect>> matches a single clip rect followed by a single draw rect
- Pattern3<Is<Save>, Star<IsDraw>, Is<Restore>> matches a single Save, followed by any number of Draws, followed by Restore
- Pattern1<Or<Is<DrawRect>, Is<ClipRect>>> matches a DrawRect or a ClipRect
- Pattern1<Not<Is<ClipRect>>> matches a command that's notClipRect.
Once you have a pattern, you can call .search() on it to step through ranges of matching commands. This means patterns can replace most of the custom iteration logic for optimization passes: the generic pattern searching steps through all the optimization candidates, which optimization-specific code further inspects and mutates.
SkRecordTraits is now unused. Bye bye!
Generated code and performance of SkRecordOpts is very similar to what it was before. (I had to use SK_ALWAYS_INLINE in a few places to make this so.)
BUG=skia:2378
R=fmalita@chromium.org, bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
263063002
git-svn-id: http://skia.googlecode.com/svn/trunk@14582
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 21:35:09 +0000 (21:35 +0000)]
fix TriColorShader to respect the paint's alpha
results can be seen in new gm: vertices_80
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
270023002
git-svn-id: http://skia.googlecode.com/svn/trunk@14581
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 5 May 2014 20:41:21 +0000 (20:41 +0000)]
new vertices gm to test alpha
git-svn-id: http://skia.googlecode.com/svn/trunk@14580
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 5 May 2014 19:37:22 +0000 (19:37 +0000)]
suppress new composeshader gm for quilt testing
git-svn-id: http://skia.googlecode.com/svn/trunk@14579
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 5 May 2014 19:24:23 +0000 (19:24 +0000)]
Revert r14571 (Infrastructure changes to support pull saveLayers forward task - https://codereview.chromium.org/
266203003) due to breaking Android unit tests
git-svn-id: http://skia.googlecode.com/svn/trunk@14578
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 19:21:16 +0000 (19:21 +0000)]
Allow custom resources in the GrContext's cache
Adds methods to GrContext for client code to store custom resources in
the cache.
BUG=skia:
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
261593009
git-svn-id: http://skia.googlecode.com/svn/trunk@14577
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 19:09:13 +0000 (19:09 +0000)]
Adds a mechanism for GrCacheable objects to notify the resource cache
when their size has changed. GrResourceCacheEntry now holds a
reference to the cache, and a cached value of the resource's most
recent size.
Also utilizes this new functionality for mipmaps, and adds a test for
changing resource sizes.
R=bsalomon@google.com, robertphillips@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
257093002
git-svn-id: http://skia.googlecode.com/svn/trunk@14576
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 18:43:16 +0000 (18:43 +0000)]
Fix an issue with FireFox where it blurs when copying from a smaller to a
larger canvas. Work around that by drawing a rect for each pixel.
Also, add a drop shadow to the hex display so you can see it on a dark background color.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
261303002
git-svn-id: http://skia.googlecode.com/svn/trunk@14575
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 18:40:15 +0000 (18:40 +0000)]
Fix android_perf script to work with changes from a137675
(http://crrev.com/
223613004). See http://crrev.com/
256413006
for a similar change.
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
262053007
git-svn-id: http://skia.googlecode.com/svn/trunk@14574
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 18:39:18 +0000 (18:39 +0000)]
Remove SkShader virtual method validContext
patch from issue
267923005
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
261773005
git-svn-id: http://skia.googlecode.com/svn/trunk@14573
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 18:23:54 +0000 (18:23 +0000)]
change composeshader_alpha to exercise srcover as well
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
263083011
git-svn-id: http://skia.googlecode.com/svn/trunk@14572
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 18:06:14 +0000 (18:06 +0000)]
Infrastructure changes to support pull-saveLayers-forward task
This is split out of (First pass at pre-rendering saveLayers for GPU - https://codereview.chromium.org/
261663003/).
It mainly:
Moves NeedsDeepCopy to somewhere more accessible (so GrPictureUtils.cpp can use it)
Moves ComputeAccelDataKey somewhere more accessible (so GPUPicture test can use it)
Adds unit test for picture saveLayer analysis (done in EXPERIMENTAL_optimize)
Adds new fields to SaveLayerInfo that are needed to pull forward layers
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
266203003
git-svn-id: http://skia.googlecode.com/svn/trunk@14571
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 17:09:05 +0000 (17:09 +0000)]
Update tests/RecordOptsTest.cpp
- use REPORTER_ASSERT;
- assert the type first, then the pointer != NULL. This helps explain why ptr == NULL;
- add a simpler NoopSaveRestore test case, which can help debugging failures of the larger test case.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
264043012
git-svn-id: http://skia.googlecode.com/svn/trunk@14570
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 16:45:01 +0000 (16:45 +0000)]
fix composeshader to respect the paint's alpha
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
265163008
git-svn-id: http://skia.googlecode.com/svn/trunk@14569
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 5 May 2014 16:32:16 +0000 (16:32 +0000)]
fix double->float warning
git-svn-id: http://skia.googlecode.com/svn/trunk@14568
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 16:19:08 +0000 (16:19 +0000)]
new gm for composeshader, exercising alpha
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
262193004
git-svn-id: http://skia.googlecode.com/svn/trunk@14567
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 16:04:42 +0000 (16:04 +0000)]
add rounding-using-doubles methods on SkScalar and SkRect
Inspired by the excellent repro case for https://crbug.com/364224
patch from issue
265933010
BUG=skia:
R=bungeman@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
267003002
git-svn-id: http://skia.googlecode.com/svn/trunk@14566
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 13:30:06 +0000 (13:30 +0000)]
Spelling fix, comments explaining script.
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
261913006
git-svn-id: http://skia.googlecode.com/svn/trunk@14565
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 12:32:37 +0000 (12:32 +0000)]
Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData.
BUG=skia:2402
Committed: http://code.google.com/p/skia/source/detail?r=14533
R=robertphillips@google.com, djsollen@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
243413002
git-svn-id: http://skia.googlecode.com/svn/trunk@14564
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 09:51:09 +0000 (09:51 +0000)]
Greenify bench bot Perf-Android-Nexus7-Tegra3-Arm7-Release at build 2774
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
269813005
git-svn-id: http://skia.googlecode.com/svn/trunk@14563
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 4 May 2014 18:08:27 +0000 (18:08 +0000)]
Revert of fix the error that path is inversed for stroke and strokeAndFill styles (https://codereview.chromium.org/
183683010/)
R=bsalomon@google.com, reed@google.com, yunchao.he@intel.com
TBR=reed@google.com
NOTRY=True
Reason for revert:
broke unittests
Original issue's description:
> fix the error that path is inversed for stroke and strokeAndFill styles.
>
> However, because hairline stroke + fill = fill (see src/core/SkStrokeRec.cpp), strokeAndFill will be thought as fill style when paint.getStrokeWidth() <= 0, this edge case can be inverse-filled.
>
> BUG=skia:2222
>
> Committed: http://code.google.com/p/skia/source/detail?r=14561
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
269903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14562
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 4 May 2014 03:43:20 +0000 (03:43 +0000)]
fix the error that path is inversed for stroke and strokeAndFill styles.
However, because hairline stroke + fill = fill (see src/core/SkStrokeRec.cpp), strokeAndFill will be thought as fill style when paint.getStrokeWidth() <= 0, this edge case can be inverse-filled.
BUG=skia:2222
R=bsalomon@google.com, reed@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
183683010
git-svn-id: http://skia.googlecode.com/svn/trunk@14561
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 4 May 2014 01:26:19 +0000 (01:26 +0000)]
fix size_t/int warnings
TBR=caryclark@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
265163003
git-svn-id: http://skia.googlecode.com/svn/trunk@14560
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 4 May 2014 00:46:50 +0000 (00:46 +0000)]
eliminate mac xcode 5 only warning
on os x 10.9.2 unistd.h defines sysconf as
long sysconf(int);
R=mtklein@google.com, reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
261673004
git-svn-id: http://skia.googlecode.com/svn/trunk@14559
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 3 May 2014 19:46:58 +0000 (19:46 +0000)]
bench rebase after d06ee45
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
264043002
git-svn-id: http://skia.googlecode.com/svn/trunk@14558
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 3 May 2014 16:45:50 +0000 (16:45 +0000)]
bench rebase after d06ee45
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
265163002
git-svn-id: http://skia.googlecode.com/svn/trunk@14557
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 3 May 2014 13:03:48 +0000 (13:03 +0000)]
Fixes lower/upper typo.
BUG=skia:
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
266023005
git-svn-id: http://skia.googlecode.com/svn/trunk@14556
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 3 May 2014 12:58:59 +0000 (12:58 +0000)]
Use a separate error parameter for lower bound.
BUG=skia:
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
268883002
git-svn-id: http://skia.googlecode.com/svn/trunk@14555
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 3 May 2014 12:40:14 +0000 (12:40 +0000)]
further adjust bench lower bounds to cope with downside flakiness.
BUG=skia:2225
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
268643004
git-svn-id: http://skia.googlecode.com/svn/trunk@14554
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 21:38:22 +0000 (21:38 +0000)]
Split GrResource into GrCacheable/GrGpuObject
Before this change, an object needed to inherit from GrResource (and
thus be a GPU object) in order to live in the GrResourceCache. That
was a problem for caching items that weren't GPU objects themselves,
but owned GPU objects.
This change splits GrResource into two classes:
1. GrCacheable: The base class for objects that can live in the
GrResourceCache.
2. GrGpuObject, which inherits from GrCacheable: The base class for
objects that get tracked by GrGpu.
This change is purely a refactor; there is no change in functionality.
Change-Id: I3e8daeb1f123041f414aa306c1366e959ae9e39e
BUG=skia:
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
251013002
git-svn-id: http://skia.googlecode.com/svn/trunk@14553
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 21:24:22 +0000 (21:24 +0000)]
add release-mode checks for null, at least for a while
BUG=skia:
R=bungeman@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
263883006
git-svn-id: http://skia.googlecode.com/svn/trunk@14552
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 21:23:52 +0000 (21:23 +0000)]
Remove setLocalMatrix calls from picture shader GM.
This makes all --skr tests pass for me. Enabling it by default in DM.
BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14549
R=reed@google.com, mtklein@google.com, fmalita@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
260863007
git-svn-id: http://skia.googlecode.com/svn/trunk@14551
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 20:51:13 +0000 (20:51 +0000)]
Revert of Remove setLocalMatrix calls from picture shader GM. (https://codereview.chromium.org/
260863007/)
Reason for revert:
changed GM unexpectedly. will sort out and try again
Original issue's description:
> Remove setLocalMatrix calls from picture shader GM.
>
> This makes all --skr tests pass for me. Enabling it by default in DM.
>
> BUG=skia:2378
>
> Committed: http://code.google.com/p/skia/source/detail?r=14549
R=reed@google.com, fmalita@google.com, mtklein@chromium.org
TBR=fmalita@google.com, mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2378
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
265013003
git-svn-id: http://skia.googlecode.com/svn/trunk@14550
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 20:30:11 +0000 (20:30 +0000)]
Remove setLocalMatrix calls from picture shader GM.
This makes all --skr tests pass for me. Enabling it by default in DM.
BUG=skia:2378
R=reed@google.com, mtklein@google.com, fmalita@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
260863007
git-svn-id: http://skia.googlecode.com/svn/trunk@14549
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 20:28:56 +0000 (20:28 +0000)]
Choose memset procs once.
TSAN shows us racing on the function pointers. Might as well fix it.
WARNING: ThreadSanitizer: data race (pid=19995)
Read of size 8 at 0x7f703affb048 by thread T12 (mutexes: write M2957):
#0 SkBitmap::internalErase(SkIRect const&, unsigned int, unsigned int, unsigned int, unsigned int) const /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/core/SkBitmap.cpp:886 (tests+0x0000003511ca)
#1 SkBitmap::eraseARGB(unsigned int, unsigned int, unsigned int, unsigned int) const /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/core/SkBitmap.cpp:919 (tests+0x0000003534bf)
#2 (anonymous namespace)::DecodingImageGenerator::getPixels(SkImageInfo const&, void*, unsigned long) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/images/SkDecodingImageGenerator.cpp:195 (tests+0x00000051bee1)
#3 SkDiscardablePixelRef::onNewLockPixels(SkPixelRef::LockRec*) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/lazy/SkDiscardablePixelRef.cpp:63 (tests+0x00000039ad9c)
#4 SkPixelRef::lockPixels(SkPixelRef::LockRec*) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/core/SkPixelRef.cpp:179 (tests+0x0000003fec23)
#5 SkBitmap::lockPixels() const /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/core/SkBitmap.cpp:414 (tests+0x00000034e41e)
#6 SkAutoLockPixels /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/include/core/SkBitmap.h:819 (tests+0x0000002752f3)
#7 ImageDecoderOptions(skiatest::Reporter*) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/tests/ImageDecodingTest.cpp:565 (tests+0x000000275d03)
#8 skiatest::Test::run() /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/tests/Test.cpp:107 (tests+0x0000002263e7)
#9 SkTestRunnable::run() /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/tests/skia_test.cpp:108 (tests+0x0000001d8607)
#10 SkThreadPoolPrivate::ThreadLocal<void>::run(SkTRunnable<void>*) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/include/utils/SkThreadPool.h:108 (tests+0x0000001d817e)
#11 thread_start(void*) /var/scratch/Release/../../../usr/local/google/home/mtklein/skia/src/utils/SkThreadUtils_pthread.cpp:66 (tests+0x000000604347)
Previous write of size 8 at 0x7f703affb048 by thread T26:
[failed to restore the stack]
BUG=skia:1792
R=bungeman@google.com, mtklein@google.com, reed@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
250503003
git-svn-id: http://skia.googlecode.com/svn/trunk@14548
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 20:27:50 +0000 (20:27 +0000)]
Add literal picture recording mode, triggered by a compile time switch.
This is helpful to record SKPs from Chrome as a fair bootstrapping source for
SkRecord. Without this sort of switch, a good bit of SkPicture's cleverness is
baked into the SKP, and thus SkRecord looks unfairly good.
Tested by defining SK_RECORD_LITERAL_PICTURES and running dm --match
~optimizations. By design that GM will never pass in literal mode.
BUG=skia:2378
R=robertphillips@google.com, reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
246393008
git-svn-id: http://skia.googlecode.com/svn/trunk@14547
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 20:26:01 +0000 (20:26 +0000)]
mark flaky GM tests as ignore-failure
followup to https://codereview.chromium.org/
265043002 ('commit GM actuals as expectations for all tests, marking them as unreviewed')
BUG=skia:2332
NOTREECHECKS=True
NOTRY=True
R=djsollen@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
269763003
git-svn-id: http://skia.googlecode.com/svn/trunk@14546
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 20:14:59 +0000 (20:14 +0000)]
guard against self-assignment
BUG=skia:
R=mtklein@google.com, bungeman@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
264793014
git-svn-id: http://skia.googlecode.com/svn/trunk@14545
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 19:59:59 +0000 (19:59 +0000)]
Don't run GPU configs in bench_pictures on RHB
BUG=skia:2518
R=epoger@google.com, djsollen@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
262803012
git-svn-id: http://skia.googlecode.com/svn/trunk@14544
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Fri, 2 May 2014 19:13:11 +0000 (19:13 +0000)]
Fix for SkMatrixConvolutionImageFilter with large borders.
Intersect the requested processing rect with the destination
bounds.
R=junov@chromium.org
Review URL: https://codereview.chromium.org/
267863004
git-svn-id: http://skia.googlecode.com/svn/trunk@14543
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 18:00:58 +0000 (18:00 +0000)]
re-enable simpleblurroundrect gm now that all the rebaselines have landed
BUG=skia:
R=djsollen@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
268763004
git-svn-id: http://skia.googlecode.com/svn/trunk@14542
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 2 May 2014 17:44:34 +0000 (17:44 +0000)]
Revert of Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData. (https://codereview.chromium.org/
243413002/)
Reason for revert:
This is firing an assert on many of the Android debug bots
Original issue's description:
> Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData.
>
> BUG=skia:2402
>
> Committed: http://code.google.com/p/skia/source/detail?r=14533
git-svn-id: http://skia.googlecode.com/svn/trunk@14541
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 2 May 2014 17:41:33 +0000 (17:41 +0000)]
Remove extra includes from android sample app
R=borenet@google.com
Review URL: https://codereview.chromium.org/
264773012
git-svn-id: http://skia.googlecode.com/svn/trunk@14540
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 17:37:05 +0000 (17:37 +0000)]
Revert of Fix iOS build. (https://codereview.chromium.org/
269663008/)
Reason for revert:
Reverting as this is a follow on to https://codereview.chromium.org/
243413002/ which is breaking android debug bots
Original issue's description:
> Fix iOS build.
>
> Committed: https://code.google.com/p/skia/source/detail?r=14537
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
261983002
git-svn-id: http://skia.googlecode.com/svn/trunk@14539
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 16:48:30 +0000 (16:48 +0000)]
remove self-tests for no-longer-supported rebaseline.py
see https://codereview.chromium.org/
262703003 ('mark rebaseline.py as deprecated')
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
265073002
git-svn-id: http://skia.googlecode.com/svn/trunk@14538
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 2 May 2014 16:15:41 +0000 (16:15 +0000)]
Fix iOS build.
Review URL: https://codereview.chromium.org/
269663008
git-svn-id: http://skia.googlecode.com/svn/trunk@14537
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 2 May 2014 15:59:13 +0000 (15:59 +0000)]
adjust win7 perf ranges to reduce flakiness
Review URL: https://codereview.chromium.org/
267903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14536
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 2 May 2014 15:54:00 +0000 (15:54 +0000)]
adjust android perf ranges to reduce flakiness.
Review URL: https://codereview.chromium.org/
264793012
git-svn-id: http://skia.googlecode.com/svn/trunk@14535
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Fri, 2 May 2014 15:38:39 +0000 (15:38 +0000)]
Lower range for bench expectation for the following faster tests.
desk_yahoosports.skp_simple_viewport_1000x1000_scalar_1.100000
Review URL: https://codereview.chromium.org/
261813004
git-svn-id: http://skia.googlecode.com/svn/trunk@14534
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 15:08:18 +0000 (15:08 +0000)]
Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData.
BUG=skia:2402
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
243413002
git-svn-id: http://skia.googlecode.com/svn/trunk@14533
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 14:57:25 +0000 (14:57 +0000)]
commit GM actuals as expectations for all tests, marking them as unreviewed
BUG=skia:1578
NOTREECHECKS=True
NOTRY=True
R=reed@google.com
TBR=reed
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
265043002
git-svn-id: http://skia.googlecode.com/svn/trunk@14532
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 2 May 2014 14:43:12 +0000 (14:43 +0000)]
Fix type in DM/mesa
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/
269723004
git-svn-id: http://skia.googlecode.com/svn/trunk@14531
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 14:34:18 +0000 (14:34 +0000)]
mark rebaseline.py as deprecated
(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=senorblanco@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
262703003
git-svn-id: http://skia.googlecode.com/svn/trunk@14530
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 14:22:38 +0000 (14:22 +0000)]
Mark drawbitmaprect's large bitmaps as immutable.
This reduces the peak memory usage of out/Debug/dm --skr --match drawbitmaprect from ~1.6G to ~200M.
I'm not sure how the numbers got so huge to begin with from a 2K x 2K 8888 bitmap (16MB).
BUG=skia:2378
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
265813007
git-svn-id: http://skia.googlecode.com/svn/trunk@14529
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 2 May 2014 14:12:54 +0000 (14:12 +0000)]
Add initial baselines for discard GM
Review URL: https://codereview.chromium.org/
267763003
git-svn-id: http://skia.googlecode.com/svn/trunk@14528
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 14:13:08 +0000 (14:13 +0000)]
Add Doxygen link to titlebar.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
268773002
git-svn-id: http://skia.googlecode.com/svn/trunk@14527
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 12:56:43 +0000 (12:56 +0000)]
Need checkerboard on history images too.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
267723010
git-svn-id: http://skia.googlecode.com/svn/trunk@14526
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 12:39:41 +0000 (12:39 +0000)]
Add flag for SkGpuSurface creation to enable distance fields.
BUG=skia:2173
R=bsalomon@google.com, reed@google.com, bungeman@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
261783004
git-svn-id: http://skia.googlecode.com/svn/trunk@14525
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 2 May 2014 03:03:47 +0000 (03:03 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14524
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 1 May 2014 22:37:56 +0000 (22:37 +0000)]
Rebaselines for r14518 (Add support for kEmbeddedBitmapText_Flag to DirectWrite.)
git-svn-id: http://skia.googlecode.com/svn/trunk@14523
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 21:23:19 +0000 (21:23 +0000)]
Fix image decode thrashing when drawing a very large source image to a GPU canvas
R=bsalomon@google.com
Author: junov@chromium.org
Review URL: https://codereview.chromium.org/
265763005
git-svn-id: http://skia.googlecode.com/svn/trunk@14522
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 21:06:39 +0000 (21:06 +0000)]
DM: Apply initial transform in --skr mode.
BUG=skia:2378
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
263853005
git-svn-id: http://skia.googlecode.com/svn/trunk@14521
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 21:03:53 +0000 (21:03 +0000)]
Remove dead code.
No files reference this file.
R=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
255243002
git-svn-id: http://skia.googlecode.com/svn/trunk@14520
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 20:52:12 +0000 (20:52 +0000)]
Add checkerboard under the image.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
263853004
git-svn-id: http://skia.googlecode.com/svn/trunk@14519
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 1 May 2014 20:39:14 +0000 (20:39 +0000)]
Add support for kEmbeddedBitmapText_Flag to DirectWrite.
R=reed@google.com
Review URL: https://codereview.chromium.org/
263503004
git-svn-id: http://skia.googlecode.com/svn/trunk@14518
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 20:20:50 +0000 (20:20 +0000)]
Revert of Roll ANGLE. (https://codereview.chromium.org/
237173002/)
Reason for revert:
breaking the buildbots (see http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Release-ANGLE/builds/3198).
NOTRY=true
Original issue's description:
> Roll ANGLE.
>
> BUG=skia:2272
>
> Committed: http://code.google.com/p/skia/source/detail?r=14243
>
> Committed: http://code.google.com/p/skia/source/detail?r=14509
R=bsalomon@chromium.org, bsalomon@google.com, geofflang@chromium.org, djsollen@google.com, mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
264733006
git-svn-id: http://skia.googlecode.com/svn/trunk@14517
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 20:17:18 +0000 (20:17 +0000)]
Fix history on workspaces, where you couldn't click on old tries.
Also allow editing the first and last line because you might need
to do that to fix "old" tries that are already stored in the database.
By "old" I mean yesterday.
BUG=skia:
R=fmalita@google.com, fmalita@chromium.org
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
264833004
git-svn-id: http://skia.googlecode.com/svn/trunk@14516
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 20:10:03 +0000 (20:10 +0000)]
Run Squid as a reverse caching proxy on port 80 and proxy the requests
to the server running on port 8000.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
261023002
git-svn-id: http://skia.googlecode.com/svn/trunk@14515
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 19:31:31 +0000 (19:31 +0000)]
create struct to hold all the params passed around for shader::context
BUG=skia:
R=scroggo@google.com, dominikg@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
264843006
git-svn-id: http://skia.googlecode.com/svn/trunk@14514
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 19:30:35 +0000 (19:30 +0000)]
Add more detailed logging when things go wrong in android_run_skia
R=borenet@google.com, halcanary@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
263733006
git-svn-id: http://skia.googlecode.com/svn/trunk@14513
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 19:29:53 +0000 (19:29 +0000)]
tweaks to tab CSS for rebaseline server page; moar pretty
BUG=skia:
R=epoger@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
264853004
git-svn-id: http://skia.googlecode.com/svn/trunk@14512
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 19:29:46 +0000 (19:29 +0000)]
gyp rules for ubsan
BUG=skia:2481
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
258393004
git-svn-id: http://skia.googlecode.com/svn/trunk@14511
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 19:22:41 +0000 (19:22 +0000)]
rebaseline simpleblurroundrect
BUG=skia:
TBR=epoger
Author: humper@google.com
Review URL: https://codereview.chromium.org/
269573007
git-svn-id: http://skia.googlecode.com/svn/trunk@14510
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 19:22:22 +0000 (19:22 +0000)]
Roll ANGLE.
BUG=skia:2272
Committed: http://code.google.com/p/skia/source/detail?r=14243
R=bsalomon@chromium.org, bsalomon@google.com
Author: geofflang@chromium.org
Review URL: https://codereview.chromium.org/
237173002
git-svn-id: http://skia.googlecode.com/svn/trunk@14509
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 19:21:41 +0000 (19:21 +0000)]
Remove SkDEBUGFAILs that are problematic for Chromium
BUG=368107
R=egdaniel@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
268683003
git-svn-id: http://skia.googlecode.com/svn/trunk@14508
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 19:21:33 +0000 (19:21 +0000)]
Move to a theme that more closely matches what was there before.
Also, since it's a variation of "default" we can drop a whole file.
BUG=skia:
R=mtklein@google.com, fmalita@chromium.org
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
265703005
git-svn-id: http://skia.googlecode.com/svn/trunk@14507
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 17:41:32 +0000 (17:41 +0000)]
DM: Push GPU-parent child tasks to the front of the queue.
Like yesterday's change to run CPU-parent child tasks serially in thread, this
reduces peak memory usage by improving the temporaly locality of the bitmaps we
create.
E.g. Let's say we start with tasks A B C and D
Queue: [ A B C D ]
Running A creates A' and A", which depend on a bitmap created by A.
Queue: [ B C D A' A" * ]
That bitmap now needs sit around in RAM while B C and D run pointlessly and can
only be destroyed at *. If instead we do this and push dependent child tasks
to the front of the queue, the queue and bitmap lifetime looks like this:
Queue: [ A' A" * B C D ]
This is much, much worse in practice because the queue is often several thousand
tasks long. 100s of megs of bitmaps can pile up for 10s of seconds pointlessly.
To make this work we add addNext() to SkThreadPool and its cousin DMTaskRunner.
I also took the opportunity to swap head and tail in the threadpool
implementation so it matches the comments and intuition better: we always pop
the head, add() puts it at the tail, addNext() at the head.
Before
Debug: 49s, 1403352k peak
Release: 16s, 2064008k peak
After
Debug: 49s, 1234788k peak
Release: 15s, 1903424k peak
BUG=skia:2478
R=bsalomon@google.com, borenet@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
263803003
git-svn-id: http://skia.googlecode.com/svn/trunk@14506
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 16:30:30 +0000 (16:30 +0000)]
Whitespace change to test the Skia CQ
(SkipBuildbotRuns)
BUG=skia:
R=fmalita@chromium.org
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
269543006
git-svn-id: http://skia.googlecode.com/svn/trunk@14505
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 1 May 2014 15:56:52 +0000 (15:56 +0000)]
remove code behind SK_SUPPORT_LEGACY_PROCXFERMODE
BUG=skia:
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
264923004
git-svn-id: http://skia.googlecode.com/svn/trunk@14504
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 15:34:28 +0000 (15:34 +0000)]
Improve Android gdbserver and gdb_ex scripts
- Don't complain if $GDB_TMP_DIR already exists
- Since $GDB_TMP_DIR/gdb.setup might already exist, overwrite the file.
NOTRY=true
R=djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
266453006
git-svn-id: http://skia.googlecode.com/svn/trunk@14503
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 15:30:52 +0000 (15:30 +0000)]
reduce total number of segments in giant-dash
still exercises large coordinates, but won't kill our memory usage on 32bit bots
NOTRY=True
R=caryclark@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
262733007
git-svn-id: http://skia.googlecode.com/svn/trunk@14502
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 15:24:55 +0000 (15:24 +0000)]
expose ConvertRadiusToSigma to aid clients in the API transition to sigma
NOTRY=True
R=robertphillips@google.com, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
264923002
git-svn-id: http://skia.googlecode.com/svn/trunk@14501
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 15:18:06 +0000 (15:18 +0000)]
Revert of re-enable simpleblurroundrect gm (https://codereview.chromium.org/
263823002/)
Reason for revert:
broken rebaseline.
Original issue's description:
> re-enable simpleblurroundrect gm
>
> BUG=skia:
> TBR=caryclark
>
> Committed: http://code.google.com/p/skia/source/detail?r=14498
R=caryclark@google.com
TBR=caryclark@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: humper@google.com
Review URL: https://codereview.chromium.org/
265863002
git-svn-id: http://skia.googlecode.com/svn/trunk@14500
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Thu, 1 May 2014 15:14:56 +0000 (15:14 +0000)]
Use CodeMirror for WebTry snippets.
CodeMirror (http://codemirror.net) is a rich code editor. This CL
adds the needed library and wires it with some minimal features, to
update the editor appearance to something like this:
http://codemirror.net/demo/theme.html?ambiance
We can later add Skia-customized features (custom keyword highlighting,
code completion, etc.).
(only tested locally)
R=jcgregorio@google.com, mtklein@google.com
Review URL: https://codereview.chromium.org/
261693003
git-svn-id: http://skia.googlecode.com/svn/trunk@14499
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 14:38:45 +0000 (14:38 +0000)]
re-enable simpleblurroundrect gm
BUG=skia:
R=caryclark@google.com
TBR=caryclark
Author: humper@google.com
Review URL: https://codereview.chromium.org/
263823002
git-svn-id: http://skia.googlecode.com/svn/trunk@14498
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 1 May 2014 14:03:41 +0000 (14:03 +0000)]
Add a fix for a spurious assert in SkMatrixConvolutionImageFilter.
When matrix convolution processes border pixels with zero width, it
asserts in getAddr32() with an invalid x coordinate. The assert is
harmless, since the returned pointer is never accessed (the next line
is a loop from left to right, which does nothing, since left == right).
However, the fix is simple: early out on an empty rect before entering
the outer loop.
R=sugoi@chromium.org
Review URL: https://codereview.chromium.org/
265693005
git-svn-id: http://skia.googlecode.com/svn/trunk@14497
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Thu, 1 May 2014 13:32:21 +0000 (13:32 +0000)]
Add fmalita@chromium.org to CQ_COMMITTERS.
R=rmistry@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
267693003
git-svn-id: http://skia.googlecode.com/svn/trunk@14496
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 12:56:19 +0000 (12:56 +0000)]
Support unknown Android target devices via environment variables.
This is useful for working with prototypes and uncommon devices.
NOTRY=true
R=djsollen@google.com, scroggo@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
263673004
git-svn-id: http://skia.googlecode.com/svn/trunk@14495
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 12:54:25 +0000 (12:54 +0000)]
Display the color at a point.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
261533006
git-svn-id: http://skia.googlecode.com/svn/trunk@14494
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 1 May 2014 12:32:39 +0000 (12:32 +0000)]
Rename expectations for Valgrind bot: ATI5770->GTX550Ti
This will likely cause GM failures, since the GPU has changed.
BUG=skia:2506
R=caryclark@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
265773004
git-svn-id: http://skia.googlecode.com/svn/trunk@14493
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 1 May 2014 03:04:54 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14492
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 23:29:02 +0000 (23:29 +0000)]
add default impl for context methods on shader
These are reasonable return values, since both of these methods can return a known value (0)
which means that no context can be created. This also makes it easier for chrome's subclasses
which already do not want to create a context, but having them actually overridden makes
changing the virtual signatures much harder.
BUG=skia:
R=scroggo@google.com, dominikg@google.com, reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
262703002
git-svn-id: http://skia.googlecode.com/svn/trunk@14491
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 30 Apr 2014 21:46:38 +0000 (21:46 +0000)]
Rebaseline tileimagefilter on IntelRhb post-r14432.
TBR=caryclark@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
267573004
git-svn-id: http://skia.googlecode.com/svn/trunk@14490
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 21:34:14 +0000 (21:34 +0000)]
remove unneeded SK_SUPPORT_LEGACY_PROCXFERMODE
BUG=skia:
R=fmalita@google.com, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
267573003
git-svn-id: http://skia.googlecode.com/svn/trunk@14489
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 21:32:37 +0000 (21:32 +0000)]
rebaseline_server: ignore builders we don't have any expectations for
(SkipBuildbotRuns)
BUG=skia:2486
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
269543002
git-svn-id: http://skia.googlecode.com/svn/trunk@14488
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 21:10:13 +0000 (21:10 +0000)]
one valgrind.supp to rule them all.
R=mtklein@google.com, robertphillips@google.com, borenet@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
268473004
git-svn-id: http://skia.googlecode.com/svn/trunk@14487
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 30 Apr 2014 20:47:30 +0000 (20:47 +0000)]
DM: run child tasks that are already on the CPU threadpool serially
These tasks tend to do similar things with similar sized bitmaps, so running
them serially means we tend to hold 2x bitmaps at a time (golden and
comparison) instead of (1+k)x bitmaps (golden and k concurrent comparisons).
We still migrate GPU task's children over to the main CPU thread pool,
because they'll run faster there and free up capacity on the GPU thread.
Before
Debug: 54s, 2.9G peak
Release: 13s, 2.4G peak
After
Debug: 48s, 1.5G peak
Release: 15s, 2.0G peak
BUG=skia:2478
R=borenet@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
261593008
git-svn-id: http://skia.googlecode.com/svn/trunk@14486
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log