platform/upstream/coreclr.git
6 years agoUpdate CoreClr, CoreFx, PgoData to preview1-26015-05, preview1-26015-06, master-20171...
dotnet-maestro-bot [Fri, 15 Dec 2017 16:55:37 +0000 (10:55 -0600)]
Update CoreClr, CoreFx, PgoData to preview1-26015-05, preview1-26015-06, master-20171215-0045, respectively (#15535)

6 years agoMerge pull request #15370 from MichalStrehovsky/defaultintf-merge
Michal Strehovský [Fri, 15 Dec 2017 10:52:33 +0000 (11:52 +0100)]
Merge pull request #15370 from MichalStrehovsky/defaultintf-merge

Merge dev/defaultintf to master

6 years agoChange ReadOnlySpan indexer to return ref readonly (#14727)
Ahson Khan [Fri, 15 Dec 2017 02:24:05 +0000 (18:24 -0800)]
Change ReadOnlySpan indexer to return ref readonly (#14727)

* Change ReadOnlySpan indexer to return ref readonly.

Update JIT to handle changes to ReadOnlySpan indexer

Resolving merge conflict and fixing jit importer

Update ReadOnlySpan Enumerator Current to use indexer.

Removing readonly keyword.

* Temporarily disabling Span perf and other tests that use ReadOnlySpan

* Isolating the ref readonly indexer change only to CoreCLR for now.

Reverting the change to Enumerator Current for now

Fix file formatting

Enable Alpine CI (#15502)

* Enable Alpine CI

This enables Alpine CI leg on every PR using the pipelines.

compare type size instead of var_types

get rid of TYP_CHAR

Adding support for Acosh, Asinh, Atanh, and Cbrt to Math and MathF

Updating the PAL layer to support acosh, asinh, atanh, and cbrt

Adding some PAL tests for acosh, asinh, atanh, and cbrt

Adding valuenum support for acosh, asinh, atanh, and cbrt

Lsra Documentation

Update LinearScan section of ryujit-overview.md, and add lsra-detail.md

Refactor Unsafe.cs to get it more in sync with CoreRT. (#15510)

* Refactor Unsafe.cs to get it more in sync with CoreRT.

* Format the document.

* Unifying the copies of Unsafe using ifdefs

* Change exception thrown to PlatformNotSupportedException

* Addressing PR feedback and moving Unsafe to shared.

* Addressing PR feedback

* Addressing PR review - adding intrinsic attribute

Update CoreClr, CoreFx to preview1-26014-01, preview1-26013-12, respectively (#15513)

Revert "Add optional integer offset to OwnedMemory Pin (#15410)"

This reverts commit 8931cfa4ebe94f57698b4c1b3ab5689cd467cb8e.

Get rid of old -altjitcrossgen argument now that CI has been updated

Merge pull request dotnet/corert#5109 from dotnet/nmirror (#15518)

Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Revert " Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (#14982)""

Fix typo `_TARGET_ARM` to `_TARGET_ARM_`. This happens mostly in comments except lsra.cpp.

Update CoreClr, CoreFx, PgoData to preview1-26014-04, preview1-26014-03, master-20171214-0043, respectively (#15520)

* Disabling a test that uses ReadOnlySpan indexer

* Temporarily disabling the superpmi test and fixing nit

* Remove debug statements.

6 years ago[RyuJit][Armel] Do not lose type information (#15449)
Sergey Andreenko [Fri, 15 Dec 2017 02:17:53 +0000 (18:17 -0800)]
[RyuJit][Armel] Do not lose type information (#15449)

* Do not lose type information

fgMorphMultiregStructArg could lose type information when replaced smth like this:
 GT_OBJ - TYP_STRUCT     <== arg
  + GT_ADDR - TYP_I_IMPL
   +  + GT_LCL_VAR - TYP_BLK  <== argValue

* Move the test to pri0 to test in ci.

* add an assert

* add the test to the arm list

* make the optimization only if struct handlers match.

* format job

* fix for the unoptimized case.

* check that we have addr node.

* change the reason to lvaSetVarDoNotEnregister

6 years agoUpdate CoreClr to preview1-26014-09 (#15531)
dotnet-maestro-bot [Fri, 15 Dec 2017 02:11:40 +0000 (20:11 -0600)]
Update CoreClr to preview1-26014-09 (#15531)

6 years agoFixing build by casting IntPtr to nint. (#15530)
dotnet bot [Fri, 15 Dec 2017 01:28:39 +0000 (17:28 -0800)]
Fixing build by casting IntPtr to nint. (#15530)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
6 years agoMerge pull request #15448 from jashook/rebase_dutw
Jarret Shook [Thu, 14 Dec 2017 23:58:32 +0000 (15:58 -0800)]
Merge pull request #15448 from jashook/rebase_dutw

Remove CoreFX runtest dependency

6 years agoAdding Unsafe API Add nuint that is used by SpanHelpers (#15527)
Ahson Khan [Thu, 14 Dec 2017 22:34:42 +0000 (14:34 -0800)]
Adding Unsafe API Add nuint that is used by SpanHelpers (#15527)

* Adding Unsafe API Add nuint that is used by SpanHelpers

* Change elementOffset to IntPtr in method signature.

6 years agoChange non-exclusive Check postconditions to null checks (#15523)
Jan Kotas [Thu, 14 Dec 2017 21:15:49 +0000 (16:15 -0500)]
Change non-exclusive Check postconditions to null checks (#15523)

The Check macro is trying to be helpful and trigger DebugBreak when the condition
is false and debugger is attached. It makes it hard to exercise the recent jump stub
changes with debugger attached. The fix is to change the non-exclusive Check postconditions
to a simple null check.

6 years agoRemove CoreFX runtest dependency
jashook [Thu, 14 Dec 2017 17:17:25 +0000 (09:17 -0800)]
Remove CoreFX runtest dependency

This change will start using build-test.sh generatelayoutonly to build
the coreoverlay directory for use with runtest.sh.

6 years agoUpdate CoreClr, CoreFx, PgoData to preview1-26014-04, preview1-26014-03, master-20171...
dotnet-maestro-bot [Thu, 14 Dec 2017 18:47:31 +0000 (12:47 -0600)]
Update CoreClr, CoreFx, PgoData to preview1-26014-04, preview1-26014-03, master-20171214-0043, respectively (#15520)

6 years agoMerge pull request #15479 from echesakovMSFT/FixTargetArmMacroTypo
Egor Chesakov [Thu, 14 Dec 2017 16:56:59 +0000 (08:56 -0800)]
Merge pull request #15479 from echesakovMSFT/FixTargetArmMacroTypo

Fix typo _TARGET_ARM to _TARGET_ARM_ in lsra.cpp

6 years agoMerge pull request #15517 from dotnet/revert-15498-asyncpin-revert
Jan Kotas [Thu, 14 Dec 2017 15:53:13 +0000 (10:53 -0500)]
Merge pull request #15517 from dotnet/revert-15498-asyncpin-revert

Revert " Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (#14982)""

6 years agoMerge pull request dotnet/corert#5109 from dotnet/nmirror (#15518)
dotnet bot [Thu, 14 Dec 2017 06:16:23 +0000 (22:16 -0800)]
Merge pull request dotnet/corert#5109 from dotnet/nmirror (#15518)

Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
6 years agoMerge pull request #15504 from BruceForstall/CleanupAltjitArg
Bruce Forstall [Thu, 14 Dec 2017 05:53:25 +0000 (21:53 -0800)]
Merge pull request #15504 from BruceForstall/CleanupAltjitArg

Get rid of old -altjitcrossgen argument now that CI has been updated

6 years agoMerge pull request #15516 from jkotas/revert
Jan Kotas [Thu, 14 Dec 2017 05:03:04 +0000 (00:03 -0500)]
Merge pull request #15516 from jkotas/revert

Revert "Add optional integer offset to OwnedMemory Pin (#15410)"

6 years agoRevert " Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE throug...
Jan Kotas [Thu, 14 Dec 2017 03:46:50 +0000 (19:46 -0800)]
Revert " Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (#14982)""

6 years agoUpdate CoreClr, CoreFx to preview1-26014-01, preview1-26013-12, respectively (#15513)
dotnet-maestro-bot [Thu, 14 Dec 2017 03:43:45 +0000 (21:43 -0600)]
Update CoreClr, CoreFx to preview1-26014-01, preview1-26013-12, respectively (#15513)

6 years agoRevert "Add optional integer offset to OwnedMemory Pin (#15410)"
Jan Kotas [Thu, 14 Dec 2017 03:33:18 +0000 (19:33 -0800)]
Revert "Add optional integer offset to OwnedMemory Pin (#15410)"

This reverts commit 8931cfa4ebe94f57698b4c1b3ab5689cd467cb8e.

6 years agoRefactor Unsafe.cs to get it more in sync with CoreRT. (#15510)
Ahson Khan [Thu, 14 Dec 2017 02:29:43 +0000 (18:29 -0800)]
Refactor Unsafe.cs to get it more in sync with CoreRT. (#15510)

* Refactor Unsafe.cs to get it more in sync with CoreRT.

* Format the document.

* Unifying the copies of Unsafe using ifdefs

* Change exception thrown to PlatformNotSupportedException

* Addressing PR feedback and moving Unsafe to shared.

* Addressing PR feedback

* Addressing PR review - adding intrinsic attribute

6 years agoMerge pull request #15483 from CarolEidt/LsraDoc
Carol Eidt [Thu, 14 Dec 2017 01:02:51 +0000 (17:02 -0800)]
Merge pull request #15483 from CarolEidt/LsraDoc

Lsra doc

6 years agoLsra Documentation
Carol Eidt [Tue, 12 Dec 2017 05:58:46 +0000 (21:58 -0800)]
Lsra Documentation

Update LinearScan section of ryujit-overview.md, and add lsra-detail.md

6 years agoMerge pull request #15456 from tannergooding/math-api
Tanner Gooding [Wed, 13 Dec 2017 22:30:38 +0000 (14:30 -0800)]
Merge pull request #15456 from tannergooding/math-api

Adding support for Acosh, Asinh, Atanh, and Cbrt to Math and MathF

6 years agoMerge pull request #15424 from fiigii/char
Carol Eidt [Wed, 13 Dec 2017 22:19:40 +0000 (14:19 -0800)]
Merge pull request #15424 from fiigii/char

[RyuJIT] Get rid of TYP_CHAR and use TYP_USHORT instead

6 years agoEnable Alpine CI (#15502)
Jan Vorlicek [Wed, 13 Dec 2017 22:05:45 +0000 (23:05 +0100)]
Enable Alpine CI (#15502)

* Enable Alpine CI

This enables Alpine CI leg on every PR using the pipelines.

6 years agoAdd a note the linker bug has been fixed
Michal Strehovský [Wed, 13 Dec 2017 21:55:30 +0000 (22:55 +0100)]
Add a note the linker bug has been fixed

6 years agoUpdate CoreFx to preview1-26013-06 (#15505)
dotnet-maestro-bot [Wed, 13 Dec 2017 20:37:59 +0000 (14:37 -0600)]
Update CoreFx to preview1-26013-06 (#15505)

6 years agoget rid of TYP_CHAR
Fei Peng [Wed, 13 Dec 2017 18:59:14 +0000 (10:59 -0800)]
get rid of TYP_CHAR

6 years agocompare type size instead of var_types
Fei Peng [Wed, 13 Dec 2017 18:32:18 +0000 (10:32 -0800)]
compare type size instead of var_types

6 years agoAdding valuenum support for acosh, asinh, atanh, and cbrt
Tanner Gooding [Mon, 11 Dec 2017 23:50:21 +0000 (15:50 -0800)]
Adding valuenum support for acosh, asinh, atanh, and cbrt

6 years agoAdding some PAL tests for acosh, asinh, atanh, and cbrt
Tanner Gooding [Sun, 10 Dec 2017 01:11:07 +0000 (17:11 -0800)]
Adding some PAL tests for acosh, asinh, atanh, and cbrt

6 years agoUpdating the PAL layer to support acosh, asinh, atanh, and cbrt
Tanner Gooding [Sat, 9 Dec 2017 18:49:25 +0000 (10:49 -0800)]
Updating the PAL layer to support acosh, asinh, atanh, and cbrt

6 years agoAdding support for Acosh, Asinh, Atanh, and Cbrt to Math and MathF
Tanner Gooding [Sat, 9 Dec 2017 17:53:51 +0000 (09:53 -0800)]
Adding support for Acosh, Asinh, Atanh, and Cbrt to Math and MathF

6 years agoMerge pull request #15244 from fiigii/vector
Carol Eidt [Wed, 13 Dec 2017 18:23:18 +0000 (10:23 -0800)]
Merge pull request #15244 from fiigii/vector

Enable Vector128/256<T> and Add intrinsics

6 years agoMerge pull request #15500 from mikedn/const-tree
Bruce Forstall [Wed, 13 Dec 2017 18:15:04 +0000 (10:15 -0800)]
Merge pull request #15500 from mikedn/const-tree

Make GenTree::AsX, gtGetOp1 and gtGetOp2 const

6 years agoGet rid of old -altjitcrossgen argument now that CI has been updated
Bruce Forstall [Wed, 13 Dec 2017 17:47:04 +0000 (09:47 -0800)]
Get rid of old -altjitcrossgen argument now that CI has been updated

6 years agoUpdate CoreClr, CoreFx, PgoData to preview1-26013-03, preview1-26013-05, master-20171...
dotnet-maestro-bot [Wed, 13 Dec 2017 16:42:00 +0000 (10:42 -0600)]
Update CoreClr, CoreFx, PgoData to preview1-26013-03, preview1-26013-05, master-20171213-0045, respectively (#15499)

6 years agoAdding Unsafe APIs that are used by System.Memory (#15497)
Ahson Khan [Wed, 13 Dec 2017 13:50:50 +0000 (05:50 -0800)]
Adding Unsafe APIs that are used by System.Memory (#15497)

* Adding Unsafe APIs that are used by System.Memory

* Update comment to match S.R.CS.U xml

* Changing S.R.CS namespace to Internal.R.CS and making Unsafe class public

* Add new InternalCompilerServices namespace to vm

6 years ago[Arm64/Linux] PAL_GetJitCpuCapabilityFlags() (#15447)
Steve MacLean [Wed, 13 Dec 2017 12:00:28 +0000 (07:00 -0500)]
[Arm64/Linux] PAL_GetJitCpuCapabilityFlags() (#15447)

Initial PAL API definition
Implementation for ARM64/Linux

6 years agoFix formatting and put more things under #if
Michal Strehovský [Wed, 13 Dec 2017 11:55:50 +0000 (12:55 +0100)]
Fix formatting and put more things under #if

6 years agoMake GenTree::AsX, gtGetOp1 and gtGetOp2 const
Mike Danes [Wed, 13 Dec 2017 07:05:34 +0000 (09:05 +0200)]
Make GenTree::AsX, gtGetOp1 and gtGetOp2 const

6 years agoMerge pull request #15498 from swgillespie/asyncpin-revert
Jan Kotas [Wed, 13 Dec 2017 04:57:55 +0000 (23:57 -0500)]
Merge pull request #15498 from swgillespie/asyncpin-revert

 Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (#14982)"

6 years agoEnable Vector128/256<T> and Add intrinsics
Fei Peng [Wed, 13 Dec 2017 04:46:49 +0000 (20:46 -0800)]
Enable Vector128/256<T> and Add intrinsics

6 years agoUpdate BuildTools, CoreClr, CoreFx to prerelease-02312-02, preview1-26013-01, preview...
dotnet-maestro-bot [Wed, 13 Dec 2017 03:57:23 +0000 (21:57 -0600)]
Update BuildTools, CoreClr, CoreFx to prerelease-02312-02, preview1-26013-01, preview1-26012-03, respectively (#15486)

6 years agoMerge pull request #15134 from BruceForstall/MakeRyuJITArm32Default
Bruce Forstall [Wed, 13 Dec 2017 03:53:08 +0000 (19:53 -0800)]
Merge pull request #15134 from BruceForstall/MakeRyuJITArm32Default

Make RyuJIT/arm32 the default arm32 JIT

6 years agoRevert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four...
Sean Gillespie [Wed, 13 Dec 2017 03:04:07 +0000 (19:04 -0800)]
Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (#14982)"

This reverts commit c755e3b7f5d597c8d192675dbaaa337268d93f1c.

6 years agoRevert "Cast lp1 to the ScanContext; lp2 is a function pointer. (#15433)"
Sean Gillespie [Wed, 13 Dec 2017 03:03:41 +0000 (19:03 -0800)]
Revert "Cast lp1 to the ScanContext; lp2 is a function pointer. (#15433)"

This reverts commit a37369ab73d49d9957034d8accbdfba4e7f59367.

6 years agoMerge pull request #15475 from briansull/issue-15412
Brian Sullivan [Wed, 13 Dec 2017 01:54:31 +0000 (17:54 -0800)]
Merge pull request #15475 from briansull/issue-15412

Fix for issue 15412

6 years agoMake RyuJIT/arm32 the default arm32 JIT
Bruce Forstall [Tue, 21 Nov 2017 01:18:01 +0000 (17:18 -0800)]
Make RyuJIT/arm32 the default arm32 JIT

RyuJIT/arm32 JIT is now named clrjit.dll (was named protojit.dll).

arm32 LEGACY_BACKEND JIT is now named legacyjit.dll (was named clrjit.dll).

Ubuntu and Tizen testing now use RyuJIT/arm32.

Tests failing for legacy backend are now excluded with `LEGACYJIT_JITSTRESS_FAIL`,
`LEGACYJIT_GCSTRESS_FAIL`, and `LEGACYJIT_FAIL`.

6 years agoMerge pull request #15489 from BruceForstall/DisableFailingArmTests
Bruce Forstall [Wed, 13 Dec 2017 01:17:59 +0000 (17:17 -0800)]
Merge pull request #15489 from BruceForstall/DisableFailingArmTests

Disable 3 failing ARM tests on Windows

6 years agoIgnore *.nuget.cache files. (#15496)
Brian Robbins [Wed, 13 Dec 2017 00:25:13 +0000 (16:25 -0800)]
Ignore *.nuget.cache files. (#15496)

6 years agoFix for issue 15412
Brian Sullivan [Mon, 11 Dec 2017 19:57:22 +0000 (11:57 -0800)]
Fix for issue 15412
  Added an IL test case for this issue
  Added the template C# simplearg.cs that was used to create the test case simplearg.il
  Added extra logging around the initial call of impNormStructVal

6 years agomake coreclr buildable on FreeBSD again (#15480)
Tomas Weinfurt [Tue, 12 Dec 2017 22:22:10 +0000 (14:22 -0800)]
make coreclr buildable on FreeBSD again (#15480)

* small changes to get coreclr building on FreeBSD again

* include <stdlib.h> to get prototype for rand()

* remove extra line

* include copmmon.h instead of stdlib.h

6 years agoDon't create the sampling thread if the threadtime event is disabled. (#15473)
Brian Robbins [Tue, 12 Dec 2017 22:19:19 +0000 (14:19 -0800)]
Don't create the sampling thread if the threadtime event is disabled. (#15473)

6 years agoDisable 3 failing ARM tests on Windows
Bruce Forstall [Tue, 12 Dec 2017 19:49:38 +0000 (11:49 -0800)]
Disable 3 failing ARM tests on Windows

mainv1, mainv2 against #15150 (JitStressRegs=1; JitStressRegs=8)
dlstack against #15156 (JitStress=2 + JitStressRegs=3)

Add PROTOJIT_JITSTRESS_FAIL to their Categories list to disable them.

6 years agoAdd SPMI for getTypeForPrimitiveNumericClass
Fei Peng [Thu, 7 Dec 2017 22:08:55 +0000 (14:08 -0800)]
Add SPMI for getTypeForPrimitiveNumericClass

6 years agoMerge pull request #15487 from mikedn/doc-use-asg
Carol Eidt [Tue, 12 Dec 2017 17:56:36 +0000 (09:56 -0800)]
Merge pull request #15487 from mikedn/doc-use-asg

Update GTF_VAR_USEASG documentation

6 years agoUpdate GTF_VAR_USEASG documentation
Mike Danes [Tue, 12 Dec 2017 17:22:13 +0000 (19:22 +0200)]
Update GTF_VAR_USEASG documentation

6 years agoCorrect sizeToCommit rounding (#15485)
Jan Kotas [Tue, 12 Dec 2017 16:47:30 +0000 (11:47 -0500)]
Correct sizeToCommit rounding (#15485)

6 years agoUpdate BuildTools, PgoData to prerelease-02311-02, master-20171212-0044, respectively...
dotnet-maestro-bot [Tue, 12 Dec 2017 14:31:18 +0000 (08:31 -0600)]
Update BuildTools, PgoData to prerelease-02311-02, master-20171212-0044, respectively (#15468)

6 years agoUse macro _countof instead of explicit sizeof(arr) / sizeof(arr[0]) or sizeof(arr...
Egor Chesakov [Tue, 12 Dec 2017 14:31:00 +0000 (06:31 -0800)]
Use macro _countof instead of explicit sizeof(arr) / sizeof(arr[0]) or sizeof(arr) / sizeof(*arr) in clrjit. (#15474)

6 years agoRemove undefined and unused getPersonalityValue function from CEECompileInfo (#15482)
Egor Chesakov [Tue, 12 Dec 2017 14:30:33 +0000 (06:30 -0800)]
Remove undefined and unused getPersonalityValue function from CEECompileInfo (#15482)

6 years agoAdded comment to explicit number (#15484)
sergey ignatov [Tue, 12 Dec 2017 13:35:19 +0000 (16:35 +0300)]
Added comment to explicit number (#15484)

6 years agoMerge pull request #15454 from mikedn/lower-cmp-minopts
Bruce Forstall [Tue, 12 Dec 2017 05:56:19 +0000 (21:56 -0800)]
Merge pull request #15454 from mikedn/lower-cmp-minopts

Disable LowerCompare optimizations in minopts

6 years agoMerge pull request #15452 from BruceForstall/FixAddOvfl
Bruce Forstall [Tue, 12 Dec 2017 05:51:04 +0000 (21:51 -0800)]
Merge pull request #15452 from BruceForstall/FixAddOvfl

Do not optimize flags-setting add

6 years agoMake EventCacheKey IEquatable (#15470)
Ben Adams [Tue, 12 Dec 2017 05:26:22 +0000 (05:26 +0000)]
Make EventCacheKey IEquatable (#15470)

6 years agoMerge pull request #15478 from BruceForstall/FixArmLocalloc
Bruce Forstall [Tue, 12 Dec 2017 04:14:15 +0000 (20:14 -0800)]
Merge pull request #15478 from BruceForstall/FixArmLocalloc

Fix arm/arm64 localloc

6 years agoMerge pull request #15481 from BruceForstall/FixTimeoutAgain
Bruce Forstall [Tue, 12 Dec 2017 04:13:04 +0000 (20:13 -0800)]
Merge pull request #15481 from BruceForstall/FixTimeoutAgain

Up pri-1 timeouts again

6 years agofix CoreCLR build errors with clang5.0. (#15477)
Sergey Andreenko [Tue, 12 Dec 2017 03:05:15 +0000 (19:05 -0800)]
fix CoreCLR build errors with clang5.0. (#15477)

* spmi: delete the explicit call to the constructor.

MethodContext was already initialized through `new MethodContext();`

* add an artificial using of lambda param.

the define `#define PAL_EXCEPT(dispositionExpression)`
can declare expression that has zero or one param. If it has zero param, then `__param` in the lambda is unused, prevent clang complains by adding this change.

6 years agoUp pri-1 timeouts again
Bruce Forstall [Tue, 12 Dec 2017 01:53:25 +0000 (17:53 -0800)]
Up pri-1 timeouts again

180 minutes was still not enough; we were still getting timeouts.
Up it to 240 minutes.

6 years agoDo not optimize flags-setting add
Bruce Forstall [Sat, 9 Dec 2017 02:07:05 +0000 (18:07 -0800)]
Do not optimize flags-setting add

In minopts, we were attempting to generate "add r0,r0,0" and
optimizing it away completely. But it if needs to generate
the flags, for a subsequent overflow (flags) check, we can't do that.

Fixes #14860

6 years agoFix arm/arm64 localloc
Bruce Forstall [Mon, 11 Dec 2017 22:52:05 +0000 (14:52 -0800)]
Fix arm/arm64 localloc

In the loop, non-initialized memory case, the stack probing code
had silent bad codegen, as follows:
```
mov     r4, 0x4000
subs    r4, sp, r4
bvc     SHORT G_M3294_IG03
movs    r4, 0

G_M3294_IG03:

ldr     r0, [sp]
sub     r0, sp, 0x1000
cmp     r0, r4
blo     SHORT G_M3294_IG04
mov     sp, r0              // Before fix, this was "mov sp, r4"
b       SHORT G_M3294_IG03

G_M3294_IG04:
```

6 years agoMerge pull request #15332 from sdmaclea/PR-ARM64-SIMDIntrinsicGetItem-Contain-Memop
Bruce Forstall [Mon, 11 Dec 2017 21:50:59 +0000 (13:50 -0800)]
Merge pull request #15332 from sdmaclea/PR-ARM64-SIMDIntrinsicGetItem-Contain-Memop

[Arm64] SIMDIntrinsicGetItem contain mem op1

6 years ago[RyuJit][x86] another forgotten case with unused flag in decomposition.
Sergey Andreenko [Mon, 11 Dec 2017 21:48:55 +0000 (13:48 -0800)]
[RyuJit][x86] another forgotten case with unused flag in decomposition.

rotate nodes are rare, so it why we did not see it.

6 years agoMerge pull request #15402 from sdmaclea/PR-ARM64-ISA-FLAGS
Bruce Forstall [Mon, 11 Dec 2017 19:32:51 +0000 (11:32 -0800)]
Merge pull request #15402 from sdmaclea/PR-ARM64-ISA-FLAGS

[Arm64] Define ISA feature flags

6 years agoMerge pull request #15450 from BruceForstall/DisableFinalizerTest
Bruce Forstall [Mon, 11 Dec 2017 18:20:54 +0000 (10:20 -0800)]
Merge pull request #15450 from BruceForstall/DisableFinalizerTest

Disable finalizertest for ARM

6 years agoUpdate BuildTools, CoreClr, CoreFx, PgoData to prerelease-02308-01, preview1-26011...
dotnet-maestro-bot [Mon, 11 Dec 2017 17:35:59 +0000 (11:35 -0600)]
Update BuildTools, CoreClr, CoreFx, PgoData to prerelease-02308-01, preview1-26011-03, preview1-26011-03, master-20171211-0111, respectively (#15413)

6 years agoFix non-PR perf pipeline job (#15438)
Michelle McDaniel [Mon, 11 Dec 2017 15:53:30 +0000 (07:53 -0800)]
Fix non-PR perf pipeline job (#15438)

6 years agoDictionary Initalize CQ (#15461)
Ben Adams [Mon, 11 Dec 2017 15:02:20 +0000 (15:02 +0000)]
Dictionary Initalize CQ (#15461)

6 years agoImprove Dict.Clear CQ (#15459)
Ben Adams [Mon, 11 Dec 2017 02:42:54 +0000 (02:42 +0000)]
Improve Dict.Clear CQ (#15459)

6 years agoFix build with Asan (#15372)
Konstantin Baladurin [Sat, 9 Dec 2017 10:57:20 +0000 (13:57 +0300)]
Fix build with Asan (#15372)

- verify_dependencies: disable checking dependencies for Asan build
  because in this case shared libraries can have undefined symbols
  (if static linking with compiler-rt is used).

- enablesanitizers.sh: remove excess quotes for ASAN_OPTIONS and
  UBSAN_OPTIONS environment variable because otherwise Asan cannot
  parse flags. Also doesn't export ASAN_SYMBOLIZER_PATH for clang > 3.6.

6 years agoDisable LowerCompare optimizations in minopts
Mike Danes [Sat, 9 Dec 2017 10:08:20 +0000 (12:08 +0200)]
Disable LowerCompare optimizations in minopts

6 years agoDisable finalizertest for ARM
Bruce Forstall [Sat, 9 Dec 2017 00:30:26 +0000 (16:30 -0800)]
Disable finalizertest for ARM

It is already disabled in issues.targets and testsFailingOutsideWindows.txt.

It has been failing on Windows ARM under MinOpts.

6 years agoTweak Resize
Ben Adams [Fri, 8 Dec 2017 20:26:24 +0000 (20:26 +0000)]
Tweak Resize

6 years agoAdd scope prefix for class vars
Ben Adams [Fri, 8 Dec 2017 19:19:07 +0000 (19:19 +0000)]
Add scope prefix for class vars

6 years agoMerge pull request #15445 from jashook/arm_archive_obj
Jarret Shook [Fri, 8 Dec 2017 23:21:20 +0000 (15:21 -0800)]
Merge pull request #15445 from jashook/arm_archive_obj

Archive the obj directory for arm builds

6 years agoJit: fix long shift helper for overly long shift counts (#15443)
Andy Ayers [Fri, 8 Dec 2017 23:10:25 +0000 (15:10 -0800)]
Jit: fix long shift helper for overly long shift counts (#15443)

Reduce shift amount modulo 64 to match behavior on other platforms and the
jit optimizer.

Also, fix IL in related test case so it is valid for 32 bits too.

Also, make these two tests pri-0 so they get run with regular CI testing.

Fixes #15442.

6 years ago[Arm64] SIMDIntrinsicGetItem contain mem op1
Steve MacLean [Wed, 29 Nov 2017 00:46:43 +0000 (19:46 -0500)]
[Arm64] SIMDIntrinsicGetItem contain mem op1

6 years agoArchive the obj directory for arm builds
jashook [Fri, 8 Dec 2017 22:29:16 +0000 (14:29 -0800)]
Archive the obj directory for arm builds

This will allow us to correctly populate the core_root for eventual
arm linux testing.

6 years agoFix typo `_TARGET_ARM` to `_TARGET_ARM_`. This happens mostly in comments except...
Egor Chesakov [Thu, 7 Dec 2017 21:20:28 +0000 (13:20 -0800)]
Fix typo `_TARGET_ARM` to `_TARGET_ARM_`. This happens mostly in comments except lsra.cpp.

6 years ago[Arm64] Define ISA feature flags
Steve MacLean [Wed, 6 Dec 2017 18:40:15 +0000 (13:40 -0500)]
[Arm64] Define ISA feature flags

6 years agoFix uaf in DestroyThread function. (#15437)
Konstantin Baladurin [Fri, 8 Dec 2017 20:26:00 +0000 (23:26 +0300)]
Fix uaf in DestroyThread function. (#15437)

Mark thread's buffers as no longer owned before calling
Thread::OnThreadTerminate because thread can delete itself in
this method.

6 years agoMerge pull request #15439 from BruceForstall/FixTimeout
Bruce Forstall [Fri, 8 Dec 2017 19:59:55 +0000 (11:59 -0800)]
Merge pull request #15439 from BruceForstall/FixTimeout

Fix timeouts. Up timeouts for non-default (Pri-1) builds.

6 years agoFix timeouts. Up timeouts for non-default (Pri-1) builds.
Bruce Forstall [Fri, 8 Dec 2017 18:49:15 +0000 (10:49 -0800)]
Fix timeouts. Up timeouts for non-default (Pri-1) builds.

6 years agoAdd optional integer offset to OwnedMemory Pin (#15410)
Ahson Khan [Fri, 8 Dec 2017 11:07:16 +0000 (03:07 -0800)]
Add optional integer offset to OwnedMemory Pin (#15410)

6 years agoAdd GetReference and TryGetArray to MemoryMarshal (#15417)
Ahson Khan [Fri, 8 Dec 2017 11:04:57 +0000 (03:04 -0800)]
Add GetReference and TryGetArray to MemoryMarshal (#15417)

* Add GetReference and TryGetArray to MemoryMarshal

* Marking GetReference with AggressiveInlining

* Do not use ByReference as a return type.

* Addressing PR feedback.

6 years agoMerge pull request #15342 from BruceForstall/FixLongNeg
Bruce Forstall [Fri, 8 Dec 2017 07:39:04 +0000 (23:39 -0800)]
Merge pull request #15342 from BruceForstall/FixLongNeg

Fix NEG decomposition to mark instructions that set and use flags

6 years agoMerge pull request #15407 from BruceForstall/ReduceArmGcStress3JobFrequency
Bruce Forstall [Fri, 8 Dec 2017 07:34:30 +0000 (23:34 -0800)]
Merge pull request #15407 from BruceForstall/ReduceArmGcStress3JobFrequency

Reduce arm/armlb/arm64 GCStress=3 and HeapVerify=1 jobs to weekly

6 years agoCast lp1 to the ScanContext; lp2 is a function pointer. (#15433)
Sean Gillespie [Fri, 8 Dec 2017 02:39:02 +0000 (18:39 -0800)]
Cast lp1 to the ScanContext; lp2 is a function pointer. (#15433)

6 years agoExternalize exception boxing (#15418)
Ben Adams [Fri, 8 Dec 2017 00:26:23 +0000 (01:26 +0100)]
Externalize exception boxing (#15418)