Andrzej Warzynski [Fri, 31 Mar 2023 07:47:02 +0000 (07:47 +0000)]
[mlir][sparse-compiler] Fix typo in a test
This patch fixes a type that was introduced in
https://reviews.llvm.org/D146917 and that triggered buildbot failure:
* https://lab.llvm.org/buildbot#builders/220/builds/18225
This is rather straightforward (and fixes a bogus test failure), hence
sending without a review.
Serguei Katkov [Fri, 31 Mar 2023 07:28:07 +0000 (14:28 +0700)]
[InstCombine] Add tests for min(a,b) +/* max(a,b) pattern.
Nicolas Vasilache [Fri, 31 Mar 2023 07:29:20 +0000 (00:29 -0700)]
[mlir][Transform] NFC - Make debug logging more actionnable
Nicolas Vasilache [Wed, 29 Mar 2023 16:06:53 +0000 (09:06 -0700)]
[mlir][Linalg] Fix Generalize transform
Generalize used to fail on ops that have a null region builder.
This is incorrect, the test should be whether the op has a region or not.
In the future we may want to support 0-region ops with a region builder.
Differential Revision: https://reviews.llvm.org/D147166
Andrzej Warzynski [Sat, 25 Mar 2023 20:01:34 +0000 (20:01 +0000)]
[mlir-cpu-runner] Add support for `-mattr` and `-march` flags
This patch adds support for `-mattr` and `-march` in mlir-cpu-runner.
With this change, one should be able to consistently use mlir-cpu-runner
for MLIR's integration tests (instead of e.g. resorting to lli when some
additional flags are needed). This is demonstrated in
concatenate_dim_1.mlir.
In order to support the new flags, this patch makes sure that
MLIR's ExecutionEngine/JITRunner (that mlir-cpu-runner is built on top of):
* takes into account the new command line flags when creating
TargetMachine,
* avoids recreating TargetMachine if one is already available,
* creates LLVM's DataLayout based on the previously configured
TargetMachine.
This is necessary in order to make sure that the command line
configuration is propagated correctly to the backend code generator.
A few additional updates are made in order to facilitate this change,
including support for debug dumps from JITRunner.
Differential Revision: https://reviews.llvm.org/D146917
Jie Fu [Fri, 31 Mar 2023 07:29:23 +0000 (15:29 +0800)]
[flang] Remove unused variable 'nullBoxTy' in ConvertExpr.cpp (NFC)
/data/llvm-project/flang/lib/Lower/ConvertExpr.cpp:728:10: error: unused variable 'nullBoxTy' [-Werror,-Wunused-variable]
auto nullBoxTy = builder.getRefType(fir::BoxType::get(noneTy));
^
1 error generated.
Martin Storsjö [Thu, 30 Mar 2023 10:31:58 +0000 (13:31 +0300)]
[ARM] Handle generating SEH unwind info for t2STR_PRE/t2LDR_POST
This fixes compiling some uncommon cases.
Differential Revision: https://reviews.llvm.org/D147212
Jean Perier [Fri, 31 Mar 2023 07:13:52 +0000 (09:13 +0200)]
[flang] Fix context less NULL() lowering
The current context less lowering of NULL is producing invalid code
(can lead to reading outside of allocated memory): it is casting
a simple pointer to a descriptor address.
Later, reads are made to this descriptor. It used to be "OK" when
fir.load of fir.box were no-ops, but this was incorrect, and the
fir.load codegen is known doing a copy, and read the whole descriptor
data, not only the base address.
The previous patch that allowed fir.box<None> allocation, this
code fix this by allocating an actual fir.box<None>.
Note: this is still an overkill way to lower foo(null()). HLFIR
lowering always contextualize NULL() lowering leading to much simpler
code:
```
%absent = fir.absent fir.box<T>
fir.call @foo(%absent)
```
Differential Revision: https://reviews.llvm.org/D147239
Jean Perier [Fri, 31 Mar 2023 07:12:43 +0000 (09:12 +0200)]
[flang] allow allocation of scalar TYPE(*) descriptors
Currently, it is OK to have alloca/store/and reboxed to
fir.box<!fir.array<?xnone>> and fir.class<none>, but not simple
fir.box<none>.
This restriction is a legacy from a time where it was thought TYPE(*)
descriptor size would not be statically known, but the way polymorphism
was implemented actually allows knowing its size: a scalar descriptor
with an addendum (in case it is a derived type).
Note that this assumes fir.box<none> are always scalars. There are currently
a few cast from ranked descriptor to !fir.box<None> around runtime calls.
These are simple casts before runtime call, so there are no load/stores
to the resulting fir.box<None> and it is OK.
When assumed rank are supported, some legacy usage of fir.box<none> as the "any"
descriptor in the runtime interface will be replaced to avoid any issues there.
This change will be required to fix an undefined behavior with NULL() that
requires allocation of a fir.box<None>.
Differential Revision: https://reviews.llvm.org/D147237
Jean Perier [Fri, 31 Mar 2023 07:07:29 +0000 (09:07 +0200)]
[flang] move ASSOCIATED intrinsic optional TARGET handling
ASSOCIATED intrinsic TARGET handling is weird for OPTIONAL, because as
opposed to other intrinsic arguments, OPTIONAL allocatable and pointers
may be absent when passed to it, and a diassociated pointer TARGET is not
the same as when TARGET is not provided. Hence, it needs custom
handling in lowering.
The handling was done late (in genIntrinsicCall, without the semantic
context), and assumed it would be possible to retrieve the optionality
aspects, but this is brittle, and hard to share with HLFIR.
Move it in CustomIntrinsicCall that is intended to deal with these
corner case.
Also avoid using fir.box<None> as the related fir.if result, and used
the correct fir.box/fir.class type for the target: using a fir.box<None>
here is risky since fir.box<None> are now meant for scalar TYPE(*), and
the TARGET may be ranked.
Move the introduction of the fir.box<None> around the runtime (when
assumed rank are supported, these will become !fir.box<!fir.array<..xNone>>).
Differential Revision: https://reviews.llvm.org/D147224
Ben Shi [Fri, 31 Mar 2023 01:34:37 +0000 (09:34 +0800)]
[LoongArch] Optimize additions with immediates
Reviewed By: SixWeining, xen0n
Differential Revision: https://reviews.llvm.org/D147222
Ben Shi [Thu, 30 Mar 2023 07:56:10 +0000 (15:56 +0800)]
[LoongArch][NFC] Add tests of additions with immediates (for D147222)
Reviewed By: SixWeining, xen0n, XiaodongLoong
Differential Revision: https://reviews.llvm.org/D147221
Timm Bäder [Fri, 13 Jan 2023 21:22:36 +0000 (22:22 +0100)]
[clang][Interp][NFC] Add failing test case for InterpFrame::describe()
Timm Bäder [Fri, 31 Mar 2023 06:21:54 +0000 (08:21 +0200)]
[clang][Interp][NFC] Add missing static_assert message
This broke builders, e.g.
https://lab.llvm.org/buildbot#builders/139/builds/38298
Tobias Gysi [Fri, 31 Mar 2023 06:08:23 +0000 (06:08 +0000)]
[mlir][llvm] Keep unhandled constant test.
Add the more precise error message introduced in
https://reviews.llvm.org/D142337 to the standard
error produced for unhandled constants. This way
we keep testing both error cases.
Reviewed By: Dinistro
Differential Revision: https://reviews.llvm.org/D147205
Timm Bäder [Fri, 13 Jan 2023 13:07:59 +0000 (14:07 +0100)]
[clang][Interp] Fix parameter map when re-visiting function
'Params' is a member of the ByteCodeEmitter. We only added the
parameters the first time we saw the function, so subsequent visits
didn't work if they had (and used) parameters.
Just do the work everytime we see a function.
Differential Revision: https://reviews.llvm.org/D141681
luxufan [Fri, 31 Mar 2023 05:19:16 +0000 (13:19 +0800)]
[Local] Preserve !align if K dominates J and K has a !noundef
Similar to D142687
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D147122
Wang, Xin10 [Fri, 31 Mar 2023 05:40:39 +0000 (01:40 -0400)]
[NFC]add & to avoid copy
The elements in FragmentMap are big objects, use reference can get
better performance, as someone do in line 1912.
Differential Revision: https://reviews.llvm.org/D147126
Timm Bäder [Thu, 12 Jan 2023 11:25:10 +0000 (12:25 +0100)]
[clang][Interp] Properly identify not-yet-defined functions
Since we now handle functions without a body as well, we can't just use
getHasBody() anymore. Funtions that haven't been defined yet are those
that don't have a body *and* aren't valid.
Also, just pass the information about whether the Function has a body or
not along from the FunctionDecl.
Differential Revision: https://reviews.llvm.org/D141591
Karl-Johan Karlsson [Fri, 31 Mar 2023 04:41:11 +0000 (06:41 +0200)]
[builtins] Support architectures with 16-bit int in __ashlti3, __ashrti3 and __lshrti3
The amount to shift should be specified by the int type not a 32-bit integer
type.
This patch change the functions for 128-bit shifts in compiler-rt the same way
as was done for 64-bit shifts in D78662.
The README.txt is updated with the shift builtins signatures from this patch and D78662.
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D146960
Yevgeny Rouban [Fri, 31 Mar 2023 03:54:44 +0000 (10:54 +0700)]
[IR] Allow destruction of symbol table entries regardless of DiscardValueNames
Value::setNameImpl() is used both to set and reset name of the value.
In destructor of Function all arguments get reset their names
(see Function::clearArguments()). If the arguments had their names set (e.g.
when the function was created with LLVMContex::DiscardValueNames == true)
then their ValueName entries referred by the function's symbol table must be
destructed. They are not destructed if LLVMContex::DiscardValueNames is set to
false because of the fast path in Value::setNameImpl(). See the new test cases
that demonstrate the problem. Without the fix they both crash in the function's
destructor.
In Value::setNameImpl() this patch narrows down the fast path return for
DiscardValueNames == true to allow destruction of ValueName entries if any.
Reviewed By: efriedma
Differential Revision: https://reviews.llvm.org/D143487
aabhinavg [Fri, 31 Mar 2023 04:02:52 +0000 (09:32 +0530)]
[docs][clang] Add extra information inside -fsanitize=unsigned-shift-base for UndefinedBehaviorSanitizer
Close: #60712
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D146947
Peter Rong [Thu, 30 Mar 2023 05:13:25 +0000 (22:13 -0700)]
[WASM] Prevent casting `undef` to `CosntantSDNode`
WebAssembly tries to cast an `undef` to `CosntantSDNode` during `LowerAccessVectorElement`.
These operations will trigger an assertion error in cast.
To avoid this issue, we prevent casting, and abort the lowering operation.
A unit test is also included.
This patch fixes [pr61828](https://github.com/llvm/llvm-project/issues/61828)
Reviewed By: tlively
Differential Revision: https://reviews.llvm.org/D147198
Fangrui Song [Fri, 31 Mar 2023 02:23:14 +0000 (19:23 -0700)]
[docs] Update LLVM_TARGETS_TO_BUILD list
Peter Rong [Thu, 30 Mar 2023 08:44:24 +0000 (01:44 -0700)]
[WASM] Fix legalizer for LowerBUILD_VECTOR.
Constants in BUILD_VECTOR may be down cast into a smaller value that fits LaneBits, i.e., the bit width of elements in the vector.
This cast didn't consider 2^N where it would be cast into -2^N, which still doesn't fit into LaneBits after casting.
This will cause an assertion in later legalization.
2^N should be cast into 0, and this patch reflects such behavior.
This patch also includes a test to reflect the fix.
This patch fixes [issue 61780](https://github.com/llvm/llvm-project/issues/61780)
Related patch: https://reviews.llvm.org/D108669
Reviewed By: tlively
Differential Revision: https://reviews.llvm.org/D147208
wren romano [Fri, 31 Mar 2023 01:21:39 +0000 (18:21 -0700)]
[mlir][sparse] Correcting some terminology / naming-scheme errors.
The name "coords" should be used for the complete tuple of Dimension-/Level-many "crd" values associated with a single element. Whereas the name "coordinates" should only be used for collections of "crd" values which span several elements (e.g., the tensor's coordinates buffer for a single level).
Reviewed By: aartbik
Differential Revision: https://reviews.llvm.org/D147291
Nikolas Klauser [Mon, 27 Mar 2023 16:22:23 +0000 (18:22 +0200)]
[libc++] Add __decay_t and use it instead of decay<>::type
This avoids instantiating lots of types.
Reviewed By: ldionne, #libc
Spies: libcxx-commits
Differential Revision: https://reviews.llvm.org/D146984
Craig Topper [Fri, 31 Mar 2023 00:20:09 +0000 (17:20 -0700)]
[RISCV] Remove -mattr=+f from rvk-user-csr-name.s.
Zvk is all integer, it shouldn't need +f.
NAKAMURA Takumi [Wed, 8 Mar 2023 15:50:45 +0000 (00:50 +0900)]
Move definitions of ArgKind from Intrinsics.h to Intrinsics.td
Values of ArgKind are used (as naked constants) also in IntrinsicEmitter.
They can be dissolved to move their logic to Intrinsics.td.
Differential Revision: https://reviews.llvm.org/D145873
NAKAMURA Takumi [Wed, 8 Mar 2023 15:50:45 +0000 (00:50 +0900)]
Let IntrinsicEnums.inc conditional by GET_INTRINSIC_ENUM_VALUES
Part of https://reviews.llvm.org/D145873
Leonard Chan [Fri, 31 Mar 2023 00:08:02 +0000 (00:08 +0000)]
Revert ""Reland "[hwasan] Provide aliases for c allocation functions for Fuchsia""
This reverts commit
1190a1dbd54d8af074e9d4986c7f9cad5c0037f3.
This probably broke
https://lab.llvm.org/buildbot/#/builders/77/builds/26043/steps/21/logs/stdio
again.
Richard Smith [Thu, 30 Mar 2023 20:08:22 +0000 (13:08 -0700)]
Retain constraints in the canonical form of an auto type.
This is necessary in order for type equality checking, for example
across redeclarations, to require constraints to match. This is also a
prerequisite for including the constraints in manglings.
In passing, fix a bug where TemplateArgument::Profile would produce the
same profile for two structurally different template names, which caused
this change to re-expose the crash previously addressed by D133072,
which it turns out had not quite addressed all problematic cases.
Richard Smith [Thu, 30 Mar 2023 20:04:02 +0000 (13:04 -0700)]
Ignore constraints when determining a canonical template parameter.
This follows C++ [temp.over.link]/6, which says that constraints are not
part of what determines whether two template parameters are equivalent.
This allows templates that have different constraints on nested template
template parameters to be ordered by their constraints.
Richard Smith [Thu, 30 Mar 2023 19:20:19 +0000 (12:20 -0700)]
Convert boolean flag in TemplateParameterListsAreEqual into an
additional enum value and document its meaning.
No functionality change intended.
Richard Smith [Thu, 30 Mar 2023 18:42:14 +0000 (11:42 -0700)]
Clean up template parameter list profiling. No functionality change.
Richard Smith [Thu, 30 Mar 2023 23:07:55 +0000 (16:07 -0700)]
Factor out helper to determine whether a function is a "member-like
constrained friend".
When a friend declaration has a requires-clause, and either it's a
non-template function or it's a function template whose requires-clause
depends on an enclosing template parameter, it is member-like for the
purpose of redeclaration checking. Specifically, the lexically enclosing
class becomes part of its signature, so it can only be redeclared by
another declaration within the same class. In this change, we call such
functions "member-like constrained friends".
No functional change intended.
Craig Topper [Thu, 30 Mar 2023 22:55:37 +0000 (15:55 -0700)]
[RISCV] Add Zicsr and Zifencei to CPUs in RISCVProcessors.td.
I only added Zicsr to CPUs that didn't already have an implication
through the F extension.
As far as I could tell from searching Rocket and Syntacore repositories,
all the CPUs support these instructions.
Reviewed By: asb
Differential Revision: https://reviews.llvm.org/D147261
Craig Topper [Thu, 30 Mar 2023 22:47:03 +0000 (15:47 -0700)]
[RISCV] Correct the EvenSrc/OddSrc computation in isInterleaveShuffle.
StartIndexes[0] Tells exactly which source element is in element 0,
the even source. Nothing needs to be swapped.
Since we're dealing with power of 2 vector lengths, StartIndexes[0]
is almost always even so the condition here was never true. The
exception is when we're interleaving two 1 element vectors. In that
case StartIndexes[0] could be 1.
We recently hit a failure from this on a pulldown. I don't have
the reduced reproducer yet and my naive attempts at making an
interleave of 1 element vectors produces a slideup instead so don't
go through this path.
Reviewed By: luke
Differential Revision: https://reviews.llvm.org/D147268
Craig Topper [Thu, 30 Mar 2023 22:46:57 +0000 (15:46 -0700)]
[RISCV] Test case for D147268. NFC
This test currently miscompiles.
Craig Topper [Thu, 30 Mar 2023 22:28:44 +0000 (15:28 -0700)]
[RISCV] Bump I, F, D, and A extension versions to
20191214 spec version
New versions I2.1, F2.2, D2.2 A2.1
Make F and Zfinx imply Zicsr.
Make G imply Zifencei.
This should have no impact to generated code. We have no plans to require Zicsr/Zifencei extension to be explicitly enabled to use Zicsr/Zifencei instructions in assembly.
See https://reviews.llvm.org/D147183 for documentation regarding what version specification we implement.
Reviewed By: asb
Differential Revision: https://reviews.llvm.org/D147179
Alan Zhao [Mon, 20 Mar 2023 21:53:53 +0000 (14:53 -0700)]
[clang] Fix 2 bugs with parenthesized aggregate initialization
* Fix an issue where temporaries initialized via parenthesized aggregate
initialization don't get destroyed.
* Fix an issue where aggregate initialization omits calls to class
members' move constructors after a TreeTransform. This occurs because
the CXXConstructExpr wrapping the call to the move constructor gets
unboxed during a TreeTransform of the wrapping FunctionalCastExpr (as with a
InitListExpr), but unlike InitListExpr, we dont reperform the
InitializationSequence for the list's expressions to regenerate the
CXXConstructExpr. This patch fixes this bug by treating
CXXParenListInitExpr identically to InitListExpr in this regard.
Fixes #61145
Reviewed By: rsmith
Differential Revision: https://reviews.llvm.org/D146465
dossai.o@yahoo.com [Thu, 30 Mar 2023 13:30:07 +0000 (09:30 -0400)]
[Flang][OpenMP] Add support for logical or reduction in worksharing-loop
Adds support for .or. reductions with logical types.
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D145410
bixia1 [Thu, 30 Mar 2023 20:58:45 +0000 (13:58 -0700)]
[mlir][sparse] Fix a problem in handling data type conversion.
Previously, the genCast function generates arith.trunci for converting f32 to
i32. Fix the function to use mlir::convertScalarToDtype to correctly handle
conversion cases beyond index casting.
Add a test case for codegen the sparse_tensor.convert op.
Reviewed By: aartbik, Peiming, wrengr
Differential Revision: https://reviews.llvm.org/D147272
Jonas Devlieghere [Thu, 30 Mar 2023 21:48:39 +0000 (14:48 -0700)]
[lldb] Fix macos build after
e64cc756819d (2/2)
My previous commit was still missing the ctor and the NativeDelegate
parent class.
Sam Clegg [Wed, 29 Mar 2023 04:54:51 +0000 (21:54 -0700)]
[lld][WebAssembly] Process stub libraries before performing LTO
There are cases where stub library processing can trigger new exports
which might require them to be included at LTO time.
Specifically `processStubLibraries` marks symbols as `forceExports`
which even effect the LTO process.
And since the LTO process can generate new undefined symbols
(specifically libcall function) we need to also process the stub
libraries after LTO.
Differential Revision: https://reviews.llvm.org/D147190
Richard Smith [Thu, 30 Mar 2023 21:21:31 +0000 (14:21 -0700)]
PR60985: Fix merging of lambda closure types across modules.
Previously, distinct lambdas would get merged, and multiple definitions
of the same lambda would not get merged, because we attempted to
identify lambdas by their ordinal position within their lexical
DeclContext. This failed for lambdas within namespace-scope variables
and within variable templates, where the lexical position in the context
containing the variable didn't uniquely identify the lambda.
In this patch, we instead identify lambda closure types by index within
their context declaration, which does uniquely identify them in a way
that's consistent across modules.
This change causes a deserialization cycle between the type of a
variable with deduced type and a lambda appearing as the initializer of
the variable -- reading the variable's type requires reading and merging
the lambda, and reading the lambda requires reading and merging the
variable. This is addressed by deferring loading the deduced type of a
variable until after we finish recursive deserialization.
This also exposes a pre-existing subtle issue where loading a
variable declaration would trigger immediate loading of its initializer,
which could recursively refer back to properties of the variable. This
particularly causes problems if the initializer contains a
lambda-expression, but can be problematic in general. That is addressed
by switching to lazily loading the initializers of variables rather than
always loading them with the variable declaration. As well as fixing a
deserialization cycle, that should improve laziness of deserialization
in general.
LambdaDefinitionData had 63 spare bits in it, presumably caused by an
off-by-one-error in some previous change. This change claims 32 of those bits
as a counter for the lambda within its context. We could probably move the
numbering to separate storage, like we do for the device-side mangling number,
to optimize the likely-common case where all three numbers (host-side mangling
number, device-side mangling number, and index within the context declaration)
are zero, but that's not done in this change.
Fixes #60985.
Reviewed By: #clang-language-wg, aaron.ballman
Differential Revision: https://reviews.llvm.org/D145737
Jakub Kuderski [Thu, 30 Mar 2023 21:13:14 +0000 (17:13 -0400)]
[mlir][vector][NFC] Clean up vector gather lowering comments
These got relocated recently.
Reviewed By: antiagainst
Differential Revision: https://reviews.llvm.org/D147257
Jonas Devlieghere [Thu, 30 Mar 2023 21:11:58 +0000 (14:11 -0700)]
[lldb] Only run TestUniversal64 on macOS 11 and later
GreenDragon is running on a host OS and toolchain that doesn't support
building for Apple Silicon.
NAKAMURA Takumi [Fri, 10 Mar 2023 23:24:39 +0000 (08:24 +0900)]
TableGen: Let getAllDerivedDefinitions() numeric order.
Since `RK::Recs` is sorted by character order, anonymous defs will be
enumerated like this;
- anonymous_0
- anonymous_1
- anonymous_10
- anonymous_100
- anonymous_1000
- ...
- anonymous_99
- anonymous_990
- ...
- anonymous_999
Some records around each gap might be wrapped around along increase or
decrease of records in middle. Then output order of anonymous defs
might be changed.
Numeric sort is expected to prevent such wrap-arounds.
This can be implemented with `StringRef::compare_numeric()`.
- ...
- anonymous_99
- anonymous_100
- ...
- anonymous_999
- anonymous_1000
- ...
See also discussions in D145874.
Differential Revision: https://reviews.llvm.org/D145874
Dave Lee [Thu, 23 Mar 2023 01:38:07 +0000 (18:38 -0700)]
[lldb] Use one Progress event per root module build
Following the work done by @jdevlieghere in D143690, this changes how Clang module build
events are emitted.
Instead of one Progress event per module being built, a single Progress event is used to
encompass all modules, and each module build is sent as an `Increment` update.
Differential Revision: https://reviews.llvm.org/D147248
Jonas Devlieghere [Thu, 30 Mar 2023 20:54:18 +0000 (13:54 -0700)]
[lldb] Fix macos build after
e64cc756819d
Shafik Yaghmour [Thu, 30 Mar 2023 20:35:10 +0000 (13:35 -0700)]
[Clang] Fix how ReadMacroParameterList handles comments in macro parameter-list when in -CC mode
Currently when in -CC mode when processing a function like macro
ReadMacroParameterList(...) does not handle the case where there is a comment
embedded in the parameter-list.
Instead of using LexUnexpandedToken(...) I switched to using
LexUnexpandedNonComment(...) which eats comments while lexing.
Fixes: https://github.com/llvm/llvm-project/issues/60887
Differential Revision: https://reviews.llvm.org/D144511
River Riddle [Thu, 30 Mar 2023 04:21:22 +0000 (21:21 -0700)]
[lldb][NFC] Move various constructor definitions from .h to .cpp
I ran into issues with linking downstream language plugin to liblldb in
debug builds, hitting link time errors of form:
```
undefined reference to `vtable for lldb_private::<Insert LLDB class here>'
```
Anchoring the vtable to the .cpp files resolved those issues.
Differential Revision: https://reviews.llvm.org/D147252
Alex Bradbury [Thu, 30 Mar 2023 20:04:37 +0000 (21:04 +0100)]
[RISCV] Add codegen for the experimental zicond extension
This directly matches the codegen for xventanacondops with vt.maskcn =>
czero.nez and vt.maskc => czero.eqz. An additional difference is that
zicond is available on RV32 in addition to RV64 (xventanacondops is RV64
only).
Differential Revision: https://reviews.llvm.org/D147147
Leonard Chan [Thu, 30 Mar 2023 19:55:05 +0000 (19:55 +0000)]
"Reland "[hwasan] Provide aliases for c allocation functions for Fuchsia"
This reverts commit
c5c6781428a70d1fffd00a256a237cbf5a3ccfd3.
This likely broke the android sanitizer builders prior because it
accidentally enabled interceptors for android, which they don't use, so
c-allocation functions like malloc would go through hwasan.
This reland adds the HWASAN_WITH_INTERCEPTORS check.
Alex Bradbury [Thu, 30 Mar 2023 19:47:28 +0000 (20:47 +0100)]
[RISCV] Slightly weaken expanded seq_cst atomic op to match reference mapping in in the spec
Table A.6 in the RISC-V ISA Manual indicates that sequentially
consistent atomic ops that have a matching instruction should be mapped
to `amo<op>.{w|d}.aqrl`. But sequentially consistent operations that are
mapped to lr/sc should produce `loop: lr.{w|d}.aqrl; <op>; sc.{w|d}.rl;
bnez loop`. Previously, LLVM produced an `sc.{w|d}.aqrl` which was
stronger than necessary. This patch adjusts the relevant logic so that a
`sc.{w|d}.rl` is produced.
Differential Revision: https://reviews.llvm.org/D146933
Dave Lee [Sat, 24 Sep 2022 22:58:03 +0000 (15:58 -0700)]
[lldb] Replace sprintf with snprintf (NFC)
On macOS, `sprintf` is deprecated, using `snprintf` is recommended instead.
Differential Revision: https://reviews.llvm.org/D147246
Louis Dionne [Thu, 30 Mar 2023 12:51:13 +0000 (08:51 -0400)]
[libc++] Systematically define a macro to check whether a feature is unavailable
Previously, we inconsistently defined whether a feature was unavailable
on a given deployment target. We would have availability attributes for
all features, but only some features had the equivalent of a _HAS_NO_FOO
macro in the form of the DISABLE_FTM___foo macros. Instead, systematically
define a _HAS_NO_FOO macro, which makes it easier to understand how to
add availability markup for a new platform.
Differential Revision: https://reviews.llvm.org/D147226
Florian Hahn [Thu, 30 Mar 2023 19:17:12 +0000 (20:17 +0100)]
[LV] Regenerate check lines for test to reduce diff in follow-up patch.
Jisheng Zhao [Tue, 28 Mar 2023 14:32:11 +0000 (10:32 -0400)]
[OpenMP] asynchronous memory copy support
We introduced the implementation of supporting asynchronous routines with depend objects specified in Version 5.1 of the OpenMP Application Programming Interface. In brief, these routines omp_target_memcpy_async and omp_target_memcpy_rect_async perform asynchronous (nonblocking) memory copies between any
combination of host and device pointers. The basic idea is to create the implicit tasks to carry the memory copy calls and handle dependencies specified by depend objects. The implicit tasks are executed via hidden helper thread in OpenMP runtime.
Reviewed By: jdoerfert, tianshilei1992
Committed By: jplehr
Differential Revision: https://reviews.llvm.org/D136103
wren romano [Thu, 30 Mar 2023 01:36:24 +0000 (18:36 -0700)]
[mlir][sparse] Cleaning up some usage of SparseTensorType
This is a followup to D147192.
Reviewed By: aartbik, Peiming
Differential Revision: https://reviews.llvm.org/D147196
Philip Reames [Thu, 30 Mar 2023 16:01:40 +0000 (09:01 -0700)]
[IVDescriptors] Add pointer InductionDescriptors with non-constant strides
This matches the handling for integer IVs. I left the non-opaque cases alone, mostly because they're largely irrelevant today.
This doesn't actually make much difference in vectorization right now as we immediately fail on aliasing checks (which also bail on non-constant strides). Slightly suprisingly, it's the case which *do* need runtime checks which work after this patch as they don't use the same dependency analysis path.
This will also enable non-constant stride pointer recurrences for other consumers. I've auditted said code, and don't see any obvious issues.
duk [Thu, 30 Mar 2023 18:43:12 +0000 (14:43 -0400)]
[MachineOutliner] Fix label outlining regression introduced in D125072
Due to a change in the APIs used to determine what instructions can be outlined, the check for label outling was never hit. Instead, all labels were considered invisible, which is the opposite of the intended behavior and causes obscure crashes down the line. We now replicate the original behavior more closely, with explicit checks for known-good and known-bad instruction types.
Reviewed by: paquette
Differential Revision: https://reviews.llvm.org/D147178
NagaChaitanya Vellanki [Thu, 30 Mar 2023 17:51:06 +0000 (10:51 -0700)]
[clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id
Fixes https://github.com/llvm/llvm-project/issues/61479
Reviewed By: dang
Differential Revision: https://reviews.llvm.org/D146866
Jez Ng [Thu, 30 Mar 2023 18:16:16 +0000 (14:16 -0400)]
[lld-macho] Don't emit spurious dupe method warnings for +load methods
+load methods are static initializers and treated specially by the
runtime: all +load methods for a class & its categories are called when
loading that class, unlike regular methods where only one definition
will get called per message. Thus, there is no need to check for
duplicates.
Reviewed By: #lld-macho, oontvoo
Differential Revision: https://reviews.llvm.org/D147230
Jez Ng [Thu, 30 Mar 2023 18:16:12 +0000 (14:16 -0400)]
[lld-macho][objc] Don't crash when rodata isn't statically linked
We were previously assuming that to hold, but it appears that `swiftc`
may generate classes that link against `__objc_empty_cache` for their
rodata pointer.
This should allow us to re-land {D142916} (as a stack).
Reviewed By: #lld-macho, oontvoo
Differential Revision: https://reviews.llvm.org/D147229
Jez Ng [Thu, 16 Feb 2023 21:18:46 +0000 (16:18 -0500)]
[lld-macho][re-land] Warn on method name collisions from category definitions
This implements ld64's checks for duplicate method names in categories &
classes.
In addition, this sets us up for implementing Obj-C category merging.
This diff handles the most of the parsing work; what's left is rewriting
those category / class structures.
Numbers for chromium_framework:
base diff difference (95% CI)
sys_time 2.182 ± 0.027 2.200 ± 0.047 [ -0.2% .. +1.8%]
user_time 6.451 ± 0.034 6.479 ± 0.062 [ -0.0% .. +0.9%]
wall_time 6.841 ± 0.048 6.885 ± 0.105 [ -0.1% .. +1.4%]
samples 33 22
Fixes https://github.com/llvm/llvm-project/issues/54912.
Issues seen with the previous land will be fixed in the next commit.
Reviewed By: #lld-macho, thevinster, oontvoo
Differential Revision: https://reviews.llvm.org/D142916
SJW [Thu, 30 Mar 2023 18:08:47 +0000 (18:08 +0000)]
[TOSA] Loosen folding restrictions for tosa.add,tosa.sub, tosa.mul
Allow folding of different tensor types when the constant tensor is broadcast.
Removed redundant and incorrect AddZero and MulOne canonical optimizations.
Reviewed By: rsuderman, eric-k256
Differential Revision: https://reviews.llvm.org/D145738
wlei [Thu, 30 Mar 2023 18:21:30 +0000 (11:21 -0700)]
fix docs warning in llvm-profdata.rst
Dave Lee [Sat, 24 Sep 2022 23:06:01 +0000 (16:06 -0700)]
[lldb] Replace deprecated CFPropertyListWriteToStream (NFC)
Replace `CFPropertyListWriteToStream` with its recommended replacement, `CFPropertyListWrite`.
Differential Revision: https://reviews.llvm.org/D147249
Jay Foad [Wed, 29 Mar 2023 16:13:52 +0000 (17:13 +0100)]
[TwoAddressInstruction] Improve tests for register killed by instruction
Define and use a MachineOperand overload of isPlainlyKilled. This
improves codegen in a couple of tests because it catches the case where
MO does not kill Reg but another operand of the same instruction does.
Differential Revision: https://reviews.llvm.org/D147167
Matthias Braun [Thu, 23 Mar 2023 20:38:16 +0000 (13:38 -0700)]
Fix codegen for coroutine with function-try-block
This fixes an assertion error when writing a coroutine with a
function-try-block. In this case the function body is not a
`CompoundStmt` so the code constructing an artificial CXXTryStmt must
also construct a `CompoundStmt` for it.
While on it adjust the `CXXStmt::Create` function to only accept
`CompoundStmt*`.
Differential Revision: https://reviews.llvm.org/D146758
Piotr Zegar [Thu, 30 Mar 2023 18:14:42 +0000 (18:14 +0000)]
[clang-tidy] Fix example provided by add_new_check.py
Currently test for newly added check in clang-tidy fails,
this is because Fix is attached to note, but test is executed
without --fix-notes. This change adding --fix-notes to test.
Fixes: https://github.com/llvm/llvm-project/issues/50400
Reviewed By: carlosgalvezp
Differential Revision: https://reviews.llvm.org/D146875
Changpeng Fang [Thu, 30 Mar 2023 18:13:21 +0000 (11:13 -0700)]
AMDGPU: Created a subclass for the return address operand in the tail call return instruction
Summary:
This is to avoid using the callee saved registers for the return address of the tail call return instruction.
Reviewers:
arsenm, cdevadas
Differential Revision:
https://reviews.llvm.org/D147096
Natasha Kononenko [Thu, 30 Mar 2023 17:57:55 +0000 (17:57 +0000)]
[mlir][tosa] Disable folder for non-int/float/index types in tosa.slice
In order to fold, we need to create an ElementsAttr, and those cannot be
generated from any type. In particular, currently we need to avoid folding
quantized types.
Reviewed By: jpienaar
Differential Revision: https://reviews.llvm.org/D147191
wlei [Mon, 20 Mar 2023 05:37:01 +0000 (22:37 -0700)]
[AutoFDO] Use flattened profiles for profile staleness metrics
For profile staleness report, before it only counts for the top-level function samples in the nested profile, the samples in the inlinees are ignored. This could affect the quality of the metrics when there are heavily inlined functions. This change adds a feature to flatten the nested profile and we're changing to use flatten profile as the input for stale profile detection and matching.
Example for profile flattening:
```
Original profile:
_Z3bazi:20301:1000
1: 1000
3: 2000
5: inline1:1600
1: 600
3: inline2:500
1: 500
Flattened profile:
_Z3bazi:18701:1000
1: 1000
3: 2000
5: 600 inline1:600
inline1:1100:600
1: 600
3: 500 inline2: 500
inline2:500:500
1: 500
```
This feature could be useful for offline analysis, like understanding the hotness of each individual function. So I'm adding the support to `llvm-profdata merge` under `--gen-flattened-profile`.
Reviewed By: hoy, wenlei
Differential Revision: https://reviews.llvm.org/D146452
Alex Brachet [Thu, 30 Mar 2023 18:00:50 +0000 (18:00 +0000)]
[CMake] Switch to -fPIE for Fuchsia Toolchain
This is a reland of D135471, save for dropping libLTO which was
already done in a separate change.
Differential Revision: https://reviews.llvm.org/D147250
Daniel Thornburgh [Thu, 30 Mar 2023 17:40:34 +0000 (10:40 -0700)]
[Docs][llvm-cov] Correct flag name.
LLVM GN Syncbot [Thu, 30 Mar 2023 17:24:21 +0000 (17:24 +0000)]
[gn build] Port
142c3d9d1414
Chenguang Wang [Thu, 30 Mar 2023 17:10:57 +0000 (10:10 -0700)]
[mlir][bazel] reformat BUILD.bazel with buildifier
Reviewed By: jreiffers
Differential Revision: https://reviews.llvm.org/D147244
Jakub Kuderski [Thu, 30 Mar 2023 17:14:36 +0000 (13:14 -0400)]
[docs] Add section on iteration utilities (`zip` & `enumerate`)
Since these are not in C++17, mention them in the programmers manual.
Reviewed By: kazu
Differential Revision: https://reviews.llvm.org/D147199
Daniel Grumberg [Thu, 30 Mar 2023 13:51:45 +0000 (14:51 +0100)]
[clang][ExtractAPI] Reland ExtractAPI for libclang improvements
This relands the changes that were originally introduced by:
- https://reviews.llvm.org/D146656
- https://reviews.llvm.org/D147138
This also fixes the leak that led to these changes being reverted
Differential Revision: https://reviews.llvm.org/D147234
Wei Wang [Tue, 21 Mar 2023 05:36:47 +0000 (22:36 -0700)]
[Coroutines] Look for dbg.declare for temp spills
A temp spill may not have direct dbg.declare attached. This can cause problem for debugger when it wants to print the value in resume/destroy/cleanup functions.
In particular, we found this happening to "this" pointer that a temp is used to store its value in entry block and spilled later.
Reviewed By: ChuanqiXu
Differential Revision: https://reviews.llvm.org/D146543
Louis Dionne [Thu, 30 Mar 2023 17:09:16 +0000 (13:09 -0400)]
[libc++][NFC] Remove stray tests
Those tests are remnants of patches that were created before we renamed
the FTM tests but merged after we renamed them.
Philip Reames [Thu, 30 Mar 2023 16:21:51 +0000 (09:21 -0700)]
[RISCV][LV] Add test coverage for strided access patterns [nfc]
Joseph Huber [Thu, 30 Mar 2023 14:50:56 +0000 (09:50 -0500)]
[libc] Support suspending threads during RPC spin loops
The RPC interface relies on waiting on atomic signals to coordinate
which side of the protocol is in control of the shared buffer. The GPU client
supports briefly suspending the executing thread group. This is used by the
thread scheduler to identify which thread groups can be switched out so that
others may execute. This allows us to ensure that other threads get a chance
to make forward progress while these threads wait on the atomic signal.
This is currently only relevant on the client-side. We could use an
alternative implementation on the server that uses the standard
`nanosleep` on supported hosts.
Reviewed By: JonChesterfield, tianshilei1992
Differential Revision: https://reviews.llvm.org/D147238
Alexey Bataev [Thu, 30 Mar 2023 14:36:12 +0000 (07:36 -0700)]
[SLP]Fix a crash when trying to shuffle multiple nodes.
Need to transform mask after applying shuffle using the mask itself as
a base to correctly mark with identity those indices, actually used in
previous shuffle. Allows to fix a crash, if different sized vectors are
shuffled.
Mateja Marjanovic [Thu, 30 Mar 2023 15:06:37 +0000 (17:06 +0200)]
[AMDGPU][GlobalISel] Add support for S_INDIRECT_REG_WRITE_MOVREL_B32_V[9|10|11|12]
Lei Zhang [Thu, 30 Mar 2023 15:49:57 +0000 (08:49 -0700)]
[mlir][spirv][complex] Convert complex ops to SPIR-V ops
This commit adds conversion from complex construction and
extraction ops to SPIR-V. Other arithemtic ops can be done
via ComplexToStandard patterns.
Reviewed By: kuhar
Differential Revision: https://reviews.llvm.org/D147193
Lei Zhang [Thu, 30 Mar 2023 15:48:24 +0000 (08:48 -0700)]
[mlir][spirv] Support convert complex types
Complex types are converted to a two-element vector type to contain
the real and imaginary numbers.
Reviewed By: kuhar
Differential Revision: https://reviews.llvm.org/D147188
David Green [Thu, 30 Mar 2023 15:46:47 +0000 (16:46 +0100)]
[AArch64] Basic target(+crypto) handling
This adds some basic handling for target(+crypto) attributes. In this patch it
just enabled aes and sha2 regardless of the architecture revision, which
matches gccs implementation (and keeps the patch simple).
Differential Revision: https://reviews.llvm.org/D142135
Benjamin Maxwell [Thu, 30 Mar 2023 14:45:54 +0000 (14:45 +0000)]
[DebugInfo] Correct out-of-bounds error message for DW_FORM_line_strp
DW_FORM_line_strp reads from the .debug_line_str section, but
previously the out-of-bounds error reported the .debug_line section.
This incorrect error message showed up when debugging an issue with
some invalid DWARF5 data.
The verify_string.s test has now been extended to check this (which
required a small change to the DWARF verifier to also look at
DW_FORM_line_strp).
Differential Revision: https://reviews.llvm.org/D146539
Ayushi Shukla [Thu, 30 Mar 2023 14:55:49 +0000 (15:55 +0100)]
[documentation] Fix some typos
This patch fixes https://github.com/llvm/llvm-project/issues/56747
Patch-By: ayushi-8102
Differential Revision: https://reviews.llvm.org/D146892
Louis Dionne [Wed, 29 Mar 2023 21:01:18 +0000 (17:01 -0400)]
[libc++] Add minor test for polymorphic_allocator.construct with mixed argument pair
Re-applying the patch after fixing an issue.
Ivan Kosarev [Thu, 30 Mar 2023 14:31:57 +0000 (15:31 +0100)]
[AMDGPU][MC] v_interp tests to check reported operands.
For these tests we want to make sure the reported operands are the
expected ones.
Reviewed By: foad
Differential Revision: https://reviews.llvm.org/D147228
Corentin Jabot [Thu, 23 Mar 2023 13:26:45 +0000 (14:26 +0100)]
[Clang] Improve diagnostics when using a concept as template argument
When using the name of a template variable or concept in places
where an expression was expected, Clang would drop the cxxscope token
preceeding it, if any.
This leads to subpar diagnostics - complaining about the
identifier being undeclared as clang would not know to look into a
non-global scope.
We make sure the scope is preserved.
When encountering `ns::Concept foo x;`, Clang would also fail
to provide the same quality as it does at global scope.
Reviewed By: aaron.ballman, erichkeane
Differential Revision: https://reviews.llvm.org/D146719
Ivan Kosarev [Thu, 30 Mar 2023 14:17:18 +0000 (15:17 +0100)]
[AMDGPU][AsmParser] Refine SMRD offset definitions.
- Fixes the type of default 8-bit offset operands.
- Adds a test for optional offsets.
This is effectively an NFC.
Reviewed By: dp
Differential Revision: https://reviews.llvm.org/D142231
Serge Pavlov [Thu, 30 Mar 2023 14:27:38 +0000 (21:27 +0700)]
[symbolizer] Build 'Request' object in single point. NFC
All control paths in executeCommand create Request object for use in
calls to 'print' function and do it identically. With this change the
Request object is created in a single point, which simplifies changing
implementation of Request class.
This is a prerequisite patch for implementation of symbol+offset lookup.
Differential Revision: https://reviews.llvm.org/D147115
Rahul Kayaith [Wed, 29 Mar 2023 22:49:08 +0000 (18:49 -0400)]
[mlir][python] Support buffer protocol for splat dense attributes
These can be made to work by setting the buffer strides to 0.
Reviewed By: stellaraccident
Differential Revision: https://reviews.llvm.org/D147187
Ivan Kosarev [Thu, 30 Mar 2023 14:11:28 +0000 (15:11 +0100)]
[AMDGPU][AsmParser][NFC] Refine immediate operand definitions.
Reviewed By: dp
Differential Revision: https://reviews.llvm.org/D144959