platform/upstream/coreclr.git
8 years agoChange JIT-EE interface GUID
Bruce Forstall [Tue, 25 Oct 2016 18:39:54 +0000 (11:39 -0700)]
Change JIT-EE interface GUID

This should have been changed with #7672. However, changing it now
will help prevent unexpected bad interactions with SuperPMI and other
tools that expect the old interface.

8 years agoCheck index before access (#7795)
Dmitry-Me [Tue, 25 Oct 2016 17:02:55 +0000 (20:02 +0300)]
Check index before access (#7795)

8 years agoAdd more lldbplugin/libsosplugin tests (#5606)
Ivan Baravy [Tue, 25 Oct 2016 16:32:15 +0000 (20:32 +0400)]
Add more lldbplugin/libsosplugin tests (#5606)

* Add more libsosplugin tests, update framework

+ Introduce test.assert* functions in testutils.py
+ Print test results as a table with failed assertions highlighted
+ PEP8!

* Add more lldbplugin/libsosplugin tests

8 years agoDo not materialize CAS PseudoCustomAttribute (#7794)
Jan Kotas [Tue, 25 Oct 2016 16:02:38 +0000 (09:02 -0700)]
Do not materialize CAS PseudoCustomAttribute (#7794)

Do not materialize CAS permissionsets as custom attributes in reflection. We are just providing the CAS types in corefx to make things compile, but nothing else.

Fix https://github.com/dotnet/corefx/issues/12759

8 years agoAdd few Interop Marshal APIs (#7742)
Faizur Rahman [Tue, 25 Oct 2016 04:21:29 +0000 (21:21 -0700)]
Add few Interop Marshal APIs (#7742)

Add the following interop Marshal APIs:
M:System.Runtime.InteropServices.Marshal.GenerateGuidForType(System.Type)
M:System.Runtime.InteropServices.Marshal.GenerateProgIdForType(System.Type)
M:System.Runtime.InteropServices.Marshal.GetComObjectData(System.Object,System.Object)
M:System.Runtime.InteropServices.Marshal.GetHINSTANCE(System.Reflection.Module)
M:System.Runtime.InteropServices.Marshal.GetIDispatchForObject(System.Object)
M:System.Runtime.InteropServices.Marshal.GetTypedObjectForIUnknown(System.IntPtr,System.Type)
M:System.Runtime.InteropServices.Marshal.PtrToStringAuto(System.IntPtr)
M:System.Runtime.InteropServices.Marshal.SetComObjectData(System.Object,System.Object,System.Object)
M:System.Runtime.InteropServices.Marshal.StringToCoTaskMemAuto(System.String)
M:System.Runtime.InteropServices.Marshal.StringToHGlobalAuto(System.String)

8 years agoFix typos in windows build instructions (#7789)
Daniel Podder [Tue, 25 Oct 2016 04:14:54 +0000 (21:14 -0700)]
Fix typos in windows build instructions (#7789)

8 years agoFix performance problem introduced in previous change. (#7783)
Mike McLaughlin [Tue, 25 Oct 2016 01:59:13 +0000 (18:59 -0700)]
Fix performance problem introduced in previous change. (#7783)

8 years agoMerge pull request #7782 from sandreenko/fix-tfs-build
sandreenko [Mon, 24 Oct 2016 23:54:56 +0000 (16:54 -0700)]
Merge pull request #7782 from sandreenko/fix-tfs-build

fix tfs build crash

8 years agofix tfs build crash
Sergey Andreenko [Mon, 24 Oct 2016 21:33:13 +0000 (14:33 -0700)]
fix tfs build crash

ifdef EE version statements were forgotten in two files.
Braket was on the wrong line.

8 years agoMerge pull request #7778 from ianhays/binaryreadwrite_buffers
Ian Hays [Mon, 24 Oct 2016 22:23:03 +0000 (15:23 -0700)]
Merge pull request #7778 from ianhays/binaryreadwrite_buffers

Add some extra checks to BinaryReader/Writer buffers

8 years agoAdd back call to BitArray::ClearAll (#7779)
Jan Kotas [Mon, 24 Oct 2016 22:16:12 +0000 (15:16 -0700)]
Add back call to BitArray::ClearAll (#7779)

8 years agoMerge pull request #7706 from mjsabby/lcgjitprofcallbacks
noahfalk [Mon, 24 Oct 2016 21:51:12 +0000 (14:51 -0700)]
Merge pull request #7706 from mjsabby/lcgjitprofcallbacks

Add LCG JIT Compilation Profiler Callbacks

8 years agoMerge pull request #7776 from sivarv/lsraStatFix
Sivarv [Mon, 24 Oct 2016 20:44:43 +0000 (13:44 -0700)]
Merge pull request #7776 from sivarv/lsraStatFix

Fix the condition to dump a basic block stats.

8 years agoPR feedback for BinaryReader/Writer buffers
Ian Hays [Mon, 24 Oct 2016 20:26:42 +0000 (13:26 -0700)]
PR feedback for BinaryReader/Writer buffers

8 years agoAdd some extra checks to BinaryReader/Writer buffers
Ian Hays [Mon, 24 Oct 2016 20:09:36 +0000 (13:09 -0700)]
Add some extra checks to BinaryReader/Writer buffers

8 years agoMerge pull request #7775 from ianhays/cfg_arm64
Ian Hays [Mon, 24 Oct 2016 19:58:19 +0000 (12:58 -0700)]
Merge pull request #7775 from ianhays/cfg_arm64

Add CFG flag to ARM64 build

8 years agoMerge pull request #7772 from jkotas/gcinfo-cleanup
Jan Kotas [Mon, 24 Oct 2016 18:51:06 +0000 (11:51 -0700)]
Merge pull request #7772 from jkotas/gcinfo-cleanup

GCInfoDecoder cleanup

8 years agoFix the condition to dump a basic block stats.
sivarv [Mon, 24 Oct 2016 18:42:03 +0000 (11:42 -0700)]
Fix the condition to dump a basic block stats.

8 years agoAdd CFG flag to ARM64 build
Ian Hays [Mon, 24 Oct 2016 18:04:03 +0000 (11:04 -0700)]
Add CFG flag to ARM64 build

8 years agoMerge pull request #7720 from Dmitry-Me/fixBrokenComparison
Pat Gavlin [Mon, 24 Oct 2016 15:54:25 +0000 (08:54 -0700)]
Merge pull request #7720 from Dmitry-Me/fixBrokenComparison

Fix broken range check

8 years agoReplace LPVOID with void*
Jan Kotas [Mon, 24 Oct 2016 14:59:16 +0000 (07:59 -0700)]
Replace LPVOID with void*

8 years agoSimplify GCINFODECODER_CONTRACT
Jan Kotas [Mon, 24 Oct 2016 04:31:29 +0000 (21:31 -0700)]
Simplify GCINFODECODER_CONTRACT

8 years agoDelete DISABLE_EH_VECTORS
Jan Kotas [Mon, 24 Oct 2016 04:11:49 +0000 (21:11 -0700)]
Delete DISABLE_EH_VECTORS

8 years agoDelete _TARGET_SET_ macro
Jan Kotas [Mon, 24 Oct 2016 01:21:22 +0000 (18:21 -0700)]
Delete _TARGET_SET_ macro

8 years agoFixed month calculating issue of calendars(#7666) (#7769)
Jim Ma [Sat, 22 Oct 2016 16:19:57 +0000 (00:19 +0800)]
Fixed month calculating issue of calendars(#7666) (#7769)

Fixed the issue introduced by misunderstanding the precedence of '+' and
'>>'.

fix #7666

8 years agoFix Binder based PInvoke resolution for dynamic assembly (#7770)
Gaurav Khanna [Sat, 22 Oct 2016 16:18:26 +0000 (09:18 -0700)]
Fix Binder based PInvoke resolution for dynamic assembly (#7770)

8 years agoFixing the StackOverflowException error message. (#4786)
Vijay Ramakrishnan [Sat, 22 Oct 2016 11:51:20 +0000 (04:51 -0700)]
Fixing the StackOverflowException error message. (#4786)

8 years agoFixed typos and format issues on clr-code-guide doc(#7767) (#7768)
Jim Ma [Sat, 22 Oct 2016 11:13:17 +0000 (19:13 +0800)]
Fixed typos and format issues on clr-code-guide doc(#7767) (#7768)

There're several typos and format issues. Just fixed them.

Fix issue #7767

8 years agoPort GC changes from CoreRT (#7764)
Jan Kotas [Sat, 22 Oct 2016 05:07:29 +0000 (22:07 -0700)]
Port GC changes from CoreRT (#7764)

https://github.com/dotnet/corert/pull/2064: Add back limit for maximum object size
https://github.com/dotnet/corert/pull/2061: Fix retail build break

8 years agoFix broken #elif (#7756)
Dmitry-Me [Sat, 22 Oct 2016 04:05:09 +0000 (07:05 +0300)]
Fix broken #elif (#7756)

8 years agoAdd Profiling API callbacks for R2R methods (#7732)
Mukul Sabharwal [Sat, 22 Oct 2016 02:45:06 +0000 (19:45 -0700)]
Add Profiling API callbacks for R2R methods (#7732)

8 years agoMerge pull request #7749 from sivarv/VectorIntDot
Sivarv [Sat, 22 Oct 2016 02:36:25 +0000 (19:36 -0700)]
Merge pull request #7749 from sivarv/VectorIntDot

Recognize Vector<int>.Dot on AVX as a JIT intrinsic.

8 years agoImprove ArraySegment's override of GetHashCode (#4654)
James Ko [Sat, 22 Oct 2016 01:21:27 +0000 (21:21 -0400)]
Improve ArraySegment's override of GetHashCode (#4654)

* Improve ArraySegment's override of GetHashCode

* Use new implementation suggested by @VSadov

* Respond to PR feedback

* Remove the workaround for object.GetHashCode

* Respond to HashHelpers changes

* Fix compile errors.

8 years agoMerge pull request #7739 from pgavlin/DisableGCStressIncompatibleTests
Pat Gavlin [Sat, 22 Oct 2016 01:21:01 +0000 (18:21 -0700)]
Merge pull request #7739 from pgavlin/DisableGCStressIncompatibleTests

Mark tests GCStress-incompatible for x86.

8 years agoMerge pull request #7760 from pgavlin/VSO279832
Pat Gavlin [Sat, 22 Oct 2016 00:24:17 +0000 (17:24 -0700)]
Merge pull request #7760 from pgavlin/VSO279832

Properly initialize the varargs base lclVar.

8 years agoMerge pull request #7759 from pgavlin/VSO278367
Pat Gavlin [Sat, 22 Oct 2016 00:22:49 +0000 (17:22 -0700)]
Merge pull request #7759 from pgavlin/VSO278367

Initialize long return type descs in `gtNewCallNode`.

8 years agoInitialize member variable (#7737)
Dmitry-Me [Fri, 21 Oct 2016 23:38:45 +0000 (02:38 +0300)]
Initialize member variable (#7737)

8 years agoOptimize Vector<int>.Dot on AVX.
sivarv [Thu, 20 Oct 2016 21:46:00 +0000 (14:46 -0700)]
Optimize Vector<int>.Dot on AVX.

8 years agoMerge pull request #7755 from dotnet-bot/from-tfs
Bruce Forstall [Fri, 21 Oct 2016 22:50:36 +0000 (15:50 -0700)]
Merge pull request #7755 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoMerge pull request #7754 from ramarag/Threading
Rama krishnan Raghupathy [Fri, 21 Oct 2016 22:40:14 +0000 (15:40 -0700)]
Merge pull request #7754 from ramarag/Threading

Exposing Some Threading Apis

8 years agoAdding Isafeserializationdata interface
Rama Krishnan Raghupathy [Fri, 21 Oct 2016 22:25:49 +0000 (15:25 -0700)]
Adding Isafeserializationdata interface

8 years agoAddress CR feedback
Mukul Sabharwal [Fri, 21 Oct 2016 22:20:02 +0000 (15:20 -0700)]
Address CR feedback

8 years agoProperly initialize the varargs base lclVar.
Pat Gavlin [Fri, 21 Oct 2016 21:39:18 +0000 (14:39 -0700)]
Properly initialize the varargs base lclVar.

The code that initializes this lclVar was not using the correct helper
to determine whether or not a lclVar was enregistered at the beginning
of a method.

8 years agoMerge pull request #7672 from sandreenko/helper-for-corert
sandreenko [Fri, 21 Oct 2016 21:19:18 +0000 (14:19 -0700)]
Merge pull request #7672 from sandreenko/helper-for-corert

Ready to run helper for static base lookups in shared generic code

8 years agoMerge pull request #7743 from sandreenko/frozen_strings
sandreenko [Fri, 21 Oct 2016 21:09:30 +0000 (14:09 -0700)]
Merge pull request #7743 from sandreenko/frozen_strings

fix value numbering for frozen strings.

8 years agoInitialize long return type descs in `gtNewCallNode`.
Pat Gavlin [Fri, 21 Oct 2016 21:03:58 +0000 (14:03 -0700)]
Initialize long return type descs in `gtNewCallNode`.

All long-returning calls (including helper calls) must have a properly
initialized ReturnTypeDesc. Previously, this ReturnTypeDesc was only
initialized by the importer for a subset of long-returning calls
(essentially user calls), which caused asserts whenother long-returning
calls were created by the compiler (e.g. for field accessors). This
change moves the necessary ReturnTypeDesc initialization into
`gtNewCallNode`.

8 years agoAdd LCG JIT Compilation Profiler Callbacks
Mukul Sabharwal [Fri, 21 Oct 2016 16:24:21 +0000 (09:24 -0700)]
Add LCG JIT Compilation Profiler Callbacks

Methods that contain no metadata (e.g. of sources are IL Stubs,
DynamicMethod, Expression Trees, etc.) also known as LCG methods are not
reported to profilers via the Profiling API. LCG, introduced in .NET 2.0
timeframe is unique in that it doesn't require the method to be hosted
in an assembly > module > type heirarchy and is GCable in of itself.

This change adds new APIs that notify the profiler of such methods but
since there is no metadata to go lookup, it provides some useful pieces
of information that the profiler author may want to expose to the
profiler user.

In the compilation start method we provide a className (always
dynamicClass), a methodName that can be a set of few predetermined names
like (ILStub_COMToCLR, etc.) or if the user has set the name for the LCG
method that can show up here. For example, when using the Expression
Trees API, the user can specify a friendly name which would be returned
here.

In the jit completed callback we provide information for the native code
start address and size. This is particularly useful to get more accurate
accounting of what the (previously unidentified) code is. At least the
user would know it is JITTed if nothing more (but most likely more
information like what kind of stub).

Furthermore, since this is going to be a profiler callback, the profiler
can initiate a stackwalk and give more contextual information to its
users beyond the pieces of information we can provide here that could
identify what they're encountering.

Finally, there is also the case that today the profiling APIs
underreport JITTed code in the process. Considerable amount of LCG code
can now be present in the program and in security-sensitive environments
where tracking JITTed code for security reasons is important the
profiling apis fall short. In such environments there is also often
restrictions on running with elevated privileges, so procuring this data
through other means (like ETW) may pose a challenge.

8 years ago[GDBJIT] Generate more complete debug information (#7617)
kvochko [Fri, 21 Oct 2016 09:17:38 +0000 (12:17 +0300)]
[GDBJIT] Generate more complete debug information (#7617)

* Implement support for classes
* Add support for 'this' argument type
* System.String debug info
* Functions are generated as class members in DWARF, use TypeKey as type key.
* Initial support of references
* Support 'this' artificial argument in gdbjit
* Resolve issue with recursive types in gdbjit
* DWARF classes are terminated even if they don't have children
* Fix System.Char encoding.
* Add support static fields for classes
* Add support for single dimension arrays.
* Simplify signature parsing.
* Preliminary support for multidimensional arrays.
* Add support of value types

8 years agoMerge pull request #7736 from hseok-oh/fix_7649
Maoni Stephens [Fri, 21 Oct 2016 04:47:19 +0000 (21:47 -0700)]
Merge pull request #7736 from hseok-oh/fix_7649

GC for large object allocation when fail to get new segment

8 years agoMerge pull request #7724 from adiaaida/implementDecomposeRotate
Michelle McDaniel [Fri, 21 Oct 2016 03:50:23 +0000 (23:50 -0400)]
Merge pull request #7724 from adiaaida/implementDecomposeRotate

Implement DecomposeRotate

8 years agoMerge pull request #7745 from dotnet-bot/from-tfs
Jan Kotas [Fri, 21 Oct 2016 03:45:43 +0000 (20:45 -0700)]
Merge pull request #7745 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoExposing Some Threading Apis
Rama Krishnan Raghupathy [Fri, 21 Oct 2016 02:51:47 +0000 (19:51 -0700)]
Exposing Some Threading Apis

8 years agoMerge pull request #7727 from AndyAyersMS/LateGCStructBailOut
Andy Ayers [Fri, 21 Oct 2016 01:47:38 +0000 (18:47 -0700)]
Merge pull request #7727 from AndyAyersMS/LateGCStructBailOut

Inliner: avoid inlining callees with GC structs on cold paths

8 years agoGC for large object allocation when fail to get new segment
Hyeongseok Oh [Thu, 20 Oct 2016 10:23:53 +0000 (19:23 +0900)]
GC for large object allocation when fail to get new segment

Delete unnecessary line

8 years agoUpdating the macro redefinition for _isnanf and _copysignf in floatsingle.cpp. This...
dotnet-bot [Thu, 20 Oct 2016 23:18:59 +0000 (16:18 -0700)]
Updating the macro redefinition for _isnanf and _copysignf in floatsingle.cpp. This is required for the scenario when the system CRT header files are used instead of the newer MSVCRT header files.

[tfs-changeset: 1634419]

8 years agoFix build break
Jan Kotas [Thu, 20 Oct 2016 22:55:30 +0000 (15:55 -0700)]
Fix build break

[tfs-changeset: 1634415]

8 years agofix value numbering for frozen strings
Sergey Andreenko [Thu, 20 Oct 2016 22:49:08 +0000 (15:49 -0700)]
fix value numbering for frozen strings

As Pat found it was value numbering issue.

8 years agoAdd comments describing why these tests are disabled.
Pat Gavlin [Thu, 20 Oct 2016 22:30:29 +0000 (15:30 -0700)]
Add comments describing why these tests are disabled.

8 years agoImplement DecomposeRotate
Michelle McDaniel [Wed, 19 Oct 2016 17:43:15 +0000 (10:43 -0700)]
Implement DecomposeRotate

fgRecognizeAndMorphBitwiseRotation can potentially morph a tree with a
TYP_LONG return type on x86 if the rotate amount is a GT_CNS_INT. This
change implements DecomposeRotate for those rotate instructions. There are
5 cases:

1) Rotate by 0: do nothing.
2) Rotate by 32: swap hi and lo.
3) Rotate by < 32: produce a shld/shld (for GT_ROL) or a shrd/shrd (for
GT_ROR).
4) Rotate by >= 32: swap hi and lo, subtract from the rotate amount 32, and
do option 3.
5) Rotate by >= 64: do rotateAmount % 64 to get the rotate amount between
0 and 63, then do one of options 1-4.

This change also updates CodegenBringUpTests\Rotate.cs to exercise these
paths.

8 years agoMerge pull request #7734 from JeremyKuhne/ArrayPool
Jeremy Kuhne [Thu, 20 Oct 2016 18:48:53 +0000 (11:48 -0700)]
Merge pull request #7734 from JeremyKuhne/ArrayPool

Move ArrayPool to System.Private.CoreLib

8 years agoMerge pull request #7730 from dotnet-bot/from-tfs
Bruce Forstall [Thu, 20 Oct 2016 18:30:34 +0000 (11:30 -0700)]
Merge pull request #7730 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoMark tests GCStress-incompatible for x86.
Pat Gavlin [Thu, 20 Oct 2016 18:29:37 +0000 (11:29 -0700)]
Mark tests GCStress-incompatible for x86.

These tests time out when GC stress is enabled on x86.

Fixes #7692 and #7695.

8 years agoreturn add with offset, add version if-defs
Sergey Andreenko [Thu, 20 Oct 2016 17:38:15 +0000 (10:38 -0700)]
return add with offset, add version if-defs

8 years agoFix Attribute implementations of Equals and GetHashCode to properly deal with derived...
Llewellyn Pritchard [Thu, 20 Oct 2016 17:32:02 +0000 (19:32 +0200)]
Fix Attribute implementations of Equals and GetHashCode to properly deal with derived types. #6232 (#6240)

8 years agoAdd cross-reference from test case to inspiring issue
Andy Ayers [Thu, 20 Oct 2016 17:24:54 +0000 (10:24 -0700)]
Add cross-reference from test case to inspiring issue

8 years agoFixing the reference declarations for System.MathF. (#7735)
Tanner Gooding [Thu, 20 Oct 2016 09:04:15 +0000 (02:04 -0700)]
Fixing the reference declarations for System.MathF. (#7735)

8 years agoRemove misleading check (#7654)
Dmitry-Me [Thu, 20 Oct 2016 00:25:48 +0000 (03:25 +0300)]
Remove misleading check (#7654)

8 years agoCall JIT compiler's shutdown logic from crossgen. (#7663)
Peter Kukol [Wed, 19 Oct 2016 23:28:20 +0000 (17:28 -0600)]
Call JIT compiler's shutdown logic from crossgen. (#7663)

* Call JIT compiler's shutdown logic from crossgen.

8 years agoMerge pull request #7733 from rahku/_appdomain
Rahul Kumar [Wed, 19 Oct 2016 23:16:09 +0000 (16:16 -0700)]
Merge pull request #7733 from rahku/_appdomain

fix assembly.Load bug

8 years agoMove ArrayPool to System.Private.CoreLib
Jeremy Kuhne [Wed, 19 Oct 2016 23:02:52 +0000 (16:02 -0700)]
Move ArrayPool to System.Private.CoreLib

Copy ArrayPool source from CoreFX and expose in System.Private.CoreLib.

8 years agofix assembly.Load bug
Rahul Kumar [Wed, 19 Oct 2016 22:09:16 +0000 (15:09 -0700)]
fix assembly.Load bug

8 years agoMerge pull request #7725 from CarolEidt/Fix278372
Carol Eidt [Wed, 19 Oct 2016 21:38:57 +0000 (14:38 -0700)]
Merge pull request #7725 from CarolEidt/Fix278372

RyuJIT/x86: handle must-init multi-reg vars

8 years agoMerge pull request #7726 from dotnet-bot/from-tfs
Bruce Forstall [Wed, 19 Oct 2016 21:10:41 +0000 (14:10 -0700)]
Merge pull request #7726 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoAdd comment to test case and run it through codeformatter.
Andy Ayers [Wed, 19 Oct 2016 20:51:34 +0000 (13:51 -0700)]
Add comment to test case and run it through codeformatter.

8 years agoRemove the UseLatestBehaviorWhenTFMNotSpecified compat switch (#5708)
AlexGhiondea [Wed, 19 Oct 2016 20:24:40 +0000 (13:24 -0700)]
Remove the UseLatestBehaviorWhenTFMNotSpecified compat switch (#5708)

* Default to latest behavior when a TFM is not specified

Instead of requiring that a compatibility switch is set in order to get the
latest behavior for all AppContext switches that are based on TFM, have that
behavior on by default.

* Remove the UseLatestBehaviorWhenTFMNotSpecified compat switch

8 years agoBetter Tuple hashing, avoid boxing in Equals/GetHashCode (#6767)
James Ko [Wed, 19 Oct 2016 20:24:01 +0000 (16:24 -0400)]
Better Tuple hashing, avoid boxing in Equals/GetHashCode (#6767)

8 years agoMerge pull request #7612 from BruceForstall/ELT
Bruce Forstall [Wed, 19 Oct 2016 20:14:54 +0000 (13:14 -0700)]
Merge pull request #7612 from BruceForstall/ELT

Enable Enter/Leave/Tailcall hooks for RyuJIT/x86

8 years agoFix arm32 build break
Rahul Kumar [Wed, 19 Oct 2016 20:03:43 +0000 (13:03 -0700)]
Fix arm32 build break

[tfs-changeset: 1634155]

8 years agocross/build-rootfs.sh: fix default UbuntuPackages for default BuildArch (#7644)
Steve Desmond [Wed, 19 Oct 2016 19:33:49 +0000 (15:33 -0400)]
cross/build-rootfs.sh: fix default UbuntuPackages for default BuildArch (#7644)

* better default UbuntuPackages for default BuildArch
* Remove multiple sets of _UbuntuPackages to default

8 years agoInliner: avoid inlining callees with GC structs on cold paths
Andy Ayers [Thu, 13 Oct 2016 01:00:13 +0000 (18:00 -0700)]
Inliner: avoid inlining callees with GC structs on cold paths

If an inline introduces a local or temp GC struct, the initialization
of that struct is done in the root method prolog. This can hurt
performance if the inline call site is cold. Detect this during
importation and update the inline policy to back out of the inline if
the inline is an always or discretionary candidate.

Jit diffs shows size wins in the core library with no regressions.
```
Total bytes of diff: -8789 (-0.29 % of base)
    diff is an improvement.
Total byte diff includes 0 bytes from reconciling methods
        Base had    0 unique methods,        0 unique bytes
        Diff had    0 unique methods,        0 unique bytes
Top file improvements by size (bytes):
       -8789 : System.Private.CoreLib.dasm (-0.29 % of base)
1 total files with size differences.
Top method improvements by size (bytes):
        -320 : System.Private.CoreLib.dasm - FrameSecurityDescriptor:CheckDemand2(ref,ref,long,bool):bool:this
        -224 : System.Private.CoreLib.dasm - RuntimeConstructorInfo:CheckCanCreateInstance(ref,bool)
        -214 : System.Private.CoreLib.dasm - RuntimeType:GetMethodBase(ref,long):ref
        -150 : System.Private.CoreLib.dasm - CultureInfo:GetCultureInfoByIetfLanguageTag(ref):ref
        -146 : System.Private.CoreLib.dasm - GC:RegisterForFullGCNotification(int,int)
103 total methods with size differences.
```
Desktop testing shows similar wins in a number of places and only
a few sparse small regressions.

Added a perf test. Thanks to @hypersw for noticing this.

Closes #7569.

8 years agoUpdating the new `System.MathF` calls which already existed in `System.Math` to call...
Tanner Gooding [Wed, 19 Oct 2016 19:15:21 +0000 (12:15 -0700)]
Updating the new `System.MathF` calls which already existed in `System.Math` to call the `System.Math` implementation. (#7721)

* Updating the new `System.MathF` calls which already existed in `System.Math` to call the `System.Math` implementation.
* Removing the FCALL entry for MathF.Abs

8 years agoRyuJIT/x86: handle must-init multi-reg vars
Carol Eidt [Wed, 19 Oct 2016 18:28:22 +0000 (11:28 -0700)]
RyuJIT/x86: handle must-init multi-reg vars

In the RyuJIT backend, lclVars can occupy multiple registers, and not have a stack location. These should be handled for must-init as for lvRegister. The existing code was doing this oinly for _TARGET_64_BIT_ when it should be !LEGACY_BACKEND.
This fixes DevDiv VSO bug 278372

8 years agoMerge pull request #7708 from pgavlin/StackParamUntracked
Pat Gavlin [Wed, 19 Oct 2016 18:23:10 +0000 (11:23 -0700)]
Merge pull request #7708 from pgavlin/StackParamUntracked

Always treat incoming on-stack parameters as GC-untracked.

8 years agoMerge pull request #7718 from dotnet-bot/from-tfs
Jan Kotas [Wed, 19 Oct 2016 18:17:40 +0000 (11:17 -0700)]
Merge pull request #7718 from dotnet-bot/from-tfs

Merge changes from TFS

8 years agoEnable Enter/Leave/Tailcall hooks for RyuJIT/x86
Bruce Forstall [Fri, 14 Oct 2016 01:10:33 +0000 (18:10 -0700)]
Enable Enter/Leave/Tailcall hooks for RyuJIT/x86

8 years agofix compilation compilation error without ready to run.
Sergey Andreenko [Wed, 19 Oct 2016 16:37:55 +0000 (09:37 -0700)]
fix compilation compilation error without ready to run.

8 years agoMerge pull request #7714 from gkhanna79/CleanupArm32
Gaurav Khanna [Wed, 19 Oct 2016 16:35:54 +0000 (09:35 -0700)]
Merge pull request #7714 from gkhanna79/CleanupArm32

Cleanup arm32

8 years agofix arm64 build break
Rahul Kumar [Wed, 19 Oct 2016 16:12:10 +0000 (09:12 -0700)]
fix arm64 build break

[tfs-changeset: 1634120]

8 years agoMerge pull request #7709 from wtgodbe/publishProj
Stephen Toub [Wed, 19 Oct 2016 12:27:47 +0000 (08:27 -0400)]
Merge pull request #7709 from wtgodbe/publishProj

Only build TargetingPack when building on Windows

8 years agoFix broken range check
Dmitry-Me [Wed, 19 Oct 2016 11:55:23 +0000 (14:55 +0300)]
Fix broken range check

8 years agoSupport "offline" initializtion of Tools (#7715)
Matt Ellis [Wed, 19 Oct 2016 08:42:45 +0000 (01:42 -0700)]
Support "offline" initializtion of Tools (#7715)

This change allows init-tools to function in an "offline" mode where
tools are picked up from standalone folders. Specifically, it introduces
support for two new environment variables:

- DOTNET_TOOLSET_DIR
- BUILD_TOOLS_TOOLSET_DIR

If either is set, instead of downloading toolsets, we copy an already
existing one from the folder.  The TOOLSET_DIR is a folder with sub
directories for every version of the tool in question.

For buildtools, we expect a published toolset (sans the "dotnetcli"
folder) not just a set of nuget packages (i.e. the layout of Tools/
after running ./init-tools.sh in "online" mode).

The above varibles are useful for situations where we want to carry
multiple toolsets with us, but are less helpful for places where a
developer has produced their own toolset by hand (since the resulting
folder structure contains extra version information). For these cases,
I've added

- DOTNET_TOOL_DIR
- BUILD_TOOLS_TOOL_DIR

Which work like the above but don't require the nested folder structure.

8 years agoFix passing struct with four floats in registers via reflection (#7716)
Jan Vorlicek [Wed, 19 Oct 2016 06:43:29 +0000 (08:43 +0200)]
Fix passing struct with four floats in registers via reflection (#7716)

This change fixes a bug in the code that copies a struct into the transition
frame. When it contains four floats, the first two are put to the right place,
but the following two are placed to an address that's offset by 8 instead of
by 16.

It also adds regression test for this problem as Pri 1 test.

8 years agoFix build break
Jan Kotas [Wed, 19 Oct 2016 06:18:24 +0000 (23:18 -0700)]
Fix build break

[tfs-changeset: 1634099]

8 years agoMerge pull request #7712 from dotnet/revert-7494-CoreLib
Jan Kotas [Wed, 19 Oct 2016 05:14:41 +0000 (22:14 -0700)]
Merge pull request #7712 from dotnet/revert-7494-CoreLib

Revert "Delete mscorlib from CoreCLR targeting pack"

8 years agoCleanup external dependency details
Gaurav Khanna [Wed, 19 Oct 2016 03:28:12 +0000 (20:28 -0700)]
Cleanup external dependency details

8 years agoMerge pull request #7681 from rahku/_appdomain
Rahul Kumar [Wed, 19 Oct 2016 03:00:14 +0000 (20:00 -0700)]
Merge pull request #7681 from rahku/_appdomain

Expose apis in System.Reflection.Assembly

8 years agoEnable DateTimeFormatInfo netstandard 1.7 APIs on Linux (#7713)
Tarek Mahmoud Sayed [Wed, 19 Oct 2016 01:28:36 +0000 (18:28 -0700)]
Enable DateTimeFormatInfo netstandard 1.7 APIs on Linux (#7713)

* Enable DateTimeFormatInfo netstandard 1.7 APIs on Linux

* Remove un-necessary return

8 years agoExpose apis in System.Reflection.Assembly
Rahul Kumar [Mon, 17 Oct 2016 23:52:57 +0000 (16:52 -0700)]
Expose apis in System.Reflection.Assembly

8 years agoformat fix
Sergey Andreenko [Tue, 18 Oct 2016 23:46:59 +0000 (16:46 -0700)]
format fix

8 years agohelper address is already known
Sergey Andreenko [Tue, 18 Oct 2016 23:42:42 +0000 (16:42 -0700)]
helper address is already known