review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

edisonn@google.com [Mon, 22 Jul 2013 15:24:26 +0000 (15:24 +0000)]

Add --csv parameter to skpdiff to dump all scores in a csv file. We can run it with all skps, and have scores available to look at worst offenders progarmatically.

R=djsollen@google.com, zachr@google.com

Review URL: https://codereview.chromium.org/19826002

git-svn-id: http://skia.googlecode.com/svn/trunk@10234 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 22 Jul 2013 15:21:23 +0000 (15:21 +0000)]

Clean up a few warnings on Windows x64.

git-svn-id: http://skia.googlecode.com/svn/trunk@10233 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 22 Jul 2013 14:39:45 +0000 (14:39 +0000)]

Update obvious deps.

This is a step toward targets declaring their deps in a sane fashion.
This change resolves cycles by forcing core to the root, then everything
in skia_lib pointing toward core as best possible, then everything
outside skia_lib depending on skia_lib for things in skia_lib. This
prevents double definitions where a symbol is provided by both the
skia_lib shared object and and a statically linked component of skia_lib.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19823003

git-svn-id: http://skia.googlecode.com/svn/trunk@10231 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Mon, 22 Jul 2013 14:18:08 +0000 (14:18 +0000)]

Update android_make to use arrays instead of space delimited strings

R=borenet@google.com

Review URL: https://codereview.chromium.org/19796008

git-svn-id: http://skia.googlecode.com/svn/trunk@10230 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Mon, 22 Jul 2013 14:12:56 +0000 (14:12 +0000)]

refactor gyp to isolate freetype usage

R=bungeman@google.com

Review URL: https://codereview.chromium.org/19835002

git-svn-id: http://skia.googlecode.com/svn/trunk@10229 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 22 Jul 2013 14:10:08 +0000 (14:10 +0000)]

Make the copy of fontconfig font names before freeing their memory.

R=reed@google.com

Review URL: https://codereview.chromium.org/19466004

git-svn-id: http://skia.googlecode.com/svn/trunk@10228 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Mon, 22 Jul 2013 13:29:20 +0000 (13:29 +0000)]

Revert "migrate skpdiff to tools"

This reverts commit 58a7ec70ce6b4548793a2ddc37c63d3d44edbc36.

git-svn-id: http://skia.googlecode.com/svn/trunk@10226 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Mon, 22 Jul 2013 13:14:04 +0000 (13:14 +0000)]

migrate skpdiff to tools

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19671002

git-svn-id: http://skia.googlecode.com/svn/trunk@10225 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sat, 20 Jul 2013 15:03:26 +0000 (15:03 +0000)]

Add SkNWayCanvas comment API overrides.

SkNWayCanvas should also dispatch beginCommentGroup(), addComment() & endCommentGroup.

R=robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19723012

git-svn-id: http://skia.googlecode.com/svn/trunk@10224 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 20 Jul 2013 07:00:58 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10223 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Sat, 20 Jul 2013 00:24:35 +0000 (00:24 +0000)]

Revert deps changes in r10220 and r10217.

Need to avoid linking in .a things which are already provided by .so things.

git-svn-id: http://skia.googlecode.com/svn/trunk@10222 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 19 Jul 2013 23:18:52 +0000 (23:18 +0000)]

Add a 'unique' method to SkRefCnt, document the usage, and add support.

std::shared_ptr has a method called 'unique' which captures the concept that
a reference count of 1 is special, and can be used to optimize copy on write.
It also has some undocumented need for memory barriers in certain situations
and those needs are documented here.

The motivation for looking into this is crbug.com/258499 . The use of the
reference count in this manner is a benign race with both ref() and unref().
By introducing sk_atomic_unprotected_read, it is possible for Chromium to
annotate this read to tell ThreadSanitizer that this is known.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/18770007

git-svn-id: http://skia.googlecode.com/svn/trunk@10221 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 19 Jul 2013 23:10:37 +0000 (23:10 +0000)]

Lie about views_animated dependencies until Android situation is resolved.

git-svn-id: http://skia.googlecode.com/svn/trunk@10220 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 19 Jul 2013 22:43:15 +0000 (22:43 +0000)]

Fix latent warning as error in Android specific code.

git-svn-id: http://skia.googlecode.com/svn/trunk@10219 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 19 Jul 2013 22:32:11 +0000 (22:32 +0000)]

Add a detachAsStream to SkDynamicMemoryWStream.

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10171

Committed: https://code.google.com/p/skia/source/detail?r=10178

Review URL: https://codereview.chromium.org/19677002

git-svn-id: http://skia.googlecode.com/svn/trunk@10218 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 19 Jul 2013 22:31:23 +0000 (22:31 +0000)]

Update obvious deps.

This is a step toward targets declaring their deps in a sane fashion.
This change resolves cycles by forcing core to the root,
then opts, ports, and utils depending on core, then everything else.
We will need some other change to resolve the fact that
core, opts, ports, and utils depend on each other and other targets which
depend on them. Outside of these targets, things look ok.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19823003

git-svn-id: http://skia.googlecode.com/svn/trunk@10217 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 19 Jul 2013 22:30:11 +0000 (22:30 +0000)]

Fix some noisy warnings on Windows x64.

On Windows x64, sizeof(long) < sizeof(size_t).

Review URL: https://codereview.chromium.org/19786010

git-svn-id: http://skia.googlecode.com/svn/trunk@10216 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 19 Jul 2013 21:45:10 +0000 (21:45 +0000)]

Revert "Slipping in a small bug fix for my previous patch"

This reverts commit 1908ef0441e37c98b00ffe6c0a89d247393aeead.

git-svn-id: http://skia.googlecode.com/svn/trunk@10215 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 19 Jul 2013 21:26:15 +0000 (21:26 +0000)]

bad line in gyp fie snuck into last commit, continuing the ARM breakage

git-svn-id: http://skia.googlecode.com/svn/trunk@10214 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sglez@google.com [Fri, 19 Jul 2013 21:19:11 +0000 (21:19 +0000)]

Slipping in a small bug fix for my previous patch

Review URL: https://codereview.chromium.org/19858002

git-svn-id: http://skia.googlecode.com/svn/trunk@10213 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 19 Jul 2013 21:12:08 +0000 (21:12 +0000)]

use SK_ScalarPI, and fix ARM build

git-svn-id: http://skia.googlecode.com/svn/trunk@10212 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 19 Jul 2013 20:52:12 +0000 (20:52 +0000)]

struct and class forward declarations incompatible on some compilers

git-svn-id: http://skia.googlecode.com/svn/trunk@10211 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 19 Jul 2013 20:46:20 +0000 (20:46 +0000)]

scale --> convolution typo

git-svn-id: http://skia.googlecode.com/svn/trunk@10210 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 19 Jul 2013 20:33:36 +0000 (20:33 +0000)]

missing M_PI include needed on Windows

git-svn-id: http://skia.googlecode.com/svn/trunk@10209 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 19 Jul 2013 20:30:44 +0000 (20:30 +0000)]

remove unused function

git-svn-id: http://skia.googlecode.com/svn/trunk@10208 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sglez@google.com [Fri, 19 Jul 2013 20:21:05 +0000 (20:21 +0000)]

fix mac

BUG=

Review URL: https://codereview.chromium.org/19845003

git-svn-id: http://skia.googlecode.com/svn/trunk@10207 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

humper@google.com [Fri, 19 Jul 2013 20:20:04 +0000 (20:20 +0000)]

The image resampling code has been transplanted from Chrome; it's incredibly fast.

We've tested this CL plumbed into Chrome and done benchmarking with excellent results.

This CL can land independent of any Chrome changes; it's completely internal to skia.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/19335002

git-svn-id: http://skia.googlecode.com/svn/trunk@10206 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

vandebo@chromium.org [Fri, 19 Jul 2013 20:13:44 +0000 (20:13 +0000)]

Revert "Adds SkPDFResourceDict class to manage resource dicts. Refactors existing code to use this class."

This reverts commit r10202

Review URL: https://codereview.chromium.org/19790007

git-svn-id: http://skia.googlecode.com/svn/trunk@10205 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sglez@google.com [Fri, 19 Jul 2013 20:03:57 +0000 (20:03 +0000)]

please fix the build, please
BUG=

Review URL: https://codereview.chromium.org/19693012

git-svn-id: http://skia.googlecode.com/svn/trunk@10204 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

sglez@google.com [Fri, 19 Jul 2013 19:50:00 +0000 (19:50 +0000)]

Add include to fix build

BUG=

Review URL: https://codereview.chromium.org/19516006

git-svn-id: http://skia.googlecode.com/svn/trunk@10203 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 19 Jul 2013 18:58:34 +0000 (18:58 +0000)]

Adds SkPDFResourceDict class to manage resource dicts. Refactors existing code to use this class.

BUG=
R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/18977002

git-svn-id: http://skia.googlecode.com/svn/trunk@10202 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 19 Jul 2013 18:54:04 +0000 (18:54 +0000)]

Fix build problem with reverted issue 16948011

BUG=
R=caryclark@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/19541009

git-svn-id: http://skia.googlecode.com/svn/trunk@10201 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 19 Jul 2013 18:51:10 +0000 (18:51 +0000)]

Remove unneeded mention of SkThread_pthread.cpp in ports.gyp.

This was overlooked in r10105.

git-svn-id: http://skia.googlecode.com/svn/trunk@10200 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 19 Jul 2013 18:20:26 +0000 (18:20 +0000)]

Bench performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10198 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 19 Jul 2013 18:13:02 +0000 (18:13 +0000)]

Fix texture allocation in SWMaskHelper

https://codereview.chromium.org/19789006/

git-svn-id: http://skia.googlecode.com/svn/trunk@10197 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Fri, 19 Jul 2013 17:47:39 +0000 (17:47 +0000)]

revert unreviewed 10194, will send to review

Review URL: https://codereview.chromium.org/19693010

git-svn-id: http://skia.googlecode.com/svn/trunk@10196 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 19 Jul 2013 17:43:27 +0000 (17:43 +0000)]

SkAlpha constant defs

R=edisonn@google.com, vandebo@chromium.org, reed@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19592014

git-svn-id: http://skia.googlecode.com/svn/trunk@10195 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Fri, 19 Jul 2013 17:19:47 +0000 (17:19 +0000)]

skpdiff: add ability to write the diff scores in a csv file (one line per pair of diff images, with the result of each diff engine)

Review URL: https://codereview.chromium.org/19786004

git-svn-id: http://skia.googlecode.com/svn/trunk@10194 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 19 Jul 2013 16:51:46 +0000 (16:51 +0000)]

Alter resource cache and GrContext to (optionally) never reuse a scratch texture

https://codereview.chromium.org/19482004/

git-svn-id: http://skia.googlecode.com/svn/trunk@10193 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 19 Jul 2013 15:45:22 +0000 (15:45 +0000)]

add reformat-json.py script

R=borenet@google.com

Review URL: https://codereview.chromium.org/19289011

git-svn-id: http://skia.googlecode.com/svn/trunk@10192 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 19 Jul 2013 13:55:41 +0000 (13:55 +0000)]

Add a detachAsStream to SkDynamicMemoryWStream.

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10171

Review URL: https://codereview.chromium.org/19677002

git-svn-id: http://skia.googlecode.com/svn/trunk@10178 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 19 Jul 2013 07:00:57 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10175 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 19 Jul 2013 00:50:48 +0000 (00:50 +0000)]

Reverting r10173 due to compile problems

git-svn-id: http://skia.googlecode.com/svn/trunk@10174 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 19 Jul 2013 00:32:39 +0000 (00:32 +0000)]

Measurement tool for Bounding-Box-Hierarchies.

BUG=
R=caryclark@google.com, reed@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/16948011

git-svn-id: http://skia.googlecode.com/svn/trunk@10173 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 23:59:16 +0000 (23:59 +0000)]

Revert r10171 due to test failure in StreamTest

git-svn-id: http://skia.googlecode.com/svn/trunk@10172 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 18 Jul 2013 22:27:21 +0000 (22:27 +0000)]

Add a detachAsStream to SkDynamicMemoryWStream.

R=reed@google.com

Review URL: https://codereview.chromium.org/19677002

git-svn-id: http://skia.googlecode.com/svn/trunk@10171 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 18 Jul 2013 22:26:39 +0000 (22:26 +0000)]

Plumb in flag for reusing scratch textures

R=bsalomon@google.com, brian@thesalomons.net

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/19636002

git-svn-id: http://skia.googlecode.com/svn/trunk@10170 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 18 Jul 2013 21:14:04 +0000 (21:14 +0000)]

add copyright notices

git-svn-id: http://skia.googlecode.com/svn/trunk@10169 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 18 Jul 2013 21:05:50 +0000 (21:05 +0000)]

Update static SkMutex to remove static initializer on Linux.

R=reed@google.com

Review URL: https://codereview.chromium.org/19540018

git-svn-id: http://skia.googlecode.com/svn/trunk@10168 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 18 Jul 2013 20:48:06 +0000 (20:48 +0000)]

use { 0, 0, 0, 0 } to fix warning

git-svn-id: http://skia.googlecode.com/svn/trunk@10167 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 18 Jul 2013 20:20:10 +0000 (20:20 +0000)]

init prevLevel to avoid warning

git-svn-id: http://skia.googlecode.com/svn/trunk@10166 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 18 Jul 2013 20:14:45 +0000 (20:14 +0000)]

Remove assert which is failing.

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10165 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 18 Jul 2013 20:08:26 +0000 (20:08 +0000)]

Test decoding the bounds in skimage.

Test that the bounds match the bounds from doing a pixel decode.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19587003

git-svn-id: http://skia.googlecode.com/svn/trunk@10164 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 18 Jul 2013 20:06:28 +0000 (20:06 +0000)]

Add test to ensure buildTileIndex stores SkStream.

PNG fails this test without https://codereview.chromium.org/19185006/

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19555004

git-svn-id: http://skia.googlecode.com/svn/trunk@10163 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 18 Jul 2013 20:03:15 +0000 (20:03 +0000)]

Support decoding Gray to A8 in PNG.

Move the code which sets the filler and forces gray to rgb after
we get the config, so we can skip them if the caller wants A8.

Call set_gray_to_rgb consistently for both normal decode and subset
decode.

In PNG, prevent subset decodes from alternating configs, which
would otherwise fail.

Use SK_RESTRICT for pointers in getBitmapConfig.

Ref the SkStream input to buildTileIndex, so it will not be destroyed
before calling decodeSubset.

Convert some fields to match Skia style.

Builds on https://codereview.chromium.org/18083026/, which has not yet been checked in.

R=reed@google.com

Review URL: https://codereview.chromium.org/19185006

git-svn-id: http://skia.googlecode.com/svn/trunk@10162 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 18 Jul 2013 19:53:31 +0000 (19:53 +0000)]

pull mipmap class into its own (private) header

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/19462007

git-svn-id: http://skia.googlecode.com/svn/trunk@10161 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 18 Jul 2013 19:42:35 +0000 (19:42 +0000)]

Initialize config.

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10159 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 18 Jul 2013 19:37:46 +0000 (19:37 +0000)]

A8 bitmaps from JPEG are not opaque.

So do not set them to be.

Depends on https://codereview.chromium.org/19185006/

R=reed@google.com

Review URL: https://codereview.chromium.org/19613002

git-svn-id: http://skia.googlecode.com/svn/trunk@10158 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 18 Jul 2013 19:34:49 +0000 (19:34 +0000)]

Allow decoding JPEG into A8.

If the original image is grayscale, allow decoding into A8.

Change the size of PrefConfigTable to allow for 8bit gray, a new source config.

Add a new sampler to SkScaledBitmapSampler to 'convert' to A8.

FIXME: Should there be a dithered option for gray scale?

R=reed@google.com

Review URL: https://codereview.chromium.org/18083026

git-svn-id: http://skia.googlecode.com/svn/trunk@10157 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 18 Jul 2013 19:21:44 +0000 (19:21 +0000)]

Hold on to image-filtered texture in SkGpuDevice

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/19729006

git-svn-id: http://skia.googlecode.com/svn/trunk@10156 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 18 Jul 2013 19:11:30 +0000 (19:11 +0000)]

Add bench to test float to fixed conversion

R=reed@google.com

Review URL: https://codereview.chromium.org/19773006

git-svn-id: http://skia.googlecode.com/svn/trunk@10155 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 18 Jul 2013 19:04:45 +0000 (19:04 +0000)]

Remove unimplemented Mutex() method from SkFontMgr.h.

R=reed@google.com

Review URL: https://codereview.chromium.org/19543008

git-svn-id: http://skia.googlecode.com/svn/trunk@10154 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 18 Jul 2013 18:45:17 +0000 (18:45 +0000)]

svndiff.py: add support for git checkouts
(and yes, we should probably rename the tool soon)

R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/19512002

git-svn-id: http://skia.googlecode.com/svn/trunk@10153 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 18:33:39 +0000 (18:33 +0000)]

Fix for Ubuntu compiler complaint

git-svn-id: http://skia.googlecode.com/svn/trunk@10151 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 18:20:20 +0000 (18:20 +0000)]

Yet another build fix for r10148

git-svn-id: http://skia.googlecode.com/svn/trunk@10150 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 18:07:39 +0000 (18:07 +0000)]

Fix build breakages due to r10148

git-svn-id: http://skia.googlecode.com/svn/trunk@10149 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 17:39:14 +0000 (17:39 +0000)]

Improve null gpu's memory handling

https://codereview.chromium.org/19678010/

git-svn-id: http://skia.googlecode.com/svn/trunk@10148 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 18 Jul 2013 17:22:30 +0000 (17:22 +0000)]

Fix Android bench bots for Xoom due to OOM errors.

BUG= 1422
BUG= 1430
R=borenet@google.com

Review URL: https://codereview.chromium.org/19672007

git-svn-id: http://skia.googlecode.com/svn/trunk@10147 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 17:12:57 +0000 (17:12 +0000)]

The rest of: Add purgeAsNeeded calls before addResource calls

https://codereview.chromium.org/19591003/

git-svn-id: http://skia.googlecode.com/svn/trunk@10146 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 18 Jul 2013 17:11:45 +0000 (17:11 +0000)]

Add purgeAsNeeded calls before addResource calls

https://codereview.chromium.org/19591003/

git-svn-id: http://skia.googlecode.com/svn/trunk@10145 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 18 Jul 2013 13:47:01 +0000 (13:47 +0000)]

add FilterLevel API to SkPaint, replacing various Flag bits

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/19769005

git-svn-id: http://skia.googlecode.com/svn/trunk@10138 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 18 Jul 2013 13:03:03 +0000 (13:03 +0000)]

pdfviewer: fix warning in release

Review URL: https://codereview.chromium.org/19773002

git-svn-id: http://skia.googlecode.com/svn/trunk@10137 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Thu, 18 Jul 2013 11:13:51 +0000 (11:13 +0000)]

Whitespace change to trigger builds.

git-svn-id: http://skia.googlecode.com/svn/trunk@10135 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 18 Jul 2013 07:00:56 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10134 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 17 Jul 2013 21:55:08 +0000 (21:55 +0000)]

[PDF] Use SkTypeface::countGlyphs instead of getAdvancedTypefaceMetrics

resubmit r10063

BUG=1088
R=bungeman@google.com

Author: vandebo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19668002

git-svn-id: http://skia.googlecode.com/svn/trunk@10133 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 17 Jul 2013 21:39:58 +0000 (21:39 +0000)]

Fix leak of GrGLTexID when its owning GrGLTexture has been abandoned.

BUG=260708
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/19580003

git-svn-id: http://skia.googlecode.com/svn/trunk@10132 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 17 Jul 2013 21:39:54 +0000 (21:39 +0000)]

Avoid lineTo() duplication in SkPath::dump().

Currently, SkPath.dump() produces duplicate entries for lineTo():

path.moveTo(0, 0);
path.lineTo(1.00000012f, 0);
path.lineTo(1.00000012f, 0);
path.lineTo(1.00000012f, 1.00000012f);
path.lineTo(1.00000012f, 1.00000012f);
path.lineTo(0, 1.00000012f);
path.lineTo(0, 1.00000012f);
path.lineTo(0, 0);
path.lineTo(0, 0);
path.close();

R=bungeman@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19540004

git-svn-id: http://skia.googlecode.com/svn/trunk@10131 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 17 Jul 2013 21:39:42 +0000 (21:39 +0000)]

Replace all instances of GrRect with SkRect.

And remove the typedef in GrRect.h. The same with GrIRect.

R=robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19449002

git-svn-id: http://skia.googlecode.com/svn/trunk@10130 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 17 Jul 2013 21:39:28 +0000 (21:39 +0000)]

Add getRectCount to SkRegtion

It is useful to know how many rects comprise a region,
since in some situations we can optimize code based on
the complexity of the region. For instance, if we use
SkRegion for tracking invalidation we might opt to use
the region bounds as invalidation instead of iterating
over each rect.

R=reed@google.com, tomhudson@chromium.org, caryclark@google.com, robertphillips@google.com

Author: vmpstr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19366008

git-svn-id: http://skia.googlecode.com/svn/trunk@10129 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

egdaniel@google.com [Wed, 17 Jul 2013 19:30:41 +0000 (19:30 +0000)]

Add bench for hairline paths.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/19238003

git-svn-id: http://skia.googlecode.com/svn/trunk@10128 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Wed, 17 Jul 2013 19:29:19 +0000 (19:29 +0000)]

make OpenCL optional for skpdiff

- add CPU based different pixels metric

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19374006

git-svn-id: http://skia.googlecode.com/svn/trunk@10127 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 17 Jul 2013 19:00:33 +0000 (19:00 +0000)]

pdfviewer: fixes (indents) in input pdf spec

Review URL: https://codereview.chromium.org/19665002

git-svn-id: http://skia.googlecode.com/svn/trunk@10126 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 17 Jul 2013 07:01:13 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10122 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 17 Jul 2013 00:09:10 +0000 (00:09 +0000)]

rebaseline.py: re-record already succeeding test results, just in case
TBR=borenet

Review URL: https://codereview.chromium.org/19459002

git-svn-id: http://skia.googlecode.com/svn/trunk@10121 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 23:49:46 +0000 (23:49 +0000)]

in experimental/ : roll back a few expected GM image checksums, for testing

git-svn-id: http://skia.googlecode.com/svn/trunk@10120 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 23:37:01 +0000 (23:37 +0000)]

svndiff.py: fix --add-new for JSON-format expectations

Review URL: https://codereview.chromium.org/19444003

git-svn-id: http://skia.googlecode.com/svn/trunk@10119 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 16 Jul 2013 22:55:03 +0000 (22:55 +0000)]

Missed this is r9949 (Allow the resource cache to (indirectly) flush the InOrderDrawBuffer - https://codereview.chromium.org/18466005/)

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/19401002

git-svn-id: http://skia.googlecode.com/svn/trunk@10118 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 21:10:54 +0000 (21:10 +0000)]

rebaseline.py: fix --add-new for JSON files
TBR=borenet

Review URL: https://codereview.chromium.org/19415002

git-svn-id: http://skia.googlecode.com/svn/trunk@10117 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 20:43:08 +0000 (20:43 +0000)]

experimental/json-expectations: reformat to match output of rebaseline.py

Created using reformat-json.py script from https://codereview.chromium.org/19289011

Review URL: https://codereview.chromium.org/19289012

git-svn-id: http://skia.googlecode.com/svn/trunk@10116 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 20:20:04 +0000 (20:20 +0000)]

commit updated JSON expectations to experimental (based on gm-expectations at r10113)

Review URL: https://codereview.chromium.org/19399003

git-svn-id: http://skia.googlecode.com/svn/trunk@10115 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 20:14:11 +0000 (20:14 +0000)]

experimental/json-expectations: mark all JSON files as plaintext, so diff tools work

git-svn-id: http://skia.googlecode.com/svn/trunk@10114 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 18:56:32 +0000 (18:56 +0000)]

svndiff.py: add ability to compare before-and-after JSON files, not just raw images

This should complete step 3 of https://goto.google.com/ChecksumTransitionDetail !

R=borenet@google.com

Review URL: https://codereview.chromium.org/19112002

git-svn-id: http://skia.googlecode.com/svn/trunk@10113 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 16 Jul 2013 18:34:14 +0000 (18:34 +0000)]

NIT MASTER 9000

fixed nits

BUG=
R=robertphillips@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/19394004

git-svn-id: http://skia.googlecode.com/svn/trunk@10112 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 16 Jul 2013 18:21:46 +0000 (18:21 +0000)]

Add the lazy decoder from PictureFlags to SkImageDecoder

R=caryclark@google.com, scroggo@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/19109002

git-svn-id: http://skia.googlecode.com/svn/trunk@10111 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 16 Jul 2013 17:39:08 +0000 (17:39 +0000)]

More PathUtilsTest.cpp nits

Reordered the includes, changed define to a constant global var.

more PathUtils Nits

BUG=
R=robertphillips@google.com, tfarina@chromium.org

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/19272014

git-svn-id: http://skia.googlecode.com/svn/trunk@10110 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 16 Jul 2013 17:35:39 +0000 (17:35 +0000)]

rebaseline.py: add --keep-going-on-failure option, off by default

R=borenet@google.com

Review URL: https://codereview.chromium.org/18092004

git-svn-id: http://skia.googlecode.com/svn/trunk@10109 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 16 Jul 2013 16:36:47 +0000 (16:36 +0000)]

Fixed PathUtils nits.

Fixed PathUtils nits

BUG=
R=robertphillips@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/19392002

git-svn-id: http://skia.googlecode.com/svn/trunk@10108 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Tue, 16 Jul 2013 16:11:16 +0000 (16:11 +0000)]

harden and speed up path op unit tests

PathOps tests internal routines direcctly. Check to make sure that
test points, lines, quads, curves, triangles, and bounds read from
arrays are valid (i.e., don't contain NaN) before calling the
test function.

Repurpose the test flags.
- make 'v' verbose test region output against path output
- make 'z' single threaded (before it made it multithreaded)

The latter change speeds up tests run by the buildbot by 2x to 3x.

BUG=

Review URL: https://codereview.chromium.org/19374003

git-svn-id: http://skia.googlecode.com/svn/trunk@10107 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Tue, 16 Jul 2013 15:47:07 +0000 (15:47 +0000)]

add table pregeneration script for pmetric

R=djsollen@google.com

Review URL: https://codereview.chromium.org/19256002

git-svn-id: http://skia.googlecode.com/svn/trunk@10106 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Tue, 16 Jul 2013 14:59:24 +0000 (14:59 +0000)]

Split TLS implementation into its own translation unit.

SkTLS has it's own header separate from SkThread, and having SkThread own
the platform implementation of SkTLS is problematic with Chromium. The
simplest way to clean this up is to put the implementation in its own set
of files, where it is also more easily found.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/19240007

git-svn-id: http://skia.googlecode.com/svn/trunk@10105 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;

RSS Atom