platform/upstream/dotnet/runtime.git
5 years agoManually updating dependencies in order to get the new coreclr packages. (dotnet...
Jose Perez Rodriguez [Thu, 18 Apr 2019 00:48:24 +0000 (17:48 -0700)]
Manually updating dependencies in order to get the new coreclr packages. (dotnet/corefx#36976)

* Update the Index and Range interfaces and tests

* Fix api compat failure with utf8string

* Fix the test to use Assert.Throws

* Update dependencies manually

Commit migrated from https://github.com/dotnet/corefx/commit/d5a5f3c9eb96adf38115cbc04e5664abf328b02d

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36922)
dotnet-maestro[bot] [Wed, 17 Apr 2019 23:18:59 +0000 (16:18 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36922)

* Update dependencies from https://github.com/dotnet/coreclr build 20190415.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27615-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27615-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27615-72

* Update dependencies from https://github.com/dotnet/coreclr build 20190416.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27616-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27616-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27616-72

* Update CoreCLR dependencies to 3.0.0-preview5-27616-73

* Fixing the Min/Max and MinMagnitude/MaxMagnitude for System.Math and System.MathF to expect NaN propagation

Commit migrated from https://github.com/dotnet/corefx/commit/818355a02ec70c72d44e4ad2b1b95943350d55bb

5 years agoAdd Json serializer property name related features (dotnet/corefx#36940)
Steve Harter [Wed, 17 Apr 2019 22:52:49 +0000 (15:52 -0700)]
Add Json serializer property name related features (dotnet/corefx#36940)

Commit migrated from https://github.com/dotnet/corefx/commit/bc8c22291049b2626ec5b102869685fc95fa41cc

5 years agoUse NativeLibrary.[Try]Load for netcoreapp3 (dotnet/corefx#36944)
Adeel Mujahid [Wed, 17 Apr 2019 18:44:46 +0000 (19:44 +0100)]
Use NativeLibrary.[Try]Load for netcoreapp3 (dotnet/corefx#36944)

Commit migrated from https://github.com/dotnet/corefx/commit/fbc748b93e65600a68b217ec59fc4522d5df4ffb

5 years agoRegenerating the System.Runtime.Intrinsics reference source (dotnet/corefx#36965)
Tanner Gooding [Wed, 17 Apr 2019 17:07:51 +0000 (10:07 -0700)]
Regenerating the System.Runtime.Intrinsics reference source (dotnet/corefx#36965)

Commit migrated from https://github.com/dotnet/corefx/commit/fa25b86d6789440f42ba391deda428e302f584f9

5 years agoDisable asserting HttpListener web socket test (dotnet/corefx#36964)
Stephen Toub [Wed, 17 Apr 2019 15:15:40 +0000 (11:15 -0400)]
Disable asserting HttpListener web socket test (dotnet/corefx#36964)

Commit migrated from https://github.com/dotnet/corefx/commit/18cd561127e35841db2775dc7a85adad70363e18

5 years agoadding default encoder as png when we are not able to find encoder (dotnet/corefx...
Anirudh Agnihotry [Wed, 17 Apr 2019 06:22:12 +0000 (23:22 -0700)]
adding default encoder as png when we are not able to find encoder (dotnet/corefx#36937)

Commit migrated from https://github.com/dotnet/corefx/commit/dbbabfbf3e5a355b9bde2a01f2effde96631242a

5 years agoRun IBCMerge on Linux build (dotnet/corefx#36924)
Michal Strehovský [Wed, 17 Apr 2019 04:47:15 +0000 (06:47 +0200)]
Run IBCMerge on Linux build (dotnet/corefx#36924)

This reverts commit dotnet/corefx@8e843314e1dbd3b3f26abb1f285349be8920cce4.

Commit migrated from https://github.com/dotnet/corefx/commit/f9f88bd7fd774ce433a764b6d388517c6460164a

5 years agofix tests with http/2 (dotnet/corefx#36945)
Tomas Weinfurt [Wed, 17 Apr 2019 04:00:27 +0000 (21:00 -0700)]
fix tests with http/2 (dotnet/corefx#36945)

Commit migrated from https://github.com/dotnet/corefx/commit/f80cf8c360ef00c9a5fdc990e3abd7df23ee0015

5 years agoUpdate testdata versions (dotnet/corefx#36938)
Viktor Hofer [Wed, 17 Apr 2019 00:40:30 +0000 (02:40 +0200)]
Update testdata versions (dotnet/corefx#36938)

* Update testdata versions

* Bump versions in projects and group in TestData

* Fix typo

Commit migrated from https://github.com/dotnet/corefx/commit/e5d2b5291277dbd7444d0a17a2bff4784265d917

5 years agoFix ClientWebSocket close handshake when using proxy (dotnet/corefx#36928)
David Shulman [Wed, 17 Apr 2019 00:15:30 +0000 (17:15 -0700)]
Fix ClientWebSocket close handshake when using proxy (dotnet/corefx#36928)

When the client websocket was going through a proxy, it would sometimes transition to the
'Aborted' state and not the 'Closed' state after a successful closing handshake.

I first opened this bug a year ago but finally was able to get back to it and root cause the
problem. The problem only occured with the managed websocket. The .NET Framework did not have
this problem. And some proxies didn't cause a problem with managed websocket (such as Fiddler).

The root cause is a misinterpretation of RFC 6455, Section 7.1.1. This describes the behavior
of how the websocket's TCP connection should be closed. The most graceful way is to wait for
the server to initiate the close of the socket. In cases where it is taking too long to wait
for the server to start the TCP close, then the client can start the TCP close of the socket.

But no matter how the socket is finally closed, the websocket state should transition to 'Closed'
as soon as a valid closing handshake was performed (i.e. close frames both sent and received).
And this occurs before any logic for closing the TCP connection.

The code in managed websocket has a timer to wait 1 second for the server to start a close. If
the timer finishes, then the managed websocket calls an Abort() method to close the socket. This
ends up transitioning the websocket to an 'Aborted' state which is incorrect. The state should
only be moved to the 'Aborted' state if a closing handshake was not completed.

I added a new test to support this change and moved the LoopbackProxyServer code to Common.

Fixes dotnet/corefx#28027

Commit migrated from https://github.com/dotnet/corefx/commit/0c9684c2c4057908cf697a366a3b1527326e507d

5 years agoFix VB.Core SLN configurations (dotnet/corefx#36934)
Eric StJohn [Tue, 16 Apr 2019 23:06:39 +0000 (16:06 -0700)]
Fix VB.Core SLN configurations (dotnet/corefx#36934)

Commit migrated from https://github.com/dotnet/corefx/commit/39cc91592c3d9c8fe7700a6323755cd7747c34ab

5 years agoadd tests for invalid HTTP headers (dotnet/corefx#36898)
Tomas Weinfurt [Tue, 16 Apr 2019 21:53:07 +0000 (14:53 -0700)]
add tests for invalid HTTP headers (dotnet/corefx#36898)

* add SendAsync_InvalidHeader_Throw

* fix tests

* move SendAsync_InvalidHeader_Throw

Commit migrated from https://github.com/dotnet/corefx/commit/18e1fabd13b40eb6ea88c1b7bae8c4e14a927019

5 years agoUpdate owners (dotnet/corefx#36936)
Carlos Sanchez Lopez [Tue, 16 Apr 2019 21:24:34 +0000 (14:24 -0700)]
Update owners (dotnet/corefx#36936)

Updating ownership in the System.Net area (removing Max and Caesar).
URI - Will.

Commit migrated from https://github.com/dotnet/corefx/commit/c3c0efd9029370ab9762ee254e3db8b8e3dddf34

5 years agoMove EventSource to shared CoreLib partition
Filip Navara [Sun, 14 Apr 2019 20:50:50 +0000 (22:50 +0200)]
Move EventSource to shared CoreLib partition

Commit migrated from https://github.com/dotnet/corefx/commit/00279f8fd11a96f57b8a56855d313f9e2c9bb513

5 years agosupport HTTP/2 without TLS (dotnet/corefx#36753)
Tomas Weinfurt [Tue, 16 Apr 2019 18:54:24 +0000 (11:54 -0700)]
support HTTP/2 without TLS (dotnet/corefx#36753)

* support HTTP/2 without ssl

* feedback from review

* revert changes GetAsync->SendAsync

* remove unused variable

* feedback from review

* feedback from review

* add missong Trace().

Commit migrated from https://github.com/dotnet/corefx/commit/7ed0c5338941346a3cacb4e18f19aaddb283da90

5 years agoReact to RunTests CLI changes & Manual darc update (dotnet/corefx#36915)
Viktor Hofer [Tue, 16 Apr 2019 17:41:48 +0000 (19:41 +0200)]
React to RunTests CLI changes & Manual darc update (dotnet/corefx#36915)

* Manual darc update from build '20190415.12'

* React to RunTests CLI changes

Commit migrated from https://github.com/dotnet/corefx/commit/53f9e9e7fc87cbc08449307fbb0fbe567516e38f

5 years agoRemove devdocs from System.Runtime.InteropServices code (dotnet/corefx#36669)
Hugh Bellamy [Tue, 16 Apr 2019 14:59:12 +0000 (15:59 +0100)]
Remove devdocs from System.Runtime.InteropServices code (dotnet/corefx#36669)

* Cleanup System.Runtime.InteropServices code

- Move public classes/enums to their own file
- Use summary instead of devdoc
- Misc

Commit migrated from https://github.com/dotnet/corefx/commit/8d79b6117e9d584eebb8b6933bba83dd514010ca

5 years agoUpdate SDK requirement in windows-instructions
Viktor Hofer [Tue, 16 Apr 2019 11:59:00 +0000 (13:59 +0200)]
Update SDK requirement in windows-instructions

Commit migrated from https://github.com/dotnet/corefx/commit/e2ecd2c33aed216f9a1062044aedf10e25ee8ca4

5 years agoUpgrade dotnet SDK to 3.0-preview3 (dotnet/corefx#36859)
Viktor Hofer [Tue, 16 Apr 2019 07:19:21 +0000 (09:19 +0200)]
Upgrade dotnet SDK to 3.0-preview3 (dotnet/corefx#36859)

* Upgrade SDK to 3.0

* Remove asp and desktop framework references

* Manual darc update from build '20190415.1'

* Suppress type overlap with ns2.1

* Make SDK use output of core-setup for both ref and runtime

SDK is ignoring RuntimeFrameworkVersion for ref packs.  Set TargetingPackVersion
on KnownFrameworkReference instead.

https://github.com/dotnet/sdk/issues/3129

Commit migrated from https://github.com/dotnet/corefx/commit/66bcc2d2b1248ed5384393adf5f3a647d18b75f1

5 years agoRef Assembly and Units for Span.Trim (dotnet/corefx#35576)
Grant [Tue, 16 Apr 2019 01:24:04 +0000 (18:24 -0700)]
Ref Assembly and Units for Span.Trim (dotnet/corefx#35576)

* Units for Trim

* Add ref assembly

* Bug

* Add char units

* Bugs

* CR fixes - 1

* CR fixes - 2

* CR fixes - 3

* CR fixes - 4

* CR fixes - 5

* Revert formatting

* unfo formatting

* Get MemberData working

* Normalize ref

* Manual revert changes

* CR fixes

* Undo code cleanup

* Fixes

* Update ref

* Update ref

* Update ref

* Move memory tests

* Revert StringTests

* Remove redundant unit code

* Add missing refs

* Bug

* dotnet msbuild /t:GenerateReferenceSource

* Revert unintended changes

* POC : Check if fix works

* Fix units

* Revert temp test

* Update ApiCompatBaseline.uapaot.txt

Commit migrated from https://github.com/dotnet/corefx/commit/2191763a765654710df5317dc65dc7cd935bc8c1

5 years agoadd test for lower casing header name logic (dotnet/corefx#36708)
Tomas Weinfurt [Mon, 15 Apr 2019 22:15:32 +0000 (15:15 -0700)]
add test for lower casing header name logic  (dotnet/corefx#36708)

* add test for 35164

* update SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2

* fix uwp tests

* change port from 123 to 443

Commit migrated from https://github.com/dotnet/corefx/commit/4e3b46c22cec88a1f0deaa2f594634e5553412e1

5 years agoRemove null coalescing assignment operator to avoid build-from-source compile issues...
Steve Harter [Mon, 15 Apr 2019 21:44:04 +0000 (14:44 -0700)]
Remove null coalescing assignment operator to avoid build-from-source compile issues (dotnet/corefx#36890)

Commit migrated from https://github.com/dotnet/corefx/commit/f78e9881bd8ef1def0227569d822693b944378a7

5 years agoClose the socket if bind() fails (dotnet/corefx#36769)
Omair Majid [Mon, 15 Apr 2019 20:55:02 +0000 (16:55 -0400)]
Close the socket if bind() fails (dotnet/corefx#36769)

When using a socket with bind() and bind fails, close the socket to free
up the resources associated with the socket.

Commit migrated from https://github.com/dotnet/corefx/commit/03ae543d4da4e539b9915a5f38f36a69739fa9d9

5 years agoJson deserializer collection perf improvements by avoiding boxing (dotnet/corefx...
Steve Harter [Mon, 15 Apr 2019 17:58:03 +0000 (10:58 -0700)]
Json deserializer collection perf improvements by avoiding boxing (dotnet/corefx#36865)

Commit migrated from https://github.com/dotnet/corefx/commit/6bfaf4116b5180c857bf6ad531f0655fd57c5eef

5 years agoRemove myget publish entirely (dotnet/corefx#36886)
Santiago Fernandez Madero [Mon, 15 Apr 2019 17:55:42 +0000 (12:55 -0500)]
Remove myget publish entirely (dotnet/corefx#36886)

Commit migrated from https://github.com/dotnet/corefx/commit/d601d2e7602c9dbb6ae0d95c450bce2db027f78d

5 years agoAdd guard for runtimes that support large arrays (dotnet/corefx#36883)
Filip Navara [Mon, 15 Apr 2019 16:46:18 +0000 (18:46 +0200)]
Add guard for runtimes that support large arrays (dotnet/corefx#36883)

Commit migrated from https://github.com/dotnet/corefx/commit/679dba7531d3be10b387203c9a9f350f39ea3a8a

5 years agoRestore internal tools using .net core restore (dotnet/corefx#36840)
Santiago Fernandez Madero [Mon, 15 Apr 2019 16:03:58 +0000 (11:03 -0500)]
Restore internal tools using .net core restore (dotnet/corefx#36840)

* Restore internal tools using .net core restore

* Restore internal tools from dnceng-internal

Bump TestILC version

* Manual Darc update from build '20190414.2'

* Add buildExtraArguments to common

Commit migrated from https://github.com/dotnet/corefx/commit/10d7d6f812295a572eb148aedb19efd2f96fbe17

5 years agoAdd more number converter tests (dotnet/corefx#36653)
Hugh Bellamy [Mon, 15 Apr 2019 14:15:24 +0000 (15:15 +0100)]
Add more number converter tests (dotnet/corefx#36653)

* Add more number converter tests

* Fix if bug in BaseNumberConverter

* Address PR feedback

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/25c10204a69c09afd0701740d1555eba04496c71

5 years agoUpdate ProjectNTfs, ProjectNTfsTestILC to beta-27612-00, beta-27612-00, respectively...
dotnet-maestro-bot [Mon, 15 Apr 2019 04:10:26 +0000 (21:10 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27612-00, beta-27612-00, respectively (dotnet/corefx#36867)

Commit migrated from https://github.com/dotnet/corefx/commit/81e0e2cb79e272e6e270c6562017b64f9c773e99

5 years agoSocketPal.Unix: replace DangerousGetHandle with SafeHandle marshalling (dotnet/corefx...
Tom Deseyn [Mon, 15 Apr 2019 01:48:56 +0000 (03:48 +0200)]
SocketPal.Unix: replace DangerousGetHandle with SafeHandle marshalling (dotnet/corefx#36721)

* SocketPal.Unix: replace DangerousGetHandle with SafeHandle marshalling

DangerousGetHandle was used here for performance. SafeHandle marshalling is
faster now, and preferable to avoid using invalid handles.

* Socket.Windows: replace DangerousGetHandle with SafeHandle marshalling for async operations

Commit migrated from https://github.com/dotnet/corefx/commit/88b6ebe8faaadb027c1378132dc9767c13912159

5 years agoCleanup SocketOptionNameTest (dotnet/corefx#36864)
David Shulman [Mon, 15 Apr 2019 01:34:25 +0000 (18:34 -0700)]
Cleanup SocketOptionNameTest (dotnet/corefx#36864)

One of the oldest issues dotnet/corefx#4887 was about the Windows socket option, ReuseUnicastPort.
This test was disabled several years ago because it was very difficult to test in CI since it
required not only a newer version of Windows but also specific network settings on the machine.

At this point, there is not any way to reliably test this. And the end-to-end test isn't really
of high value for .NET Core since we would really be mostly testing an OS feature.

As part of cleaning that issue up, I cleaned up the rest of the tests, some of which were marked
as Outerloop but didn't need to be.

Closes dotnet/corefx#29929
Closes dotnet/corefx#21327
Closes dotnet/corefx#4887

Commit migrated from https://github.com/dotnet/corefx/commit/f389a14d375ef90f971bc15095b925f73845a7d3

5 years agoRemove IgnoredTypes entries for the System.Runtime.Intrinsics.Arm.Arm64 types (dotnet...
Tanner Gooding [Mon, 15 Apr 2019 00:46:34 +0000 (17:46 -0700)]
Remove IgnoredTypes entries for the System.Runtime.Intrinsics.Arm.Arm64 types (dotnet/corefx#36866)

Commit migrated from https://github.com/dotnet/corefx/commit/7336f57f745e7399803902efca8fd085ff6ca326

5 years agoImplement IEquatable to Memory and ReadOnlyMemory (dotnet/corefx#36497)
Ganbarukamo41 [Sun, 14 Apr 2019 23:34:34 +0000 (00:34 +0100)]
Implement IEquatable to Memory and ReadOnlyMemory (dotnet/corefx#36497)

* Implement IEquatable to Memory and ReadOnlyMemory

* Add equality tests using IEquatable of ReadOnlyMemory and Memory

* Fix and add tests for Memory and ReadOnlyMemory
* Fixed where IEquatable interface tests were using object.Equals(object) instead of T.Equals(T)
* Added IEquatable interface tests for Memory of different types (char, string)

* Fix IEquatable tests for Memory and ReadOnlyMemory
* Fix tests that were missed in the previous commit (IEquatable tests calling object.Equals(object))
* Should use ReadOnlyMemory in ReadOnlyMemory tests

* Update uapaot baseline for dotnet/corefx#36497

Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)

* Update uapaot baseline for dotnet/corefx#36497

Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)
* Remove baselines added to System.Runtime by mistake
* Add baselines to System.Memory

* Update uapaot baseline for dotnet/corefx#36497
Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)
* Add removed baselines to System.Runtime again

Commit migrated from https://github.com/dotnet/corefx/commit/68920bb0764fb13257f710f44dd08e85e4a35c7c

5 years agoFix build (dotnet/corefx#36862)
Krzysztof Wicher [Sun, 14 Apr 2019 19:31:59 +0000 (12:31 -0700)]
Fix build (dotnet/corefx#36862)

Commit migrated from https://github.com/dotnet/corefx/commit/822da3133d02da072843ffe7715c6af29d0c4192

5 years agoRemove myget feeds (dotnet/corefx#36797)
Santiago Fernandez Madero [Sun, 14 Apr 2019 17:31:01 +0000 (12:31 -0500)]
Remove myget feeds (dotnet/corefx#36797)

* Remove myget feeds

* Bump compression testdata package version

Commit migrated from https://github.com/dotnet/corefx/commit/0aa6ccc261165e9e045a6aab6218f3e71f99e0f4

5 years agoImprove HttpClient POST with REDIRECT tests (dotnet/corefx#36848)
David Shulman [Sun, 14 Apr 2019 03:16:43 +0000 (20:16 -0700)]
Improve HttpClient POST with REDIRECT tests (dotnet/corefx#36848)

This PR is similar to dotnet/corefx#36801 and dotnet/corefx#36828 which improved upload tests stability.

Modify the POST with REDIRECT test to use the VerifyUpload endpoint which avoids
having to echo back the large request body.

Closes dotnet/corefx#36220

Commit migrated from https://github.com/dotnet/corefx/commit/52d4723aaa8e561a6f36589a6d1e112287c0308b

5 years agoAdd Assembly.LoadWithPartialName cases (dotnet/corefx#36803)
Steve MacLean [Sun, 14 Apr 2019 01:57:06 +0000 (21:57 -0400)]
Add Assembly.LoadWithPartialName cases (dotnet/corefx#36803)

* Add Assembly.LoadWithPartialName cases

Cover hole reported in dotnet/coreclrdotnet/corefx#19817

* Verify argument parameter name

* Disable new test on .NetFramework

Commit migrated from https://github.com/dotnet/corefx/commit/5ae3c5655cd84bf3c7f9568477153642fdd7c95e

5 years agoContextual reflection (dotnet/corefx#36845)
Steve MacLean [Sun, 14 Apr 2019 01:56:49 +0000 (21:56 -0400)]
Contextual reflection (dotnet/corefx#36845)

* Add ContextualReflection facade

* Update ApiCompatBaseline.uapaot

Commit migrated from https://github.com/dotnet/corefx/commit/3e2be4796df626d7f4e73c0018992c4f4aa60627

5 years agoFix bad null check in pal_dsa.c
Omair Majid [Mon, 8 Apr 2019 14:40:49 +0000 (10:40 -0400)]
Fix bad null check in pal_dsa.c

The code calls DSA_new() and then, only after assigning the value from
DSA_new to a pointer, tries to check that the pointer was not null.
Assigning to a null pointer leads to undefined behaviour and a compiler
can assume that assignment-to-a-null-pointer wont happen. Subsequently,
the compiler can remove the entire check because the pointer can't be
null.

Fix that by:

1. Moving the check for whether the pointer is null before dereferncing
   the pointer.

2. Checking the return value of DSA_new() spearately after it has been
   called.

Commit migrated from https://github.com/dotnet/corefx/commit/e7fd1669eafafd16de85cd90b558d54abb3a3343

5 years agoJsonSerializerOptions API update and ignore property features (dotnet/corefx#36776)
Steve Harter [Sat, 13 Apr 2019 22:32:49 +0000 (15:32 -0700)]
JsonSerializerOptions API update and ignore property features (dotnet/corefx#36776)

Commit migrated from https://github.com/dotnet/corefx/commit/b06250eb9ef50bca50cf7676e87753dbd8b5470a

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36816)
dotnet-maestro[bot] [Sat, 13 Apr 2019 18:53:57 +0000 (11:53 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36816)

- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27612-73
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27612-73
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27612-73
- Also react to changes in the UTF-8 transcoding logic (dotnet/corefx#36712)

Commit migrated from https://github.com/dotnet/corefx/commit/4c3d4a083488b9f89676926a8b75aa5f7572f67f

5 years agoaddress feedback from 36775 (dotnet/corefx#36839)
Krzysztof Wicher [Sat, 13 Apr 2019 17:46:05 +0000 (10:46 -0700)]
address feedback from 36775 (dotnet/corefx#36839)

Commit migrated from https://github.com/dotnet/corefx/commit/c3981ca2455f8a6593301bac1adb363d02934954

5 years agoFix LsaOpenPolicy interop definition
Hugh Bellamy [Sat, 13 Apr 2019 16:52:14 +0000 (17:52 +0100)]
Fix LsaOpenPolicy interop definition

* Move Lsa handles to Interop code

* Fix implementation of LsaOpenPolicy

* Move LSA_STRING and LSA_UNICODE_STRING to Advapi32

* Consolidate LSA_UNICODE_STRING and UNICODE_STRING

Commit migrated from https://github.com/dotnet/corefx/commit/f5e2679e76c102aea8218ae290ffb7f4d97e9cc2

5 years agoFix encoding of Digest authentication headers (dotnet/corefx#36627)
Filip Navara [Sat, 13 Apr 2019 16:07:10 +0000 (18:07 +0200)]
Fix encoding of Digest authentication headers (dotnet/corefx#36627)

* Fix encoding of Digest authentication headers for servers that don't understand RFC 5987 encoding

* Quote-prefix special characters when encoding Digest headers

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/cce7870129dcca472f4e6108e21e87bc9573b8d2

5 years agoAllow cookies with spaces in the name (dotnet/corefx#36566)
Paito Anderson [Sat, 13 Apr 2019 15:28:21 +0000 (11:28 -0400)]
Allow cookies with spaces in the name (dotnet/corefx#36566)

* Allow cookies with spaces in the name

* Apply suggestions from code review

Co-Authored-By: PaitoAnderson <pj.paito@gmail.com>
* Added supporting HttpClient functional cookie test

* Updated UWP cookie class and added additional tests

* Prevent cookies with spaces at the start or end

* Forgot UWP

* Fix could allocate on trim

Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Better cookie space start/end check

Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Bring checks into line

Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Skip test on .net framework

* Skip additional tests on .net framework

* Fix typo

Commit migrated from https://github.com/dotnet/corefx/commit/8a22438a1af870cdd04eaf798b155b8a1ab04cb4

5 years agoRead system proxy information on macOS (dotnet/corefx#36177)
Filip Navara [Sat, 13 Apr 2019 15:19:53 +0000 (17:19 +0200)]
Read system proxy information on macOS (dotnet/corefx#36177)

* Read system proxy information on macOS

* Replace CFRunLoopRemoveSource with CFRunLoopSourceInvalidate to mimic recommended flow from Chromium / WebKit

Commit migrated from https://github.com/dotnet/corefx/commit/2aa2518a47c541148e2dc3f9d040942e44395acd

5 years agoFix TypeInfoTests.GenericParameterConstraints() test (dotnet/corefx#36832)
Alexander Köplinger [Sat, 13 Apr 2019 04:47:30 +0000 (06:47 +0200)]
Fix TypeInfoTests.GenericParameterConstraints() test (dotnet/corefx#36832)

It was a Theory instead of a Fact and the method parameter wasn't being used.

Commit migrated from https://github.com/dotnet/corefx/commit/1a83ff9b6d6d3406a6ef800dbe2bc7a74e4d5d3c

5 years agooverwrite -> overwriteFiles (dotnet/corefx#36831)
Maira Wenzel [Sat, 13 Apr 2019 04:46:42 +0000 (21:46 -0700)]
overwrite -> overwriteFiles (dotnet/corefx#36831)

Commit migrated from https://github.com/dotnet/corefx/commit/326246059f3e7422e39dd71f2e1541c0288777d0

5 years agoPort ErrObject and CreateProjectError (dotnet/corefx#36808)
Charles Stoner [Sat, 13 Apr 2019 04:45:11 +0000 (21:45 -0700)]
Port ErrObject and CreateProjectError (dotnet/corefx#36808)

* Port ErrObject and CreateProjectError

* PR feedback

* Add FilterDefaultMessage test

Commit migrated from https://github.com/dotnet/corefx/commit/e2ab05d35f00f9cd9a92a94284698cc241f8380d

5 years agoAdd support for generic interface-based collections in JsonSerializer (dotnet/corefx...
Layomi Akinrinade [Sat, 13 Apr 2019 01:44:18 +0000 (21:44 -0400)]
Add support for generic interface-based collections in JsonSerializer (dotnet/corefx#36756)

* Add support for generic interface-based collections in JsonSerializer

Specifically, add enumerable converters for:

* IEnumerable<T>
* ICollection<T>
* IList<T>
* IReadOnlyCollection<T>
* IReadOnlyList<T>

This partially addresses https://github.com/dotnet/corefx/issues/36643

* Address review comments

* Add serialization tests for generic interface collection as members of class objects

Commit migrated from https://github.com/dotnet/corefx/commit/cc01ec9a781c4af5afd495c5b80a1f7d9616bed2

5 years agoCipherSuitePolicy implementation (dotnet/corefx#36775)
Krzysztof Wicher [Sat, 13 Apr 2019 01:23:31 +0000 (18:23 -0700)]
CipherSuitePolicy implementation (dotnet/corefx#36775)

* CipherSuitePolicy implementation (Linux)

* SSL_CIPHER_find

* do not call TLS1.3 APIs on platforms which don't support it

* Non-TLS1.3 specific tests are skipped when not enough cipher suites is enabled

* clean ups

* attempt to fix OSX

* another attempt to fix OSX

* missing define

* address some feedback, try to fix test failures

* portable build fix

* do not call old set ciphers API when only TLS 1.3 is requested

* apply feedback

* add OSX implementation

* fixes to OSX

* explicit convert

* use explicit SSLCipherSuite instead of uint16_t

* random change to trigger CI

* s/unsafe/fixed

* fixes

* random change to trigger CI

* client ordering does not have to win

* tests: AllowedCipherSuites, new CipherSuitesPolicy(null)

* run AllowedCipherSuites tests only when CSP is supported

* add summary on CipherSuitesPolicy

* address feedback

* move OS specific files to CipherSuitesPolicyPal

* FALLBACK->LIGHTUP and remove local_

* do not call 1.1.1 function on non-portable build when lower openssl version is installed

* get rid of warning that arg is unused

* make CipherSuitesPolicyPal public members internal

Commit migrated from https://github.com/dotnet/corefx/commit/07f443b6c9f27dd050ffb5eb3afa126a2b1bdddd

5 years agoAdd JsonElement.Clone to make a long-term persistable copy
Jeremy Barton [Sat, 13 Apr 2019 00:37:52 +0000 (17:37 -0700)]
Add JsonElement.Clone to make a long-term persistable copy

Commit migrated from https://github.com/dotnet/corefx/commit/cd020c11b563b51f439324bcefc559d1408f4e09

5 years agoImprove WebClient upload tests stability (dotnet/corefx#36828)
David Shulman [Sat, 13 Apr 2019 00:27:40 +0000 (17:27 -0700)]
Improve WebClient upload tests stability (dotnet/corefx#36828)

This PR is a follow-up to PR dotnet/corefx#36801 which improved HttpClient tests stability.

Some of the WebClient tests were failing with WebExceptions being caused by the
Azure remote endpoint returning 500 status code. Similar to the fixes done to
the HttpClient tests, this PR updates some of the WebClient upload tests to use
the VerifyUpload endpoint which doesn't have to echo back the request body payload.

Some of the WebClient tests upload more complex multi-part formats and can't be
easily changed to use the VerifyUpload endpoint. But those tests aren't using large
data sets so it should be ok.

Closes dotnet/corefx#36226

Commit migrated from https://github.com/dotnet/corefx/commit/00e9390eb0e9b95a410bd3e91b2c58cf9ec85d95

5 years agoembed generated files into pdbs (dotnet/corefx#36825)
Anirudh Agnihotry [Fri, 12 Apr 2019 19:07:39 +0000 (12:07 -0700)]
embed generated files into pdbs (dotnet/corefx#36825)

Commit migrated from https://github.com/dotnet/corefx/commit/c1730e55ba3e1a4d2ae22d052fe17694d2c69379

5 years agoThis should fix the flaky test (dotnet/corefx#36826)
David Fowler [Fri, 12 Apr 2019 18:55:20 +0000 (11:55 -0700)]
This should fix the flaky test (dotnet/corefx#36826)

- The pool in the test wasn't being used (This was changed in a previous commit)
- Use the DisposeTrackingBufferPool to make sure we allocated the number of segments we expect

Commit migrated from https://github.com/dotnet/corefx/commit/6eeed98a406adf281649e94546975d52c72465e6

5 years agoUpdate zlib-intel to v1.2.11.1_jtkv6.3 (dotnet/corefx#36795)
Eric StJohn [Fri, 12 Apr 2019 13:20:07 +0000 (06:20 -0700)]
Update zlib-intel to v1.2.11.1_jtkv6.3 (dotnet/corefx#36795)

* inflate: handle windowBits == 16

* deflate_medium: add dist -1 to hash even for long matches

This fixes an issue where a repeat sequence longer than 258 would be
encoded using longer distance values after the first match.

* deflate_medium: avoid emitting a suboptimal literal in the restart case

When we load new data into the window, we invalidate the next match, in
case the match would improve. In this case, the hash has already been
updated with this data, so when we look for a new match it will point
it back at itself. As a result, a literal is generated even when a
better match is available.

This avoids that by catching this case and ensuring we're looking at the
past.

Commit migrated from https://github.com/dotnet/corefx/commit/6322a406f88e854c5b827ab838f988f8992048f8

5 years agoremove copy of Interop.GetCurrentThreadId.cs (dotnet/corefx#36807)
Krzysztof Wicher [Fri, 12 Apr 2019 13:19:51 +0000 (06:19 -0700)]
remove copy of Interop.GetCurrentThreadId.cs (dotnet/corefx#36807)

Commit migrated from https://github.com/dotnet/corefx/commit/46f57de34bc4df79e50911dce6ec9abb4f35b553

5 years agoGet more information about a flaky test (dotnet/corefx#36810)
David Fowler [Fri, 12 Apr 2019 11:42:34 +0000 (04:42 -0700)]
Get more information about a flaky test (dotnet/corefx#36810)

Commit migrated from https://github.com/dotnet/corefx/commit/f843b9ca2ecdc1b3f52d6ab9dfb094689281dee3

5 years agoUpdate Version comparison operator tests (dotnet/corefx#36799)
Stephen Toub [Fri, 12 Apr 2019 02:11:51 +0000 (22:11 -0400)]
Update Version comparison operator tests (dotnet/corefx#36799)

* Update Version comparison operator tests

Better validate the operators, and update the tests now that the operators won't throw for null.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/599955ac3c2c6625c7baae46be301767b1f074d2

5 years agoRemove octet string wrapping from EnvelopedCms
Kevin Jones [Fri, 12 Apr 2019 01:20:23 +0000 (21:20 -0400)]
Remove octet string wrapping from EnvelopedCms

Removes the octet string wrapping from EnvelopedCms encrypt if the content type is id-data.

Commit migrated from https://github.com/dotnet/corefx/commit/2cd5d08337a7c5fadf90c7d2a571cc18709601d2

5 years agoImprove HttpClient POST tests stability (dotnet/corefx#36801)
David Shulman [Fri, 12 Apr 2019 00:31:25 +0000 (17:31 -0700)]
Improve HttpClient POST tests stability (dotnet/corefx#36801)

Several of the HttpClient POST scenario tests were failing with HTTP status code 500. This was caused
by the Azure remote endpoint generating OutOfMemoryException at times. The tests are sending
large amounts of request body data to the Echo endpoint. That endpoint will respond back with all
the headers and request body data serialized into a JSON payload. The OOM exceptions were
coming from the Newtonsoft JSON serialization code currently used by the server endpoint.

These tests don't really require that the request body data be sent back. The purpose of the tests is
to verify that the request body payload was correctly sent by the client. We already have an endpoint,
VerifyUpload, that can do that without echo'ing back the large request body data.

This PR modifies the tests to use that endpoint. This should mitigate the OOM exceptions
currently being generated in the server-side code. Additional mitigations/fixes will be done later on the server-side code to improve robustness. But fixing the tests to be more streamlined is goodness and will result in these tests being faster and more stable.

Closes dotnet/corefx#36782

Commit migrated from https://github.com/dotnet/corefx/commit/288ce93787799052705814876d6e5ccb0523797d

5 years agoFixes race in NamespaceCache (dotnet/corefx#36699)
Marco Rossignoli [Thu, 11 Apr 2019 20:53:08 +0000 (22:53 +0200)]
Fixes race in NamespaceCache (dotnet/corefx#36699)

* fix race

* address PR feedback

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/ce62a086814fdfecea1d6ba6657c3fb88763e1d6

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36788)
dotnet-maestro[bot] [Thu, 11 Apr 2019 19:37:46 +0000 (12:37 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36788)

* Update dependencies from https://github.com/dotnet/coreclr build 20190410.72

- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27610-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27610-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27610-72

* Regenerating the System.Runtime.Intrinsics ref assembly to pick up the API changes.

* Update Range.GetOffsetAndLength Contract

* Fix return Tuple fields names

* Fix apicompat failure with Range type

Commit migrated from https://github.com/dotnet/corefx/commit/2cae2dbe1f8b687b15c5e7e3acffb0942524cfe4

5 years agoMerge pull request dotnet/corefx#36735 from Wraith2/sqlfix-envchangepool
Afsaneh Rafighi [Thu, 11 Apr 2019 18:24:31 +0000 (11:24 -0700)]
Merge pull request dotnet/corefx#36735 from Wraith2/sqlfix-envchangepool

SqlClient fix SqlEnvChangePool thread safety bug

Commit migrated from https://github.com/dotnet/corefx/commit/af562e84b8b5a4a335ceb5006886a6c42c1c023e

5 years agoHTTP/2 Request Cancellation (dotnet/corefx#35118)
Max Kerr [Thu, 11 Apr 2019 18:23:45 +0000 (11:23 -0700)]
HTTP/2 Request Cancellation (dotnet/corefx#35118)

HTTP/2 cancellation support, plus improvements to outgoing write buffering.

Commit migrated from https://github.com/dotnet/corefx/commit/d6e36e4ecb0d004de54eb7bdf0ed6cdcb042e3c9

5 years agoRemove NETSTandard Test Suite (dotnet/corefx#36784)
Viktor Hofer [Thu, 11 Apr 2019 17:43:27 +0000 (19:43 +0200)]
Remove NETSTandard Test Suite (dotnet/corefx#36784)

Commit migrated from https://github.com/dotnet/corefx/commit/d26c6cdd6895e8df5ac665ce23f20bbaa42a2a9f

5 years agoSystem.Linq.Expressions: Skip tests if DebuggerTypeProxy attribute isn't available...
Alexander Köplinger [Thu, 11 Apr 2019 17:07:13 +0000 (19:07 +0200)]
System.Linq.Expressions: Skip tests if DebuggerTypeProxy attribute isn't available (dotnet/corefx#36785)

* System.Linq.Expressions: Skip tests if DebuggerTypeProxy attribute isn't available

These tests failed on Xamarin.iOS since the linker strips out most Debugger*
attributes in release builds. We can gracefully handle this case and simply
skip the tests instead.

* Use ConditionalFact/Theory

Commit migrated from https://github.com/dotnet/corefx/commit/7b7345665ec28a85084b3ad2932e03f7641d6151

5 years agoFix -allconfigurations build on linux (dotnet/corefx#36780)
Eric StJohn [Thu, 11 Apr 2019 15:42:19 +0000 (08:42 -0700)]
Fix -allconfigurations build on linux (dotnet/corefx#36780)

* Fix -allconfigurations build on linux

* Fix whitespace

Commit migrated from https://github.com/dotnet/corefx/commit/80672656a723818863ae0021370cc4f9ddfbdc73

5 years agoRevert "Run IBCMerge on Linux build (dotnet/corefx#36763)" (dotnet/corefx#36791)
Michal Strehovský [Thu, 11 Apr 2019 15:42:00 +0000 (17:42 +0200)]
Revert "Run IBCMerge on Linux build (dotnet/corefx#36763)" (dotnet/corefx#36791)

This reverts commit dotnet/corefx@ef2ee1291ea6140cb462ead8b4cc86a762b58f64.

Commit migrated from https://github.com/dotnet/corefx/commit/8e843314e1dbd3b3f26abb1f285349be8920cce4

5 years agoRemove NativeMethods from System.IO.Ports (dotnet/corefx#36740)
Hugh Bellamy [Thu, 11 Apr 2019 12:46:33 +0000 (13:46 +0100)]
Remove NativeMethods from System.IO.Ports (dotnet/corefx#36740)

* Remove NativeMethods from System.IO.Ports

Commit migrated from https://github.com/dotnet/corefx/commit/e4dbfa4cbb0ff67efab2bf4214f34125892df986

5 years agoRun IBCMerge on Linux build (dotnet/corefx#36763)
Michal Strehovský [Thu, 11 Apr 2019 12:08:14 +0000 (14:08 +0200)]
Run IBCMerge on Linux build (dotnet/corefx#36763)

* Restores IBC data for both Linux and Windows on all platforms
* Chooses the right IBC data based on the target OS
* When target OS isn't anything specific (like, e.g. System.Linq and other assemblies that are not OS specific), embeds Windows IBC data

Commit migrated from https://github.com/dotnet/corefx/commit/ef2ee1291ea6140cb462ead8b4cc86a762b58f64

5 years agoSocketAsyncEngine.Unix: use ConcurrentDictionary to get rid of lock for context looku...
Tom Deseyn [Thu, 11 Apr 2019 09:20:43 +0000 (11:20 +0200)]
SocketAsyncEngine.Unix: use ConcurrentDictionary to get rid of lock for context lookup (dotnet/corefx#36358)

Commit migrated from https://github.com/dotnet/corefx/commit/1c881ce4e49d723891d10ffabb171dc07b75972e

5 years agoAdd ref asms and unit tests for string.GetPinnableReference (dotnet/corefx#36777)
Levi Broderick [Thu, 11 Apr 2019 07:01:56 +0000 (00:01 -0700)]
Add ref asms and unit tests for string.GetPinnableReference (dotnet/corefx#36777)

Commit migrated from https://github.com/dotnet/corefx/commit/4672a7b5d28070bd3dc8431887b3474a04249ccf

5 years agoRemoved FEATURE_NOTIFYPROPERTYCHANGED checks (dotnet/corefx#36774)
Alan Parr [Wed, 10 Apr 2019 22:45:45 +0000 (23:45 +0100)]
Removed FEATURE_NOTIFYPROPERTYCHANGED checks (dotnet/corefx#36774)

Commit migrated from https://github.com/dotnet/corefx/commit/1ae46a2b2a7719e0fd8d30b5df14b7e181d1c963

5 years agoAdd Win10 19H1 platform detection (dotnet/corefx#36767)
Levi Broderick [Wed, 10 Apr 2019 19:24:55 +0000 (12:24 -0700)]
Add Win10 19H1 platform detection (dotnet/corefx#36767)

Commit migrated from https://github.com/dotnet/corefx/commit/dc63fa0a60e68174f423fe5316e323c6635c08fe

5 years agoFix outerloop linux build missing container resource (dotnet/corefx#36773)
Santiago Fernandez Madero [Wed, 10 Apr 2019 18:59:29 +0000 (11:59 -0700)]
Fix outerloop linux build missing container resource (dotnet/corefx#36773)

Commit migrated from https://github.com/dotnet/corefx/commit/3773daaaba958e65f87e54fc0ec64c4a02282282

5 years agoAddress PR feedback for nullability docs
Stephen Toub [Wed, 10 Apr 2019 16:51:50 +0000 (12:51 -0400)]
Address PR feedback for nullability docs

Commit migrated from https://github.com/dotnet/corefx/commit/99943e1060fcb45eae398a04076819e2939716dd

5 years agoFix docs on System.Text.Json.JsonElement.GetString
Paul Buonopane [Wed, 10 Apr 2019 14:10:36 +0000 (10:10 -0400)]
Fix docs on System.Text.Json.JsonElement.GetString

Commit migrated from https://github.com/dotnet/corefx/commit/ffd0ae699611a7b172408ebd96b52f6eec0ebe67

5 years agoCondition Utf8String package build on IsPrerelease flag
Levi Broderick [Wed, 10 Apr 2019 03:35:03 +0000 (20:35 -0700)]
Condition Utf8String package build on IsPrerelease flag

Commit migrated from https://github.com/dotnet/corefx/commit/5b6a71f295e5b7dcdff4fae98f1301c6a5772c7d

5 years agoFix official builds failing due to LinuxNoTest matrix being empty (dotnet/corefx...
Santiago Fernandez Madero [Tue, 9 Apr 2019 22:28:07 +0000 (15:28 -0700)]
Fix official builds failing due to LinuxNoTest matrix being empty (dotnet/corefx#36750)

Commit migrated from https://github.com/dotnet/corefx/commit/401436a3c0cfd48250bbf4d299d593397d49f0a8

5 years agoFix build breaks and undo package filtering
Eric St. John [Tue, 9 Apr 2019 19:17:52 +0000 (12:17 -0700)]
Fix build breaks and undo package filtering

Commit migrated from https://github.com/dotnet/corefx/commit/b67328f7ac17bd842a3f1b67bf969e03837f0c77

5 years agoDon't build UTF8String.Experimental in release/3.0
wtgodbe [Tue, 9 Apr 2019 18:35:29 +0000 (11:35 -0700)]
Don't build UTF8String.Experimental in release/3.0

Commit migrated from https://github.com/dotnet/corefx/commit/9fb566123fc1f4d5f662eee44847a2161933de5d

5 years agoRemoved netcoreappaot configuration from corefx (dotnet/corefx#36739)
Anirudh Agnihotry [Tue, 9 Apr 2019 21:07:31 +0000 (14:07 -0700)]
Removed netcoreappaot configuration from corefx (dotnet/corefx#36739)

* netcoreappaot-Windows_NT regex removed

* netcoreappaot-WebAssembly;\n regex removed

* netcoreappaot-Windows_NT-Debug;netcoreappaot-Windows_NT-Release;
regex removed

* netcoreappaot; regex removed

* netcoreappaot-Debug;netcoreappaot-Release; removed

* removing rest of occurences of netcoreappaot

* deleteing the netcoreappaot apicompat files

Commit migrated from https://github.com/dotnet/corefx/commit/e9d1a10ed1d38a8b1ed599b3b5be09b8349f8ea8

5 years agoCopy json dependency to test out dir (dotnet/corefx#36738)
Viktor Hofer [Tue, 9 Apr 2019 20:28:10 +0000 (22:28 +0200)]
Copy json dependency to test out dir (dotnet/corefx#36738)

Commit migrated from https://github.com/dotnet/corefx/commit/5bfb3d6e4e32e1cdb579c96cb1668710697d0383

5 years agoremove pool
Wraith2 [Tue, 9 Apr 2019 20:19:29 +0000 (21:19 +0100)]
remove pool

Commit migrated from https://github.com/dotnet/corefx/commit/538cf16de9aa7155d6b905272648f3d9a3492cb0

5 years agospelling feedback
Wraith2 [Tue, 9 Apr 2019 19:07:08 +0000 (20:07 +0100)]
spelling feedback

Commit migrated from https://github.com/dotnet/corefx/commit/f27d235b0bfc08106258c7e3ffff49d3811d2cae

5 years agoaddress feedback
Wraith2 [Tue, 9 Apr 2019 18:29:45 +0000 (19:29 +0100)]
address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/73885393cea96b536564ea39f09a86d6494d83a0

5 years agochange SqlEnvChangePool to be simpler and safe
Wraith2 [Tue, 9 Apr 2019 16:49:00 +0000 (17:49 +0100)]
change SqlEnvChangePool to be simpler and safe

Commit migrated from https://github.com/dotnet/corefx/commit/b9bd3548b69a14c969ecd3604ac71272ca8c4725

5 years agoFix deserialize cache test (dotnet/corefx#36646)
Steve Harter [Tue, 9 Apr 2019 16:35:31 +0000 (09:35 -0700)]
Fix deserialize cache test (dotnet/corefx#36646)

Commit migrated from https://github.com/dotnet/corefx/commit/e3ec42fb156c0354aa4095b125f3f56c27d0ecf7

5 years agoAdd test for string.Concat(object) that ToString returns null (dotnet/corefx#36436)
Santiago Fernandez Madero [Tue, 9 Apr 2019 16:28:47 +0000 (09:28 -0700)]
Add test for string.Concat(object) that ToString returns null (dotnet/corefx#36436)

Commit migrated from https://github.com/dotnet/corefx/commit/f9c971097b9bea6206cc328188ee1fc3bc984fd1

5 years agoAdd more ArrayConverter tests and cleanup code (dotnet/corefx#36654)
Hugh Bellamy [Tue, 9 Apr 2019 15:51:19 +0000 (16:51 +0100)]
Add more ArrayConverter tests and cleanup code (dotnet/corefx#36654)

* Add more ArrayConverter tests and cleanup code

* Disable netfx test

Commit migrated from https://github.com/dotnet/corefx/commit/3f7071d66f563cc2f0d49d4c9be7dd538c0e24ae

5 years agoAdd more misc type converters tests (dotnet/corefx#36655)
Hugh Bellamy [Tue, 9 Apr 2019 15:47:39 +0000 (16:47 +0100)]
Add more misc type converters tests (dotnet/corefx#36655)

*  Add more misc type converters tests

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/e65153e07ff478d1e71ed54e6a8b8c6547bb884e

5 years agoAdd initial nullability annotations guidance (dotnet/corefx#36711)
Stephen Toub [Tue, 9 Apr 2019 14:58:04 +0000 (10:58 -0400)]
Add initial nullability annotations guidance (dotnet/corefx#36711)

* Add initial nullability annotations guidance

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/663af00ced6ba81a3a7715e6347270306c1bad52

5 years agoChange charsets to explicitly unicode in System.Drawing.Common (dotnet/corefx#36718)
Jeremy Koritzinsky [Tue, 9 Apr 2019 01:44:23 +0000 (18:44 -0700)]
Change charsets to explicitly unicode in System.Drawing.Common (dotnet/corefx#36718)

* Change charsets to explicitly unicode.

* Remove ActiveIssue.

Commit migrated from https://github.com/dotnet/corefx/commit/02d4a83f640a802ae34588579ba25e8d77ead8ac

5 years agoUpdating all types in System.Numerics.Vectors, minus Vector<T>, to use the readonly...
Tanner Gooding [Tue, 9 Apr 2019 00:18:02 +0000 (17:18 -0700)]
Updating all types in System.Numerics.Vectors, minus Vector<T>, to use the readonly members feature. (dotnet/corefx#36702)

Commit migrated from https://github.com/dotnet/corefx/commit/5023c2420a4145bcb560c4b8c57f4bb60cd6973f

5 years agoUpdate coding-style.md (dotnet/corefx#36695)
Milosz Kukla [Mon, 8 Apr 2019 23:54:36 +0000 (01:54 +0200)]
Update coding-style.md (dotnet/corefx#36695)

* Update coding-style.md

Removed info about corefx.vssettings since it was removed at https://github.com/dotnet/corefx/pull/35683

* Update coding-style.md

Commit migrated from https://github.com/dotnet/corefx/commit/7b320a0ad1ea83670f561a6ef9231916465bb4b4

5 years agoChanges required to use newGenfacadeModel (dotnet/corefx#36126)
Anirudh Agnihotry [Mon, 8 Apr 2019 23:01:30 +0000 (16:01 -0700)]
Changes required to use newGenfacadeModel (dotnet/corefx#36126)

* making corefx compatible with newGenfacadesTask

correcting the new runtime variable

updating genfacades version to latest

fixes uap build and removes extra seed ype preferences for uapaot

* adding build configuration, comments and updating genfacadwa version

* fixing build  for netcoreapaot

* removing netcoreappaot build from all configurations build

Commit migrated from https://github.com/dotnet/corefx/commit/52206f12e2a34b708f33304d9b076b4958fbaa5e

5 years agoUpdate APICompat Baselines (dotnet/corefx#36578)
William Godbe [Mon, 8 Apr 2019 22:40:41 +0000 (15:40 -0700)]
Update APICompat Baselines (dotnet/corefx#36578)

* Update APICompat Baselines

* Fix baslines for UAP/UAPAOT

* Fix baseline for UAPAOT

Commit migrated from https://github.com/dotnet/corefx/commit/9924aa7f049da3a902be5b70c9935dcc9fad0952

5 years agoAdd more Decimal constructor tests (dotnet/corefx#36668)
Hugh Bellamy [Mon, 8 Apr 2019 21:43:16 +0000 (22:43 +0100)]
Add more Decimal constructor tests (dotnet/corefx#36668)

Commit migrated from https://github.com/dotnet/corefx/commit/47d17e30dcbcdec64ec3b00a23145e20afbb048e