Kassem Sandarusi [Sun, 4 Feb 2018 21:26:16 +0000 (15:26 -0600)]
TypeDefinition.IsNested Property (dotnet/corefx#25963)
* Adding API TypeDefinition.IsNested. Closes dotnet/corefx#5377
* Adding related tests.
* fixing backward asserts.
* Switching to expression-bodied syntax.
* Adding doc comment. Switching to an assembly that actually has nested types.
* Fixing xml doc comment to align with msdn comment style.
* Update TypeDefinition.cs
Fixing bad grammar in comments.
Commit migrated from https://github.com/dotnet/corefx/commit/
af18a5fe0d4aab25d8fcb6900fcffa8c99befb60
Marco Rossignoli [Sun, 4 Feb 2018 18:20:57 +0000 (19:20 +0100)]
remove special-cases TKey string (dotnet/corefx#26816)
Commit migrated from https://github.com/dotnet/corefx/commit/
5d71d9ea70418c26874949b36e6434c4849fde52
Dan Moseley [Sun, 4 Feb 2018 18:15:06 +0000 (10:15 -0800)]
Fix IndexOutOfRange for invalid grouping construct (dotnet/corefx#26829)
* Fix method name
* Fix IndexOutOfRange for invalid grouping construct
* Skip test on NETFX
Commit migrated from https://github.com/dotnet/corefx/commit/
3cd61ad064e7d14e8c3452ef2dba288cac5ab0e0
dotnet-maestro-bot [Sun, 4 Feb 2018 17:03:18 +0000 (11:03 -0600)]
Update CoreClr to preview2-26204-05 (dotnet/corefx#26832)
Commit migrated from https://github.com/dotnet/corefx/commit/
012791a249b131642eb08d2f158bbc097137c3de
Stephen Toub [Sun, 4 Feb 2018 11:19:22 +0000 (06:19 -0500)]
Merge pull request dotnet/corefx#26825 from jkotas/master-UpdateDependencies
Update CoreClr to preview2-26204-01 (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
8dbeee99ce48a46c3cee9d1b765c3b31af94e172
Jan Kotas [Sat, 3 Feb 2018 08:07:10 +0000 (00:07 -0800)]
Disable UAP configurations in all configurations build
Commit migrated from https://github.com/dotnet/corefx/commit/
2202b4fd49ace58876763903f43cf27b2275c10a
Jan Kotas [Sun, 4 Feb 2018 05:46:11 +0000 (21:46 -0800)]
Disable or fix failing tests
Commit migrated from https://github.com/dotnet/corefx/commit/
87fd2766fdb3920b307b873c1cff824bebd17f3b
ahsonkhan [Sat, 3 Feb 2018 01:10:37 +0000 (17:10 -0800)]
Changing Span to return default on null instead of throwing.
Commit migrated from https://github.com/dotnet/corefx/commit/
cd48d8680762ab47e39236227c346efa042d789c
Jan Kotas [Sun, 4 Feb 2018 04:30:15 +0000 (20:30 -0800)]
Update System.Diagnostic.Debug whitebox test to match CoreCLR changes
Commit migrated from https://github.com/dotnet/corefx/commit/
c98a1539d423bb579af01610bec73b79559156bb
Eric Erhardt [Wed, 31 Jan 2018 20:36:12 +0000 (14:36 -0600)]
Use Vector<T> from System.Private.CoreLib.
Add TypeForwards for Vector<T> in System.Numerics.Vectors to CoreLib when building for netcoreapp.
Commit migrated from https://github.com/dotnet/corefx/commit/
3ad966ff5250f96026522884ffb678160d501c17
dotnet-maestro-bot [Sun, 4 Feb 2018 01:30:10 +0000 (17:30 -0800)]
Update CoreClr to preview2-26204-01
Commit migrated from https://github.com/dotnet/corefx/commit/
40ef474fb5ef4e8d7ccdcc34c936dfe4e81c120c
dajeffri [Sun, 4 Feb 2018 04:01:46 +0000 (23:01 -0500)]
Codecoverage corefx\src\System.Reflection.Metadata\src\System\Reflection\Metadata\MetadataReader.cs (dotnet/corefx#26321)
* Code Coverage
Complete for ReadMetadataHeader, GetMetadataKind, and ReadStreamHeaders.
* Cleaned up Code
* Code coverage for InitializeStreamReaders
Completes missing code coverage for InitializeStreamReaders
* ReadStandalonePortablePdbStream code coverage
Code coverage for System.Reflection.Metadata.MetadataReader.ReadStandalonePortablePdbStream
* Codecoverage for MetaDataTableHeaders
* Code coverage for ReadMetadataTableRowCounts
Completes code coverage for ReadMetadataTableRowCounts
* completes constructor coverage
Completes constructor coverage for System.Reflection.Metadata.MetadataReader except lines 776-778. These appear unreachable.
* use Array.Copy instead of InsertBytes, change FindIndex to IndexOf, and remove Array.Copy from IndexOf
Changes from feedback. Use Array.Copy instead of InsertBytes, remove InsertBytes, change FindIndex to IndexOf, and remove Array.Copy from IndexOf. I can't find a SequenceEqual that takes a start index and length. I used slice inside of SequenceEqual and it performs better.
* Found one missing test and one duplicate
Commit migrated from https://github.com/dotnet/corefx/commit/
d4d1f4a6ecf2dc8058d5e1278f1cdcb9d4796ac1
Dan Moseley [Sun, 4 Feb 2018 04:01:06 +0000 (20:01 -0800)]
Update performance-tests.md
Commit migrated from https://github.com/dotnet/corefx/commit/
1678ac268e2517ccdbda9156d15a6d7bad5e825a
Jan Kotas [Sun, 4 Feb 2018 03:22:16 +0000 (19:22 -0800)]
Disable UAP legs per dotnet/corefx#26802 (dotnet/corefx#26822)
Commit migrated from https://github.com/dotnet/corefx/commit/
120dce456a90df9982797d6c94eaaababd3e00d1
Stephen Toub [Sat, 3 Feb 2018 11:07:36 +0000 (06:07 -0500)]
Disable ExpectContinue in ManagedHandler when using version 1.0 (dotnet/corefx#26774)
Don't fail, but disable sending the header and respecting the setting if the version is 1.0.
Commit migrated from https://github.com/dotnet/corefx/commit/
8ec2cf215893c1f86c25bc079ff67e67678e0a04
Tarek Mahmoud Sayed [Sat, 3 Feb 2018 11:05:59 +0000 (03:05 -0800)]
Enable Stress mode environment variable (dotnet/corefx#26808)
* Enable Stress mode environment variable
To write any stress test, you may mark the stress test case with one of the attributes:
[ConditionalFact(typeof(TestEnvironment), nameof(TestEnvironment.IsStressModeEnabled))]
[ConditionalTheory(typeof(TestEnvironment), nameof(TestEnvironment.IsStressModeEnabled))]
and set the value of the environment variable COREFX_STRESS to 1 or true
* apply the stress mode detection on System.Net.Http
* remove un-needed comments
Commit migrated from https://github.com/dotnet/corefx/commit/
3d38415b8df3a707834e05830a9f78185ebd7b18
Saurabh Singh [Sat, 3 Feb 2018 06:36:07 +0000 (22:36 -0800)]
Use Temp tables in tests (dotnet/corefx#26805)
* Move tests to use Temp tables to avoid problems with NetFx Tests
* Fix indentation
Commit migrated from https://github.com/dotnet/corefx/commit/
a4e3009f56530e49796db10fe0e460f8eaf44ba8
Cory Rivera [Sat, 3 Feb 2018 05:31:21 +0000 (21:31 -0800)]
Fix issues with test tables in SqlClient tests (dotnet/corefx#26809)
* Check if full-text index exists before running WarningsBeforeRowsTest.
* Remove identity columns from the temp tables created in AdapterTest.
Commit migrated from https://github.com/dotnet/corefx/commit/
3952fdd5072ea38705df9e86cdc5dc4a4c47cc41
Paulo Janotti [Sat, 3 Feb 2018 03:07:29 +0000 (19:07 -0800)]
Fix test PostAsync_ThrowFromContentCopy_RequestFails (dotnet/corefx#26794)
* Fix test to catch proper exception according to handler
* Removing test trait added for my local tests
* Uap handler behaves like the managed one
* Switch if branching for simpler condition
Commit migrated from https://github.com/dotnet/corefx/commit/
f38afda24305979be4613d08df8ea154a6a2d16d
dotnet-maestro-bot [Sat, 3 Feb 2018 02:41:38 +0000 (20:41 -0600)]
Update BuildTools, CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview2-02502-01, preview2-26202-06, preview2-26202-05, beta-26202-01, beta-26202-01, respectively (master) (dotnet/corefx#26776)
* Update BuildTools, CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview2-02502-01, preview2-26202-06, preview2-26202-05, beta-26202-01, beta-26202-01, respectively
* Fix name of ConvertScalarToVector128UInt32 to match coreclr.
Commit migrated from https://github.com/dotnet/corefx/commit/
08ba5c32326ba5dae10d5ba92fcf6b22a754189a
Tarek Mahmoud Sayed [Sat, 3 Feb 2018 02:33:59 +0000 (18:33 -0800)]
Add Debug Views to the Channel (dotnet/corefx#26795)
* Add Debug Views to the Channel
* Add Debug Attributes test
Commit migrated from https://github.com/dotnet/corefx/commit/
ea356c0b48869cc8dd374cd657c5835b3625f869
Ahson Khan [Sat, 3 Feb 2018 02:20:16 +0000 (18:20 -0800)]
System.Memory source cleanup and fix byteOffset check in tests (dotnet/corefx#26598)
* String-like Span extension methods - Remove / PadLeft and Right
* Get rid off Remove, update PadLeft/Right and address feedback.
* Update PadLeft and PadRight tests since we removed totalWidth
* Getting rid of PadLeft and PadRight APIs. Add later if needed.
Commit migrated from https://github.com/dotnet/corefx/commit/
1d19c3a3448cdc67322f3331297f22665621c90c
Cory Rivera [Sat, 3 Feb 2018 01:02:26 +0000 (17:02 -0800)]
Update TVPTest error comparisons to use error codes instead of full exception messages. Exception messages can be slightly different between different versions of SQL Server. (dotnet/corefx#26800)
Commit migrated from https://github.com/dotnet/corefx/commit/
0e67638b1505c7ee19c36ac8df7c988eef8af02b
Keerat Singh [Fri, 2 Feb 2018 22:14:43 +0000 (14:14 -0800)]
Updated contract and exposed GetSchema and GetSchemaTable methods (dotnet/corefx#26762)
* Updated contract and exposed GetSchema and GetSchemaTable methods via concrete classes SqlConnection and SqlDataReader respectively
* Updated DataTable to fully qualified name
Commit migrated from https://github.com/dotnet/corefx/commit/
3d395687a9745c0df49f453335dd802367e4a8c2
Maryam Ariyan [Fri, 2 Feb 2018 22:04:10 +0000 (17:04 -0500)]
Adding EnsureCapacity API to HashSet (dotnet/corefx#26777)
* Adding EnsureCapacity API to hash set
* Making EnsureCapacity tests generic when possible
Issue is: dotnet/corefx#24445
Commit migrated from https://github.com/dotnet/corefx/commit/
e7de7f7c8add536edd5c4120ab63e7d44fae894b
Tarek Mahmoud Sayed [Fri, 2 Feb 2018 19:40:39 +0000 (11:40 -0800)]
Span factoring (dotnet/corefx#26667)
Commit migrated from https://github.com/dotnet/corefx/commit/
a68803c848df70ae900f53e602424ba71a4760b1
Tomas Weinfurt [Fri, 2 Feb 2018 18:15:47 +0000 (10:15 -0800)]
get connection from pool to send digest auth response (dotnet/corefx#26733)
* get connection from pool to send digest auth response
* fix incorrect comment.
* s/TBD/TODO/
Commit migrated from https://github.com/dotnet/corefx/commit/
c727d1226a886a8ac2d2fdef64cc56a8eee7f8f9
Stephen Toub [Fri, 2 Feb 2018 15:47:00 +0000 (10:47 -0500)]
Disable failing DNS tests on macOS (dotnet/corefx#26790)
Commit migrated from https://github.com/dotnet/corefx/commit/
524f01c982407591051b69e6fb13d9ffbc0e36fa
Stephen Toub [Fri, 2 Feb 2018 14:53:22 +0000 (09:53 -0500)]
Update environment variable used for Http.StressEnabled
Commit migrated from https://github.com/dotnet/corefx/commit/
63c75d00971702d0a07edd648db1c7a821c53649
Stephen Toub [Fri, 2 Feb 2018 13:50:35 +0000 (08:50 -0500)]
Clean up ManagedHandler sending of request content (dotnet/corefx#26759)
* Clean up ManagedHandler sending of request content
Centralize the copy into the function that actually sends the content.
* Add HttpClientHandler test for handling request content copy failure
Commit migrated from https://github.com/dotnet/corefx/commit/
6f8a600be95671162bd4de3014adafabe0a0e5ed
Maryam Ariyan [Fri, 2 Feb 2018 07:00:53 +0000 (02:00 -0500)]
Improving EnsureCapacity unit tests (dotnet/corefx#26653)
* Improving Dictionary EnsureCapacity unit tests
* Adding test showing the enumerator does not get invalidated after EnsureCapacity
Commit migrated from https://github.com/dotnet/corefx/commit/
1852360d581843e36675d85efe9af666a7cfa964
Stephen Toub [Fri, 2 Feb 2018 03:04:16 +0000 (22:04 -0500)]
Fix ManagedHandler env var / AppContext handling (dotnet/corefx#26763)
* Fix ManagedHandler env var / AppContext handling
* Update two names
* Update README.md
Commit migrated from https://github.com/dotnet/corefx/commit/
473a4cf05c28f95d8a93b826647f755dbdec8728
Maryam Ariyan [Fri, 2 Feb 2018 02:25:21 +0000 (21:25 -0500)]
bugfix and adding test for GetFolderPath when special folder doesnt exist (dotnet/corefx#26731)
Fixing exception on GetFolderPath in Unix when special folder doesnt exist
Fixes dotnet/corefx#26677
Commit migrated from https://github.com/dotnet/corefx/commit/
6f5ce856e9f40a7d247c241a6bb916fc546045ff
Stephen Toub [Fri, 2 Feb 2018 01:58:20 +0000 (20:58 -0500)]
Disable SetDelegate_ConnectionSucceeds on Linux (dotnet/corefx#26773)
Commit migrated from https://github.com/dotnet/corefx/commit/
166f2bacd530d658fa889731e5989b89f2aedee4
Stephen Toub [Fri, 2 Feb 2018 01:15:16 +0000 (20:15 -0500)]
Move ManagedHandler version/chunking validation earlier (dotnet/corefx#26766)
Move it to ManagedHandler.SendAsync rather than HttpConnection.SendAsync so that it happens before we even try to get a connection. A minor benefit of the change as well is that isHttp10 is no longer lifted to the state machine.
Commit migrated from https://github.com/dotnet/corefx/commit/
bb738a07720a8c0888a088f2adb737d2cbe09ca2
Stephen Toub [Fri, 2 Feb 2018 01:07:57 +0000 (20:07 -0500)]
Use TryFormat with spans in a few more places in ManagedHandler (dotnet/corefx#26755)
Commit migrated from https://github.com/dotnet/corefx/commit/
2b4664a53d8a5729343f056ffa82ff5cb4d32d40
Stephen Toub [Fri, 2 Feb 2018 01:07:44 +0000 (20:07 -0500)]
Remove Supports* properties from ManagedHandler (dotnet/corefx#26764)
Commit migrated from https://github.com/dotnet/corefx/commit/
c18664d0d55dad41d00193ac182e292c0c6cd458
Matt Galbraith [Fri, 2 Feb 2018 01:01:24 +0000 (17:01 -0800)]
Merge pull request dotnet/corefx#26723 from MattGal/Update-From-EOL-Linux
Update Linux Versions for test execution
Commit migrated from https://github.com/dotnet/corefx/commit/
cfca3aac61689191888a6d074caca6dad3a95d6c
Pent Ploompuu [Thu, 1 Feb 2018 22:57:03 +0000 (00:57 +0200)]
BigInteger based random testing of Decimal (part 2) (dotnet/corefx#26338)
Commit migrated from https://github.com/dotnet/corefx/commit/
64634c7c7f260a1025d61c7b0523fc522523932c
Matt Galbraith [Wed, 31 Jan 2018 23:26:41 +0000 (15:26 -0800)]
Some cleanups for test execution, in preparation of removing support for running on EOL Linux OSes.
Removals:
Fedora 25 - EOL 12/20/17
OpenSUSE 42.2 - EOL 01/26/18
RedHat 7.2 - EOL 11/30/17
Additions:
OpenSUSE 42.3
Fedora 27
Commit migrated from https://github.com/dotnet/corefx/commit/
3de89a70a1ac81d420543604cf1956818abbe7e8
Stephen Toub [Thu, 1 Feb 2018 22:22:53 +0000 (17:22 -0500)]
Disable Test_Write_Metric_EventListener test (dotnet/corefx#26761)
Commit migrated from https://github.com/dotnet/corefx/commit/
b60c5db080b2fe4c1457cce3acd2647f8ebc4e99
Stephen Toub [Thu, 1 Feb 2018 22:22:00 +0000 (17:22 -0500)]
Use ValueTask shared from corelib (dotnet/corefx#26636)
Commit migrated from https://github.com/dotnet/corefx/commit/
7b6abc253912de3caeddfcb06aa3f619255351f7
Jon Hanna [Thu, 1 Feb 2018 20:23:58 +0000 (20:23 +0000)]
Only search for member types in Microsoft.CSharp member lookup. (dotnet/corefx#26633)
As opposed to nested classes, or type parameters.
Fixes dotnet/corefx#26632
Commit migrated from https://github.com/dotnet/corefx/commit/
9bf574ec5edeb682f46e9635447fe3dc84fc4efa
Stephen Toub [Thu, 1 Feb 2018 18:52:25 +0000 (13:52 -0500)]
Disable Brotli perf tests (dotnet/corefx#26746)
Commit migrated from https://github.com/dotnet/corefx/commit/
033851fe7d545d6e48fe492fe110e5b72c8d2668
Stephen Toub [Thu, 1 Feb 2018 18:52:11 +0000 (13:52 -0500)]
Disable failing NameResolutionPalTests (dotnet/corefx#26747)
Commit migrated from https://github.com/dotnet/corefx/commit/
0bc7246a14c0dea01926ba371009a3a14c557c0b
Lakshmi Priya Sekar [Thu, 1 Feb 2018 18:43:27 +0000 (10:43 -0800)]
Make SslStreamInternal to free resources with SslStream dispose. (dotnet/corefx#26666)
* Make SslStreamInternal to free resources with SslStream dispose.
* Fix framework test.
* Respond to PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
04f0b1eeb4c634b1f41f396244892571e94b5b16
John Doe [Thu, 1 Feb 2018 17:46:48 +0000 (09:46 -0800)]
intecept -> intercept (dotnet/corefx#26742)
* typo
* typo
* Typo
* Typo
* Fix a typo
Commit migrated from https://github.com/dotnet/corefx/commit/
7c4d35b12e16beaf8a10c9d9b304c6b92defcb61
Ben Adams [Thu, 1 Feb 2018 17:40:08 +0000 (17:40 +0000)]
NetworkChange should capture AsyncLocals (but not to Timer) (dotnet/corefx#26073)
* NetworkChange shouldn't capture AsyncLocals into its Timer
* Capture EC on Linux
* Capture EC on OSX
* Feedback/dedupe platforms
* Better null checking
Commit migrated from https://github.com/dotnet/corefx/commit/
60003797de586098f83eea0719d31787b9c2e141
Caesar Chen [Thu, 1 Feb 2018 17:13:32 +0000 (09:13 -0800)]
Update HttpStatusCode enum (dotnet/corefx#26727)
* Update HttpStatusCode enum
* address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
504781cbfb166c71204b9077c0528623c85cf68c
Tanner Gooding [Tue, 30 Jan 2018 02:24:00 +0000 (18:24 -0800)]
Updating the x86 HWIntrinsic ref assembly
Commit migrated from https://github.com/dotnet/corefx/commit/
90027686dc6ee078ae190bfa471962efeab7a123
dotnet-maestro-bot [Thu, 1 Feb 2018 04:16:04 +0000 (20:16 -0800)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-02431-05, preview2-26201-01, preview2-26201-01, preview2-26131-06, beta-26201-00, beta-26201-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
c2c94e2c89c04392fba55e76f97311c3d1a8bf15
Stephen Toub [Thu, 1 Feb 2018 15:42:50 +0000 (10:42 -0500)]
Fix spacing in WebClient tests .csproj
Commit migrated from https://github.com/dotnet/corefx/commit/
c1f7bb9cb3f5490e1477bc13078f074da78c7959
Douglas-Cleghorn [Thu, 1 Feb 2018 15:41:48 +0000 (08:41 -0700)]
WebClient progress monitoring uses ContentLength header (dotnet/corefx#26462)
* WebClient progress monitoring uses ContentLength header
* Added test for download progress
* Fixed build issue
* Set contentLength to zero if the header is zero
* Fixing WebClient async tests
Commit migrated from https://github.com/dotnet/corefx/commit/
3c4115d601335a61d9d170a71bdfb71eb2177beb
Geoff Kizer [Thu, 1 Feb 2018 14:21:36 +0000 (06:21 -0800)]
fix dribble tests when client disconnects on bad request (dotnet/corefx#26730)
Fixes dotnet/corefx#26729
Commit migrated from https://github.com/dotnet/corefx/commit/
6f5d255a76a192906f692fd3d2b9104ab6aeb2f2
Geoff Kizer [Thu, 1 Feb 2018 04:24:58 +0000 (20:24 -0800)]
Merge pull request dotnet/corefx#26708 from geoffkizer/httpretry
ManagedHandler: implement connection retry logic
Commit migrated from https://github.com/dotnet/corefx/commit/
95bfb895707d5756d4b9693286672780f0a6ba02
dotnet-maestro-bot [Thu, 1 Feb 2018 03:03:40 +0000 (21:03 -0600)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02430-04, preview2-26130-05, preview2-26130-01, preview2-26129-06, beta-26130-01, beta-26130-01, respectively (master) (dotnet/corefx#26631)
* Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to prerelease-02430-04, preview2-26130-05, preview2-26130-01, preview2-26129-06, beta-26130-01, beta-26130-01, respectively
* Undoing BuildTools update
* Skipping test causing UAP test run to crash for Process
Commit migrated from https://github.com/dotnet/corefx/commit/
39742d3f1eac73898ad1b153141419e1f6e866d0
Tomas Weinfurt [Wed, 31 Jan 2018 23:46:27 +0000 (15:46 -0800)]
add proxy configuration based on environment variables on Unix (dotnet/corefx#26341)
* initial attempt
* remove extra debug message and cleanup.
* take feedabck from reviews
* adress comments from review and add unit tests
* add missing variables to cleanup function
* fix more style and review comments
* updates suggested by geoff
* few more places s/Credientials/Credentials/
* refactor credentials handling
* more fixes to address review feedback
* include HttpProxyConnectionHandler.*.cs only for netcoreapp
Commit migrated from https://github.com/dotnet/corefx/commit/
454220d87dc118a6cb039ef5bd68707de20b79a5
Paulo Janotti [Wed, 31 Jan 2018 23:37:08 +0000 (15:37 -0800)]
Separate basic auth test cases for HttpClientHandler (dotnet/corefx#26713)
Separating the test cases between compliant and non-compliant names. Related to dotnet/corefx#23135
Commit migrated from https://github.com/dotnet/corefx/commit/
62a3d898ceb94227b2b03462b5b09f0a7cd4e3a8
Geoff Kizer [Wed, 31 Jan 2018 23:04:18 +0000 (15:04 -0800)]
address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
87ff7479b35c3df7b1a5381447d89c42e2463bc7
Atsushi Kanamori [Wed, 31 Jan 2018 21:49:03 +0000 (13:49 -0800)]
Utf8Parsing - the remaining 'N' format overloads (dotnet/corefx#26683)
* Utf8Parsing - the remaining 'N' format overloads
Fixes https://github.com/dotnet/corefx/issues/24986
This is a piece of the Utf8Parser that was punted for time
last year.
There are 8 overloads for each of the 8 integer types.
Int32 was done in a previous PR - this completes the set.
The "N" format prints out integers like this:
`"N2" => 12,345.00`
This parser mimics the behavior of
`int.TryParse(v, NumberStyles.Integer | AllowThousands | AllowDecimalPoint)`
The thing that may look strange is that the parser
allows commas anywhere, not just on the 10^3 digits.
This mimics the desktop api behavior. Comma placement is
culture-dependent and this is an api that is culture-agnostic.
The test data was confirmed on a control implementation
that calls the classic int.TryParse().
* Added comment
* Fix comment typo
Commit migrated from https://github.com/dotnet/corefx/commit/
efdbbe6ba587a9efb1389f6d090b564f441c7b86
Stephen Toub [Wed, 31 Jan 2018 19:34:24 +0000 (14:34 -0500)]
Fix BoundedChannel.DequeueItemAndPostProcess to respect _doneWriting (dotnet/corefx#26707)
It shouldn't attempt to interact with _blockedWriters/_waitingWriters if _doneWriting has been set.
Commit migrated from https://github.com/dotnet/corefx/commit/
8ae3df0dddc4608b7c03cfcae26a42d4f3deebc8
Stephen Toub [Wed, 31 Jan 2018 19:04:08 +0000 (14:04 -0500)]
Add ValueTask perf tests (dotnet/corefx#26706)
Basic perf tests for ValueTasks.
Commit migrated from https://github.com/dotnet/corefx/commit/
623af48d03bffb857616be5cc9c46a0f19c18cc6
Geoff Kizer [Wed, 31 Jan 2018 18:19:41 +0000 (10:19 -0800)]
Merge pull request dotnet/corefx#26585 from geoffkizer/httpversionhandling
clean up request and response version handling in managed handler
Commit migrated from https://github.com/dotnet/corefx/commit/
2e10ed5418bac7b6b47a407b7efb28ccfcbc9f21
Geoff Kizer [Tue, 30 Jan 2018 06:28:33 +0000 (22:28 -0800)]
implement connection retry logic and related changes
Commit migrated from https://github.com/dotnet/corefx/commit/
64976bf062b6cbc55a3e708dbf7116188d075ff1
Jose Perez Rodriguez [Wed, 31 Jan 2018 17:09:37 +0000 (09:09 -0800)]
Building non-Windows builds using the CLI's MSBuild (dotnet/corefx#26686)
Commit migrated from https://github.com/dotnet/corefx/commit/
363599c0e29a5843031f5360d1b114a5ac088805
Jan Kotas [Wed, 31 Jan 2018 16:57:17 +0000 (08:57 -0800)]
Replace JitIntrinsicAttribute with IntrinsicAttribute (dotnet/corefx#26700)
* Replace JitIntrinsicAttribute with IntrinsicAttribute
* Use s_ prefix for statics
Commit migrated from https://github.com/dotnet/corefx/commit/
9885497081a1bc58d2645d99aa4ed8b3bd303ee7
Ben Adams [Wed, 31 Jan 2018 16:04:48 +0000 (16:04 +0000)]
Activity shouldn't capture AsyncLocals into its Timer (dotnet/corefx#26071)
* Activity shouldn't capture AsyncLocals into its Timer
* SecuritySafeCritical
* feddback
Commit migrated from https://github.com/dotnet/corefx/commit/
54d3e65708a9c20d11c6d6164f63a249ebca5aa5
Stephen Toub [Wed, 31 Jan 2018 14:04:36 +0000 (09:04 -0500)]
Remove ValueTask<T>.CreateAsyncMethodBuilder from ref (dotnet/corefx#26703)
Commit migrated from https://github.com/dotnet/corefx/commit/
9ba6220b3d8846d7c5bb1a28b9c3fb10270a98a3
Marco Rossignoli [Wed, 31 Jan 2018 13:51:42 +0000 (14:51 +0100)]
Add new MediaTypeNames (dotnet/corefx#26701)
* add new types
* fix MembersMustExist
Commit migrated from https://github.com/dotnet/corefx/commit/
9e1b3345b8414ab17366bdf2d48369d796daf394
Anirudh Agnihotry [Wed, 31 Jan 2018 06:54:03 +0000 (22:54 -0800)]
Follow up changes For serviceBase (dotnet/corefx#26695)
Commit migrated from https://github.com/dotnet/corefx/commit/
530fb9e84dd9e24b085dc63ceb0810cf719e6c8f
Michal Strehovský [Wed, 31 Jan 2018 06:50:22 +0000 (07:50 +0100)]
Add test coverage for Type.GetInterfaceMap (dotnet/corefx#26679)
Commit migrated from https://github.com/dotnet/corefx/commit/
6cd7e55e1a3fc7b2890023483e319f39bfb34c35
Jeremy Barton [Wed, 31 Jan 2018 06:30:13 +0000 (22:30 -0800)]
Make AsnSerializer resiliant to ILC reflection rules
AsnSerializer had two different paths which checked for ordered fields, one
which used the MetadataToken and one which didn't. The MetadataToken
method is more reliable, but is not available on ILC.
With this change
* MetadataToken is used when available, and we hope for the best otherwise.
* The two paths now use the same resolution, so future algorithms apply evenly
* The results are cached, so we only sort once per type
Commit migrated from https://github.com/dotnet/corefx/commit/
035305b0b4cc598f0acfe435f93d523bddd523c1
Gene Lee [Wed, 31 Jan 2018 04:26:44 +0000 (20:26 -0800)]
Fixed ReadAsync blocking issue (dotnet/corefx#26595)
Commit migrated from https://github.com/dotnet/corefx/commit/
da8a105c39ce4b10406c2da5dfce19269293942b
Ben Adams [Wed, 31 Jan 2018 01:22:22 +0000 (01:22 +0000)]
Don't capture AsyncLocals into ODBC Global Timers (dotnet/corefx#26066)
Commit migrated from https://github.com/dotnet/corefx/commit/
48525389b9e8957b3bb527edd6b7f149c4af6c11
Dan Moseley [Wed, 31 Jan 2018 01:12:29 +0000 (01:12 +0000)]
Missing guid from two interop types (dotnet/corefx#26688)
* Add missing Guids to two interfaces
* Curly
Commit migrated from https://github.com/dotnet/corefx/commit/
ec353e2e18007f36a5a192bf08f97e9826509a8c
Josh Free [Tue, 30 Jan 2018 23:12:53 +0000 (15:12 -0800)]
Add System.IO.Pipelines
Add new section for System.IO.Pipelines
Commit migrated from https://github.com/dotnet/corefx/commit/
21486567a754e580dc1c058b97ac42b875f3d80e
Tarek Mahmoud Sayed [Tue, 30 Jan 2018 23:09:58 +0000 (15:09 -0800)]
Remove Unbuffer Channel (dotnet/corefx#26689)
Commit migrated from https://github.com/dotnet/corefx/commit/
1f8e408e7f2b0681056d1cac55b3ccc5586e8995
Josh Free [Tue, 30 Jan 2018 22:58:18 +0000 (14:58 -0800)]
Add System.Threading.Channels
Add new section for System.Threading.Channels
Commit migrated from https://github.com/dotnet/corefx/commit/
873d4ee2d5dcb173f5fb592edbc9f1c9a0eebe1a
Santiago Fernandez Madero [Tue, 30 Jan 2018 22:27:57 +0000 (14:27 -0800)]
Update servicemodel dependencies to latest stable version (dotnet/corefx#26281)
Commit migrated from https://github.com/dotnet/corefx/commit/
5494ff2ea60503fe739443c3c8d52df6eebe2bf5
Eric Erhardt [Tue, 30 Jan 2018 21:44:49 +0000 (15:44 -0600)]
Move Vector<T> to the shared CoreLib partition. (dotnet/corefx#26656)
* Move Vector<T> to the shared CoreLib partition.
This is in support of eventually compiling it into System.Private.CoreLib. That way we can use it in other corelib algorithms.
* Update Test project to link to new CoreLib file path
Commit migrated from https://github.com/dotnet/corefx/commit/
6aa7ebdcb444c05449c9e14c66eb38f13826bfc7
Paulo Janotti [Tue, 30 Jan 2018 21:26:09 +0000 (13:26 -0800)]
Make redirect test case really 'redirect' (dotnet/corefx#26674)
The test case was redirecting to the same URL this was bringing instability with the handlers (more with the managed). This change should make the test more reliable, as such moving it to inner loop.
Fixes dotnet/corefx#23769
Since no action is planned for dotnet/corefx#26434 this also closes dotnet/corefx#26434
Commit migrated from https://github.com/dotnet/corefx/commit/
3b69635f25636377841ded02de254eacec6e3728
Paulo Janotti [Tue, 30 Jan 2018 21:06:51 +0000 (13:06 -0800)]
Http protocol dribble tests taking two long (dotnet/corefx#26680)
The time of inner loop is dominated by the http protocol dribble tests.
Returning the Task.Delay to Task.Yield reduces it from ~19 seconds to less than a second on a Windows 10 RS3 box.
Commit migrated from https://github.com/dotnet/corefx/commit/
179cf080901f8f7f4e5499b80ad393b7370eef40
Lakshmi Priya Sekar [Tue, 30 Jan 2018 18:35:11 +0000 (10:35 -0800)]
Merge pull request dotnet/corefx#26625 from wfurt/fix_26599
make opaque parameter optional for digest auth
Commit migrated from https://github.com/dotnet/corefx/commit/
dee052ff7c5b49af357678f40afe97e4f2bd0940
Santiago Fernandez Madero [Tue, 30 Jan 2018 18:10:58 +0000 (10:10 -0800)]
Add netfx placeholder configuration to System.Data.DataSetExtensions (dotnet/corefx#26576)
* Add netfx placeholder configuration to System.Data.DataSetExtensions
* Update System.Data.DataSetExtensions key to match Desktop public key
Commit migrated from https://github.com/dotnet/corefx/commit/
451824f7d2c0679888b2d4acd541795de9f8a7f7
Anirudh Agnihotry [Tue, 30 Jan 2018 17:38:16 +0000 (09:38 -0800)]
ServiceBase And ServiceController Tests using NamedPipes (dotnet/corefx#26524)
ServiceBase And ServiceController tests using NamedPipes
Commit migrated from https://github.com/dotnet/corefx/commit/
c78d3d4f1879e5b0bf3c58edf5baefdc9cdb4e1c
Ben Adams [Tue, 30 Jan 2018 15:15:54 +0000 (15:15 +0000)]
Don't capture AsyncLocals into EventCounter timer (dotnet/corefx#26075)
* Don't capture AsyncLocals into EventCounter timer
* Harden Flow suppression
* Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
bcc2940faeb58cc92a66c61ca404bed54a3a3bb3
Ian Hays [Tue, 30 Jan 2018 13:36:57 +0000 (05:36 -0800)]
Use ToArray based debuggerview for portable span (dotnet/corefx#26661)
* Use ToArray based debuggerview for portable span
* Fix Ordering for System.Memory csproj include
Commit migrated from https://github.com/dotnet/corefx/commit/
4a57e8045ff5f9eff5f7b17778785f7790589bec
Jeremy Barton [Tue, 30 Jan 2018 13:30:28 +0000 (05:30 -0800)]
Make Linux and macOS throw the same exception on unknown hash algorithms (dotnet/corefx#26648)
Currently Linux throws CryptographicException with a default message, and
macOS throws a PNSE with a message.
This normalizes them to throw CryptographicException with a message.
Windows NetFX throws CryptographicException(NTE_BAD_ALGID), and CoreFx
behaves similarly.
Commit migrated from https://github.com/dotnet/corefx/commit/
34709c597cb88ff7ff7f270a7a020d681b2deb61
Ben Adams [Tue, 30 Jan 2018 13:28:12 +0000 (13:28 +0000)]
Don't capture AsyncLocals into SQL global timers (dotnet/corefx#26065)
* Don't capture AsyncLocals into SQL global timers
* Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
093126c7219819f1acd500331a733d1bba4ce17f
Günther Foidl [Tue, 30 Jan 2018 12:44:52 +0000 (13:44 +0100)]
Stack<T> optimization of (Try)Peek, (Try)Pop and Push (dotnet/corefx#26086)
* Stack.Pop RCE
With value types the effect is not so big, because there is still one (manual) check for bounds.
For reference types one bounds-check can be saved, so there is a win.
* Applied same optimizations as for Pop on Peek, TryPeek, TryPop, Push
* Revert change for Push
I can't see a real win, sometimes it's faster and sometimes slower. On Linux the tendency is to be slower.
Therefore the state as is will be remained.
* Stack.Push with hot-/cold-path (PushWithResize)
* Addressed PR feedback
Cf. https://github.com/dotnet/corefx/pull/26086#discussion_r158987900
* Array-copy in Peek is not necessary, JIT can do the same
As of PR-feedback https://github.com/dotnet/corefx/pull/26086#discussion_r159071441
* Reverted b0bfd83
Cf. https://github.com/dotnet/corefx/pull/26086#issuecomment-
357314683
* Addressed PR feedback
Cf. https://github.com/dotnet/corefx/pull/26086#discussion_r164453817
Commit migrated from https://github.com/dotnet/corefx/commit/
36ae61031f94c7d92ce8750c088bfa640b5ccb1e
Günther Foidl [Tue, 30 Jan 2018 09:55:08 +0000 (10:55 +0100)]
Queue<T> optimization of (Try)Dequeue (dotnet/corefx#26087)
* Queue RCE
With value types the effect is not so big, because there is still one (manual) check for bounds.
For reference types one bounds-check can be saved, so there is a win.
In MoveNext the conditional is with if, so the JIT can produce better code.
* MoveNext uses temp-Variable for register access instead of memory access
* Addressed PR feedback
* https://github.com/dotnet/corefx/pull/26087#pullrequestreview-
92229686
* https://github.com/dotnet/corefx/pull/26087#pullrequestreview-
92229910
Commit migrated from https://github.com/dotnet/corefx/commit/
fc7cd1bf8eb8406b84cc995cfe225fa41f46d0ee
Tomas Weinfurt [Tue, 30 Jan 2018 01:14:05 +0000 (17:14 -0800)]
merge positive and negative test to one. add more test cases
Commit migrated from https://github.com/dotnet/corefx/commit/
6457d8102bc6527b8a5277c7cc4838a497cf2e48
Tomas Weinfurt [Tue, 30 Jan 2018 00:26:52 +0000 (16:26 -0800)]
update from reviews. refactor opaque handling, make realm mandatory and add negative test case.
Commit migrated from https://github.com/dotnet/corefx/commit/
dd1d93fc8a25343ab15360e368a0c7d900355c34
Cory Rivera [Mon, 29 Jan 2018 23:18:10 +0000 (15:18 -0800)]
Add try-finally statements around AbortTransaction calls in SqlBulkCopy, so that parser locks always get released. (dotnet/corefx#26649)
Commit migrated from https://github.com/dotnet/corefx/commit/
5b5eacfce3a62712ceb67dfb51128221b0fce137
Ian Hays [Mon, 29 Jan 2018 23:01:25 +0000 (15:01 -0800)]
Consume Span moves (dotnet/corefx#26467)
Consume Span moves
- [Move Span.DangerousCreate to MemoryMarshal.CreateSpan](dotnet/corefx#26139)
- [Move ReadOnlySpan.DangerousCreate to MemoryMarshal.CreateReadOnlySpan](dotnet/corefx#26139)
- [Move Span.NonPortableCast to MemoryMarshal.Cast](dotnet/corefx#26368)
- [Move ReadOnlySpan.NonPortableCast to MemoryMarshal.Cast](dotnet/corefx#26368)
- [Add ToString override to Span and ReadOnlySpan](dotnet/corefx#26295)
- [Add ToEnumerable function to MemoryMarshal that takes a Memory](dotnet/corefx#24854)
Commit migrated from https://github.com/dotnet/corefx/commit/
540a99ce273265ba62a25b48c696d2d506c88ab4
Jeremy Barton [Mon, 29 Jan 2018 19:00:59 +0000 (11:00 -0800)]
Make ProtectedData function on empty input
In .NET Framework the implementation used GCHandle.Alloc, which does not
normalize an empty array to null. In .NET Core the implementation uses fixed,
which does normalize empty to null. Since the Win32 API rejects null inputs,
map empty to some other array for the duration of the call.
Commit migrated from https://github.com/dotnet/corefx/commit/
7590642a7a40594136f0f91555704781c49587da
Jon Hanna [Mon, 29 Jan 2018 21:50:48 +0000 (21:50 +0000)]
Fix regression in Microsoft.CSharp on accessing accessors or operators (dotnet/corefx#26620)
Correct incorrectly inverted if test so accessor methods are allowed
iff they are on parametrised properties.
Fixes dotnet/corefx#26619
Commit migrated from https://github.com/dotnet/corefx/commit/
4f8c637f0f7f0a4b313e2b0bc4101bd30d669704
Geoff Kizer [Mon, 29 Jan 2018 21:31:18 +0000 (13:31 -0800)]
fix CurlHandler test for 2.0 response
Commit migrated from https://github.com/dotnet/corefx/commit/
b91b6c63aa3678ba707a9900b64eea9f8e0a6d00
Stephen Toub [Mon, 29 Jan 2018 20:36:45 +0000 (15:36 -0500)]
Replace TryCopyTo with CopyTo (dotnet/corefx#26641)
While doing various Span-related work involving copying, in a few places I previously used a pattern of calling TryCopyTo and then asserting its result, in places where I knew the destination was long enough. This was because CopyTo was implemented as a wrapper around TryCopyTo and thus involved an extra unnecessary branch. Now that that's no longer the case, I'm simplifying the call sites.
cc: @GrabYourPitchforks
Commit migrated from https://github.com/dotnet/corefx/commit/
b3ad6ab802bc7fd050b2bfb2381ff525ac370594
Saurabh Singh [Mon, 29 Jan 2018 20:33:27 +0000 (12:33 -0800)]
Disable the DiagnosticTest on Framework (dotnet/corefx#26645)
* Disable the DiagnosticTest on Framework because the feature is not available
* Fixing comments
Commit migrated from https://github.com/dotnet/corefx/commit/
dfd9d7649c7c5c79e9af54bb5e854a2b2e60f345