Marc-André Moreau [Thu, 12 Feb 2015 17:03:15 +0000 (12:03 -0500)]
libfreerdp-core: improve TSG virtual connection and channel management
Marc-André Moreau [Thu, 12 Feb 2015 15:15:14 +0000 (10:15 -0500)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Thu, 12 Feb 2015 15:14:23 +0000 (10:14 -0500)]
Merge pull request #2386 from bjcollins/master
Fix remote app in xfreerdp.
Marc-André Moreau [Thu, 12 Feb 2015 15:12:01 +0000 (10:12 -0500)]
Merge pull request #2385 from hardening/nego_fix
Fix server-side protocol negociation
Hardening [Thu, 12 Feb 2015 10:21:09 +0000 (11:21 +0100)]
Merge pull request #2377 from bmiklautz/wtsapi_tests
wtsapi: add TestWtsApiExtra
Bernhard Miklautz [Thu, 12 Feb 2015 09:45:43 +0000 (10:45 +0100)]
Merge pull request #2388 from MartinHaimberger/mh-wtsapi-handler
wtsapi: added handler for LogonUser and LogoffUser
Martin Fleisz [Thu, 12 Feb 2015 09:42:55 +0000 (10:42 +0100)]
Merge pull request #2379 from streetdragon/master
Replaced ternary operator with condition only
Martin Haimberger [Thu, 12 Feb 2015 09:31:00 +0000 (01:31 -0800)]
wtsapi: added handler for LogonUser and LogoffUser
bjcollins [Wed, 11 Feb 2015 23:24:06 +0000 (17:24 -0600)]
Fix remote app in xfreerdp.
Remove use of the visibleOffset, this completely breaks the display of all windows except for the main application window. Instead,
just maintain a local offset correction of the windowOffset.
Apply workaround to determining the workArea for remote app mode.
David FORT [Wed, 11 Feb 2015 20:38:32 +0000 (21:38 +0100)]
Fix server-side protocol negociation
Before this patch, RDP security was (wrongly) the fallback when negociating a
security protocol between the client and the server. For example when a client
was claiming TLS-only when connecting to a FreeRDP based-server with RDP security only,
the result of the negociation was that the server started to do RDP security.
The expected behaviour is to send a nego failure packet with error code
SSL_NOT_ALLOWED_BY_SERVER. This patch fixes this.
We also try to handle all cases of failed negociation and return the corresponding
error code.
Marc-André Moreau [Wed, 11 Feb 2015 20:26:22 +0000 (15:26 -0500)]
libfreerdp-core: refactor tsg virtual connection, in/out channels
Marc-André Moreau [Wed, 11 Feb 2015 19:27:29 +0000 (14:27 -0500)]
libfreerdp-core: gateway connection refactoring
Marc-André Moreau [Wed, 11 Feb 2015 16:57:02 +0000 (11:57 -0500)]
libfreerdp-core: move stuff down from transport to tsg layer
Marc-André Moreau [Wed, 11 Feb 2015 16:04:14 +0000 (11:04 -0500)]
Merge pull request #2384 from awakecoding/master
Fix TS Gateway Disconnection (broken by #2383)
Marc-André Moreau [Wed, 11 Feb 2015 15:57:14 +0000 (10:57 -0500)]
libfreerdp-core: fix tsg crash on disconnect
Marc-André Moreau [Wed, 11 Feb 2015 15:05:33 +0000 (10:05 -0500)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Wed, 11 Feb 2015 15:05:22 +0000 (10:05 -0500)]
Merge pull request #2383 from hardening/transport_cleanup
Cleanups
David FORT [Wed, 11 Feb 2015 14:47:43 +0000 (15:47 +0100)]
Fix socket leak when transport is disconnected
David FORT [Wed, 11 Feb 2015 14:23:14 +0000 (15:23 +0100)]
Fix compilation with valgrind helpers
Kurt McAlpine [Tue, 10 Feb 2015 22:15:25 +0000 (11:15 +1300)]
Replaced ternary operator with condition only
Marc-André Moreau [Tue, 10 Feb 2015 21:32:07 +0000 (16:32 -0500)]
xfreerdp: fix egfx multimonitor support
Marc-André Moreau [Tue, 10 Feb 2015 20:22:45 +0000 (15:22 -0500)]
Merge pull request #2378 from awakecoding/master
xfreerdp fullscreen fix
Marc-André Moreau [Tue, 10 Feb 2015 20:15:30 +0000 (15:15 -0500)]
xfreerdp: fix fullscreen mode
Bernhard Miklautz [Tue, 10 Feb 2015 17:05:40 +0000 (18:05 +0100)]
wtsapi: add TestWtsApiExtra
Move wtsapi tests that only make sense when run within a session
("interactive") to TestWtsApiExtra since they either brake automated
builds or don't make sense if the return value isn't checked.
TestWtsApiExtra is not build by default but can be enabled by specifying
-DTESTS_WTSAPI_EXTRA=ON (this option is only available if BUILD_TESTING
is enabled).
The tests set the ctest label WTSAPI_EXTRA and can therefore also
be run explicitly with ctest -L WTSAPI_EXTRA.
Marc-André Moreau [Tue, 10 Feb 2015 15:43:59 +0000 (10:43 -0500)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Tue, 10 Feb 2015 15:42:13 +0000 (10:42 -0500)]
Merge pull request #2372 from MartinHaimberger/wtsapiextension
wtsapi: extended wtsapi
Marc-André Moreau [Tue, 10 Feb 2015 15:41:10 +0000 (10:41 -0500)]
Merge pull request #2374 from bjcollins/master
Apply correct exit code to xfreerdp application for certain log offs
Marc-André Moreau [Tue, 10 Feb 2015 15:40:30 +0000 (10:40 -0500)]
Merge pull request #2373 from akallabeth/reconnect_resource_fix
Reconnect resource cleanup fix
Norbert Federa [Tue, 10 Feb 2015 13:57:57 +0000 (14:57 +0100)]
Merge pull request #2371 from bmiklautz/terminate_process
winpr/process: handle PIDs <= 0 in TerminateProcess
Norbert Federa [Tue, 10 Feb 2015 13:56:30 +0000 (14:56 +0100)]
Merge pull request #2375 from hardening/minimize_diff
Check return value for fcntl()
Norbert Federa [Tue, 10 Feb 2015 13:55:57 +0000 (14:55 +0100)]
Merge pull request #2376 from hardening/minimize_diff2
Handle OOM in Stream_New()
Hardening [Tue, 10 Feb 2015 09:26:32 +0000 (10:26 +0100)]
Handle OOM in Stream_New()
Hardening [Tue, 10 Feb 2015 09:08:39 +0000 (10:08 +0100)]
Check return value for fcntl()
bjcollins [Mon, 9 Feb 2015 23:15:07 +0000 (17:15 -0600)]
Apply correct exit code to xfreerdp application for log off from certain flavors of Windows.
Armin Novak [Mon, 9 Feb 2015 16:35:41 +0000 (17:35 +0100)]
Fixed codecs_free
Armin Novak [Mon, 9 Feb 2015 16:33:55 +0000 (17:33 +0100)]
Fixed resource cleanup on disconnect.
Armin Novak [Mon, 9 Feb 2015 16:33:43 +0000 (17:33 +0100)]
Fixed resource cleanup on disconnect.
Martin Haimberger [Mon, 9 Feb 2015 14:30:18 +0000 (06:30 -0800)]
wtsapi: extended wtsapi
- added missing definitions for session change notification
- extended wtsapi to allow remote logon and logoff against the wtsapi (this allows remote wtsapi usage)
Bernhard Miklautz [Mon, 9 Feb 2015 13:07:14 +0000 (14:07 +0100)]
winpr/process: handle pids <= 0
TerminateProcess shouldn't call kill if the PID is <=0 because this has
unwanted effects (and is not what TerminateProcess should do):
* with PID == 0 any process in the same process group gets the signal
sent
* with PID == -1 *every* processes that the running users has
permissions to gets the signal sent
* with PID < -1 the process within the same process group and -PID gets
the signal send
For more details see kill(2).
Marc-André Moreau [Mon, 9 Feb 2015 03:29:52 +0000 (22:29 -0500)]
libwinpr-winsock: add WSAEventSelect, ioctlsocket
Marc-André Moreau [Fri, 6 Feb 2015 23:29:33 +0000 (18:29 -0500)]
Merge pull request #2368 from awakecoding/master
AutoReconnect Fixes
Marc-André Moreau [Fri, 6 Feb 2015 23:02:16 +0000 (18:02 -0500)]
Merge pull request #2367 from eledoux/ports
fixed: serial redirect not work #2333
Marc-André Moreau [Fri, 6 Feb 2015 23:02:10 +0000 (18:02 -0500)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Fri, 6 Feb 2015 22:59:48 +0000 (17:59 -0500)]
Merge pull request #2366 from xsumbe00/master
Fixes Solaris bus error on sparc.
Marc-André Moreau [Fri, 6 Feb 2015 22:46:15 +0000 (17:46 -0500)]
xfreerdp: fix egfx multimon on reconnect
Marc-André Moreau [Fri, 6 Feb 2015 22:35:14 +0000 (17:35 -0500)]
libfreerdp-core: add channel reconnect
Marc-André Moreau [Fri, 6 Feb 2015 21:55:21 +0000 (16:55 -0500)]
libfreerdp-core: refactor client info pdu functions
Marc-André Moreau [Fri, 6 Feb 2015 21:37:28 +0000 (16:37 -0500)]
libfreerdp-core: fix auto reconnect cookie security verifier computation
Marc-André Moreau [Fri, 6 Feb 2015 20:44:29 +0000 (15:44 -0500)]
libfreerdp-core: improve client core info debug output
Marc-André Moreau [Fri, 6 Feb 2015 19:21:26 +0000 (14:21 -0500)]
libfreerdp-core: improve reconnection
Emmanuel Ledoux [Fri, 6 Feb 2015 18:56:36 +0000 (19:56 +0100)]
serial: changed the default underlying ServerSerialDriverId from SerialDriverSerCx2Sys to SerialDriverSerialSys
Marc-André Moreau [Thu, 5 Feb 2015 22:01:56 +0000 (17:01 -0500)]
xfreerdp: partial reconnect fixes
Marc-André Moreau [Thu, 5 Feb 2015 20:10:24 +0000 (15:10 -0500)]
libfreerdp-codec: allow region_uninit to be called multiple times
Petr Sumbera [Thu, 5 Feb 2015 16:46:56 +0000 (08:46 -0800)]
Fixes Solaris bus error on sparc.
Marc-André Moreau [Wed, 4 Feb 2015 16:58:34 +0000 (11:58 -0500)]
Merge pull request #2364 from awakecoding/gateway
Gateway Improvements and Fixes
Marc-André Moreau [Wed, 4 Feb 2015 16:40:19 +0000 (11:40 -0500)]
wlfreerdp: fix unused variable warning
Marc-André Moreau [Wed, 4 Feb 2015 16:36:05 +0000 (11:36 -0500)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP into gateway
Marc-André Moreau [Wed, 4 Feb 2015 16:34:02 +0000 (11:34 -0500)]
Merge pull request #2355 from xsumbe00/master
Fixes some build issues on Solaris 11.
Marc-André Moreau [Wed, 4 Feb 2015 16:32:12 +0000 (11:32 -0500)]
Merge pull request #2343 from kilobyte/master
Fix build failure on x32.
Marc-André Moreau [Wed, 4 Feb 2015 16:31:49 +0000 (11:31 -0500)]
Merge pull request #2340 from akallabeth/openssl_detection_fix
Openssl detection fix
Marc-André Moreau [Wed, 4 Feb 2015 16:30:35 +0000 (11:30 -0500)]
Merge pull request #2349 from RolKau/2349_dvp
Forward layout ID of Programmer Dvorak to server
Marc-André Moreau [Wed, 4 Feb 2015 16:27:41 +0000 (11:27 -0500)]
Merge pull request #2350 from giox069/master
Fix freerdp_channels_free for clients with multiple active connections
Marc-André Moreau [Wed, 4 Feb 2015 16:18:27 +0000 (11:18 -0500)]
libfreerdp-core: make tsg rpc connection event-driven, fix race condition on connection
Norbert Federa [Wed, 4 Feb 2015 09:03:21 +0000 (10:03 +0100)]
Merge pull request #2361 from bmiklautz/set_pointer_fix
xfreerdp: fix problem with SetPosition
Marc-André Moreau [Wed, 4 Feb 2015 01:39:47 +0000 (20:39 -0500)]
libfreerdp-core: add event-driven RTS connection code
Marc-André Moreau [Tue, 3 Feb 2015 22:17:17 +0000 (17:17 -0500)]
libfreerdp-core: start event-driven gateway http code
Marc-André Moreau [Tue, 3 Feb 2015 21:33:45 +0000 (16:33 -0500)]
libfreerdp-core: add more IN/OUT gateway channel states
Petr Sumbera [Tue, 3 Feb 2015 21:29:35 +0000 (13:29 -0800)]
Better to use HAVE_SYS_FILIO_H when we already have it.
Petr Sumbera [Tue, 3 Feb 2015 21:14:40 +0000 (13:14 -0800)]
"ar" and zero or several 'm' matches also to "sparc". Adding '^' at the begiinning seems like the safest option.
Bernhard Miklautz [Tue, 3 Feb 2015 21:08:34 +0000 (22:08 +0100)]
xfreerdp: fix problem with SetPosition
Since XWarpPointer generates an pointer motion event, as if the mouse
was moved by hand, xfreerdp sends back the received mouse position to
the server. This behavior is wrong since pointer positions set via
server pointer update pdu shouldn't get sent back to the server
(it's not a "real" mouse move).
To fix this problem change the x windows event mask to not handle
pointer motion events before setting the new pointer position and change
it back again afterwards.
Possible downside of this is that some pointer motion events might get
lost but this shouldn't be noticeable.
Thanks to nfedera for the neat idea ;).
Emmanuel Ledoux [Tue, 3 Feb 2015 20:16:29 +0000 (21:16 +0100)]
winpr-comm: fixed timeouts to return immediately with zeroed timeval structures instead of a NULL pointer.
Marc-André Moreau [Tue, 3 Feb 2015 19:44:31 +0000 (14:44 -0500)]
libfreerdp-core: improve error handling in ts gateway
Hardening [Tue, 3 Feb 2015 16:22:21 +0000 (17:22 +0100)]
Merge pull request #2358 from nfedera/fix-2015-02-03-01
core/fastpath: removed flawed slow-path conversion
Hardening [Tue, 3 Feb 2015 16:15:51 +0000 (17:15 +0100)]
Merge pull request #2356 from nfedera/fix-2015-02-02-01
core/capabilities: remove misplaced/useless code
Bernhard Miklautz [Tue, 3 Feb 2015 15:09:01 +0000 (16:09 +0100)]
pkg/rpm: fix changelog order
Bernhard Miklautz [Tue, 3 Feb 2015 15:07:54 +0000 (16:07 +0100)]
pkg/rpm: fix typo in changelog
Hardening [Tue, 3 Feb 2015 14:52:16 +0000 (15:52 +0100)]
Merge pull request #2360 from bmiklautz/version_update
Update version to 1.2.1
Marc-André Moreau [Tue, 3 Feb 2015 14:47:15 +0000 (09:47 -0500)]
Merge pull request #2359 from bmiklautz/ringbuffer_debug
ringbuffer: add option to enable/disable debugging
Bernhard Miklautz [Tue, 3 Feb 2015 12:49:05 +0000 (13:49 +0100)]
pkgs: update version to 1.2.1
Hardening [Mon, 2 Feb 2015 21:52:35 +0000 (22:52 +0100)]
Update version to 1.2.1
This allows code using FreeRDP to detect the presence of the skipCompression field in
surface commands.
Bernhard Miklautz [Tue, 3 Feb 2015 14:28:05 +0000 (15:28 +0100)]
ringbuffer: add option to enable/disable debugging
Add option WITH_DEBUG_RINGBUFFER to enable/disable ringbuffer debugging
at compile time.
Even if it is possible to filter specific wlog tags it's not yet
possible to exclude one or more and ringbuffer adds massive debugging
output if enabled and WLOG_LEVEL is set to DEBUG.
Norbert Federa [Tue, 3 Feb 2015 12:51:35 +0000 (13:51 +0100)]
core/fastpath: removed flawed slow-path conversion
Commit
0357a38e3129b67093c7c055c7eaa242ce293673 modified the function
fastpath_send_update_pdu() to check if the desired update is possible
by checking the payload size against the computed maxLength and the
clients's advertised max request size.
If the check failed that commit added a workaround which simply
copied the payload to a slow path updade.
This workaround is totally flawed and causes protocol errors:
- the fast path update code is not checked and required data format
conversions are missing
- depending on the fast path update code rdp_send_data_pdu() would
have to be called with differend data pdu type values but the
workaround always uses DATA_PDU_TYPE_UPDATE
- the workaround does not check if the total size would exceed
the maximum possible size for a slow path update
The check if a fast path output is actually possible with the
passed parameters is basically a good idea.
However, if that check fails it would only indicate an error in
the server implementation who must not generate updates that
exceed the client's max request size.
Even though a slow-path conversion would be possible there is
much more involved than simply copying the payload stream.
In addition it is highly doubtful if there is a benefit at all.
Even the oldest rdesktop and windows ce clients do support fast
path and although some lack the multi-fragment update capability
we cannot really send larger updates using slow-path outputs.
For the reasons elucidated above, I have removed the workaround
but kept a modified version of the check if a fast-path output
is possible at all.
Marc-André Moreau [Mon, 2 Feb 2015 23:50:26 +0000 (18:50 -0500)]
libfreerdp-core: add better state machine transitions to ts gateway
Marc-André Moreau [Mon, 2 Feb 2015 22:16:32 +0000 (17:16 -0500)]
libfreerdp-core: improve http parsing
Petr Sumbera [Mon, 2 Feb 2015 18:59:51 +0000 (10:59 -0800)]
Added ifdef to previous commit.
Norbert Federa [Mon, 2 Feb 2015 17:25:10 +0000 (18:25 +0100)]
core/capabilities: remove misplaced/useless code
Commit
0357a38e3129b67093c7c055c7eaa242ce293673 has added some code
without any effect.
That commit added code to rdp_read_capability_sets() to check if
CAPSET_TYPE_MULTI_FRAGMENT_UPDATE was not received which caused
settings->MultifragMaxRequestSize to be set to 0.
- this was done in the wrong place because we do these kind
of checks in rdp_recv_confirm_active() by consulting the
variable settings->ReceivedCapabilities[]
- the code had no effect at all because MultifragMaxRequestSize gets
set to FASTPATH_FRAGMENT_SAFE_SIZE in rdp_recv_confirm_active()
if the CAPSET_TYPE_MULTI_FRAGMENT_UPDATE was not received.
Norbert Federa [Mon, 2 Feb 2015 17:12:49 +0000 (18:12 +0100)]
Merge pull request #2354 from bmiklautz/ts_pointer_pdu
Handle Server Pointer Update PDU client side
Marc-André Moreau [Mon, 2 Feb 2015 16:50:56 +0000 (11:50 -0500)]
libfreerdp-core: make tsg threadless
Petr Sumbera [Mon, 2 Feb 2015 16:48:54 +0000 (08:48 -0800)]
Fixes some build issues on Solaris 11.
Bernhard Miklautz [Mon, 2 Feb 2015 16:03:33 +0000 (17:03 +0100)]
Merge pull request #2332 from bmiklautz/pkg_rpm
Preparations for rpm builds
Bernhard Miklautz [Mon, 2 Feb 2015 14:32:49 +0000 (15:32 +0100)]
xfreerdp: add support to set pointer
Marc-André Moreau [Mon, 2 Feb 2015 13:19:07 +0000 (08:19 -0500)]
libfreerdp-core: remove receive queue, make tsg connection sequence more event-driven
Bernhard Miklautz [Tue, 13 Jan 2015 16:12:02 +0000 (17:12 +0100)]
gfx/pointer: add support to set pointer
Extend rdp_pointer with function SetPosition. Can then be used by
clients support setting pointer by server which might be used in
shadowing scenarios.
Marc-André Moreau [Mon, 2 Feb 2015 01:47:43 +0000 (20:47 -0500)]
libfreerdp-core: remove TS Gateway send queue
Marc-André Moreau [Sun, 1 Feb 2015 23:50:21 +0000 (18:50 -0500)]
libfreerdp-core: restructure RPC connection sequence
Marc-André Moreau [Sun, 1 Feb 2015 22:55:24 +0000 (17:55 -0500)]
libfreerdp-core: refactor tsg connection sequence towards better state machine usage
Marc-André Moreau [Sun, 1 Feb 2015 22:06:50 +0000 (17:06 -0500)]
libfreerdp-core: fix possible lost signal in tsg_connect
Marc-André Moreau [Sun, 1 Feb 2015 20:58:32 +0000 (15:58 -0500)]
libfreerdp-core: remove usage of magic 60-byte pad in TsProxyCreateTunnelWriteRequest
Marc-André Moreau [Sun, 1 Feb 2015 18:09:28 +0000 (13:09 -0500)]
libfreerdp-core: use ringbuffer for TS Gateway receive pipe
Giovanni Panozzo [Sun, 1 Feb 2015 09:57:54 +0000 (10:57 +0100)]
Fix channels_free for multiple connected clients
When a client disconnects from a server and its channel structures are removed, the global hash g_OpenHandles should not be destroyed. Only freed channels must be removed from the hash.