platform/upstream/ofono.git
15 years agoFixes to parser state when command prompt is used
Denis Kenzior [Sat, 20 Jun 2009 02:10:51 +0000 (21:10 -0500)]
Fixes to parser state when command prompt is used

15 years agoAdd yet another unit test
Denis Kenzior [Fri, 19 Jun 2009 19:38:13 +0000 (14:38 -0500)]
Add yet another unit test

15 years agoSome fixes to sms_text_prepare
Denis Kenzior [Fri, 19 Jun 2009 17:49:25 +0000 (12:49 -0500)]
Some fixes to sms_text_prepare

15 years agoAdd address from string utility for SMS
Denis Kenzior [Fri, 19 Jun 2009 17:26:04 +0000 (12:26 -0500)]
Add address from string utility for SMS

15 years agoFix minor bug in phone number handling
Denis Kenzior [Fri, 19 Jun 2009 17:24:55 +0000 (12:24 -0500)]
Fix minor bug in phone number handling

15 years agoUpdate unit tests
Denis Kenzior [Fri, 19 Jun 2009 15:16:11 +0000 (10:16 -0500)]
Update unit tests

15 years agoUtility to create SMS, both fragmented and not
Denis Kenzior [Fri, 19 Jun 2009 15:14:33 +0000 (10:14 -0500)]
Utility to create SMS, both fragmented and not

15 years agoAdd utility function
Denis Kenzior [Fri, 19 Jun 2009 13:38:24 +0000 (08:38 -0500)]
Add utility function

15 years agoMinor style issue
Denis Kenzior [Fri, 19 Jun 2009 13:38:06 +0000 (08:38 -0500)]
Minor style issue

15 years agoDon't fail in own_buf if items_written is NULL
Denis Kenzior [Fri, 19 Jun 2009 13:03:53 +0000 (08:03 -0500)]
Don't fail in own_buf if items_written is NULL

15 years agoFix another logic bug in SS parser
Denis Kenzior [Thu, 18 Jun 2009 21:55:07 +0000 (16:55 -0500)]
Fix another logic bug in SS parser

If the passwords do not match, it is still a recognized string,
but we must return invalid format

15 years agoMinor style issue
Denis Kenzior [Thu, 18 Jun 2009 21:49:47 +0000 (16:49 -0500)]
Minor style issue

15 years agoFix logic flow in SS parser
Denis Kenzior [Thu, 18 Jun 2009 21:39:55 +0000 (16:39 -0500)]
Fix logic flow in SS parser

15 years agoImplement CallBarring::ChangePassword in AT driver
Andrzej Zaborowski [Thu, 18 Jun 2009 04:04:46 +0000 (06:04 +0200)]
Implement CallBarring::ChangePassword in AT driver

15 years agoAdd CallBarring::ChangePassword
Andrzej Zaborowski [Thu, 18 Jun 2009 04:04:34 +0000 (06:04 +0200)]
Add CallBarring::ChangePassword

15 years agoTeach USSD to recognise password change strings.
Andrzej Zaborowski [Thu, 18 Jun 2009 04:04:23 +0000 (06:04 +0200)]
Teach USSD to recognise password change strings.

This is slightly hacky, part of ussd.c responsible for registering services
is duplicated and parse_ss_control_string is modified to accept a fourth
SI fragment in the input string.

15 years agoMove struct ussd_data definition out of the header.
Andrzej Zaborowski [Thu, 18 Jun 2009 04:04:13 +0000 (06:04 +0200)]
Move struct ussd_data definition out of the header.

No fuctional change.

15 years agoMention Yang's contribution
Denis Kenzior [Thu, 18 Jun 2009 20:29:05 +0000 (15:29 -0500)]
Mention Yang's contribution

15 years agoMention Aki's contribution
Denis Kenzior [Thu, 18 Jun 2009 20:28:32 +0000 (15:28 -0500)]
Mention Aki's contribution

15 years agoMention Rémi's contribution
Denis Kenzior [Thu, 18 Jun 2009 20:27:59 +0000 (15:27 -0500)]
Mention Rémi's contribution

15 years agoDon't bother reporting subscriber numbers by type
Denis Kenzior [Thu, 18 Jun 2009 08:59:13 +0000 (03:59 -0500)]
Don't bother reporting subscriber numbers by type

15 years agoCleanup EFmsisdn reading patch
Denis Kenzior [Thu, 18 Jun 2009 08:46:08 +0000 (03:46 -0500)]
Cleanup EFmsisdn reading patch

15 years agoAdd a new extract_bcd_number utility
Denis Kenzior [Thu, 18 Jun 2009 08:45:55 +0000 (03:45 -0500)]
Add a new extract_bcd_number utility

15 years agoRead own numbers from EFmsisdn instead of AT+CNUM.
Andrzej Zaborowski [Thu, 18 Jun 2009 03:44:56 +0000 (05:44 +0200)]
Read own numbers from EFmsisdn instead of AT+CNUM.

15 years agoMinor style fixes
Denis Kenzior [Thu, 18 Jun 2009 07:23:37 +0000 (02:23 -0500)]
Minor style fixes

15 years agoAdd record based file capability to sim_ops
Andrzej Zaborowski [Thu, 18 Jun 2009 03:44:44 +0000 (05:44 +0200)]
Add record based file capability to sim_ops

Add capability to read / write / stat files on the SIM.  This now
supports cyclic, linear fixed and transparent SIM files.

Parse GET RESPONSE result to find structure of the file (cyclic, linear
fixed, or transparent), the file size and the record length.

Add both read and update capability for binary and record-based files.

Implement writing sim files through AT.

15 years agoUse GET RESPONSE sim command to retrieve EF length
Andrzej Zaborowski [Thu, 18 Jun 2009 03:44:28 +0000 (05:44 +0200)]
Use GET RESPONSE sim command to retrieve EF length

Also accept 0x9f as a success status word 1 for READ BINARY (GSM specific).

15 years agoFix NetworkRegistration test by fixing indentation.
Andrzej Zaborowski [Thu, 18 Jun 2009 03:44:06 +0000 (05:44 +0200)]
Fix NetworkRegistration test by fixing indentation.

[Sorry if you get this mail or some of the other mails a second time,
I sent a copy from an unsubscribed address yesterday].

15 years agoPhonebook API tweak
Denis Kenzior [Wed, 17 Jun 2009 23:19:20 +0000 (18:19 -0500)]
Phonebook API tweak

15 years agoAdd call-history driver type
Denis Kenzior [Wed, 17 Jun 2009 12:03:21 +0000 (07:03 -0500)]
Add call-history driver type

15 years agoReturn slist elements back to the allocator
Denis Kenzior [Wed, 17 Jun 2009 11:29:31 +0000 (06:29 -0500)]
Return slist elements back to the allocator

15 years agoRefactor phonebook code
Denis Kenzior [Tue, 16 Jun 2009 21:33:05 +0000 (16:33 -0500)]
Refactor phonebook code

Use immediate mode reporting, which means that the individual CPBR
lines are reported up to the core immediately.  This has a couple
advantages:
  - We do not need to malloc/free a bunch of single variables
    and copy them over.  Helps performance.
  - The lines are not buffered up and given to the plugin in one
    shot, instead processing is performed piecemeal.  This helps
    with keeping memory consumption down to a minimum

15 years agoUse library functions appropriately
Denis Kenzior [Tue, 16 Jun 2009 21:31:32 +0000 (16:31 -0500)]
Use library functions appropriately

Instead of using custom parsing, use the existing library
functionality in result iter open_list, next_range and close_list

15 years agoNo need for mainloop in this test
Denis Kenzior [Tue, 16 Jun 2009 21:26:17 +0000 (16:26 -0500)]
No need for mainloop in this test

15 years agoHeader guards not to be present in private headers
Denis Kenzior [Tue, 16 Jun 2009 15:51:04 +0000 (10:51 -0500)]
Header guards not to be present in private headers

15 years agoFix SMS port addressing
Denis Kenzior [Tue, 16 Jun 2009 15:48:47 +0000 (10:48 -0500)]
Fix SMS port addressing

15 years agoSMS 8-Bit and 16-Bit ports are not the same
Denis Kenzior [Tue, 16 Jun 2009 15:48:27 +0000 (10:48 -0500)]
SMS 8-Bit and 16-Bit ports are not the same

15 years agoFix not being able to set some attributes
Denis Kenzior [Tue, 16 Jun 2009 03:22:44 +0000 (22:22 -0500)]
Fix not being able to set some attributes

15 years agoFix test case
Denis Kenzior [Tue, 16 Jun 2009 00:36:15 +0000 (19:36 -0500)]
Fix test case

15 years agoCleanup phonebook implementation
Denis Kenzior [Tue, 16 Jun 2009 00:35:41 +0000 (19:35 -0500)]
Cleanup phonebook implementation

15 years agoFix style issues
Denis Kenzior [Tue, 16 Jun 2009 00:35:20 +0000 (19:35 -0500)]
Fix style issues

15 years agoChange some defines
Denis Kenzior [Tue, 16 Jun 2009 00:31:05 +0000 (19:31 -0500)]
Change some defines

15 years agoDon't use spaces and use tabs instead
Denis Kenzior [Tue, 16 Jun 2009 00:29:10 +0000 (19:29 -0500)]
Don't use spaces and use tabs instead

15 years agoRe-arrange destruction order
Denis Kenzior [Tue, 16 Jun 2009 00:28:42 +0000 (19:28 -0500)]
Re-arrange destruction order

15 years agoMake const-correct
Denis Kenzior [Tue, 16 Jun 2009 00:28:15 +0000 (19:28 -0500)]
Make const-correct

15 years agoImprove string parsing code
Denis Kenzior [Mon, 15 Jun 2009 22:41:50 +0000 (17:41 -0500)]
Improve string parsing code

Currently next_string and next_hexstring functions use a static
buffer in the iterator to store the value.  This value is clobbered
as soon as next_string or next_hexstring is called.  Instead,
we copy the entire line in iter_next and use it as a scratch buffer.
The only limitation is that lines of max 2048 are possible, however
these are limited to around this size by parts of the standard.

15 years agoAdd g_at_send_listing function
Denis Kenzior [Mon, 15 Jun 2009 21:37:13 +0000 (16:37 -0500)]
Add g_at_send_listing function

15 years agoExport phonebook as vCard 3.0 format
Yang Gu [Mon, 15 Jun 2009 08:18:48 +0000 (16:18 +0800)]
Export phonebook as vCard 3.0 format

15 years agoRework CMGR as an unsolicited notification
Denis Kenzior [Mon, 15 Jun 2009 20:45:52 +0000 (15:45 -0500)]
Rework CMGR as an unsolicited notification

Since the PDU line doesn't have a prefix, the parser can get confused
if other unsolicited notifications arrive.  There is already explicit
support for unsolicited notifications with PDU, so we use that
instead

15 years agoAdd SMS fragment assembly capabilities
Denis Kenzior [Sun, 14 Jun 2009 07:00:56 +0000 (02:00 -0500)]
Add SMS fragment assembly capabilities

15 years agoAdd Unit test for SMS re-assembly code
Denis Kenzior [Sun, 14 Jun 2009 07:00:39 +0000 (02:00 -0500)]
Add Unit test for SMS re-assembly code

15 years agoAdd utilities for SMS re-assembly
Denis Kenzior [Sun, 14 Jun 2009 07:00:06 +0000 (02:00 -0500)]
Add utilities for SMS re-assembly

15 years agoFix SMS Concatenation header parsing
Denis Kenzior [Sun, 14 Jun 2009 05:20:06 +0000 (00:20 -0500)]
Fix SMS Concatenation header parsing

15 years agoChange function signature
Denis Kenzior [Sun, 14 Jun 2009 05:19:35 +0000 (00:19 -0500)]
Change function signature

15 years agoFix to use negative error return in gisi/client.c
Aki Niemi [Mon, 15 Jun 2009 08:33:16 +0000 (11:33 +0300)]
Fix to use negative error return in gisi/client.c

15 years agoRename ISI client and PhoNet netlink APIs
Aki Niemi [Mon, 15 Jun 2009 08:17:30 +0000 (11:17 +0300)]
Rename ISI client and PhoNet netlink APIs

- Add g_ prefix to functions
- Add G-prefix and use CamelCasing in types

15 years agoAdd Basic SMS reception capabilities
Denis Kenzior [Sat, 13 Jun 2009 02:32:39 +0000 (21:32 -0500)]
Add Basic SMS reception capabilities

- Can receive 7Bit, 8Bit and UCS2 encoded messages
- 8Bit is assumed to be a datagram to a certain port
- Messages with Invalid format are ignored
- Concatenation not yet supported

15 years agoAdd utility to extract text SMS
Denis Kenzior [Sat, 13 Jun 2009 02:19:55 +0000 (21:19 -0500)]
Add utility to extract text SMS

15 years agoAdd utility to extract datagrams
Denis Kenzior [Sat, 13 Jun 2009 02:19:30 +0000 (21:19 -0500)]
Add utility to extract datagrams

15 years agoAdd utility to extract SMS concatenation info
Denis Kenzior [Sat, 13 Jun 2009 02:18:36 +0000 (21:18 -0500)]
Add utility to extract SMS concatenation info

15 years agoAdd utility to extract application port address
Denis Kenzior [Sat, 13 Jun 2009 02:17:42 +0000 (21:17 -0500)]
Add utility to extract application port address

15 years agoAdd a couple new sms_udh_iter utilities
Denis Kenzior [Sat, 13 Jun 2009 02:16:34 +0000 (21:16 -0500)]
Add a couple new sms_udh_iter utilities

15 years agoAdd pretty print function for SMS addresses
Denis Kenzior [Sat, 13 Jun 2009 02:15:24 +0000 (21:15 -0500)]
Add pretty print function for SMS addresses

15 years agoAdd sms_extract_common function
Denis Kenzior [Sat, 13 Jun 2009 02:05:06 +0000 (21:05 -0500)]
Add sms_extract_common function

Extract common attributes from the various SMS types

15 years agoMake SCTS to time function const-correct
Denis Kenzior [Sat, 13 Jun 2009 02:02:49 +0000 (21:02 -0500)]
Make SCTS to time function const-correct

15 years agoCan't implement Multiparty Hangup without chld
Denis Kenzior [Fri, 12 Jun 2009 16:44:32 +0000 (11:44 -0500)]
Can't implement Multiparty Hangup without chld

15 years agoDo not use chld=1 on mpty when another held
Denis Kenzior [Fri, 12 Jun 2009 05:19:14 +0000 (00:19 -0500)]
Do not use chld=1 on mpty when another held

If we're trying to hangup an active MPTY call, and we have
calls on hold we shouldn't use CHLD=1 (release_all_active)
since this will have the side-effect of activating the held
calls

15 years agoFix memory leak
Denis Kenzior [Sat, 13 Jun 2009 00:40:51 +0000 (19:40 -0500)]
Fix memory leak

15 years agoFixup style issues with previous MCC/MNC patch
Denis Kenzior [Sat, 13 Jun 2009 00:33:55 +0000 (19:33 -0500)]
Fixup style issues with previous MCC/MNC patch

- Breakup MCC/MNC LENGTH constant
- Don't hardcode numbers
- Fix >80 column length
- Fix test case to expect strings instead of shorts

15 years agoChange MNC and MCC variable types to string
Aki Niemi [Fri, 12 Jun 2009 07:02:52 +0000 (10:02 +0300)]
Change MNC and MCC variable types to string

This is to make sure both 2 and 3-digit MNC values are correctly
handled. Both the modem plugin API as well as the D-Bus API are
affected.

15 years agoFix another pointer cast to use GINT_TO_POINTER
Denis Kenzior [Fri, 12 Jun 2009 04:43:33 +0000 (23:43 -0500)]
Fix another pointer cast to use GINT_TO_POINTER

15 years agoAdd additional sanity check
Denis Kenzior [Thu, 11 Jun 2009 22:00:14 +0000 (17:00 -0500)]
Add additional sanity check

15 years agoMake SMS UDH iterators const-correct
Denis Kenzior [Thu, 11 Jun 2009 19:27:14 +0000 (14:27 -0500)]
Make SMS UDH iterators const-correct

15 years agoPhonet/ISI client helper
Rémi Denis-Courmont [Tue, 9 Jun 2009 13:26:36 +0000 (16:26 +0300)]
Phonet/ISI client helper

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
15 years agoPhonet datagram socket helpers
Rémi Denis-Courmont [Tue, 9 Jun 2009 13:26:26 +0000 (16:26 +0300)]
Phonet datagram socket helpers

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
15 years agoPhonet Netlink helpers
Rémi Denis-Courmont [Thu, 4 Jun 2009 15:46:48 +0000 (18:46 +0300)]
Phonet Netlink helpers

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
15 years agoCheck for restrict keyword
Rémi Denis-Courmont [Thu, 4 Jun 2009 15:26:20 +0000 (18:26 +0300)]
Check for restrict keyword

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
15 years agoconfigure: set compiler flags at the end
Rémi Denis-Courmont [Tue, 9 Jun 2009 13:35:28 +0000 (16:35 +0300)]
configure: set compiler flags at the end

This fixes interferences with warning-unsafe autoconf macros.

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
15 years agoFix for multiparty_hangup
Denis Kenzior [Thu, 11 Jun 2009 15:43:30 +0000 (10:43 -0500)]
Fix for multiparty_hangup

Due to the use of an invalid structure, release_all_active was being
called instead of release_all_held

15 years agoFix typo
Denis Kenzior [Wed, 10 Jun 2009 21:06:14 +0000 (16:06 -0500)]
Fix typo

15 years agoAdd TP-PID enumeration
Denis Kenzior [Wed, 10 Jun 2009 20:52:28 +0000 (15:52 -0500)]
Add TP-PID enumeration

15 years agoAdditional fixes to multiline responses
Denis Kenzior [Tue, 9 Jun 2009 03:43:27 +0000 (22:43 -0500)]
Additional fixes to multiline responses

The previous fix did not take into account the logic in have_line
function, which takes care of certain modems that do not prefix
their responses by <cr><lf> at all.  This fix should take both
into consideration

15 years agoFix multiline responses in GAtChat
Denis Kenzior [Mon, 8 Jun 2009 19:06:07 +0000 (14:06 -0500)]
Fix multiline responses in GAtChat

The standard is a bit fuzzy on how multiline responses are returned
GAtChat assumed that they will always start with <cr><lf>, however
this doesn't seem to be correct.  Add a new state which is entered
when a response is obtained.  If <cr> is encountered, then it
is processed regularly, otherwise the parser assumes that the
next line is part of the multiline response

15 years agoAdd utility for parsing MWI SMS DCS types
Denis Kenzior [Fri, 5 Jun 2009 22:56:11 +0000 (17:56 -0500)]
Add utility for parsing MWI SMS DCS types

15 years agoOnly USSD needs the special <cr> handling
Denis Kenzior [Fri, 5 Jun 2009 22:35:50 +0000 (17:35 -0500)]
Only USSD needs the special <cr> handling

Apparently all Cell Broadcasts are always 88 bytes long, with a
6 byte header and 82 byte payload.  <cr> character is used as a
terminator and padding for the unused payload

15 years agoFixup header
Denis Kenzior [Fri, 5 Jun 2009 22:30:30 +0000 (17:30 -0500)]
Fixup header

15 years agoReorder the header file a bit
Denis Kenzior [Fri, 5 Jun 2009 22:28:09 +0000 (17:28 -0500)]
Reorder the header file a bit

15 years agoRename ud_len_in_octets to sms_udl_in_bytes
Denis Kenzior [Fri, 5 Jun 2009 18:31:47 +0000 (13:31 -0500)]
Rename ud_len_in_octets to sms_udl_in_bytes

15 years agoRename sms utilities properly
Denis Kenzior [Fri, 5 Jun 2009 18:29:03 +0000 (13:29 -0500)]
Rename sms utilities properly

Rename encode_sms to sms_encode
Rename decode_sms to sms_decode

15 years agoAdd SMS specific DCS decoding function
Denis Kenzior [Fri, 5 Jun 2009 18:27:16 +0000 (13:27 -0500)]
Add SMS specific DCS decoding function

15 years agoAdd utility to convert SCTS to local/remote time
Denis Kenzior [Fri, 5 Jun 2009 16:51:46 +0000 (11:51 -0500)]
Add utility to convert SCTS to local/remote time

15 years agoAdd proper handling for various messages
Denis Kenzior [Thu, 4 Jun 2009 22:13:09 +0000 (17:13 -0500)]
Add proper handling for various messages

Handle Deliver / Status Report / Cell Broadcast messages and send the
appropriate acknowledgement PDUs (+CNMA) if required

15 years agoSMS-Command is also submitted with sc address
Denis Kenzior [Thu, 4 Jun 2009 21:17:29 +0000 (16:17 -0500)]
SMS-Command is also submitted with sc address

15 years agoAdd colons to SMS prefixes
Denis Kenzior [Thu, 4 Jun 2009 17:35:17 +0000 (12:35 -0500)]
Add colons to SMS prefixes

15 years agoAdd SMS interface initialization code for atmodem
Denis Kenzior [Thu, 4 Jun 2009 02:07:25 +0000 (21:07 -0500)]
Add SMS interface initialization code for atmodem

15 years agoAdd check for error path
Denis Kenzior [Tue, 2 Jun 2009 19:39:27 +0000 (14:39 -0500)]
Add check for error path

15 years agoAdd check for error path
Denis Kenzior [Tue, 2 Jun 2009 19:38:42 +0000 (14:38 -0500)]
Add check for error path

15 years agoAdd UDH Iterator unit test
Denis Kenzior [Tue, 2 Jun 2009 18:20:18 +0000 (13:20 -0500)]
Add UDH Iterator unit test

15 years agoBreak out VPF printing into separate function
Denis Kenzior [Tue, 2 Jun 2009 18:18:25 +0000 (13:18 -0500)]
Break out VPF printing into separate function

15 years agoAdd User-Data-Header iterator utilities
Denis Kenzior [Tue, 2 Jun 2009 18:17:20 +0000 (13:17 -0500)]
Add User-Data-Header iterator utilities