platform/upstream/gst-plugins-good.git
9 years agov4l2object: reuse caps framerate if not overwritten by v4l2 device
Peter Seiderer [Fri, 14 Nov 2014 11:59:31 +0000 (12:59 +0100)]
v4l2object: reuse caps framerate if not overwritten by v4l2 device

Enables duration setting in v4l2src.

https://bugzilla.gnome.org/show_bug.cgi?id=740403

9 years agortpsession: Fix indention
Sebastian Dröge [Thu, 22 Jan 2015 09:29:24 +0000 (10:29 +0100)]
rtpsession: Fix indention

9 years agoqtdemux_dump: Bypass even more code if debugging is disabled
Edward Hervey [Wed, 21 Jan 2015 16:36:26 +0000 (17:36 +0100)]
qtdemux_dump: Bypass even more code if debugging is disabled

And avoid using variables that won't exist when debugging is disabled

9 years agoqtdemux: Only traverse/dump nodes if guaranteed to be used
Edward Hervey [Wed, 21 Jan 2015 14:30:33 +0000 (15:30 +0100)]
qtdemux: Only traverse/dump nodes if guaranteed to be used

__gst_debug_min is the "global" lowest debug level set. There's no
guarantee the qtdemux debug category is actually set at that level.

9 years agomatroska: Avoid debugging below category threshold
Edward Hervey [Sat, 20 Dec 2014 16:09:14 +0000 (17:09 +0100)]
matroska: Avoid debugging below category threshold

This part alone was what made the matroska thread take a full core
on an android phone ...

9 years agoConstify some static arrays everywhere
Sebastian Dröge [Wed, 21 Jan 2015 08:55:30 +0000 (09:55 +0100)]
Constify some static arrays everywhere

9 years agoqtdemux: fix deadlock seeking in files without seek entries
Vincent Penquerc'h [Mon, 19 Jan 2015 17:49:54 +0000 (17:49 +0000)]
qtdemux: fix deadlock seeking in files without seek entries

A mutex unlock was missing.

https://bugzilla.gnome.org/show_bug.cgi?id=739975

9 years agovideomixer: fix illegal memory access in blend function with negative ypos
Vincent Penquerc'h [Mon, 19 Jan 2015 12:34:25 +0000 (12:34 +0000)]
videomixer: fix illegal memory access in blend function with negative ypos

https://bugzilla.gnome.org/show_bug.cgi?id=741115

9 years agov4l2videodec: Proxy getcaps
Nicolas Dufresne [Tue, 13 Jan 2015 21:49:34 +0000 (16:49 -0500)]
v4l2videodec: Proxy getcaps

Replace the sink_query with new getcaps() virtual and use the proxy
helper with the probed caps. This allow upstream element taking decision
base on what is supported downstream.

9 years agoqtmux: Add support for v210
Sebastian Dröge [Tue, 13 Jan 2015 18:05:20 +0000 (19:05 +0100)]
qtmux: Add support for v210

9 years agoqtdemux: v210 is v210, not UYVY and yuv2 is YUY2, not I420
Sebastian Dröge [Tue, 13 Jan 2015 17:58:01 +0000 (18:58 +0100)]
qtdemux: v210 is v210, not UYVY and yuv2 is YUY2, not I420

Also add a few other raw video formats we support: v308, v216
and add comments for a few others we don't support yet.

https://developer.apple.com/library/mac/technotes/tn2162/

9 years agoAutomatic update of common submodule
Stefan Sauer [Mon, 12 Jan 2015 14:56:29 +0000 (15:56 +0100)]
Automatic update of common submodule

From f2c6b95 to bc76a8b

9 years agoosxvideosink: Disable hack for NSApp iteration with a special #define
Sebastian Dröge [Sat, 10 Jan 2015 14:51:16 +0000 (15:51 +0100)]
osxvideosink: Disable hack for NSApp iteration with a special #define

The hack causes deadlocks and other interesting problems and it really
can only be fixed properly inside GLib. We will include a patch for
GLib in our builds for now that handles this, and hopefully at some
point GLib will also merge a proper solution.

A proper solution would first require to refactor the polling in
GMainContext to only provide a single fd, e.g. via epoll/kqueue
or a thread like the one added by our patch. Then this single
fd could be retrieved from the GMainContext and directly integrated
into a NSRunLoop.

https://bugzilla.gnome.org/show_bug.cgi?id=741450
https://bugzilla.gnome.org/show_bug.cgi?id=704374

9 years agopulsesink: uncork if needed upon commit
Mark Nauwelaerts [Thu, 8 Jan 2015 20:07:05 +0000 (21:07 +0100)]
pulsesink: uncork if needed upon commit

... to provide for a running clock.

9 years agov4l2videodec: Prevent renegotiation
Nicolas Dufresne [Fri, 9 Jan 2015 21:59:53 +0000 (16:59 -0500)]
v4l2videodec: Prevent renegotiation

Renegotiation isn't supported, simply prevent it the way we do in
v4l2src.

9 years agov4l2videodec: Don't unlock the stream lock twice
Nicolas Dufresne [Tue, 6 Jan 2015 18:54:25 +0000 (13:54 -0500)]
v4l2videodec: Don't unlock the stream lock twice

9 years agoqtdemux: fix stream time conversion
Thiago Santos [Fri, 9 Jan 2015 14:40:40 +0000 (11:40 -0300)]
qtdemux: fix stream time conversion

Use the right macro to convert to the correct scale or the
segment information will be wrong

https://bugzilla.gnome.org/show_bug.cgi?id=742572

9 years agov4l2allocator: Add protection against driver bug
Nicolas Dufresne [Wed, 7 Jan 2015 23:48:58 +0000 (18:48 -0500)]
v4l2allocator: Add protection against driver bug

v4l2loopback driver has a this nasty bug that if the queue is larger
then 2 buffers, it returns random index on dqbuf. So far we assumed
that the index was always right, which would lead to memory being
unref twice, and eventually crash.

9 years agov4l2: Don't use allocator size to iterate
Nicolas Dufresne [Wed, 7 Jan 2015 22:58:05 +0000 (17:58 -0500)]
v4l2: Don't use allocator size to iterate

As the buffer array is fixed size and small, it's safer to simply
use this static size to cleanup the buffers. This is also more
consistent with the rest. The associated method is no longer
required and can be dropped.

9 years agov4l2bufferpool: Don't clean buffer array in dispose
Nicolas Dufresne [Wed, 7 Jan 2015 22:55:14 +0000 (17:55 -0500)]
v4l2bufferpool: Don't clean buffer array in dispose

This should already have been done, plus this code is incorrect
and may lead to crash.

https://bugzilla.gnome.org/show_bug.cgi?id=742074

9 years agov4l2bufferpool: Don't ref queued output buffer
Nicolas Dufresne [Wed, 7 Jan 2015 22:48:31 +0000 (17:48 -0500)]
v4l2bufferpool: Don't ref queued output buffer

This partly revert to the old 1.2 behavior. Instead of keeping a
reference to the output buffer queued, we simply release them but
don't forward it to GstBufferPool. This way, the buffer pool don't
need to be flushed to be stopped.

https://bugzilla.gnome.org/show_bug.cgi?id=742074

9 years agov4l2bufferpool: Never fail on streamoff
Nicolas Dufresne [Thu, 8 Jan 2015 16:37:23 +0000 (11:37 -0500)]
v4l2bufferpool: Never fail on streamoff

Failing streamoff prevents allocator from being disposed hence
lead to device FD leak. There is no known cases where streamoff
may fails for which we'd still be streaming. streamoff is known
to fail when a device is being unplugged (in which case errno
19/ENODEV is set).

https://bugzilla.gnome.org/show_bug.cgi?id=732734

9 years agov4l2: Add support for detecting the presence of V4L2 support on OpenBSD
Brad Smith [Thu, 8 Jan 2015 02:52:17 +0000 (21:52 -0500)]
v4l2: Add support for detecting the presence of V4L2 support on OpenBSD

https://bugzilla.gnome.org/review?bug=742503

9 years agoac3parse: request at least 8 bytes to properly parse header
Matej Knopp [Sun, 4 Jan 2015 14:57:10 +0000 (15:57 +0100)]
ac3parse: request at least 8 bytes to properly parse header

https://bugzilla.gnome.org/show_bug.cgi?id=742325

9 years agowavparse: skip an additional uninteresting chunk type before the fmt chunk.
Michael Smith [Thu, 8 Jan 2015 00:20:03 +0000 (16:20 -0800)]
wavparse: skip an additional uninteresting chunk type before the fmt chunk.

9 years agoaudiodynamic: assert func_index is inside bounds
Luis de Bethencourt [Wed, 7 Jan 2015 18:16:12 +0000 (18:16 +0000)]
audiodynamic: assert func_index is inside bounds

Bringing back the check removed in the previous commit but have that check be a
g_assert. Changing the function to static void since return can never be False,
because audio format will never be unkown.

9 years agoaudiodynamic: remove always-true conditional
Luis de Bethencourt [Wed, 7 Jan 2015 17:31:39 +0000 (17:31 +0000)]
audiodynamic: remove always-true conditional

func_index is set by the sum of three ternary operators which add, 0:4, 0:2,
and 1:0. Minimum value would be 0+0+0=0, and maximum would be 4+2+1=7.
The conditional checking if func_index is >= 0 and < 8 will always be true.
Removing it.

CID 1226442

9 years agortpjitterbuffer: If we get a gap with a buffer without DTS, error out
Sebastian Dröge [Wed, 7 Jan 2015 17:05:18 +0000 (18:05 +0100)]
rtpjitterbuffer: If we get a gap with a buffer without DTS, error out

We (currently?) can't really handle gaps between RTP packets if they're not
properly timestamped. The current code would go into calculations with
GST_CLOCK_TIME_NONE and then cause assertions everywhere. It's probably
better to error out cleanly instead.

9 years agortspsrc: set PLAYING state after configuring caps
Aleix Conchillo Flaqué [Fri, 21 Nov 2014 19:39:19 +0000 (11:39 -0800)]
rtspsrc: set PLAYING state after configuring caps

We set to PLAYING after we have configured the caps, otherwise we
might end up calling request_key (with SRTP) while caps are still
being configured, ending in a crash.

https://bugzilla.gnome.org/show_bug.cgi?id=740505

9 years agotests: gdkpixbufoverlay-test: remove outdated FIXME
Tim-Philipp Müller [Tue, 30 Dec 2014 18:03:22 +0000 (18:03 +0000)]
tests: gdkpixbufoverlay-test: remove outdated FIXME

9 years agotests: rtpcollision: use alawenc/dec in these tests instead of Speex
Tim-Philipp Müller [Tue, 30 Dec 2014 17:19:42 +0000 (17:19 +0000)]
tests: rtpcollision: use alawenc/dec in these tests instead of Speex

They should always be built, while the speex elements are not.

Need to check for a smaller number of buffers then (7->4) because
speexenc will add 3 header buffers while alawenc will just output
as many buffers as it receives as input.

https://bugzilla.gnome.org/show_bug.cgi?id=742098

9 years agotests: simple-launch-lines: only run jpeg/png tests if elements are available
Tim-Philipp Müller [Tue, 30 Dec 2014 16:36:02 +0000 (16:36 +0000)]
tests: simple-launch-lines: only run jpeg/png tests if elements are available

9 years agosouphttpsrc: Don't return a buffer when returning not GST_FLOW_OK
Sebastian Dröge [Tue, 30 Dec 2014 15:26:58 +0000 (16:26 +0100)]
souphttpsrc: Don't return a buffer when returning not GST_FLOW_OK

basesrc assumes that we don't return a buffer if
something else than OK is returned. It will just
leak any buffer we might accidentially provide
here.

This can potentially happen during flushing.

Maybe fixes https://bugzilla.gnome.org/show_bug.cgi?id=741993

9 years agotests: rtpaux: use alawenc/dec in these tests instead of Speex
Tim-Philipp Müller [Tue, 30 Dec 2014 14:52:42 +0000 (14:52 +0000)]
tests: rtpaux: use alawenc/dec in these tests instead of Speex

They should always be built, while the speex elements are not.

https://bugzilla.gnome.org/show_bug.cgi?id=742098

9 years agomatroskademux: Improve detection of being stuck at the same offset
Sebastian Dröge [Mon, 29 Dec 2014 14:35:19 +0000 (15:35 +0100)]
matroskademux: Improve detection of being stuck at the same offset

Only error out if we read from the same position again and got the
same length. Just the same position is not necessarily enough.

9 years agomatroskademux: Don't get stuck at the same offset when searching for clusters
Sebastian Dröge [Mon, 29 Dec 2014 14:00:02 +0000 (15:00 +0100)]
matroskademux: Don't get stuck at the same offset when searching for clusters

This could happen if there is an invalid cluster with size 0, and in that
case just error out instead of looping forever.

9 years agoqtmux: fix ALAC muxing
Tim-Philipp Müller [Thu, 25 Dec 2014 21:32:40 +0000 (21:32 +0000)]
qtmux: fix ALAC muxing

Actually copy the codec data instead of copying nothing
and then bombing out because there's no data.

Fixes: gst-launch-1.0 audiotestsrc ! avenc_alac ! qtmux ! fakesink

https://bugzilla.gnome.org/show_bug.cgi?id=741783

9 years agortpptdemux: just drop invalid rtp packets instead of erroring out
Tim-Philipp Müller [Thu, 25 Dec 2014 15:48:04 +0000 (15:48 +0000)]
rtpptdemux: just drop invalid rtp packets instead of erroring out

Apparently linphone sends an invalid RTP packet as very
first packet. We want to ignore that instead of erroring
out (same for any other invalid packets really).

https://bugzilla.gnome.org/show_bug.cgi?id=741398

9 years agortpptdemux: fix 0.10-ism in docs
Tim-Philipp Müller [Thu, 25 Dec 2014 15:44:15 +0000 (15:44 +0000)]
rtpptdemux: fix 0.10-ism in docs

9 years agotests: gdkpixbufoverlay-test: use absolute positioning to fix demo
Tim-Philipp Müller [Thu, 25 Dec 2014 14:58:12 +0000 (14:58 +0000)]
tests: gdkpixbufoverlay-test: use absolute positioning to fix demo

https://bugzilla.gnome.org/show_bug.cgi?id=739566

9 years agogdkpixbufoverlay: add "positioning-mode" property to allow absolute positions
Tim-Philipp Müller [Thu, 25 Dec 2014 14:53:09 +0000 (14:53 +0000)]
gdkpixbufoverlay: add "positioning-mode" property to allow absolute positions

Set positioning-mode=pixels-absolute to allow positioning with
absolute coordinates, meaning negative x/y offsets will be
interpreted as being to the left/above the video frame instead
of being interpreted as relative to the right/bottom edge of
the video frame (which is a silly default, but that's how it is).

This means we can nicely slide images into and out of the frame,
see gdkpixbufoverlay-test.

https://bugzilla.gnome.org/show_bug.cgi?id=739566

9 years agoosxaudio: Directly return the ringbuffer's caps if it is acquired
Sebastian Dröge [Mon, 22 Dec 2014 14:33:51 +0000 (15:33 +0100)]
osxaudio: Directly return the ringbuffer's caps if it is acquired

9 years agoosxaudio: Put all audio formats into the template caps
Sebastian Dröge [Mon, 22 Dec 2014 11:56:19 +0000 (12:56 +0100)]
osxaudio: Put all audio formats into the template caps

We report the proper caps later from the get_caps() vfunc implementation after
probing the selected device.

9 years agoosxaudio: Also set the big endian flag for floating point samples
Sebastian Dröge [Mon, 22 Dec 2014 11:56:05 +0000 (12:56 +0100)]
osxaudio: Also set the big endian flag for floating point samples

9 years agoMAINTAINERS: Update my mail address
Sebastian Dröge [Mon, 22 Dec 2014 10:45:59 +0000 (11:45 +0100)]
MAINTAINERS: Update my mail address

9 years agoosxaudio: Fix deadlock and property change notification in device selection code
Sebastian Dröge [Mon, 22 Dec 2014 09:23:01 +0000 (10:23 +0100)]
osxaudio: Fix deadlock and property change notification in device selection code

After creating the ringbuffer we have to set the device on the ringbuffer as
it defaults to kAudioDeviceUnknown. At this point it can't have changed to
anything else yet and we don't have to notify about changes to the sink/src
"device" property. It's also not a good idea because GstAudioBaseSrc has the
object lock taken while the ringbuffer is created, which might cause a
deadlock if something calls back into the element from "notify::device".

Once the base class is done with the NULL_TO_READY state change, it has opened
the device via the ringbuffer and this might have chosen a different device.
Especially if we initially used kAudioDeviceUnknown. Also notify about this
property change as initially intended by this code.

9 years agov4l2pool: Update configuration size
Nicolas Dufresne [Fri, 19 Dec 2014 17:30:03 +0000 (12:30 -0500)]
v4l2pool: Update configuration size

We already update our copy of VideoInfo.size to proper size, now also
the configuration so the size matches on release.

https://bugzilla.gnome.org/show_bug.cgi?id=741420

9 years agomatroska-demux: Cache upstream length
Edward Hervey [Fri, 19 Dec 2014 09:57:29 +0000 (10:57 +0100)]
matroska-demux: Cache upstream length

Instead of constantly querying upstream, just cache the last duration,
and in the unlikelyness we might have gone over query again before
deciding we are EOS.

Cut 15% cpu off matroskademux streaming thread (srsly...)

9 years agomatroska: mux/demux the OpusHead header
Vincent Penquerc'h [Wed, 17 Dec 2014 17:36:18 +0000 (17:36 +0000)]
matroska: mux/demux the OpusHead header

This is meant to be so (https://wiki.xiph.org/MatroskaOpus - while
it is marked as a draft, this part was confirmed to be correct on
IRC), and allows one to determine whether a demuxed stream is
multistream or not, and thus set the multistream caps field
accordingly. In turn, this means downstream does not have to guess.

https://bugzilla.gnome.org/show_bug.cgi?id=740744

9 years agortspsrc: Don't dereference NULL if a suitable stream for the AUX element can't be...
Sebastian Dröge [Thu, 18 Dec 2014 10:50:33 +0000 (11:50 +0100)]
rtspsrc: Don't dereference NULL if a suitable stream for the AUX element can't be found

CID 1258717

9 years agoAutomatic update of common submodule
Sebastian Dröge [Thu, 18 Dec 2014 09:53:39 +0000 (10:53 +0100)]
Automatic update of common submodule

From ef1ffdc to f2c6b95

9 years agoudpsink: allocate scratch space for render functions on the heap
Tim-Philipp Müller [Fri, 12 Dec 2014 23:06:07 +0000 (23:06 +0000)]
udpsink: allocate scratch space for render functions on the heap

and not the stack. Our allocations could get a bit too large
to be sure it's not going to cause trouble using the stack.

9 years agomultiudpsink: re-use send_buffers() code path for render() function
Tim-Philipp Müller [Tue, 24 Jun 2014 00:16:37 +0000 (01:16 +0100)]
multiudpsink: re-use send_buffers() code path for render() function

It's like rendering a buffer list, just with one buffer.
Has the added advantage that if there are multiple clients
we can send the buffer to all the clients in one go.

9 years agomultiudpsink: keep client list consistent during removals
Tim-Philipp Müller [Tue, 24 Jun 2014 00:15:25 +0000 (01:15 +0100)]
multiudpsink: keep client list consistent during removals

We unlock and re-lock the client lock while emitting the
removed signal, which causes inconsistencies in the client
list vs. the client counts. Instead, remove the client from
the list already before emitting the signal and put it into
a temporary list of clients to be removed. That way things
look consistent to the streaming thread, but signal callbacks
can still do things like get stats from removed clients.

9 years agomultiudpsink: fix client count after removal
Tim-Philipp Müller [Mon, 23 Jun 2014 23:56:27 +0000 (00:56 +0100)]
multiudpsink: fix client count after removal

9 years agomultiudpsink: keep client list sorted by socket family
Tim-Philipp Müller [Mon, 23 Jun 2014 17:43:21 +0000 (18:43 +0100)]
multiudpsink: keep client list sorted by socket family

We make use of in the send_buffers() function if we
need to use different sockets to send to IPv4 and
IPv6 destinations.

9 years agomultiudpsink: add sendmmsg-ready render_list function prototype
Tim-Philipp Müller [Fri, 20 Jun 2014 10:36:19 +0000 (11:36 +0100)]
multiudpsink: add sendmmsg-ready render_list function prototype

Add prototype for a render_list() function that can use a
sendmmsg-style g_socket_send_messages() function once it lands
in GLib. We can use this infrastructure to send multiple buffers
made up by multiple memories to multiple clients in one go, which
drastically reduces the number of syscalls made when sending
high-bitrate video streams.

https://bugzilla.gnome.org/show_bug.cgi?id=732152

9 years agomultiudpsink: make udp client structure refcounted
Tim-Philipp Müller [Thu, 19 Jun 2014 18:16:01 +0000 (19:16 +0100)]
multiudpsink: make udp client structure refcounted

Use the refcount for memory management and keep track
of the number of duplicate clients in a separate
variable. This will be useful later, and means we
don't have to hold the OBJECT_LOCK all the time.

https://bugzilla.gnome.org/show_bug.cgi?id=732866

9 years agomultiudpsink: keep count of number of unique and non-unique IPv4 and IPv6 clients
Tim-Philipp Müller [Thu, 19 Jun 2014 17:31:05 +0000 (18:31 +0100)]
multiudpsink: keep count of number of unique and non-unique IPv4 and IPv6 clients

This will come in handy later.

9 years agov4l2bufferpool: Disable create_buf with libv4l2
Nicolas Dufresne [Tue, 16 Dec 2014 20:00:22 +0000 (15:00 -0500)]
v4l2bufferpool: Disable create_buf with libv4l2

Libv4l2 does not work with CREATE_BUFS. Instead of failing on random
error caused by libv4l2, disable CREATE_BUFS when an emulated format is
detected.

9 years agov4l2allocator: Add protection against broken libv4l2
Nicolas Dufresne [Tue, 9 Dec 2014 22:39:12 +0000 (17:39 -0500)]
v4l2allocator: Add protection against broken libv4l2

It looks like libv4l2 support for CREATE_BUF is incomplete. That
combine with existing bugs may lead to crash in GStreamer. These
check will make it robust by:

- Checking create buf index isn't an already in used index
- Checking that the index out of QUERYBUF matches the requested
  index

9 years agortspsrc: Add something to the debug logs if an RTX AUX element can't be added
Sebastian Dröge [Tue, 16 Dec 2014 15:37:24 +0000 (16:37 +0100)]
rtspsrc: Add something to the debug logs if an RTX AUX element can't be added

... because the application already has a signal handler set up here.

9 years agortspsrc: add retransmission support according to RFC4588
Matthew Waters [Fri, 21 Nov 2014 03:13:34 +0000 (14:13 +1100)]
rtspsrc: add retransmission support according to RFC4588

Based on the client-rtpaux example

9 years agoosxvideosink: clear rectangle structures before use
Wim Taymans [Tue, 16 Dec 2014 12:25:01 +0000 (13:25 +0100)]
osxvideosink: clear rectangle structures before use

9 years agov4l2object: Always set format
Nicolas Dufresne [Tue, 9 Dec 2014 20:09:56 +0000 (15:09 -0500)]
v4l2object: Always set format

Right now we try to be clever by detecting if device format have
changed or not, and skip setting format in this case. This is valid
behaviour with V4L2, but it's also very error prone. The rational
for not setting these all the time is for speed, though I can't
measure any noticeable gain on any HW I own. Also, until recently,
we where doing get/set on the format for each format we where
probing, making it near to impossible that the format would match.
This also fixes bug where we where skipping frame-rate setting if
format didn't change.

https://bugzilla.gnome.org/show_bug.cgi?id=740636

9 years agovideocrop: Remove todo about caps filter
Nicolas Dufresne [Mon, 15 Dec 2014 23:30:01 +0000 (18:30 -0500)]
videocrop: Remove todo about caps filter

The filter is already interected.

9 years agovideocrop: Make sure new crop is applied
Nicolas Dufresne [Mon, 15 Dec 2014 23:19:05 +0000 (18:19 -0500)]
videocrop: Make sure new crop is applied

Since "basetransform: Fix caps equality check" commit a7f357,
set_info() will not be called anymore if crop didn't change
the caps. This is fixed by setting "need_update" boolean when
cropping properties has been changed, and then applying these
if they where not applied before rendering the next frame. This
patch also fixed the locking, dropping un-needed custom lock,
and no holding needless lock while doing the operation as we
already hold the streaming lock.

https://bugzilla.gnome.org/show_bug.cgi?id=740787

9 years agoosxaudiosink: Prefer filter caps order while getting caps
Arun Raghavan [Fri, 12 Dec 2014 12:40:35 +0000 (18:10 +0530)]
osxaudiosink: Prefer filter caps order while getting caps

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudiosink: Add some error handling around channel layout parsing
Arun Raghavan [Tue, 9 Dec 2014 08:08:26 +0000 (13:38 +0530)]
osxaudiosink: Add some error handling around channel layout parsing

For now we just spit a warning and ignore the channel layout if we can't
support it.

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudio: Take lock around sink/source before accessing the ringbuffer
Arun Raghavan [Mon, 8 Dec 2014 17:08:22 +0000 (22:38 +0530)]
osxaudio: Take lock around sink/source before accessing the ringbuffer

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudiosrc: Probe channel layout too
Arun Raghavan [Mon, 1 Dec 2014 15:36:27 +0000 (21:06 +0530)]
osxaudiosrc: Probe channel layout too

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudiosink: Only fix up channels/layout for PCM caps while probing
Arun Raghavan [Mon, 1 Dec 2014 15:02:04 +0000 (20:32 +0530)]
osxaudiosink: Only fix up channels/layout for PCM caps while probing

It's unlikely that setting a channel layout will do much for AC3/DTS
streams. If we find at some point that it does make sense, we can
perform the structure copying unconditionally (i.e., the current code is
wrong, since AC3/DTS will get two structures now - one with the channel
layout, one without).

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudiosrc: Implement caps probing
Arun Raghavan [Mon, 1 Dec 2014 14:11:35 +0000 (19:41 +0530)]
osxaudiosrc: Implement caps probing

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudio: Bind audio device to audio unit early
Arun Raghavan [Mon, 1 Dec 2014 13:59:57 +0000 (19:29 +0530)]
osxaudio: Bind audio device to audio unit early

We want to bind the device during open so that subsequent format queries
on the audio unit are as specific as possible from that point onwards.

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudiosink: Fix up caps querying a bit
Arun Raghavan [Sat, 29 Nov 2014 17:46:30 +0000 (23:16 +0530)]
osxaudiosink: Fix up caps querying a bit

This should make caps queries correct in PAUSED and higher as well.

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudio: Move osxaudiosrc-specific code out of the generic path
Arun Raghavan [Fri, 28 Nov 2014 17:02:36 +0000 (22:32 +0530)]
osxaudio: Move osxaudiosrc-specific code out of the generic path

Avoids one layering violation (GstCoreAudio referring to
GstOsxAudioSrc).

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudio: Clean up a GstCoreAudio -> GstOsxAudioSrc/Sink reference
Arun Raghavan [Fri, 28 Nov 2014 16:53:17 +0000 (22:23 +0530)]
osxaudio: Clean up a GstCoreAudio -> GstOsxAudioSrc/Sink reference

Now that device selection has no sink/source-specific bits, we can have
generic device selection for this path. We do need to now track state
changes so we can look up the final device_id once the device is open,
though.

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudiosink: Move device caps probing to get_caps()
Arun Raghavan [Fri, 28 Nov 2014 14:10:52 +0000 (19:40 +0530)]
osxaudiosink: Move device caps probing to get_caps()

This should be preferred to running the probe at device open time.

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudio: Make some debug code compile conditionally
Arun Raghavan [Fri, 28 Nov 2014 13:07:02 +0000 (18:37 +0530)]
osxaudio: Make some debug code compile conditionally

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudio: Move device selection to ringbuffer->open_device()
Arun Raghavan [Fri, 28 Nov 2014 09:36:35 +0000 (15:06 +0530)]
osxaudio: Move device selection to ringbuffer->open_device()

This is conceptually the right thing to do, and allows us to correctly
catch errors in device selection as well, which we could not do while
creating the ringbuffer.

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoosxaudio: Consolidate input and output code paths a bit
Arun Raghavan [Fri, 28 Nov 2014 09:04:34 +0000 (14:34 +0530)]
osxaudio: Consolidate input and output code paths a bit

https://bugzilla.gnome.org/show_bug.cgi?id=740987

9 years agoDeinterlace: in query_caps return only supported formats if filter is interlaced
Thibault Saunier [Fri, 21 Nov 2014 10:54:18 +0000 (11:54 +0100)]
Deinterlace: in query_caps return only supported formats if filter is interlaced

In some cases the currently set GstVideoInfo is not interlaced, but
upstream caps are interlaced and the info is passed in the filter,
we should take that info into account and make sure that we do not
consider that case as a "pass through" case.

https://bugzilla.gnome.org/show_bug.cgi?id=741407

9 years agoqtdemux: Fix debug statement
Edward Hervey [Fri, 12 Dec 2014 10:06:17 +0000 (11:06 +0100)]
qtdemux: Fix debug statement

It was using the non-increasing offset variable, which made that statement
not so useful :)

9 years agoqtdemux: Add macros for the various timescale conversions
Edward Hervey [Fri, 12 Dec 2014 10:03:15 +0000 (11:03 +0100)]
qtdemux: Add macros for the various timescale conversions

This helps make the code more readable and avoid future bad usage of
scaling function argument order.

9 years agortph264pay: fix potential crash when shutting down
Patrick Radizi [Thu, 11 Dec 2014 09:16:06 +0000 (10:16 +0100)]
rtph264pay: fix potential crash when shutting down

A race condition in the state change function may cause buffers
to be unreffed while they are still used by the streaming thread
in gst_rtp_h264_pay_send_sps_pps() resulting in a crash. Chain
up to the parent class first in the state change function to
make sure streaming has stopped and only then free those buffers.

https://bugzilla.gnome.org/show_bug.cgi?id=741381

9 years agoqtdemux: Copy flags of the overall segment to output segments
Jan Schmidt [Thu, 11 Dec 2014 13:42:06 +0000 (00:42 +1100)]
qtdemux: Copy flags of the overall segment to output segments

Preserve the segment flags of the overall demux segment on the output
segments for each pad.

9 years agoqtmux: use 64bit chunk_offset
Matej Knopp [Tue, 9 Dec 2014 01:43:00 +0000 (02:43 +0100)]
qtmux: use 64bit chunk_offset

https://bugzilla.gnome.org/show_bug.cgi?id=741279

9 years agoqtdemux: Fix rounding errors in duration update
Edward Hervey [Wed, 10 Dec 2014 16:39:17 +0000 (17:39 +0100)]
qtdemux: Fix rounding errors in duration update

Make sure we store updated segment stop/duration with the same
granularity as the duration timescale.

And add more debug

9 years agoqtdemux: Update duration when we get more information
Edward Hervey [Wed, 10 Dec 2014 15:55:44 +0000 (16:55 +0100)]
qtdemux: Update duration when we get more information

When dealing with fragmented files, we will get more accurate duration
information via the mfra and moof atoms.

In order for playback to not stop at the initial duration (from the
moov atom), we need to check and update the various duration variables
when we find more information.

Fixes playback of fragmented files in pull mode

9 years agoqtdemux: Remove variable assignments never read
Edward Hervey [Wed, 10 Dec 2014 14:08:40 +0000 (15:08 +0100)]
qtdemux: Remove variable assignments never read

As detected by clang/scan-build

9 years agoqtdemux: Use GstClockTime for nanosecond-based time variables/fields
Edward Hervey [Wed, 10 Dec 2014 13:56:06 +0000 (14:56 +0100)]
qtdemux: Use GstClockTime for nanosecond-based time variables/fields

Avoids confusion with timescaled-based variables and bytes (offset)
variables.
And use GST_CLOCK_TIME_NONE where applicable

9 years agopushfilesrc: Add TIME SEGMENT capability
Edward Hervey [Wed, 3 Dec 2014 13:47:05 +0000 (14:47 +0100)]
pushfilesrc: Add TIME SEGMENT capability

Adds a new set of properties to make pushfilesrc output a TIME SEGMENT
(instead of the filesrc BYTE SEGMENT).

When time-segment is set to True the following will happen:
* Seeks are refused (data starts from the beginning of the file)
* The BYTE segment will be replaced by a TIME segment with the values
  specified in the various properties
* The first outgoing buffer will have a timestamp set on it (by default
  it has a value of GST_CLOCK_TIME_NONE)

9 years agoaacparse: Also only unref caps if they're not NULL
Sebastian Dröge [Wed, 10 Dec 2014 10:35:29 +0000 (11:35 +0100)]
aacparse: Also only unref caps if they're not NULL

9 years agoaacparse: gst_pad_get_allowed_caps() will return NULL if there is no peer
Sebastian Dröge [Wed, 10 Dec 2014 10:34:42 +0000 (11:34 +0100)]
aacparse: gst_pad_get_allowed_caps() will return NULL if there is no peer

9 years agovpXenc: CLOCK_TIME_NONE is not a valid min_latency value
Thibault Saunier [Tue, 9 Dec 2014 15:38:38 +0000 (16:38 +0100)]
vpXenc: CLOCK_TIME_NONE is not a valid min_latency value

We should just use 0 if we do not have the information

9 years agortpsession: Use an empty iterator in iterate_internal_link when no links
Thibault Saunier [Wed, 3 Dec 2014 16:26:56 +0000 (17:26 +0100)]
rtpsession: Use an empty iterator in iterate_internal_link when no links

And not a NULL Iterator, so it is consistent with the way it usually
works and avoid user to need a different code paths to handle that.

9 years agov4l2bufferpool: set buffer interlace flags when field is V4L2_FIELD_INTERLACED
Aurélien Zanelli [Tue, 9 Dec 2014 13:01:50 +0000 (14:01 +0100)]
v4l2bufferpool: set buffer interlace flags when field is V4L2_FIELD_INTERLACED

If v4l2_buffer.field is V4L2_FIELD_INTERLACED, we set corresponding
GstVideoBuffer flags depending on the video standard.
According to V4L2 specification, M/NTSC transmits the bottom field
first, all other standards the top field first.

https://bugzilla.gnome.org/show_bug.cgi?id=737603

9 years agortph264pay: Fixes buffer leak when using SPS/PPS
Patrick Radizi [Mon, 8 Dec 2014 20:26:18 +0000 (21:26 +0100)]
rtph264pay: Fixes buffer leak when using SPS/PPS

Fixes a buffer leak that would occurr if the pipeline was shutdown
while a SPS/PPS header was being created.

https://bugzilla.gnome.org/show_bug.cgi?id=741271

9 years agoagingtv: fix memcpy when no color aging requested.
Mathieu Duponchelle [Tue, 9 Dec 2014 03:43:29 +0000 (04:43 +0100)]
agingtv: fix memcpy when no color aging requested.

video_size is the size in pixels, actual size of the memcpy
has to be stride * height.

9 years agov4l2: Workaround libv4l2 RW emulation bug
Nicolas Dufresne [Sun, 7 Dec 2014 22:33:51 +0000 (17:33 -0500)]
v4l2: Workaround libv4l2 RW emulation bug

When libv4l2 emulates RW mode on top of MMAP devices, the queues are
only initialized on first read. The problem is that poll() will fail
if called before the queues are initialized and streaming. Workaround
this by doing a zero size read when pool is started in that IO mode.

https://bugzilla.gnome.org/show_bug.cgi?id=740633