Chih-Hung Hsieh [Tue, 10 Oct 2017 19:20:23 +0000 (12:20 -0700)]
Use -Werror in external/deqp
Bug:
66996870
Test: build with WITH_TIDY=1
Change-Id: I8b711d0fdfcf5241dc1b7754a8be5fbd712d555f
Chris Forbes [Tue, 3 Oct 2017 22:23:11 +0000 (22:23 +0000)]
Disable some UBO tests which got broken by recent glslang change
am:
d81d8e2af7
Change-Id: I1dadbabb85dfe7ecb5da296acb84a91538521e3e
Chris Forbes [Tue, 3 Oct 2017 17:17:59 +0000 (10:17 -0700)]
Disable some UBO tests which got broken by recent glslang change
Bug: b/
67013571
Change-Id: I54c3f9aba636381a57e398de603b09dad4d14188
Mika Isojärvi [Thu, 28 Sep 2017 17:25:24 +0000 (10:25 -0700)]
Update owners file
Test: build/make/tools/checkowners.py -c -v OWNERS
Change-Id: I117459d91f39055aaa5f0bc6abfbda32f31cdab2
Emil Velikov [Wed, 30 Aug 2017 14:12:14 +0000 (15:12 +0100)]
Use hidden visibility with GCC and Clang
The final result of the build are standalone executables, with all the
code statically linked.
Change the visibility to hidden, to avoid the symbol leakage and allow
the compiler to discard some code.
As a result the binary size is drastically decreased.
Total executable size on my setup drops by ~20%
158M before
128M after
Note: The binaries still export multiple unneeded symbols. Resolving
those is left as an exercise for later.
Test: full rebuild, running resulting binaries.
Change-Id: Ife10bbd123d59f4480349794785f13978516df30
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Mika Isojärvi [Fri, 8 Sep 2017 19:36:34 +0000 (12:36 -0700)]
Add missing JNIEXPORT and JNICALL to createTestActivity() JNI call
Test: Ran internal deqp tests on couple of Google devices
Change-Id: I08c8ff0a040261aaf60fa761158a12cccff987c2
Mika Isojrvi [Fri, 22 Sep 2017 20:18:06 +0000 (20:18 +0000)]
Fix missing SSBO binding in EGL robustness tests
am:
645b470b61
Change-Id: Iead5688ac950b539338d12f5d67d7fdf721e2425
Mika Isojrvi [Fri, 22 Sep 2017 20:18:04 +0000 (20:18 +0000)]
Fix unused uniform bug in EGL robustness tests
am:
cd1ec788ec
Change-Id: If01714db26cabd3b12d6d1bac7d7cf32ce3ad381
Michael Chock [Fri, 22 Sep 2017 20:17:44 +0000 (20:17 +0000)]
Do not use degenerate frames in EGL tests
am:
8adce77ee5
Change-Id: If6e08077865264ff25bdf05a494f1d6e1799ba22
Mika Isojrvi [Fri, 22 Sep 2017 20:17:38 +0000 (20:17 +0000)]
Exclude mutable image tests from Android CTS
am:
ae838ac1c9
Change-Id: Iaee028a392f31f0af0b069ce1bf0dcd980bcbf3a
Mika Isojärvi [Fri, 22 Sep 2017 17:39:21 +0000 (10:39 -0700)]
resolve merge conflicts of
9b726ab8 to master
Test: Ran scripts/check_build_sanity.py build Android CTS.
Change-Id: Ibc797d43c71edee9a82592369f30d6a72bfcde2f
Mika Isojärvi [Thu, 31 Aug 2017 18:54:48 +0000 (11:54 -0700)]
Fix missing SSBO binding in EGL robustness tests
Bug:
64845581
Bug:
65175642
Test: Ran the tests on couple of Google devices
Change-Id: I3a98fe12802e6951483499e800cd3fe7412e37f0
Mika Isojärvi [Thu, 31 Aug 2017 19:13:05 +0000 (12:13 -0700)]
Fix unused uniform bug in EGL robustness tests
Bug:
64845766
Bug:
65175554
Test: Ran tests on couple of Google devices
Change-Id: Iee2918c1e45ad305dd9ca30f1b81998bdac06127
Michael Chock [Mon, 14 Aug 2017 18:55:14 +0000 (11:55 -0700)]
Do not use degenerate frames in EGL tests
The dEQP-EGL.functional.buffer_age.* and
dEQP-EGL.functional.partial_update.* tests use randomly-generated frames
for rendering. The test allows the generation of frames with a width or
height of 0, but the tcu::PixelBufferAccess interface does not permit
0-sized subregions (see assertions inside getSubregion overloads in
tcuTextureUtil.cpp).
Skip the rendering of degenerate frames in the reference renderer, as
they are unsupported but would not affect the rendering if they were.
Bug:
65317274
Test: Ran tests on couple of Google devices
Change-Id: I3977c3c293715db633dde74132e56b5d9303ab28
Mika Isojärvi [Mon, 18 Sep 2017 20:27:19 +0000 (13:27 -0700)]
Exclude mutable image tests from Android CTS
Bug:
65844886
Test: Ran scripts/check_build_sanity.py
Change-Id: Ia779ed1e9c3339f0e4ddb599647284c15f1aeaaf
Tapani Pälli [Mon, 18 Sep 2017 10:31:04 +0000 (13:31 +0300)]
fix a copy-paste error in wide_color tests
Change "10:10:10:2" to "16:16:16:16" in checkFP16Support print out.
Change-Id: Id3eb25ed4f72b08fc1465af786177175579490ce
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Mika Isojärvi [Fri, 15 Sep 2017 21:15:20 +0000 (14:15 -0700)]
Merge Vulkan CTS 1.0.2.6 into aosp/oreo-cts-dev
Bug:
65677277
Test: Run Android CTS deqp tests
Change-Id: I2ffb7d3929448e721f8097f323eaab011b445d8b
Pyry Haulos [Thu, 14 Sep 2017 02:20:20 +0000 (02:20 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2
am:
6d0cee6923
Change-Id: I7155ee4dfca234f42d6cdd02ac65f65a6b10d504
Graeme Leese [Thu, 14 Sep 2017 02:20:00 +0000 (02:20 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am:
4f1051ad32 am:
b8e4ff4043 am:
a2d901c3d8 am:
2431a0b0d9 am:
5fe6ec300f am:
781a2ef1e0
am:
b85caaf64f
Change-Id: I1ef65460f3e67367b871e9b601401ba767c6c674
Graeme Leese [Thu, 14 Sep 2017 02:19:45 +0000 (02:19 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am:
4f1051ad32 am:
5bd0fb31a1 am:
3558abf238 am:
222fa619e5 am:
37ce9a1ac7
am:
1801be75eb
Change-Id: I7753a883d40e28eb6020218ee3ac1944d3f8d974
Kalle Raita [Thu, 14 Sep 2017 02:19:26 +0000 (02:19 +0000)]
CP: Add triangle edge guardband for Tex2D lookup diff
am:
e345d7b6ba
Change-Id: I1d52d5d5d0cb5b1c53de7fc43e27f526680608e5
Mika Isojrvi [Thu, 14 Sep 2017 02:19:10 +0000 (02:19 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898 am:
b426d8bfad am:
580f143209 am:
73a16f417e am:
550064261f am:
1b81ecf035 am:
68d441aedd am:
088fbbc341 am:
e3939224e7 am:
495df8aec0
am:
271d2c56f9
Change-Id: I0a239959cda4fce12548f79b20fe12a12519320c
Mika Isojrvi [Thu, 14 Sep 2017 02:18:56 +0000 (02:18 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898 am:
14cd264501 am:
6e80057a20 am:
cae1fe52ac am:
754e8f0192 am:
d422ad8111 am:
a8804ca914
am:
802854925b
Change-Id: I1be013ce9a238f81e973ecff1eac9ad45dfaaa44
Mika Isojrvi [Thu, 14 Sep 2017 02:18:38 +0000 (02:18 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898 am:
14cd264501 am:
d4c01761d3 am:
d20475d813 am:
66bd71c817 am:
c06d76b076
am:
5e5d57c9d9
Change-Id: Ia837c1a5524aa4935fefcf015f3f832aba1e739e
Mika Isojrvi [Thu, 14 Sep 2017 02:18:18 +0000 (02:18 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a am:
4d1d6446da am:
b78f9b0e57 am:
c2180f74a8 am:
76b48a0db2 am:
ff2205c90c
am:
bde0d133a4
Change-Id: Id371d2842d97e3f5d3d52d2b107e8e3d74b80719
Mika Isojrvi [Thu, 14 Sep 2017 02:18:01 +0000 (02:18 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a am:
4d1d6446da am:
6c0e0ebde7 am:
371f033807 am:
e64be738f6 am:
a242f668a7 am:
7ed7199caf
am:
a921fc5252
Change-Id: I0825b4f59d2fbc8485ff24f6eec748757e7f8f09
Mika Isojrvi [Thu, 14 Sep 2017 02:17:29 +0000 (02:17 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a am:
e37b18673d am:
97ce4c6f8c am:
4c56c58687 am:
0ddc9faea1 am:
d2d7d49296 am:
301312d147 am:
4dd9680c5d am:
bf288e2971 am:
1678011b33
am:
14f0575d74
Change-Id: I0e0ae598f390c38b1d57cb83d161ab6921020168
Courtney Goeltzenleuchter [Tue, 12 Sep 2017 23:11:21 +0000 (17:11 -0600)]
Catch BAD_MATCH from createWindowSurface
On some platforms, it's possible to fail createWindowSurface
for some attribute combinations. Catch that case and return
NotSupported rather than a test failure.
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Bug:
65376495
Change-Id: I6546cbdfc011c7d26cfa3cdad7cc6f0df1b67122
Courtney Goeltzenleuchter [Tue, 12 Sep 2017 23:10:51 +0000 (17:10 -0600)]
Require EGL_KHR_gl_colorspace for wide_color tests
These tests utilize enum EGL_GL_COLORSPACE_KHR which is introduced by
EGL_KHR_gl_colorspace extension, check first for support and skip the
test if extension is not supported.
v2: loosen the check, only check when enum in use (Courtney)
v3: use EGL_NONE instead of DE_NULL when indicating that test
should use the default colorspace. That is do not include
the EGL_GL_COLORSPACE_KHR attribute in the appropriate
create function.
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Bug:
65291400
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
(cherry picked from commit
fbf132dcf9467388408627bee73d90f7e8a1d401)
Change-Id: I6bd6423e6eb5fe4bb4df0222ab624c41446b0b60
Tony Wasserka [Tue, 12 Sep 2017 11:03:13 +0000 (12:03 +0100)]
Check for depthBounds support in shader builtin frag depth tests
Depth bounds testing was enabled without checking for feature support
in a couple of tests. With this change, tests that don't need this
feature leave it disabled, whereas other tests (currently only
dEQP-VK.glsl.builtin_var.fragdepth.*) now throw NotSupported when
the device doesn't support it.
Affects:
dEQP-VK.clipping.*
dEQP-VK.glsl.builtin_var.*
Components: Vulkan
VK-GL-CTS issue: 685
Change-Id: I44d94142e295ff135ad1a55d0d6e212b65994257
Courtney Goeltzenleuchter [Mon, 11 Sep 2017 19:06:48 +0000 (13:06 -0600)]
Fix handling of EGL_NONE as color space
Color space of EGL_NONE was getting passed down and
driver threw EGL_BAD_ATTRIBUTE in response.
Issue was caused when changing the colorspace from nullptr
to EGL_NONE, missed a couple of places that needed to
test against EGL_NONE instead of nullptr.
Bug:
65376495
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Change-Id: If8812725be9d3858bf610c647ba53ff38944dd50
(cherry picked from commit
0d4e616c35fd3cbad82eb3c1f0a604dbbc6c8662)
Treehugger Robot [Mon, 11 Sep 2017 19:30:30 +0000 (19:30 +0000)]
Merge changes Id437e220,I9d6b3fba
* changes:
Allow ES 3.2 contexts to run sRGB write control unsupported test.
Require GL_EXT_sRGB_write_control for GL_FRAMEBUFFER_SRGB enable/disable
Treehugger Robot [Mon, 11 Sep 2017 18:58:52 +0000 (18:58 +0000)]
Merge "Use 64-bit math in work group size assertion."
Treehugger Robot [Mon, 11 Sep 2017 18:57:22 +0000 (18:57 +0000)]
Merge "Delete incorrect invalid map tests."
Kenneth Graunke [Sat, 9 Sep 2017 06:30:15 +0000 (23:30 -0700)]
Allow ES 3.2 contexts to run sRGB write control unsupported test.
GL_EXT_sRGB_write_control functionality is not part of ES 3.2.
So there's no need to restrict this to older contexts.
Affects:
dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_unsupported_enum
Components: AOSP
Change-Id: Id437e220958c66acf65fd5c40004e1fde13fdf64
Kenneth Graunke [Sat, 9 Sep 2017 06:26:15 +0000 (23:26 -0700)]
Require GL_EXT_sRGB_write_control for GL_FRAMEBUFFER_SRGB enable/disable
This test required GL_EXT_sRGB_write_control or ES 3.2. But glEnable
and glDisable of GL_FRAMEBUFFER_SRGB requires the extension - ES 3.2
doesn't provide that functionality. ES 3.2 implementations without the
extension would fail. Now they report NotSupported.
Affects:
dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled
Components: AOSP
Change-Id: I9d6b3fba892288354620ecbbc51ef7a351507e43
Kenneth Graunke [Fri, 8 Sep 2017 22:37:38 +0000 (15:37 -0700)]
Delete incorrect invalid map tests.
The citation given in these tests comes from the OpenGL man pages, which
are not authoritative. The ES 3.2 specification says:
"6.3.2 Effects of Mapping Buffers on Other GL Commands
Any GL command which attempts to read from, write to, or change the
state of a buffer object may generate an INVALID_OPERATION error if
all or part of the buffer object is mapped. However, only commands
which explicitly describe this error are required to do so. If an
error is not generated, using such commands to perform invalid
reads, writes, or state changes will have undefined results and may
result in GL interruption or termination."
Importantly, it says "_may_ generate an INVALID_OPERATION error". Some
drivers choose not to implement this to avoid the CPU overhead required
to enforce this optional restriction.
Affects:
- dEQP-GLES31.functional.debug.negative_coverage.*.vertex_array.*_invalid_map
Components: AOSP
Change-Id: I26eb6ac0dfffbfc50612bed44d1beb6eb3d366c9
Treehugger Robot [Fri, 8 Sep 2017 21:25:48 +0000 (21:25 +0000)]
Merge "Relax EGL functional test thresholds"
Kenneth Graunke [Thu, 13 Jul 2017 01:44:11 +0000 (18:44 -0700)]
Use 64-bit math in work group size assertion.
If the maximum workgroup size in each dimension is large enough, this
can overflow, causing the comparison to fail. For example, on Intel
Haswell, we get:
assert(2048 * 2048 * 2048 > 2048) -> assert(0 > 2048) -> fail
Casting one value to deInt64 causes the multiplications to occur as
64-bit values, so we don't overflow.
Affects:
dEQP-GLES31.functional.debug.negative_coverage.*.compute.invalid_maximum_work_group_sizes
Components: AOSP
Change-Id: Ie03627a378f4fdc46ce241bbdd3693ae829c217d
james.glanville [Tue, 29 Aug 2017 10:40:53 +0000 (11:40 +0100)]
Relax EGL functional test thresholds
The current threshold of 0.02 was selected as suitable for 8-bit color depths.
However, for smaller bit depths such as RGB565 this threshold is too strict
and it has been relaxed to allow a larger error for low bit depth formats.
Affects:
dEQP-EGL.functional.render.*
Change-Id: I6d6e061be02bc8e63cb5d9662feb804bc839d567
Alexander Galazin [Fri, 8 Sep 2017 07:13:24 +0000 (09:13 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Change-Id: Ied1a7d639c56dbdffd3db89085b4b771741e43f7
Graeme Leese [Wed, 30 Aug 2017 15:37:14 +0000 (16:37 +0100)]
Change required sample counts for storage images
Update the API feature info tests to set requiredSampleCounts to 1 for
all images that are not usable as some type of framebuffer attachment.
Previously images that were not usable as attachments but could be used
as a storage image were incorrectly exempted from the requirement.
Components: Vulkan
VK-GL-CTS Issue: 645
Affects: dEQP-VK.api.info.image_format_properties.*
Change-Id: Ia0d09ad0ff51029b75cd3a264860a3dd63c249fb
Boris Zanin [Thu, 7 Sep 2017 07:19:08 +0000 (09:19 +0200)]
Fix VK_KHR_maintenance2 extended_usage_bit tests
Due to test runs over uncompressed formats it cannot include
VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR bit.
Remove this bit from the tests.
Update tests:
* dEQP-VK.image.extended_usage_bit.*
Components: Vulkan
VK-GL-CTS issue: 673, 614
Change-Id: I0adb26c5306a9d5f49936ffef070050fd5936faa
Gary Sweet [Mon, 4 Sep 2017 10:14:58 +0000 (11:14 +0100)]
Fixup some missing/incorrect flushes and invalidates
Some of the flushes were too small, and there were a few
missing invalidates.
Affects:
dEQP-VK.ssbo.layout.*
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test
Components: Vulkan
VK-GL-CTS issue: 660
Change-Id: I27fac24397984f82865683f30b823570c3e52aed
Slawomir Cygan [Wed, 6 Sep 2017 14:47:04 +0000 (16:47 +0200)]
Use SRC image layout for copy image to buffer
The test was calling vkCmdCopyImageToBuffer with
VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout, which is not a valid
parameter value for this function (and not the layout the image is currently in).
Affects: dEQP-VK.memory.binding.*.*.image_*
Components: Vulkan
VK-GL-CTS issue: 666
Change-Id: Ifb5a1bd8726535de02a0dc134f5ac76a2734a661
Courtney Goeltzenleuchter [Tue, 5 Sep 2017 23:48:27 +0000 (17:48 -0600)]
Check for EGL_KHR_gl_colorspace before using it
Bug:
65376495
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Change-Id: Ief654c998e93d72899225120b0ca1ab2fa3ca624
Treehugger Robot [Tue, 5 Sep 2017 21:35:29 +0000 (21:35 +0000)]
Merge "Add more allowed 'dot' alternatives"
Slawomir Cygan [Tue, 5 Sep 2017 14:39:12 +0000 (16:39 +0200)]
Do not use ycbcr formats if ycbcr extension is not supported
Spec says (on "vkGetPhysicalDeviceFormatProperties"):
"format must be a valid VkFormat value"
Formats from future or unsupported extensions do not
constitute a "valid VkFormat values".
Affects: dEQP-VK.memory.requirements.*.image.*
Components: Vulkan
VK-GL-CTS issue: 663
Change-Id: Ia284977b830d5fda14bcbd9d96010995d84014d5
Mika Isojärvi [Thu, 31 Aug 2017 19:13:05 +0000 (12:13 -0700)]
Fix unused uniform bug in EGL robustness tests
Bug:
64845766
Bug:
65175554
Test: Ran tests on couple of Google devices
Change-Id: Iee2918c1e45ad305dd9ca30f1b81998bdac06127
Treehugger Robot [Tue, 5 Sep 2017 17:18:37 +0000 (17:18 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests"
Pyry Haulos [Tue, 5 Sep 2017 15:22:27 +0000 (15:22 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
9e85a126d2
Change-Id: I86a852a2216971095d4aa256a97f0b8e68e73646
Pyry Haulos [Tue, 5 Sep 2017 15:21:58 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
9e85a126d2
Change-Id: Ia7cd7612e6c2f0f961837734f1900a21b52a0e39
Pyry Haulos [Tue, 5 Sep 2017 15:14:23 +0000 (15:14 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am:
0f672f2a20
Change-Id: Ib7e13db1c7801095b925890f226a38969a1b418e
Gary Sweet [Mon, 4 Sep 2017 09:39:36 +0000 (10:39 +0100)]
Fixup some missing/incorrect flushes and invalidates
Some of the flushes were too small, and there were a few
missing invalidates.
Affects:
dEQP-VK.ssbo.layout.*
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test
Components: Vulkan
VK-GL-CTS issue: 660
Change-Id: Id29b59d127e004a028c04a1075db563d697140a1
Alexander Galazin [Tue, 22 Aug 2017 13:59:49 +0000 (15:59 +0200)]
Add more allowed 'dot' alternatives
Expanded dot may be re-associated in multiple ways.
Add all possible alternatives to prevent precision failures.
Components: AOSP
VK-GL-CTS issue: 634
Google issue:
28767510
Affects:
dEQP-GLES3.functional.shaders.builtin_functions.precision.dot.*
dEQP-GLES3.functional.shaders.builtin_functions.precision.reflect.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.dot.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.reflect.*
Change-Id: I2a91add1b92363acab2172179320cd880da779ec
Mika Isojärvi [Thu, 31 Aug 2017 18:54:48 +0000 (11:54 -0700)]
Fix missing SSBO binding in EGL robustness tests
Bug:
64845581
Bug:
65175642
Test: Ran the tests on couple of Google devices
Change-Id: I3a98fe12802e6951483499e800cd3fe7412e37f0
Daniel Koch [Thu, 31 Aug 2017 13:48:53 +0000 (09:48 -0400)]
Whitelist new extensions for VK 1.0.2.6
VK-GL-CTS issue: 653
Component: Vulkan
Affects:
dEQP-VK.api.info.device.extensions
Change-Id: I7f5ef7511ce8312e67833e07c154cd6b9fea6041
Mika Isojärvi [Tue, 15 Aug 2017 23:57:24 +0000 (16:57 -0700)]
Add tests for image copies between YCbCr formats
Components: Vulkan, Framework
VK-GL-CTS issue: 111
Change-Id: I3a7050ae5605c4397cd678e14438f851a7cf48ce
(cherry picked from commit
f24269bdd0c4d3801c2118b153082f0b0223f55a)
Mika Isojärvi [Tue, 16 May 2017 21:17:49 +0000 (14:17 -0700)]
Add tests for VK_KHR_sampler_ycbcr_conversion
Components: Vulkan, Framework
VK-GL-CTS issue: 111
Change-Id: Id0810b196f0a148903922df3fc08f1c5db88f86e
(cherry picked from commit
595b5f763a8f6ef1c68bfd133a55ded9c25ac101)
Boris Zanin [Fri, 12 May 2017 08:11:01 +0000 (10:11 +0200)]
Test VK_KHR_dedicated_allocation mem requirement queries
Add tests:
* dEQP-VK.memory.requirements.dedicated_allocation.buffer.*
* dEQP-VK.memory.requirements.dedicated_allocation.image.*
Components: Vulkan
VK-GL-CTS issue: 391
Change-Id: I9510464987e33b395a5ac20c2fdb9129eefd91da
(cherry picked from commit
6c472cc5e98a1a73aeac019ce34cccac7f3fa30e)
David Sodman [Fri, 24 Feb 2017 19:04:46 +0000 (11:04 -0800)]
Add tests for FragCoord interaction with multisampling
Components: Vulkan
VK-GL-CTS issue: 89
Test: fragcoord_msaa, frontface, fragdepth, clipping
Change-Id: Ibf342e63f224b88fe0b0cffde59b10b34afd1faf
(cherry picked from commit
69a7a0079a6cc06d556ecb5314f275d2fa01a60d)
Maciej Jesionowski [Wed, 26 Jul 2017 13:53:13 +0000 (15:53 +0200)]
Fix VS12 compilation error (typedef)
Change-Id: Iebfece1455df2a49c79885d42f43817001a31b84
(cherry picked from commit
68c41978cf7a76391e898af7faaddea0598a3911)
Slawomir Cygan [Wed, 5 Jul 2017 17:17:02 +0000 (19:17 +0200)]
Fix wrong transition in dEQP-VK.glsl.builtin_var.fragdepth
The test was using vkCmdClearDepthStencilImage to clear an
image, than used this image as a depth attachment in
redering performed by VulkanDrawContext utility.
However, this utility always starts the renderpass on depth
attachment from UNDEFINED layout. As no depth clear is done
in the renderpass, the depth attachment contents are undefined
(and initially cleared image contents may be corrupted).
The easiest fix here is to move the clear to LOAD_OP - as
is already done for color, leaving the UNDEFINED layout as is.
Affects: dEQP-VK.glsl.builtin_var.fragdepth*
Components: Vulkan
VK-GL-CTS issue: 559
Change-Id: Icef3289ba62f71bf1ed989f84085a4d9d3b7218a
(cherry picked from commit
f3a36239082b721e1f5f6849afc70af65b42e3ed)
David Sodman [Fri, 24 Feb 2017 18:41:59 +0000 (10:41 -0800)]
Add test for FragDepth shader built-in
Components: Vulkan
VK-GL-CTS issue: 93
Test: fragdepth, frontface, clipping
Change-Id: I531e39a58dd6b577108bff14b2206d7bf9d9cd4f
(cherry picked from commit
3aeb0c565fe64441466247fe381fc815209d46e4)
David Sodman [Tue, 6 Sep 2016 21:05:59 +0000 (14:05 -0700)]
Extend gl_FrontFacing tests
Update gl_FrontFacing tests to include more tests as well as to use the
vktDrawUtil utility class
Change-Id: If94fb552f5f9366c79ffa3fcac6f085611a23f65
(cherry picked from commit
417115b2676c3064a06385184573b6d7a0644f42)
David Sodman [Fri, 9 Sep 2016 02:58:35 +0000 (19:58 -0700)]
Add ability to generate images with the reference renderer
*Separate DrawContext into a DrawContext and DrawContextState to reflect
graphics API's are split between state and action parts
* Add abstract DrawContext class
Test: Test clipping and synchronization primitives
Change-Id: I9f3945c6c3de169325fadea7bf70a9d5d7bfd932
(cherry picked from commit
11da53fb71eced942e89bac59407a5681dba3bb1)
David Sodman [Thu, 1 Sep 2016 17:40:21 +0000 (10:40 -0700)]
Add Vulkan DrawContext utility class
This is the first in a series of changes to move the DrawContext class
for more general use.
Test: run clipping tests on Vulkan
Affects: dEQP-VK.clipping.*
Change-Id: Ia9b8953d25c10ec2a6c227bf300637dcd62ea898
(cherry picked from commit
9a928cdc2014c830eb8cb43043746f8f2ea6969a)
Arkadiusz Sarwa [Tue, 29 Aug 2017 14:40:58 +0000 (16:40 +0200)]
VK_KHR_maintenance2: View block-compressed add check shader_read_only_optimal
Affects:
* dEQP-VK.image.texel_view_compatible.compute.extended.image_load.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texel_fetch.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texture.*
* dEQP-VK.image.texel_view_compatible.compute.extended.image_store.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_write.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_write.*
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: Ida0c7b8085e7ca90c325ffb0477773e8b09bf564
(cherry picked from commit
62e68c3916ce22a76b44bec91e470abc42cd6e92)
Boris Zanin [Tue, 8 Aug 2017 09:59:32 +0000 (11:59 +0200)]
VK_KHR_maintenance2: extended_usage_bit tests
Add tests:
* dEQP-VK.image.extended_usage_bit.*
Components: Vulkan
VK-GL-CTS issue: 614
Change-Id: Ied6251e642746d5f37aa7b2fe3f262061f765f8f
(cherry picked from commit
dcae428a67a0bccf2a6694075dd06115f0eb1db7)
Arkadiusz Sarwa [Tue, 29 Aug 2017 10:39:57 +0000 (12:39 +0200)]
Fix build errors with uint32_t vktImageMutableTests.cpp
Change-Id: I072fade98fd20b6a4a0389e9a63e790d36d6c0d0
Components: Vulkan
(cherry picked from commit
1afc0a15d483701f3319467f7a3f1d9b47692f66)
Boris Zanin [Thu, 24 Aug 2017 08:29:06 +0000 (10:29 +0200)]
VK_KHR_maintenance2: View block-compressed speedup
Do strict comparison first, if it fails use fuzzy.
Update tests:
* dEQP-VK.image.texel_view_compatible.compute.*
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: I1ad580d60638ba3fce83fc913819608d5d9a8812
(cherry picked from commit
c9e2dea449429762592af0530b609cf80ab913ce)
Arkadiusz Sarwa [Fri, 21 Jul 2017 14:35:33 +0000 (16:35 +0200)]
VK_KHR_maintenance2: View block-compressed formats extended tests
Add tests:
* dEQP-VK.image.texel_view_compatible.compute.extended.image_load.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texel_fetch.*
* dEQP-VK.image.texel_view_compatible.compute.extended.texture.*
* dEQP-VK.image.texel_view_compatible.compute.extended.image_store.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.attachment_write.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_read.*
* dEQP-VK.image.texel_view_compatible.graphic.extended.texture_write.*
Update tests:
* dEQP-VK.image.texel_view_compatible.compute.basic.*
* dEQP-VK.image.texel_view_compatible.graphic.basic.*
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: Ia51ece39a339617302ec4f2a48c9133a3f9423d4
(cherry picked from commit
90d87fdceed790f9542acb19c3da196951c4d2dc)
Fix build errors with makeViewport
Local makeViewport cannot be used in recently added tests
in vktImageMutableTests.
Fix: Remove local makeViewport and use one from vkTypeUtil.inl
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: I27c9c255d9e46a74a6528327339317ba74e5eb98
(cherry picked from commit
310b00cc9869e26e85e620b55b6ad3a7efeb8d90)
Pyry Haulos [Mon, 12 Jun 2017 20:52:42 +0000 (13:52 -0700)]
Framework support for VK_KHR_sampler_ycbcr_conversion
Change-Id: I749b92c79766f933ea34bb183d3d34c102e023c2
(cherry picked from commit
e5cf8de067694afde10873b6fdbd7907486e5611)
Mika Isojärvi [Thu, 4 May 2017 22:55:19 +0000 (15:55 -0700)]
Add support for 10 and 12bit packed unorm formats
10 and 12bit unsigned normalized values are packed into highers bits
of 16bit unsigned int.
Change-Id: I18a88547ba29003961bf0806a50cb17995c72f13
Components: Framework
(cherry picked from commit
07621ffcf0362606afeccf2c2deac35bc0f3668a)
Iago Toral Quiroga [Tue, 4 Jul 2017 08:59:45 +0000 (10:59 +0200)]
Add tests for VK_KHR_image_format_list
Components: Vulkan
VK-GL-CTS issue: 550
New tests:
dEQP-VK.image.mutable.*_format_list
Change-Id: Ic72304a65c76335c98764678e056f030fafba71f
(cherry picked from commit
dcd00f2f316fae0b86e1b03a8cf22774ce312c1d)
Iago Toral Quiroga [Thu, 29 Jun 2017 05:37:41 +0000 (07:37 +0200)]
Expand tests for mutable images
Currently, only the image load/store tests use mutable images,
but these require the images's layout to be
VK_IMAGE_LAYOUT_GENERAL (requirement for image load/store) so they
don't provide coverage for the most interesting scenarios.
These tests add cases that mix combined image upload/download
methods that exercise various other image layouts and scenarios.
Specifically, it tests each of [copy, clear, draw, store] upload
methods with each of [copy, load, texture] download methods.
Components: Vulkan
VK-GL-CTS issue: 513
New Tests:
dEQP-VK.image.mutable.*
Change-Id: I01cd77ab250f9934e71f5c9997b850950c9bd552
(cherry picked from commit
16b30ca0f65fc9c6a1508d1f99ba1f6014f4e828)
Marcin Rogucki [Fri, 21 Jul 2017 11:44:23 +0000 (13:44 +0200)]
Tests for VK_KHR_bind_memory2
Regular and aliased bindings with suballocated and
dedicatedly allocated memory are exercised.
Added tests:
* dEQP-VK.memory.binding.*
Components: Vulkan
VK-GL-CTS issue: 434
Change-Id: I853ca8b007a9b2f6340ed60cca1a5cb35887ec11
(cherry picked from commit
a0aa054cbddcebe880d12836fae9a24ad4eade9f)
Arkadiusz Sarwa [Fri, 9 Jun 2017 15:58:01 +0000 (17:58 +0200)]
VK_KHR_maintenance2: View block-compressed formats
Add tests:
* dEQP-VK.image.texel_view_compatible.compute.image_load.*
* dEQP-VK.image.texel_view_compatible.compute.texel_fetch.*
* dEQP-VK.image.texel_view_compatible.compute.texture.*
* dEQP-VK.image.texel_view_compatible.compute.image_store.*
* dEQP-VK.image.texel_view_compatible.graphic.attachment_read.*
* dEQP-VK.image.texel_view_compatible.graphic.attachment_write.*
* dEQP-VK.image.texel_view_compatible.graphic.texture_read.*
* dEQP-VK.image.texel_view_compatible.graphic.texture_write.*
Components: Vulkan
VK-GL-CTS issue: 124
Change-Id: I8f12778e764144198dab603dbef72257faed0503
(cherry picked from commit
52af60c002b457dbc09044dc2e88ccee9cb59555)
Boris Zanin [Mon, 10 Apr 2017 17:14:55 +0000 (19:14 +0200)]
VK_KHR_maintenance2: Point clipping
Updated tests:
* dEQP-VK.clipping.clip_volume.clipped.large_points
* dEQP-VK.rasterization.primitives.lines_wide
* dEQP-VK.rasterization.primitives.line_strip_wide
* dEQP-VK.rasterization.primitives_multisample_2_bit.lines_wide
* dEQP-VK.rasterization.primitives_multisample_4_bit.lines_wide
* dEQP-VK.rasterization.primitives_multisample_8_bit.lines_wide
Components: Vulkan
VK-GL-CTS issue: 126
Change-Id: Id0cecb96e8a448ec3eb09e2a25d6c82acd837057
(cherry picked from commit
14bfa832d795dca9057699e867d0273db95c7de4)
Mika Isojärvi [Fri, 21 Apr 2017 22:33:54 +0000 (15:33 -0700)]
VK_KHR_maintenance2: New depth and stencil layouts
New Tests:
dEQP-VK.renderpass.formats.d24_unorm_s8_uint.*.*_depth_read_only
dEQP-VK.renderpass.formats.d24_unorm_s8_uint.*.*_stencil_read_only
dEQP-VK.renderpass.formats.d24_unorm_s8_uint.input.*.*_depth_read_only
dEQP-VK.renderpass.formats.d24_unorm_s8_uint.input.*.*_stencil_read_only
dEQP-VK.renderpass.formats.d32_sfloat_s8_uint.*.*_depth_read_only
dEQP-VK.renderpass.formats.d32_sfloat_s8_uint.*.*_stencil_read_only
dEQP-VK.renderpass.formats.d32_sfloat_s8_uint.input.*.*_depth_read_only
dEQP-VK.renderpass.formats.d32_sfloat_s8_uint.input.*.*_stencil_read_only
VK-GL-CTS issues: 339
Components: Vulkan
Change-Id: Ifac0a3a5fe861440424f85029dd25bad5755cd63
(cherry picked from commit
226ae75fa4fc85eaa46b1544dc8871fceeeb759c)
Pyry Haulos [Tue, 18 Apr 2017 21:49:12 +0000 (14:49 -0700)]
VK_KHR_maintenance2: Tessellation domain origin
This change extends existing dEQP-VK.tessellation.winding tests with
variants that supply tessellation domain origin when creating the
pipeline.
Existing tests in the group have been moved under "default_domain"
group.
VK-GL-CTS issue: 127
Components: Vulkan
Change-Id: Ib3ed3fd32dc66805d139db08a2c0546650d0de5f
(cherry picked from commit
333b51b00a943447c0eb921f04b2804af428dfc9)
Jason Ekstrand [Thu, 26 Jan 2017 22:27:48 +0000 (14:27 -0800)]
Add yflip versions of tessellation winding order tests
Changed: dEQP-VK.tessellation.winding.triangles_*
Components: Vulkan
Change-Id: I3e0abc8d25132e129cb2979b1fce985ca4a60dc4
(cherry picked from commit
a9c1d0abb740baa5f368758f17142336baeb17f9)
Mika Isojärvi [Thu, 13 Apr 2017 20:53:21 +0000 (13:53 -0700)]
VK_KHR_maintenance2: Render pass input aspect specifiers
VK-GL-CTS issues: 125
Components: Vulkan
Change-Id: I32a88f1d82560df4bc1b8f7cac483a074434ec86
(cherry picked from commit
a1a041546262e8ad17fa62f40af8b293ebbb698a)
Pyry Haulos [Thu, 8 Jun 2017 19:32:17 +0000 (12:32 -0700)]
Add framework support for VK_KHR_maintenance2
Components: Vulkan
VK-GL-CTS issue: 199
Change-Id: I9112fc0c44c6516e5e65d53535c9b0247f91e272
(cherry picked from commit
59b5bb0016f0f0bc6a2e3973016ae6f90655ac7c)
Alexander Galazin [Thu, 31 Aug 2017 17:02:20 +0000 (19:02 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Change-Id: I5dfa06e462512838179803963ddd04094679aa4f
Alex Walters [Thu, 17 Aug 2017 14:53:01 +0000 (15:53 +0100)]
Make create_buffer test use platform limits
The create_buffer tests use a maximum buffer size of half the heap size
as reported by vkGetPhysicalDeviceMemoryProperties. On systems where
device memory comes out of system memory, due to the memory in use in
the system the selected buffer size may be too large.
The heap size is checked against the platform limits, the min is taken
and that is used as the basis for calculating the buffer size to test
Affects:
dEQP-VK.api.buffer.createBuffer_*
Components: Vulkan
VK-GL-CTS issue: 362
Change-Id: I7a644e8e48b961dad0d19675e3d54add4b11d99c
Pyry Haulos [Thu, 9 Mar 2017 17:46:29 +0000 (09:46 -0800)]
Fix issues in pipeline.timestamp.transfer_tests
This change fixes two issues:
* Buffer overrun in vkCmdCopyBufferToImage and vkCmdCopyImageToBuffer
tests.
* Validation error (srcStageMask must not be 0).
VK-GL-CTS issue: 185
Components: Vulkan
Change-Id: I9679566f08c4a914eb6066bab248abd6d51e0f7e
Slawomir Cygan [Wed, 30 Aug 2017 13:36:27 +0000 (15:36 +0200)]
dEQP-VK.geometry: use proper layout for sampling the image
While 'GENERAL' layout is acceptable layout for sampling image, the barrier in
geometry\vktGeometryBasicGeometryShaderTests.cpp:235
transitions the image to `SHADER_READ_ONLY_OPTIMAL` layout.
Both layout must much, otherwise the behavior is undefined.
Affects:
dEQP-VK.geometry.basic.output_vary_by_texture_instancing
dEQP-VK.geometry.basic.output_vary_by_texture
Components: Vulkan
VK-GL-CTS issue: 648
Change-Id: I2b947a150173f0a060cfbf851d117ef91097c1d8
Tapani Pälli [Mon, 28 Aug 2017 06:20:53 +0000 (09:20 +0300)]
Require EGL_KHR_gl_colorspace for wide_color tests.
These tests utilize enum EGL_GL_COLORSPACE_KHR which is introduced by
EGL_KHR_gl_colorspace extension, check first for support and skip the
test if extension is not supported.
v2: loosen the check, only check when enum in use (Courtney)
Change-Id: I891a6fdcce49ac6dcd42577076d4cf64a143dd38
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Ian Elliott [Wed, 16 Aug 2017 21:11:57 +0000 (15:11 -0600)]
Fix flakiness in mailbox.display_timing
The "vktWsiDisplayTimingTests.cpp" file was originally written just for
a present mode of VK_PRESENT_MODE_FIFO_KHR. It has a case at image 80,
where it changes the desiredPresentTime to be 1 second earlier, and then
checks that later. Such a check doesn't work with
VK_PRESENT_MODE_MAILBOX_KHR, which can throw off the timing of images
(because some images may not be presented). This has resulted in the
test having random failures. The "image 80 test" wasn't intended to
occur with MAILBOX, and so it's now being removed.
VK-GL-CTS issue: 622
Components: Vulkan
Affects: dEQP-VK.wsi.*.display_timing.mailbox.display_timing
Change-Id: I9fbd2254b4e6fc1c7bff077c8c0a5229a6d74800
Treehugger Robot [Thu, 24 Aug 2017 22:57:17 +0000 (22:57 +0000)]
Merge "Check only what's needed and use threshold"
Mika Isojärvi [Thu, 24 Aug 2017 20:13:19 +0000 (13:13 -0700)]
Merge Vulkan CTS 1.0.2.5 into aosp/master
Bug:
64932237
Change-Id: Ic2758a85f3a8f8cf00985b03a89830ba509f824d
Courtney Goeltzenleuchter [Fri, 28 Jul 2017 19:51:31 +0000 (13:51 -0600)]
Check only what's needed and use threshold
Check for only the functionality needed for a specific test.
E.g. if testing floating point color, don't need to check
for support of 10:10:10:2 pixel format.
Some devices are not able to hit the exact values calculated.
Not unexpected, update tests to use thresholds.
Note: waiting on results of b/
64487716. Seeing failure on
Pixel devices. Need to make sure it's not a test issue.
Test: adb -s
0424415804161004f80d -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Change-Id: I2adb31eaa3b189179aeceb9e8f6b1ac8587b6027
(cherry picked from commit
041a1b5e82db7a6945aaefd791639de1c8c9e84d)
Treehugger Robot [Tue, 22 Aug 2017 18:13:36 +0000 (18:13 +0000)]
Merge "Avoid thread state races in EGL multithread tests"
Treehugger Robot [Tue, 22 Aug 2017 18:10:07 +0000 (18:10 +0000)]
Merge "Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present"
Alexander Galazin [Thu, 17 Aug 2017 14:16:09 +0000 (16:16 +0200)]
Add more allowed 'dot' alternatives
Expanded dot may be re-associated in multiple ways.
Add all possible alternatives to prevent precision failures.
Components: Vulkan
VK-GL-CTS issue: 634
Affects:
dEQP-VK.glsl.builtin.precision.dot.*
dEQP-VK.glsl.builtin.precision.reflect.*
Change-Id: I7fecbfa1cde04eab95bb3d418972631727d6d6af
Alexander Galazin [Wed, 16 Aug 2017 09:36:01 +0000 (11:36 +0200)]
Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present
Draw*BaseVertex methods are enabled if
the EXT_draw_elements_base_vertex extension is present
Follow-up on
1b1ea05b
Components: AOSP
Affects: dEQP-GLES31.functional.draw_base_vertex.*
Change-Id: If8a4860a956c771ec5ea3341e2227f437b12a286
Mika Isojrvi [Thu, 17 Aug 2017 00:08:48 +0000 (00:08 +0000)]
Fix texture mip level size in framebuffer fetch tests
am:
be0d165a5d
Change-Id: I7fb9c075ee79e411ea295999e9edd7f38a5e5bc9
Mika Isojärvi [Wed, 16 Aug 2017 20:40:22 +0000 (13:40 -0700)]
Fix texture mip level size in framebuffer fetch tests
Bug:
64280744
Test: Ran tests with multiple Google devices
Change-Id: I369a3c9b16270655332d5a608207f0da2633e0fe
james.glanville [Wed, 16 Aug 2017 19:04:43 +0000 (19:04 +0000)]
Merge "Use safe glFramebufferTexture* function"
am:
ec5ccbe144
Change-Id: I156ecc2a6ed17e3e23ef17ebbe026be27c1670c3