senorblanco [Thu, 17 Dec 2015 16:10:17 +0000 (08:10 -0800)]
Fix gaussian blur for small sigma.
I broke this in https://skia.googlesource.com/skia/+/
c57e0ded7d535523cfc6bf07c78e5f3479bb8c42.
That change added support for cropping during blur, but
did not do the correct thing for the small-sigma 2D matrix convolution
optimization when blurring from small-to-large textures.
The fix is pass the correct dstRect and srcOffset to convolve_gaussian_2d.
I also changed convolve_gaussian_1d() and convolve_gaussian_2d() to take
the original (non-negated) srcOffset, and to negate them when constructing
the local matrix.
Test: added a new (blur 0.3 0.3) column to imagefilterscropexpand, so that
GM will have to be rebaselined.
BUG=skia:4719,569883
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1529313003
Review URL: https://codereview.chromium.org/
1529313003
reed [Thu, 17 Dec 2015 15:55:39 +0000 (07:55 -0800)]
check bounds of each cubic segment against clip
Timing against complex svg image (map),
no tiling: no change or very slightly faster
tiling (4x4): went from 3x slower (than untiled) to 2x slower
no gold changes expected
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1532733002
Review URL: https://codereview.chromium.org/
1532733002
reed [Wed, 16 Dec 2015 22:25:30 +0000 (14:25 -0800)]
remove obsolete ondrawsprite base virtual
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1529283003
TBR=
Review URL: https://codereview.chromium.org/
1529283003
scroggo [Wed, 16 Dec 2015 22:17:58 +0000 (14:17 -0800)]
Revert of Add test for previously unflattenables (patchset #1 id:1 of https://codereview.chromium.org/
1514373003/ )
Reason for revert:
Speculative fix for skbug.com/4709
Original issue's description:
> Add test for previously unflattenables
>
> BUG=skia:4613
>
> Committed: https://skia.googlesource.com/skia/+/
061aaa79f7d8a2e93962e8296abaae13f0a7a715
TBR=halcanary@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4613
Review URL: https://codereview.chromium.org/
1532753002
mtklein [Wed, 16 Dec 2015 21:42:37 +0000 (13:42 -0800)]
count is an int, so constrain it to a 32-bit w-register.
This piece of code is already 64-bit only, so we don't need to think about ARMv7.
Hopefully this shuts up the warnings. They were harmless.
If this doesn't work (it's relatively new modifier, so maybe some compilers barf), an alternative is to cast count to a size_t.
BUG=skia:4686
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1527123003
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1527123003
caryclark [Wed, 16 Dec 2015 21:41:23 +0000 (13:41 -0800)]
add fsync to try to get complete skps from webpage picture capture
R=reed@google.com,mtklein@google.com
BUG=skia:4691
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1530783003
Review URL: https://codereview.chromium.org/
1530783003
joshualitt [Wed, 16 Dec 2015 20:54:19 +0000 (12:54 -0800)]
Add VisualBench switch to extra_config
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1533523003
Review URL: https://codereview.chromium.org/
1533523003
caryclark [Wed, 16 Dec 2015 20:28:35 +0000 (12:28 -0800)]
only call scalar finite when necessary
Mike points that the the ulps compares
rank high in path ops profiles. The
check for finite scalars is rarely
required.
Call it less by:
- specializing _pin version of compares
- checking for 0 divides up front
- handling failing cases before comparing
- casting float to double before adding
R=reed@google.com
Review URL: https://codereview.chromium.org/
1522183002
bsalomon [Wed, 16 Dec 2015 19:51:22 +0000 (11:51 -0800)]
Generate a table of config->glformat info. Precursor to lifting this to caps.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1527383003
Review URL: https://codereview.chromium.org/
1527383003
mtklein [Wed, 16 Dec 2015 19:15:56 +0000 (11:15 -0800)]
SSE 4.1 SrcOver blits: color32, blitmask.
This is mainly warmup for an AVX2 version.
The machine I'm typing this on just doesn't support AVX2.
This strategy should translate easily down to SSSE3 and SSE2.
Xfermode_SrcOver: 2.73ms -> 2.62ms (0.96x) (That's Color32.)
Xfermode_SrcOver_aa: 3.48ms -> 3.09ms (0.89x) (That's BlitMask_D32_A8.)
AA text blits (text_16_AA_{88,FF,WT,BK}) show speedups in the range of 5 to 20%.
Unlike previous versions of this code, all the div255() are exactly (x+127)/255.
This won't fix any major bugs, but it does correct our bias in the middle.
There will be many diffs, all minor.
I've punted for now on pmaddubsw for lerping. I do intend to try that,
but I want this (relatively simple) code as my basis for comparison.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1526883004
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1526883004
joshualitt [Wed, 16 Dec 2015 18:38:35 +0000 (10:38 -0800)]
Blacklist GLInstancedArraysBench on ipad
TBR=jvanverth@google.com
BUG=skia:4714
Review URL: https://codereview.chromium.org/
1522273006
scroggo [Wed, 16 Dec 2015 18:21:43 +0000 (10:21 -0800)]
Remove Subset*Benches
These were originally used to compare to the old implementation of
subset decoding in SkImageDecoder. The old implementation has been
removed, and they do not provide useful information that is not
covered by the BitmapRegionDecoderBenches.
This will greatly speed up some of our infra bots, which spend a lot of
time decoding interlaced PNGs repeatedly (thanks to
SubsetTranslateBench).
BUG=skia:4715
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1531833002
Review URL: https://codereview.chromium.org/
1531833002
joshualitt [Wed, 16 Dec 2015 18:20:11 +0000 (10:20 -0800)]
Revert of Blacklist GLInstancedArraysBench on the ipad (patchset #1 id:1 of https://codereview.chromium.org/
1529973002/ )
Reason for revert:
Whoops, this is for nanobench
Original issue's description:
> Blacklist GLInstancedArraysBench on the ipad
>
> BUG=skia:4714
>
> Committed: https://skia.googlesource.com/skia/+/
5d16fea9e22221be5fbe2866bbcfe8d6f4c6aeac
TBR=jvanverth@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:4714
Review URL: https://codereview.chromium.org/
1534513002
caryclark [Wed, 16 Dec 2015 16:53:41 +0000 (08:53 -0800)]
This brings hairlines into agreement with thick strokes.
Add more testing and a pixel magnification to GM.
R=reed@google.com, fmalita@chromium.org
BUG=skia:4599
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1527083002
Review URL: https://codereview.chromium.org/
1527083002
reed [Wed, 16 Dec 2015 16:38:15 +0000 (08:38 -0800)]
Reland of move drawSprite from canvas (patchset #1 id:1 of https://codereview.chromium.org/
1529803004/ )
Reason for revert:
guard has landed in chrome
Original issue's description:
> Revert of remove drawSprite from canvas (patchset #4 id:60001 of https://codereview.chromium.org/
1534443003/ )
>
> Reason for revert:
> need to remove an override in chrome
>
> Original issue's description:
> > remove drawSprite from canvas
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/
4657ce2324ea197507c4ba728d81138f56da13b1
>
> TBR=fmalita@chromium.org,robertphillips@google.com,senorblanco@chromium.org,mtklein@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
32704674f64cb6a14356dfebe060cd3484c06cc7
TBR=fmalita@chromium.org,robertphillips@google.com,senorblanco@chromium.org,mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1530203002
reed [Wed, 16 Dec 2015 16:27:10 +0000 (08:27 -0800)]
Revert of remove drawSprite from canvas (patchset #4 id:60001 of https://codereview.chromium.org/
1534443003/ )
Reason for revert:
need to remove an override in chrome
Original issue's description:
> remove drawSprite from canvas
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
4657ce2324ea197507c4ba728d81138f56da13b1
TBR=fmalita@chromium.org,robertphillips@google.com,senorblanco@chromium.org,mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1529803004
reed [Wed, 16 Dec 2015 15:52:46 +0000 (07:52 -0800)]
remove drawSprite from canvas
BUG=skia:
Review URL: https://codereview.chromium.org/
1534443003
scroggo [Wed, 16 Dec 2015 15:34:21 +0000 (07:34 -0800)]
Use SK_BUILD_FOR_ANDROID_FRAMEWORK in compose
We are trying to support the behavior provided by the Android
framework. Other developers do not necessarily need this behavior.
BUG=skia:4296
Review URL: https://codereview.chromium.org/
1518933002
robertphillips [Wed, 16 Dec 2015 13:08:27 +0000 (05:08 -0800)]
Avoid pixel GPU readback in saveLayerWithPickup
When the default framebuffer is wrapped in a device for rendering we don't get a GrTexture. This CL adds a copy to a temporary texture in this instance so the rest of the Ganesh pipeline can continue on as usual.
Review URL: https://codereview.chromium.org/
1531493002
joshualitt [Tue, 15 Dec 2015 21:07:21 +0000 (13:07 -0800)]
Blacklist GLInstancedArraysBench on the ipad
BUG=skia:4714
Review URL: https://codereview.chromium.org/
1529973002
bsalomon [Tue, 15 Dec 2015 20:37:38 +0000 (12:37 -0800)]
Set GL_PACK_ALIGNMENT before calling glReadPixels
Review URL: https://codereview.chromium.org/
1525193002
joshualitt [Tue, 15 Dec 2015 19:33:19 +0000 (11:33 -0800)]
Make draw* lines responsible for cache management
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1521613002
ethannicholas [Tue, 15 Dec 2015 19:01:12 +0000 (11:01 -0800)]
Fix for GrAALinearizingConvexPathRenderer incorrectly drawing non-convex paths
BUG=552080
Review URL: https://codereview.chromium.org/
1522973002
smklein [Tue, 15 Dec 2015 18:52:51 +0000 (10:52 -0800)]
Porting Skia for newlib compatibility.
"locale_t" is not defined for Newlib.
BUG=https://github.com/domokit/mojo/issues/431
Review URL: https://codereview.chromium.org/
1526703003
joshualitt [Tue, 15 Dec 2015 18:46:21 +0000 (10:46 -0800)]
Blacklist AndroidOne + WritePixelsTest
BUG=skia:4711
Review URL: https://codereview.chromium.org/
1528033002
bsalomon [Tue, 15 Dec 2015 17:25:06 +0000 (09:25 -0800)]
Add helper for determining whether to use sized internal format in GL
Fix case where texture format and data format are different.
Use helper when createing a testing "backend" texture.
BUG=skia:
Review URL: https://codereview.chromium.org/
1527753002
halcanary [Tue, 15 Dec 2015 17:20:19 +0000 (09:20 -0800)]
Tests: reduce verbosity
Review URL: https://codereview.chromium.org/
1526943003
mseaborn [Tue, 15 Dec 2015 15:52:31 +0000 (07:52 -0800)]
SkPreConfig.h: Allow defined(__unix__) to imply SK_BUILD_FOR_UNIX
This is more general than checking for __linux, __FreeBSD__, etc. (In
principle we could remove some of the existing checks such as
__FreeBSD__, but I have not tried that so far.)
In particular, it allows Skia to build with the NaCl or PNaCl
toolchains, which is something we would like for Mojo.
BUG=https://github.com/domokit/mojo/issues/431
TEST=none
Review URL: https://codereview.chromium.org/
1523733003
mtklein [Tue, 15 Dec 2015 15:38:54 +0000 (07:38 -0800)]
Specialize Sk2d for SSE2
Given the autovectorization we've seen, I wouldn't expect big speedups
from this, but it does give us a point of control over what's going on.
BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1526923003
benjaminwagner [Tue, 15 Dec 2015 15:13:21 +0000 (07:13 -0800)]
Revert of In BUILD.public, enable SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS. (patchset #1 id:1 of https://codereview.chromium.org/
1516863007/ )
Reason for revert:
The failing test has been blacklisted. The issue was not caused by this CL.
Original issue's description:
> In BUILD.public, enable SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS.
>
> Somehow https://codereview.chromium.org/
1491843006 causes fills to change in one test.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
b6c77f6d62a62db3aec483e0a995ca30b9c97f0b
TBR=mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1530533003
fmalita [Tue, 15 Dec 2015 14:48:48 +0000 (06:48 -0800)]
SkBitmapProcState rounding bias
Epsilon bias to keep bitmap sample rounding consistent with geometry
rounding.
Also update the GM to draw an outer border + drop uninteresting
scales in favor of negative scale variants.
BUG=skia:4680,skia:4649
R=reed@google.com,caryclark@google.com,mtklein@google.com
Review URL: https://codereview.chromium.org/
1527633002
rmistry [Tue, 15 Dec 2015 14:23:33 +0000 (06:23 -0800)]
Add link to Gold trybot runs in every uploaded Skia CL
BUG=skia:4433
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=
1521913005
Review URL: https://codereview.chromium.org/
1521913005
borenet [Tue, 15 Dec 2015 12:25:39 +0000 (04:25 -0800)]
adb_wait_for_device: More fixes
BUG=skia:4690
Review URL: https://codereview.chromium.org/
1527713002
msarett [Mon, 14 Dec 2015 22:14:06 +0000 (14:14 -0800)]
Fix valgrind suppressions for libjpeg-turbo warning
BUG=skia:
Review URL: https://codereview.chromium.org/
1518393003
benjaminwagner [Mon, 14 Dec 2015 20:41:10 +0000 (12:41 -0800)]
Update sync_google3.sh to match autoroller.py.
BUG=skia:
Review URL: https://codereview.chromium.org/
1526593003
bsalomon [Mon, 14 Dec 2015 20:13:09 +0000 (12:13 -0800)]
Add option to control maximum GrBatch lookback
Review URL: https://codereview.chromium.org/
1498653002
ethannicholas [Mon, 14 Dec 2015 19:37:55 +0000 (11:37 -0800)]
Switch fragment coordinate to 'highp' to fix various broken GMs.
BUG=skia:4693
Review URL: https://codereview.chromium.org/
1523793002
mtklein [Mon, 14 Dec 2015 19:25:18 +0000 (11:25 -0800)]
Unify some SkNx code
- one base case and one N=1 case instead of two each (or three with doubles)
- use SkNx_cast instead of FromBytes/toBytes
- 4-at-a-time Sk4f::ToBytes becomes a special standalone Sk4f_ToBytes
If I did everything right, this'll be perf- and pixel- neutral.
https://gold.skia.org/search2?issue=
1526523003&unt=true&query=source_type%3Dgm&master=false
BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1526523003
mtklein [Mon, 14 Dec 2015 18:54:24 +0000 (10:54 -0800)]
Revert of SkTime updates (patchset #2 id:20001 of https://codereview.chromium.org/
1521293002/ )
Reason for revert:
linux Canary builder has no std::steady_clock. Weird...
Original issue's description:
> SkTime updates
>
> 1) Use steady_clock instead of high_resolution_clock. If we don't have a
> guarantee of monotonicity, it's pretty much useless for timing things.
>
> 2) Implement Mac/iOS with <chrono> too. This was waiting on C++11 library support.
>
> Both high_resolution_clock and steady_clock are (still) busted on MSVC 2013,
> so no change there.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
6a20871e5aeaa7e61f3348694bf436af16f824b9
TBR=herb@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1529603002
halcanary [Mon, 14 Dec 2015 18:19:17 +0000 (10:19 -0800)]
SkBitmap move
Running `Release/dm --gpu 0`, the number of times we call
SkBitmap::operator=(const SkBitmap&)
(which refs the pixelref) is reduced from ~214929 to ~214626.
Review URL: https://codereview.chromium.org/
1514503004
borenet [Mon, 14 Dec 2015 18:07:36 +0000 (10:07 -0800)]
adb_wait_for_device: Add battery fallback, support no battery
BUG=skia:4690
TBR=rmistry
Review URL: https://codereview.chromium.org/
1528563002
halcanary [Mon, 14 Dec 2015 18:03:31 +0000 (10:03 -0800)]
Documentation: HarfBuzz link
NOTRY=true
TBR=caryclark@google.com
Review URL: https://codereview.chromium.org/
1526683002
halcanary [Mon, 14 Dec 2015 17:50:15 +0000 (09:50 -0800)]
Documentation: text shaping
NOTRY=true
DOCS_PREVIEW= https://skia.org/user/tips?cl=
1523023002#kerning
Review URL: https://codereview.chromium.org/
1523023002
caryclark [Mon, 14 Dec 2015 16:43:21 +0000 (08:43 -0800)]
path ops: check for deleted ends
TBR=fmalita@chromium.org
BUG=569540
Review URL: https://codereview.chromium.org/
1524803002
mtklein [Mon, 14 Dec 2015 16:39:13 +0000 (08:39 -0800)]
SkTime updates
1) Use steady_clock instead of high_resolution_clock. If we don't have a
guarantee of monotonicity, it's pretty much useless for timing things.
2) Implement Mac/iOS with <chrono> too. This was waiting on C++11 library support.
Both high_resolution_clock and steady_clock are (still) busted on MSVC 2013,
so no change there.
BUG=skia:
Review URL: https://codereview.chromium.org/
1521293002
caryclark [Mon, 14 Dec 2015 16:38:09 +0000 (08:38 -0800)]
If a point is on a path edge, it's in the path, at least for all cases where the path edge is not canceled with another edge through coincidence.
Add test cases for edges and conics, and make sure it all works.
R=reed@google.com
BUG=skia:4669,4265
Review URL: https://codereview.chromium.org/
1517883002
borenet [Mon, 14 Dec 2015 14:48:43 +0000 (06:48 -0800)]
adb_wait_for_device: If we can't get the battery level, just exit
BUG=skia:4606
TBR=rmistry
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
1529453002
reed [Mon, 14 Dec 2015 13:58:25 +0000 (05:58 -0800)]
Revert of Add config options to run different GPU APIs to dm and nanobench (patchset #12 id:220001 of https://codereview.chromium.org/
1490113005/ )
Reason for revert:
speculative revert to see if it unblocks the DEPS roll
https://codereview.chromium.org/
1529443002
Original issue's description:
> Add config options to run different GPU APIs to dm and nanobench
>
> Add extended config specification form that can be used to run different
> gpu backend with different APIs.
>
> The configs can be specified with the form:
> gpu(api=string,dit=bool,nvpr=bool,samples=int)
>
> This replaces and removes the --gpuAPI flag.
>
> All existing configs should still work.
>
> Adds following documentation:
>
> out/Debug/dm --help config
>
> Flags:
> --config: type: string default: 565 8888 gpu nonrendering
> Options: 565 8888 debug gpu gpudebug gpudft gpunull msaa16 msaa4
> nonrendering null nullgpu nvprmsaa16 nvprmsaa4 pdf pdf_poppler skp svg
> xps or use extended form 'backend(option=value,...)'.
>
> Extended form: 'backend(option=value,...)'
>
> Possible backends and options:
>
> gpu(api=string,dit=bool,nvpr=bool,samples=int) GPU backend
> api type: string default: native.
> Select graphics API to use with gpu backend.
> Options:
> native Use platform default OpenGL or OpenGL ES backend.
> gl Use OpenGL.
> gles Use OpenGL ES.
> debug Use debug OpenGL.
> null Use null OpenGL.
> dit type: bool default: false.
> Use device independent text.
> nvpr type: bool default: false.
> Use NV_path_rendering OpenGL and OpenGL ES extension.
> samples type: int default: 0.
> Use multisampling with N samples.
>
> Predefined configs:
>
> gpu = gpu()
> msaa4 = gpu(samples=4)
> msaa16 = gpu(samples=16)
> nvprmsaa4 = gpu(nvpr=true,samples=4)
> nvprmsaa16 = gpu(nvpr=true,samples=16)
> gpudft = gpu(dit=true)
> gpudebug = gpu(api=debug)
> gpunull = gpu(api=null)
> debug = gpu(api=debug)
> nullgpu = gpu(api=null)
>
> BUG=skia:2992
>
> Committed: https://skia.googlesource.com/skia/+/
e13ca329fca4c28cf4e078561f591ab27b743d23
TBR=bsalomon@google.com,scroggo@google.com,joshualitt@google.com,kkinnunen@nvidia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:2992
Review URL: https://codereview.chromium.org/
1528473002
borenet [Mon, 14 Dec 2015 13:56:45 +0000 (05:56 -0800)]
Add minimum battery level to adb_wait_for_device
This should prevent the Android bots running out of battery at the
expense of extra time spent waiting at the end of the build.
BUG=skia:4606
Review URL: https://codereview.chromium.org/
1522013002
kkinnunen [Mon, 14 Dec 2015 12:49:17 +0000 (04:49 -0800)]
Add config options to run different GPU APIs to dm and nanobench
Add extended config specification form that can be used to run different
gpu backend with different APIs.
The configs can be specified with the form:
gpu(api=string,dit=bool,nvpr=bool,samples=int)
This replaces and removes the --gpuAPI flag.
All existing configs should still work.
Adds following documentation:
out/Debug/dm --help config
Flags:
--config: type: string default: 565 8888 gpu nonrendering
Options: 565 8888 debug gpu gpudebug gpudft gpunull msaa16 msaa4
nonrendering null nullgpu nvprmsaa16 nvprmsaa4 pdf pdf_poppler skp svg
xps or use extended form 'backend(option=value,...)'.
Extended form: 'backend(option=value,...)'
Possible backends and options:
gpu(api=string,dit=bool,nvpr=bool,samples=int) GPU backend
api type: string default: native.
Select graphics API to use with gpu backend.
Options:
native Use platform default OpenGL or OpenGL ES backend.
gl Use OpenGL.
gles Use OpenGL ES.
debug Use debug OpenGL.
null Use null OpenGL.
dit type: bool default: false.
Use device independent text.
nvpr type: bool default: false.
Use NV_path_rendering OpenGL and OpenGL ES extension.
samples type: int default: 0.
Use multisampling with N samples.
Predefined configs:
gpu = gpu()
msaa4 = gpu(samples=4)
msaa16 = gpu(samples=16)
nvprmsaa4 = gpu(nvpr=true,samples=4)
nvprmsaa16 = gpu(nvpr=true,samples=16)
gpudft = gpu(dit=true)
gpudebug = gpu(api=debug)
gpunull = gpu(api=null)
debug = gpu(api=debug)
nullgpu = gpu(api=null)
BUG=skia:2992
Review URL: https://codereview.chromium.org/
1490113005
kkinnunen [Mon, 14 Dec 2015 07:12:31 +0000 (23:12 -0800)]
Try to fix intermittent GrAutoLocaleSetter crashes on Windows
Try to fix intermittent GrAutoLocaleSetter crashes on Windows.
The string returned by setlocale() is only valid up to
next setlocale(), so it can not be fed to setlocale().
Also, libraries such as ANGLE might call setlocale when
inside a callstack containing GrAutoLocaleSetter. This
would render the old locale pointer invalid.
Review URL: https://codereview.chromium.org/
1514083002
update-skps [Sun, 13 Dec 2015 08:31:51 +0000 (00:31 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
Review URL: https://codereview.chromium.org/
1522753002
benjaminwagner [Fri, 11 Dec 2015 22:08:58 +0000 (14:08 -0800)]
In SkPixmap.cpp, change SkAlphaMul to SkMulDiv255.
Add a test that we get the same color back after calling SkBitmap::eraseColor, modulo rounding.
Also update some incorrect docs.
BUG=skia:4297
Review URL: https://codereview.chromium.org/
1521673002
mtklein [Fri, 11 Dec 2015 20:04:47 +0000 (12:04 -0800)]
archive skpx... currently dead code
BUG=skia:
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
Review URL: https://codereview.chromium.org/
1521623003
benjaminwagner [Fri, 11 Dec 2015 19:26:44 +0000 (11:26 -0800)]
Change google3 sync scripts to sync latest rather than LKGR.
This matches the behavior of the autoroller and is generally more useful.
BUG=skia:
Review URL: https://codereview.chromium.org/
1508313004
joshualitt [Fri, 11 Dec 2015 19:05:43 +0000 (11:05 -0800)]
A change to cleanup some organization around df text
BUG=skia:
Review URL: https://codereview.chromium.org/
1519083002
fmalita [Fri, 11 Dec 2015 19:03:27 +0000 (11:03 -0800)]
New GM: image_scale_aligned
To verify alignment for various image scaling modes.
BUG=skia:4649
R=reed@google.com
Review URL: https://codereview.chromium.org/
1514923002
msarett [Fri, 11 Dec 2015 18:37:39 +0000 (10:37 -0800)]
Change computeOutputColorType() to mimic old behavior
This will prevent behavior changes in BitmapFactory when
switching from SkImageDecoder to SkAndroidCodec.
We will only choose kGray8 if it is explicitly requested (and
also supported).
Additionally, we will always decode GIFS and WBMPS to
kIndex8.
BUG=skia:
Review URL: https://codereview.chromium.org/
1519843002
scroggo [Fri, 11 Dec 2015 18:29:02 +0000 (10:29 -0800)]
Add test for previously unflattenables
BUG=skia:4613
Review URL: https://codereview.chromium.org/
1514373003
scroggo [Fri, 11 Dec 2015 17:49:57 +0000 (09:49 -0800)]
Fix a crash in SkParsePath::FromSVGString
BUG=skia:3491
Review URL: https://codereview.chromium.org/
1515193002
joshualitt [Fri, 11 Dec 2015 16:31:17 +0000 (08:31 -0800)]
remove explicit 'f' in glbench shader
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1503383006
benjaminwagner [Fri, 11 Dec 2015 15:54:24 +0000 (07:54 -0800)]
In BUILD.public, enable SK_SUPPORT_LEGACY_HAIR_IGNORES_CAPS.
Somehow https://codereview.chromium.org/
1491843006 causes fills to change in one test.
BUG=skia:
Review URL: https://codereview.chromium.org/
1516863007
msarett [Fri, 11 Dec 2015 15:38:50 +0000 (07:38 -0800)]
Make BitmapRegionDecoder succeed on invalid requests
If the client requests a color type or alpha type that is
not supported, we should decode to the default/appropriate
color and alpha types to match existing behavior in Android.
BUG=skia:
Review URL: https://codereview.chromium.org/
1513023002
joshualitt [Fri, 11 Dec 2015 14:11:21 +0000 (06:11 -0800)]
Move all text stuff to its own folder
BUG=skia:
Review URL: https://codereview.chromium.org/
1521453002
joshualitt [Fri, 11 Dec 2015 14:08:59 +0000 (06:08 -0800)]
make internaldrawBmpText part of GrTextUtils
BUG=skia:
Review URL: https://codereview.chromium.org/
1518883002
robertphillips [Fri, 11 Dec 2015 12:59:36 +0000 (04:59 -0800)]
Add check for highp support in Conic effect
This CL may not really be necessary since it seems that the Android Ones we have fall back to mediump when highp isn't supported.
FYI, for bits-of-precision/precision we have:
Low Med High Precision-Used
A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad
N5 (Adreno 330) 10 10 23 High - conic looks bad!!!
N6 (Adreno 420) 10 10 23 High - conic looks good
N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!!
N9 (K1) 23 23 23 High - looks good
N10 (Mail-604) 10 10 23 High - looks good
I suspect derivative computation is broken on the Adreno 300s.
BUG=555779,skia:4668
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
1513573009
kkinnunen [Fri, 11 Dec 2015 08:05:33 +0000 (00:05 -0800)]
Initialize glGen* call id args to zero
Initialize glGenTexture, glGenBuffer call id buffer items to zero before
calls. Otherwise it's not easy to check if the call succeeded or not.
Assert the rule in debug gl context.
Make TesselatingPathRendererTests use debug gl context. It exercises
some of the GenBuffers call sites.
Review URL: https://codereview.chromium.org/
1514033002
kkinnunen [Fri, 11 Dec 2015 07:19:29 +0000 (23:19 -0800)]
Run debug gl context for DEF_GPU_TEST_FOR_ALL_CONTEXTS
Run debug gl context for tests defined with
DEF_GPU_TEST_FOR_ALL_CONTEXTS.
Review URL: https://codereview.chromium.org/
1514023002
msarett [Thu, 10 Dec 2015 23:14:27 +0000 (15:14 -0800)]
Revert of DM: fix `--config $VIA-pdf` to not crash (patchset #3 id:40001 of https://codereview.chromium.org/
1513323002/ )
Reason for revert:
I believe that this is breaking master-skia in Android.
Original issue's description:
> DM: fix `--config $VIA-pdf` to not crash
>
> Committed: https://skia.googlesource.com/skia/+/
6bce4177cb72faac9c10d01d57e17168ae7ecadf
TBR=mtklein@google.com,halcanary@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1513053004
msarett [Thu, 10 Dec 2015 22:45:03 +0000 (14:45 -0800)]
Remove flag needed by outdated libpng
BUG=skia:
Review URL: https://codereview.chromium.org/
1514873003
mtklein [Thu, 10 Dec 2015 22:34:23 +0000 (14:34 -0800)]
yet another memcpy -> sk_careful_memcpy
will fix
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3834
No API changes.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1514923003
cdalton [Thu, 10 Dec 2015 22:20:06 +0000 (14:20 -0800)]
Add a warmup flag to visualbench
Adds a flag to control whether we use a warmup bench.
BUG=skia:
Review URL: https://codereview.chromium.org/
1468233003
herb [Thu, 10 Dec 2015 22:17:41 +0000 (14:17 -0800)]
Fix UB function problems for AA merger.
BUG=skia:4634
Review URL: https://codereview.chromium.org/
1518863002
aam [Thu, 10 Dec 2015 22:14:56 +0000 (14:14 -0800)]
Fix 'debugging on Android' android_gdb_app script.
1) com.skia -> com.skia.sample_app
2) pass arguments to android_gdb_app to android_setup.sh so you can build gdbserver binaries for your actual device(rather than default arm64). This allows you to run it like this for example:
./platform_tools/android/bin/android_gdb_app -d nexus_6
BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=
1509853006
Review URL: https://codereview.chromium.org/
1509853006
herb [Thu, 10 Dec 2015 22:12:33 +0000 (14:12 -0800)]
Change SkTaskGroup to use std::function. Ripple all the changes.
BUG=skia:4634
Review URL: https://codereview.chromium.org/
1519573003
scroggo [Thu, 10 Dec 2015 21:46:04 +0000 (13:46 -0800)]
Use size_t for strlen() return value
BUG=skia:2810
Review URL: https://codereview.chromium.org/
1518843002
reed [Thu, 10 Dec 2015 21:44:45 +0000 (13:44 -0800)]
try adding flag to allow lcd text even in a layer
BUG=skia:
Review URL: https://codereview.chromium.org/
1513513002
scroggo [Thu, 10 Dec 2015 21:31:59 +0000 (13:31 -0800)]
Use DEF_GM everywhere
BUG=skia:1902
Review URL: https://codereview.chromium.org/
1518893002
robertphillips [Thu, 10 Dec 2015 21:29:14 +0000 (13:29 -0800)]
Address precision issue in circle blur effect
BUG=560651
Review URL: https://codereview.chromium.org/
1504333003
joshualitt [Thu, 10 Dec 2015 21:20:58 +0000 (13:20 -0800)]
Create GrTextUtils
BUG=skia:
Review URL: https://codereview.chromium.org/
1514933002
msarett [Thu, 10 Dec 2015 21:09:24 +0000 (13:09 -0800)]
Add reallyHasAlpha() to SkAndroidCodec
This also modified the default implementation
of onReallyHasAlpha() in SkCodec.
BUG=skia:
Review URL: https://codereview.chromium.org/
1518743002
halcanary [Thu, 10 Dec 2015 20:46:42 +0000 (12:46 -0800)]
DM: fix `--config $VIA-pdf` to not crash
Review URL: https://codereview.chromium.org/
1513323002
halcanary [Thu, 10 Dec 2015 20:40:23 +0000 (12:40 -0800)]
default SkPixelSerializer
Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function.
Add SkImageEncoder::CreatePixelSerializer() to return a
PixelSerializer that calls into SkImageEncoder::EncodeData.
SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer.
Committed: https://skia.googlesource.com/skia/+/
b0bd1516bff3f5afcbfd615e805867531657811b
Committed: https://skia.googlesource.com/skia/+/
808ce2886d732b1055f89c8fb0f1b11b47fcb0ce
Review URL: https://codereview.chromium.org/
1507123002
borenet [Thu, 10 Dec 2015 20:09:14 +0000 (12:09 -0800)]
Add buildbot spec for Android One bots
BUG=skia:
Review URL: https://codereview.chromium.org/
1517733002
xidachen [Thu, 10 Dec 2015 20:08:44 +0000 (12:08 -0800)]
SkBlurImageFilter returns input when sigma = 0
In the current implementation, a blur filter is always created even in the
case when sigma.fX == 0 && sigma.fY == 0. This CL makes the blur filter
return input in this case.
BUG=568393
Review URL: https://codereview.chromium.org/
1518643002
scroggo [Thu, 10 Dec 2015 19:28:01 +0000 (11:28 -0800)]
Remove unused CallStacker
Found this while looking for uses of strlen (skbug.com/2810). This code
was written by a former member of the team and is not used.
BUG=skia:2810
Review URL: https://codereview.chromium.org/
1512753006
joshualitt [Thu, 10 Dec 2015 19:22:08 +0000 (11:22 -0800)]
Move flush logic into GrAtlasTextBlob
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1518763002
scroggo [Thu, 10 Dec 2015 18:44:13 +0000 (10:44 -0800)]
Switch SkAutoMalloc to SkAutoTMalloc to avoid cast
Make SkAutoTMalloc's interface look more like SkAutoMalloc:
- add free(), which does what you expect
- make reset() return a pointer fPtr
No public API changes (SkAutoTMalloc is in include/private)
BUG=skia:2148
Review URL: https://codereview.chromium.org/
1516833003
halcanary [Thu, 10 Dec 2015 17:30:57 +0000 (09:30 -0800)]
SkPixelSerializer: remove deprecated virtual
Review URL: https://codereview.chromium.org/
1512333002
joshualitt [Thu, 10 Dec 2015 17:10:10 +0000 (09:10 -0800)]
Move DistanceAdjustTable to its own file
BUG=skia:
Review URL: https://codereview.chromium.org/
1512823004
jvanverth [Thu, 10 Dec 2015 17:06:24 +0000 (09:06 -0800)]
Add Apple renderer strings to PowerVR detection
BUG=skia:4148
Review URL: https://codereview.chromium.org/
1512903005
halcanary [Thu, 10 Dec 2015 16:59:43 +0000 (08:59 -0800)]
SkDocument::setDCTEncoder() for old versions of webkit
Review URL: https://codereview.chromium.org/
1505763003
joshualitt [Thu, 10 Dec 2015 16:54:41 +0000 (08:54 -0800)]
Move appending of large glyphs into GrAtlasTextBlob
BUG=skia:
Review URL: https://codereview.chromium.org/
1517563002
scroggo [Thu, 10 Dec 2015 16:54:36 +0000 (08:54 -0800)]
Silence another PNG print statement
It can still be turned on by using setting
c_suppressPNGImageDecoderWarnings to true.
Review URL: https://codereview.chromium.org/
1512293003
caryclark [Thu, 10 Dec 2015 16:03:58 +0000 (08:03 -0800)]
try again on md formatting
TBR=hcm@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1520533002
Review URL: https://codereview.chromium.org/
1520533002
halcanary [Thu, 10 Dec 2015 15:52:45 +0000 (07:52 -0800)]
experiment/fiddle
Review URL: https://codereview.chromium.org/
1349163003
joshualitt [Thu, 10 Dec 2015 15:44:50 +0000 (07:44 -0800)]
Move 'mustRegenerate' function into GrAtlasTextBlob
BUG=skia:
Review URL: https://codereview.chromium.org/
1515543003
mtklein [Thu, 10 Dec 2015 15:42:47 +0000 (07:42 -0800)]
another null src, memcpy -> sk_careful_memcpy
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3798/steps/dm/logs/stdio
BUG=skia:
Review URL: https://codereview.chromium.org/
1510903005
joshualitt [Thu, 10 Dec 2015 15:29:54 +0000 (07:29 -0800)]
Remove uniform color for GrDistanceFieldGeoProc
BUG=skia:
Review URL: https://codereview.chromium.org/
1512533003
caryclark [Thu, 10 Dec 2015 14:29:44 +0000 (06:29 -0800)]
add path ops presentations to skia.org
TBR=hcm@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1518453003
Review URL: https://codereview.chromium.org/
1518453003