Philip Withnall [Mon, 24 Oct 2011 19:20:00 +0000 (20:20 +0100)]
core: Add extra debug for primary store configuration
Travis Reitter [Fri, 21 Oct 2011 23:05:30 +0000 (16:05 -0700)]
Simplify NoteFieldDetails.equal()
Travis Reitter [Fri, 21 Oct 2011 23:05:16 +0000 (16:05 -0700)]
Simplify PhoneFieldDetails.equal()
Travis Reitter [Fri, 21 Oct 2011 22:54:07 +0000 (15:54 -0700)]
Check the GLib.Type of both elements for AbstractFieldDetails.equal()
This simplifies the code for overridden equal() functions.
Travis Reitter [Fri, 21 Oct 2011 16:37:26 +0000 (09:37 -0700)]
Add AbstractFieldDetails.values_equal().
This function is lets subclasses to provide "smart" value comparisons
without needing to factor in the parameters. This is particularly
important for uses like PotententialMatches.
This clarifies the roles of AbstractFieldDetails.equal() and
parameters_equal() (both in form and documentation).
Closes: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Fri, 21 Oct 2011 15:17:41 +0000 (08:17 -0700)]
Migrate PhoneDetails to using AbstractFieldDetails.id
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Thu, 20 Oct 2011 17:24:14 +0000 (10:24 -0700)]
Migrate RoleDetails to AbstractFieldDetails.id
Deprecate Role.uid in favor of AbstractFieldDetails.id
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Fri, 21 Oct 2011 00:11:45 +0000 (17:11 -0700)]
Guarantee all Role members are non-null.
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Thu, 20 Oct 2011 17:23:51 +0000 (10:23 -0700)]
Migrate NoteDetails to AbstractFieldDetails.id
Deprecate NoteFieldDetails.uid in favor of AbstractFieldDetails.id
NoteFieldDetails.equal() now ignores NoteFieldDetails.uid
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Fri, 21 Oct 2011 17:11:55 +0000 (10:11 -0700)]
Guarantee all NoteFieldDetails members are non-null.
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Thu, 20 Oct 2011 17:24:40 +0000 (10:24 -0700)]
Use the most-parent equal() function when comparing postal addresses.
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Thu, 20 Oct 2011 17:23:08 +0000 (10:23 -0700)]
Migrate PostalAddressDetails to using AbstractFieldDetails.id
Deprecate PostalAddress.uid in favor of AbstractFieldDetails.id
PostalAddress.equal() now ignores PostalAddress.uid
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Thu, 20 Oct 2011 17:19:28 +0000 (10:19 -0700)]
Add AbstractFieldDetails.id to identify instances of details.
This will unify the way we handle IDs for the various classes that
derive from AbstractFieldDetails for eccentric data stores (I'm
looking at you, Tracker).
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Thu, 20 Oct 2011 05:42:51 +0000 (22:42 -0700)]
Only add non-empty Role components to Edsf.Personas.
The EDS test "set-roles" was failing because some empty parameters were
getting added to Edsf.Personas, thus failing parameter equality checks.
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Thu, 20 Oct 2011 05:50:15 +0000 (22:50 -0700)]
Properly set the parameters for the eds/set-phones test
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Thu, 20 Oct 2011 02:45:29 +0000 (19:45 -0700)]
Fix eds test add-persona for param matching
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Thu, 20 Oct 2011 02:30:33 +0000 (19:30 -0700)]
Fix the params used for the postal-address-details eds test
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Wed, 19 Oct 2011 21:18:23 +0000 (14:18 -0700)]
Always include parameters in AFD-derived subclass equal() functions.
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Wed, 19 Oct 2011 22:48:28 +0000 (15:48 -0700)]
Factor out AFD parameter equality (for use in derived classes)
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Wed, 19 Oct 2011 21:23:41 +0000 (14:23 -0700)]
Fix the signature of RoleFieldDetails.equal()
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Wed, 19 Oct 2011 22:30:40 +0000 (15:30 -0700)]
Add test for RoleFieldDetails.
Helps: bgo#662433 - AbstractFieldDetails.equal() is ambiguous about
checking parameters.
Travis Reitter [Thu, 20 Oct 2011 17:13:35 +0000 (10:13 -0700)]
Fix trivial spacing issues.
Alexander Larsson [Thu, 20 Oct 2011 11:58:01 +0000 (13:58 +0200)]
Correctly update email based im addresses during contact changes
When we have already read a contact, but are updating it e.g. due
to a property change there is a problem in
Edsf.Persons._update_im_addressess(). Its looking at the existing
personas im_addresses for already existing im addresses before adding
new ones. However, they were already added there based on the email
addresses last time, which means we don't add them now.
The fix is simple, just look in new_im_addressess for existing
im_addresses.
https://bugzilla.gnome.org/show_bug.cgi?id=662285
Travis Reitter [Tue, 18 Oct 2011 17:51:55 +0000 (10:51 -0700)]
Post-release version bump.
Travis Reitter [Tue, 18 Oct 2011 17:20:56 +0000 (10:20 -0700)]
Release version 0.6.4.1
Travis Reitter [Tue, 18 Oct 2011 17:00:35 +0000 (10:00 -0700)]
Fix the SONAME.
We accidentally decreased the SONAME with the 0.6.4 release, so this
adjusts the various easy-to-understand/impossible-to-confuse libtool
numbers.
Closes: bgo#662095
Travis Reitter [Tue, 18 Oct 2011 17:04:30 +0000 (10:04 -0700)]
Marginally clarify our comments for the lt numbers.
This should help us avoid mangling them in the future.
Don't quote me on that.
Travis Reitter [Tue, 18 Oct 2011 04:43:40 +0000 (21:43 -0700)]
Post-release version bump.
Travis Reitter [Mon, 17 Oct 2011 18:54:47 +0000 (11:54 -0700)]
Release version 0.6.4
Travis Reitter [Tue, 18 Oct 2011 03:56:59 +0000 (20:56 -0700)]
build: Fix explicit build dependency to un-break vala-free builds.
Travis Reitter [Tue, 18 Oct 2011 00:24:47 +0000 (17:24 -0700)]
build: Distribute test-dependent makefiles.
This is mainly to enable running "make foo.gdb" from the source
distribution.
Travis Reitter [Mon, 17 Oct 2011 23:45:34 +0000 (16:45 -0700)]
build: Include internal folks library for valadoc parsing issues
Obviously, these symbols shouldn't be documented externally, but since
valadoc uses libvala internal, it requires the ability to resolve them
(even if they won't be exposed in the finals docs).
Travis Reitter [Mon, 17 Oct 2011 23:35:51 +0000 (16:35 -0700)]
build: Require valac if libfolks-internal files are missing.
Travis Reitter [Mon, 17 Oct 2011 23:15:49 +0000 (16:15 -0700)]
build: Fix the libfolks path to libfolks-internal.la
Travis Reitter [Mon, 17 Oct 2011 19:24:07 +0000 (12:24 -0700)]
build: Fix test ObjectCache for internal API breaks.
Philip Withnall [Sun, 16 Oct 2011 08:24:57 +0000 (09:24 +0100)]
telepathy: Add support for caching vCard parameters for contacts
Add birthday, full name, e-mail address, phone number and URL support to the
Telepathy object cache so that contacts’ vCards are correctly stored when
the cache is updated.
Closes: bgo#661475
Philip Withnall [Sun, 16 Oct 2011 08:23:29 +0000 (09:23 +0100)]
core: Add support for object version migration in object cache files
Add the ability for the variant type used in object cache files to vary with
the cache file version, and for object cache implementations to claim they
don't support given versions.
Helps: bgo#661475
Philip Withnall [Sun, 16 Oct 2011 08:19:29 +0000 (09:19 +0100)]
telepathy: Fix mixed-assignments-and-declarations warning in test library
Matej Urbančič [Mon, 17 Oct 2011 13:14:48 +0000 (15:14 +0200)]
Updated Slovenian translation
Piotr Drąg [Fri, 14 Oct 2011 13:27:13 +0000 (15:27 +0200)]
Updated Polish translation
Daniel Mustieles [Fri, 14 Oct 2011 11:59:36 +0000 (13:59 +0200)]
Updated Spanish translation
Daniel Mustieles [Fri, 14 Oct 2011 11:58:44 +0000 (13:58 +0200)]
Updated Spanish translation
Travis Reitter [Thu, 13 Oct 2011 17:48:51 +0000 (10:48 -0700)]
Clarify in configure output that we require 0.6 <= gee <= 0.8.
Closes: bgo#660937 - [regression] build failure: No package 'gee-1.0' found
Travis Reitter [Tue, 11 Oct 2011 21:46:34 +0000 (14:46 -0700)]
Fix our birthday string parsing for Telepathy backend.
Travis Reitter [Mon, 10 Oct 2011 17:54:58 +0000 (10:54 -0700)]
Don't prepare the Telepathy Connection until it's guaranteed to exist.
Travis Reitter [Mon, 10 Oct 2011 18:07:01 +0000 (11:07 -0700)]
Distinguish Telepathy errors with new UNSUPPORTED_ON_NON_USER
Travis Reitter [Mon, 10 Oct 2011 02:11:07 +0000 (19:11 -0700)]
Support Birthdays for the Telepathy backend.
Travis Reitter [Sun, 9 Oct 2011 23:39:52 +0000 (16:39 -0700)]
Support UrlDetails for the Telepathy backend.
Travis Reitter [Fri, 7 Oct 2011 20:39:03 +0000 (13:39 -0700)]
Support EmailDetails for the Telepathy backend.
Travis Reitter [Fri, 7 Oct 2011 18:26:30 +0000 (11:26 -0700)]
Split utility functions into an internal library.
This lets us avoid stuffing them into unrelated public libraries.
Travis Reitter [Thu, 6 Oct 2011 22:46:22 +0000 (15:46 -0700)]
Memoize the ContactInfo SupportedFields values.
Travis Reitter [Thu, 6 Oct 2011 18:37:59 +0000 (11:37 -0700)]
Factor in server-side writeability of ContactInfo fields.
Travis Reitter [Thu, 6 Oct 2011 22:00:46 +0000 (15:00 -0700)]
Include required Telepathy Connection ContactInfo features.
These are required to look up the connection's ContactInfoFlags.Can_Set
and SupportedFields. We need both to determine which ContactInfo fields
are writeable (for Tpf.Persona.writeable_properties).
Travis Reitter [Thu, 6 Oct 2011 16:57:57 +0000 (09:57 -0700)]
Reorganize tp/individual-properties test.
Travis Reitter [Thu, 6 Oct 2011 16:54:54 +0000 (09:54 -0700)]
Add assertions about Telepathy writeable properties to our tests.
Travis Reitter [Wed, 5 Oct 2011 22:08:15 +0000 (15:08 -0700)]
Ensure that our test self contact has an identifier.
Travis Reitter [Wed, 5 Oct 2011 21:40:58 +0000 (14:40 -0700)]
Print contact info for Telepathy contacts in tests.
Travis Reitter [Fri, 30 Sep 2011 17:54:15 +0000 (10:54 -0700)]
Support writing extended info for Telepathy user contacts
Helps: bgo#657602 - Telepathy backend fails to set Personas' phone
numbers from ContactInfo
Travis Reitter [Thu, 29 Sep 2011 21:44:35 +0000 (14:44 -0700)]
Implement ContactInfo in the Telepathy test backend.
Helps: bgo#657602 - Telepathy backend fails to set Personas' phone
numbers from ContactInfo
Raul Gutierrez Segales [Mon, 19 Sep 2011 17:24:34 +0000 (18:24 +0100)]
Telepathy: implement PhoneDetails for Tpf.Persona
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=657602
Raul Gutierrez Segales [Mon, 19 Sep 2011 17:11:56 +0000 (18:11 +0100)]
Move SetComparator into folks/utils so it can be used by other backends
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=657602
Kristjan SCHMIDT [Sun, 2 Oct 2011 08:26:37 +0000 (10:26 +0200)]
Add Esperanto translation
Jorge González [Sat, 1 Oct 2011 14:11:32 +0000 (16:11 +0200)]
Updated Spanish translation
Travis Reitter [Tue, 27 Sep 2011 20:47:50 +0000 (13:47 -0700)]
Also update tracker-sparql versions for Tracker backend.
Closes: bgo#660217 - folks-0.6.3.2 requires tracker-0.12, but
configure.ac calls VALA_CHECK_PACKAGES([tracker-sparql-0.10])
Travis Reitter [Tue, 27 Sep 2011 15:12:17 +0000 (08:12 -0700)]
Use consistent version checking for tracker-sparql-0.12
Closes: bgo#660217 - folks-0.6.3.2 requires tracker-0.12, but
configure.ac calls VALA_CHECK_PACKAGES([tracker-sparql-0.10])
Raul Gutierrez Segales [Tue, 27 Sep 2011 12:47:16 +0000 (13:47 +0100)]
core: add debug info about configured primary store
Travis Reitter [Tue, 27 Sep 2011 00:57:32 +0000 (17:57 -0700)]
Post-release version bump.
Travis Reitter [Tue, 27 Sep 2011 00:16:50 +0000 (17:16 -0700)]
Release version 0.6.3.2
Travis Reitter [Mon, 26 Sep 2011 23:23:51 +0000 (16:23 -0700)]
Require Tracker 0.12
Closes: bgo#660051 - require tracker 0.12
Travis Reitter [Mon, 26 Sep 2011 22:07:05 +0000 (15:07 -0700)]
Don't assume that "CONNECTED" Tp.Accounts have valid Tp.Connections
There's an in-between state where the Tp.Account is "CONNECTED" but hasn't
finished preparing its Tp.Connection (and thus, it's null).
Closes: bgo#659041 — tpf-persona-store.vala: try to connect to a NULL object
Philip Withnall [Mon, 26 Sep 2011 22:36:39 +0000 (15:36 -0700)]
Ensure we prepare all TpAccounts before trying to use them.
Helps: bgo#659041 - tpf-persona-store.vala: try to connect to a NULL object
Travis Reitter [Mon, 26 Sep 2011 22:44:47 +0000 (15:44 -0700)]
More-tightly scope variable in EDS backend.
Travis Reitter [Mon, 26 Sep 2011 16:44:39 +0000 (09:44 -0700)]
Actually fall back to eds:system in case there's no default address book.
Closes: bgo#660140 - contacts_contact_find_persona_from_store: assertion `store
!= NULL' failed
Christian Kirbach [Sat, 24 Sep 2011 09:03:36 +0000 (11:03 +0200)]
[l10n] Updated German translation
Travis Reitter [Fri, 23 Sep 2011 22:55:39 +0000 (15:55 -0700)]
Trivial NEWS fix.
Travis Reitter [Fri, 23 Sep 2011 22:54:52 +0000 (15:54 -0700)]
Note in the NEWS that we fixed bgo#659732 before the 0.6.3.1 release.
Travis Reitter [Fri, 23 Sep 2011 20:19:14 +0000 (13:19 -0700)]
Post-release version bump.
Travis Reitter [Thu, 22 Sep 2011 16:45:05 +0000 (09:45 -0700)]
Release version 0.6.3.1
Travis Reitter [Fri, 23 Sep 2011 01:26:06 +0000 (18:26 -0700)]
Make sure we source GConf files installed next to us.
Travis Reitter [Fri, 23 Sep 2011 00:00:41 +0000 (17:00 -0700)]
Deal with lingering callbacks in the eds/set-avatar test.
These can be called after we've set this._main_loop = null,
so if we don't check it first, we'll hit warnings (which get
treated as errors).
This isn't an ideal solution, but there doesn't seem to be a
great way to avoid the handlers from firing after we no
longer care (we need something like thaw/freeze_notify(),
except for general signals, not just notify).
Travis Reitter [Thu, 22 Sep 2011 17:37:37 +0000 (10:37 -0700)]
Serialize checks for completion in EDS test.
We were interleaving checks which resulted in inconsistent behavior.
Travis Reitter [Thu, 22 Sep 2011 17:30:15 +0000 (10:30 -0700)]
Exit EDS test early in case multiple signal emissions are in-flight.
This fixes a race between the mainloop being nullified and a dependent
signal handler calling quit() again (no idea how the signals were
getting issued and handled after the initial quit() though).
Raul Gutierrez Segales [Wed, 21 Sep 2011 22:05:42 +0000 (23:05 +0100)]
eds: split up link-personas test and cut relative URI dependency
Though some code might be duplicated, it's healthy to split tests
into different executables to assure our clean-up code (wiping out
GConf entries, shutting down our own session Bus, etc) runs between
tests.
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=659732
Raul Gutierrez Segales [Wed, 21 Sep 2011 21:07:27 +0000 (22:07 +0100)]
eds: rework tests so that they don't depend on relative URIs
Previously, tests were build around the assumption that each
Edsf.PersonaStore had an id == ESource.relative_uri. That
stopped being true (because you'll get swallowed by a black
hole in pwithnall's garden if you use relative URIs).
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=659732
Raul Gutierrez Segales [Wed, 21 Sep 2011 15:24:30 +0000 (16:24 +0100)]
e-d-s: use UID instead of relative URI to track ESources
Some e-d-s backends (i.e.: the Exchange one) might not have
a relative URI so we can't rely on it as an address book
identifier. So from now on we use the ESource's UID.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=659732
Raul Gutierrez Segales [Wed, 21 Sep 2011 20:35:20 +0000 (21:35 +0100)]
tpf: no need to use a lambda since callback exists
Raul Gutierrez Segales [Wed, 21 Sep 2011 19:25:54 +0000 (20:25 +0100)]
tpf: don't unprepare the backend if it isn't prepared
Travis Reitter [Wed, 21 Sep 2011 18:09:21 +0000 (11:09 -0700)]
Clean up variables in Tpf test to match Edsf test.
Travis Reitter [Wed, 21 Sep 2011 18:07:37 +0000 (11:07 -0700)]
Check for expected-missing capabilities in PersonaStore tests.
Travis Reitter [Wed, 21 Sep 2011 16:49:02 +0000 (09:49 -0700)]
Use PersonaStore.always_writeable_properties.
This removes references to the deprecated
PersonaStore.can_alias_personas and PersonaStore.can_group_personas
Closes: bgo#659737 - tests fail due to usage of deprecated methods
Colin Walters [Wed, 21 Sep 2011 16:13:31 +0000 (12:13 -0400)]
build: Fix regular expression to extract dlname
The regex writer unintentially made a character range in ".-+".
This was always wrong, but it actively fails when LANG=C.
Closes: bgo#658002 - defective typelib
Raul Gutierrez Segales [Mon, 19 Sep 2011 11:38:08 +0000 (12:38 +0100)]
Deprecate PersonaStore.can-[alias|group]-personas
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=658332
Matej Urbančič [Tue, 20 Sep 2011 11:17:07 +0000 (13:17 +0200)]
Updated Slovenian translation
Matej Urbančič [Tue, 20 Sep 2011 11:07:06 +0000 (13:07 +0200)]
Updated Slovenian translation
Matej Urbančič [Mon, 19 Sep 2011 14:14:53 +0000 (16:14 +0200)]
Updated Slovenian translation
Raul Gutierrez Segales [Mon, 19 Sep 2011 11:09:24 +0000 (12:09 +0100)]
Update NEWS file for next release
Philip Withnall [Sun, 18 Sep 2011 18:32:44 +0000 (19:32 +0100)]
build: Post-release version bump
Philip Withnall [Sun, 18 Sep 2011 18:30:23 +0000 (19:30 +0100)]
build: Release version 0.6.3
Philip Withnall [Sun, 18 Sep 2011 18:01:31 +0000 (19:01 +0100)]
url-details: s/HOMEPAGE/HOME_PAGE/
Quick, before this gets released and frozen!
Philip Withnall [Sun, 18 Sep 2011 17:24:50 +0000 (18:24 +0100)]
eds: Fix potential false matches in _is_in_source_list()
It's possible for the relative URIs of two ESources to be equal (though it's
unlikely). Consequently, we need to compare by UID as well.