platform/upstream/efl.git
4 years agoelm_interface_scrollable: correctly handle bouncing
Marcel Hollerbach [Fri, 25 Oct 2019 18:04:46 +0000 (14:04 -0400)]
elm_interface_scrollable: correctly handle bouncing

Summary:
if bounding is enabled, those values can get smaller and bigger than the
max value.

ref T4918

Depends on D9906

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T4918

Differential Revision: https://phab.enlightenment.org/D9907

4 years agotheme: redo scroller theme of elm
Marcel Hollerbach [Fri, 25 Oct 2019 18:04:39 +0000 (14:04 -0400)]
theme: redo scroller theme of elm

Summary:
this was a little bit weird. There was a script that did what we already
do in C and pass it on via signals, however, there was also somewhere a
bug in this script, the arrow was not getting enabled, even if the
position is not completly max and not completly min, the problem here
was that the numbers that are passed to edje are not 100% correct (I
think they got somehwere on the way casted to an int).

With this commit we just use the signals from c in the theme and replace
the theme, this should also make everything a bit easier on the
mainloop, as a single movement of the scroller does not schedule 10
timers anymore.

ref T4918

Reviewers: zmike, eagleeye, woohyun

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T4918

Differential Revision: https://phab.enlightenment.org/D9906

4 years agoci: use shell to directly set base_dir for osx builds
Mike Blumenkrantz [Fri, 25 Oct 2019 17:33:41 +0000 (13:33 -0400)]
ci: use shell to directly set base_dir for osx builds

Summary: this crashes somehow and is impossible to debug remotely

Reviewers: bu5hm4n

Reviewed By: bu5hm4n

Subscribers: bu5hm4n, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10529

4 years agocsharp: Using Array.Empty Eina.
Bruno da Silva Belo [Fri, 25 Oct 2019 16:49:24 +0000 (13:49 -0300)]
csharp: Using Array.Empty Eina.

Summary: ref T8421

Reviewers: lauromoura, felipealmeida, segfaultxavi, YOhoho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8421

Differential Revision: https://phab.enlightenment.org/D10500

4 years agocsharp:Using Array.Empty genericmodel.
Bruno da Silva Belo [Fri, 25 Oct 2019 16:57:48 +0000 (13:57 -0300)]
csharp:Using Array.Empty genericmodel.

Summary: ref T8421

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8421

Differential Revision: https://phab.enlightenment.org/D10501

4 years agocsharp: Changing Count() to Length on eina_value.
Bruno da Silva Belo [Fri, 25 Oct 2019 16:08:37 +0000 (13:08 -0300)]
csharp: Changing Count() to Length on eina_value.

Summary: ref T8422

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8422

Differential Revision: https://phab.enlightenment.org/D10499

4 years agocsharp: Using Count eina_promises.
Bruno da Silva Belo [Fri, 25 Oct 2019 16:06:59 +0000 (13:06 -0300)]
csharp: Using Count eina_promises.

Summary: ref T8422

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8422

Differential Revision: https://phab.enlightenment.org/D10498

4 years agocsharp: Calling ConfigureAwait on tasks GM.
Bruno da Silva Belo [Fri, 25 Oct 2019 14:23:08 +0000 (11:23 -0300)]
csharp: Calling ConfigureAwait on tasks GM.

Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10497

4 years agocsharp: Calling ConfigureAwait on tasks Model.
Bruno da Silva Belo [Fri, 25 Oct 2019 14:22:35 +0000 (11:22 -0300)]
csharp: Calling ConfigureAwait on tasks Model.

Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10496

4 years agocsharp: Calling ConfigureAwait on task eopromises.
Bruno da Silva Belo [Fri, 25 Oct 2019 14:17:53 +0000 (11:17 -0300)]
csharp: Calling ConfigureAwait on task eopromises.

Summary: ref T8424

Reviewers: lauromoura, felipealmeida, YOhoho, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8424

Differential Revision: https://phab.enlightenment.org/D10495

4 years agomono: implement dispose method based on dispose pattern
Yeongjong Lee [Thu, 24 Oct 2019 20:46:13 +0000 (17:46 -0300)]
mono: implement dispose method based on dispose pattern

Summary:
Fix CA1063, CA1816
ref T8400, T8419

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: felipealmeida, brunobelo, YOhoho

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8419, T8400

Differential Revision: https://phab.enlightenment.org/D10460

4 years agotests/layout: add legacy layout test to verify behavior with legacy size hints
Mike Blumenkrantz [Fri, 25 Oct 2019 13:42:41 +0000 (09:42 -0400)]
tests/layout: add legacy layout test to verify behavior with legacy size hints

Summary:
this verifies that user-set legacy size hints will be applied accurately during
calc, and that the size of a layout can accurately decrease when its contents min
sizes decrease

ref 95b5731461c53df2691ef43db61f321de5b366d3

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10453

4 years agoefl_ui/text_scroller: fix null derefs
Mike Blumenkrantz [Fri, 25 Oct 2019 13:42:33 +0000 (09:42 -0400)]
efl_ui/text_scroller: fix null derefs

Summary: CIDs 1403890, 1396964, 1396945

Reviewers: cedric, vtorri

Reviewed By: cedric

Subscribers: vtorri, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10447

4 years agocsharp: Returning only method name iwrapper.
Bruno da Silva Belo [Thu, 24 Oct 2019 21:50:48 +0000 (18:50 -0300)]
csharp: Returning only method name iwrapper.

Summary:
GetUserMethods returning only strings,
not the whole method informations.

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10503

4 years agoefl_ui_relative_layout: change child, target parameter type to Efl.Gfx.Entity
Yeongjong Lee [Tue, 15 Oct 2019 06:21:16 +0000 (06:21 +0000)]
efl_ui_relative_layout: change child, target parameter type to Efl.Gfx.Entity

child, target should be graphical object.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10401

4 years agoelm/code: check save file attrs after opening
Mike Blumenkrantz [Thu, 17 Oct 2019 14:23:34 +0000 (10:23 -0400)]
elm/code: check save file attrs after opening

ensure that they haven't changed between time of check and time of open

CID 1396966

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10440

4 years agoefl_message: add pending queue for filtering message.
Hosang Kim [Thu, 24 Oct 2019 07:27:37 +0000 (07:27 +0000)]
efl_message: add pending queue for filtering message.

Sometimes message is appended when message queue is walking.
In this case, newly added messages are not filtered.
So I add message pending queue for filtering message.

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D10459

4 years agoeina_mono: re-throw exception to preserve stack details
Yeongjong Lee [Thu, 24 Oct 2019 21:21:39 +0000 (18:21 -0300)]
eina_mono: re-throw exception to preserve stack details

Summary:
fix CA2200
ref T8426

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8426

Differential Revision: https://phab.enlightenment.org/D10462

4 years agoeina_mono: Initialize UNHANDLED_EXCEPTION inline
Yeongjong Lee [Thu, 24 Oct 2019 21:24:07 +0000 (18:24 -0300)]
eina_mono: Initialize UNHANDLED_EXCEPTION inline

Summary:
fix CA2207
ref T8427

Test Plan:
meson setup -Dbindings=mono,cxx -Dmono-beta=true
ninja test

Reviewers: lauromoura, felipealmeida, brunobelo

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8427

Differential Revision: https://phab.enlightenment.org/D10463

4 years agocsharp: Add since information to EoWrapper.cs
Lauro Moura [Thu, 24 Oct 2019 16:42:40 +0000 (18:42 +0200)]
csharp: Add since information to EoWrapper.cs

Reviewers: brunobelo, segfaultxavi, felipealmeida, woohyun

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10429

4 years agotests/ecore: ensure that we attempt to re-set PATH in ecore-file tests
Mike Blumenkrantz [Thu, 24 Oct 2019 16:23:14 +0000 (18:23 +0200)]
tests/ecore: ensure that we attempt to re-set PATH in ecore-file tests

Summary:
if this test failed before for any reason, PATH would be permanently changed
for the current shell and process, which is obviously not what we want
Depends on D10414

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10415

4 years agotests/ecore: replace all bespoke strcats with snprintf
Mike Blumenkrantz [Thu, 24 Oct 2019 16:23:11 +0000 (18:23 +0200)]
tests/ecore: replace all bespoke strcats with snprintf

Summary:
CID 1400812
Depends on D10413

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10414

4 years agotests/ecore: unset app args after app args unit test to prevent invalid reads
Mike Blumenkrantz [Thu, 24 Oct 2019 16:23:03 +0000 (18:23 +0200)]
tests/ecore: unset app args after app args unit test to prevent invalid reads

Summary:
various internal components in efl access the app args and read them which
will result in invalid memory access since these are stack-allocated strings
Depends on D10412

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10413

4 years agoecore/app: permit resetting app args to uninitialized (zeroed) state
Mike Blumenkrantz [Thu, 24 Oct 2019 16:14:25 +0000 (18:14 +0200)]
ecore/app: permit resetting app args to uninitialized (zeroed) state

Summary:
this is mainly useful for unit testing, but unsetting values should not be
treated as an error

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10412

4 years agotests/eina: use slstr_steal function in slstr_steal test
Mike Blumenkrantz [Thu, 24 Oct 2019 15:53:23 +0000 (17:53 +0200)]
tests/eina: use slstr_steal function in slstr_steal test

Summary: CID 1401043

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10404

4 years agotests/spec: free array in multi selectable tests
Mike Blumenkrantz [Thu, 24 Oct 2019 15:43:19 +0000 (17:43 +0200)]
tests/spec: free array in multi selectable tests

Summary: CIDs 1405810, 1405807, 1405806, 1405805, 1405803, 1405801, 1403902

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10403

4 years agomono: merge namespaces in manual bindings
Yeongjong Lee [Thu, 24 Oct 2019 15:18:44 +0000 (17:18 +0200)]
mono: merge namespaces in manual bindings

Summary:
It will enhance readability.
Before
```
namespace Efl {
namespace Eo {
```

After
```
namespace Efl.Eo {
```

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, Jaehyun_Cho, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10466

4 years agocxx: Add license to CXX bindings.
Felipe Magno de Almeida [Thu, 24 Oct 2019 13:36:42 +0000 (10:36 -0300)]
cxx: Add license to CXX bindings.

Summary:
Like C#, it will also be Apache 2.0

Depends on D9414

Reviewers: vitor.sousa, woohyun, jpeg, lauromoura

Reviewed By: lauromoura

Subscribers: jpeg, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9418

4 years agocsharp: Add licensing information.
Lauro Moura [Thu, 24 Oct 2019 13:01:50 +0000 (10:01 -0300)]
csharp: Add licensing information.

Summary:
C# bindings will be lincensed under Apache Sofware License 2.0.

This commit adds the license text to the licenses folder and a copyright
notice to the binding files.

Fixes T8039

Reviewers: woohyun, felipealmeida, vitor.sousa

Reviewed By: felipealmeida

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8039

Differential Revision: https://phab.enlightenment.org/D9414

4 years agoexamples/efl_thread: fix oob writes
Mike Blumenkrantz [Thu, 24 Oct 2019 12:50:27 +0000 (14:50 +0200)]
examples/efl_thread: fix oob writes

Summary: CIDs 1403896, 1403895, 1403892

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10395

4 years agoexamples/ecore: use correct type for getchar() return
Mike Blumenkrantz [Thu, 24 Oct 2019 12:35:28 +0000 (14:35 +0200)]
examples/ecore: use correct type for getchar() return

Summary:
correct prototype is int getchar(void);

CID 1400794

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10391

4 years agospaces--
Carsten Haitzler (Rasterman) [Thu, 24 Oct 2019 12:13:29 +0000 (13:13 +0100)]
spaces--

4 years agoeina: remove eina_config.h.in
Daniel Kolesa [Wed, 23 Oct 2019 13:51:34 +0000 (15:51 +0200)]
eina: remove eina_config.h.in

This is never actually used since meson generates eina_config.h
from scratch. Apart from the byteswap checks done in the previous
commit, all of the other things already seem to be done by meson,
so just remove it.

4 years agoeina: unbreak byteswap checks
Daniel Kolesa [Wed, 23 Oct 2019 13:44:22 +0000 (15:44 +0200)]
eina: unbreak byteswap checks

For one, eina_config.h.in is never used by anything since meson,
so doing any checks in it and expecting them to work is wrong.
Byteswaps are one place where this is the case, so move the
checks back in their appropriate place.

4 years agodocs: small fixes to Efl.Text
Xavi Artigas [Wed, 23 Oct 2019 08:15:30 +0000 (10:15 +0200)]
docs: small fixes to Efl.Text

4 years agoecore-evas-wayland: Minor formatting fixes
Christopher Michael [Tue, 22 Oct 2019 14:59:29 +0000 (10:59 -0400)]
ecore-evas-wayland: Minor formatting fixes

NB: No functional changes

4 years agoecore-wl2: Minor formatting fix
Christopher Michael [Tue, 22 Oct 2019 14:42:54 +0000 (10:42 -0400)]
ecore-wl2: Minor formatting fix

NB: No functional changes

4 years agoecore_evas_wayland: Fix array step size
Christopher Michael [Tue, 22 Oct 2019 14:12:51 +0000 (10:12 -0400)]
ecore_evas_wayland: Fix array step size

Fix bug where eina_array step size was being increased by 10 everytime
a handler was pushed to the array. There is no need to increase array
size by 10 each time we add 1 pointer to handler.

@fix

4 years agoecore-evas-wayland: Add handler to array
Christopher Michael [Tue, 22 Oct 2019 14:11:24 +0000 (10:11 -0400)]
ecore-evas-wayland: Add handler to array

Small patch to fix bug where last event handler was not being added to
the event_hdls array

@fix

4 years agoecore-evas-wayland: Minor formatting fix
Christopher Michael [Tue, 22 Oct 2019 14:06:23 +0000 (10:06 -0400)]
ecore-evas-wayland: Minor formatting fix

NB: No functional changes

4 years agoecore-evas-wayland: Minor formatting fix
Christopher Michael [Tue, 22 Oct 2019 14:04:01 +0000 (10:04 -0400)]
ecore-evas-wayland: Minor formatting fix

NB: No functional changes

4 years agoeina: fix network byte order swap funcs on big endian
Daniel Kolesa [Sun, 20 Oct 2019 16:49:04 +0000 (18:49 +0200)]
eina: fix network byte order swap funcs on big endian

4 years agobuild: resolve migration build error
Jongmin Lee [Mon, 21 Oct 2019 23:24:41 +0000 (08:24 +0900)]
build: resolve migration build error

Change-Id: I7ab5cb4a3e283546a25670ab35f03db25a1918b3

4 years agoevas_object_textblock: add support for variation sequences
Ali Alzyod [Sat, 19 Oct 2019 05:01:36 +0000 (14:01 +0900)]
evas_object_textblock: add support for variation sequences

Summary: update font processing to handle variation sequences unicodes to select proper glypg in respect to variation seqences

Test Plan:
```

EAPI_MAIN int
elm_main(int argc, char **argv)
{
   Evas_Object *win, *textblock;

   elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);

   win = elm_win_util_standard_add("Main", "");
   elm_win_autodel_set(win, EINA_TRUE);
   textblock = evas_object_textblock_add(win);
   efl_canvas_text_style_set(textblock,NULL,"DEFAULT='font=DejaVuSans font_fallbacks=SamsungColorEmoji color=#000 font_size=20'");
   evas_object_textblock_text_markup_set(textblock, "8&#xfe0f;&#x20E3;&#x262a;&#xfe0f;AAA&#x262a;&#xfe0E;1234567&#xfe0f;&#x20E3;");

   evas_object_size_hint_weight_set(textblock, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(textblock, EVAS_HINT_FILL, EVAS_HINT_FILL);
   evas_object_show(textblock);
   evas_object_move(textblock, 0, 0);
   evas_object_resize(textblock, 320, 320);
   evas_object_resize(win, 320, 320);
   evas_object_show(win);
   elm_run();
   return 0;

}

ELM_MAIN()

```

Reviewers: woohyun, bowonryu, segfaultxavi, cedric, bu5hm4n

Reviewed By: woohyun, cedric

Subscribers: bu5hm4n, subodh6129, herdsman, segfaultxavi, zmike, cedric, #committers, #reviewers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D9053

4 years agofix various trivial null derefs
Mike Blumenkrantz [Fri, 18 Oct 2019 17:30:10 +0000 (13:30 -0400)]
fix various trivial null derefs

Summary:
CIDs 1401081, 1401044, 1400983, 1400960, 1400927, 1400799, 1396946, 1396944,
     1383851, 1383847, 1382211, 1379921, 1379921

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10452

4 years agoefl/io: return EINVAL if null slice is passed for writing
Mike Blumenkrantz [Fri, 18 Oct 2019 17:30:03 +0000 (13:30 -0400)]
efl/io: return EINVAL if null slice is passed for writing

Summary: CIDs 1396996, 1396983, 1396953

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10451

4 years agotests/ecore_con: clarify pointer usage in ecore_con_url tests
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:57 +0000 (13:29 -0400)]
tests/ecore_con: clarify pointer usage in ecore_con_url tests

Summary:
this was pretty bizarre

CID 1401029

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10450

4 years agoelm/main: fix null deref
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:51 +0000 (13:29 -0400)]
elm/main: fix null deref

Summary: CID 1402697

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10449

4 years agoefl/engines: fix null derefs
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:44 +0000 (13:29 -0400)]
efl/engines: fix null derefs

Summary: CIDs 1402640, 1402709

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10448

4 years agoevas_vg/svg: fix null deref
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:38 +0000 (13:29 -0400)]
evas_vg/svg: fix null deref

Summary: CID 1405672

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10446

4 years agoeina/convert: init endptr in failure case of eina_convert_strtod_c
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:32 +0000 (13:29 -0400)]
eina/convert: init endptr in failure case of eina_convert_strtod_c

Summary:
there is not any way to determine that this function has failed other
than to check this pointer, so ensure that it always has a value which
is meaningful in failure cases

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10445

4 years agoefl/boolean_model: remove misleading null check
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:26 +0000 (13:29 -0400)]
efl/boolean_model: remove misleading null check

Summary:
this is always a pointer to a stack variable

CID 1405799

Reviewers: cedric

Reviewed By: cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10444

4 years agoembryo: don't use sizeof() when strlen() is intended
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:20 +0000 (13:29 -0400)]
embryo: don't use sizeof() when strlen() is intended

Summary: CID 1402617

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10411

4 years agotests: fix minor string leaks
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:13 +0000 (13:29 -0400)]
tests: fix minor string leaks

Summary: CIDs 1404754, 1401022, 1400965

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10405

4 years agobenchmarks/eina: fix possible div by zero in ecore_hash
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:07 +0000 (13:29 -0400)]
benchmarks/eina: fix possible div by zero in ecore_hash

Summary: CID 1400768

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10397

4 years agoecore/main: avoid calling FD_SET with invalid fd value
Mike Blumenkrantz [Fri, 18 Oct 2019 17:29:01 +0000 (13:29 -0400)]
ecore/main: avoid calling FD_SET with invalid fd value

Summary:
it's possible that _ecore_get_epoll_fd() can return -1, so ensure that we
correctly handle this

CID 1383850

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10394

4 years agoecore/getopt: handle negative return in arg parsing
Mike Blumenkrantz [Fri, 18 Oct 2019 17:28:54 +0000 (13:28 -0400)]
ecore/getopt: handle negative return in arg parsing

Summary:
_ecore_getopt_parse_find_nonargs_base() can return -1 on errors

CID 1402615

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10393

4 years agotests/eldbus: add va_end for va_args usage in message test
Mike Blumenkrantz [Fri, 18 Oct 2019 17:28:48 +0000 (13:28 -0400)]
tests/eldbus: add va_end for va_args usage in message test

Summary: CIDs 1400977, 1400974

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: devilhorns, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10390

4 years agoevas/language: #ifdef guard variable which is only used inside #ifdef
Mike Blumenkrantz [Fri, 18 Oct 2019 17:28:41 +0000 (13:28 -0400)]
evas/language: #ifdef guard variable which is only used inside #ifdef

Summary:
this variable is already only changed inside an #ifdef, so declare and
free it only inside the same ifdef for clarity

ref 9d9aa8b6ae0c07ebe23e1ea3fcb81f8050311651
CID 1400807

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10389

4 years agocsharp: Setting ELM_ENGINE if it is none.
Bruno da Silva Belo [Fri, 18 Oct 2019 14:40:33 +0000 (11:40 -0300)]
csharp: Setting ELM_ENGINE if it is none.

Reviewers: lauromoura, felipealmeida

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8322

Differential Revision: https://phab.enlightenment.org/D10442

4 years agowl egl - use platform get display
Carsten Haitzler (Rasterman) [Fri, 18 Oct 2019 11:49:21 +0000 (12:49 +0100)]
wl egl - use platform get display

if possible, use the platform specific egl get display as a wl egl
client. this fixes client side init with ... some drivers that can't
auto-detect the display type passed in.

@fix

4 years agomono: encapsulate invoke method
Yeongjong Lee [Thu, 17 Oct 2019 23:23:11 +0000 (20:23 -0300)]
mono: encapsulate invoke method

Summary: This patch will fix compiler warning CA1401.

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, segfaultxavi, Jaehyun_Cho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, woohyun, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10338

4 years agocsharp: updating eldbus_message doc and hide api.
Bruno da Silva Belo [Thu, 17 Oct 2019 18:53:48 +0000 (15:53 -0300)]
csharp: updating eldbus_message doc and hide api.

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8361

Differential Revision: https://phab.enlightenment.org/D10431

4 years agocsharp: updating eldbus_proxy doc and hide api.
Bruno da Silva Belo [Thu, 17 Oct 2019 18:39:47 +0000 (15:39 -0300)]
csharp: updating eldbus_proxy doc and hide api.

Summary: ref T8361

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8361

Differential Revision: https://phab.enlightenment.org/D10428

4 years agocsharp: updating eldbus_pending docs and hide api.
Bruno da Silva Belo [Thu, 17 Oct 2019 18:25:17 +0000 (15:25 -0300)]
csharp: updating eldbus_pending docs and hide api.

Summary: ref T8361

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8361

Differential Revision: https://phab.enlightenment.org/D10427

4 years agocsharp: updating eldbus_object docs and hide api.
Bruno da Silva Belo [Thu, 17 Oct 2019 17:49:15 +0000 (14:49 -0300)]
csharp: updating eldbus_object docs and hide api.

Summary: ref T8361

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8361

Differential Revision: https://phab.enlightenment.org/D10426

4 years agocsharp: hide eldbus_service api.
Bruno da Silva Belo [Thu, 17 Oct 2019 17:40:48 +0000 (14:40 -0300)]
csharp: hide eldbus_service api.

Summary: ref T8361

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8361

Differential Revision: https://phab.enlightenment.org/D10425

4 years agomono: add static modifier to static holder types.
Yeongjong Lee [Thu, 17 Oct 2019 17:36:15 +0000 (14:36 -0300)]
mono: add static modifier to static holder types.

Summary: This patch will fix CA1052 compiler warnings.

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, Jaehyun_Cho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10434

4 years agomono: merge namespaces
Yeongjong Lee [Thu, 17 Oct 2019 17:32:29 +0000 (14:32 -0300)]
mono: merge namespaces

Summary:
This patch merge namespaces to improve readablity.
Before
```
namespace Efl {
namespace Canvas {
```

After
```
namespace Efl.Canvas {
```

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, Jaehyun_Cho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10436

4 years agomono: remove underscores of Efl_Op_Description, Efl_Object_Ops
Yeongjong Lee [Thu, 17 Oct 2019 16:57:22 +0000 (13:57 -0300)]
mono: remove underscores of Efl_Op_Description, Efl_Object_Ops

Summary:
C# does not use underscore in type name.

ref T8333

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8333

Differential Revision: https://phab.enlightenment.org/D10422

4 years agogesture_manager: Deleted function and definition that are no more use.
Woochanlee [Thu, 17 Oct 2019 14:41:15 +0000 (10:41 -0400)]
gesture_manager: Deleted function and definition that are no more use.

Summary:
D7762

Searching for event what is using in gesture manager.
But the value was wrong.

And now D10437 made it better.

Reviewers: Hermet, smohanty, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10438

4 years agocsharp: Add Efl.Model implementations to internal model
Lauro Moura [Thu, 17 Oct 2019 14:11:00 +0000 (11:11 -0300)]
csharp: Add Efl.Model implementations to internal model

Summary:
CollectionView tries to access some properties from the base model so we
need to provide some implementation of the property getter/setter.

Reviewers: SanghyeonLee, cedric, felipealmeida

Reviewed By: SanghyeonLee

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10300

4 years agovector json: fix a ordering issue of stroke.
Hermet Park [Thu, 17 Oct 2019 08:39:26 +0000 (17:39 +0900)]
vector json: fix a ordering issue of stroke.

for optimization, we created a shape node in a lazy way,
This introduced corrupted layering order issue.

We fix it by keeping the object creation order.

Layzing creation is just for an ideal case,
It doesn't verified the performance.

4 years agovector json: optimize logic.
Hermet Park [Thu, 17 Oct 2019 07:59:14 +0000 (16:59 +0900)]
vector json: optimize logic.

if a layer is full transparent, skip it further processing.

4 years agocsharp: Updating eldbus_common docs.
Bruno da Silva Belo [Wed, 16 Oct 2019 14:26:03 +0000 (11:26 -0300)]
csharp: Updating eldbus_common docs.

Summary: ref T8361

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8361

Differential Revision: https://phab.enlightenment.org/D10416

4 years agocsharp: updating eldbus_config docs.
Bruno da Silva Belo [Wed, 16 Oct 2019 14:00:29 +0000 (11:00 -0300)]
csharp: updating eldbus_config docs.

Summary: ref T8361

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8361

Differential Revision: https://phab.enlightenment.org/D10417

4 years agocsharp: updating eldbus_connection docs.
Bruno da Silva Belo [Wed, 16 Oct 2019 13:50:10 +0000 (10:50 -0300)]
csharp: updating eldbus_connection docs.

Summary: ref T8361

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8361

Differential Revision: https://phab.enlightenment.org/D10418

4 years agomono: make public static field const or readonly
Yeongjong Lee [Wed, 16 Oct 2019 13:39:52 +0000 (10:39 -0300)]
mono: make public static field const or readonly

Summary: This patch will fix CA2211 compiler warnings.

Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true

Reviewers: lauromoura, Jaehyun_Cho

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10423

4 years agocsharp: rename Factory.cs to ItemFactory.cs
Jaehyun Cho [Wed, 16 Oct 2019 13:31:22 +0000 (10:31 -0300)]
csharp: rename Factory.cs to ItemFactory.cs

Summary:
Since current Factory.cs contains class ItemFactory, Factory.cs is
renamed to ItemFactory.cs.

Reviewers: lauromoura, YOhoho, SanghyeonLee

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10424

4 years agoefl_canvas_vg : Propagates the alpha color of the parent
JunsuChoi [Wed, 16 Oct 2019 06:12:13 +0000 (15:12 +0900)]
efl_canvas_vg : Propagates the alpha color of the parent

Summary:
The current color is affected by the parent's opacity.
If p_opacity is set, it will be applied to the current color.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10399

4 years agoexamples/eldbus: fix pointer leak on failure case
Mike Blumenkrantz [Tue, 15 Oct 2019 22:02:49 +0000 (07:02 +0900)]
examples/eldbus: fix pointer leak on failure case

Summary: CID 1400787

Reviewers: kimcinoo

Reviewed By: kimcinoo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10407

4 years agoexamples/evas: free map pointer in map example
Mike Blumenkrantz [Tue, 15 Oct 2019 21:57:34 +0000 (06:57 +0900)]
examples/evas: free map pointer in map example

Summary: CID 1400959

Reviewers: kimcinoo

Reviewed By: kimcinoo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10406

4 years agocsharp: Add since documentation to struct and struct fields
Felipe Magno de Almeida [Mon, 14 Oct 2019 03:51:15 +0000 (03:51 +0000)]
csharp: Add since documentation to struct and struct fields

Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10385

4 years agolz4: fix potential div by zero
Mike Blumenkrantz [Tue, 15 Oct 2019 14:20:53 +0000 (11:20 -0300)]
lz4: fix potential div by zero

Summary:
LZ4F_getBlockSize() can return 0

CID 1404010

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10392

4 years agotests/eina: fix assign when compare was intended
Mike Blumenkrantz [Tue, 15 Oct 2019 14:18:43 +0000 (11:18 -0300)]
tests/eina: fix assign when compare was intended

Summary: CID 1400858

Reviewers: lauromoura

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10396

4 years agocsharp: Avoid direct usage of some dllimport funcs
Lauro Moura [Tue, 15 Oct 2019 13:11:09 +0000 (10:11 -0300)]
csharp: Avoid direct usage of some dllimport funcs

Summary:
Instead of accessing them directly, generated code should access them
only through proper managed wrappers.

JIT should take care of inline them.

This would allow D10338 without depending on the friendly assembly feature.

Reviewers: YOhoho, felipealmeida, brunobelo, woohyun, segfaultxavi

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10366

4 years agocsharp: Fix promises docs and hide api
Lauro Moura [Tue, 15 Oct 2019 13:10:53 +0000 (10:10 -0300)]
csharp: Fix promises docs and hide api

Summary: ref T8293

Reviewers: felipealmeida, brunobelo, segfaultxavi, woohyun

Reviewed By: brunobelo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10331

4 years agoefl_ui: rename efl_ui_types.eot to efl_ui_drag_types.eot
Jaehyun Cho [Tue, 15 Oct 2019 13:06:48 +0000 (09:06 -0400)]
efl_ui: rename efl_ui_types.eot to efl_ui_drag_types.eot

Summary:
The current efl_ui_types.eot contains only enum Efl.Ui.Drag_Dir.
Therefore, it is renamed to efl_ui_drag_types.eot as follows.
src/lib/efl/interfaces/efl_ui_types.eot -> efl_ui_drag_types.eot

Reviewers: bu5hm4n, segfaultxavi, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10387

4 years agocsharp: fix to write cref Eina.Array<T> correctly
Jaehyun Cho [Tue, 15 Oct 2019 08:28:35 +0000 (17:28 +0900)]
csharp: fix to write cref Eina.Array<T> correctly

Since the class is Eina.Array<T>, cref Eina.Array is replaced to
Eina.Array<T>.

4 years agovector json: use lottie apis case by case.
Hermet Park [Tue, 15 Oct 2019 06:03:47 +0000 (15:03 +0900)]
vector json: use lottie apis case by case.

We can request loading from data only in case of actual memory map.
The lottie-player would take care of the parsing on utf8/16/32 formats
more precisely so that we don't need to take care of this converting
from the memory.

4 years agoecore_evas/wl2 0 fux xdg close cb for window when it's closed remotely
Carsten Haitzler (Rasterman) [Mon, 14 Oct 2019 18:12:25 +0000 (19:12 +0100)]
ecore_evas/wl2 0 fux xdg close cb for window when it's closed remotely

this should fix this:

https://matrix.org/_matrix/media/r0/download/matrix.org/lhFneENlWAjuXDaJfSYuJjjJ

unfortunately this means adding an api and then using it in ecore_evas.

@fix

4 years agocsharp: updating GenericModel.cs docs.
Bruno da Silva Belo [Mon, 14 Oct 2019 21:33:01 +0000 (18:33 -0300)]
csharp: updating GenericModel.cs docs.

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8345

Differential Revision: https://phab.enlightenment.org/D10376

4 years agocsharp: updating Bind docs and hide api.
Bruno da Silva Belo [Mon, 14 Oct 2019 21:27:49 +0000 (18:27 -0300)]
csharp: updating Bind docs and hide api.

Summary: ref T8345

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8345

Differential Revision: https://phab.enlightenment.org/D10374

4 years agocsharp: updating Factory docs.
Bruno da Silva Belo [Mon, 14 Oct 2019 21:01:30 +0000 (18:01 -0300)]
csharp: updating Factory docs.

Summary: ref T8345

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8345

Differential Revision: https://phab.enlightenment.org/D10375

4 years agocsharp: Remove test dependency on internal funcs
Lauro Moura [Mon, 14 Oct 2019 20:19:12 +0000 (17:19 -0300)]
csharp: Remove test dependency on internal funcs

Summary: This will help cleaninup the EFL# API.

Test Plan: run test suite

Reviewers: YOhoho, felipealmeida, segfaultxavi, woohyun, brunobelo

Reviewed By: YOhoho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D10365

4 years agocsharp: Updating eina_array docs and hide api.
Bruno da Silva Belo [Mon, 14 Oct 2019 20:02:45 +0000 (17:02 -0300)]
csharp: Updating eina_array docs and hide api.

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10309

4 years agocsharp: updating eina_common docs and hide api.
Bruno da Silva Belo [Mon, 14 Oct 2019 19:36:25 +0000 (16:36 -0300)]
csharp: updating eina_common docs and hide api.

Reviewers: lauromoura, felipealmeida, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10311

4 years agocsharp: updating eina_config docs and hide api.
Bruno da Silva Belo [Mon, 14 Oct 2019 15:23:56 +0000 (12:23 -0300)]
csharp: updating eina_config docs and hide api.

Reviewers: felipealmeida, lauromoura, woohyun, segfaultxavi

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10312

4 years agocsharp: updating eina_container_common doc and api
Bruno da Silva Belo [Mon, 14 Oct 2019 14:57:01 +0000 (11:57 -0300)]
csharp: updating eina_container_common doc and api

Reviewers: felipealmeida, lauromoura, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10314

4 years agocsharp: updating eina_error docs.
Bruno da Silva Belo [Mon, 14 Oct 2019 14:36:25 +0000 (11:36 -0300)]
csharp: updating eina_error docs.

Reviewers: felipealmeida, lauromoura, segfaultxavi, woohyun

Reviewed By: lauromoura

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8293

Differential Revision: https://phab.enlightenment.org/D10323