arv [Fri, 16 Jan 2015 00:20:00 +0000 (16:20 -0800)]
Computed property names: Enable test on windows again
Enable test on windows again and disable the problematic lines only.
BUG=v8:3815
LOG=N
R=dslomov@chromium.org
Review URL: https://codereview.chromium.org/
850773004
Cr-Commit-Position: refs/heads/master@{#26086}
Erik Arvidsson [Thu, 15 Jan 2015 20:51:22 +0000 (15:51 -0500)]
Skip computed property name test on Windows
BUG=v8:3815
LOG=N
TBR=dslomov@chromium.org
Review URL: https://codereview.chromium.org/
854903002
Cr-Commit-Position: refs/heads/master@{#26085}
arv [Thu, 15 Jan 2015 20:02:20 +0000 (12:02 -0800)]
ES6 computed property names
This adds support for computed property names, under the flag
--harmony-computed-property-names, for both object literals and
classes.
This is a revert of the revert,
7d48fd9dc29c8f5d7c8b5215f9bd537cdd005eba.
BUG=v8:3754
LOG=Y
R=dslomov@chromium.org
Review URL: https://codereview.chromium.org/
798243004
Cr-Commit-Position: refs/heads/master@{#26084}
adamk [Thu, 15 Jan 2015 19:18:05 +0000 (11:18 -0800)]
Remove dead TargetCollector code from the parser
This also simplifies target_stack_ and tightens up the types of nodes
that can appear in it.
Best I can tell, this code has been dead since
https://code.google.com/p/v8/source/detail?r=7542
Review URL: https://codereview.chromium.org/
850093004
Cr-Commit-Position: refs/heads/master@{#26083}
bmeurer [Thu, 15 Jan 2015 17:08:41 +0000 (09:08 -0800)]
[turbofan] Improve AstGraphBuilder::BuildToBoolean() for heap constants.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
852963004
Cr-Commit-Position: refs/heads/master@{#26082}
bmeurer [Thu, 15 Jan 2015 15:29:31 +0000 (07:29 -0800)]
Revert of [turbofan] Make Factory::NewNumber() always return the minus_zero_value. (patchset #1 id:1 of https://codereview.chromium.org/
838263006/)
Reason for revert:
Breaks the tree
Original issue's description:
> [turbofan] Make Factory::NewNumber() always return the minus_zero_value.
>
> TEST=unittests
> R=mstarzinger@chromium.org, dcarney@chromium.org
>
> Committed: https://crrev.com/
55b3e268b2895e2c09230d39669a75b6ab4e7e4d
> Cr-Commit-Position: refs/heads/master@{#26080}
TBR=dcarney@chromium.org,mstarzinger@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
853683009
Cr-Commit-Position: refs/heads/master@{#26081}
Benedikt Meurer [Thu, 15 Jan 2015 15:09:50 +0000 (16:09 +0100)]
[turbofan] Make Factory::NewNumber() always return the minus_zero_value.
TEST=unittests
R=mstarzinger@chromium.org, dcarney@chromium.org
Review URL: https://codereview.chromium.org/
838263006
Cr-Commit-Position: refs/heads/master@{#26080}
bmeurer [Thu, 15 Jan 2015 15:07:29 +0000 (07:07 -0800)]
[turbofan] Turn IrOpcode::IsXXX() into range checks.
TEST=unittests
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
807573004
Cr-Commit-Position: refs/heads/master@{#26079}
bmeurer [Thu, 15 Jan 2015 13:26:40 +0000 (05:26 -0800)]
Revert of [turbofan] Use PlainPrimitiveToNumber whenever possible. (patchset #1 id:1 of https://codereview.chromium.org/
852763002/)
Reason for revert:
Tanks performance of SQLite and towers.c.
Original issue's description:
> [turbofan] Use PlainPrimitiveToNumber whenever possible.
>
> TEST=cctest,unittests
> R=jarin@chromium.org
>
> Committed: https://crrev.com/
1a5db24e6bf831e61e3f4aa0c252f77e48c3689c
> Cr-Commit-Position: refs/heads/master@{#26071}
TBR=jarin@chromium.org,dcarney@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
852153003
Cr-Commit-Position: refs/heads/master@{#26078}
marja [Thu, 15 Jan 2015 13:10:01 +0000 (05:10 -0800)]
Check author of a CL against the AUTHORS file.
The code is copied from Chromium presubmit.
BUG=
Review URL: https://codereview.chromium.org/
837503003
Cr-Commit-Position: refs/heads/master@{#26077}
mvstanton [Thu, 15 Jan 2015 12:52:33 +0000 (04:52 -0800)]
Vector-based LoadICs need to handle Smi receivers.
The MISS handler was being called when the receiver was a Smi, instead,
we should recognize the case and use the heap number map.
BUG=
Review URL: https://codereview.chromium.org/
854623002
Cr-Commit-Position: refs/heads/master@{#26076}
mstarzinger [Thu, 15 Jan 2015 12:47:53 +0000 (04:47 -0800)]
Remove redundant test expectation from mjsunit.
R=jkummerow@chromium.org
TEST=mjsunit/nans
Review URL: https://codereview.chromium.org/
850303002
Cr-Commit-Position: refs/heads/master@{#26075}
dcarney [Thu, 15 Jan 2015 12:17:23 +0000 (04:17 -0800)]
[turbofan] add flag for register allocation verification
BUG=
Review URL: https://codereview.chromium.org/
798873008
Cr-Commit-Position: refs/heads/master@{#26074}
Yang Guo [Thu, 15 Jan 2015 11:48:57 +0000 (12:48 +0100)]
Fix number-string cache test case.
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/
843913008
Cr-Commit-Position: refs/heads/master@{#26073}
yangguo [Thu, 15 Jan 2015 11:22:04 +0000 (03:22 -0800)]
Fix remaining issues in the custom snapshot.
Math functions:
Some Math functions require typed arrays for their implementation. The embedded
script may call those Math functions. The serializer needs to deal with this.
Added assertion to make sure no other typed array is created when snapshotting.
Number-string cache:
We assume that the initial snapshot does not expand the number-string cache.
This is no longer true for custom heap snapshots.
Bound functions:
Bound functions store the bound arguments in a COW fixed array, including the
bindee function. COW arrays are serialized into the startup snapshot and
referenced in the partial snapshot via partial snapshot cache. However, the
bindee function is context-dependent and must not be part of the startup
snapshot. There is no need for bound functions to use a COW array though.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
851073002
Cr-Commit-Position: refs/heads/master@{#26072}
bmeurer [Thu, 15 Jan 2015 09:49:14 +0000 (01:49 -0800)]
[turbofan] Use PlainPrimitiveToNumber whenever possible.
TEST=cctest,unittests
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
852763002
Cr-Commit-Position: refs/heads/master@{#26071}
ulan [Thu, 15 Jan 2015 09:43:25 +0000 (01:43 -0800)]
Make map check in NamedStoreHandlerCompiler::GenerateFieldTypeChecks weak.
BUG=v8:3629
LOG=N
Review URL: https://codereview.chromium.org/
853713002
Cr-Commit-Position: refs/heads/master@{#26070}
dcarney [Thu, 15 Jan 2015 09:05:52 +0000 (01:05 -0800)]
Reland "[turbofan] simplify gap ordering"
BUG=
Review URL: https://codereview.chromium.org/
854703002
Cr-Commit-Position: refs/heads/master@{#26069}
dcarney [Thu, 15 Jan 2015 08:55:51 +0000 (00:55 -0800)]
add register allocator regression test
BUG=
Review URL: https://codereview.chromium.org/
852633002
Cr-Commit-Position: refs/heads/master@{#26068}
machenbach [Thu, 15 Jan 2015 08:01:03 +0000 (00:01 -0800)]
Revert of Auto-generate v8 version based on tags. (patchset #5 id:80001 of https://codereview.chromium.org/
797503007/)
Reason for revert:
Blocks roll on android_aosp:
https://codereview.chromium.org/
851953005/
Original issue's description:
> Auto-generate v8 version based on tags.
>
> BUG=chromium:446166
> LOG=y
>
> Committed: https://crrev.com/
b301b85be895c6fcd1edfe2fd1e60b5abd0ac64d
> Cr-Commit-Position: refs/heads/master@{#26062}
TBR=jochen@chromium.org,jkummerow@chromium.org,tandrii@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromium:446166
Review URL: https://codereview.chromium.org/
850263002
Cr-Commit-Position: refs/heads/master@{#26067}
baptiste.afsa [Thu, 15 Jan 2015 06:30:51 +0000 (22:30 -0800)]
[turbofan] Allow 0.0 as immediate for floating-point comparison on arm/arm64.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
850073002
Cr-Commit-Position: refs/heads/master@{#26066}
v8-autoroll [Thu, 15 Jan 2015 06:29:40 +0000 (22:29 -0800)]
Update V8 DEPS.
Rolling v8/build/gyp to
789a019a832029f9a6f8d906a4bcee4736eabc90
Rolling v8/testing/gtest to
be1868139ffe0ccd0e8e3b37292b84c821d9c8ad
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
850223003
Cr-Commit-Position: refs/heads/master@{#26065}
balazs.kilvady [Wed, 14 Jan 2015 20:39:44 +0000 (12:39 -0800)]
MIPS: Fix 'MIPS: Fix after 'Reland remaining parts of 'Use weak cells in map checks in polymorphic ICs''.'
Fix
30f2578ca2829a5c9b8952df20fd39bf7c99ea30
BUG=
Review URL: https://codereview.chromium.org/
846423002
Cr-Commit-Position: refs/heads/master@{#26064}
Ben L. Titzer [Wed, 14 Jan 2015 17:06:26 +0000 (18:06 +0100)]
[turbofan] Fix corner case in loop analysis.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
852783002
Cr-Commit-Position: refs/heads/master@{#26063}
machenbach [Wed, 14 Jan 2015 16:43:24 +0000 (08:43 -0800)]
Auto-generate v8 version based on tags.
BUG=chromium:446166
LOG=y
Review URL: https://codereview.chromium.org/
797503007
Cr-Commit-Position: refs/heads/master@{#26062}
yangguo [Wed, 14 Jan 2015 16:42:15 +0000 (08:42 -0800)]
Correctly reference global proxy in the partial snapshot.
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
853493003
Cr-Commit-Position: refs/heads/master@{#26061}
mstarzinger [Wed, 14 Jan 2015 15:24:20 +0000 (07:24 -0800)]
First simple implementation of for-of in TurboFan.
R=rossberg@chromium.org
TEST=cctest/test-run-jsbranches/ForOfContinueStatement
Review URL: https://codereview.chromium.org/
850803002
Cr-Commit-Position: refs/heads/master@{#26060}
yangguo [Wed, 14 Jan 2015 15:22:40 +0000 (07:22 -0800)]
Introduce new compile histogram that includes parsing/caching.
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/
851953003
Cr-Commit-Position: refs/heads/master@{#26059}
jochen [Wed, 14 Jan 2015 14:43:58 +0000 (06:43 -0800)]
Remove support for signatures with arguments
Support for it is slow and difficult to implement, and it's not used in
Blink. An embedder that uses this feature will have to check the
argument types itself.
BUG=none
R=dcarney@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/
848173002
Cr-Commit-Position: refs/heads/master@{#26058}
fedor.indutny [Wed, 14 Jan 2015 14:35:24 +0000 (06:35 -0800)]
src: fix build on freebsd
BUG=
R=danno
Review URL: https://codereview.chromium.org/
839053004
Cr-Commit-Position: refs/heads/master@{#26057}
bmeurer [Wed, 14 Jan 2015 13:56:55 +0000 (05:56 -0800)]
Add proper support for proxies to HType.
TEST=mjsunit/regress/regress-crbug-448730
BUG=chromium:448730
LOG=y
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
847373002
Cr-Commit-Position: refs/heads/master@{#26056}
Benedikt Meurer [Wed, 14 Jan 2015 13:49:35 +0000 (14:49 +0100)]
Remove stray + character.
TBR=jarin@chromium.org
Review URL: https://codereview.chromium.org/
847383002
Cr-Commit-Position: refs/heads/master@{#26055}
marja [Wed, 14 Jan 2015 13:23:36 +0000 (05:23 -0800)]
Saner AUTHORS, part 2: Adding AUTHORS based on "Patch from" / "Patch by" lines.
Notes:
- All the added authors have signed the CLA.
- Updated 2 AUTHORS lines to match the e-mail addresses used for signing the CLA.
- In addition, checked that all authors in the AUTHORS file after this change
have signed the CLA.
- Whenever it was possible to guess, based on the e-mail address, that the
contribution was made under a corporate CLA, added the company and the
wildcard instead of the individual.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/
832083004
Cr-Commit-Position: refs/heads/master@{#26054}
jarin [Wed, 14 Jan 2015 13:09:20 +0000 (05:09 -0800)]
[turbofan] Allow deoptimization for JSToNumber operator.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
841443004
Cr-Commit-Position: refs/heads/master@{#26053}
jochen [Wed, 14 Jan 2015 12:48:29 +0000 (04:48 -0800)]
Update gyp files to guarantee proper recreation when changing deps
Also make sure that x86_64 is mapped to x64 as target arch
R=machenbach@chromium.org
LOG=n
BUG=none
Review URL: https://codereview.chromium.org/
846363002
Cr-Commit-Position: refs/heads/master@{#26052}
bmeurer [Wed, 14 Jan 2015 12:06:41 +0000 (04:06 -0800)]
[turbofan] Fix truncation/representation sloppiness wrt. bool/bit.
TEST=cctest,mjsunit,unittests
BUG=v8:3812
LOG=y
Review URL: https://codereview.chromium.org/
850013003
Cr-Commit-Position: refs/heads/master@{#26051}
dcarney [Wed, 14 Jan 2015 11:52:24 +0000 (03:52 -0800)]
Revert of Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of https://codereview.chromium.org/
833563004/)
Reason for revert:
This is now really blocking the roll. I believe it's just missing
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
in the d8 config but I have no way to check.
Original issue's description:
> Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of https://codereview.chromium.org/
838983002/)
>
> Reason for revert:
> Relanding because this is not actually blocking the roll.
>
> Original issue's description:
> > Revert of Add d8 target to the GN build. (patchset #2 id:40001 of https://codereview.chromium.org/
834113005/)
> >
> > Reason for revert:
> > V8 roll fails due to this change. (see https://codereview.chromium.org/
843673003/)
> >
> > Original issue's description:
> > > Add d8 target to the GN build.
> > >
> > > Also formats the rest of the file with "gn format". This accounts for all the changes except for the "d8" target additions.
> > >
> > > Committed: https://crrev.com/
36383f08c1f692ea797d54a27d7c6b3d3d53b440
> > > Cr-Commit-Position: refs/heads/master@{#25984}
> >
> > TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> >
> > Committed: https://crrev.com/
ef50fdfdb05e1a3a3822962f5235b804218a5f4e
> > Cr-Commit-Position: refs/heads/master@{#25985}
>
> TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/
ebf3c34fb91b4b61f5c32383a115214c516ab5b0
> Cr-Commit-Position: refs/heads/master@{#25996}
TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org,yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
810493004
Cr-Commit-Position: refs/heads/master@{#26050}
yangguo [Wed, 14 Jan 2015 11:06:38 +0000 (03:06 -0800)]
Store embed-script flag as metadata into snapshot blob.
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/
848023002
Cr-Commit-Position: refs/heads/master@{#26049}
bmeurer [Wed, 14 Jan 2015 09:06:50 +0000 (01:06 -0800)]
Revert of [turbofan] Improve typed lowering of JSBitwiseAnd. (patchset #1 id:1 of https://codereview.chromium.org/
811653004/)
Reason for revert:
Breaks SQLite
Original issue's description:
> [turbofan] Improve typed lowering of JSBitwiseAnd.
>
> TEST=unittests
> R=jarin@chromium.org
>
> Committed: https://crrev.com/
284e1108182995abe85f580bc813d26491642b8c
> Cr-Commit-Position: refs/heads/master@{#26046}
TBR=jarin@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
795833006
Cr-Commit-Position: refs/heads/master@{#26048}
Benedikt Meurer [Wed, 14 Jan 2015 07:56:19 +0000 (08:56 +0100)]
[turbofan] Index parameter to StoreWriteBarrier is word size.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
818173004
Cr-Commit-Position: refs/heads/master@{#26047}
Benedikt Meurer [Wed, 14 Jan 2015 07:39:58 +0000 (08:39 +0100)]
[turbofan] Improve typed lowering of JSBitwiseAnd.
TEST=unittests
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
811653004
Cr-Commit-Position: refs/heads/master@{#26046}
balazs.kilvady [Tue, 13 Jan 2015 20:27:55 +0000 (12:27 -0800)]
MIPS: [turbofan] Improve code generation for unordered comparisons.
Port
c24220c0c14b60e6c6d7383b7d9c287086050afb
TEST=cctest,unittests
BUG=
Review URL: https://codereview.chromium.org/
850733004
Cr-Commit-Position: refs/heads/master@{#26045}
verwaest [Tue, 13 Jan 2015 18:05:35 +0000 (10:05 -0800)]
Reduce number of deopts caused by ForceDelete.
BUG=
Review URL: https://codereview.chromium.org/
845403002
Cr-Commit-Position: refs/heads/master@{#26044}
Andy Wingo [Tue, 13 Jan 2015 14:36:50 +0000 (15:36 +0100)]
AbortOptimization, RetryOptimization preserve first bailout reason
The current logic appears to have been introduced in
https://codereview.chromium.org/
596783002.
R=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
836033005
Cr-Commit-Position: refs/heads/master@{#26043}
mstarzinger [Tue, 13 Jan 2015 13:38:41 +0000 (05:38 -0800)]
Make UBSan happy about OpParameter casts.
R=svenpanne@chromium.org
BUG=chromium:448141
LOG=N
Review URL: https://codereview.chromium.org/
847093002
Cr-Commit-Position: refs/heads/master@{#26042}
chunyang.dai [Tue, 13 Jan 2015 13:12:27 +0000 (05:12 -0800)]
Fix the compilation error for turbofan unsupported platform.
Fix the compilation error for turbofan unsupported platform. The Linkage::GetOsrValuePosition()
function is implemented in linkage-impl.h. And this file is included by different platform specific
file separately. This leads to compilation error for turbofan unsupported platform.
The fix is adding one dummy implementation in linkage.cc.
BUG=
Review URL: https://codereview.chromium.org/
848873002
Cr-Commit-Position: refs/heads/master@{#26041}
bmeurer [Tue, 13 Jan 2015 13:02:28 +0000 (05:02 -0800)]
[turbofan] Reduce Word32And masking with shifted inputs.
TEST=unittests
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
847113002
Cr-Commit-Position: refs/heads/master@{#26040}
marja [Tue, 13 Jan 2015 11:58:37 +0000 (03:58 -0800)]
Saner AUTHORS, part 1: Corporate CLLAs and wildcards.
Updating AUTHORS for companies who have signed CCLA.
Changes:
- Added wildcard rules for company e-mail addresses
- Removed individual e-mail addresses for contributors who are under a corporate
CLLA (the copyright holder in this case is the company, not the individual
authors). Domains affected by this change: intel.com, arm.com, codeaurora.org.
In addition, added a wildcard rule for Chromium (which was not previously
listed at all).
R=danno
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
850653003
Cr-Commit-Position: refs/heads/master@{#26039}
bmeurer [Tue, 13 Jan 2015 11:02:40 +0000 (03:02 -0800)]
[turbofan] Add PlainPrimitiveToNumber simplified operator.
TEST=unittests
Review URL: https://codereview.chromium.org/
845333002
Cr-Commit-Position: refs/heads/master@{#26038}
Sven Panne [Tue, 13 Jan 2015 10:52:29 +0000 (11:52 +0100)]
Avoid MSVC's C6323 warning (use of arithmetic operator on Boolean type)
We could use BoolToInt consistently, but for now let's just fix the warnings.
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/
825913005
Cr-Commit-Position: refs/heads/master@{#26037}
bmeurer [Tue, 13 Jan 2015 10:01:06 +0000 (02:01 -0800)]
[turbofan] Avoid expensive fixup for Uint32Div if divisor is even.
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
840813008
Cr-Commit-Position: refs/heads/master@{#26036}
yangguo [Tue, 13 Jan 2015 08:48:00 +0000 (00:48 -0800)]
Update references to global object after deserializing context.
R=jochen@chromium.org
TEST=test-serialize/CustomContext{Des,S}erialization
Also test by
- make ia32.debug embedscript=<full path to mjsunit.js>
- d8 -e "assertDoesNotThrow('print(1)')"
Review URL: https://codereview.chromium.org/
846023002
Cr-Commit-Position: refs/heads/master@{#26035}
bmeurer [Tue, 13 Jan 2015 08:41:52 +0000 (00:41 -0800)]
[turbofan] Improve code generation for unordered comparisons.
TEST=cctest,unittests
Review URL: https://codereview.chromium.org/
850653002
Cr-Commit-Position: refs/heads/master@{#26034}
jarin [Tue, 13 Jan 2015 08:40:39 +0000 (00:40 -0800)]
[turbofan] Add missing deopt.
BUG=chromium:447567
LOG=n
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
809463005
Cr-Commit-Position: refs/heads/master@{#26033}
svenpanne [Tue, 13 Jan 2015 08:36:53 +0000 (00:36 -0800)]
Avoid MSVC's C6282 warning (assignment of constant in Boolean context).
By courtesy of /analyze... :-}
Review URL: https://codereview.chromium.org/
846223002
Cr-Commit-Position: refs/heads/master@{#26032}
v8-autoroll [Tue, 13 Jan 2015 04:22:39 +0000 (20:22 -0800)]
Update V8 DEPS.
Rolling v8/tools/clang to
a4a0b2db20ba74e9d928be13ff701b244cfdd0c2
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
847043002
Cr-Commit-Position: refs/heads/master@{#26031}
marja [Mon, 12 Jan 2015 17:31:47 +0000 (09:31 -0800)]
CompleteParserRecorder: Don't do zero-sized allocations.
Instead, we should use Collector::kMinCapacity.
R=jochen@chromium.org
BUG=v8:3727
LOG=N
Review URL: https://codereview.chromium.org/
847823002
Cr-Commit-Position: refs/heads/master@{#26030}
yangguo [Mon, 12 Jan 2015 15:26:20 +0000 (07:26 -0800)]
Embed custom script into the snapshot.
R=vogelheim@chromium.org
Review URL: https://codereview.chromium.org/
845973003
Cr-Commit-Position: refs/heads/master@{#26029}
caitpotter88 [Mon, 12 Jan 2015 15:07:36 +0000 (07:07 -0800)]
Check for octals in template spans only, not expressions
BUG=v8:3806
LOG=N
R=arv@chromium.org, dslomov@chromium.org
Review URL: https://codereview.chromium.org/
808793004
Cr-Commit-Position: refs/heads/master@{#26028}
bmeurer [Mon, 12 Jan 2015 15:01:58 +0000 (07:01 -0800)]
[turbofan] Canonicalize x - K to x + -K.
TEST=unittests
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
846913002
Cr-Commit-Position: refs/heads/master@{#26027}
mstarzinger [Mon, 12 Jan 2015 14:32:14 +0000 (06:32 -0800)]
Enable test after arguments count limitation was lifted.
R=bmeurer@chromium.org
TEST=mozilla/js1_5/Regress/regress-396684
BUG=v8:3786
Review URL: https://codereview.chromium.org/
832713005
Cr-Commit-Position: refs/heads/master@{#26026}
balazs.kilvady [Mon, 12 Jan 2015 14:28:57 +0000 (06:28 -0800)]
MIPS64: Fix '[turbofan] Implement OSR for outer loops.'
Add missing include of
159b14172f75ddb89e5daf2cceb9078f1f294916.
BUG=
Review URL: https://codereview.chromium.org/
845983003
Cr-Commit-Position: refs/heads/master@{#26025}
rmcilroy [Mon, 12 Jan 2015 12:53:57 +0000 (04:53 -0800)]
[d8] Fix V8 external snapshot for Windows.
Adds a cast to V8 external snapshot code for Windows.
BUG=421063, 439661
LOG=N
Review URL: https://codereview.chromium.org/
842573004
Cr-Commit-Position: refs/heads/master@{#26024}
jochen [Mon, 12 Jan 2015 12:25:09 +0000 (04:25 -0800)]
Remove unused iossim setting from mac asan config
R=glider@chromium.org
LOG=n
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/
844283002
Cr-Commit-Position: refs/heads/master@{#26023}
erikcorry [Mon, 12 Jan 2015 12:11:49 +0000 (04:11 -0800)]
Unify phantom and internal fields weak handle callbacks
R=dcarney@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
842153004
Cr-Commit-Position: refs/heads/master@{#26022}
dslomov [Mon, 12 Jan 2015 11:42:48 +0000 (03:42 -0800)]
Map -0 to integer 0 for typed array constructors.
R=bmeurer@chromium.org
BUG=chromium:447756
LOG=Y
Review URL: https://codereview.chromium.org/
790813005
Cr-Commit-Position: refs/heads/master@{#26021}
titzer [Mon, 12 Jan 2015 11:39:48 +0000 (03:39 -0800)]
[turbofan] Implement OSR for outer loops.
R=bmeurer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
809333002
Cr-Commit-Position: refs/heads/master@{#26020}
jochen [Mon, 12 Jan 2015 09:58:29 +0000 (01:58 -0800)]
Merge v8_optimized_debug 1 and 2
All builders that used level 1 should meanwhile define
v8_enable_slow_dchecks, and so they can use level 2 without losing
coverage. Level 2, however, is considerably faster, so we want to use it
on those builders as well. The make optdebug setting is not affected by
this change.
BUG=none
R=machenbach@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
847753002
Cr-Commit-Position: refs/heads/master@{#26019}
marja [Mon, 12 Jan 2015 09:50:15 +0000 (01:50 -0800)]
ES6 unicode escapes, part 2: Regexps.
Allows \u{xxxxx} in regexps. Behind the --harmony-unicode flag.
Part 1 is here: https://codereview.chromium.org/
716423002
BUG=v8:3648
LOG=N
Review URL: https://codereview.chromium.org/
788043005
Cr-Commit-Position: refs/heads/master@{#26018}
v8-autoroll [Sun, 11 Jan 2015 04:26:58 +0000 (20:26 -0800)]
Update V8 DEPS.
Rolling v8/third_party/icu to
4e3266f32c62d30a3f9e2232a753c60129d1e670
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
843313002
Cr-Commit-Position: refs/heads/master@{#26017}
paul.lind [Fri, 9 Jan 2015 20:12:14 +0000 (12:12 -0800)]
MIPS: remove immediate constraint within CompareAndSwap.
Improper use of immediate constraint is slightly non-optimal
with gcc/gnu-as but causes breakage with clang.
BUG=
Review URL: https://codereview.chromium.org/
841263002
Cr-Commit-Position: refs/heads/master@{#26016}
jochen [Fri, 9 Jan 2015 16:25:36 +0000 (08:25 -0800)]
Introduce a gyp variable to control whether or not slow dchecks are on
The default for the various debug modes doesn't change.
In a follow-up, OptDebug1 and OptDebug2 will be merged
R=machenbach@chromium.org
LOG=y
BUG=none
Review URL: https://codereview.chromium.org/
846653002
Cr-Commit-Position: refs/heads/master@{#26015}
bmeurer [Fri, 9 Jan 2015 14:19:55 +0000 (06:19 -0800)]
[turbofan] Fix typo in IrOpcode::Mnemonic.
TEST=unittests
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
843043002
Cr-Commit-Position: refs/heads/master@{#26014}
jochen [Fri, 9 Jan 2015 13:38:13 +0000 (05:38 -0800)]
Add ASAN and TSAN support for Mac
BUG=none
LOG=n
R=machenbach@chromium.org,glider@chromium.org
Review URL: https://codereview.chromium.org/
838383005
Cr-Commit-Position: refs/heads/master@{#26013}
jochen [Fri, 9 Jan 2015 13:07:29 +0000 (05:07 -0800)]
Correctly setup the freelist of the coderange on Win64
Since we have a special guard page at the beginning of the code range on
win64, we need to make sure to adjust the size of the free list
accordingly when creating it.
BUG=chromium:447555
R=hpayer@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/
843973002
Cr-Commit-Position: refs/heads/master@{#26012}
Jochen Eisinger [Fri, 9 Jan 2015 12:55:48 +0000 (13:55 +0100)]
Fast forward V8 to version 4.2
R=machenbach@chromium.org
LOG=y
BUG=none
Review URL: https://codereview.chromium.org/
809803007
Cr-Commit-Position: refs/heads/master@{#26011}
hpayer [Fri, 9 Jan 2015 12:54:07 +0000 (04:54 -0800)]
Try to reduce memory footprint when we run out of memory in Deserializer.
BUG=403113
LOG=n
Review URL: https://codereview.chromium.org/
831893003
Cr-Commit-Position: refs/heads/master@{#26010}
titzer [Fri, 9 Jan 2015 12:27:59 +0000 (04:27 -0800)]
[turbofan] Fix control reducer for degenerate cases of self-loop branches.
R=jarin@chromium.org
BUG=chromium:447526
Review URL: https://codereview.chromium.org/
828823006
Cr-Commit-Position: refs/heads/master@{#26009}
ishell [Fri, 9 Jan 2015 12:17:18 +0000 (04:17 -0800)]
Verify that Api function's instance call handler is actually a CallHandlerInfo structure.
This is to ensure that chromium:443798 is caused by a random memory
corruption.
Review URL: https://codereview.chromium.org/
846613002
Cr-Commit-Position: refs/heads/master@{#26008}
ishell [Fri, 9 Jan 2015 11:52:17 +0000 (03:52 -0800)]
Extend grokdump's dd command with a second optional parameter defining number of words to dump.
Review URL: https://codereview.chromium.org/
845713002
Cr-Commit-Position: refs/heads/master@{#26007}
vogelheim [Fri, 9 Jan 2015 10:27:04 +0000 (02:27 -0800)]
Disable webkit/array-iterate-backwards for debug builds.
(Debug builds have --enable-slow-asserts, and with slow asserts each
assignment to the array in the prepare function will trigger a check
over the entire array. This turns it into n^2 work, for reasonably
large n.)
BUG=
Review URL: https://codereview.chromium.org/
831953003
Cr-Commit-Position: refs/heads/master@{#26006}
yangguo [Fri, 9 Jan 2015 09:56:14 +0000 (01:56 -0800)]
Add sticky flag to RegExpMirror.
R=marja@chromium.org
Review URL: https://codereview.chromium.org/
840253002
Cr-Commit-Position: refs/heads/master@{#26005}
v8-autoroll [Fri, 9 Jan 2015 04:30:47 +0000 (20:30 -0800)]
Update V8 DEPS.
Rolling v8/buildtools to
451dcd05a5b34936f5be67b2472cd63aaa508401
TBR=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
834243003
Cr-Commit-Position: refs/heads/master@{#26004}
Daniel Vogelheim [Thu, 8 Jan 2015 19:08:41 +0000 (20:08 +0100)]
Whitespace, to trigger the bots.
BUG=
Review URL: https://codereview.chromium.org/
831193004
Cr-Commit-Position: refs/heads/master@{#26003}
hpayer [Thu, 8 Jan 2015 18:17:23 +0000 (10:17 -0800)]
Regularly check hash set addresses to verify memory integrity.
BUG=
Review URL: https://codereview.chromium.org/
804603006
Cr-Commit-Position: refs/heads/master@{#26002}
jochen [Thu, 8 Jan 2015 16:29:27 +0000 (08:29 -0800)]
Remove "extra checks"
Instead, just use DCHECKs. The builders that want them in release mode
should already be useding dcheck_always_on anyways
BUG=none
R=machenbach@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/
841083002
Cr-Commit-Position: refs/heads/master@{#26001}
dslomov [Thu, 8 Jan 2015 15:10:52 +0000 (07:10 -0800)]
Unship ES6 classes.
R=rossberg@chromium.org
BUG=v8:3330
Review URL: https://codereview.chromium.org/
836393003
Cr-Commit-Position: refs/heads/master@{#26000}
hpayer [Thu, 8 Jan 2015 14:45:14 +0000 (06:45 -0800)]
Verify that heap object iterator stays within page bound.
BUG=
Review URL: https://codereview.chromium.org/
823583010
Cr-Commit-Position: refs/heads/master@{#25999}
jochen [Thu, 8 Jan 2015 14:31:16 +0000 (06:31 -0800)]
Revert of Revert of Revert of Turn on job-based recompilation (patchset #1 id:1 of https://codereview.chromium.org/
840023002/)
Reason for revert:
still doesn't work
Original issue's description:
> Revert of Revert of Turn on job-based recompilation (patchset #1 id:1 of https://codereview.chromium.org/
791033007/)
>
> Reason for revert:
> attempt reland after landing a fix
>
> Original issue's description:
> > Revert of Turn on job-based recompilation (patchset #2 id:20001 of https://codereview.chromium.org/
832183004/)
> >
> > Reason for revert:
> > revert
> >
> > Original issue's description:
> > > Turn on job-based recompilation
> > >
> > > BUG=v8:3608
> > > LOG=y
> > > R=yangguo@chromium.org
> > >
> > > Committed: https://crrev.com/
715552409b4a08504301cf1ad4cb2e45a815f01b
> > > Cr-Commit-Position: refs/heads/master@{#25972}
> >
> > TBR=yangguo@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=v8:3608
> >
> > Committed: https://crrev.com/
28a5a4865183769cbed9d42ad3fdc1b1d8bae3a3
> > Cr-Commit-Position: refs/heads/master@{#25975}
>
> TBR=yangguo@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:3608
>
> Committed: https://crrev.com/
b4bc9c1a3a7d03dee0b3dd6460414085f79cd36e
> Cr-Commit-Position: refs/heads/master@{#25994}
TBR=yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=v8:3608
Review URL: https://codereview.chromium.org/
832103003
Cr-Commit-Position: refs/heads/master@{#25998}
bmeurer [Thu, 8 Jan 2015 14:13:18 +0000 (06:13 -0800)]
[turbofan] Cleanup duplicated/unused code in InstructionSelector.
- Use C++11 range based for loops.
- Remove duplicated virtual register set in unittests.
- Don't expose implementation details of InstructionSelector.
TEST=unittests
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/
837423002
Cr-Commit-Position: refs/heads/master@{#25997}
yangguo [Thu, 8 Jan 2015 13:21:52 +0000 (05:21 -0800)]
Revert of Revert of Add d8 target to the GN build. (patchset #1 id:1 of https://codereview.chromium.org/
838983002/)
Reason for revert:
Relanding because this is not actually blocking the roll.
Original issue's description:
> Revert of Add d8 target to the GN build. (patchset #2 id:40001 of https://codereview.chromium.org/
834113005/)
>
> Reason for revert:
> V8 roll fails due to this change. (see https://codereview.chromium.org/
843673003/)
>
> Original issue's description:
> > Add d8 target to the GN build.
> >
> > Also formats the rest of the file with "gn format". This accounts for all the changes except for the "d8" target additions.
> >
> > Committed: https://crrev.com/
36383f08c1f692ea797d54a27d7c6b3d3d53b440
> > Cr-Commit-Position: refs/heads/master@{#25984}
>
> TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/
ef50fdfdb05e1a3a3822962f5235b804218a5f4e
> Cr-Commit-Position: refs/heads/master@{#25985}
TBR=jochen@chromium.org,machenbach@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
833563004
Cr-Commit-Position: refs/heads/master@{#25996}
yangguo [Thu, 8 Jan 2015 13:18:45 +0000 (05:18 -0800)]
Fix unsafe unaligned accesses in the serializer/deserializer.
R=svenpanne@chromium.org
BUG=v8:3771
LOG=N
Review URL: https://codereview.chromium.org/
841943002
Cr-Commit-Position: refs/heads/master@{#25995}
jochen [Thu, 8 Jan 2015 13:15:55 +0000 (05:15 -0800)]
Revert of Revert of Turn on job-based recompilation (patchset #1 id:1 of https://codereview.chromium.org/
791033007/)
Reason for revert:
attempt reland after landing a fix
Original issue's description:
> Revert of Turn on job-based recompilation (patchset #2 id:20001 of https://codereview.chromium.org/
832183004/)
>
> Reason for revert:
> revert
>
> Original issue's description:
> > Turn on job-based recompilation
> >
> > BUG=v8:3608
> > LOG=y
> > R=yangguo@chromium.org
> >
> > Committed: https://crrev.com/
715552409b4a08504301cf1ad4cb2e45a815f01b
> > Cr-Commit-Position: refs/heads/master@{#25972}
>
> TBR=yangguo@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:3608
>
> Committed: https://crrev.com/
28a5a4865183769cbed9d42ad3fdc1b1d8bae3a3
> Cr-Commit-Position: refs/heads/master@{#25975}
TBR=yangguo@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=v8:3608
Review URL: https://codereview.chromium.org/
840023002
Cr-Commit-Position: refs/heads/master@{#25994}
jochen [Thu, 8 Jan 2015 13:14:16 +0000 (05:14 -0800)]
Make sure that the TimerEventScope is destroyed before we signal completion
Otherwise, the isolate that is referenced by the scope might already be
gone
BUG=v8:3608
R=yangguo@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/
836413005
Cr-Commit-Position: refs/heads/master@{#25993}
Ben Noordhuis [Thu, 8 Jan 2015 13:13:39 +0000 (14:13 +0100)]
compiler: enable optimizer for function literals
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
821553003
Patch from Ben Noordhuis <ben@strongloop.com>.
Cr-Commit-Position: refs/heads/master@{#25992}
machenbach [Thu, 8 Jan 2015 10:50:03 +0000 (02:50 -0800)]
Revert of Hack around broken snapshot generation in the GN build on Android. (patchset #1 id:1 of https://codereview.chromium.org/
832413005/)
Reason for revert:
Suspected to block the current v8 roll:
https://codereview.chromium.org/
842783003/
Original issue's description:
> Hack around broken snapshot generation in the GN build on Android.
>
> The generated snapshot just crashes on the device, but
> disabling snapshots allows us to run V8 just fine which
> is sufficient for our purposes at this point.
>
> Mojo/Sky are GN-only so we depend on the V8 GN build even if
> it's not considered production for Chromium yet.
>
> R=jochen@chromium.org
>
> Committed: https://crrev.com/
3e97df1ee8b8bfdddd63ad3c7b79960d24c83b74
> Cr-Commit-Position: refs/heads/master@{#25982}
TBR=jochen@chromium.org,eseidel@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
841043002
Cr-Commit-Position: refs/heads/master@{#25991}
machenbach [Thu, 8 Jan 2015 10:48:04 +0000 (02:48 -0800)]
Revert of Run "gn format" on v8's BUILD.gn file. (patchset #1 id:1 of https://codereview.chromium.org/
787873003/)
Reason for revert:
Need to revert in order to revert
https://codereview.chromium.org/
832413005/
Original issue's description:
> Run "gn format" on v8's BUILD.gn file.
>
> There should be no functional change.
>
> This is a reland of a portion of https://codereview.chromium.org/
834113005/
>
> Committed: https://crrev.com/
e1d957268d154e7fb7abd5a6cad54f602badc9b8
> Cr-Commit-Position: refs/heads/master@{#25986}
TBR=jochen@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
793613003
Cr-Commit-Position: refs/heads/master@{#25990}
Yang Guo [Thu, 8 Jan 2015 10:45:58 +0000 (11:45 +0100)]
Correctly parse line ends for debugging.
Instead of using only \n as line terminator, we now use the definition
in http://www.ecma-international.org/ecma-262/5.1/#sec-7.3
R=marja@chromium.org
BUG=v8:2825
LOG=Y
Review URL: https://codereview.chromium.org/
821383009
Cr-Commit-Position: refs/heads/master@{#25989}
svenpanne [Thu, 8 Jan 2015 09:53:53 +0000 (01:53 -0800)]
Fixed printing during DCE.
Removed a superfluous space on the way.
BUG=v8:3679
LOG=y
Review URL: https://codereview.chromium.org/
843673004
Cr-Commit-Position: refs/heads/master@{#25988}
bmeurer [Thu, 8 Jan 2015 09:48:30 +0000 (01:48 -0800)]
[turbofan] Correctify representation changes to bit.
TEST=cctest/test-representation-change,unittests,mjsunit/compiler/regress-bit-number-constant
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
840953003
Cr-Commit-Position: refs/heads/master@{#25987}