commit-queue@webkit.org [Mon, 20 Feb 2012 15:02:09 +0000 (15:02 +0000)]
Source/WebCore: Added code to support dispatching of missed cues in case of normal playback
and event sorting in case of simultaneous event triggering.
<track>-related events cuechange, enter, and exit should be sorted and filtered before dispatching
https://bugs.webkit.org/show_bug.cgi?id=72171
Patch by Victor Carbune <victor@rosedu.org> on 2012-02-20
Reviewed by Eric Carlson.
Tests: media/track/track-cues-missed.html
media/track/track-cues-sorted-before-dispatch.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Added initialization code
for newly added state variables.
(WebCore::trackIndexCompare): Static boolean compare function between
the index of two tracks.
(WebCore):
(WebCore::eventTimeCueCompare): Static boolean compare function between
events associated with text track cues.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Added code to
sort the events associated with text track cues before dispatching.
Each step from the specification is commented within the code.
(WebCore::HTMLMediaElement::finishSeek): Added a boolean variable that
is needed within the text track update function, to know whether a seek
event has occured before or not.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Moved the update
call for text tracks at the beginning of the function instead of the end.
'ended' events for video should be dispatched after track specific events.
* html/HTMLMediaElement.h: Added variables to keep
state information required by the text track update algorithm (last time
the algorithm was run, and whether a seeking event has occured)
(HTMLMediaElement):
* html/LoadableTextTrack.cpp: Refactored fireCueChangeEvent method
(WebCore::LoadableTextTrack::fireCueChangeEvent): The method dispatches a
synchronous cue change event for the track element.
* html/LoadableTextTrack.h:
(LoadableTextTrack):
* html/TextTrack.cpp: Modified the fireCueChange method, cached track index.
(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::trackIndex): Cached the track index.
(WebCore):
(WebCore::TextTrack::invalidateTrackIndex): Invalidates the track. Used
when a new track is added in a TextTrackList instance.
* html/TextTrack.h:
(TextTrack):
(WebCore::TextTrack::fireCueChangeEvent): The fireCueChangeEvent has been changed,
as events need to be fired asyncronously.
* html/TextTrackCue.cpp: Added internal variables to keep the current index
position in the track cue order. This is invalidated when an element is
inserted before.
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::cueIndex): Getter for the cueIndex.
(WebCore):
(WebCore::TextTrackCue::invalidateCueIndex): Invalidates the currently stored
cue index.
(WebCore::TextTrackCue::dispatchEvent): Event dispatching is done asynchronously
now. This should be the only method used for event dispatching.
(WebCore::TextTrackCue::setIsActive): The setIsActive method no longer dispatches
events, but rather just changes the m_isActive variable.
* html/TextTrackCue.h:
(TextTrackCue):
* html/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::getCueIndex): Retrieves the cue index, in the track cue
order, of a given cue.
(WebCore):
(WebCore::TextTrackCueList::add): Modified the add method such that all the next cue
indexes are invalidated.
(WebCore::TextTrackCueList::invalidateCueIndexes): Invalidates all cue indexes starting
with a specific position.
* html/TextTrackCueList.h:
(TextTrackCueList):
* html/track/TextTrackList.cpp:
(TextTrackList::getTrackIndex): Retrieves the track index position.
(TextTrackList::append): Added method for invalidating the text track index in case of
changing the list contents.
* html/track/TextTrackList.h:
(TextTrackList):
LayoutTests: <track>-related events cuechange, enter, and exit should be sorted and filtered before dispatching
https://bugs.webkit.org/show_bug.cgi?id=72171
Patch by Victor Carbune <victor@rosedu.org> on 2012-02-20
Reviewed by Eric Carlson.
* media/track/captions-webvtt/missed-cues.vtt: Added.
* media/track/captions-webvtt/sorted-dispatch.vtt: Added.
* media/track/track-cues-cuechange-expected.txt: This test had to be changed because
the synchronous dispatch of the events against the HTMLTrackElement doesn't mean that
the text track actually has any active cues at the dispatch moment.
* media/track/track-cues-cuechange.html: Changed tests structure to guide the entering and
exit events according to the asynchronous dispatch done by TextTrack.
* media/track/track-cues-missed-expected.txt: Added.
* media/track/track-cues-missed.html: Added.
* media/track/track-cues-sorted-before-dispatch-expected.txt: Added.
* media/track/track-cues-sorted-before-dispatch.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Mon, 20 Feb 2012 14:54:49 +0000 (14:54 +0000)]
[WebSocket] Move WebSocketChannel::FrameData into a separate header file
https://bugs.webkit.org/show_bug.cgi?id=78682
Extract WebSocketChannel::FrameData as WebSocketFrame. This brings
flexibility to add classes which want to do something for
incoming/outgoing frames (e.g. compression/decompression).
Reviewed by Kent Tamura.
No new tests. No behavior change.
* GNUmakefile.list.am: AddedWebSocketFrame.h
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* websockets/WebSocketChannel.cpp: Modified to use WebSocketFrame instead of FrameData
(WebCore):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::parseFrame):
(WebCore::WebSocketChannel::processFrame):
(WebCore::WebSocketChannel::enqueueTextFrame):
(WebCore::WebSocketChannel::enqueueRawFrame):
(WebCore::WebSocketChannel::enqueueBlobFrame):
(WebCore::appendMaskedFramePayload): Added.
(WebCore::makeFrameData): Added.
(WebCore::WebSocketChannel::sendFrame):
* websockets/WebSocketChannel.h: Removed FrameData.
(WebSocketChannel):
(QueuedFrame):
* websockets/WebSocketFrame.h: Added.
(WebCore):
(WebSocketFrame):
(WebCore::WebSocketFrame::isNonControlOpCode):
(WebCore::WebSocketFrame::isControlOpCode):
(WebCore::WebSocketFrame::isReservedOpCode):
(WebCore::WebSocketFrame::WebSocketFrame):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 20 Feb 2012 14:53:08 +0000 (14:53 +0000)]
32-bit build fix
* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::setRawValue): Explicitly cast long long to int, since they
are different widths in 32-bit.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 20 Feb 2012 14:51:17 +0000 (14:51 +0000)]
Clang build fix
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::willModifyDOMAttr): Removed unused parameter.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Mon, 20 Feb 2012 14:03:14 +0000 (14:03 +0000)]
Unreviewed manual rollout of r107970 which breaks table column widths
updates from javascript (e.g. inspector's network panel).
Source/WebCore:
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
* rendering/RenderTableCol.h:
(RenderTableCol):
LayoutTests:
* css2.1/
20110323/fixed-table-layout-013-expected.html: Removed.
* css2.1/
20110323/fixed-table-layout-013.htm: Removed.
* css2.1/
20110323/fixed-table-layout-015-expected.html: Removed.
* css2.1/
20110323/fixed-table-layout-015.htm: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 20 Feb 2012 13:42:14 +0000 (13:42 +0000)]
Web Inspector: [Styles] Inconsistent alignment of non-parsed properties (having an exclamation mark)
https://bugs.webkit.org/show_bug.cgi?id=79028
Reviewed by Yury Semikhatsky.
* inspector/front-end/elementsPanel.css:
(.styles-section .properties li.not-parsed-ok img.exclamation-mark):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 20 Feb 2012 13:11:40 +0000 (13:11 +0000)]
Web Inspector: DOMAttrModified should not be fired if the attribute value remains the same
https://bugs.webkit.org/show_bug.cgi?id=79025
Reviewed by Pavel Feldman.
Source/WebCore:
* dom/Element.cpp:
(WebCore::Element::willModifyAttribute):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::willModifyDOMAttr):
(WebCore):
(WebCore::InspectorDOMAgent::didModifyDOMAttr):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willModifyDOMAttr):
LayoutTests:
* inspector/elements/set-attribute-expected.txt:
* inspector/elements/set-attribute.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wingo@igalia.com [Mon, 20 Feb 2012 13:00:22 +0000 (13:00 +0000)]
Fix ChangeLog from last commit.
* ChangeLog: Quick fix to date and email address.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wingo@igalia.com [Mon, 20 Feb 2012 12:49:41 +0000 (12:49 +0000)]
2012-02-120 Andy Wingo <wingo@pobox.com>
Remove unused features from CodeFeatures
https://bugs.webkit.org/show_bug.cgi?id=78804
Reviewed by Gavin Barraclough.
* parser/Nodes.h:
* parser/ASTBuilder.h:
(JSC::ClosureFeature):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::usesClosures):
Remove "ClosureFeature". Since we track captured variables more
precisely, this bit doesn't do us any good.
(JSC::AssignFeature):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
(JSC::ASTBuilder::usesAssignment):
Similarly, remove AssignFeature. It is unused.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Feb 2012 12:25:14 +0000 (12:25 +0000)]
[Qt][WK2] Implement proxy authentication handling.
https://bugs.webkit.org/show_bug.cgi?id=78792
Patch by Michael BrĂ¼ning <michael.bruning@nokia.com> on 2012-02-20
Reviewed by Simon Hausmann.
This patch implements the proxy authentication handling
for the Qt port in a similar matter to the http authentication
implementation.
Since there is a need to pass the proxy port, which is of type uint16_t,
from the WebProcess to the UIProcess, an encoder and a decoder for
this type was added because it did not exist.
The message that was added to the WebPageProxy is called synchronously
as this is needed by the implementation of the network access manager
and has also been implemented this way already for the http
authentication.
* Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::decodeUInt16):
(CoreIPC):
* Platform/CoreIPC/ArgumentDecoder.h:
(ArgumentDecoder):
(CoreIPC::ArgumentDecoder::decode):
(CoreIPC):
* Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::encodeUInt16):
(CoreIPC):
* Platform/CoreIPC/ArgumentEncoder.h:
(ArgumentEncoder):
(CoreIPC::ArgumentEncoder::encode):
(CoreIPC):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleProxyAuthenticationRequiredRequest):
(QQuickWebViewExperimental::proxyAuthenticationDialog):
(QQuickWebViewExperimental::setProxyAuthenticationDialog):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/PageClient.h:
(PageClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::proxyAuthenticationRequiredRequest):
(WebKit):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/QtDialogRunner.cpp:
(ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::ProxyAuthenticationDialogContextObject):
(ProxyAuthenticationDialogContextObject::hostname):
(ProxyAuthenticationDialogContextObject::port):
(ProxyAuthenticationDialogContextObject::prefilledUsername):
(ProxyAuthenticationDialogContextObject::accept):
(ProxyAuthenticationDialogContextObject::reject):
(QtDialogRunner::initForProxyAuthentication):
* UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::handleProxyAuthenticationRequiredRequest):
* UIProcess/qt/QtPageClient.h:
(QtPageClient):
* WebProcess/WebPage/DecoderAdapter.cpp:
(WebKit::DecoderAdapter::decodeUInt16):
(WebKit):
* WebProcess/WebPage/DecoderAdapter.h:
(DecoderAdapter):
* WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::encodeUInt16):
(WebKit):
* WebProcess/WebPage/EncoderAdapter.h:
(EncoderAdapter):
* WebProcess/qt/QtNetworkAccessManager.cpp:
(WebKit::QtNetworkAccessManager::onProxyAuthenticationRequired):
(WebKit):
* WebProcess/qt/QtNetworkAccessManager.h:
(QtNetworkAccessManager):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wingo@igalia.com [Mon, 20 Feb 2012 12:16:23 +0000 (12:16 +0000)]
Add wingo as a committer.
Unreviewed.
* Scripts/webkitpy/common/config/committers.py: Add myself to the
committers list.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Feb 2012 11:44:41 +0000 (11:44 +0000)]
Correct a typo error in ScrollingCoordinator.h
https://bugs.webkit.org/show_bug.cgi?id=79012
Patch by Kwonjin Jeong <gram@company100.net> on 2012-02-20
Reviewed by Andreas Kling.
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 20 Feb 2012 10:50:55 +0000 (10:50 +0000)]
Web Inspector: [Styles] box-shadow and -webkit-box-shadow properties are not considered color-aware
https://bugs.webkit.org/show_bug.cgi?id=78988
Reviewed by Yury Semikhatsky.
* inspector/front-end/CSSKeywordCompletions.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Feb 2012 10:47:55 +0000 (10:47 +0000)]
[Forms] Spin buttons of number input type should fire both input and change event
https://bugs.webkit.org/show_bug.cgi?id=75067
Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-02-20
Reviewed by Kent Tamura.
Source/WebCore:
This patch makes spin button in number input field clicks to fire input and change events as described in WHATWG HTML5 specification.
To implement this behavior, this patch introduces new value DispatchInputAndChangeEvent in TextFieldEventBehavior.
Test: fast/forms/number/spin-button-events.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::stepUpFromRenderer): Pass DispatchInputAndChangeEvent instead of DispatchChangeEvent to applyStep, setValue, and setValueAsNumber.
* html/HTMLTextFormControlElement.h: Add new enum value DispatchInputAndChangeEvent to TextFieldEventBehavior.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::setValue): Handle DispatchInputAndChangeEvent and use RefPtr for element to keep reference.
LayoutTests:
* fast/forms/number/spin-button-events-expected.txt: Added.
* fast/forms/number/spin-button-events.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 20 Feb 2012 10:15:33 +0000 (10:15 +0000)]
[CMake] Update and sort list of source files.
* CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Mon, 20 Feb 2012 09:33:15 +0000 (09:33 +0000)]
Attached/Detached state must be testable
https://bugs.webkit.org/show_bug.cgi?id=79010
Reviewed by Hajime Morita.
Source/WebCore:
Added a method to check an element attached or not.
Test: fast/dom/shadow/shadow-root-attached.html
* testing/Internals.cpp:
(WebCore::Internals::attached):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
LayoutTests:
* fast/dom/shadow/shadow-root-attached-expected.txt: Added.
* fast/dom/shadow/shadow-root-attached.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Mon, 20 Feb 2012 09:30:24 +0000 (09:30 +0000)]
[chromium] check that we're not running multiple modal dialogs at the same time
https://bugs.webkit.org/show_bug.cgi?id=78486
Reviewed by Kent Tamura.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setIsDisplayingModalDialog):
(TestShell::isDisplayingModalDialog):
(TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::runModal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 20 Feb 2012 09:12:46 +0000 (09:12 +0000)]
Fix WebKit2GTK+ for 'make distcheck'.
Instead of conditionally including WebKit2 GNUmakefiles, always
include them and conditionally activate the final targets.
.:
* GNUmakefile.am:
Source/WebKit2:
* GNUmakefile.am:
* UIProcess/API/gtk/tests/GNUmakefile.am:
Tools:
* MiniBrowser/gtk/GNUmakefile.am:
* WebKitTestRunner/GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Mon, 20 Feb 2012 08:59:42 +0000 (08:59 +0000)]
[WebSocket] Add deflater/inflater classes
https://bugs.webkit.org/show_bug.cgi?id=78449
Source/WebCore:
Add WebSocketDeflater/WebSocketInflater classes which wrap zlib
functions. These classes are not used yet, but will be used for
supporting WebSocket deflate-frame extension.
This patch is second try. The previous patch broke Chromium Win
build. I added dependency of zlib to WebCore.gyp. I think it's
OK because Chromium already depends on zlib.
Reviewed by Kent Tamura.
No new tests except for chromium port. Behavior is unchanged.
* GNUmakefile.list.am: Added WebSocketDeflater.(cpp|h).
* WebCore.gyp/WebCore.gyp: Added zlib dependency.
* WebCore.gypi: Added WebSocketDeflater.(cpp|h).
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* websockets/WebSocketDeflater.cpp: Added.
(WebCore):
(WebCore::WebSocketDeflater::create):
(WebCore::WebSocketDeflater::WebSocketDeflater):
(WebCore::WebSocketDeflater::initialize):
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::setStreamParameter):
(WebCore::WebSocketDeflater::addBytes):
(WebCore::WebSocketDeflater::finish):
(WebCore::WebSocketDeflater::reset):
(WebCore::WebSocketInflater::create):
(WebCore::WebSocketInflater::WebSocketInflater):
(WebCore::WebSocketInflater::initialize):
(WebCore::WebSocketInflater::~WebSocketInflater):
(WebCore::WebSocketInflater::addBytes):
(WebCore::WebSocketInflater::finish):
(WebCore::WebSocketInflater::reset):
* websockets/WebSocketDeflater.h: Added.
(WebCore):
(WebSocketDeflater):
(WebCore::WebSocketDeflater::data):
(WebCore::WebSocketDeflater::size):
(WebSocketInflater):
(WebCore::WebSocketInflater::data):
(WebCore::WebSocketInflater::size):
Source/WebKit/chromium:
Add tests which ensure WebSocketDeflater/WebSocketInflater can
compress/decompress data correctly.
Reviewed by Kent Tamura.
* WebKit.gypi: Added zlib dependency.
* WebKitUnitTests.gyp: Ditto.
* tests/WebSocketDeflaterTest.cpp: Added.
(WebCore):
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 20 Feb 2012 08:40:15 +0000 (08:40 +0000)]
Web Inspector: consume undo/redo shortcuts.
https://bugs.webkit.org/show_bug.cgi?id=79016
Reviewed by Vsevolod Vlasov.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleShortcut):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Mon, 20 Feb 2012 08:39:58 +0000 (08:39 +0000)]
Enable video option for EFL port in build-webkit.
https://bugs.webkit.org/show_bug.cgi?id=79006
Reviewed by Daniel Bates.
* Scripts/build-webkit:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 20 Feb 2012 08:38:05 +0000 (08:38 +0000)]
[GTK][WK2] WebKit2 does not build if gtk-unix-printing-3.0 is not available
https://bugs.webkit.org/show_bug.cgi?id=79011
Fix the build when gtk-unix-printing-3.0 is not present.
* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialog):
(webkitPrintOperationRunDialogForFrame):
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 20 Feb 2012 08:37:23 +0000 (08:37 +0000)]
MediaPlayer: MediaPlayerPrivate registration cleanup
https://bugs.webkit.org/show_bug.cgi?id=78897
Reviewed by Martin Robinson.
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Simplified GStreamer Private
player registration by using the PlatformMediaEngineClassName
macro like other players do.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 20 Feb 2012 08:34:54 +0000 (08:34 +0000)]
Unreviewed, GTK baselines for a new fast/css-generated-content
test.
* platform/gtk/fast/css-generated-content/before-content-continuation-chain-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 20 Feb 2012 08:28:49 +0000 (08:28 +0000)]
Unreviewed, GTK fast/repaint rebaseline.
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* platform/gtk/fast/repaint/region-painting-via-layout-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 20 Feb 2012 07:51:27 +0000 (07:51 +0000)]
[Chromium] Web Inspector: terminated workers are not removed from dedicated worker list
https://bugs.webkit.org/show_bug.cgi?id=78899
Source/WebCore:
Notify inspector about starting context from WorkerContextProxy not from Worker.
Reviewed by Pavel Feldman.
* workers/Worker.cpp:
(WebCore::Worker::notifyFinished):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):
Source/WebKit/chromium:
Pass original WorkerContextProxy object to the inspector instrumentation instead
of Chromium-specific one for consistency with WorkerMessagingProxy implementation
in WebCore.
Reviewed by Pavel Feldman.
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Mon, 20 Feb 2012 07:41:56 +0000 (07:41 +0000)]
[CMAKE] Check gstreamer minimum required version.
https://bugs.webkit.org/show_bug.cgi?id=79005
Reviewed by Daniel Bates.
To enable video, Gstreamer version requires to be above 0.10.30.
This patch checks whether Gstreamer version is greater than 0.10.30.
* Source/cmake/FindGStreamer-App.cmake:
* Source/cmake/FindGStreamer-Base.cmake:
* Source/cmake/FindGStreamer-Interfaces.cmake:
* Source/cmake/FindGStreamer-Pbutils.cmake:
* Source/cmake/FindGStreamer-Plugins-Base.cmake:
* Source/cmake/FindGStreamer-Video.cmake:
* Source/cmake/FindGStreamer.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Mon, 20 Feb 2012 07:03:33 +0000 (07:03 +0000)]
[Chromium] Unreviewed, update a few test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Mon, 20 Feb 2012 06:17:31 +0000 (06:17 +0000)]
Use shadowRootList for ColorInputType
https://bugs.webkit.org/show_bug.cgi?id=79007
Reviewed by Kent Tamura.
* html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree): Changed shadowRoot to shadowRootList.
(WebCore::ColorInputType::shadowColorSwatch): Changed shadowRoot to shadowRootList.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Mon, 20 Feb 2012 06:06:07 +0000 (06:06 +0000)]
[chromium] Unreviewed. Update remaining expectations for SVGImageElement-svgdom-requiredFeatures.html.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Removed.
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Mon, 20 Feb 2012 06:00:35 +0000 (06:00 +0000)]
Introduce InsertionPoint, which will be a common base class of HTMLShadowElement and HTMLContentElement.
https://bugs.webkit.org/show_bug.cgi?id=78771
Reviewed by Hajime Morita.
This patch introduces InsertionPoint, which will be a common base class of HTMLShadowElement and HTMLContentElement.
This is a step for rendering <shadow> correctly, because <shadow> has almost the same function of <content>.
After this patch, we will change NodeRenderingContext and related classes to accept InsertionPoint instead of
HTMLContentElement only.
No new tests, no change in behavior.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::parseAttribute):
* html/shadow/HTMLContentElement.h:
* html/shadow/InsertionPoint.cpp: Added.
(WebCore):
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::~InsertionPoint):
* html/shadow/InsertionPoint.h: Added.
(WebCore):
(InsertionPoint):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 20 Feb 2012 05:24:14 +0000 (05:24 +0000)]
[GTK] Can't find webinspector and error page redirection on Windows
https://bugs.webkit.org/show_bug.cgi?id=51616
Source/WebCore:
Create and use an abstraction for finding shared resources on Windows.
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-02-19
Reviewed by Martin Robinson.
* platform/FileSystem.h:
(WebCore):
* platform/audio/gtk/AudioBusGtk.cpp:
(WebCore::AudioBus::loadPlatformResource):
* platform/graphics/gtk/ImageGtk.cpp:
(WebCore::getPathToImageResource):
* platform/gtk/FileSystemGtk.cpp:
(WebCore::sharedResourcesPath):
(WebCore):
Source/WebKit/gtk:
Use an abstraction for finding shared resources on Windows.
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2012-02-19
Reviewed by Martin Robinson.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidFailLoad):
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::inspectorFilesPath):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Mon, 20 Feb 2012 04:22:22 +0000 (04:22 +0000)]
[Chromium] Unreviewed gardening. Update Leopard expectation for
SVGImageElement-svgdom-requiredFeatures.html.
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Mon, 20 Feb 2012 01:11:19 +0000 (01:11 +0000)]
[chromium] Unreviewed - mark failing test as failing.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Mon, 20 Feb 2012 00:04:54 +0000 (00:04 +0000)]
[chromium] Unreviewed gardening. Add leopard baselines for fast/css/relative-positioned-block-* tests, fix up test_expectations.txt
* platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sun, 19 Feb 2012 23:51:39 +0000 (23:51 +0000)]
Move stub implementations of ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp
https://bugs.webkit.org/show_bug.cgi?id=78951
Reviewed by Adam Barth.
This move stubs for ScrollingCoordinator functions into ScrollingCoordinatorNone.cpp instead of #ifdefing inside
ScrollingCoordinator.cpp. The mac port uses ScrollingCoordinator when #if ENABLE(THREADED_SCROLLING) is not set
and implementations in ScrollingCoordinator.cpp / ScrollingCoordinatorMac.mm otherwise. The chromium port
always uses implementations in ScrollingCoordinatorChromium.cpp. All other ports use
ScrollingCoordinatorNone.cpp.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbx:
* page/scrolling/ScrollingCoordinator.cpp:
* page/scrolling/ScrollingCoordinatorNone.cpp:
(WebCore):
(WebCore::ScrollingCoordinator::create):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinator::create):
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Sun, 19 Feb 2012 23:47:10 +0000 (23:47 +0000)]
Rename [CheckDomainSecurity] to [CheckSecurity]
https://bugs.webkit.org/show_bug.cgi?id=78874
Reviewed by Adam Barth.
"Domain security" isn't a term that's used elsewhere.
This patch renames IDL attributes as follows:
- [CheckDomainSecurity] => [CheckSecurity]
- [DoNotCheckDomainSecurity] => [DoNotCheckSecurity]
- [DoNotCheckDomainSecurityOnGetter] => [DoNotCheckSecurityOnGetter]
- [DoNotCheckDomainSecurityOnSetter] => [DoNotCheckSecurityOnSetter]
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertyDescriptorBody):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(IsVisibleAcrossOrigins):
(GenerateFunctionCallback):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateToV8Converters):
* bindings/scripts/test/TestDomainSecurity.idl:
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
* page/DOMWindow.idl:
* page/History.idl:
* page/Location.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sun, 19 Feb 2012 23:32:55 +0000 (23:32 +0000)]
Unreviewed, rolling out r108195.
http://trac.webkit.org/changeset/108195
https://bugs.webkit.org/show_bug.cgi?id=77700
Lots of failing ASSERT()s on v8 bots, requested by kling on
#webkit
Source/WebCore:
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
LayoutTests:
* fast/css/css-value-wrapper-sameness-expected.txt: Removed.
* fast/css/css-value-wrapper-sameness.html: Removed.
* fast/dom/StyleSheet/gc-inline-style-cssvalues-expected.txt: Added.
* fast/dom/StyleSheet/gc-inline-style-cssvalues.html: Added.
* fast/dom/domListEnumeration-expected.txt:
* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:
* fast/dom/script-tests/domListEnumeration.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Sun, 19 Feb 2012 23:30:47 +0000 (23:30 +0000)]
Rename [CheckAccessToNode] to [CheckSecurityForNode]
https://bugs.webkit.org/show_bug.cgi?id=78991
Reviewed by Adam Barth.
For naming consistency with [CheckSecurity], this patch renames
[CheckAccessToNode] to [CheckSecurityForNode].
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* html/HTMLEmbedElement.idl:
* html/HTMLFrameElement.idl:
* html/HTMLIFrameElement.idl:
* html/HTMLObjectElement.idl:
* page/DOMWindow.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sun, 19 Feb 2012 23:24:35 +0000 (23:24 +0000)]
Sort WebCore XCode project files with sort-Xcode-project-files script. Unreviewed.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sun, 19 Feb 2012 20:58:36 +0000 (20:58 +0000)]
Update expectations for test results changed by r108185
The bots only check text results.
Unreviewed.
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Sun, 19 Feb 2012 20:16:34 +0000 (20:16 +0000)]
Make CSSValue wrapper getters return unique objects every time.
<http://webkit.org/b/77700>
Reviewed by Antti Koivisto.
Source/WebCore:
Change the behavior of CSSValue getters to return unique JS wrappers every
time they are called. This means we no longer have to deal with the risk
of leaking custom properties between unrelated documents, and are free to
implement global value sharing across WebCore.
This patch will be followed by one making CSSValuePool globally shared,
it's done in two steps to monitor the impact of this change.
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(IsCSSValueType):
LayoutTests:
* fast/css/css-value-wrapper-sameness-expected.txt: Added.
* fast/css/css-value-wrapper-sameness.html: Added.
* fast/dom/StyleSheet/gc-inline-style-cssvalues-expected.txt: Removed.
* fast/dom/StyleSheet/gc-inline-style-cssvalues.html: Removed.
* fast/dom/domListEnumeration-expected.txt:
* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:
* fast/dom/script-tests/domListEnumeration.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Sun, 19 Feb 2012 20:06:56 +0000 (20:06 +0000)]
Crash in RenderBlock::splitAnonymousBlocksAroundChild.
https://bugs.webkit.org/show_bug.cgi?id=78994
Reviewed by Eric Seidel.
Source/WebCore:
Generalize splitTablePartsAroundChild to handle splitting
in nested tables.
Table->Table Section->Table Row->Table Cell->Table->Table Section->Table Row
Test: fast/table/table-split-inside-table.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitTablePartsAroundChild):
LayoutTests:
* fast/table/table-split-inside-table-expected.txt: Added.
* fast/table/table-split-inside-table.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Sun, 19 Feb 2012 19:36:13 +0000 (19:36 +0000)]
Unreviewed. Remove gsettings schema from EXTRA_DIST.
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 19 Feb 2012 19:29:44 +0000 (19:29 +0000)]
[EFL] Use modifier keys to execute pre-rendering.
https://bugs.webkit.org/show_bug.cgi?id=77933
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-02-19
Reviewed by Chang Shu.
Use modifier key to execute pre-rendering instead of using reserved function keys.
* EWebLauncher/main.c:
(on_key_down):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 19 Feb 2012 19:16:28 +0000 (19:16 +0000)]
[GTK] Fix build on platforms where UChar is wchar_t
https://bugs.webkit.org/show_bug.cgi?id=78996
Patch by Kalev Lember <kalevlember@gmail.com> on 2012-02-19
Reviewed by Martin Robinson.
The ICU backend defines UChar as wchar_t for platforms where wchar_t is
16 bits wide, e.g. win32.
* platform/graphics/pango/FontPango.cpp:
(WebCore::utf16ToUtf8): Use reinterpret_cast instead of static_cast.
* platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::typeAheadFind): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Sun, 19 Feb 2012 19:16:25 +0000 (19:16 +0000)]
[GTK] Remove unused GSettings stuff
https://bugs.webkit.org/show_bug.cgi?id=78995
Reviewed by Martin Robinson.
.:
* configure.ac: remove gsettings schema file creation.
Source/WebKit/gtk:
* GNUmakefile.am: remove GSettings-related stuff.
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit): Remove unused code.
* org.webkitgtk.gschema.xml.in: Removed.
* webkit/webkitwebinspector.cpp:
(webkit_web_inspector_execute_script): remove gsettings-related helper.
* webkit/webkitwebinspectorprivate.h: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sun, 19 Feb 2012 19:01:40 +0000 (19:01 +0000)]
Perf-o-matic should show both WebKit and Chromium revisions
https://bugs.webkit.org/show_bug.cgi?id=78955
Reviewed by Andreas Kling.
Include Chromium revision numbers in runs responses when available.
* Websites/webkit-perf.appspot.com/js/config.js:
(urlForChangeset):
(urlForChangesetList):
* Websites/webkit-perf.appspot.com/runs_handler.py:
(RunsHandler.post):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Sun, 19 Feb 2012 16:53:01 +0000 (16:53 +0000)]
Unreviewed. Fix make distcheck issues.
Source/JavaScriptCore:
* GNUmakefile.list.am: Add missing files.
Source/WebCore:
* GNUmakefile.list.am: Add missing header.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sun, 19 Feb 2012 16:27:42 +0000 (16:27 +0000)]
Chromium results for r108185
Unreviewed gardening.
* platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png.
* platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png.
* platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png.
* platform/chromium-linux/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png.
* platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png.
* platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png.
* platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png.
* platform/chromium-linux/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.png.
* platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png.
* platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png.
* platform/chromium-linux/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/encoding/utf-16-big-endian-expected.png.
* platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/encoding/utf-16-little-endian-expected.png.
* platform/chromium-mac-snowleopard/fast/inline/continuation-outlines-with-layers-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png.
* platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
* platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png: Removed.
* platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png: Removed.
* platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
* platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt.
* platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt.
* platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
* platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt.
* platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
* platform/chromium-win/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
* platform/chromium-win/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt.
* platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
* platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
* platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.png:
* platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Sun, 19 Feb 2012 15:24:50 +0000 (15:24 +0000)]
CSS 2.1 failure: inline-box-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=69210
Reviewed by David Hyatt.
Source/WebCore:
Tests: css2.1/
20110323/dynamic-top-change-005.htm
css2.1/
20110323/dynamic-top-change-005a.htm
css2.1/
20110323/dynamic-top-change-005b.htm
css2.1/
20110323/inline-box-002.htm
fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html
fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html
fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html
fast/css/relative-positioned-block-nested-with-inline-parent.html
fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html
fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html
fast/css/relative-positioned-block-with-inline-ancestor-dynamic.html
fast/css/relative-positioned-block-with-inline-ancestor.html
fast/css/relative-positioned-block-with-inline-parent-dynamic-removed.html
fast/css/relative-positioned-block-with-inline-parent-dynamic.html
fast/css/relative-positioned-block-with-inline-parent-keeps-style.html
fast/css/relative-positioned-block-with-inline-parent.html
A block within an inline is affected by relative positioning on the inline box. Give
the anonymous block containing the block a layer and make it relative positioned. Then
calculate the offset of the anonymous block's layer by accumulating the offsets from its
inline continuation and the inline continuation's inline parents.
If the position of an inline changes from or to relative positioned then ensure that any
descendant blocks update their position and layer accordingly.
* rendering/RenderBoxModelObject.cpp:
(): add an enum RelPosAxis
(WebCore::accumulateRelativePositionOffsets):
Total up the offsets of all relatively positioned inlines that are de-facto parents of the relatively
positioned anonymous block's child block.
(WebCore):
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
Use accumulateRelativePositionOffsets when calculating the relative position offset of a relatively positioned anonymous block.
(WebCore::RenderBoxModelObject::relativePositionOffsetY): ditto
* rendering/RenderInline.cpp:
(WebCore::hasRelPositionedInlineAncestor):
Detects if the anonymous block contains a block that is the de-facto descendant of a relatively positioned inline.
(WebCore::updateStyleOfAnonymousBlockContinuations):
Update the style's positioning for each anonymous block containing a block that is descendant from the inline whose style has changed.
(WebCore::RenderInline::styleDidChange):
If an inline changes to or from relative positioning ensure that any descendant blocks change to or from relative positioning
as well, unless they still have a relatively positioned ancestor after the current ancestor loses its relative positioning.
(WebCore::RenderInline::addChildIgnoringContinuation):
If the anonymous block contains a block that is effectively descended from a relatively positioned inline, make it relatively
positioned so the block will respect its inline ancestor's relative positioning.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
Preserve style position in anonymous block continuations when the parent block propagates a style change.
LayoutTests:
* css2.1/
20110323/dynamic-top-change-005-expected.html: Added.
* css2.1/
20110323/dynamic-top-change-005.htm: Added.
* css2.1/
20110323/dynamic-top-change-005a-expected.html: Added.
* css2.1/
20110323/dynamic-top-change-005a.htm: Added.
* css2.1/
20110323/dynamic-top-change-005b-expected.html: Added.
* css2.1/
20110323/dynamic-top-change-005b.htm: Added.
* css2.1/
20110323/inline-box-002-expected.html: Added.
* css2.1/
20110323/inline-box-002.htm: Added.
* fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed.html: Added.
* fast/css/relative-positioned-block-nested-with-inline-parent-dynamic.html: Added.
* fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic.html: Added.
* fast/css/relative-positioned-block-nested-with-inline-parent.html: Added.
* fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html: Added.
* fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed.html: Added.
* fast/css/relative-positioned-block-with-inline-ancestor-dynamic.html: Added.
* fast/css/relative-positioned-block-with-inline-ancestor.html: Added.
* fast/css/relative-positioned-block-with-inline-parent-dynamic-removed.html: Added.
* fast/css/relative-positioned-block-with-inline-parent-dynamic.html: Added.
* fast/css/relative-positioned-block-with-inline-parent-expected.html: Added.
* fast/css/relative-positioned-block-with-inline-parent-keeps-style.html: Added.
* fast/css/relative-positioned-block-with-inline-parent.html: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
* platform/chromium-linux-x86/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.
* platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
* platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
* platform/chromium-linux/fast/inline/continuation-outlines-with-layers-2-expected.txt:
* platform/chromium-linux/fast/inline/continuation-outlines-with-layers-expected.png:
* platform/chromium-linux/fast/repaint/transform-absolute-in-positioned-container-expected.png:
* platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
* platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
* platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.txt:
* platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
* platform/chromium/test_expectations.txt: Suppress existing tests until results rebaselined.
* platform/gtk/test_expectations.txt: ditto
* platform/mac/test_expectations.txt: ditto
* platform/qt/test_expectations.txt: ditto
* platform/win/Skipped: ditto
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 19 Feb 2012 06:25:41 +0000 (06:25 +0000)]
Track the NPN protocol version negotiated with the server
https://bugs.webkit.org/show_bug.cgi?id=77349
Source/WebCore:
Patch by raman Tenneti <rtenneti@chromium.org> on 2012-02-18
Reviewed by Darin Fisher..
[chromium] Added ExtraData to WebURLResponse.
No intended functionality change.
* platform/network/chromium/ResourceResponse.h:
(ExtraData):
(WebCore::ResourceResponse::ExtraData::~ExtraData):
(ResourceResponse):
(WebCore::ResourceResponse::extraData):
(WebCore::ResourceResponse::setExtraData):
Source/WebKit/chromium:
Patch by raman Tenneti <rtenneti@chromium.org> on 2012-02-18
Reviewed by Darin Fisher.
[chromium] Added ExtraData to WebURLResponse.
* WebKit.gypi:
* public/platform/WebURLResponse.h:
(ExtraData):
(WebKit::WebURLResponse::ExtraData::~ExtraData):
(WebURLResponse):
* src/WebURLResponse.cpp:
(WebKit::WebURLResponse::extraData):
(WebKit):
(WebKit::WebURLResponse::setExtraData):
* tests/WebURLResponseTest.cpp: Added.
(WebKit):
(TestExtraData):
(WebKit::TestExtraData::TestExtraData):
(WebKit::TestExtraData::~TestExtraData):
(WebKit::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Sun, 19 Feb 2012 04:57:04 +0000 (04:57 +0000)]
Unreviewed, rolling out r107965.
http://trac.webkit.org/changeset/107965
https://bugs.webkit.org/show_bug.cgi?id=78273
Source/WebCore:
crashes
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
LayoutTests:
Crashes on ClusterFuzz.
* fast/multicol/span/clone-flexbox-expected.txt: Removed.
* fast/multicol/span/clone-flexbox.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sun, 19 Feb 2012 04:07:15 +0000 (04:07 +0000)]
Fix one more dangling reference to worker_connection.name, delete unused code.
Unreviewed, build fix.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.update):
(_WorkerState.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 19 Feb 2012 03:53:29 +0000 (03:53 +0000)]
<rdar://problem/
10891801> BackingStore::scroll() unnecessarily copies pixels around
https://bugs.webkit.org/show_bug.cgi?id=78976
Reviewed by Anders Carlsson.
Rather than move pixels in the backing store in response to scrolling, we can maintain a
mapping, for the most recently scrolled rect, from backing store coordinates to view
client coordinates.
* UIProcess/BackingStore.h:
* UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::performWithScrolledRectTransform): Added. Given a block to be
performed on a rect, divides the rect into parts such that for each part the mapping from
backing store coordinates to client coordinates is a (uniform) translation, and performs
the block on that part, passing it the translation that applies to the part.
(WebKit::BackingStore::resetScrolledRect): Added. Copies everything in the scrolled rect
back to where it should be under the identity map, and resets the scrolled rect and offset.
(WebKit::BackingStore::paint): Changed to call through performWithScrolledRectTransform().
(WebKit::BackingStore::incorporateUpdate): Ditto.
(WebKit::BackingStore::scroll): Now instead of copying pixels, just updates the scrolled
rect and offset.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 19 Feb 2012 01:53:04 +0000 (01:53 +0000)]
Fix style issues in DFG Phase classes
https://bugs.webkit.org/show_bug.cgi?id=78983
Reviewed by Ryosuke Niwa.
* dfg/DFGArithNodeFlagsInferencePhase.cpp:
* dfg/DFGCFAPhase.cpp:
* dfg/DFGCSEPhase.cpp:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
Add a space before the colon in class declarations.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 19 Feb 2012 01:08:39 +0000 (01:08 +0000)]
Make WebCore compile with libc++ (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=78974
Reviewed by Anders Carlsson.
* config.h:
Disable the DisallowCType check when using libc++.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 19 Feb 2012 00:57:57 +0000 (00:57 +0000)]
Fix the build.
* page/DOMWindow.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sun, 19 Feb 2012 00:50:46 +0000 (00:50 +0000)]
Add a change that should've been in r108005.
Unreviewed, build fix.
In the refactoring/cleanup in r108005 I should've changed the
implementation of WorkerConnection to make it match BrokerClient
(and everything else) so that objects had a name() method
instead of a name property.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_WorkerConnection.__init__):
(_WorkerConnection.name):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker.__init__):
(_TestsMixin.name):
(_TestsMixin.test_name):
(_TestsMixin.test_cancel):
(_TestsMixin.test_unknown_message):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sun, 19 Feb 2012 00:33:56 +0000 (00:33 +0000)]
Attempt to fix Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 18 Feb 2012 23:51:52 +0000 (23:51 +0000)]
webkitpy: remove webkitpy.common.array_stream
https://bugs.webkit.org/show_bug.cgi?id=78952
Reviewed by Eric Seidel.
Turns out array_stream didn't really do anything that StringIO
didn't do (at least as of Python 2.6). This change removes it
and updates all of the callers. Where possible, I changed the
test assertions in order to capture the intent more clearly,
e.g., instead of calling self.assertTrue('foo' in stream.get()),
we have self.assertContainsLine(stream, 'foo'), and instead of
self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
the latter isn't that much more readable, but StringIO doesn't
export an empty() method.
* Scripts/webkitpy/common/array_stream.py: Removed.
* Scripts/webkitpy/common/array_stream_unittest.py: Removed.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(passing_run):
(run_and_capture):
(StreamTestingMixin):
(StreamTestingMixin.assertContains):
(StreamTestingMixin.assertContainsLine):
(StreamTestingMixin.assertEmpty):
(StreamTestingMixin.assertNotEmpty):
(LintTest):
(LintTest.test_lint_test_files):
(LintTest.test_lint_test_files__errors):
(MainTest):
(MainTest.test_child_process_1):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_help_printing):
(MainTest.test_hung_thread):
(MainTest.test_no_tests_found):
(MainTest.test_no_tests_found_2):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_test_list):
(MainTest.test_unexpected_failures):
(MainTest.test_worker_model__inline_with_child_processes):
(MainTest.test_additional_platform_directory):
(RebaselineTest):
(RebaselineTest.assertBaselines):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):
* Scripts/webkitpy/layout_tests/views/metered_stream.py:
(MeteredStream.update):
* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(TestMeteredStream.test_regular):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(TestUtilityFunctions.assertEmpty):
(TestUtilityFunctions):
(TestUtilityFunctions.assertNotEmpty):
(TestUtilityFunctions.assertWritten):
(TestUtilityFunctions.test_configure_logging):
(Testprinter.assertEmpty):
(Testprinter):
(Testprinter.assertNotEmpty):
(Testprinter.assertWritten):
(Testprinter.reset):
(Testprinter.get_printer):
(Testprinter.test_help_printer):
(Testprinter.do_switch_tests.do_helper):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_print_test_result):
(Testprinter.test_print_progress):
(Testprinter.test_write_nothing):
(Testprinter.test_write_misc):
(Testprinter.test_write_everything):
(Testprinter.test_write_verbose):
(Testprinter.test_print_unexpected_results):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.assertWritten):
(create_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
(test_run_test_set_with_multiple_repositories):
(test_upload_json):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 18 Feb 2012 23:42:03 +0000 (23:42 +0000)]
Make WebCore compile with libc++ (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=78974
Reviewed by Anders Carlsson.
Add a workaround for <rdar://problem/
10858112>, which cause the standard heap functions
not to work when using an iterator with proxy objects for reference and pointer types.
* WebCorePrefix.h:
(move):
Add an overload of std::move that the heap functions can call successfully.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Sat, 18 Feb 2012 22:30:44 +0000 (22:30 +0000)]
Unreviewed chromium rebaselines after r108157.
* platform/chromium-mac/fast/dom/setPrimitiveValue-exceptions-expected.txt:
* platform/chromium-win/fast/dom/setPrimitiveValue-exceptions-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sat, 18 Feb 2012 22:10:28 +0000 (22:10 +0000)]
[wx] Fix wx port compilation.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sat, 18 Feb 2012 22:07:18 +0000 (22:07 +0000)]
[wx] Build fixes for C++ bindings after recent changes.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sat, 18 Feb 2012 22:04:06 +0000 (22:04 +0000)]
[wx] Build fix, add new platform method wx impl.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 18 Feb 2012 21:48:15 +0000 (21:48 +0000)]
Fix part of the windows build failure.
* WebCore.vcproj/WebCore.vcproj:
Don't build JSWebKitCSSRegionRule.cpp, since it is already being built
as part of DerivedSources.cpp.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 18 Feb 2012 21:30:58 +0000 (21:30 +0000)]
Fix the libc++ build.
Reviewed by Anders Carlsson.
* heap/Weak.h:
Libc++'s nullptr emulation does not allow default construction
of the nullptr_t type. Work around this with the arguably clearer
just returning nullptr.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 18 Feb 2012 21:28:05 +0000 (21:28 +0000)]
Fix the ENABLE(THREADED_SCROLLING) build.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 18 Feb 2012 20:07:32 +0000 (20:07 +0000)]
DFGPropagator.cpp has too many things
https://bugs.webkit.org/show_bug.cgi?id=78956
Reviewed by Oliver Hunt.
Added the notion of a DFG::Phase. Removed DFG::Propagator, and took its
various things and put them into separate files. These new phases follow
the naming convention "DFG<name>Phase" where <name> is a noun. They are
called via functions of the form "perform<name>".
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGArithNodeFlagsInferencePhase.cpp: Added.
(DFG):
(JSC::DFG::performArithNodeFlagsInference):
* dfg/DFGArithNodeFlagsInferencePhase.h: Added.
(DFG):
* dfg/DFGCFAPhase.cpp: Added.
(DFG):
(JSC::DFG::performCFA):
* dfg/DFGCFAPhase.h: Added.
(DFG):
* dfg/DFGCSEPhase.cpp: Added.
(DFG):
(JSC::DFG::performCSE):
* dfg/DFGCSEPhase.h: Added.
(DFG):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGPhase.cpp: Added.
(DFG):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
* dfg/DFGPhase.h: Added.
(DFG):
(Phase):
(JSC::DFG::Phase::Phase):
(JSC::DFG::Phase::~Phase):
(JSC::DFG::Phase::globalData):
(JSC::DFG::Phase::codeBlock):
(JSC::DFG::Phase::profiledBlock):
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
(JSC::DFG::runPhase):
* dfg/DFGPredictionPropagationPhase.cpp: Added.
(DFG):
(JSC::DFG::performPredictionPropagation):
* dfg/DFGPredictionPropagationPhase.h: Added.
(DFG):
* dfg/DFGPropagator.cpp: Removed.
* dfg/DFGPropagator.h: Removed.
* dfg/DFGVirtualRegisterAllocationPhase.cpp: Added.
(DFG):
(JSC::DFG::performVirtualRegisterAllocation):
* dfg/DFGVirtualRegisterAllocationPhase.h: Added.
(DFG):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Sat, 18 Feb 2012 19:58:57 +0000 (19:58 +0000)]
HTML: Remove unnecessary attributeChange() overrides.
<http://webkit.org/b/78890>
Reviewed by Anders Carlsson.
Move logic from attributeChanged() overrides into parseAttribute().
This is a step towards making attributeChanged() non-virtual.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseAttribute):
* html/HTMLScriptElement.h:
(HTMLScriptElement):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute):
* html/HTMLTrackElement.h:
(HTMLTrackElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Sat, 18 Feb 2012 19:53:43 +0000 (19:53 +0000)]
Remove Element::createAttribute().
<http://webkit.org/b/78965>
Reviewed by Anders Carlsson.
Switch call sites to use Attribute::create() directly, as there is no magic
in calling Element::createAttribute() anymore (it used to be virtual and handled
differently by StyledElement.)
* dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
* dom/Element.h:
* svg/properties/SVGAnimatedPropertySynchronizer.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Sat, 18 Feb 2012 19:48:46 +0000 (19:48 +0000)]
HTMLBodyElement: Avoid synchronous style recalc when setting link/vlink/alink.
<http://webkit.org/b/78959>
Reviewed by Anders Carlsson.
Mark the body element for deferred style recalc instead of doing it synchronously
when the attributes change.
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::parseAttribute):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 18 Feb 2012 18:33:24 +0000 (18:33 +0000)]
Fix the TextureMapper build for non-Qt ports. Qt debug builds
must use RTTI, but GTK+, at least, does not.
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore): Make the RTTI check
Qt only.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Sat, 18 Feb 2012 18:17:13 +0000 (18:17 +0000)]
[wx] Unreviewed build fix. Don't error out or hang if we have
downloaded dependencies but server update check fails.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 18 Feb 2012 13:04:53 +0000 (13:04 +0000)]
[Qt] Unreviewed gardening after r107971.
* platform/qt/tables/mozilla/bugs/bug27038-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug27038-2-expected.txt:
* platform/qt/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 18 Feb 2012 12:59:09 +0000 (12:59 +0000)]
[Qt] Unreviewed weekend gardening, skip new failing tests.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 18 Feb 2012 12:51:08 +0000 (12:51 +0000)]
Unreviewed gardening r108133.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Sat, 18 Feb 2012 11:42:36 +0000 (11:42 +0000)]
FontFamilyValue: Utilize inheritance from CSSPrimitiveValue better.
<http://webkit.org/b/78806>
Reviewed by Antti Koivisto.
Source/WebCore:
Now that FontFamilyValue's string doesn't change after creation, we can just
pass the massaged family name up to the CSSPrimitiveValue constructor and get
cached cssText() for free. This also shrinks FontFamilyValue by sizeof(String)
though that's less of an issue now that we cache them in CSSValuePool.
* css/FontFamilyValue.cpp:
(WebCore::stripFontFamilyJunk):
(WebCore::FontFamilyValue::FontFamilyValue):
* css/FontFamilyValue.h:
(WebCore::FontFamilyValue::familyName):
(FontFamilyValue):
LayoutTests:
Rebaseline as CSSPrimitiveValue.getStringValue() is no longer broken for
font-family values.
* fast/dom/setPrimitiveValue-exceptions-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 18 Feb 2012 07:56:10 +0000 (07:56 +0000)]
DFG::Graph should have references to JSGlobalData, the CodeBlock being compiled, and
the CodeBlock that was used for profiling
https://bugs.webkit.org/show_bug.cgi?id=78954
Reviewed by Gavin Barraclough.
* bytecode/CodeBlock.h:
(JSC::baselineCodeBlockForOriginAndBaselineCodeBlock):
(JSC):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::execute):
* dfg/DFGAbstractState.h:
* dfg/DFGAssemblyHelpers.h:
(AssemblyHelpers):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::parse):
* dfg/DFGByteCodeParser.h:
(DFG):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::Graph):
(Graph):
(JSC::DFG::Graph::getJSConstantPrediction):
(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::isInt32Constant):
(JSC::DFG::Graph::isDoubleConstant):
(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::isBooleanConstant):
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfNumberConstant):
(JSC::DFG::Graph::valueOfBooleanConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
(JSC::DFG::Graph::baselineCodeBlockFor):
(JSC::DFG::Graph::valueProfileFor):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::JITCompiler):
(JITCompiler):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::isNotNegZero):
(JSC::DFG::Propagator::isNotZero):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::globalCFA):
(JSC::DFG::propagate):
* dfg/DFGPropagator.h:
(DFG):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isConstant):
(JSC::DFG::SpeculativeJIT::isJSConstant):
(JSC::DFG::SpeculativeJIT::isInt32Constant):
(JSC::DFG::SpeculativeJIT::isDoubleConstant):
(JSC::DFG::SpeculativeJIT::isNumberConstant):
(JSC::DFG::SpeculativeJIT::isBooleanConstant):
(JSC::DFG::SpeculativeJIT::isFunctionConstant):
(JSC::DFG::SpeculativeJIT::valueOfInt32Constant):
(JSC::DFG::SpeculativeJIT::valueOfNumberConstant):
(JSC::DFG::SpeculativeJIT::valueOfJSConstant):
(JSC::DFG::SpeculativeJIT::valueOfBooleanConstant):
(JSC::DFG::SpeculativeJIT::valueOfFunctionConstant):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 18 Feb 2012 07:28:22 +0000 (07:28 +0000)]
There is a warning in memset in glibc that gets triggered through a
warndecl when the fill-value of memset is a non-zero constant and the
size is zero. This warning is enabled when building with
-D_FORTIFY_SOURCE=2. This patch fixes the warning.
https://bugs.webkit.org/show_bug.cgi?id=78513
Patch by Ahmad Sharif <asharif.tools@gmail.com> on 2012-02-17
Reviewed by Alexey Proskuryakov
* wtf/Vector.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Sat, 18 Feb 2012 03:22:10 +0000 (03:22 +0000)]
Avoid inconsistency in Node::inDocument due to DOMSubtreeModified dispatch
https://bugs.webkit.org/show_bug.cgi?id=76087
Reviewed by Ryosuke Niwa.
Source/WebCore:
Move post-removal notifications after call to Node::removeFromDocument
to avoid inconsistent state of Node::inDocument() and thus avoid
inconsistent state in DocumentOrderedMap.
Tests: fast/dom/getElementById-consistency.html
fast/dom/getElementById-consistency2.html
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText): Fixed to work with new timing of DOMSubtreeModified dispatch.
LayoutTests:
* fast/dom/getElementById-consistency-expected.txt: Added.
* fast/dom/getElementById-consistency.html: Added.
* fast/dom/getElementById-consistency2-expected.txt: Added.
* fast/dom/getElementById-consistency2.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Sat, 18 Feb 2012 02:51:01 +0000 (02:51 +0000)]
[GTK] change the way of registering DeviceOrientation clients.
https://bugs.webkit.org/show_bug.cgi?id=78680
Reviewed by Gustavo Noronha Silva.
Bug 78085 removed deviceOrientationClient and deviceMotionClient from PageClients. Instead,
DeviceOrientationClient and DeviceMotionClient should be registered by PageSupplement class.
Chromium, mac and qt ports are already changed by Bug 78085.
* webkit/webkitwebview.cpp:
(webkit_web_view_init):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Sat, 18 Feb 2012 02:46:13 +0000 (02:46 +0000)]
IndexedDB: Support overloaded methods that take IDBKey or IDBKeyRange
https://bugs.webkit.org/show_bug.cgi?id=78399
Source/WebCore:
Implements IDBObjectStore.delete(IDBKeyRange) to exercise the functionality.
Reviewed by Tony Chang.
Test: storage/indexeddb/delete-range.html
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallString): Use .get() to disambiguate when passing RefPtr.
* bindings/scripts/test/V8/V8TestObj.cpp: Update test expectations.
* storage/IDBLevelDBBackingStore.cpp:
(WebCore):
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::deleteFunction):
(WebCore):
* storage/IDBObjectStore.h:
(IDBObjectStore):
* storage/IDBObjectStore.idl:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
* storage/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):
* storage/IDBObjectStoreBackendInterface.h:
Source/WebKit/chromium:
Implements the WebKit API for IDBObjectStore.delete(IDBKeyRange),
to exercise the overload capability.
Reviewed by Tony Chang.
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::deleteFunction):
(WebKit):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::deleteFunction):
(WebKit):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
LayoutTests:
Tests IDBObjectStore.delete(IDBKeyRange). The spec has been updated such
that delete() always yields a result of undefined rather than a boolean,
so other test expectations are updated.
Reviewed by Tony Chang.
* storage/indexeddb/delete-range-expected.txt: Added.
* storage/indexeddb/delete-range.html: Added.
* storage/indexeddb/mozilla/delete-result-expected.txt:
* storage/indexeddb/mozilla/delete-result.html:
* storage/indexeddb/objectStore-required-arguments-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/resources/objectstore-basics.js:
(createIndex):
(removeSuccess):
(removeSuccessButNotThere):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Sat, 18 Feb 2012 02:20:47 +0000 (02:20 +0000)]
Replace [V8OnInstance] with [V8Unforgeable]
https://bugs.webkit.org/show_bug.cgi?id=78894
Reviewed by Adam Barth.
[V8OnInstance] means that the method should be defined
(not on a prototype chain but) on a DOM object. It is the
same meaning as [V8Unforgeable]. This patch replaces [V8OnInstance]
with [V8Unforgeable].
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* page/Location.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sat, 18 Feb 2012 02:03:10 +0000 (02:03 +0000)]
[chromium] Unreviewed gardening, update baselines for svg/dynamic-updates/.. and some more getComputedStyle
results
* platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Removed.
* platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sat, 18 Feb 2012 01:19:23 +0000 (01:19 +0000)]
[chromium] Unreviewed build fix. MSVS gyp generator can't handle multiple .cpps with the same name in the same
target from different paths.
* WebCore.gypi:
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: Renamed from Source/WebCore/page/scrolling/chromium/ScrollingCoordinator.cpp.
(WebCore):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sat, 18 Feb 2012 01:02:54 +0000 (01:02 +0000)]
Unreviewed mac compile fix pt 2
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setScrollParameters):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 18 Feb 2012 01:01:30 +0000 (01:01 +0000)]
The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
https://bugs.webkit.org/show_bug.cgi?id=69444
Reviewed by Tony Chang.
Currently if a test's image checksum doesn't match the checksum
in the baseline, but the images themselves match according to
ImageDiff, new-run-webkit-tests ignores the problem. This is
probably bad, but it's not yet clear what the right thing to do
is. This patch will log a warning to stderr, at least (but the
test will still pass).
* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):
(SingleTestRunner._run_reftest):
* Scripts/webkitpy/layout_tests/port/test.py:
(unit_test_list):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108144
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 18 Feb 2012 00:56:05 +0000 (00:56 +0000)]
NRWT does not report failure for a skipped test
https://bugs.webkit.org/show_bug.cgi?id=78750
Reviewed by Eric Seidel.
If a test is listed in a Skipped file and you run it anyway
with --force, and the test fails, currently NRWT will print
"test ran as expected"; this is confusing, because you probably
expect the test to fail and yet this might lead you to think the
test passed. This patch changes the expected behavior to "PASS",
so tests that fail will be reported.
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(result_was_expected):
(TestExpectationParser):
(TestExpectationParser.expectation_for_skipped_test):
(TestExpectations):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_add_skipped_tests):
* Scripts/webkitpy/layout_tests/port/test.py:
(unit_test_list): Add some tests that are expected to be in a Skipped file.
(TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sat, 18 Feb 2012 00:50:03 +0000 (00:50 +0000)]
Unreviewed mac compile fix (unused parameter warning)
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108142
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 18 Feb 2012 00:33:52 +0000 (00:33 +0000)]
webkitpy: fix test code after bug 78181
https://bugs.webkit.org/show_bug.cgi?id=78870
Reviewed by Adam Barth.
I forgot to update the test code as per Tony's suggestion in
bug 78181 (r108005). This change does that, and in doing so
it revealed a subtle bug in _InlineWorkerConnection.run() that
I am fixing as part of this (_alive would not be cleared if an
exception was thrown).
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_InlineWorkerConnection.run):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker.__init__):
(_TestWorker.handle_stop):
(_TestWorker.handle_test):
(_TestWorker.run):
(_TestsMixin.handle_exception):
(_TestsMixin.test_unknown_message):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sat, 18 Feb 2012 00:23:16 +0000 (00:23 +0000)]
Move ScrollingCoordinator out of ENABLE(THREADED_SCROLLING) ifdef and enable on all platforms
https://bugs.webkit.org/show_bug.cgi?id=78401
Reviewed by Adam Barth.
Separates THREADED_SCROLLING from ScrollingCoordinator and enables ScrollingCoordinator-related code on
chromium. ScrollingCoordinator receives scrolling information to be used with an external scrolling source.
ENABLE(THREADED_SCROLLING) enables a codepath that uses a thread in WebCore to handle scrolling related input
events and interact with composited layers.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* dom/Document.cpp:
(WebCore::wheelEventHandlerCountChanged):
* page/FrameView.cpp:
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::performPostLayoutTasks):
* page/Page.cpp:
(WebCore::Page::~Page):
(WebCore):
* page/Page.h:
(Page):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(Settings):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::ScrollingCoordinator):
(WebCore::ScrollingCoordinator::~ScrollingCoordinator):
(WebCore::ScrollingCoordinator::pageDestroyed):
(WebCore):
* page/scrolling/ScrollingCoordinator.h:
(WebCore):
(ScrollingCoordinator):
* page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::createThreadIfNeeded):
* page/scrolling/ScrollingTreeState.cpp:
* page/scrolling/ScrollingTreeState.h:
* page/scrolling/chromium/ScrollingCoordinator.cpp: Added.
(WebCore):
(WebCore::ScrollingCoordinator::scheduleTreeStateCommit):
(WebCore::ScrollingCoordinator::frameViewScrollLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::shouldCompositeOverflowControls):
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):
(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::ensureRootLayer):
(WebCore):
* rendering/RenderLayerCompositor.h:
(WebCore):
(RenderLayerCompositor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sat, 18 Feb 2012 00:14:35 +0000 (00:14 +0000)]
[chromium] Unreviewed - removing expectations for tests that consistently pass, update some baselines for
getComputedStyle due to new -webkit-line-align property.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Sat, 18 Feb 2012 00:02:54 +0000 (00:02 +0000)]
Add FractionalLayoutPoint for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=78913
Reviewed by Eric Seidel.
Add FractionalLayoutUnit version of Point class and a couple of
conversion methods to the Int and Float versions of same.
No new tests.
* GNUmakefile.list.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/FloatPoint.cpp:
(WebCore::FloatPoint::FloatPoint):
(WebCore):
(WebCore::FloatPoint::moveBy):
* platform/graphics/FloatPoint.h:
(WebCore):
(FloatPoint):
* platform/graphics/FractionalLayoutPoint.h: Added.
(WebCore):
(FractionalLayoutPoint):
(WebCore::FractionalLayoutPoint::FractionalLayoutPoint):
(WebCore::FractionalLayoutPoint::zero):
(WebCore::FractionalLayoutPoint::x):
(WebCore::FractionalLayoutPoint::y):
(WebCore::FractionalLayoutPoint::setX):
(WebCore::FractionalLayoutPoint::setY):
(WebCore::FractionalLayoutPoint::move):
(WebCore::FractionalLayoutPoint::moveBy):
(WebCore::FractionalLayoutPoint::scale):
(WebCore::FractionalLayoutPoint::expandedTo):
(WebCore::FractionalLayoutPoint::shrunkTo):
(WebCore::FractionalLayoutPoint::clampNegativeToZero):
(WebCore::FractionalLayoutPoint::transposedPoint):
(WebCore::operator+=):
(WebCore::operator-=):
(WebCore::operator+):
(WebCore::operator-):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::toPoint):
(WebCore::toSize):
(WebCore::flooredIntPoint):
(WebCore::roundedIntPoint):
(WebCore::ceiledIntPoint):
* platform/graphics/FractionalLayoutSize.cpp:
(WebCore::pixelSnappedIntSize):
* platform/graphics/FractionalLayoutSize.h:
(WebCore):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 17 Feb 2012 23:57:08 +0000 (23:57 +0000)]
Move textDirectionForSelection from Editor to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=78868
Reviewed by Enrica Casucci.
Move textDirectionForSelection from Editor to EditingStyle to centralize the editing code's
dependency on CSSStyleDeclaration.
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore):
* editing/EditingStyle.h:
(EditingStyle):
* editing/Editor.cpp:
(WebCore):
* editing/Editor.h:
(Editor):
* editing/EditorCommand.cpp:
(WebCore::stateTextWritingDirection):
* editing/ReplaceSelectionCommand.cpp:
* editing/markup.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Feb 2012 23:33:05 +0000 (23:33 +0000)]
MathML internals - embellished operators, getBase() accessor functions
https://bugs.webkit.org/show_bug.cgi?id=78617
Patch by David Barton <dbarton@mathscribe.com> on 2012-02-17
Reviewed by Eric Seidel.
Define functions that return an unembellished "base", by omitting
subscripts/superscripts, underscripts/overscripts, or denominators. This is needed in
subsequent patches both for correct operator stretching and simple code factoring.
No new tests.
* rendering/mathml/RenderMathMLBlock.h:
(WebCore):
(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::unembellishedOperator):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::unembellishedOperator):
(WebCore):
* rendering/mathml/RenderMathMLFraction.h:
(RenderMathMLFraction):
* rendering/mathml/RenderMathMLOperator.h:
(WebCore::RenderMathMLOperator::unembellishedOperator):
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::base):
(WebCore):
(WebCore::RenderMathMLSubSup::unembellishedOperator):
(WebCore::RenderMathMLSubSup::stretchToHeight):
- renamed a variable for clarity, especially in later patches
(WebCore::RenderMathMLSubSup::layout):
- renamed a variable for clarity, especially in later patches
* rendering/mathml/RenderMathMLSubSup.h:
(RenderMathMLSubSup):
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::base):
(WebCore):
(WebCore::RenderMathMLUnderOver::unembellishedOperator):
(WebCore::RenderMathMLUnderOver::stretchToHeight):
* rendering/mathml/RenderMathMLUnderOver.h:
(RenderMathMLUnderOver):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Fri, 17 Feb 2012 23:28:18 +0000 (23:28 +0000)]
[Qt][WK2] Allow opaque tiles
https://bugs.webkit.org/show_bug.cgi?id=78809
Source/WebCore:
Replace the isOpaque boolean in BitmapTexture to a SupportsAlpha flag.
Use reset/didReset instead of a virtual function that has to call the superclass.
Make sure that all calls to BitmapTexture::reset() pass the correct SupportsAlpha flag,
based on the source image.
Since we now disable blending for opaque textures, we also have to make sure that we treat
the depth buffer correctly and bring it back to its previous state.
Reviewed by Kenneth Rohde Christiansen.
No behavior changes.
* platform/graphics/opengl/TextureMapperGL.cpp:
(TextureMapperGLData):
(WebCore::TextureMapperGLData::initStencil):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(BitmapTextureGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::beginClip):
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::BitmapTexture):
(WebCore::BitmapTexture::flags):
(WebCore::BitmapTexture::didReset):
(WebCore::BitmapTexture::reset):
(BitmapTexture):
* platform/graphics/texmap/TextureMapperBackingStore.cpp:
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
* platform/graphics/texmap/TextureMapperBackingStore.h:
(TextureMapperTiledBackingStore):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::didReset):
(WebCore):
* platform/graphics/texmap/TextureMapperImageBuffer.h:
(BitmapTextureImageBuffer):
Source/WebKit2:
Apply the SupportsAlpha flag only when the buffers actually have alpha.
Reviewed by Kenneth Rohde Christiansen.
* Shared/ShareableBitmap.h:
(ShareableBitmap):
* Shared/qt/ShareableBitmapQt.cpp:
* UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStoreTile::swapBuffers):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 17 Feb 2012 23:16:38 +0000 (23:16 +0000)]
Crash in SVGAnimateElement due to changed target
https://bugs.webkit.org/show_bug.cgi?id=75096
Patch by Stephen Chenney <schenney@chromium.org> on 2012-02-17
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The SVGAnimateElement object creates various internal objects
depending on the type of property being animated, which depends on the
target. These objects were not being recreated when the target
changed, and crashes ensued. Now the SVGSMILElement provides a virtual
method that is called when the target changes, and SVGAnimateElement
updates its objects as necessary. We also deactivate the animation
when the target changes, forcing recomputation of other derived
objects.
This change also removes various unnecessary calls to semi-expensive
methods.
Not only does this change fix the new test, it also fixes potential
crashes in other tests that apparently never manifested before (but
manifest when this new test is included in DRT).
Test: svg/animations/svglength-animation-retarget-crash.html
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::hasValidAttributeType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::calculateDistance):
(WebCore):
(WebCore::SVGAnimateElement::targetElementDidChange):
* svg/SVGAnimateElement.h:
(SVGAnimateElement):
* svg/SVGAnimatedTypeAnimator.h:
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::type):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::targetElement):
(WebCore::SVGSMILElement::resetTargetElement):
(WebCore):
* svg/animation/SVGSMILElement.h:
(SVGSMILElement):
(WebCore::SVGSMILElement::targetElementDidChange):
LayoutTests:
This test verifies that the target element information is correctly
updated when the target changes. Note that the clone is required, as
it causes the results of one animation to be pushed to a different
animation.
* svg/animations/svglength-animation-retarget-crash-expected.txt: Added.
* svg/animations/svglength-animation-retarget-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 17 Feb 2012 23:13:29 +0000 (23:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=78934
Add the -webkit-line-align property to support the alignment of lines in the inline direction
to the line grid.
Reviewed by Dan Bernstein.
Source/WebCore:
Added fast/line-grid/line-align-parsing.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator LineAlign):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
LayoutTests:
* fast/line-grid/line-align-parsing-expected.txt: Added.
* fast/line-grid/line-align-parsing.html: Added.
* fast/line-grid/script-tests/line-align-parsing.js: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc