zihao.jiang [Sun, 28 Jun 2015 17:39:09 +0000 (01:39 +0800)]
server/shadow: Fix incorrect handle of makecert_context_process.
Also fix another typo for makecert_context_set_output_file_name
Norbert Federa [Fri, 26 Jun 2015 13:30:00 +0000 (15:30 +0200)]
Merge pull request #2724 from bmiklautz/leak_fix
Fix leaks in certificate and identity handling
Marc-André Moreau [Fri, 26 Jun 2015 13:24:08 +0000 (09:24 -0400)]
Merge pull request #2737 from nfedera/nf-fix-gdi-return-value-weirdness
libfreerdp/gdi: fixed gdi return value madness
Bernhard Miklautz [Fri, 26 Jun 2015 13:12:33 +0000 (15:12 +0200)]
nla: clear identity memory before releasing
Norbert Federa [Fri, 26 Jun 2015 13:01:08 +0000 (15:01 +0200)]
Merge pull request #2727 from akallabeth/leak_fixes_reformat
Fixed leaks, NULL dereferences and broken init.
Norbert Federa [Fri, 26 Jun 2015 12:32:38 +0000 (14:32 +0200)]
libfreerdp/gdi: fixed gdi return value madness
Mostly booleanization to comply with the MS API
Marc-André Moreau [Fri, 26 Jun 2015 12:27:22 +0000 (08:27 -0400)]
Merge pull request #2719 from bmiklautz/pull/2481
OSS, tsmf, usb and BSD fixes and improvements
Bernhard Miklautz [Fri, 26 Jun 2015 12:20:37 +0000 (14:20 +0200)]
Merge pull request #2736 from akallabeth/windows_client_fix
Fixed windows client pre_connect return.
Norbert Federa [Fri, 26 Jun 2015 11:15:56 +0000 (13:15 +0200)]
Merge pull request #2734 from giox069/master
Fixes for software GDI issues #2732 and #2137
Armin Novak [Fri, 26 Jun 2015 11:13:32 +0000 (13:13 +0200)]
Fixed windows client pre_connect return.
Bernhard Miklautz [Fri, 26 Jun 2015 10:49:42 +0000 (12:49 +0200)]
Merge pull request #2735 from akallabeth/clipboard_temp_file_name_conversion_fix
[Clipboard] Fixed out of bound array access.
Hardening [Fri, 26 Jun 2015 09:15:09 +0000 (11:15 +0200)]
Merge pull request #2729 from akallabeth/win_reg_key_by_vendor_product_define
Replaced hard coded registry keys with cmake defines.
Armin Novak [Fri, 26 Jun 2015 07:50:21 +0000 (09:50 +0200)]
Fixed out of bound array access.
Giovanni Panozzo [Thu, 25 Jun 2015 14:54:08 +0000 (16:54 +0200)]
Returing OK when there is nothing to draw after clipping, fixes #2732
Giovanni Panozzo [Thu, 25 Jun 2015 14:49:29 +0000 (16:49 +0200)]
Signed glyph offset calculation, fixes #2137
Norbert Federa [Thu, 25 Jun 2015 10:39:12 +0000 (12:39 +0200)]
Merge pull request #2731 from akallabeth/mutex_cleanup_fix
Fixed mutex trylock in MutexCloseHandle.
Armin Novak [Thu, 25 Jun 2015 10:24:28 +0000 (12:24 +0200)]
Fixed mutex trylock in MutexCloseHandle.
Norbert Federa [Thu, 25 Jun 2015 10:11:50 +0000 (12:11 +0200)]
Merge pull request #2728 from bmiklautz/unsigned
Fix possible endless loops on cleanup.
Bernhard Miklautz [Thu, 25 Jun 2015 09:53:03 +0000 (11:53 +0200)]
clipboard: fix of by one error on cleanup
Bernhard Miklautz [Thu, 25 Jun 2015 08:33:54 +0000 (10:33 +0200)]
Integrate pull request feedback
Use while instead of for with additional variable where appropriate.
Armin Novak [Wed, 24 Jun 2015 12:59:59 +0000 (14:59 +0200)]
Fixed cleanup of resources, only in error case now.
Armin Novak [Wed, 24 Jun 2015 09:12:59 +0000 (11:12 +0200)]
Replaced registry keys with cmake defines.
Bernhard Miklautz [Wed, 24 Jun 2015 10:26:13 +0000 (12:26 +0200)]
Fix possible endless loops on cleanup.
Some cleanup code possibly create endless loops because an unsigned
type was used as run variable but the check was >= 0 in the for loop.
Armin Novak [Wed, 24 Jun 2015 10:12:40 +0000 (12:12 +0200)]
Fixed cleanup of MachineAddresses and MachinePorts.
Armin Novak [Wed, 24 Jun 2015 08:08:04 +0000 (10:08 +0200)]
Fixed loop condition.
Armin Novak [Wed, 24 Jun 2015 08:02:42 +0000 (10:02 +0200)]
Fixed memory leak.
Armin Novak [Wed, 24 Jun 2015 08:02:30 +0000 (10:02 +0200)]
Fixed sizeof misuse.
Armin Novak [Wed, 24 Jun 2015 07:45:40 +0000 (09:45 +0200)]
Fixed a resource leak.
Armin Novak [Wed, 24 Jun 2015 07:33:20 +0000 (09:33 +0200)]
Fixed a resource leak.
Armin Novak [Wed, 24 Jun 2015 07:29:52 +0000 (09:29 +0200)]
Fixed a resource leak.
Armin Novak [Wed, 24 Jun 2015 07:29:13 +0000 (09:29 +0200)]
Fixed a resource leak.
Martin Fleisz [Wed, 24 Jun 2015 07:22:55 +0000 (09:22 +0200)]
Merge pull request #2717 from realjiangms/shadow_encoder_fps
server/shadow: shadow encoder related enhancement/fix.
Armin Novak [Tue, 23 Jun 2015 19:29:21 +0000 (21:29 +0200)]
Fixed leaks, NULL dereferences and broken init.
Hardening [Tue, 23 Jun 2015 17:32:26 +0000 (19:32 +0200)]
Merge pull request #2725 from akallabeth/warning_fixes_more_more_more
Warning fixes more more more
Armin Novak [Tue, 23 Jun 2015 14:04:15 +0000 (16:04 +0200)]
Removed unused variable and incorrect comment.
Armin Novak [Tue, 23 Jun 2015 14:02:53 +0000 (16:02 +0200)]
ifdef variables used with specific build options.
Bernhard Miklautz [Tue, 23 Jun 2015 13:40:37 +0000 (15:40 +0200)]
Fix leaks in certificate and identity handling
Bernhard Miklautz [Tue, 23 Jun 2015 12:30:23 +0000 (14:30 +0200)]
Merge pull request #2721 from akallabeth/warning_fixes_some_more
Some warnings fixed
Armin Novak [Tue, 23 Jun 2015 10:25:07 +0000 (12:25 +0200)]
Fixed memory leak.
Armin Novak [Tue, 23 Jun 2015 10:17:37 +0000 (12:17 +0200)]
Added missing argument checks.
Armin Novak [Tue, 23 Jun 2015 10:12:59 +0000 (12:12 +0200)]
Fixed malloc with 0 size.
Armin Novak [Tue, 23 Jun 2015 10:12:16 +0000 (12:12 +0200)]
Fixed uninitialized value.
Armin Novak [Tue, 23 Jun 2015 10:09:42 +0000 (12:09 +0200)]
Fixed uninitialized value.
Armin Novak [Tue, 23 Jun 2015 10:08:47 +0000 (12:08 +0200)]
Fixed grabage return value.
Armin Novak [Tue, 23 Jun 2015 10:07:38 +0000 (12:07 +0200)]
Fixed NULL pointer dereference.
Bernhard Miklautz [Tue, 23 Jun 2015 09:40:04 +0000 (11:40 +0200)]
tsmf_oss: fix compiler warning
Norbert Federa [Tue, 23 Jun 2015 09:18:19 +0000 (11:18 +0200)]
Merge pull request #2708 from bmiklautz/dupdup
alloc and strdup checks
Bernhard Miklautz [Tue, 23 Jun 2015 09:08:44 +0000 (11:08 +0200)]
core: use error instead of debug
When the function would return with an error print an error message
instead of a debug message
Bernhard Miklautz [Tue, 23 Jun 2015 08:14:11 +0000 (10:14 +0200)]
nla and cmdline: integrated feedback
* fix possible problems with 0 size lengths
* add return value checks
zihao.jiang [Thu, 9 Apr 2015 18:33:54 +0000 (02:33 +0800)]
server/shadow: shadow encoder related enhancement/fix.
1. Export fps related API so that subsystem implementation no longer need to know about details in encoder structure.
2. Discard frameList dictionary.
The 'value' in this dictionary is never used and not properly free'ed when client is disconnected.
The dictionary was used to calculate 'inflight' frame count. Once an ACK is received from client, an item in the dictionary is removed.
We then calculate 'inflight' frame by the count of the items in the dictionary.
However, some rdp clients (win7 mstsc) skips frame ACK if it is inactive, ACK of some frame would actually never arrive.
We actually don't need the dictionary. We only need to record the latest acknowledged frame id, and the difference between last sent frame id is the inflight frame count.
3. Minor fix in default fps calculation. encoder->frameAck is wrongly used as integer while it's actually bool flag.
Bernhard Miklautz [Mon, 22 Jun 2015 17:45:56 +0000 (19:45 +0200)]
oss: fix formating
Bernhard Miklautz [Mon, 22 Jun 2015 17:31:25 +0000 (19:31 +0200)]
windows: fix compilation and warnings
Bernhard Miklautz [Mon, 22 Jun 2015 16:52:13 +0000 (18:52 +0200)]
misc: integrate pull request feedback
Bernhard Miklautz [Mon, 22 Jun 2015 12:26:11 +0000 (14:26 +0200)]
client/locale: properly check popen return value
popen returns NULL if an error occurs and not < 0.
Bernhard Miklautz [Mon, 22 Jun 2015 10:09:18 +0000 (12:09 +0200)]
client/android: reset debug level to default
* WLOG debug level was hard coded to DEBUG which generates a lot of
noise
* remove indecent and unneeded debug message
Bernhard Miklautz [Fri, 19 Jun 2015 08:38:37 +0000 (10:38 +0200)]
sspi/ntlm: integrate pull request comments
Bernhard Miklautz [Thu, 18 Jun 2015 11:00:10 +0000 (13:00 +0200)]
cmd line: add missing checks
* strdup
* some allocs
Bernhard Miklautz [Wed, 17 Jun 2015 10:23:14 +0000 (12:23 +0200)]
cache: fix regression
Fix a regression in cache_new introduced in commit
b4f147e242ea396ef92082d29866e5ab7d041b4e
Bernhard Miklautz [Tue, 16 Jun 2015 15:47:33 +0000 (17:47 +0200)]
codec/planar: regression - fix conflicting types
Update planar.h to fix the conflicting types of
freerdp_bitmap_planar_delta_encode_planes.
David FORT [Tue, 16 Jun 2015 13:42:07 +0000 (15:42 +0200)]
Fixes for malloc / calloc + other fixes
This patch contains:
* checks for malloc return value + treat callers;
* modified malloc() + ZeroMemory() to calloc();
* misc fixes of micro errors seen during the code audit:
** some invalid checks in gcc.c, also there were some possible
integer overflow. This is interesting because at the end the data are parsed
and freed directly, so it's a vulnerability in some kind of dead code (at least
useless);
** fixed usage of GetComputerNameExA with just one call, when 2 were used
in misc places. According to MSDN GetComputerNameA() is supposed to return
an error when called with NULL;
** there were a bug in the command line parsing of shadow;
** in freerdp_dynamic_channel_collection_add() the size of array was multiplied
by 4 instead of 2 on resize
David FORT [Sat, 13 Jun 2015 22:55:09 +0000 (00:55 +0200)]
A malloc() pass on WinPR
This patch treats remaining non-checked mallocs. And changes to calloc in places
where it makes sense
Bernhard Miklautz [Tue, 16 Jun 2015 14:03:34 +0000 (16:03 +0200)]
client/android: misc updates and fixes
* increase minimum required SDK to 14
* change functions from void to BOOL where required to have proper
return values
* update the JAVA classes and JNI accordingly
* add return value checks for *alloc and strdup
Bernhard Miklautz [Wed, 10 Jun 2015 16:57:05 +0000 (18:57 +0200)]
android: fix misc compiler warnings
with gcc version arm-linux-androideabi-gcc (GCC) 4.8
Bernhard Miklautz [Wed, 3 Jun 2015 14:44:07 +0000 (16:44 +0200)]
winpr/wtsapi: disable tests that block on windows
Bernhard Miklautz [Wed, 3 Jun 2015 13:53:44 +0000 (15:53 +0200)]
winpr/thread: fix test compilation on windows
Use DWORD instead of QWORD.
Bernhard Miklautz [Tue, 2 Jun 2015 13:04:34 +0000 (15:04 +0200)]
Fix compiler warnings:
gcc 4.7.2
client/X11/xf_keyboard.c: In function ‘xf_keyboard_action_script_init’:
client/X11/xf_keyboard.c:48:6: warning: unused variable ‘exitCode’
[-Wunused-variable]
gcc 4.9
client/X11/xf_client.c: In function ‘xf_client_thread’:
client/X11/xf_client.c:1537:3: warning: ‘inputThread’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
Bernhard Miklautz [Tue, 9 Jun 2015 13:22:50 +0000 (15:22 +0200)]
client/ios: fix unchecked strdups
Bernhard Miklautz [Wed, 17 Jun 2015 20:08:02 +0000 (22:08 +0200)]
Fix unchecked strdups
* add missing checks
* adapt function return values where necessary
* add initial test for settings
Marc-André Moreau [Mon, 22 Jun 2015 14:24:26 +0000 (10:24 -0400)]
Merge pull request #2686 from bmiklautz/ios/openssl
ios: update openssl build script
Marc-André Moreau [Mon, 22 Jun 2015 14:19:22 +0000 (10:19 -0400)]
Merge pull request #2705 from akallabeth/sspi_fix_v2
Sspi fix v2 - Fixes static build
Marc-André Moreau [Mon, 22 Jun 2015 13:52:53 +0000 (09:52 -0400)]
Merge pull request #2697 from realjiangms/shadow_audio
Shadow server: fix channel disposal and add audio support. fix message mechanism in client
Marc-André Moreau [Mon, 22 Jun 2015 13:39:17 +0000 (09:39 -0400)]
Merge pull request #2698 from realjiangms/shadow_stand_alone
server/shadow: Decouple shadow_subsystem and subsystem implementation detail.
Marc-André Moreau [Mon, 22 Jun 2015 13:38:46 +0000 (09:38 -0400)]
Merge pull request #2699 from realjiangms/shadow_connect_disconnect
server/shadow: add connect/disconnect anchor in subsystem callback
Marc-André Moreau [Mon, 22 Jun 2015 13:31:38 +0000 (09:31 -0400)]
Merge pull request #2701 from akallabeth/upn_syntax_support
Allowing UPN syntax for user argument.
Marc-André Moreau [Mon, 22 Jun 2015 13:31:15 +0000 (09:31 -0400)]
Merge pull request #2684 from Skool/master
Add bépo layout
Marc-André Moreau [Mon, 22 Jun 2015 13:15:37 +0000 (09:15 -0400)]
Merge pull request #2636 from xhaakon/master
Fix crashes in shadow server
Marc-André Moreau [Mon, 22 Jun 2015 12:53:36 +0000 (08:53 -0400)]
Merge pull request #2713 from bmiklautz/divbyzero
core/metrics: prevent division by zero
Marc-André Moreau [Mon, 22 Jun 2015 12:53:05 +0000 (08:53 -0400)]
Merge pull request #2702 from akallabeth/nla_null_identity_support
NLA Use current users credentials if none provided.
Bernhard Miklautz [Mon, 22 Jun 2015 10:26:31 +0000 (12:26 +0200)]
Merge pull request #2711 from nfedera/nf-fix-rdprecvmessagechannelpdu
core: message channel pdu broken with rdp security
Bernhard Miklautz [Fri, 19 Jun 2015 15:21:16 +0000 (17:21 +0200)]
core/metrics: prevent division by zero
Norbert Federa [Fri, 19 Jun 2015 12:47:00 +0000 (14:47 +0200)]
core: message channel pdu broken with rdp security
rdp_recv_message_channel_pdu always read the rdp security header
even if it was already previously read (which is the case if rdp
security is active)
This caused malfunctions and disconnects when heartbeat or bandwidth
autodetect packets were sent/received in rdp security mode.
Credit goes to @MartinHaimberger for identifying the broken code
part.
Armin Novak [Thu, 18 Jun 2015 14:07:25 +0000 (16:07 +0200)]
Setting hostname as default domain now.
Armin Novak [Thu, 18 Jun 2015 14:07:09 +0000 (16:07 +0200)]
Fixed typo and invalid domain name.
Armin Novak [Thu, 18 Jun 2015 11:01:28 +0000 (13:01 +0200)]
Fixed domain setting for windows client.
Armin Novak [Thu, 18 Jun 2015 10:24:22 +0000 (12:24 +0200)]
UPN syntax fix: domain must be empty, not NULL.
Armin Novak [Thu, 18 Jun 2015 10:01:17 +0000 (12:01 +0200)]
Added user setting if no domain provided.
Armin Novak [Thu, 18 Jun 2015 09:49:16 +0000 (11:49 +0200)]
Fixed variable parsed.
Armin Novak [Thu, 18 Jun 2015 09:35:22 +0000 (11:35 +0200)]
Using last @ for domain split.
Command line parser splits username after
parsing all options.
Hardening [Thu, 18 Jun 2015 07:28:31 +0000 (09:28 +0200)]
Merge pull request #2706 from nfedera/nf-fix-reset-event
winpr/synch: fix ResetEvent & improve CTest
Vic Lee [Thu, 18 Jun 2015 02:43:47 +0000 (02:43 +0000)]
Merge pull request #2675 from akallabeth/path_make_path
Added PathMakePath function.
Norbert Federa [Wed, 17 Jun 2015 12:13:28 +0000 (14:13 +0200)]
winpr/synch: fix ResetEvent & improve CTest
Unless there is an invalid parameter or internal error, ResetEvent
must return TRUE, even if the object is in nonsignaled state.
Also fixed and improved the CTest TestSynchEvent to test for the
expected/correct SetEvent and ResetEvent return values.
Armin Novak [Wed, 17 Jun 2015 11:24:11 +0000 (13:24 +0200)]
Removed duplicate function tables, respecting WITH_NATIVE_SSPI
Armin Novak [Wed, 17 Jun 2015 11:23:44 +0000 (13:23 +0200)]
Using InitSecurityInterfaceEx(0) now.
Armin Novak [Wed, 17 Jun 2015 11:23:21 +0000 (13:23 +0200)]
Fixed cmake warning.
Vic Lee [Tue, 16 Jun 2015 15:02:57 +0000 (15:02 +0000)]
Merge pull request #2703 from akallabeth/unified_sspi
Let SSPI module choose which implementation to use.
zihao.jiang [Mon, 15 Jun 2015 11:37:26 +0000 (19:37 +0800)]
server/shadow: integrate comment from @hardening
Return directly at subsystem->ClientConnect
Also change to argument to accept shadow_client instead of freerdp_peer
zihao.jiang [Mon, 15 Jun 2015 15:54:30 +0000 (23:54 +0800)]
server/shadow: Integrate comment from @hardening: use switch to handle different message id.
Armin Novak [Fri, 12 Jun 2015 08:32:13 +0000 (10:32 +0200)]
Let SSPI module choose which implementation to use.
Armin Novak [Mon, 15 Jun 2015 13:03:13 +0000 (15:03 +0200)]
NLA identity now a pointer, allowing NULL.
When NLA identity is NULL, the current user context
is used on windows.
Armin Novak [Mon, 15 Jun 2015 07:47:16 +0000 (09:47 +0200)]
Allowing UPN syntax for user.