Tom Hacohen [Mon, 20 Apr 2015 14:00:40 +0000 (15:00 +0100)]
Evas 3d mesh: remove non-implemented functions from "implements".
They are not implemented, so they should not be marked as implemented.
Eo already properly handles functions that are not implemented, this is
completely unnecessary.
Tom Hacohen [Mon, 20 Apr 2015 14:00:13 +0000 (15:00 +0100)]
Ector: remove use of #warning directive as TODO.
There's already a fixme in code, and an error output at runtime.
As discussed on the ML, using #warning this way is bad.
Carsten Haitzler (Rasterman) [Mon, 20 Apr 2015 12:46:23 +0000 (21:46 +0900)]
eio - fix crashes due to stale eio files in tracking list
so eio_eet didnt free fiels the same as the rest of eio. it thought it
was special. it thought it could just go free() it's objects (even
though they inherit the core Eio_File object type in their structs).
everyone else ended up calling eio_file_free() EXCEPT eio_eet. so the
eio_(long)_file_set() funcs ewnded up adding this eio file to the
tracking list via eio_file_register() but never unregistered because
they really liked to just do their own thing anyway...
BAD CEDRIC! SPANKING TIME
http://33.media.tumblr.com/
3422c76c33c3b9b045f623ff73e0bf8d/tumblr_mhvu61N9br1rbavngo1_500.gi
so this unifies all allocation to now use a single allocator (that
also ensures all eio async io objects are zero'd out), and a SINGLE
free path, and then it all works. no more valgrind complaints on e
shutdown/restart whilst eio "things" were used before or ... maybe
still around.
this should fix T2129
so try again "git master" after this commit.
@fix
Stefan Schmidt [Mon, 20 Apr 2015 10:17:35 +0000 (12:17 +0200)]
release: Update NEWS and bump version for 1.14.0-beta2 release
Carsten Haitzler (Rasterman) [Mon, 20 Apr 2015 03:14:10 +0000 (12:14 +0900)]
emotion gst1 module - remove printf
this debugging printf seems to have been left around - remove it so we
don't get unexpected noise in gst playback
Carsten Haitzler (Rasterman) [Mon, 20 Apr 2015 03:12:27 +0000 (12:12 +0900)]
emotion - gst1 module - handle long standing bad map/unmap of gst buf
this fixes a pending XXX where we didnt keep the buffer mapped as long
as the evas image object pointed to the video pixel data. this fixes
this along with less over-zealous refinf to make things more obvious
(now last_buffer actualyl really matters and if it was mapped and
refed).
@fix
Jean-Philippe Andre [Mon, 20 Apr 2015 08:34:15 +0000 (17:34 +0900)]
Evas: Fix memory leak
Fixes CID 1293000
Jean-Philippe Andre [Mon, 20 Apr 2015 06:15:34 +0000 (15:15 +0900)]
Evas tests: Add callback_del order test
Jean-Philippe Andre [Mon, 20 Apr 2015 07:31:36 +0000 (16:31 +0900)]
Evas: Remove callbacks in reverse order with callback_del
This function is deprecated, because del_full should be used instead.
Still, the documentation specifies in which order the callbacks should
be deleted.
Fixes T2077 (not really fixes according to the comment but fixes
according to the doc).
Jean-Philippe Andre [Mon, 20 Apr 2015 07:02:46 +0000 (16:02 +0900)]
Evas tests: Add debug logs telling people to ignore ERR
Some of the ERR messages are expected and it's part of the
test suite to test for invalid cases (parsing stuff).
Jean-Philippe Andre [Mon, 20 Apr 2015 06:15:10 +0000 (15:15 +0900)]
Eina tests: fix warning about pointer signedness
Jean-Philippe Andre [Mon, 20 Apr 2015 06:14:47 +0000 (15:14 +0900)]
Eina tests: suppress warnings over deprecated functions
Jean-Philippe Andre [Mon, 20 Apr 2015 02:44:27 +0000 (11:44 +0900)]
Evas GL_X11: Fix memory leak
Stefan Schmidt [Mon, 20 Apr 2015 07:12:34 +0000 (09:12 +0200)]
bindings/eo: Only install Eo.hh once to avoid failing double install
Eo.hh is listed in both dist_installed_eocxxmainheaders_DATA and
dist_installed_eocxxheaders_DATA this leads to a situation where they file
should be installed but already exists and thus the installation fails.
00:32:27.919 /usr/bin/install: cannot create regular file '/srv/build/workspace/changely_efl_configure_xcb/destdir/include/eo-cxx-1/Eo.hh': File exists
00:32:27.923 Makefile:32620: recipe for target 'install-dist_installed_eocxxmainheadersDATA' failed
00:32:27.923 make[4]: *** [install-dist_installed_eocxxmainheadersDATA] Error
Given that it is the only item in dist_installed_eocxxmainheaders_DATA I suspect
it was but into the other rule by accident.
Vincent Torri [Sun, 19 Apr 2015 06:28:56 +0000 (08:28 +0200)]
evil: remove unused files (evil_p*) and uneeded evil_uuid.c file (managed by mingw-w64)
Just keeping up with latest mingw-w64.
Cedric BAIL [Sun, 19 Apr 2015 07:50:29 +0000 (09:50 +0200)]
eio: forgot to test when xattr tests are disable.
Cedric BAIL [Sat, 18 Apr 2015 16:48:20 +0000 (18:48 +0200)]
eio: this should not be visible outside of this file.
vivek [Sat, 18 Apr 2015 15:40:59 +0000 (17:40 +0200)]
eio: add test cases for eio xattr module.
Summary:
Added test cases for eio_file_xattr, eio_file_xattr_set and eio_file_xattr_get functions
Signed-off-by: vivek <vivek.ellur@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2374
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Sat, 18 Apr 2015 15:28:46 +0000 (17:28 +0200)]
eio: reorder include to fix build on Windows.
Vincent Torri [Sat, 18 Apr 2015 15:28:16 +0000 (17:28 +0200)]
eio: headers are part of the source code and should be handle like they are.
Adrien Nader [Sat, 18 Apr 2015 15:24:53 +0000 (17:24 +0200)]
ecore_win32: don't fail if OleInitialize() had been called before.
kabeer khan [Fri, 17 Apr 2015 10:06:43 +0000 (12:06 +0200)]
ecore_file: less confusing documentation of ecore_file_download API
Summary: Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2373
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
kabeer khan [Fri, 17 Apr 2015 10:05:18 +0000 (12:05 +0200)]
ecore_file: fix crashing test of ecore_file
Summary: Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2372
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Fri, 17 Apr 2015 09:54:11 +0000 (11:54 +0200)]
evas: more fix for include order in an attempt to fix Windows build.
Subhransu Mohanty [Fri, 17 Apr 2015 02:24:47 +0000 (11:24 +0900)]
evas: update Evas_Object_VG examples to use eina_matrix api correctly after change.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subhransu Mohanty [Fri, 17 Apr 2015 02:22:48 +0000 (11:22 +0900)]
evas: update matrix calulation as the behaviour of eina_matrix api changed.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Subhransu Mohanty [Fri, 17 Apr 2015 02:19:59 +0000 (11:19 +0900)]
eina: updated matrix_translate, matrix_scale and matrix_rotate implementation to do compose of the matrix in not identity matrix.
This is a late change that has been discussing on the ML as we don't want to release an API, we can't make faster.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tom Hacohen [Fri, 17 Apr 2015 08:26:48 +0000 (09:26 +0100)]
Revert "edje: refactor styles_del() logic like styles_add()"
We are in a feature freeze. No room for refactoring/new features, only
surgical (or if you must, non-surgical) fixes!
This reverts commit
fa0384ed2c0f784d26f0bfbd4ff40940921768c4.
Sohyun Kim [Fri, 17 Apr 2015 08:22:31 +0000 (17:22 +0900)]
edje: refactor styles_del() logic like styles_add()
Jaeun Choi [Fri, 17 Apr 2015 08:09:51 +0000 (17:09 +0900)]
evas: restore the value of "do_region" in jpeg loader as EINA_TRUE
this was an unwanted change from
1ab8cc75c4b85d3421ebfd34d04f2f4c01e99468
@fix
Sohyun Kim [Fri, 17 Apr 2015 07:10:20 +0000 (16:10 +0900)]
Evas textblock: remove freed item from the line list
@fix
Jean-Philippe Andre [Fri, 17 Apr 2015 00:24:46 +0000 (09:24 +0900)]
Evas masking: Skip GL fast path for border images
Right now the engines don't support mask tiles so we can't
just scale up an image on-the-fly when doing a masking operation.
Skip fast path and force render of border images into their own surface.
Jean-Philippe Andre [Thu, 16 Apr 2015 08:36:32 +0000 (17:36 +0900)]
Evas render: Fix debug logs
Those are only printed out if REND_DBG is set to 1 in evas_private.h
--> Non functional change.
kabeer khan [Thu, 16 Apr 2015 16:47:44 +0000 (18:47 +0200)]
eio: add new tests for eio.
Summary: Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2360
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
se.osadchy [Thu, 16 Apr 2015 16:45:25 +0000 (18:45 +0200)]
evas: fix bug in Evas_3D examples.
Summary: Fix evas-3d-shooter and evas-3d-parallax-occlusion.
Reviewers: cedric, raster, Hermet
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2365
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Thu, 16 Apr 2015 16:41:42 +0000 (18:41 +0200)]
epp: fix annotate.
Yomi [Thu, 16 Apr 2015 16:29:10 +0000 (18:29 +0200)]
edje: fix misspelling of annotate.
Summary: Anotate to Annotate
Test Plan: test it to make sure I didn't break it...
Reviewers: raster, cedric
Differential Revision: https://phab.enlightenment.org/D2356
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Oleksandr Shcherbina [Thu, 16 Apr 2015 16:28:18 +0000 (18:28 +0200)]
evas: fix possible segfault in evas_3d_node_member_add/del.
Summary: @fix
Reviewers: Hermet, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2367
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Chris Michael [Thu, 16 Apr 2015 16:47:29 +0000 (12:47 -0400)]
ecore-drm: Don't fetch output geometry on every mouse movement
Summary: This is a better way to allow mouse movement across multiple
outputs as this does not require us to fetch output geometry on Every
mouse movement (as before).
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 16 Apr 2015 16:35:36 +0000 (12:35 -0400)]
ecore-drm: Fix mouse movement across multiple outputs
Summary: When running E-Wl with multiple outputs, we could not
previously move the mouse pointer across to the second output. This
commit fixes that issue.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 16 Apr 2015 14:51:56 +0000 (10:51 -0400)]
ecore-drm: Fix hotplugging of outputs
Summary: In order to process hotplugging of outputs, we need to send
the 'dev' structure as data to the callback so that we can update
outputs. This fixes hotplugging of outputs when running E
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 16 Apr 2015 14:23:55 +0000 (10:23 -0400)]
evas-drm: Mark the Ecore_Drm_Fb as complete when we get the page flip event.
Summary: This fixes Ticket T2289 where the mouse pointer was leaving a
trail while moving. This was caused due to not waiting for the page
flip to complete
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 16 Apr 2015 14:22:44 +0000 (10:22 -0400)]
ecore-drm: Add pending_flip field to Ecore_Drm_Fb
Summary: This adds a pending_flip field to Ecore_Drm_Fb structure so
that when we schedule a pageflip event we can wait until the flip is
complete before trying to reuse the buffer again.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Thu, 16 Apr 2015 13:56:59 +0000 (09:56 -0400)]
evas-drm: Handle render mode for 4 buffers
Summary: If we are using 4 buffers, we should be returning
MODE_QUADRUPLE for render_mode_get function
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Daniel Kolesa [Thu, 16 Apr 2015 13:23:04 +0000 (14:23 +0100)]
mailmap: update q66
Daniel Kolesa [Thu, 16 Apr 2015 10:03:21 +0000 (11:03 +0100)]
eio: reorder tests linkage to unbreak debian-based systems
@fix
Cedric BAIL [Wed, 15 Apr 2015 15:44:51 +0000 (17:44 +0200)]
eina: remove warning from eina_str tests.
Srivardhan Hebbar [Wed, 15 Apr 2015 12:50:03 +0000 (14:50 +0200)]
ecore_con: add test cases for ecore_con_eet.
Summary:
Added test case for ecore_con_eet.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2347
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Srivardhan Hebbar [Wed, 15 Apr 2015 12:29:33 +0000 (14:29 +0200)]
ecore_con: add test cases related to cookies.
Summary:
Added test cases related to ecore_con_url cookies.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2298
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
kabeer khan [Wed, 15 Apr 2015 12:15:38 +0000 (14:15 +0200)]
ecore_file: improved Ecore_File_Download test.
Summary: Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2338
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
se.osadchy [Wed, 15 Apr 2015 10:16:48 +0000 (12:16 +0200)]
evas: fix compilation in the Evas 3D examples.
Summary: Fix compilation line.
Reviewers: Hermet, raster, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D2340
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Tom Hacohen [Wed, 15 Apr 2015 07:18:25 +0000 (08:18 +0100)]
Revert "eo: add eo_error_get"
As discussed on IRC and ML. We are in a feature freeze phase, and this
patch is not essential. Furthermore, this patch was never discussed.
This reverts commit
537c7fe9e3a72242c386b8851dd450fdc6312171.
Jaehwan Kim [Wed, 15 Apr 2015 04:52:01 +0000 (13:52 +0900)]
eo: add eo_error_get
This is pair of eo_error_set.
Jean-Philippe Andre [Wed, 15 Apr 2015 01:44:02 +0000 (10:44 +0900)]
Emile: Reduce ERR logs on invalid JPEG images
When reading the head of a file, we may get the error that it is
not a JPEG image (which is normal), so we should not print any ERR.
The JPEG header read function can indeed be called to test whether a
file can be opened by the JPEG loader or not (any file).
Note that JPEG files don't have reliable magic numbers, so we
don't check them, but rely on libjpeg instead.
Fixes T2290
Mike Blumenkrantz [Wed, 15 Apr 2015 01:09:27 +0000 (21:09 -0400)]
evas sw: fix compile warning
modules/evas/engines/software_generic/ector_surface.c: In function '_ector_cairo_software_surface_surface_set':
modules/evas/engines/software_generic/ector_surface.c:89:4: warning: implicit declaration of function 'evas_common_cpu_end_opt' [-Wimplicit-function-declaration]
evas_common_cpu_end_opt();
^
Mike Blumenkrantz [Tue, 14 Apr 2015 23:55:03 +0000 (19:55 -0400)]
eo_gdb.py: fix syntax error
I guess this has never ever worked. I hate everyone for making me look at python.
@fix
Cedric BAIL [Tue, 14 Apr 2015 20:27:40 +0000 (22:27 +0200)]
eio: correct header inclusion for Windows.
Cedric BAIL [Tue, 14 Apr 2015 19:39:55 +0000 (21:39 +0200)]
evas: split ector surface from gl generic backend in an attempt to fix windows build.
Cedric BAIL [Tue, 14 Apr 2015 19:26:17 +0000 (21:26 +0200)]
evas: split software backend use of ector surface in an attempt to fix windows build.
Stefan Schmidt [Tue, 14 Apr 2015 12:44:10 +0000 (14:44 +0200)]
tests/eeze: Disable libcheck timeout like we do for the rest of our suites
Recently I have seen that eeze_suite times out more often on jenkins when
being under load. Looking in this revealed that we have been using the default
4s timeout for eeze while almost all others suites had the timeout disabled
already. In eeze there should be no test that would really block and if I find
one I can simply add a specific timeout like we did for eina_barrier.
Jean-Philippe Andre [Tue, 14 Apr 2015 11:55:50 +0000 (20:55 +0900)]
Evas GL: Add some safety code
Set some pointers to NULL to avoid invalid accesses after free.
Move the similar condition for sfc after the make_current check.
Jean-Philippe Andre [Tue, 14 Apr 2015 11:41:56 +0000 (20:41 +0900)]
Evas GL: Disable direct rendering if there is a map
The engine itself (gl_generic) will detect whether the target
surface (canvas where to draw the gl stuff) is the window
backbuffer or not.
Jean-Philippe Andre [Tue, 14 Apr 2015 11:02:01 +0000 (20:02 +0900)]
Evas GL: Fallback to indirect rendering if mul_col != 0xFFFFFFFF
@fix
Felipe Magno de Almeida [Tue, 14 Apr 2015 12:10:56 +0000 (09:10 -0300)]
eio-cxx: Added Eio.hh to .gitignore file
Since Eio.hh is a generated file, added it to .gitignore file so it
doesn't pollute git statuses.
Felipe Magno de Almeida [Tue, 14 Apr 2015 12:09:17 +0000 (09:09 -0300)]
eolian-cxx: Fix dependency problem in makefile
Fixed lacking explicit dependency for C Eolian headers, causing random compilation errors in test for eolian-cxx.
Jean-Philippe Andre [Tue, 14 Apr 2015 08:27:06 +0000 (17:27 +0900)]
Evas GL generic: Fix log domain
The log domain EvasGL is used by evas_gl_common and initialized
only when an Evas GL surface is created.
Jean-Philippe Andre [Tue, 14 Apr 2015 07:20:00 +0000 (16:20 +0900)]
Evas render: Fix double-clipping issue with maps
Situation:
- Evas Object A has a clip C and a map M.
Problem:
- Clip C will be applied once inside the map surface S and
again when the surface S is drawn to the canvas.
Solution:
- Track whether the current object is the mapped object
or a child of the mapped object. In the first case,
discard the clipper when rendering to the map surface.
In the second case, the child's clipper is PROBABLY[*]
inside the map, so it should be applied when rendering the
map surface itself.
Note: This also applies to masks.
[*] This is clearly not the ultimate clipping fix.
Jean-Philippe Andre [Mon, 13 Apr 2015 12:49:45 +0000 (21:49 +0900)]
Evas GL common: Fix RGB+A textures
Since the shaders system rewrite, RGB+A (used for ETC1+Alpha encoding)
did not work anymore.
Jean-Philippe Andre [Mon, 13 Apr 2015 12:29:37 +0000 (21:29 +0900)]
Evas GL common: Fix texture preload with RGB+Alpha
Jean-Philippe Andre [Mon, 13 Apr 2015 12:07:21 +0000 (21:07 +0900)]
Evas GL masking: Skip fast path if colorspace is not supported
Masking in GL assumes only one texture to sample from. This means
RGB+Alpha and YUV types are not supported. While it would
make sense for RGB+Alpha, it doesn't make any sense for YUV (because
masks are alpha planes and YUV is opaque...)
Jean-Philippe Andre [Mon, 13 Apr 2015 11:54:23 +0000 (20:54 +0900)]
Emile image: Fix decoding of ETC1+Alpha images
This bug is probably a copy&paste issue when writing emile.
Jean-Philippe Andre [Mon, 13 Apr 2015 11:43:46 +0000 (20:43 +0900)]
Evas GL common: Fix masking of maps based on RGB+A textures
That's like a case that will never happen.
Apply a map on an image loaded from an ETC1_ALPHA image. Oh, and
also add a mask on top of that.
Carsten Haitzler (Rasterman) [Tue, 14 Apr 2015 04:52:12 +0000 (13:52 +0900)]
efreetd - cache - mark cd as const as it isnt needing a free on return
Felipe Magno de Almeida [Tue, 14 Apr 2015 03:46:19 +0000 (00:46 -0300)]
eina-cxx: Fix compilation error on clang
Clang implicitly deletes the default-constructor on range_ptrlist, which must be explicitly defined.
Felipe Magno de Almeida [Mon, 13 Apr 2015 18:31:59 +0000 (15:31 -0300)]
cxx: Made automake files depend on their C counterparts for compilation
Avoids redundancy and maintenance for non-C++ developers.
Vitor Sousa [Thu, 26 Mar 2015 14:48:09 +0000 (11:48 -0300)]
eolain_cxx: Fix C++ support for new Eolian features
Added optional constructor methods for C++ Eolian wrappers.
Changed the interface of wrappers' main constructors.
If there are optional constructor methods they should be passed as variadic
template argument at the end of the constructor.
To support variadic template arguments, the optional "parent" parameter is
now the first parameter and there is another constructor without the
"parent" parameter.
Checking for @optinal and @nullable attributes instead of @nonull.
Now @nonull is the default, and eina::optional is only used when @optional
or @nullable attribute is specified.
The names of constructor methods no longer have the class name prefixed.
Added unit tests for checking the binding of optional constructors.
Added new .eo file to be used in the test.
Changed the generated documentation of constructors.
Changed the efl::eo::inherit accordingly, to address these new features.
Now the constructor methods should be explicit called in the
efl::eo::inherit constructor, which will receive them via variadic
template arguments.
Added another constructor to efl::eo::inherit for passing the parent
object.
Updated some tests and examples to follow the new interface.
Removed some code that is no longer necessary.
Also, fix Eolian C++ support for constructing properties. fix
assertion when parsing constructing properties.
Now if a property is a constructing property eolian_cxx will generate a
constructor method that have the property name (without the "_set" suffix).
Vitor Sousa [Thu, 19 Feb 2015 15:09:32 +0000 (13:09 -0200)]
eina_cxx: Add methods to get an eina::accessor from an eina::ptr_array
eina::ptr_array was missing the methods to get an eina::accessor from it.
Added these methods.
Vitor Sousa [Fri, 13 Feb 2015 01:22:50 +0000 (23:22 -0200)]
eina_cxx: Fix compatibility between eina::optionals of convertible types
Now an eina::optional that wraps a specific type can be constructed or
have content assigned to it using another eina::optional that wraps a
different type, provided that the two wrapped types are convertible
between each other.
Added "disengage" member function to be able to disengage a R-value
eina::optional of different contained type.
It also adds for increased convenience.
Fix constructing an engaged eina::optional from an disengaged one.
Fix small assertion problem of trying to construct an eina::optional
already flagged as engaged.
Fix incorrect use of std::move. Changed it to std::forward.
Added constexpr property for trivial constructors.
Added auxiliary function "make_optional".
Added unit test to check compatibility between eina::optionals of
convertible types.
Vitor Sousa [Mon, 26 Jan 2015 17:49:16 +0000 (15:49 -0200)]
eo_cxx: Fix signal_connection disconnect crash
Fixed crash when disconnecting event inside of its own event callback.
Instead of deleting the callback object immediately during disconnection
(which causes the callback to be freed), the deletion is now scheduled
for later (using ecore_main_loop_thread_safe_call_async).
Updated some Makefiles to proper include ecore now that it is used in
all event wrappers.
Added a unit test to verify crashes under these circumstances.
Vitor Sousa [Fri, 23 Jan 2015 21:31:27 +0000 (19:31 -0200)]
ecore_cxx: Fix perfect forward of callback argument
Vitor Sousa [Mon, 12 Jan 2015 14:00:59 +0000 (12:00 -0200)]
eolian_cxx: Add protected methods and events to C++ wrappers and fixes
Using eina::string_view in eolian generated interfaces (instead of
std::string) to allow lightweight passing of both C strings and C++
std::string.
Also, No longer using eina::optional in generated headers for types
that already implements the concept of null state (like Eo wrappers
and eina_accessor).
Also fix allocating callback objects require by class methods
(i.e. static) in static vectors so the memory will be freed when the
programs exit.
Added a new test case for testing callbacks on class methods.
Moved method definitions and supplementary code from generated C++
wrappers to auxiliary header file (.eo.impl.hh) generated together
with the main ".eo.hh" file. Updated Makefiles to list such files in
the compilation and cleanup processes. Updated .gitignore to include
these new generated files.
Made general adjustments on the documentation of generated C++ wrappers
Added "PREDEFINED" preprocessor macro definition in the Doxyfile.in in
order to make some adjustments for better documentation in the C++
generated headers. Excluding generation of documentation for classes
in the "eo_cxx" namespace (the namespace for "abstract" eolian C++
wrappers). Now generating the documentation for the events too.
Hiding some auxiliary code from being documented. Some aesthetic
adjustments for generated white space. Generate documentation for the
main constructor of C++ wrappers and added auxiliary grammars to list
parameters names.
Vitor Sousa [Mon, 12 Jan 2015 13:57:19 +0000 (11:57 -0200)]
eina_cxx: Add eina::string_view class (non owning reference to string)
Add an implementation of string_view to Eina C++. It is a non owning
reference to a string that allows lightweight argument passing of both
C++ std::string and C strings (const char*) on interfaces.
Vitor Sousa [Tue, 6 Jan 2015 17:39:44 +0000 (15:39 -0200)]
eolian_cxx: Declaring all inherited events on the concrete C++ wrapper
Added declaration of all inherited events on the concrete type to
avoid unnecessary type conversion on event callbacks.
Note that when two events happens to have the same name, only the
event of the derived class is declared in the concrete class. Access to
such events should be made through the base class type specification.
Fix on forwarding callback object (changed std::move to std::forward).
Additional line break at the end of event handling methods in the
generated headers to improve readability.
Chris Michael [Tue, 14 Apr 2015 00:29:53 +0000 (20:29 -0400)]
efreetd: If we fail to allocate space for subdir_cache, then get out
Summary: Fix coverity CID1294212 (potential Null pointer dereference) as
the alloc for subdir_cache Could fail, however if it does we Were
still trying to use it. In the case that it fails, ERR msg and return.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Mon, 13 Apr 2015 13:51:10 +0000 (15:51 +0200)]
release: Update NEWS and bump version for 1.14.0-beta1 release
Tom Hacohen [Mon, 13 Apr 2015 13:34:45 +0000 (14:34 +0100)]
Ector: Fix distcheck.
The generated Eolian headers should *not* be included in the dist
tarball. This makes autofoo go crazy (why would it? ffs) and is
wrong anyway.
Tom Hacohen [Mon, 13 Apr 2015 12:50:43 +0000 (13:50 +0100)]
Evas object: verify the parent is valid and fail if not.
It seems like before the switch to Eo, all the object_*_add functions
had magic checks that only allowed non NULL Evas pointers to be passed.
Since we switched to Eo we apparently missed the early failure we used
to have, and we instead fail later. This patch should fix that.
Thanks to jaehwan for reporting.
@fix
Jihoon Kim [Mon, 13 Apr 2015 10:11:13 +0000 (19:11 +0900)]
eina: fix typos in doxygen
Stefan Schmidt [Fri, 10 Apr 2015 15:24:09 +0000 (17:24 +0200)]
build: Make sure the ecore_drm Makefile gets included after its dependencies
This problem have been observed by Scimmia22 on the Arch builds as well as on
the jenkins wayland build job. While compiling works fine the relinking during
make install fails with ecore-drm linking does not find eeze or eldbus as its
deps. This only shows on systems with no efl installed, a build from scratch.
As far as I can see we have all dependencies set correctly in configure as
well as in the Makefile which are working fine even in highly parallel builds.
It was a bit surprising here to me that the include order is still important
with our correct dependencies. Autotools wisdom is welcome here to either
explain to me why this is needed or what the correct fix would be.
The includes all moved before Ecore_Evas because that would use ecore_drm if
enabled.
Fixes T2281
Jean-Philippe Andre [Mon, 13 Apr 2015 06:29:52 +0000 (15:29 +0900)]
Evas GL common: Properly disable texuv3 when only texuv2 is used
Yet another vertex array fix (GL crash).
Jean-Philippe Andre [Mon, 13 Apr 2015 06:28:16 +0000 (15:28 +0900)]
Evas GL common: Enable vertex arrays only when requested
This should fix Dave's crash with the GL engine.
Indeed the pointer to the color array is passed directly
to the driver, without memcpy. Then, during glDrawArrays, the
driver will try to address it... but it could as well be NULL or
invalid. So, crashes would occur.
Also mark use_vertex as always true. We keep this field only for the
alloc() function.
Jean-Philippe Andre [Mon, 13 Apr 2015 05:00:46 +0000 (14:00 +0900)]
Emile: Fix memory leak
The binbuf wrappers were never freed.
Jean-Philippe Andre [Mon, 13 Apr 2015 04:51:53 +0000 (13:51 +0900)]
Evas GL common: Fix size of vertices data buffer
This actually has more chances of fixing Dave's GL crash.
Jean-Philippe Andre [Mon, 13 Apr 2015 02:13:52 +0000 (11:13 +0900)]
Evas GL common: Only push color VBO for map when required
Since the new shader selection system is able to check the
value of nomul, we can avoid pushing color when they are not
required (color is opaque white).
Hopefully this will fix Dave's crash (mayyyyybe...)
Chris Michael [Mon, 13 Apr 2015 01:08:20 +0000 (21:08 -0400)]
evas-software-x11: Fix dereference before null check(s)
Summary: This fixes Coverity CID1270028, CID1270029, CID1270030 where
variables RGBA_Image and Native where dereferencing function input
paramaters Before null checking them.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 13 Apr 2015 01:04:10 +0000 (21:04 -0400)]
evas-gl-x11: Fix dereference before null check
Summary: This fixes Coverity CID1293519 where einfo was being used
Before it was being null checked (which Could have caused a crash if
in fact einfo Was NULL).
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 13 Apr 2015 00:58:59 +0000 (20:58 -0400)]
edje: Fix dereference null return value
Summary: Fix Coverity CID1287154. _alloc function can return null
however 'color' was never checked after call to _alloc and thus Could
be NULL.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 13 Apr 2015 00:55:49 +0000 (20:55 -0400)]
evas-3d: Fix Resource leak from CID1271635
Summary: This fixes a reported resource leak (by coverity).
_pack_meshes_vertex_data allocates memory stored in 'vertices' however
vertices is never free'd unless count > 0
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 13 Apr 2015 00:51:31 +0000 (20:51 -0400)]
ector: Fix Coverity CID1293003
Summary: This fixes an issue of coverity reporting Explicit null
dereference as fetchfunc is defaulted to NULL, yet no check is made
later before calling it.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 13 Apr 2015 00:49:10 +0000 (20:49 -0400)]
evas: Fix CID1293000 (resource leak)
Summary: This fixes a resource leak of eina_array in
eng_ector_renderer_draw which would return without freeing an
allocated array.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>