Zbigniew Jędrzejewski-Szmek [Mon, 2 Jul 2018 21:21:04 +0000 (23:21 +0200)]
man: use the same markup for "ap" everywhere
Evgeny Vereshchagin [Sat, 30 Jun 2018 05:19:01 +0000 (05:19 +0000)]
tests: up the image size a little, use twice that size with STRIP_BINARIES=no
to make sure that there's enough room for unstripped binaries.
Violet Halo [Fri, 15 Jun 2018 08:18:07 +0000 (01:18 -0700)]
sd-bus: publicize sd_bus_message_readv()
The D-Bus library supplies a va_list variant of
`sd_bus_message_append()` called `sd_bus_message_appendv()`,
but failed to provide a va_list variant of its opposite,
`sd_bus_message_read()`. This commit publicizes a previously static
function as `sd_bus_message_readv()`.
Yu Watanabe [Fri, 29 Jun 2018 07:26:49 +0000 (16:26 +0900)]
tree-wide: use instead of #ifdef for HAVE_*
Yu Watanabe [Thu, 28 Jun 2018 14:57:22 +0000 (23:57 +0900)]
resolve: update log message
Follow-up for
f43580f17d9977ea330deacc8931982e41a49abf.
Lennart Poettering [Fri, 29 Jun 2018 09:35:57 +0000 (11:35 +0200)]
Merge pull request #9468 from yuwata/small-cleanups
small fixes and cleanups for comments
ChenQi1989 [Fri, 29 Jun 2018 06:54:07 +0000 (06:54 +0000)]
Use #if instead of #ifdef for ENABLE_GSHADOW
ENABLE_GSHADOW is defined to be 0 or 1. So #if should be used instead of #ifdef.
RussianNeuroMancer [Wed, 27 Jun 2018 16:32:19 +0000 (00:32 +0800)]
Add accel mount matrix for BayTrail-based tablets by DEXP
This commit adds accel mount matrix for DEXP Ursus 10XW and Z110i tablets. In current state (*svn*DEXP*:*pn*DEXPOEM*) it will apply to many (if not almost all) BayTrail-based tablets with Windows by DEXP (with same DMI strings) but this expected to cause no (or very little) harm as this devices is mostly very similar with slight difference.
However, if correction of this quirk becomes necessary in the future, this DMI strings could be used to distinguish 10XW and Z110i from other tablets by DEXP.
DEXP Ursus 10XW: dmi:bvnTechvisionHASHVersion96AC8868:bvr5.6.5:bd12/26/2014:svnDEXP:pnDEXPOEM:pvr1.0:rvnDEXP:rnDEXPOEM:rvr1.0:cvnToBeFilledByO.E.M.:ct3:cvrToBeFilledByO.E.M.:
DEXP Ursus Z110i Apollo: dmi:bvnTechvisionHASHVersion1DE28747:bvr5.6.5:bd03/14/2015:svnDEXP:pnDEXPOEM:pvr1.0:rvnDEXP:rnDEXPOEM:rvr1.0:cvnToBeFilledByO.E.M.:ct3:cvrToBeFilledByO.E.M.:
Yu Watanabe [Fri, 29 Jun 2018 03:40:27 +0000 (12:40 +0900)]
man: add missing parentheses
Yu Watanabe [Fri, 29 Jun 2018 03:35:36 +0000 (12:35 +0900)]
bus-util: update comment
Originally, request_name_handler_may_reload_dbus() was written for
timesyncd. But now it is also called by networkd or resolved.
Yu Watanabe [Fri, 29 Jun 2018 02:02:17 +0000 (11:02 +0900)]
tree-wide: drop double newline
Yu Watanabe [Fri, 29 Jun 2018 02:00:30 +0000 (11:00 +0900)]
tree-wide: drop empty comments
Yu Watanabe [Fri, 29 Jun 2018 01:50:23 +0000 (10:50 +0900)]
tree-wide: drop empty lines in the begining of comments
Yu Watanabe [Mon, 25 Jun 2018 12:04:22 +0000 (21:04 +0900)]
network: update log message
Closes #9396.
Yu Watanabe [Mon, 25 Jun 2018 07:19:32 +0000 (16:19 +0900)]
bus-util: drop unnecessary !!
Lennart Poettering [Thu, 28 Jun 2018 08:17:54 +0000 (10:17 +0200)]
Merge pull request #9422 from yuwata/conf-files
cleanups for default conf files
Yu Watanabe [Wed, 27 Jun 2018 06:46:43 +0000 (15:46 +0900)]
tree-wide: use 'signed int' instead of 'int' for bit field variables
Suggested by LGTM: https://lgtm.com/rules/
1506024027114/
Lennart Poettering [Thu, 28 Jun 2018 08:07:59 +0000 (10:07 +0200)]
Merge pull request #9452 from evverx/coverity.sh
coverity.sh: use a comma to separate module names
Yu Watanabe [Thu, 28 Jun 2018 06:01:28 +0000 (15:01 +0900)]
resolve: warn when our stub listener is disabled but resolv.conf uses it
Closes #9450.
Yu Watanabe [Thu, 28 Jun 2018 07:09:04 +0000 (16:09 +0900)]
meson: do not compare objects of different types
This fixes the following warning:
```
meson.build:1140: WARNING: Trying to compare values of different types (DependencyHolder, list) using !=.
The result of this is undefined and will become a hard error in a future Meson release.
```
Follow-up for
f02582f69fe1e7663a87ba80bd4f90d5d23ee75f(#9410).
Evegeny Vereshchagin [Tue, 26 Jun 2018 02:32:44 +0000 (02:32 +0000)]
sd-bus: stop using the result of an assignment as an operand of &&
This makes OBJECT_PATH_FOREACH_PREFIX consistent with PATH_FOREACH_PREFIX
and also fixes 7 alerts reported by LGTM at
https://lgtm.com/projects/g/systemd/systemd/snapshot/
ac0a08700344a5690803df8dd80e8bb5013184a5/files/src/libsystemd/sd-bus/bus-objects.c?sort=name&dir=ASC&mode=heatmap&showExcluded=true#V1383
Lennart Poettering [Wed, 27 Jun 2018 18:02:49 +0000 (20:02 +0200)]
core: tiny comment fix
Lennart Poettering [Wed, 27 Jun 2018 17:59:45 +0000 (19:59 +0200)]
summary: update nspawn description string a bit
nspawn as it is now is a generally useful tool, hence let's drop the
comments about it being useful for debug and so on only.
The new wording just makes the first sentence of the main page also the
summary.
Filipe Brandenburger [Wed, 27 Jun 2018 16:19:33 +0000 (09:19 -0700)]
sleep: fix one more printf format of a fiemap field
Use PRIu64 constant to get the format right on LP-64 architectures,
cast to (uint64_t) to solve incompatibility of __u64.
This was missed in
ad4bc3352285f467f4ffa03c3171b19fa0a8758d, so fix it
with this follow up.
Mike Gilbert [Wed, 27 Jun 2018 14:36:50 +0000 (10:36 -0400)]
basic: add missing comma in raw_clone assembly for sparc
Fixes:
96f64eb5741b157f26a9089816fdd992e959792e
Closes: https://github.com/systemd/systemd/issues/9444
Lorenz Hübschle-Schneider [Tue, 26 Jun 2018 17:41:30 +0000 (19:41 +0200)]
cryptsetup: Add dependency on loopback setup to generated units
For loopback volumes, the generated unit needs to depend on
systemd-tmpfiles-setup-dev.service to ensure that loopback
support is loaded.
Fixes #9308
Yu Watanabe [Wed, 27 Jun 2018 12:20:55 +0000 (21:20 +0900)]
bus-util: make log level lower in request_name_destroy_callback()
Fixes #9442.
Lennart Poettering [Wed, 27 Jun 2018 08:37:36 +0000 (10:37 +0200)]
Merge pull request #9440 from yuwata/fix-js
journal-gateway: update browse.html
Lennart Poettering [Wed, 27 Jun 2018 08:36:50 +0000 (10:36 +0200)]
Merge pull request #9438 from yuwata/lgtm-fixes-2
small fixes suggested by LGTM
Yu Watanabe [Tue, 26 Jun 2018 07:41:22 +0000 (16:41 +0900)]
resolve: reduce number of conversions between ifname and ifindex
This also fixes minor memleak introduced in
654457e560c5723b90b419f7651b87040aade07e.
Filipe Brandenburger [Tue, 26 Jun 2018 01:07:48 +0000 (18:07 -0700)]
resolvconf: fixes for the compatibility interface
Also use compat_main() when called as `resolvconf`, since the interface
is closer to that of `systemd-resolve`.
Use a heap allocated string to set arg_ifname, since a stack allocated
one would be lost after the function returns. (This last one broke the
case where an interface name was suffixed with a dot, such as in
`resolvconf -a tap0.dhcp`.)
Tested:
$ build/resolvconf -a nonexistent.abc </etc/resolv.conf
Unknown interface 'nonexistent': No such device
Fixes #9423.
Yu Watanabe [Wed, 27 Jun 2018 04:32:05 +0000 (13:32 +0900)]
analyze: actually select longest activated-time of services
Discovered by LGTM.
Yu Watanabe [Wed, 27 Jun 2018 05:50:19 +0000 (14:50 +0900)]
journal-gateway: use localStorage["cursor"] only when it has valid value
Discovered by LGTM.
Yu Watanabe [Wed, 27 Jun 2018 05:22:24 +0000 (14:22 +0900)]
journal-gateway: explicitly declare local variables
Suggested by LGTM.
Yu Watanabe [Wed, 27 Jun 2018 04:28:28 +0000 (13:28 +0900)]
sd-bus: fix implicit downcast of bitfield reported by LGTM
Filipe Brandenburger [Tue, 26 Jun 2018 16:43:49 +0000 (09:43 -0700)]
sleep: fix printf format of fiemap fields
Use PRIu64 and PRIu32 constants to also get the format right on LP-64
architectures.
For the 64-bit fields, we need a cast to (uint64_t), since __u64 is
defined as a `long long unsigned` and PRIu64 expects a `long unsigned`.
In practice, both are the same, so the cast should be OK.
Evegeny Vereshchagin [Mon, 25 Jun 2018 05:32:16 +0000 (05:32 +0000)]
README.md: add an LGTM badge
Now that @yuwata has fixed a lot of alerts, the badge looks
much better than before, so let's show it :-)
Yu Watanabe [Mon, 25 Jun 2018 17:55:25 +0000 (02:55 +0900)]
tree-wide: use localtime_r() instead of localtime()
Follow-up for
e46acb7950a9f07ac60d772309de842c444ad2bd.
Yu Watanabe [Mon, 25 Jun 2018 17:01:16 +0000 (02:01 +0900)]
netdev: do not assign unused values
Jan Janssen [Mon, 25 Jun 2018 18:33:31 +0000 (20:33 +0200)]
crypt-util: Translate libcryptsetup log level instead of using log_debug()
This makes sure that errors reported by libcryptsetup are shown to the
user instead of getting swallowed up by log_debug().
Evegeny Vereshchagin [Mon, 25 Jun 2018 22:22:29 +0000 (22:22 +0000)]
coverity.sh: fail if uploading data to Coverity Scan is forbidden
Evegeny Vereshchagin [Mon, 25 Jun 2018 22:02:41 +0000 (22:02 +0000)]
coverity.sh: use a comma to separate module names
Otherwise Python bails out with
```
Traceback (most recent call last):
File "<string>", line 1, in <module>
NameError: name 'json' is not defined
```
See https://travis-ci.org/systemd/systemd/jobs/
397490437
Evegeny Vereshchagin [Mon, 25 Jun 2018 21:59:28 +0000 (21:59 +0000)]
coverity.sh: make the script compatible with Python 3
Evegeny Vereshchagin [Mon, 25 Jun 2018 21:57:43 +0000 (21:57 +0000)]
coverity.sh: fix a couple indents
Yu Watanabe [Mon, 25 Jun 2018 19:07:44 +0000 (04:07 +0900)]
man: add missing option for system.conf
Yu Watanabe [Mon, 25 Jun 2018 19:07:19 +0000 (04:07 +0900)]
core: add missing option and drop nonexistent option in system.conf
Yu Watanabe [Mon, 25 Jun 2018 19:05:42 +0000 (04:05 +0900)]
journal: add missing option in journald.conf
Yu Watanabe [Mon, 25 Jun 2018 19:04:45 +0000 (04:04 +0900)]
journal-remote: add license and reference to man page in conf files
Yu Watanabe [Mon, 25 Jun 2018 18:34:49 +0000 (03:34 +0900)]
network: provide default networkd.conf
Lennart Poettering [Mon, 25 Jun 2018 12:29:25 +0000 (14:29 +0200)]
timedate: use gmtime_r() and localtime_r()
gmtime() and localtime() operate on a static buffer. let's avoid this,
as we never know whether some library might use these calls in some
backrgound thread.
Discovered by lgtm:
https://lgtm.com/projects/g/systemd/systemd/
Zbigniew Jędrzejewski-Szmek [Mon, 25 Jun 2018 17:03:31 +0000 (19:03 +0200)]
Merge pull request #9411 from poettering/systemctl-is-running-fixes
tiny systemctl fixes
Yu Watanabe [Mon, 25 Jun 2018 16:43:33 +0000 (01:43 +0900)]
man: add comments about MTUBytes= and MACAddress= for tuntap devices
Closes #9407.
Zbigniew Jędrzejewski-Szmek [Mon, 25 Jun 2018 16:48:01 +0000 (18:48 +0200)]
Merge pull request #4522 from lucaswerkmeister/unescape-template
escape: support --unescape with --template
Lennart Poettering [Thu, 21 Jun 2018 16:51:49 +0000 (18:51 +0200)]
busctl: make parameter const
it's initialized from an argv[] entry, hence let's be make it
non-writable by default.
Yu Watanabe [Mon, 25 Jun 2018 13:40:40 +0000 (22:40 +0900)]
meson: check whether gnutls supports TCP fast open
Fixes #9403
Lennart Poettering [Mon, 25 Jun 2018 14:23:18 +0000 (16:23 +0200)]
systemctl: if we can't detect the system-is-running state, assume it's not running
Lennart Poettering [Mon, 25 Jun 2018 14:22:48 +0000 (16:22 +0200)]
systemctl: log errors to LOG_DEBUG rather than eating them up entirely
Lennart Poettering [Mon, 25 Jun 2018 14:22:13 +0000 (16:22 +0200)]
systemctl: add 'static' to constant state array
Zbigniew Jędrzejewski-Szmek [Mon, 25 Jun 2018 13:18:29 +0000 (15:18 +0200)]
bls: allow firmware-supported file systems
This copies the text from Matthew Garrett's version verbatim. At
least MacOS uses HFS+ for their ESP.
Ludwin Janvier [Mon, 25 Jun 2018 11:18:13 +0000 (13:18 +0200)]
[hwdb] Add support for HP ProBook 650 wifi switch key (#9260)
Add support for HP ProBook 650 wifi switch key
Filipe Brandenburger [Tue, 12 Jun 2018 19:52:39 +0000 (12:52 -0700)]
resolved: assert t->server is set in dns_transaction_emit_tcp.
Uncovered by Coverity. Fixes CID 1393390.
Filipe Brandenburger [Tue, 12 Jun 2018 21:20:04 +0000 (14:20 -0700)]
core/job: add check for return of job_type_merge_and_collapse()
Using an assertion is fine, since calls to job_merge_into_installed()
are protected by a check for job_type_is_conflicting().
Uncovered by Coverity, fixes CID 996307.
M0Rf30 [Mon, 25 Jun 2018 09:40:12 +0000 (11:40 +0200)]
hwdb: added accelerometer quirk for Aspire Switch 10 (sw5-011)
Lennart Poettering [Mon, 25 Jun 2018 11:12:44 +0000 (13:12 +0200)]
Merge pull request #9398 from yuwata/lgtm-fixes
fixes error handlings and several cleanups suggested by LGTM
Michal Koutný [Fri, 22 Jun 2018 14:19:52 +0000 (16:19 +0200)]
core/manager: Make sure jobs statistics are not double after daemon-reload
We add n_installed_jobs and n_failed_jobs to our inner state after
deserialization. This is fine during daemon-reexec when we start with clear
Manager (and some jobs possibly queued before deserialization), however,
daemon-reload works with the same manager and adding the values would
effectively double the counters. Reset the counters before we deserialize and
add their values again.
Michal Koutný [Fri, 22 Jun 2018 13:45:41 +0000 (15:45 +0200)]
man: SystemMaxUse= clarification in journald.conf(5)
Similar semantics applies to {System,Runtime}MaxUse= as to
{System,Runtime}MaxFiles=, i.e. active files aren't vacuumed and the limit
is not thus strictly honored.
Lucas Werkmeister [Sun, 30 Oct 2016 22:49:15 +0000 (23:49 +0100)]
escape: add --instance option
Suggested by @keszybz in #4522.
Zbigniew Jędrzejewski-Szmek [Mon, 25 Jun 2018 08:52:58 +0000 (10:52 +0200)]
boot: do not assume the last character in cmdline is a newline
Fixes #9401.
Lucas Werkmeister [Sun, 30 Oct 2016 14:43:01 +0000 (15:43 +0100)]
escape: support --unescape with --template
Yu Watanabe [Mon, 25 Jun 2018 05:56:49 +0000 (14:56 +0900)]
tmpfiles: specify access mode for /run/systemd/netif
This partially reverts
2af767729489f6baa98a2641b2007acab44ed353.
As the directories are certainly readable and not-writable by
non-privileged users.
Yu Watanabe [Mon, 25 Jun 2018 05:42:10 +0000 (14:42 +0900)]
network: fix log message
Yu Watanabe [Sat, 23 Jun 2018 00:53:10 +0000 (09:53 +0900)]
timesync: update log message
Fixes #9388.
Yu Watanabe [Sat, 23 Jun 2018 00:41:55 +0000 (09:41 +0900)]
timesync: changes type of drift_freq to int64_t
drift_freq is used for storing timex.freq, and is a 64bit integer.
To support x32 ABI, this changes the type of drift_freq to int64_t.
Fixes #9387.
Sandy [Sat, 23 Jun 2018 04:14:46 +0000 (21:14 -0700)]
hwdb: Fix secondary backslash on MSI GS65 laptop
The MSI GS65 Stealth Thin series laptop contains an extra physical backslash key next to the spacebar which does not yield the correct keycode.
This pull request fixes the issue
RussianNeuroMancer [Sun, 24 Jun 2018 09:42:41 +0000 (17:42 +0800)]
Add resolution of Trust Flex Graphics Tablet to hwdb
Product:
https://www.trust.com/en/product/21259-flex-design-tablet-black
http://trust.com/21259
Support in libinput is already in place since libinput 1.11 release (I tested it)
https://gitlab.freedesktop.org/libinput/libinput/issues/38
So only missing part is definition in hwdb.
Evegeny Vereshchagin [Sat, 23 Jun 2018 16:53:04 +0000 (16:53 +0000)]
docs: put LGTM on the list of QA tools and fix a couple typos
Yu Watanabe [Mon, 25 Jun 2018 05:07:16 +0000 (14:07 +0900)]
install: fix error handling in is_symlink_with_known_name()
Yu Watanabe [Mon, 25 Jun 2018 04:56:27 +0000 (13:56 +0900)]
portable: fix error handling
Yu Watanabe [Mon, 25 Jun 2018 04:54:44 +0000 (13:54 +0900)]
import: drop unnecessary condition
Yu Watanabe [Mon, 25 Jun 2018 04:51:34 +0000 (13:51 +0900)]
sd-dhcp: drop unnecessary condition
Yu Watanabe [Mon, 25 Jun 2018 04:49:56 +0000 (13:49 +0900)]
machine-pool: drop unnecessary condition
Yu Watanabe [Mon, 25 Jun 2018 04:46:52 +0000 (13:46 +0900)]
resolve: drop dead code
Yu Watanabe [Mon, 25 Jun 2018 04:42:31 +0000 (13:42 +0900)]
resolve: drop dead code
Yu Watanabe [Mon, 25 Jun 2018 04:40:36 +0000 (13:40 +0900)]
bootctl: drop dead code
Yu Watanabe [Mon, 25 Jun 2018 04:36:49 +0000 (13:36 +0900)]
journal: drop redundant condition
Yu Watanabe [Mon, 25 Jun 2018 04:23:16 +0000 (13:23 +0900)]
resolve: fix return value type of dns_answer_has_dname_for_cname()
Yu Watanabe [Mon, 25 Jun 2018 04:20:35 +0000 (13:20 +0900)]
resolve: dns_scope_network_good() does not returns negative errno
Yu Watanabe [Mon, 25 Jun 2018 04:09:48 +0000 (13:09 +0900)]
core/cgroup: drop unnecessary condition
Yu Watanabe [Mon, 25 Jun 2018 04:08:02 +0000 (13:08 +0900)]
bus-util: fix error handling
Yu Watanabe [Mon, 25 Jun 2018 04:04:59 +0000 (13:04 +0900)]
tree-wide: add multiple inclusion guard
Yu Watanabe [Fri, 22 Jun 2018 22:16:27 +0000 (07:16 +0900)]
meson: drop unused option
Follow-up for
add384dd4d2b96db6ace5ad9c52b1dd7553ebec2.
Yu Watanabe [Fri, 22 Jun 2018 21:39:19 +0000 (06:39 +0900)]
core: drop unused log message
temporary_filesystem_add() does not parse mount options.
YmrDtnJu [Fri, 22 Jun 2018 23:17:07 +0000 (23:17 +0000)]
core: Actually use the resolved path for TemporaryFileSystem= (#9385)
The code already resolves specifiers using unit_full_printf() but then uses the
unresolved version again for temporary_filesystem_add().
Zbigniew Jędrzejewski-Szmek [Fri, 22 Jun 2018 12:13:43 +0000 (14:13 +0200)]
tree-wide: drop copyright lines for more authors
Acks in https://github.com/systemd/systemd/issues/9320.
Lennart Poettering [Fri, 22 Jun 2018 11:03:47 +0000 (13:03 +0200)]
meson: bump package and library version
Lennart Poettering [Fri, 22 Jun 2018 10:57:54 +0000 (12:57 +0200)]
final touches to NEWS
Zbigniew Jędrzejewski-Szmek [Fri, 22 Jun 2018 11:03:21 +0000 (13:03 +0200)]
man: small fixups for systemd-boot(8)
- "UEFI firmware" is a name, no need for an article
- The specification is more than "recommendation"
Jan Synacek [Fri, 22 Jun 2018 07:11:49 +0000 (09:11 +0200)]
man: correct the meaning of TimeoutStopSec= (#9325)
Fixes: #9325
Yu Watanabe [Fri, 22 Jun 2018 03:32:28 +0000 (12:32 +0900)]
tmpfile: do not specify mode and owner to /run/systemd/netif
Fixes #9369.
Kevin Kuehler [Tue, 19 Jun 2018 20:56:36 +0000 (13:56 -0700)]
journalctl: handle inotify exhaustion nicer
Instead of failing, log that inotify wds
are exhausted and fallback to -n switch.
Fixes #1296.