platform/framework/web/chromium-efl.git
6 years agoRestructure chromium-efl.gyp (build entry point)
Antonio Gomes [Thu, 9 Jul 2015 12:25:59 +0000 (21:25 +0900)]
Restructure chromium-efl.gyp (build entry point)

Patch creates a "build_all"-like target for EWK,
where all the sample apps are set as 'dependencies'.
It also deliberately removes the explicit inclusion of
efl_integration.gypi (where the 'chromium-ewk' target is
declared).

Reasoning is that 'chromium-ewk' is set as an explicit
dependecy of all three targets currently listed in chromium-ewk.gyp,
so its inclusion is redundant.
Also, the explicit inclusion of efl_integration.gypi from
chromium-ewk.gyp caused GYP error when we try to set 'chromium-ewk'
target as a dependency for 'xwalk' target:

[XXs] IndexError: string index out of range while reading
includes of /(..)/tizen_src/ewk/chromium-ewk.gyp while trying to load
/(..)/tizen_src/ewk/chromium-ewk.gyp

Reference: https://groups.google.com/forum/#!topic/gyp-developer/J-0xR5wye30

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: Ic30be2a2dd218c7da3a1b5398b222b1c926ee941
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoLimit memory allocations in MessagePumpForUIEfl
Pawel Forysiuk [Mon, 8 Jun 2015 18:13:31 +0000 (20:13 +0200)]
Limit memory allocations in MessagePumpForUIEfl

There was a segfault which occured when ecore_timer callback was
called but |MessagePumpForUIEfl| object (passed as |this| to the
callback) was previously destroyed.

In order to prevent this, all pending timers were added to |unordered_set|
object and they were deleted either when MessagePumpForUIEfl destructor was
called (to invalidate them) or when callback was handled.

As timers work asynchronously all objects passed to timer were
previously created on heap. As a result, there were a huge
number of allocations, for example,
scroll down and up on m.naver.com cause ~3500 of them.

According to doc of MessagePump::ScheduleDelayedWork() from
src/base/message_loop/message_pump.h, all previous pending timers
should be cancelled.
This fact allows getting rid of keeping pending timers and from now
only one timer is alive in MessagePumpForUIEfl.

Since this is extremely hot path in the source, this patch updates
pending timer interval instead of:
if (timer)
    ecore_timer_del(timer);
timer = ecore_timer_add(...);

This should have good performance impact as well.

In average, depends on page content, this patch saves ~400 KB in PSS
for Browser process.

Patch cherry picked from beta/m40_2214_t_memopt

http://suprem.sec.samsung.net/gerrit/#/c/35486/

Original Author: Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by: Janusz Majnert, Karol Furmaniak, kavitha devara

Change-Id: I76b73d6134543af7b87ebb21546eaf7b2e24a9ed
Signed-off-by: Pawel Forysiuk <p.forysiuk@samsung.com>
6 years agoFix the chromium-ewk.filter patch in GYP
Antonio Gomes [Thu, 9 Jul 2015 07:02:57 +0000 (16:02 +0900)]
Fix the chromium-ewk.filter patch in GYP

When we make crosswalk to link against chromium-ewk.so,
the relative path set for chromium-efl.filter fails to
resolve, as per the error below:

(..)/third_party/binutils/Linux_x64/Release/bin/ld.gold: error:
  cannot open ../../../tizen_src/ewk/chromium-ewk.filter: No such file or directory
(..)/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: fatal error:
unable to parse version script file ../../../tizen_src/ewk/chromium-ewk.filter

Patch sets chromium-ewk.filter path in an absolute way,
similarly to [1].

[1] https://goo.gl/OiXpH3

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: SeungSeop Park, Sharath Kamath

Change-Id: I630bcc6f60b720a98f34a20eb97ec1c8602ff745
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoBuild content_shell by default in desktop build
SeungSeop Park [Fri, 10 Jul 2015 00:44:05 +0000 (09:44 +0900)]
Build content_shell by default in desktop build

If you don't like to build it, pass '--no-content-shell' to build_desktop.sh.
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: I23e42e9a3ee1138f9b51c6d3bda229765c6bd019
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
6 years agoPreventing creation of unused instance 'EdgeEffect' on TV target
Youngsoo Choi [Thu, 2 Jul 2015 05:10:21 +0000 (14:10 +0900)]
Preventing creation of unused instance 'EdgeEffect' on TV target

[issue]
TV does not support touch event, so instance of 'EdgeEffect'
does not need to be created on the target.
But the instance has been created.

[resolve]
This patch provides lazy initialization for instance of 'EdgeEffect',
so that it can not be created on TV target which does not support
touch event.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13549
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: Ifc784f92097f8dc2dc0418664dc03c9a74b35c4c
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
6 years ago[MM][CAPI] Handle CAPI callbacks on main thread.
k2.nagaraju [Wed, 8 Jul 2015 10:07:09 +0000 (15:37 +0530)]
[MM][CAPI] Handle CAPI callbacks on main thread.

Handle all CAPI callbacks on main thread. Call CAPI API's only from
main thread. Don't do any processing of data in capi callback function
to avoid possible errors / deadlocks.

This reverts commit http://165.213.202.130/gerrit/#/c/75385/4
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11539
Reviewed by: SeungSeop Park, Venugopal S M

Change-Id: Ife6f0c58f3bcad98546924a57ba1309bff53256c
Signed-off-by: k2.nagaraju <k2.nagaraju@samsung.com>
6 years agoEnabling switches for memory optimization patches.
amit.kumar8 [Mon, 6 Jul 2015 12:58:26 +0000 (18:28 +0530)]
Enabling switches for memory optimization patches.

This patch enables switches for following patches.

1. Implement purging unused resources.
   http://165.213.202.130/gerrit/#/c/81192/
2. Optimize the tile texture size for edge tiles.
   http://165.213.202.130/gerrit/#/c/81137/
3. Adding runtime switch for providing tile size
   rounding up factor.
   http://165.213.202.130/gerrit/#/c/81138/
4. Release discardable memory after used if purgable.
   http://165.213.202.130/gerrit/#/c/81265/
5. Add runtime switch to configure the discardable
   image cache size.
   http://165.213.202.130/gerrit/#/c/81142/
Reviewed by: Antonio Gomes, Prashant Nevase

Change-Id: I039cc38e23fe049e2fb9aa99970d571c36acb7a0
Signed-off-by: amit.kumar8 <amit.kumar8@samsung.com>
6 years ago[M40 merge][MM] Audio is mismatching with video frame.
sm.venugopal [Mon, 25 May 2015 14:22:51 +0000 (19:52 +0530)]
[M40 merge][MM] Audio is mismatching with video frame.

Streaming user-agent is now being set for media player. This was required
because for website "www.espncricinfo.com/ci/content/video_audio/796581.html",
the CDN was providing video URL in which there was audio-video sync issue.
After setting the user-agent it gives proper video URL.

Reference patch: http://165.213.202.130/gerrit/#/c/76885/

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13055
Reviewed by: SeungSeop Park, Venugopal S M

Change-Id: Iba923286d9de766d3bb4b742cb68537235f361db
Signed-off-by: sm.venugopal <sm.venugopal@samsung.com>
Signed-off-by: jitu.patel <jitu.patel@samsung.com>
6 years agoDefer creation of DisambiguationPopupEfl
Pawel Forysiuk [Tue, 9 Jun 2015 07:12:53 +0000 (09:12 +0200)]
Defer creation of DisambiguationPopupEfl

This object is unnecessarily allocated and initialized together with rwhv as
the likehood of its usage is rather low.

This popup notifies the client that multiple touch targets may have been pressed.
Test: WebKit/Source/web/tests/data/disambiguation_popup.html

To test memory gain, you need to pass:
    --enable-link-disambiguation-popup

This patch defers creation of DisambiguationPopupEfl when it needs to be shown.
This change does not regress performance and saves ~10O KB PSS.

Patch cherry picked from beta/m40_2214_t_memopt

http://suprem.sec.samsung.net/gerrit/#/c/33075/

Original Author: Grzegorz Czajkowski <g.czajkowski@samsung.com>
Reviewed by: Antonio Gomes, Janusz Majnert

Change-Id: I2bcbe247c8cd5123d7ca2d35ced576aa504a9cc2
Signed-off-by: Pawel Forysiuk <p.forysiuk@samsung.com>
6 years ago[M40 Merge] Enable parallel canvas by default.
Nitish [Wed, 8 Jul 2015 11:54:08 +0000 (17:24 +0530)]
[M40 Merge] Enable parallel canvas by default.

Enable Parallel canvas by default for tizen OS.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13033
Reviewed by: DaeHyun Ko, Prashant Nevase

Change-Id: I9c7cc0610d28c63c8e3ae700398231622ab37d8e
Signed-off-by: Nitish <ask.nitish@samsung.com>
6 years agoAdded autofill options to uBrowser menu.
Karol Furmaniak [Thu, 18 Jun 2015 12:19:49 +0000 (14:19 +0200)]
Added autofill options to uBrowser menu.

[Problem]: There is no autofill related options in uBrowser.

[Solution]: Added autofill related options to uBrowser menu:
Enable/Disable Form Profile
Enable/Disable Remember Form Data
Enable/Disable Remember Password

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12731
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: I3c27fa0a29cb0de901e0939dbcc172de9253126e
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years agoAdded ubrowser launch icon for tizen 2.4 and tizen 3.0.
Marcin Lapinski [Tue, 7 Jul 2015 13:08:03 +0000 (15:08 +0200)]
Added ubrowser launch icon for tizen 2.4 and tizen 3.0.

Reviewed by: Antonio Gomes, Janusz Majnert
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13309
Change-Id: I7380573f9da465d6c39f4d3b3683e79768496262

6 years agofixup! [M40 Merge] Add Ewk_Context specific notification handling
DongJun Kim [Tue, 7 Jul 2015 05:19:05 +0000 (14:19 +0900)]
fixup! [M40 Merge] Add Ewk_Context specific notification handling

This patch is a fixup of http://165.213.202.130/gerrit/#/c/82262/

WRT had error in latest platform because mismatching of typedef.
It is for reverting modification that
had removed "Ewk_Context*" from notification callback.
Also we make a new implementation for
"ewk_context_notification_callbacks_set/reset" without build error.
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: I780523a86cd4bf528c4c1906bd10acd9268ca1ab
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
6 years ago[M40 Merge] Fix ewk_error_code_get
Sanghyup Lee [Wed, 8 Jul 2015 01:40:33 +0000 (10:40 +0900)]
[M40 Merge] Fix ewk_error_code_get

Currently ewk_error_code_get returns the code defined in
src/net/base/net_error_list.h. This patch introduces a function converting
some of the net_error_list's into Ewk_Error_Code enums.

m40 patch: http://165.213.202.130/gerrit/#/c/76234/
Original author: Michał Pakuła vel Rutka <m.pakula@samsung.com>
Reviewed by: DONGJUN KiM, Hyunhak Kim

Change-Id: I05abb2b3e3cbe7c70a01e391fe7fddec5a93811d
Signed-off-by: Sanghyup Lee <sh53.lee@samsung.com>
6 years ago[tizen 3.0][m42][EWKAPI] add NULL check in ewk_autofill_profile_data_set
joke.song [Wed, 8 Jul 2015 01:18:15 +0000 (10:18 +0900)]
[tizen 3.0][m42][EWKAPI] add NULL check in ewk_autofill_profile_data_set

There is no NULL check for third parameter of ewk_autofill_profile_data_set.
It is needed for negaitve UTC cases,
utc_webkit2_ewk_autofill_profile_data_get_func_n,
utc_webkit2_ewk_autofill_profile_data_set_func_n.
Reviewed by: Antonio Gomes, DONGJUN KiM

Change-Id: Ie65cda987ea21c50ab65d19326b73e1ff9399753
Signed-off-by: joke.song <joke.song@samsung.com>
6 years ago[MM] Fix crash on playing only audio/video streams
sm.venugopal [Mon, 6 Jul 2015 16:53:07 +0000 (22:23 +0530)]
[MM] Fix crash on playing only audio/video streams

Unused elements are removed while playing only audio/video streams. No
reference is maintained. So, only |gst_bin_remove| is sufficient. It will
internally free the element.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13518
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: I51cd62e951bfc99454b51aff9a432aba21973801
Signed-off-by: sm.venugopal <sm.venugopal@samsung.com>
6 years ago[uBrowser] Can not open same window on window manager
Marcin Lapinski [Thu, 2 Jul 2015 09:59:23 +0000 (11:59 +0200)]
[uBrowser] Can not open same window on window manager

Problem is caused by the default behavior of list item, which sends callback
only when first becoming selected. Any further clicks will do nothing.

Solution is changing window list selection mode to
ELM_OBJECT_SELECT_MODE_ALWAYS which makes calling callback on every click
for items even if item is selected.

Reviewed by: Antonio Gomes, Janusz Majnert
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13359
Change-Id: Ie3548f820a91366712f0d29ac340036d0631bef1

6 years agoRemove FOR_TESTING_ewk_hit_test_image_height_get
Arnaud Renevier [Mon, 6 Jul 2015 14:35:20 +0000 (16:35 +0200)]
Remove FOR_TESTING_ewk_hit_test_image_height_get

Remove FOR_TESTING_ewk_hit_test_image_height_get and
FOR_TESTING_ewk_hit_test_image_width_get. Those apis aren't used
anywhere.
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: Ic97f4060e6b7d1d6d65f1fd802bd430084b10265
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years ago[MM] Fix proper restart after video play ends
ws29.jung [Thu, 2 Jul 2015 09:34:47 +0000 (18:34 +0900)]
[MM] Fix proper restart after video play ends

Before, restarting finished video didn't work properly because
internally, player tried to start video before seeking job is done.
This patch make player start video after seeking is done.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13568
Reviewed by: SeungSeop Park, Venugopal S M

Change-Id: I601e931910cec63585ef764904d9ff416c8e4dba
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
6 years agoFixing for ewk_settings_edge_effect_enabled_set
Youngsoo Choi [Thu, 2 Jul 2015 01:08:14 +0000 (10:08 +0900)]
Fixing for ewk_settings_edge_effect_enabled_set

[issue]
The EWK provides a API 'ewk_settings_edge_effect_enabled_set' to set
edge effect, but it does not work due to wrong condition in chromium-efl.

[resolve]
The variable 'enabled_globally' is changed by 'g_force_disable_edge_effect'
which follows google coding style, for better understanding,
and 'g_force_disable_edge_effect' is removed from the class member.

This patch also meets following condition.

Only if 'enabled_' is TRUE and 'g_force_disable_edge_effect' is FALSE,
the edge effect should be enabled.
Otherwise, the edge effect should be disabled.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13545
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: I636e87cf4d08a52b1192ad0dcd649a098ce52394
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
6 years agofixup! fixup! [wayland][tizen v3.0] Initial support for TV and mobile
yh106.jung [Tue, 7 Jul 2015 03:30:37 +0000 (12:30 +0900)]
fixup! fixup! [wayland][tizen v3.0] Initial support for TV and mobile

Patch removes wrong guard, MakeTouchEvent is not related to x11.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12490
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: Ic6b9874b4071d64c3f685cf71ee29a02b2008161
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
6 years ago[tizen 3.0][m42][EWKAPI] Implementation "ewk_object_ref, ewk_object_unref"
Adrian Szafranek [Mon, 29 Jun 2015 09:39:34 +0000 (11:39 +0200)]
[tizen 3.0][m42][EWKAPI] Implementation "ewk_object_ref, ewk_object_unref"

Patch adds functions ewk_object_ref and ewk_object_unref

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13329
Reviewed by: Hyunhak Kim, Marcin Kolibabka

Change-Id: I9a63c2d141e4e87d31cc1f94c601a18c62e545ff
Signed-off-by: Adrian Szafranek <a.szafranek@samsung.com>
6 years agoIntroduce 'crosswalk-bin.spec'.
Antonio Gomes [Wed, 24 Jun 2015 05:27:23 +0000 (22:27 -0700)]
Introduce 'crosswalk-bin.spec'.

Goal of the patch is:
Avoid requiring a full build of chromium-efl in order to
build xwalk-efl.
In order to achieve that, xwalk-efl "requires" chromium-efl-libs,
and makes it a hard dependency on the crosswalk-bin spec file.

Basically, chromium-efl-libs installs into the system all
.so files resulted of a component build of chromium-efl
targets ('xwalk' and 'ewk' targets excluded).

Then, when building crosswalk-bin, chromium (well also
blink, mojo, ffmpeg) is patched so that some targets
(the ones that take longer to build) are not rebuilt.
This is done by
crosswalk-do-not-build-several-chromium-dependencies.diff.
This patch changes several targets in the build system so that
they do not build or generate any files and just pass "-l<target>"
to the linker.

* packaging/crosswalk-bin.spec: fork of the xwalk's crosswalk-bin.spec.
  Difference from the original: It adds some dependencies needed by
  chromium-efl sources; it also calls gyp_chromiumefl.sh instead of
  directly calling gyp_xwalk, and changes some filepaths are per
  our needs.

* build/patches/crosswalk/crosswalk-do-not-build-several-chromium-dependencies.diff:
  fork of the xwalk version.
  Difference from the original: it does not patch the following
  targets:
  * third_party/icu/icu.gyp: we use ICU from system, and
    patch was not making a different for such case.
  * ui/views/views.gyp: chromium-efl (and xwalk-efl) use
    EFL as toolkit, so patching 'views' is irrelevant.
  * ui/aura/aura.gyp: same reason as above.

When building xwalk-efl (with crosswalk-bin) from scratch, only 2349
files are built instead of the original 12.6k of a full chromium-efl build.
There is a chance that the number of files built is decreased even more
if more chromium targets are changed as per the logic described above.

How to use use:
$ tizen_src/build/build_mobile.sh --crosswalk-bin

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: If0b5af0ffb82d7f4ac450c7083d3538c13d3d322
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years ago[M40 Merge] Enable accelerated 2d canvas feature.
Nitish [Fri, 3 Jul 2015 05:19:15 +0000 (10:49 +0530)]
[M40 Merge] Enable accelerated 2d canvas feature.

Accelerated 2d canvas feature is not enabled by default in m42.
Enable accelerated 2d canvas by default by adding switch
kForceAccelerated2dCanvas.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13033
Reviewed by: DaeHyun Ko, venu musham

Change-Id: Id695f7dd55d00d0e854ff465897659ceda4256c8
Signed-off-by: Nitish <ask.nitish@samsung.com>
6 years agofixup! Implement Delegate renderer using frame buffer object on Tizen.
Chandan Padhi [Thu, 2 Jul 2015 06:39:09 +0000 (12:09 +0530)]
fixup! Implement Delegate renderer using frame buffer object on Tizen.

Currently, there are two InsertSyncPointCHROMIUM() calls in
MailboxOutputSurfaceEfl::SwapBuffers() which is unnescessary.
Only one call would suffice.
Reviewed by: DaeHyun Ko, venu musham

Change-Id: I00da46d3363a93bcea679f9b2682c59ba07939f0
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
6 years agoImplement orientation_lock and orientation_unlock API
Tomasz Weglarski [Tue, 23 Jun 2015 10:22:39 +0000 (12:22 +0200)]
Implement orientation_lock and orientation_unlock API

This is a very basic implementation of orientation lock/unlock API:
http://www.w3.org/TR/screen-orientation/, based on current Chromium Android
implementation. Android's version has been stripped from Android specific
Start/StopAccurateListening methods, which will be provided in next patch.

This patch deprecates EWK API's ewk_view_orientation_lock_callback_set.

Together with: I51b8692482780fad707c723768b66dc776aa63cb
Reviewed by: Hyunhak Kim, Janusz Majnert, Karol Furmaniak, Piotr Grad, Tomasz Weglarski

Change-Id: I7569d94341c4de84b16066aab555822febacb03f
Signed-off-by: Michał Pakuła vel Rutka <m.pakula@samsung.com>
Signed-off-by: Tomasz Weglarski <t.weglarski@samsung.com>
6 years agoTie edge effect kick-off to touch events.
Antonio Gomes [Wed, 1 Jul 2015 18:33:04 +0000 (14:33 -0400)]
Tie edge effect kick-off to touch events.

When touch events are disabled (in case of TV profile, and
desktop builds), RWHVEfl::DidOverscroll is still called, and
kicks off edge effect logic.
Problem is that our edge effect hide logic, happens on a touch-only
code path. As a consequence, edge effect does no go away on non-touch
set ups.
Additionally, WebKit/EFL for Tizen TV profile does not have edge
effect enabled at all.

In order to avoid that problem, patch makes our edge effect kick
off logic tied to touch events.

Bug:  http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13452
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: I3e648bafcf3ca8908e58fb6e14f928283dff4d2c
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agofixup! Introduce 'chromium-efl-libs.spec'.
Antonio Gomes [Thu, 2 Jul 2015 21:18:09 +0000 (14:18 -0700)]
fixup! Introduce 'chromium-efl-libs.spec'.

Patch is a fixup of http://165.213.202.130/gerrit/#/c/82776/,
and consists in including the generated edj files
as part of the packaging of chromium-efl-libs.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: Ia8a9846922c0a30e6f665e47efa1154291292960
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoInternalization for notification
DongJun Kim [Tue, 30 Jun 2015 14:57:02 +0000 (23:57 +0900)]
Internalization for notification

This patch is internalization for notification on tizen 3.0.
Permission request callback is set to web-engine
by default using this.
- _ewk_view_default_notification_permission
If do not set any permission callback by user,
it will be shown up by web engine side.
Reviewed by: Hyunhak Kim, Karol Furmaniak

Change-Id: I5df4a37c30ee17bc0bd07e95c7a0d0e734e51050
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
6 years agoMake some edje resources directly compiled by content targets.
Antonio Gomes [Thu, 2 Jul 2015 19:18:40 +0000 (12:18 -0700)]
Make some edje resources directly compiled by content targets.

Some edc resources currently living in ewk/ are used
solely by chromium_impl targets. Namely:
Magnifier, Overscrolling and DisambiguationPopup.

Patch moves them to a specific target 'edje_resources_efl'
to be set as dependencies of targetd that need it.

As a consequence, it allows chromium-efl-libs (there
EWK targets are *not* build) to install the generated
edj files as part of packaging rules.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11889
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: Ib90a6a69d2a4bf6c1458d00840d661f99ddb94f4
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoInternalization for geolocation
DongJun Kim [Tue, 30 Jun 2015 05:48:57 +0000 (14:48 +0900)]
Internalization for geolocation

This patch is internalization for geolocation on tizen 3.0.

Permission request callback is set to web-engine
by default using this.
- _ewk_view_default_user_media_permission

If do not set any permission callback by user,
it will be shown up by web engine side.
Reviewed by: Hyunhak Kim, Karol Furmaniak

Change-Id: I15c6237c97f0b7e9114b1bed4a5ae65303910586
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
6 years ago[MM][GUM] Change default camera on TV
ws29.jung [Fri, 26 Jun 2015 02:44:55 +0000 (11:44 +0900)]
[MM][GUM] Change default camera on TV

Before "back" camera was mapped to CAPI enum CAMERA_DEVICE_CAMERA0
and "front" camera to CAMERA_DEVICE_CAMERA1.
CameraHandle, an internal wrapper class for CAPI's camera handle, creates
a camera with CAMERA_DEVICE_CAMERA0 in its default constructor.
However, back camera (CAMERA_DEVICE_CAMERA0) is not available in TV,
which yields invalid CameraHandle and GetUserMedia does not work as result.

To fix this, patch changes the mapping on TV so that CAMERA_DEVICE_CAMERA0
be associated with "front" camera.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13236
Reviewed by: SeungSeop Park, Sharath Kamath

Change-Id: I5c80c3f98e147122acd9065a9207c5fff855ac03
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
6 years agofixup! [wayland][tizen v3.0] Initial support for TV and mobile
Antonio Gomes [Tue, 30 Jun 2015 20:31:21 +0000 (13:31 -0700)]
fixup! [wayland][tizen v3.0] Initial support for TV and mobile

Patch removes unneeded dependencies and unneeded targets.
Namely: wayland-{client,cursor,egl,server}.

The dependencies were added needlessly, in preparation to a full
wayland-backend being developed for chromium-efl in [1]. This changed
when it was decided to take the ozone codepath [2].

[1] http://165.213.202.130/gerrit/#/c/80036/
[2] http://165.213.202.130/gerrit/#/c/80317/

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12490
Reviewed by: Antonio Gomes, Balazs Kelemen, arno renevier

Change-Id: I3aa0eab3e9cb1e0de3378da46eba73a0e5413163
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agofixup! Different build fixups for ozone
Antonio Gomes [Tue, 30 Jun 2015 17:54:34 +0000 (13:54 -0400)]
fixup! Different build fixups for ozone

Patch makes 'gl' target (ui/gl) depend explictly
on 'x11' target. It fixes the following build error
when doing a component build of chromium-efl for
Tizen 2.4 mobile profile.

gfx::OffScreenRootWindow::~OffScreenRootWindow():
  error: undefined reference to 'XUnmapWindow'
gfx::OffScreenRootWindow::~OffScreenRootWindow():
  error: undefined reference to 'XDestroyWindow'
gfx::NativeDisplayConnection::~NativeDisplayConnection():
  error: undefined reference to 'XCloseDisplay'
gfx::NativeDisplayConnection::NativeDisplayConnection():
  error: undefined reference to 'XOpenDisplay'
gfx::OffScreenRootWindow::OffScreenRootWindow(_XDisplay*):
  error: undefined reference to 'XDefaultRootWindow'
gfx::OffScreenRootWindow::OffScreenRootWindow(_XDisplay*):
  error: undefined reference to 'XCreateSimpleWindow'
gfx::OffScreenRootWindow::OffScreenRootWindow(_XDisplay*):
  error: undefined reference to 'XChangeWindowAttributes'
gfx::OffScreenRootWindow::OffScreenRootWindow(_XDisplay*):
  error: undefined reference to 'XMapWindow'
gfx::NativeBuffer::~NativeBuffer():
  error: undefined reference to 'XFree'
gfx::NativeBufferManager::Initialize():
  error: undefined reference to 'XDefaultScreen'
gfx::NativeBuffer::Lock(unsigned long, int):
  error: undefined reference to 'XFree'
gfx::EflPixmap::CreatePixmap(gfx::Size const&):
  error: undefined reference to 'XCreatePixmap'
gfx::EflPixmap::CreatePixmap(gfx::Size const&):
  error: undefined reference to 'XFlush'
gfx::EflPixmap::Initialize():
  error: undefined reference to 'XSync'
gfx::EflPixmap::FreePixmap(unsigned long):
  error: undefined reference to 'XFreePixmap'

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: Id971299dcc214078ba00bda0dc55234c31515ab8
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years ago[EWK_REFACTOR] bringup Ewk_Settings::useKeyPadWithoutUserAction() in OnTextInputState...
hh4813.kim [Tue, 16 Jun 2015 11:23:37 +0000 (20:23 +0900)]
[EWK_REFACTOR] bringup Ewk_Settings::useKeyPadWithoutUserAction() in OnTextInputStateChanged

EWK_REFACTOR guards are removed for bringup Ewk_Settings::useKeyPadWithoutUserAction() call
in RenderWidgetHostViewEfl::OnTextInputStateChanged().

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12028
Reviewed by: Antonio Gomes, DONGJUN KiM, arno renevier

Change-Id: I4e5ef32cec0a36392bfe0afdb657dd2e8da162b4
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
6 years agofixup! Implement Delegate renderer using frame buffer object on Tizen.
Chandan Padhi [Mon, 22 Jun 2015 09:22:17 +0000 (14:52 +0530)]
fixup! Implement Delegate renderer using frame buffer object on Tizen.

Currently, a TransferableFrame with empty mailbox is added to
pending_textures_ in MailboxOutputSurfaceEfl constructor. In
case of debug build, this results in crash due to failure in
DCHECK(!it->mailbox.IsZero()) condition in OnSwapAck().

This patch fixes the above crash.
Reviewed by: DaeHyun Ko, Prashant Nevase, venu musham

Change-Id: Ie65b263ae7884726f3a01977aad9dea135c9a3a3
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
6 years agouBrowser menu is unreadable.
Karol Furmaniak [Thu, 18 Jun 2015 12:07:10 +0000 (14:07 +0200)]
uBrowser menu is unreadable.

[Problem]: After opening menu(right bottom button) there
is no readable popup, only high thin popup.
Menu is not hiding properly.

[Solution]: Added menu resize. Fixed menu hide.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13213
Reviewed by: Hyunhak Kim, Piotr Grad

Change-Id: I620c6ff6d214ae427ca2ad0350bcaa5b9e02395f
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years agoUnapply patches on EXIT signal
Arnaud Renevier [Tue, 30 Jun 2015 14:15:34 +0000 (16:15 +0200)]
Unapply patches on EXIT signal

Right now, we unapply patches on ERR SIGINT SIGTERM SIGQUIT signals. We
also unapply them at the end of normal execution. Instead, this commit
traps EXIT signal which is more generic. It makes the code simple: no
need to unapply patches after the normal execution. The normal exit will
be handled. Also, patches were not unapplied in case of build failure;
it is fixed with this commit.

Note that currently, patches are not unapplied when build is canceled
with Control-C. This commit does not fix that issue.
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: I20a7e4389bc749bc156d10cf0c5ddc49c6aa0506
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agofixup! Introduce 'chromium-efl-libs.spec'.
yh106.jung [Tue, 30 Jun 2015 14:08:29 +0000 (23:08 +0900)]
fixup! Introduce 'chromium-efl-libs.spec'.

We have to define 'exe_dir' as path of chromium-efl-libs
in order to use properly icu data file.
Pleaes refer to InitializeICU in base/i18n/icu_util.cc.

In addition, define data_dir, edje_dir, locale_dir for later.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: I5aa967217ebe1df0acdf5a06acc88f64878fce1c
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
6 years agoIntroduce 'chromium-efl-libs.spec'.
Antonio Gomes [Tue, 16 Jun 2015 22:35:50 +0000 (15:35 -0700)]
Introduce 'chromium-efl-libs.spec'.

Goal of the patch is:
build and pack all chromium targets that both 'xwalk'
and 'chromium-ewk' targets depends on, using a component build.
Note that any target define in xwalk/ or tizen_src/ewk/
directories are excluded.
As result, chromium-efl-libs.rpm will contain all .so files
that xwalk and chromium-ewk targets requires to get build.

In a follow up patch, a crosswalk-bin.spec will be
introduced, and it will depend on chromium-efl-libs.rpm.
crosswalk-bin will build all xwalk targets, but not the chromium
targets already built by chromium-efl-libs.
This will speed up xwalk development cycle.

* packaging/chromium-efl-libs.spec: fork of the xwalk's crosswalk-libs.spec.
  Difference from the original: It adds some dependencies needed by
  chromium-efl sources; it also, calls gyp_chromiumefl.sh instead of
  directly calling gyp_xwalk.

* packaging/print-chromium-deps.py: fork of the xwalk version.
  Difference from the original: it changes the if condition that
  filter out xwalki and chromium-ewk targets from the final output.
  Script processes dump.json, which is the output of GYP when
  "dump_dependency_json" is set to GYP_GENERATORS.
  It prints out a list of targets to be built.

* packaging/chromium-efl-libs.manifest: copy from xwalk.

The change in system.gyp is needed because on component
builds, target that 'base' depends on directly need to
have a toolsets definition. see [1] for reference.

[1] http://codereview.chromium.org/7904034

How to use use:
$ tizen_src/build/build_mobile.sh --libs

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: I3268bc7aaff5bfa3ffda24c41da048654dbec75e
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years ago[tizen v3.0] Fixing malfunction of IME in Korean language mode
Youngsoo Choi [Wed, 24 Jun 2015 06:57:42 +0000 (15:57 +0900)]
[tizen v3.0] Fixing malfunction of IME in Korean language mode

[Issue]
A preediting Korean word is deleted, right after completion of the word.

[cause]
The API 'ecore_imf_context_reset' has been used in wrong case.

The usage of the API is like below in editable element.

1) When focus is out
2) When position of a cursor is moved by touch input
3) Before text selection starts
4) Before deleting string

[resolve]
This patch removes a redundant API.
When a preediting Korean word is completed,
platform emits a event 'ECORE_IMF_CALLBACK_COMMIT'
although 'ecore_imf_context_reset' is not called.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13441
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: I047411be517f0358d0a6f468fa71b95727159d46
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
6 years agoInternalization for user_media
DongJun Kim [Wed, 17 Jun 2015 11:30:13 +0000 (20:30 +0900)]
Internalization for user_media

This patch is internalization for user media on tizen 3.0.

In Previous version, permission request popups are
implemented on application side like WRT or browser.
Now we change to internalize this on web-engine.

Permission request callback is set to web-engine by default.
If do not set any permission callback by user,
it will be shown up by web engine side.

In this procedure, web-engine can manage request popup via below classes.
- UserMediaPermissionPopup
- PermissionPopupManager

On the other hand,
application can set to callback function and reply to result via below APIs.
- ewk_view_user_media_permission_callback_set()
- ewk_user_media_permission_reply()
- ewk_user_media_permission_request_origin_get()

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13067
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: I652ca1cbda5fd4fe38f5baba06a9c3103d4ac6fd
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
6 years ago[wayland] Webcursor for wayland
yh106.jung [Thu, 25 Jun 2015 07:08:45 +0000 (16:08 +0900)]
[wayland] Webcursor for wayland

Set cursor from the name that was predefined on wayland.
In wayland, 13 cursor types are provided.
======================
bottom_left_corner
bottom_right_corner
bottom_side
grabbing
left_ptr
left_side
right_side
top_left_corner
top_right_corner
top_side
xterm
hand1
watch
======================

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12763
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: If928caa49646abd6c29c59cf0186879064318567
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
6 years agoAdd missing dependency for efl-init
Arnaud Renevier [Fri, 19 Jun 2015 21:59:37 +0000 (14:59 -0700)]
Add missing dependency for efl-init

efl-init needs to depend on ozone, on compositor, and on
ecore-{x,wayland}.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, Hyunhak Kim, arno renevier

Change-Id: I095f1eb317b5fd0d6eeb08c01800de4268d1977f
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agoCreate shared mailbox manager in content module
Arnaud Renevier [Wed, 17 Jun 2015 01:00:17 +0000 (18:00 -0700)]
Create shared mailbox manager in content module

Right now, mailbox manager is created gl_shared_context_efl.cc

But gpu targets depend on 'gl'

So that means that 'gl' target depends on an object defined in gpu. But
gpu itself depend on gl target. In order to build with shared component,
we need to break that cycle.

So, this patch creates a shared mailbox manager object which resides in
content module.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, Prashant Nevase

Change-Id: Iee44b421448b95a7c0896cd8f080a7b66ed46a80
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agofixup! [Rebase][dev/m42_2311] Autofill bringup
Karol Furmaniak [Fri, 19 Jun 2015 11:41:41 +0000 (13:41 +0200)]
fixup! [Rebase][dev/m42_2311] Autofill bringup

[Problem]: Datalist popup does not show.
Only first element from list is entred to datalist
control field.

[Solution]: Elements with frontend_id < 0 were removed from
suggestion list, but shouldn't be.
After selecting suggestion, genlist index was passed as identificator,
but frontend_id should be passed.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12729
Reviewed by: Antonio Gomes, Piotr Grad

Change-Id: Idc63c08e2590ccadcaf8d3a569e6adcf1cefef4b
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years ago[M40 Merge] Add multisampling samples count to '4' for canvas on TV.
Nitish [Thu, 18 Jun 2015 12:36:09 +0000 (18:06 +0530)]
[M40 Merge] Add multisampling samples count to '4' for canvas on TV.

Set default multisampling count to 4. We can change it using
command line argument:

 --canvas-msaa-sample-count=|value|

+--------+-------------------+
|        | Canvas Perf Score |
+--------+-------------------+
| Before |       0.99        |
+--------+-------------------+
| After  |      ~2.00        |
+--------+-------------------+

m40 patch: http://165.213.202.130/gerrit/#/c/75340/

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12674
Reviewed by: Prashant Nevase, venu musham

Change-Id: Icf28ed2b218dd1d28f8cd65f835e038fc5f9773b
Signed-off-by: Nitish <ask.nitish@samsung.com>
6 years ago[MM]Enable TTS feature on 3.0 TV
ws29.jung [Wed, 24 Jun 2015 02:07:29 +0000 (11:07 +0900)]
[MM]Enable TTS feature on 3.0 TV

Before TTS feature was only enabled with Mobile build.
This patch enables TTS feature with Tizen 3.0 TV.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13391
Reviewed by: SeungSeop Park, Venugopal S M

Change-Id: I2e6c1fc942caab5eed8232cc0c5cd91c03698d8d
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
6 years agoRemove redundant and incorrect TOPDIR definitions
SeungSeop Park [Wed, 17 Jun 2015 23:57:48 +0000 (08:57 +0900)]
Remove redundant and incorrect TOPDIR definitions

After directory structure refactoring, TOPDIR defintion became wrong
in some build scripts. It caused no problem until now because correct
TOPDIR exported by common.sh overrides the wrong one anyway.
Patch just removes such redundant and incorrect TOPDIR definitions.
Reviewed by: Antonio Gomes, Hyungsun Ryu, arno renevier

Change-Id: I0c0c097e1319e36f82fc36f118dc4bd26e9c0838
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
6 years ago[Ubrowser] Implement user media permission popup
Marcin Lapinski [Wed, 24 Jun 2015 16:27:21 +0000 (18:27 +0200)]
[Ubrowser] Implement user media permission popup

Patch implements "usermedia,permission,request", and add general
permission popup windows UI in uBrowser. It makes iteasier to
implement other permission callbacks, (e.g. geolocation).

To verify this change follow these steps:
   1. Open page: https://www.simpl.info/getusermedia/
   2. Popup should appear.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13149
Reviewed by: Antonio Gomes, Janusz Majnert

Change-Id: If1c24b5487c48b10a20e865af84804c7449e111e
Signed-off-by: Marcin Lapinski <m.lapinski@samsung.com>
6 years agoMove WebMediaPlayerEfl from media to content_renderer
yh106.jung [Mon, 22 Jun 2015 03:52:24 +0000 (12:52 +0900)]
Move WebMediaPlayerEfl from media to content_renderer

Component build was failed when trying to link libmedia,
because WebMediaPlayerEfl needs libcontent.
If we add libcontent as a dependency in gyp to resolve link error,
it may result in cyclic dependency.
To avoid dependency on libcontent, WebMediaPlayerEfl should be
moved to content_renderer.
Please refer to the android's implementation(WebMediaPlayerAndroid).

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, SeungSeop Park, Venugopal S M

Change-Id: Id1ab83e5f5d5712061355c49a3d9f63de144967c
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
6 years ago[M40 Merge] Add Ewk_Context specific notification handling
DongJun Kim [Sun, 21 Jun 2015 09:23:30 +0000 (18:23 +0900)]
[M40 Merge] Add Ewk_Context specific notification handling

Below 2 APIs are missed in beta/m42.
So we need to migration from beta/m40
- ewk_context_notification_callbacks_set
- ewk_context_notification_callbacks_reset

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11367

Original patch: http://web.sec.samsung.net/gerrit/#/c/75818/
Reviewed by: Hyunhak Kim, Karol Furmaniak

Change-Id: I858117f52a5e7ca67ded2b2651cbd23938f8cabb
Signed-off-by: DongJun Kim <djmix.kim@samsung.com>
6 years agoRemove explicit dependency on capi-system-system-settings
Antonio Gomes [Wed, 17 Jun 2015 16:32:33 +0000 (09:32 -0700)]
Remove explicit dependency on capi-system-system-settings

After [1], content_common target does not need to
explicitly depend on 'capi-system-system-settings'.
Patch cleans this up.

For completeness, the dependency was originally added
by [2].

[1] http://165.213.202.130/gerrit/#/c/81990/
[2] http://165.213.202.130/gerrit/#/c/79010/
Reviewed by: Hyunhak Kim, mohan reddy

Change-Id: Iefc2b6dd9bb6fe9b128815c5569cdb8569e05a00
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoDo not "force" ninja as the gyp generated format
Antonio Gomes [Mon, 22 Jun 2015 16:56:34 +0000 (09:56 -0700)]
Do not "force" ninja as the gyp generated format

'ninja' is set as the default gyp output format in
src/build/gyp_environment.py, so we do not need to
explicitly set it.

Also, we were setting it unconditionally, which was
making it impossible to customize its value (e.g. by
GYP_GENERATORS environment variable).
For chromium-efl-libs work, we need to be able to set
'dump_dependency_json' as one of our gyp output format.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Balazs Kelemen, SeungSeop Park

Change-Id: Iaa0b579019ed756a886085ef7dcdf5a40b788503
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agofixup! Set more chromium-ewk target dependencies explicitly
Antonio Gomes [Mon, 22 Jun 2015 12:10:21 +0000 (05:10 -0700)]
fixup! Set more chromium-ewk target dependencies explicitly

That solves the following "undefined reference" errors at link time
(GBS builds):

function efl::AppendPortParams():
  error: undefined reference to 'cc::switches::kEnableTileCompression'
function efl::AppendPortParams():
  error: undefined reference to 'cc::switches::kTileCompressionThreshold'
function efl::AppendPortParams():
  error: undefined reference to 'cc::switches::kTileCompressionMethod'
function efl::AppendPortParams():
  error: undefined reference to 'cc::switches::kDisableTileCompression'

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Balazs Kelemen, Hyunhak Kim

Change-Id: Idd8e3cb0cf8b9e18aef8b9f939e6b68e2a9745dd
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agofixup! Various exports
Antonio Gomes [Mon, 22 Jun 2015 12:06:13 +0000 (05:06 -0700)]
fixup! Various exports

Export some extra class definitions (Tts) caught by
GBS builds of ewk target.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: I0e8228f1bee2bd610af9f2277de70bca481a3082
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agofixup! Flag to build chromium with shared components
Antonio Gomes [Mon, 22 Jun 2015 11:50:16 +0000 (04:50 -0700)]
fixup! Flag to build chromium with shared components

Patch adds support component=shared_library on GBS builds.

$build_{mobile,tv,emulator}.sh --component-build
or
$ gbs --define "component_build 1"

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: I40c082835a813e4753b79dd07b59170d17d8e3d1
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoExport content::WebAudioDecoderGStreamer
yh106.jung [Mon, 22 Jun 2015 11:33:47 +0000 (20:33 +0900)]
Export content::WebAudioDecoderGStreamer

content::WebAudioDecoderGStreamer is needed by Chromium-ewk.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: I170c463999f0e838c95c895efd7d4a6f31ed12f2
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
6 years agofixup! [wayland][tizen v3.0] Initial support for TV and mobile
Antonio Gomes [Fri, 19 Jun 2015 20:31:59 +0000 (16:31 -0400)]
fixup! [wayland][tizen v3.0] Initial support for TV and mobile

Patch removes 'xkbcommon' target declaration.
It is not only not needed, but if we ever need it
we can instead use GYP use_xkbcommon variable instead.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12490
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: I7bbc308c11d2393515e947ccdd2d11eff08a154c
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoSet more chromium-ewk target dependencies explicitly
Antonio Gomes [Fri, 19 Jun 2015 14:21:03 +0000 (10:21 -0400)]
Set more chromium-ewk target dependencies explicitly

That solves the following "undefined reference" errors at link time:

RemoveBitmapCommand::sqlExecute():
  error: undefined reference to 'sqlite3_*'
InsertFaviconURLCommand::sqlExecute():
  error: undefined reference to 'sqlite3_*'
InitDatabaseCommand::sqlExecute():
  error: undefined reference to 'sqlite3_*'
UpdateFaviconURLCommand::sqlExecute():
  error: undefined reference to 'sqlite3_bind_text'
InsertBitmapCommand::sqlExecute():
  error: undefined reference to 'sqlite3_bind_blob'
UpdateBitmapCommand::sqlExecute():
  error: undefined reference to 'sqlite3_bind_blob'
LoadDatabaseCommand::sqlExecute():
  error: undefined reference to 'sqlite3_column_text'
LoadDatabaseCommand::sqlExecute():
  error: undefined reference to 'sqlite3_column_blob'
FaviconDatabase::Close():
  error: undefined reference to 'sqlite3_close'
PrintWebViewHelperEfl::PrintPageInternal():
  error: undefined reference to 'printing::MetafileSkiaWrapper::SetMetafileOnCanvas()'
PrintWebViewHelperEfl::PrintPagesToPdf():
  error: undefined reference to 'printing::PdfMetafileSkia::PdfMetafileSkia()'
PrintWebViewHelperEfl::PrintPagesToPdf():
  error: undefined reference to 'printing::PdfMetafileSkia::Init()'
PrintWebViewHelperEfl::PrintPagesToPdf():
  error: undefined reference to 'printing::PdfMetafileSkia::~PdfMetafileSkia()'
PrintWebViewHelperEfl::PrintPagesToPdf():
  error: undefined reference to 'printing::PdfMetafileSkia::FinishDocument()'
PrintWebViewHelperEfl::PrintPagesToPdf():
  error: undefined reference to 'printing::PdfMetafileSkia::GetDataSize() const'
PrintWebViewHelperEfl::PrintPagesToPdf():
  error: undefined reference to 'printing::PdfMetafileSkia::GetData() const'
(anonymous namespace)::GetFileSystemOriginsOnFILEThread():
  error: undefined reference to 'storage::FileSystemQuotaClient::FileSystemQuotaClient()'
EWebView::SetOrientation(int):
  error: undefined reference to 'ecore_x_default_screen_get'
  error: undefined reference to 'ecore_x_screen_size_get'
  error: undefined reference to 'ecore_x_default_screen_get'
  error: undefined reference to 'ecore_x_screen_size_get'
EWebView::HandleTouchEvents():
  error: undefined reference to 'ui::TouchEvent::~TouchEvent()'
EWebView::Initialize():
  error: undefined reference to 'switches::kTouchEvents'
EwkGlobalData::GetInstance():
  error: undefined reference to 'ui::OzonePlatform::InitializeForUI()'
VibrationProviderClientEwk::GetInstance():
  error: undefined reference to 'device::VibrationManagerImplEfl::RegisterProviderClient()'
efl::AppendPortParams(base::CommandLine&):
  error: undefined reference to 'gfx::kGLImplementationEGLName'
efl::AppendPortParams(base::CommandLine&):
  error: undefined reference to 'switches::kUseGL'
efl::AppendPortParams(base::CommandLine&):
  error: undefined reference to 'switches::kUIDisableThreadedCompositing'
RenderProcessObserverEfl::OnPurgeMemory():
  error: undefined reference to 'v8::Isolate::GetCurrent()'
RenderProcessObserverEfl::OnPurgeMemory():
 error: undefined reference to 'v8::Isolate::LowMemoryNotification()'

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Hyunhak Kim, arno renevier

Change-Id: Ic9355a57603aa8beadef51e999240dde90ad4906
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoRemove EvasParentViewMoveCallback callback
Arnaud Renevier [Fri, 19 Jun 2015 18:32:31 +0000 (11:32 -0700)]
Remove EvasParentViewMoveCallback callback

In SelectionControllerEfl, a callback is set in the constructor, but not
unset in the desctructor.

Because of that, I encountered a crash of the browser process when the
renderer process crashed. This shouldn't happen (the browser process
should survive the renderer process).

This patch fixes the issue.
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: If4c236c481c56351771de9c4fd24de95f0099695
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years ago[EWK_REFACTOR] bringup EWebViewCallbacks::ZoomStarted/ZoomFinished SmartCallback
hh4813.kim [Wed, 10 Jun 2015 11:08:00 +0000 (20:08 +0900)]
[EWK_REFACTOR] bringup EWebViewCallbacks::ZoomStarted/ZoomFinished SmartCallback

EWK_REFACTOR guards are removed for bringup ZoomStarted/ZoomFinished SmartCallback.
WebContentsViewEflDelegate::HandleZoomGesture is newly introduced to deliver zoom
gesture events to EWebView, so it can trigger ZoomStarted/ZoomFinished SmartCallback.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12028
Reviewed by: Antonio Gomes, DONGJUN KiM

Change-Id: I56fb07992f4e7b543cfe45b50f440c732a808a72
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
6 years agoMake vconf an external dependency for selection code (gbs builds).
Antonio Gomes [Thu, 18 Jun 2015 22:00:09 +0000 (15:00 -0700)]
Make vconf an external dependency for selection code (gbs builds).

This fixes the following error:
[XXs] tizen_src/chromium_impl/c/b/selection/selection_controller_efl.cc:95:
  error: undefined reference to 'vconf_notify_key_changed'

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, Hyunhak Kim, arno renevier

Change-Id: Id9e9ab9d1b2c334f4cc1aad9f45370112d119971
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoExport ui:SetScreenOrientation for component build
yh106.jung [Wed, 17 Jun 2015 02:53:12 +0000 (11:53 +0900)]
Export ui:SetScreenOrientation for component build

ui:SetScreenOrientation is needed by content
during component build, so export it.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, Hyunhak Kim, arno renevier

Change-Id: Ic50e5dd48b7221add1a685f88b8fe36ae19fad1e
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
6 years agoSave image doesn't work on context menu
Grzegorz Spryszynski [Thu, 18 Jun 2015 14:52:44 +0000 (16:52 +0200)]
Save image doesn't work on context menu

[Problem] Nothing happend after invoke 'Save image' command
from image context menu. No message, no image is saved.
[Cause] There was a change in files structure. There is no more
directory /opt/user/media/Images where Chromium trying to save
the files.
[Solution] Now images (and downloads) are kept in
/usr/data/data-media. Commit change proper paths.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13334

Reviewed by: Hyunhak Kim, Karol Furmaniak
Signed-off-by: Grzegorz Spryszynski <g.spryszynsk@samsung.com>
Change-Id: Ic2ba93cb353940724e2811a44cda9d72be875757

6 years ago[M40 Merge] Remove "unfocused" callback in context_menu
Karol Furmaniak [Thu, 12 Mar 2015 07:20:16 +0000 (16:20 +0900)]
[M40 Merge] Remove "unfocused" callback in context_menu

This is workaround patch before resolving by platform.

"unfocused" callback is called by immediately,
after context menu is shown up in latest platform.
At this time, context menu is hided.
We need to remove "unfocused" callback.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13199

Original patch: http://165.213.202.130/gerrit/#/c/77325/
Reviewed by: Hyunhak Kim, Piotr Grad, commitbot

Change-Id: Id0a5497f800af63c62604e05cc6148e7ca741823
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years ago[M40 Merge] Fixed form autofill popup position.
Karol Furmaniak [Mon, 2 Mar 2015 15:31:12 +0000 (16:31 +0100)]
[M40 Merge] Fixed form autofill popup position.

Autofill form data popup wasn't shown below input list.
It seems that position of webview hasn't been included
in AutofillManagerDelegateEfl::ShowAutofillPopup.
Adding it solves problem in both minibrowser and browser.

Original commit: http://165.213.202.130/gerrit/#/c/75975/
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12729
Reviewed by: Hyunhak Kim, Jaesik Chang, Karol Furmaniak, Piotr Grad, commitbot

Change-Id: Ib8df80ad5bbbb8f027ea73f85680913e7cb045cf
Signed-off-by: Michał Obrembski <m.obrembski@samsung.com>
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years agofixup! Composite frame to native surface directly on main thread.(impl part, optional)
Arnaud Renevier [Thu, 18 Jun 2015 19:31:46 +0000 (12:31 -0700)]
fixup! Composite frame to native surface directly on main thread.(impl part, optional)

We also need to remove dependency on switches::kDisableGpuThread.
Otherwise, we get a link error: undefined reference to
'switches::kDisableGpuThread'

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: Ic3f2b2c417d30dd4fb5bb95d1ded287b3c672374
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years ago[M42][Tizen 3.0] Delete processor directives for WRT
joke.song [Fri, 12 Jun 2015 08:00:23 +0000 (17:00 +0900)]
[M42][Tizen 3.0] Delete processor directives for WRT

[Issue]     N/A
[Problem]   Fix Mobile build error
[Cause]     There are processor directives using feature flags that are not supported on WRT
[Solution]  Delete processor directive
[Verify]    build and check

change-Id: I64c55213e0ac6eba2d2acc171f5fed0c3859624f
Signed-off-by: joke.song <joke.song@samsung.com>
6 years agoWrap GetContentClient() in GetContentClientExport()
Arnaud Renevier [Wed, 17 Jun 2015 22:11:28 +0000 (15:11 -0700)]
Wrap GetContentClient() in GetContentClientExport()

GetContentClient() is supposed to be used only in content module. But we
need it ewk too. For now, we simply add its declaration when needed. But
this wont't work any more for component build.

So we define a method GetContentClientExport() in content. That method
will simply return GetContentClient()

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: I696b6890c9113c1d981d8cdb9dbeb0ca3508d567
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agoBuild directly additory sources for ui modules during component build
yh106.jung [Wed, 17 Jun 2015 10:32:25 +0000 (19:32 +0900)]
Build directly additory sources for ui modules during component build

In static mode, we build additory sources that is needed
by efl-port as injectable static library.
However, in component mode, we build each of ui modules
as single DLL. So we include needed sources directly.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, Hyunhak Kim, arno renevier

Change-Id: I76dbb7348132ab83ccf363e86741d637f7a02716
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
6 years agocontent.gyp refactorisation
Arnaud Renevier [Wed, 17 Jun 2015 00:13:57 +0000 (17:13 -0700)]
content.gyp refactorisation

Content module is built as a single dll in component mode, but as
multiple targets in static mode. (see src/content/content.gyp). So, in
chromium, source files of content_browser, content_child,
content_common, content_efl, content_gpu and content_renderer are
defined in different files. This allows those lists to be included in
the two cases.

This patch reproduces this behaviour for our content module.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, Hyunhak Kim, arno renevier

Change-Id: I0a722d5d94e473a644991184117a82e047f728b6
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agoFix IME events handling
jiyoon.seol [Fri, 5 Jun 2015 07:19:50 +0000 (03:19 -0400)]
Fix IME events handling

When we try to insert text by virtual keyboard,
it is not operated normally.
Because commit text is not delivered to renderer process.
It is already implemented in m40 branch
(refer to http://suprem.sec.samsung.net/gerrit/#/c/2949/).
So, Implemented some functions that handle IME events in m42 branch.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13192
Reviewed by: Antonio Gomes, Hyunhak Kim, SeungSeop Park

Change-Id: I6034e72ad9c5ada53b90af0ad36914c4b9903308
Signed-off-by: jiyoon.seol <jiyoon.seol@samsung.com>
6 years agoMove --depth definition to gyp_chromium.sh
Antonio Gomes [Wed, 17 Jun 2015 20:13:03 +0000 (13:13 -0700)]
Move --depth definition to gyp_chromium.sh

Both gyp_chromiumefl and gyp_xwalk need to define
GYP's argument "--depth" in order to be able to "locate"
"src" directory.
As it is, gyp_chromiumefl does it, but gyp_xwalk does not.

Patch moves the --depth definition done in gyp_chromiumefl
up to gyp_chromiumefl.sh, so that gyp_xwalk can also benefit
from it

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: Antonio Gomes, SeungSeop Park, arno renevier

Change-Id: Ia15653438e5620993c42ef1505f89cbedbee3c9b
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoVarious exports
Arnaud Renevier [Wed, 17 Jun 2015 21:58:02 +0000 (14:58 -0700)]
Various exports

Export all the methods and classes which are needed to build ewk

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: I054b9897f7f51596ee70d05f9945f0ea2c85d13a
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agofixup! Implement Delegate renderer using frame buffer object on Tizen.
Chandan Padhi [Wed, 17 Jun 2015 13:43:21 +0000 (19:13 +0530)]
fixup! Implement Delegate renderer using frame buffer object on Tizen.

Currently, segmentation fault occurs if a new page is loaded on top of an
already loaded page. In this scenario, current RWHVEfl is destroyed and a
new RWHVEfl is created. In delegated rendering, ui::ContextFactoryEfl and
ui::Compositor are created as scoped pointers with ContextFactoryEfl being
created before Compositor. Destruction of scoped pointers takes place in the
same order as their creation. Therefore, ContextFactoryEfl gets deleted before
Compositor even though Compositor holds a reference to ContextFactoryEfl.
Crash occurs when Compositor tries to access ContextFactoryEfl which has been
already deleted.

To solve this problem, we now create ContextFactoryEfl and Compositor as raw
pointers and delete them in RWHVEfl's destructor in the required order.
Reviewed by: DaeHyun Ko, Prashant Nevase, venu musham

Change-Id: I5172342df43fde49f71750b9752588e242380cf2
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
6 years agoExport ClipboardHelperEfl for component build
yh106.jung [Wed, 17 Jun 2015 11:20:18 +0000 (20:20 +0900)]
Export ClipboardHelperEfl for component build

ClipboardHelperEfl is needed by Content module
during component build.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, Hyunhak Kim, arno renevier

Change-Id: I894b6f1ac46bfb1674aa354a194272e777ee69fc
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
6 years agoExport GLSharedContextEfl and GetTextureIdFromTexture
Arnaud Renevier [Wed, 17 Jun 2015 19:02:17 +0000 (12:02 -0700)]
Export GLSharedContextEfl and GetTextureIdFromTexture

GLSharedContextEfl and GetTextureIdFromTexture are needed by content
during component build, so export them.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: Ia32f7363bb57c3284517c9d4d6f6044fdad7ac0a
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agoUse GYP_GENERATOR_FLAGS instead of GYP_GENERATOR_OUTPUT
Antonio Gomes [Wed, 17 Jun 2015 16:27:01 +0000 (09:27 -0700)]
Use GYP_GENERATOR_FLAGS instead of GYP_GENERATOR_OUTPUT

As it is, gyp_chromiumefl makes use of the value set to
GYP_GENERATOR_OUTPUT variable in order to determine
the 'out' directory name to output ninja content.
Differently, gyp_walk makes use of GYP_GENERATOR_FLAGS
for the same.
That difference makes it erroneous to call gyp_xwalk from
gyp_chromiumefl.sh, something that we want to be able to do
as part of our crosswalk-libs/bin packaging seperation (see
bug 13316).

In order to allow both gyp_xwalk and gyp_chromiumefl to
be invoked from gyp_chromiumefl.sh, patch changes the later
to use GYP_GENERATOR_FLAGS to determine the gyp output
directory name.
For gyp_chromiumefl, patch is a refactor only. For crosswalk,
it allows gyp_xwalk to be called by gyp_chromiumefl.sh.

Note that "GetOutputDirectory" function that replaces
"get_output_dir" is identical to xwalk/gyp_xwalk and
build/gyp_chromium.

Reviewed by: SeungSeop Park, arno renevier
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Change-Id: I9fef8a5b904c12dd1431593beeafc0a632adff90

6 years agoRemoving required rpm 'location'
Youngsoo Choi [Wed, 17 Jun 2015 01:38:09 +0000 (10:38 +0900)]
Removing required rpm 'location'

The rpm 'location' does not need to be required in spec file.

The 'location' should be required by 'capi-location-manager'
and 'capi-location-manager' is required by 'chromium-efl'.

This change has been requested by platform team.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13323
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: I41dca69440b1e4308a35cff13cebe885231ecf56
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
6 years agoMove selection code into content/ module.
Arnaud Renevier [Tue, 16 Jun 2015 23:31:51 +0000 (16:31 -0700)]
Move selection code into content/ module.

Currently, selection code (SelectionBoxEfl, SelectionControllerEfl,
SelectionHandleEfl and SelectionMagnifierEfl) are into ui/base
directory.

But those objects are used in content and are even defined in namespace
content. So those files definitely belong in content/ module.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: Iae3f7e76978223cec4d5925c915d0fb529e1290c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years ago[tizen v3.0] Removing spec configuration for architecture 'arm64-x11'
Youngsoo Choi [Wed, 17 Jun 2015 05:32:04 +0000 (14:32 +0900)]
[tizen v3.0] Removing spec configuration for architecture 'arm64-x11'

The repository 'arm64-x11' has been deprecated on Tizen v3.0,
and the architecture 'aarch64' is supportive on the repository 'arm64-wayland'.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13326
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: Ib2e9194a0ad992084b9af59ef44998f45882b032
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
6 years agofixup! Composite frame to native surface directly on main thread.(impl part, optional)
YongGeol Jung [Mon, 15 Jun 2015 11:05:34 +0000 (20:05 +0900)]
fixup! Composite frame to native surface directly on main thread.(impl part, optional)

We avoid using content::GpuDataManagerImpl::GetInstance() in ui
If we try to build chromium with shared component, this won't work. We
would need to add a gyp dependency on content_browser ui:compositor. But
that would result in a cyclic dependency. So, the only way is to have
ui:compositor not depend on content_browser, and therefore, not using
content::GpuDataManagerImpl

Reviewed by: KwangHyuk Kim, Prashant Nevase, SeungSeop Park
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Change-Id: Ief76bcfebfb4350dbb965aad3997c82a1017b11f
Signed-off-by: YongGeol Jung <yg48.jung@samsung.com>
6 years agofixup! [MM] Enabling CAPI for ME
ws29.jung [Fri, 12 Jun 2015 07:15:10 +0000 (16:15 +0900)]
fixup! [MM] Enabling CAPI for ME

Resolves muted start.

Previously, SetVolume function refused to set volume when player state is
PLAYER_STATE_IDLE but actual precondition accept idle state to set volume.
Also player_set_mute is removed from SetVolume because mute state is
actually handled at Webkit side.
Reviewed by: SeungSeop Park, Venugopal S M

Change-Id: I3717bb653e5003670c1d05980b6a2c90ca3293a9
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
6 years agoCrash when select context menu item.
Karol Furmaniak [Tue, 16 Jun 2015 11:36:23 +0000 (13:36 +0200)]
Crash when select context menu item.

[Problem]: Long press on text in input field. Choose "Select"
from context menu. Browser will crash.

[Cause]: ContextMenuControllerEfl::HideContextMenu was called
when ContextMenuControllerEfl instance was already destroyed.

[Solution]: Avoid calling HideContextMenu after MenuItemSelected
call in ContextMenuItemSelectedCallback. There can be
ContextMenuControllerEfl scoped_ptr already reseted.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=12741
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: I96eadc48be555354fb14c46b76d142f46d79dcdc
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
6 years agofixup! Implement CAPI-ME port using media_packet and appsink
Umesh Kumar Patel [Mon, 15 Jun 2015 10:38:10 +0000 (16:08 +0530)]
fixup! Implement CAPI-ME port using media_packet and appsink

Video format information is not updated due to which green
screen is observed while trying to play video using ME.

Also fixed build warning issues.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13311
Reviewed by: SeungSeop Park, Venugopal S M

Change-Id: I4530e9c01b2b07ff0b1f9837c3fb49f1400dc797
Signed-off-by: Umesh Kumar Patel <umeshk.patel@samsung.com>
6 years agoRemove duplicate BuildRequires in chromiums-efl.spec
Arnaud Renevier [Tue, 16 Jun 2015 20:49:12 +0000 (13:49 -0700)]
Remove duplicate BuildRequires in chromiums-efl.spec

6 packages are currently referenced twice in the spec file. This patch
cleans that up
Reviewed by: Antonio Gomes, SeungSeop Park, arno renevier

Change-Id: I76e5dc817dd754eb0affa7e1217bc9b4e2ea5607
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agofixup! Disable Pango
Arnaud Renevier [Mon, 15 Jun 2015 18:26:04 +0000 (11:26 -0700)]
fixup! Disable Pango

Disable cairo in addition to Pango

While disabling pango and not cairo builds currently, it doesn't allow
building with shared component. src/build/linux/system.gyp has a single
target pangocairo. It's difficult to untangle pango and cairo in
chromium build system.

Cairo is only used in BitmapPlatformDevice (in src/skia/ext). We don't
use cairo here. For screenshot for example, we use skia for
BitmapPlatformDevice.

So, it's probably safe to disable cairo. The alternatives are either to
modify chromium build system to disentangle cairo and pango, or to
revert the the Disable Pango patch for the moment.

Also, we had a dependency to fontconfig. fontconfig is used in content/
But after disabling pango and cairo, fontcongig dependency is not
computed by gyp for non aura builds. We could fix that by modifying
src/content/content_browser.gypi, but it's easier and less troublesome
to maintain to add the dependency in our gyp files.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13279
Reviewed by: Antonio Gomes, DaeHyun Ko

Change-Id: I277b98a236a0935a7f14958d51eef8b0426429b3
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agoDifferent build fixups for ozone
Arnaud Renevier [Fri, 12 Jun 2015 22:39:51 +0000 (15:39 -0700)]
Different build fixups for ozone

Different things which are needed to build chromium-efl with shared
components

- Export CreateOzonePlatformEfl
- Add different gyp dependencies
- make media depend on ozone_efl even if tizen_multimedia_support is
  not set

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: I08857a428329ae60ede8dfcd90c1ae9280ae8a40
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agoEnable Tile compression.
venu.musham [Fri, 12 Jun 2015 17:10:12 +0000 (22:40 +0530)]
Enable Tile compression.

Enable by default ETC1 compression method for tiles. This commit
disables gpu rasterization which is enabled partially based on
meta tag. Tile compression cannot be enabled with gpu rasterization.

Memory Details:
--------------------------------
| Without patch:               |
--------------------------------
|   page       |  PSS  |  3D   |
--------------------------------
| Google suwon | 52421 | 22272 |
--------------------------------
| naver.com(d) | 80077 | 23552 |
--------------------------------

--------------------------------
| With Tile Compression:       |
--------------------------------
|   page       |  PSS  |  3D   |
--------------------------------
| Google suwon | 48100 | 14205 |
--------------------------------
| naver.com(d) | 73632 | 14592 |
--------------------------------
Reviewed by: DaeHyun Ko, Prashant Nevase

Change-Id: I1c6b7b5baa9e28cfbdd206b6ae1c0ed9b82da7b2
Signed-off-by: venu.musham <venu.musham@samsung.com>
6 years agoFlag to build chromium with shared components
Arnaud Renevier [Fri, 12 Jun 2015 22:38:52 +0000 (15:38 -0700)]
Flag to build chromium with shared components

Add --component-build to create a component build of chromium-efl
(desktop only for now)

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: Ifb5728b366a08180fde120e3111398260ea69c45
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agoExplicitly depend on vconf for 'device_battery' target
Antonio Gomes [Mon, 15 Jun 2015 18:24:20 +0000 (11:24 -0700)]
Explicitly depend on vconf for 'device_battery' target

While working on the packaging separation for crosswalk
integration on tizen.org, the build type used is
component=shared_library, which reveals some gaps we have
currently in our (static linked) build system.

our 'injected' code into device_battery target
depends explictly on vconf, but target misses
to 'inject' the dependency.

Patch fixes it.

PS: Problem does not manifest on static linked builds

Error:
[ Xs] tizen_src/chromium_impl/device/battery/battery_status_manager_tizen.cc:154:
      error: undefined reference to 'vconf_ignore_key_changed'
[ Xs] tizen_src/chromium_impl/device/battery/battery_status_manager_tizen.cc:197:
      error: undefined reference to 'vconf_get_int'
[ Xs] tizen_src/chromium_impl/device/battery/battery_status_manager_tizen.cc:27:
      error: undefined reference to 'vconf_keynode_get_name'

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13316
Reviewed by: SeungSeop Park, arno renevier

Change-Id: Ie586692fd5b943ba3ccdd0ee1ca69942f3a1d381
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoUse mobile viewport style for tizen mobile.
yh106.jung [Tue, 12 May 2015 15:46:14 +0000 (17:46 +0200)]
Use mobile viewport style for tizen mobile.

This patch enables usage of mobile optimized viewport style when
compiling the code for Tizen Mobile. To make it also testable on desktop
the patch adds additional command line flag, use-mobile-viewport-style
which can control the property from command line. This allows
applications like ubrowser to enable such mobile specific features on
desktop when started with --mobile flag.

It's an alternative to M40 solution found in
http://165.213.202.130/gerrit/#/c/75686/. Compared to the original this
patch uses a setting that was exposed by blink in M43. The patch was also
backported to M42 in order to simplify future updates.

Original author: Piotr Tworek

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10317
Reviewed by: Antonio Gomes, Hyunhak Kim, SeungSeop Park, Youngha Jung

Change-Id: I513c9a441404c5ab09b3d94660787cf362d23e82
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
6 years ago[M40 Merge] Use MessagePumpGlib as the default backend for renderer main thread
yh106.jung [Mon, 8 Jun 2015 04:30:46 +0000 (13:30 +0900)]
[M40 Merge] Use MessagePumpGlib as the default backend for renderer main thread

Current implementation of WRT plugins run inside renderer process main thread.
The plugins use external libraries that require working glib message pump (MessagePumpGlib).
But use_glib is disabling on Ozone platform because of
some small embedded system that do not provide glib.
In order to use glib message pump on Ozone platform, add use_glib=1 as supplement.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=6116

Together with: Ibd9620a439f402fccd4bc6538ad22d3d32236eba
Reviewed by: Antonio Gomes, Hyunhak Kim, Piotr Grad, SeungSeop Park, arno renevier

Change-Id: I6a942d0415695348854c2d8fd3046fe3c91de8a2
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years agoSimplify SurfaceFactoryEfl::LoadEGLGLES2Bindings
Arnaud Renevier [Fri, 12 Jun 2015 22:38:33 +0000 (15:38 -0700)]
Simplify SurfaceFactoryEfl::LoadEGLGLES2Bindings

There is actually a function ui::LoadDefaultEGLGLES2Bindings which does
exactly what we need. We can use it, and delete most of
surface_factory_efl.cc

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13303
Reviewed by: Antonio Gomes, Hyunhak Kim

Change-Id: I1fb8492d9be64190dd9e0b6f29c4f89ed025f44d
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
6 years agoMove exclusions out of supplement.gypi
Antonio Gomes [Fri, 12 Jun 2015 18:07:07 +0000 (11:07 -0700)]
Move exclusions out of supplement.gypi

Patch cleans up supplement.gypi by moving exclusions
related to wayland_bringup to the targets they
belong to.

No functional difference intended.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12490
Reviewed by: Balazs Kelemen, arno renevier

Change-Id: I6e442729a182f133292145f916982568ecc8d825
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
6 years ago[EWK_REFACTOR] bringup QuerySelectionStyle for efl_delegate_
hh4813.kim [Tue, 9 Jun 2015 12:57:38 +0000 (21:57 +0900)]
[EWK_REFACTOR] bringup QuerySelectionStyle for efl_delegate_

EWK_REFACTOR guards are removed for bringup QuerySelectionStyle
in SelectionControllerEfl. It triggers EWebViewCallbacks::TextStyleState
via EWebView::OnQuerySelectionStyleReply,

So QuerySelectionStyle is only required in case that WebContentsViewEfl
has valid efl_delegate_.

Also RenderWidgetHostViewEfl::ExecuteEditCommand is removed since it's
not required any more.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12549
Reviewed by: Antonio Gomes, Karol Furmaniak, Piotr Grad

Change-Id: I4619e2d14a62a5d1c0666c0a6879b9d17a4cc515
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
6 years agoDisable Pango
p.niemirski [Fri, 12 Jun 2015 15:00:28 +0000 (17:00 +0200)]
Disable Pango

Since Pango library is only used to get font list (involving Cairo)
and this functionality is implemented by Chrome Extensions there is
no need to link libchromium against Pango for TIZEN.

This patch is based on http://165.213.202.130/gerrit/#/c/77249/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=13279
Reviewed by: Antonio Gomes, DaeHyun Ko

Change-Id: I5054b939b8e948167e46ada21a86c105ba12a9ce
Signed-off-by: p.niemirski <p.niemirski@samsung.com>
6 years agoComposite frame to native surface directly on main thread.(impl part, optional)
YongGeol Jung [Thu, 16 Apr 2015 07:40:49 +0000 (16:40 +0900)]
Composite frame to native surface directly on main thread.(impl part, optional)

This is experimental patch.
The purpose of this patch is checking possibility
whether gpu commands could be executed on main thread or not.
(with http://165.213.202.130/gerrit/#/c/81008/)
Reviewed by: KwangHyuk Kim, Prashant Nevase

Change-Id: Idbd6c642a78c1fbe58c84e539fb0f25a9ce5fcb6
Signed-off-by: YongGeol Jung <yg48.jung@samsung.com>
6 years agofixup! [EWK_REFACTOR] Get orientation from native window, not ewebview
yh106.jung [Wed, 10 Jun 2015 12:12:52 +0000 (21:12 +0900)]
fixup! [EWK_REFACTOR] Get orientation from native window, not ewebview

Native screen sent invalid orientation, it always returned 0.
So set orientation value once app informs to WebCotentsViewEfl.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13156
Reviewed by: Antonio Gomes, Hyunhak Kim, SeungSeop Park, arno renevier

Change-Id: Iee806175b3616d31188687f0dafd2dabc0fb1cb6
Signed-off-by: yh106.jung <yh106.jung@samsung.com>