Matthew Netsch [Wed, 16 Nov 2022 21:01:09 +0000 (13:01 -0800)]
Fixes barycentric test float64 support check
Barycentric tests were not checking shaderFloat64 check
Components: Vulkan
VK-GL-CTS Issue: 4112
Affects:
dEQP-VK.fragment_shading_barycentric.*double*
Change-Id: Ie31ab9998e6bd9a8f551d4906f7cbda7417ea94b
Matthew Netsch [Thu, 17 Nov 2022 20:32:24 +0000 (20:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Ib92b3d3b2282186df729d4694083ccaec6e3c525
Lionel Landwerlin [Sun, 16 Oct 2022 23:09:01 +0000 (01:09 +0200)]
Fix color blend state color attachments in depth tests
The number of color attachments in pColorBlendState must match the
number of color attachments in the subpass when creating the pipeline
Components: Vulkan
VK-GL-CTS issue: 4058
Affected tests:
dEQP-VK.pipeline.*.depth.*
dEQP-VK.pipeline.*.stencil.*
Change-Id: Id2c911dc88c4169a9c800b4a1ff7d505bec91234
Matthew Netsch [Thu, 17 Nov 2022 18:32:21 +0000 (18:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I2550c13c4df05f75c68a39aef76c1b9a032cfb94
James Fitzpatrick [Mon, 14 Nov 2022 09:51:50 +0000 (09:51 +0000)]
Enable VK_*_global_priority before using it
A number of tests were testing functionality from
VK_EXT_global_priority and VK_KHR_global_priority without first
enabling the extension.
Affects: dEQP-VK.api.device_init.create_device_global_priority*
Components: vulkan
VK-GL-CTS issue: 4107
Change-Id: Ib6fc36a8602f544b945fad2f5bfec3c2f8bcd72c
Matthew Netsch [Thu, 17 Nov 2022 18:07:49 +0000 (18:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I7cc1f00c66d75b85505ee76301f437ba878e5683
Matthew Netsch [Thu, 17 Nov 2022 17:39:42 +0000 (17:39 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Ifffbd3aecc8e2d066ed988ed8fc5af4210aa88da
ziga-lunarg [Fri, 4 Nov 2022 20:22:22 +0000 (21:22 +0100)]
Add missing check for rgba10x6 features
Feature formatRgba10x6WithoutYCbCrSampler must be supported if image is
created with format VK_FORMAT_R10x6G10X6B10X6A10X6_UNORM_4PACK16 and
level count is greater than 1
Components: Vulkan
VK-GL-CTS issue: 3992
Affected tests:
dEQP-VK.pipeline.image_view.view_type.*.format.*
Change-Id: I63f7d2083ea85d9f6232540d72178bd8172b13d5
Matthew Netsch [Thu, 17 Nov 2022 17:12:03 +0000 (17:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I571894bfd5fc1ab88a09272d7452522bce76165d
Christopher Hambacher [Fri, 11 Nov 2022 20:17:58 +0000 (14:17 -0600)]
Fix failed memory map check for reconvergence tests
Tests are checking for ResourceError, when a failed memory map will return TestError.
Components: Vulkan
VK-GL-CTS issue: 4100
Affected tests:
dEQP-VK.reconvergence.*
Change-Id: I61fcc9f29fe19ff592b74986ac39a7e3958f06e8
Ricardo Garcia [Tue, 15 Nov 2022 15:07:16 +0000 (16:07 +0100)]
Limit number of concurrent query pools
The max concurrency tests use a heuristic to try to estimate a safe
number of objects of different types that the implementation would be
able to create, with an upper limit of 16384 objects.
However, in some implementations the creation of these objects have
external limitations that make the safe value hard to guess by only
looking at system and device memory usage. For example, the kernel
driver may impose further limits on the total number of certain objects.
This is reflected in the current tests with some lower hardcoded limits
for some types of objects, like instances, devices, synchronization
primitives and pipeline caches.
This commit halves the limit of concurrent query pools being tested to a
value that doesn't trigger any issue in the Mesa RPi drivers.
Affects:
dEQP-VK.api.object_management.max_concurrent.query_pool
VK-GL-CTS issue: 4106
Components: Vulkan
Change-Id: If88c6aa1ecd3d9c18892b38cb55907a82eee6cf8
Matthew Netsch [Wed, 17 Aug 2022 19:35:23 +0000 (19:35 +0000)]
Reintroduce tests for acceleration structure size query
VK-GL-CTS Issue: 3836
Components: Vulkan
Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.*.*.*.structure_size
Change-Id: Ie6d5bb49ef25f8066c83606d8307ebadb195f1a9
Matthew Netsch [Thu, 10 Nov 2022 22:07:01 +0000 (22:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: If6c415f4dddeb997b23aba4075f9608b2c99ddb8
ziga-lunarg [Sun, 16 Oct 2022 23:09:01 +0000 (01:09 +0200)]
Fix color blend state color attachments in depth tests
The number of color attachments in pColorBlendState must match the
number of color attachments in the subpass when creating the pipeline
Components: Vulkan
VK-GL-CTS issue: 4058
Affected tests:
dEQP-VK.pipeline.*.depth.*
Change-Id: I1b566bd4aec80873631fe1edbb2ced47441c877a
ziga-lunarg [Sun, 16 Oct 2022 22:08:53 +0000 (00:08 +0200)]
Add missing image memory barrier in ray tracing pipeline tests
Image layout transition from VK_IMAGE_LAYOUT_UNDEFINED to
VK_IMAGE_LAYOUT_GENERAL is missing
Components: Vulkan
VK-GL-CTS issue: 4056
Affected test:
dEQP-VK.ray_tracing_pipeline.pipeline_no_null_shaders_flag.*
Change-Id: I6c969985061b1c3e165148da24f899d5a7607e2a
Sławomir Cygan [Fri, 14 Oct 2022 10:55:48 +0000 (12:55 +0200)]
Fix compressed texture tests always returning Pass
The test, if supported, was always returning Pass
disregarding the texture comparison result.
Affects: dEQP-VK.texture.compressed.*
VK-GL-CTS Issue: 4040
Components: Vulkan
Authored-by: Dorian R Apanel <dorian.r.apanel@intel.com>
Change-Id: I1da7204d248af3f6122f3acbe412980a86f6a403
Matthew Netsch [Thu, 10 Nov 2022 19:32:44 +0000 (19:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: Ide448246c50fedae41f37859022c20fffa764a1c
ziga-lunarg [Sun, 16 Oct 2022 17:34:09 +0000 (19:34 +0200)]
Enable minLod feature when used
The tests use VkImageViewMinLoadCreateInfoEXT::minLod, but do not enable
the minLod feature
Components: Vulkan
VK-GL-CTS issue: 4052
Affected tests:
dEQP-VK.texture.mipmap.3d.image_view_min_lod.min_lod.*
Change-Id: I2bf99e7543d3ebb799d50ac5f644cc2e12d535e2
Matthew Netsch [Thu, 10 Nov 2022 19:08:10 +0000 (19:08 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I1e2379907371708b4f3fb556938acb39f3f2f5bc
ziga-lunarg [Fri, 14 Oct 2022 21:03:32 +0000 (23:03 +0200)]
Fix wrong format in unused clear attachment tests
VkPipelineRenderingCreateInfo::depthAttachmentFormat must be a format
that includes a depth aspect or VK_FORMAT_UNDEFINED
VkPipelineRenderingCreateInfo::stencilAttachmentFormat must be a format
that includes a stencil aspect or VK_FORMAT_UNDEFINED
Components: Vulkan
VK-GL-CTS issue: 4041
Affected tests: dEQP-VK.dynamic_rendering.*.unused_clear_attachments.*
Change-Id: I8b003dd2a831e9205f6f91ea00c3ddf2541b512a
Matthew Netsch [Thu, 10 Nov 2022 18:39:54 +0000 (18:39 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I9f9902ca38ce71e194a12f5aacff73afaaa37972
Ricardo Garcia [Fri, 21 Oct 2022 14:19:52 +0000 (16:19 +0200)]
Add missing checks for geometry shader support
Affects:
dEQP-VK.multiview.*geometry*
dEQP-VK.subgroups.*geometry*
dEQP-VK.fragment_shading_rate.*.gs*
VK-GL-CTS issue: 4064
Components: Vulkan
Change-Id: I64a3b6d7adc8da7671817710c4a4882db2c27035
ziga-lunarg [Sat, 15 Oct 2022 00:03:25 +0000 (02:03 +0200)]
Add missing read without format bit check in robustness tests
If buffer view is being read as storage texel buffer with image format
of OpTypeImage being Unknown then the view's buffer features must
contain VK_FORMAT_FEATURE_2_STORAGE_READ_WITHOUT_FORMAT_BIT
Components: Vulkan
VK-GL-CTS issue: 4047
Affected tests:
dEQP-VK.robustness.robustness2.bind.*
Change-Id: I46e5482fbfea3a945b133dbca0e020159049516f
ziga-lunarg [Fri, 14 Oct 2022 23:24:43 +0000 (01:24 +0200)]
Fix stencilAttachmentFormat in inverted depth ranges tests
If format is not VK_FORMAT_UNDEFINED in
VKPipelineRenderingCreateInfo::stencilAttachmentFormat then it must be a
format that includes a stencil aspect
Components: Vulkan
VK-GL-CTS issue: 4046
Affected tests:
dEQP-VK.draw.dynamic_rendering.inverted_depth_ranges.*
Change-Id: Ia0dcb1989b8ace78632d26dd0a1e3c1101f5f547
Matthew Netsch [Thu, 10 Nov 2022 18:12:22 +0000 (18:12 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I46781852d8da0c1c3d65c9435cf93cd05ce1781b
ziga-lunarg [Sun, 16 Oct 2022 22:42:52 +0000 (00:42 +0200)]
Fix viewport width in FSR with multiviewport tests
Tests with extent 1x1 create viewport with width equal to 0.0f
Components: Vulkan
VK-GL-CTS issue: 4057
Affected tests:
dEQP-VK.fragment_shading_rate.*
Change-Id: I99a050348de83d1790320bd5d6d711722dd1fbaf
ziga-lunarg [Sat, 15 Oct 2022 19:51:22 +0000 (21:51 +0200)]
Fix image barrier oldLayout in timeline semaphore tests
Image layout in image barrier must be updated after first transition
Components: Vulkan
VK-GL-CTS issue: 4049
Affected tests:
dEQP-VK.synchronization.timeline_semaphore.one_to_n.*
Change-Id: I7fde2342007a3ec9c2562375fd634539e186acdc
ziga-lunarg [Sun, 16 Oct 2022 19:45:02 +0000 (21:45 +0200)]
Fix barrier in ray tracing pipeline build tests
If access mask is VK_ACCEDSS_ACCELERATION_STRUCTURE_WRITE_BIT_KHR then
stage must be VK_PIPELINE_STAGE_ACCELERATION_STRUCTURE_BUILD_BIT_KHR
Components: Vulkan
VK-GL-CTS issue: 4053
Affected tests:
dEQP-VK.ray_tracing_pipeline.build.*
Change-Id: I0a8080881f944319aae2417e5f9fe3297b933dd7
ziga-lunarg [Sun, 16 Oct 2022 01:50:25 +0000 (03:50 +0200)]
Fix pMutableDescriptorTypeLists in mutable descriptor tests
pMutableDescriptorTypeLists between srcBinding and dstBinding must match
exactly for copying descriptor sets
Components: Vulkan
VK-GL-CTS issue: 4051
Affected tests:
dEQP-VK.binding_model.mutable_descriptor.*
Change-Id: I64445e84ccd4872789a3db8b15e005d36c08d8a4
Hyunjun Ko [Fri, 21 Oct 2022 00:27:05 +0000 (09:27 +0900)]
Fix to reset dynamicDenstiyMap after dynamic subsampled tets done.
Affects:
dEQP-VK.*.fragment_density_map.*.static_nonsubsampled*
dEQP-VK.*.fragment_density_map.*.deferred_nonsubsampled*
VK-GL-CTS Issue: 4062
Components: Vulkan
Change-Id: Ib347bd6e4734b2928ccacfa17dd01dfc134301bb
ziga-lunarg [Fri, 14 Oct 2022 22:53:12 +0000 (00:53 +0200)]
Fix flush memory range in ssbo corner case tests
The size in VKMappedMemoryRange used in vkFlushMappedMemoryRanges must
either be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or
offset + size must be equal to the size of memory
Components: Vulkan
VK-GL-CTS issue: 4044
Affected tests:
dEQP-VK.ssbo.corner_case.*
Change-Id: I9ea2ee1e055b55ec39988a6ec0539cd3219937f4
ziga-lunarg [Fri, 14 Oct 2022 23:11:59 +0000 (01:11 +0200)]
Fix flush memory range in robustness vertex access tests
The size in VkMappedMemoryRange used in vkFlushMappedMemoryRanges must
either be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or
offset + size must be equal to the size of memory
Components: Vulkan
VK-GL-CTS issue: 4045
Affected tests:
dEQP-VK.robustness.vertex_access.r32_sint.draw.*
Change-Id: I3d0944b6c6808dc66de0c9dc25f6c4e99578a1cf
ziga-lunarg [Sat, 15 Oct 2022 22:05:50 +0000 (00:05 +0200)]
Add shader image atomic int64 extension if used when creating device
Add VK_EXT_shader_image_atomic_int64 extension and enabled the features
when creating the device in sparse resources tests if the extension
is used
Components: Vulkan
VK-GL-CTS issue: 4050
Affected tests:
dEQP-VK.sparse_resources.*
Change-Id: If3de1d1e30a57db076802e2933392081c7c3069c
ziga-lunarg [Fri, 14 Oct 2022 22:30:38 +0000 (00:30 +0200)]
Fix attachment description in explicit vertex parameter tests
If initialLayout is VK_IMAGE_LAYOUT_UNDEFINED then loadOp must not be
VK_ATTACHMENT_LOAD_OP_LOAD
Components: Vulkan
VK-GL-CTS issue: 4043
Affected tests:
dEQP-VK.draw.explicit_vertex_parameter.*
Change-Id: I94cd72967798d424081f13033d1afbb3e11d993b
ziga-lunarg [Tue, 11 Oct 2022 15:38:01 +0000 (17:38 +0200)]
Add missing flag in ray tracing with queries tests
Command buffer is reused but it is allocated from a command pool that
did not have VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT flag
Components: Vulkan
VK-GL-CTS issue: 4033
Affected tests:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.*
Change-Id: I68888c2a08647e9d77122e5888aba8f66d849f11
Matthew Netsch [Thu, 27 Oct 2022 19:04:07 +0000 (19:04 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Iaf15595051e9e11e259a92c75d74f45881131dd7
Iván Briano [Tue, 18 Oct 2022 21:50:40 +0000 (14:50 -0700)]
Fix using NULL for the default color blend state
Since graphics pipeline libraries was merged, we need to explicitly ask
for NULL to mean the default state when creating a pipeline.
Components: Vulkan
VK-GL-CTS issue: 4061
Affected tests:
dEQP-VK.pipeline.*stencil.*
Change-Id: If09ad15322cbc7e39ba4ae9c4cf9825ff131cd46
ziga-lunarg [Tue, 11 Oct 2022 22:12:04 +0000 (00:12 +0200)]
Fix independent_pipeline_layout_sets tests
These bugs are already fixed in the main branch, but not in others
Invalid pipeline stages are used in pipeline barriers and wrong vertex
binding and description counts
Components: Vulkan
VK-GL-CTS issue: 4035
Affected tests:
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.independent_pipeline_layout_sets.*
Change-Id: I4c68ac57bd616cdbc2147d725d5b6ea1d6874d90
Matthew Netsch [Thu, 27 Oct 2022 18:31:37 +0000 (18:31 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I175ea10a0a7a64890834267adfc74ec62fee48d3
ziga-lunarg [Wed, 21 Sep 2022 01:38:41 +0000 (03:38 +0200)]
Fix VK_KHR_global_priority tests
Support for priorities must be queries and if a priority is used but not
reported by VkQueueFamilyGlobalPriorityPropertiesKHR the driver must
fail with VK_ERROR_INITIALIZATION_FAILED
Components: Vulkan
VK-GL-CTS issue: 3898
Affected tests:
dEQP-VK.api.device_init.create_device_global_priority*
Change-Id: I5570006758e73522968a2399a2a4294588b2dde5
Matthew Netsch [Thu, 27 Oct 2022 18:07:00 +0000 (18:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I96317661558490598f309c45bc9a6d040b937d13
Matthew Netsch [Thu, 27 Oct 2022 17:38:34 +0000 (17:38 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I4b3c2c0c9e8185a634b8917faa9b67cd97469fe7
Matthew Netsch [Thu, 27 Oct 2022 17:10:48 +0000 (17:10 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I398ca9776ea24153af3f5cc4bd4db4812333d76a
ziga-lunarg [Mon, 10 Oct 2022 22:39:37 +0000 (00:39 +0200)]
Fix loadOp in imageless framebuffer test
If initial layout in attachment descriptions is
VK_IMAGE_LAYOUT_UNDEFINED, then the load op must not be
VK_ATTACHMENT_LOAD_OP_LOAD
Components: Vulkan
VK-GL-CTS issue: 4030
Affected tests:
dEQP-VK.imageless_framebuffer.*
Change-Id: I5e7f3f5e440dd380a05cf82127af4bea2538fdd2
Tapani Pälli [Wed, 5 Oct 2022 16:59:48 +0000 (19:59 +0300)]
Choose optimal tiling with dmabuf in synchronization tests.
This is revert of commit
55027ea63. Problem is that while that change
caused coverage to raise on some drivers it decreased coverage on
others. Ideally this will be written in more dynamic way as a
follow-up work so that everyone could have coverage with these
tests.
Component: Vulkan
Affects: dEQP-VK.synchronization.cross_instance*
VK-GL-CTS issue: 2887
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: I252c87ccd1870067417166bf1a4ba769a153105f
ziga-lunarg [Sun, 16 Oct 2022 21:07:41 +0000 (23:07 +0200)]
Fix memory binding tests
Wrong size is used in results verification
Components: Vulkan
VK-GL-CTS issue: 4055
Affected tests:
dEQP-VK.memory.binding.*
Change-Id: I3325070d5173dfcc469b2d836616f79a0777d8e4
ziga-lunarg [Sun, 2 Oct 2022 19:45:08 +0000 (21:45 +0200)]
Fix cull distance tests without fragment shader read
These tests were supposed to test using gl_cullDistance but removing
those writes from shaders did not affect the tests passing
If fragment shader does not read cull distances the tests will now set a
cull plane and check the number of fragments culled
Components: Vulkan
VK-GL-CTS issue: 3502
Affected tests:
dEQP-VK.clipping.user_defined.clip_cull_distance.*
Change-Id: I5ea3d95cc14da934994db2b41aa22fa386570d70
Matthew Netsch [Fri, 14 Oct 2022 17:47:41 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: Ie7b88a8cc79fcca867ba4d2d16005f88e848c981
Matthew Netsch [Fri, 14 Oct 2022 17:47:32 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I4e09eb19ac33ab340c6b7b0369f98b6b25257231
Matthew Netsch [Fri, 14 Oct 2022 17:47:16 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: Id2c911dc88c4169a9c800b4a1ff7d505bec9b74e
Matthew Netsch [Fri, 14 Oct 2022 17:47:09 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I2ea5abbe68202c09a290fad282bba0152514691b
Matthew Netsch [Fri, 14 Oct 2022 17:47:03 +0000 (17:47 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: Id224a630047cd512b36da121961684a9350ff731
Matthew Netsch [Fri, 14 Oct 2022 16:22:49 +0000 (16:22 +0000)]
Fixes zlib dependency
Components: Framework
Change-Id: I70c130a367afa7d3eb2cbd81dd1662331c6723b8
(cherry picked from commit
188db4918e48556a330814d9e09ec305e4497227)
Matthew Netsch [Thu, 13 Oct 2022 21:38:44 +0000 (21:38 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I6f074d5b4611da1efe18afcee1707a3a2c3b4e03
Ricardo Garcia [Wed, 21 Sep 2022 15:01:14 +0000 (17:01 +0200)]
Fix out-of-bounds vertex buffer writes in PrimitiveGeneratedQuery tests
Wrong index usage was leaving a gap in the vertex buffer and writing out
of bounds.
Affects:
dEQP-VK.transform_feedback.primitives_generated_query.*
Components: Vulkan
VK-GL-CTS issue: 3965
VK-GL-CTS issue: 3966
Change-Id: I2d656797506031713187a867902c05b1a363b450
James Fitzpatrick [Mon, 10 Oct 2022 17:23:16 +0000 (18:23 +0100)]
Update IMG waiver #229
Update waiver #229 after test names were changed to add tests for
VK_EXT_graphics_pipeline_libraries
Components: vulkan
VK-GL-CTS issue: 229
Change-Id: I33bd7a44631c8ddb95eff3a95db04033e2773983
Matthew Netsch [Thu, 13 Oct 2022 21:07:11 +0000 (21:07 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I5350055731e9c6ef9cab81fc347f102681555570
Matthew Netsch [Thu, 13 Oct 2022 19:04:21 +0000 (19:04 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I9a1dfa4f5801789b9ef062699bd6cadbfb1ddd20
Arkadiusz Sarwa [Tue, 11 Oct 2022 14:29:06 +0000 (16:29 +0200)]
Add missing barrier after cmdFillBuffer.
Components: Vulkan
VK-GL-CTS issue: 4036
Affected tests:
dEQP-VK.api.image_clearing.*
Change-Id: Ieddaa85461311e1b39de4aeee69a192d01c6c92c
Matthew Netsch [Thu, 13 Oct 2022 16:45:19 +0000 (16:45 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: I0146109f64a3a011ba56b33e1c498dcc0f2bae56
Matthew Netsch [Thu, 13 Oct 2022 16:16:54 +0000 (16:16 +0000)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I867eda5f06e1a9df38b95d604b1d98ee5691e552
Alex Shi [Fri, 30 Sep 2022 04:29:53 +0000 (12:29 +0800)]
Fix winding issue in watertightness tests
The winding order of shared edge vertices wasn't consistent.
Add a check to ensure all triangles have same winding order.
Affects:
dEQP-VK.ray_tracing_pipeline.watertightness*
Components: Vulkan
VK-GL-CTS issue: 4009
Change-Id: I24607720fedcae2e903707dcd8f2d2d8b6ec12c0
ziga-lunarg [Sat, 8 Oct 2022 18:32:44 +0000 (20:32 +0200)]
Remove tests using invalid sType
This test creates a structure with sType VK_STRUCTURE_TYPE_MAX_ENUM and
passes it to other create info structs through pNext, but this sType is
not allowed in the pNext of those create info structs
Components: Vulkan
VK-GL-CTS issue: 4023
Removed tests:
dEQP-VK.api.smoke-triangle_ext_structs
Change-Id: Iccfbcebb2bf9b43e93871bfc74aecea921bc31b8
Russell Chou [Tue, 4 Oct 2022 21:07:52 +0000 (14:07 -0700)]
Fix synchronization.cross_instance TEMPORARY permanence
VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT only supports TEMPORARY permanence, so check for that.
Affects:
dEQP-VK.synchronization.cross_instance.*_binary_semaphore_fence_fd
dEQP-VK.synchronization2.cross_instance.*_binary_semaphore_fence_fd
Components: Vulkan Framework
VK-GL-CTS issue: 4021
Change-Id: I6f663cbc35fcd7f81927878f31f78a6aaadf1a74
ziga-lunarg [Sun, 25 Sep 2022 15:39:29 +0000 (17:39 +0200)]
Fix subpass dependency in geometry layered tests
If both stages include a framebuffer-space stage in a self dependency,
then flags must include VK_DEPENDENCY_BY_REGION_BIT
Components: Vulkan
VK-GL-CTS issue: 3997
Affected tests:
dEQP-VK.geometry.layered.*
Change-Id: Id9941c16488a4c3bfbf569490d9e146437c4ae40
ziga-lunarg [Fri, 23 Sep 2022 23:31:28 +0000 (01:31 +0200)]
Fix color blend state in pipeline stencil tests
attachmentCount of pColorBlendState in pipeline create info must match
the colorAttachmentCount of the subpass used in creating the pipeline
Components: Vulkan
VK-GL-CTS issue: 3990
Affected tests:
dEQP-VK.pipeline.*stencil.*
Change-Id: Ic9bbcd9e14fc98e13e02698d7a138662a28782ae
ziga-lunarg [Mon, 19 Sep 2022 23:15:07 +0000 (01:15 +0200)]
Check if buffer size is multiple of nonCoherentAtomSize
When flushing memory range, if VK_WHOLE_SIZE is used, size must be a
multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize
Components: Vulkan
VK-GL-CTS issue: 3972
Affected tests:
dEQP-VK.memory.binding.*
Change-Id: If66e593f88af00450a55dfacc988df93ef6991eb
ziga-lunarg [Sun, 25 Sep 2022 13:38:58 +0000 (15:38 +0200)]
Fix queueFamilyIndex in synchronization tests
Invalid index is used, instead of retrieving queueFamilyIndex
Components: Vulkan
VK-GL-CTS issue: 3996
Affected tests:
dEQP-VK.synchronization.internally_synchronized_objects.*
Change-Id: I69aabf6199437cc26f519c257a3b26ee1605f8ef
ziga-lunarg [Sat, 17 Sep 2022 17:00:11 +0000 (19:00 +0200)]
Enable instance extensions when creating robustness device
Custom robustness context enables device extensions without enabling any
of the required instance extensions
Components:
Framework Vulkan VulkanSC
VK-GL-CTS issue: 3958
Affected tests:
dEQP-VK.*
dEQP-VKSC.*
Change-Id: I06d7d914eceb5aec97f723f726f97168341d8da5
ziga-lunarg [Thu, 15 Sep 2022 22:44:14 +0000 (00:44 +0200)]
Remove invalid dedicated allocation tests with bind offset
When dedicated allocation is used VkMemoryRequirements::size must match
VkMemoryAllocateInfo::allocationSize
Components: Vulkan
VK-GL-CTS issue: 3947
Affected tests:
dEQP-VK.api.copy_and_blit.*
Change-Id: I6eb0939746504566750b1cc958e1704cbf15ae51
ziga-lunarg [Fri, 16 Sep 2022 23:08:45 +0000 (01:08 +0200)]
Fix enabling timelineSemaphore feature
The feature was only enabled if the extension was used and not when
vulkan version 1.2 was used
Components: Vulkan
VK-GL-CTS issue: 3955
Affected tests:
dEQP-VK.*.smoke.timeline_semaphores
dEQP-VKSC.*.smoke.timeline_semaphores
Change-Id: If1b6fb3a6b0f6ef6e54b3bc2f36f1a7a55fd5fab
ziga-lunarg [Fri, 23 Sep 2022 00:11:33 +0000 (02:11 +0200)]
Fix missing cmd buffer reset flag in query_pool_results tests
Command buffer is begun multiple times when command pool was created
without VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT
Components: Vulkan
VK-GL-CTS issue: 3983
Affected tests:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.query_pool_results.*
Change-Id: If5445bb51c3b3a7b1aebd5397ef97f0f57dc7a9d
Neslisah [Mon, 26 Sep 2022 20:00:49 +0000 (16:00 -0400)]
Limit call of getQueryPoolResults to BUILD_TYPE_DEVICE
When the buildType is BUILD_TYPE_HOST, queryPool results are retrieved immediately to the CPU, and queryPool is not set to the result value.
Due to unset value at queryPool, later calling getQueryPoolResults causes the size to be messed up, and assertion to be trigerred.
The intention to call getQueryPoolResults is for BUILD_TYPE_DEVICE where you need to wait for cmdBuffer to be executed.
Call of getQueryPoolResults should only be made if the build type is BUILD_TYPE_DEVICE.
Affects:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.copy_within_pipeline.cpu.*
Components: Vulkan
https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/4016
Change-Id: I2e8c3dc9c56c98c288bba17d6c4074a9b88e0851
Matthew Netsch [Fri, 7 Oct 2022 21:32:23 +0000 (21:32 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3
Change-Id: I869c5e50453097a134dfa73defee01f9512b1bcb
ziga-lunarg [Sat, 24 Sep 2022 20:09:24 +0000 (22:09 +0200)]
Remove VK_PIPELINE_CREATE_DERIVATIVE_BIT for pipeline libraries in util
vkPipelineConstructionUtil creates pipeline libraries with same flags as
the main pipeline, but base pipeline handle is never provided
Components: Vulkan, Framework
VK-GL-CTS issue: 3994
Affected tests:
dEQP-VK.pipeline.*
Change-Id: If30b3caebd00463587a00f9e82810b53a7b72eb6
ziga-lunarg [Sat, 24 Sep 2022 15:06:34 +0000 (17:06 +0200)]
Fix color blend state in FSR tests
The attachment count used in pColorBlendState must match the attachment
count in the subpass the pipeline is created with
Components: Vulkan
VK-GL-CTS issue: 3993
Affected tests:
dEQP-VK.pipeline.*.multisample_with_fragment_shading_rate.*
Change-Id: Ic208371f7a6c704f169c3c16f0c19836014dcd85
ziga-lunarg [Fri, 23 Sep 2022 21:12:31 +0000 (23:12 +0200)]
Fix enabling pipeline libraries in push descriptor tests
Add missing required extension and enable the required feature for
pipeline libraries
Components: Vulkan
VK-GL-CTS issue: 3989
Affected tests:
dEQP-VK.pipeline.*.push_descriptor.*
Change-Id: Ibd7b588e822e94e42a405c2d3bb8c3ef81bd4aa0
Matthew Netsch [Fri, 7 Oct 2022 17:28:26 +0000 (17:28 +0000)]
Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2
Change-Id: I62bf1f49ff0dab41398a140dc29ca17a46142be5
ziga-lunarg [Fri, 16 Sep 2022 22:24:22 +0000 (00:24 +0200)]
Enable dynamicRendering feature in FSR tests using it
Fragment shading rate tests using dynamic rendering did not enable the
feature
Components: Vulkan
VK-GL-CTS issue: 3953
Affected tests:
dEQP-VK.fragment_shading_rate.dynamic_rendering.attachment_rate.*
Change-Id: I0959c88f42d820bed3b58473d45693bbcbd28896
Mike Byrne [Thu, 16 Jun 2022 11:00:53 +0000 (11:00 +0000)]
Fix barriers in dynamic rendering fragment density tests
Addeded additional barrier to ensure work on subsampled image is
complete before copy to output image.
Affects: dEQP-VK.dynamic_rendering.fragment_*
Components: Vulkan
VK-GL-CTS Issue: 3796
Change-Id: I5875f22b7fd3ccb47c9762067cb57048011115c0
Matthew Netsch [Fri, 7 Oct 2022 16:17:26 +0000 (09:17 -0700)]
Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1
Change-Id: I995d279b4aa7949762e1321013c1ae56c2bacad5
Matthew Netsch [Thu, 6 Oct 2022 21:08:48 +0000 (14:08 -0700)]
Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0
Change-Id: Iccd8336664b28aaa5c009f7da85295995a8297eb
ziga-lunarg [Mon, 29 Aug 2022 00:16:31 +0000 (02:16 +0200)]
Add missing buffer features check in image store tests
Check if format supports storage write for VkBufferView where
OpTypeImage is Unknown
Components: Vulkan
VK-GL-CTS issue: 3765
Affected tests:
dEQP-VK.image.store.without_format.*
Change-Id: I74365f2f753fb61397d83403098a288cdcf53953
ziga-lunarg [Sat, 17 Sep 2022 19:46:02 +0000 (21:46 +0200)]
Fix resetting command buffer in ray tracing tests
VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT must be set to reset
command buffer and add missing reset
Components: Vulkan
VK-GL-CTS issue: 3960
Affected tests:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.*
Change-Id: Icc5029fc796bff7cf095cbb78832483463cdaaaa
ziga-lunarg [Mon, 19 Sep 2022 18:46:43 +0000 (20:46 +0200)]
Fix ds attachment formats in dynamic rendering with inheritance
In VkCommandBufferInheritanceRenderingInfoKHR the depthAttachmentFormat
must have a depth aspect or be VK_FORMAT_UNDEFINED, and the
stencilAttachmentFormat must have a stencil aspect or be
VK_FORMAT_UNDEFINED
Components: Vulkan
VK-GL-CTS issue: 3970
Affected tests:
dEQP-VK.dynamic_rendering.*
Change-Id: I6d3248643a7a2b1f5761833828889e3484a25a57
ziga-lunarg [Fri, 16 Sep 2022 21:07:44 +0000 (23:07 +0200)]
Fix VkPipelineRenderingCreateInfoKHR formats in dynamic rendering tests
depthAttachmentFormat must include a depth aspect and stencilAttachment
format must include a stencil aspect
Components: Vulkan
VK-GL-CTS issue: 3952
Affected tests:
dEQP-VK.dynamic_rendering.*
Change-Id: Ifbbadb4f2917fb36fef669f1fc0a0eae6d0c7802
ziga-lunarg [Sat, 17 Sep 2022 15:31:33 +0000 (17:31 +0200)]
Enable used features in present_id_wait tests
Featuers presentId and presentWait are used, but not enabled
Components: Vulkan
VK-GL-CTS issue: 3957
Affected tests:
dEQP-VK.wsi.win32.present_id_wait.*
Change-Id: Ia6e899d65c05a81876c5d46b8426425c10b657f1
ziga-lunarg [Sat, 17 Sep 2022 22:07:41 +0000 (00:07 +0200)]
Add image format support check in sparse render target tests
Check if format is supported for the test
Components: Vulkan
VK-GL-CTS issue: 3961
Affected tests:
dEQP-VK.*.suballocation.sparserendertarget.*
Change-Id: I9878d04465839ce73f9f6661e263a114c01037fb
ziga-lunarg [Fri, 23 Sep 2022 15:27:22 +0000 (17:27 +0200)]
Fix rendering flags in secondary command buffers tests
VkCommandBufferInheritanceRenderingInfo::flags must match
VkRenderingInfo::flags excluding
VK_RENDERING_CONTENTS_SECONDARY_COMMAND_BUFFERS_BIT
Components: Vulkan
VK-GL-CTS issue: 3987
Affected tests:
dEQP-VK.multiview.dynamic_rendering.secondary_cmd_buffer.*
Change-Id: I205594a88fbe7baf60146121e05b75201be9b46b
Matthew Netsch [Thu, 6 Oct 2022 19:54:16 +0000 (12:54 -0700)]
Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8
Change-Id: I56e0faf8f022888c1d28b368d7852a83575ae57d
ziga-lunarg [Sat, 17 Sep 2022 22:29:20 +0000 (00:29 +0200)]
Check if stage is supported with subgroup size
When using required subgroup size, shader stage used must be a bit in
VkPhysicalDeviceSubgroupSizeControlProperties requiredSubgroupSizeStages
Components: Vulkan
VK-GL-CTS issue: 3962
Affected tests:
dEQP-VK.reconvergence.*
Change-Id: Ie2109b6974c4da57f19e8d321e27ccbad1298c71
Matthew Netsch [Thu, 6 Oct 2022 16:26:49 +0000 (09:26 -0700)]
Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7
Change-Id: Iea1e614855e2a12ab124da1dd1f24f2aaa938406
ziga-lunarg [Mon, 19 Sep 2022 21:23:16 +0000 (23:23 +0200)]
Fix dedicated allocations in split frame rendering tests
The image bound to dedicated memory must match the image from
VkMemoryDedicatedAllocateInfo
Components: Vulkan
VK-GL-CTS issue: 3971
Affected tests:
dEQP-VK.device_group.sfr_*
Change-Id: I23684ae6777d575da5eb244dfd856946ba67aa4a
ziga-lunarg [Wed, 21 Sep 2022 21:00:04 +0000 (23:00 +0200)]
Fix external memory opaque fd tests for MacOS
Components: Vulkan
VK-GL-CTS issue: 3981
Affected tests:
dEQP-VK.api.external.memory.*
Change-Id: I21a169aab047e58bc716d2aa69426b23af9295f2
ziga-lunarg [Fri, 16 Sep 2022 00:42:41 +0000 (02:42 +0200)]
Fix attachment load op in framebuffer compatible render pass tests
If image layout is VK_LAYOUT_UNDEFINED the loadOp of
VkAttachmentDescription must not be VK_ATTACHMENT_LOAD_OP_LOAD
Components: Vulkan
VK-GL-CTS issue:3948
Affected tests:
dEQP-VK.api.pipeline.renderpass.framebuffer_compatible_renderpass
Change-Id: I4b31df7fa9ca56d9c31af1326b8036f81e9d80fe
ziga-lunarg [Mon, 19 Sep 2022 17:01:59 +0000 (19:01 +0200)]
Fix errors in imageless framebuffer tests
Attachment must not be VK_ATTACHMENT_LOAD_OP_LOAD if initialLayout is
VK_IMAGE_LAYOUT_UNDEFINED
If framebuffer flags contain VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT then
image usage must include VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT
Components: Vulkan
VK-GL-CTS issue: 3969
Affected tests:
dEQP-VK.imageless_framebuffer.*
Change-Id: Ie588c547f8f55710eeffdccea94dd552dd8559a2
ziga-lunarg [Sat, 17 Sep 2022 19:25:08 +0000 (21:25 +0200)]
Use only required buffer usage bit in robustness tests
Using all bits requires additional checks for format support
Components: Vulkan
VK-GL-CTS issue: 3959
Affected tests:
dEQP-VK.robustness.*
Change-Id: I7a7c9e338b1e38a2d028f1fcffd6196bb75fa285
ziga-lunarg [Wed, 21 Sep 2022 16:45:54 +0000 (18:45 +0200)]
Fix srcStageMask in vkCmdWaitEvents in external fence tests
If event is set with vkSetEvent the srcStageMask must be
VK_PIPELINE_STAGE_HOST_BIT
Components: Vulkan
VK-GL-CTS issue: 3979
Affected tests:
dEQP-VK.api.external.fence.*
Change-Id: I9ca6fb5bdb597639cd5cb88afdbb03dde565acd8
ziga-lunarg [Wed, 21 Sep 2022 17:11:03 +0000 (19:11 +0200)]
Fix srcStageMask in vkCmdWaitEvents in secondary cmd buffers tests
If event is set with vkCmdSetEvent the srcStageMask must be
VK_PIPELINE_STAGE_HOST_BIT
Components: Vulkan
VK-GL-CTS issue: 3980
Affected tests:
dEQP-VK.api.command_buffers.secondary_execute_twice
Change-Id: Ib784e454ecf2bead488a267a069111da16ddfa8d
ziga-lunarg [Tue, 20 Sep 2022 19:49:29 +0000 (21:49 +0200)]
Fix memory allocation tests with device coherent memory
Extension VK_AMD_device_coherent_memory needs to be enabled in order ot
use VkPhysicalDeviceCoherentMemoryFeaturesAMD
Components: Vulkan
VK-GL-CTS issue: 3973
Affected tests:
dEQP-VK.memory.allocation.*
Change-Id: Ia866ab947bbd1af867f409053f830598965dea12