profile/ivi/qtbase.git
12 years agoQNetworkAccessManager - ensure abort reaches QFtp
Shane Kearns [Wed, 25 Apr 2012 14:31:11 +0000 (15:31 +0100)]
QNetworkAccessManager - ensure abort reaches QFtp

Previously, we just disconnected signals from QFtp and allowed it
to continue downloading in the background.

Task-number: QTBUG-25494
Change-Id: I891c2fff88ef1ee554d1ccf821a3f7998eeb8406
Reviewed-by: Martin Petersson <Martin.Petersson@nokia.com>
12 years agotst_qdnslookup: disabled broken testdata
Rohan McGovern [Thu, 3 May 2012 04:05:05 +0000 (14:05 +1000)]
tst_qdnslookup: disabled broken testdata

The mentioned records for råkat.se cannot be resolved.
Note these were marked with a FIXME in the first place.

Change-Id: I4ea3bbb0aec8ca1b3487c44656b48a8715228886
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
12 years agomkspecs: Define compilers and linkers elsewhere for freebsd-g++46.
Raphael Kubo da Costa [Sun, 29 Apr 2012 00:29:34 +0000 (21:29 -0300)]
mkspecs: Define compilers and linkers elsewhere for freebsd-g++46.

Commit 996672933a61016fdc0ec6d42d536986c5080ac5 has made the
freebsd-g++46 mkspec use g++-base.conf, which on its turn resets
QMAKE_CC and QMAKE_CXX to other values.

Redefine them to gcc46 and g++46, respectively (and fix the linker
values) after the inclusion of g++-unix.conf so the settings are not
lost.

Change-Id: I2d03548fdc492c5e4c4744b636b29df2cefe2acd
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoPass configured timeout to callWithCallback too.
David Faure [Wed, 2 May 2012 18:09:39 +0000 (20:09 +0200)]
Pass configured timeout to callWithCallback too.

This was missing in ccf3b9e48b2d773999a9a88e249f79380618cde6.

Change-Id: I8bc8239591b893aad361b372a36ed5b9478aff24
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoFix unit confusion in ccf3b9e48b2d773999a9a88e249f79380618cde6
David Faure [Wed, 2 May 2012 20:36:40 +0000 (22:36 +0200)]
Fix unit confusion in ccf3b9e48b2d773999a9a88e249f79380618cde6

I wrote nonsense in that commit. The older methods that take a timeout
all take milliseconds, and the comments in the unit test really meant
milliseconds, not seconds. 1s is not shorter than 100ms....

Change-Id: Ic18899bb0462d89575dc5a9a311478adc4dea1cb
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoUpdate QXbWindow orientation API
Lauro Neto [Tue, 24 Apr 2012 18:35:15 +0000 (15:35 -0300)]
Update QXbWindow orientation API

After orientation handling was split in window orientation
and content orientation QXcbWindow remained with the old api.
This patch renames setOrientation to handleContentOrientationChange,
fixing the issue of double status bar (portrait and landscape)
when running Qt5 apps with QtComponents on N9 in portrait mode.
(thanks to Simon for pointing out the difference between
changing the window and the content orientations)

Change-Id: I20d0be0c7f7e4593ac1e3c2ac2518144fc7fed0e
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
12 years agoStub out QDnsLookup on Android.
Robin Burchell [Wed, 2 May 2012 12:14:11 +0000 (14:14 +0200)]
Stub out QDnsLookup on Android.

Android's resolv.h is completely crippled, so we can't use the libc resolver.

Change-Id: I07e310e3561c719f4fe0bf08e58b5194f5a76e4a
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoAndroid's resolv.h is busted, so stub out QHostInfo::localDomainName().
Robin Burchell [Wed, 2 May 2012 12:35:54 +0000 (14:35 +0200)]
Android's resolv.h is busted, so stub out QHostInfo::localDomainName().

Change-Id: Idcf5ca7298eed55121b690906885af0eb3fe0b9e
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoDisable code using if_nameindex on Android.
Robin Burchell [Wed, 2 May 2012 12:39:50 +0000 (14:39 +0200)]
Disable code using if_nameindex on Android.

Android doesn't support if_nameindex.

Change-Id: Idb0cbf52e6cffb19fe65e30430ef53626e0eeac7
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoWork around Android not having SYS_futex.
Robin Burchell [Wed, 2 May 2012 09:23:40 +0000 (11:23 +0200)]
Work around Android not having SYS_futex.

Even though we really shouldn't, we can get away with using __NR_futex instead.

Done-with: Thiago Macieira <thiago.macieira@intel.com>
Change-Id: I0ba449b740acf2c78825f8093d1515a74f0bc9cd
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoAdd implementation of virtual keyboard based on BPS events
Kevin Krammer [Tue, 27 Mar 2012 16:39:49 +0000 (18:39 +0200)]
Add implementation of virtual keyboard based on BPS events

Change-Id: Ida4fa344c54db32b7b22b08a124b8c7b6df8adef
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Reviewed-by: Nicolas Arnaud-Cormos <nicolas@kdab.com>
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
12 years agoWindows: Fix a crash in Vista style.
Friedemann Kleint [Wed, 2 May 2012 12:18:35 +0000 (14:18 +0200)]
Windows: Fix a crash in Vista style.

Do not query the paintDevice of a backing store that has not
received a resize yet.

Change-Id: I49bf8f7e85c092c5664e5bc507802bd2cd8b62ea
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@digia.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoRemove unused Mac OS X code from QtWidgets
Bradley T. Hughes [Wed, 2 May 2012 11:47:05 +0000 (13:47 +0200)]
Remove unused Mac OS X code from QtWidgets

qcolordialog_mac.mm, qfiledialog_mac.mm, qfontdialog_mac.mm, and
qnspanelproxy_mac.mm are unused, remove them. The functionality they
used to provide is already included in the Cocoa platform plugin.

Change-Id: I2815d119687fd8d8dd421da36563afbd645ee000
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoAvoid macro re-definition warning for QT_NO_EXCEPTIONS
Stephen Kelly [Wed, 2 May 2012 11:14:07 +0000 (13:14 +0200)]
Avoid macro re-definition warning for QT_NO_EXCEPTIONS

Change-Id: I0c4b2d00dd567af17f22b733b93032ff1056fcbd
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoAvoid undefined macro warning for __GXX_EXPERIMENTAL_CXX0X__.
Stephen Kelly [Wed, 2 May 2012 11:15:16 +0000 (13:15 +0200)]
Avoid undefined macro warning for __GXX_EXPERIMENTAL_CXX0X__.

The GCC use of this is already correct.

Change-Id: I28650196c7a325b552117fe2f2014ad7d6b365c2
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoQDoc: Remove all occurences of 'qdoc3' in source.
Casper van Donderen [Wed, 2 May 2012 11:14:29 +0000 (13:14 +0200)]
QDoc: Remove all occurences of 'qdoc3' in source.

Change-Id: I7d4e3238a9233d6aab32cc7a3c5a883e718113d5
Reviewed-by: Martin Smith <martin.smith@nokia.com>
12 years agoAdd "make docs" target for QtNetwork and sanitize other qdocconfs.
Casper van Donderen [Mon, 30 Apr 2012 15:23:04 +0000 (17:23 +0200)]
Add "make docs" target for QtNetwork and sanitize other qdocconfs.

Change-Id: Ic9d6384b20162debeb69cb067c96c330c0fd999a
Reviewed-by: Jerome Pasion <jerome.pasion@nokia.com>
12 years agofix documentation for QKeySequence::StandardKey "What's This"
stockton [Mon, 30 Apr 2012 15:49:37 +0000 (08:49 -0700)]
fix documentation for QKeySequence::StandardKey "What's This"

add apostrophe and double-quotes.

Task-number: QTBUG-25545

Change-Id: Ib79953731953166ff7d8b999fee6571e62d86d01
Reviewed-by: Rick Stockton <rickstockton@reno-computerhelp.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
12 years agoEnable QML debugging of qtquick1 with CONFIG+=quick1
Kai Koehne [Wed, 2 May 2012 10:02:52 +0000 (12:02 +0200)]
Enable QML debugging of qtquick1 with CONFIG+=quick1

Make the option name align with the name of the module.

Change-Id: I29a822b55b3cb52a51592aa2bd0746a53bfe44b9
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
12 years agoSupport mkspecs in subdirs for xcompile under windows
Andreas Holzammer [Wed, 2 May 2012 09:42:20 +0000 (11:42 +0200)]
Support mkspecs in subdirs for xcompile under windows

Support mkspecs in subdirectories for cross compilation
under windows. Mkspecs in subdirectories are separated by
slashes.

Change-Id: Id3954cc38df2922b20156589335faad989ec0537
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agomkdtemp() is not included in Android's libc
Robin Burchell [Tue, 1 May 2012 19:27:29 +0000 (21:27 +0200)]
mkdtemp() is not included in Android's libc

Use our own implementation instead.

Change-Id: Ic04dd480d52404e03e26cdf4caa1d00e4c3219c7
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: David Faure <faure@kde.org>
12 years agoAllow creation of QOpenGLShaderProgram without a current context
Sean Harmer [Wed, 2 May 2012 09:10:39 +0000 (10:10 +0100)]
Allow creation of QOpenGLShaderProgram without a current context

This change prevents the qWarning() in QOpenGLFunctions from being
triggered when creating a QOpenGLShaderProgram object without a current
QOpenGLContext. This is a common case especially when the shader program
is a member variable of a class.

It now relies upon the QOpenGLShaderProgram::init() function to resolve
the GL function pointers when the shader program is first used which of
course should be done with an active context.

Change-Id: Ib7dc345593f2a70d72ef8f650151cc90001058ca
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoInitialize QOpenGLFunctions before using it in QOpenGLShaderProgram
Sean Harmer [Tue, 1 May 2012 15:44:57 +0000 (16:44 +0100)]
Initialize QOpenGLFunctions before using it in QOpenGLShaderProgram

Change-Id: I472e97092b05f1721b7df5759d674c213d6018c6
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoFix compilation of public headers with QT_NO_DEPRECATED defined
Olivier Goffart [Mon, 30 Apr 2012 12:26:41 +0000 (14:26 +0200)]
Fix compilation of public headers with QT_NO_DEPRECATED defined

Put the functions in QT_DEPRECATED_SINCE if possible

QPluginLoader::staticInstances is not documented as deprecated, and do
not reference any alternative use. So I unmarked it as deprecated.

Change-Id: I556c3f3657fb0490dd5543fcc56718fe9bd394e7
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
12 years agoIntroduce QObject::isSignalConnected(QMetaMethod)
Olivier Goffart [Tue, 24 Apr 2012 13:01:47 +0000 (15:01 +0200)]
Introduce QObject::isSignalConnected(QMetaMethod)

This is much more performant than calling QObject::receivers(const char*)

Can be used instead of connectNotify in some cases.

Change-Id: I19e0933f678f171f515d9a0f69f0ad4fb7d894b4
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
12 years agoDon't use obsolete qVariantValue, qVariantCanConvert, etc.
Debao Zhang [Sun, 29 Apr 2012 07:11:28 +0000 (00:11 -0700)]
Don't use obsolete qVariantValue, qVariantCanConvert, etc.

qVariantValue and qVariantCanConvert are Compatibility members, while in
Qt4.8 they are marked as Qt 3 Support Members.

qVariantFromValue and qVariantSetValue are Obsolete members.

Change-Id: Ie8505cad1e0950e40c6f6710fde9f6fb2ac670fd
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoMake eglfs hooks functionality namespace cognisant
Donald Carr [Wed, 2 May 2012 00:44:45 +0000 (00:44 +0000)]
Make eglfs hooks functionality namespace cognisant

Change-Id: Ie9f86bd0494c0423f50d0f405922ab169b2431e3
Reviewed-by: Girish Ramakrishnan <girish.1.ramakrishnan@nokia.com>
12 years agoFixed windows platform plugin with -qtnamespace.
Rohan McGovern [Wed, 2 May 2012 00:34:43 +0000 (10:34 +1000)]
Fixed windows platform plugin with -qtnamespace.

Added missing QT_BEGIN_NAMESPACE/QT_END_NAMESPACE

Change-Id: I2ffc5ec18d19027c01c81ba9c29f6d7cac5e9619
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
12 years agoFixed QtGui and QtPrintSupport with -qtnamespace and MSVC
Rohan McGovern [Wed, 2 May 2012 00:31:11 +0000 (10:31 +1000)]
Fixed QtGui and QtPrintSupport with -qtnamespace and MSVC

With this compiler, external functions declared inside other functions
will end up in the wrong namespace.

Change-Id: Ia37283d632dbc2ee0c269aeffa1f045b3e60148e
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
12 years agoFix regression in connectNotify(const char *) emission
Kent Hansen [Thu, 26 Apr 2012 18:17:33 +0000 (20:17 +0200)]
Fix regression in connectNotify(const char *) emission

Reimplementations of connectNotify() and disconnectNotify() can
assume that the signal argument is in normalized form, but after the
introduction of the Qt5 meta-object format, it could happen that it's
not.

The problem is that the internal QArgumentType class, which attempts
to resolve a typename to a type id, was calling QMetaType::type().
QMetaType::type() falls back to trying the normalized form of the
typename if the original argument can't be resolved as a type (this
behavior isn't documented, but that's how it works). This means that
e.g. QMetaType::type("const QString &") returns QMetaType::QString.

Since QMetaObjectPrivate::indexOfMethodRelative() (more specifically,
the methodMatch() helper function) prefers to compare type ids
over typenames (since the type ids are stored directly in the meta-
object data for built-in types), the method lookup would *succeed*
for signatures with non-normalized built-in typenames as parameters.
QObject::connect() would then think that it did not have to
normalize the signature (see "// check for normalized signatures").
The consequence was that the original, non-normalized form got
passed to connectNotify().

This commit introduces an internal typename-to-type function that
is the same as QMetaType::type(), except it doesn't try to normalize
the name. This way, the only place where normalization can occur in
the signature-to-meta-method processing is through the calls to
QMetaObject::normalizedSignature() in QObject::connect() itself.

The implication is that there are now cases where the method
signature will be decoded and processed twice, where processing it
once was sufficient before. On the other hand, it is consistent with
the pre-Qt5-meta-object behavior, where we predict that the
signature is already normalized, and only perform (comparatively
costly) normalization if the initial lookup fails.

Change-Id: Ie6b60f60b0f9a57ebd378d980329dac62d57bbd9
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
12 years agoQNetworkProxyFactory: check the "no_proxy" environment variable
Adrien Bustany [Mon, 23 Apr 2012 07:49:11 +0000 (10:49 +0300)]
QNetworkProxyFactory: check the "no_proxy" environment variable

The QNetworkProxyFactory class considered the http_proxy environment
variable, but not the no_proxy one. This commit adds no_proxy handling,
loosely modeled after the way curl does it.

Change-Id: Ibb9e5ffcb30fed5c95dc9fc3bc4177e20d025a50
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoFixed compile of QSslSocket with -qtnamespace on Windows.
Rohan McGovern [Mon, 30 Apr 2012 06:09:05 +0000 (16:09 +1000)]
Fixed compile of QSslSocket with -qtnamespace on Windows.

Q_DECLARE_METATYPE must be outside of the qt namespace.

System headers must be included outside of the qt namespace.

Change-Id: I2f48b1df87e5edae2baee6ce813af08d3e011dc0
Reviewed-by: Sergio Ahumada <sergio.ahumada@nokia.com>
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoFix warning
Olivier Goffart [Mon, 30 Apr 2012 12:32:35 +0000 (14:32 +0200)]
Fix warning

qxcbnativeinterface.cpp:209:8: warning: unused parameter ‘context’
[-Wunused-parameter]

Change-Id: I0c90e94020907cf84626af9f3fef3e6746182431
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoFixed uninitialized memory in QMetaObjectBuilder::fromRelocatableData
Rohan McGovern [Tue, 1 May 2012 05:02:48 +0000 (15:02 +1000)]
Fixed uninitialized memory in QMetaObjectBuilder::fromRelocatableData

static_metacall was never set on the metaobject written by
QMetaObjectBuilder::fromRelocatableData, sometimes causing a crash.  It
should be initialized to 0.

Change-Id: I79373d895e131f0cc2ff1af6d2177a0c1a282be7
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoFix warning about narrowing inside {}
Olivier Goffart [Mon, 30 Apr 2012 12:14:11 +0000 (14:14 +0200)]
Fix warning about narrowing inside {}

Such as
qdialogbuttonbox.cpp:259:1: warning: narrowing conversion of
‘2147483650u’ from ‘unsigned int’ to ‘const int’ inside { }
[-Wnarrowing]

Change-Id: I00d66d96ef3af1a46935a58119668a20f8fd58c7
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoconfigure: Escape '{' in getQMakeConf2 function
Sergio Ahumada [Mon, 30 Apr 2012 12:29:26 +0000 (14:29 +0200)]
configure: Escape '{' in getQMakeConf2 function

Change-Id: I7df0ca940a76b80d7b0da24dbedbabd2b8736bb8
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoHandle navigator events in BPS event filter
Kevin Krammer [Tue, 27 Mar 2012 14:07:24 +0000 (16:07 +0200)]
Handle navigator events in BPS event filter

Change-Id: I37b5de4bf1e9f9bbe53910eb5e3f490172b28371
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
12 years agoRegister for and handle screen events delivered through BPS
Kevin Krammer [Mon, 26 Mar 2012 14:44:07 +0000 (16:44 +0200)]
Register for and handle screen events delivered through BPS

Delegates actual event inspection and reaction to the screen event
handler class already used by the PPS screen event handler

Change-Id: Ic07efa1de3f6b452f3091e901bd8a577175e3cf0
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
12 years agoWidgets: No longer use deprecated QPixmap::grabWindow(),grabWidget().
Friedemann Kleint [Mon, 30 Apr 2012 12:42:40 +0000 (14:42 +0200)]
Widgets: No longer use deprecated QPixmap::grabWindow(),grabWidget().

Change-Id: Icf0d6a672edcfd1d3d10275bb9a93bde29251e79
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoAllow loading of static plugins by index
Lars Knoll [Mon, 30 Apr 2012 10:31:48 +0000 (12:31 +0200)]
Allow loading of static plugins by index

Static plugins could so far not get loaded by
index. Implement the missing support for this.

Task-number: QTBUG-25274
Change-Id: I901b08bfaf4f9fc3cb9fcea0b47f3ed89588a27b
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoReset pointer to 0 after freeing
Lars Knoll [Mon, 30 Apr 2012 09:56:45 +0000 (11:56 +0200)]
Reset pointer to 0 after freeing

set m_textureResource to 0 after freeing it, to
ensure we allocate a new one two lines below before
using it again 5 lines below.

Change-Id: Ib9c4de94aefed91f15d0fab0cd3c774a64f2f891
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoInitialize member variable
Lars Knoll [Mon, 30 Apr 2012 09:56:33 +0000 (11:56 +0200)]
Initialize member variable

Change-Id: Icfbe064e89b0c2f7b67ba58cbdc79347275b63b1
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
12 years agoRestructure how we initialize hash nodes a little
Lars Knoll [Mon, 30 Apr 2012 09:01:05 +0000 (11:01 +0200)]
Restructure how we initialize hash nodes a little

This should help to silence coverity which was complaining
hundreds of times about Qt not initializing h and next in
QHashNode.

Change-Id: Ib7977693e9786d4b310799e4f428115c65bb3fee
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoInitialize members
Lars Knoll [Mon, 30 Apr 2012 07:19:31 +0000 (09:19 +0200)]
Initialize members

Change-Id: I786de497af63a45d9c38780e856a3f27c5ce8468
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoqdoc: Further changes to the QML specialization
Martin Smith [Mon, 30 Apr 2012 11:30:12 +0000 (13:30 +0200)]
qdoc: Further changes to the QML specialization

Re-adding <qmlInherits>, <qmlInheritedBy>,
<qmlInstantiates>, and <qmlSince>. Also adding
<qmlAttached>.

Change-Id: Iebd70a37b083bc404ce621d0bb9d3090dbc1109e
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
12 years agoNever attempt to run the dbus tests on APPLE.
Stephen Kelly [Fri, 27 Apr 2012 12:30:46 +0000 (14:30 +0200)]
Never attempt to run the dbus tests on APPLE.

The Qt buildsystem is creating the config files for it even
when it is not building QtDBus, so Qt5DBus_FOUND = True.

Re-enable the CI testing on mac with this change.

Task-number: QTBUG-25522

Change-Id: I5d2690d17fde6c5aabcbdd3e2eef9f0846edd97d
Reviewed-by: Alexander Neundorf <neundorf@kde.org>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoTemporarily disable -Woverloaded-virtual in headersclean test
Kent Hansen [Mon, 30 Apr 2012 10:45:15 +0000 (12:45 +0200)]
Temporarily disable -Woverloaded-virtual in headersclean test

This autotest fails to build after the introduction of the
QMetaMethod-based connect/disconnectNotify() functions; we are
intentionally keeping the old const char * versions (overloads) for
a limited time, to avoid disrupting other modules.

This commit will be reverted as soon as the compatibility overloads
have been removed.

Change-Id: I9b5a40b51ffa3bfa3d185410389678c262ca7b45
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoPort bearer plugins to QMetaMethod-based connectNotify()
Kent Hansen [Mon, 23 Apr 2012 19:36:04 +0000 (21:36 +0200)]
Port bearer plugins to QMetaMethod-based connectNotify()

The const char *-based API is deprecated and will be removed in Qt5.

Some of the reimplementations were commented out since the signals
being checked for aren't even declared by the relevant classes.

Change-Id: I4486d1f3242db21cebd55fb53def3904f7c236ba
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoPort QtDBus to QMetaMethod-based connectNotify()
Kent Hansen [Sun, 22 Apr 2012 13:05:56 +0000 (15:05 +0200)]
Port QtDBus to QMetaMethod-based connectNotify()

The const char *-based API is deprecated and will be removed in Qt5.

Change-Id: I1c7f0e46149964367f42faccfff4b89acbf16511
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoPort QNetworkSession to QMetaMethod-based connectNotify()
Kent Hansen [Sun, 22 Apr 2012 12:35:56 +0000 (14:35 +0200)]
Port QNetworkSession to QMetaMethod-based connectNotify()

The const char *-based API is deprecated and will be removed in Qt5.

Change-Id: I36f6dc761e3b5a087e38db29b761c3e9237958b4
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoPort QBuffer to QMetaMethod-based connectNotify()
Kent Hansen [Sun, 22 Apr 2012 12:30:32 +0000 (14:30 +0200)]
Port QBuffer to QMetaMethod-based connectNotify()

The const char *-based API is deprecated and will be removed in Qt5.

Also fix a bug in the disconnectNotify() reimplementation; when all
signals are disconnected at once, disconnectNotify() is only called
a single time, with an invalid method as argument. Thus, the signal
connection count should be set to 0, instead of decremented.

Change-Id: Ieee92293777bff87f8b28e56e23ab55d0b8b8101
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoPort QtConcurrent to QMetaMethod-based connectNotify()
Kent Hansen [Sun, 22 Apr 2012 12:23:53 +0000 (14:23 +0200)]
Port QtConcurrent to QMetaMethod-based connectNotify()

The const char *-based API is deprecated and will be removed in Qt5.

Change-Id: Ica5b2c5020adf972db5005be8c062ddcdae8c0b4
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoAdd QMetaMethod-based QObject::connect/disconnectNotify() API
Kent Hansen [Fri, 20 Apr 2012 18:19:12 +0000 (20:19 +0200)]
Add QMetaMethod-based QObject::connect/disconnectNotify() API

This API will fully replace the const char *-based connectNotify()
and disconnectNotify() in Qt5; the old functions will be REMOVED
before Qt 5.0 final.

The new implementation fixes the long-standing issue of
connectNotify() not being called when using the (internal)
index-based QMetaObject::connect() (e.g., from QML).

As with the old API, there are still two "unintuitive" behaviors
concerning disconnectNotify():
- disconnectNotify() is not called when the signal is disconnected
  using the QObject::disconnect(QMetaObject::Connection) overload.
- disconnectNotify() is not called when a receiver is destroyed
  (i.e., when a connection is implicitly removed).

The old versions of connectNotify() and disconnectNotify() are kept
for now, and they are still called. They will be removed once known
existing reimplementations (e.g., QtNetwork, QtDBus) have been
ported to the new API.

Change-Id: I8b4f007f3c6d89199c1ba04a3e23c8ca314e0896
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
12 years agoFix compiler warning in qdrawhelper.cpp
Olivier Goffart [Mon, 30 Apr 2012 11:21:57 +0000 (13:21 +0200)]
Fix compiler warning in qdrawhelper.cpp

warning: always_inline function might not be inlinable [-Wattributes]

Those function are only used in array of function pointers. They
cannot be inlined.

Change-Id: I82b10d82ac8915129dc8921b1a74d42d8547bc40
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoSupport all modality types in QPlatformDialogHelper
Bradley T. Hughes [Thu, 26 Apr 2012 11:32:14 +0000 (13:32 +0200)]
Support all modality types in QPlatformDialogHelper

Modality is not a boolean property in Qt. There are 2 types: window
modality and application modality. Native dialogs can support both of
these types as well (e.g. on Cocoa, a window modal file dialog should be
displayed as a Sheet). Remove the QPlatformDialogHelper::ShowFlags enum
and instead pass a Qt::WindowModality parameter to
QPlatformDialogHelper::show_sys().

The Windows implementation has been updated to check for
Qt::ApplicationModal instead of the ShowModal flag (since only
Qt::ApplicationModal dialogs are blocking).

The Cocoa implementation has been updated to only use non-modal and
application modal native color and font dialogs (which restores Qt 4
behavior). These are shared Cocoa panels that cannot be shown as sheets,
however. If the programmer asks for window modal color/font dialogs, we
use the Qt versions, not the native ones. The file dialog can be shown
either as a Sheet (but we need to pass an NSWindow parent for it to work
properly) or as an application modal dialog.

This change has been tested on Mac OS X with
tests/manual/windowmodality.

Change-Id: I9064987433895c55f68aac979ef8e8207fb24bbe
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Morten Johan Sørvig <morten.sorvig@nokia.com>
12 years agoMake QGtkStyle work on Qt 5.
Morten Johan Sorvig [Tue, 24 Apr 2012 12:23:02 +0000 (14:23 +0200)]
Make QGtkStyle work on Qt 5.

Mostly straightforward porting: Add configure test from Qt 4. Add X11
include to qgtkstyle_p.cpp. Use renamed QGuiApplicationPrivate::showModalWindow.

Change-Id: I83020e13ec00b49f3fe346814f881bce19a6f602
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoCocoa: Fix beep-on-show for Creator menus.
Morten Johan Sorvig [Thu, 26 Apr 2012 10:29:01 +0000 (12:29 +0200)]
Cocoa: Fix beep-on-show for Creator menus.

Maintain a current window state variable in QCocoaWindnow
and use it when setting the new window state on the
NSWindow.

The NSWindow state accessors can apparently not be
trusted, in particular isZoomed always returns true
for the Creator popup menu.

Change-Id: I78f13de251f3730752813bba17459011f8558aee
Reviewed-by: James Turner <james.turner@kdab.com>
Reviewed-by: Christoph Schleifenbaum <christoph.schleifenbaum@kdab.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
12 years agoRemove unused code
Lars Knoll [Mon, 30 Apr 2012 07:01:00 +0000 (09:01 +0200)]
Remove unused code

Change-Id: I185db2361990dd1d503488a364826738270388b5
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
Reviewed-by: Martin Smith <martin.smith@nokia.com>
12 years agoDisable force_align_arg_pointer function attribute with MinGW-w64
Jonathan Liu [Thu, 26 Apr 2012 14:57:56 +0000 (00:57 +1000)]
Disable force_align_arg_pointer function attribute with MinGW-w64

The force_align_arg_pointer function attribute is not necessary for
MinGW-w64 to align stack for SSE and generates a compiler warning as
it is ignored. Do not use force_align_arg_pointer with MinGW-w64 to
silence the warning.

Change-Id: I58a754dc3ec01b36a1d3c9490f45ccf0824468ba
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoFix the tst_QOpenGL::sharedResourceCleanup() test case in Windows
Miikka Heikkinen [Mon, 30 Apr 2012 10:14:58 +0000 (13:14 +0300)]
Fix the tst_QOpenGL::sharedResourceCleanup() test case in Windows

QWindowsGLContext was returning always false for isSharing() query,
as it was falling back to default implementation.

Task-number: QTBUG-24192
Change-Id: I884d559d69545ef85a0d07d7287bc50ce459c1bd
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoUse BPS based event dispatcher
Kevin Krammer [Tue, 27 Mar 2012 12:01:38 +0000 (14:01 +0200)]
Use BPS based event dispatcher

Create a QPA specific subclass of the blackberry event dispatcher
(basically the BPS equivalent to the QUnixEventDispatcherQPA created
by createUnixEventDispatcher()).

Create an event dispatcher event filter that will receive all BPS events
and then either handle them itself or delegate to event subtype
specific handlers.

Change-Id: I112e0274156727d3aa9e5693b59d041c65be4daf
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Reviewed-by: Rafael Roquetto <rafael.roquetto@kdab.com>
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
12 years agoRemove declaration of QWindowsFontEngine::createEngine()
Miikka Heikkinen [Mon, 30 Apr 2012 08:59:37 +0000 (11:59 +0300)]
Remove declaration of QWindowsFontEngine::createEngine()

There is no implementation for this function so might as well remove
the declaration. The function is actually implemented by
QWindowsFontDatabase class, where it is also properly declared.

Change-Id: I8f5c050fa3f3c48b07e10f205eb0f7b16e12b737
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoRemoved insignification from QBackingStore test
Miikka Heikkinen [Mon, 30 Apr 2012 08:40:24 +0000 (11:40 +0300)]
Removed insignification from QBackingStore test

The test is passing in CI for both Mac and Windows, so removed the
insignification from it.

Task-number: QTBUG-24885
Change-Id: Ida39d98b72e49fc82358d016b8de725bbfc5d6de
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoRemove unused private and protected members from QClipboard
Laszlo Agocs [Mon, 30 Apr 2012 07:52:51 +0000 (10:52 +0300)]
Remove unused private and protected members from QClipboard

Change-Id: I1d5ce0db4a9a6582629e2c0b74e9ab998b405788
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
12 years agoFix Qt::MouseButton Documentation for Qt::ExtraButton24,
stockton [Mon, 30 Apr 2012 05:21:43 +0000 (22:21 -0700)]
Fix Qt::MouseButton Documentation for Qt::ExtraButton24,

Documentation for the 'more mouse buttons' feature has a Typo on
Qt::ExtraButton24 (is shown as "Qt::ExtraButton44", no value.)
Also, the order of BackButton/Xbutton1/ExtraButton1 causes the
'BackButton' value to be a forward reference to XButton1, which
makes it awkward and hard to understand. Same with ForwardButton/
XButton2/ExtraButton2.

Task-number: QTBUG-25529

Change-Id: I04b76d91d7a2155c1917a809a51700059320f510
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
12 years agoRemove insignification of lancelot test on Mac OS X.
Jason McDonald [Fri, 27 Apr 2012 07:55:26 +0000 (17:55 +1000)]
Remove insignification of lancelot test on Mac OS X.

This test has been passing consistently since the previous crash was
skipped in commit 6dbd00b12052d749492763ee2a768d952fdddba9.

Task-number: QTBUG-22792
Change-Id: I41ac001a3b9e16cde4d674dc9f34ab2dffb848cd
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoRemove insignficiation from qgraphicsscene test on Windows.
Jason McDonald [Fri, 27 Apr 2012 09:06:07 +0000 (19:06 +1000)]
Remove insignficiation from qgraphicsscene test on Windows.

This test has been passing consistently since it started running in CI.

Task-number: QTBUG-24295
Change-Id: If2a163607ae72cae9e28619dd5de1b333aea4ed9
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@digia.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoRemove insignification from qsslsocket_onDemandCertificates_* tests
Jason McDonald [Fri, 27 Apr 2012 08:50:12 +0000 (18:50 +1000)]
Remove insignification from qsslsocket_onDemandCertificates_* tests

These tests have been passing consistently since they started running
on Windows in CI.

Change-Id: I4505497afc477a7f4fbda0acc29987d0d0cf220a
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoRemove insignification from qtcpserver test on Mac OS X.
Jason McDonald [Fri, 27 Apr 2012 08:59:47 +0000 (18:59 +1000)]
Remove insignification from qtcpserver test on Mac OS X.

This test has been passing consistently since starting to run in CI.

Task-number: QTBUG-25445
Change-Id: Id024921b18ea4ef94ad2f47d9db2ccda3212eaaa
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoRemove insignification of qsslsocket test on Windows and Mac.
Jason McDonald [Fri, 27 Apr 2012 08:41:05 +0000 (18:41 +1000)]
Remove insignification of qsslsocket test on Windows and Mac.

The test has a single stable failure on both of these platforms. Mark
the failure with QEXPECT_FAIL (that was already the case on Ubuntu
11.10) and re-enable the test.

Note also the elimination of duplicate bug numbers.

Task-number: QTBUG-24234
Change-Id: Ica11e7d1f3cd9487647127984fef7c75e0e764fe
Reviewed-by: Shane Kearns <shane.kearns@accenture.com>
12 years agoFix MinGW-w64 compilation
Jonathan Liu [Fri, 27 Apr 2012 10:50:08 +0000 (20:50 +1000)]
Fix MinGW-w64 compilation

Use qintptr and quintptr for exchanging data with registers for cpuid
as the size of long does not match the size of the register on Win64
which uses the LLP64 data model.

Change-Id: I23b8c8e0977166f7e62795c16e9080e44d9f25f5
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoIf a dependency was not found, and we were not called with REQUIRED, we are not found.
Stephen Kelly [Fri, 27 Apr 2012 14:45:20 +0000 (16:45 +0200)]
If a dependency was not found, and we were not called with REQUIRED, we are not found.

This only works with CMake 2.8.8, but it is no harm to earlier versions.

Change-Id: I62c220e4b24f951e83c23eb57d5f833de4d181c5
Reviewed-by: Alexander Neundorf <neundorf@kde.org>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoProperly quote the dependencies string.
Stephen Kelly [Sun, 29 Apr 2012 18:03:16 +0000 (20:03 +0200)]
Properly quote the dependencies string.

Change-Id: I319b04cdb21860652658ee8d3e577d41a913ed5a
Reviewed-by: Alexander Neundorf <neundorf@kde.org>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoGet rid of most warnings related to QInputMethod
Lars Knoll [Fri, 27 Apr 2012 21:25:57 +0000 (23:25 +0200)]
Get rid of most warnings related to QInputMethod

Change-Id: Id0b1235a5dc209c5c06e0a64613364c89e733005
Reviewed-by: Pekka Vuorela <pekka.ta.vuorela@nokia.com>
12 years agoMake sure different modules do not overwrite each others dependencies.
Stephen Kelly [Fri, 27 Apr 2012 14:50:33 +0000 (16:50 +0200)]
Make sure different modules do not overwrite each others dependencies.

Change-Id: I30ca05d3c692a707cfe829ad5fee099549bab540
Reviewed-by: Alexander Neundorf <neundorf@kde.org>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoForward the REQUIRED and QUIET arguments when finding dependencies.
Stephen Kelly [Fri, 27 Apr 2012 14:40:55 +0000 (16:40 +0200)]
Forward the REQUIRED and QUIET arguments when finding dependencies.

Change-Id: I5d7c26f12a296ac3527575149978b18c5e9a4a67
Reviewed-by: Alexander Neundorf <neundorf@kde.org>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoSimplify the cmake version check.
Stephen Kelly [Fri, 27 Apr 2012 13:30:22 +0000 (15:30 +0200)]
Simplify the cmake version check.

Change-Id: Ifdd89397f88b090a6b43d40636dbeac029faaed8
Reviewed-by: Alexander Neundorf <neundorf@kde.org>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years agoAdd some more useful output when about the cmake version
Stephen Kelly [Fri, 27 Apr 2012 13:11:26 +0000 (15:11 +0200)]
Add some more useful output when about the cmake version

Change-Id: I58efa1f295dbc652b1882937ca27ea52d9f4a923
Reviewed-by: Alexander Neundorf <neundorf@kde.org>
Reviewed-by: Stephen Kelly <stephen.kelly@kdab.com>
12 years ago[SIC] Make non-const the QRegExp methods that modify the internals
Thiago Macieira [Fri, 20 Apr 2012 14:50:36 +0000 (16:50 +0200)]
[SIC] Make non-const the QRegExp methods that modify the internals

These methods modify QRegExp internals and should not have been
const. It's actually dangerous to have them const, since users may
think it's safe to use the matching method in a thread-safe manner.

Task-number: QTBUG-25064
Change-Id: Ia370eb42fd0407a94924f420297c5e83d3908214
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoDoc: Fix most qdoc errors in QtSql.
Casper van Donderen [Fri, 27 Apr 2012 13:18:27 +0000 (15:18 +0200)]
Doc: Fix most qdoc errors in QtSql.

- Move 2 images from qtdoc.
- Add "make docs" command for qtsql
- Fix qdoc command usage errors.

Change-Id: Id2f0548d09ed8f77b2317863d443c19d1cccdd83
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoqdoc: Further changes to the QML specialization
Martin Smith [Fri, 27 Apr 2012 14:08:16 +0000 (16:08 +0200)]
qdoc: Further changes to the QML specialization

The <qmlPropertyGroup> tag now has an id attribute
of the form "id-qml-propertygroup-xxx" where the
xxx is the property name. //This should be unique
within the document.

Change-Id: I20b30266dbe92b85b60400de30ebf9b1f1e292ea
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
12 years agoDon't generate compiler warnings for using deprecated methods
Lars Knoll [Fri, 27 Apr 2012 21:12:13 +0000 (23:12 +0200)]
Don't generate compiler warnings for using deprecated methods

We need to construct QImageTextKeyLang objects for the deprecated
method in QImage. That's impossible to do if we don't have a
constructor for the class that's non deprecated. So add a private
constructor and make QImage a fried of the class so it can use
that constructor.

Change-Id: I6359e9943fe031ed3dca85479ee9ec47ceaf776b
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoGet rid of some deprecation warnings
Lars Knoll [Fri, 27 Apr 2012 21:24:00 +0000 (23:24 +0200)]
Get rid of some deprecation warnings

Change-Id: I05e6f9479789652cc1536cb5bced2bc8fa664c84
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
12 years agoRe-enable casting to and from "ASCII" on tst_qstring.cpp
Thiago Macieira [Wed, 25 Apr 2012 11:33:03 +0000 (13:33 +0200)]
Re-enable casting to and from "ASCII" on tst_qstring.cpp

Turns out that we've had some old unit tests commented out that did not
compile. QString does not have a std::string constructor nor overloads
to many other methods. And std::string does not cast to char* on its
own. So these tests need to be removed.

Change-Id: I22df66fc3ccc68bc2840f2d83747234418e480f5
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoDon't use the QRegExp methods that modify the object [QtCore]
Thiago Macieira [Fri, 20 Apr 2012 12:59:30 +0000 (14:59 +0200)]
Don't use the QRegExp methods that modify the object [QtCore]

QRegExp matching methods modify the object, which we don't want to. In
particular, when we receive a QRegExp from the user or we store in a
context that might require thread-safety, make sure we make a copy
before using it.

QRegularExpression has no such shortcoming.

Task-number: QTBUG-25064
Change-Id: Icf22986cd5f6fd086518c78a7d56e6cadfe9f5f6
Reviewed-by: Giuseppe D'Angelo <dangelog@gmail.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoWrap the non-ASCII testcases with QString::fromUtf8
Thiago Macieira [Mon, 23 Apr 2012 21:11:40 +0000 (23:11 +0200)]
Wrap the non-ASCII testcases with QString::fromUtf8

And use QString::toUtf8() to recover the byte array original.

Change-Id: Ic94de12e7ac67479e85a64a86f8467428b4d22ba
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoWrap all Latin 1 strings with QString::fromLatin1 or QLatin1Strings
Thiago Macieira [Mon, 23 Apr 2012 14:38:17 +0000 (16:38 +0200)]
Wrap all Latin 1 strings with QString::fromLatin1 or QLatin1Strings

Change-Id: I1a1891b9126a2546c1872ec25aba9581cc84bb2f
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoConvert these files to ASCII or UTF-8
Thiago Macieira [Mon, 23 Apr 2012 13:14:24 +0000 (15:14 +0200)]
Convert these files to ASCII or UTF-8

Remove all non-UTF-8 sequences from source code in Qt.

Change-Id: I46d9cb23ef2199894896f171d553b3144822f36c
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoForce tst_qstring to use fromLatin1 where it has Latin 1 literals
Thiago Macieira [Mon, 23 Apr 2012 13:01:33 +0000 (15:01 +0200)]
Force tst_qstring to use fromLatin1 where it has Latin 1 literals

Change-Id: I941d20733da2987ca7ced14c314adebaf6a431f6
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoFix QWindow autotest for Windows.
Miikka Heikkinen [Fri, 27 Apr 2012 13:45:24 +0000 (16:45 +0300)]
Fix QWindow autotest for Windows.

The test was flawed, as it didn't process queued events before checking
for received event counts, which caused window minimum size enforcement
triggered resizes to be missed. Added event processing steps before
critical checks and also increased the size of the windows so that
event counts are predictable also on Windows.

Note that this might also fix the issues this test has on Mac, but I
can't test that.

Task-number: QTBUG-24904
Change-Id: I01a4bd1ddabcf3650a8abff67b03c75b9c40a626
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoRemove old Qt4 to-do comment.
Jason McDonald [Fri, 27 Apr 2012 09:47:33 +0000 (19:47 +1000)]
Remove old Qt4 to-do comment.

Addressing the comment would likely break existing applications, so
leave things as they are for now.

Task-number: QTBUG-25099
Change-Id: I7dfd0e1ae121dcae57c2babc3373c2e5d16ad44b
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoMove QWinEventNotifier data members to a private class
Shane Kearns [Tue, 24 Apr 2012 12:33:22 +0000 (13:33 +0100)]
Move QWinEventNotifier data members to a private class

This is a binary incompatible change to allow future changes
to QWinEventNotifier to be possible in a binary compatible way.

Change-Id: I268d3e01d8ee237ecbd164ee0f7cae1eb73dd725
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@nokia.com>
Reviewed-by: Debao Zhang <dbzhang800@gmail.com>
12 years agoReplace QGuiApplication::activeWindow by focusWindow().
Friedemann Kleint [Thu, 26 Apr 2012 07:33:16 +0000 (09:33 +0200)]
Replace QGuiApplication::activeWindow by focusWindow().

Fix deprecation warnings.

Change-Id: I8d33aa8c035df6f5ef3fff6a402e980e43e03406
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoWindows: Fix warning about retrieving the handle from non-toplevels.
Friedemann Kleint [Fri, 27 Apr 2012 09:06:41 +0000 (11:06 +0200)]
Windows: Fix warning about retrieving the handle from non-toplevels.

Change-Id: I967f218c98309e77371717aa16e46995a767caa3
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoQWindowsBackingStore: Flush to correct window.
Friedemann Kleint [Fri, 27 Apr 2012 12:01:26 +0000 (14:01 +0200)]
QWindowsBackingStore: Flush to correct window.

Task-number: QTBUG-25435

Change-Id: I13f57a328a7ac3402fe0def9d724f7e700016c80
Reviewed-by: Jonathan Liu <net147@gmail.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoRemove deprecation tags from QWheelEvent.
Morten Johan Sorvig [Thu, 26 Apr 2012 08:29:16 +0000 (10:29 +0200)]
Remove deprecation tags from QWheelEvent.

0df1c9f1 enabled deprecation warnings from Qt,
causing warnings from QWheelEvent use.

Using delta() and orientation() in new code is still
not advised, but since QtWidgets uses them the
"deprecated" tag is not suitable.

Change-Id: I597e8ddf9fd2dc911d0e30044e96df744982ff81
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoWindows/Vista style: Fix painting of QGroupBox.
Friedemann Kleint [Thu, 26 Apr 2012 13:38:17 +0000 (15:38 +0200)]
Windows/Vista style: Fix painting of QGroupBox.

QGroupBox in Vista style does not show a frame, currently.

drawBackgroundDirectly should also be called if the paintDevice
is a backing store.

Task-number: QTBUG-25395
Change-Id: Ifa20802dea6c182904f68271ddd0d175007e4b0e
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@digia.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
12 years agoFix warning about int-truncation (MSVC2010, 64bit).
Friedemann Kleint [Tue, 24 Apr 2012 14:48:40 +0000 (16:48 +0200)]
Fix warning about int-truncation (MSVC2010, 64bit).

Change-Id: Idfc483ccb80a8bbad128672052edfa04635bd532
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
12 years agodoc: removed wrong license headers from several .pro snippets
Rohan McGovern [Fri, 27 Apr 2012 02:45:22 +0000 (12:45 +1000)]
doc: removed wrong license headers from several .pro snippets

qmake can't parse /* C-style comments */.  The license headers in these
files should use # as the comment delimiter.  However, .pro files anyway
don't need license headers, so just remove them.

Continues from commit 8dea79701579f78023c6b40c4b5cbea278bc62c1, which
removed the header from one file.

Change-Id: Ib227aabb27224fc1fe89b7ced4fbbf7b1af8b193
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
12 years agoAdd QMetaMethod::fromSignal() function
Kent Hansen [Sun, 22 Apr 2012 20:44:58 +0000 (22:44 +0200)]
Add QMetaMethod::fromSignal() function

Given a member function that's a signal, returns the corresponding
QMetaMethod. Inspired by the implementation of the template-based
QObject::connect().

The primary use case for this function is to have an effective and
exact (not subject to shadowing) way of checking whether a known
signal was connected to in reimplementations of
QObject::connectNotify(QMetaMethod), avoiding string comparisons.
Example:

void MyObject::connectNotify(const QMetaMethod &signal)
{
    if (signal == QMetaMethod::fromSignal(&MyObject::mySignal)) {
        // Someone connected to mySignal ...
    }
}

Change-Id: I5e4de434275fe543c004d569dcaa9ceda3442f03
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>