profile/ivi/webkit-efl.git
12 years agoStyleElement ownerNode is not cleared correctly
arv@chromium.org [Wed, 11 Apr 2012 19:21:59 +0000 (19:21 +0000)]
StyleElement ownerNode is not cleared correctly
https://bugs.webkit.org/show_bug.cgi?id=83696

Reviewed by Antti Koivisto.

Source/WebCore:

When the css text changes in such a way that we remove the sheet of a style element or a link[rel=stylesheet]
element we need to ensure that the ownerNode of the sheet is cleared. If we don't do this and there is a
wrapper for the sheet the sheet is kept alive but the ownerNode of the sheet may point to a deleted node.

Tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html
       fast/dom/StyleSheet/detached-sheet-owner-node.html

* dom/StyleElement.cpp:
(WebCore::StyleElement::removedFromDocument):
(WebCore::StyleElement::clearSheet):
(WebCore):
(WebCore::StyleElement::createSheet):
* dom/StyleElement.h:
(StyleElement):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::clearSheet):
(WebCore):
* html/HTMLLinkElement.h:
(HTMLLinkElement):

LayoutTests:

* fast/dom/StyleSheet/detached-sheet-owner-node-expected.txt: Added.
* fast/dom/StyleSheet/detached-sheet-owner-node-link-expected.txt: Added.
* fast/dom/StyleSheet/detached-sheet-owner-node-link.html: Added.
* fast/dom/StyleSheet/detached-sheet-owner-node.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOptimize String.split() for 1 character separator
benjamin@webkit.org [Wed, 11 Apr 2012 19:09:31 +0000 (19:09 +0000)]
Optimize String.split() for 1 character separator
https://bugs.webkit.org/show_bug.cgi?id=83546

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-11
Reviewed by Gavin Barraclough.

This patch adds a serie of optimizations to make stringProtoFuncSplit() faster in the common case
where the separator is a single character.

The two main gains are:
-Use of the find() function with a single character instead of doing a full string matching.
-Use of WTF::find() instead of UString::find() to avoid branching on is8Bit() and have a simpler inline
 function.

The code is also changed to avoid making unnecessary allocations by converting the 8bit string to 16bits.

This makes String.split() faster by about 13% in that particular case.

* runtime/StringPrototype.cpp:
(JSC):
(JSC::splitStringByOneCharacterImpl):
(JSC::stringProtoFuncSplit):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=83614
hyatt@apple.com [Wed, 11 Apr 2012 18:35:37 +0000 (18:35 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=83614
<rdar://problem/11177351>

REGRESSION: Table on wikipedia overlaps float on right hand side.

Revise how auto margins are resolved so that for objects that avoid floats, the available line
width is always used instead of the overall containing block width. computeLogicalWidth now
always properly computes inline margins (based off the object's current logicalTop() position)
and so the code in computeStartPositionDeltaForChildAvoidingFloats that recomputes inline
direction margins can now be removed.

Reviewed by Dan Bernstein.

Added new test in fast/block/float.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::shrinkToAvoidFloats):
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=83614

Improve how auto margins are handled on objects that avoid floats. Add a new test covering this
for tables and overflow sections and revise existing results. The CSS2.1 test in particular is
a progression.

Reviewed by Dan Bernstein.

* fast/block/float/avoiding-float-centered.html: Added.
* platform/mac/css2.1/20110323/replaced-elements-001-expected.txt:
* platform/mac/fast/block/float/avoiding-float-centered-expected.png: Added.
* platform/mac/fast/block/float/avoiding-float-centered-expected.txt: Added.
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed gardening. Found EFL results.
tomz@codeaurora.org [Wed, 11 Apr 2012 18:30:52 +0000 (18:30 +0000)]
Unreviewed gardening.  Found EFL results.

* platform/efl/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-color-border-box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/box-shadow-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/color-behind-images-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-actual.txt: Added.
* platform/efl/ietestcenter/css3/bordersbackgrounds/order-of-images-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-001-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-002-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-003-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-004-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-005-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-006-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-007-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-008-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-009-actual.txt: Added.
* platform/efl/ietestcenter/css3/text/textshadow-010-actual.txt: Added.
* platform/efl/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix regression where a clip style change did not update layer sizes
enne@google.com [Wed, 11 Apr 2012 18:20:23 +0000 (18:20 +0000)]
Fix regression where a clip style change did not update layer sizes
https://bugs.webkit.org/show_bug.cgi?id=82990

Reviewed by Simon Fraser.

Source/WebCore:

After r111456, the size of composited layers also used clip, whereas
it previously had only used overflow. Because of this, when clip
changes on a render layer, it needs to recalculate its layer tree.

Test: compositing/clip-change.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):

LayoutTests:

* compositing/clip-change-expected.png: Added.
* compositing/clip-change-expected.txt: Added.
* compositing/clip-change.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoExpectations update after 81936 and 82734
tomz@codeaurora.org [Wed, 11 Apr 2012 18:03:37 +0000 (18:03 +0000)]
Expectations update after 81936 and 82734
https://bugs.webkit.org/show_bug.cgi?id=81936

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-04-11
Reviewed by Adam Barth.

* platform/mac/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
* platform/mac/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
* platform/mac/test_expectations.txt:
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-applies-to-block-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background_color_padding_box-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-003-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-005-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-010-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-content-edge-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-initial-value-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-not-inherited-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-003-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-003-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/box-shadow-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/color-behind-images-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/order-of-images-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-001-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-002-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-003-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-004-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-006-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-007-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-008-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-009-expected.txt: Added.
* platform/qt/ietestcenter/css3/text/textshadow-010-expected.txt: Added.
* platform/qt/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoV8 bindings are polluting WebCore namespace with overly generic FooInternal namespaces
antti@apple.com [Wed, 11 Apr 2012 18:02:10 +0000 (18:02 +0000)]
V8 bindings are polluting WebCore namespace with overly generic FooInternal namespaces
https://bugs.webkit.org/show_bug.cgi?id=83699

Reviewed by Adam Barth.

Call them FooV8Internal instead.

* bindings/scripts/CodeGeneratorV8.pm:
(GetFunctionTemplateCallbackName):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Add OVERRIDE annotations for cc animation-related interfaces
jamesr@google.com [Wed, 11 Apr 2012 17:58:33 +0000 (17:58 +0000)]
[chromium] Add OVERRIDE annotations for cc animation-related interfaces
https://bugs.webkit.org/show_bug.cgi?id=83650

Reviewed by Daniel Bates.

This adds OVERRIDE annotations to the implementations of the following interfaces:
- CCAnimationCurve
- CCFloatAnimationCurve
- CCLayerAnimationControllerClient
- CCTransformAnimationCurve

Source/WebCore:

* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/cc/CCTimingFunction.h:
* platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
(CCKeyframedFloatAnimationCurve):
(CCKeyframedTransformAnimationCurve):
* platform/graphics/chromium/cc/CCLayerImpl.h:

Source/WebKit/chromium:

* tests/CCAnimationTestCommon.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix bug where stroke's bounding box was clipped
pdr@google.com [Wed, 11 Apr 2012 17:50:55 +0000 (17:50 +0000)]
Fix bug where stroke's bounding box was clipped
https://bugs.webkit.org/show_bug.cgi?id=83651

Reviewed by Dirk Schulze.

Source/WebCore:

This change contains two fixes for one bug:
1) FloatRect::contains contained a nasty mistake where
   maxy() < y() was compared instead of maxy() < point.y().
2) RenderSVGShape::strokeContains was depending on its internal
   m_strokeAndMarkerBoundingBox instead of calling the virtual
   method strokeBoundingBox(). This change switches to using
   strokeBoundingBox().

Test: svg/hittest/svg-ellipse-rect-stroke.xhtml

* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::contains):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::strokeContains):

LayoutTests:

* svg/hittest/svg-ellipse-rect-stroke-expected.txt: Added.
* svg/hittest/svg-ellipse-rect-stroke.xhtml: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoEnable the [Supplemental] IDL on BlackBerry
haraken@chromium.org [Wed, 11 Apr 2012 17:45:57 +0000 (17:45 +0000)]
Enable the [Supplemental] IDL on BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=75413

Reviewed by Rob Buis.

This patch enables the [Supplemental] IDL on BlackBerry by changing the build
flow of BlackBerry as follows.

- Previous build flow:
    foreach $idl (all IDL files) {
        generate-bindings.pl depends on $idl;
        generate-bindings.pl reads $idl;
        generate-bindings.pl generates .h and .cpp files for $idl;
    }

- New build flow (See the discussions in bug 72138 for more details):
    preprocess-idls.pl depends on all IDL files;
    preprocess-idls.pl reads all IDL files;
    preprocess-idls.pl resolves the dependency of [Supplemental=XXXX];
    preprocess-idls.pl outputs supplemental_dependency.tmp;
    foreach $idl (all IDL files) {
        generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
        generate-bindings.pl reads $idl;
        generate-bindings.pl reads supplemental_dependency.tmp;
        generate-bindings.pl generates .h and .cpp files for $idl,
            including all attributes in the IDL files that are implementing $idl;
    }

Tests: Confirm that build succeeds.
       http/tests/websocket/tests/*

* PlatformBlackBerry.cmake: This change is similar to the change we have done for
UseJSC.cmake and UseV8.cmake (bug 75345).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r113836.
commit-queue@webkit.org [Wed, 11 Apr 2012 17:44:34 +0000 (17:44 +0000)]
Unreviewed, rolling out r113836.
http://trac.webkit.org/changeset/113836
https://bugs.webkit.org/show_bug.cgi?id=83705

Broke all the WebKit2 inspector tests (Requested by andersca
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
(registerWindowClass):
* WebInspector.cpp:
(WebInspector::setTimelineProfilingEnabled):
* WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
* WebNodeHighlight.h:
(WebNodeHighlight):
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
(WebView):

Tools:

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::showWebInspector):
(WTR::LayoutTestController::closeWebInspector):
(WTR::LayoutTestController::evaluateInWebInspector):
(WTR::LayoutTestController::setJavaScriptProfilingEnabled):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r113872.
commit-queue@webkit.org [Wed, 11 Apr 2012 17:36:54 +0000 (17:36 +0000)]
Unreviewed, rolling out r113872.
http://trac.webkit.org/changeset/113872
https://bugs.webkit.org/show_bug.cgi?id=83703

broke chromium win/mac builds (Requested by simonjam on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-11

* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::initializeFonts):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
(WebCore::CCHeadsUpDisplay::drawFPSCounterText):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(CCHeadsUpDisplay):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove webkit prefix from Media Source runtime feature name.
commit-queue@webkit.org [Wed, 11 Apr 2012 17:32:54 +0000 (17:32 +0000)]
Remove webkit prefix from Media Source runtime feature name.
https://bugs.webkit.org/show_bug.cgi?id=83633

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

Source/WebCore:

* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::mediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaSourceEnabled):
* html/HTMLMediaElement.idl:

Source/WebKit/chromium:

* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableMediaSource):
(WebKit::WebRuntimeFeatures::isMediaSourceEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWider suppression.
antonm@chromium.org [Wed, 11 Apr 2012 17:05:31 +0000 (17:05 +0000)]
Wider suppression.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSingle ShareableBitmap revision blacks out WebView on Harmattan
noam.rosenthal@nokia.com [Wed, 11 Apr 2012 16:59:35 +0000 (16:59 +0000)]
Single ShareableBitmap revision blacks out WebView on Harmattan
https://bugs.webkit.org/show_bug.cgi?id=83631

When swizzling is not supported in the driver, we need to initialize the texture as RGBA,
and make sure that the manual swizzling only modifies the sub-image.

Rubber stamped by Kenneth Rohde Christiansen.

Covered by existing tests.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::swizzleBGRAToRGBA):
(WebCore::BitmapTextureGL::didReset):
(WebCore):
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] When rendering goes idle, do not count that time against frame rate
commit-queue@webkit.org [Wed, 11 Apr 2012 16:57:16 +0000 (16:57 +0000)]
[chromium] When rendering goes idle, do not count that time against frame rate
https://bugs.webkit.org/show_bug.cgi?id=73454

The FPS counter had a few issues with its reporting. The first
3 swapbuffers are non-blocking and create FPS rates that are
unrealistically high, throwing off the moving averages and
introducing false spikes into the FPS graph. There was also no
way to monitor the smoothness of the animation, or to focus in
on a particular animation or transition.

This patch updates the FPS counter code so that bad data points
are trimmed and not graphed; so that the graph itself is taller
and more legible; so that there is a clear boundary between 40FPS
and better; and to keep statistics on frame rate between
pauses in the activity in the UI so that you can trigger a
transition and read off the average and standard deviation for
that transition to judge it smooth enough or not.

Patch by Alex Nicolaou <anicolao@chromium.org> on 2012-04-11
Reviewed by James Robinson.

HUD is not testable in webkit.

* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::onFrameBegin):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawFPSCounter):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Draw missing layer tile checkerboards as checkerboards
enne@google.com [Wed, 11 Apr 2012 16:21:10 +0000 (16:21 +0000)]
[chromium] Draw missing layer tile checkerboards as checkerboards
https://bugs.webkit.org/show_bug.cgi?id=83241

Reviewed by James Robinson.

Source/WebCore:

For non-Android platforms, draw missing tile checkerboards as actual
checkerboards. Use a shader to do this so that no texture uploads are
needed. This only happens on the non-composited content host to avoid
having unexpected (or transformed and aliased) checkerboards on other
content layers.

* WebCore.gypi:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setDrawCheckerboardForMissingTiles):
(WebCore::LayerChromium::drawCheckerboardForMissingTiles):
(LayerChromium):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore):
(WebCore::LayerRendererChromium::checkerboardProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderCheckerboard::FragmentShaderCheckerboard):
(WebCore):
(WebCore::FragmentShaderCheckerboard::init):
(WebCore::FragmentShaderCheckerboard::getShaderString):
* platform/graphics/chromium/ShaderChromium.h:
(FragmentShaderCheckerboard):
(WebCore::FragmentShaderCheckerboard::alphaLocation):
(WebCore::FragmentShaderCheckerboard::texTransformLocation):
(WebCore::FragmentShaderCheckerboard::frequencyLocation):
(WebCore):
* platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.h.
(WebCore):
(WebCore::CCCheckerboardDrawQuad::create):
(WebCore::CCCheckerboardDrawQuad::CCCheckerboardDrawQuad):
* platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.h.
(WebCore):
(CCCheckerboardDrawQuad):
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toCheckerboardDrawQuad):
(WebCore):
* platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore):
(CCDrawQuad):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::setDrawCheckerboardForMissingTiles):
(WebCore::CCLayerImpl::drawCheckerboardForMissingTiles):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForLayer):
* platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
(CCScrollbarLayerImpl):
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h:
(CCSolidColorLayerImpl):
* platform/graphics/chromium/cc/CCTextureLayerImpl.h:
(CCTextureLayerImpl):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
(CCVideoLayerImpl):

Source/WebKit/chromium:

Rename usedCheckerboard to hadMissingTile to avoid confusion. Update
tests to not expect SolidColor quads for checkerboards.

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
* tests/CCQuadCullerTest.cpp:
(WebCore::appendQuads):
* tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
* tests/CCTiledLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon::getQuads):
* tests/LayerChromiumTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Initial cookies API for WebKit2 GTK+ API
carlosgc@webkit.org [Wed, 11 Apr 2012 16:14:45 +0000 (16:14 +0000)]
[GTK] Initial cookies API for WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=82441

Reviewed by Gustavo Noronha Silva.

* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitCookieManager.cpp: Added.
(webkit_cookie_manager_init):
(webkitCookieManagerFinalize):
(webkit_cookie_manager_class_init):
(webkitCookieManagerCreate): Create a new WebKitCookieManager for
the given WKCookieManagerRef.
(webkit_cookie_manager_set_accept_policy): Set the cookie
acceptance policy.
(webkitCookieManagerGetAcceptPolicyCallback): Callback called by
the C API when the cookie acceptance policy has been received.
(webkit_cookie_manager_get_accept_policy): Asynchronously get the
cookie acceptance policy.
(webkit_cookie_manager_get_accept_policy_finish): Finish async
operation started by webkit_cookie_manager_get_accept_policy()
returning the cookie acceptance policy.
(webkitCookieManagerGetDomainsWithCookiesCallback): Callback
called by the C API when the list of hostnames with cookies has
been received.
(webkit_cookie_manager_get_domains_with_cookies): Asynchronously
get the list of domains with cookies.
(webkit_cookie_manager_get_domains_with_cookies_finish): Finish
async operation started by
webkit_cookie_manager_get_domains_with_cookies() returning the
list of domains.
(webkit_cookie_manager_delete_cookies_for_domain): Delete all
cookies for the given domain.
(webkit_cookie_manager_delete_all_cookies): Delete all cookies.
* UIProcess/API/gtk/WebKitCookieManager.h: Added.
* UIProcess/API/gtk/WebKitCookieManagerPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_get_cookie_manager): Get the
WebKitCookieManager associated with the web context.
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new chapter for
WebKitCookieManager.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/docs/webkit2gtk.types: Add
webkit_cookie_manager_get_type.
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/TestCookieManager.cpp: Added.
(testCookieManagerAcceptPolicy):
(testCookieManagerDeleteCookies):
(serverCallback):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/webkit2.h: Include WebKitCookieManager.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening after r113738.
ossy@webkit.org [Wed, 11 Apr 2012 16:09:28 +0000 (16:09 +0000)]
[Qt] Unreviewed gardening after r113738.

* platform/qt/Skipped: Unskip a non-existing test.
* platform/qt/fast/multicol/cell-shrinkback-expected.png: Added.
* platform/qt/fast/multicol/cell-shrinkback-expected.txt: Added.
* platform/qt/fast/multicol/table-vertical-align-expected.png:
* platform/qt/fast/multicol/table-vertical-align-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[BlackBerry] Update to the thread-safe GuardedPointer API
commit-queue@webkit.org [Wed, 11 Apr 2012 16:05:49 +0000 (16:05 +0000)]
[BlackBerry] Update to the thread-safe GuardedPointer API
https://bugs.webkit.org/show_bug.cgi?id=83603

Patch by Joe Mason <jmason@rim.com> on 2012-04-11
Reviewed by Rob Buis.

Source/WebCore:

RIM PR: 134894
Make the destructors of all objects inheriting GuardedPointerBase protected or
private, and delete them using BlackBerry::Platform::deleteGuardedObject.
Access all GuardedPointers through GuardedPointerLocker. Use GuardedPointerDeleter
to delete LayerCompositingThread to avoid a deadlock.

No new tests, refactor.

Reviewed internally by Yong Li and George Staikos.

* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::~CookieDatabaseBackingStore):
* platform/blackberry/CookieManager.h:
* platform/graphics/blackberry/LayerCompositingThread.cpp:
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
(WTF::::deref):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):

Source/WebKit/blackberry:

RIM PR: 134984
Make the destructors of all objects inheriting GuardedPointerBase protected or
private, and delete them using BlackBerry::Platform::deleteGuardedObject.
Access all GuardedPointers through GuardedPointerLocker.

No new tests, refactor.

Reviewed internally by Yong Li and George Staikos.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStore::~BackingStore):
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::~WebPage):
(BlackBerry::WebKit::WebPage::destroy):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL][DRT] SVG dynamic-updates rebaseline
rakuco@webkit.org [Wed, 11 Apr 2012 16:03:40 +0000 (16:03 +0000)]
[EFL][DRT] SVG dynamic-updates rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83689

Unreviewed, EFL gardening.

Bug 83562 landed EFL fixes for SVG support from JavaScript.
This allows us to unskip the dynamic-updates/* family of SVG tests.
All results were visually inspected and produced PASS results.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-11

* platform/efl/Skipped: dynamic-updates removed.
* platform/efl/svg/dynamic-updates/: New baselines.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Fix the build on OpenGL ES2 platforms
abecsi@webkit.org [Wed, 11 Apr 2012 15:53:24 +0000 (15:53 +0000)]
[Qt] Fix the build on OpenGL ES2 platforms

Unreviewed build fix.

No new tests needed.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
Fix typo in TEXMAP_OPENGL_ES_2 define.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove unused WebVideoFrame::Format values
fischman@chromium.org [Wed, 11 Apr 2012 15:49:08 +0000 (15:49 +0000)]
Remove unused WebVideoFrame::Format values
https://bugs.webkit.org/show_bug.cgi?id=83625

Reviewed by Kenneth Russell.

Source/WebCore:

Covered by existing tests.

* platform/graphics/chromium/VideoFrameChromium.h:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::convertVFCFormatToGC3DFormat):

Source/WebKit/chromium:

* public/WebVideoFrame.h:
(WebKit):
* src/AssertMatchingEnums.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFollow up to r113863: fix chromium inspector interactive test harness.
pfeldman@chromium.org [Wed, 11 Apr 2012 15:40:20 +0000 (15:40 +0000)]
Follow up to r113863: fix chromium inspector interactive test harness.

* src/js/Tests.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: Web Inspector: extracting NetworkRequest from Resource (step 1)
pfeldman@chromium.org [Wed, 11 Apr 2012 15:29:42 +0000 (15:29 +0000)]
Source/WebCore: Web Inspector: extracting NetworkRequest from Resource (step 1)
https://bugs.webkit.org/show_bug.cgi?id=83684

Reviewed by Yury Semikhatsky.

Meta bug: https://bugs.webkit.org/show_bug.cgi?id=61363.
In this step, NetworkRequest is introduced. It temporarily inherits from
the Resource, but all the call sites are now referring to it as to request.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView):
(WebInspector.AuditLauncherView.prototype._onRequestStarted):
(WebInspector.AuditLauncherView.prototype._onRequestFinished):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.getDomainToResourcesMap):
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.GzipRule.prototype._isCompressed):
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
(WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.CacheControlRule.prototype.doRun):
(WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype._cacheableAndNonCacheableResources):
(WebInspector.AuditRules.CacheControlRule.prototype.execCheck):
(WebInspector.AuditRules.CacheControlRule.prototype.freshnessLifetimeGreaterThan):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.hasResponseHeader):
(WebInspector.AuditRules.CacheControlRule.prototype.isCompressible):
(WebInspector.AuditRules.CacheControlRule.prototype.isPubliclyCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.responseHeaderMatch):
(WebInspector.AuditRules.CacheControlRule.prototype.hasExplicitExpiration):
(WebInspector.AuditRules.CacheControlRule.prototype._isExplicitlyNonCacheable):
(WebInspector.AuditRules.CacheControlRule.prototype.isCacheableResource):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.handleNonCacheableResources):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._missingExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._varyCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneMonthExpirationCheck):
(WebInspector.AuditRules.BrowserCacheControlRule.prototype._oneYearExpirationCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype.runChecks):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._questionMarkCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._publicCachingCheck):
(WebInspector.AuditRules.ProxyCacheControlRule.prototype._setCookieCacheableCheck):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun.resultCallback):
(WebInspector.AuditRules.CookieRuleBase.prototype.doRun):
(WebInspector.AuditRules.CookieRuleBase.prototype.mapResourceCookies):
(WebInspector.AuditRules.CookieRuleBase.prototype._callbackForResourceCookiePairs):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype._executeAudit):
(WebInspector.AuditCategory.prototype.run):
(WebInspector.AuditRule.prototype.run):
(WebInspector.AuditRule.prototype.doRun):
* inspector/front-end/ConsoleMessage.js:
* inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
* inspector/front-end/ContentProviders.js:
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.ResourceContentProvider.prototype.searchInContent):
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetHAR):
(WebInspector.ExtensionServer.prototype._notifyRequestFinished):
* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry):
(WebInspector.HAREntry.prototype.build):
(WebInspector.HAREntry.prototype._buildRequest):
(WebInspector.HAREntry.prototype._buildResponse):
(WebInspector.HAREntry.prototype._buildContent):
(WebInspector.HAREntry.prototype._buildTimings):
(WebInspector.HAREntry.prototype._buildPostData):
(WebInspector.HAREntry.prototype._buildCookie):
(WebInspector.HAREntry.prototype._interval):
(WebInspector.HAREntry.prototype.get requestBodySize):
(WebInspector.HAREntry.prototype.get responseBodySize):
(WebInspector.HAREntry.prototype.get responseCompression):
(WebInspector.HARLog):
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._buildPages):
(WebInspector.HARLog.prototype._convertResource):
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
* inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog):
(WebInspector.NetworkLog.prototype.get requests):
(WebInspector.NetworkLog.prototype.pageLoadForRequest):
(WebInspector.NetworkLog.prototype._onMainFrameNavigated):
(WebInspector.NetworkLog.prototype._onRequestStarted):
(WebInspector.NetworkLog.prototype._onLoad):
(WebInspector.PageLoad):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.inflightRequestForURL):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromCache):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.dataReceived):
(WebInspector.NetworkDispatcher.prototype.loadingFinished):
(WebInspector.NetworkDispatcher.prototype.loadingFailed):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketClosed):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._finishNetworkRequest):
(WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners):
(WebInspector.NetworkDispatcher.prototype._createNetworkRequest):
(get WebInspector):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._initializeView):
(WebInspector.NetworkLogView.prototype.get statusBarItems):
(WebInspector.NetworkLogView.prototype._createSortingFunctions):
(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkLogView.prototype._updateDividersIfNeeded):
(WebInspector.NetworkLogView.prototype._invalidateAllItems):
(WebInspector.NetworkLogView.prototype._requestGridNode):
(WebInspector.NetworkLogView.prototype._createRequestGridNode):
(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype.get requests):
(WebInspector.NetworkLogView.prototype.requestById):
(WebInspector.NetworkLogView.prototype._onRequestStarted):
(WebInspector.NetworkLogView.prototype._appendRequest):
(WebInspector.NetworkLogView.prototype._onRequestUpdated):
(WebInspector.NetworkLogView.prototype._refreshRequest):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
(WebInspector.NetworkLogView.prototype.get _setLargerRequests):
(WebInspector.NetworkLogView.prototype._getPopoverAnchor):
(WebInspector.NetworkLogView.prototype._showPopover):
(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkLogView.prototype._copyAll):
(WebInspector.NetworkLogView.prototype._copyRequest):
(WebInspector.NetworkLogView.prototype._copyLocation):
(WebInspector.NetworkLogView.prototype._copyRequestHeaders):
(WebInspector.NetworkLogView.prototype._copyResponseHeaders):
(WebInspector.NetworkLogView.prototype._exportAll):
(WebInspector.NetworkLogView.prototype._exportRequest):
(WebInspector.NetworkLogView.prototype._matchRequest):
(WebInspector.NetworkLogView.prototype._clearSearchMatchedList):
(WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):
(WebInspector.NetworkLogView.prototype._updateHighlightIfMatched):
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):
(WebInspector.NetworkLogView.prototype.performSearch):
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkLogView.prototype.revealAndHighlightRequest):
(WebInspector.NetworkPanel.prototype.handleShortcut):
(WebInspector.NetworkPanel.prototype.get requests):
(WebInspector.NetworkPanel.prototype.requestById):
(WebInspector.NetworkPanel.prototype._requestByAnchor):
(WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
(WebInspector.NetworkPanel.prototype.showAnchorLocation):
(WebInspector.NetworkPanel.prototype.revealAndHighlightRequest):
(WebInspector.NetworkPanel.prototype._onViewCleared):
(WebInspector.NetworkPanel.prototype._onRequestSelected):
(WebInspector.NetworkPanel.prototype._showRequest):
(WebInspector.NetworkPanel.prototype._closeVisibleRequest):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingRequestMode):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphPercentages):
(WebInspector.NetworkTimeCalculator.prototype.computeBarGraphLabels):
(WebInspector.NetworkTimeCalculator.prototype.updateBoundaries):
(WebInspector.NetworkTimeCalculator.prototype._lowerBound):
(WebInspector.NetworkTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._lowerBound):
(WebInspector.NetworkTransferTimeCalculator.prototype._upperBound):
(WebInspector.NetworkTransferDurationCalculator.prototype._upperBound):
(WebInspector.NetworkDataGridNode):
(WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
(WebInspector.NetworkDataGridNode.prototype.select):
(WebInspector.NetworkDataGridNode.prototype._openInNewTab):
(WebInspector.NetworkDataGridNode.prototype.get selectable):
(WebInspector.NetworkDataGridNode.prototype._createTimelineCell):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
(WebInspector.NetworkDataGridNode.prototype._fileName):
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
(WebInspector.NetworkDataGridNode.prototype._refreshSizeCell):
(WebInspector.NetworkDataGridNode.prototype._refreshTimeCell):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):
(WebInspector.NetworkDataGridNode.NameComparator):
(WebInspector.NetworkDataGridNode.SizeComparator):
(WebInspector.NetworkDataGridNode.InitiatorComparator):
(WebInspector.NetworkDataGridNode.RequestPropertyComparator):
* inspector/front-end/NetworkRequest.js: Added.
(WebInspector.NetworkRequest):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype._requestFinished):
(WebInspector.RawSourceCode.prototype._createContentProvider):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.displayName):
(WebInspector.Resource.prototype.get request):
(WebInspector.Resource.prototype.set finished):
(WebInspector.Resource.prototype.set timing):
(WebInspector.Resource.prototype.set requestHeaders):
(WebInspector.Resource.prototype.set requestHeadersText):
(WebInspector.Resource.prototype.set responseHeaders):
(WebInspector.Resource.prototype.set responseHeadersText):
(WebInspector.Resource.prototype.requestContent):
* inspector/front-end/ResourceCookiesView.js:
(WebInspector.ResourceCookiesView):
(WebInspector.ResourceCookiesView.prototype.get _gotCookies):
(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView):
(WebInspector.ResourceHeadersView.prototype._refreshURL):
(WebInspector.ResourceHeadersView.prototype._refreshQueryString):
(WebInspector.ResourceHeadersView.prototype._refreshUrlFragment):
(WebInspector.ResourceHeadersView.prototype._refreshFormData):
(WebInspector.ResourceHeadersView.prototype._refreshRequestHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshResponseHeaders):
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
* inspector/front-end/ResourceTimingView.js:
(WebInspector.ResourceTimingView):
(WebInspector.ResourceTimingView.prototype.wasShown):
(WebInspector.ResourceTimingView.prototype._refresh):
(WebInspector.ResourceTimingView.createTimingTable):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._frontendReused):
(WebInspector.ResourceTreeModel.prototype._onRequestUpdated):
(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._createResource):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._addRequest):
* inspector/front-end/ResourceUtils.js:
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/externs.js:
(WebInspector.networkRequestById):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.networkRequestById):
(WebInspector.openRequestInNetworkPanel):

Tools: Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):

LayoutTests: Web Inspector: extracting NetworkRequest from Resource (step 1)
https://bugs.webkit.org/show_bug.cgi?id=83684

Reviewed by Yury Semikhatsky.

* http/tests/inspector/network-preflight-options.html:
* http/tests/inspector/network-test.js:
* http/tests/inspector/network/async-xhr-json-mime-type.html:
* http/tests/inspector/network/download.html:
* http/tests/inspector/network/network-cachedresources-with-same-urls.html:
* http/tests/inspector/network/network-content-replacement-embed.html:
* http/tests/inspector/network/network-content-replacement-xhr.html:
* http/tests/inspector/network/network-cyrillic-xhr.html:
* http/tests/inspector/network/network-disable-cache-memory.html:
* http/tests/inspector/network/network-disable-cache-xhrs.html:
* http/tests/inspector/network/network-disabling-check-no-memory-leak.html:
* http/tests/inspector/network/network-embed.html:
* http/tests/inspector/network/network-empty-xhr.html:
* http/tests/inspector/network/network-iframe-load-and-delete.html:
* http/tests/inspector/network/network-initiator-from-console.html:
* http/tests/inspector/network/network-initiator.html:
* http/tests/inspector/network/network-request-revision-content.html:
* http/tests/inspector/network/network-shared-worker.html:
* http/tests/inspector/network/network-sidebar-width.html:
* http/tests/inspector/network/network-size-chunked.html:
* http/tests/inspector/network/network-size-sync.html:
* http/tests/inspector/network/network-size.html:
* http/tests/inspector/network/network-timing.html:
* http/tests/inspector/network/network-worker.html:
* http/tests/inspector/network/network-xhr-async.html:
* http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
* http/tests/inspector/network/network-xhr-sync.html:
* http/tests/inspector/network/ping.html:
* http/tests/inspector/network/x-frame-options-deny.html:
* http/tests/inspector/resource-har-conversion.html:
* http/tests/inspector/resource-har-headers.html:
* http/tests/inspector/resource-har-pages.html:
* http/tests/inspector/resource-parameters.html:
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.requestURLComparer):
* inspector/debugger/raw-source-code.html:
* inspector/debugger/source-frame.html:
* inspector/network-status-non-http.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMicrodata: Implement cache mechanism for HTMLPropertiesCollection.
arko@motorola.com [Wed, 11 Apr 2012 15:20:04 +0000 (15:20 +0000)]
Microdata: Implement cache mechanism for HTMLPropertiesCollection.
https://bugs.webkit.org/show_bug.cgi?id=80490

Reviewed by Ryosuke Niwa.

Implemented caching mechanism for HTMLPropertiesCollection.
propertyCache - contains microdata item properties.
itemRefElements - contains sorted microdata item and itemref elements.
propertyNames - contains microdata property names of the elements in the collection.
itemRefElementPosition - store the current position of itemRefElements.
hasItemRefElements - set to ture once we have sorted microdata item and itemref elements list i.e, itemRefElements.
Cache is invalidated only when dom tree modified. Whenever any query is made on HTMLPropertiesCollection,
result is returned from the cache. Earliar we used to calculate properties node list every time a query is made.

* html/HTMLPropertiesCollection.cpp:
(WebCore):
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::invalidateCacheIfNeeded):
(WebCore::HTMLPropertiesCollection::updateRefElements): Appends microdata item element and elements which
are added through itemref attribute in itemRefElements (in tree order).
(WebCore::nextNodeWithProperty):
(WebCore::HTMLPropertiesCollection::itemAfter): Takes parent base and previous item property as argument.
Finds the next item property in base.
(WebCore::HTMLPropertiesCollection::calcLength): Calculates the length of properties collection if length
is not available in the cache.
(WebCore::HTMLPropertiesCollection::length):
(WebCore::HTMLPropertiesCollection::firstProperty): Returns the first property in the collection.
(WebCore::HTMLPropertiesCollection::item):
(WebCore::HTMLPropertiesCollection::findProperties): Finds microdata item properties in the base element.
Appends the properties in propertyCache and property names in propertyNames.
(WebCore::HTMLPropertiesCollection::updateNameCache):  It updates the propertyCache and propertyNames if hasNameCache is false.
(WebCore::HTMLPropertiesCollection::names):
(WebCore::HTMLPropertiesCollection::namedItem):
(WebCore::HTMLPropertiesCollection::hasNamedItem):
* html/HTMLPropertiesCollection.h:
(HTMLPropertiesCollection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] InspectorServer: Add an API level auto test
jocelyn.turcotte@nokia.com [Wed, 11 Apr 2012 14:53:27 +0000 (14:53 +0000)]
[Qt] InspectorServer: Add an API level auto test
https://bugs.webkit.org/show_bug.cgi?id=83594

Reviewed by Kenneth Rohde Christiansen.

.:

* Source/tests.pri:

Source/WebKit2:

This tests InspectorServer and WebSocketServer.

* UIProcess/API/qt/tests/inspectorserver/inspectorserver.pro: Added.
* UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp: Added.
(tst_InspectorServer):
(tst_InspectorServer::tst_InspectorServer):
(tst_InspectorServer::prepareWebViewComponent):
(tst_InspectorServer::newWebView):
(tst_InspectorServer::init):
(tst_InspectorServer::cleanup):
(tst_InspectorServer::webView):
(tst_InspectorServer::fetchPageList):
(tst_InspectorServer::testPageList): This tests that pages with developerExtrasEnabled appear available for inspection.
(tst_InspectorServer::testRemoteDebuggingMessage): This tests a web socket connection using a raw inspector command.
(tst_InspectorServer::openRemoteDebuggingSession): This tests the whole pipeline by starting a remote inspection session.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView):
(tst_QQuickWebView::prepareWebViewComponent):
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/API/qt/tests/util.cpp:
(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadingChanged):
* UIProcess/API/qt/tests/util.h:
(LoadStartedCatcher):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] InspectorServer: Improve the JSON page list's parameter names
jocelyn.turcotte@nokia.com [Wed, 11 Apr 2012 14:52:19 +0000 (14:52 +0000)]
[Qt] InspectorServer: Improve the JSON page list's parameter names
https://bugs.webkit.org/show_bug.cgi?id=83592

Reviewed by Simon Hausmann.

- Add "id" that would be needed to build the URL when using local front-end resources
  (and will be used by tests)
- Rename description to "title", the description contains both the title and URL on the final list
- Rename inspectorLocation to "inspectorUrl" to match with the url parameter.

* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:
(WebKit::WebInspectorServer::buildPageList):
* qt/Resources/inspectorPageIndex.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Fix issues when using the WebView as ShaderEffectSource
jocelyn.turcotte@nokia.com [Wed, 11 Apr 2012 14:50:42 +0000 (14:50 +0000)]
[Qt] Fix issues when using the WebView as ShaderEffectSource
https://bugs.webkit.org/show_bug.cgi?id=83587

Reviewed by Noam Rosenthal.

Source/WebCore:

- Make sure that the bound frame buffer is preserved instead of binding
  to the default one
- Accept a "mirrored" flag in beginPainting that we're applying on the
  projection matrix just as with internal FBOs

The "flip" logic in createProjectionMatrix has been reversed and renamed to
mirrored so that FBO rendering is considered the special case and not the
other way around just like within Qt.

* platform/graphics/texmap/TextureMapper.h:
(WebCore::TextureMapper::beginPainting):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::TextureMapperGLData):
(TextureMapperGLData):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::createProjectionMatrix):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::bindSurface):
* platform/graphics/texmap/TextureMapperGL.h:

Source/WebKit2:

Qt is going to mirror the projection matrix when the shader effect source
is grabbed. Detect that the matrix is mirrored and pass on this information
to TextureMapper so that it can do the same.

* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* UIProcess/qt/QtWebPageSGNode.cpp:
(WebKit::ContentsSGNode::render):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Remove unnecessary rendering code
jocelyn.turcotte@nokia.com [Wed, 11 Apr 2012 14:49:21 +0000 (14:49 +0000)]
[Qt] Remove unnecessary rendering code
https://bugs.webkit.org/show_bug.cgi?id=83591

Reviewed by Noam Rosenthal.

- Remove code that isn't needed since the introduction of WebLayerTreeRenderer
- Remove TextureMapper::bindSurface(0) calls following beginPainting, which calls it itself.

* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paint):
* UIProcess/API/qt/qquickwebpage_p_p.h:
(QQuickWebPagePrivate):
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
* UIProcess/LayerTreeHostProxy.cpp:
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::paintToGraphicsContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agosvg/text/svg-zoom-large-value.xhtml ASSERTs on Chromium Linux Debug
schenney@chromium.org [Wed, 11 Apr 2012 14:00:18 +0000 (14:00 +0000)]
svg/text/svg-zoom-large-value.xhtml ASSERTs on Chromium Linux Debug
https://bugs.webkit.org/show_bug.cgi?id=63400

Unreviewed Chromium test expectation removal.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoShadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
schenney@chromium.org [Wed, 11 Apr 2012 13:41:51 +0000 (13:41 +0000)]
Shadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
https://bugs.webkit.org/show_bug.cgi?id=83484

Unreviewed attempted build fix.

* dom/ContainerNodeAlgorithms.h: Adding Document.h include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Skip a new test because of missing layoutTestController.setBackingScaleFactor...
ossy@webkit.org [Wed, 11 Apr 2012 13:31:29 +0000 (13:31 +0000)]
[Qt] Skip a new test because of missing layoutTestController.setBackingScaleFactor() implemetation.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-11
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove unnecessary assignments from CSSParser::parseLinearGradient().
macpherson@chromium.org [Wed, 11 Apr 2012 13:29:01 +0000 (13:29 +0000)]
Remove unnecessary assignments from CSSParser::parseLinearGradient().
https://bugs.webkit.org/show_bug.cgi?id=83661

Reviewed by Kentaro Hara.

No new tests / code cleanup only.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseLinearGradient):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Manage graphics buffers in the web process
noam.rosenthal@nokia.com [Wed, 11 Apr 2012 13:23:36 +0000 (13:23 +0000)]
[Qt][WK2] Manage graphics buffers in the web process
https://bugs.webkit.org/show_bug.cgi?id=78675

Make graphics surface available only for Qt 5, attempting to fix
the Qt-mac build.

Unreviewed build fix.

* qmake/mkspecs/features/features.prf:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoShadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
schenney@chromium.org [Wed, 11 Apr 2012 13:18:30 +0000 (13:18 +0000)]
Shadow tree TreeScope data is not removed by ContainerNode::removeAllChildren
https://bugs.webkit.org/show_bug.cgi?id=83484

Reviewed by Hajime Morita.

The ContainerNode::removeAllChildren method does fast and dirty node removal.
As compared to ContainerNode::removeChildren, it does not include the
method to adopt the removed child node into the root document's TreeScope.
Rather, it leaves the existing TreeScope in place. However, the existing
TreeScope may be removed, causing a crash when something prevents the child
node from being deleted immediately. The fix is to modify the code in
ContainerNodeAlgorithms to do the TreeScope adoption.

Could not reproduce crash in layout test.

* dom/ContainerNodeAlgorithms.h:
(Private):
(WebCore::Private::NodeRemovalDispatcher::dispatch):
(WebCore::Private::addChildNodesToDeletionQueue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: showing summary view is very slow on a snapshot with thousands of...
yurys@chromium.org [Wed, 11 Apr 2012 12:52:04 +0000 (12:52 +0000)]
Web Inspector: showing summary view is very slow on a snapshot with thousands of constructors
https://bugs.webkit.org/show_bug.cgi?id=83682

Node content is created only when the node becomes visible in the corresponding view.
This saves a lot of time when openning summary/comparison view of a snapshot
with lots of different classes.

Reviewed by Pavel Feldman.

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode):
(WebInspector.HeapSnapshotLazyGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode.prototype.createCells):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotDiffNode):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.DetailedHeapshotView.prototype._changeNameFilter):
* inspector/front-end/heapProfiler.css:
(.detailed-heapshot-view .data-grid tr:empty):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK NRWT follow-up fix after r113849.
philn@webkit.org [Wed, 11 Apr 2012 12:24:13 +0000 (12:24 +0000)]
Unreviewed, GTK NRWT follow-up fix after r113849.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] media/event-attributes.html fails
commit-queue@webkit.org [Wed, 11 Apr 2012 11:57:52 +0000 (11:57 +0000)]
[GTK] media/event-attributes.html fails
https://bugs.webkit.org/show_bug.cgi?id=71662

Patch by Simon Pena <spena@igalia.com> on 2012-04-11
Reviewed by Philippe Normand.

Source/WebCore:

In MediaPlayerPrivateGStreamer::didEnd, when EOS is reached, don't
synchronize position and duration on regular playback. That is:
synchronize it (and fire the durationChange signal) only on reverse
playback.

This change makes media/event-attributes.html pass. It was
previously failing because an additional durationChange signal was
emitted.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Avoid
sending durationChange signal on regular playback.

Tools:

PulseAudio's module "module-stream-restore" allows saving the volume
of a stream, restoring it the next time it runs.
This affects the tests, since DumpRenderTree's volume settings are
saved between test runs, and tests relying on specific volume values
would miss some volumeChange events (or get additional ones).

This patch hooks on the existing GtkPort setup_test_run method and
creates a new clean_up_test_run method, so PulseAudio's module is
unloaded (if found) before running the tests, and restored (if it
was there previously) after they finished, ensuring the tests run in
the right environment.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._clean_up_run): Invoke the port implementation of
clean_up_test_run.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.clean_up_test_run): Add an empty implementation of
clean_up_test_run.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._unload_pulseaudio_module): Unloads the offending
pulseaudio module, if found.
(GtkPort):
(GtkPort._restore_pulseaudio_module): Restores the offending
pulseaudio module, if it was there previously.
(GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
(GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.

LayoutTests:

Unskip tests media/video-seek-past-end-playing and
media/sources-fallback-codecs, which no longer fail, and
media/event-attributes, which is fixed with this patch.

* platform/gtk/Skipped: Unskip media/video-seek-past-end-playing,
media/sources-fallback-codecs and media/event-attributes

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the build with gcc 4.7.0
abecsi@webkit.org [Wed, 11 Apr 2012 11:23:19 +0000 (11:23 +0000)]
Fix the build with gcc 4.7.0
https://bugs.webkit.org/show_bug.cgi?id=83584

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests needed.

* Target.pri: Disable Werror on the ANGLE code since it has several recurring issues
because older versions of flex (<2.5.35) and bison (<2.5) generate code which
triggers warnings. This generated code is committed on each version update of ANGLE,
and it is very likely that the code is generated with older versions of the mentioned
tools.
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::createForJSConstructor): Fails because of -Werror=extra
* platform/graphics/TiledBackingStoreClient.h: Fails because -Werror=delete-non-virtual-dtor,
gcc requires classes which have virtual methods to have a virtual destructor, if their instances
or the instances of their subclasses are deleted.
(WebCore::TiledBackingStoreClient::~TiledBackingStoreClient):
* platform/graphics/texmap/TextureMapperPlatformLayer.h: Ditto.
(WebCore::TextureMapperPlatformLayer::~TextureMapperPlatformLayer):

Tools:

* qmake/mkspecs/features/unix/default_post.prf:
The -fuse-ld=gold option is not supported with upstream gcc.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK gardening.
philn@webkit.org [Wed, 11 Apr 2012 10:50:48 +0000 (10:50 +0000)]
Unreviewed, GTK gardening.

* platform/gtk/test_expectations.txt: Mark two a11y tests as flaky.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[V8] Calendar Picker: Add a helper function to expose PagePopupClient::setValueAndClo...
tkent@chromium.org [Wed, 11 Apr 2012 10:06:24 +0000 (10:06 +0000)]
[V8] Calendar Picker: Add a helper function to expose PagePopupClient::setValueAndClosePopup() to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=83561

Reviewed by Adam Barth.

Add ScriptController::installFunctionsForPagePopup(), which add
window.setValueAndClosePopup() for JavaScript code in PagePopup
environment, and the function calls
WebCore::PagePopupClient::setValueAndClosePopup().

This patch introduces Supplement<DOMWindow> object to hold a
PagePopupClient object. It makes keeping a PagePopupClient easier.

* WebCore.gypi: Add DOMWindowPagePopup.{cpp,h}
* bindings/v8/ScriptController.cpp:
(WebCore::setValueAndClosePopupCallback):
(WebCore::ScriptController::installFunctionsForPagePopup):
* bindings/v8/ScriptController.h:
(ScriptController): Add installFunctionsForPagePopup().
* page/DOMWindowPagePopup.cpp: Added.
(WebCore::DOMWindowPagePopup::DOMWindowPagePopup):
(WebCore::DOMWindowPagePopup::supplementName):
Returns "DOMWindowPagePopup" as a key of this Supplement<DOMWindow>.
(WebCore::DOMWindowPagePopup::setValueAndClosePopup):
Gets a DOMWindowPagePopup from the window, then calls PagePopupClient::setValueAndClosePopup().
(WebCore::DOMWindowPagePopup::install):
On-demand creation of DOMWindowPagePopup doesn't work because it
must have a PagePopupClient object. We need to install
DOMWindowPagePopup explicitly.
* page/DOMWindowPagePopup.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Add Battery Status API support.
commit-queue@webkit.org [Wed, 11 Apr 2012 10:00:21 +0000 (10:00 +0000)]
[chromium] Add Battery Status API support.

Source/WebCore:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

This change is covered by tests in batterystatus/.

* Modules/battery/BatteryController.cpp:
(WebCore::BatteryController::updateBatteryStatus):
(WebCore):
* Modules/battery/BatteryController.h:
(BatteryController):
* Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::charging):
(WebCore::BatteryManager::chargingTime):
(WebCore::BatteryManager::dischargingTime):
(WebCore::BatteryManager::level):
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

Source/WebKit/chromium:

The battery-client (BatteryClientChromium) will notify the client (WebBatteryStatusClient) when to start or stop
sending battery status updates. The client, in response will send the notifications to WebViewImpl, which sends
this update information to the WebCore::BatteryClient, and it triggers the appropriate javascript-callbacks.
The spec is at http://www.w3.org/TR/2011/WD-battery-status-20111129/.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

* WebKit.gyp:
* features.gypi:
* public/WebBatteryStatus.h: Added.
(WebKit):
(WebBatteryStatus):
(WebKit::WebBatteryStatus::WebBatteryStatus):
* public/WebBatteryStatusClient.h: Added.
(WebKit):
(WebBatteryStatusClient):
(WebKit::WebBatteryStatusClient::~WebBatteryStatusClient):
* public/WebView.h:
(WebKit):
(WebView):
(WebKit::WebView::updateBatteryStatus):
* public/WebViewClient.h:
(WebKit):
(WebViewClient):
(WebKit::WebViewClient::batteryStatusClient):
* src/BatteryClientImpl.cpp: Added.
(WebKit):
(WebKit::BatteryClientImpl::BatteryClientImpl):
(WebKit::BatteryClientImpl::updateBatteryStatus):
(WebKit::BatteryClientImpl::setController):
(WebKit::BatteryClientImpl::startUpdating):
(WebKit::BatteryClientImpl::stopUpdating):
(WebKit::BatteryClientImpl::batteryControllerDestroyed):
* src/BatteryClientImpl.h: Added.
(WebKit):
(BatteryClientImpl):
(WebKit::BatteryClientImpl::~BatteryClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):
* src/WebViewImpl.h:
(WebKit):
(WebViewImpl):

LayoutTests:

Add Battery Status API support to chromium.
https://bugs.webkit.org/show_bug.cgi?id=83284

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-04-11
Reviewed by Adam Barth.

* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro
paroga@webkit.org [Wed, 11 Apr 2012 09:44:20 +0000 (09:44 +0000)]
[CMake] Add WEBKIT_CREATE_FORWARDING_HEADERS macro
https://bugs.webkit.org/show_bug.cgi?id=83574

Reviewed by Daniel Bates.

This new macro generates forwarding headers with absolute paths to the original files.
It accepts a list of files and/or a list of directories as input.

* Source/cmake/WebKitMacros.cmake:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK gardening.
philn@webkit.org [Wed, 11 Apr 2012 09:43:01 +0000 (09:43 +0000)]
Unreviewed, GTK gardening.

* platform/gtk/test_expectations.txt: Mark an editing test as flaky.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[CSS Regions]Add helper class for flow threads info in RenderView
mihnea@adobe.com [Wed, 11 Apr 2012 09:41:37 +0000 (09:41 +0000)]
[CSS Regions]Add helper class for flow threads info in RenderView
https://bugs.webkit.org/show_bug.cgi?id=83464

Reviewed by David Hyatt.

This patch creates a new helper class FlowThreadController that will accommodate all the flow thread
related info from RenderView and moves all the data structures/methods from RenderView into this new class.
There is only one FlowThreadController object per RenderView and it can be retrieved using flowThreadController() method from RenderView.
The flow thread controller object is owned by the RenderView and it is created on demand only if there are flowing
threads in the page.

Since there is no change in functionality, there are no new tests added.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* rendering/FlowThreadController.cpp: Added.
(WebCore):
(WebCore::FlowThreadController::create):
(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::~FlowThreadController):
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
* rendering/FlowThreadController.h: Added.
(WebCore):
(FlowThreadController):
(WebCore::FlowThreadController::currentRenderFlowThread):
(WebCore::FlowThreadController::setCurrentRenderFlowThread):
(WebCore::FlowThreadController::isRenderNamedFlowThreadOrderDirty):
(WebCore::FlowThreadController::setIsRenderNamedFlowThreadOrderDirty):
(WebCore::FlowThreadController::renderNamedFlowThreadList):
(WebCore::FlowThreadController::hasRenderNamedFlowThreads):
* rendering/RenderFlowThread.cpp:
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadDisabler::CurrentRenderFlowThreadDisabler):
(WebCore::CurrentRenderFlowThreadDisabler::~CurrentRenderFlowThreadDisabler):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::addDependencyOnFlowThread):
(WebCore::RenderNamedFlowThread::removeDependencyOnFlowThread):
* rendering/RenderNamedFlowThread.h:
(RenderNamedFlowThread):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
(WebCore::RenderObject::enclosingRenderFlowThread):
(WebCore::RenderObject::willBeDestroyed):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderNamedFlowThreads):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::hasRenderNamedFlowThreads):
(WebCore::RenderView::flowThreadController):
* rendering/RenderView.h:
(WebCore):
(RenderView):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL][DRT] SVG Filters rebaseline
commit-queue@webkit.org [Wed, 11 Apr 2012 09:29:51 +0000 (09:29 +0000)]
[EFL][DRT] SVG Filters rebaseline
https://bugs.webkit.org/show_bug.cgi?id=83673

Unreviewed, EFL rebaseline.

Bug 83562 fixed programmatically creating filters from JS, this
allows us to unskip a lot of SVG tests. This is part two.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-11

* platform/efl/Skipped: Removed svg/filters/*.
* platform/efl/svg/filters/: New baselines.
* platform/efl/test_expectations.txt: Added one dropShadow filter failure.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: [Device Metrics] Implement dimension swapping
apavlov@chromium.org [Wed, 11 Apr 2012 09:16:11 +0000 (09:16 +0000)]
Web Inspector: [Device Metrics] Implement dimension swapping
https://bugs.webkit.org/show_bug.cgi?id=83676

The change adds a "Swap dimensions" button that swaps the emulated device dimensions to
mimic the device rotation (give that the ORIENTATION_EVENTS feature is disabled in Chromium).

Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement.swapDimensionsClicked):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRefactor PerfTestRunner to include file extensions in test names
rniwa@webkit.org [Wed, 11 Apr 2012 08:54:53 +0000 (08:54 +0000)]
Refactor PerfTestRunner to include file extensions in test names
https://bugs.webkit.org/show_bug.cgi?id=83677

Reviewed by Hajime Morita.

Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._collect_tests):
(PerfTestsRunner._run_tests_set):
(PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
(PerfTestsRunner._run_single_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(run_test):
(_tests_for_runner):
(test_run_test_set):
(test_run_test_set_kills_drt_per_run):
(test_run_test_pause_before_testing):
(test_run_test_set_for_parser_tests):
(test_collect_tests):
(test_collect_tests_with_skipped_list):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compiler warnings for generated CalendarPicker.cpp with VC++
tkent@chromium.org [Wed, 11 Apr 2012 08:52:32 +0000 (08:52 +0000)]
Fix compiler warnings for generated CalendarPicker.cpp with VC++
https://bugs.webkit.org/show_bug.cgi?id=83672

Reviewed by Kentaro Hara.

* make-file-arrays.py:
(main): Do not generate literal integers larger than 127 for
members of char arrays. Use '\xHH' instead.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK rebaseline and baselines for new tests.
philn@webkit.org [Wed, 11 Apr 2012 08:49:30 +0000 (08:49 +0000)]
Unreviewed, GTK rebaseline and baselines for new tests.

* platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
* platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
* platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
* platform/gtk/fast/table/cell-pref-width-invalidation-expected.txt:
* platform/gtk/fast/text/text-shadow-no-default-color-expected.txt: Added.
* platform/gtk/ietestcenter/: Added.
* platform/gtk/tables/mozilla/bugs/bug2123-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2509-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug34176-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Disabling Inspector causes build failure on Windows
commit-queue@webkit.org [Wed, 11 Apr 2012 08:49:18 +0000 (08:49 +0000)]
Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-11
Reviewed by Pavel Feldman.

Source/WebKit/win:

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

* WebCoreSupport/WebInspectorClient.cpp:
* WebInspector.cpp:
* WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
* WebNodeHighlight.h:
(WebNodeHighlight):
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
(WebView):

Tools:

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: fix category -> type refactoring implications.
pfeldman@chromium.org [Wed, 11 Apr 2012 08:38:33 +0000 (08:38 +0000)]
Web Inspector: fix category -> type refactoring implications.
https://bugs.webkit.org/show_bug.cgi?id=83680

Reviewed by Yury Semikhatsky.

We are now using type identifiers (singulars) as opposed to category identifier (plurals) in the style.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems.createFilterElement):
(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems):
(WebInspector.NetworkLogView.prototype._showCategory):
(WebInspector.NetworkLogView.prototype._hideCategory):
(WebInspector.NetworkLogView.prototype._filter):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement):
(WebInspector.ResourceRevisionTreeElement):
* inspector/front-end/networkLogView.css:
(.network-log-grid.data-grid .network-type-script .icon):
(.network-log-grid.data-grid.small .network-type-script .icon):
(.network-log-grid.data-grid .network-type-document .icon):
(.network-log-grid.data-grid.small .network-type-document .icon):
(.network-log-grid.data-grid .network-type-stylesheet .icon):
(.network-log-grid.data-grid.small .network-type-stylesheet .icon):
(.network-log-grid.data-grid .network-type-image .icon):
(.network-log-grid.data-grid.small .network-type-image .icon):
(.network-type-document .network-graph-bar):
(.network-type-document.resource-cached .network-graph-bar):
(.network-type-stylesheet .network-graph-bar):
(.network-type-stylesheet.resource-cached .network-graph-bar):
(.network-type-image .network-graph-bar):
(.network-type-image.resource-cached .network-graph-bar):
(.network-type-font .network-graph-bar):
(.network-type-font.resource-cached .network-graph-bar):
(.network-type-script .network-graph-bar):
(.network-type-script.resource-cached .network-graph-bar):
(.network-type-xhr .network-graph-bar):
(.network-type-xhr.resource-cached .network-graph-bar):
(.network-type-websocket .network-graph-bar):
(.network-type-websocket.resource-cached .network-graph-bar):
(.network-log-grid.data-grid.filter-other table.data tr.revealed.network-type-other):
* inspector/front-end/resourcesPanel.css:
(.resource-sidebar-tree-item.resources-type-image .icon):
(.resources-type-image .image-resource-icon-preview):
(.children.small .resource-sidebar-tree-item.resources-type-image .icon):
(.children.small .resources-type-image .image-resource-icon-preview):
(.resource-sidebar-tree-item.resources-type-document .icon):
(.children.small .resource-sidebar-tree-item.resources-type-document .icon):
(.resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.children.small .resource-sidebar-tree-item.resources-type-stylesheet .icon):
(.resource-sidebar-tree-item.resources-type-font .icon):
(.children.small .resource-sidebar-tree-item.resources-type-font .icon):
(.resource-sidebar-tree-item.resources-type-script .icon):
(.children.small .resource-sidebar-tree-item.resources-type-script .icon):
(.resource-sidebar-tree-item.resources-type-xhr .icon):
(.children.small .resource-sidebar-tree-item.resources-type-xhr .icon):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK gardening.
philn@webkit.org [Wed, 11 Apr 2012 08:29:12 +0000 (08:29 +0000)]
Unreviewed, GTK gardening.

* platform/gtk/Skipped: Skip failing ref test
* platform/gtk/test_expectations.txt: Mark two tests as crashing
and unskip tests needing rebaseline.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] ImageBuffer: Canonical mimeType for encoding implies startsWith('image/')
noel.gordon@gmail.com [Wed, 11 Apr 2012 07:02:17 +0000 (07:02 +0000)]
[GTK] ImageBuffer: Canonical mimeType for encoding implies startsWith('image/')
https://bugs.webkit.org/show_bug.cgi?id=83657

Reviewed by Martin Robinson.

Canonical image mimeTypes begin with "image/", and this is tested by an ASSERT
guard in toDataURL(): that checks the WebCore mimeType registry for image-for-
encoding mimeType. There is no need to also test mimeType.startsWith("image/")
because that is a given.

No new tests. Covered by existing fast/canvas/*toDataURL* tests.

* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK rebaseline after r113756.
philn@webkit.org [Wed, 11 Apr 2012 07:00:33 +0000 (07:00 +0000)]
Unreviewed, GTK rebaseline after r113756.

* platform/gtk/fast/multicol/table-vertical-align-expected.txt:
* platform/gtk/fast/overflow/hidden-scrollbar-resize-expected.txt:
* platform/gtk/fast/repaint/overflow-outline-repaint-expected.txt:
* platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Fix make distcheck issues.
carlosgc@webkit.org [Wed, 11 Apr 2012 06:46:56 +0000 (06:46 +0000)]
Unreviewed. Fix make distcheck issues.

Source/JavaScriptCore:

* GNUmakefile.list.am: Ad missing files.

Source/WebCore:

* GNUmakefile.list.am: Add missing header file.

Source/WebKit2:

* GNUmakefile.am: Add missing header file.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Signedness issue with code informing v8 of PatternSkia memory use
enne@google.com [Wed, 11 Apr 2012 06:26:39 +0000 (06:26 +0000)]
[chromium] Signedness issue with code informing v8 of PatternSkia memory use
https://bugs.webkit.org/show_bug.cgi?id=83642

Reviewed by James Robinson.

The unary negation of size_t is still a size_t, so clamp and cast to
an int instead when adjusting v8 memory limits.

* platform/graphics/Pattern.h:
(Pattern):
* platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformPattern):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
tkent@chromium.org [Wed, 11 Apr 2012 05:39:23 +0000 (05:39 +0000)]
Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.

* Scripts/webkitpy/common/config/watchlist:
* Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] ImageBuffer minor style fix: remove compound declaration
noel.gordon@gmail.com [Wed, 11 Apr 2012 05:35:16 +0000 (05:35 +0000)]
[chromium] ImageBuffer minor style fix: remove compound declaration
https://bugs.webkit.org/show_bug.cgi?id=83660

Reviewed by Kent Tamura.

No new tests. Covered by existing fast/canvas/*toDataURL* tests.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll Chromium DEPS to last-known good revision
fischman@chromium.org [Wed, 11 Apr 2012 05:23:01 +0000 (05:23 +0000)]
Roll Chromium DEPS to last-known good revision
https://bugs.webkit.org/show_bug.cgi?id=83652

Unreviewed, just a DEPS roll (131469:131684)

* DEPS:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd gesture event enums for long-press and pinch
commit-queue@webkit.org [Wed, 11 Apr 2012 04:58:33 +0000 (04:58 +0000)]
Add gesture event enums for long-press and pinch
https://bugs.webkit.org/show_bug.cgi?id=83640

Patch by Alexandre Elias <aelias@google.com> on 2012-04-10
Reviewed by James Robinson.

Add new enum values GestureLongPress and GesturePinchBegin/End/Update,
along with no-op default handling.

Source/WebCore:

No new tests. (No-op change.)

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* platform/PlatformEvent.h:

Source/WebKit/chromium:

* public/WebInputEvent.h:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCrash due to intruding float not removed from next siblings.
inferno@chromium.org [Wed, 11 Apr 2012 04:48:41 +0000 (04:48 +0000)]
Crash due to intruding float not removed from next siblings.
https://bugs.webkit.org/show_bug.cgi?id=83301

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html

markSiblingsWithFloatsForLayout currently only handled overhanging floats and made
checks for those by checking if logicalBottomForFloat > our logicalHeight. We need
to take care of intruding floats as well, since these can intrude into the neighbouring
blocks too. So, generalized the function to check all our next siblings if they contains
that float (one getting removed) and if yes, mark it and all its descendants for layout.
This fixes the crash.

For performance, we change the looping condition to iterate over the next sibling
blocks first and finding which ones can contain floats and then check it against
our floating object list. Currently, it is the other way around and is less
performant due to repeated calls to isRenderBlock(), isFloatingOrPositioned()
and avoidFloats().

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):

LayoutTests:

* fast/block/float/intruding-float-not-removed-from-next-sibling-crash-expected.txt: Added.
* fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPrevent fallthrough to keep static analysis tools happy
mikelawther@chromium.org [Wed, 11 Apr 2012 04:19:01 +0000 (04:19 +0000)]
Prevent fallthrough to keep static analysis tools happy
https://bugs.webkit.org/show_bug.cgi?id=83639

Reviewed by Darin Adler.

No new tests - no new behaviour.

* css/LengthFunctions.cpp:
(WebCore::valueForLength):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDon't expose the intrinsic padding concept to the code outside rendering
jchaffraix@webkit.org [Wed, 11 Apr 2012 04:15:37 +0000 (04:15 +0000)]
Don't expose the intrinsic padding concept to the code outside rendering
https://bugs.webkit.org/show_bug.cgi?id=83380

Reviewed by Eric Seidel.

No new tests, refactoring only.

The current code would expose the concept of intrinsic padding to every
object holding a renderer through an enum on the padding* functions.

This was very fragile as only the class using intrinsic padding should know about
its very existence, the rest of the code shouldn't have to special case for it.
There is one exception: the getComputedStyle logic needs the opposite value
rendering needs. To handle that, we make it more explicit what returns the
computed values vs the rendering values.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::sizingBox):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Updated those functions to use the new computedCSS* functions below.

* rendering/RenderBox.h:
(RenderBox):
(WebCore::RenderBox::computedCSSContentBoxRect):
This is the computed content box. It includes the intrinsic padding.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
Renamed from padding* as they returned the CSS computed values.

* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
Killed the enum paddingOptions!

(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
All padding* functions call the computedCSSPadding* ones above.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):
Updated these functions after the renaming.

* rendering/RenderTableCell.h:
(RenderTableCell):
Updated the functions signature and decorated them with OVERRIDE.

* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::paddingTop):
(WebCore::RenderMathMLBlock::paddingBottom):
(WebCore::RenderMathMLBlock::paddingLeft):
(WebCore::RenderMathMLBlock::paddingRight):
(WebCore::RenderMathMLBlock::paddingBefore):
(WebCore::RenderMathMLBlock::paddingAfter):
(WebCore::RenderMathMLBlock::paddingStart):
(WebCore::RenderMathMLBlock::paddingEnd):
* rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
Updated these functions after the renaming.

* rendering/mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::paint):
Updated this function to use computeCSSContentBoxRect.location().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTextureMapperGL.cpp breaks build with OpenGL ES
commit-queue@webkit.org [Wed, 11 Apr 2012 03:35:05 +0000 (03:35 +0000)]
TextureMapperGL.cpp breaks build with OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=83622

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-04-10
Reviewed by Noam Rosenthal.

Add !defined(TEXMAP_OPENGL_ES_2) guards as suggested by
No'am Rosenthal.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCalendar Picker: Initialize CalendarPickerElement::m_popup
tkent@chromium.org [Wed, 11 Apr 2012 03:33:17 +0000 (03:33 +0000)]
Calendar Picker: Initialize CalendarPickerElement::m_popup
https://bugs.webkit.org/show_bug.cgi?id=83656

Reviewed by Hajime Morita.

* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::CalendarPickerElement): Set 0 to m_popup.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCodeGeneratorV8 cleanup: eliminate redundant calls to IsRefPtrType
adamk@chromium.org [Wed, 11 Apr 2012 03:26:54 +0000 (03:26 +0000)]
CodeGeneratorV8 cleanup: eliminate redundant calls to IsRefPtrType
https://bugs.webkit.org/show_bug.cgi?id=83623

Reviewed by Adam Barth.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader): Always emit toV8(PassRefPtr), as all wrapped types are RefCounted.
(GenerateImplementation): Always emit code for derefObject, as all wrapped types are RefCounted.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Add OVERRIDE annotations for cc tree host and proxy interfaces
jamesr@google.com [Wed, 11 Apr 2012 03:02:10 +0000 (03:02 +0000)]
[chromium] Add OVERRIDE annotations for cc tree host and proxy interfaces
https://bugs.webkit.org/show_bug.cgi?id=83653

Reviewed by Adrienne Walker.

This adds OVERRIDE annotations to the implementations of the following interfaces:
- CCLayerTreeHostClient
- CCLayerTreeHostImplClient
- CCProxy
- LayerRendererChromiumClient

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCProxy.h:
(WebCore):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* src/WebLayerTreeViewImpl.h:
(WebLayerTreeViewImpl):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/FakeCCLayerTreeHostClient.h:
* tests/LayerRendererChromiumTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNotify observers of WorkerRunLoop stopping before the V8 isolate dies.
dgrogan@chromium.org [Wed, 11 Apr 2012 02:59:54 +0000 (02:59 +0000)]
Notify observers of WorkerRunLoop stopping before the V8 isolate dies.
https://bugs.webkit.org/show_bug.cgi?id=83104

Source/WebCore:

PlatformSupport::didStopWorkerRunLoop ultimately causes
~V8AbstractEventListener to call
v8::Local<v8::Object>::New(m_listener) after the V8 isolate has been
disposed, which manifests as a crash in V8.

The current code in trunk runs this at shutdown:
1) removeAllDOMObjects()
2) dispose of V8
3) didStopWorkerRunLoop()  <-- problem

This patch changes the order to be:
1) removeAllDOMObjects()
2) didStopWorkerRunLoop()
3) dispose of V8

We put didStopWorkerRunLoop after removeAllDOMObjects because we don't
want chromium code that runs on a webcore worker to run after it
receives the didStopWorkerRunLoop signal. The destructors of some IDB
objects are run by removeAllDOMObjects, so putting
didStopWorkerRunLoop before removeAllDOMObjects would violate that
constraint.

It's possible that there's a lower layer fix available in V8 or the
bindings.

Reviewed by David Levin.

Test: storage/indexeddb/pending-version-change-on-exit.html

* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
New location of didStopWorkerRunLoop. removeAllDOMObjects and V8
disposal are called here, to run something between them it also has
to go here.

* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread): Old location of
didStopWorkerRunLoop.

LayoutTests:

Reviewed by David Levin.

* storage/indexeddb/pending-version-change-on-exit-expected.txt: Added.
* storage/indexeddb/pending-version-change-on-exit.html: Added.
* storage/indexeddb/resources/pending-version-change-on-exit.js: Added.
(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBreak the association between form controls and their owner when the owner leaves...
adamk@chromium.org [Wed, 11 Apr 2012 02:57:47 +0000 (02:57 +0000)]
Break the association between form controls and their owner when the owner leaves the tree
https://bugs.webkit.org/show_bug.cgi?id=81420

Reviewed by Kent Tamura.

Source/WebCore:

When parsing malformed markup, it's possible for a form and a
form-associated element to not be in an ancestor/descendant relationship.
When that form is later removed from the tree, the relationship needs to be updated.

Test: fast/forms/parser-associated-form-removal.html

* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::FormAssociatedElement):
(WebCore::FormAssociatedElement::formRemovedFromTree): New method called when
by the form when it's being removed: handles either resetting the
owner or storing a bit to optimize away a second walk up the tree.
* html/FormAssociatedElement.h:
(FormAssociatedElement):
* html/HTMLFormElement.cpp:
(WebCore::findRoot): Simple helper method copied from FormAssociatedElement (this should probably live elsewhere).
(WebCore::HTMLFormElement::removedFromTree): Override removedFromTree to notify associated elements of the removal.
* html/HTMLFormElement.h:
(HTMLFormElement):

LayoutTests:

* fast/forms/parser-associated-form-removal-expected.txt: Added.
* fast/forms/parser-associated-form-removal.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Add OVERRIDE annotations for cc scheduler-related client interfaces
jamesr@google.com [Wed, 11 Apr 2012 02:55:39 +0000 (02:55 +0000)]
[chromium] Add OVERRIDE annotations for cc scheduler-related client interfaces
https://bugs.webkit.org/show_bug.cgi?id=83646

Reviewed by Adrienne Walker.

This adds OVERRIDE annotations to the implementations of the following interfaces:
- CCFrameRateControllerClient
- CCSchedulerClient
- CCTimeSource
- CCTimeSourceClient
- CCTimerClient

Source/WebCore:

* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
* platform/graphics/chromium/cc/CCFrameRateController.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
* platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* tests/CCSchedulerTest.cpp:
* tests/CCSchedulerTestCommon.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[CSS Regions] Convert a fast/regions pixel test to a ref test
commit-queue@webkit.org [Wed, 11 Apr 2012 02:51:03 +0000 (02:51 +0000)]
[CSS Regions] Convert a fast/regions pixel test to a ref test
https://bugs.webkit.org/show_bug.cgi?id=83529

Patch by David Alcala <dalcala@adobe.com> on 2012-04-10
Reviewed by Ryosuke Niwa.

* fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.html: Added.
* platform/chromium-linux/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/chromium-mac-leopard/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/chromium-mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/chromium-mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
* platform/chromium-win/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/chromium-win/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
* platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/efl/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Removed.
* platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAttempt to fix the Windows build.
mrowe@apple.com [Wed, 11 Apr 2012 02:49:54 +0000 (02:49 +0000)]
Attempt to fix the Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIf NRWT gets killed halfway through a run, it incorrectly reports tests that weren...
dpranke@chromium.org [Wed, 11 Apr 2012 02:38:12 +0000 (02:38 +0000)]
If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
https://bugs.webkit.org/show_bug.cgi?id=82799

Reviewed by Ojan Vafai.

The tests we were skipping in _mark_interrupted_tests_as_skipped
had incorrectly-constructed TestResults, and so they were not
being treated as failures. The JSON generator doesn't record
tests that are passed or skiped in incremental_results, so you
couldn't tell these tests were being skipped at all.

This change changes _mark_interrupted_tests_as_skipped() to
treat the skipped tests as failures; this is arguably still
incorrect but is minimally invasive for now. We probably need to
revisit how we are uploading information about tests that are
skipped and passed altogether in a separate change.

This change also cleans up a couple of other nits that were
unnecessary or broken in this same code path.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._mark_interrupted_tests_as_skipped):
(Manager._upload_json_files): Deletes the check for
chromium-mac-leopard (as it is no longer necessary).
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator.__init__): Here we were
recalculating the failure type unnecessarily.
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(determine_result_type):
(FailureEarlyExit): Adds a new failure type so we can tell what
happened.
(FailureEarlyExit.message):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_exit_after_n_failures_upload): Add more checks to
ensure that we are recording the SKIP correctly; this is less
than ideal, because we can't actually test the contents of
incremental_results.json. We should fix that at some point.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a function to set empty clients to a PageClients
tkent@chromium.org [Wed, 11 Apr 2012 02:27:01 +0000 (02:27 +0000)]
Add a function to set empty clients to a PageClients
https://bugs.webkit.org/show_bug.cgi?id=83555

Reviewed by Adam Barth.

No new tests because of no behavior change.

* CMakeLists.txt: Add EmptyClients.cpp.
* GNUmakefile.list.am: ditto.
* Target.pri: ditto.
* WebCore.gypi: ditto.
* WebCore.vcproj/WebCore.vcproj: ditto.
* WebCore.xcodeproj/project.pbxproj: ditto.

* loader/EmptyClients.cpp: Added.
(WebCore::fillWithEmptyClients): Some code was moved from SVGImage::dataChanged().
* loader/EmptyClients.h: Add the declaration of fillWithEmptyClients().
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged): Moved some code to fillWithEmptyClients().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Garden fast/{backgrounds,dynamic,encoding}.
rakuco@webkit.org [Wed, 11 Apr 2012 02:19:47 +0000 (02:19 +0000)]
[EFL] Garden fast/{backgrounds,dynamic,encoding}.

* platform/efl/fast/backgrounds/svg-as-mask-expected.txt:
* platform/efl/fast/dynamic/002-expected.png:
* platform/efl/fast/dynamic/004-expected.png:
* platform/efl/fast/dynamic/006-expected.png:
* platform/efl/fast/dynamic/012-expected.png:
* platform/efl/fast/dynamic/015-expected.png:
* platform/efl/fast/dynamic/anchor-lock-expected.txt:
* platform/efl/fast/dynamic/anonymous-block-orphaned-lines-expected.png:
* platform/efl/fast/dynamic/containing-block-change-expected.png:
* platform/efl/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-expected.png:
* platform/efl/fast/dynamic/float-withdrawal-expected.png:
* platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/efl/fast/dynamic/noninlinebadness-expected.png:
* platform/efl/fast/dynamic/outerHTML-doc-expected.png:
* platform/efl/fast/dynamic/outerHTML-img-expected.png:
* platform/efl/fast/dynamic/selection-highlight-adjust-expected.png:
* platform/efl/fast/dynamic/staticY-marking-parents-regression-expected.png:
* platform/efl/fast/dynamic/text-combine-expected.png:
* platform/efl/fast/dynamic/text-combine-expected.txt:
* platform/efl/fast/dynamic/view-overflow-expected.png:
* platform/efl/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
* platform/efl/fast/encoding/invalid-UTF-8-expected.png:
* platform/efl/fast/encoding/utf-16-big-endian-expected.png:
* platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
* platform/efl/fast/encoding/utf-16-little-endian-expected.png:
* platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
* platform/efl/fast/encoding/xmacroman-encoding-test-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Fold LayerChromium::updateCompositorResources into main update
jamesr@google.com [Wed, 11 Apr 2012 02:13:42 +0000 (02:13 +0000)]
[chromium] Fold LayerChromium::updateCompositorResources into main update
https://bugs.webkit.org/show_bug.cgi?id=83530

Reviewed by Adrienne Walker.

Source/WebCore:

We used to update layer contents in two phases. The first, called paintContentsIfDirty() /
idlePaintContentsIfDirty(), ran on the main WebKit thread and took care of any main-thread work - primarily
WebCore painting as the name implies. The second, called updateCompositorResources(), ran on the compositor
thread with the main thread blocked and took care of any actions that required direct access to the compositor's
context - such as texture uploads into compositor-managed textures. Now that all compositor texture operations
are queued on a CCTextureUpdater, the compositor can take care of these operations on the correct thread at the
right time without needing layer-specific logic.

This folds both functions into one function called LayerChromium::update() (and idleUpdate() for idle
prepainting) and adds a CCTextureUpdater reference for queuing up texture operations.

The CCProxy is responsible for the lifetime of the CCTextureUpdater. In the threaded proxy, the updater is
tied to the lifetime of the beginFrame operation. Specifically it's constructed on the impl thread when the
beginFrame message is generated, is accessed by reference on the main thread during the commit, and then
destroyed by the proxy when the commit is complete. CCTextureUpdater::update should only be called on the impl
thread by the proxy. In the future, it might be worth exposing a more limited interface to layers.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::update):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::update):
(WebCore::ContentLayerChromium::idleUpdate):
* platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::updateLayerRect):
(WebCore::ImageLayerChromium::update):
* platform/graphics/chromium/ImageLayerChromium.h:
(ImageLayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::update):
(WebCore::LayerChromium::idleUpdate):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::isDirty):
(WebCore::UpdatableTile::copyAndClearDirty):
(WebCore::UpdatableTile::isDirtyForCurrentFrame):
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::createTile):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::reserveTextures):
(WebCore::TiledLayerChromium::resetUpdateState):
(WebCore::TiledLayerChromium::updateLayerRect):
(WebCore::TiledLayerChromium::idleUpdateLayerRect):
(WebCore::TiledLayerChromium::needsIdlePaint):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::update):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitComplete):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::reserveTextures):
(WebCore::CCLayerTreeHost::update):
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::scheduledActionCommit):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(WebCore::CCThreadProxy::BeginFrameAndCommitState::BeginFrameAndCommitState):
(BeginFrameAndCommitState):

Source/WebKit/chromium:

Update tests for interface changes.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::runTest):
(WTF::ContentLayerChromiumWithUpdateTracking::update):
(WTF::ContentLayerChromiumWithUpdateTracking::idleUpdate):
(WTF::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(ContentLayerChromiumWithUpdateTracking):
(WTF::CCLayerTreeHostTestOpacityChange::afterTest):
(WTF::CCLayerTreeHostTestSetViewportSize::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::TestLayerChromium::update):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestContentLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
* tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeLayerTextureUpdater::updateLayerRect):
(WebKitTests::FakeTiledLayerChromium::update):
* tests/CCTiledLayerTestCommon.h:
(FakeLayerTextureUpdater):
(FakeTiledLayerChromium):
* tests/Canvas2DLayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
(WTF::idlePaintRepeat):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agofast/forms/implicit-submission.html is flakey
dglazkov@chromium.org [Wed, 11 Apr 2012 02:07:33 +0000 (02:07 +0000)]
fast/forms/implicit-submission.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=39056

Speed up the test by removing unnecessary iframe and navigation,
make it less flaky by removing timeouts.

Reviewed by Hajime Morita.

* fast/forms/implicit-submission.html: Deflakified and sped up.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Garden fast/css.
rakuco@webkit.org [Wed, 11 Apr 2012 02:05:05 +0000 (02:05 +0000)]
[EFL] Garden fast/css.

Account for some changes related to the jhbuild and font commits
and adjust some wrong results with fonts that are too big.

* platform/efl/fast/css/001-expected.png:
* platform/efl/fast/css/003-expected.png:
* platform/efl/fast/css/004-expected.png:
* platform/efl/fast/css/005-expected.png:
* platform/efl/fast/css/MarqueeLayoutTest-expected.png:
* platform/efl/fast/css/ZeroOpacityLayers-expected.png:
* platform/efl/fast/css/ZeroOpacityLayers2-expected.png:
* platform/efl/fast/css/absolute-poition-in-rtl-parent-expected.png:
* platform/efl/fast/css/acid2-pixel-expected.png:
* platform/efl/fast/css/apple-prefix-expected.png:
* platform/efl/fast/css/begin-end-contain-selector-empty-value-expected.png:
* platform/efl/fast/css/bidi-override-in-anonymous-block-expected.png:
* platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/efl/fast/css/border-radius-outline-offset-expected.png:
* platform/efl/fast/css/color-correction-backgrounds-and-text-expected.png:
* platform/efl/fast/css/color-correction-expected.png:
* platform/efl/fast/css/color-correction-on-text-expected.png:
* platform/efl/fast/css/compare-content-style-expected.png:
* platform/efl/fast/css/continuationCrash-expected.png:
* platform/efl/fast/css/create_element_align-expected.png:
* platform/efl/fast/css/css-imports-expected.png:
* platform/efl/fast/css/css1_forward_compatible_parsing-expected.png:
* platform/efl/fast/css/css2-system-fonts-expected.png:
* platform/efl/fast/css/css3-modsel-22-expected.png:
* platform/efl/fast/css/css3-nth-child-expected.png:
* platform/efl/fast/css/css3-space-in-nth-and-lang-expected.png:
* platform/efl/fast/css/empty-pseudo-class-expected.png:
* platform/efl/fast/css/error-in-last-decl-expected.png:
* platform/efl/fast/css/ex-after-font-variant-expected.png:
* platform/efl/fast/css/fieldset-display-row-expected.png:
* platform/efl/fast/css/find-next-layer-expected.png:
* platform/efl/fast/css/first-child-pseudo-class-expected.png:
* platform/efl/fast/css/first-letter-capitalized-expected.png:
* platform/efl/fast/css/first-letter-detach-expected.png:
* platform/efl/fast/css/first-letter-float-after-float-expected.png:
* platform/efl/fast/css/first-letter-float-expected.png:
* platform/efl/fast/css/first-letter-hover-expected.png:
* platform/efl/fast/css/first-letter-punctuation-expected.png:
* platform/efl/fast/css/first-letter-recalculation-expected.png:
* platform/efl/fast/css/first-letter-skip-out-of-flow-expected.png:
* platform/efl/fast/css/first-letter-visibility-expected.png:
* platform/efl/fast/css/first-of-type-pseudo-class-expected.png:
* platform/efl/fast/css/focus-ring-detached-expected.png:
* platform/efl/fast/css/focus-ring-multiline-expected.png:
* platform/efl/fast/css/focus-ring-multiline-writingmode-vertical-expected.png:
* platform/efl/fast/css/focus-ring-outline-offset-expected.png:
* platform/efl/fast/css/font-face-implicit-local-font-expected.png:
* platform/efl/fast/css/font-face-locally-installed-expected.png:
* platform/efl/fast/css/font-face-multiple-faces-expected.png:
* platform/efl/fast/css/font-face-unicode-range-expected.png:
* platform/efl/fast/css/font-weight-1-expected.png:
* platform/efl/fast/css/font_property_normal-expected.png:
* platform/efl/fast/css/h1-in-section-elements-expected.png:
* platform/efl/fast/css/hover-subselector-expected.png:
* platform/efl/fast/css/hsl-color-expected.png:
* platform/efl/fast/css/import-rule-regression-11590-expected.png:
* platform/efl/fast/css/import-rule-regression-11590-expected.txt:
* platform/efl/fast/css/inline-element-line-break-expected.png:
* platform/efl/fast/css/inline-element-line-break-expected.txt:
* platform/efl/fast/css/inline-properties-important-expected.png:
* platform/efl/fast/css/inline-properties-important-expected.txt:
* platform/efl/fast/css/invalid-percentage-property-expected.png:
* platform/efl/fast/css/invalid-percentage-property-expected.txt:
* platform/efl/fast/css/invalidation-errors-2-expected.png:
* platform/efl/fast/css/invalidation-errors-2-expected.txt:
* platform/efl/fast/css/invalidation-errors-3-expected.png:
* platform/efl/fast/css/invalidation-errors-3-expected.txt:
* platform/efl/fast/css/invalidation-errors-expected.png:
* platform/efl/fast/css/invalidation-errors-expected.txt:
* platform/efl/fast/css/last-child-pseudo-class-expected.png:
* platform/efl/fast/css/last-child-pseudo-class-expected.txt:
* platform/efl/fast/css/last-of-type-pseudo-class-expected.png:
* platform/efl/fast/css/last-of-type-pseudo-class-expected.txt:
* platform/efl/fast/css/layerZOrderCrash-expected.png:
* platform/efl/fast/css/layerZOrderCrash-expected.txt:
* platform/efl/fast/css/line-height-expected.png:
* platform/efl/fast/css/line-height-expected.txt:
* platform/efl/fast/css/line-height-overflow-expected.png:
* platform/efl/fast/css/line-height-overflow-expected.txt:
* platform/efl/fast/css/list-outline-expected.png:
* platform/efl/fast/css/list-outline-expected.txt:
* platform/efl/fast/css/margin-bottom-form-element-quirk-expected.png:
* platform/efl/fast/css/margin-bottom-form-element-quirk-expected.txt:
* platform/efl/fast/css/margin-bottom-form-element-strict-expected.png:
* platform/efl/fast/css/margin-bottom-form-element-strict-expected.txt:
* platform/efl/fast/css/margin-top-bottom-dynamic-expected.png:
* platform/efl/fast/css/margin-top-bottom-dynamic-expected.txt:
* platform/efl/fast/css/namespaces/004-expected.png:
* platform/efl/fast/css/namespaces/005-expected.png:
* platform/efl/fast/css/namespaces/namespaces-comments-expected.png:
* platform/efl/fast/css/namespaces/namespaces-empty-expected.png:
* platform/efl/fast/css/namespaces/namespaces-escapes-expected.png:
* platform/efl/fast/css/namespaces/namespaces-invalid-at-expected.png:
* platform/efl/fast/css/negative-leading-expected.png:
* platform/efl/fast/css/negative-leading-expected.txt:
* platform/efl/fast/css/negative-nth-child-expected.png:
* platform/efl/fast/css/negative-nth-child-expected.txt:
* platform/efl/fast/css/nested-floating-relative-position-percentages-expected.png:
* platform/efl/fast/css/nested-floating-relative-position-percentages-expected.txt:
* platform/efl/fast/css/nested-layers-with-hover-expected.png:
* platform/efl/fast/css/nested-layers-with-hover-expected.txt:
* platform/efl/fast/css/nested-rounded-corners-expected.png:
* platform/efl/fast/css/nth-child-dynamic-expected.png:
* platform/efl/fast/css/nth-child-dynamic-expected.txt:
* platform/efl/fast/css/only-child-pseudo-class-expected.png:
* platform/efl/fast/css/only-child-pseudo-class-expected.txt:
* platform/efl/fast/css/only-of-type-pseudo-class-expected.png:
* platform/efl/fast/css/only-of-type-pseudo-class-expected.txt:
* platform/efl/fast/css/outline-auto-location-expected.png:
* platform/efl/fast/css/outline-auto-location-expected.txt:
* platform/efl/fast/css/outline-narrowLine-expected.png:
* platform/efl/fast/css/outline-narrowLine-expected.txt:
* platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.png:
* platform/efl/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
* platform/efl/fast/css/percentage-non-integer-expected.png:
* platform/efl/fast/css/percentage-non-integer-expected.txt:
* platform/efl/fast/css/positioned-overflow-scroll-expected.png:
* platform/efl/fast/css/pseudo-element-line-break-expected.png:
* platform/efl/fast/css/pseudo-element-line-break-expected.txt:
* platform/efl/fast/css/pseudo-first-line-border-width-expected.png:
* platform/efl/fast/css/pseudo-first-line-border-width-expected.txt: Added.
* platform/efl/fast/css/quirk-orphaned-units-expected.png:
* platform/efl/fast/css/quirk-orphaned-units-expected.txt:
* platform/efl/fast/css/resize-corner-tracking-expected.png:
* platform/efl/fast/css/resize-corner-tracking-expected.txt:
* platform/efl/fast/css/resize-corner-tracking-transformed-expected.png:
* platform/efl/fast/css/resize-corner-tracking-transformed-expected.txt:
* platform/efl/fast/css/rtl-ordering-expected.png:
* platform/efl/fast/css/rtl-ordering-expected.txt:
* platform/efl/fast/css/selector-set-attribute-expected.png:
* platform/efl/fast/css/selector-set-attribute-expected.txt:
* platform/efl/fast/css/table-text-align-quirk-expected.png:
* platform/efl/fast/css/table-text-align-quirk-expected.txt:
* platform/efl/fast/css/table-text-align-strict-expected.png:
* platform/efl/fast/css/table-text-align-strict-expected.txt:
* platform/efl/fast/css/text-align-expected.png:
* platform/efl/fast/css/text-align-expected.txt:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.png:
* platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.txt:
* platform/efl/fast/css/text-overflow-ellipsis-expected.png:
* platform/efl/fast/css/text-overflow-ellipsis-expected.txt:
* platform/efl/fast/css/text-overflow-ellipsis-strict-expected.png:
* platform/efl/fast/css/text-overflow-ellipsis-strict-expected.txt:
* platform/efl/fast/css/text-security-expected.png:
* platform/efl/fast/css/text-security-expected.txt:
* platform/efl/fast/css/text-transform-select-expected.png:
* platform/efl/fast/css/text-transform-select-expected.txt:
* platform/efl/fast/css/textCapitalizeEdgeCases-expected.png:
* platform/efl/fast/css/textCapitalizeEdgeCases-expected.txt:
* platform/efl/fast/css/transformed-mask-expected.png:
* platform/efl/fast/css/transformed-mask-expected.txt:
* platform/efl/fast/css/universal-hover-quirk-expected.png:
* platform/efl/fast/css/universal-hover-quirk-expected.txt:
* platform/efl/fast/css/value-list-out-of-bounds-crash-expected.png:
* platform/efl/fast/css/value-list-out-of-bounds-crash-expected.txt:
* platform/efl/fast/css/word-space-extra-expected.png:
* platform/efl/fast/css/word-space-extra-expected.txt:
* platform/efl/fast/css/zoom-font-size-expected.png:
* platform/efl/fast/css/zoom-font-size-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoStore V8 SVGElementInstance wrappers in the regular DOMObjectMap
adamk@chromium.org [Wed, 11 Apr 2012 01:57:03 +0000 (01:57 +0000)]
Store V8 SVGElementInstance wrappers in the regular DOMObjectMap
https://bugs.webkit.org/show_bug.cgi?id=83615

Reviewed by Adam Barth.

Historically, these wrappers had their own map, but there doesn't seem
to be any particular reason for this. The V8GCController doesn't
treat them specially (which is the reason you normally need a separate
wrapper map).

No new tests, no expected change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GetDomMapName):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::getDOMWrapperMap):
* bindings/v8/DOMDataStore.h:
(DOMDataStore):
* bindings/v8/ScopedDOMDataStore.cpp:
(WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
(WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
* bindings/v8/StaticDOMDataStore.cpp:
(WebCore::StaticDOMDataStore::StaticDOMDataStore):
* bindings/v8/StaticDOMDataStore.h:
(StaticDOMDataStore):
* bindings/v8/V8DOMMap.cpp:
(WebCore::removeAllDOMObjects):
* bindings/v8/V8DOMMap.h:
(WebCore):
* bindings/v8/V8DOMWrapper.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Separate image encoding from dataURL construction
noel.gordon@gmail.com [Wed, 11 Apr 2012 01:46:49 +0000 (01:46 +0000)]
[Qt] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83132

Reviewed by Noam Rosenthal.

Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.

No new tests, refactoring only, covered by existing canvas tests.

* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::encodeImage): Output the encoded image to the provided QByteArray.
(WebCore):
(WebCore::ImageBuffer::toDataURL) Format the dataURL encoding of the mimeType
encoded image data here. Clarify the comment.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agomake chromium layout tests not depend on platform/win, platform/mac-leopard, or platf...
dpranke@chromium.org [Wed, 11 Apr 2012 01:45:09 +0000 (01:45 +0000)]
make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
https://bugs.webkit.org/show_bug.cgi?id=83401

Reviewed by Adam Barth.

Last patch in the series - no longer look in mac-leopard,
mac-snowleopard, or mac-lion.

* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort):
* TestResultServer/static-dashboards/flakiness_dashboard.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for WinCE after r113730.
paroga@webkit.org [Wed, 11 Apr 2012 01:39:23 +0000 (01:39 +0000)]
Build fix for WinCE after r113730.

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::isInBounds):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkit-patch: add a print-expectations command
dpranke@chromium.org [Wed, 11 Apr 2012 01:37:47 +0000 (01:37 +0000)]
webkit-patch: add a print-expectations command
https://bugs.webkit.org/show_bug.cgi?id=83347

Reviewed by Adam Barth.

This command will print the expected results for a given set of
tests on a given set of ports matching a given set of keywords.

Example output (printing all the tests not expected to pass, and their
expected results, on a Mac):

$ webkit-patch print-expectations -x pass fast/html
// For mac-snowleopard
fast/html/details-open4.html = TEXT
fast/html/details-open2.html = TEXT
fast/html/details-no-summary4.html = TEXT
fast/html/details-open-javascript.html = TEXT
$

You can also print full test-expectatons.txt lines using --full and a
CSV-style report (which can be useful for post-processing) using --csv.

It will replace the 'skipped-files' command (which will be
removed in a subsequent patch) and is a more general (and
cleaner and properly layered) solution.

Also add an update() command to MockOptions() to make overriding keywords easier.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationSerializer.to_string):
(TestExpectationSerializer):
(TestExpectationSerializer.to_csv):
(TestExpectationSerializer._format_result):
(TestExpectationLine.create_passing_expectation):
(TestExpectationsModel.get_test_set_for_keyword):
(TestExpectationsModel.has_keyword):
(TestExpectations.model):
* Scripts/webkitpy/tool/commands/queries.py:
(execute):
(PrintExpectations):
(PrintExpectations.__init__):
(PrintExpectations.execute):
(PrintExpectations._filter_tests):
(PrintExpectations._format_lines):
(PrintExpectations._model):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(TestPrintExpectations): Added.
* Scripts/webkitpy/tool/mocktool.py:
(MockOptions):
(MockOptions.__init__):
(MockOptions.update): Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: refactor handling of --platform and related options
dpranke@chromium.org [Wed, 11 Apr 2012 01:30:24 +0000 (01:30 +0000)]
webkitpy: refactor handling of --platform and related options
https://bugs.webkit.org/show_bug.cgi?id=83525

Reviewed by Adam Barth.

This change moves to centralize handling of --platform, --debug,
--gtk, and other similar flags into a central place next to the
code that actually uses those flags in PortFactory to get the
right Port object.

* Scripts/webkitpy/layout_tests/port/__init__.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
(port_options):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/tool/commands/queries.py:
(PrintBaselines.__init__):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/10583749> WebKit2 should log to both ASL and stderr
mrowe@apple.com [Wed, 11 Apr 2012 01:24:07 +0000 (01:24 +0000)]
<rdar://problem/10583749> WebKit2 should log to both ASL and stderr

Source/WebKit2:

Replace direct calls to fprintf stderr with calls to WTFLogAlways.

Reviewed by Sam Weinig.

* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
(WebKit::InjectedBundle::load):
* WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
(readSandboxProfile):
(WKN_EnterSandbox):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

Source/WTF:

Reviewed by Sam Weinig.

* wtf/Assertions.cpp: Add a WTFLogAlways function that unconditionally logs the given message.
* wtf/Assertions.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd transfer map argument to Intent constructor
commit-queue@webkit.org [Wed, 11 Apr 2012 01:15:30 +0000 (01:15 +0000)]
Add transfer map argument to Intent constructor
http://dvcs.w3.org/hg/web-intents/raw-file/tip/spec/Overview.html
This adds the ability to pass transferables (i.e. MessagePorts)
through web intents, and puts the calling convention in line
with the Web Messaging spec:
http://dev.w3.org/html5/postmsg/

Implementation in chromium API follows the port-passing method
of PlatformMessagePortChannel.

https://bugs.webkit.org/show_bug.cgi?id=80200

Patch by Greg Billock <gbillock@google.com> on 2012-04-10
Reviewed by Adam Barth.

* Modules/intents/Intent.cpp:
(WebCore::Intent::create):
* Modules/intents/Intent.idl:
* WebCore.gypi:
* bindings/v8/custom/V8IntentCustom.cpp: Added.
(WebCore):
(WebCore::V8Intent::constructorCallback):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCleanup wtf/Platform.h and config.h files
paroga@webkit.org [Wed, 11 Apr 2012 01:09:07 +0000 (01:09 +0000)]
Cleanup wtf/Platform.h and config.h files
https://bugs.webkit.org/show_bug.cgi?id=83431

Reviewed by Eric Seidel.

The ENABLE() and USE() macros take care about the case when the flag
isn't defined. So there is no need to define anything with 0.

Also move duplicated code from the config.h files to Platform.h and
merge a few preprocessor commands to make the file more readable.

Source/JavaScriptCore:

* config.h:

Source/WebCore:

* config.h:

Source/WTF:

* config.h:
* wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed gardening.
simonjam@chromium.org [Wed, 11 Apr 2012 00:56:02 +0000 (00:56 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/basic-textareas-expected.txt.
* platform/chromium-mac/fast/forms/basic-textareas-expected.png:
* platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDFG should flush SetLocals to arguments
fpizlo@apple.com [Wed, 11 Apr 2012 00:37:04 +0000 (00:37 +0000)]
DFG should flush SetLocals to arguments
https://bugs.webkit.org/show_bug.cgi?id=83554

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

This is necessary to match baseline JIT argument capture behavior.

But to make this work right we need to have a story for arguments into
which we store values of different formats. This patch introduces the
notion of an ArgumentPosition - i.e. an argument in a particular inline
call frame - and forces unification of all data pertinent to selecting
the argument's data format.

Also fixed an amusing bug in the handling of OSR on SetLocals if there
was any insertion/deletion of nodes in the basic block. This is benign
for now but won't be eventually since the DFG is getting smarter. So
better fix it now.

Also fixed an amusing bug in the handling of OSR on SetLocals if they
are immediately followed by a Flush. I think this bug might have always
been there but now it'll happen more commonly, and it's covered by the
run-javascriptcore-tests.

* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGArgumentPosition.h: Added.
(DFG):
(ArgumentPosition):
(JSC::DFG::ArgumentPosition::ArgumentPosition):
(JSC::DFG::ArgumentPosition::addVariable):
(JSC::DFG::ArgumentPosition::mergeArgumentAwareness):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGDoubleFormatState.h: Added.
(DFG):
(JSC::DFG::mergeDoubleFormatStates):
(JSC::DFG::mergeDoubleFormatState):
(JSC::DFG::doubleFormatStateToString):
* dfg/DFGGraph.h:
(Graph):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::predict):
(JSC::DFG::VariableAccessData::argumentAwarePrediction):
(VariableAccessData):
(JSC::DFG::VariableAccessData::mergeArgumentAwarePrediction):
(JSC::DFG::VariableAccessData::doubleFormatState):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::mergeDoubleFormatState):
(JSC::DFG::VariableAccessData::makePredictionForDoubleFormat):

Source/WTF:

Reviewed by Gavin Barraclough.

Added an isRoot() method that is a faster shorthand for saying
find() == this.

* wtf/UnionFind.h:
(WTF::UnionFind::isRoot):
(UnionFind):

LayoutTests:

Rubber stamped by Gavin Barraclough.

Added a variety of tests for reassigning arguments prior to function.arguments
retrieval.

* fast/js/dfg-inline-arguments-become-double-expected.txt: Added.
* fast/js/dfg-inline-arguments-become-double.html: Added.
* fast/js/dfg-inline-arguments-become-int32-expected.txt: Added.
* fast/js/dfg-inline-arguments-become-int32.html: Added.
* fast/js/dfg-inline-arguments-reset-changetype-expected.txt: Added.
* fast/js/dfg-inline-arguments-reset-changetype.html: Added.
* fast/js/dfg-inline-arguments-reset-expected.txt: Added.
* fast/js/dfg-inline-arguments-reset.html: Added.
* fast/js/script-tests/dfg-inline-arguments-become-double.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
* fast/js/script-tests/dfg-inline-arguments-become-int32.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
* fast/js/script-tests/dfg-inline-arguments-reset-changetype.js: Added.
(foo):
(bar):
(baz):
(argsToStr):
* fast/js/script-tests/dfg-inline-arguments-reset.js: Added.
(foo):
(bar):
(baz):
(argsToStr):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
abarth@webkit.org [Wed, 11 Apr 2012 00:17:42 +0000 (00:17 +0000)]
Source/WebCore: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

As recommended by David Hyatt in
<https://lists.webkit.org/pipermail/webkit-dev/2010-July/013536.html>,
we should phase out support for -khtml- and -apple- vendor prefixes in
CSS (in favor of -webkit-).

As noted in <https://bugs.webkit.org/show_bug.cgi?id=42093#c29>, Dave's
proposal is a bit too agressive.  These prefixes appear to be needed
for a number of dashboard widgets.  For that reason, this patch limits
the prefixes to ENABLE(LEGACY_CSS_VENDOR_PREFIXES).

This patch enables ENABLE(LEGACY_CSS_VENDOR_PREFIXES) on apple-mac and
apple-win, which will let us learn whether removing these prefixes
causes a compatibility problem on the broader web.

* Configurations/FeatureDefines.xcconfig:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyInfo):
* css/CSSParser.cpp:
(WebCore::cssPropertyID):

Source/WebKit/chromium: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

* features.gypi:

WebKitLibraries: Limit -apple- and -khtml- to ENABLE(DASHBOARD_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

* win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests: Limit -apple- and -khtml- to ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
https://bugs.webkit.org/show_bug.cgi?id=83256

Reviewed by Eric Seidel.

Skip these two tests, which are testing that -apple- and -khtml- vendor
prefixes work correctly.

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove unused NonNullPassRefPtr from WTF
adamk@chromium.org [Wed, 11 Apr 2012 00:15:36 +0000 (00:15 +0000)]
Remove unused NonNullPassRefPtr from WTF
https://bugs.webkit.org/show_bug.cgi?id=82389

Reviewed by Kentaro Hara.

Source/JavaScriptCore:

* JavaScriptCore.order: Remove nonexistent symbols referencing NonNullPassRefPtr.

Source/WTF:

NonNullPassRefPtr seems to be unused since JSC allocation was
restructured in r84052.

If someone decides they need this later, they can always revert this patch.

* wtf/PassRefPtr.h:
* wtf/RefPtr.h:
(RefPtr):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed build fix after r113791.
yael.aharon@nokia.com [Wed, 11 Apr 2012 00:09:45 +0000 (00:09 +0000)]
Unreviewed build fix after r113791.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClean up multiple RenderedPosition::absoluteRect definitions and correct LayoutUnit...
leviw@chromium.org [Tue, 10 Apr 2012 23:44:26 +0000 (23:44 +0000)]
Clean up multiple RenderedPosition::absoluteRect definitions and correct LayoutUnit usage
https://bugs.webkit.org/show_bug.cgi?id=83604

Reviewed by Julien Chaffraix.

Removing unnecessary definitions of absoluteRect and replacing them with a single public
version that's more explicit about its contract.

Also correcting a LayoutUnit misuse, as rects in absolute coordinates should be returned
using integers, not LayoutUnits. See https://trac.webkit.org/wiki/LayoutUnit for details.

No new tests. No change in behavior.

* editing/Editor.cpp:
(WebCore::Editor::firstRectForRange):
* editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::absoluteRect): Pixel snapping the local rect before converting
to absolute coordinates.
* editing/RenderedPosition.h:
(RenderedPosition):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoInitial support for fixed position elements in Qt WebKit2
yael.aharon@nokia.com [Tue, 10 Apr 2012 23:40:51 +0000 (23:40 +0000)]
Initial support for fixed position elements in Qt WebKit2
https://bugs.webkit.org/show_bug.cgi?id=81786

Reviewed by Noam Rosenthal.

.:

* ManualTests/fixed-position.html: Added.

Source/WebCore:

When the setting acceleratedCompositingForFixedPositionEnabled is true, we update
the position of fixed layers, and send updates to the UI process as we scroll.
Before painting, TextureMapperLayer receives a delta of the scroll positions between the UI
and the web processes, and adjusts its transform position accordingly.

* page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setScrollPositionDelta):
(WebCore):
* platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):

Source/WebKit2:

Turn on the flag acceleratedCompositingForFixedPositionEnabled when using fixed layout.
As we scroll, we keep track of the delta in scroll position between the UI and web processes,
and adjust the position of all the fixed layers by that delta.
When WebLayerTreeRenderer receives a new scroll position from the web process, it keeps it as pending,
and commit the new scroll position in flushLayerChanges.
This patch does not address scrolling overshoot and it does not fix the wrong positioning
that occurs when we zoom. These issues will be addressed in future patches.

* Shared/WebLayerTreeInfo.h:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::updateSize):
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::setContentsSize):
(WebKit):
(WebKit::LayerTreeHostProxy::renderNextFrame):
(WebKit::LayerTreeHostProxy::didChangeScrollPosition):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/LayerTreeHostProxy.messages.in:
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::boundedScrollPosition):
(WebKit):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
(WebKit::WebLayerTreeRenderer::setContentsSize):
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::WebLayerTreeRenderer::didChangeScrollPosition):
(WebKit::WebLayerTreeRenderer::syncLayerParameters):
(WebKit::WebLayerTreeRenderer::deleteLayer):
(WebKit::WebLayerTreeRenderer::flushLayerChanges):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
(WebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::fixedToViewport):
(WebCore::WebGraphicsLayer::setFixedToViewport):
(WebGraphicsLayer):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::updateOffsetFromViewportForSelf):
(WebKit):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::LayerTreeHostQt::syncFixedLayers):
(WebKit::LayerTreeHostQt::setVisibleContentsRect):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed gardening.
simonjam@chromium.org [Tue, 10 Apr 2012 23:34:52 +0000 (23:34 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium-linux/fast/multicol/cell-shrinkback-expected.png: Added.
* platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac-leopard/fast/forms/basic-textareas-expected.png:
* platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-textareas-expected.txt: Removed.
* platform/chromium-mac-snowleopard/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac/fast/overflow/hidden-scrollbar-resize-expected.txt: Removed.
* platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.txt: Removed.
* platform/chromium-win/fast/multicol/cell-shrinkback-expected.png: Added.
* platform/chromium-win/fast/multicol/table-vertical-align-expected.txt:
* platform/chromium-win/fast/overflow/hidden-scrollbar-resize-expected.txt:
* platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png:
* platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove empty directories.
abarth@webkit.org [Tue, 10 Apr 2012 23:16:06 +0000 (23:16 +0000)]
Remove empty directories.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClone any baselines chromium is using from mac-leopard and mac-snowleopard into chrom...
dpranke@chromium.org [Tue, 10 Apr 2012 23:10:20 +0000 (23:10 +0000)]
Clone any baselines chromium is using from mac-leopard and mac-snowleopard into chromium dirs.
https://bugs.webkit.org/show_bug.cgi?id=83401

Unreviewed, baseline shuffling.

* platform/chromium-mac-leopard/accessibility/aria-tables-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/lists-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/media-element-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-attributes-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-cell-spans-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-cells-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-detection-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-sections-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/table-with-rules-expected.txt: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/documentgetinputencoding03-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetinputencoding02-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/entitygetxmlversion02-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri05-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri07-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri09-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri10-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri11-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri15-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri17-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodegetbaseuri18-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.png: Added.
* platform/chromium-mac-leopard/dom/xhtml/level3/core/nodelookupprefix19-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/paste-RTFD-expected.png: Added.
* platform/chromium-mac-leopard/editing/pasteboard/paste-TIFF-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/designmode-no-caret-expected.png: Added.
* platform/chromium-mac-leopard/editing/spelling/grammar-expected.txt: Added.
* platform/chromium-mac-leopard/editing/text-iterator/findString-expected.txt: Added.
* platform/chromium-mac-leopard/fast/backgrounds/animated-gif-as-background-expected.png: Added.
* platform/chromium-mac-leopard/fast/backgrounds/solid-color-context-restore-expected.png: Added.
* platform/chromium-mac-leopard/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/color-correction-on-box-shadow-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/color-correction-on-text-shadow-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/disabled-author-styles-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/font-weight-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/css/outline-auto-empty-rects-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
* platform/chromium-mac-leopard/fast/dom/gc-10-expected.png: Added.
* platform/chromium-mac-leopard/fast/events/keydown-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
* platform/chromium-mac-leopard/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
* platform/chromium-mac-leopard/fast/frames/inline-object-inside-frameset-expected.png: Added.
* platform/chromium-mac-leopard/fast/images/pdf-as-image-landscape-expected.png: Added.
* platform/chromium-mac-leopard/fast/reflections/inline-crash-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/line-in-scrolled-clipped-block-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/rel-positioned-inline-with-overflow-expected.png: Added.
* platform/chromium-mac-leopard/fast/replaced/pdf-as-image-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/font-initial-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bold-bengali-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/international/thai-baht-space-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
* platform/chromium-mac-leopard/fast/writing-mode/border-vertical-lr-expected.txt: Added.
* platform/chromium-mac-leopard/fast/writing-mode/japanese-lr-selection-expected.png: Added.
* platform/chromium-mac-leopard/fast/writing-mode/japanese-rl-selection-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/inspector/console-websocket-error-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/misc/favicon-as-image-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/misc/slow-loading-mask-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/navigation/error404-goback-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/navigation/error404-subframeload-expected.png: Added.
* platform/chromium-mac-leopard/java/lc3/JavaObject/JavaObjectToDouble-001-expected.txt: Added.
* platform/chromium-mac-leopard/media/video-replaces-poster-expected.png: Added.
* platform/chromium-mac-leopard/platform/mac/editing/input/devanagari-ligature-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
* platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* platform/chromium-mac-leopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Added.
* platform/chromium-mac-leopard/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Added.
* platform/chromium-mac-leopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/style-attribute-font-size-expected.png: Added.
* platform/chromium-mac-leopard/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-mac-leopard/svg/hixie/error/012-expected.png: Added.
* platform/chromium-mac-leopard/svg/hixie/error/012-expected.txt: Added.
* platform/chromium-mac-leopard/svg/hixie/mixed/007-expected.png: Added.
* platform/chromium-mac-leopard/svg/text/font-size-below-point-five-expected.txt: Added.
* platform/chromium-mac-leopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/chromium-mac-leopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
* platform/chromium-mac-leopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
* platform/chromium-mac-leopard/transforms/2d/zoom-menulist-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/general/perspective-units-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-2-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
* platform/chromium-mac-leopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/masks/layer-mask-placement-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/video/video-background-color-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t1202-counter-09-b-expected.txt: Added.
* platform/chromium-mac-snowleopard/css2.1/t1202-counters-09-b-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-background-size-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-blending-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-simple-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-sizing-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-TIFF-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/set-colors-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/images/pdf-as-image-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/preloader/document-write-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/preloader/document-write-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-break-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphenate-locale-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/hyphens-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bidi-neutral-run-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/international/khmer-selection-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/editing/selection/25228-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/mac/fast/text/line-break-locale-expected.txt: Added.
* platform/chromium-mac-snowleopard/platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
* platform/chromium-mac-snowleopard/printing/compositing-layer-printing-expected.png: Added.
* platform/chromium-mac-snowleopard/printing/media-queries-print-expected.png: Added.
* platform/chromium-mac-snowleopard/printing/page-rule-in-media-query-expected.png: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Added.
* platform/chromium-mac-snowleopard/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/image-with-prefix-in-webarchive-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/style-attribute-font-size-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dom/SVGLocatable-getCTM-svg-root-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/filters/sourceAlpha-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/error/012-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/mixed/007-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/viewbox/001-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/viewbox/002-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/webarchive/svg-cursor-subresources-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/webarchive/svg-feimage-subresources-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/2d/hindi-rotated-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/general/perspective-units-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
* platform/chromium-mac-snowleopard/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
* platform/chromium-mac-snowleopard/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
* platform/chromium-mac-snowleopard/webarchive/test-link-rel-icon-beforeload-expected.png: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a chromeless view to the individual tests view
ojan@chromium.org [Tue, 10 Apr 2012 22:59:52 +0000 (22:59 +0000)]
Add a chromeless view to the individual tests view
https://bugs.webkit.org/show_bug.cgi?id=83541

Reviewed by Daniel Bates.

This is the view suitable to inlining in other contexts (e.g. garden-o-matic).

* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testHtmlForIndividualTestOnAllBuilders):
(testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
(testHtmlForIndividualTestOnAllBuildersWithChrome):
(testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
(testHtmlForIndividualTests):
(htmlEscape):
(runTests):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113787 268f45cc-cd09-0410-ab3c-d52691b4dbfc