0 [Tue, 30 Oct 2001 18:52:00 +0000 (18:52 +0000)]
Dont setup cancel_fd. (camel_operation_cancel_fd): If cancel_fd not
2001-10-30 <NotZed@Ximian.com>
* camel-operation.c (camel_operation_new): Dont setup cancel_fd.
(camel_operation_cancel_fd): If cancel_fd not created, set it up.
(camel_operation_cancel): Set cancel flag before sending message.
(cancel_thread): Same.
0 [Tue, 30 Oct 2001 18:22:14 +0000 (18:22 +0000)]
Make sure we unref the mimeparse when we're done (successfully). This was
2001-10-30 <NotZed@Ximian.com>
* camel-filter-driver.c (camel_filter_driver_filter_mbox): Make
sure we unref the mimeparse when we're done (successfully). This
was leaking an fd every get-mail! :(
* camel-lock-client.c (camel_lock_helper_init): Close all fd's
above 2.
0 [Tue, 30 Oct 2001 12:41:17 +0000 (12:41 +0000)]
Remove the X-Evolution header before anyone else gets to see this private
2001-10-30 <NotZed@Ximian.com>
* providers/local/camel-mbox-folder.c (mbox_get_message): Remove
the X-Evolution header before anyone else gets to see this private
thing. Shoudl fix 11676 since we were inheriting flags from
X-Evolution headers we didn't want to.
0 [Tue, 30 Oct 2001 07:55:59 +0000 (07:55 +0000)]
If we can't retrieve the message, ignore it, it can't match.
2001-10-30 <NotZed@Ximian.com>
* camel-folder-search.c (match_message): If we can't retrieve the
message, ignore it, it can't match.
* providers/imap/camel-imap-search.c
(camel_imap_search_class_init): Setup parent class pointer.
(imap_body_contains): If offline, just use the parent
body_contains method which will get the messages and search them
manually.
* providers/imap/camel-imap-folder.c (imap_search_by_expression,
imap_search_by_uids): Remove offline check.
Dan Winship [Tue, 30 Oct 2001 05:23:59 +0000 (05:23 +0000)]
Fix this to match get_headers.
* camel-mime-part.c (free_headers): Fix this to match get_headers.
0 [Tue, 30 Oct 2001 05:20:50 +0000 (05:20 +0000)]
Dont try to move ibex if we have none.
2001-10-30 <NotZed@Ximian.com>
* providers/local/camel-local-store.c (rename_folder): Dont try to
move ibex if we have none.
0 [Tue, 30 Oct 2001 04:29:00 +0000 (04:29 +0000)]
Fixed compilation errors.
2001-10-30 <NotZed@Ximian.com>
* camel-tcp-stream-openssl.c (stream_write): Fixed compilation
errors.
Jeffrey Stedfast [Tue, 30 Oct 2001 04:26:28 +0000 (04:26 +0000)]
Removed unused variable.
2001-10-29 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-utils.c (camel_mime_utils_init): Removed unused
variable.
Jeffrey Stedfast [Tue, 30 Oct 2001 04:24:28 +0000 (04:24 +0000)]
fixed a compile problem and saved errno before calling fcntl() in stream_read
0 [Tue, 30 Oct 2001 03:27:28 +0000 (03:27 +0000)]
w(x) out some warnings.
2001-10-30 <NotZed@Ximian.com>
* camel-mime-utils.c (header_decode_mailbox): w(x) out some warnings.
* providers/local/camel-local-summary.c
(camel_local_summary_load): Remove the warning about not loading
summary file - its a valid case for new folders.
Jeffrey Stedfast [Tue, 30 Oct 2001 03:09:01 +0000 (03:09 +0000)]
Removed. (stream_write): Keep looping (non-blocking case) if errno is
2001-10-29 Jeffrey Stedfast <fejj@ximian.com>
* camel-tcp-stream-openssl.c (my_SSL_write): Removed.
(stream_write): Keep looping (non-blocking case) if errno is
EAGAIN, EINTR or EWOULDBLOCK. For NONBLOCKing I/O, sync up with
CamelTcpStreamRaw. As with CamelTcpStreamRaw/SSL - make sure to
write out everything before returning.
(my_SSL_read): Removed.
(stream_read): Just call ssl_error_to_errno() and check the errno
values that we care about so we can keep the general look of all
this stream code the same. Also when checking the return value of
SSL_read, check for <0 instead of ==-1 since the man page for
SSL_read doesn't say it will return -1 on fail, it just says <0.
(stream_flush): Don't fsync() since syncing on a socket is a Bad
Thing (tm).
* camel-tcp-stream-ssl.c (stream_write): Make sure we write out
everything just like in camel-tcp-stream-raw.c.
* camel-stream-buffer.c (camel_stream_buffer_gets): If
camel_stream_read() returns -1, don't necessarily return -1 to our
caller since it's possible that we did actually "read" some data
(ie, we copied some pre-buffered data into the out buffer).
* camel-stream-buffer.h: Removed CAMEL_STREAM_BUFFER_NEWLINE since
it never got used anywhere and it isn't supported anyway.
0 [Tue, 30 Oct 2001 01:34:55 +0000 (01:34 +0000)]
If we get an empty name, then mark that as NoSelect. Workaround fix for
2001-10-30 <NotZed@Ximian.com>
* providers/imap/camel-imap-store.c
(parse_list_response_as_folder_info): If we get an empty name,
then mark that as NoSelect. Workaround fix for #13239.
Dan Winship [Tue, 30 Oct 2001 00:52:11 +0000 (00:52 +0000)]
Set an X-Evolution-Source header on the returned message so replies come
* providers/imap/camel-imap-folder.c (get_message_simple,
imap_get_message): Set an X-Evolution-Source header on the
returned message so replies come from the right identity.
9 [Tue, 30 Oct 2001 00:24:55 +0000 (00:24 +0000)]
If we're not going to search on a changed uid, make sure we change out
2001-10-29 <NotZed@Ximian.com>
* camel-vee-folder.c (folder_changed_change): If we're not going
to search on a changed uid, make sure we change out copy still.
Fixes #13916.
Jeffrey Stedfast [Mon, 29 Oct 2001 23:23:12 +0000 (23:23 +0000)]
Don't emit a folder_subscribed signal if we are in the process of renaming
2001-10-29 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-store.c (subscribe_folder): Don't emit
a folder_subscribed signal if we are in the process of renaming
folders.
(unsubscribe_folder): Same here but for the unsubscribe signal.
(rename_folder): Unsubscribe from the folder being renamed and any
subfolders it may have before actually renaming. Once the folder
has been renamed, re-subscribe to it and it's subfolders with the
new name.
* camel-store.c (camel_folder_info_build): Sort the folder info's
before constructing the tree.
Jeffrey Stedfast [Mon, 29 Oct 2001 20:51:24 +0000 (20:51 +0000)]
Minor fix - should have been using a strNcmp when checking if it was an
2001-10-29 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-utils.c (header_decode_param): Minor fix - should
have been using a strNcmp when checking if it was an rfc2047
encoded word.
Jeffrey Stedfast [Mon, 29 Oct 2001 18:40:12 +0000 (18:40 +0000)]
Notify the user that PGP 2.6.x is no longer supported and use
2001-10-29 Jeffrey Stedfast <fejj@ximian.com>
* camel-pgp-context.c (pgp_sign): Notify the user that PGP 2.6.x
is no longer supported and use camel_exception_set() instead of
setv() where appropriate.
(pgp_clearsign): Same.
(pgp_verify): And again here.
(pgp_encrypt): Here too.
(pgp_decrypt): And finally here.
Dan Winship [Mon, 29 Oct 2001 18:31:40 +0000 (18:31 +0000)]
Don't free the hash table key if the folder wasn't found in the hash
* providers/imap/camel-imap-store.c (unsubscribe_folder): Don't
free the hash table key if the folder wasn't found in the hash
table. I'm not sure where the bug is/was that made it possible to
add a folder to the tree after creating it failed, but now if that
happens, it won't crash if you try to delete it again. (#11492)
Dan Winship [Mon, 29 Oct 2001 18:25:42 +0000 (18:25 +0000)]
if the service is being connected and thinks it's online, but the session
* camel-disco-store.c (camel_disco_store_status): if the service
is being connected and thinks it's online, but the session is
offline, then mark the service offline as well. Fixes 13683.
9 [Mon, 29 Oct 2001 08:24:00 +0000 (08:24 +0000)]
Turn off w() -> warnings.
2001-10-29 <NotZed@Ximian.com>
* camel-mime-utils.c: Turn off w() -> warnings.
* providers/imap/camel-imap-store.c (rename_folder): Also rename
the message cache.
(rename_folder): Fix subscribed folders table with rename(s).
* providers/imap/camel-imap-folder.c (imap_rename): Implement,
rename the cache dir pointer.
* providers/imap/camel-imap-message-cache.c
(camel_imap_message_cache_set_path): New method to set the path
used by a message cache.
9 [Mon, 29 Oct 2001 05:06:59 +0000 (05:06 +0000)]
Fix the 'is this a matching subfolder or subfolder'' logic to match
2001-10-29 <NotZed@Ximian.com>
* camel-vee-store.c (build_info): Fix the 'is this a matching
subfolder or subfolder'' logic to match camel-store
get_subfolders'.
* camel-store.c (get_subfolders): Fix the 'is this a matching
folder or subfolder' logic.
8 [Sun, 28 Oct 2001 13:05:36 +0000 (13:05 +0000)]
Changed to call ibex_move to rename it internally.
2001-10-28 <NotZed@Ximian.com>
* providers/local/camel-local-store.c (rename_folder): Changed to
call ibex_move to rename it internally.
8 [Sun, 28 Oct 2001 10:51:19 +0000 (10:51 +0000)]
Use the right variable, not info.
2001-10-28 <NotZed@Ximian.com>
* camel-store.c (camel_store_rename_folder): Use the right variable, not info.
Jeffrey Stedfast [Sun, 28 Oct 2001 09:37:36 +0000 (09:37 +0000)]
Make sure we've actually read data before checking if p[-] is '\r' or not.
2001-10-28 Jeffrey Stedfast <fejj@ximian.com>
* camel-stream-buffer.c (camel_stream_buffer_read_line): Make sure
we've actually read data before checking if p[-] is '\r' or not.
Jeffrey Stedfast [Sun, 28 Oct 2001 07:03:32 +0000 (07:03 +0000)]
Same.
2001-10-28 Jeffrey Stedfast <fejj@ximian.com>
* camel-tcp-stream-raw.c (stream_write): Same.
* camel-stream-fs.c (stream_write): If errno isn't EAGAIN, just
exit with -1 and instead of using continue (which doesn't go to
the top of the do-while thus making our logic suck), just set w to
0. Still seems to be a bug in select() if it's telling us the
socket is ready for data when it really isn't but oh well.
8 [Sun, 28 Oct 2001 05:10:56 +0000 (05:10 +0000)]
Use path not protocol as the path part of the uri of the folder_created
2001-10-28 <NotZed@Ximian.com>
* providers/local/camel-local-folder.c
(camel_local_folder_construct): Use path not protocol as the path
part of the uri of the folder_created event.
* providers/local/camel-maildir-store.c (scan_dir): If FAST is
set, dont try and scan for unread counts.
* providers/local/camel-local-store.c (create_folder): Implement,
just return the folderinfo of the folder matched, not all of it.
* camel-store.c (camel_store_rename_folder): Rename the
camelfolders before emitting the folderchanged event (otherwise
vstore fails to pick up change.
* camel-store.c (camel_store_init): Always use a default dir_sep
of '/'.
* camel-store.h (struct _CamelStore): Added a dir_sep to the base
store so rename and whatnot can work, temporary fix for mixed dir
separator in folder name api's.
* providers/imap/camel-map-store.c:
(imap_connect_online): Also set the store's dir_sep here.
(imap_connect_offline): "
Ettore Perazzoli [Sat, 27 Oct 2001 18:14:49 +0000 (18:14 +0000)]
More fixing of the license texts.
Ettore Perazzoli [Sat, 27 Oct 2001 16:59:34 +0000 (16:59 +0000)]
Fixing the license text.
7 [Sat, 27 Oct 2001 06:00:34 +0000 (06:00 +0000)]
Finished implementation.
2001-10-27 <NotZed@Ximian.com>
* providers/imap/camel-imap-store.c (rename_folder): Finished
implementation.
* providers/local/camel-local-folder.c (local_rename): Implement
local rename of folder objects.
2001-10-26 <NotZed@Ximian.com>
* camel-vee-folder.c (camel_vee_folder_class_init): Hook into
rename function.
(vee_rename): Implement the veefolder rename function.
(camel_vee_folder_class_init):
(folder_changed_change): Kill a warning with a cast.
* camel-vee-store.c (vee_rename_folder): Emit a folder_renamed
event properly, also call parent to do some rename stuff.
* camel-store.h: Added a CamelRenameInfo for the rename event.
* camel-folder.c (camel_folder_rename): New function to rename a
folder object.
(camel_folder_class_init): Added a renamed event.
(folder_rename): Default impl, set full_name, and set name
assuming the dir separator is '/'.
* camel-store.c (camel_store_class_init): Added folder_renamed
event.
(camel_store_rename_folder): Rename an active folder object if we
have one, and update the folder table.
(rename_folder): Make a default implementation that handles
updating the folder tree.
Jeffrey Stedfast [Sat, 27 Oct 2001 05:12:50 +0000 (05:12 +0000)]
Don't bother checking ex since we can rely on the response being NULL on
2001-10-26 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-store.c (delete_folder): Don't bother
checking ex since we can rely on the response being NULL on error.
(rename_folder): Implemented.
Ettore Perazzoli [Sat, 27 Oct 2001 00:20:37 +0000 (00:20 +0000)]
Update the licensing information to require version 2 of the GPL
(instead of version 2 or any later version).
Jeffrey Stedfast [Fri, 26 Oct 2001 23:13:20 +0000 (23:13 +0000)]
Check to make sure that the dataset is non-NULL before using and/or
2001-10-26 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-folder.c (imap_get_message): Check to
make sure that the dataset is non-NULL before using and/or
freeing.
Jeffrey Stedfast [Fri, 26 Oct 2001 22:54:02 +0000 (22:54 +0000)]
Check for EWOULDBLOCK too? (stream_read): Same. (stream_flush): Return 0
2001-10-26 Jeffrey Stedfast <fejj@ximian.com>
* camel-tcp-stream-raw.c (stream_write): Check for EWOULDBLOCK
too?
(stream_read): Same.
(stream_flush): Return 0 always, fsync() and tcp sockets don't
play nice :-)
* providers/imap/camel-imap-message-cache.c
(camel_imap_message_cache_get): Lets try putting a
camel_stream_reset() here. Logic being that the stream may have
been read from since it was cached and thus our caller may try
reading from it and get no data from it since it is already at the
EOS. This may fix bug #12943.
Jeffrey Stedfast [Fri, 26 Oct 2001 22:52:15 +0000 (22:52 +0000)]
Check for EWOULDBLOCK too? (stream_read): Same.
2001-10-26 Jeffrey Stedfast <fejj@ximian.com>
* camel-tcp-stream-raw.c (stream_write): Check for EWOULDBLOCK too?
(stream_read): Same.
* providers/imap/camel-imap-message-cache.c
(camel_imap_message_cache_get): Lets try putting a
camel_stream_reset() here. Logic being that the stream may have
been read from since it was cached and thus our caller may try
reading from it and get no data from it since it is already at the
EOS. This may fix bug #12943.
Jeffrey Stedfast [Fri, 26 Oct 2001 20:03:02 +0000 (20:03 +0000)]
Lets try putting a camel_stream_reset() here. Logic being that the stream
2001-10-26 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-message-cache.c
(camel_imap_message_cache_get): Lets try putting a
camel_stream_reset() here. Logic being that the stream may have
been read from since it was cached and thus our caller may try
reading from it and get no data from it since it is already at the
EOS. This may fix bug #12943.
5 [Fri, 26 Oct 2001 00:37:52 +0000 (00:37 +0000)]
Remove the stupid warning that should never have been there in the first
2001-10-25 <NotZed@Ximian.com>
* camel-search-private.c (utf8_get): Remove the stupid warning
that should never have been there in the first place.
* camel-sasl-digest-md5.c (digest_response): s/iconv/e_iconv/
* camel-pgp-context.c (pgp_verify): "
* camel-mime-utils.c (rfc2047_decode_word, rfc2047_decode_word,
append_8bit, rfc2047_encode_word, rfc2184_decode,
header_decode_param): "
* camel-mime-part-utils.c (convert_buffer, convert_buffer): "
* camel-mime-filter-charset.c (reset, complete, filter): "
Dan Winship [Thu, 25 Oct 2001 00:27:39 +0000 (00:27 +0000)]
Don't let fi->name be NULL.
* providers/imap/camel-imap-store.c (unsubscribe_folder): Don't
let fi->name be NULL.
Jeffrey Stedfast [Wed, 24 Oct 2001 22:15:47 +0000 (22:15 +0000)]
updated the SIMULATE_FLAKY_NETWORK code
Jeffrey Stedfast [Wed, 24 Oct 2001 21:09:35 +0000 (21:09 +0000)]
Same as in the TcpStreamRaw code. (stream_write): And again here...
2001-10-24 Jeffrey Stedfast <fejj@ximian.com>
* camel-stream-fs.c (stream_read): Same as in the TcpStreamRaw code.
(stream_write): And again here...
* camel-tcp-stream-raw.c (stream_read): Handle the EAGAIN error
case as well.
(stream_write): Same here, this might fix the SMTP truncation
thing? I hope?
Dan Winship [Tue, 23 Oct 2001 16:18:47 +0000 (16:18 +0000)]
Remove an extra * in one of the regexps that glibc apparently doesn't mind
* camel-mime-utils.c (mail_list_magic): Remove an extra * in one
of the regexps that glibc apparently doesn't mind but bsd does.
3 [Tue, 23 Oct 2001 06:20:06 +0000 (06:20 +0000)]
made d(x) x recompile again.
2001-10-23 <NotZed@Ximian.com>
* providers/local/camel-mbox-summary.c: made d(x) x recompile again.
2 [Mon, 22 Oct 2001 22:40:58 +0000 (22:40 +0000)]
No, use Storing, as the other code does :p (spool_summary_check): Check
2001-10-22 <NotZed@Ximian.com>
* providers/local/camel-spool-summary.c (summary_rebuild): No, use
Storing, as the other code does :p
(spool_summary_check): Check for consistency.
Jon Trowbridge [Mon, 22 Oct 2001 22:34:46 +0000 (22:34 +0000)]
s/summarising/summarizing/. (spool_summary_check): s/summarise/summarize/.
2001-10-22 Jon Trowbridge <trow@ximian.com>
* providers/local/camel-spool-summary.c (summary_rebuild):
s/summarising/summarizing/.
(spool_summary_check): s/summarise/summarize/.
Jeffrey Stedfast [Mon, 22 Oct 2001 21:50:21 +0000 (21:50 +0000)]
If we are kludging around a inline-pgp signed part, do some charset
2001-10-22 Jeffrey Stedfast <fejj@ximian.com>
* camel-pgp-mime.c (camel_pgp_mime_part_verify): If we are
kludging around a inline-pgp signed part, do some charset
conversion to protect any 8bit text.
Michael Zucci [Mon, 22 Oct 2001 21:08:05 +0000 (21:08 +0000)]
Use search_type_mlist for mailing list searches.
* camel-filter-search.c, camel-folder-search.c (check_header): Use
search_type_mlist for mailing list searches.
* camel.c (camel_init): call camel-mime-utils-init func.
* camel-mime-utils.c: Changed mail mail_list_magic to include a
domain part, also pre-compile all the patterns. They are all
backward compatible except List-Id: which now uses the
mail-address-like <list-name.host.name> part rather than the
plain-text part (which might've been blank anyway).
(camel_mime_utils_init): Initialisation function to setup any
static data required by camel-mime-utils at run-time. We now
setup the base64/charset class tables here, so it doesn't need to
be done statically.
(camel_mime_special_table, camel_mime_base64_rank): No longer
statically initialise these.
(main): Removed + the tests at the end of the file.
(header_raw_check_mailing_list): Dont compile regex's here,
already compiled in utils_init. Use the regex patterns to remove
leading <'s from addresses. Also, if there is a domain part
matched, add that after a '@' is added.
camel-search-private.c:
(camel_search_header_match): Added SEARCH_TYPE_MLIST for mlist
search types. It ignores the domain part if either (but not both)
of the values dont have it.
Michael Zucci [Mon, 22 Oct 2001 19:12:06 +0000 (19:12 +0000)]
(camel_search_header_match): Oops, missing i=0.
Dan Winship [Mon, 22 Oct 2001 18:46:46 +0000 (18:46 +0000)]
Pass a CORBA_Environment to bonobo_config_get_string so it doesn't g_warn
* e-passwords.c (e_passwords_get_password): Pass a
CORBA_Environment to bonobo_config_get_string so it doesn't g_warn
on error. (Since the "error" is most likely just that the password
isn't cached.)
(e_passwords_remember_password, e_passwords_get_password,
e_passwords_add_password): Change "if (foo) { entire function; }"
to "if (!foo) return;"
* e-html-utils.c (special_chars): Don't allow single quote or
backtick in email addresses, or pipes following URLs.
2 [Mon, 22 Oct 2001 18:29:01 +0000 (18:29 +0000)]
Match check against all addresses in a multiple address match. Should fix
2001-10-22 <NotZed@Ximian.com>
* camel-search-private.c (camel_search_header_match): Match check
against all addresses in a multiple address match. Should fix
#13051.
Dan Winship [Mon, 22 Oct 2001 17:44:50 +0000 (17:44 +0000)]
Add a hack: if the multipart/signed part has a "x-inline-pgp-hack"
* camel-pgp-mime.c (camel_pgp_mime_part_verify): Add a hack: if
the multipart/signed part has a "x-inline-pgp-hack" parameter in
its Content-Type, don't pass the MIME headers as part of the data
to be verified.
Rodrigo Moya [Mon, 22 Oct 2001 17:10:14 +0000 (17:10 +0000)]
added $GNOME_INCLUDEDIR to INCLUDES, needed for latest libgnome, which
2001-10-22 Rodrigo Moya <rodrigo@ximian.com>
* Makefile.am: added $GNOME_INCLUDEDIR to INCLUDES, needed for latest
libgnome, which install headers in $(prefix)/gnome-1.0
Jeffrey Stedfast [Mon, 22 Oct 2001 02:08:10 +0000 (02:08 +0000)]
Only do the rawtext checks if the part is a text part, otherwise don't
2001-10-21 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-part-utils.c
(simple_data_wrapper_construct_from_parser): Only do the rawtext
checks if the part is a text part, otherwise don't bother wasting
cpu cycles.
Jeffrey Stedfast [Mon, 22 Oct 2001 00:45:25 +0000 (00:45 +0000)]
Updated comments to make the code a bit more clear.
2001-10-21 Jeffrey Stedfast <fejj@ximian.com>
* camel-store.c (camel_folder_info_build): Updated comments to
make the code a bit more clear.
1 [Sun, 21 Oct 2001 20:27:43 +0000 (20:27 +0000)]
Dont do the macro stuff - basically so you can actually debug calls.
2001-10-21 <NotZed@Ximian.com>
* camel-store.c (CS_CLASS): Dont do the macro stuff - basically so
you can actually debug calls.
(camel_store_uri_cmp): New function to compare store objects.
* camel-vee-folder.c (vee_folder_add_info): oops, dont free the
vuid, since its alloca'd now.
(folder_changed_change): Kill a compile warning.
1 [Sun, 21 Oct 2001 18:18:51 +0000 (18:18 +0000)]
oops, dont free the vuid, since its alloca'd now.
2001-10-21 <NotZed@Ximian.com>
* camel-vee-folder.c (vee_folder_add_info): oops, dont free the
vuid, since its alloca'd now.
0 [Sat, 20 Oct 2001 01:01:06 +0000 (01:01 +0000)]
If no exception supplied, use a local one. (move_message_to): Set the seen
2001-10-20 <NotZed@Ximian.com>
* camel-folder.c (move_messages_to): If no exception supplied, use
a local one.
(move_message_to): Set the seen flag also when we delete it.
Jeffrey Stedfast [Fri, 19 Oct 2001 23:32:05 +0000 (23:32 +0000)]
If the destination folder is the vfolder source folder, then
2001-10-19 Jeffrey Stedfast <fejj@ximian.com>
* camel-vtrash-folder.c (vtrash_move_messages_to): If the
destination folder is the vfolder source folder, then
set_message_flags on it.
9 [Fri, 19 Oct 2001 22:25:54 +0000 (22:25 +0000)]
When registering provider, translate all strings.
2001-10-19 <NotZed@Ximian.com>
* camel-session.c (register_provider): When registering provider,
translate all strings.
Michael Zucci [Fri, 19 Oct 2001 21:26:18 +0000 (21:26 +0000)]
camel-vee-folder.c (folder_changed_change): Change logic, we always add
camel-vee-folder.c
(folder_changed_change): Change logic, we always add changed stuff
if it now matches, but dont remove it unless its auto-remove, only
propagate changes for it.
(vee_set_message_flags): Call parent method after doing our work.
(vee_set_message_user_flag): Same here.
Michael Zucci [Fri, 19 Oct 2001 20:32:22 +0000 (20:32 +0000)]
Fixes a deadlock. camel-vee-folder.c: (folder_changed_change): Ok, so dont
Fixes a deadlock.
camel-vee-folder.c:
(folder_changed_change): Ok, so dont hold the subfolder lock for
the whole duration of the changed event, although we probably
should, requires a recursive mutex.
Michael Zucci [Fri, 19 Oct 2001 07:03:50 +0000 (07:03 +0000)]
Typo, srlen aint right.
Michael Zucci [Fri, 19 Oct 2001 06:39:54 +0000 (06:39 +0000)]
camel-vee-folder.c: (folder_changed_change_uid): Use alloca for vuid, and
camel-vee-folder.c:
(folder_changed_change_uid): Use alloca for vuid, and not
sprintf(".lengths")
(vee_search_by_expression): Dont use sprintf for vuid.
(vee_search_by_uids): "
(vee_folder_add_info): "
(folder_changed_remove_uid): "
(folder_changed_change): "
(folder_changed_change_uid): Also check folder_unmatched for
changed uid's so we properly update/propagate unmatched changes.
9 [Fri, 19 Oct 2001 05:33:21 +0000 (05:33 +0000)]
Lock the right lock for unmatched subfolder list stuff. If the sub folder
2001-10-19 <NotZed@Ximian.com>
* camel-vee-folder.c (camel_vee_folder_remove_folder): Lock the
right lock for unmatched subfolder list stuff. If the sub folder
is deleted & part of unmatched, or the last ref to the sub folder
is gone from unmatched, blow it away completely from unmatched,
but only do it once.
(vee_folder_remove_folder): Added arg to kill unmatched
unconditionally. Also handle deleted folders, always remove
stuff.
(folder_changed_change): Lock subfolder lock for entirety of
operation, and also check to see if the subfolder is still there
before doing any fancy work (incase it got removed while we were
waiting to execute).
* camel-store.c (camel_store_unsubscribe_folder): If we are
unsubscribing from a folder we have loaded, set the folder
deleted, as with the delete_folder case.
Jeffrey Stedfast [Fri, 19 Oct 2001 02:34:13 +0000 (02:34 +0000)]
If a charset isn't specified or claims to be utf-8, check the validity of
2001-10-18 Jeffrey Stedfast <fejj@ximian.com>
* camel-mime-part-utils.c
(simple_data_wrapper_construct_from_parser): If a charset isn't
specified or claims to be utf-8, check the validity of the text
and if it's invalid, set the rawtext bit to TRUE. If the charset
is x-unknown or some other x- charset, always set the rawtext bit
to TRUE.
8 [Fri, 19 Oct 2001 01:54:42 +0000 (01:54 +0000)]
Added CAMEL_CFLAGS so we get the right iconv stuff, patch from Yanko
2001-10-18 <NotZed@Ximian.com>
* providers/(imap|local|pop3|sendmail|smtp)/Makefile.am: Added
CAMEL_CFLAGS so we get the right iconv stuff, patch from Yanko
Kaneti <yaneti@declera.com>
Jeffrey Stedfast [Fri, 19 Oct 2001 00:30:36 +0000 (00:30 +0000)]
Make sure the cancel_fd isn't -1.
2001-10-18 Jeffrey Stedfast <fejj@ximian.com>
* camel-pgp-context.c (crypto_exec_with_passwd): Make sure the
cancel_fd isn't -1.
Jeffrey Stedfast [Thu, 18 Oct 2001 23:15:34 +0000 (23:15 +0000)]
Flush the stream here, not sure it really matters but it might (hopefully)
2001-10-18 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-message-cache.c (insert_finish): Flush
the stream here, not sure it really matters but it might
(hopefully) fix bug #12943.
Jeffrey Stedfast [Thu, 18 Oct 2001 22:48:26 +0000 (22:48 +0000)]
Make user-cancellable.
2001-10-18 Jeffrey Stedfast <fejj@ximian.com>
* camel-pgp-context.c (crypto_exec_with_passwd): Make
user-cancellable.
Jeffrey Stedfast [Thu, 18 Oct 2001 22:26:06 +0000 (22:26 +0000)]
String cleanup for bug #6640.
2001-10-18 Jeffrey Stedfast <fejj@ximian.com>
* providers/local/camel-local-provider.c: String cleanup for bug
#6640.
Jeffrey Stedfast [Thu, 18 Oct 2001 20:38:45 +0000 (20:38 +0000)]
Fix my Cyrus imapd workaround...instead of checking to see if info->flags
2001-10-18 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap/camel-imap-folder.c (imap_sync_online): Fix my
Cyrus imapd workaround...instead of checking to see if info->flags
== FLAGGED, just check to see if it contains any IMAP flags.
7 [Wed, 17 Oct 2001 22:59:15 +0000 (22:59 +0000)]
Use '.' as the inbox name for filter new messages test.
2001-10-17 <NotZed@Ximian.com>
* providers/local/camel-maildir-folder.c
(camel_maildir_folder_new): Use '.' as the inbox name for filter
new messages test.
7 [Wed, 17 Oct 2001 22:44:27 +0000 (22:44 +0000)]
New function to clone a folderinfo tree.
2001-10-17 <NotZed@Ximian.com>
* camel-store.c (camel_folder_info_clone): New function to clone a
folderinfo tree.
Jeffrey Stedfast [Wed, 17 Oct 2001 22:23:29 +0000 (22:23 +0000)]
Same as maildir and mbox append-message.
2001-10-17 Jeffrey Stedfast <fejj@ximian.com>
* providers/local/camel-mh-folder.c (mh_append_message): Same as
maildir and mbox append-message.
* providers/local/camel-maildir-folder.c (maildir_append_message):
Same as mbox append.
* camel-exception.c (camel_exception_set): Make sure the new
description isn't the same as the old description pointer before
freeing the old one.
(camel_exception_setv): Don't free the old description until we
set the new one this way we can reuse the old description in the
new description.
* providers/local/camel-mbox-folder.c (mbox_append_message): If
errno == EINTR, then we got a user-cancel so set the exception
appropriately so that we don't make the user shit his pants.
Jeffrey Stedfast [Wed, 17 Oct 2001 22:16:46 +0000 (22:16 +0000)]
Make sure the new description isn't the same as the old description
2001-10-17 Jeffrey Stedfast <fejj@ximian.com>
* camel-exception.c (camel_exception_set): Make sure the new
description isn't the same as the old description pointer before
freeing the old one.
(camel_exception_setv): Don't free the old description until we
set the new one this way we can reuse the old description in the
new description.
* providers/local/camel-mbox-folder.c (mbox_append_message): If
errno == EINTR, then we got a user-cancel so set the exception
appropriately so that we don't make the user shit his pants.
Jeffrey Stedfast [Wed, 17 Oct 2001 21:33:41 +0000 (21:33 +0000)]
Add an optimization for when destination folder is the same as the source
2001-10-17 Jeffrey Stedfast <fejj@ximian.com>
* camel-filter-driver.c (do_copy): Add an optimization for when
destination folder is the same as the source folder.
7 [Wed, 17 Oct 2001 20:38:15 +0000 (20:38 +0000)]
Patch from Danw, Use unread count of -1 to mark unflagged messages. Make
2001-10-17 <NotZed@Ximian.com>
* providers/imap/camel-imap-store.c (get_folder_info_online):
(parse_list_response_as_folder_info): Patch from Danw, Use unread
count of -1 to mark unflagged messages. Make sure any folder we
dont lookup explicitly is marked as -1. Should fix #9947 and
friends.
* providers/local/camel-mbox-summary.c (mbox_summary_sync): Only
touch the summary if the timestamp or size changed.
Jeffrey Stedfast [Wed, 17 Oct 2001 20:23:42 +0000 (20:23 +0000)]
Set the DELETED flag on directly on the info if the source folder doesn't
2001-10-17 Jeffrey Stedfast <fejj@ximian.com>
* camel-filter-driver.c (camel_filter_driver_filter_message): Set
the DELETED flag on directly on the info if the source folder
doesn't have summary capability.
Not Zed [Wed, 17 Oct 2001 04:09:17 +0000 (04:09 +0000)]
As below.
2001-10-17 Not Zed <NotZed@Ximian.com>
* camel-tcp-stream-raw.c (stream_write): As below.
* camel-stream-fs.c (stream_write): If not checking cancellation,
make sure we write out everything asked of us.
Jeffrey Stedfast [Wed, 17 Oct 2001 00:12:33 +0000 (00:12 +0000)]
Rearange the order of the gpg options slightly otherwise it might try to
2001-10-16 Jeffrey Stedfast <fejj@ximian.com>
* camel-pgp-context.c (pgp_verify): Rearange the order of the gpg
options slightly otherwise it might try to use "--no-tty" as the
filename to verify :-)
Jeffrey Stedfast [Tue, 16 Oct 2001 21:47:34 +0000 (21:47 +0000)]
If CAMEL_DEBUG is defined, print some useful ref/unref info.
2001-10-16 Jeffrey Stedfast <fejj@ximian.com>
* camel-object.[c,h]: If CAMEL_DEBUG is defined, print some useful
ref/unref info.
* providers/imap/camel-imap-store.c (delete_folder): Fixed an
assignment warning.
* camel-uid-cache.c (camel_uid_cache_new): Make sure that the
parent directory exists before trying to open the filename, if it
doesn't, create it.
6 [Tue, 16 Oct 2001 20:35:49 +0000 (20:35 +0000)]
If no content, dont try and decode further and spit meaningless warnings.
2001-10-16 <NotZed@Ximian.com>
* camel-mime-utils.c (header_address_decode): If no content, dont
try and decode further and spit meaningless warnings.
Jeffrey Stedfast [Tue, 16 Oct 2001 19:03:16 +0000 (19:03 +0000)]
Only perform the operation on the folder if the folder has summary
2001-10-16 Jeffrey Stedfast <fejj@ximian.com>
* camel-filter-driver.c (do_flag): Only perform the operation on
the folder if the folder has summary capability, else just poke
the info directly. Fixes the "Filters don't work" bug.
(do_score): Same.
(do_colour): And here too.
Jeffrey Stedfast [Mon, 15 Oct 2001 22:10:19 +0000 (22:10 +0000)]
Save the errno before calling fcntl so fcntl doesn't overwrite errno in
2001-10-15 Jeffrey Stedfast <fejj@ximian.com>
* camel-stream-fs.c (stream_read): Save the errno before calling
fcntl so fcntl doesn't overwrite errno in case of a previous
error.
(stream_write): Same.
Jeffrey Stedfast [Sat, 13 Oct 2001 18:21:31 +0000 (18:21 +0000)]
Replace the Bcc headers in a single location and don't flush the data
2001-10-13 Jeffrey Stedfast <fejj@ximian.com>
* providers/smtp/camel-smtp-transport.c (smtp_data): Replace the
Bcc headers in a single location and don't flush the data unless
the write was successful.
Jeffrey Stedfast [Fri, 12 Oct 2001 23:09:34 +0000 (23:09 +0000)]
oops, it should remove the bcc header, not the cc header
Jeffrey Stedfast [Fri, 12 Oct 2001 22:45:10 +0000 (22:45 +0000)]
Remove the stripheader filter from the build.
2001-10-12 Jeffrey Stedfast <fejj@ximian.com>
* Makefile.am: Remove the stripheader filter from the build.
* camel-mime-filter-stripheader.[c,h]: Removed.
* providers/smtp/camel-smtp-transport.c (smtp_data): Check the
return value of camel_stream_flush to make sure it flushed the
data successfully before continuing. Don't use the stripheader
filter, it was completely broken - instead remove the header and
set it again after we send.
2 [Fri, 12 Oct 2001 22:27:56 +0000 (22:27 +0000)]
Unhook from all events before removing folder.
2001-10-12 <NotZed@Ximian.com>
* camel-vee-folder.c (camel_vee_folder_remove_folder): Unhook from
all events before removing folder.
(camel_vee_folder_add_folder): Hook onto delete event.
(camel_vee_folder_finalise): Unhook from deleted event for suibfolder.
(subfolder_deleted): When the folder is deleted, remove it from
the vfolder automagically.
Chris Toshok [Fri, 12 Oct 2001 22:19:34 +0000 (22:19 +0000)]
new parameter to e_passwords_init, and add prototype for
2001-10-12 Chris Toshok <toshok@ximian.com>
* e-passwords.h: new parameter to e_passwords_init, and add
prototype for e_passwords_clear_component_passwords.
* e-passwords.c (e_passwords_init): copy off the component name.
(e_passwords_shutdown): free/NULL the component name.
(e_passwords_clear_component_passwords): new function. remove the
subtree rooted at /Passwords/<ComponentName>.
(e_passwords_remember_password): use component_name when building
up the path.
(e_passwords_get_password): same.
(e_passwords_add_password): remove/free the currently stored
session password for this key if there is one, before adding the
new one.
Chris Toshok [Fri, 12 Oct 2001 02:01:38 +0000 (02:01 +0000)]
change prototype for e_passwords_get_password.
2001-10-11 Chris Toshok <toshok@ximian.com>
* e-passwords.h: change prototype for e_passwords_get_password.
* e-passwords.c (e_passwords_get_password): remove 'const' from
return type - the return type is now allocated and must be freed
by the caller.
1 [Thu, 11 Oct 2001 23:39:08 +0000 (23:39 +0000)]
convert the uids list to a subset appropriate for each subfolder before
2001-10-11 <NotZed@Ximian.com>
* camel-vee-folder.c (vee_search_by_uids): convert the uids list
to a subset appropriate for each subfolder before trying to search
on it.
1 [Thu, 11 Oct 2001 22:08:20 +0000 (22:08 +0000)]
Removed charset/locale charset lookup and iconv_open/close functions,
2001-10-11 <NotZed@Ximian.com>
* camel-charset-map.[ch]: Removed charset/locale charset lookup
and iconv_open/close functions, moved to gal. Fixed all callers.
Jeffrey Stedfast [Thu, 11 Oct 2001 21:57:20 +0000 (21:57 +0000)]
Same.
2001-10-11 Jeffrey Stedfast <fejj@ximian.com>
* camel-tcp-stream-ssl.c (ssl_cert_is_saved): Same.
* camel-tcp-stream-openssl.c (ssl_cert_is_saved): Instead of
opening the file, stat it and make sure that it belongs to us.
Chris Toshok [Thu, 11 Oct 2001 20:13:23 +0000 (20:13 +0000)]
open the bonobo config db for our passwords. (e_passwords_shutdown): sync
2001-10-11 Chris Toshok <toshok@ximian.com>
* e-passwords.c (e_passwords_init): open the bonobo config db for
our passwords.
(e_passwords_shutdown): sync and unref the bonobo db, and clear
out the per session hash.
(e_passwords_forget_passwords): remove the bonobo config db
/Passwords path, and free up the session hash (but don't destroy
it).
(e_passwords_remember_password): remove the key/value from the
session hash, after inserting it into the bonobo db.
(e_passwords_get_password): look up a session password for the
uri, and if it's not there, consult the bonobo db.
(e_passwords_ask_password): quiet gcc's warnings, and only consult
the toggle button state if we actaully created it.
Jeffrey Stedfast [Wed, 10 Oct 2001 22:13:05 +0000 (22:13 +0000)]
Same hack as below.
2001-10-10 Jeffrey Stedfast <fejj@ximian.com>
* camel-tcp-stream-openssl.c (ssl_verify): Same hack as below.
* camel-tcp-stream-ssl.c (ssl_bad_cert): Hack around the fact that
adding a cert to nss's certdb seems to not work.
0 [Wed, 10 Oct 2001 21:50:42 +0000 (21:50 +0000)]
Only re-build the folder if we're expunging. Also only clear out the
2001-10-10 <NotZed@Ximian.com>
* camel-vee-folder.c (vee_sync): Only re-build the folder if we're
expunging. Also only clear out the changed folders list if we're
expungung and everything worked.
Michael Zucci [Wed, 10 Oct 2001 21:50:30 +0000 (21:50 +0000)]
slight wording changes, mainly LGPL=>GPL
Jeffrey Stedfast [Wed, 10 Oct 2001 21:36:22 +0000 (21:36 +0000)]
Added a hack for Solaris systems.
2001-10-10 Jeffrey Stedfast <fejj@ximian.com>
* camel-charset-map.c (camel_charset_map_init): Added a hack for
Solaris systems.
0 [Wed, 10 Oct 2001 19:48:27 +0000 (19:48 +0000)]
oops, we want get_unread_message_count, not get_message_count!
2001-10-10 <NotZed@Ximian.com>
* providers/local/camel-maildir-store.c (scan_dir): oops, we want
get_unread_message_count, not get_message_count!
2001-10-09 <NotZed@Ximian.com>
* camel-service.c (camel_service_disconnect): Duplicate connect
code that unregisters a cancel op if we created one.
Jeffrey Stedfast [Wed, 10 Oct 2001 19:03:29 +0000 (19:03 +0000)]
updated
9 [Tue, 9 Oct 2001 23:36:31 +0000 (23:36 +0000)]
Another go at getting the logic right again. Make transients only update
2001-10-09 <NotZed@Ximian.com>
* camel-operation.c (camel_operation_progress): Another go at
getting the logic right again. Make transients only update after
5 seconds (CAMEL_OPERATION_TRANSIENT_DELAY)
(camel_operation_end): Likewise.
Michael Zucci [Tue, 9 Oct 2001 23:13:21 +0000 (23:13 +0000)]
Forgot a little bit of debug.