Elinor Fung [Wed, 8 May 2019 21:28:45 +0000 (14:28 -0700)]
Specify version.dll and add notification hook for delay load (#24449)
Mitigates an issue with hijacking of version.dll.
This is particularly an issue for self-contained and single-file-exe apps, as the hijacking in those cases does not require access to a machine-wide .NET Core install.
Fadi Hanna [Wed, 8 May 2019 20:39:15 +0000 (13:39 -0700)]
Fix 23317. (#24383)
The issue is that a LDVIRTFTN operation becomes a dictionary lookup to a direct call to an abstract function with no code. We AV later when executing the PreStub of that direct call. Fixed by making this a dictionary lookup to a MethodDescSlot lookup, followed by the call to the JIT_VirtualFunctionPointer helper to resolve the target code (Same logic executing in jitted IL mode)
Steve MacLean [Wed, 8 May 2019 20:08:29 +0000 (16:08 -0400)]
Remove more MDA support code (#24457)
* Remove more MDA support code
* PR Feedback
Fadi Hanna [Wed, 8 May 2019 17:36:16 +0000 (10:36 -0700)]
Add a check to prevent mixed-mode assemblies from being compiled into R2R (#24451)
Sergey Andreenko [Wed, 8 May 2019 16:19:11 +0000 (09:19 -0700)]
Merge pull request #24447 from sandreenko/addGCStressExtraJobs
Add GCStress extra jobs.
Andrew Au [Wed, 8 May 2019 00:23:42 +0000 (17:23 -0700)]
Handle the case when the SamplingProfiler thread is terminated prematurely
Mike McLaughlin [Wed, 8 May 2019 07:46:51 +0000 (00:46 -0700)]
Add generate crash dump command to diagnostics server (#24460)
Add the DiagnosticProtocolHelper class to deserialize and dispatch
the new GenerateCoreDump command.
Refactor the PAL createdump launch on unhandled exception code to
used by a new PAL_GenerateCoreDump method that doesn't depend on
the complus dump environment variables.
Changed the "full" createdump not to include the uncommitted pages and
removed the "add module metadata" workaround for SOS clrstack !UNKNOWN
problem now that is fixed in SOS (crashinfo.cpp).
Sergey Andreenko [Wed, 8 May 2019 04:22:55 +0000 (21:22 -0700)]
Merge pull request #24463 from sandreenko/ExcludeMethodImpl
Exclude MethodImplOptionsTests.
Sergey Andreenko [Wed, 8 May 2019 01:09:27 +0000 (18:09 -0700)]
Exclude MethodImplOptionsTests.
Exclude the test because the fix is postponed.
Bruce Forstall [Tue, 7 May 2019 23:23:34 +0000 (16:23 -0700)]
Merge pull request #24444 from BruceForstall/FixGenerateLayoutArgPassing
Fix build.cmd passing of args to runtest.cmd
Tarek Mahmoud Sayed [Tue, 7 May 2019 22:35:46 +0000 (15:35 -0700)]
Make Idn.GetAscii compatible with Windows (#24443)
GetAscii on Windows ignore if the uri has hyphens in the third and fourth places. We relaxing this on Linux too for the sake of the consistent behavior. This issue was causing some problems with the http stack.
Tanner Gooding [Tue, 7 May 2019 20:18:16 +0000 (13:18 -0700)]
Fixing up time.cpp in the PAL (#24428)
* Fixing up time.cpp in the PAL
* Fixing GetTickCount64 in the PAL to continue using CLOCK_MONOTONIC_COARSE where available
* Reverting QueryPerformanceFrequency in the PAL to return tccSecondsToNanoSeconds for CLOCK_MONOTONIC
* Removing two unused variables from GetTickCount64 in the PAL
* Updating the PAL to error if neither mach_absolute_time nor clock_gettime(CLOCK_MONOTONIC) are supported.
* Fixing the PAL configure.cmake to link rt where applicable
Sergey Andreenko [Tue, 7 May 2019 19:11:23 +0000 (12:11 -0700)]
Fix typo.
Bruce Forstall [Tue, 7 May 2019 18:06:28 +0000 (11:06 -0700)]
Fix build.cmd passing of args to runtest.cmd
If you use the `generatelayout` argument to build.cmd, it passes
all "unprocessed" arguments directly on to msbuild. To accomplish
the same this with runtest.cmd, you must use the "msbuildargs"
argument, or else the arg will be treated as a `CORE_ROOT` argument.
(This seems like a bad design, but that's a separate issue.)
E.g., I always pass `/consoleloggerparameters:ForceNoAlign`, and want
that passed on to runtest.cmd. (This should also be the default, but
once again, that's a separate issue.)
Sergey Andreenko [Tue, 7 May 2019 17:55:51 +0000 (10:55 -0700)]
Add GCStress extra jobs.
Contributes to #24358.
Jeremy Koritzinsky [Tue, 7 May 2019 17:46:00 +0000 (10:46 -0700)]
Update Microsoft.Build.Traversal SDK to v2. (#24430)
Sergey Andreenko [Tue, 7 May 2019 17:35:29 +0000 (10:35 -0700)]
Merge pull request #23587 from BrianBohe/brbohe/moving_variableLiveRange
Moving VariableLiveRanges classes outside Compiler class
Sergey Andreenko [Tue, 7 May 2019 04:49:20 +0000 (21:49 -0700)]
Merge pull request #24421 from sandreenko/AddZapDisableTailCallStresss
Add ZapDisable and TailCallStress ADO testing.
Mukul Sabharwal [Tue, 7 May 2019 03:53:14 +0000 (20:53 -0700)]
Add option to only notify profiler of LOH allocations (#24291)
Anirudh Agnihotry [Tue, 7 May 2019 03:31:35 +0000 (20:31 -0700)]
making DiagnosticCounter internal (#24427)
Sergey Andreenko [Mon, 6 May 2019 23:39:22 +0000 (16:39 -0700)]
Merge pull request #24415 from sandreenko/corefxAddExclsusions
Add new CoreFX exclusions.
Jeremy Koritzinsky [Mon, 6 May 2019 23:09:28 +0000 (16:09 -0700)]
Move the Formatting jobs over to AzDO (#24367)
* First stab at running the format jobs in AzDO.
* Add display names for formatting jobs.
* Try to use a python version in the path
* Try to fix bootstrap download.
* Use imported paths. Output python major version.
* Clean up imports.
* Fix imports.
* Try just using urlretrieve again
* Cleanup
* Add back killing spurious dotnet processes.
* Try leaving all shutdown/kill work to AzDO.
* PR Feedback.
Brian Bohe [Mon, 6 May 2019 23:01:39 +0000 (20:01 -0300)]
Leaving Scope Info as variable location tracking default system again
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
Fadi Hanna [Mon, 6 May 2019 23:00:05 +0000 (16:00 -0700)]
Replace E_FAIL with E_NOTIMPL for an unsupported R2R encoding (Future work) (#24386)
Andrew Au [Mon, 6 May 2019 19:04:13 +0000 (12:04 -0700)]
Launch DiagnosticServer after EEStartup
Tomáš Rylek [Mon, 6 May 2019 21:38:45 +0000 (23:38 +0200)]
Improve R2RDump resiliency towards invalid tokens (#24379)
This change adds a bunch of try blocks that make R2RDump survive
partially corrupted input.
Thanks
Tomas
Jeremy Koritzinsky [Mon, 6 May 2019 20:45:52 +0000 (13:45 -0700)]
Handle E_NOTIMPL return from CoInitializeEx. (#24387)
* Handle E_NOTIMPL return from CoInitializeEx.
* Remove unneeded STA attributes.
Sergey Andreenko [Mon, 6 May 2019 19:29:33 +0000 (12:29 -0700)]
Add zapdisable and tailcallstress testing.
Sergey Andreenko [Mon, 6 May 2019 19:29:18 +0000 (12:29 -0700)]
Rename ADO group outerloop-jitminopts-jitstress1-jitstress2 to outerloop-jitstress.
Allows us to add more scenarios there.
Aaron Robinson [Mon, 6 May 2019 17:19:49 +0000 (10:19 -0700)]
Port all managed product binaries to use SDK style projects (#24285)
Convert managed product binary to use SDK project system.
- Uses Arcade for versions strings
- Overrides Arcade defined output paths - should change in the future
Sergey Andreenko [Mon, 6 May 2019 16:12:07 +0000 (09:12 -0700)]
Add new CoreFX exclusions.
Mukul Sabharwal [Mon, 6 May 2019 15:21:19 +0000 (08:21 -0700)]
Fixes AV when accessing LoaderModule for some objects (#24406)
Krzysztof Wicher [Mon, 6 May 2019 13:50:18 +0000 (06:50 -0700)]
Nullable: System.Collections.Generic remainder (#24340)
* Nullable: System.Collections.Generic remainder
* apply review feedback
Ben Adams [Sun, 5 May 2019 20:01:07 +0000 (21:01 +0100)]
Move AsyncMethodBuilder.SetStateMachine to non-generic (#24403)
dotnet-maestro[bot] [Sun, 5 May 2019 14:55:14 +0000 (14:55 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190505.1 (#24401)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190505.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190505.1
Steve MacLean [Sat, 4 May 2019 18:31:34 +0000 (14:31 -0400)]
Reenable corefx tests (#24157)
Adeel Mujahid [Sat, 4 May 2019 16:43:35 +0000 (19:43 +0300)]
Minor tweaks for gcc (#24391)
* Fix a consistency check condition
Following error is reported by gcc 8 with debug configuration:
> error: enum constant in boolean context [-Werror=int-in-bool-context]
* Apply -Wno-register only to CXX flags
gcc 8 errors out like this:
```
[ 96%] Building C object src/ilasm/CMakeFiles/ilasm.dir/__/__/version.c.o
cc1: error: command line option -Wno-register is valid for C++/ObjC++ but not for C [-Werror]
cc1: all warnings being treated as errors
src/ilasm/CMakeFiles/ilasm.dir/build.make:254: recipe for target 'src/ilasm/CMakeFiles/ilasm.dir/__/__/version.c.o' failed
make[2]: *** [src/ilasm/CMakeFiles/ilasm.dir/__/__/version.c.o] Error 1
CMakeFiles/Makefile2:5710: recipe for target 'src/ilasm/CMakeFiles/ilasm.dir/all' failed
make[1]: *** [src/ilasm/CMakeFiles/ilasm.dir/all] Error 2
```
* Remove extra parantheses from variable declaration
gcc 8 reports:
> error: unnecessary parentheses in declaration of m_HashedModules [-Werror=parentheses]
* Use macro instead of const in C
gcc throws:
> error: variably modified collatorsPerOption at file scope
UCollator* collatorsPerOption[CompareOptionsMask + 1];
* Cast to uintptr_t before (32-bit) DWORD
gcc error was:
> error: cast from LPCWSTR {aka const char16_t*} to DWORD {aka unsigned int} loses precision [-fpermissive]
dotnet-maestro[bot] [Sat, 4 May 2019 14:50:46 +0000 (14:50 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190504.1 (#24393)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190504.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190504.1
Sergey Andreenko [Sat, 4 May 2019 09:08:38 +0000 (02:08 -0700)]
Merge pull request #24392 from dotnet/revert-24363-GitHub_23199
Revert "Fix GCStress for multireg returns. "
Sergey Andreenko [Sat, 4 May 2019 09:02:07 +0000 (02:02 -0700)]
Revert "Fix GCStress for multireg returns. "
Koundinya Veluri [Sat, 4 May 2019 05:35:03 +0000 (22:35 -0700)]
Fix incorrect tier reported by SOS (#24374)
Fix incorrect tier reported by SOS
- The tier of the initial code version was being assumed to be 0
- Whether call counting is enabled for a method needed to be available to the DAC
- Some small renames / cleanup to simplify code
Jan Kotas [Thu, 2 May 2019 20:07:24 +0000 (13:07 -0700)]
Fix CoreRT build breaks
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Sung Yoon Whang [Sat, 4 May 2019 01:05:57 +0000 (18:05 -0700)]
Re-enable EventSourceTrace test (#24365)
Jeremy Koritzinsky [Sat, 4 May 2019 00:56:20 +0000 (17:56 -0700)]
Use our local-built instances of tools from Microsoft.DotNet.BuildTools.CoreClr instead of using the package. (#24347)
* Use our local-built instances of tools from Microsoft.DotNet.BuildTools.CoreClr instead of using the package.
* Fix const-correctness in InjectResource.
* Build cross-arch native components before building native components for target arch.
* Build InjectResource and GenClrDebugResource for the host arch when cross-building and import the targets into the cross-build.
* install(EXPORT) in the directory where the target is created
Andrew Au [Fri, 3 May 2019 22:44:06 +0000 (15:44 -0700)]
Fix EventPipe initialization order
David Mason [Fri, 3 May 2019 23:52:46 +0000 (16:52 -0700)]
Enable CoreFX test filtering for CoreCLR PRs (#24259)
This change enables CoreFX tests for CoreCLR.
Russ Keldorph [Fri, 3 May 2019 16:46:28 +0000 (09:46 -0700)]
Disable remaining Jenkins default-PR-triggered jobs
Jeremy Koritzinsky [Fri, 3 May 2019 23:25:55 +0000 (16:25 -0700)]
Change our DateTime marshalling tests to be culture-independent. (#24362)
Fixes #24089
William Godbe [Fri, 3 May 2019 21:53:24 +0000 (14:53 -0700)]
Merge pull request #24315 from dotnet/darc-master-
c4cf8915-b4aa-4756-a614-
aa01a76fd5cb
[master] Update dependencies from dnceng/internal/dotnet-optimization
Tomáš Rylek [Fri, 3 May 2019 21:15:25 +0000 (23:15 +0200)]
New options --sb / --isb for binary signature dump (#24375)
Based on JanV's suggestion I have added two new options to R2RDump:
"--sb" (SignatureBinary) appends the binary signature representation
at the end of the parsed textual signature;
"--isb" (InlineSignatureBinary) inlines the signature bytes into
the parsed textual signature and makes it (somewhat) easy to correlate
the binary bytes with individual parts of the signature.
Thanks
Tomas
Brian Sullivan [Fri, 3 May 2019 13:56:16 +0000 (06:56 -0700)]
Merge pull request #24343 from briansull/add-hva-tests
Add two additional HVA tests:
Filip Navara [Fri, 3 May 2019 13:37:19 +0000 (15:37 +0200)]
Implement String.IsAscii in shared CoreLib and use it for [Is]Normalize[d] for all runtimes (#24373)
dotnet-maestro [Fri, 3 May 2019 13:01:55 +0000 (13:01 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190503.1
- optimization.IBC.CoreCLR - 99.99.99-master-
20190503.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190503.1
Sergey Andreenko [Fri, 3 May 2019 07:59:56 +0000 (00:59 -0700)]
Merge pull request #24363 from sandreenko/GitHub_23199
Fix GCStress for multireg returns.
Sergey Andreenko [Fri, 3 May 2019 07:58:16 +0000 (00:58 -0700)]
Update the comment.
Levi Broderick [Fri, 3 May 2019 06:09:56 +0000 (23:09 -0700)]
Vector.CopyTo / TryCopyTo should be readonly methods (#24359)
Vladimir Sadov [Fri, 3 May 2019 05:16:31 +0000 (22:16 -0700)]
System.GC.AllocateUninitializedArray (#24096)
* Do not expand to allocation_quantum in SOH when GC_ALLOC_ZEROING_OPTIONAL
* short-circuit short arrays to use `new T[size]`
* Clean syncblock of large-aligned objects on ARM32
* specialize single-dimensional path AllocateSzArray
* Unit tests
* Some PR feedback. Made AllocateUninitializedArray not be trimmed away.
* PR feedback on gchelpers
- replaced use of multiple bool parameters with flags enum
- merged some methods with nearly identical implementation
- switched callers to use AllocateSzArray vs. AllocateArrayEx where appropriate.
* PR feedback. Removed X86 specific array/string allocation helpers.
Brian Sullivan [Fri, 3 May 2019 01:07:46 +0000 (18:07 -0700)]
Merge pull request #24339 from briansull/linux-creation-time
Fix the PAL implemention of GetProcessTimes to write the creation time
Brian Sullivan [Fri, 3 May 2019 00:14:34 +0000 (17:14 -0700)]
Changes from code review
Andrew Au [Thu, 2 May 2019 18:06:52 +0000 (11:06 -0700)]
Make sure we check the second buffer's creation date before we return
Andrew Au [Thu, 2 May 2019 20:32:48 +0000 (13:32 -0700)]
Make sure the thread running EventPipe::Disable is registered with the thread store so that rundown events can be collected
Sergey Andreenko [Thu, 2 May 2019 22:45:08 +0000 (15:45 -0700)]
Fix DoGcStress for multireg return with GC pointers.
Note: we are overprotecting registers here, for example, we always protect 2 registers even if only one is returned. GCStress infrastructure should be able to tolerate extra registers. We have had such examples before (for example when returned a struct without pointers we protected the first reg anyway).
Brian Sullivan [Wed, 1 May 2019 17:45:39 +0000 (10:45 -0700)]
In the PAL GetProcessTimes implement lpCreationTime using the current time returned by gettimeofday
This allows IBC profile data to record a meaningful time of when the training scenario was run.
Made EPOCH_DIFF a defined constant
Change calcTime to be an unsigned 64-bit integer
Change constants to units of 100NS instead of NS to avoid division and integer overflows.
Use the defined constants SECS_TO_100NS and USECS_TO_100NS when performing time calculations
Don't add a space after the Assembly arg when argc is zero
Sergey Andreenko [Thu, 2 May 2019 22:05:40 +0000 (15:05 -0700)]
Add a repro test.
Koundinya Veluri [Thu, 2 May 2019 20:48:13 +0000 (13:48 -0700)]
When QuickJit is enabled, disable it for methods that contain loops by default (#24252)
When QuickJit is enabled, disable it for methods that contain loops by default
Fixes https://github.com/dotnet/coreclr/issues/19751 by default when QuickJit is enabled
- Added config variable TC_QuickJitForLoops. When disabled (the default), the JIT identifies loops and explicit tail calls and switches to tier 1 JIT.
- This would prevent the possibility of spending too long in QuickJit code, but may decrease startup time a bit when QuickJit is enabled
- Removed TC_StartupTier_OptimizeCode, as now that there is TC_QuickJit, I didn't see a good use for it
- Removed references to "StartupTier" in config variables because we had previously decided not to call it that.
- When QuickJit is disabled, avoid creating native code slots for methods in non-R2R'ed modules, as tiering would be disabled for those anyway
- Marked TC_QuickJit config var as external
Sung Yoon Whang [Thu, 2 May 2019 19:34:39 +0000 (12:34 -0700)]
Add Series/CounterType to CounterPayload and IncrementingCounterPayload (#24349)
Jan Vorlicek [Thu, 2 May 2019 19:16:25 +0000 (21:16 +0200)]
Merge pull request #24332 from janvorli/fix-module-override
Fix module override effect on method instantiating signature
Krzysztof Wicher [Wed, 1 May 2019 20:29:33 +0000 (13:29 -0700)]
Add using System.Diagnostics on some files
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Stephen Toub [Wed, 1 May 2019 17:52:38 +0000 (13:52 -0400)]
Delete stale compilation constants from AsyncIteratorMethodBuilder (#37331)
I accidentally left these MICROSOFT_BCL_ASYNCINTERFACES_PACKAGE references in as part of some recent churn. This compilation constant isn't set anywhere.
And the CORERT ifdef is no longer needed now that we've consolidated the code to shared.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Stephen Toub [Wed, 1 May 2019 15:57:35 +0000 (11:57 -0400)]
Add ManualResetValueTaskSourceCore / AsyncIterateMethodBuilder to Microsoft.Bcl.AsyncInterfaces (#37320)
* Add ManualResetValueTaskSourceCore / AsyncIterateMethodBuilder to Microsoft.Bcl.AsyncInterfaces
These two types needed modifications to target .NET Standard 2.0 and are the necessary pieces to enable the compiler to compile async iterators.
- Copied ManualResetValueTaskSourceCore.cs from coreclr and tweaked it. I opted to do this rather than ifdef because the changes are not localized and I didn't want to significantly perturb the primary implementation.
- Added a few ifdefs to the shared AsyncIteratorMethodBuilder. It already had ifdefs, so I just added to it.
- Added a test project, and included the existing ManualResetValueTaskSourceCore tests. I had to disable two of the tests because of some of the optimization differences.
- Augmented those tests to validate that the compiler is able to successfully generate iterators and await foreach them.
* Address PR feedback
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Tanner Gooding [Thu, 2 May 2019 18:15:49 +0000 (11:15 -0700)]
Adding more coverage for the AES hwintrinsic tests. (#24335)
* Updating the AES tests to cover all current scenarios
* Regenerating the AES HWIntrinsic tests from the updated templates.
* Fixing a couple of typos in the Aes*OpTest.templates
* Modifying CodeGen::inst_RV_TT_IV to no longer assert when memIndir is nullptr
David Wrighton [Thu, 2 May 2019 17:53:59 +0000 (10:53 -0700)]
Re-enable all com crossgen testing (#24348)
- COM testing with crossgen was disabled due to lack of manifest support in crossgen
dotnet-maestro-bot [Thu, 2 May 2019 17:41:32 +0000 (10:41 -0700)]
Update CoreClr to preview6-27702-71 (#24353)
Ludovic Henry [Thu, 2 May 2019 14:39:19 +0000 (07:39 -0700)]
Implement GC.RegisterMemoryLoadChangeNotification (#24202)
* Implement GC.RegisterMemoryLoadChangeNotification
This allows users to register a callback to be called whenever the
memory load is between a low and high thresholds. The idea is to allow
them to tweak their memory usage based on the available memory.
It is only internal for now because we are not confident on the shape of
the API and if it's the best we can provide users. This needs to go
through a few iterations with first party users like ASP.NET or corefx.
WIP for https://github.com/dotnet/coreclr/issues/18619
* fixup! Implement GC.RegisterMemoryLoadChangeNotification
* fixup! Implement GC.RegisterMemoryLoadChangeNotification
* fixup! Implement GC.RegisterMemoryLoadChangeNotification
Tomáš Rylek [Thu, 2 May 2019 13:23:08 +0000 (15:23 +0200)]
Bug fix in R2RDump signature decoder w.r.t. large version bubbles (#24352)
JanV discovered a complex signature where the generic type argument
got decoded in an incorrect module context by R2RDump. Investigating
the issue I found out that the problem was caused by my slight
misunderstanding - all module override indices within a signature
are relative to the global signature context module, not to the current
context module that may change during descent into the signature tree.
Thanks
Tomas
Jan Vorlicek [Thu, 2 May 2019 09:12:10 +0000 (11:12 +0200)]
Merge pull request #24322 from am11/libunwind-format-specifier
Unify Wformat suppression for libunwind
Sung Yoon Whang [Thu, 2 May 2019 06:47:04 +0000 (23:47 -0700)]
Add threading-related runtime counters (#24304)
* Add threadpool/contention counters
* fix build error
Dan Moseley [Thu, 2 May 2019 05:49:50 +0000 (22:49 -0700)]
Adjust some terms (#24351)
Adeel [Thu, 2 May 2019 04:56:20 +0000 (04:56 +0000)]
Unify Wformat suppression for libunwind
Krzysztof Wicher [Thu, 2 May 2019 04:21:29 +0000 (21:21 -0700)]
Nullable: Interop and src/System remainder (#24328)
* Nullable: Interop and src/System remainder
* apply feedback
Krzysztof Wicher [Thu, 2 May 2019 04:20:50 +0000 (21:20 -0700)]
Nullable: System.Collections remainder (non-generic) (#24326)
* Nullable: System.Collections remainder (non-generic)
* apply feedback
dotnet-maestro-bot [Thu, 2 May 2019 04:20:28 +0000 (21:20 -0700)]
Update CoreClr to preview6-27701-72 (#24329)
Blake Hensley [Thu, 2 May 2019 04:07:07 +0000 (21:07 -0700)]
Added overloads to Path.Join (#24307)
* Added overloads to Path.Join
* Refactor Path.Join and Path.Combine to use ValueStringBuilder
* Use proper defined const for empty string
* Fix Windows-specific const
Andrew Au [Thu, 2 May 2019 01:31:14 +0000 (18:31 -0700)]
Addressing code review feedbacks
Andrew Au [Thu, 2 May 2019 01:21:48 +0000 (18:21 -0700)]
Simplifying Pop() logic
Andrew Au [Wed, 1 May 2019 00:12:12 +0000 (17:12 -0700)]
Remove the RundownThread filter
Andrew Au [Mon, 29 Apr 2019 20:50:58 +0000 (13:50 -0700)]
Avoid nested spin lock in WriteAllBuffersToFile and GetNextEvent
Sung Yoon Whang [Wed, 24 Apr 2019 22:09:00 +0000 (15:09 -0700)]
Pulling in Noah's fix in event_pipe_lock_fix branch
Fadi Hanna [Thu, 2 May 2019 00:49:28 +0000 (17:49 -0700)]
Update issues.targets and reduce test execution time. (#24345)
* Update issues.targets and reduce test execution time.
Andy Hanson [Wed, 1 May 2019 23:36:57 +0000 (16:36 -0700)]
When large pages are enabled, only reserve/commit 1x seg size for LOH (#24320)
When large pages are enabled, we must commit everything we reserve.
Previously we reserved 2x the segment size for LOH. This is a problem
with large pages where we must commit everything we reserve.
Thanks to https://github.com/dotnet/coreclr/pull/24081 this does not
cause performance regression with large pages; but without large pages
we were seeing regressions when the loh_seg_size was reduced. So this
change will only take effect when large pages are enabled.
David Wrighton [Wed, 1 May 2019 22:29:34 +0000 (15:29 -0700)]
Copy all win32 resources (#24308)
- Add crossgen test to verify file version is preserved
- Add support for general win32 resource copying to ReadyToRun
- Copy all resources
Stephen Toub [Wed, 1 May 2019 20:54:40 +0000 (16:54 -0400)]
Move the new ConfigureAwait/WithCancellation extension methods to a new type (#24331)
We decided after all to put these on a different type, TaskAsyncEnumerableExtensions. This commit adds the new type. We can delete the methods in the old location once corefx consumes an updated build and switches over to using the new ones.
Brian Sullivan [Wed, 1 May 2019 20:51:32 +0000 (13:51 -0700)]
Add two additional HVA tests:
VectorMgdMgdStatic.cs - Tests where we are passing and using a HVA that is stored in a static
VectorMgdMgdArray.cs - Tests where we are passing and using a HVA that is stored in an array
Russ Keldorph [Wed, 1 May 2019 17:52:10 +0000 (10:52 -0700)]
Update SDK to 2.1.504
(Hopefully) Fixes #24083
Russ Keldorph [Wed, 1 May 2019 12:41:00 +0000 (05:41 -0700)]
Disable CallbackStressTest everywhere.
dotnet-maestro [Wed, 1 May 2019 12:55:11 +0000 (12:55 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190501.1
- optimization.IBC.CoreCLR - 99.99.99-master-
20190501.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190501.1
Tanner Gooding [Wed, 1 May 2019 02:00:44 +0000 (19:00 -0700)]
Updating lookupNamedIntrinsic to no longer assert for an unexpected hwintrinsic method. (#24327)
Jan Vorlicek [Wed, 1 May 2019 01:22:03 +0000 (03:22 +0200)]
Fix module override effect on method instantiating signature
When a module override is placed on a fixup blob top level, it also
affects types in the method instantiating signature. This can cause
tokens in the signature to be resolved in a wrong module.
This change fixes it by adding module zapsig elements before each
argument of the method's instantiating signature.
Santiago Fernandez Madero [Tue, 30 Apr 2019 22:01:45 +0000 (15:01 -0700)]
Merge pull request #24258 from dotnet/NullableFeature
Merge nullable feature into master
Andrew Au [Tue, 30 Apr 2019 18:31:29 +0000 (11:31 -0700)]
Changing comments/names that refers to file switching to flushing instead