platform/upstream/dotnet/runtime.git
5 years agoChange EstablishConnectionAndProcessOneRequestAsync test method to use WhenAllOrAnyFa...
Stephen Toub [Tue, 11 Jun 2019 20:01:14 +0000 (13:01 -0700)]
Change EstablishConnectionAndProcessOneRequestAsync test method to use WhenAllOrAnyFailed (dotnet/corefx#38462)

* Change EstablishConnectionAndProcessOneRequestAsync test method to use WhenAllOrAnyFailed

CI is currently hanging when the client operation fails in a way that the server never hears about the request, and waits forever.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/0b5479dde70fc565c5edefac4259578865496e84

5 years agoProvide more exception details when PlatformDetection.ToVersion fails (dotnet/corefx...
Stephen Toub [Tue, 11 Jun 2019 20:00:42 +0000 (13:00 -0700)]
Provide more exception details when PlatformDetection.ToVersion fails (dotnet/corefx#38463)

Commit migrated from https://github.com/dotnet/corefx/commit/49b6ade10a35e44573da6e851bc09133d5922c0a

5 years agoRemove allocation for empty Activity.Baggage/Tags (dotnet/corefx#38389)
Stephen Toub [Tue, 11 Jun 2019 18:28:40 +0000 (11:28 -0700)]
Remove allocation for empty Activity.Baggage/Tags (dotnet/corefx#38389)

Accessing Activity.Baggage/Tags allocates an enumerable, even when there is no baggage or tags.  This fast-paths the empty case.

Commit migrated from https://github.com/dotnet/corefx/commit/ec93eb4e8a0b225c1bfca093396328e6ba1fe9d2

5 years agoResolves dotnet/corefx#37250. Re-enable tests that dotnet/corefx#38038 resolved....
Cory Nelson [Tue, 11 Jun 2019 18:11:16 +0000 (11:11 -0700)]
Resolves dotnet/corefx#37250. Re-enable tests that dotnet/corefx#38038 resolved. (dotnet/corefx#38461)

Commit migrated from https://github.com/dotnet/corefx/commit/5f5925c0c1a3a87e870db36ca6acce81dedf3bc9

5 years agoFix several comparison issues in ConcurrentBag (dotnet/corefx#38424)
Stephen Toub [Tue, 11 Jun 2019 15:34:32 +0000 (08:34 -0700)]
Fix several comparison issues in ConcurrentBag (dotnet/corefx#38424)

A failed assert now and again in CI highlighted that we weren't properly accounting for overflows in ConcurrentBag.  In a variety of cases we compare the head position to the tail position, e.g. `head < tail` to determine if there are items in the queue, but in some situations when a position is temporarily updated, head can temporarily progress beyond tail, and if it does and wraps around due to overflow, we can end up in a situation where the condition passes even though it shouldn't.  This fixes all of the comparisons to do the subtraction and compare to 0, to avoid the overflow issue.

Separately, TrySteal had an inverted condition that was checking whether the queue contained at least 2 elements rather than checking whether it contained <= 2.  Also fixed that by inverting the check, along with doing the comparison appropriately per the above.

Commit migrated from https://github.com/dotnet/corefx/commit/56496a6dc2583db7ec82e779235813e0b8d32611

5 years agoMake it so GenAPI is only used during online source build (dotnet/corefx#38433)
Eric StJohn [Tue, 11 Jun 2019 15:17:34 +0000 (08:17 -0700)]
Make it so GenAPI is only used during online source build (dotnet/corefx#38433)

Commit migrated from https://github.com/dotnet/corefx/commit/548e58ebe2346c04a3353a53e6d8c64ab38198d0

5 years ago[3.0 Bug fix]Fix JsonSerializer.WriteAsync (dotnet/corefx#38308)
Marco Rossignoli [Tue, 11 Jun 2019 04:56:58 +0000 (06:56 +0200)]
[3.0 Bug fix]Fix JsonSerializer.WriteAsync (dotnet/corefx#38308)

* fix serialization

* create tailored test

* cleanup namespace

* address some feedback

* add poco test

* update test

* simplify loop

Commit migrated from https://github.com/dotnet/corefx/commit/bab7cea4e612c8d0bd13b4a52a2c91ec974f4e96

5 years agoAdd debug state machine tracking to GoAwayFrame_NoPendingStreams_ConnectionClosed...
Stephen Toub [Tue, 11 Jun 2019 03:22:05 +0000 (20:22 -0700)]
Add debug state machine tracking to GoAwayFrame_NoPendingStreams_ConnectionClosed test (dotnet/corefx#38438)

Commit migrated from https://github.com/dotnet/corefx/commit/0b0df51dab6f641e2988846dd6913de2db30789c

5 years agoFix review comments in dotnet/corefx#38280 (dotnet/corefx#38406)
Liudmila Molkova [Tue, 11 Jun 2019 02:09:37 +0000 (19:09 -0700)]
Fix review comments in dotnet/corefx#38280 (dotnet/corefx#38406)

Commit migrated from https://github.com/dotnet/corefx/commit/6d37591d13dd58abc90b7f15b707f605e809be29

5 years agoRework Linux/Kerberos native interop layer (dotnet/corefx#38377)
David Shulman [Tue, 11 Jun 2019 02:06:08 +0000 (19:06 -0700)]
Rework Linux/Kerberos native interop layer (dotnet/corefx#38377)

The latest changes to the System.Net.Security.Native shim layer fixed a lot of important
bugs for Linux Kerberos usage. But this created a new problem since SqlClient ships
in out-of-band NuGet packages separate from the .NET Core runtime. SqlClient builds
out of the CoreFx repo and uses the common source includes for Kerberos authentication.
This created an unexpected dependency on the System.Net.Security.Native shim layer.
The recent changes to these API signatures caused problems with different combinations
of SqlClient NuGet packages and .NET Core 2.x versus .NET Core 3.0.

After discussion with the SqlClient team, we decided to rework the changes to these
native APIs so that they would remain compatible across all .NET Core versions.

Long-term, the plan is to implement dotnet/corefx#36896 to expose a Kerberos API in .NET Core which
could be used by SqlClient and other consumers.

Closes dotnet/corefx#37183
Closes dotnet/corefx#25205

Commit migrated from https://github.com/dotnet/corefx/commit/7f920b2984a97ce8643bc8e64a93e7bd4d8a059e

5 years agoUpdate System.Runtime.Caching owner to Steve (dotnet/corefx#38429)
Hong Li [Tue, 11 Jun 2019 01:01:20 +0000 (18:01 -0700)]
Update System.Runtime.Caching owner to Steve (dotnet/corefx#38429)

Commit migrated from https://github.com/dotnet/corefx/commit/9a42e7974e2cb99cec9cf30058d8681542186e09

5 years agoSome tests imported from Newtonsoft Json (dotnet/corefx#38153)
buyaa-n [Tue, 11 Jun 2019 00:51:30 +0000 (17:51 -0700)]
Some tests imported from Newtonsoft Json (dotnet/corefx#38153)

Tests imported from Newtonsoft Json

Commit migrated from https://github.com/dotnet/corefx/commit/ff6ce7de1c206a5d552d98395b22f47a8eba368e

5 years agoAdd System.Text.Encoding.CodePages library to the shared framework (dotnet/corefx...
Tarek Mahmoud Sayed [Mon, 10 Jun 2019 22:48:13 +0000 (23:48 +0100)]
Add System.Text.Encoding.CodePages library to the shared framework (dotnet/corefx#38357)

* Add System.Text.Encoding.CodePages library to the shared framework

* Temporarily suppress check for CodePages on netcoreapp3.0

Commit migrated from https://github.com/dotnet/corefx/commit/b3663523e0c0705600042e327150fab88ccebae3

5 years agoAdd more packages to Microsoft.Windows.Compatibility (dotnet/corefx#38352)
Eric StJohn [Mon, 10 Jun 2019 19:35:53 +0000 (12:35 -0700)]
Add more packages to Microsoft.Windows.Compatibility (dotnet/corefx#38352)

Commit migrated from https://github.com/dotnet/corefx/commit/687ec698a4120a818dc8860bebfcd7a91df9a572

5 years agoRevert "Enable test for MemoryBarrierProcessWide on ARM64." (dotnet/corefx#38401)
Stephen Toub [Mon, 10 Jun 2019 15:17:56 +0000 (11:17 -0400)]
Revert "Enable test for MemoryBarrierProcessWide on ARM64." (dotnet/corefx#38401)

* Revert "Enable test for MemoryBarrierProcessWide on ARM64. (dotnet/corefx#38386)"

This reverts commit dotnet/corefx@7e56d8bd8b224d834b782a98bfd7035f71c3f547.

* Update comment for new issue number

Commit migrated from https://github.com/dotnet/corefx/commit/8135319caa7e457ed61053ca1418313b88057b51

5 years agoEnable test for MemoryBarrierProcessWide on ARM64. (dotnet/corefx#38386)
Vladimir Sadov [Sun, 9 Jun 2019 22:29:56 +0000 (15:29 -0700)]
Enable test for MemoryBarrierProcessWide on ARM64. (dotnet/corefx#38386)

* Enable test for MemoryBarrierProcessWide on ARM64 since corresponding bug is closed.

Re:https://github.com/dotnet/coreclr/issues/20215

Commit migrated from https://github.com/dotnet/corefx/commit/7e56d8bd8b224d834b782a98bfd7035f71c3f547

5 years agoadd cancellation tests
campersau [Fri, 7 Jun 2019 13:50:16 +0000 (15:50 +0200)]
add cancellation tests

Commit migrated from https://github.com/dotnet/corefx/commit/46d9f33d96a1db41a9634b84dd68256db2eeed4f

5 years agoPass CancellationToken to DbDataReader
campersau [Fri, 7 Jun 2019 08:58:20 +0000 (10:58 +0200)]
Pass CancellationToken to DbDataReader

Commit migrated from https://github.com/dotnet/corefx/commit/2cae0df3a727ea1d8965978c8f3b0ffb3756de78

5 years agoAugment GetStateMachineData to recur (dotnet/corefx#38376)
Stephen Toub [Sun, 9 Jun 2019 09:40:35 +0000 (05:40 -0400)]
Augment GetStateMachineData to recur (dotnet/corefx#38376)

The GetStateMachineData test helper I previously added only output the top-level state machine's fields.  This change causes it to recur into awaiters, so we can get more details on exactly what's being awaited and what's causing a hang.

Commit migrated from https://github.com/dotnet/corefx/commit/48c3adf8ad0256689375060437c2e6262d5e805a

5 years agoAdded LeaveOpen option to StreamPipeReader and StreamPipeWriter. (dotnet/corefx#37667)
Anatoly Zhmur [Sun, 9 Jun 2019 06:34:08 +0000 (08:34 +0200)]
Added LeaveOpen option to StreamPipeReader and StreamPipeWriter. (dotnet/corefx#37667)

* Added LeaveOpen option to StreamPipeReader and StreamPipeWriter.

* Added leaveOpen to PipeReader/WriterStreams

* Fixed review comments.

Commit migrated from https://github.com/dotnet/corefx/commit/83f60a5955b0b66886ec81bcce9c16ec7e2ee2c3

5 years agoFix nullability annotations for corelib updates
Stephen Toub [Sun, 9 Jun 2019 01:20:11 +0000 (21:20 -0400)]
Fix nullability annotations for corelib updates

Commit migrated from https://github.com/dotnet/corefx/commit/200a36f6591317f258c189d2220f45776a6c4bf3

5 years agoAdd DisplayUnits to DiagnosticCounter reference assembly
Sung Yoon Whang [Sat, 8 Jun 2019 23:26:49 +0000 (16:26 -0700)]
Add DisplayUnits to DiagnosticCounter reference assembly

Commit migrated from https://github.com/dotnet/corefx/commit/6203eb73f97b31503972bbe357e393287f3ecc74

5 years agoEnable tracing context propagation without listener in presence of parent Activity...
Liudmila Molkova [Sun, 9 Jun 2019 01:55:57 +0000 (18:55 -0700)]
Enable tracing context propagation without listener in presence of parent Activity (dotnet/corefx#38280)

* Enable tracing context propagation without listener in presence of parent Activity
* tests for AppContext switch

Commit migrated from https://github.com/dotnet/corefx/commit/35ebd462cc03bddc7ac135b7ec218ebd8357f7b2

5 years ago[Tests]: JsonSerializer.Parse for json strings containing Enum (dotnet/corefx#37895)
Maryam Ariyan [Sat, 8 Jun 2019 16:50:19 +0000 (09:50 -0700)]
[Tests]: JsonSerializer.Parse for json strings containing Enum (dotnet/corefx#37895)

* Adding tests for Parsing json strings contains Enums

Related to: dotnet/corefx#37735

* Broke down new tests to make more readable

* nit + Add ActiveIssue test for bug found

Commit migrated from https://github.com/dotnet/corefx/commit/af8d3eee98e018cb3fcbcf9d87f3d38725342dc2

5 years agoApply feedback from JsonElement back into original logic from Utf8JsonReader (dotnet...
Maryam Ariyan [Sat, 8 Jun 2019 05:38:48 +0000 (22:38 -0700)]
Apply feedback from JsonElement back into original logic from Utf8JsonReader (dotnet/corefx#38205)

use const length for stackalloc but keep using unsafe span stackalloc pattern

Commit migrated from https://github.com/dotnet/corefx/commit/20ba99aaf60ba91180f304211b096e1147564a7c

5 years ago[Code Coverage] Test for Utf8JsonReader.TryGetGuid (dotnet/corefx#38321)
Maryam Ariyan [Sat, 8 Jun 2019 00:05:15 +0000 (17:05 -0700)]
[Code Coverage] Test for Utf8JsonReader.TryGetGuid (dotnet/corefx#38321)

* [Code Coverage] Test for Utf8JsonReader.TryGetGuid
- For value sequence

* nit + Improve failure messaging for Assert.True/False

* Add isFinalBlock false case too

Commit migrated from https://github.com/dotnet/corefx/commit/ff3ad21651536853d156525f50b296fd883e775e

5 years agoHttpClient: Try decode Location header using UTF-8 (dotnet/corefx#37852)
Krzysztof Wicher [Fri, 7 Jun 2019 21:38:02 +0000 (14:38 -0700)]
HttpClient: Try decode Location header using UTF-8 (dotnet/corefx#37852)

* Use desktop logic for parsing Location (try decode using UTF-8)

* Tests and feedback

* fix netfx

* Convert UTF-8 in non-allocating way without try .. catch

Commit migrated from https://github.com/dotnet/corefx/commit/02026907370c57380a9f091b54ee77873f276a68

5 years agoUpdate code coverage docs and remove regular runs
Viktor Hofer [Fri, 7 Jun 2019 20:36:54 +0000 (22:36 +0200)]
Update code coverage docs and remove regular runs

Commit migrated from https://github.com/dotnet/corefx/commit/4b6562e0da17ba1d92d72bc2406af9eea3e9337a

5 years agoAvoid using X509Certificate2's IntPtr ctor in SecureChannel (dotnet/corefx#38344)
Stephen Toub [Fri, 7 Jun 2019 20:10:54 +0000 (16:10 -0400)]
Avoid using X509Certificate2's IntPtr ctor in SecureChannel (dotnet/corefx#38344)

* Avoid using X509Certificate2's IntPtr ctor in SecureChannel

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/82e49157906d6c9c1ed7013e99d50dca74e7fafc

5 years agoAdd debug data to help diagnose HTTP2 test failure (dotnet/corefx#38345)
Stephen Toub [Fri, 7 Jun 2019 20:09:38 +0000 (16:09 -0400)]
Add debug data to help diagnose HTTP2 test failure (dotnet/corefx#38345)

The GoAwayFrame_AbortAllPendingStreams_StreamFailWithExpectedException test has been frequently hanging on some Linux distros.  This adds some diagnostics to help track it down in CI: every minute, it'll dump out the fields of the async state machine, which if nothing else will let us see which await it's stuck on and what is the state of each of the tasks.

Commit migrated from https://github.com/dotnet/corefx/commit/410a162f68eb319e8066ac7bf2d7bcd6e2ce47d0

5 years agoFix issue in NamedPipeServerStream.GetImpersonationUserName() (dotnet/corefx#37676)
Carlos Sanchez Lopez [Fri, 7 Jun 2019 19:35:43 +0000 (12:35 -0700)]
Fix issue in NamedPipeServerStream.GetImpersonationUserName() (dotnet/corefx#37676)

Fix for issue where NamedPipeServerStream.GetImpersonationUserName() throws unexpected InvalidationOperationException("The operation completed successfully") when impersonation is not allowed, when in fact it should simply return an empty string.

The fix will call GetNamedPipeHandleStateW once. If it fails, it will try to load sspicli.dll if it was not loaded, and will reattempt the call to GetNamedPipeHandleStateW.

This fix is only for Win32: UAP does not allow calling LoadLibraryEx, and Windows Nano says denies access to GetNamedPipeHandleStateW even after attempting to load sspicli.dll.

Commit migrated from https://github.com/dotnet/corefx/commit/30c7f263fc60a558cbabf388555ebea211bce642

5 years agoMove type to last argument in order to meet fx design guidelines for overloads ...
Eric StJohn [Fri, 7 Jun 2019 19:21:24 +0000 (12:21 -0700)]
Move type to last argument in order to meet fx design guidelines for overloads  (dotnet/corefx#38272)

* Make type name last in the Add*Resource methods

* Reformat Res.Extensions ref

Includes the missing interface definitions & reorders the members.

Commit migrated from https://github.com/dotnet/corefx/commit/0e86c5b5ae460780a78ee7145204a151deebe7e4

5 years agoAdded CopyToAsync(PipeWriter) (dotnet/corefx#38326)
David Fowler [Fri, 7 Jun 2019 16:06:30 +0000 (09:06 -0700)]
Added CopyToAsync(PipeWriter) (dotnet/corefx#38326)

* Added CopyToAsync(PipeWriter)
- Reuse existing CopyToAsync routine to implement the PipeWriter overload.
- Added tests for PipeWriter overload

* Remove delegate allocations

Commit migrated from https://github.com/dotnet/corefx/commit/d4f34564bc98aee98adf0861dd4771ff473ebdbe

5 years agoDisable System.Net.Sockets.Async.Stress.Tests on CI
Viktor Hofer [Fri, 7 Jun 2019 15:30:28 +0000 (17:30 +0200)]
Disable System.Net.Sockets.Async.Stress.Tests on CI

Commit migrated from https://github.com/dotnet/corefx/commit/a39c60d9057db9b56ecdca5049900a205ec60ac9

5 years agoDon't throw in the On* callbacks (dotnet/corefx#38327)
David Fowler [Fri, 7 Jun 2019 14:24:21 +0000 (07:24 -0700)]
Don't throw in the On* callbacks (dotnet/corefx#38327)

- We can't throw NotSupportedException in the OnWriterCompleted and OnReaderCompleted callbacks since consumers of the API won't know if it's safe to do so. We could add a SupportsOn* boolean but nooping is a much simpler solution without breaking existing callers. We can also add a boolean in the future so callers will know when they can register callbacks or not.

Commit migrated from https://github.com/dotnet/corefx/commit/672cc2c985d1f6f00afe853e678ed05de9757724

5 years agoAllow OperationCanceledExceptions to propagate out of ClientWebSocket.ConnectAsync...
Stephen Toub [Fri, 7 Jun 2019 10:53:54 +0000 (06:53 -0400)]
Allow OperationCanceledExceptions to propagate out of ClientWebSocket.ConnectAsync (dotnet/corefx#38204)

They're currently being wrapped in WebSocketExceptions, but they should be allowed to escape unwrapped.

Commit migrated from https://github.com/dotnet/corefx/commit/513f9f92cb81e87dee358018ce59a48249d1c51d

5 years agoRemoved lost and unused file (dotnet/corefx#38320)
Yoh Deadfall [Fri, 7 Jun 2019 10:12:33 +0000 (13:12 +0300)]
Removed lost and unused file (dotnet/corefx#38320)

Commit migrated from https://github.com/dotnet/corefx/commit/18198f5758b6aed66293eb0de675286902700899

5 years agoProcessNameMatchesScriptName: add missing Fact attribute (dotnet/corefx#38251)
Tom Deseyn [Fri, 7 Jun 2019 03:16:12 +0000 (05:16 +0200)]
ProcessNameMatchesScriptName: add missing Fact attribute (dotnet/corefx#38251)

* ProcessNameMatchesScriptName: add missing Fact attribute

* Skip test on RHEL6

Commit migrated from https://github.com/dotnet/corefx/commit/de1da50fc5f972348aba2fa40ff14e1cbadb13de

5 years agoFix calls to functions moved from PathInternal to Path
Stephen Toub [Fri, 31 May 2019 02:54:01 +0000 (22:54 -0400)]
Fix calls to functions moved from PathInternal to Path

Commit migrated from https://github.com/dotnet/corefx/commit/b60e3c347d0af66dc7f7788b736be7f5315c3ad1

5 years agoDelete CoreFX tests of COM lifetime control methods. (dotnet/corefx#38290)
Jeremy Koritzinsky [Fri, 7 Jun 2019 02:58:08 +0000 (19:58 -0700)]
Delete CoreFX tests of COM lifetime control methods. (dotnet/corefx#38290)

* Delete CoreFX tests of COM lifetime control methods.

* Remove deleted files from project file.

Commit migrated from https://github.com/dotnet/corefx/commit/500e6882a78c92ecfd584bd4d8ba8e49f4410eb7

5 years agoSimplify loop add with UnionWith method. (dotnet/corefx#38300)
Tim [Fri, 7 Jun 2019 02:56:56 +0000 (21:56 -0500)]
Simplify loop add with UnionWith method. (dotnet/corefx#38300)

Commit migrated from https://github.com/dotnet/corefx/commit/78c4949d341dc51739e4027611f267700e58b60e

5 years agoRemove Redundant counter : System.Collections.Immutable.ImmutableHashSet_1.SetEquals...
wcontayon [Fri, 7 Jun 2019 02:51:38 +0000 (02:51 +0000)]
Remove Redundant counter : System.Collections.Immutable.ImmutableHashSet_1.SetEquals (dotnet/corefx#38325)

Commit migrated from https://github.com/dotnet/corefx/commit/29c88546923bca1cdfba6091098c5d25bd09fd00

5 years agoNullable annotate System.Private.Uri (dotnet/corefx#38113)
Stephen Toub [Fri, 7 Jun 2019 01:57:41 +0000 (21:57 -0400)]
Nullable annotate System.Private.Uri (dotnet/corefx#38113)

* Nullable annotate System.Private.Uri

* Address PR feedback

* Fix unit tests project

Commit migrated from https://github.com/dotnet/corefx/commit/df452f1ee61004dd1d61811fdd80ab165c2d8b1b

5 years agoAdd nullable attributes to partial facade implementations (dotnet/corefx#38309)
Stephen Toub [Fri, 7 Jun 2019 01:54:11 +0000 (21:54 -0400)]
Add nullable attributes to partial facade implementations (dotnet/corefx#38309)

* Add nullable attributes to partial facade implementations

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/3ea7b55e275fb6367f67e7fb0432be4bb3902f09

5 years agoThrowing Jsonexception when trying to convert a value into a Dictionary (dotnet/coref...
Anirudh Agnihotry [Thu, 6 Jun 2019 23:32:42 +0000 (16:32 -0700)]
Throwing Jsonexception when trying to convert a value into a Dictionary (dotnet/corefx#38183)

* improving exception

* adding immutable check and moving check to proper place

* adding poco dictionary tests

* combining if conditions

Commit migrated from https://github.com/dotnet/corefx/commit/05171beb453577b516caa051ce2bea2ae48d4b83

5 years agoExpose SecurityDescriptor as protected (dotnet/corefx#38283)
Jeremy Kuhne [Thu, 6 Jun 2019 22:16:53 +0000 (15:16 -0700)]
Expose SecurityDescriptor as protected (dotnet/corefx#38283)

* Expose SecurityDescriptor as protected

Classes derived from ObjectSecurity depended on seeing the _securityDescriptor field, which is marked internal. Internal visibility no longer works as types have split into different assemblies and is causing failures, such as dotnet/corefx#35993.

This change also ran the UpdateVSConfigurations target on the changed libraries.

* Address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/7570445805fe57966ff6494fcd582de8b79088a0

5 years agoMerge pull request dotnet/corefx#38317 from DustinCampbell/fix-38311
Dustin Campbell [Thu, 6 Jun 2019 22:13:53 +0000 (15:13 -0700)]
Merge pull request dotnet/corefx#38317 from DustinCampbell/fix-38311

Allow ReflectPropertyDescriptor to reflect over non-public members

Commit migrated from https://github.com/dotnet/corefx/commit/8dc48fad4eac24fd2997f6e73751fd7317e2b19b

5 years agoUpdate Reflection.Emit and String tests after changes due to nullable review (dotnet...
Santiago Fernandez Madero [Thu, 6 Jun 2019 21:01:05 +0000 (14:01 -0700)]
Update Reflection.Emit and String tests after changes due to nullable review (dotnet/corefx#38269)

* Update Reflection.Emit and String tests after changes due to nullable review

* Run darc update to update coreclr dependencies

* Add missing assert

Commit migrated from https://github.com/dotnet/corefx/commit/bdbdfaa286b94c44fadb2abd64e858b2e533a2cf

5 years agoRemove NetNative uapaot support (dotnet/corefx#38170)
Viktor Hofer [Thu, 6 Jun 2019 19:39:46 +0000 (21:39 +0200)]
Remove NetNative uapaot support (dotnet/corefx#38170)

* Remove NetNative uapaot support

* Remove uapaot assets from packages

* Disable emit lightweight and ilgen version check

Commit migrated from https://github.com/dotnet/corefx/commit/ab58ff6e649852b85fdb99b15992a2fa3a7d8834

5 years agoClean up code style in PropertyDescriptorTests.cs
Dustin Campbell [Thu, 6 Jun 2019 19:31:12 +0000 (12:31 -0700)]
Clean up code style in PropertyDescriptorTests.cs

Commit migrated from https://github.com/dotnet/corefx/commit/bce319455d8a71bc422249ffb5b1bed89cbffaa8

5 years agoAllow ReflectPropertyDescriptor to reflect over non-public members
Dustin Campbell [Thu, 6 Jun 2019 18:49:43 +0000 (11:49 -0700)]
Allow ReflectPropertyDescriptor to reflect over non-public members

Fixes dotnet/corefx#38311

On .NET Framework, ReflectPropertyDescriptor can access non-public members,
but has been disabled on .NET Core since ReflectPropertyDescriptor was ported.
Most PropertyDescriptor runtime scenarios don't require this behavior, but
design-time scenarios do. Component/Control designers can (and do) create new
PropertyDescriptors that expose non-public properties from runtime components
for design-time (e.g. for display in the Property Browser). In addition,
designers often create "shadow" properties which are used at design-time in place
of the actual properties on the runtime components. A shadowed property is normally
declared as private, but ReflectPropertyDescriptor still needs to be able to find
it.

Commit migrated from https://github.com/dotnet/corefx/commit/7cfe839e1d076b55fb14d5fa519f1b86d8833fa4

5 years agoMerge pull request dotnet/corefx#38312 from dotnet/MattGal-patch-1
Matt Galbraith [Thu, 6 Jun 2019 17:00:01 +0000 (10:00 -0700)]
Merge pull request dotnet/corefx#38312 from dotnet/MattGal-patch-1

Fix Debian 10 image

Commit migrated from https://github.com/dotnet/corefx/commit/a5eec2c658782103e5baf2a42f2112d5be063c66

5 years agoFix Debian 10 image
Matt Galbraith [Thu, 6 Jun 2019 16:47:22 +0000 (09:47 -0700)]
Fix Debian 10 image

Older image had missing home/helixbot folder which broke reporting;  tested and fixed in run e395a455-344e-411b-9ac2-1b3b89671ca3

@safern , @wfurt FYI

Commit migrated from https://github.com/dotnet/corefx/commit/e9bc423c0455a9c12702382e6f5cd7d0eeed7973

5 years agoImprove ReadOnlySequence.Slice docs (dotnet/corefx#38150)
Bradley Grainger [Thu, 6 Jun 2019 13:29:10 +0000 (06:29 -0700)]
Improve ReadOnlySequence.Slice docs (dotnet/corefx#38150)

* Improve ReadOnlySequence.Slice docs. Fixes dotnet/corefx#32021

* Synchronise documentation with dotnet-api-docs.

Commit migrated from https://github.com/dotnet/corefx/commit/7626863d5a48f771513f7d22977189aab14dcd0b

5 years agofix CopyToAsyncCore - cancellation and infinite loop (dotnet/corefx#37848)
Vladislav Richter [Thu, 6 Jun 2019 09:05:53 +0000 (11:05 +0200)]
fix CopyToAsyncCore - cancellation and infinite loop (dotnet/corefx#37848)

ReadResult result = await ReadAsync(cancellationToken).ConfigureAwait(false); should be before the try/finally block because if you cancel the read operation the finally clause will try to advance reader that is not in reading state and instead of OperationCancelledException you will end up with InvalidOperationException.

There is a bug either in PipeReader.CopyToAsyncCore() or ReadOnlySequence.TryGet():

When ReadOnlySequence.TryGet() reaches final segment it will return true and this final memory but it will also set position as default(SequencePosition) - I don't know if this is by design but CopyToAsyncCore() method does not take it in consideration and it will copy the memory but not advance the reader - this will cause it to repeat this data indefinitely.

* Fixed test CopyToAsyncWorks() to make sure that multiple separate reads from the reader produce expected result.
Added test to verify that cancellation between reads from the Reader throws OperationCancelledException.

Commit migrated from https://github.com/dotnet/corefx/commit/71aec681dd1247979e7956372abae8bbc02c9546

5 years agoRe-generate System.Threading.Overlapped ref assembly against implementation (dotnet...
Santiago Fernandez Madero [Thu, 6 Jun 2019 06:28:39 +0000 (23:28 -0700)]
Re-generate System.Threading.Overlapped ref assembly against implementation (dotnet/corefx#38282)

Commit migrated from https://github.com/dotnet/corefx/commit/4e0c8ec7b124e2a1c5294bee24e61ef42bbd79ec

5 years agoRe-generate System.Memory ref assembly against implementation (dotnet/corefx#38287)
Santiago Fernandez Madero [Thu, 6 Jun 2019 04:11:32 +0000 (21:11 -0700)]
Re-generate System.Memory ref assembly against implementation (dotnet/corefx#38287)

Commit migrated from https://github.com/dotnet/corefx/commit/7b87ec99d747478ddcb1eba048411be24e9b9b87

5 years agoRe-generate System.Runtime.Loader ref assembly against implementation (dotnet/corefx...
Santiago Fernandez Madero [Thu, 6 Jun 2019 04:11:11 +0000 (21:11 -0700)]
Re-generate System.Runtime.Loader ref assembly against implementation (dotnet/corefx#38286)

Commit migrated from https://github.com/dotnet/corefx/commit/9f3032395582f2abd33cee8fa8bba25f7576774b

5 years agoUpdate JsonSerializer and JsonElement APIs - drop "As" and parameter re-ordering...
Ahson Khan [Wed, 5 Jun 2019 21:49:59 +0000 (14:49 -0700)]
Update JsonSerializer and JsonElement APIs - drop "As" and parameter re-ordering (dotnet/corefx#38270)

* Update JsonSerializer and JsonElement APIs

* Fix the test since the call became ambiguous and overload resolution
picked the different overload.

Commit migrated from https://github.com/dotnet/corefx/commit/5c2ba765f55462dcc5e00179a34398fc70bf37b7

5 years agoAdd missing APIs for OleDb (dotnet/corefx#38235)
Maryam Ariyan [Wed, 5 Jun 2019 20:27:50 +0000 (13:27 -0700)]
Add missing APIs for OleDb (dotnet/corefx#38235)

Commit migrated from https://github.com/dotnet/corefx/commit/c63e5ebecc5449a360b6293ecdbf151bfd11a1a6

5 years agoFix digest authentication on SocketsHttpHandler (dotnet/corefx#38225)
Marco Rossignoli [Wed, 5 Jun 2019 18:33:31 +0000 (20:33 +0200)]
Fix digest authentication on SocketsHttpHandler (dotnet/corefx#38225)

* fix digest

* improve test

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/94c5f1384c9b6477d164050de964cf6dcf99b2a9

5 years agoMoving the JsonSerializer to the root namespace - System.Text.Json (dotnet/corefx...
Ahson Khan [Wed, 5 Jun 2019 18:18:50 +0000 (11:18 -0700)]
Moving the JsonSerializer to the root namespace - System.Text.Json (dotnet/corefx#38120)

* CHanging namespace for json serializer

* Update ref and namespace to react to recent changes.

* Auto-gen the ref.

* Remove unnecessary using directive that got added recently.

Commit migrated from https://github.com/dotnet/corefx/commit/7e0c5dd1927981131c370141c4ef44c0ebd26c05

5 years agoRe-generate reference source against impl for System.Threading.Tasks (dotnet/corefx...
Santiago Fernandez Madero [Wed, 5 Jun 2019 16:28:23 +0000 (09:28 -0700)]
Re-generate reference source against impl for System.Threading.Tasks (dotnet/corefx#38231)

Commit migrated from https://github.com/dotnet/corefx/commit/cb603ed5ec0249da022a96f9ec583f24c5a50fae

5 years agoEnable code path in TypeDescriptor.GetAssociation(...) to use IDesignerHost (dotnet...
Dustin Campbell [Wed, 5 Jun 2019 14:58:02 +0000 (07:58 -0700)]
Enable code path in TypeDescriptor.GetAssociation(...) to use IDesignerHost (dotnet/corefx#38244)

* Enable code path in TypeDescriptor.GetAssociation(...) to use IDesignerHost

Fixes dotnet/corefx#38241

TypeDescriptor.GetAssociation(...) is supposed to have a fallback in the case
that the primary object passed to it is a sited IComponent in design-mode. In
that case, it tries to acquire an IDesignerHost from the component site and
calls IDesignerHost.GetDesigner(...). Unfortunately, this code path has been
disabled since TypeDescriptor was introduced in the corefx code base 3 years
ago.

This change enables that code path and adds a test for the scenario.

This is currently blocking WinForms Designer work.

* Code review feedback for TypeConverterTests.cs

Commit migrated from https://github.com/dotnet/corefx/commit/d6a3b78f3fa2b636621f6030fc3f8b99e08474bb

5 years agoReenable BuildInvalidSignatureTwice with better diagnostics
Jeremy Barton [Wed, 5 Jun 2019 14:48:22 +0000 (07:48 -0700)]
Reenable BuildInvalidSignatureTwice with better diagnostics

Commit migrated from https://github.com/dotnet/corefx/commit/09c3160b52e1e47b3a92c837337672d1b426e170

5 years agoIncrease sample size for random tests.
Kevin Jones [Wed, 5 Jun 2019 14:41:29 +0000 (10:41 -0400)]
Increase sample size for random tests.

Commit migrated from https://github.com/dotnet/corefx/commit/3d007d3084713f7b9644545e7b7450c69c3ee4a1

5 years agoAdd Debian 10 "Buster" test execution
Matt Galbraith [Wed, 5 Jun 2019 14:40:07 +0000 (07:40 -0700)]
Add Debian 10 "Buster" test execution

Add test leg to full matrix using debian-10-helix-amd64-f55606d-20190521154431

Commit migrated from https://github.com/dotnet/corefx/commit/c8a3f3241265f1b287f3acd81ddabf2c5dfb9a53

5 years agoOpen pdb files with FileShare.Read and FileShare.Delete (dotnet/corefx#38214)
David Fowler [Wed, 5 Jun 2019 13:44:29 +0000 (06:44 -0700)]
Open pdb files with FileShare.Read and FileShare.Delete (dotnet/corefx#38214)

* Added test to verify PDB isn't locked

Commit migrated from https://github.com/dotnet/corefx/commit/a1940826e89c4c333bca45459b25ba009e869ff6

5 years agoFix XmlSerializer fails to serialize Type with special character in string
Carol Wang [Wed, 5 Jun 2019 13:16:54 +0000 (21:16 +0800)]
Fix XmlSerializer fails to serialize Type with special character in string

Commit migrated from https://github.com/dotnet/corefx/commit/1b081bbfb8cfb7b4d9e56928e44bf5393d5a1f67

5 years agoIgnore indexer properties (dotnet/corefx#38133)
Marco Rossignoli [Wed, 5 Jun 2019 09:28:59 +0000 (11:28 +0200)]
Ignore indexer properties (dotnet/corefx#38133)

* fix indexer

* address PR feedback

* address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/656ccfbbef3a0d75c02e17b7477122a658b92557

5 years agoMove System.Threading.Channels into Microsoft.NetCore.App (dotnet/corefx#38207)
David Fowler [Wed, 5 Jun 2019 00:11:53 +0000 (17:11 -0700)]
Move System.Threading.Channels into Microsoft.NetCore.App (dotnet/corefx#38207)

* Move System.Threading.Channels into Microsoft.NetCore.App

* Update packageIndex to make Channels inbox

Commit migrated from https://github.com/dotnet/corefx/commit/10fc6eee0683524006ce5c8260059865e00fefac

5 years agoMerge pull request dotnet/corefx#35363 from Wraith2/sqlperf-managedsmux
Gary Zhang [Tue, 4 Jun 2019 22:26:18 +0000 (15:26 -0700)]
Merge pull request dotnet/corefx#35363 from Wraith2/sqlperf-managedsmux

SqlClient managed networking improvements, all test passed

Commit migrated from https://github.com/dotnet/corefx/commit/2469a91c2aa68f9cb6b0f18f75dffc673a1f7895

5 years agoAdd missing PlatformSpecific attribute to ProcessStart_OnLinux_UsesSpecifiedProgram...
Stephen Toub [Tue, 4 Jun 2019 22:15:59 +0000 (18:15 -0400)]
Add missing PlatformSpecific attribute to ProcessStart_OnLinux_UsesSpecifiedProgram test (dotnet/corefx#38228)

Commit migrated from https://github.com/dotnet/corefx/commit/88c5a3e317dd2edadc95adedc764c1acad5e3541

5 years agoUpdate ProjectNTfs to beta-27804-00 (dotnet/corefx#38220)
dotnet-maestro-bot [Tue, 4 Jun 2019 21:12:40 +0000 (14:12 -0700)]
Update ProjectNTfs to beta-27804-00 (dotnet/corefx#38220)

Commit migrated from https://github.com/dotnet/corefx/commit/d5a4975994a1b825b4c40a9fdcbd8a367f198177

5 years agoDisable JSON LookupOverflow test (dotnet/corefx#38222)
Stephen Toub [Tue, 4 Jun 2019 20:54:02 +0000 (16:54 -0400)]
Disable JSON LookupOverflow test (dotnet/corefx#38222)

Commit migrated from https://github.com/dotnet/corefx/commit/f7ace29a0089e2089a4309fe1bda1344a34cbea2

5 years agoHttpClient.SendAsync() should not attempt to read response body on a HEAD or PUT...
Martin Baulig [Tue, 4 Jun 2019 20:52:27 +0000 (16:52 -0400)]
HttpClient.SendAsync() should not attempt to read response body on a HEAD or PUT request. (dotnet/corefx#38129)

* HttpClient.SendAsync() should not attempt to read response body on a HEAD or PUT request.

* Update HttpMethod.cs

* Address feedback.

* Cleanup.

* Update HttpRequestMessageTest.cs

Commit migrated from https://github.com/dotnet/corefx/commit/73e610f847f9c5100a0cec4a80692969836ff35d

5 years agoFix catch block for cancellation in ConnectHelper.ConnectAsync (dotnet/corefx#38211)
Stephen Toub [Tue, 4 Jun 2019 20:03:25 +0000 (16:03 -0400)]
Fix catch block for cancellation in ConnectHelper.ConnectAsync (dotnet/corefx#38211)

There are logic errors in ConnectHelper's catch blocks regarding cancellation.  It's catching all exceptions and then trying to decide whether it should wrap the exception in an OperationCanceledException (based on whether cancellation was requested), but it's ignoring the possibility that the exception already is an OperationCanceledException.

Commit migrated from https://github.com/dotnet/corefx/commit/80252bbc5cf2f933aef1f30d6bec7deaa3064f54

5 years agoLoopbackProxyServer cleanup (dotnet/corefx#38038)
Cory Nelson [Tue, 4 Jun 2019 18:04:49 +0000 (11:04 -0700)]
LoopbackProxyServer cleanup (dotnet/corefx#38038)

* Resolves dotnet/corefx#32808.

Ensure all connections are finished prior to Dispose() returning.
Shutdown CONNECT sessions properly.
Dispose sockets rather than relying on finalizers.
Eat fewer errors automatically.
Send errors to an event source to assist with troubleshooting.

Commit migrated from https://github.com/dotnet/corefx/commit/055dd469f7d402f496fcab31ae91e80efd474fa9

5 years agoProcessStart_OpenFileOnLinux_UsesSpecifiedProgram: avoid early exit issues by using...
Tom Deseyn [Tue, 4 Jun 2019 16:25:45 +0000 (18:25 +0200)]
ProcessStart_OpenFileOnLinux_UsesSpecifiedProgram: avoid early exit issues by using 'sleep' instead of 'vi' (dotnet/corefx#38158)

* ProcessStart_OpenFileOnLinux_UsesSpecifiedProgram: avoid early exit issues by using 'sleep' instead of 'vi'

Fixes https://github.com/dotnet/corefx/issues/38114

* PR feedback

* Match sleep time with RemoteExecutor.FailWaitTimeoutMilliseconds

* Move Assert out of finally block to keep exception

Commit migrated from https://github.com/dotnet/corefx/commit/6efdb0fc21c5eb559657a85a62a14d0907f6eff4

5 years agoDisable TurkishI_Is_Differently_LowerUpperCased_In_Turkish_Culture on uap (dotnet...
Stephen Toub [Tue, 4 Jun 2019 16:24:44 +0000 (12:24 -0400)]
Disable TurkishI_Is_Differently_LowerUpperCased_In_Turkish_Culture on uap (dotnet/corefx#38209)

Commit migrated from https://github.com/dotnet/corefx/commit/3e360f03d0ef21873276a3488046de97687bfce0

5 years agoBetter handle resx scenarios (dotnet/corefx#38012)
Eric StJohn [Tue, 4 Jun 2019 15:38:33 +0000 (08:38 -0700)]
Better handle resx scenarios (dotnet/corefx#38012)

* Better handle resx scenarios

There were two resx scenarios that we weren't handling well.

1. BinaryFormatted data that is missing the type information

BinaryFormatted data never takes the type into account, it's only used
to check the deserialized data after it's read.  In the old resx reader
it would deserialize the data in the build task, only to reserialize it
back, recording the type information.  Since we're eliminating build
time deserialziation we cannot do this, so just permit the payload to
flow through without recording the type information.  This is
effectively what happened before since the user never recorded the
type information in the resx so it isn't introducing any new opportunity
for inconsistencies.  To implement this I used the existing ResX format
with a sentinel type to indicate that the BinaryFormatter payload type
was unknown.

2. Primitive types stored as string

ResX reader deserialized all types during the build, we're trying to
eliminate this as it results in build time / cross-framework type
loading.  In doing so we lose the ability to handle primitive types
since the only way we currently write primitive types is when they
are passed in as live objects.  To fix this, we'll make the string-based
type converter method aware of primitive types, and permit it to
deserialize those primitive types (IOW: parse the string via
typeconverter) so that we still write these as primitive resources.
We'll rename this method to AddResource to indicate it is more
generic than just handling pre-serialized data.  To identify primitive types
we use a string comparer to match the type name written in the resx,
and map it to a known type (in the build framework).

* Respond to feedback

* Apply suggestions from code review

Co-Authored-By: Rainer Sigwald <raines@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/00c7405a3b079e1641d32c50831d3f5053d9419e

5 years agoRe-generate System.Threading ref assembly against implementation (dotnet/corefx#38190)
Santiago Fernandez Madero [Tue, 4 Jun 2019 04:42:10 +0000 (21:42 -0700)]
Re-generate System.Threading ref assembly against implementation (dotnet/corefx#38190)

Commit migrated from https://github.com/dotnet/corefx/commit/6d5959cbc7d489406f8f85dba0a42f06d4a0ea9b

5 years agoProcessNameMatchesScriptName: add some asserts for debugging (dotnet/corefx#38175)
Tom Deseyn [Tue, 4 Jun 2019 03:25:08 +0000 (05:25 +0200)]
ProcessNameMatchesScriptName: add some asserts for debugging (dotnet/corefx#38175)

Commit migrated from https://github.com/dotnet/corefx/commit/b6c814e0d0da3b3251b518f2d9445174e4fc1979

5 years agoFix deletion tests on Windows 10 1903. (dotnet/corefx#38186)
Jeremy Kuhne [Tue, 4 Jun 2019 03:17:15 +0000 (20:17 -0700)]
Fix deletion tests on Windows 10 1903. (dotnet/corefx#38186)

In the 1903 release of Windows 10 the deletion behavior has changed. Previously, the filename would be reserved until all open handles were closed after being marked for deletion. Now the filename is immediately released.

Commit migrated from https://github.com/dotnet/corefx/commit/a4cf9a480b34a00e11201e932f7152c63b99b85f

5 years agoPersist InterfaceTypeAttribute in ref assemblies (dotnet/corefx#38182)
Eric StJohn [Tue, 4 Jun 2019 01:53:57 +0000 (18:53 -0700)]
Persist InterfaceTypeAttribute in ref assemblies (dotnet/corefx#38182)

Commit migrated from https://github.com/dotnet/corefx/commit/37b09ac0fc37c77bb9e1ff2320bf3149411f1c55

5 years agoAdds JsonElement.ValueEquals / JsonProperty.NameEquals APIs, (dotnet/corefx#37911)
Maryam Ariyan [Tue, 4 Jun 2019 00:21:10 +0000 (17:21 -0700)]
Adds JsonElement.ValueEquals / JsonProperty.NameEquals APIs, (dotnet/corefx#37911)

* - Rename Utf8JsonReader.TextEquals to Utf8JsonReader.ValueTextEquals
- Implement JsonElement.ValueEquals and add code coverage
- Reuse logic for JsonProperty and add code coverage
- improve header documentation
- cleanup tests

Commit migrated from https://github.com/dotnet/corefx/commit/f09135a373caa94eca1566f7ad497aaf19587140

5 years agoFix RegexCultureTests by moving it out-of-proc (dotnet/corefx#38166)
Stephen Toub [Mon, 3 Jun 2019 18:34:34 +0000 (14:34 -0400)]
Fix RegexCultureTests by moving it out-of-proc (dotnet/corefx#38166)

All of our tests that manipulate current culture currently need to be run out-of-proc.

Commit migrated from https://github.com/dotnet/corefx/commit/55950a7c733de83f2efbafd3b5cad23e3ea6873a

5 years agofix tests (dotnet/corefx#38096)
Marco Rossignoli [Mon, 3 Jun 2019 15:25:09 +0000 (17:25 +0200)]
fix tests (dotnet/corefx#38096)

Commit migrated from https://github.com/dotnet/corefx/commit/c84b3861a3ff8f0843b1da64ae88fb712f4af57d

5 years agoUse fallbacks when link() fails (dotnet/corefx#36957)
Alexis Christoforides [Mon, 3 Jun 2019 15:05:00 +0000 (08:05 -0700)]
Use fallbacks when link() fails (dotnet/corefx#36957)

System.IO.Filesystem's MoveFile() and ReplaceFile() use the link() syscall under some conditions to avoid a copy. This fixes two problems with that:

* MoveFile()'s fall-back does not recognize a possible Android error as non-critical, and bails out on the fall-back with an exception. From logs we know that 'strerror_r(android_error)' = 'Permission denied' so the Android error should be EACCES (we already check for EPERM)
* While MoveFile() was using a fall-back, ReplaceFile() wasn't.

Commit migrated from https://github.com/dotnet/corefx/commit/f6aed7b177580ed3953e6e23dccbe2de57850729

5 years agoX509Store_MachineStoreLoadSkipsInvalidFiles: skip test when running as root (dotnet...
Tom Deseyn [Mon, 3 Jun 2019 14:09:49 +0000 (16:09 +0200)]
X509Store_MachineStoreLoadSkipsInvalidFiles: skip test when running as root (dotnet/corefx#38162)

* X509Store_MachineStoreLoadSkipsInvalidFiles: skip test when running as root

Fixes https://github.com/dotnet/corefx/issues/30162

* PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/de1748bb797ee079c5592ed035b18fded0a96e27

5 years agoUpdate ProjectNTfs to beta-27803-00 (dotnet/corefx#38155)
dotnet-maestro-bot [Mon, 3 Jun 2019 08:05:21 +0000 (01:05 -0700)]
Update ProjectNTfs to beta-27803-00 (dotnet/corefx#38155)

Commit migrated from https://github.com/dotnet/corefx/commit/0eed4042f056b4d9f6f4d1bf2918e234d67a6f88

5 years agoaddress PR feedback (dotnet/corefx#38147)
Marco Rossignoli [Mon, 3 Jun 2019 00:26:42 +0000 (02:26 +0200)]
address PR feedback (dotnet/corefx#38147)

Commit migrated from https://github.com/dotnet/corefx/commit/a42e890c3af1069a52b75b5728444bf29c421703

5 years agoFix tests to match exception output change (dotnet/corefx#38145)
Dan Moseley [Mon, 3 Jun 2019 00:25:38 +0000 (17:25 -0700)]
Fix tests to match exception output change (dotnet/corefx#38145)

Commit migrated from https://github.com/dotnet/corefx/commit/360621af9620de205193f627ae84c41ddec60551

5 years ago[master] Update dependencies from dotnet/arcade (dotnet/corefx#38134)
dotnet-maestro[bot] [Sun, 2 Jun 2019 18:21:11 +0000 (18:21 +0000)]
[master] Update dependencies from dotnet/arcade (dotnet/corefx#38134)

* Update dependencies from https://github.com/dotnet/arcade build 20190531.5

- Microsoft.DotNet.XUnitExtensions - 2.4.1-beta.19281.5
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19281.5
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19281.5
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19281.5
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19281.5
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19281.5
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19281.5
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19281.5
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19281.5
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19281.5
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19281.5
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19281.5
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19281.5
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19281.5

* Update dependencies from https://github.com/dotnet/arcade build 20190601.2

- Microsoft.DotNet.XUnitExtensions - 2.4.1-beta.19301.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19301.2
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19301.2
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19301.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19301.2
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19301.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19301.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19301.2
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19301.2
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19301.2
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19301.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19301.2
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19301.2
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19301.2

* Remove dotnet-root option

Commit migrated from https://github.com/dotnet/corefx/commit/aa0c037c1f64c91f73698d0607dea16904d08da8

5 years agoUse LoopbackServer for HttpWebRequestTests (dotnet/corefx#37451)
Viktor Hofer [Sun, 2 Jun 2019 16:13:13 +0000 (18:13 +0200)]
Use LoopbackServer for HttpWebRequestTests (dotnet/corefx#37451)

* Use LoopbackServer for HttpWebRequestTests

Commit migrated from https://github.com/dotnet/corefx/commit/d57a1a29f1237f2691daa8eac29eb4581a4eaf88

5 years agoFix CustomValidationAttribute.TypeId (dotnet/corefx#38140)
Marco Rossignoli [Sun, 2 Jun 2019 04:20:35 +0000 (06:20 +0200)]
Fix CustomValidationAttribute.TypeId (dotnet/corefx#38140)

* fix TypeId

* nit

Commit migrated from https://github.com/dotnet/corefx/commit/9813f2de83c5f4b270b7cbb34f7117f80d402f4d

5 years agoChange use of AllowRenegotiation in HttpConnectionPool (dotnet/corefx#38127)
Stephen Toub [Sat, 1 Jun 2019 19:27:50 +0000 (15:27 -0400)]
Change use of AllowRenegotiation in HttpConnectionPool (dotnet/corefx#38127)

* Change use of AllowRenegotation in HttpConnectionPool

* Address PR feedback

Fix typos in comments

Co-Authored-By: David Shulman <david.shulman@microsoft.com>
Commit migrated from https://github.com/dotnet/corefx/commit/cada442a1385e4ecaf9139eb9f98e522776043e2

5 years agoFix downlevel build-break in System.Net.WebSockets.WebSocketProtocol (dotnet/corefx...
Stephen Toub [Sat, 1 Jun 2019 13:44:24 +0000 (09:44 -0400)]
Fix downlevel build-break in System.Net.WebSockets.WebSocketProtocol (dotnet/corefx#38138)

Commit migrated from https://github.com/dotnet/corefx/commit/dfd3eb6b0c4786b8b4a70a1ea6c6bed8bfb919a0

5 years agoTest for Exception.ToString() calling derived implementation (dotnet/corefx#37960)
Dan Moseley [Fri, 31 May 2019 23:38:29 +0000 (16:38 -0700)]
Test for Exception.ToString() calling derived implementation (dotnet/corefx#37960)

* Test for Exception.ToString()

* Ensure Message is not present

Commit migrated from https://github.com/dotnet/corefx/commit/0d2ee6c1db6038adb776565af81ff944423a6fb3

5 years agoEnsure aligned access in ManagedWebSocket.ApplyMask (dotnet/corefx#37999)
Cory Nelson [Fri, 31 May 2019 23:25:33 +0000 (16:25 -0700)]
Ensure aligned access in ManagedWebSocket.ApplyMask (dotnet/corefx#37999)

* Resolves dotnet/corefx#30747 ensuring pointer alignment.

* Make mods unsigned so optimizer will translate them to AND. Use BitOperations.RotateRight rather than custom implementation.

* Reduce code size; improve perf on unaligned data.

* Fix length check.

* Address review suggestions:

Use MemoryMarshal.GetReference rather than pinning the span directly.
Add Debug.Assert() to improve maintainability.
Prefer a larger indent mountain over goto.

Commit migrated from https://github.com/dotnet/corefx/commit/9ec6bfa8c5045fb2c0affe8870ea238ca5f57f37