platform/upstream/libSkiaSharp.git
11 years agogm self-test: use a pathologically simple test case instead of dashing2
commit-bot@chromium.org [Fri, 1 Mar 2013 15:32:34 +0000 (15:32 +0000)]
gm self-test: use a pathologically simple test case instead of dashing2

BUG=https://code.google.com/p/skia/issues/detail?id=677

Review URL: https://chromiumcodereview.appspot.com/12381038

git-svn-id: http://skia.googlecode.com/svn/trunk@7922 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r7914 due to Linux rendering issues
robertphillips@google.com [Fri, 1 Mar 2013 15:18:41 +0000 (15:18 +0000)]
Revert r7914 due to Linux rendering issues

git-svn-id: http://skia.googlecode.com/svn/trunk@7921 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix mesa build error from r7519.
bsalomon@google.com [Fri, 1 Mar 2013 14:56:40 +0000 (14:56 +0000)]
Fix mesa build error from r7519.

git-svn-id: http://skia.googlecode.com/svn/trunk@7920 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support to GrGLInterface for vertex array objects
bsalomon@google.com [Fri, 1 Mar 2013 14:37:18 +0000 (14:37 +0000)]
Add support to GrGLInterface for vertex array objects
Review URL: https://codereview.chromium.org/12379025

git-svn-id: http://skia.googlecode.com/svn/trunk@7919 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for Mac compiler problem in 7916
robertphillips@google.com [Fri, 1 Mar 2013 14:24:33 +0000 (14:24 +0000)]
Fix for Mac compiler problem in 7916

unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@7918 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for skp chunk sizes when clips are used outside of any save
robertphillips@google.com [Fri, 1 Mar 2013 14:17:58 +0000 (14:17 +0000)]
Fix for skp chunk sizes when clips are used outside of any save

https://codereview.appspot.com/7342047/

git-svn-id: http://skia.googlecode.com/svn/trunk@7917 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCollapse saveLayer/drawBitmapRect/restore trios to drawBitmapRect when possible
robertphillips@google.com [Fri, 1 Mar 2013 14:12:59 +0000 (14:12 +0000)]
Collapse saveLayer/drawBitmapRect/restore trios to drawBitmapRect when possible

https://codereview.appspot.com/7387045/

git-svn-id: http://skia.googlecode.com/svn/trunk@7916 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace A8 with RGBA8 when renderable A8 isn't supported
robertphillips@google.com [Fri, 1 Mar 2013 14:10:57 +0000 (14:10 +0000)]
Replace A8 with RGBA8 when renderable A8 isn't supported

https://codereview.appspot.com/7372053/

git-svn-id: http://skia.googlecode.com/svn/trunk@7914 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 1 Mar 2013 12:12:55 +0000 (12:12 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7910 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r7901 & r7899 to allow DEPS roll
robertphillips@google.com [Thu, 28 Feb 2013 23:08:28 +0000 (23:08 +0000)]
Revert r7901 & r7899 to allow DEPS roll

git-svn-id: http://skia.googlecode.com/svn/trunk@7909 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCheckpoint towards core profile support.
bsalomon@google.com [Thu, 28 Feb 2013 22:06:02 +0000 (22:06 +0000)]
Checkpoint towards core profile support.

1) Stop calling glDisable for removed state

2) Use new GLSL names for texture sampling functions.
Review URL: https://codereview.chromium.org/12330181

git-svn-id: http://skia.googlecode.com/svn/trunk@7908 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSplit GrGLContextInfo into GrGLContext & GrGLContextInfo
robertphillips@google.com [Thu, 28 Feb 2013 20:16:25 +0000 (20:16 +0000)]
Split GrGLContextInfo into GrGLContext & GrGLContextInfo

https://codereview.appspot.com/7436045/

git-svn-id: http://skia.googlecode.com/svn/trunk@7905 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove the default definition of GR_USE_NEW_SHADER_SOURCE_SIGNATURE to GrGLConfig.
bsalomon@google.com [Thu, 28 Feb 2013 19:26:04 +0000 (19:26 +0000)]
Move the default definition of GR_USE_NEW_SHADER_SOURCE_SIGNATURE to GrGLConfig.

R=senorblanco@google.com
Review URL: https://codereview.chromium.org/12390021

git-svn-id: http://skia.googlecode.com/svn/trunk@7904 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding missing const for r7902
jvanverth@google.com [Thu, 28 Feb 2013 19:18:07 +0000 (19:18 +0000)]
Adding missing const for r7902

git-svn-id: http://skia.googlecode.com/svn/trunk@7903 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake SkTDArray accessors const-friendly.
commit-bot@chromium.org [Thu, 28 Feb 2013 19:03:13 +0000 (19:03 +0000)]
Make SkTDArray accessors const-friendly.

This change creates const and non-const versions of SkTDArray::begin(), end(), operator[]() and getAt(). This will keep us from inadvertently changing a const SkTDArray, which the previous signatures allowed.

Review URL: https://chromiumcodereview.appspot.com/12315131

git-svn-id: http://skia.googlecode.com/svn/trunk@7902 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix assert in bench due to r7899. Unreviewed.
jvanverth@google.com [Thu, 28 Feb 2013 17:15:03 +0000 (17:15 +0000)]
Fix assert in bench due to r7899. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7901 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse updated Khronos signature for glShaderSource
commit-bot@chromium.org [Thu, 28 Feb 2013 17:11:11 +0000 (17:11 +0000)]
Use updated Khronos signature for glShaderSource
(const char* const instead of char**).

This is needed for new Khronos headers.

BUG=178589

Review URL: https://chromiumcodereview.appspot.com/12310156

git-svn-id: http://skia.googlecode.com/svn/trunk@7900 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd new vertex attribute array specification.
jvanverth@google.com [Thu, 28 Feb 2013 16:28:34 +0000 (16:28 +0000)]
Add new vertex attribute array specification.

This changes the old method of setting vertex layout to a new one where we
specify vertex attribute data separately from attribute bindings (i.e. program
functionality). Attribute data is now set up via an array of generic attribute
types and offsets, and this is mapped to the old program functionality by
setting specific attribute indices. This allows us to create more general
inputs to shaders.

git-svn-id: http://skia.googlecode.com/svn/trunk@7899 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Thu, 28 Feb 2013 16:12:39 +0000 (16:12 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7898 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOnly print error message in debug mode.
scroggo@google.com [Thu, 28 Feb 2013 15:50:13 +0000 (15:50 +0000)]
Only print error message in debug mode.

Currently, PictureTest runs a test of recording a bad bitmap to a
picture and then replaying the picture. We assert at the record
step in debug mode, so the test only runs in release, to ensure that
we can still play back a picture, even if it has a bad bitmap. Silence
the error message in release, so our test doesn't appear to error
(since it is actually working as desired).

Review URL: https://codereview.chromium.org/12315138

git-svn-id: http://skia.googlecode.com/svn/trunk@7897 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert r7892
edisonn@google.com [Thu, 28 Feb 2013 14:01:44 +0000 (14:01 +0000)]
revert r7892

git-svn-id: http://skia.googlecode.com/svn/trunk@7896 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change: Reset skia-autogen
borenet@google.com [Thu, 28 Feb 2013 12:33:47 +0000 (12:33 +0000)]
Whitespace change: Reset skia-autogen

git-svn-id: http://skia.googlecode.com/svn/trunk@7895 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r7882 (Replace A8 with RGBA8 when renderable A8 isn't supported) due Androi...
robertphillips@google.com [Wed, 27 Feb 2013 20:27:44 +0000 (20:27 +0000)]
Reverting r7882 (Replace A8 with RGBA8 when renderable A8 isn't supported) due Android rendering issues

git-svn-id: http://skia.googlecode.com/svn/trunk@7893 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoresubmit after fixing assert issue: https://codereview.appspot.com/6744050
edisonn@google.com [Wed, 27 Feb 2013 19:45:11 +0000 (19:45 +0000)]
resubmit after fixing assert issue: https://codereview.appspot.com/6744050

git-svn-id: http://skia.googlecode.com/svn/trunk@7892 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTests : Unused parameters cleanup
sugoi@google.com [Wed, 27 Feb 2013 19:17:41 +0000 (19:17 +0000)]
Tests : Unused parameters cleanup

I removed unused parameters in the tests wherever it was trivial to do so. I'm trying to get the easy ones out of the way before we get into more involved discussions around this.
Review URL: https://codereview.appspot.com/7394055

git-svn-id: http://skia.googlecode.com/svn/trunk@7891 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert fontconfig gyp change for now (need to install it on housekeeper and chromeos...
reed@google.com [Wed, 27 Feb 2013 19:17:07 +0000 (19:17 +0000)]
revert fontconfig gyp change for now (need to install it on housekeeper and chromeos bots)

git-svn-id: http://skia.googlecode.com/svn/trunk@7890 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSort GL extension strings and search to find.
bsalomon@google.com [Wed, 27 Feb 2013 19:07:32 +0000 (19:07 +0000)]
Sort GL extension strings and search to find.
Review URL: https://codereview.chromium.org/12316141

git-svn-id: http://skia.googlecode.com/svn/trunk@7889 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoenable fontconfig by default in ports.gyp
reed@google.com [Wed, 27 Feb 2013 19:06:52 +0000 (19:06 +0000)]
enable fontconfig by default in ports.gyp

git-svn-id: http://skia.googlecode.com/svn/trunk@7888 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse fontconfig fonthost for skia (in prep for using in chrome)
reed@google.com [Wed, 27 Feb 2013 19:06:30 +0000 (19:06 +0000)]
use fontconfig fonthost for skia (in prep for using in chrome)
Review URL: https://codereview.chromium.org/12319150

git-svn-id: http://skia.googlecode.com/svn/trunk@7887 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAssign color=0 in GrDrawState.cpp to stop tools from raising false alarms about unini...
bsalomon@google.com [Wed, 27 Feb 2013 18:43:47 +0000 (18:43 +0000)]
Assign color=0 in GrDrawState.cpp to stop tools from raising false alarms about uninit reads.

We were assigning color to oldColor but it in turn would never be read because the valid flags
would be cleared.

R=jvanverth@google.com
Review URL: https://codereview.chromium.org/12313150

git-svn-id: http://skia.googlecode.com/svn/trunk@7886 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange SkTileGride geometry calculations to match the Chromium compositor.
junov@chromium.org [Wed, 27 Feb 2013 18:35:16 +0000 (18:35 +0000)]
Change SkTileGride geometry calculations to match the Chromium compositor.

This patch changes the semantics of tileWidth/Height to include the border region, and
uses an offset to take into account the fact that there is no outer border for outer
tiles. This patch also fixes a previous bug where the right column and bottom row were
considered to be included in bounds that are expressed as an SkIRect.

Companion Chromium CL required for roll: https://codereview.chromium.org/12221077/

TEST=TileGrid unit test
Review URL: https://codereview.appspot.com/7350050

git-svn-id: http://skia.googlecode.com/svn/trunk@7885 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r7883
edisonn@google.com [Wed, 27 Feb 2013 17:46:09 +0000 (17:46 +0000)]
Revert r7883

git-svn-id: http://skia.googlecode.com/svn/trunk@7884 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse SkSet to fix issue when pdf generates an exp number of resources.
edisonn@google.com [Wed, 27 Feb 2013 16:54:44 +0000 (16:54 +0000)]
Use SkSet to fix issue when pdf generates an exp number of resources.

The problem fixed - http://code.google.com/p/skia/issues/detail?id=940 - is that getResources will recursively obtain all child resource recursively without checking for duplicates.

If we have lots of duplicates, then we try to build a very large vector (exponential with the number of nodes usually) and sooner or later we end up using too much memory and crash.

A possible solution could have been to make sure resources do not have duplicates, but that requirement is impractical, and it this leaves the solution fragile, if there is any issue in the tree,  we crash.

When we emit the pdf, the large number of duplicates is not an issue, because SkPDFCatalog::addObject will deal with duplicates.

I have run the gm with --config pdf, and the images are 100% same bits, while the pdfs have the same size but some very small changes, the order of some objects.
Review URL: https://codereview.appspot.com/6744050

git-svn-id: http://skia.googlecode.com/svn/trunk@7883 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace A8 with RGBA8 when renderable A8 isn't supported
robertphillips@google.com [Wed, 27 Feb 2013 16:43:49 +0000 (16:43 +0000)]
Replace A8 with RGBA8 when renderable A8 isn't supported

https://codereview.appspot.com/7372053/

git-svn-id: http://skia.googlecode.com/svn/trunk@7882 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM : Unused parameters cleanup
sugoi@google.com [Wed, 27 Feb 2013 15:41:12 +0000 (15:41 +0000)]
GM : Unused parameters cleanup

I removed unused parameters in the gms wherever it was trivial to do so. I'm
trying to get the easy ones out of the way before we get into more involved
discussions around this.
Review URL: https://codereview.appspot.com/7398056

git-svn-id: http://skia.googlecode.com/svn/trunk@7881 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild freetype as a standalone_static_library
borenet@google.com [Wed, 27 Feb 2013 14:12:55 +0000 (14:12 +0000)]
Build freetype as a standalone_static_library

Needed by external applications which don't use our libraries in-place.
Review URL: https://codereview.chromium.org/12328138

git-svn-id: http://skia.googlecode.com/svn/trunk@7879 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change (SkipBuildbotRuns)
rmistry@google.com [Wed, 27 Feb 2013 13:24:35 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@7878 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change (SkipBuildbotRuns)
rmistry@google.com [Wed, 27 Feb 2013 13:24:22 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@7877 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change (SkipBuildbotRuns)
rmistry@google.com [Wed, 27 Feb 2013 13:24:12 +0000 (13:24 +0000)]
Whitespace change (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@7876 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 27 Feb 2013 07:10:10 +0000 (07:10 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7875 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix getFamilyName by calling FcFreeTypeQuery
reed@google.com [Tue, 26 Feb 2013 22:58:09 +0000 (22:58 +0000)]
fix getFamilyName by calling FcFreeTypeQuery

git-svn-id: http://skia.googlecode.com/svn/trunk@7874 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixed sk_getMetrics_utf32_xy function
sugoi@google.com [Tue, 26 Feb 2013 21:56:19 +0000 (21:56 +0000)]
Fixed sk_getMetrics_utf32_xy function

The unused parameters x and y here seems to be a mistake.
Review URL: https://codereview.appspot.com/7386055

git-svn-id: http://skia.googlecode.com/svn/trunk@7873 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse glGetStringi to get extensions when available.
bsalomon@google.com [Tue, 26 Feb 2013 21:46:32 +0000 (21:46 +0000)]
Use glGetStringi to get extensions when available.
Review URL: https://codereview.chromium.org/12328111

git-svn-id: http://skia.googlecode.com/svn/trunk@7872 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoimplement CreateTypefaceFromFile
reed@google.com [Tue, 26 Feb 2013 17:11:07 +0000 (17:11 +0000)]
implement CreateTypefaceFromFile

git-svn-id: http://skia.googlecode.com/svn/trunk@7869 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogit-svn-id: http://skia.googlecode.com/svn/trunk@7868 2bbb7eff-a529-9590-31e7-b0007b4...
reed@google.com [Tue, 26 Feb 2013 17:01:26 +0000 (17:01 +0000)]
git-svn-id: skia.googlecode.com/svn/trunk@7868 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove SampleTypeface into gm/typefacestyles
reed@google.com [Tue, 26 Feb 2013 16:57:16 +0000 (16:57 +0000)]
move SampleTypeface into gm/typefacestyles

git-svn-id: http://skia.googlecode.com/svn/trunk@7867 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test commit-queue
commit-bot@chromium.org [Tue, 26 Feb 2013 16:25:04 +0000 (16:25 +0000)]
Whitespace change to test commit-queue

(SkipBuildbotRuns)

Review URL: https://chromiumcodereview.appspot.com/12328109

git-svn-id: http://skia.googlecode.com/svn/trunk@7866 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemoving blank lines from codereview.settings.
rmistry@google.com [Tue, 26 Feb 2013 16:01:21 +0000 (16:01 +0000)]
Removing blank lines from codereview.settings.

depot_tools/checkout.py does not like blank lines:
https://github.com/beurdouche/tools/blob/master/depot_tools/checkout.py#L38
Due to blank lines in our codereview.settings it was not returning the correct VIEW_VC and due to this the 'Commited' line was not showing up in changes submitted by the commit-queue.

(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/7388061

git-svn-id: http://skia.googlecode.com/svn/trunk@7865 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Tue, 26 Feb 2013 15:56:05 +0000 (15:56 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7864 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogit-svn-id: http://skia.googlecode.com/svn/trunk@7863 2bbb7eff-a529-9590-31e7-b0007b4...
reed@google.com [Tue, 26 Feb 2013 15:50:51 +0000 (15:50 +0000)]
git-svn-id: skia.googlecode.com/svn/trunk@7863 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRename template param to SkSTArray to be consistent with its base class, SkTArray.
bsalomon@google.com [Tue, 26 Feb 2013 15:40:01 +0000 (15:40 +0000)]
Rename template param to SkSTArray to be consistent with its base class, SkTArray.

R=jvanverth@google.com
Review URL: https://codereview.appspot.com/7372050

git-svn-id: http://skia.googlecode.com/svn/trunk@7862 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd files omitted from gcl change in r7860.
bsalomon@google.com [Tue, 26 Feb 2013 14:45:41 +0000 (14:45 +0000)]
Add files omitted from gcl change in r7860.

git-svn-id: http://skia.googlecode.com/svn/trunk@7861 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoConsolidate functions common the the null and debug GL interfaces.
bsalomon@google.com [Tue, 26 Feb 2013 14:34:43 +0000 (14:34 +0000)]
Consolidate functions common the the null and debug GL interfaces.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7400053

git-svn-id: http://skia.googlecode.com/svn/trunk@7860 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test commit queue
commit-bot@chromium.org [Tue, 26 Feb 2013 13:13:44 +0000 (13:13 +0000)]
Whitespace change to test commit queue

(SkipBuildbotRuns)

Review URL: https://chromiumcodereview.appspot.com/12326121

git-svn-id: http://skia.googlecode.com/svn/trunk@7859 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPointing CODE_REVIEW_SERVER to Chromium Rietveld.
rmistry@google.com [Tue, 26 Feb 2013 12:01:28 +0000 (12:01 +0000)]
Pointing CODE_REVIEW_SERVER to Chromium Rietveld.

(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/7382058

git-svn-id: http://skia.googlecode.com/svn/trunk@7858 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 26 Feb 2013 07:01:22 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7857 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogit-svn-id: http://skia.googlecode.com/svn/trunk@7856 2bbb7eff-a529-9590-31e7-b0007b4...
reed@google.com [Mon, 25 Feb 2013 22:19:20 +0000 (22:19 +0000)]
git-svn-id: skia.googlecode.com/svn/trunk@7856 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a bunch of warnings, mainly around rowBytes.
scroggo@google.com [Mon, 25 Feb 2013 21:47:41 +0000 (21:47 +0000)]
Fix a bunch of warnings, mainly around rowBytes.

My recent change changed the way SkBitmap::fRowBytes is stored,
and parameter/return values referring to rowBytes were changed
to type size_t. Change the storage back, and eliminate warnings
resulting from returning a size_t.

Review URL: https://codereview.appspot.com/7396059

git-svn-id: http://skia.googlecode.com/svn/trunk@7855 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove duplicate impl for getFileName() on SkFDStream
reed@google.com [Mon, 25 Feb 2013 21:02:21 +0000 (21:02 +0000)]
remove duplicate impl for getFileName() on SkFDStream

git-svn-id: http://skia.googlecode.com/svn/trunk@7854 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixed the hash key comparison function.
sugoi@google.com [Mon, 25 Feb 2013 20:42:44 +0000 (20:42 +0000)]
Fixed the hash key comparison function.
Review URL: https://codereview.appspot.com/7378065

git-svn-id: http://skia.googlecode.com/svn/trunk@7853 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocheck-point: skiafy SkFontHost_fontconfig from chrome
reed@google.com [Mon, 25 Feb 2013 20:38:07 +0000 (20:38 +0000)]
check-point: skiafy SkFontHost_fontconfig from chrome

git-svn-id: http://skia.googlecode.com/svn/trunk@7852 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd --tmpDir foo option to tests, to allow unittests that want to write/read files
reed@google.com [Mon, 25 Feb 2013 20:24:24 +0000 (20:24 +0000)]
add --tmpDir foo option to tests, to allow unittests that want to write/read files
use tmpDir in SkStream tests

git-svn-id: http://skia.googlecode.com/svn/trunk@7851 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGive GrDrawTarget a back ptr to its owning GrContext.
bsalomon@google.com [Mon, 25 Feb 2013 20:12:45 +0000 (20:12 +0000)]
Give GrDrawTarget a back ptr to its owning GrContext.
Review URL: https://codereview.appspot.com/7395055

git-svn-id: http://skia.googlecode.com/svn/trunk@7850 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd an SkSet class to be used by Pdf only, for now - reverted because of triggering...
edisonn@google.com [Mon, 25 Feb 2013 20:07:24 +0000 (20:07 +0000)]
Add an SkSet class to be used by Pdf only, for now - reverted because of triggering heap corruption on Win7, original coe review: https://codereview.appspot.com/6749054

git-svn-id: http://skia.googlecode.com/svn/trunk@7849 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodon't #include <unistd.h> if we're windows
reed@google.com [Mon, 25 Feb 2013 18:46:11 +0000 (18:46 +0000)]
don't #include <unistd.h> if we're windows

git-svn-id: http://skia.googlecode.com/svn/trunk@7848 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodon't try to access filedescriptors on windows
reed@google.com [Mon, 25 Feb 2013 18:41:26 +0000 (18:41 +0000)]
don't try to access filedescriptors on windows

git-svn-id: http://skia.googlecode.com/svn/trunk@7847 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove SkFDStream out of images into core
reed@google.com [Mon, 25 Feb 2013 18:17:12 +0000 (18:17 +0000)]
move SkFDStream out of images into core

git-svn-id: http://skia.googlecode.com/svn/trunk@7846 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove bogus ability for creating an SkPicturePlayback to fail.
scroggo@google.com [Mon, 25 Feb 2013 16:05:00 +0000 (16:05 +0000)]
Remove bogus ability for creating an SkPicturePlayback to fail.

Change SkPicturePlayback::parseBufferTag to return void, since
it can never return false.

Change SkPicturePlayback::parseStreamTag to return void, since
the only way it can return false is if parseBufferTag returns
false, or if creating a sub picture failed, both of which are
nonsensical.

Due to the above, there is no reason for creating an
SkPicturePlayback to fail, so remove the isValid parameter.

Update subclasses in SkDebuggerGUI.

Review URL: https://codereview.appspot.com/7388050

git-svn-id: http://skia.googlecode.com/svn/trunk@7844 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse size_t for rowBytes.
scroggo@google.com [Mon, 25 Feb 2013 16:02:36 +0000 (16:02 +0000)]
Use size_t for rowBytes.

Previously, we were using uint32_t sometimes, int sometimes, and
size_t sometimes. Switch to using size_t, since we are actually
talking about a number of bytes.

In copyPixelsTo, use 0 as a flag to use the internal rowBytes,
which is more consistent with setConfig.

Review URL: https://codereview.appspot.com/7370047

git-svn-id: http://skia.googlecode.com/svn/trunk@7843 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAlways round text position correctly.
bungeman@google.com [Mon, 25 Feb 2013 15:55:13 +0000 (15:55 +0000)]
Always round text position correctly.
https://codereview.appspot.com/7383049/

Will require rebaseline of fontscaler GM.

Must add SK_IGNORE_SUBPIXEL_AXIS_ALIGN_FIX to Chromium
until ~150 layout tests can be rebaselined.

git-svn-id: http://skia.googlecode.com/svn/trunk@7842 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test commit queue
commit-bot@chromium.org [Mon, 25 Feb 2013 13:32:31 +0000 (13:32 +0000)]
Whitespace change to test commit queue

(SkipBuildbotRuns)

Review URL: https://chromiumcodereview.appspot.com/12340051

git-svn-id: http://skia.googlecode.com/svn/trunk@7841 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixed '#if with no expression' warning/error
robertphillips@google.com [Mon, 25 Feb 2013 01:38:01 +0000 (01:38 +0000)]
Fixed '#if with no expression' warning/error

git-svn-id: http://skia.googlecode.com/svn/trunk@7840 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 23 Feb 2013 07:02:45 +0000 (07:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7839 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix debugger build.
scroggo@google.com [Fri, 22 Feb 2013 22:37:31 +0000 (22:37 +0000)]
Fix debugger build.

Review URL: https://codereview.appspot.com/7375050

git-svn-id: http://skia.googlecode.com/svn/trunk@7838 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove SkSerializationHelpers.
scroggo@google.com [Fri, 22 Feb 2013 22:04:19 +0000 (22:04 +0000)]
Remove SkSerializationHelpers.

Move the function definition for EncodeBitmap to SkPicture,
where InstallPixelRefProc has already moved (and where it is
relevant).

Review URL: https://codereview.appspot.com/7386053

git-svn-id: http://skia.googlecode.com/svn/trunk@7837 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Fri, 22 Feb 2013 21:50:07 +0000 (21:50 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7836 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCreate SkLazyPixelRef which performs lazy decoding.
scroggo@google.com [Fri, 22 Feb 2013 21:38:35 +0000 (21:38 +0000)]
Create SkLazyPixelRef which performs lazy decoding.

The new pixel ref behaves similarly to SkImageRef, with some key differences:
It does not depend on the images project.
It requires an SkImageCache, which handles allocation and caching of the pixel
memory.
It takes a function signature for decoding which decodes into already allocated
pixel memory rather than into an SkBitmap.

Add two implementations of SkImageCache: SkLruImageCache and SkAshmemImageCache.

Replace SkSerializationHelpers::DecodeBitmap with SkPicture::InstallPixelRefProc,
and update sites that referenced it.

SkBitmapFactory now sets the pixel ref to a new object of the new
class SkLazyPixelRef, provided it has an SkImageCache for caching.

Provide an option to do lazy decodes in render_pictures and bench_pictures.

SkPicture:
Eliminate the default parameters in the constructor.
If a proc for decoding bitmaps is installed, use it to decode any encoded
data in subpictures.
When parsing deserializing subpictures, check for success.
When serializing subpictures, pass the picture's bitmap encoder to the
subpicture's call to serialize.

Update BitmapFactoryTest to test its new behavior.

BUG=https://code.google.com/p/skia/issues/detail?id=1008
BUG=https://code.google.com/p/skia/issues/detail?id=1009

Review URL: https://codereview.appspot.com/7060052

git-svn-id: http://skia.googlecode.com/svn/trunk@7835 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix signed/unsigned comparison warnings in benchmain.cpp
bsalomon@google.com [Fri, 22 Feb 2013 19:17:13 +0000 (19:17 +0000)]
Fix signed/unsigned comparison warnings in benchmain.cpp

git-svn-id: http://skia.googlecode.com/svn/trunk@7833 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse DEF_GM
reed@google.com [Fri, 22 Feb 2013 17:28:16 +0000 (17:28 +0000)]
use DEF_GM

git-svn-id: http://skia.googlecode.com/svn/trunk@7832 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnable cpu-array dynamic vertex data on SGX.
bsalomon@google.com [Fri, 22 Feb 2013 16:44:04 +0000 (16:44 +0000)]
Enable cpu-array dynamic vertex data on SGX.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7388045

git-svn-id: http://skia.googlecode.com/svn/trunk@7830 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove obsolete build flags:
reed@google.com [Fri, 22 Feb 2013 16:36:57 +0000 (16:36 +0000)]
remove obsolete build flags:

SK_IGNORE_TRANS_CLAMP_FIX
SK_IGNORE_1XN_BITMAP_OPT
SK_IGNORE_CLIP_BUG_FIX
SK_IGNORE_FAST_SCALEMATRIX_INVERT
SK_IGNORE_QUAD_STROKE_FIX
SK_IGNORE_MULTIPLY_XFERMODE_OPT
SK_IGNORE_LARGE_DASH_OPT
Review URL: https://codereview.appspot.com/7381050

git-svn-id: http://skia.googlecode.com/svn/trunk@7829 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix GPU-less build of bench.
bsalomon@google.com [Fri, 22 Feb 2013 16:25:28 +0000 (16:25 +0000)]
Fix GPU-less build of bench.

git-svn-id: http://skia.googlecode.com/svn/trunk@7828 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GPU versions of benchs use the same canvas size as raster.
bsalomon@google.com [Fri, 22 Feb 2013 16:13:16 +0000 (16:13 +0000)]
Make GPU versions of benchs use the same canvas size as raster.
Review URL: https://codereview.appspot.com/7400049

git-svn-id: http://skia.googlecode.com/svn/trunk@7827 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix ChartBench crash.
bsalomon@google.com [Fri, 22 Feb 2013 16:07:59 +0000 (16:07 +0000)]
Fix ChartBench crash.

git-svn-id: http://skia.googlecode.com/svn/trunk@7826 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAvoid an unitialized warning on linux.
scroggo@google.com [Fri, 22 Feb 2013 15:50:37 +0000 (15:50 +0000)]
Avoid an unitialized warning on linux.

Review URL: https://codereview.appspot.com/7378050

git-svn-id: http://skia.googlecode.com/svn/trunk@7825 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a warning on Android.
scroggo@google.com [Fri, 22 Feb 2013 15:46:44 +0000 (15:46 +0000)]
Fix a warning on Android.

Only define/use haveBuffer in debug mode, since it's only used for
assertions.

Review URL: https://codereview.appspot.com/7384051

git-svn-id: http://skia.googlecode.com/svn/trunk@7824 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a warning on linux.
scroggo@google.com [Fri, 22 Feb 2013 15:46:00 +0000 (15:46 +0000)]
Fix a warning on linux.

Review URL: https://codereview.appspot.com/7392045

git-svn-id: http://skia.googlecode.com/svn/trunk@7823 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd chart bench.
bsalomon@google.com [Fri, 22 Feb 2013 15:10:36 +0000 (15:10 +0000)]
Add chart bench.
Review URL: https://codereview.appspot.com/7368051

git-svn-id: http://skia.googlecode.com/svn/trunk@7821 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove obsolete build flag SK_IGNORE_CONVEX_QUAD_OPT
reed@google.com [Fri, 22 Feb 2013 14:19:58 +0000 (14:19 +0000)]
remove obsolete build flag SK_IGNORE_CONVEX_QUAD_OPT
Review URL: https://codereview.appspot.com/7363046

git-svn-id: http://skia.googlecode.com/svn/trunk@7820 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove obsolete build flag SK_IGNORE_SETLINE_FIX
reed@google.com [Fri, 22 Feb 2013 14:02:58 +0000 (14:02 +0000)]
remove obsolete build flag SK_IGNORE_SETLINE_FIX

git-svn-id: http://skia.googlecode.com/svn/trunk@7819 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove obsolete build flag SK_IGNORE_GRADIENT_DITHER_FIX
reed@google.com [Fri, 22 Feb 2013 13:03:29 +0000 (13:03 +0000)]
remove obsolete build flag SK_IGNORE_GRADIENT_DITHER_FIX

git-svn-id: http://skia.googlecode.com/svn/trunk@7818 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 22 Feb 2013 07:16:18 +0000 (07:16 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7817 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSmall adjustments to SkRectShaderImageFilter to follow up on original cl.
sugoi@google.com [Thu, 21 Feb 2013 20:26:50 +0000 (20:26 +0000)]
Small adjustments to SkRectShaderImageFilter to follow up on original cl.
Review URL: https://codereview.appspot.com/7377049

git-svn-id: http://skia.googlecode.com/svn/trunk@7816 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix GM self-test expectations, mkII
borenet@google.com [Thu, 21 Feb 2013 19:48:02 +0000 (19:48 +0000)]
Fix GM self-test expectations, mkII
Review URL: https://codereview.appspot.com/7393046

git-svn-id: http://skia.googlecode.com/svn/trunk@7815 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix GM self-test expectations
borenet@google.com [Thu, 21 Feb 2013 19:20:11 +0000 (19:20 +0000)]
Fix GM self-test expectations
Review URL: https://codereview.appspot.com/7386048

git-svn-id: http://skia.googlecode.com/svn/trunk@7814 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix ignored errors in GM when no reference images are provided
borenet@google.com [Thu, 21 Feb 2013 18:34:14 +0000 (18:34 +0000)]
Fix ignored errors in GM when no reference images are provided
Review URL: https://codereview.appspot.com/7400044

git-svn-id: http://skia.googlecode.com/svn/trunk@7813 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix warnings-as-errors on Mac10.6 and Win. Unreviewed.
senorblanco@chromium.org [Thu, 21 Feb 2013 17:10:44 +0000 (17:10 +0000)]
Fix warnings-as-errors on Mac10.6 and Win.  Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7811 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse CPU arrays for dynamic indices/vertices on ARM GPUs.
bsalomon@google.com [Thu, 21 Feb 2013 16:34:21 +0000 (16:34 +0000)]
Use CPU arrays for dynamic indices/vertices on ARM GPUs.
Review URL: https://codereview.appspot.com/7365047

git-svn-id: http://skia.googlecode.com/svn/trunk@7810 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNew SkRectShaderImageFilter image filter
sugoi@google.com [Thu, 21 Feb 2013 15:02:28 +0000 (15:02 +0000)]
New SkRectShaderImageFilter image filter

This new changelist also introduces a new image filter called SkRectShaderImageFilter which is make to simply apply a shader on a region without using any inputs.

TEST=Added ShaderImageFilter test
Review URL: https://codereview.appspot.com/7300046

git-svn-id: http://skia.googlecode.com/svn/trunk@7808 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support for vertex data rendered from CPU arrays.
bsalomon@google.com [Thu, 21 Feb 2013 14:33:46 +0000 (14:33 +0000)]
Add support for vertex data rendered from CPU arrays.
Review URL: https://codereview.appspot.com/7380044

git-svn-id: http://skia.googlecode.com/svn/trunk@7807 2bbb7eff-a529-9590-31e7-b0007b416f81