platform/upstream/libSkiaSharp.git
11 years agoFix spelling error.
bsalomon@google.com [Thu, 24 Jan 2013 19:00:02 +0000 (19:00 +0000)]
Fix spelling error.

git-svn-id: http://skia.googlecode.com/svn/trunk@7376 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochange giantdashline test to use 4 intervals, to explicitly avoid the asPoints
reed@google.com [Thu, 24 Jan 2013 18:43:32 +0000 (18:43 +0000)]
change giantdashline test to use 4 intervals, to explicitly avoid the asPoints
special case code (which we may test separately later).

git-svn-id: http://skia.googlecode.com/svn/trunk@7375 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodoh. drawRRect is not on SkDevice.... yet
reed@google.com [Thu, 24 Jan 2013 18:37:53 +0000 (18:37 +0000)]
doh. drawRRect is not on SkDevice.... yet

git-svn-id: http://skia.googlecode.com/svn/trunk@7374 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix logic bug introduced in r7346.
bsalomon@google.com [Thu, 24 Jan 2013 18:28:51 +0000 (18:28 +0000)]
Fix logic bug introduced in r7346.

git-svn-id: http://skia.googlecode.com/svn/trunk@7373 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agooverride drawOval and drawRRect in GatherPixelRefDevice, so we don't miss those,
reed@google.com [Thu, 24 Jan 2013 18:27:42 +0000 (18:27 +0000)]
override drawOval and drawRRect in GatherPixelRefDevice, so we don't miss those,
and possibly crash trying to raster into an empty device.

http://code.google.com/p/skia/issues/detail?id=1086
Review URL: https://codereview.appspot.com/7193057

git-svn-id: http://skia.googlecode.com/svn/trunk@7372 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoupdate to emphasis the culling aspect of the test (making the line much longer,
reed@google.com [Thu, 24 Jan 2013 17:33:21 +0000 (17:33 +0000)]
update to emphasis the culling aspect of the test (making the line much longer,
and adding hairline and non-hairline cases.)

git-svn-id: http://skia.googlecode.com/svn/trunk@7371 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd bench for giant dashed lines, to test future optimizations for culling
reed@google.com [Thu, 24 Jan 2013 17:17:28 +0000 (17:17 +0000)]
add bench for giant dashed lines, to test future optimizations for culling

git-svn-id: http://skia.googlecode.com/svn/trunk@7368 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse DEF_BENCH for clarity
reed@google.com [Thu, 24 Jan 2013 16:56:36 +0000 (16:56 +0000)]
use DEF_BENCH for clarity

git-svn-id: http://skia.googlecode.com/svn/trunk@7367 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove method calls on invalid "this" pointer.
bungeman@google.com [Thu, 24 Jan 2013 16:38:23 +0000 (16:38 +0000)]
Remove method calls on invalid "this" pointer.
https://codereview.appspot.com/7198050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7366 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThe oval path bench tests used to draw a circle, but I changed them to an oval
jvanverth@google.com [Thu, 24 Jan 2013 15:45:35 +0000 (15:45 +0000)]
The oval path bench tests used to draw a circle, but I changed them to an oval
so that we could track performance changes for ovals. However, rendering the
stroked oval cases are now ~5ms slower since they're larger. This restores them
to something close to their original performance by slightly shrinking the
bounds. This will help determine what effect r7304 may have had.

git-svn-id: http://skia.googlecode.com/svn/trunk@7365 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix sort test.
bungeman@google.com [Thu, 24 Jan 2013 15:06:47 +0000 (15:06 +0000)]
Fix sort test.
https://codereview.appspot.com/7199050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7364 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
rmistry@google.com [Thu, 24 Jan 2013 15:01:22 +0000 (15:01 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7363 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake all GrContext members that return a texture also ref the texture for the caller.
bsalomon@google.com [Thu, 24 Jan 2013 14:46:47 +0000 (14:46 +0000)]
Make all GrContext members that return a texture also ref the texture for the caller.
Review URL: https://codereview.appspot.com/7198049

git-svn-id: http://skia.googlecode.com/svn/trunk@7362 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove code in isPaintOpaque from SkDeferredCanvas.cpp to SkPaintPriv
junov@chromium.org [Thu, 24 Jan 2013 14:38:23 +0000 (14:38 +0000)]
Move code in isPaintOpaque from SkDeferredCanvas.cpp to SkPaintPriv

The purpose of this code move is to make it re-usable in order to implement
occlusion culling optimizations in SkPicture similar to what we have now
in SkDeferredCanvas.

BUG=https://code.google.com/p/chromium/issues/detail?id=164530
Review URL: https://codereview.appspot.com/7196046

git-svn-id: http://skia.googlecode.com/svn/trunk@7361 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 24 Jan 2013 07:06:13 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7357 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.
rmistry@google.com [Thu, 24 Jan 2013 04:15:57 +0000 (04:15 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7356 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd deferred count to GrResource.
bsalomon@google.com [Wed, 23 Jan 2013 21:37:01 +0000 (21:37 +0000)]
Add deferred count to GrResource.

This will be used to determine whether a resource can either be deleted or reinserted in the cache when its ref count reaches zero.
Review URL: https://codereview.appspot.com/7202046

git-svn-id: http://skia.googlecode.com/svn/trunk@7355 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bug introduced in r7348, deleting wrapped resources.
bsalomon@google.com [Wed, 23 Jan 2013 21:32:32 +0000 (21:32 +0000)]
Fix bug introduced in r7348, deleting wrapped resources.

git-svn-id: http://skia.googlecode.com/svn/trunk@7354 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace gcl_try with submit_try
borenet@google.com [Wed, 23 Jan 2013 20:54:29 +0000 (20:54 +0000)]
Replace gcl_try with submit_try

submit_try supports both git and svn and hooks directly into depot_tools rather
than calling it in a subprocess.
Review URL: https://codereview.appspot.com/7202044

git-svn-id: http://skia.googlecode.com/svn/trunk@7352 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChanges per-tile bench values to use the average of repetitions from new bench log...
bensong@google.com [Wed, 23 Jan 2013 20:51:17 +0000 (20:51 +0000)]
Changes per-tile bench values to use the average of repetitions from new bench log output.
Corresponding logs change was done at https://codereview.appspot.com/7101060/ and this CL needs to be submitted together with that one for data consistency. Then we can turn on timePerTile.
Review URL: https://codereview.appspot.com/7193051

git-svn-id: http://skia.googlecode.com/svn/trunk@7351 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverse sense of convex-quad-fix compiler flag
robertphillips@google.com [Wed, 23 Jan 2013 20:45:26 +0000 (20:45 +0000)]
Reverse sense of convex-quad-fix compiler flag

https://codereview.appspot.com/7206045/

git-svn-id: http://skia.googlecode.com/svn/trunk@7349 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GrResource know whether 3D objects' lifetimes are managed by Skia or not.
bsalomon@google.com [Wed, 23 Jan 2013 20:25:22 +0000 (20:25 +0000)]
Make GrResource know whether 3D objects' lifetimes are managed by Skia or not.
Review URL: https://codereview.appspot.com/7201046

git-svn-id: http://skia.googlecode.com/svn/trunk@7348 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r7341
edisonn@google.com [Wed, 23 Jan 2013 20:12:31 +0000 (20:12 +0000)]
Revert r7341

git-svn-id: http://skia.googlecode.com/svn/trunk@7347 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReland r7342 with fixes.
bsalomon@google.com [Wed, 23 Jan 2013 19:53:46 +0000 (19:53 +0000)]
Reland r7342 with fixes.

git-svn-id: http://skia.googlecode.com/svn/trunk@7346 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert 7342 to investigate failures.
bsalomon@google.com [Wed, 23 Jan 2013 19:09:06 +0000 (19:09 +0000)]
Revert 7342 to investigate failures.

git-svn-id: http://skia.googlecode.com/svn/trunk@7345 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate Android toolchain to NDK r8d with GCC 4.7
djsollen@google.com [Wed, 23 Jan 2013 18:56:38 +0000 (18:56 +0000)]
Update Android toolchain to NDK r8d with GCC 4.7

Review URL: https://codereview.appspot.com/7201045

git-svn-id: http://skia.googlecode.com/svn/trunk@7343 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GrDrawState::DeferredState for saving GrDrawStates in GrInOrderDrawBuffer.
bsalomon@google.com [Wed, 23 Jan 2013 18:29:21 +0000 (18:29 +0000)]
Add GrDrawState::DeferredState for saving GrDrawStates in GrInOrderDrawBuffer.

A future CL will do the unref'ing of GrResources when converting a GrDrawState to a DeferredState.
Review URL: https://codereview.appspot.com/7181049

git-svn-id: http://skia.googlecode.com/svn/trunk@7342 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIf getAdvance fails, getAdvanceData should not assert, but ignored.
edisonn@google.com [Wed, 23 Jan 2013 16:08:15 +0000 (16:08 +0000)]
If getAdvance fails, getAdvanceData should  not assert, but ignored.
Review URL: https://codereview.appspot.com/7127056

git-svn-id: http://skia.googlecode.com/svn/trunk@7341 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd alias for MakeFromIRect (just Make)
reed@google.com [Wed, 23 Jan 2013 15:37:56 +0000 (15:37 +0000)]
add alias for MakeFromIRect (just Make)

git-svn-id: http://skia.googlecode.com/svn/trunk@7340 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse Skia style cast in SkDeviceProperties.
bungeman@google.com [Wed, 23 Jan 2013 15:31:43 +0000 (15:31 +0000)]
Use Skia style cast in SkDeviceProperties.
(Alternative to 7329.)

git-svn-id: http://skia.googlecode.com/svn/trunk@7339 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd rand10 bench for sort, which makes 10% of the entries repeats
reed@google.com [Wed, 23 Jan 2013 14:52:12 +0000 (14:52 +0000)]
add rand10 bench for sort, which makes 10% of the entries repeats
reorder sort tests to make comparisons easier to read

git-svn-id: http://skia.googlecode.com/svn/trunk@7338 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDisplay a warning prompt in presubmit if the tree status is in 'Caution'.
rmistry@google.com [Wed, 23 Jan 2013 14:35:58 +0000 (14:35 +0000)]
Display a warning prompt in presubmit if the tree status is in 'Caution'.

Example presubmit output:

Running presubmit upload checks ...

** Presubmit Warnings **
Tree state is: caution

***************
Please use caution in checkins
http://skia-tree-status-staging.appspot.com/banner-status?format=json
***************

There were presubmit warnings. Are you sure you wish to continue? (y/N):
Review URL: https://codereview.appspot.com/7200043

git-svn-id: http://skia.googlecode.com/svn/trunk@7337 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnsure that streams written using SkFlattenableBuffer's can be read with readByteArra...
djsollen@google.com [Wed, 23 Jan 2013 13:40:40 +0000 (13:40 +0000)]
Ensure that streams written using SkFlattenableBuffer's can be read with readByteArray(...)

Review URL: https://codereview.appspot.com/7138063

git-svn-id: http://skia.googlecode.com/svn/trunk@7335 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 23 Jan 2013 07:06:17 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7332 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle...
rmistry@google.com [Wed, 23 Jan 2013 05:47:03 +0000 (05:47 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7331 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd bench for sorting
mike@reedtribe.org [Wed, 23 Jan 2013 02:23:40 +0000 (02:23 +0000)]
add bench for sorting

git-svn-id: http://skia.googlecode.com/svn/trunk@7330 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSpeculative fix for cros_daisy compilation failure
robertphillips@google.com [Wed, 23 Jan 2013 01:46:26 +0000 (01:46 +0000)]
Speculative fix for cros_daisy compilation failure

include/core/SkDeviceProperties.h:82:51: error: narrowing conversion of '(((int)orientation) | ((int)layout))' from 'int' to 'uint8_t

unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@7329 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for oversight in r7325
robertphillips@google.com [Wed, 23 Jan 2013 00:36:02 +0000 (00:36 +0000)]
Fix for oversight in r7325

unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@7328 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove declaration of unimplemented function.
bsalomon@google.com [Tue, 22 Jan 2013 22:04:13 +0000 (22:04 +0000)]
Remove declaration of unimplemented function.

git-svn-id: http://skia.googlecode.com/svn/trunk@7327 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSwitch GrEffect::onIsEqual signature back to GrEffect from GrEffectRef.
bsalomon@google.com [Tue, 22 Jan 2013 20:35:13 +0000 (20:35 +0000)]
Switch GrEffect::onIsEqual signature back to GrEffect from GrEffectRef.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7188046

git-svn-id: http://skia.googlecode.com/svn/trunk@7326 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bug in 1xN SkBitmapProcShader optimization
robertphillips@google.com [Tue, 22 Jan 2013 20:29:16 +0000 (20:29 +0000)]
Fix bug in 1xN SkBitmapProcShader optimization

https://codereview.appspot.com/7187047/

git-svn-id: http://skia.googlecode.com/svn/trunk@7325 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix r7321 build errors on non-windows compilers (using forward declared but not...
bsalomon@google.com [Tue, 22 Jan 2013 20:10:17 +0000 (20:10 +0000)]
Fix r7321  build errors on non-windows compilers (using forward declared but not defined class in templated function).

git-svn-id: http://skia.googlecode.com/svn/trunk@7324 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix Android only code in SkDraw for 7317.
bungeman@google.com [Tue, 22 Jan 2013 20:00:01 +0000 (20:00 +0000)]
Fix Android only code in SkDraw for 7317.

git-svn-id: http://skia.googlecode.com/svn/trunk@7322 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoLet them eat GrEffectRef.
bsalomon@google.com [Tue, 22 Jan 2013 19:55:59 +0000 (19:55 +0000)]
Let them eat GrEffectRef.

Changes the remaining existing code that operates on naked GrEffects to GrEffectRef.
Review URL: https://codereview.appspot.com/7124058

git-svn-id: http://skia.googlecode.com/svn/trunk@7321 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix VC++ warning and Android only code for 7317.
bungeman@google.com [Tue, 22 Jan 2013 19:49:33 +0000 (19:49 +0000)]
Fix VC++ warning and Android only code for 7317.

git-svn-id: http://skia.googlecode.com/svn/trunk@7319 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded multi-select deletion to debugger
robertphillips@google.com [Tue, 22 Jan 2013 19:38:46 +0000 (19:38 +0000)]
Added multi-select deletion to debugger

https://codereview.appspot.com/7190043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7318 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExpose geometry and gamma on device.
bungeman@google.com [Tue, 22 Jan 2013 19:25:14 +0000 (19:25 +0000)]
Expose geometry and gamma on device.
https://codereview.appspot.com/6499101/

git-svn-id: http://skia.googlecode.com/svn/trunk@7317 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd wrapper for "gcl try"
borenet@google.com [Tue, 22 Jan 2013 18:23:56 +0000 (18:23 +0000)]
Add wrapper for "gcl try"

Adds some validation for --bot
Review URL: https://codereview.appspot.com/7179048

git-svn-id: http://skia.googlecode.com/svn/trunk@7315 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix saving modified skp from debugger
robertphillips@google.com [Tue, 22 Jan 2013 18:03:56 +0000 (18:03 +0000)]
Fix saving modified skp from debugger

https://codereview.appspot.com/7181048/

git-svn-id: http://skia.googlecode.com/svn/trunk@7314 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSimple Build fix. Unreviewed.
junov@chromium.org [Tue, 22 Jan 2013 18:01:26 +0000 (18:01 +0000)]
Simple Build fix. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7313 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing invalid text clipping on SkPicture playback
junov@chromium.org [Tue, 22 Jan 2013 17:50:47 +0000 (17:50 +0000)]
Fixing invalid text clipping on SkPicture playback

The bug was caused by an invalid assumption that a flattend object's
index is related to its array index in SkFlatDictionary::fData.
The data in SkFlatDictionary is sorted by flattened data content,
not by index number. Problem was solved by passing down the SkFlatData*
through addPaint, rather than the index value. The bug was causing
SkPictureRecord::addFontMetricsTopBottom to use cached font metrics
from the wrong SkPaint instance.

BUG=https://code.google.com/p/chromium/issues/detail?id=170964
Review URL: https://codereview.appspot.com/7178045

git-svn-id: http://skia.googlecode.com/svn/trunk@7312 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded toString to SkXfermode-derived classes (for debugger)
robertphillips@google.com [Tue, 22 Jan 2013 14:32:09 +0000 (14:32 +0000)]
Added toString to SkXfermode-derived classes (for debugger)

https://codereview.appspot.com/7139058/

git-svn-id: http://skia.googlecode.com/svn/trunk@7308 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPatch for r7304. Add string in bench_pictures_main's gFilterTypes for oval filter...
jvanverth@google.com [Tue, 22 Jan 2013 13:54:52 +0000 (13:54 +0000)]
Patch for r7304. Add string in bench_pictures_main's gFilterTypes for oval filter type.

git-svn-id: http://skia.googlecode.com/svn/trunk@7307 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GPU support for axis-aligned ovals:
jvanverth@google.com [Tue, 22 Jan 2013 13:34:01 +0000 (13:34 +0000)]
Add GPU support for axis-aligned ovals:
- Add drawOval base function to SkDevice, and override in SkGpuDevice
- Move isSimilarityMatrix to SkMatrix (renamed to isSimilarity) and fixed up unit test
- Since both SkGpuDevice::drawOval() and GrContext::drawPath() can try to draw ovals, added GrContext::canDrawOval() and GrContext::internalDrawOval() to avoid duplicate code
- Hooked in axis-aligned oval fill shader
- Enabled GPU stroked circles
- Added stroked circle bench test

Review URL: https://codereview.appspot.com/7137050

git-svn-id: http://skia.googlecode.com/svn/trunk@7304 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Tue, 22 Jan 2013 12:55:54 +0000 (12:55 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7303 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPlace fix in r7278 behind compile flag
robertphillips@google.com [Mon, 21 Jan 2013 21:48:58 +0000 (21:48 +0000)]
Place fix in r7278 behind compile flag

git-svn-id: http://skia.googlecode.com/svn/trunk@7300 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle...
rmistry@google.com [Mon, 21 Jan 2013 21:18:14 +0000 (21:18 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7299 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPlacing 1xN bitmap shader opt behind a flag to delay WebKit rebaselines
robertphillips@google.com [Mon, 21 Jan 2013 21:17:16 +0000 (21:17 +0000)]
Placing 1xN bitmap shader opt behind a flag to delay WebKit rebaselines

git-svn-id: http://skia.googlecode.com/svn/trunk@7298 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
rmistry@google.com [Mon, 21 Jan 2013 03:43:21 +0000 (03:43 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7297 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.
rmistry@google.com [Sun, 20 Jan 2013 16:22:24 +0000 (16:22 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7296 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sun, 20 Jan 2013 07:05:51 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7295 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Sat, 19 Jan 2013 13:22:39 +0000 (13:22 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7294 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 19 Jan 2013 07:05:38 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7293 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bugs in r7291
epoger@google.com [Sat, 19 Jan 2013 04:56:36 +0000 (04:56 +0000)]
Fix bugs in r7291
TBR=reed
Review URL: https://codereview.appspot.com/7129057

git-svn-id: http://skia.googlecode.com/svn/trunk@7292 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agore-land r7258 with fixes and tests
epoger@google.com [Sat, 19 Jan 2013 04:21:27 +0000 (04:21 +0000)]
re-land r7258 with fixes and tests
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=reed
Review URL: https://codereview.appspot.com/7132060

git-svn-id: http://skia.googlecode.com/svn/trunk@7291 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPartial revert of r7287 to green up the bots.
senorblanco@chromium.org [Fri, 18 Jan 2013 21:53:12 +0000 (21:53 +0000)]
Partial revert of r7287 to green up the bots.

git-svn-id: http://skia.googlecode.com/svn/trunk@7290 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRoll out r7258
epoger@google.com [Fri, 18 Jan 2013 21:45:42 +0000 (21:45 +0000)]
Roll out r7258
BUG=http://code.google.com/p/skia/issues/detail?id=1079
TBR=robertphillips
Review URL: https://codereview.appspot.com/7138065

git-svn-id: http://skia.googlecode.com/svn/trunk@7289 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate gyp revision.
bungeman@google.com [Fri, 18 Jan 2013 21:20:16 +0000 (21:20 +0000)]
Update gyp revision.
Now allows out-of-source output directories.

git-svn-id: http://skia.googlecode.com/svn/trunk@7288 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago(Relanding r7275 with assert fix, plus fixes from r7276, r7280, r7283.)
senorblanco@chromium.org [Fri, 18 Jan 2013 20:48:20 +0000 (20:48 +0000)]
(Relanding r7275 with assert fix, plus fixes from r7276, r7280, r7283.)

Implement a bicubic resampling image filter, with raster and GPU backends.
In order to get this to work on the GPU side, I had to modify the width and height of the drawn texture in drawSprite() and drawDevice() to use the filtered texture's dimensions, instead of the source texture.  (This wasn't a problem before since all other image filters produce results the same dimensions as their input texture.)
For now, this implementation only does axis-aligned scaling (same as the Lanczos-3 implementation in Chrome).  It's also done for correctness and clarity, not speed, so there are lots of opportunities for speedups.

Committed: https://code.google.com/p/skia/source/detail?r=7275

Review URL: https://codereview.appspot.com/7033049

git-svn-id: http://skia.googlecode.com/svn/trunk@7287 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm self-test: followup to r7284
epoger@google.com [Fri, 18 Jan 2013 20:03:58 +0000 (20:03 +0000)]
gm self-test: followup to r7284
TBR=rmistry
Review URL: https://codereview.appspot.com/7128056

git-svn-id: http://skia.googlecode.com/svn/trunk@7286 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting chain of SkBicubicImageFilter changes (7275, 7276, 7280 & 7283)
robertphillips@google.com [Fri, 18 Jan 2013 19:20:52 +0000 (19:20 +0000)]
Reverting chain of SkBicubicImageFilter changes (7275, 7276, 7280 & 7283)

git-svn-id: http://skia.googlecode.com/svn/trunk@7285 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomake gm self-test more robust
epoger@google.com [Fri, 18 Jan 2013 19:19:47 +0000 (19:19 +0000)]
make gm self-test more robust
BUG=http://code.google.com/p/skia/issues/detail?id=1068
Review URL: https://codereview.appspot.com/7164043

git-svn-id: http://skia.googlecode.com/svn/trunk@7284 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix unused-variable warning in src/effects/SkBicubicImageFilter.cpp
reed@google.com [Fri, 18 Jan 2013 18:31:19 +0000 (18:31 +0000)]
fix unused-variable warning in src/effects/SkBicubicImageFilter.cpp

git-svn-id: http://skia.googlecode.com/svn/trunk@7283 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotools.gyp: dependencies in apfabetical order
edisonn@google.com [Fri, 18 Jan 2013 18:06:22 +0000 (18:06 +0000)]
tools.gyp: dependencies in apfabetical order
Review URL: https://codereview.appspot.com/7127055

git-svn-id: http://skia.googlecode.com/svn/trunk@7281 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemoved unused variable in SkBicubicImageFilter.cpp
robertphillips@google.com [Fri, 18 Jan 2013 17:56:31 +0000 (17:56 +0000)]
Removed unused variable in SkBicubicImageFilter.cpp

git-svn-id: http://skia.googlecode.com/svn/trunk@7280 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoin SkPath::dump(), add \n after close() printf, so we don't run into the next verb...
reed@google.com [Fri, 18 Jan 2013 17:53:36 +0000 (17:53 +0000)]
in SkPath::dump(), add \n after close() printf, so we don't run into the next verb (e.g. moveTo)

git-svn-id: http://skia.googlecode.com/svn/trunk@7279 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoincrease iteration count from 16 to 24, when computing cubic-line intersection.
reed@google.com [Fri, 18 Jan 2013 17:49:28 +0000 (17:49 +0000)]
increase iteration count from 16 to 24, when computing cubic-line intersection.
This fixes crbug 170666. Before the fix, were were finishing the "clip" step
with a curve that was still partly negative, and so as assert would fire.

added unittest to confirm that the assert doesn't fire.

git-svn-id: http://skia.googlecode.com/svn/trunk@7278 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix 7273 for neon
robertphillips@google.com [Fri, 18 Jan 2013 17:41:26 +0000 (17:41 +0000)]
Fix 7273 for neon

https://codereview.appspot.com/7137059/

git-svn-id: http://skia.googlecode.com/svn/trunk@7277 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix GPU-less build. Unreviewed.
senorblanco@chromium.org [Fri, 18 Jan 2013 17:32:50 +0000 (17:32 +0000)]
Fix GPU-less build.  Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7276 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement a bicubic resampling image filter, with raster and GPU backends.
senorblanco@chromium.org [Fri, 18 Jan 2013 17:29:15 +0000 (17:29 +0000)]
Implement a bicubic resampling image filter, with raster and GPU backends.
In order to get this to work on the GPU side, I had to modify the width and height of the drawn texture in drawSprite() and drawDevice() to use the filtered texture's dimensions, instead of the source texture.  (This wasn't a problem before since all other image filters produce results the same dimensions as their input texture.)
For now, this implementation only does axis-aligned scaling (same as the Lanczos-3 implementation in Chrome).  It's also done for correctness and clarity, not speed, so there are lots of opportunities for speedups.

Review URL: https://codereview.appspot.com/7033049

git-svn-id: http://skia.googlecode.com/svn/trunk@7275 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild render_pdfs on buildbot.
edisonn@google.com [Fri, 18 Jan 2013 17:24:33 +0000 (17:24 +0000)]
Build render_pdfs on buildbot.
Review URL: https://codereview.appspot.com/7134055

git-svn-id: http://skia.googlecode.com/svn/trunk@7274 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded shaderproc for 1xN repeatX/repeatY BitmapProcShader
robertphillips@google.com [Fri, 18 Jan 2013 16:38:40 +0000 (16:38 +0000)]
Added shaderproc for 1xN repeatX/repeatY BitmapProcShader

https://codereview.appspot.com/7063054/

git-svn-id: http://skia.googlecode.com/svn/trunk@7273 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix gyp files when building Android for x86
djsollen@google.com [Fri, 18 Jan 2013 15:21:54 +0000 (15:21 +0000)]
Fix gyp files when building Android for x86

BUG=606

Review URL: https://codereview.appspot.com/7086053

git-svn-id: http://skia.googlecode.com/svn/trunk@7271 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace commit to test annotations (AddDashboardAnnotation)
rmistry@google.com [Fri, 18 Jan 2013 12:13:40 +0000 (12:13 +0000)]
Whitespace commit to test annotations (AddDashboardAnnotation)

git-svn-id: http://skia.googlecode.com/svn/trunk@7270 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 18 Jan 2013 07:07:28 +0000 (07:07 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7268 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agochange SkPath::dump() to output compilable code snippet, to aid in debugging.
reed@google.com [Thu, 17 Jan 2013 22:07:50 +0000 (22:07 +0000)]
change SkPath::dump() to output compilable code snippet, to aid in debugging.

git-svn-id: http://skia.googlecode.com/svn/trunk@7267 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Thu, 17 Jan 2013 21:02:47 +0000 (21:02 +0000)]
shape ops work in progress

mostly working on cubic/cubic intersect

git-svn-id: http://skia.googlecode.com/svn/trunk@7266 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDon't die when there are no fonts available.
bungeman@google.com [Thu, 17 Jan 2013 20:19:13 +0000 (20:19 +0000)]
Don't die when there are no fonts available.
https://codereview.appspot.com/7147044/

git-svn-id: http://skia.googlecode.com/svn/trunk@7265 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded new bench to test out 1xN BitmapProcShaders
robertphillips@google.com [Thu, 17 Jan 2013 19:51:41 +0000 (19:51 +0000)]
Added new bench to test out 1xN BitmapProcShaders

https://codereview.appspot.com/7160043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7264 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAll skp files in Google Storage have been updated
rmistry@google.com [Thu, 17 Jan 2013 18:43:29 +0000 (18:43 +0000)]
All skp files in Google Storage have been updated

git-svn-id: http://skia.googlecode.com/svn/trunk@7261 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix call to INHERITED::isEqual in GrRadial2Gradient. Should be INHERITED::onIsEqual.
bsalomon@google.com [Thu, 17 Jan 2013 18:39:59 +0000 (18:39 +0000)]
Fix call to INHERITED::isEqual in GrRadial2Gradient. Should be INHERITED::onIsEqual.

git-svn-id: http://skia.googlecode.com/svn/trunk@7260 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReapply r7198 with Mac/Windows fixes
epoger@google.com [Thu, 17 Jan 2013 17:54:28 +0000 (17:54 +0000)]
Reapply r7198 with Mac/Windows fixes
BUG=https://code.google.com/p/skia/issues/detail?id=1067
Review URL: https://codereview.appspot.com/7138056

git-svn-id: http://skia.googlecode.com/svn/trunk@7258 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove default implementation of GrEffect::isEqual. Make GrSingleTextureEffect abstract.
bsalomon@google.com [Thu, 17 Jan 2013 16:50:08 +0000 (16:50 +0000)]
Remove default implementation of GrEffect::isEqual. Make GrSingleTextureEffect abstract.
Review URL: https://codereview.appspot.com/7142049

git-svn-id: http://skia.googlecode.com/svn/trunk@7254 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake navigating the picture view in debugger more functional.
bungeman@google.com [Thu, 17 Jan 2013 16:30:56 +0000 (16:30 +0000)]
Make navigating the picture view in debugger more functional.
https://codereview.appspot.com/7134049/

git-svn-id: http://skia.googlecode.com/svn/trunk@7253 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix debugger handling of clip rrects
robertphillips@google.com [Thu, 17 Jan 2013 16:07:04 +0000 (16:07 +0000)]
Fix debugger handling of clip rrects

https://codereview.appspot.com/7135053/

git-svn-id: http://skia.googlecode.com/svn/trunk@7252 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocherry-pick from 7241: speed-up matrix44::setconcat when both inputs are
reed@google.com [Thu, 17 Jan 2013 16:01:19 +0000 (16:01 +0000)]
cherry-pick from 7241: speed-up matrix44::setconcat when both inputs are
scale+translate by inlining the zero-assignments, rather than calling sk_bzero.

bench: matrix44_setconcat 2x faster

git-svn-id: http://skia.googlecode.com/svn/trunk@7251 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding CheckChangeHasOnlyOneEol to upload and commit presubmit checks
rmistry@google.com [Thu, 17 Jan 2013 14:50:59 +0000 (14:50 +0000)]
Adding CheckChangeHasOnlyOneEol to upload and commit presubmit checks
Review URL: https://codereview.appspot.com/7151043

git-svn-id: http://skia.googlecode.com/svn/trunk@7247 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSwitch debugger profiling stubs over to being guarded by SK_DEVELOPER
robertphillips@google.com [Thu, 17 Jan 2013 14:39:20 +0000 (14:39 +0000)]
Switch debugger profiling stubs over to being guarded by SK_DEVELOPER

https://codereview.appspot.com/7134053/

git-svn-id: http://skia.googlecode.com/svn/trunk@7246 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r7241, which broke tests on most platforms.
tomhudson@google.com [Thu, 17 Jan 2013 13:29:35 +0000 (13:29 +0000)]
Revert r7241, which broke tests on most platforms.

git-svn-id: http://skia.googlecode.com/svn/trunk@7245 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove unused debugger code from SampleApp.
djsollen@google.com [Thu, 17 Jan 2013 13:20:01 +0000 (13:20 +0000)]
Remove unused debugger code from SampleApp.

Review URL: https://codereview.appspot.com/7133049

git-svn-id: http://skia.googlecode.com/svn/trunk@7244 2bbb7eff-a529-9590-31e7-b0007b416f81