reed [Mon, 29 Sep 2014 19:10:27 +0000 (12:10 -0700)]
remove alphatype from colortable
the owning bitmap is (already) responsible for knowing the alphatype
BUG=skia:
R=djsollen@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
611093002
humper [Mon, 29 Sep 2014 18:42:25 +0000 (11:42 -0700)]
allow caller to override the default output directory for gyp
BUG=skia:
R=jcgregorio@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
614753002
robertphillips [Mon, 29 Sep 2014 18:39:38 +0000 (11:39 -0700)]
Move offset and CTM from LayerCache Key to per-hoisted-layer info
This CL reduces the amount of information used in the layer cache key:
- the stop value isn't needed since the start value uniquely identifies the layer in the picture.
- only the upper-left 2x2 portion of the CTM should be used as a key for looking up cached layers.
- individual layers can be redraw in different locations so the final offset cannot be a part of the key.
Since this data is no longer stored in the cached layer, but is still required to draw the cached layer, it is now stored in the per-layer information (i.e., HoistedLayer).
This is split out of (Fix sub-picture layer rendering bugs - https://codereview.chromium.org/
597293002/).
BUG=skia:2315
R=egdaniel@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
609403003
robertphillips [Mon, 29 Sep 2014 18:17:58 +0000 (11:17 -0700)]
Rebaselining Win7 image failures (textblob, verttext2)
Rebaselining these for now and see if they recur.
R=borenet@google.com
TBR=borenet@google.com
BUG=skia:2956
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
600533003
bsalomon [Mon, 29 Sep 2014 18:01:58 +0000 (11:01 -0700)]
Make writeRenderTargetPixels use draw buffer rather than GrGpu
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
586393005
tfarina [Mon, 29 Sep 2014 17:50:59 +0000 (10:50 -0700)]
Fix some references to non-existant polyfill directory.
Looks like the name of the directory is "poly" rather than "polyfill".
BUG=None
TEST=None
R=humper@google.com, jcgregorio@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
610003003
tfarina [Mon, 29 Sep 2014 17:50:29 +0000 (10:50 -0700)]
Mention 'go get' command in the README file.
This is necessary to build webtry.go as it imports packages from
github.com
BUG=None
TEST=follow the README instructions
R=humper@google.com, jcgregorio@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
601033004
junov [Mon, 29 Sep 2014 17:18:59 +0000 (10:18 -0700)]
Applying post-commit comments from https://codereview.chromium.org/
607993002/
BUG=skia:
R=robertphillips@google.com
Author: junov@chromium.org
Review URL: https://codereview.chromium.org/
612063003
djsollen [Mon, 29 Sep 2014 15:57:49 +0000 (08:57 -0700)]
Temp fix for crash when generating 16-bit cache for colorTables.
BUG=skia:2795
R=reed@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
617443002
piotaixr [Mon, 29 Sep 2014 15:56:19 +0000 (08:56 -0700)]
Override drawImage*() in SkNWayCanvas
BUG=skia:2947
R=junov@chromium.org, reed@google.com, bsalomon@chromium.org
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
600643002
mtklein [Mon, 29 Sep 2014 15:44:46 +0000 (08:44 -0700)]
Don't test the old picture backend anymore.
This saves a bunch of CPU time in DM, and even better, lets us tear it down!
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
612603002
tfarina [Mon, 29 Sep 2014 15:16:11 +0000 (08:16 -0700)]
webtry database has more than one table.
Fix the wording in the DESIGN doc. Currently it says "the only table" as
implying the database has just a single table.
That is not true, the webtry database has four tables: webtry,
workspace, workspacetry and source_images.
BUG=None
TEST=None
R=jcgregorio@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
611763002
senorblanco [Mon, 29 Sep 2014 14:57:20 +0000 (07:57 -0700)]
Sanitize SkMatrixConvolutionImageFilter creation params.
Apply the same memory limit in the Create() function that we do when
deserializing.
R=reed@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
610723002
humper [Mon, 29 Sep 2014 14:40:41 +0000 (07:40 -0700)]
run the webtry build script instead of using go build
BUG=skia:
R=jcgregorio@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
601203002
caryclark [Mon, 29 Sep 2014 13:58:41 +0000 (06:58 -0700)]
fail on extremely large coincident curves
TBR=
BUG=418381
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
607913007
fmalita [Mon, 29 Sep 2014 13:29:53 +0000 (06:29 -0700)]
Revert of Revert of Fix SkTextBlob offset semantics. (patchset #1 id:1 of https://codereview.chromium.org/
609223003/)
Reason for revert:
Re-landing: Chromium-side fix to be landed with the roll (https://codereview.chromium.org/
607853003/)
Original issue's description:
> Revert of Fix SkTextBlob offset semantics. (patchset #2 id:20001 of https://codereview.chromium.org/
605533002/)
>
> Reason for revert:
> Breaking the Chrome builds with the error:
>
> [14:54:14.317833] ../../skia/ext/pixel_ref_utils.cc:221:16: error: 'drawPosText' marked 'override' but does not override any member functions
> [14:54:14.318022] virtual void drawPosText(const SkDraw& draw,
> [14:54:14.318082] ^
>
> Original issue's description:
> > Fix SkTextBlob offset semantics.
> >
> > Implement proper x/y drawTextBlob() handling by plumbing a
> > drawPosText() offset parameter (to act as an additional glyph pos
> > translation) throughout the device layer.
> >
> > The new offset superceeds the existing constY, with a minor semantic
> > tweak: whereas previous implementations were ignoring constY in 2D
> > positioning mode (scalarsPerGlyph == 2), now the offset is always
> > observed, in all positioning modes. We can do this because existing
> > drawPosText() clients always pass constY == 0 for full positioning mode.
> >
> > R=reed@google.com, jvanverth@google.com, robertphillips@google.com
> >
> > Committed: https://skia.googlesource.com/skia/+/
c13bc571d3e61a43b87eb97f0719abd304cafaf2
>
> TBR=jvanverth@google.com,reed@google.com,bsalomon@google.com,fmalita@chromium.org
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/
d46b8d2bab7cfba8458432248e1568ac377429e9
R=jvanverth@google.com, reed@google.com, bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com, jvanverth@google.com, reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
607413003
robertphillips [Mon, 29 Sep 2014 12:32:49 +0000 (05:32 -0700)]
Update RecordReplaceDrawTest to generate and pass pictures
This CL splits the unit test changes out of (Fix sub-picture layer rendering bugs - https://codereview.chromium.org/
597293002/).
For various reasons GrRecordReplaceDraw now needs to take an SkPicture (rather than an SkRecord and a BBH).
R=egdaniel@google.com, bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
608823002
mtklein [Mon, 29 Sep 2014 12:27:59 +0000 (05:27 -0700)]
Always force the bounds of the empty pathref.
Chrome's TSAN bots are seeing various races on the bounds of the empty
path ref, and it's a simple fix to just force them on creation. In
fact, we used to do this for this very reason, but for some reason it
looks like I decided it wasn't necessary. Maybe not, but it certainly
doesn't hurt, and it's nice to keep TSAN happy.
Reminder to self: merge this into M39 branch too.
BUG=418299
R=fmalita@chromium.org, robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
603503003
robertphillips [Mon, 29 Sep 2014 12:07:39 +0000 (05:07 -0700)]
Make pictures in multipicturedraw GM fit in 0,0..W,H range
Having the picture contents not actually reside in the 0,0..W,H range wrecks havoc with the layer hoisting. The hoisting works correctly but since the picture don't fulfill their contract the results look incorrect.
This CL just translates the picture's contents to the right so they are within the picture bound.
R=egdaniel@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
594363003
robertphillips [Mon, 29 Sep 2014 11:48:52 +0000 (04:48 -0700)]
Revert of Fix SkTextBlob offset semantics. (patchset #2 id:20001 of https://codereview.chromium.org/
605533002/)
Reason for revert:
Breaking the Chrome builds with the error:
[14:54:14.317833] ../../skia/ext/pixel_ref_utils.cc:221:16: error: 'drawPosText' marked 'override' but does not override any member functions
[14:54:14.318022] virtual void drawPosText(const SkDraw& draw,
[14:54:14.318082] ^
Original issue's description:
> Fix SkTextBlob offset semantics.
>
> Implement proper x/y drawTextBlob() handling by plumbing a
> drawPosText() offset parameter (to act as an additional glyph pos
> translation) throughout the device layer.
>
> The new offset superceeds the existing constY, with a minor semantic
> tweak: whereas previous implementations were ignoring constY in 2D
> positioning mode (scalarsPerGlyph == 2), now the offset is always
> observed, in all positioning modes. We can do this because existing
> drawPosText() clients always pass constY == 0 for full positioning mode.
>
> R=reed@google.com, jvanverth@google.com, robertphillips@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
c13bc571d3e61a43b87eb97f0719abd304cafaf2
R=jvanverth@google.com, reed@google.com, bsalomon@google.com, fmalita@chromium.org
TBR=bsalomon@google.com, fmalita@chromium.org, jvanverth@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
609223003
Justin Novosad [Fri, 26 Sep 2014 21:41:28 +0000 (17:41 -0400)]
Adding test suppression for image-surface GM
Test needs to be rebaselined on gpu
TBR=bsalomon
Review URL: https://codereview.chromium.org/
602203006
junov [Fri, 26 Sep 2014 20:09:47 +0000 (13:09 -0700)]
Change GrContext::copyTexture to go through GrDrawTarget
BUG=crbug.com/415100
R=bsalomon@google.com, robertphillips@google.com
Author: junov@chromium.org
Review URL: https://codereview.chromium.org/
607993002
tomhudson [Fri, 26 Sep 2014 18:45:48 +0000 (11:45 -0700)]
SkMatrix44::preserves2dAxisAlignment()
Convenience function requested for Chrome compositor that may have a performance
advantage.
BUG=skia:1017
R=reed@google.com, danakj@chromium.org, vollick@chromium.org
Author: tomhudson@google.com
Review URL: https://codereview.chromium.org/
508303005
piotaixr [Fri, 26 Sep 2014 14:36:26 +0000 (07:36 -0700)]
Rename SkImage::draw(_, SkRect, SkRect) in SkImage::drawRect()
BUG=skia:2947
R=reed@google.com, junov@chromium.org
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
605843002
Florin Malita [Fri, 26 Sep 2014 14:33:37 +0000 (10:33 -0400)]
Fix SkTextBlob offset semantics.
Implement proper x/y drawTextBlob() handling by plumbing a
drawPosText() offset parameter (to act as an additional glyph pos
translation) throughout the device layer.
The new offset superceeds the existing constY, with a minor semantic
tweak: whereas previous implementations were ignoring constY in 2D
positioning mode (scalarsPerGlyph == 2), now the offset is always
observed, in all positioning modes. We can do this because existing
drawPosText() clients always pass constY == 0 for full positioning mode.
R=reed@google.com, jvanverth@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/
605533002
piotaixr [Fri, 26 Sep 2014 14:10:38 +0000 (07:10 -0700)]
Replace a forgotten call to SkImage::draw() by SkCanvas::drawImageRect()
BUG=skia:2947
R=reed@google.com, junov@chromium.org
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
599203007
egdaniel [Fri, 26 Sep 2014 13:15:04 +0000 (06:15 -0700)]
Split GrDrawState and GrOptDrawState into separate classes and remove base class.
Besides splitting the two classes, there are no logical changes here and mostly moving code around.
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
597323002
tfarina [Fri, 26 Sep 2014 13:10:00 +0000 (06:10 -0700)]
Reinitialize monit to changes take effect.
Otherwise changes made to the configuration won't take effect when they
are synced.
BUG=None
TEST=None
R=jcgregorio@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
602293002
borenet [Fri, 26 Sep 2014 04:25:26 +0000 (21:25 -0700)]
Update SKP version to 112
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
604983003
senorblanco [Thu, 25 Sep 2014 22:51:35 +0000 (15:51 -0700)]
Fix SkTableColorFilter deserialization validation.
Broken in https://skia.googlesource.com/skia/+/
9fa60daad4d5f54c0dbe3dbcc7608a8f6d721187.
R=reed@google.com
TBR=reed@google.com
BUG=skia:
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
604873004
piotaixr [Thu, 25 Sep 2014 21:39:40 +0000 (14:39 -0700)]
Add doc on SkCanvas::drawImage*() methods
BUG=skia:2947
R=junov@chromium.org, reed@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
595043002
piotaixr [Thu, 25 Sep 2014 21:30:56 +0000 (14:30 -0700)]
Make SkImage::draw() private
BUG=skia:2947
R=junov@chromium.org, reed@google.com, bsalomon@chromium.org
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
608623002
Mike Klein [Thu, 25 Sep 2014 19:07:55 +0000 (15:07 -0400)]
Seems that some of our compliers can't infer this type, though most can.
BUG=skia:
Review URL: https://codereview.chromium.org/
603263002
mtklein [Thu, 25 Sep 2014 18:57:53 +0000 (11:57 -0700)]
Remove SkPaint dirty bits.
fDirtyBits is only used by SkPaint::FlatteningTraits, which in turn was
only used as a smaller, faster format to flatten paints in-memory to dedup
them in the old picture backend.
SkRecord obsoleted all this. Neither flatten()/unflatten() (disk format)
nor FlatteningTraits is used anywhere performance or size matters.
Here I revert the deduping code back to using the disk format for flattened paints.
We stil do have to flatten and unflatten paints while coverting from SkRecord
backend to the old backend, so we can't just delete this all yet, but any
faithful round trip flatten()/unflatten() pair will be fine, however slow.
NOTRY=true
BUG=skia:
R=reed@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
604813003
piotaixr [Wed, 24 Sep 2014 20:03:30 +0000 (13:03 -0700)]
SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas
BUG=skia:2947
Committed: https://skia.googlesource.com/skia/+/
432789972c1e1f8a66165c75a250dba1853efa08
R=junov@chromium.org, reed@google.com, bsalomon@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
583453002
senorblanco [Wed, 24 Sep 2014 18:09:38 +0000 (11:09 -0700)]
Fix SkXfermode deserialization.
Validation was failing due to an inverted test condition.
BUG=417266
R=reed@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
596333002
bungeman [Wed, 24 Sep 2014 18:04:41 +0000 (11:04 -0700)]
Correct glyph with non-bmp from typeface on Mac.
CTFontGetGlyphsForChars puts the glyph id at the index of the lead
surrogate as is documented in comments, but the code is looking at
the index of the trail surrogate.
BUG=skia:2960
R=mtklein@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
596413002
borenet [Wed, 24 Sep 2014 18:03:35 +0000 (11:03 -0700)]
Revert of SkCanvas::drawImage is the new way for drawing an SkImage to a Canvas (patchset #9 id:160001 of https://codereview.chromium.org/
583453002/)
Reason for revert:
Broke ChromiumOS Ozone builder: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/4087/steps/compile/logs/stdio
Reverting to unblock DEPS roll.
Original issue's description:
> SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas
>
> BUG=skia:2947
>
> Committed: https://skia.googlesource.com/skia/+/
432789972c1e1f8a66165c75a250dba1853efa08
R=junov@chromium.org, reed@google.com, bsalomon@google.com, piotaixr@chromium.org
TBR=bsalomon@google.com, junov@chromium.org, piotaixr@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2947
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
598133002
egdaniel [Wed, 24 Sep 2014 17:30:12 +0000 (10:30 -0700)]
Use OptDrawState instead of DrawState when flushing state in GrGpuGL
BUG=skia:
R=bsalomon@google.com, joshualitt@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
599963002
mtklein [Wed, 24 Sep 2014 15:59:37 +0000 (08:59 -0700)]
Swap iteration order in TileGrid::insert().
Was looking at performance here (it's the record hotspot) and noticed we
iterate through the grid out of order. This is a tiny little thing, but it's
probably orthogonal to any other performance improvements we'll make in here.
BUG=skia:
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
598933004
robertphillips [Wed, 24 Sep 2014 15:52:18 +0000 (08:52 -0700)]
Update layer hoisting code to correctly render sub-picture layers
The prior code assumed all layers came from a single picture.
BUG=skia:2315
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
595543002
Brian Salomon [Wed, 24 Sep 2014 15:41:24 +0000 (11:41 -0400)]
Revert "Use draw buffer for texture copy impl."
This reverts commit
e3d4bf234a04e14b6b0f33e11b3e1132b560c145.
Conflicts:
src/gpu/GrContext.cpp
mtklein [Wed, 24 Sep 2014 13:34:09 +0000 (06:34 -0700)]
Have nanobench --verbose mode always just print integer nanoseconds.
Don't know that anyone but me is using this. Speak up now!
BUG=skia:
NOTREECHECKS=true
R=mtklein@google.com, tfarina@chromium.org
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
599913002
borenet [Wed, 24 Sep 2014 12:31:07 +0000 (05:31 -0700)]
Revert "Add support for EGL on linux"
This reverts commit
1cea736c3280b6f0553e3eaa598e41370b305b57.
Caused segfaults on all Android devices
R=bsalomon@google.com, djsollen@google.com
TBR=bsalomon, djsollen
NOTRY=true
BUG=skia:
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
599493003
borenet [Wed, 24 Sep 2014 04:22:12 +0000 (21:22 -0700)]
Update SKP version to 110
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
595203002
derekf [Tue, 23 Sep 2014 22:17:36 +0000 (15:17 -0700)]
Add support for EGL on linux
Allow setting skia_egl=1 to build skia against EGL instead of GLX on unix
R=bsalomon@google.com, djsollen@google.com
Author: derekf@osg.samsung.com
Review URL: https://codereview.chromium.org/
543363004
piotaixr [Tue, 23 Sep 2014 21:10:50 +0000 (14:10 -0700)]
SkCanvas::drawImage is the new way for drawing a SkImage to a Canvas
BUG=skia:2947
R=junov@chromium.org, reed@google.com, bsalomon@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
583453002
Mike Klein [Tue, 23 Sep 2014 19:28:38 +0000 (15:28 -0400)]
We need to adjust the bounds of clip ops with SaveLayer paints too.
Before this CL, SkRecord only adjusted the bounds of draw ops for SaveLayers' paints.
That worked fine, but as a final step we intersect the bounds of draw ops with the
bounds of the current clip, essentially undoing all that work.
I think the right fix here is to also adjust the bounds of the clip ops.
BUG=skia:2957, 415468
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
595953002
egdaniel [Tue, 23 Sep 2014 18:04:54 +0000 (11:04 -0700)]
Remove unused fRequiresVertexShader data member from OptDrawState
BUG=skia:
R=jvanverth@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
578323003
joshualitt [Tue, 23 Sep 2014 16:50:21 +0000 (09:50 -0700)]
Patch to create a distinct geometry processor. The vast majority of this patch
is just a rename. The meat is in GrGeometryProcessor, GrProcessor,
GrGL*Processor, GrProcessorStage, Gr*BackendProcessorFactory,
GrProcessUnitTestFactory, and the builders
BUG=skia:
R=bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/
582963002
mtklein [Tue, 23 Sep 2014 16:20:13 +0000 (09:20 -0700)]
Remove underscores from mode identifiers.
Underscore is used as a field separator sometimes when parsing the task
name into a list of config, mode, etc. (This itself is dumb and TODO(mtklein): fix.)
Underscores in the field names will really mess that up, both in directories generated
from human-mode -w, and in the .json file.
BUG=skia:
R=jcgregorio@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
599503002
bsalomon [Tue, 23 Sep 2014 16:15:03 +0000 (09:15 -0700)]
Use draw buffer for texture copy impl.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
589143004
bsalomon [Tue, 23 Sep 2014 15:19:00 +0000 (08:19 -0700)]
Use uniform color/coverage inputs when path rendering.
BUG=skia:2954
R=egdaniel@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
600483002
egdaniel [Tue, 23 Sep 2014 15:14:13 +0000 (08:14 -0700)]
Fix inputCoverageIsUsed bug in GrGLProgramDesc
BUG=skia:
R=joshualitt@chromium.org
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
593803003
junov [Tue, 23 Sep 2014 14:30:09 +0000 (07:30 -0700)]
Adding support for GL_CHROMIUM_copy_texture, part 1
Part 1 of 2. This change just adds the gl API entrypoint
so that the chromium/ganesh bindings can set it. Once
the chromium part is landed, we will add full support for
the extension
BUG=crbug.com/415100
R=bsalomon@google.com
Author: junov@chromium.org
Review URL: https://codereview.chromium.org/
594663002
borenet [Tue, 23 Sep 2014 04:33:08 +0000 (21:33 -0700)]
Update SKP version to 109
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
594783002
jvanverth [Mon, 22 Sep 2014 21:26:53 +0000 (14:26 -0700)]
Fix SDF font positions when using global scale.
Also fixes a crash in the dftext GM when using SampleApp,
and adds new test case in dftext.
BUG=skia:2928
R=joshualitt@google.com, egdaniel@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
588223002
egdaniel [Mon, 22 Sep 2014 20:17:02 +0000 (13:17 -0700)]
Calculate Primary and Secondary output types in the GrOptDrawState
Follow up CL to https://codereview.chromium.org/
545693004/
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
554833002
egdaniel [Mon, 22 Sep 2014 19:29:52 +0000 (12:29 -0700)]
Change GrGLProgramDesc header to have DoPathRendering flag instead of RequiresVertexShader
Also update GLProgramTests to fix bug where it would incorrectly try to PathRendering when we did
not want to.
BUG=skia:
R=bsalomon@google.com, joshualitt@chromium.org
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
586793002
cdalton [Mon, 22 Sep 2014 19:26:41 +0000 (12:26 -0700)]
Rebaseline gm expectations after nvpr text change
BUG=skia:2951
BUG=skia:2954
R=bsalomon@google.com, borenet@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
580943003
bungeman [Mon, 22 Sep 2014 19:24:41 +0000 (12:24 -0700)]
Don't try to scale embedded bitmaps.
If a font is bitmap only we need to scale a bitmap to obtain
the requested size if there isn't an exact match. If a font has
embedded bitmaps then these bitmaps should never be scaled by Skia.
Allow FreeType to do the scaling (as requested by the font).
BUG=chromium:408059
R=mtklein@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
596513002
bsalomon [Mon, 22 Sep 2014 19:21:08 +0000 (12:21 -0700)]
Don't flush on read/write pixels unless necessary
BUG=skia:2889
Committed: https://skia.googlesource.com/skia/+/
150723b9298772a5096bec7acd2999c5c9d66239
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
586073002
mtklein [Mon, 22 Sep 2014 18:40:33 +0000 (11:40 -0700)]
Make a flipped fDirtyBit always mean "this field is not the default".
Haven't been able to measure any perf effect, so I figure I'll let the bots have at it.
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
595583003
reed [Mon, 22 Sep 2014 17:34:41 +0000 (10:34 -0700)]
remove flags that now live in chrome's SkUserConfig.h
NOTRY=True
TBR=robertphilips@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
591133003
jcgregorio [Mon, 22 Sep 2014 17:32:59 +0000 (10:32 -0700)]
Fix typo in experimental/webtry/DESIGN.md.
R=tfarina@chromium.org
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
593723003
joshualitt [Mon, 22 Sep 2014 17:29:30 +0000 (10:29 -0700)]
Proposed fix for small bug in gpu conical gradients
BUG=skia:
R=bsalomon@google.com, egdaniel@google.com, senorblanco@chromium.org
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/
593443002
bsalomon [Mon, 22 Sep 2014 16:12:11 +0000 (09:12 -0700)]
Revert of Don't flush on read/write pixels unless necessary (patchset #2 id:20001 of https://codereview.chromium.org/
586073002/)
Reason for revert:
Breaking the tree
Original issue's description:
> Don't flush on read/write pixels unless necessary
>
> BUG=skia:2889
>
> Committed: https://skia.googlesource.com/skia/+/
150723b9298772a5096bec7acd2999c5c9d66239
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2889
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
594543004
bsalomon [Mon, 22 Sep 2014 15:17:02 +0000 (08:17 -0700)]
Don't flush on read/write pixels unless necessary
BUG=skia:2889
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
586073002
reed [Mon, 22 Sep 2014 14:29:03 +0000 (07:29 -0700)]
Introduce Props to surface (patchset #27 id:520001 of https://codereview.chromium.org/
551463004/)"
This reverts commit
29c857d0f3a1cb837f73406eeb6ba9771879b5e7.
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/
588143004
piotaixr [Mon, 22 Sep 2014 13:01:37 +0000 (06:01 -0700)]
Cleaning includes in SkImage-related files
BUG=skia:2948
R=junov@chromium.org, tfarina@chromium.org, reed@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
586853003
borenet [Mon, 22 Sep 2014 03:37:57 +0000 (20:37 -0700)]
Update SKP version to 108
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
586403002
reed [Sun, 21 Sep 2014 17:25:07 +0000 (10:25 -0700)]
Revert of introduce Props to surface (patchset #27 id:520001 of https://codereview.chromium.org/
551463004/)
Reason for revert:
Broke call site in WebKit
Original issue's description:
> introduce Props to surface (work in progress)
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
3716fd067a5621bb94a6cb08d72afec8bf3aceda
R=robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, bungeman@google.com, fmalita@google.com, vangelis@chromium.org, reed@google.com
TBR=bsalomon@google.com, bungeman@google.com, fmalita@google.com, jvanverth@google.com, reed@google.com, robertphillips@google.com, vangelis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
583773004
reed [Sun, 21 Sep 2014 16:39:55 +0000 (09:39 -0700)]
introduce Props to surface (work in progress)
BUG=skia:
R=robertphillips@google.com, bsalomon@google.com, jvanverth@google.com, bungeman@google.com, fmalita@google.com, vangelis@chromium.org, reed@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
551463004
borenet [Sun, 21 Sep 2014 04:15:07 +0000 (21:15 -0700)]
Update SKP version to 107
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
585313002
fmalita [Sat, 20 Sep 2014 12:40:22 +0000 (05:40 -0700)]
Souped-up SkTextBlob.
Refactored text blob backend for improved performance: instead of using
separate buffers for runs/positions/glyphs, everything is now packed in
a consolidated slab (including the SkTextBlob object itself!).
Benefits:
* number of allocations per blob construction reduced from ~4 to 1
(also minimizes internal fragmentation)
* run record size reduced by 8 bytes
This takes the blob construction overhead down to negligible levels
(for the current Blink uncached textblob implementation).
Unfortunately, the code is much more finicky (run merging in
particular) -- hence the assert spree.
Multi-run blobs are vulnerable to realloc storms but this is not a
problem at the moment because Blink is using one-run blobs 99% of the
time. Will be addressed in the future.
R=mtklein@google.com, reed@google.com, robertphillips@google.com
Committed: https://skia.googlesource.com/skia/+/
13645ea0ea87038ebd71be3bd6d53b313069a9e4
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
581173003
borenet [Sat, 20 Sep 2014 04:12:50 +0000 (21:12 -0700)]
Update SKP version to 106
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
590643003
fmalita [Sat, 20 Sep 2014 02:03:06 +0000 (19:03 -0700)]
Revert of Souped-up SkTextBlob. (patchset #3 id:40001 of https://codereview.chromium.org/
581173003/)
Reason for revert:
Broke the new blobshader gm.
Original issue's description:
> Souped-up SkTextBlob.
>
> Refactored text blob backend for improved performance: instead of using
> separate buffers for runs/positions/glyphs, everything is now packed in
> a consolidated slab (including the SkTextBlob object itself!).
>
> Benefits:
>
> * number of allocations per blob construction reduced from ~4 to 1
> (also minimizes internal fragmentation)
> * run record size reduced by 8 bytes
>
> This takes the blob construction overhead down to negligible levels
> (for the current Blink uncached textblob implementation).
>
> Unfortunately, the code is much more finicky (run merging in
> particular) -- hence the assert spree.
>
> Multi-run blobs are vulnerable to realloc storms but this is not a
> problem at the moment because Blink is using one-run blobs 99% of the
> time. Will be addressed in the future.
>
>
> R=reed@google.com,mtklein@google.com,robertphillips@google.com
>
> Committed: https://skia.googlesource.com/skia/+/
13645ea0ea87038ebd71be3bd6d53b313069a9e4
R=mtklein@google.com, reed@google.com, robertphillips@google.com
TBR=mtklein@google.com, reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
588853002
fmalita [Sat, 20 Sep 2014 01:37:00 +0000 (18:37 -0700)]
Souped-up SkTextBlob.
Refactored text blob backend for improved performance: instead of using
separate buffers for runs/positions/glyphs, everything is now packed in
a consolidated slab (including the SkTextBlob object itself!).
Benefits:
* number of allocations per blob construction reduced from ~4 to 1
(also minimizes internal fragmentation)
* run record size reduced by 8 bytes
This takes the blob construction overhead down to negligible levels
(for the current Blink uncached textblob implementation).
Unfortunately, the code is much more finicky (run merging in
particular) -- hence the assert spree.
Multi-run blobs are vulnerable to realloc storms but this is not a
problem at the moment because Blink is using one-run blobs 99% of the
time. Will be addressed in the future.
R=mtklein@google.com, reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
581173003
piotaixr [Fri, 19 Sep 2014 20:30:06 +0000 (13:30 -0700)]
Get rid of SkImage_Codec
Use SkImage_Raster with an ImageGenerator instead.
BUG=skia:2948
R=junov@chromium.org, reed@google.com, bsalomon@chromium.org
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
589713002
jvanverth [Fri, 19 Sep 2014 20:07:38 +0000 (13:07 -0700)]
Don't try to add large glyphs to the font atlas.
When the glyph data is invalid we can try to allocate a ridiculous amount of memory. This adds a check to cover such cases.
BUG=414581
R=egdaniel@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
585853003
reed [Fri, 19 Sep 2014 20:04:17 +0000 (13:04 -0700)]
enable conservative clips for gpudevice
TBR=bsalomon
Author: reed@google.com
Review URL: https://codereview.chromium.org/
587793003
egdaniel [Fri, 19 Sep 2014 19:07:43 +0000 (12:07 -0700)]
Add UniqueID to GrDrawTargetCaps.
This is needed for creating the Optimized Draw State and checking that we have the same caps
on subsequent calls to ODS
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
585043002
bsalomon [Fri, 19 Sep 2014 18:48:02 +0000 (11:48 -0700)]
Move IOType to GrGpuRef and rename that to GrIORef. Template GrPendingIORef on IOType.
BUG=skia:2889
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
579403003
fmalita [Fri, 19 Sep 2014 18:40:51 +0000 (11:40 -0700)]
SkTextBlob shader space workaround.
Blink would like drawTextBlob(x,y) to behave the same as drawText(x,y)
WRT shader space. Due to the current generic device base impl, that is
not the case.
This is a transitional workaround, pending proper drawTextBlob impls
in SkDevice classes.
R=reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
586743002
robertphillips [Fri, 19 Sep 2014 18:30:37 +0000 (11:30 -0700)]
Fix memory leak in MultiPictureDraw GM
R=fmalita@google.com, fmalita@chromium.org
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
585033002
cdalton [Fri, 19 Sep 2014 18:12:46 +0000 (11:12 -0700)]
Fix stack-allocated GPU path object
Fixes nvpr text to dynamically allocate its template path object, as
per the Skia policy.
BUG=skia:
R=robertphillips@google.com, bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
582033003
bsalomon [Fri, 19 Sep 2014 18:10:40 +0000 (11:10 -0700)]
Make GrIODB keep pending IO refs on all resources it records into its cmd stream.
BUG=skia:2889
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
581123002
mtklein [Fri, 19 Sep 2014 17:35:07 +0000 (10:35 -0700)]
Add a "mode" tag to key in DM json output.
This lets us distinguish the original ("direct") runs from their replay modes.
There was a bit of a bug in here now fixed: we used the first entry in
fSuffixes as the config. Actually, the last entry in suffixes is the
config. This is moot when there's only one suffix (direct drawing), but
for mode drawing we were recording the mode as config! Now it's correct.
Here's some example output where I rigged a bunch of modes to fail:
{
"results" : [
{
"key" : {
"config" : "565",
"mode" : "default-nobbh",
"name" : "xfermodes2"
},
"md5" : "
2daf6f7e2b8e56543b92068a10d2179e",
"options" : {
"source_type" : "GM"
}
},
{
"key" : {
"config" : "8888",
"mode" : "default-nobbh",
"name" : "xfermodes2"
},
"md5" : "
490361e8a52800d29558bc23876da8c6",
"options" : {
"source_type" : "GM"
}
},
...
{
"key" : {
"config" : "565",
"mode" : "direct",
"name" : "xfermodes2"
},
"md5" : "
92a3801d5914d6c2662904a3bb50d2b9",
"options" : {
"source_type" : "GM"
}
},
...
{
"key" : {
"config" : "8888",
"mode" : "direct",
"name" : "xfermodes2"
},
"md5" : "
e7e8b3e9d31e601acaaff4633ed5f63a",
"options" : {
"source_type" : "GM"
}
},
BUG=skia:
R=jcgregorio@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
586533005
robertphillips [Fri, 19 Sep 2014 15:56:09 +0000 (08:56 -0700)]
Extend MultiPictureDraw GM
This new GM case is intended to exercise the matrix oriented aspects of layer caching.
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
582113004
bsalomon [Fri, 19 Sep 2014 14:47:08 +0000 (07:47 -0700)]
Stop calling rand() in debug-only code for GLProgramsTest
R=egdaniel@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
584913002
jvanverth [Fri, 19 Sep 2014 13:46:09 +0000 (06:46 -0700)]
Add ignored expectation for https://codereview.chromium.org/
563283004.
BUG=skia:2951
R=bsalomon@google.com
TBR=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
585943002
caryclark [Fri, 19 Sep 2014 13:33:31 +0000 (06:33 -0700)]
fail early if coincidence can't be resolved
Bail out if a very large value causes coincidence resolution to
fail.
TBR=
BUG=415866
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
585913002
reed [Fri, 19 Sep 2014 12:56:29 +0000 (05:56 -0700)]
remove RenderTargetFlags -- NewRenderTargetDirect will never clear
BUG=skia:
R=robertphillips@google.com, bsalomon@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
583043002
borenet [Fri, 19 Sep 2014 04:27:26 +0000 (21:27 -0700)]
Update SKP version to 105
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
580263003
bungeman [Thu, 18 Sep 2014 20:57:20 +0000 (13:57 -0700)]
Restore old behavior of SkTypeface::CreateFromTypeface.
This reverts
https://skia.googlesource.com/skia/+/
9db509272a6fa2badbbdd2f5afce827370960a5f
and completes
https://skia.googlesource.com/skia/+/
f91c47d91d72a1d85e2d6701864b8d7accc81647 .
R=caryclark@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
586473002
reed [Thu, 18 Sep 2014 20:57:05 +0000 (13:57 -0700)]
check for failed file->data (fails on mac)
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/
581263002
robertphillips [Thu, 18 Sep 2014 20:52:08 +0000 (13:52 -0700)]
Add counting of some GL calls
I would like this facility for tracking FBO switch improvements.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
553583008
cdalton [Thu, 18 Sep 2014 20:51:53 +0000 (13:51 -0700)]
Uses a single pre-baked set of paths for drawing nvpr text of a given
typeface. Loads the paths using the driver's glyph loading routines.
Refactors GrPathRange to accept a PathGenerator class that it uses to
lazily initialize its paths. The client code is no longer expected to
initialize the paths in a GrPathRange; instead it must provide a
PathGenerator* instance to createPathRange().
Adds a new createGlyphs() method to GrPathRendering that creates a
range of glyph paths, indexed by glyph id. GrPathRendering implements
createGlyphs() with a PathGenerator that loads glyph paths using the
skia frameworks. GrGLPathRendering uses glMemoryGlyphIndexArrayNV()
instead, when possible, to load the glyph paths.
Removes all GlyphPathRange logic from GrStencilAndCoverTextContext.
It instead uses createGlyphs().
BUG=skia:2939
R=bsalomon@google.com, jvanverth@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
563283004
reed [Thu, 18 Sep 2014 20:36:11 +0000 (13:36 -0700)]
remove no-op override
NOTREECHECKS=True
NOTRY=True
R=egdaniel@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
586463002
joshualitt [Thu, 18 Sep 2014 19:26:38 +0000 (12:26 -0700)]
Changes to remove program effects builder
BUG=skia:
R=bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/
551253004