Michal Strehovský [Fri, 17 May 2019 03:23:04 +0000 (20:23 -0700)]
Add support for invariant casing in PAL (#24597)
unicodedata.cpp based on UnicodeData.txt v11.0.
Sung Yoon Whang [Fri, 17 May 2019 03:16:01 +0000 (20:16 -0700)]
Add runtime counter for TP work items produced (#24618)
Anirudh Agnihotry [Fri, 17 May 2019 03:15:05 +0000 (20:15 -0700)]
Correcting documentation for span and memory slice (#24612)
Sinan Kaya [Fri, 17 May 2019 03:03:58 +0000 (23:03 -0400)]
compilation fixes (#24613)
Levi Broderick [Fri, 17 May 2019 03:02:48 +0000 (20:02 -0700)]
Fix parameter names in ToUtf16 (#24617)
Jeremy Koritzinsky [Fri, 17 May 2019 00:40:23 +0000 (17:40 -0700)]
Add Managed->Native tests for our WinRT primitives (#23529)
* First pass generating the contracts for the WinRT tests. Managed ones are manually written, Native are generated via C++/WinRT.
* Don't overwrite the public implementation files when we run cppwinrt
* Don't output a MIDL-processed header.
* Add default constructor for BindingViewModel.
* Partial implementation of most of the native winrt component.
* Finish implementation of native winrt component.
* Get native component building correctly (cppwinrt doesn't include wrappers for the "Windows::UI::Xaml::Interop::IBindable*" collection types.
* Add WinRT primitive marshalling tests.
* Add testing for projected types used for binding.
* Add license headers to native files.
* Disable WinRT tests on non-WinRT platforms (detection copied from CoreFX).
* Use WINDOWS_SDK_VERSION variable in all locations.
* Use Windows SDK version determined by CMake in WinRT build.
* Resolve WinMDs via globs so the build can roll between different Windows SDK versions that have required APIs seamlessly.
* Add logging of cppwinrt version.
* Try to construct path to cppwinrt when finding it
* Just directly construct the cppwinrt path.
* Remove -prefix flag from cppwinrt invocation
* PR feedback.
* Fix syntax in BindableVectorWrapper.
* Disable winrt binding test on Nano Server.
* Add enum testing. Clean up WinRT tests to hopefully build on CI (or at least fail at a later point).
* Add some more logging to try to determine why an older SDK version is being picked.
* Try to define CMAKE_SYSTEM_VERSION and see if that selects the correct SDK version (it seems to work on the build.cmd script)
* Clean up WinRT CMake now that it builds on AzDO CI.
* Disable WinRT binding test on pre-Win10V1809 systems.
Michal Strehovský [Thu, 16 May 2019 18:55:42 +0000 (11:55 -0700)]
Delete iswxdigit test (#24608)
Tarek Mahmoud Sayed [Thu, 16 May 2019 17:53:08 +0000 (10:53 -0700)]
Fix Handling time patterns with quotes (#24589)
We encountered some cultures have a time patterns with single quotes which we should handle keeping the parts between quotes as fixed text inside the pattern and not treat it as any of the time specifiers
Jeremy Koritzinsky [Thu, 16 May 2019 17:39:33 +0000 (10:39 -0700)]
Split the phases of EEClassLayoutInfo::CollectLayoutFieldMetadataThrowing (#23013)
* Split the phases of EEClassLayoutInfo::CollectLayoutFieldMetadataThrowing into separate private static functions.
* Combine native and managed-sequential field offset and size calculations (since they are the exact same algorithm)
* Remove TypeLayoutHelper because it's was only used in CalculateSizeAndFieldOffsets after having combined the offset/size calculations.
* Remove unused members in LayoutRawFieldInfo.
* Comment boolean parameter.
* Add comments to parameters.
* Remove unused prototypes.
* Make sure we consistently use managed in the managed paths and native in the native paths.
* Add to m_numCTMFields instead of setting it (need to make sure we account for fields in a non-trivial parent).
* Track native alignment in a field.
* Refactor field placement info to remove lots of repeated branching.
* PR Feedback.
dotnet-maestro[bot] [Thu, 16 May 2019 17:09:31 +0000 (10:09 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190515.11 (#24605)
- Microsoft.NETCore.App - 3.0.0-preview6-27715-11
Carol Eidt [Thu, 16 May 2019 16:25:00 +0000 (09:25 -0700)]
Ensure that SIMD fields are correctly typed (#24377)
When a struct field is imported, its type needs to be normalized.
Also, the LHS of a struct init, even if a SIMD type, should not be transformed to a non-block node,
except in the case of a SIMD local, in which case it must be transformed to a simple assignment.
Also, add an assert to catch this kind of bug in liveness.
Fix #24336
Fadi Hanna [Thu, 16 May 2019 14:19:31 +0000 (07:19 -0700)]
Suppress crossgen warnings on failures to load types/methods from IBC data. (#24596)
It's not unusual to see these types of warnings with incremental IBC.
These warnings will move under the crossgen verbose mode.
Levi Broderick [Thu, 16 May 2019 06:15:23 +0000 (23:15 -0700)]
Make Label and OpCode readonly and IEquatable (#24360)
Egor Chesakov [Thu, 16 May 2019 02:25:33 +0000 (19:25 -0700)]
Merge pull request #24603 from dotnet/revert-24554-UnconditionallyCaptureXUnitOutput
Revert "Unconditionally capture output of xUnit tests"
Egor Chesakov [Thu, 16 May 2019 02:23:05 +0000 (19:23 -0700)]
Revert "Unconditionally capture output of xUnit tests"
Andrew Au [Wed, 15 May 2019 23:00:17 +0000 (16:00 -0700)]
Avoid doing dangerous cleanup in case of process detach
David Wrighton [Thu, 16 May 2019 01:28:42 +0000 (18:28 -0700)]
Remove concept of AppDomains from the GC (#24536)
* Remove concept of AppDomains from the GC
- Leave constructs allowing for multiple handle tables, as scenarios for that have been proposed
- Remove FEATURE_APPDOMAIN_RESOURCE_MONITORING
Sergey Andreenko [Thu, 16 May 2019 01:20:40 +0000 (18:20 -0700)]
Merge pull request #24590 from sandreenko/deleteJitOpts
Delete JitOptions struct.
Andrew Au [Tue, 14 May 2019 20:59:17 +0000 (13:59 -0700)]
Make sure variable live range for prolog is reported first
Michal Strehovský [Wed, 15 May 2019 23:43:26 +0000 (16:43 -0700)]
Delete unicode API emulator (#24581)
Egor Chesakov [Wed, 15 May 2019 23:33:18 +0000 (16:33 -0700)]
Unconditionally capture output of xUnit tests (#24554)
Egor Chesakov [Wed, 15 May 2019 23:32:41 +0000 (16:32 -0700)]
Enable JIT\superpmi\superpmicollect on Linux and macOS (#24560)
* Replace backslashes with forward slashes in tests/src/JIT/superpmi/TestProjects.txt
* Enable JIT\superpmi\superpmicollect.csproj on Linux and macOS
Sergey Andreenko [Wed, 15 May 2019 22:13:41 +0000 (15:13 -0700)]
delete JitOptions struct.
That was an old struct and probably nobody remembers how it was supposed to be used.
Egor Chesakov [Wed, 15 May 2019 21:52:31 +0000 (14:52 -0700)]
Fix memory corruption in GetResultFileName in SuperPMI (#24537)
Egor Chesakov [Wed, 15 May 2019 21:49:36 +0000 (14:49 -0700)]
Before calling getModuleAssembly and getClassModule check whether s_pJitDisasmIncludeAssembliesList is non empty in src/jit/compiler.cpp (#24488)
dotnet-maestro[bot] [Wed, 15 May 2019 20:20:17 +0000 (13:20 -0700)]
[master] Update dependencies from dotnet/core-setup (#24149)
* Update dependencies from https://github.com/dotnet/core-setup build
20190429.07
- Microsoft.NETCore.App - 3.0.0-preview6-27629-07
* Workaround for https://github.com/dotnet/core-setup/pull/5893
* Update dependencies from https://github.com/dotnet/core-setup build
20190502.01
- Microsoft.NETCore.App - 3.0.0-preview6-27702-01
* Update dependencies from https://github.com/dotnet/core-setup build
20190503.02
- Microsoft.NETCore.App - 3.0.0-preview6-27703-02
* Update dependencies from https://github.com/dotnet/core-setup build
20190503.17
- Microsoft.NETCore.App - 3.0.0-preview6-27703-17
* Update dependencies from https://github.com/dotnet/core-setup build
20190505.02
- Microsoft.NETCore.App - 3.0.0-preview6-27705-02
* Update dependencies from https://github.com/dotnet/core-setup build
20190506.03
- Microsoft.NETCore.App - 3.0.0-preview6-27706-03
* Update dependencies from https://github.com/dotnet/core-setup build
20190506.21
- Microsoft.NETCore.App - 3.0.0-preview6-27706-21
* Update dependencies from https://github.com/dotnet/core-setup build
20190507.10
- Microsoft.NETCore.App - 3.0.0-preview6-27707-10
* Workaround for Microsoft.NetCore.App version in Coreclr.TestWrapper.csproj to unblock #24149
* Update dependencies from https://github.com/dotnet/core-setup build
20190508.04
- Microsoft.NETCore.App - 3.0.0-preview6-27708-04
* Add comment attaching specific pull request to workaround
* Update dependencies from https://github.com/dotnet/core-setup build
20190509.05
- Microsoft.NETCore.App - 3.0.0-preview6-27709-05
* Add comments in versions.props to prevent merge conflicts in future blocked maestro PRs
* Update dependencies from https://github.com/dotnet/core-setup build
20190514.15
- Microsoft.NETCore.App - 3.0.0-preview6-27714-15
Fadi Hanna [Wed, 15 May 2019 19:19:26 +0000 (12:19 -0700)]
Fix bug where crossgen would throw OOM when given an input with no dir-separator characters (overflow bug) (#24559)
Fadi Hanna [Wed, 15 May 2019 19:18:19 +0000 (12:18 -0700)]
Making crossgen throw when compiling with the PartialNgen flag and no IBC data (#24557)
* Making crossgen throw when compiling with the PartialNgen flag and no IBC data
* Adding missing m_fPartialNGen check
Mike McLaughlin [Wed, 15 May 2019 17:50:35 +0000 (10:50 -0700)]
Update xplat-minidump-generation.md
Fix COMPlus_DbgMiniDumpType values
dotnet-maestro[bot] [Wed, 15 May 2019 15:27:23 +0000 (08:27 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190514.9 (#24586)
- Microsoft.NETCore.Platforms - 3.0.0-preview6.19264.9
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview6.19264.9
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview6.19264.9
Koundinya Veluri [Wed, 15 May 2019 05:26:37 +0000 (22:26 -0700)]
Enable QuickJit by default (#24576)
- Recently, a decision was made to enable QuickJit by default. In startup perf, this mode appears to be consistently better than with QuickJit disabled, and usually equal or better than with TieredCompilation disabled.
- QuickJitForLoops remains disabled by default, so this enables QuickJit only for methods that don't contain loops
dotnet-maestro[bot] [Wed, 15 May 2019 05:22:35 +0000 (22:22 -0700)]
[master] Update dependencies from dotnet/corefx (#24521)
* Update dependencies from https://github.com/dotnet/corefx build
20190513.9
- Microsoft.NETCore.Platforms - 3.0.0-preview6.19263.9
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview6.19263.9
* Add dependency flow for Microsoft.Bcl.AsyncInterfaces
Adeel Mujahid [Wed, 15 May 2019 05:08:06 +0000 (08:08 +0300)]
Switch to zero-length array in otherwise empty class (#24370)
Flexible array is a feature of ISO C99, that ISO C++ has not
([yet](https://thephd.github.io/vendor/future_cxx/papers/d1039.html))
included. Therefore clang and gcc with `-fpedantic` and msvc with
`/Wall` warn about it, and are equally unhappy when flexible array is
used in C++ code.
The exception in CoreCLR is `FastTable` class, where there is only one
member which is a flexible array. The length of array is written at a
specific offset of contents array.
gcc 6+ does not like this particular case, and gives a fatal error that
cannot be suppressed by regular means (`-Wno-XXX`):
```
error: flexible array member FastTable::contents in an otherwise empty class FastTable
size_t contents[];
^
```
Fix is to either not wrap this single field in concrete data structure
or use a zero-length array instead, which produces same assembly code
as the flexible array; tested with clang, gcc and msvc.
Read about this fix here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69550
Jan Kotas [Wed, 15 May 2019 02:07:53 +0000 (19:07 -0700)]
Fix issues reported by PREfast static analysis tool (#24577)
Steve MacLean [Wed, 15 May 2019 00:34:39 +0000 (20:34 -0400)]
Stack size override (#24532)
Add ability to override stack size on all platforms
* Add DEFAULT_STACK_SIZE property
* Make environment variable affect all platforms
Egor Chesakov [Tue, 14 May 2019 23:31:29 +0000 (16:31 -0700)]
Decorate SuperPMI DllMain jitStartup getJit with DLLEXPORT (#24508)
* Decorate DllMain with DLLEXPORT in superpmi-shim-collector.cpp superpmi-shim-counter.cpp superpmi-shim-simple.cpp
* Decorate jitStartup, getJit, sxsJitStartup with DLLEXPORT in superpmi-shim-collector.cpp superpmi-shim-counter.cpp superpmi-shim-simple.cpp
Jeremy Koritzinsky [Tue, 14 May 2019 23:08:07 +0000 (16:08 -0700)]
Add explicit cmake dependency between clretwrc and eventing_headers. (#24575)
Koundinya Veluri [Tue, 14 May 2019 22:10:17 +0000 (15:10 -0700)]
Fix a contract violation in ThreadPool.get_CompletedWorkItemCount (#24535)
Fix a contract violation in ThreadPool.get_CompletedWorkItemCount
Fixes https://github.com/dotnet/coreclr/issues/24515
- Looks like the path that acquires the thread store lock has code that is marked witH GC_TRIGGERS
- Changed ThreadPool.get_CompletedWorkItemCount and Monitor.get_LockContentionCount to use QCalls instead of FCalls
Andrew Au [Mon, 6 May 2019 23:50:30 +0000 (16:50 -0700)]
Log the real command line in case the process is started as a service
Jeremy Koritzinsky [Tue, 14 May 2019 20:54:29 +0000 (13:54 -0700)]
Disable IJW tests on ARM32 (#24570)
Jan Kotas [Tue, 14 May 2019 20:51:34 +0000 (13:51 -0700)]
Fix Type.GetCustomAttributes for multiple instances of the same attribute (#24474)
Fixes dotnet/corefx#37261
Sergey Andreenko [Tue, 14 May 2019 17:54:58 +0000 (10:54 -0700)]
Merge pull request #24553 from sandreenko/excludeTestsThatAreFailingUnderGCStress
Exclude tests that are failing under gc stress
Carol Eidt [Tue, 14 May 2019 16:42:06 +0000 (09:42 -0700)]
Fix more save/restore code for HVAs (#24434)
Fix OnHijackTripThread.
Re-enable the mandelbrot-7 test.
Fix #24224
Tomáš Rylek [Tue, 14 May 2019 16:40:46 +0000 (09:40 -0700)]
Further improvements for R2RDump robustness in the presence of bugs (#24429)
Based on JanV's suggestion I have added checks for token ranges
to MetadataNameFormatter to make it resilient towards invalid
tokens.
Thanks
Tomas
dotnet-maestro[bot] [Tue, 14 May 2019 15:26:58 +0000 (15:26 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190510.1 (#24522)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190510.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190510.1
Sergey Andreenko [Mon, 13 May 2019 19:16:37 +0000 (12:16 -0700)]
Disable _il_relu_fld under GCStress.
The issue is https://github.com/dotnet/coreclr/issues/24464
Sergey Andreenko [Mon, 13 May 2019 19:19:12 +0000 (12:19 -0700)]
Disable versionbubbles under GCStress.
The issue is https://github.com/dotnet/coreclr/issues/22245
Sergey Andreenko [Tue, 14 May 2019 05:00:02 +0000 (22:00 -0700)]
Merge pull request #24551 from sandreenko/disable_eventsourcetrace_in_jitstress
Exclude eventsourcetrace from jitstress runs.
David Mason [Tue, 14 May 2019 04:40:29 +0000 (21:40 -0700)]
Profiler API to request ReJIT with inliners (#24461)
This API is necessary for attaching profilers to be able to ReJIT methods and replace everything that uses the old IL.
Aaron Robinson [Tue, 14 May 2019 00:57:00 +0000 (17:57 -0700)]
Fix broken XML
Jan Kotas [Tue, 14 May 2019 02:58:23 +0000 (19:58 -0700)]
Delete InternalCasingHelper (#24511)
The unmanaged runtime has number of different paths for case-insensitive operations, each with unique issues. This is replacing InternalCasingHelper with SString to reduce number of different paths for case-insensitive operations that need to be maintained.
Contributes to #20616
Jan Vorlicek [Tue, 14 May 2019 01:50:15 +0000 (18:50 -0700)]
Merge pull request #24524 from janvorli/fix-encode-field
Fix field signature generation
Jan Vorlicek [Tue, 14 May 2019 01:44:08 +0000 (18:44 -0700)]
Merge pull request #24523 from janvorli/fix-constraint-module-override
Add module override for constraint type in method
Steve MacLean [Tue, 14 May 2019 01:10:50 +0000 (21:10 -0400)]
RemoveThrowMessage (#24563)
Aaron Robinson [Mon, 13 May 2019 23:41:59 +0000 (16:41 -0700)]
Was too aggressive with changes to PackageOutputPath property.
- This represents this repo's generated packages rather than
packages it consumes.
Aaron Robinson [Mon, 13 May 2019 21:17:00 +0000 (14:17 -0700)]
The PackagesDir property is used in places that expected a trailing slash.
Ludovic Henry [Mon, 13 May 2019 20:15:05 +0000 (13:15 -0700)]
Implement GC.GetTotalAllocatedBytes (#23852)
* keep what's allocated so far on each heap
* Implement GC.GetTotalAllocatedBytes
It is based on https://github.com/dotnet/corefx/issues/34631 and https://github.com/dotnet/corefx/issues/30644
* Fixing races related to dead_threads_non_alloc_bytes
* separated per-heap SOH and LOH counters. Different locks imply that we need different counters.
* allow/ignore torn 64bit reads on 32bit in imprecise mode.
* PR feedback
* simplified the test a little to avoid OOM on ARM
Egor Chesakov [Mon, 13 May 2019 19:24:05 +0000 (12:24 -0700)]
Unconditionally capture output of xUnit tests
Sergey Andreenko [Mon, 13 May 2019 19:11:31 +0000 (12:11 -0700)]
Disable tests that are failing with timeouts.
See examples in https://dev.azure.com/dnceng/public/_build/results?buildId=186855&view=ms.vss-test-web.build-test-results-tab
Sergey Andreenko [Mon, 13 May 2019 17:55:16 +0000 (10:55 -0700)]
exclude eventsourcetrace from jitstress runs.
Gleb Balykov [Mon, 13 May 2019 17:14:28 +0000 (20:14 +0300)]
Fix build error for mscoree coreclr.exports (#24547)
This partially reverts #23853
Aaron Robinson [Mon, 13 May 2019 00:23:51 +0000 (17:23 -0700)]
Cleanup some build files (#24539)
* Remove OsEnvironment, PackagesDir, and CoreCLRBinDir properties
* Replace usage of __BuildArch with BuildArch
* Simplify test timing out on ARM64
Yoh Deadfall [Sun, 12 May 2019 14:20:49 +0000 (17:20 +0300)]
Fixed link to .NET Core SDK (#24544)
Dan Moseley [Sun, 12 May 2019 00:14:56 +0000 (17:14 -0700)]
Update UsingYourBuild.md (#24389)
Change MyGet to the custom feeds. I found that for dotnet new console to restore, I needed an ASP.NET feed as well.
Tanner Gooding [Sat, 11 May 2019 03:19:26 +0000 (20:19 -0700)]
Fixing S.P.Corelib to not double include files and ensure that S.N.V is marked #nullable enable (#24526)
* Changing EnableDefaultCompileItems=false to EnableDefaultItems=false
* Taking the VS auto-fixes for the solution and corelib csproj
* Removing the duplicated T4 file includes in the main csproj
* Regenerating the included T4 templates
* Fixing S.P.Corelib to properly list available platforms/configurations
* Add a comment on the T4 template service
Sung Yoon Whang [Fri, 10 May 2019 23:59:38 +0000 (16:59 -0700)]
Fix EventCounter disable logic (#24519)
Koundinya Veluri [Fri, 10 May 2019 23:59:20 +0000 (16:59 -0700)]
Disable a tail call test when using minopts (#24426)
Disable a tail call test when using minopts
Fixes https://github.com/dotnet/coreclr/issues/24424
Jeremy Koritzinsky [Fri, 10 May 2019 23:24:42 +0000 (16:24 -0700)]
Move EventProvider native layout to be driven by CMake configure (#24478)
* Generate eventpipe implementation as part of CMake configure.
* Generate Etw provider as part of CMake configure.
* First pass porting over lttng provider to cmake.
* Fix up CMake Lttng provider generation.
* Move Lttng provider into CMake tree.
* Move dummy event provider to CMake
* Move genEventing into the CMake tree.
* Remove extraneous logging and unused python locator.
* Clean up build.sh
* Clean up genEventingTests.py
* Add dependencies to enable more incremental builds (providers not fully incremental).
* Convert to custom command and targets instead of at configure time.
* Get each eventing target to incrementally build.
* Fix incremental builds
* Add missing dependencies on eventing headers.
* PR Feedback. Mark all generated files as generated
* Clean up eventprovider test CMakeLists
Jeremy Koritzinsky [Fri, 10 May 2019 23:22:02 +0000 (16:22 -0700)]
Re-enable accidentally disabled tests. (#24531)
Jeremy Koritzinsky [Fri, 10 May 2019 23:20:14 +0000 (16:20 -0700)]
Reenable IJW tests. (#24530)
Aaron Robinson [Fri, 10 May 2019 21:07:11 +0000 (14:07 -0700)]
Properly set the nuget cache for the repo (#24505)
* Properly set the nuget cache for the repo
* Change coreclr NuGet package cache from "./packages" to "./.packages"
Andrew Au [Fri, 10 May 2019 16:30:23 +0000 (09:30 -0700)]
Remove obsolete comments
Jan Vorlicek [Fri, 10 May 2019 16:05:11 +0000 (18:05 +0200)]
Fix field signature generation
The ZapSig::EncodeField was missing similar treatment that was made to
the encodeMethod in the past for enabling large version bubble. We
should encode all fields as field defs and the module override at the
beginning of the fixup signature is computed with that assumption.
The issue was that we were storing memberrefs in some cases and the
module override made them invalid.
It fixes a corefx test that was failing due to this when crossgen-ed
with large version bubble enabled.
Jan Vorlicek [Fri, 10 May 2019 15:59:04 +0000 (17:59 +0200)]
Add module override for constraint type in method
The constraint type for method signature encoding was missing module
zapsig when it was needed.
Stephen Toub [Fri, 10 May 2019 13:18:53 +0000 (09:18 -0400)]
Tweak a few nullable annotations (#24494)
- Assembly.ToString() won't return null
- Several attributes have the intent that their arguments are non-nullable, even though they don't check and throw; the annotations should match the intent in such cases.
dotnet-maestro[bot] [Fri, 10 May 2019 03:46:14 +0000 (20:46 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190509.1 (#24495)
- Microsoft.NETCore.Platforms - 3.0.0-preview6.19259.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview6.19259.1
Stephen Toub [Thu, 9 May 2019 21:21:48 +0000 (17:21 -0400)]
Fix netstandard build for nullable annotations
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Stephen Toub [Thu, 9 May 2019 19:25:49 +0000 (15:25 -0400)]
Fix netfx build with nullable annotations
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Dan Moseley [Fri, 10 May 2019 03:43:00 +0000 (20:43 -0700)]
Dead string (#24516)
dotnet-maestro[bot] [Fri, 10 May 2019 03:42:35 +0000 (20:42 -0700)]
[master] Update dependencies from dnceng/internal/dotnet-optimization (#24473)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190509.1
- optimization.IBC.CoreCLR - 99.99.99-master-
20190509.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190509.1
Sung Yoon Whang [Fri, 10 May 2019 03:30:39 +0000 (20:30 -0700)]
Fix an overflow issue with eventpipe buffer size (#24512)
Leslie Zhai [Fri, 10 May 2019 03:24:25 +0000 (22:24 -0500)]
[X86/Linux] Fix error: no member named 'GetId' in 'AppDomain' when enabled Interpreter issue (#24513)
https://github.com/dotnet/coreclr/issues/24492
Eugene Rozenfeld [Fri, 10 May 2019 00:16:10 +0000 (17:16 -0700)]
Merge pull request #24482 from erozenfeld/Fix24159
Mark local struct as having overlapping fields after struct reinterpretation
Mike McLaughlin [Thu, 9 May 2019 21:01:10 +0000 (14:01 -0700)]
Fix memory leak in PAL_GenerateCoreDump (#24503)
Tanner Gooding [Thu, 9 May 2019 20:46:38 +0000 (13:46 -0700)]
More cleanup of the HWIntrinsic test templates (#24455)
* Adding some templates from which other HWIntrinsic test templates can be generated
* Regenerating the HWIntrinsic tests
Eugene Rozenfeld [Tue, 7 May 2019 22:35:42 +0000 (15:35 -0700)]
Mark local struct as having overlapping fields after struct reinterpretation
Methods like System.Runtime.CompilerServices.Unsafe.As<TFrom, TTo> may
have struct reinterpretation when function signature specifies Struct1&
and the method returns Struct2& where Struct1 and Struct2 are different
structs. This may confuse jit optimizations (in particular, value
numbering) because fields of a struct of type Struct1 may be accessed
using handles of Struct2. This fix marks the source local involved in
such struct reinterpretation as having overlapping fields. That prevents
SSA builder from inserting the local into SSA.
Fixes #24159.
No diffs in framework assemblies and coreclr benchmarks.
Gregory LEOCADIE [Thu, 9 May 2019 17:05:44 +0000 (19:05 +0200)]
Add a new version of ContentionEnd event (#22487)
Add new contention event
- This new event contains the duration of the contention.
- Compute duration and emit contention events only when Contention keyword is activated
Brian Sullivan [Thu, 9 May 2019 17:02:42 +0000 (10:02 -0700)]
Merge pull request #24456 from briansull/ibc-work
IBC refactor - Zero Diff, rename types and methods
Stephen Toub [Thu, 9 May 2019 16:40:16 +0000 (12:40 -0400)]
Turn on nullability for all of Corelib (#24497)
* Enable nullable at the project level
* Remove `#nullable enable` from individual files
Removes `#nullable enable` from almost all .cs files in System.Private.CoreLib. I left it only in the ~30 files (out of ~1480 that had it) that are mirrored to corefx, that are built into projects by corefx that don't yet set NullableContextOptions at the project level, and that use nullable annotations; otherwise, they'd break the corefx build.
Michal Strehovský [Thu, 9 May 2019 15:50:31 +0000 (17:50 +0200)]
Delete suspicious code in delegate construction (#24493)
This reverts commit
0786da806b9727c466f3f9393cb3d55cf9df7536.
dotnet-maestro[bot] [Thu, 9 May 2019 11:51:41 +0000 (04:51 -0700)]
[master] Update dependencies from dotnet/corefx (#24314)
* Update dependencies from https://github.com/dotnet/corefx build
20190506.1
- Microsoft.NETCore.Platforms - 3.0.0-preview6.19256.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview6.19256.1
* Use last stable version of System.Numerics.Vectors package
* Add Microsoft.Bcl.AsyncInterfaces package
* Disable Microsoft.Bcl.AsyncInterfaces
Jeremy Koritzinsky [Thu, 9 May 2019 07:39:27 +0000 (00:39 -0700)]
Fix ComActivator typo. (#24485)
Andrew Au [Wed, 8 May 2019 17:35:43 +0000 (10:35 -0700)]
Return the required padding size instead of the current position to avoid integer overflow.
Steve MacLean [Thu, 9 May 2019 02:33:10 +0000 (22:33 -0400)]
Remove premature throw (#24450)
* Remove premature throw
ResolveUsingEvent is no longer the last resort for Assembly resolution
and should not be throwing simply because the Assembly.Resolve event did
not find the Assembly
* Delay throw FileNotFound until after AppDomain.AssemblyResolve
Koundinya Veluri [Thu, 9 May 2019 02:16:16 +0000 (19:16 -0700)]
Fix ETL event rejit IDs and sending of the IL to native map event when code versioning is in use (#24422)
Fix ETL event rejit IDs and sending of the IL to native map event when code versioning is in use
Fixes https://github.com/dotnet/coreclr/issues/22904
Fixes https://github.com/dotnet/coreclr/issues/22908
- Method events now always send the native code ID for the rejit ID, and the IL to native map event continues to send the IL code ID
- Took code versioning into account when sending rundown events for a method including the IL to native map
Divino César [Wed, 8 May 2019 22:29:27 +0000 (15:29 -0700)]
Merge pull request #24479 from dotnet/UpdateHelixSDK
Update Helix SDK Version - Master branch
Aaron Robinson [Wed, 8 May 2019 22:12:11 +0000 (15:12 -0700)]
Fix scenarios where SPCL is not crossgen'd and the output is not in the bin directory (#24477)
Aaron Robinson [Wed, 8 May 2019 22:09:41 +0000 (15:09 -0700)]
Add support in SPCL to call into user supplied register and unregiste… (#24452)
* Add support in SPCL to call into user supplied register and unregister functions
Brian Sullivan [Wed, 8 May 2019 22:07:12 +0000 (15:07 -0700)]
Merge pull request #24462 from briansull/fix-24440
Fix 24440
Sergey Andreenko [Wed, 8 May 2019 21:46:40 +0000 (14:46 -0700)]
Merge pull request #24366 from sandreenko/fixLogPrinting
Fix some small issues with stress logging.