Bernhard Miklautz [Tue, 3 May 2016 12:47:53 +0000 (14:47 +0200)]
pkg/deb: update the package
Bernhard Miklautz [Tue, 3 May 2016 12:16:11 +0000 (14:16 +0200)]
Add library libwinpr-tools
libwinpr-tools is a replacement for winpr-makecert-tool.a. Currently
it's basically the same as winpr-makecert-tool.a but in future
functionality that doesn't fit directly in winpr will be added here.
Bernhard Miklautz [Tue, 3 May 2016 08:44:42 +0000 (10:44 +0200)]
client/X11: fix build without client interface
Fix build when -DWITH_CLIENT_INTERFACE=OFF is used.
Bernhard Miklautz [Mon, 2 May 2016 16:44:40 +0000 (18:44 +0200)]
Merge pull request #3313 from bmiklautz/typos
libfreerd/color: fix typo
Bernhard Miklautz [Mon, 2 May 2016 16:31:43 +0000 (18:31 +0200)]
libfreerd/color: fix typo
Source: http://anonscm.debian.org/cgit/collab-maint/freerdp2.git/commit/?id=
f3c1f25bbfe0f17a0d1317096984b73db6fa1f38
akallabeth [Mon, 2 May 2016 16:09:24 +0000 (18:09 +0200)]
Merge pull request #3311 from bmiklautz/static_rdtk
Don't export/install rdtk
akallabeth [Mon, 2 May 2016 16:08:46 +0000 (18:08 +0200)]
Merge pull request #3312 from bmiklautz/commtests
Disable comm tests per default
Bernhard Miklautz [Mon, 2 May 2016 15:44:25 +0000 (17:44 +0200)]
rdtk: fix windows build
Don't do export any functions.
Bernhard Miklautz [Mon, 2 May 2016 14:59:25 +0000 (16:59 +0200)]
Disable comm tests per default
comm tests require a serial device for testing. If the test environment
isn't available the tests will return errors therefore the tests are
now disabled per default. They can be (re-)enabled by using the cmake
option BUILD_COMM_TESTS.
Bernhard Miklautz [Mon, 2 May 2016 14:10:31 +0000 (16:10 +0200)]
Don't export/install rdtk
Although exported rdtk isn't really mature and stable yet therefore it is
not exported/installed anymore. In case FreeRDP is built without
static libraries librdtk is installed as part or the
FreeRDP-ShadowTargets exports as this is the only place it is used right
now.
Bernhard Miklautz [Tue, 26 Apr 2016 09:01:40 +0000 (11:01 +0200)]
Merge pull request #3305 from akallabeth/dynamic_channel_crash_fix
Dynamic channel crash fix
akallabeth [Tue, 26 Apr 2016 07:59:40 +0000 (09:59 +0200)]
Merge pull request #3250 from mfleisz/cssp_v3
core: Add support for CredSSP version 3
Armin Novak [Tue, 26 Apr 2016 07:35:54 +0000 (09:35 +0200)]
Dynamic channel internal functions now static.
Armin Novak [Tue, 26 Apr 2016 07:34:12 +0000 (09:34 +0200)]
ListDictionary handle NULL list argument.
Hardening [Tue, 19 Apr 2016 15:57:53 +0000 (17:57 +0200)]
Merge pull request #3296 from akallabeth/clipboard_file_fix
Fix CB_FILECONTENTS_REQUEST message decoding.
Armin Novak [Tue, 19 Apr 2016 14:44:31 +0000 (16:44 +0200)]
Fix CB_FILECONTENTS_REQUEST message decoding.
Do not require optional fields to be present as required by
[MS-RDPECLIP] 2.2.5.3 File Contents Request PDU (CLIPRDR_FILECONTENTS_REQUEST)
Norbert Federa [Tue, 19 Apr 2016 13:32:56 +0000 (15:32 +0200)]
Merge pull request #3294 from bmiklautz/misc_build
Misc build and test fixes
Norbert Federa [Tue, 19 Apr 2016 13:21:49 +0000 (15:21 +0200)]
Merge pull request #3287 from bmiklautz/linking_fixes2
build: add missing dependencies
Hardening [Tue, 19 Apr 2016 12:55:26 +0000 (14:55 +0200)]
Merge pull request #3293 from nfedera/mitigate-cbclientaddress-verification
core: allow TS Gateway protocol violation
Bernhard Miklautz [Tue, 19 Apr 2016 12:33:26 +0000 (14:33 +0200)]
build: disable -Wl,--no-undefined per default
As building with -Wl,--no-undefined might cause issues when
combined with other linker flags (e.g. with -fsanitize=address see #3289)
it is now disabled per default but can be re-enabled with
-DWITH_NO_UNDEFINED=ON.
It is enabled for ci builds on linux to find undefined symbols.
Norbert Federa [Tue, 19 Apr 2016 12:09:58 +0000 (14:09 +0200)]
core: allow TS Gateway protocol violation
According to [MS-RDPBCGR 2.2.1.11.1.1.1] the TS_EXTENDED_INFO_PACKET
structure's cbClientAddress field must include the _mandatory_ NULL
terminator of the clientAddress field in its byte count.
However, connections proxied via Microsoft's TS Gateway set the
cbClientDir value to 0.
Bernhard Miklautz [Tue, 19 Apr 2016 10:46:54 +0000 (12:46 +0200)]
Tests: Disable TESTS_WTSAPI_EXTRA per default
TESTS_WTSAPI_EXTRA was mistakenly always enabled if BUILD_TESTING
was enabled.
Bernhard Miklautz [Fri, 15 Apr 2016 12:48:46 +0000 (14:48 +0200)]
Merge pull request #3285 from rjcorrig/kb3148851
winpr: KB3148851: Updates to Russian Time Zones for 2016
Bernhard Miklautz [Fri, 15 Apr 2016 12:32:40 +0000 (14:32 +0200)]
build: add missing dependencies
Add all missing dependencies found when building with
STATIC_CHANNELS=OFF.
Fixes #3281
Robert Corrigan [Wed, 13 Apr 2016 17:34:43 +0000 (13:34 -0400)]
KB3148851: Updates to Russian Time Zones for 2016
Hardening [Mon, 11 Apr 2016 18:47:53 +0000 (20:47 +0200)]
Merge pull request #3274 from bmiklautz/linking_fixes
Fix build regressions
Hardening [Mon, 11 Apr 2016 09:10:08 +0000 (11:10 +0200)]
Merge pull request #3276 from nfedera/nf-fix-ms-android-protocol-violation
core: allow ms android client protocol violation
Norbert Federa [Mon, 11 Apr 2016 08:50:27 +0000 (10:50 +0200)]
core: allow ms android client protocol violation
According to [MS-RDPBCGR 2.2.1.11.1.1.1] the TS_EXTENDED_INFO_PACKET
structure's cbClientDir field must include the _mandatory_ NULL
terminator of the ClientDir field.
However, since version 8.1.31.44, the Microsoft Remote Desktop Client
for Android sets cbClientDir to 0.
akallabeth [Fri, 8 Apr 2016 13:28:40 +0000 (15:28 +0200)]
Merge pull request #3275 from nfedera/fix-server-establish-keys-typo
core: fix broken rdp security (server side)
Norbert Federa [Fri, 8 Apr 2016 12:47:35 +0000 (14:47 +0200)]
core: fix broken rdp security (server side)
- fixed typo in rdp_server_establish_keys
Bernhard Miklautz [Thu, 7 Apr 2016 12:39:16 +0000 (14:39 +0200)]
build: add missing dependencies
Add all missing dependencies found with --no-undefined. Since
dependencies aren't exported anymore (if not required) it is no necessary
to explicitly list all required libraries.
Bernhard Miklautz [Thu, 7 Apr 2016 12:52:52 +0000 (14:52 +0200)]
Merge pull request #3273 from realjiangms/fix_android_crash_rotate_3258
Fix android rotation crash
Bernhard Miklautz [Thu, 7 Apr 2016 12:35:57 +0000 (14:35 +0200)]
build: use --no-undefined if available
zihao.jiang [Thu, 7 Apr 2016 12:19:22 +0000 (20:19 +0800)]
Fix android rotation crash
Bernhard Miklautz [Thu, 31 Mar 2016 09:43:38 +0000 (11:43 +0200)]
Merge pull request #3254 from akallabeth/avc444_cmd_arg
Added advanced gfx command line options.
Armin Novak [Thu, 31 Mar 2016 09:01:45 +0000 (11:01 +0200)]
Cleaned up empty if.
akallabeth [Wed, 30 Mar 2016 13:20:53 +0000 (15:20 +0200)]
Merge pull request #3259 from bmiklautz/overlinking
Fix overlinking
Bernhard Miklautz [Tue, 29 Mar 2016 13:10:00 +0000 (15:10 +0200)]
usbdrc: remove unused dependencies
Bernhard Miklautz [Fri, 25 Mar 2016 15:28:17 +0000 (16:28 +0100)]
First shot on fixing over linking
If a target is linked against libraries with cmake
(target_link_libraries) and the libraries are not marked as PRIVATE
they are "exported" and in case a other target is linked against this
target it is also linked against *all* (not private) libraries.
Without declaring private libraries PRIVATE a lot of over linking
(linking against unneeded libraries) was done.
Bernhard Miklautz [Tue, 1 Mar 2016 11:45:25 +0000 (12:45 +0100)]
winpr/TestFileGetStdHandle: rename variable stdout
stdout shouldn't be used as variable name (can't even be used on
windows).
Armin Novak [Thu, 24 Mar 2016 15:25:22 +0000 (16:25 +0100)]
Added advanced gfx command line options.
Martin Fleisz [Mon, 21 Mar 2016 15:58:09 +0000 (16:58 +0100)]
core: correctly set last error on credssp errors
Martin Fleisz [Mon, 21 Mar 2016 09:23:18 +0000 (10:23 +0100)]
core: Propagate credssp error code by setting last error
Martin Fleisz [Fri, 18 Mar 2016 12:45:51 +0000 (13:45 +0100)]
winpr: Fix definition of NTSTATUS_FROM_WIN32
Martin Fleisz [Fri, 18 Mar 2016 12:32:13 +0000 (13:32 +0100)]
core: Add support for CredSSP version 3
akallabeth [Thu, 17 Mar 2016 10:06:39 +0000 (11:06 +0100)]
Merge pull request #3243 from hardening/typofix
Fixed a typo in debug messages
Bernhard Miklautz [Thu, 17 Mar 2016 10:02:51 +0000 (11:02 +0100)]
Merge pull request #3240 from akallabeth/drive_fixes
Small Drive fixes
David FORT [Thu, 17 Mar 2016 09:44:11 +0000 (10:44 +0100)]
Fixed a typo in debug messages
Armin Novak [Thu, 17 Mar 2016 08:34:24 +0000 (09:34 +0100)]
Replace SetFilePointerEx with SetFilePointer.
Armin Novak [Thu, 17 Mar 2016 08:33:39 +0000 (09:33 +0100)]
Print device name when loading channel.
Martin Fleisz [Wed, 16 Mar 2016 14:19:11 +0000 (15:19 +0100)]
Merge pull request #3164 from akallabeth/windows_UnixChangeFileMode
Implemented UnixChangeFileMode for windows.
Bernhard Miklautz [Wed, 16 Mar 2016 13:05:55 +0000 (14:05 +0100)]
Merge pull request #3215 from akallabeth/avc_444
Avc 444 support
Bernhard Miklautz [Wed, 16 Mar 2016 12:56:39 +0000 (13:56 +0100)]
Merge pull request #3204 from akallabeth/rdp_file_preference_fix
Rdp file preference fix
Armin Novak [Wed, 16 Mar 2016 12:46:47 +0000 (13:46 +0100)]
Assume the update rectangle is inclusive.
Armin Novak [Mon, 14 Mar 2016 08:01:57 +0000 (09:01 +0100)]
Fixed comments.
Armin Novak [Mon, 14 Mar 2016 07:57:00 +0000 (08:57 +0100)]
Renamed GFX defines to conform to spec.
Armin Novak [Wed, 2 Mar 2016 14:16:49 +0000 (15:16 +0100)]
Implemented GFX AVC444 support.
Armin Novak [Wed, 2 Mar 2016 13:53:55 +0000 (14:53 +0100)]
Implemented YUV444 related primitives.
Armin Novak [Wed, 2 Mar 2016 13:39:36 +0000 (14:39 +0100)]
Unified RDPGFX_RECT16 and RECTANGLE_16
akallabeth [Wed, 16 Mar 2016 12:32:51 +0000 (13:32 +0100)]
Merge pull request #3226 from rjcorrig/#3198
winpr: Updates time zones and fixes bias values
akallabeth [Wed, 16 Mar 2016 12:32:29 +0000 (13:32 +0100)]
Merge pull request #3234 from bmiklautz/rdkt_version
Increase rdtk version to 2.0.0
Robert Corrigan [Wed, 16 Mar 2016 12:29:21 +0000 (08:29 -0400)]
winpr_detect_windows_time_zone should have void argument
Armin Novak [Wed, 16 Mar 2016 12:15:39 +0000 (13:15 +0100)]
Parse RDP and assistance files in parser.
The command line parser is now populating the settings with
the RDP or assistance file content before parsing the rest
of the arguments.
Armin Novak [Wed, 16 Mar 2016 12:05:00 +0000 (13:05 +0100)]
Removed windows extra handling for RDP files.
Bernhard Miklautz [Wed, 16 Mar 2016 12:15:24 +0000 (13:15 +0100)]
Increase rdtk version to 2.0.0
rdtk was initially 1.0.0 then changed to 0.0.1.
To have a clean cut and prevent problems on systems which already have
FreeRDP in a version where rdtk was 1.0.0 increase it to 2.0.0
Armin Novak [Wed, 16 Mar 2016 12:08:06 +0000 (13:08 +0100)]
Updated ConvertToUnicode return check.
Bernhard Miklautz [Wed, 16 Mar 2016 12:03:33 +0000 (13:03 +0100)]
Merge pull request #3207 from akallabeth/mic_crash_fix
Fixed error handling for channel load failures.
Armin Novak [Wed, 16 Mar 2016 11:39:36 +0000 (12:39 +0100)]
Fixed double free.
Bernhard Miklautz [Wed, 16 Mar 2016 10:58:31 +0000 (11:58 +0100)]
Merge pull request #3214 from hardening/fix_systemd_appender
Make systemd appender honor layout and logs off
akallabeth [Tue, 15 Mar 2016 08:25:50 +0000 (09:25 +0100)]
Merge pull request #3225 from mfleisz/fix_set_err_info
freerdp: Fix possible crash when setting error info in server-mode
Robert Corrigan [Thu, 10 Mar 2016 20:10:49 +0000 (15:10 -0500)]
winpr: Updates time zones and fixes bias values
Bernhard Miklautz [Mon, 14 Mar 2016 14:28:56 +0000 (15:28 +0100)]
Merge pull request #3223 from comicfans/wayland_fix
only compile wayland client when WAYLAND_FOUND
Martin Fleisz [Mon, 14 Mar 2016 14:27:15 +0000 (15:27 +0100)]
freerdp: Fix possible crash when setting error info in server-mode
Bernhard Miklautz [Mon, 14 Mar 2016 14:13:52 +0000 (15:13 +0100)]
Merge pull request #3224 from mfleisz/win32_bld_fix
winpr: Fix definition of PathFileExists on Win32
Martin Fleisz [Mon, 14 Mar 2016 13:08:48 +0000 (14:08 +0100)]
winpr: Fix definition of PathFileExists on Win32
comicfans44 [Mon, 14 Mar 2016 12:51:50 +0000 (12:51 +0000)]
only compile wayland client when WAYLAND_FOUND
Armin Novak [Mon, 14 Mar 2016 12:19:08 +0000 (13:19 +0100)]
Reverted WTS API changes.
Armin Novak [Tue, 8 Mar 2016 12:19:40 +0000 (13:19 +0100)]
Fixed return value for failed malloc.
Armin Novak [Mon, 7 Mar 2016 11:54:49 +0000 (12:54 +0100)]
Fixed error handling for channel load failures.
Bernhard Miklautz [Mon, 14 Mar 2016 12:00:52 +0000 (13:00 +0100)]
Merge pull request #3209 from akallabeth/android_translation_fix
Reverted translation of internal VALUE arrays.
akallabeth [Mon, 14 Mar 2016 09:08:25 +0000 (10:08 +0100)]
Merge pull request #3221 from bmiklautz/fix_nightlies
pkg/deb: adapt channel paths
Bernhard Miklautz [Mon, 14 Mar 2016 08:57:33 +0000 (09:57 +0100)]
Merge pull request #3212 from realjiangms/fix_default_audin
audin: Fixed default sys argument for audin
Armin Novak [Mon, 14 Mar 2016 08:53:45 +0000 (09:53 +0100)]
Removed untranslatable strings from translated files.
Bernhard Miklautz [Mon, 14 Mar 2016 08:38:35 +0000 (09:38 +0100)]
pkg/deb: adapt channel paths
Martin Fleisz [Mon, 14 Mar 2016 08:20:30 +0000 (09:20 +0100)]
Merge pull request #3213 from akallabeth/android_build_fixes
Android build and settings fixes
Martin Fleisz [Fri, 11 Mar 2016 10:22:59 +0000 (11:22 +0100)]
Merge pull request #3177 from akallabeth/codec_reset_fix
Fixed codec reset, now resetting resolution too.
Hardening [Thu, 10 Mar 2016 22:41:12 +0000 (23:41 +0100)]
Make systemd appender honor layout and log off
Armin Novak [Thu, 10 Mar 2016 21:07:30 +0000 (22:07 +0100)]
Replaced version patch with make argument.
Armin Novak [Thu, 10 Mar 2016 20:54:11 +0000 (21:54 +0100)]
Updated OpenSSL version in script.
Armin Novak [Thu, 10 Mar 2016 20:52:40 +0000 (21:52 +0100)]
Fixed settings load/store.
Armin Novak [Thu, 10 Mar 2016 20:18:19 +0000 (21:18 +0100)]
Fixed paralell building issue.
zihao.jiang [Thu, 10 Mar 2016 17:52:18 +0000 (01:52 +0800)]
audin: Fixed default sys argument for audin
PR #3173 fixed argument parsing. However it breaks the usage without specifying subsystem: "/microphone"
In particular, aFreerdp microphone redirect is broken as it exactly uses "/microphone"
This PR fixes the regression.
Fix: We should not call CommandLineParseArgumentsA if argc is only 1 (same case as rdpsnd_main.c)
Martin Fleisz [Thu, 10 Mar 2016 07:22:30 +0000 (08:22 +0100)]
Merge pull request #3210 from hardening/env_fix
Don't require HOME env var to be set for server-side code
David FORT [Wed, 9 Mar 2016 13:10:31 +0000 (14:10 +0100)]
Don't require HOME env var to be set for server-side code
Armin Novak [Tue, 8 Mar 2016 19:34:19 +0000 (20:34 +0100)]
Marked non translatable strings as such.
Armin Novak [Tue, 8 Mar 2016 15:27:51 +0000 (16:27 +0100)]
Reverted translation of internal VALUE arrays.
akallabeth [Tue, 8 Mar 2016 19:50:30 +0000 (20:50 +0100)]
Merge pull request #3172 from realjiangms/android_launch_by_scheme_2720
android: Allow freerdp mobile version to be launched from URI (freerdp://)
zihao.jiang [Sat, 27 Feb 2016 10:31:43 +0000 (18:31 +0800)]
android: Allow freerdp mobile version to be launched from URI (freerdp://)
It would be good if we have a easy way to call aFreeRDP in another Android APP (Requirement also mentioned in #2720)
We can define a scheme (freerdp://) as unified way to launch FreeRDP from another APP or browser and connect to compatible RDP server
1. Define scheme freerdp://
2. General form could be freerdp://user@hostname:port/connect?key1=value&key2=-&key3=%2b&key4=
3. [user] part would be translated to /u:
4. [hostname:port] would be translated to /v:
5. The [user@hostname:port] part would be used as app title, currently it's just the progress dialog title
6. query parameters would be translated to command line arguments. Later same arguments will overwrite the formers:
a. key1=value: => /key1:value
b. key2=-: => -key2
c. key3=%2b => +key3 (%2b is url encoded +)
d. key4= => /key4
e. Especially, drive=sdcard will be properly handled with local sdcard path. On my device it will be translated to /drive:sdcard,/storage/emulated/0
Owing to the refactor work in PR #3097, we now pass same command line argument to JNI for freerdp settings.
We just need to make the SessionActivity accept freerdp scheme and translate argument from URI form to command line form.
Martin Fleisz [Tue, 8 Mar 2016 09:05:57 +0000 (10:05 +0100)]
Merge pull request #3181 from akallabeth/wlog_filter_fix
Respecting filter in WLog_GetLogLevel
Bernhard Miklautz [Mon, 7 Mar 2016 14:39:59 +0000 (15:39 +0100)]
Merge pull request #3206 from akallabeth/openssl_unification
Moved assistance to winpr crypto.