platform/upstream/mesa.git
13 months agospirv: add support for SpvCapabilityFragmentBarycentricKHR
Samuel Pitoiset [Fri, 6 May 2022 12:00:40 +0000 (14:00 +0200)]
spirv: add support for SpvCapabilityFragmentBarycentricKHR

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23254>

13 months agozink: update profiles schema
Erik Faye-Lund [Wed, 31 May 2023 18:25:24 +0000 (20:25 +0200)]
zink: update profiles schema

The 0.8.1-251 release has shipped, which contains the latest bits we
need in order to be clean here. Let's bump the bumpbump-bump.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23342>

13 months agodraw: add (disabled) vertex dumping for non-linear emit
Mike Blumenkrantz [Wed, 31 May 2023 16:09:31 +0000 (12:09 -0400)]
draw: add (disabled) vertex dumping for non-linear emit

matches linear path

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23368>

13 months agolavapipe: don't pass indirect info in streamout draws
Mike Blumenkrantz [Wed, 31 May 2023 20:40:58 +0000 (16:40 -0400)]
lavapipe: don't pass indirect info in streamout draws

this is otherwise broken for a sequence like draw_indirect -> draw_indirect_bc

cc: mesa-stable

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23368>

13 months agolavapipe: stop setting patch vertices constantly
Mike Blumenkrantz [Wed, 31 May 2023 19:31:14 +0000 (15:31 -0400)]
lavapipe: stop setting patch vertices constantly

this pollutes gallium traces and makes debugging more annoying

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23368>

13 months agolavapipe: bump max push constant size
Mike Blumenkrantz [Tue, 30 May 2023 14:40:36 +0000 (10:40 -0400)]
lavapipe: bump max push constant size

this matches vkd3d-proton requirements

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23368>

13 months agolavapipe: fix DS3 min sample setting
Mike Blumenkrantz [Wed, 31 May 2023 19:25:41 +0000 (15:25 -0400)]
lavapipe: fix DS3 min sample setting

if a DS3 pipeline enabling dynamic samples is not bound when samples
are set dynamically, then such a pipeline is later bound, min samples
would have been incorrectly set to 1

instead, flag the update for later and do it just before draw

cc: mesa-stable

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23368>

13 months agoradv: Guard against misplaced RGP barrier markers.
Tatsuyuki Ishi [Wed, 1 Feb 2023 08:40:02 +0000 (17:40 +0900)]
radv: Guard against misplaced RGP barrier markers.

RGP will crash if we emit a layout transition marker outside a barrier.
If this happens, trigger an assertion if its enabled or silently discard
the marker otherwise to avoid traces that cannot be opened.

Also, guard against attempts to start barrier markers recursively, since
this will corrupt the internal start/end matching.

Closes: <https://gitlab.freedesktop.org/mesa/mesa/-/issues/7971>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21033>

13 months agoradv: Add RGP barrier markers for render pass transition and copy.
Tatsuyuki Ishi [Wed, 1 Feb 2023 08:27:26 +0000 (17:27 +0900)]
radv: Add RGP barrier markers for render pass transition and copy.

This allows them to be attributed to the correct event instead of being
blend to the previous barrier.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21033>

13 months agoradeonsi: enable aco for mono standalone vs
Qiang Yu [Fri, 28 Apr 2023 03:54:56 +0000 (11:54 +0800)]
radeonsi: enable aco for mono standalone vs

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoac/llvm: remove unused barrier implementation
Qiang Yu [Tue, 16 May 2023 02:43:41 +0000 (10:43 +0800)]
ac/llvm: remove unused barrier implementation

memory buffer barrier is still used when nir lowering, will
be removed later.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoradeonsi: always use scoped barrier
Qiang Yu [Tue, 16 May 2023 02:22:17 +0000 (10:22 +0800)]
radeonsi: always use scoped barrier

aco has removed non-scoped barrier support.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoradeonsi: use nir_umul_high for fast udiv
Qiang Yu [Thu, 11 May 2023 11:41:20 +0000 (19:41 +0800)]
radeonsi: use nir_umul_high for fast udiv

nir has dedicated alu op for it. Also for removing int64
multiply which aco does not support.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoradeonsi: calculate needed lds size when upload raw binary for vs
Qiang Yu [Wed, 10 May 2023 08:06:08 +0000 (16:06 +0800)]
radeonsi: calculate needed lds size when upload raw binary for vs

ELF do the same when upload binary. We can't do this when
compile, because it's know when draw time in radeonsi.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoradeonsi: fill aco shader info for mono standalone vs
Qiang Yu [Fri, 28 Apr 2023 07:51:09 +0000 (15:51 +0800)]
radeonsi: fill aco shader info for mono standalone vs

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agonir,ac/llvm,radeonsi: replace nir_buffer_atomic_add_amd with ssbo atomic
Qiang Yu [Tue, 16 May 2023 08:05:34 +0000 (16:05 +0800)]
nir,ac/llvm,radeonsi: replace nir_buffer_atomic_add_amd with ssbo atomic

Now that radeonsi support pass desc to ssbo atomic ops,
we can use ssbo atomic instead. aco does not implement
nir_buffer_atomic_add either.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoac/llvm,radeonsi: lower nir_load_ring_esgs_amd in abi
Qiang Yu [Wed, 17 May 2023 08:06:15 +0000 (16:06 +0800)]
ac/llvm,radeonsi: lower nir_load_ring_esgs_amd in abi

It's not implemented by aco. So move the code from llvm
to nir.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoac/llvm,radeonsi: lower nir_load_ordered_id_amd in abi
Qiang Yu [Tue, 16 May 2023 08:11:21 +0000 (16:11 +0800)]
ac/llvm,radeonsi: lower nir_load_ordered_id_amd in abi

aco does not implement it.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoac/llvm,radeonsi: lower nir_load_packed_passthrough_primitive_amd in abi
Qiang Yu [Wed, 10 May 2023 08:43:58 +0000 (16:43 +0800)]
ac/llvm,radeonsi: lower nir_load_packed_passthrough_primitive_amd in abi

aco does not implement it.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoac/llvm,radeonsi: lower nir_load_initial_edgeflags_amd in abi
Qiang Yu [Fri, 28 Apr 2023 08:31:37 +0000 (16:31 +0800)]
ac/llvm,radeonsi: lower nir_load_initial_edgeflags_amd in abi

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoac/llvm,radeonsi: lower load_workgroup_num_input_(vertices|primitives) in abi
Qiang Yu [Fri, 28 Apr 2023 06:35:41 +0000 (14:35 +0800)]
ac/llvm,radeonsi: lower load_workgroup_num_input_(vertices|primitives) in abi

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoac/llvm,radeonsi: lower nir_load_merged_wave_info_amd in abi
Qiang Yu [Fri, 28 Apr 2023 06:31:09 +0000 (14:31 +0800)]
ac/llvm,radeonsi: lower nir_load_merged_wave_info_amd in abi

aco does not implement it.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoac/llvm,radeonsi: lower nir_load_gs_vertex_offset_amd in abi
Qiang Yu [Fri, 28 Apr 2023 06:24:24 +0000 (14:24 +0800)]
ac/llvm,radeonsi: lower nir_load_gs_vertex_offset_amd in abi

aco does not implement this.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoradeonsi: add scratch offset vs args explicitly for aco
Qiang Yu [Fri, 28 Apr 2023 03:18:00 +0000 (11:18 +0800)]
radeonsi: add scratch offset vs args explicitly for aco

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoradeonsi: resolve lds ngg aco symbols
Qiang Yu [Thu, 27 Apr 2023 09:46:29 +0000 (17:46 +0800)]
radeonsi: resolve lds ngg aco symbols

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23096>

13 months agoaco: use ac_get_image_dim for array check when image intrinsic
Qiang Yu [Tue, 30 May 2023 11:22:48 +0000 (19:22 +0800)]
aco: use ac_get_image_dim for array check when image intrinsic

This is to avoid missing array flag when <=GFX8 and 3D image
in which case is treated as 2D array image.

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23094>

13 months agoaco: implement nir_bindless_image_fragment_mask_load_amd
Qiang Yu [Thu, 18 May 2023 02:07:43 +0000 (10:07 +0800)]
aco: implement nir_bindless_image_fragment_mask_load_amd

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Sigend-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23094>

13 months agoaco: implement nir_xfb_counter_sub_amd
Qiang Yu [Tue, 16 May 2023 09:28:18 +0000 (17:28 +0800)]
aco: implement nir_xfb_counter_sub_amd

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23094>

13 months agoaco: use gds reg when ordered xfb counter add
Qiang Yu [Tue, 16 May 2023 08:54:59 +0000 (16:54 +0800)]
aco: use gds reg when ordered xfb counter add

This is currently only used by radeonsi.

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23094>

13 months agoaco/assembler: handle ds_(add|sub)_gs_reg_rtn encoding
Qiang Yu [Tue, 16 May 2023 08:48:38 +0000 (16:48 +0800)]
aco/assembler: handle ds_(add|sub)_gs_reg_rtn encoding

They are different than normal DS instructions, only
use DATA[0], not use ADDR.

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23094>

13 months agoaco: implement load buffer with ACCESS_USES_FORMAT_AMD
Qiang Yu [Thu, 11 May 2023 07:39:16 +0000 (15:39 +0800)]
aco: implement load buffer with ACCESS_USES_FORMAT_AMD

This is used by radeonsi for vs input load and cdna
image load emulation.

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23094>

13 months agoac/nir/ngg: don't use 8bit alu ops
Qiang Yu [Wed, 10 May 2023 06:11:48 +0000 (14:11 +0800)]
ac/nir/ngg: don't use 8bit alu ops

aco doesn't support 8bit alu ops and radeonsi won't
call nir_lower_bit_size for most alu ops, so just
don't use 8bit alu ops (they will be lowered to 32bit
anyway if we do).

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23094>

13 months agoaco,radv: remove unused aco_shader_info fields
Qiang Yu [Fri, 28 Apr 2023 07:36:43 +0000 (15:36 +0800)]
aco,radv: remove unused aco_shader_info fields

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23094>

13 months agoaco: implement two load lds ngg intrininsic for radeonsi
Qiang Yu [Thu, 27 Apr 2023 09:01:56 +0000 (17:01 +0800)]
aco: implement two load lds ngg intrininsic for radeonsi

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23094>

13 months agoci/turnip: Update full-run xfails.
Emma Anholt [Wed, 17 May 2023 22:28:04 +0000 (15:28 -0700)]
ci/turnip: Update full-run xfails.

The big pile of crashes were all either not covered by the fractional run
and a full run hadn't been run to update them, or unsupported where
Crash->Skip is not being reported as UnexpectedPass.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23385>

13 months agoci: Respect $HTTP_PROXY for ci_run_n_monitor
Daniel Stone [Wed, 31 May 2023 17:50:11 +0000 (18:50 +0100)]
ci: Respect $HTTP_PROXY for ci_run_n_monitor

We need to explicitly tell AIOHTTP that it's OK to take the HTTP proxy
from the environment.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23341>

13 months agoci/crocus: Add a missing xfail.
Emma Anholt [Thu, 1 Jun 2023 20:53:13 +0000 (13:53 -0700)]
ci/crocus: Add a missing xfail.

Probably more fallout from debian 12 uprev.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23379>

13 months agocrocus: Fix regression from !20153
Emma Anholt [Thu, 1 Jun 2023 20:50:24 +0000 (13:50 -0700)]
crocus: Fix regression from !20153

The MR fixed iris in 14dec0c1479aa149edead1e95b7feb1669ccc4c1, but didn't
do the same fix for crocus.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23379>

13 months agoRevert "ci: disable anholt's farm"
Emma Anholt [Thu, 1 Jun 2023 19:53:56 +0000 (12:53 -0700)]
Revert "ci: disable anholt's farm"

Things are back up.  This reverts commit
520c5091d7de4290f87bb984a59e7ac2993471a4.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23381>

13 months agoci/freedreno: Update minetest hash.
Emma Anholt [Thu, 1 Jun 2023 19:50:21 +0000 (12:50 -0700)]
ci/freedreno: Update minetest hash.

1 different pixel, undetectable change.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa: Use shared NIR code for ARB_vp and FF VS position transformation.
Emma Anholt [Wed, 31 May 2023 18:58:10 +0000 (11:58 -0700)]
mesa: Use shared NIR code for ARB_vp and FF VS position transformation.

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa/ffvs: Fix mvp_with_dp4 position transformation.
Emma Anholt [Wed, 31 May 2023 18:49:47 +0000 (11:49 -0700)]
mesa/ffvs: Fix mvp_with_dp4 position transformation.

Copy and paste mistake, but didn't affect anybody since this knob is
disconnected at the moment.

Fixes: c5b3d488f9be ("mesa/main: make ffvertex output nir")
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa: Use the NIR pass for fixed function fog.
Emma Anholt [Tue, 16 May 2023 23:54:20 +0000 (16:54 -0700)]
mesa: Use the NIR pass for fixed function fog.

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa/ati_fs: Move prog->SamplersUsed/TexturesUsed setup to EndFragmentShader.
Emma Anholt [Thu, 18 May 2023 16:32:54 +0000 (09:32 -0700)]
mesa/ati_fs: Move prog->SamplersUsed/TexturesUsed setup to EndFragmentShader.

No need to have st_program.c come back into ATI_fs for this when it's a
property of program generation.  ARB programs set these up in their
translation, as well.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa/ati_fs: Move NIR translation to ATI_fs compile time.
Emma Anholt [Wed, 17 May 2023 00:07:31 +0000 (17:07 -0700)]
mesa/ati_fs: Move NIR translation to ATI_fs compile time.

Now ati_fs takes the same basic path as prog_to_nir, and we don't have to
think about it so much.  Also, the ATI_fs frontend can skip shader info
setup since nir_shader_gather_info does it.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa/ati_fs: Move sampler dim adjustment to a separate NIR pass.
Emma Anholt [Wed, 17 May 2023 00:01:52 +0000 (17:01 -0700)]
mesa/ati_fs: Move sampler dim adjustment to a separate NIR pass.

This means that the main NIR translation for ATI_fs is now independent of
the fp key, and we could do it earlier in the compile pipeline.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa: Move st_prog_to_nir_postprocess out of prog_to_nir.
Emma Anholt [Tue, 16 May 2023 23:44:57 +0000 (16:44 -0700)]
mesa: Move st_prog_to_nir_postprocess out of prog_to_nir.

We called it in the else branch, anyway.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa: Drop remaining unused ARB program instructions.
Emma Anholt [Tue, 16 May 2023 22:18:39 +0000 (15:18 -0700)]
mesa: Drop remaining unused ARB program instructions.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa: Drop unused control flow instructions for ARB programs.
Emma Anholt [Tue, 16 May 2023 22:17:25 +0000 (15:17 -0700)]
mesa: Drop unused control flow instructions for ARB programs.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa: Drop ARB program helper functions that are no longer used.
Emma Anholt [Tue, 16 May 2023 22:12:03 +0000 (15:12 -0700)]
mesa: Drop ARB program helper functions that are no longer used.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa: Move ARB_vp position invariant option handling to NIR.
Emma Anholt [Tue, 16 May 2023 22:03:44 +0000 (15:03 -0700)]
mesa: Move ARB_vp position invariant option handling to NIR.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa/ARB_fp: Use the NIR pass for adding fog code instead of ARB instrs.
Emma Anholt [Tue, 16 May 2023 21:36:20 +0000 (14:36 -0700)]
mesa/ARB_fp: Use the NIR pass for adding fog code instead of ARB instrs.

Tested with
https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/813

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa/ARB_fp: Drop an extra enum for fog mode.
Emma Anholt [Tue, 16 May 2023 21:29:54 +0000 (14:29 -0700)]
mesa/ARB_fp: Drop an extra enum for fog mode.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa: Move ATI_fragment_shader fog code emit to a NIR lowering pass.
Emma Anholt [Tue, 16 May 2023 19:38:57 +0000 (12:38 -0700)]
mesa: Move ATI_fragment_shader fog code emit to a NIR lowering pass.

Now it's implemented as a RMW of the FRAG_RESULT_COLOR output var (or
adjusting the store_output intrinsic's value for lowered i/o), which
should be reusable other places we might want to emit shader code for fog
(ARB_fp, fixed function fragment shaders).

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agonir,mesa: Add helpers for creating uniform state variables.
Emma Anholt [Tue, 16 May 2023 20:37:53 +0000 (13:37 -0700)]
nir,mesa: Add helpers for creating uniform state variables.

It's one of the weirder parts of our shader interface's interactions with
the GL API, so let's try to make it a little cleaner.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agonir: Use find_state_var in lower_atomics_to_ssbo.
Emma Anholt [Tue, 16 May 2023 20:30:18 +0000 (13:30 -0700)]
nir: Use find_state_var in lower_atomics_to_ssbo.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agomesa: Use find_state_var in lower_builtin.
Emma Anholt [Tue, 16 May 2023 19:48:03 +0000 (12:48 -0700)]
mesa: Use find_state_var in lower_builtin.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23111>

13 months agod3d12: Support PIPE_CAP_VS_LAYER_VIEWPORT
Jesse Natalie [Thu, 1 Jun 2023 19:28:35 +0000 (12:28 -0700)]
d3d12: Support PIPE_CAP_VS_LAYER_VIEWPORT

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23377>

13 months agomicrosoft/compiler: Viewport/layer as input to GS/HS needs to set feature bit
Jesse Natalie [Thu, 1 Jun 2023 20:08:11 +0000 (13:08 -0700)]
microsoft/compiler: Viewport/layer as input to GS/HS needs to set feature bit

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23377>

13 months agomicrosoft/compiler: Fix usage of type var in semantic asserts
Jesse Natalie [Thu, 1 Jun 2023 20:06:24 +0000 (13:06 -0700)]
microsoft/compiler: Fix usage of type var in semantic asserts

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23377>

13 months agomicrosoft/compiler: Fix the int->uint pass for arrayed I/O
Jesse Natalie [Thu, 1 Jun 2023 20:05:49 +0000 (13:05 -0700)]
microsoft/compiler: Fix the int->uint pass for arrayed I/O

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23377>

13 months agodzn: Don't lower away mediump
Jesse Natalie [Wed, 31 May 2023 20:18:01 +0000 (13:18 -0700)]
dzn: Don't lower away mediump

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23344>

13 months agospirv2dxil: Enable mediump
Jesse Natalie [Wed, 31 May 2023 20:17:47 +0000 (13:17 -0700)]
spirv2dxil: Enable mediump

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23344>

13 months agomicrosoft/compiler: Handle mediump
Jesse Natalie [Wed, 31 May 2023 20:14:58 +0000 (13:14 -0700)]
microsoft/compiler: Handle mediump

Instead of treating all 16-bit values as "native 16-bit types,"
differentiate between concrete casts and mediump casts, where the
former requires native 16-bit types, and the latter only requires
DXIL min-precision. Additionally, UBO/SSBO loads/stores require
native 16-bit types.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23344>

13 months agomicrosoft/compiler: Always set support_16bit_alu
Jesse Natalie [Wed, 31 May 2023 20:13:54 +0000 (13:13 -0700)]
microsoft/compiler: Always set support_16bit_alu

This just affects some nir opts. If we're lowering 16bit ops anyway,
the optimization doesn't matter.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23344>

13 months agonir: Add preserve_mediump as a shader compiler option
Jesse Natalie [Wed, 31 May 2023 20:10:47 +0000 (13:10 -0700)]
nir: Add preserve_mediump as a shader compiler option

The DXIL backend would like to distinguish between casts to 16-bit
that must cast, vs those that may. If a shader only ever produces
16-bit types from mediump casts and ALU ops on those values, then
the resulting shader can be annotated with DXIL's min-precision
qualifier, basically telling the driver to use 16-bit precision if
it's faster for them. If it uses concrete 16-bit casts, or loads/
stores to externally-visible memory, then it must use the "native"
16-bit flag, which is not supported on all hardware.

Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23344>

13 months agozink: Use PIPE_CAP_FS_POINT_IS_SYSVAL.
Emma Anholt [Mon, 8 May 2023 20:52:44 +0000 (13:52 -0700)]
zink: Use PIPE_CAP_FS_POINT_IS_SYSVAL.

This better matches up to how spirv treats the value.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22950>

13 months agonir/lower_texcoord_replace: Flag SYSTEM_VALUE_POINT_COORD read when we load it.
Emma Anholt [Mon, 8 May 2023 20:56:17 +0000 (13:56 -0700)]
nir/lower_texcoord_replace: Flag SYSTEM_VALUE_POINT_COORD read when we load it.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22950>

13 months agoglsl: Allow invariant flags on sysvals, such as gl_PointCoord.
Emma Anholt [Wed, 10 May 2023 18:11:58 +0000 (11:11 -0700)]
glsl: Allow invariant flags on sysvals, such as gl_PointCoord.

When you set PIPE_CAP_FS_POINT_IS_SYSVAL, we'd fall out of
is_allowed_invariant(), despite it being allowed on special builtins.

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22950>

13 months agogallium/nir/tgsi: add various support for task/mesh bits
Dave Airlie [Mon, 29 May 2023 03:38:00 +0000 (13:38 +1000)]
gallium/nir/tgsi: add various support for task/mesh bits

these translators are used by llvmpipe so need to be updated

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agogallium/cso: add task/mesh shaders to the cso cache
Dave Airlie [Mon, 29 May 2023 03:37:44 +0000 (13:37 +1000)]
gallium/cso: add task/mesh shaders to the cso cache

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agod3d12: don't report mesh/task limits
Dave Airlie [Wed, 31 May 2023 20:40:25 +0000 (06:40 +1000)]
d3d12: don't report mesh/task limits

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agosvga: don't report mesh/task shader limits
Dave Airlie [Wed, 31 May 2023 20:38:51 +0000 (06:38 +1000)]
svga: don't report mesh/task shader limits

Reviewed-by: Neha Bhende <bhenden@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agoradeonsi: don't report shader params for task/mesh
Dave Airlie [Wed, 31 May 2023 20:33:40 +0000 (06:33 +1000)]
radeonsi: don't report shader params for task/mesh

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agocrocus: don't report mesh/task limits
Dave Airlie [Wed, 31 May 2023 20:38:34 +0000 (06:38 +1000)]
crocus: don't report mesh/task limits

Acked-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agoiris: don't return shader params for task/mesh.
Dave Airlie [Wed, 31 May 2023 20:33:22 +0000 (06:33 +1000)]
iris: don't return shader params for task/mesh.

These should be reported as 0 for cso

Acked-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agogallium: add task/mesh shader entrypoints in context
Dave Airlie [Mon, 29 May 2023 03:37:30 +0000 (13:37 +1000)]
gallium: add task/mesh shader entrypoints in context

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agofreedreno: don't report task/mesh.
Dave Airlie [Wed, 31 May 2023 20:43:52 +0000 (06:43 +1000)]
freedreno: don't report task/mesh.

Acked-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agogallium: add a new PIPE_SHADER_MESH_TYPES
Dave Airlie [Mon, 29 May 2023 03:36:45 +0000 (13:36 +1000)]
gallium: add a new PIPE_SHADER_MESH_TYPES

This adds a new limit, changing PIPE_SHADER_TYPES seems frought
with danger and very tricky. Currently only lava/llvmpipe plan to
offer task/mesh in GL land, so let's limit the fallout for now.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agogallium: expand pipe_grid_info to handle task/mesh.
Dave Airlie [Mon, 29 May 2023 03:27:29 +0000 (13:27 +1000)]
gallium: expand pipe_grid_info to handle task/mesh.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agogallium: add task/mesh shader query types to stats interface.
Dave Airlie [Mon, 29 May 2023 03:27:02 +0000 (13:27 +1000)]
gallium: add task/mesh shader query types to stats interface.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23291>

13 months agorusticl/device: limit MAX_PARAMETER_SIZE to 32k
Karol Herbst [Thu, 1 Jun 2023 19:37:49 +0000 (21:37 +0200)]
rusticl/device: limit MAX_PARAMETER_SIZE to 32k

There is no good reason of having it too big and radeonsi returns an
absurd high value through PIPE_SHADER_CAP_MAX_CONST_BUFFER0_SIZE.

This speeds up the CTS testing this device limit.

Signed-off-by: Karol Herbst <git@karolherbst.de>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23378>

13 months agointel/compiler: Fix a fallthrough in components_read() for atomics
Kenneth Graunke [Wed, 31 May 2023 19:15:02 +0000 (12:15 -0700)]
intel/compiler: Fix a fallthrough in components_read() for atomics

In commit 284f0c9a57e17b14c044c04c7cf9ae77d6694492 I refactored the
handling of the data source to just call a helper rather than special
casing opcodes with 0 or 2 sources.  Unfortunately, I also dropped the
"else return 1", creating a fallthrough for all sources other than
SURFACE_LOGICAL_SRC_ADDRESS and SURFACE_LOGICAL_SRC_DATA.

The case below happened to return the correct value for all cases except
SURFACE_LOGICAL_SRC_SURFACE, which has been returning 2 instead of 1
since that commit.

Restore the else case.  Thanks to Marcin Ślusarz for catching this.

Fixes: 284f0c9a57e1 ("intel/compiler: Add an lsc_op_num_data_values() helper")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23347>

13 months agofreedreno/a6xx: Enable gl46
Rob Clark [Sun, 28 May 2023 19:08:28 +0000 (12:08 -0700)]
freedreno/a6xx: Enable gl46

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23301>

13 months agofreedreno/a6xx: GL_ARB_pipeline_statistics_query
Rob Clark [Sun, 28 May 2023 19:03:51 +0000 (12:03 -0700)]
freedreno/a6xx: GL_ARB_pipeline_statistics_query

Handle the other pipeline stats counters in order to implement
GL_ARB_pipeline_statistics_query.  Note that this does away with
collecting *all* the counters if DEBUG_COUNTERS is enabled, other-
wise it was getting over-complicated.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23301>

13 months agofreedreno: Handle compute queries
Rob Clark [Mon, 29 May 2023 15:20:16 +0000 (08:20 -0700)]
freedreno: Handle compute queries

Compute stage can have queries too.  We need to handle that.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23301>

13 months agofreedreno/a6xx: Handle nested pipeline stats queries
Rob Clark [Sun, 28 May 2023 18:15:26 +0000 (11:15 -0700)]
freedreno/a6xx: Handle nested pipeline stats queries

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23301>

13 months agofreedreno/a6xx: Split primitives and pipeline-stats queries
Rob Clark [Sun, 28 May 2023 18:08:53 +0000 (11:08 -0700)]
freedreno/a6xx: Split primitives and pipeline-stats queries

They are really two completely different things.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23301>

13 months agofreedreno/a6xx: GL_ARB_transform_feedback_overflow_query
Rob Clark [Sat, 27 May 2023 18:03:45 +0000 (11:03 -0700)]
freedreno/a6xx: GL_ARB_transform_feedback_overflow_query

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23301>

13 months agofreedreno/a6xx: Remove primitives_relocw()
Rob Clark [Sun, 28 May 2023 17:41:31 +0000 (10:41 -0700)]
freedreno/a6xx: Remove primitives_relocw()

These days we don't track read vs write relocs, so it is the same thing
as primitives_reloc()

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23301>

13 months agofreedreno/a6xx: Fix xfb stream configuration
Rob Clark [Sun, 28 May 2023 15:12:50 +0000 (08:12 -0700)]
freedreno/a6xx: Fix xfb stream configuration

Also, only emit PC_SO_STREAM_CNTL for tess shaders, to align with how
turnip does it.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23301>

13 months agofreedreno/a6xx: Add missing cap
Rob Clark [Sat, 27 May 2023 19:05:57 +0000 (12:05 -0700)]
freedreno/a6xx: Add missing cap

Fixes wrong value reported for GL_MAX_VERTEX_STREAMS.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23301>

13 months agofreedreno/a6xx: Stop using fd_wfi()
Rob Clark [Sat, 27 May 2023 16:27:58 +0000 (09:27 -0700)]
freedreno/a6xx: Stop using fd_wfi()

This was originally intended for earlier gens where certain draw-time
state needed a WFI (because it wasn't banked, etc).  This isn't the case
on a6xx.  So just directly emit WFIs where they are needed.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23301>

13 months agofreedreno/a6xx: Clean up open coded flushes
Rob Clark [Sat, 27 May 2023 15:45:28 +0000 (08:45 -0700)]
freedreno/a6xx: Clean up open coded flushes

Migrate more code to fd6_emit_flushes().

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23301>

13 months agoaco: p_start_linear_vgpr doesn't always need exec mask
Georg Lehmann [Mon, 29 May 2023 14:39:39 +0000 (16:39 +0200)]
aco: p_start_linear_vgpr doesn't always need exec mask

Foz-DB Navi21:
Totals from 1605 (1.21% of 132657) affected shaders:
CodeSize: 14023700 -> 14020320 (-0.02%)
Instrs: 2589881 -> 2589052 (-0.03%)
Latency: 22478420 -> 22473359 (-0.02%)
InvThroughput: 3851237 -> 3851092 (-0.00%)
Copies: 215316 -> 215438 (+0.06%); split: -0.39%, +0.44%

Allows more vcmpx usage.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23302>

13 months agointel/fs: fix a couple of descriptor mistakes
Lionel Landwerlin [Thu, 1 Jun 2023 06:30:37 +0000 (09:30 +0300)]
intel/fs: fix a couple of descriptor mistakes

I found those issues while testing DOOM eternal and Ian also ran into
it with other shaders.

We write the desc register in SIMD1 exec_all, so all the data is in
the first component. We need to make sure to pass that component in
the lower SEND instructions.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Tested-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23354>

13 months agoradv: allow wave32 for geometry shaders
Rhys Perry [Wed, 31 May 2023 14:01:10 +0000 (15:01 +0100)]
radv: allow wave32 for geometry shaders

Because is_ngg wasn't set early enough, radv_get_wave_size() would always
return 64.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23336>

13 months agoac/surface: relax custom pitch requirements to any multiple of 256B on gfx10.3+
Marek Olšák [Mon, 15 May 2023 05:29:44 +0000 (01:29 -0400)]
ac/surface: relax custom pitch requirements to any multiple of 256B on gfx10.3+

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23015>

13 months agoradv: implement setting a custom pitch to any multiple of 256B on gfx10.3+
Marek Olšák [Mon, 15 May 2023 06:53:18 +0000 (02:53 -0400)]
radv: implement setting a custom pitch to any multiple of 256B on gfx10.3+

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23015>

13 months agoradeonsi: implement setting a custom pitch to any multiple of 256B on gfx10.3+
Marek Olšák [Mon, 15 May 2023 05:28:15 +0000 (01:28 -0400)]
radeonsi: implement setting a custom pitch to any multiple of 256B on gfx10.3+

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23015>