Yang Tse [Thu, 24 Nov 2011 17:18:42 +0000 (18:18 +0100)]
lib573.c: fix double data type variable comparison with zero
Yang Tse [Thu, 24 Nov 2011 17:13:09 +0000 (18:13 +0100)]
getinfo.c: reset app connect time when clearing session-info time variables
Yang Tse [Thu, 24 Nov 2011 11:11:52 +0000 (12:11 +0100)]
Fix unreleased regression when using windows gnutls versions older than 2.8
Mark Brand [Tue, 22 Nov 2011 21:48:15 +0000 (22:48 +0100)]
gnutls: only translate winsock errors for old versions
Bugfix: https handshake fails using gnutls 3 on windows
http://sourceforge.net/tracker/index.php?func=detail&aid=3441084&group_id=976&atid=100976
New gnutls versions have an error handler that knows about Winsock
errors, which is why gnutls_transport_set_global_errno() was deprecated
and then removed.
This is a correction of commit f5bb370 (blame me) which meant to
reimplement gnutls_transport_set_global_errno(), which is not necessary.
Daniel Stenberg [Mon, 21 Nov 2011 22:36:21 +0000 (23:36 +0100)]
protocol_connect: show verbose connect and set connect time
Regression: commit
b998d95b (shipped first in release 7.22.0) made the
condition always equal false that should reset the TIMER_CONNECT timer
and call the Curl_verboseconnect() function.
Reported by: "Captain Basil"
Bug: http://curl.haxx.se/mail/archive-2011-11/0035.html
Daniel Stenberg [Sun, 20 Nov 2011 22:33:46 +0000 (23:33 +0100)]
-J -O: use -O name if no Content-Disposition header comes!
A regression between 7.22.0 and 7.23.0 -- downloading a file with the
flags -O and -J results in the content being written to stdout if and
only if there was no Content-Disposition header in the http response. If
there is a C-D header with a filename attribute, the output is correctly
written.
Reported by: Dave Reisner
Bug: http://curl.haxx.se/mail/archive-2011-11/0030.html
Martin Storsjo [Tue, 15 Nov 2011 09:52:32 +0000 (11:52 +0200)]
Add support for using nettle instead of gcrypt as gnutls backend
Jonas Schnelli [Fri, 18 Nov 2011 19:30:46 +0000 (20:30 +0100)]
test: SFTP quote commands with * prefix
Related to the
f64812ca63 commit
Daniel Stenberg [Fri, 18 Nov 2011 19:27:07 +0000 (20:27 +0100)]
CURLOPT_QUOTE: SFTP supports the '*'-prefix now
Jonas Schnelli [Fri, 18 Nov 2011 14:55:09 +0000 (15:55 +0100)]
SFTP: support '*' prefix for quote operations
prefixing a command with '*' means it is allowed to fail without
aborting the chain actions
Daniel Stenberg [Thu, 17 Nov 2011 22:55:36 +0000 (23:55 +0100)]
getsessionid: don't ever return while locked
Also, check for the session sharing bit instead of comparing pointers
Daniel Stenberg [Thu, 17 Nov 2011 22:46:29 +0000 (23:46 +0100)]
Curl_ssl_getsessionid: increase the value, not the pointer
Daniel Stenberg [Thu, 17 Nov 2011 22:43:38 +0000 (23:43 +0100)]
THANKS: one new contributor in 7.23.1
Alejandro Alvarez Ayllon [Thu, 17 Nov 2011 22:34:38 +0000 (23:34 +0100)]
SSL session share: move the age counter to the share object
Previously the age counter would be counted individually in each easy
handle that shared SSL sessions!
Alejandro Alvarez Ayllon [Thu, 17 Nov 2011 22:33:42 +0000 (23:33 +0100)]
libtest build: add the missing lib586
Jason Glasgow [Tue, 12 Apr 2011 15:34:28 +0000 (11:34 -0400)]
CURLOPT_DNS_SERVERS: set name servers if possible
Daniel Stenberg [Thu, 17 Nov 2011 17:29:15 +0000 (18:29 +0100)]
RELEASE-NOTES: correct the release and contributor numbers
Daniel Stenberg [Thu, 17 Nov 2011 17:03:21 +0000 (18:03 +0100)]
FindWin32CACert: return OK even if CA cert isn't found
Bug: http://curl.haxx.se/mail/lib-2011-11/0180.html
Reported by: Mark Brand
Dan Fandrich [Thu, 17 Nov 2011 01:11:31 +0000 (17:11 -0800)]
curl has been built on many Android versions
Daniel Stenberg [Tue, 15 Nov 2011 19:44:49 +0000 (20:44 +0100)]
7.24.0: start the work
Daniel Stenberg [Tue, 15 Nov 2011 19:44:24 +0000 (20:44 +0100)]
THANKS: added 18 new contributors from 7.23.0
Dan Fandrich [Mon, 14 Nov 2011 22:03:31 +0000 (14:03 -0800)]
curl_easy_setopt arguments should be of type long in the examples
Daniel Stenberg [Sat, 12 Nov 2011 09:09:54 +0000 (10:09 +0100)]
RELEASE-NOTES: synced with
10120e6a
one more bug fix and contributor
Daniel Stenberg [Wed, 9 Nov 2011 21:50:36 +0000 (22:50 +0100)]
progress_cb: avoid buffer overflow
The progress bar output function would blindly use the terminal width
without bounds checking. When using a very wide terminal that caused a
buffer overflow and segfault.
We now limit the max bar with to 255 columns, and I simplified the code
to avoid an extra snprintf and buffer.
Bug: http://curl.haxx.se/bug/view.cgi?id=3435710
Reported by: Alexey Zakhlestin
Yang Tse [Fri, 11 Nov 2011 18:46:44 +0000 (19:46 +0100)]
Active mode FTP test cases with server not establishing data connection
591 -> FTP multi PORT and 425 on upload
592 -> FTP multi PORT and 421 on upload
593 -> FTP multi PORT upload, no data conn and no transient neg. reply
594 -> FTP multi PORT upload, no data conn and no positive prelim. reply
1206 -> FTP PORT and 425 on download
1207 -> FTP PORT and 421 on download
1208 -> FTP PORT download, no data conn and no transient negative reply
1209 -> FTP PORT download, no data conn and no positive preliminary reply
Guenter Knauf [Tue, 8 Nov 2011 04:46:46 +0000 (05:46 +0100)]
Fix to skip untrusted certs.
Daniel Stenberg [Sun, 6 Nov 2011 22:42:28 +0000 (23:42 +0100)]
RELEASE-NOTES: synced with
e3166df1bb3
4 new bugfixes, 2 more contributors
Daniel Stenberg [Sun, 6 Nov 2011 15:53:07 +0000 (16:53 +0100)]
ftp PORT: don't hang if bind() fails
When the user requests PORT with a specific port or port range, the code
could lock up in an endless loop. There's now an extra conditional that
makes sure to special treat the error and try the local address only
once so a second failure will abort the loop correctly.
Bug: http://curl.haxx.se/bug/view.cgi?id=3433968
Reported by: Gokhan Sengun
Daniel Stenberg [Sun, 6 Nov 2011 16:38:36 +0000 (17:38 +0100)]
pingpong: change two comments wrongly referring "FTP"
Just a sign of where the code originally was ripped out from. Now it is
generic "pingpong".
Daniel Stenberg [Sun, 6 Nov 2011 16:28:28 +0000 (17:28 +0100)]
test 590: verify the bug fix in
4851dafcf1
This test is created to verify Rene Bernhardt's patch which makes sure
libcurl properly _not_ deals with Negotiate if not asked to even if the
proxy says it can serve it.
Rene Bernhardt [Thu, 3 Nov 2011 22:25:17 +0000 (23:25 +0100)]
HTTP auth: fix proxy Negotiate bug
If a proxy offers several Authentication schemes where NTLM and
Negotiate are offered by the proxy and you tell libcurl not to use the
Negotiate scheme then the request never returns when the proxy answers
with its HTTP 407 reply.
It is reproducible by the following steps:
- Use a proxy that offers NTLM and Negotiate ( CURLOPT_PROXY and
CURLOPT_PROXYPORT )
- Tell libcurl NOT to use Negotiate CURL_EASY_SETOPT(CURLOPT_PROXYAUTH,
CURLAUTH_BASIC | CURLAUTH_DIGEST | CURLAUTH_NTLM )
- Start the request
The call to CURL_EASY_PERFORM never returns. If you switch on debug
logging you can see that libcurl issues a new request As soon as it
received the 407 reply. Instead it should return and set the response
code to 407.
Bug: http://curl.haxx.se/mail/lib-2011-10/0323.html
Yang Tse [Fri, 4 Nov 2011 12:08:37 +0000 (13:08 +0100)]
ssluse.c: fix calling of OpenSSL's ERR_remove_state(0)
Move calling of ERR_remove_state(0) a.k.a ERR_remove_thread_state(NULL)
from Curl_ossl_close_all() to Curl_ossl_cleanup().
In this way ERR_remove_state(0) is now only called in libcurl by
curl_global_cleanup(). Previously it would get called by functions
curl_easy_cleanup(), curl_multi_cleanup and potentially each time a
connection was removed from a connection cache leading to premature
destruction of OpenSSL's thread local state hash.
Multi-threaded apps using OpenSSL enabled libcurl should still call
function ERR_remove_state(0) or ERR_remove_thread_state(NULL) at the
very end end of threads that do not call curl_global_cleanup().
Yang Tse [Thu, 3 Nov 2011 22:26:38 +0000 (23:26 +0100)]
tool_cb_wrt.c: disambiguate warning message
Yang Tse [Thu, 3 Nov 2011 22:21:01 +0000 (23:21 +0100)]
tool_cfgable.c: pending check done
Yang Tse [Thu, 3 Nov 2011 20:56:51 +0000 (21:56 +0100)]
url.c and file.c: fix OOM triggered segfault
Daniel Stenberg [Thu, 3 Nov 2011 08:54:12 +0000 (09:54 +0100)]
rename ftp_ssl: the struct field is used for many protocols
Now called 'use_ssl' instead, which better matches the current CURLOPT
name and since the option is used for all pingpong protocols (at least)
it makes sense to not use 'ftp' in the name.
Daniel Stenberg [Wed, 2 Nov 2011 21:44:22 +0000 (22:44 +0100)]
gtls_connect_step1: remove use of deprecated functions
Use gnutls_priority_set_direct() instead of gnutls_protocol_set_priority().
Remove the gnutls_certificate_type_set_priority() use since x509 is the
default certificate type anyway.
Reported by: Vincent Torri
Yang Tse [Wed, 2 Nov 2011 21:34:41 +0000 (22:34 +0100)]
url.c and transfer.c: nullify connection pointer when free()'ed
Yang Tse [Wed, 2 Nov 2011 12:38:31 +0000 (13:38 +0100)]
FTP test server: NODATACONN commands follow-up
Make NODATACONN425 and NODATACONN421 return a 150 positive preliminary reply
before 425 or 421.
New NODATACONN150 returns 150 without further positive nor negative reply
Now NODATACONN doesn't reply anything at all.
Yang Tse [Tue, 1 Nov 2011 13:38:21 +0000 (14:38 +0100)]
multi.c: OOM handling fix
Yang Tse [Tue, 1 Nov 2011 13:11:36 +0000 (14:11 +0100)]
FTP test server: NODATACONN commands follow-up
Make NODATACONN custom commands apply to both active and passive FTP,
and ensure 425 and 421 are not returned unless data channel usage is
attempted.
Yang Tse [Tue, 1 Nov 2011 11:53:23 +0000 (12:53 +0100)]
tool_cb_see.h: fix compiler warning
Yang Tse [Mon, 31 Oct 2011 21:42:43 +0000 (22:42 +0100)]
setup.h: fix compiler warning
Yang Tse [Mon, 31 Oct 2011 06:29:13 +0000 (07:29 +0100)]
FTP test server: NODATACONN commands commit
c761fcb0 follow-up
Adjustments that make NODATACONN custom commands fully usable.
Dave Reisner [Sun, 30 Oct 2011 03:28:11 +0000 (04:28 +0100)]
doc/curl.1: fix sentence with ending for -# option
Try to be a little more descriptive about the effect of this flag,
rather than parroting what was said in the paragraph just above.
Yang Tse [Sun, 30 Oct 2011 16:12:20 +0000 (17:12 +0100)]
FTP test server: fix server unresponsiveness
Some torture tests left FTP test server in an unresponsive state, resulting
in torture tests that actually completed following unexpected code paths.
Changes in this commit solely address this issue and some adjustments for
ftpserver.pl logging relative to data channel establishment and tear down.
Pending NODATACONN relative adjustments reserved for a further commit.
Yang Tse [Sun, 30 Oct 2011 15:45:14 +0000 (16:45 +0100)]
runtests.pl: running server checks - commit
4464583a follow-up
Ensure verification takes place with no server commands file.
Ignore verbose setting for running server precheck.
Tweak unresponsive server message, to allow detection by haxx.se scripts.
Yang Tse [Sat, 29 Oct 2011 12:58:50 +0000 (14:58 +0200)]
gtls.c: gnutls_transport_set_global_errno() deprecated in version 2.12.3
Yang Tse [Fri, 28 Oct 2011 13:59:36 +0000 (15:59 +0200)]
runtests.pl: running server checks - commit
3676ec96 follow-up
Fix called sub when checking TFTP server, and adjust message.
Yang Tse [Thu, 27 Oct 2011 22:05:16 +0000 (00:05 +0200)]
runtests.pl: running server checks - commit
4464583a follow-up
Extended server checks to others in addition to pingpong when torture testing.
Yang Tse [Thu, 27 Oct 2011 20:00:23 +0000 (22:00 +0200)]
lib589.c: add CURLOPT_READDATA missing stuff
Yang Tse [Thu, 27 Oct 2011 19:46:24 +0000 (21:46 +0200)]
ftpserver.pl: three new custom FTP server commands to disable data channel
NODATACONN421: applies only to active FTP mode, instructs server to not
establish data connection back to client and reply with FTP 421.
NODATACONN425: applies only to active FTP mode, instructs server to not
establish data connection back to client and reply with FTP 425.
NODATACONN: applies to both active and passive FTP modes, instructs server
to not establish nor accept a data channel and fool client into believing
that the data channel connection is possible.
Some polishing probably required.
Yang Tse [Thu, 27 Oct 2011 15:08:02 +0000 (17:08 +0200)]
multi.c: OOM handling fix
Fix curl_multi_cleanup() segfault when using weird cleanup sequence.
Daniel Stenberg [Thu, 27 Oct 2011 10:46:29 +0000 (12:46 +0200)]
multi: start ftp state machine when switching to DO_MORE
This extends the fix from commit
d7934b8bd491
When the multi state is changed within the multi_runsingle from DOING to
DO_MORE, we didn't immediately start the FTP state machine again. That
then left the FTP state in FTP_STOP. When curl_multi_fdset() was
subsequently called, the ftp_domore_getsock() function would return the
wrong fd info.
Reported by: Gokhan Sengun
Daniel Stenberg [Thu, 27 Oct 2011 07:22:15 +0000 (09:22 +0200)]
libcurl-multi.3: update the list of areas still blocking
Yang Tse [Wed, 26 Oct 2011 16:55:35 +0000 (18:55 +0200)]
test 589: active FTP upload using multi timeout and EPRT disabled server
Yang Tse [Wed, 26 Oct 2011 16:46:32 +0000 (18:46 +0200)]
multi tests: OOM handling fixes - commit
629d2e34 follow-up
Patrick Monnerat [Wed, 26 Oct 2011 12:48:20 +0000 (14:48 +0200)]
- Prepare the ILE/RPG binding and OS400 documentation for the upcoming release
Daniel Stenberg [Tue, 25 Oct 2011 21:28:30 +0000 (23:28 +0200)]
RELEASE-NOTES: synced with
4464583a6ed
5 more bug fixes, 4 additional contributors
Yang Tse [Tue, 25 Oct 2011 21:19:36 +0000 (23:19 +0200)]
runtests.pl: running server checks
When running torture tests, verify before each test case that required
pingpong servers which are supposed to be alive are actually responsive.
If found not responsive then restart them.
Daniel Stenberg [Mon, 24 Oct 2011 21:09:59 +0000 (23:09 +0200)]
dist: add test 587
I created test 587 in commit
840eff44f2b but forgot to add the file to
the tarball. Added now.
Daniel Stenberg [Mon, 24 Oct 2011 21:08:16 +0000 (23:08 +0200)]
test 588: verify active FTP with multi interface without EPRT
This is using the verbatim 525 test code but it disables EPRT in the
server and this should work just as well anyway.
Daniel Stenberg [Mon, 24 Oct 2011 20:54:53 +0000 (22:54 +0200)]
FTP server: allow EPRT by default
EPRT is now supported by default by the server. To disable it, use the
generic REPLY instruction in the <servercmd> tag. Test 116 now has it
disabled. All other existing active FTP port tests strip out the port
commands from the logs already so the change of the server isn't that
noticable.
Yang Tse [Mon, 24 Oct 2011 18:42:01 +0000 (20:42 +0200)]
ftp.c: some OOM handling fixes
Yang Tse [Mon, 24 Oct 2011 18:40:25 +0000 (20:40 +0200)]
ftpserver.pl: ensure integral number usage for passive mode string
Daniel Stenberg [Mon, 24 Oct 2011 15:28:41 +0000 (17:28 +0200)]
large headers: have curl accept >16K headers
As commit
5850cc4808ab clarifies, libcurl can deliver header lines that
are longer than CURL_MAX_WRITE_SIZE, only body data is limited to that
size. The curl tool has check (when built debug-enabled) that made the
wrong checks and this new test 1205 verifies that larger headers work.
Daniel Stenberg [Mon, 24 Oct 2011 14:43:53 +0000 (16:43 +0200)]
curl_easy_setopt.3: headers can be CURL_MAX_HTTP_HEADER bytes
Mention this maximum header size for the header callback cases
Daniel Stenberg [Mon, 24 Oct 2011 11:11:43 +0000 (04:11 -0700)]
Merge pull request #25 from trtom/master
make sure the static build uses the static build option!
Daniel Stenberg [Sun, 23 Oct 2011 22:13:47 +0000 (00:13 +0200)]
curl_easy_setopt.3: fix typo
shoot, Dan Fandrich already had this pointed out...
Steve Holme [Fri, 21 Oct 2011 21:59:50 +0000 (22:59 +0100)]
curl_easy_setopt: Added pop3 to CURLOPT_URL.
Added pop3 username and password example as well as an explanation of
how path part of the URL is used under pop3.
Additionally have corrected a couple of typos.
Yang Tse [Sat, 22 Oct 2011 12:46:49 +0000 (14:46 +0200)]
tool_operate.c: OOM handling fix
Move curl_easy_perform source code geneartion out of curl_easy_perform's loop
for proper OOM handling and source code geneartion.
Daniel Stenberg [Fri, 21 Oct 2011 21:36:54 +0000 (23:36 +0200)]
curl_multi_fdset: correct fdset with FTP PORT use
After a PORT has been issued, and the multi handle would switch to the
CURLM_STATE_DO_MORE state (which is unique for FTP), libcurl would
return the wrong fdset to wait for when curl_multi_fdset() is
called. The code would blindly assume that it was waiting for a connect
of the second connection, while that isn't true immediately after the
PORT command.
Also, the function multi.c:domore_getsock() was highly FTP-centric and
therefore ugly to keep in protocol-agnostic code. I solved this problem
by introducing a new function pointer in the Curl_handler struct called
domore_getsock() which is only called during the DOMORE state for
protocols that set that pointer.
The new ftp.c:ftp_domore_getsock() function now returns fdset info about
the control connection's command/response handling while such a state is
in use, and goes over to waiting for a writable second connection first
once the commands are done.
The original problem could be seen by running test 525 and checking the
time stamps in the FTP server log. I can verify that this fix at least
fixes this problem.
Bug: http://curl.haxx.se/mail/lib-2011-10/0250.html
Reported by: Gokhan Sengun
Dan Fandrich [Fri, 21 Oct 2011 20:30:22 +0000 (13:30 -0700)]
Added some missing test case XML tags and keywords
Yang Tse [Fri, 21 Oct 2011 14:40:02 +0000 (16:40 +0200)]
file.c: OOM handling fix
file_disconnect() free's resources for multi API
Yang Tse [Fri, 21 Oct 2011 14:37:13 +0000 (16:37 +0200)]
multi.c: fix segfault
Yang Tse [Fri, 21 Oct 2011 14:34:37 +0000 (16:34 +0200)]
runtests.pl: fix printing of multivalued error codes
Yang Tse [Fri, 21 Oct 2011 14:26:18 +0000 (16:26 +0200)]
multi tests: OOM handling fixes
Additionally, improved error checking and logging.
Dan Fandrich [Fri, 21 Oct 2011 00:54:18 +0000 (17:54 -0700)]
Fixed compilation when HTTP or cookies are disabled
Daniel Stenberg [Thu, 20 Oct 2011 11:11:10 +0000 (13:11 +0200)]
KNOWN_BUGS: #74 fixed
Multiple auths in the same WWW-Authenticate header
Fixed in commit
7d81e3f7193b8c
Daniel Stenberg [Thu, 20 Oct 2011 11:05:09 +0000 (13:05 +0200)]
Curl_http_input_auth: handle multiple auths in WWW-Authenticate
The fix is pretty much the one Nick Zitzmann provided, just edited to do
the right indent levels and with test case 1204 added to verify the fix.
Bug: http://curl.haxx.se/mail/lib-2011-10/0190.html
Reported by: Nick Zitzmann
Daniel Stenberg [Thu, 20 Oct 2011 10:58:26 +0000 (12:58 +0200)]
Curl_smtp_escape_eob: first byte is index 0...
Fix a bug with with commit
2621dd42a4d that happened due to my last
second pre-commit cleanup of the change without proper testing
afterwards!
Daniel Stenberg [Thu, 20 Oct 2011 06:48:15 +0000 (08:48 +0200)]
CURLM_CALL_MULTI_PERFORM: remove mention
This return code has not been used since 7.20.0 so we can stop
mentioning it for current libcurl.
Dan Fandrich [Thu, 20 Oct 2011 04:18:52 +0000 (21:18 -0700)]
Silenced a compiler warning about an unused variable
Tim Harder [Wed, 19 Oct 2011 08:08:56 +0000 (10:08 +0200)]
gtls: only call gnutls_transport_set_lowat with <gnutls-2.12.0
The default lowat level for gnutls-2.12* is set to zero to avoid
unnecessary system calls and the gnutls_transport_set_lowat function has
been totally removed in >=gnutls-3 which causes build failures.
Therefore, the function shouldn't be used except for versions that
require it, <gnutls-2.12.0.
Daniel Stenberg [Wed, 19 Oct 2011 22:13:09 +0000 (00:13 +0200)]
Curl_smtp_escape_eob: fix EOB escaping
As the EOB string can come byte by byte over a series of writes we must
match byte-wise.
Bug: http://curl.haxx.se/mail/lib-2011-10/0172.html
Daniel Stenberg [Tue, 18 Oct 2011 20:34:32 +0000 (22:34 +0200)]
RELEASE-NOTES: synced with
ecbb08cea3cd6
Daniel Stenberg [Mon, 17 Oct 2011 20:01:09 +0000 (22:01 +0200)]
singleipconnect: unstick the ipv6-connection boolean
Previously the bit was set before the connection was found working so if
it would first fail to an ipv6 address and then connect fine to a IPv4
address the variable would still be TRUE.
Reported by: Thomas L. Shinnick
Bug: http://curl.haxx.se/bug/view.cgi?id=3421912
Kamil Dudka [Tue, 6 Sep 2011 16:17:38 +0000 (18:17 +0200)]
nss: avoid a SIGSEGV with immature version of NSS
Bug: https://bugzilla.redhat.com/733685
Kamil Dudka [Fri, 26 Aug 2011 13:43:48 +0000 (15:43 +0200)]
nss: big cleanup in nss_load_cert() and cert_stuff()
Kamil Dudka [Fri, 26 Aug 2011 12:53:26 +0000 (14:53 +0200)]
nss: refactor fmt_nickname() -> dup_nickname()
Do not use artificial nicknames for certificates from files.
Kamil Dudka [Fri, 26 Aug 2011 12:38:18 +0000 (14:38 +0200)]
nss: select client certificates by DER
... instead of nicknames, which are not unique.
Daniel Stenberg [Sun, 16 Oct 2011 22:04:43 +0000 (00:04 +0200)]
--epsv: fix typo
Reported by: Thomas L. Shinnick
Daniel Stenberg [Sun, 16 Oct 2011 21:39:59 +0000 (23:39 +0200)]
--show-error: position indepdenent
Previously we required that -S/--show-error was used _after_
-s/--silent. This was slightly confusing since we strive to make
arguments as position independent as possible.
Now, you can use them in any order and the result should still be the
same.
Bug: http://curl.haxx.se/bug/view.cgi?id=3424286
Reported by: Andreas Olsson
Daniel Stenberg [Sun, 16 Oct 2011 21:38:48 +0000 (23:38 +0200)]
curl_multi_fdset: clarify the max_fd == -1 case
Elaborate what max_fd == -1 means
Remove the reference to CURLM_CALL_MULTI_PERFORM as modern libcurl
versions don't ever return that.
Daniel Stenberg [Sat, 15 Oct 2011 23:07:29 +0000 (01:07 +0200)]
formdata: ack read callback abort
When doing a multipart formpost with a read callback, and that callback
returns CURL_READFUNC_ABORT, that return code must be properly
propagated back and handled accordingly. Previously it would be handled
as a zero byte read which would cause a hang!
Added test case 587 to verify. It uses the lib554.c source code with a
small ifdef.
Reported by: Anton Bychkov
Bug: http://curl.haxx.se/mail/lib-2011-10/0097.html
Daniel Stenberg [Sat, 15 Oct 2011 23:06:48 +0000 (01:06 +0200)]
TODO: have form functions use CURL handle argument
Dave Reisner [Tue, 11 Oct 2011 01:24:40 +0000 (03:24 +0200)]
typecheck: allow NULL to unset CURLOPT_ERRORBUFFER
There might be situations where a user would want to unset this option.
Avoid forcing him/her to cast the NULL argument to (char *) in order to
get past the compile time typecheck.
Daniel Stenberg [Sat, 15 Oct 2011 21:44:28 +0000 (23:44 +0200)]
singleipconnect: don't clobber errno
Save the errno value immediately after a connect() failure so that it
won't get reset to something else before we read it.
Bug: http://curl.haxx.se/mail/lib-2011-10/0066.html
Reported by: Frank Van Uffelen and Fabian Hiernaux
Michal Marek [Thu, 13 Oct 2011 08:51:17 +0000 (10:51 +0200)]
docs: --xattr
Yang Tse [Fri, 14 Oct 2011 16:23:16 +0000 (18:23 +0200)]
file.c: fix compiler warning