Gustavo Lima Chaves [Tue, 31 Jul 2012 22:06:41 +0000 (22:06 +0000)]
[elm] Progressbar now inheritable.
SVN revision: 74689
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:06:36 +0000 (22:06 +0000)]
[elm] List now inheritable.
SVN revision: 74688
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:06:31 +0000 (22:06 +0000)]
[elm] Slider now inheritable.
SVN revision: 74687
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:06:26 +0000 (22:06 +0000)]
[elm] Naviframe now inheritable.
SVN revision: 74686
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:06:21 +0000 (22:06 +0000)]
[elm] Conformant now inheritable.
SVN revision: 74685
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:06:16 +0000 (22:06 +0000)]
[elm] Actionslider now inheritable.
SVN revision: 74684
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:06:11 +0000 (22:06 +0000)]
[elm] Bring header files install rule up to date.
SVN revision: 74683
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:06:06 +0000 (22:06 +0000)]
[elm] Genlist now inheritable.
Widgets having internal panning objects won't have so fancy inheriting
schemas for those very objects, but they should be fine with
re-defining their own, if they want/need and overwriting it in their
smart_add()s.
SVN revision: 74682
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:06:00 +0000 (22:06 +0000)]
[elm] Slideshow now inheritable.
SVN revision: 74681
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:05:55 +0000 (22:05 +0000)]
[elm] Scroller now inheritable.
SVN revision: 74680
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:05:50 +0000 (22:05 +0000)]
[elm] Here, better.
SVN revision: 74679
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:05:43 +0000 (22:05 +0000)]
[elm] Hover now inheritable.
SVN revision: 74678
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:05:38 +0000 (22:05 +0000)]
[elm] Inheritance tweeks on layout.
SVN revision: 74677
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:05:33 +0000 (22:05 +0000)]
[elm] Mapbuf now inheritable.
SVN revision: 74676
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:05:27 +0000 (22:05 +0000)]
[elm] Notify now inheritable.
SVN revision: 74675
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:05:22 +0000 (22:05 +0000)]
[elm] Elm container a little bit more
future-proof.
SVN revision: 74674
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:05:17 +0000 (22:05 +0000)]
[elm] Route now inheritable.
SVN revision: 74673
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:05:12 +0000 (22:05 +0000)]
[elm] Plug now inheritable.
SVN revision: 74672
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:05:06 +0000 (22:05 +0000)]
[elm] Grid now inheritable.
SVN revision: 74671
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:05:00 +0000 (22:05 +0000)]
[elm] Diskselector now inheritable.
SVN revision: 74670
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:04:54 +0000 (22:04 +0000)]
[elm] Glview now inheritable.
SVN revision: 74669
Gustavo Lima Chaves [Tue, 31 Jul 2012 22:04:45 +0000 (22:04 +0000)]
[elm] Web now inheritable.
We still gotta find a way to use our scrolling infra with it.
SVN revision: 74668
Gustavo Sverzut Barbieri [Tue, 31 Jul 2012 20:07:09 +0000 (20:07 +0000)]
genlist: full-cell contents style.
item style "full" will have a single SWALLOW part that covers the
whole item. This is great when you have more complex visual that do
not fit a standard style yet you don't want to create your own style
for it.
SVN revision: 74665
Carsten Haitzler [Tue, 31 Jul 2012 12:31:31 +0000 (12:31 +0000)]
chlog++
SVN revision: 74651
Kim Shinwoo [Tue, 31 Jul 2012 12:30:48 +0000 (12:30 +0000)]
From: Kim Shinwoo <kimcinoo.efl@gmail.com>
Subject: [E-devel] [patch][elementary] ctxpopup, focus-chain
i'd like to raise an issue about focus chain on the ctxpopup. the focus
would go around only in the ctxpopup. (IMHO, raster keep the previous
popup
patch. so definitely!!)
but.. first of all, current ctxpopup does not have focus_next(). even
though there is focus_next(), it is not work properly,
because the parent of ctxpopup would be a widget which does not take
care
of sub objects in the focus_next(); such as elm_list.
(every widget can be a parent of ctxpopup, if the widget is enough
size to
display ctxpopup. thus the elm_list can be a parent of ctxpopup also).
anyhow, to resolve this issue, the patch uses event() of
elm_widget_event_hook_set().
the ctxpopup item is equal to the elm_list item. but the focus chain of
elm_list does not work properly.
generally, we use 'Tab' key to move focus, but elm_list uses the
(up,down)
arrow key moreover it is not a focus.
if you want to check this patch, it would be better to use
ELM_ACCESS_MODE=1.
SVN revision: 74650
Kim Shinwoo [Tue, 31 Jul 2012 12:24:58 +0000 (12:24 +0000)]
From: Kim Shinwoo <kimcinoo.efl@gmail.com>
Subject: [E-devel] [patch][elementary] dayselector - focus chain, and
about accessibility policy.
dayselector does not work in focus cycle because there is no
focus_chain().
because dayselctor is a child of Elm_Layout_Smart_Class, so it is
enough to
use focus_chain() of layout.
and.. very carefully..
i'd like to raise an issue that currently visually impaired person
should
be obliged to click(tap) quickly two times to activate widget such as
button, check.
the implementation to check 2nd click in elm_access is great. but one
single click is enough to activate button or change state of elm_check.
moreover some widgets like dayselector which has customized style for
elm_check does not work properly, because they do something at signal
'mouse,down,1'.
SVN revision: 74649
Carsten Haitzler [Tue, 31 Jul 2012 12:19:15 +0000 (12:19 +0000)]
fix 1 liner oops in smart member add handler.. yet AGAIN runing the
smart member add... :)
SVN revision: 74648
Kim Shinwoo [Tue, 31 Jul 2012 11:12:00 +0000 (11:12 +0000)]
From: Kim Shinwoo <kimcinoo.efl@gmail.com>
Subject: [E-devel] [patch][elementary] naviframe - focus chain, access
i have attached a patch to fix focus chin issue when the item title is not
visible. and to add accessibility feature.
SVN revision: 74646
Daniel Juyung Seo [Tue, 31 Jul 2012 11:02:30 +0000 (11:02 +0000)]
elm test_gengrid.c: Added bring_in/show buttons.
SVN revision: 74644
Daniel Juyung Seo [Tue, 31 Jul 2012 11:02:27 +0000 (11:02 +0000)]
elm gengrid: Fixed item_show bug.
SVN revision: 74643
Christopher Michael [Tue, 31 Jul 2012 06:04:52 +0000 (06:04 +0000)]
Elm: Update label example to move labels so they do not overlap and
actually call evas_object_move on one that was missing it.
SVN revision: 74614
Gustavo Lima Chaves [Mon, 30 Jul 2012 22:36:50 +0000 (22:36 +0000)]
[elm] Map now inheritable.
SVN revision: 74610
Gustavo Lima Chaves [Mon, 30 Jul 2012 22:36:38 +0000 (22:36 +0000)]
[elm] Icon now inheritable.
SVN revision: 74609
Gustavo Lima Chaves [Mon, 30 Jul 2012 22:36:29 +0000 (22:36 +0000)]
[elm] Remove unused var.
SVN revision: 74608
Gustavo Lima Chaves [Mon, 30 Jul 2012 22:36:19 +0000 (22:36 +0000)]
[elm] Image now (better) inheritable.
SVN revision: 74607
Gustavo Lima Chaves [Mon, 30 Jul 2012 22:36:06 +0000 (22:36 +0000)]
[elm] Photocam now inheritable.
SVN revision: 74606
Gustavo Lima Chaves [Mon, 30 Jul 2012 22:35:55 +0000 (22:35 +0000)]
[elm] Menu now inheritable.
SVN revision: 74605
Gustavo Lima Chaves [Mon, 30 Jul 2012 22:35:44 +0000 (22:35 +0000)]
[elm] Thumb now inheritable.
SVN revision: 74604
Gustavo Lima Chaves [Mon, 30 Jul 2012 22:35:32 +0000 (22:35 +0000)]
[elm] Table now inheritable.
SVN revision: 74603
Gustavo Lima Chaves [Mon, 30 Jul 2012 22:35:22 +0000 (22:35 +0000)]
[elm] Making box inheritable.
SVN revision: 74602
Gustavo Lima Chaves [Mon, 30 Jul 2012 22:35:11 +0000 (22:35 +0000)]
[elm] Making photo inheritable.
SVN revision: 74601
Gustavo Lima Chaves [Mon, 30 Jul 2012 22:34:57 +0000 (22:34 +0000)]
[elm] Permit multipe object
attachments/detachments from a scrollable iface.
SVN revision: 74600
Christopher Michael [Mon, 30 Jul 2012 10:06:28 +0000 (10:06 +0000)]
Elm: Account for framespace when resizing frame object. Do not need to
account for it in any other case.
SVN revision: 74569
Cedric BAIL [Mon, 30 Jul 2012 09:02:23 +0000 (09:02 +0000)]
elementary: defert Elm_Calendar generation until needed.
NOTE: The new infra is awesome ! That was a piece of cake once
I understand how it work. I love it !
SVN revision: 74562
Christopher Michael [Mon, 30 Jul 2012 07:18:16 +0000 (07:18 +0000)]
Elm: Formatting.
SVN revision: 74554
Cedric BAIL [Mon, 30 Jul 2012 07:14:33 +0000 (07:14 +0000)]
elementary: add thaw/freeze to Elm_Layout and use it in Elm_Calendar.
NOTE: This improve calendar performance quite a lot, but a better improvement
would be to populate the object when we really need it. I don't know how to
do that in current Elementary source code. Reason for another expected massive
improvement is that every time you set a property on an Elm_Calendar trigger
a populate and that one is costly (Around 6 populates call per Elm_Calendar in
our code example, meaning doing it could give us a 6 times boost...).
SVN revision: 74553
Jihoon Kim [Mon, 30 Jul 2012 06:50:44 +0000 (06:50 +0000)]
elm_main.c: fix typo
SVN revision: 74552
Cedric BAIL [Sat, 28 Jul 2012 13:32:53 +0000 (13:32 +0000)]
elementary: catching double and triple clicks in spinner.
Patch by Jean-Philippe André <jpeg@videolan.org>
SVN revision: 74529
Cedric BAIL [Sat, 28 Jul 2012 13:29:50 +0000 (13:29 +0000)]
elementary: round up the spinning speed when the step is too small with a warning message.
Patch by Jean-Philippe André <jpeg@videolan.org>
SVN revision: 74528
Kim Shinwoo [Fri, 27 Jul 2012 02:27:16 +0000 (02:27 +0000)]
From: Kim Shinwoo <kimcinoo.efl@gmail.com>
Subject: [E-devel] [patch][elementary] popup - focus chain,
accessibility
you would be in rush because of freezing.. but there is still hot. -_-;
i'd like to raise an issue about focus chain on the popup. The focus would
go around only in the popup. (IMHO)
but current popup gives a chance to get the focus to other widget which is
not in the popup.
please check the attachment which has accessibility feature also and give
your opinion. thanks.
SVN revision: 74467
Gustavo Sverzut Barbieri [Thu, 26 Jul 2012 23:12:18 +0000 (23:12 +0000)]
check/toggle: toggle on click.
If we just clicked a toggle, we should toggle it. No need to drag.
SVN revision: 74461
Gustavo Sverzut Barbieri [Thu, 26 Jul 2012 20:50:34 +0000 (20:50 +0000)]
naviframe: always keep title centered
if there is a button, consider the same amount on the other side, even
if there is no button in there, limited to the maximum button size
(100px). It's not optimal, but looks less ugly.
SVN revision: 74451
Gustavo Sverzut Barbieri [Thu, 26 Jul 2012 19:39:10 +0000 (19:39 +0000)]
naviframe: improve automatic previous button without breaking compatibility.
proper fix instead of r74428.
SVN revision: 74450
Gustavo Sverzut Barbieri [Thu, 26 Jul 2012 19:21:27 +0000 (19:21 +0000)]
naviframe: fix missing clips spotted by elementary_config.
as Tasn reported elementary_config was broken as the naviframe title
was covering the toolbar. This was due its usage of
elm_naviframe_item_simple_push() that uses
elm_naviframe_item_title_visible_set(FALSE) and a missing clipper on
my part.
SVN revision: 74449
Carsten Haitzler [Thu, 26 Jul 2012 09:10:25 +0000 (09:10 +0000)]
lets not break theme api :( sorry. :(
SVN revision: 74428
Carsten Haitzler [Thu, 26 Jul 2012 06:41:22 +0000 (06:41 +0000)]
setitng min/max size hint on an elm obj actually should not be done
because elm controls these itself. examples all wrong in thsi regard.
fix!
SVN revision: 74414
Daniel Juyung Seo [Thu, 26 Jul 2012 05:50:31 +0000 (05:50 +0000)]
elm genlist: Enhance genlist item unrealize performance by
initializing text parts first. Patch by Bluezery <ohpowel@gmail.com>
On Thu, Jul 26, 2012 at 2:29 PM, Bluezery <ohpowel@gmail.com> wrote:
> Hello,
>
> This patch make genlist free their text parts when each item is
unrealized.
> Before this patch, the item is just cached when an item is unrealized
> and the text part is freed and set by other text when the cached item
> is realized.
> This improves scrolling performance with very long text because this
> can reduce needless edje size recalculation time.
> Please review this patch.
>
SVN revision: 74413
Daniel Juyung Seo [Thu, 26 Jul 2012 05:50:21 +0000 (05:50 +0000)]
elm genlist: Fixed garbage item issue in decorate all mode.
This fixes "elm - genlist decorate all mode on and scroll - garbage
items left around."
Note: Do not manipulate swallowed items. Unswallow it first then
manipulate it.
SVN revision: 74412
WooHyun Jung [Thu, 26 Jul 2012 04:36:12 +0000 (04:36 +0000)]
elementary/elm_toolbar : Toolbar didn't get key_down event because
there was no evas focus. And add event_hook for JaeHwan :)
SVN revision: 74411
ChunEon Park [Thu, 26 Jul 2012 04:26:31 +0000 (04:26 +0000)]
naviframe - removed unnecessary line
SVN revision: 74410
Kim Shinwoo [Thu, 26 Jul 2012 03:57:25 +0000 (03:57 +0000)]
From: Kim Shinwoo <kimcinoo.efl@gmail.com>
Subject: [E-devel] [patch][elementary] popup - getting proper geometry value]
current popup does not give proper geometry value,
evas_object_geometry_get(popup, &x, &y, &w, &h) gives 0, 0, 0, 0.
the patch resolves it, but it would be not a good way to get geometry
value. which is the best way to set obj->cur.geometry.x(y,w,h)?
please enlighten me. thanks.
SVN revision: 74409
Gustavo Sverzut Barbieri [Wed, 25 Jul 2012 22:42:21 +0000 (22:42 +0000)]
segment control: improve test, show broken theme.
segment control theme is broken and non-standard. It should be like a
button in internals.
SVN revision: 74407
Gustavo Lima Chaves [Wed, 25 Jul 2012 22:03:15 +0000 (22:03 +0000)]
[elm] One more scrolling hook that must be there
till I address it.
SVN revision: 74406
Gustavo Lima Chaves [Wed, 25 Jul 2012 22:03:07 +0000 (22:03 +0000)]
[elm] Some oopsies--.
SVN revision: 74405
Gustavo Sverzut Barbieri [Wed, 25 Jul 2012 22:02:29 +0000 (22:02 +0000)]
check: fix visual annoyances for toggle.
toggle was clipping the drag knob and this always annoyed me. Now it's
on top of frame and makes me happy.
SVN revision: 74404
Gustavo Sverzut Barbieri [Wed, 25 Jul 2012 21:08:53 +0000 (21:08 +0000)]
naviframe improvements:
- fixed theme to look less like an arse:
- overlap theme is translucent
- naviframe title visibility toggle is now animated
- item pop/push animation now applies to title area as well
- icon without title label is now centered (see Naviframe 2 test)
- title label and subtitle are now centered among the free space, should not overlap buttons anymore.
- title will use a font-size range, trying to not overlap buttons anymore.
- title will use ellipsis, trying to not overlap buttons anymore.
- prev/next buttons do not have a fixed min/max size anymore
- emit signals elm,state,title_label,show and elm,state,title_label,hide
- by default the previous button label is the title of the previous page
however by using a regular elm_button with an icon and long label
exposes a bug with button theme. And there is a conceptual issue: if
the previous button label is too big, it will look horrible. We should
have a maximum size that, if reached, should have ellipsis. This
should be a different elm_button style, with
elm/button/base/naviframe/back_btn/default being an alias to it.
SVN revision: 74403
Daniel Juyung Seo [Wed, 25 Jul 2012 21:07:54 +0000 (21:07 +0000)]
elm genlist.h: Added more description about elm_genlist_homogeneous_set.
SVN revision: 74402
Gustavo Sverzut Barbieri [Wed, 25 Jul 2012 17:38:48 +0000 (17:38 +0000)]
naviframe: back button text defaults to previous page title.
SVN revision: 74401
Gustavo Sverzut Barbieri [Wed, 25 Jul 2012 17:29:17 +0000 (17:29 +0000)]
test_naviframe: use standard icons, recommended elm_layout_content_set().
SVN revision: 74400
Gustavo Sverzut Barbieri [Wed, 25 Jul 2012 17:20:34 +0000 (17:20 +0000)]
naviframe: improve default back button.
back button now uses standard icon "arrow_left", and provides a "Back"
text that should be translated with the application.
Then we can define the elm/button/base/naviframe/back_btn/default as
an alias to the default button. If a theme wants it could still
provide an alternative button. IOW no breaks.
SVN revision: 74399
Jihoon Kim [Wed, 25 Jul 2012 14:55:04 +0000 (14:55 +0000)]
elm: fix typos
SVN revision: 74397
Gustavo Lima Chaves [Wed, 25 Jul 2012 14:39:03 +0000 (14:39 +0000)]
[elm] Apparently I missed part aliasing for the
alien naviframe case.
SVN revision: 74395
Carsten Haitzler [Wed, 25 Jul 2012 11:19:59 +0000 (11:19 +0000)]
fix fileselctor to not display > next to files... in expand mode.
SVN revision: 74386
Carsten Haitzler [Wed, 25 Jul 2012 11:11:51 +0000 (11:11 +0000)]
fix player theme to work in both illume and standard and not be
unusable/look like arse
SVN revision: 74385
WooHyun Jung [Wed, 25 Jul 2012 10:28:51 +0000 (10:28 +0000)]
elementary / elc_popup : Add focus direction for popup.
SVN revision: 74383
Carsten Haitzler [Wed, 25 Jul 2012 10:00:25 +0000 (10:00 +0000)]
oops printf--
SVN revision: 74381
Carsten Haitzler [Wed, 25 Jul 2012 09:56:00 +0000 (09:56 +0000)]
fix auicklaunch to transport environment as well as args. fixes
startup id tracking for e.
SVN revision: 74380
Daniel Juyung Seo [Wed, 25 Jul 2012 05:03:53 +0000 (05:03 +0000)]
elm test_genlist.c: Fix wrong callback name.
SVN revision: 74370
WooHyun Jung [Wed, 25 Jul 2012 02:43:32 +0000 (02:43 +0000)]
elementary/elm_widget : focus_region function in elm_scroller was not
executed because of _elm_legacy_is always returned EINA_FALSE. So I removed
it.
SVN revision: 74367
WooHyun Jung [Wed, 25 Jul 2012 02:39:33 +0000 (02:39 +0000)]
elementary/elm_scroller : Focus direction failed on elm_scroller.
So I fixed.
SVN revision: 74366
Jihoon Kim [Wed, 25 Jul 2012 01:52:43 +0000 (01:52 +0000)]
[elm] fix typos in elementary_test
SVN revision: 74362
Gustavo Sverzut Barbieri [Tue, 24 Jul 2012 21:57:11 +0000 (21:57 +0000)]
flip: proper api: elm_flip_go_to().
In real world it's very likely you're flipping to something, back or
front, not randomly flipping around based on one button.
I'd say we should deprecate the elm_flip_go().
SVN revision: 74360
Gustavo Sverzut Barbieri [Tue, 24 Jul 2012 21:39:12 +0000 (21:39 +0000)]
flip: make quick sequence of "go" work.
whenever we "go" flip while flipping, we'll enter an inconsitent
state. We should detect where to flip and flip back if required.
Test: go to "Flip" test, click "1" button twice, before the first
animation ends.
SVN revision: 74359
Gustavo Lima Chaves [Tue, 24 Jul 2012 17:34:06 +0000 (17:34 +0000)]
[elm] Also don't advertise this type on our tree
figures.
SVN revision: 74358
Gustavo Lima Chaves [Tue, 24 Jul 2012 17:33:58 +0000 (17:33 +0000)]
[elm] This must be an internal object.
SVN revision: 74357
Carsten Haitzler [Tue, 24 Jul 2012 09:35:27 +0000 (09:35 +0000)]
printf--
SVN revision: 74349
Carsten Haitzler [Tue, 24 Jul 2012 04:59:45 +0000 (04:59 +0000)]
fix layer bug with floating popup object in slider i added just before
freeze.
SVN revision: 74343
Carsten Haitzler [Tue, 24 Jul 2012 04:35:08 +0000 (04:35 +0000)]
fix name of title/name of 3d test window
SVN revision: 74341
Daniel Juyung Seo [Tue, 24 Jul 2012 03:08:10 +0000 (03:08 +0000)]
elm genlist.h: Added more description for elm_genlist_item_update.
SVN revision: 74335
ChunEon Park [Tue, 24 Jul 2012 02:35:25 +0000 (02:35 +0000)]
elementary/scroller - Fixed scroller to not have the hold flag which causes the edje object up event block.
Please review this patch I don't know the intention why did someone add this flags on mouse up in scroller.
Anyhow I tested and works fine.
SVN revision: 74334
Carsten Haitzler [Mon, 23 Jul 2012 12:35:48 +0000 (12:35 +0000)]
fix segv on popup... with items. infinite stack blow. but oh my there
is so much more to fix.. i don't know where to begin.
SVN revision: 74324
ChunEon Park [Mon, 23 Jul 2012 11:16:42 +0000 (11:16 +0000)]
elementary - Updated Changelog
SVN revision: 74320
ChunEon Park [Mon, 23 Jul 2012 08:23:01 +0000 (08:23 +0000)]
elementary/win - fixed invalid sd memory access catched by valgrind.
now, more simple and clear!
SVN revision: 74310
Jaehwan Kim [Mon, 23 Jul 2012 01:59:41 +0000 (01:59 +0000)]
The label should be inserted and the visible signal should be emitted, only when the text exists.
SVN revision: 74304
Gustavo Lima Chaves [Fri, 20 Jul 2012 20:38:18 +0000 (20:38 +0000)]
[elm] Oopsie--.
SVN revision: 74259
Gustavo Lima Chaves [Fri, 20 Jul 2012 14:58:39 +0000 (14:58 +0000)]
[elm] Fix changed API call for webkit.
SVN revision: 74256
Gustavo Lima Chaves [Fri, 20 Jul 2012 14:58:33 +0000 (14:58 +0000)]
[elm] Fix on focus handle on photocam.
SVN revision: 74255
Gustavo Lima Chaves [Fri, 20 Jul 2012 14:58:21 +0000 (14:58 +0000)]
[elm] Removing unused var.
SVN revision: 74254
Carsten Haitzler [Fri, 20 Jul 2012 10:08:08 +0000 (10:08 +0000)]
fix OTHER segv in colorselector! the one cedric didn't find!
SVN revision: 74228
Carsten Haitzler [Fri, 20 Jul 2012 08:42:52 +0000 (08:42 +0000)]
lets not have the getsure layer 3 test us ea timer - bad bad bad style
and jerky anim! :(
SVN revision: 74220