Clean up some SonarQube warnings (trailing whitespace, etc).

Clean up trailing whitespace and removed Windows line endings from
most text files to address SonarQube warnings.  As a side effect of
this clean-up, several files that should not have been executable had
their executable permission bit removed.

Change-Id: Ie388df6e383219cdebfb56ba8fa86cacf2ca3e46
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1980
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix invalid memory access on resource cache module.

invalidate callback in deleted instance.

Change-Id: Ica3028700935c0cef062719a43affc5f4754a336
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1972
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

RI Sample for Tizen

working RI Sample for Tizen

Change-Id: Idba74286734d2159b128ddde55cc588bbb19cbea
Signed-off-by: vimala.v <vimala.v@samsung.com>
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1719
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Modify resourceCache unittest buildscript to fix gcc bug

- on gcc-4.6 in linux 64bit environment, gcc bug is occurred.
  To fix it, remove the '-Wnoexcept' option in the SConscript file
- additionally, remove constructor, destructor on the unittest class
  to prevent build error(noexcept tag) on gcc-4.8

Change-Id: I411ca979e607cdfe33ea50f9fe32b88b434320ed
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1970
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Modify DataCache code files to support thread synchronization

- add thread synchronization for the subscriberList
- modify notifyObservers()'s parameter to const variable

Change-Id: I13e18a56be2ec2f6e7e4c0eadc371161dc6b5f3b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1949
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix a callback problem of PrimitiveResource

The problem was calling the callback even after the object for it was gone.
PrimitiveResource is only created with shared_ptr and callbacks are async operations.
When received the response, there is a possibility that no one holds the resource.

Now checks the object is alive before executing the callback.

Change-Id: I07b20d251c2b8544e7d27f354193b53c910d579c
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1950
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

modified comment for doxygen.

Fixed several files with out of date or
incorrect doxygen comments

Change-Id: Iddd76b6aed32de74c819d3794e6845401561bae5
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1939
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

modified Sconscript in Blockwise transfer

- BWT was not enabling in multiple selection case.
  ex) TARGET_TRANSPORT=BLE,IP
- added PDU null checker. (fixed IOT-647 issue)

Change-Id: I2ea5439d57cae63e128d8afb1b2ff519e914c9ce
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1925
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Add License notification to unit test codes of resource encapsulation

Insert License notification to Unit test codes

Change-Id: I7440b9f26147116f4f46644970b71309329400af
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1947
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Add new resource property 'EXPLICIT_DISCOVERABLE'

Some resources (such as, SVR's) needs to be discovered only when
explicitly requested. This property allows the resource to be included
in discovery response only when explicitly requested via query filters.

Change-Id: I1adeffa0996ecf36ffdd9ebd3dbf9c32d9f3cc0d
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1680
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Doxygen: Statement end with period ('.')

Change-Id: Ie023e6be66c739c701509a6365237e659205d6d3
Signed-off-by: sandipan.p <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1934
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>

Including RCS prefix in ResourceContainer class name

Change-Id: Icc1c47349687911ed8ad878e6b0d546e177769a8
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1945
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix set command line options for ANDROID_XXX into scons environment.

Due to this the android SDK, NDK and Gradle were downloaded even if
the options are specified on commandline.

Change-Id: I00564d62c8374b73f3b4b75b7d75735d0a49f16f
Signed-off-by: Ashwini Kumar <k.ashwini@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1513
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

expanding the coverage of testing RCSResourceObject.cpp

It calls both
addAttributeUpdatedListener(const std::string& key,AttributeUpdatedListener h)
addAttributeUpdatedListener(const std::string&& key,AttributeUpdatedListener h)

Change-Id: Ic46f85104fb4887515af9745b3dc11b3d90b9516
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1938
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[Resource-Encapsulation] Modified Sample Application

Change-Id: If5c5e1118d9a423a4e7eb1611ac80f431bab0f20
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1941
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Cleaning unused mutex variables for receiver handler.

Server Receiver Handler and Client Receiver Handler are
optimized and merged to a single function CALEDataReceiverHandler.

Change-Id: I633da97c4f6f1ff38efa3c81559223f51316de41
Signed-off-by: sandipan.p <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1942
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

update android sample app

I have added some log for port number
since there is no way to know it.

Change-Id: I306d0d94ae1523d9de948465ec303d503111ff2f
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1846
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Modify resourceCache to handle datacache releasing exception

- catch release exception using try-cache
- clarify the exception discription of resourceCache

Change-Id: I865fc111c1fd8df05fb4e875109b339e99b744f8
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1937
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Modify ResourcePresenceUnitTest Code

- There is Segmentation fault because it is used 'weak pointer' without non-pre used 'shared pointer'.
so ResourcePresence instance's type is changed 'low pointer' to 'shared pointer'

- ResourcePresence's logic was chaging. so UnitTest's logic was changing(used mocking api's order and number)

Change-Id: Ic7ab6ae24b4b7bcb671d11728d16d0031842e002
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1935
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Update ResourceCache Unittest code files

Change-Id: Ic5dab8f0f90fad94f464c68b5ae608415547ed2b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1931
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Update Doxygen path for Resource-Encapsulation

Update header path of resource-encapsulation APIs in Doxyfile.
Fix broken API links of RCSDiscoveryManager, RCSRemoteResourceObject

Change-Id: I34671cbbde69fe0e1d616f1a789261ce28a41da6
Signed-off-by: hunje.yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1930
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixing segmentation fault if container is started without configuration file.
https://jira.iotivity.org/browse/IOT-633

Change-Id: I3559719cf084e462260da55d0b54d0848767e09c
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1926
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Resource Manipulation: resolve Jira issue IOT-641.

Prevent calling incorrect OC::Platform method.

Change-Id: Ie08b578ac04b768bdcb9404c557749a37acaaf41
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1921
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fixed warning due to incorrect type and comparison order.

Change-Id: Ifb4a7c644c5599888b74895429eb2296ab2c9f57
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1900
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: JungYong KIM <jyong2.kim@samsung.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[Resource-Encapsulation] Splitted Resource Client to 2 files

- RCSDiscoveryManager and RCSRemoteResourceObject

Change-Id: Iccf1aae4100eba313127fad33dd2adb8bb6bec64
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1914
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[Resource Encapsulation] Updated Discover API of Resource Client for RCSAddress

- updated Resource Client, sample, UnittestCases
- added more Exception to Resource Client

Change-Id: Ib91934b372efe23f7a657152a63a9dd7aa5d06ce
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1905
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Removed noexcept(true) descrutor from test classes

Change-Id: Ibbb00a3b84f33545b7ab441c6f985216a00150d9
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1906
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Rename ResourceAttributes to RCSResourceAttributes

Prefix is added for consistency for exposed headers.

Change-Id: I4b038fe5fdd79bfbc6d5b8963491332a180b77a4
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1893
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Rename BundleInfo to RCSBundleInfo and ResourceContainer to RCSResourceContainer

Prefixes are added for consistency for exposed headers as a part of API.

Change-Id: Ia968888331f27210e2c8ec00f3859ddadf3e2844
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1892
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Rename ResourceObject to RCSResourceObject

Prefix is added for consistency for exposed headers

Change-Id: I8366dba5f404089237ac4b16f19a498a2179356c
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1891
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add a comparison helper class for ResourceAttributes::Value

The hepler class is needed to avoid implicitly converting and comparing raw values,
because ResourceAttributes::Value has implicit constructors to make it easy to use.

Change-Id: Ie72524d9000f930e01e63b0f0e0384295ed4f41d
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1890
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

BLE De-fragmentation changes and optimization for receiver handler

Change-Id: If2217589eb7538018fa9e4e79ee55cd3bb52aed8
Signed-off-by: sandipan.p <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1410
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[Resource-Manipulation] Renamed Resource-Manipulation to Resource-Encapsulation

Change-Id: I2520ee961d6556b26c3ba52be8e6d16238615d30
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1888
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modify UnitTest Code about "Resource Broker"

- Modify inherit class : "Test" class -> "TestWithMock" class
- Support 4.6, 4.7, 4.8 gcc compiler

Change-Id: Ie4de09086ba737033f17f5d87bf1a809019351b6
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1878
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

resource-manipulation: rcs_common.so add missing depending library

rcs_common.so is also depending on liboc.so and libpthread.so, this
patch adds these dependencies to the build.
Add LIBPATH to make sure the libs will be found, this fixes a problem
in some jenkins tests.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: I753c5ec2d35876c789d93d843542344257f44c54
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1883
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

csdk: libconnectivity_abstraction.so: add missing depending library

libconnectivity_abstractionso depends on libcoap.so and librt.so when
build as shared lib, which is the case for the Tizen build. This patch
adds these dependencies to the build.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: Ib972be2b766d7fbccac9b246ae6f11e6182af94c
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1825
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Update UnitTest Code about "Resource Cache"

- Modify inherit class : "Test" class -> "TestWithMock" class
- Support 4.8 gcc compiler

Change-Id: I0d7f279c178a14eaef1b465ce3bce80253c97dae
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1880
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove "define variables" on Notification Manager.

change anonymous namespace variables from define variables.
change macro to function in OIC::Service namespace.

Change-Id: I9d1e2a8d23d92b190b3255d21434c84efe359c73
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1875
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

resource-manipulation: libserver_builder.so add missing depending library

libserver_builder.so is also depending on liboc.so and
librcs_common.so, this patch adds these dependencies to the build.

liboctbstack.so is only needed when LOGGING=true is set. Without
liboctbstack.so libserver_builder.so misses the dependencies to the
OCLog and OCLogv symbols.
Add LIBPATH to make sure the libs will be found, this fixes a problem
in some jenkins tests.

pthread is added two times, once should be enough.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: I6af126eb4af975b7231d01df922885c7dec5fc56
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1799
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

soft-sensor-manager: libSSMCore.so: add missing depending library

libSSMCore.so also depends on libdl.so, this patch adds these
dependencies to the build.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: I76faff46fe96caef75fb6673c7e83d62b15b8489
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1796
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

things-manager: libTGMSDKLibrary.so: add missing depending library

libTGMSDKLibrary.so also depends on liboc.so, liboctbstack.so and
pthread, this patch adds these dependencies to the build.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: I174b38e747be247fc25544db629f8ad2b7eb5ef5
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1795
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update ResourceObject Class.

Doxygen comments for ResourceObject.
Implement feature of autoNotify about if Attribute is deleted.
And add unit test about that case.

Change-Id: I03974b098c13d6d71a1dc209f5a7d41b289274aa
Signed-off-by: Heewon Park <h_w.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1866
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update UnitTest Code about "Resource Broker"

- Modify inherit class : "Test" class -> "TestWithMock" class
- Support 4.8 gcc compiler

Modify TestCase for DevicePresenceUnitTest.

Change-Id: Ia7ff55abc186c9dc388803ac967ed37c5d89ed73
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1843
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix invalid memory access on resource broker module.

remove the duplicated memory access on list.
invalidate callback in deleted instance.
delete useless member variable on ResourcePresence class.

Change-Id: If6b3831fa2355140b23efdafc213615280e336ac
Signed-off-by: jyong2.kim <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1844
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: kwon doil <doil.kwon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Require explicit scons argument (containerJavaSupport=1) to include Java related code in resource container.

Further, added a fix of the ResoureContainerTest to be compatible with gcc 4.6. Removed virtual override usage.
More uniform API for whole resource-encapsulation module (using const string refererences).
Use test helper class to avoid gcc version problems.

Change-Id: I338ee7a7305a83f70babb7b07f9a542644f0c111
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1838
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

build: make build fail if unresolved symbols found

gcc links shared libs also when there are still some unresolved
symbols, you have to specify it explicitly to make it fail in such
cases. I think a compiler should fail in such cases otherwise
someone will add some not intended dependencies or some existing
dependencies are not getting declared.

This patch makes gcc fail in such cases. I have only activated this for
libs build in a Linux build and explicitly deactivates it for windows
(does this even work at all?) This should be build tested with Android
also.

This was build tested for Linux and Android.

This patch depends on some other patches I send which are fixing the
problems I found with this change.

Change-Id: I9ab79896ca2e86e9226cd9b39060a0763ef89694
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1802
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modify service/SConscript file to support PPM for Android platform.

Change-Id: I6708ec0a2d69f0e0f974abfa81df62b27cd6575b
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1842
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update comments for ResourceAttributes

Now, ResourceAttributes has appropriate comments for doxygen

Change-Id: I4a8f3f8881117c4cb91a0d871e0549faa66bd047
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1849
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Corrected files with doxygen comments that were generating warnings.

Fixed several files with out of date or incorrect doxygen comments.
These included use of explicit tags (@fn, @var, @struct, etc.),
incorrect use of "[IN]" and "[OUT]", and other issues.

Aside from the problems actually marked in the output as warnings,
these issues were causing a large portion of the documentation to
be dropped silently.

Change-Id: I66027f4f98a6e82b7db826693b5ec1b1f30e58cf
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1836
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed doxygen comments in camutex.h

Fixed problems with doxygen comments that included a few causing
outright errors and missing functions in the resulting
documentation.

- Removed use of '@' on local names instead of Doxygen keywords
 which were causing errors.

- Prefixed '::' to types and enums that were not recongnized.

- Fixed typo in enum name

- Added missing periods at end of brief/summary prose.

Change-Id: I2731d9d5ebf10f738e387a1922027fb752a8a3be
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1834
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Corrected @file doxygen commands that had explicit filenames that
were not valid.

Removed the explicit filename from @file doxygen commands where
the filenames were invalid and causing warnings. (In general the
@file command should be used by itself, with no explicit filename)

Change-Id: I0c3e3392b172c8760e0a281f0c3b293050bedabc
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1835
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed CA linux sample bug for bulk data

we have to create text file for bulk data only.
so I fixed the condition for data size check.

Change-Id: I96f9441e475dbe67729391e29571cdb8ab443e21
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1847
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Updated discovery response when filter query does not match.

Iotivity should respond to discovery requests in below manner:
If query filter matching fails (or if Server does not have
any DISCOVERABLE resources) and discovery request is multicast,
it should NOT send any response.
But, if the discovery request is unicast in above scenario,
it should send an error(RESOURCE_NOT_FOUND - 404) response with
empty payload.

Currently, Iotivity stack sends a response in all error scenarios
with return code as OC_EH_OK (along with some payload) which has
various drawbacks, such as, causes un-necessary traffic in the network
and also wastes power on constrained devices.

Change-Id: Ibb3bedc7b8ae67b708b89e9ad747c031ab552cae
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1766
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Changing resource "URL" to "URI"

We were logging the resource URI as URL which
was ambiguous for the test team.

Change-Id: I90e862cc35f3c1fd3ec2f3a95950668fb45d0134
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1861
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>

Finalizing CI build script changes.

This commit effectively only affects the Integration/Validation build.
This had to be done in steps to not break any of the ongoing pre-[build
script overhaul] work that were already in their merge-into-master
validation stages.

Change-Id: I3c32df57d526f7a34847a96f48814fd31f79e4fc
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1859
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

liboc: add missing depending library

liboc.so depends on liboctbstack.so, liboc_logger.so and pthread, this
patch adds these dependencies to the build.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: I971b45669adef31dc9cca719884ebeb74aaf735e
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1794
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Eliminate warning about const mismatch in caipadapter (IOT-632)

Change-Id: I9c5afff53ded18b01467c0426c24876b219d7a34
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1858
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

csdk: remove dependency to liboc_logger.so in c code

The liboc_logger.so is only used by the c++ part and not by the c part,
remove it from the c only part.

Change-Id: Ib0894974de8ef7150401f02fbd0ea864d1d6f2cd
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1801
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Removing unnecessary logs in message handler.

The "IN" and "OUT" tags give no useful information
and completely floods the debug mode. All the useful
information is already being logged within the function.

Change-Id: Ieac528913b659fbaccedcb465000f11f370b678a
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1816
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix memory leak on OCDoResource

OCDoResource was leaking the generated payload each time, so
this fixes the issue by ensuring it is free'd at the end.

Change-Id: I693318bdcb6d7baa37a5397fab33b0fe4c784960
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1821
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Clean up CBOR payload in Arduino sample app.

This effectively keeps Arduino server from crashing when it receives
+24 requests. Services bug IOT-484
(https://jira.iotivity.org/browse/IOT-484).

Change-Id: I1b651e560d935bc71c1b8a3aa5062c2162e313f7
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1824
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix Tizen Build

Hopefully fixes the Tizen build

Change-Id: Ic202729f4d6a571cfad18724da27e5295258a1e2
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1854
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Modify resourceCache Unittest code for gcc 4.6 version

remove override tag on the each test code.

Change-Id: I8a22c442c65a3f9099cbb9adcf6e40a518c4fd56
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1837
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

resource-manipulation: add unittest for container

- add unittest for dynamic bundle loading and resource registration
- update sample bundle used for unittest

Change-Id: I9a59ecd5cbd49a8adbff703d58c0cb72ff58687a
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1839
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

resource-manipulation: Fix some typo errors

Fixed some typo in resource-manipulation scons script.

Change-Id: I64099f8b7d1ec18954e13d177b47d5c5cd73bfc8
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1773
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update PPM Android Sample Application for Updated CA API

OcConnectivityType Option on FindResource API(ALL to CT_ADAPTER_IP)

Change-Id: Ide07e1049ce505e03ceeb8ea934378935057d913
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1812
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove boost library dependency on PPM module.

Change-Id: Ic8710ec19e0417d912869a0a24c7e476a932acf0
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1810
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Initialize response payload in entity handler

As no payload is set for observe deregister and the response
payload was uninitialized, the payload destroy method caused a
segfault. This fixes IOT-611.

Change-Id: I050587c18fee922bfe61522f3ba7af6a2b207b09
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1828
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed memory leak while sending the response in SRM

Dynamic memory was being allocated while forming the OCSecurityPayload
and was not freed. Also, updated code in ocserverrequest.c to replace
dynamic memory allocation with local variable on the function stack for
CAToken variable.

Change-Id: I4372fe46001c10cb68d069cae5916c8798913121
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1815
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[ARDUINO][BLE] Changed UUID's as per OIC Spec

Updated RBL library patch to advertise new UUID's as per OIC spec

Change-Id: I50c50d59779922b2c16e86156fe43ec0a62cde52
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1781
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Updated auto_build.sh for continuous integration improvements.

This commit effectively adds a new mode of building in the build
script. This new mode can be referenced as "parallel". Before all
builds occurred in sequence and could take a long time. Now an
individual contributor may build just a shim of the entire build
list. This will allow the Jenkins CI system to build each of the
shims in parallel to better utilize the several executors found
across the many build servers we have available for CI.

Change-Id: I945bc45201d8c3d4a5c754de02eaa623f59c8449
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1818
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed invalid write in doxmresource

The doxmresource was allocating based on the size of a short,
but the type was an enum.  This adjusts the size to be correct.

Change-Id: Id0dcc26b346b2ef096992bd84173319ddce2c7e6
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1819
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

modified linux CA sample to handling blockwise-transfer

currently, CA sample send the fixed payload data.
so I modified the CA sample to send bulk data request and response

Change-Id: Icd94f5f0c56defe80890cf020f4413cbc4153f83
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1782
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

blockwise-transfer rebase into master for merge/review

- block option1, option2 can be supported
- size option can be supported
- late negotiation is supported
- IP tansport can be supported
- not supported in single threaded devices such as the Arduino Mega
- design document can be found on the link below
  https://wiki.iotivity.org/proposal_for_block-wise_transfer

Change-Id: Iebaa23ff8a6c1e23ee9fa6e10c09d76385affb66
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Signed-off-by: Sandipan Patra <sandipan.p@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1667
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

adding UnitTest functions in Server Builder

-addAttributeUpdatedListener()
-removeAttributeUpdatedListener()

Change-Id: I3bc137c02d4b6d386b406ee0879242ea961ff085
Signed-off-by: Rami Jung <rami.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1811
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix compiler warnings.

This fixes compiler warnings related to in csdk and services dirs.
- unused but set variables
- control reaching end of non-void functions

Change-Id: I98b83091dc97e059e2755b98e33aef209dbb5adb
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1778
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[Resource Manipulation] Integrated Resource Manipulation libraries into 4 categories

- rcs_server
- rcs_client
- rcs_common
- rcs_container

Change-Id: I262b7e9c57c48530e2128d14545c335c6a098223
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1814
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fixed build warnings due to assert, unused function, time

This fixes a handful of the warnings present on master.

Change-Id: Idc39f9c8f8c73e0107831bc340738028a1294604
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1804
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Default entity handler for collections

Adding default entity handler for collection C samples
in the case when the resource does not exist. This change
fixes IOT-628.

Change-Id: I4f060a856fd9bb712fc145a5c98081ecbe1fec7e
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1803
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

protocol-plugin: libfanserver_mqtt_plugin.so and liblightserver_mqtt_plugin.so add missing depending library

libfanserver_mqtt_plugin.so and liblightserver_mqtt_plugin.so are also
depending on liboc.so and libcrypto.so, this patch adds these
dependencies to the build. In addition it puts the dependency to
mosquitto to the beginning of the list. This is needed because
mosquitto is a statically linked lib and it also has unresolved
symbols, but gcc only searches the dynamic libs defined after the
static for unresolved symbols in the static lib.

mosquitto was only build as a static linked library so we can use the
normal LIBS mechanism and it will be statically linked.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: Ia130827d04bd3bb1a8863fc64d0097a076edc751
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1798
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

mqtt-fan: libmosquittopp.so: add missing depending library

libmosquittopp.so also depends on libpthread.so, this patch adds these
dependencies to the build. In addition it puts the dependency to
mosquitto to the beginning of the list. This is needed because
mosquitto is a statically linked lib and it also has unresolved
symbols, but gcc only searches the dynamic libs defined after the
static for unresolved symbols in the static lib.

Without this the dynamic loader will not automatically load these
libraries and it could result in unresolved dependencies at runtime.

Change-Id: I866a46305c31d37cf706b9f2b965e843c35c5667
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1797
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Modify UnitTest Code for 'ResourceBroker'

- Bug fix : Segmentation Fault Issue
- Support 4.6 gcc compiler and 4.7 gcc compiler

Modify WhiteSpace Error

Change-Id: I9fa65b24b7133f08fcd5ecb03fd163fa6de106b7
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1808
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[resource-manipulation] Add RCSAddress class

This is a helper class to provide distinguishable api for the address of discoverResource.

Change-Id: I3108f852b504d7b900e06435b7033d6d93f35e9d
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1807
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

ResourcePresenceUnitTest: Fix when the requesterList is not initialized

This issue fixes the segmentation fault issue during the execution of broker_test.
The fix returns true when the requesterList itself is not initialized, otherwise
returns the value of requesterList->empty().

Change-Id: I3e57264497fd283e15824b088c6dcad925e0c2f4
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1780
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

[resource-manipulation] Add Test Helper class

The class is to avoid aborting test execution, when expectation is not fulfilled on GCC 4.8.
The issue is caused by a difference of destructor's noexcept specifier between MockRepository of HippoMock and Test of gtest.
This class allows test fixtures have same usage regardless of GCC version.

Change-Id: I247a63009ca2625b27a29eb5320a1a6e3ebbd71b
Signed-off-by: coderhyme <jhyo.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1779
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

resource-manipulation: Update container bundle-api doxygen comments

- add bundle-api doxygen comments for updates regarding bundle resource attributes and dynamic configuration
- update bundles and bundle resources for applying resource attribute

Change-Id: Ic1389eb0c643ded2df313e1b1bfa2968743af525
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1806
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix of header file for compability with gcc 4.6

Change-Id: I31f018da290c98fdfe6042327c3eefbbc41e9c52
Signed-off-by: Markus Jung <markus.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1777
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

fixed linux, android ca sample application

after 'New IP Adapter supports IPv6' changes,
ca sample is not working. so I fixed the issue.

Change-Id: Idadf0e5ecfdd3433d8e598c9d3af392e2ffb6a0b
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1752
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Re-enable Tizen build

Tizen build was disabled for the 0.9.2 release since it was incomplete
and interfered with features.  This commit puts them back into the
auto_build.sh so that it'll be building on master.

Change-Id: I4ecf2cd7a9df06a3d2ca987fffc7130fabba0ca1
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1764
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed Presence

Wrong presence URI was being formed as a part of
IPV6 changes. Also, the presence resource URI was not
updated in the IPv6 changes.

Change-Id: I66dcbcd729e4c91cec57f551bf9b1be36a559442
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1770
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed payload length in Android Sample App

the code related to length of payload in Android Sample App
is changed.

Change-Id: I8c62a4065e46609149fa69f2d42772b56e22dd38
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1754
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Implement VERIFY_NON_NULL() in terms VERIFY_NON_NULL_RET().

Minimize code duplication in the VERIFY_NON_NULL() macro by
implementing it terms of the VERIFY_NON_NULL_RET() macro.

Removed duplicate definitions of these macros as well.

Change-Id: I692b68744a0a1606ca64c7a676d910d32ffbbaf5
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1772
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Merge Single/Multi thread for camessagehandler

Common code in Single thread and multithread merged into single file
Specific code is seperated with SINGLETHREAD flag

Change-Id: I6e9f3486c28fc188635fd86be1f01036636dedb3
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/892
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[CA] Fix for tizen build error and CA sample for Tizen

Fix for tizen build error and fixed CA sample for Tizen for IPv6 changes

Change-Id: Idb551359c3223c0c1d26a08a8443ac6874f3ff87
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1755
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix redefinition types in octype

Remove duplicate definition in octype header.

Change-Id: If99021458bc16ae6aa645f7946bd047baa565b67
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1786
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

csdk: Fix build issues related to OCResource conversions on Linux

This fixes OCResource conversion issues to/from rsrc_t

Change-Id: I04c197446df9311c2617f0035e469058ff81e81e
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1783
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

prefer the other version
Revert "csdk: Fix build issues related to conversions on Linux"

This reverts commit 9604ac4ece381c26b7478e97f1ee8a604bc50d6c.

Change-Id: I4704d20a0a091920842dc33056eb238a0a3789d8
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1791

csdk: Fix build issues related to conversions on Linux

This fixes OCResource conversion issues to/from rsrc_t

Change-Id: I09c03eebba9226afad1a9278733d436f9927361e
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1775
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

C++ samples select Correct Adapter Type

Previously we were allowing the user to select between
IPv4 and IPv6 which is wrong since the stack is supposed
to make this decision by itself. This fixes IOT-621

Change-Id: If8f1c125f739696d33d6fef211a9a9033ec63f45
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1771
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Disabled boost download when boost is already downloaded.

This effectively disables the build server from downloading boost
when it already has it. (Before it was making its decision on
whether or not to download it based solely on whether or not the
*.zip file already existed.)

Change-Id: I155fec0428b7caa0b517bbbe6458ee85e692ec8b
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1768
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>